[Bug 1866577] Re: powerpc-none-eabi-gdb.exe GDB 9.1 with QEMU 4.2 gdb-stub comes with Reply contains invalid hex digit 79

2021-07-05 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1866577 Title: powerpc-non

[Bug 1871270] Re: [Feature Request] add usbredir device reset blacklist options support to allow macOS guest to iOS device usbredir

2021-07-05 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1871270 Title: [Feature Re

[Bug 1864984] Re: "nr_entries is too big" when using virgl

2021-07-05 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1864984 Title: "nr_entries

[Bug 1871267] Re: Multiple (Repeating) Keystrokes in macOS

2021-07-05 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1871267 Title: Multiple (R

[Bug 1865188] Re: Switching from the monitor to the emulated machine with a French keyboard (AZERTY)

2021-07-05 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1865188 Title: Switching f

[Bug 1872644] Re: MacOS host qemu-system-x86_64 -cpu host not working

2021-07-05 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1872644 Title: MacOS host

[Bug 1865099] Re: cannot run x64 based system on x64 host with Intel Haxm

2021-07-05 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1865099 Title: cannot run

[Bug 1866792] Re: formating vdi-disk over nbd fails

2021-07-05 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1866792 Title: formating v

[Bug 1868617] Re: multiseat: route different spice tablet events to distinct vdagents

2021-07-05 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1868617 Title: multiseat:

[Bug 1863710] Re: qemu 4.2 does not process discard(trim) commands

2021-07-05 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1863710 Title: qemu 4.2 do

[Bug 1865350] Re: fstrim not working with image mounted to path?

2021-07-05 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1865350 Title: fstrim not

[Bug 1867786] Re: Qemu PPC64 freezes with multi-core CPU

2021-07-05 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1867786 Title: Qemu PPC64

[Bug 1864536] Re: Support for XSAVES intel instructions in QEMU

2021-07-05 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1864536 Title: Support for

[Bug 1865348] Re: virsh domfsinfo testdom crashes the guest agent

2021-07-05 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1865348 Title: virsh domfs

[Bug 1865626] Re: s390x guest hang when ipl boot from a mdev dasd

2021-07-05 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1865626 Title: s390x guest

Re: [PATCH v2 2/6] tests/acceptance: add replay kernel test for ppc64

2021-07-05 Thread Pavel Dovgalyuk
On 05.07.2021 20:46, Willian Rampazzo wrote: Already upstream :) Ok, thanks. On Fri, Jun 25, 2021 at 2:39 AM Pavel Dovgalyuk wrote: This patch adds record/replay test which boots Linux kernel on ppc64 platform. The test uses kernel binaries taken from boot_linux_console test. Signed-off-

[Bug 1863601] Re: unable to type "|" character in french keyboard.

2021-07-05 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1863601 Title: unable to t

Re: [PATCH v1 3/3] hw/riscv: opentitan: Add the flash alias

2021-07-05 Thread Alistair Francis
On Mon, Jul 5, 2021 at 4:16 PM Bin Meng wrote: > > On Fri, Jul 2, 2021 at 1:20 PM Alistair Francis > wrote: > > Could you add some commit message to explain this alias? Yep, I'll add something. > > > > > Signed-off-by: Alistair Francis > > --- > > include/hw/riscv/opentitan.h | 2 ++ > > hw/r

[PATCH 2/2] docs/system: ppc: Update ppce500 documentation with eTSEC support

2021-07-05 Thread Bin Meng
This adds eTSEC support to the PowerPC `ppce500` machine documentation. Signed-off-by: Bin Meng --- docs/system/ppc/ppce500.rst | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/docs/system/ppc/ppce500.rst b/docs/system/ppc/ppce500.rst index 7a815c1881..afc58f60f5 10

[PATCH 1/2] roms/u-boot: Bump ppce500 u-boot to v2021.07 to add eTSEC support

2021-07-05 Thread Bin Meng
Update the QEMU shipped u-boot.e500 image built from U-Boot mainline v2021.07 release, which added eTSEC support to the QEMU ppce500 target, via the following U-Boot series: http://patchwork.ozlabs.org/project/uboot/list/?series=233875&state=* The cross-compilation toolchain used to build the U

Re: [PATCH v3] linux-user/elfload: Implement ELF_HWCAP for RISC-V

2021-07-05 Thread Richard Henderson
On 7/5/21 8:50 PM, Kito Cheng wrote: Set I, M, A, F, D and C bit for hwcap if misa is set. V3 Changes: - Simplify logic of getting hwcap. V2 Changes: - Only set imafdc bits, sync with upstream linux kernel. Signed-off-by: Kito Cheng --- linux-user/elfload.c | 13 + 1 file change

[PATCH] target/ppc: mtmsrd is an illegal instruction on BookE

2021-07-05 Thread Nicholas Piggin
MSR is a 32-bit register in BookE and there is no mtmsrd instruction. Cc: Christian Zigotzky Signed-off-by: Nicholas Piggin --- target/ppc/translate.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index f65d1e81ea..d1f482b0f3 100644 ---

Re: [PATCH v3] linux-user/elfload: Implement ELF_HWCAP for RISC-V

2021-07-05 Thread Bin Meng
On Tue, Jul 6, 2021 at 11:50 AM Kito Cheng wrote: > > Set I, M, A, F, D and C bit for hwcap if misa is set. > > V3 Changes: > - Simplify logic of getting hwcap. > > V2 Changes: > - Only set imafdc bits, sync with upstream linux kernel. These changelogs should not be in the commit message, but sho

Re: [PATCH 1/2 v3] Configure script for Haiku

2021-07-05 Thread Thomas Huth
On 05/07/2021 21.21, Richard Zak wrote: The configure script doesn't test for presence of TPM device or support. It activates TPM support if not explicitly disabled, and disables TPM support if explicitly enabled on Windows. With TPM support compiled in, it causes an assertion failure on launch

[PATCH v8 02/16] python: Reduce strictness of pylint's duplicate-code check

2021-07-05 Thread Emanuele Giuseppe Esposito
From: John Snow Pylint prior to 2.8.3 (We pin at >= 2.8.0) includes function and method signatures as part of its duplicate checking algorithm. This check does not listen to pragmas, so the only way to disable it is to turn it off completely or increase the minimum duplicate lines so that it does

[PATCH v8 06/16] qemu-iotests: delay QMP socket timers

2021-07-05 Thread Emanuele Giuseppe Esposito
Attaching gdbserver implies that the qmp socket should wait indefinitely for an answer from QEMU. Signed-off-by: Emanuele Giuseppe Esposito --- tests/qemu-iotests/iotests.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotest

[PATCH v8 09/16] docs/devel/testing: add -gdb option to the debugging section of QEMU iotests

2021-07-05 Thread Emanuele Giuseppe Esposito
Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- docs/devel/testing.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 9d6a8f8636..8b24e6fb47 100644 --- a/docs/devel/testing.rst +++ b/d

[PATCH v8 13/16] qemu-iotests: insert valgrind command line as wrapper for qemu binary

2021-07-05 Thread Emanuele Giuseppe Esposito
If -gdb and -valgrind are both defined, return an error. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iote

[PATCH v8 04/16] docs/devel/testing: add debug section to the QEMU iotests chapter

2021-07-05 Thread Emanuele Giuseppe Esposito
Introduce the "Debugging a test case" section, in preparation to the additional flags that will be added in the next patches. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- docs/devel/testing.rst | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v8 07/16] qemu_iotests: insert gdbserver command line as wrapper for qemu binary

2021-07-05 Thread Emanuele Giuseppe Esposito
Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index e176a84620..e7e3d92d3e 100644 --- a/test

[PATCH v8 16/16] docs/devel/testing: add -p option to the debug section of QEMU iotests

2021-07-05 Thread Emanuele Giuseppe Esposito
Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- docs/devel/testing.rst | 4 1 file changed, 4 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 719accdb1e..e5311cb167 100644 --- a/docs/devel/testing.rst +++ b/docs/devel

[PATCH v8 08/16] qemu-iotests: add gdbserver option to script tests too

2021-07-05 Thread Emanuele Giuseppe Esposito
Remove read timer in test script when GDB_OPTIONS are set, so that the bash tests won't timeout while running gdb. The only limitation here is that running a script with gdbserver will make the test output mismatch with the expected results, making the test fail. Signed-off-by: Emanuele Giuseppe

[PATCH v8 05/16] qemu-iotests: add option to attach gdbserver

2021-07-05 Thread Emanuele Giuseppe Esposito
Define -gdb flag and GDB_OPTIONS environment variable to python tests to attach a gdbserver to each qemu instance. This patch only adds and parses this flag, it does not yet add the implementation for it. if -gdb is not provided but $GDB_OPTIONS is set, ignore the environment variable. Signed-off

[PATCH v8 14/16] docs/devel/testing: add -valgrind option to the debug section of QEMU iotests

2021-07-05 Thread Emanuele Giuseppe Esposito
Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- docs/devel/testing.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 8b24e6fb47..719accdb1e 100644 --- a/docs/devel/te

[PATCH v8 12/16] qemu-iotests: allow valgrind to read/delete the generated log file

2021-07-05 Thread Emanuele Giuseppe Esposito
When using -valgrind on the script tests, it generates a log file in $TEST_DIR that is either read (if valgrind finds problems) or otherwise deleted. Provide the same exact behavior when using -valgrind on the python tests. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov

[PATCH v8 15/16] qemu-iotests: add option to show qemu binary logs on stdout

2021-07-05 Thread Emanuele Giuseppe Esposito
Using the flag -p, allow the qemu binary to print to stdout. Also create the common function _close_qemu_log_file() to avoid accessing machine.py private fields directly and have duplicate code. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- python/qemu

[PATCH v8 11/16] qemu-iotests: extend QMP socket timeout when using valgrind

2021-07-05 Thread Emanuele Giuseppe Esposito
As with gdbserver, valgrind delays the test execution, so the default QMP socket timeout and the generic class Timeout in iotests.py timeouts too soon. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 6 +++--- 1 file change

Re: [PATCH 1/3] ci: build & store windows installer

2021-07-05 Thread Thomas Huth
On 23/06/2021 11.11, Gerd Hoffmann wrote: Build windows installer for qemu in gitlab CI, store the result as artifact. Signed-off-by: Gerd Hoffmann --- .gitlab-ci.d/crossbuild-template.yml | 5 + .gitlab-ci.d/crossbuilds.yml | 6 ++ tests/docker/d

Re: [PATCH 3/3] ci: build & store guest agent msi

2021-07-05 Thread Thomas Huth
On 23/06/2021 11.11, Gerd Hoffmann wrote: Build guest agent windows msi install package in gitlab CI, store the result as artifact. Signed-off-by: Gerd Hoffmann --- .gitlab-ci.d/crossbuild-template.yml | 3 ++- .gitlab-ci.d/crossbuilds.yml | 2 ++ tests/d

Re: [PATCH v3] dp8393x: don't force 32-bit register access

2021-07-05 Thread Mark Cave-Ayland
On 05/07/2021 02:44, Finn Thain wrote: On Sun, 4 Jul 2021, Mark Cave-Ayland wrote: Commit 3fe9a838ec "dp8393x: Always use 32-bit accesses" assumed that all accesses to the registers were 32-bit As I said, that assumption was not made there. If commit 3fe9a838ec is deficient it is probably

Re: [PATCH 3/3] hw/sd: Check for valid address range in SEND_WRITE_PROT (CMD30)

2021-07-05 Thread Bin Meng
On Fri, Jul 2, 2021 at 11:59 PM Philippe Mathieu-Daudé wrote: > > OSS-Fuzz found sending illegal addresses when querying the write > protection bits triggers an assertion: > > qemu-fuzz-i386: hw/sd/sd.c:824: uint32_t sd_wpbits(SDState *, uint64_t): > Assertion `wpnum < sd->wpgrps_size' failed.

Re: [PATCH v4 0/4] avocado-qemu: New SMMUv3 and intel IOMMU tests

2021-07-05 Thread Eric Auger
Hi Wainer, On 7/1/21 1:22 AM, Wainer dos Santos Moschetta wrote: > Hi, > > On 6/29/21 5:17 PM, Eric Auger wrote: >> Hi Cleber, all, >> >> On 6/29/21 4:36 PM, Eric Auger wrote: >>> This series adds ARM SMMU and Intel IOMMU functional >>> tests using Fedora cloud-init images. >>> >>> ARM SMMU tests

Re: [PATCH v2] docs: document file-posix locking protocol

2021-07-05 Thread Vladimir Sementsov-Ogievskiy
03.07.2021 17:50, Nir Soffer wrote: On Sat, Jul 3, 2021 at 4:51 PM Vladimir Sementsov-Ogievskiy wrote: Let's document how we use file locks in file-posix driver, to allow external programs to "communicate" in this way with Qemu. This makes the locking implementation public, so qemu can never

Re: [PATCH 00/53] acpi: refactor error prone build_header() and packed structures usage in ACPI tables

2021-07-05 Thread Igor Mammedov
On Fri, 2 Jul 2021 10:47:20 -0400 "Michael S. Tsirkin" wrote: > On Fri, Jun 25, 2021 at 05:17:24AM -0400, Igor Mammedov wrote: > > Highlights: > > * drop pointer arithmetic in ACPI tables code > > * use endian agnostic API > > * simplifies review of tables. /in most cases just line by line

[PATCH] ui: update keycodemapdb submodule commit

2021-07-05 Thread Akihiko Odaki
The change of ui/keycodemapdb effective on QEMU is only commit d21009b1c9f94b740ea66be8e48a1d8ad8124023, which adds mappings for key codes added in commit d7696ff884e35c6dacf83a7cbe3355e3b0a90125. d21009b1c9f94b740ea66be8e48a1d8ad8124023 Add QEMU QKeyCode "lang1" and "lang2" 320f92c36a80bfafc5d578

Re: [PATCH v4 2/4] avocado_qemu: Add SMMUv3 tests

2021-07-05 Thread Eric Auger
Hi Wainer, On 7/1/21 8:13 PM, Wainer dos Santos Moschetta wrote: > Hi, > > On 6/29/21 11:36 AM, Eric Auger wrote: >> Add new tests checking the good behavior of the SMMUv3 protecting >> 2 virtio pci devices (block and net). We check the guest boots and >> we are able to install a package. Differen

Re: [PATCH] hw/sd: sdhci: Enable 64-bit system bus capability in the default SD/MMC host controller

2021-07-05 Thread Bin Meng
On Thu, Jun 24, 2021 at 3:01 AM Joanne Koong wrote: > > The default SD/MMC host controller uses SD spec v2.00. 64-bit system bus > capability > was added in v2. > > In this change, we arrive at 0x157834b4 by computing (0x057834b4 | (1ul << > 28)) > where 28 represents the BUS64BIT SDHC_CAPAB fie

Re: [PATCH] nbd: register yank function earlier

2021-07-05 Thread Vladimir Sementsov-Ogievskiy
04.07.2021 01:07, Lukas Straub wrote: Although unlikely, qemu might hang in nbd_send_request(). Allow recovery in this case by registering the yank function before calling it. Signed-off-by: Lukas Straub Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH resend] nbd: register yank function earlier

2021-07-05 Thread Vladimir Sementsov-Ogievskiy
04.07.2021 13:56, Lukas Straub wrote: Although unlikely, qemu might hang in nbd_send_request(). Allow recovery in this case by registering the yank function before calling it. Signed-off-by: Lukas Straub Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

[PATCH 1/4] target/i386: Added MSRPM and IOPM size check

2021-07-05 Thread Lara Lazier
The address of the last entry in the MSRPM and in the IOPM must be smaller than the largest physical address. (APM2 15.10-15.11) Signed-off-by: Lara Lazier --- target/i386/svm.h | 3 +++ target/i386/tcg/sysemu/svm_helper.c | 15 +++ 2 files changed, 18 insertions(+

[PATCH 0/4] target/i386: Continuing fixing kvm-unit-tests for svm

2021-07-05 Thread Lara Lazier
Following the APM2 I added some consistency checks to resolve the following tests in kvm-unit-tests for svm: * EFER.SVME: 1500 * EFER.SVME: 500 * Test EFER 9:8: 1700 * Test EFER 63:16: 11500 * Test EFER 63:16: 101500 * Test EFER 63:16: 1001500 * Test EFER 63:16: 10001500 * Test EFER 63:16:

[PATCH 4/4] target/i386: Added VMRUN consistency checks for CR3 and CR4

2021-07-05 Thread Lara Lazier
All MBZ bits in CR3 and CR4 must be zero. (APM2 15.5) Added reserved bitmask for CR4 and added checks in both helper_vmrun and helper_write_crN. Signed-off-by: Lara Lazier --- target/i386/cpu.h| 29 target/i386/tcg/sysemu/misc_helper.c | 6 ++

Re: [v4] migration: fix the memory overwriting risk in add_to_iovec

2021-07-05 Thread Dr. David Alan Gilbert
* linfeng (M) (linfen...@huawei.com) wrote: > > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > > Subject: Re: [v4] migration: fix the memory overwriting risk in add_to_iovec > > > > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > > > * Lin Feng (linfen...@huawei.com) wrote: > > >

[PATCH 2/4] target/i386: Added DR6 and DR7 consistency checks

2021-07-05 Thread Lara Lazier
DR6[63:32] and DR7[63:32] are reserved and need to be zero. (AMD64 Architecture Programmer's Manual, V2, 15.5) Signed-off-by: Lara Lazier --- target/i386/svm.h | 2 ++ target/i386/tcg/sysemu/svm_helper.c | 8 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git

QEMU modules improvements objective (Was: Re: [RFC 0/3] Improve module accelerator error message)

2021-07-05 Thread Claudio Fontana
On 7/1/21 1:27 AM, Jose R. Ziviani wrote: > Hello! > > I'm sending this as RFC because it's based on a patch still on > review[1], so I'd like to see if it makes sense. > > Tt will improve the error message when an accelerator module could > not be loaded. Instead of the current assert error, a f

[PATCH 3/4] target/i386: Added consistency checks for EFER

2021-07-05 Thread Lara Lazier
EFER.SVME has to be set, and EFER[63:16], EFER[9], EFER[7:5] are reserved and must be zero. In Addition the combinations * EFER.LMA or EFER.LME is non-zero and the processor does not support LM * non-zero EFER.LME and CR0.PG and zero CR4.PAE * non-zero EFER.LME and CR0.PG and zero CR0.PE * non-

[PATCH] Makefile: Remove /usr/bin/env wrapper from the SHELL variable

2021-07-05 Thread Thomas Huth
The wrapper should not be needed here (it's not the shebang line of a shell script), and it is causing trouble on Haiku where "env" resides in a different directory. Reported-by: Richard Zak Signed-off-by: Thomas Huth --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

Re: [PATCH v2] docs: document file-posix locking protocol

2021-07-05 Thread Denis V. Lunev
On 7/5/21 10:55 AM, Vladimir Sementsov-Ogievskiy wrote: > 03.07.2021 17:50, Nir Soffer wrote: >> On Sat, Jul 3, 2021 at 4:51 PM Vladimir Sementsov-Ogievskiy >> wrote: >>> >>> Let's document how we use file locks in file-posix driver, to allow >>> external programs to "communicate" in this way with

Re: [PATCH] Makefile: Remove /usr/bin/env wrapper from the SHELL variable

2021-07-05 Thread Daniel P . Berrangé
On Mon, Jul 05, 2021 at 10:25:42AM +0200, Thomas Huth wrote: > The wrapper should not be needed here (it's not the shebang line of > a shell script), and it is causing trouble on Haiku where "env" > resides in a different directory. > > Reported-by: Richard Zak > Signed-off-by: Thomas Huth > ---

[PATCH] hw/net: Discard overly fragmented packets

2021-07-05 Thread Philippe Mathieu-Daudé
Our infrastructure can handle fragmented packets up to NET_MAX_FRAG_SG_LIST (64) pieces. This hard limit has been proven enough in production for years. If it is reached, it is likely an evil crafted packet. Discard it. Include the qtest reproducer provided by Alexander Bulekov: $ make check-qt

Re: [PATCH] Makefile: Remove /usr/bin/env wrapper from the SHELL variable

2021-07-05 Thread Philippe Mathieu-Daudé
On 7/5/21 10:25 AM, Thomas Huth wrote: > The wrapper should not be needed here (it's not the shebang line of > a shell script), and it is causing trouble on Haiku where "env" > resides in a different directory. > > Reported-by: Richard Zak > Signed-off-by: Thomas Huth > --- > Makefile | 2 +- >

Re: [PATCH 3/9] tests/acceptance: Tag NetBSD tests as 'os:netbsd'

2021-07-05 Thread Philippe Mathieu-Daudé
Hi Niek, On 7/4/21 2:35 PM, Niek Linnenbank wrote: > for test_arm_orangepi_uboot_netbsd9: > > Reviewed-by: Niek Linnenbank > Thanks for the review. Does your R-b tag applies for this single patch or all patches related to test_arm_orangepi_uboot_netbsd9 in this

Re: [PULL 00/20] migration queue

2021-07-05 Thread Peter Maydell
On Thu, 1 Jul 2021 at 15:19, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > The following changes since commit 1ec2cd0ce2ca94292ce237becc2c21b4eb9edca0: > > Merge remote-tracking branch 'remotes/nvme/tags/nvme-next-pull-request' > into staging (2021-06-30 21:09:27 +

[PATCH v1] s390x/tcg: Fix m5 vs. m4 field for VECTOR MULTIPLY SUM LOGICAL

2021-07-05 Thread David Hildenbrand
The element size is located in m5, not in m4. As there is no m4, qemu currently crashes with an assertion, trying to lookup that field. Reproduced and tested via GO, which ends up using VMSL once the Vector enhancements facility is around for verifying certificates with elliptic curves. Reported-

Re: [PULL 00/20] migration queue

2021-07-05 Thread Daniel P . Berrangé
On Mon, Jul 05, 2021 at 09:57:20AM +0100, Peter Maydell wrote: > On Thu, 1 Jul 2021 at 15:19, Dr. David Alan Gilbert (git) > wrote: > > > > From: "Dr. David Alan Gilbert" > > > > The following changes since commit 1ec2cd0ce2ca94292ce237becc2c21b4eb9edca0: > > > > Merge remote-tracking branch 'r

Re: [RFC PATCH 5/6] pc/machine: Disallow any configuration of dies for non-PC machines

2021-07-05 Thread wangyanan (Y)
On 2021/7/2 18:18, Daniel P. Berrangé wrote: On Fri, Jul 02, 2021 at 06:07:38PM +0800, Yanan Wang wrote: Since a machine type does not support topology parameter of dies, it's probably more reasonable to reject any explicit specification to avoid possible confuse, including "dies=0" and "dies=1"

RE: [PATCH 4/7] colo: fixed 'Segmentation fault' when the simplex mode PVM poweroff

2021-07-05 Thread Rao, Lei
I can reproduce this bug successfully and the GDB stack is as follows: Program terminated with signal SIGSEGV, Segmentation fault. #0 object_class_dynamic_cast (class=0x55c8f5d2bf50, typename=0x55c8f2f7379e "qio-channel") at qom/object.c:832 832 if (type->class->interfaces && [Current thr

Re: [PATCH v1] s390x/tcg: Fix m5 vs. m4 field for VECTOR MULTIPLY SUM LOGICAL

2021-07-05 Thread David Hildenbrand
On 05.07.21 11:03, David Hildenbrand wrote: The element size is located in m5, not in m4. As there is no m4, qemu currently crashes with an assertion, trying to lookup that field. Reproduced and tested via GO, which ends up using VMSL once the Vector enhancements facility is around for verifying

RE: [PATCH] crypto tls session: GNUTLS internal buffer is now cleared of stale data

2021-07-05 Thread Marcks, Harrison
ping https://lists.nongnu.org/archive/html/qemu-devel/2021-06/msg07713.html -Original Message- From: Marcks, Harrison Sent: 29 June 2021 16:50 To: qemu-devel@nongnu.org Cc: berra...@redhat.com; Marcks, Harrison Subject: [PATCH] crypto tls session: GNUTLS internal buffer is now cleared o

[PATCH 02/14] iotests.py: qemu_img*("create"): support IMGOPTS='compression_type=zstd'

2021-07-05 Thread Vladimir Sementsov-Ogievskiy
Adding support of IMGOPTS (like in bash tests) allows user to pass a lot of different options. Still, some may require additional logic. Now we want compression_type option, so add some smart logic around it: ignore compression_type=zstd in IMGOPTS, if test want qcow2 in compatibility mode. As wel

[PATCH 00/14] iotests: support zstd

2021-07-05 Thread Vladimir Sementsov-Ogievskiy
Hi all! These series makes all test pass with IMGOPTS='compression_type=zstd' Also, python iotests start to support IMGOPTS (they didn't before). Also, tests works if enable compression type zstd by default. There is no such config option currently, probably it will appear in future or we'll

[PATCH 01/14] iotests.py: img_info_log(): rename imgopts argument

2021-07-05 Thread Vladimir Sementsov-Ogievskiy
We are going to support IMGOPTS environment variable like in bash tests. Corresponding global variable in iotests.py should be called imgopts. So to not interfere with function argument, rename it in advance. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/210| 8 -

[PATCH 06/14] iotest 302: use img_info_log() helper

2021-07-05 Thread Vladimir Sementsov-Ogievskiy
Instead of qemu_img_log("info", ..) use generic helper img_info_log(). img_info_log() has smarter logic. For example it use filter_img_info() to filter output, which in turns filter a compression type. So it will help us in future when we implement a possibility to use zstd compression by default

[PATCH 04/14] iotest 065: explicit compression type

2021-07-05 Thread Vladimir Sementsov-Ogievskiy
The test checks different options. It of course fails if set IMGOPTS='compression_type=zstd'. So, let's be explicit in what compression type we want and independent of IMGOPTS. Test both existing compression types. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/065 | 14 +

[PATCH 05/14] iotests.py: filter compression type out

2021-07-05 Thread Vladimir Sementsov-Ogievskiy
We want iotests pass with both the default zlib compression and with IMGOPTS='compression_type=zstd'. Actually the only test that is interested in real compression type in test output is 287 (test for qcow2 compression type) and it's in bash. So for now we can safely filter out compression type in

[PATCH 10/14] iotests: massive use _qcow2_dump_header

2021-07-05 Thread Vladimir Sementsov-Ogievskiy
We are going to add filtering in _qcow2_dump_header and want all tests use it. The patch is generated by commands: cd tests/qemu-iotests sed -ie 's/$PYTHON qcow2.py "$TEST_IMG" dump-header\($\| \)/_qcow2_dump_header\1/' ??? tests/* (the difficulty is to avoid converting dump-header-exts) Si

[PATCH 08/14] iotests/common.rc: _make_test_img(): smarter compressiont_type handling

2021-07-05 Thread Vladimir Sementsov-Ogievskiy
Like it is done in iotests.py in qemu_img_create_prepare_args(), let's not follow compression_type=zstd of IMGOPTS if test creates image in old format. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/common.rc | 8 1 file changed, 8 insertions(+) diff --git a/tests/q

[PATCH 07/14] qcow2: simple case support for downgrading of qcow2 images with zstd

2021-07-05 Thread Vladimir Sementsov-Ogievskiy
If image doesn't have any compressed cluster we can easily switch to zlib compression, which may allow to downgrade the image. That's mostly needed to support IMGOPTS='compression_type=zstd' in some iotests which do qcow2 downgrade. While being here also fix checkpatch complain against '#' in pri

[PATCH 14/14] iotest 214: explicit compression type

2021-07-05 Thread Vladimir Sementsov-Ogievskiy
The test-case "Corrupted size field in compressed cluster descriptor" heavily depends on zlib compression type. So, make it explicit. This way test passes with IMGOPTS='compression_type=zstd'. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/214 | 2 +- 1 file changed, 1 insert

[PATCH 11/14] iotests: bash tests: filter compression type

2021-07-05 Thread Vladimir Sementsov-Ogievskiy
We want iotests pass with both the default zlib compression and with IMGOPTS='compression_type=zstd'. Actually the only test that is interested in real compression type in test output is 287 (test for qcow2 compression type), so implement specific option for it. Signed-off-by: Vladimir Sementsov-

[PATCH 03/14] iotest 303: explicit compression type

2021-07-05 Thread Vladimir Sementsov-Ogievskiy
The test prints qcow2 header fields which depends on chosen compression type. So, let's be explicit in what compression type we want and independent of IMGOPTS. Test both existing compression types. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/303 | 25 -

[PATCH 12/14] iotests 60: more accurate set dirty bit in qcow2 header

2021-07-05 Thread Vladimir Sementsov-Ogievskiy
Don't touch other incompatible bits, like compression-type. This makes the test pass with IMGOPTS='compression_type=zstd'. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/060 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/060 b/tests/qem

[PATCH 13/14] iotest 39: use _qcow2_dump_header

2021-07-05 Thread Vladimir Sementsov-Ogievskiy
_qcow2_dump_header has filter for compression type, so this change makes test pass with IMGOPTS='compression_type=zstd'. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/039 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/039 b/tests/qemu-

[PATCH 09/14] iotests/common.rc: introduce _qcow2_dump_header helper

2021-07-05 Thread Vladimir Sementsov-Ogievskiy
We'll use it in tests instead of explicit qcow2.py. Then we are going to add some filtering in _qcow2_dump_header. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/common.rc | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/qemu-iotests/common.rc b/tests/qem

Re: [PATCH v5 0/2] target/s390x: Fix SIGILL/SIGFPE/SIGTRAP psw.addr reporting

2021-07-05 Thread Cornelia Huck
On Fri, Jul 02 2021, Laurent Vivier wrote: > Le 02/07/2021 à 12:34, Cornelia Huck a écrit : >> On Wed, Jun 23 2021, Ilya Leoshkevich wrote: >> >>> qemu-s390x puts a wrong value into SIGILL's siginfo_t's psw.addr: it >>> should be a pointer to the instruction following the illegal >>> instructio

Re: [PATCH 0/2] linux-user/s390x: signal with SIGFPE on compare-and-trap

2021-07-05 Thread Cornelia Huck
On Mon, Jun 21 2021, Jonathan Albrecht wrote: > qemu-s390x signals with SIGILL on compare-and-trap instructions. This > breaks OpenJDK which expects SIGFPE in its implementation of implicit > exceptions. > > This patch depends on [PATCH v3 0/2] target/s390x: Fix SIGILL psw.addr > reporting. > ht

Re: [PATCH v1] s390x/tcg: Fix m5 vs. m4 field for VECTOR MULTIPLY SUM LOGICAL

2021-07-05 Thread Thomas Huth
On 05/07/2021 11.03, David Hildenbrand wrote: The element size is located in m5, not in m4. As there is no m4, qemu currently crashes with an assertion, trying to lookup that field. Reproduced and tested via GO, which ends up using VMSL once the Vector enhancements facility is around for verifyi

Re: [PATCH] crypto tls session: GNUTLS internal buffer is now cleared of stale data

2021-07-05 Thread Daniel P . Berrangé
On Tue, Jun 29, 2021 at 03:50:04PM +, Marcks, Harrison wrote: > From 7a95cd3f827be55153e7e457caa89351c48f247d Mon Sep 17 00:00:00 2001 > From: harrison marcks > Date: Tue, 29 Jun 2021 16:50:00 +0100 > Subject: [PATCH] crypto tls session: GNUTLS internal buffer is now cleared of > stale data >

Re: [PATCH v5 1/2] target/s390x: Fix SIGILL/SIGFPE/SIGTRAP psw.addr reporting

2021-07-05 Thread David Hildenbrand
On 23.06.21 04:32, Ilya Leoshkevich wrote: For SIGILL, SIGFPE and SIGTRAP the PSW must point after the instruction, and at the instruction for other signals. Currently under qemu-user it always points at the instruction. Fix by advancing psw.addr for these signals. Buglink: https://gitlab.com/q

Re: [RFC v6 00/13] s390x cleanup

2021-07-05 Thread Cornelia Huck
On Wed, Jun 30 2021, Cornelia Huck wrote: > On Tue, Jun 29 2021, "Cho, Yu-Chen" wrote: > >> this is the next version of a cleanup series for s390x. >> > > (...) > >> Cho, Yu-Chen (13): >> target/s390x: meson: add target_user_arch >> hw/s390x: rename tod-qemu.c to tod-tcg.c >> hw/s390x: onl

Re: [PATCH] tests/acceptance: Test NetBSD 5.1 on the Jazz Magnum machine

2021-07-05 Thread Philippe Mathieu-Daudé
On 7/5/21 2:58 AM, Finn Thain wrote: > On Mon, 5 Jul 2021, Philippe Mathieu-Daudé wrote: > >> Test NetBSD 5.1 on the Jazz Magnum machine. As the firmware is not >> redistributable, it has to be extracted from the floppy configuration >> disk coming with a Mips Magnum 4000 system, then the NTPROM_B

Re: [PATCH 0/3] hw/sd: Check for valid address range in SEND_WRITE_PROT (CMD30)

2021-07-05 Thread Philippe Mathieu-Daudé
On 7/2/21 5:58 PM, Philippe Mathieu-Daudé wrote: > Trivial fix for https://gitlab.com/qemu-project/qemu/-/issues/450 > > Missing review: patch #3 > > Philippe Mathieu-Daudé (3): > hw/sd: When card is in wrong state, log which state it is > hw/sd: Extract address_in_range() helper, log invalid

[PATCH 1/7] docs: Fix documentation Copyright date

2021-07-05 Thread Peter Maydell
In commit 6d8980a38fa we updated the copyright string we present to the user in -version output, About dialogs, etc, but we forgot that the Sphinx manuals have a separate copyright string setting. Update that one too. Signed-off-by: Peter Maydell --- docs/conf.py | 2 +- 1 file changed, 1 inser

[PATCH 0/7] docs: State QEMU version and license in all HTML footers

2021-07-05 Thread Peter Maydell
This patchset is an effort to fix something up which I promised Markus I would do after we got the initial conversion to Sphinx done. The old QAPI reference documentation noted the documentation license in the texinfo source (but not in the generated HTML or in the generated manpages); Sphinx gener

[PATCH 4/7] docs: Move deprecation, build and license info out of system/

2021-07-05 Thread Peter Maydell
Now that we have a single Sphinx manual rather than multiple manuals, we can provide a better place for "common to all of QEMU" information like the deprecation notices, build platforms, license information, which we currently have in the system/ manual even though it applies to all of QEMU. Creat

Re: [PATCH] hw/sd: sdhci: Enable 64-bit system bus capability in the default SD/MMC host controller

2021-07-05 Thread Philippe Mathieu-Daudé
On 6/23/21 8:59 PM, Joanne Koong wrote: > The default SD/MMC host controller uses SD spec v2.00. 64-bit system bus > capability > was added in v2. > > In this change, we arrive at 0x157834b4 by computing (0x057834b4 | (1ul << > 28)) > where 28 represents the BUS64BIT SDHC_CAPAB field. > > Signe

[PATCH 3/7] docs: Remove "Contents:" lines from top-level subsections

2021-07-05 Thread Peter Maydell
Since the top-level subsections aren't self-contained manuals any more, the "Contents:" lines at the top of each of their index pages look a bit odd; remove them. Signed-off-by: Peter Maydell --- docs/devel/index.rst | 2 -- docs/interop/index.rst | 2 -- docs/specs/index.rst | 2 -- docs/sy

[PATCH 7/7] docs: Add QEMU version information to HTML footer

2021-07-05 Thread Peter Maydell
Add a line to the HTML document footer mentioning the QEMU version. The version information is already provided in very faint text below the QEMU logo in the sidebar, but that is rather inconspicious, so repeating it in the footer seems useful. Signed-off-by: Peter Maydell --- docs/_templates/fo

[PATCH 6/7] docs: Add license note to the HTML page footer

2021-07-05 Thread Peter Maydell
The standard Sphinx/RTD HTML page footer gives a copyright line (based on the 'copyright' variable set in conf.py) and a line "Built with Sphinx using a theme provided by Read the Docs" (which can be disabled via the html_show_sphinx variable, but we leave it enabled). As a free software project, w

[PATCH 5/7] docs: Add some actual About text to about/index.rst

2021-07-05 Thread Peter Maydell
Add some text to About to act as a brief introduction to the QEMU manual and to make the about page a bit less of an abrupt start to it. Signed-off-by: Peter Maydell --- docs/about/index.rst | 17 + 1 file changed, 17 insertions(+) diff --git a/docs/about/index.rst b/docs/about/

  1   2   3   4   >