Re: [PATCH 33/53] acpi: build_tpm_tcpa: use acpi_init_table()/acpi_table_composed() instead of build_header()

On Tue, 29 Jun 2021 11:19:17 -0400 Stefan Berger wrote: > On 6/25/21 5:17 AM, Igor Mammedov wrote: > > > it replaces error-prone pointer arithmetic for build_header() API, > > with 2 calls to start and finish table creation, > > which hides offsets magic from API user. > > > > While at it switch

[PATCH v2 33/53] acpi: build_tpm_tcpa: use acpi_init_table()/acpi_table_composed() instead of build_header()

it replaces error-prone pointer arithmetic for build_header() API, with 2 calls to start and finish table creation, which hides offsets magic from API user. While at it switch to build_append_int_noprefix() to build table entries (which also removes some manual offset calculations). Signed-off-by

Re: [PATCH v9] qapi: introduce 'query-kvm-cpuid' action

On Mon, Jun 21, 2021 at 07:09:51PM +0300, Valeriy Vdovin wrote: > On Mon, Jun 21, 2021 at 05:50:55PM +0200, Markus Armbruster wrote: > > Eduardo Habkost writes: > > > > > On Mon, Jun 21, 2021 at 10:07:44AM +0200, Claudio Fontana wrote: > > >> On 6/18/21 10:40 PM, Eduardo Habkost wrote: > > >> > O

[PATCH] qga: fix a memory leak in qmp_guest_exec_status()

From: Wang Yechao The $GuestExecInfo.out.data is alloced in guest_exec_output_watch(), and the buffer size is $GuestExecInfo.out.size. We should free the $GuestExecInfo.out.data judge by the size, not length. Because the $GuestExecInfo.out.length maybe zero in some case. $GuestExecInfo.err.data

Re: [PATCH] qga: fix a memory leak in qmp_guest_exec_status()

Hi On Wed, Jun 30, 2021 at 11:42 AM Yi Wang wrote: > From: Wang Yechao > > The $GuestExecInfo.out.data is alloced in guest_exec_output_watch(), > and the buffer size is $GuestExecInfo.out.size. We should free the > $GuestExecInfo.out.data judge by the size, not length. Because the > $GuestExecI

Re: [PATCH v2 1/2] hw/i386/pc: pc_system_ovmf_table_find: Assert that flash was parsed

On 6/30/21 7:46 AM, Dov Murik wrote: > Add assertion in pc_system_ovmf_table_find that verifies that the flash > was indeed previously parsed (looking for the OVMF table) by > pc_system_parse_ovmf_flash. > > Now pc_system_ovmf_table_find distinguishes between "no one called > pc_system_parse_ovmf_

[PATCH] Fix CPUID_Fn8000001E_EBX for AMD

According to AMD64 Arch Programmer's Manual Appendix D, bits 7:0 in Fn8000_001E_EBX should be physical core(s) per logical processor, not per die. Signed-off-by: Jade Cheng --- target/i386/cpu.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/targe

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

On Wed, Jun 30, 2021 at 02:36:31PM +0800, wangyanan (Y) wrote: > Hi Drew, Igor, > > I have a question below, hope for some explanation... :) > > I'm trying to rearrange the smp_parse() helper to make it more scalable. > But I wonder why we are currently using maxcpus to calculate the missing > so

Possible io_uring regression with QEMU on Ubuntu's kernel

Hi everyone. With the latest Ubuntu 20.04's HWE kernel 5.8.0-59, I'm noticing some weirdness when using QEMU/libvirt with the following storage configuration: QEMU version is 5.2+dfsg-9ubuntu3 and libvirt version is 7.0.0-2ubuntu2. The guest VM is unable to handle I/O proper

[PATCH] softmmu/vl: Remove obsolete comment about the "frame" parameter

The frame parameter has been removed along with the support for SDL 1.2. Fixes: 09bd7ba9f5 ("Remove deprecated -no-frame option") Signed-off-by: Thomas Huth --- softmmu/vl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index d99e2cbdbf..cee6339580 100644 --- a

Re: [PATCH 2/2] migration: failover: continue to wait card unplug on error

On 29/06/2021 19:50, Juan Quintela wrote: > Laurent Vivier wrote: >> If the user cancels the migration in the unplug-wait state, >> QEMU will try to plug back the card and this fails because the card >> is partially unplugged. >> To avoid the problem, continue to wait the card unplug, but to >> al

Re: [PATCH 2/2] migration: failover: continue to wait card unplug on error

Laurent Vivier wrote: > On 29/06/2021 19:50, Juan Quintela wrote: >> Laurent Vivier wrote: >>> If the user cancels the migration in the unplug-wait state, >>> QEMU will try to plug back the card and this fails because the card >>> is partially unplugged. >>> To avoid the problem, continue to wait

Re: [question] Shall we flush ITS tables into guest RAM when shutdown the VM?

On 6/30/21 3:38 AM, Kunkun Jiang wrote: > On 2021/6/30 4:14, Eric Auger wrote: >> Hi Kunkun, >> >> On 6/29/21 11:33 AM, Kunkun Jiang wrote: >>> Hi all, >>> >>> Accroding to the patch cddafd8f353d2d251b1a5c6c948a577a85838582, >>> our original intention is to flush the ITS tables into guest RAM at

[PATCH] ui: Mark the '-no-quit' option as deprecated

It's just a cumbersome wrapper around the -display ...,window_close=off parameter, so we should rather tell our users to use that instead. Signed-off-by: Thomas Huth --- docs/system/deprecated.rst | 6 ++ qemu-options.hx| 5 +++-- softmmu/vl.c | 2 ++ 3 files change

Re: [PATCH] ui: Mark the '-no-quit' option as deprecated

On Wed, Jun 30, 2021 at 11:21:27AM +0200, Thomas Huth wrote: > It's just a cumbersome wrapper around the -display ...,window_close=off > parameter, so we should rather tell our users to use that instead. > > Signed-off-by: Thomas Huth > --- > docs/system/deprecated.rst | 6 ++ > qemu-options

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

On 2021/6/30 16:30, Andrew Jones wrote: On Wed, Jun 30, 2021 at 02:36:31PM +0800, wangyanan (Y) wrote: Hi Drew, Igor, I have a question below, hope for some explanation... :) I'm trying to rearrange the smp_parse() helper to make it more scalable. But I wonder why we are currently using maxcpu

Re: [PATCH 20/20] target/loongarch: Add linux-user emulation support

maobibo writes: > 在 2021年06月29日 21:42, Peter Maydell 写道: >> On Mon, 28 Jun 2021 at 13:05, Song Gao wrote: >>> >>> Add files to linux-user/loongarch64 >>> Add file to default-configs >>> Add loongarch to target/meson.build >>> >>> Signed-off-by: Song Gao >>> --- >>> MAINTAINERS

Re: [PATCH v2] virtiofsd: Don't allow file creation with FUSE_OPEN

* Greg Kurz (gr...@kaod.org) wrote: > A well behaved FUSE client uses FUSE_CREATE to create files. It isn't > supposed to pass O_CREAT along a FUSE_OPEN request, as documented in > the "fuse_lowlevel.h" header : > > /** > * Open a file > * > * Open flags are available in fi->fla

[PATCH v2] qga: fix a memory leak in qmp_guest_exec_status()

From: Wang Yechao In some case, $GuestExecInfo.out.length maybe zero and the memory is leaked in qmp_guest_exec_status(). Call g_free() on the fileds directly to fix memory leak (NULL is ignored). $GuestExecInfo.err.data has the same problem. Signed-off-by: Yechao Wang Signed-off-by: Yi Wang

Re: [PATCH] ui: Mark the '-no-quit' option as deprecated

On Wed, 30 Jun 2021 at 10:22, Thomas Huth wrote: > > It's just a cumbersome wrapper around the -display ...,window_close=off > parameter, so we should rather tell our users to use that instead. This is an interesting definition of "cumbersome" -- personally I would say the long -display option is

Re: [PATCH] ui: Mark the '-no-quit' option as deprecated

On Wed, Jun 30, 2021 at 11:01:06AM +0100, Peter Maydell wrote: > On Wed, 30 Jun 2021 at 10:22, Thomas Huth wrote: > > > > It's just a cumbersome wrapper around the -display ...,window_close=off > > parameter, so we should rather tell our users to use that instead. > > This is an interesting defin

Re: [v4] migration: fix the memory overwriting risk in add_to_iovec

* Lin Feng (linfen...@huawei.com) wrote: > From: Feng Lin > > When testing migration, a Segmentation fault qemu core is generated. > 0 error_free (err=0x1) > 1 0x7f8b862df647 in qemu_fclose (f=f@entry=0x55e06c247640) > 2 0x7f8b8516d59a in migrate_fd_cleanup (s=s@entry=0x55e06c0e1ef0) >

Re: [PATCH] ui: Mark the '-no-quit' option as deprecated

On 30/06/2021 12.01, Peter Maydell wrote: On Wed, 30 Jun 2021 at 10:22, Thomas Huth wrote: It's just a cumbersome wrapper around the -display ...,window_close=off parameter, so we should rather tell our users to use that instead. This is an interesting definition of "cumbersome" -- personall

Re: [Virtio-fs] [PATCH v7 1/7] virtiofsd: Fix fuse setxattr() API change issue

* Greg Kurz (gr...@kaod.org) wrote: > On Mon, 28 Jun 2021 15:46:40 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Vivek Goyal (vgo...@redhat.com) wrote: > > > With kernel header updates fuse_setxattr_in struct has grown in size. > > > But this new struct size only takes affect if user has opted

Re: [PATCH] tests/vm: update NetBSD to 9.2

Hi Brad, You forgot to Cc the maintainers: $ ./scripts/get_maintainer.pl -f tests/vm/netbsd "Alex Bennée" (maintainer:Build and test au...) "Philippe Mathieu-Daudé" (maintainer:Build and test au...) Thomas Huth (maintainer:Build and test au...) Wainer dos Santos Moschetta (reviewer:Build and

Re: [PATCH] tests/vm: update openbsd to release 6.9

On 5/31/21 4:01 AM, Brad Smith wrote: > tests/vm: update openbsd to release 6.9 > > Signed-off-by: Brad Smith Acked-by: Philippe Mathieu-Daudé > --- > tests/vm/openbsd | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/vm/openbsd b/tests/vm/openbsd > index 4d1

Re: [PULL 3/6] hmp-commands: Add new HMP command for filter passthrough

* Zhang Chen (chen.zh...@intel.com) wrote: > Add hmp_passthrough_filter_add and hmp_passthrough_filter_del make user > can maintain object network passthrough list in human monitor > > Signed-off-by: Zhang Chen > --- > hmp-commands.hx | 26 +++ > include/monitor/hmp.h | 2 ++ >

Re: [PATCH] ui: Mark the '-no-quit' option as deprecated

On 30/06/2021 12.16, Thomas Huth wrote: On 30/06/2021 12.01, Peter Maydell wrote: On Wed, 30 Jun 2021 at 10:22, Thomas Huth wrote: It's just a cumbersome wrapper around the -display ...,window_close=off parameter, so we should rather tell our users to use that instead. This is an interestin

Re: [PATCH] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL

On Mon, Jun 28, 2021 at 10:49:52AM -0700, Richard Henderson wrote: > On 6/28/21 9:32 AM, Ulrich Weigand wrote: > >>Don't clear out env->fpu_status.float_exception_flags in > >>handle_exceptions. Wait until we're actually done with the data. > > > >I don't really know much about qemu internals, but

Re: [PATCH v2] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL

On Mon, Jun 28, 2021 at 11:45:27AM -0700, Richard Henderson wrote: > On 6/28/21 9:35 AM, Ulrich Weigand wrote: > >@@ -506,6 +534,7 @@ uint64_t HELPER(cgeb)(CPUS390XState *env, uint64_t v2, > >uint32_t m34) > > { > > int old_mode = s390_swap_bfp_rounding_mode(env, round_from_m34(m34)); > >

[PATCH v3] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL

The FP-to-integer conversion instructions need to set CC 3 whenever a "special case" occurs; this is the case whenever the instruction also signals the IEEE invalid exception. (See e.g. figure 19-18 in the Principles of Operation.) However, qemu currently will set CC 3 only in the case where the

Re: [PATCH] block/ssh: add support for sha256 host key fingerprints

Am 22.06.2021 um 13:51 hat Daniel P. Berrangé geschrieben: > Currently the SSH block driver supports MD5 and SHA1 for host key > fingerprints. This is a cryptographically sensitive operation and > so these hash algorithms are inadequate by modern standards. This > adds support for SHA256 which has

Re: [PATCH v2 1/2] hw/i386/pc: pc_system_ovmf_table_find: Assert that flash was parsed

On 30/06/2021 11:23, Philippe Mathieu-Daudé wrote: > On 6/30/21 7:46 AM, Dov Murik wrote: >> Add assertion in pc_system_ovmf_table_find that verifies that the flash >> was indeed previously parsed (looking for the OVMF table) by >> pc_system_parse_ovmf_flash. >> >> Now pc_system_ovmf_table_find

Re: [PATCH v7 2/4] Jobs based on custom runners: build environment docs and playbook

Cleber Rosa writes: > To run basic jobs on custom runners, the environment needs to be > properly set up. The most common requirement is having the right > packages installed. > > The playbook introduced here covers the QEMU's project s390x and > aarch64 machines. At the time this is being pr

[PATCH] pvrdma: Ensure correct input on ring init (CVE-2021-3607)

Check the guest passed a non zero page count for pvrdma device ring buffers. Fixes: CVE-2021-3607 Reported-by: VictorV (Kunlun Lab) Reviewed-by: VictorV (Kunlun Lab) Signed-off-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/rdma/v

[PATCH] pvrdma: Fix the ring init error flow (CVE-2021-3608)

Do not unmap uninitialized dma addresses. Fixes: CVE-2021-3608 Reviewed-by: VictorV (Kunlun Lab) Tested-by: VictorV (Kunlun Lab) Signed-off-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_dev_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma_dev_ring.c b

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

On Wed, Jun 30, 2021 at 05:37:42PM +0800, wangyanan (Y) wrote: > On 2021/6/30 16:30, Andrew Jones wrote: > > On Wed, Jun 30, 2021 at 02:36:31PM +0800, wangyanan (Y) wrote: > > > Hi Drew, Igor, > > > > > > I have a question below, hope for some explanation... :) > > > > > > I'm trying to rearrange

[PULL 1/7] crypto/tlscreds: Introduce qcrypto_tls_creds_check_endpoint() helper

From: Philippe Mathieu-Daudé Introduce the qcrypto_tls_creds_check_endpoint() helper to access QCryptoTLSCreds internal 'endpoint' field. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- crypto/tlscreds.c | 12 in

[PULL 2/7] block/nbd: Use qcrypto_tls_creds_check_endpoint()

From: Philippe Mathieu-Daudé Avoid accessing QCryptoTLSCreds internals by using the qcrypto_tls_creds_check_endpoint() helper. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- block/nbd.c| 6 +++--- blockdev-nbd.c | 6 +++--- 2 fi

[PULL 7/7] crypto: Make QCryptoTLSCreds* structures private

From: Philippe Mathieu-Daudé Code consuming the "crypto/tlscreds*.h" APIs doesn't need to access its internals. Move the structure definitions to the "tlscredspriv.h" private header (only accessible by implementations). The public headers (in include/) still forward-declare the structures typedef

[PULL 0/7] crypto patches

The following changes since commit 13d5f87cc3b94bfccc501142df4a7b12fee3a6e7: Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-axp-20210628' into staging (2021-06-29 10:02:42 +0100) are available in the Git repository at: https://gitlab.com/berrange/qemu tags/tls-deps-pull-request

[PULL 6/7] ui/vnc: Use qcrypto_tls_creds_check_endpoint()

From: Philippe Mathieu-Daudé Avoid accessing QCryptoTLSCreds internals by using the qcrypto_tls_creds_check_endpoint() helper. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- ui/vnc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ui/vnc

[PULL 3/7] qemu-nbd: Use qcrypto_tls_creds_check_endpoint()

From: Philippe Mathieu-Daudé Avoid accessing QCryptoTLSCreds internals by using the qcrypto_tls_creds_check_endpoint() helper. Tested-by: Akihiko Odaki Reviewed-by: Eric Blake Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- qemu-nbd.c | 19 +++ 1

[PULL 4/7] chardev/socket: Use qcrypto_tls_creds_check_endpoint()

From: Philippe Mathieu-Daudé Avoid accessing QCryptoTLSCreds internals by using the qcrypto_tls_creds_check_endpoint() helper. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- chardev/char-socket.c | 18 ++ 1 file chan

[PULL 5/7] migration/tls: Use qcrypto_tls_creds_check_endpoint()

From: Philippe Mathieu-Daudé Avoid accessing QCryptoTLSCreds internals by using the qcrypto_tls_creds_check_endpoint() helper. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- migration/tls.c | 6 +- 1 file changed, 1 insertion(+)

Re: [PATCH v2 33/53] acpi: build_tpm_tcpa: use acpi_init_table()/acpi_table_composed() instead of build_header()

On 6/30/21 3:25 AM, Igor Mammedov wrote: it replaces error-prone pointer arithmetic for build_header() API, with 2 calls to start and finish table creation, which hides offsets magic from API user. While at it switch to build_append_int_noprefix() to build table entries (which also removes som

Re: [PATCH 0/7] vhost-user-blk: Implement reconnection during realize

Am 09.06.2021 um 17:46 hat Kevin Wolf geschrieben: > My previous series removed the broken implementation of automatic > reconnection during .realize(). This series adds some error reporting > improvements that allow distinguishing cases where reconnecting could > help from permanent errors, and th

Re: [PATCH 1/1] s390x/cpumodel: add 3931 and 3932

On 22.06.21 22:19, Christian Borntraeger wrote: This defines 5 new facilities and the new 3931 and 3932 machines. As before the name is not yet known and we do use gen16a and gen16b. The new features are part of the full model. The default model is still empty (same as z15) and will be added in

Re: [PATCH v2] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL

On 6/30/21 3:49 AM, Ulrich Weigand wrote: I'm thinking that should be able to remove TCGv_i32 cc_op in the translator and manually write back to the slot instead. We already do a good job of caching the value within DisasContext -- I imagine that the final code wouldn't even change too much. I

Re: [PATCH v2 1/2] hw/i386/pc: pc_system_ovmf_table_find: Assert that flash was parsed

On 6/30/21 12:46 AM, Dov Murik wrote: > Add assertion in pc_system_ovmf_table_find that verifies that the flash > was indeed previously parsed (looking for the OVMF table) by > pc_system_parse_ovmf_flash. > > Now pc_system_ovmf_table_find distinguishes between "no one called > pc_system_parse_ovmf

Re: [PATCH 1/1] s390x/cpumodel: add 3931 and 3932

On 30.06.21 15:32, David Hildenbrand wrote: On 22.06.21 22:19, Christian Borntraeger wrote: This defines 5 new facilities and the new 3931 and 3932 machines. As before the name is not yet known and we do use gen16a and gen16b. The new features are part of the full model. The default model is

Re: [PATCH] pvrdma: Ensure correct input on ring init (CVE-2021-3607)

On Wed, 30 Jun 2021 at 14:46, Marcel Apfelbaum wrote: > Check the guest passed a non zero page count > for pvrdma device ring buffers. > > Fixes: CVE-2021-3607 > Reported-by: VictorV (Kunlun Lab) > Reviewed-by: VictorV (Kunlun Lab) > Signed-off-by: Marcel Apfelbaum > --- > hw/rdma/vmw/pvrdma_

Re: [PATCH] pvrdma: Fix the ring init error flow (CVE-2021-3608)

On Wed, 30 Jun 2021 at 14:52, Marcel Apfelbaum wrote: > Do not unmap uninitialized dma addresses. > > Fixes: CVE-2021-3608 > Reviewed-by: VictorV (Kunlun Lab) > Tested-by: VictorV (Kunlun Lab) > Signed-off-by: Marcel Apfelbaum > --- > hw/rdma/vmw/pvrdma_dev_ring.c | 2 +- > 1 file changed, 1

Re: [PATCH v2] qga: fix a memory leak in qmp_guest_exec_status()

On Wed, Jun 30, 2021 at 1:55 PM Yi Wang wrote: > From: Wang Yechao > > In some case, $GuestExecInfo.out.length maybe zero and the memory > is leaked in qmp_guest_exec_status(). Call g_free() on the fileds > directly to fix memory leak (NULL is ignored). > > $GuestExecInfo.err.data has the same p

Re: [PATCH v6 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

On Tue, Jun 29, 2021 at 10:08 PM Cleber Rosa wrote: > > On Fri, Jun 11, 2021 at 7:04 AM Alex Bennée wrote: > > > > > > Cleber Rosa Junior writes: > > > > > On Tue, Jun 8, 2021 at 2:30 AM Philippe Mathieu-Daudé > > > wrote: > > > > > > Hi Alex, Stefan, > > > > > > On 6/8/21 5:14 AM, Cleber Ro

Re: [PATCH] pvrdma: Fix the ring init error flow (CVE-2021-3608)

On 6/30/21 1:52 PM, Marcel Apfelbaum wrote: > Do not unmap uninitialized dma addresses. > > Fixes: CVE-2021-3608 > Reviewed-by: VictorV (Kunlun Lab) > Tested-by: VictorV (Kunlun Lab) > Signed-off-by: Marcel Apfelbaum > --- > hw/rdma/vmw/pvrdma_dev_ring.c | 2 +- > 1 file changed, 1 insertion(+

Re: [PATCH v2 1/2] hw/i386/pc: pc_system_ovmf_table_find: Assert that flash was parsed

On 6/30/21 3:38 PM, Tom Lendacky wrote: > On 6/30/21 12:46 AM, Dov Murik wrote: >> Add assertion in pc_system_ovmf_table_find that verifies that the flash >> was indeed previously parsed (looking for the OVMF table) by >> pc_system_parse_ovmf_flash. >> >> Now pc_system_ovmf_table_find distinguishes

Re: [PATCH v3 01/15] python/qom: Do not use 'err' name at module scope

On 6/29/21 6:43 PM, John Snow wrote: Pylint updated to 2.9.0 upstream, adding new warnings for things that re-use the 'err' variable. Luckily, this only breaks the python-check-tox job, which is allowed to fail as a warning. Signed-off-by: John Snow --- I guess that's good enough evidence t

Re: [PATCH v3 10/15] python: only check qemu/ subdir with flake8

On Tue, Jun 29, 2021 at 6:43 PM John Snow wrote: > > flake8 is a little eager to check everything it can. Limit it to > checking inside the qemu namespace directory only. Update setup.cfg now > that the exclude patterns are no longer necessary. > > Signed-off-by: John Snow > --- > python/setup.c

Re: [PATCH v3 01/15] python/qom: Do not use 'err' name at module scope

On Tue, Jun 29, 2021 at 6:43 PM John Snow wrote: > > Pylint updated to 2.9.0 upstream, adding new warnings for things that > re-use the 'err' variable. Luckily, this only breaks the > python-check-tox job, which is allowed to fail as a warning. > > Signed-off-by: John Snow > > --- > > I guess tha

Re: [PATCH v3 11/15] python: add 'make check-dev' invocation

On Tue, Jun 29, 2021 at 6:43 PM John Snow wrote: > > This is a *third* way to run the Python tests. Unlike the first two > (check-pipenv, check-tox), this version does not require any specific > interpreter version -- making it a lot easier to tell people to run it > as a quick smoketest prior to

Re: [PATCH v3 15/15] python: Fix broken ReST docstrings

On Tue, Jun 29, 2021 at 6:44 PM John Snow wrote: > > This patch *doesn't* update all of the docstring standards across the > QEMU package directory to make our docstring usage consistent. It > *doesn't* fix the formatting to make it look pretty or reasonable in > generated output. It *does* fix a

Re: [PATCH v3 11/15] python: add 'make check-dev' invocation

On 6/29/21 6:43 PM, John Snow wrote: This is a *third* way to run the Python tests. Unlike the first two (check-pipenv, check-tox), this version does not require any specific interpreter version -- making it a lot easier to tell people to run it as a quick smoketest prior to submission to GitLa

Re: [PATCH v3 11/15] python: add 'make check-dev' invocation

On Wed, Jun 30, 2021 at 10:41 AM Willian Rampazzo wrote: > On Tue, Jun 29, 2021 at 6:43 PM John Snow wrote: > > > > This is a *third* way to run the Python tests. Unlike the first two > > (check-pipenv, check-tox), this version does not require any specific > > interpreter version -- making it a

Re: [PATCH] nvdimm: add 'target-node' option

On Fri, 25 Jun 2021 10:25:18 +0800 Jingqi Liu wrote: > Linux kernel version 5.1 brings in support for the volatile-use of > persistent memory as a hotplugged memory region (KMEM DAX). > When this feature is enabled, persistent memory can be seen as a > separate memory-only NUMA node(s). This newl

Re: [PATCH v3 10/15] python: only check qemu/ subdir with flake8

On 6/29/21 6:43 PM, John Snow wrote: flake8 is a little eager to check everything it can. Limit it to checking inside the qemu namespace directory only. Update setup.cfg now that the exclude patterns are no longer necessary. Signed-off-by: John Snow --- python/setup.cfg | 2 -- pytho

Re: [PATCH v3 11/15] python: add 'make check-dev' invocation

On 6/30/21 11:58 AM, John Snow wrote: On Wed, Jun 30, 2021 at 10:41 AM Willian Rampazzo > wrote: On Tue, Jun 29, 2021 at 6:43 PM John Snow mailto:js...@redhat.com>> wrote: > > This is a *third* way to run the Python tests. Unlike the first two > (c

Re: [PATCH v3 15/15] python: Fix broken ReST docstrings

On 6/29/21 6:43 PM, John Snow wrote: This patch *doesn't* update all of the docstring standards across the QEMU package directory to make our docstring usage consistent. It *doesn't* fix the formatting to make it look pretty or reasonable in generated output. It *does* fix a few small instances

[Bug 1907497] Re: [OSS-Fuzz] Issue 28435 qemu:qemu-fuzz-i386-target-generic-fuzz-intel-hda: Stack-overflow in ldl_le_dma

@Thomas, could you try by compiling qemu with a commit close to the timeframe mentioned here [0]? [0] https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=28435#c2 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchp

Re: [RFC v6 07/13] target/s390x: move sysemu-only code out to cpu-sysemu.c

On Tue, Jun 29 2021, "Cho, Yu-Chen" wrote: > move sysemu-only code out to cpu-sysemu.c > > Signed-off-by: Claudio Fontana > Signed-off-by: Cho, Yu-Chen > --- > target/s390x/cpu-sysemu.c | 309 ++ > target/s390x/cpu.c| 285 ++--

Re: [PATCH 3/3] hw/sh4: sh7750 using renesas_sci.

On Tue, 29 Jun 2021 22:23:01 +0900, Peter Maydell wrote: > > On Wed, 16 Jun 2021 at 10:14, Yoshinori Sato > wrote: > > > > Signed-off-by: Yoshinori Sato > > --- > > include/hw/sh4/sh.h | 8 > > hw/sh4/sh7750.c | 41 + > > hw/sh4/Kconfig

Re: [RFC v6 10/13] target/s390x: use kvm_enabled() to wrap call to kvm_s390_get_hpage_1m

On Tue, Jun 29 2021, "Cho, Yu-Chen" wrote: > this will allow to remove the kvm stubs. > > Signed-off-by: Claudio Fontana > Signed-off-by: Cho, Yu-Chen > --- > target/s390x/diag.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target/s390x/diag.c b/target/s390x/diag.

Re: [RFC v6 11/13] target/s390x: remove kvm-stub.c

On Tue, Jun 29 2021, "Cho, Yu-Chen" wrote: > all function calls are protected by kvm_enabled(), > so we do not need the stubs. > > Signed-off-by: Claudio Fontana > Signed-off-by: Cho, Yu-Chen > --- > MAINTAINERS | 1 - > target/s390x/kvm-stub.c | 121 ---

Re: [RFC v6 12/13] target/s390x: move kvm files into kvm/

On Tue, Jun 29 2021, "Cho, Yu-Chen" wrote: > move kvm files into kvm/ > After the reshuffling, update MAINTAINERS accordingly. > Make use of the new directory: > > target/s390x/kvm/ > > Signed-off-by: Claudio Fontana > Signed-off-by: Cho, Yu-Chen > --- > MAINTAINERS| 3

Re: [RFC v6 00/13] s390x cleanup

On Tue, Jun 29 2021, "Cho, Yu-Chen" wrote: > this is the next version of a cleanup series for s390x. > (...) > Cho, Yu-Chen (13): > target/s390x: meson: add target_user_arch > hw/s390x: rename tod-qemu.c to tod-tcg.c > hw/s390x: only build tod-tcg from the CONFIG_TCG build > hw/s390x: t

Contributions: Adding New Devices

Hello, I can't find this information on the website, so here I am. I developed a QEMU device that virtualises a PCI card that we widely use at CERN. But this card is only used at CERN. Clearly, having CERN specific devices in QEMU does not help much the qemu community, hence I maintain an inte

[PATCH v5 03/10] hw/intc: GICv3 ITS command queue framework

Added functionality to trigger ITS command queue processing on write to CWRITE register and process each command queue entry to identify the command type and handle commands like MAPD,MAPC,SYNC. Signed-off-by: Shashi Mallela Reviewed-by: Peter Maydell --- hw/intc/arm_gicv3_its.c | 305

[PATCH v5 00/10] GICv3 LPI and ITS feature implementation

This patchset implements qemu device model for enabling physical LPI support and ITS functionality in GIC as per GICv3 specification. Both flat table and 2 level tables are implemented.The ITS commands for adding/deleting ITS table entries,trigerring LPI interrupts are implemented.Translated LPI in

[PATCH v5 01/10] hw/intc: GICv3 ITS initial framework

Added register definitions relevant to ITS,implemented overall ITS device framework with stubs for ITS control and translater regions read/write,extended ITS common to handle mmio init between existing kvm device and newer qemu device. Signed-off-by: Shashi Mallela Reviewed-by: Peter Maydell ---

[PATCH v5 02/10] hw/intc: GICv3 ITS register definitions added

Defined descriptors for ITS device table,collection table and ITS command queue entities.Implemented register read/write functions, extract ITS table parameters and command queue parameters,extended gicv3 common to capture qemu address space(which host the ITS table platform memories required for s

[PATCH v5 04/10] hw/intc: GICv3 ITS Command processing

Added ITS command queue handling for MAPTI,MAPI commands,handled ITS translation which triggers an LPI via INT command as well as write to GITS_TRANSLATER register,defined enum to differentiate between ITS command interrupt trigger and GITS_TRANSLATER based interrupt trigger. Each of these commands

[PATCH v5 06/10] hw/intc: GICv3 redistributor ITS processing

Implemented lpi processing at redistributor to get lpi config info from lpi configuration table,determine priority,set pending state in lpi pending table and forward the lpi to cpuif.Added logic to invoke redistributor lpi processing with translated LPI which set/clear LPI from ITS device as part o

[PATCH 1/7] tests: Rename TestState to TPMTestState

Signed-off-by: Stefan Berger --- tests/qtest/bios-tables-test.c| 2 +- tests/qtest/tpm-crb-test.c| 4 ++-- tests/qtest/tpm-emu.c | 6 +++--- tests/qtest/tpm-emu.h | 6 +++--- tests/qtest/tpm-tis-device-test.c | 2 +- tests/qtest/tpm-tis-test.c| 2 +- te

[PATCH v5 05/10] hw/intc: GICv3 ITS Feature enablement

Added properties to enable ITS feature and define qemu system address space memory in gicv3 common,setup distributor and redistributor registers to indicate LPI support. Signed-off-by: Shashi Mallela --- hw/intc/arm_gicv3_common.c | 12 hw/intc/arm_gicv3_dist.c |

Re: [PATCH 1/1] s390x/cpumodel: add 3931 and 3932

On Wed, Jun 30 2021, Christian Borntraeger wrote: > On 30.06.21 15:32, David Hildenbrand wrote: >> On 22.06.21 22:19, Christian Borntraeger wrote: >>> This defines 5 new facilities and the new 3931 and 3932 machines. >>> As before the name is not yet known and we do use gen16a and gen16b. >>> The

[PATCH v5 07/10] hw/arm/sbsa-ref: add ITS support in SBSA GIC

Included creation of ITS as part of SBSA platform GIC initialization. Signed-off-by: Shashi Mallela --- hw/arm/sbsa-ref.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index 43c19b4923..3d9c073636 100644 ---

Re: [PATCH v3 11/15] python: add 'make check-dev' invocation

On Wed, Jun 30, 2021 at 11:58 AM John Snow wrote: > > > > On Wed, Jun 30, 2021 at 10:41 AM Willian Rampazzo wrote: >> >> On Tue, Jun 29, 2021 at 6:43 PM John Snow wrote: >> > >> > This is a *third* way to run the Python tests. Unlike the first two >> > (check-pipenv, check-tox), this version doe

[PATCH v5 08/10] tests/data/acpi/virt: Add IORT files for ITS

Added expected IORT files applicable with latest GICv3 ITS changes.Temporarily differences in these files are okay. Signed-off-by: Shashi Mallela --- tests/data/acpi/virt/IORT | 0 tests/data/acpi/virt/IORT.memhp | 0 tests/data/acpi/virt/IORT.numamem | 0

[PATCH v5 09/10] hw/arm/virt: add ITS support in virt GIC

Included creation of ITS as part of virt platform GIC initialization. This Emulated ITS model now co-exists with kvm ITS and is enabled in absence of kvm irq kernel support in a platform. Signed-off-by: Shashi Mallela Reviewed-by: Peter Maydell --- hw/arm/virt.c | 28 +++

Re: [PATCH 1/2] migration: Move yank outside qemu_start_incoming_migration()

* Peter Xu (pet...@redhat.com) wrote: > Starting from commit b5eea99ec2f5c, qmp_migrate_recover() calls unregister > before calling qemu_start_incoming_migration(). I believe it wanted to > mitigate > the next call to yank_register_instance(), but I think that's wrong. > > Firstly, if during reco

[PATCH v5 10/10] tests/data/acpi/virt: Update IORT files for ITS

Updated expected IORT files applicable with latest GICv3 ITS changes. Signed-off-by: Shashi Mallela --- tests/data/acpi/virt/IORT | Bin 0 -> 124 bytes tests/data/acpi/virt/IORT.memhp | Bin 0 -> 124 bytes tests/data/acpi/virt/IORT.numamem | Bin 0 -> 124 b

[PATCH 4/7] test: tpm: Create TPM 1.2 response in TPM emulator

Signed-off-by: Stefan Berger --- tests/qtest/tpm-emu.c | 5 + tests/qtest/tpm-emu.h | 3 +++ 2 files changed, 8 insertions(+) diff --git a/tests/qtest/tpm-emu.c b/tests/qtest/tpm-emu.c index 8baf49eafd..32c704194b 100644 --- a/tests/qtest/tpm-emu.c +++ b/tests/qtest/tpm-emu.c @@ -62,6 +62,11

[PATCH 6/7] tests: acpi: Add test cases for TPM 1.2 with TCPA table

Cc: Michael S. Tsirkin Cc: Igor Mammedov Signed-off-by: Stefan Berger --- tests/qtest/bios-tables-test.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index 4ccbe56158..ddfd2d2b2a 100644 --- a/tests

[PATCH 0/7] tests: Add test cases for TPM 1.2 ACPI tables

This series of patches adds test case for TPM 1.2 ACPI tables. Stefan Stefan Berger (7): tests: Rename TestState to TPMTestState tests: Add tpm_version field to TPMTestState and fill it tests: Add suffix tpm2 or tpm12 to ACPI table files test: tpm: Create TPM 1.2 response in TPM emulato

[PATCH 2/7] tests: Add tpm_version field to TPMTestState and fill it

Signed-off-by: Stefan Berger --- tests/qtest/bios-tables-test.c| 5 +++-- tests/qtest/tpm-crb-test.c| 1 + tests/qtest/tpm-emu.c | 13 ++--- tests/qtest/tpm-emu.h | 2 ++ tests/qtest/tpm-tis-device-test.c | 1 + tests/qtest/tpm-tis-test.c|

Re: [PATCH 2/2] migration: Allow reset of postcopy_recover_triggered when failed

* Peter Xu (pet...@redhat.com) wrote: > It's possible qemu_start_incoming_migration() failed at any point, when it > happens we should reset postcopy_recover_triggered to false so that the user > can still retry with a saner incoming port. > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan

[PATCH 5/7] tests: acpi: prepare for new TPM 1.2 related tables

Cc: Michael S. Tsirkin Cc: Igor Mammedov Signed-off-by: Stefan Berger --- tests/data/acpi/q35/DSDT.tis.tpm12 | 0 tests/data/acpi/q35/TCPA.tis.tpm12 | 0 tests/qtest/bios-tables-test-allowed-diff.h | 2 ++ 3 files changed, 2 insertions(+) create mode 100644 tests/data/acpi/q3

[PATCH 7/7] tests: acpi: tpm1.2: Add expected TPM 1.2 ACPI blobs

The TCPA.tis.tpm12 file contains the following: [000h 4]Signature : "TCPA"[Trusted Computing Platform Alliance table] [004h 0004 4] Table Length : 0032 [008h 0008 1] Revision : 02 [009h 0009 1] Checks

[PATCH 3/7] tests: Add suffix tpm2 or tpm12 to ACPI table files

Signed-off-by: Stefan Berger --- tests/data/acpi/q35/{DSDT.tis => DSDT.tis.tpm2} | Bin tests/data/acpi/q35/{TPM2.tis => TPM2.tis.tpm2} | Bin tests/qtest/bios-tables-test.c | 3 ++- 3 files changed, 2 insertions(+), 1 deletion(-) rename tests/data/acpi/q35/{DSDT.tis => DSDT.t

[PULL 07/24] block: introduce bdrv_set_file_or_backing_noperm()

From: Vladimir Sementsov-Ogievskiy To be used for reopen in future commit. Notes: - It seems OK to update inherits_from if new bs is recursively inherits from parent bs. Let's just not check for backing_chain_contains, to support file child of non-filters. - Simply check child->frozen inste

  1   2   3   >