Re: [PATCH 09/15] hw/net/e1000e: Fix impl.min_access_size

在 2021/6/20 上午1:26, Richard Henderson 写道: There are certainly architectural 2 byte writes, as evidenced by the e1000e_set_16bit function. I also saw a 1 byte write, though that may have been the fuzzer. Cc: Jason Wang Cc: Dmitry Fleytman Signed-off-by: Richard Henderson --- hw/net/e1000e

RE: [PATCH v2] ui/gtk: Allow user to select monitor number to display qemu in full screen through new gtk display option

Hi Gerd, Start counting from zero makes sense too. Matter of tasts. We have examples for both in the qemu source tree. So, whatever you pick, this clearly needs documentation (in ui.json option description). sweeaun: Sure, I will make sure that is mentioned clearly in documentation. Well,

[Bug 1907497] Re: [OSS-Fuzz] Issue 28435 qemu:qemu-fuzz-i386-target-generic-fuzz-intel-hda: Stack-overflow in ldl_le_dma

No, I can still reproduce this issue with current version from the git repo (commit 8f521741e1280f0957ac1) ... when I compile QEMU with Clang and --enable-sanitizers, the reproducer still crashes with "ERROR: AddressSanitizer: stack-overflow" -- You received this bug notification because you are

Re: [PATCH 11/26] target/m68k: Use translator_use_goto_tb

Le 21/06/2021 à 03:34, Richard Henderson a écrit : > Just use translator_use_goto_tb directly at the one call site, > rather than maintaining a local wrapper. > > Cc: Laurent Vivier > Signed-off-by: Richard Henderson > --- > target/m68k/translate.c | 12 +--- > 1 file changed, 1 inserti

[PATCH v2] docs/system: arm: Add nRF boards description

This adds the target guide for BBC Micro:bit. Information is taken from https://wiki.qemu.org/Features/MicroBit and from hw/arm/nrf51_soc.c. Signed-off-by: Alexandre Iooss Reviewed-by: Philippe Mathieu-Daudé --- MAINTAINERS| 1 + docs/system/arm/nrf.rst| 51 +++

Re: [PATCH v2] docs/system: arm: Add nRF boards description

On Mon, 21 Jun 2021 at 07:57, Alexandre Iooss wrote: > > This adds the target guide for BBC Micro:bit. > > Information is taken from https://wiki.qemu.org/Features/MicroBit > and from hw/arm/nrf51_soc.c. > > Signed-off-by: Alexandre Iooss > Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Joel

Re: [PATCH v4 3/6] block-copy: improve comments of BlockCopyTask and BlockCopyState types and functions

On 19/06/2021 17:23, Vladimir Sementsov-Ogievskiy wrote: 14.06.2021 10:33, Emanuele Giuseppe Esposito wrote: As done in BlockCopyCallState, categorize BlockCopyTask and BlockCopyState in IN, State and OUT fields. This is just to understand which field has to be protected with a lock. .sleep_

Re: [PATCH v9] qapi: introduce 'query-kvm-cpuid' action

On 6/18/21 10:40 PM, Eduardo Habkost wrote: > On Fri, Jun 18, 2021 at 07:52:47AM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >>> On Thu, Jun 17, 2021 at 05:53:11PM +0200, Claudio Fontana wrote: On 6/17/21 5:39 PM, Valeriy Vdovin wrote: > On Thu, Jun 17, 2021 at 04:14:17P

[PATCH v3 0/3] avocado-qemu: New SMMUv3 and intel IOMMU tests

This series adds ARM SMMU and Intel IOMMU functional tests using Fedora cloud-init images. ARM SMMU tests feature guests with and without RIL (range invalidation support) using respectively fedora 33 and 31. For each, we test the protection of virtio-net-pci and virtio-block-pci devices. Also str

[PATCH v3 2/3] avocado_qemu: Add SMMUv3 tests

Add new tests checking the good behavior of the SMMUv3 protecting 2 virtio pci devices (block and net). We check the guest boots and we are able to install a package. Different guest configs are tested: standard, passthrough an strict=0. This is tested with both fedora 31 and 33. The former uses a

[PATCH v3 1/3] Acceptance Tests: Add default kernel params and pxeboot url to the KNOWN_DISTROS collection

When running LinuxTests we may need to run the guest with custom params. It is practical to store the pxeboot URL and the default kernel params so that the tests just need to fetch those and augment the kernel params. Signed-off-by: Eric Auger --- v2 -> v3: - add fed32 and fed33 checksums ---

[PATCH v3 3/3] avocado_qemu: Add Intel iommu tests

Add Intel IOMMU functional tests based on fedora 31. Different configs are checked: - strict - caching mode, strict - passthrough. Signed-off-by: Eric Auger --- tests/acceptance/intel_iommu.py | 115 1 file changed, 115 insertions(+) create mode 100644 tests/acc

Re: [PATCH v4 3/6] block-copy: improve comments of BlockCopyTask and BlockCopyState types and functions

On 19/06/2021 20:31, Vladimir Sementsov-Ogievskiy wrote: 19.06.2021 18:23, Vladimir Sementsov-Ogievskiy wrote:   typedef struct BlockCopyTask {   AioTask task; +    /* + * IN parameters. Initialized in block_copy_task_create() + * and never changed. + */ That's just not true

Re: [PATCH v16 7/7] KVM: arm64: Document MTE capability and ioctl

On 18/06/2021 15:52, Catalin Marinas wrote: > On Fri, Jun 18, 2021 at 02:28:26PM +0100, Steven Price wrote: >> +When this capability is enabled all memory in (non-device) memslots must not >> +used VM_SHARED, attempts to create a memslot with a VM_SHARED mmap will >> result >> +in an -EINVAL retur

Re: [PATCH 2/2] tests/migration: fix "downtime_limit" type when "migrate-set-parameters"

On Thu, Jun 03, 2021 at 10:20:37PM +0800, huang...@chinatelecom.cn wrote: > From: Hyman Huang(黄勇) > > migrate-set-parameters parse "downtime_limit" as integer type when > execute "migrate-set-parameters" before migration, and, the unit > dowtime_limit is milliseconds, fix this two so that test ca

Re: [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast

On Thu, Jun 03, 2021 at 10:19:53PM +0800, huang...@chinatelecom.cn wrote: > From: Hyman Huang(黄勇) > > thread_id in CpuInfoFast is deprecated, parse thread-id instead > after execute qmp query-cpus-fast. fix this so that test can > go smoothly. > > Signed-off-by: Hyman Huang(黄勇) > --- > tests/m

Re: [PATCH v4 3/6] block-copy: improve comments of BlockCopyTask and BlockCopyState types and functions

On 19/06/2021 19:27, Vladimir Sementsov-Ogievskiy wrote: 14.06.2021 10:33, Emanuele Giuseppe Esposito wrote: As done in BlockCopyCallState, categorize BlockCopyTask and BlockCopyState in IN, State and OUT fields. This is just to understand which field has to be protected with a lock. .sleep_

Re: [PATCH RFC] meson: add option to use zstd for qcow2 compression by default

On 17/06/21 21:51, Vladimir Sementsov-Ogievskiy wrote: So, it's an RFC. I also can split the patch so that refactoring of qcow2_co_create() go in a separate preparation patch. Another RFC question, shouldn't we move to zstd by default in upstream too? I think backwards-incompatible changes in

Re: [PATCH v16 1/7] arm64: mte: Handle race when synchronising tags

On 18/06/2021 16:42, Marc Zyngier wrote: > On 2021-06-18 15:40, Catalin Marinas wrote: >> On Fri, Jun 18, 2021 at 02:28:20PM +0100, Steven Price wrote: >>> mte_sync_tags() used test_and_set_bit() to set the PG_mte_tagged flag >>> before restoring/zeroing the MTE tags. However if another thread were

Re: [PATCH v4 3/6] block-copy: improve comments of BlockCopyTask and BlockCopyState types and functions

On 19/06/2021 20:53, Vladimir Sementsov-Ogievskiy wrote: 14.06.2021 10:33, Emanuele Giuseppe Esposito wrote: --- a/block/block-copy.c +++ b/block/block-copy.c @@ -52,29 +52,35 @@ typedef struct BlockCopyCallState {   /* Coroutine where async block-copy is running */   Coroutine *co; -

Re: [PATCH v2] ui/gtk: Allow user to select monitor number to display qemu in full screen through new gtk display option

Gerd Hoffmann writes: [...] >> sweeaun: Based on my observation, when specific monitor device disconnected >> after QEMU launched on it, QEMU application will not be visible but QEMU >> application still running and screen framebuffer size is not being changed >> at all. QEMU application wil

Re: [PATCH] block/rbd: Add support for rbd image encryption

On Sat, Jun 19, 2021 at 09:44:32PM +0200, Ilya Dryomov wrote: > On Thu, Jun 17, 2021 at 6:05 PM Or Ozeri wrote: > > > > Starting from ceph Pacific, RBD has built-in support for image-level > > encryption. > > Currently supported formats are LUKS version 1 and 2. > > > > There are 2 new relevant l

Re: [PATCH v2] ui/gtk: Allow user to select monitor number to display qemu in full screen through new gtk display option

"Khor, Swee Aun" writes: > Hi Markus, > Thanks for include Graphic maintainer and the coding style comments. Yes, > sweeaun is my name 😊 I'd expect something like Signed-off-by: Khor, Swee Aun

Re: [PATCH v2 3/3] target/avr: Convert to TranslatorOps

Hi Michael, On 6/21/21 7:38 AM, Michael Rolnik wrote: > Reviewed-by: Michael Rolnik mailto:mrol...@gmail.com>> > Tested-by: Michael Rolnik mailto:mrol...@gmail.com>> Are your tags valid for the latest patch or the whole series? > On Mon, Jun 21, 2021 at 12:50 AM Richard Henderson > mailto:richar

Re: [PATCH v2 3/3] target/avr: Convert to TranslatorOps

The whole series. On Mon, Jun 21, 2021 at 11:33 AM Philippe Mathieu-Daudé wrote: > Hi Michael, > > On 6/21/21 7:38 AM, Michael Rolnik wrote: > > Reviewed-by: Michael Rolnik mailto:mrol...@gmail.com > >> > > Tested-by: Michael Rolnik mailto:mrol...@gmail.com>> > > Are your tags valid for the late

Re: [PATCH v2 19/23] hw/i386: Move pc_madt_cpu_entry() to acpi-pc.c

On 6/19/21 11:32 PM, Michael S. Tsirkin wrote: > On Sat, Jun 19, 2021 at 10:45:17AM +0200, Philippe Mathieu-Daudé wrote: >> On 6/18/21 1:37 PM, Igor Mammedov wrote: >>> On Wed, 16 Jun 2021 22:43:24 +0200 >>> Philippe Mathieu-Daudé wrote: >>> pc_madt_cpu_entry() is specific to QEMU 'PC' machin

Re: [PATCH 0/2] tcg: Fixes for temp_allocate_frame

On Sat, Jun 19, 2021 at 10:16:55AM +0200, Stefan Weil wrote: > Am 19.06.21 um 06:56 schrieb Richard Henderson: > > > Stefan, I think this will resolve #367 for you -- please test. > > > Tested-by: Stefan Weil > > > Thank you, yes, it seems to resolve that issue. > > I had to make two additio

Re: [PATCH] x86: add SEV hashing to fw_cfg for kernel/initrd/cmdline

On 17/06/2021 17.48, Philippe Mathieu-Daudé wrote: [...] This works, but I'd rather use: if (sev_enabled()) { sev_kernel_loader_calc_cmdline_hash(&sev_loader_context, kernel_cmdline); } And have sev_enabled() defined as: #ifdef CONFIG_SEV

Re: [PATCH v16 7/7] KVM: arm64: Document MTE capability and ioctl

On Mon, Jun 21, 2021 at 09:18:31AM +0100, Steven Price wrote: > On 18/06/2021 15:52, Catalin Marinas wrote: > > On Fri, Jun 18, 2021 at 02:28:26PM +0100, Steven Price wrote: > >> +When this capability is enabled all memory in (non-device) memslots must > >> not > >> +used VM_SHARED, attempts to cr

Re: [PATCH V3 5/6] block/rbd: add write zeroes support

Am 18.06.21 um 12:34 schrieb Ilya Dryomov: On Fri, Jun 18, 2021 at 11:00 AM Peter Lieven wrote: Am 16.06.21 um 14:34 schrieb Ilya Dryomov: On Wed, May 19, 2021 at 4:28 PM Peter Lieven wrote: Signed-off-by: Peter Lieven --- block/rbd.c | 37 - 1 file ch

Re: [PATCH v3 0/3] avocado-qemu: New SMMUv3 and intel IOMMU tests

Cc'ing Willian On 6/21/21 10:08 AM, Eric Auger wrote: > This series adds ARM SMMU and Intel IOMMU functional > tests using Fedora cloud-init images. > > ARM SMMU tests feature guests with and without RIL > (range invalidation support) using respectively fedora 33 > and 31. For each, we test the

Re: [PATCH v16 3/7] KVM: arm64: Introduce MTE VM feature

On Fri, 18 Jun 2021 14:28:22 +0100, Steven Price wrote: > > Add a new VM feature 'KVM_ARM_CAP_MTE' which enables memory tagging > for a VM. This will expose the feature to the guest and automatically > tag memory pages touched by the VM as PG_mte_tagged (and clear the tag > storage) to ensure tha

Re: [Virtio-fs] [PATCH v2 7/9] virtiofsd: Add inodes_by_handle hash table

On 18.06.21 20:29, Vivek Goyal wrote: On Fri, Jun 18, 2021 at 10:28:38AM +0200, Max Reitz wrote: On 17.06.21 23:21, Vivek Goyal wrote: On Wed, Jun 16, 2021 at 03:38:13PM +0200, Max Reitz wrote: On 11.06.21 22:04, Vivek Goyal wrote: On Wed, Jun 09, 2021 at 05:55:49PM +0200, Max Reitz wrote: C

Re: [PATCH v16 3/7] KVM: arm64: Introduce MTE VM feature

On 21/06/2021 10:01, Marc Zyngier wrote: > On Fri, 18 Jun 2021 14:28:22 +0100, > Steven Price wrote: >> >> Add a new VM feature 'KVM_ARM_CAP_MTE' which enables memory tagging >> for a VM. This will expose the feature to the guest and automatically >> tag memory pages touched by the VM as PG_mte_ta

Re: [PATCH 23/26] target/sparc: Use translator_use_goto_tb

On 21/06/2021 02:34, Richard Henderson wrote: Cc: Mark Cave-Ayland Signed-off-by: Richard Henderson --- target/sparc/translate.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 4bfa3179f8..fb0

RE: [PATCH v2] ui/gtk: Allow user to select monitor number to display qemu in full screen through new gtk display option

>> sweeaun: Based on my observation, when specific monitor device disconnected >> after QEMU launched on it, QEMU application will not be visible but QEMU >> application still running and screen framebuffer size is not being changed >> at all. QEMU application will be visible once you connect ba

Re: [PATCH] x86: add SEV hashing to fw_cfg for kernel/initrd/cmdline

On 6/21/21 10:44 AM, Thomas Huth wrote: > On 17/06/2021 17.48, Philippe Mathieu-Daudé wrote: > [...] >> This works, but I'd rather use: >> >>    if (sev_enabled()) { >>    sev_kernel_loader_calc_cmdline_hash(&sev_loader_context, >>    kernel_cmdline); >>

Re: [RFC PATCH 0/5] ebpf: Added ebpf helper for libvirtd.

在 2021/6/19 上午4:03, Andrew Melnichenko 写道: Hi Jason, I've checked "kernel.unprivileged_bpf_disabled=0" on Fedora,  Ubuntu, and Debian - no need permissions to update BPF maps. How about RHEL :) ? Thanks On Wed, Jun 16, 2021 at 1:18 AM Andrew Melnichenko > wrot

Re: [PATCH v4 6/6] block-copy: atomic .cancelled and .finished fields in BlockCopyCallState

On 19/06/2021 22:06, Vladimir Sementsov-Ogievskiy wrote: 14.06.2021 10:33, Emanuele Giuseppe Esposito wrote: By adding acquire/release pairs, we ensure that .ret and .error_is_read fields are written by block_copy_dirty_clusters before .finished is true. And that they are read by API user a

[PATCH v2] block/nvme: Fix VFIO_MAP_DMA failed: No space left on device

When the NVMe block driver was introduced (see commit bdd6a90a9e5, January 2018), Linux VFIO_IOMMU_MAP_DMA ioctl was only returning -ENOMEM in case of error. The driver was correctly handling the error path to recycle its volatile IOVA mappings. To fix CVE-2019-3882, Linux commit 492855939bdb ("vf

[PATCH] linux-user: fill ppid field in /proc/self/stat

Signed-off-by: Andreas Schwab --- linux-user/syscall.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 974dd46c9a..dababe463c 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -7940,6 +7940,9 @@ static int open_self_stat(void

Re: [PATCH 2/6] block: block-status cache for data regions

On 18.06.21 20:51, Eric Blake wrote: On Thu, Jun 17, 2021 at 05:52:43PM +0200, Max Reitz wrote: To address this, we want to cache data regions. Most of the time, when bad performance is reported, it is in places where the image is iterated over from start to end (qemu-img convert or the mirror

Re: [PATCH 3/6] block/file-posix: Do not force-cap *pnum

On 18.06.21 22:16, Eric Blake wrote: On Thu, Jun 17, 2021 at 05:52:44PM +0200, Max Reitz wrote: bdrv_co_block_status() does it for us, we do not need to do it here. The advantage of not capping *pnum is that bdrv_co_block_status() can cache larger data regions than requested by its caller. We

Re: [PATCH] x86: add SEV hashing to fw_cfg for kernel/initrd/cmdline

On 6/21/21 11:15 AM, Philippe Mathieu-Daudé wrote: > On 6/21/21 10:44 AM, Thomas Huth wrote: >> On 17/06/2021 17.48, Philippe Mathieu-Daudé wrote: >> [...] >>> This works, but I'd rather use: >>> >>>    if (sev_enabled()) { >>>    sev_kernel_loader_calc_cmdline_hash(&sev_loader_context, >>>    

Re: [PATCH 4/6] block/gluster: Do not force-cap *pnum

On 19.06.21 12:36, Vladimir Sementsov-Ogievskiy wrote: 17.06.2021 18:52, Max Reitz wrote: bdrv_co_block_status() does it for us, we do not need to do it here. The advantage of not capping *pnum is that bdrv_co_block_status() can cache larger data regions than requested by its caller. Signed-of

Re: [PATCH 5/6] block/nbd: Do not force-cap *pnum

On 19.06.21 12:53, Vladimir Sementsov-Ogievskiy wrote: 17.06.2021 18:52, Max Reitz wrote: bdrv_co_block_status() does it for us, we do not need to do it here. The advantage of not capping *pnum is that bdrv_co_block_status() can cache larger data regions than requested by its caller. Signed-of

Re: [PATCH v4 2/8] hw/intc: GICv3 ITS register definitions added

Hi Shashi, On 6/16/21 11:02 PM, shashi.mall...@linaro.org wrote: > Hi Eric, > > Please find my responses inline (below):- > > On Sat, 2021-06-12 at 08:08 +0200, Eric Auger wrote: >> >> On 6/2/21 8:00 PM, Shashi Mallela wrote: >>> Defined descriptors for ITS device table,collection table and ITS

[PULL 00/37] s390x update

The following changes since commit 8f521741e1280f0957ac1b873292c19219e1fb9a: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20210618.0' into staging (2021-06-18 16:42:25 +0100) are available in the Git repository at: https://gitlab.com/cohuck/qemu.git tags/s390

[PULL 01/37] s390x/kvm: remove unused gs handling

With commit 0280b3eb7c05 ("s390x/kvm: use cpu model for gscb on compat machines"), we removed any calls to kvm_s390_get_gs() in favour of a different mechanism. Let's remove the unused kvm_s390_get_gs(), and with it the now unneeded cap_gs as well. Signed-off-by: Cornelia Huck Reviewed-by: Chris

[PULL 03/37] s390x/tcg: Fix instruction name for VECTOR FP LOAD (LENGTHENED|ROUNDED)

From: David Hildenbrand Let's use the correct name. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-3-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/insn-data.def | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) dif

[PULL 02/37] s390x/tcg: Fix FP CONVERT TO (LOGICAL) FIXED NaN handling

From: David Hildenbrand In case we encounter a NaN, we have to return the smallest possible number, corresponding to either 0 or the maximum negative number. This seems to differ from IEEE handling as implemented in softfloat, whereby we return the biggest possible number. While at it, use float

[PULL 04/37] s390x/tcg: Simplify vop64_3() handling

From: David Hildenbrand Let's simplify, reworking our handler generation, passing the whole "m5" register content and not providing specialized handlers for "se", and reading/writing proper float64 values using new helpers. Suggested-by: Richard Henderson Reviewed-by: Richard Henderson Signed-

[PULL 06/37] s390x/tcg: Simplify vfc64() handling

From: David Hildenbrand Pass the m5 field via simd_data() and don't provide specialized handlers for single-element variants. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-6-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/he

[PULL 13/37] s390x/tcg: Implement VECTOR MULTIPLY SUM LOGICAL

From: David Hildenbrand Fortunately, we only need the Doubleword implementation. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-13-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/insn-data.def | 2 ++ target/s390x/trans

[PULL 10/37] s390x/tcg: Simplify vflr64() handling

From: David Hildenbrand Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-10-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/helper.h | 1 - target/s390x/translate_vx.c.inc | 3 +-- target/s390x/vec_fpu_helper.c | 2

[PULL 05/37] s390x/tcg: Simplify vop64_2() handling

From: David Hildenbrand Let's rework our macros and simplify. We still need helper functions in most cases due to the different parameters types. Next, we'll only have 32/128bit variants for vfi and vfsq, so special case the others. Note that for vfsq, the XxC and erm passed in the simd_data()

[PULL 07/37] s390x/tcg: Simplify vftci64() handling

From: David Hildenbrand Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-7-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/helper.h | 1 - target/s390x/translate_vx.c.inc | 7 ++- target/s390x/vec_fpu_helper.c

[PULL 21/37] s390x/tcg: Implement 32/128 bit for VECTOR FP TEST DATA CLASS IMMEDIATE

From: David Hildenbrand Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-21-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/helper.h | 2 ++ target/s390x/translate_vx.c.inc | 23 ++-- target/s390x/vec_fpu_

[PULL 12/37] s390x/tcg: Implement VECTOR BIT PERMUTE

From: David Hildenbrand Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-12-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.c.inc | 8

[PULL 09/37] s390x/tcg: Simplify vfll32() handling

From: David Hildenbrand Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-9-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/helper.h | 1 - target/s390x/translate_vx.c.inc | 6 +- target/s390x/vec_fpu_helper.c |

[PULL 23/37] s390x/tcg: Implement VECTOR FP NEGATIVE MULTIPLY AND (ADD|SUBTRACT)

From: David Hildenbrand Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-23-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/helper.h | 6 + target/s390x/insn-data.def | 4 target/s390x/translate_vx.c.in

Re: [RFC PATCH] hw/display/virtio-gpu: Fix memory leak (CID 1453811)

ping? On 6/14/21 12:52 PM, Philippe Mathieu-Daudé wrote: > ping? > > On 5/31/21 12:19 PM, Philippe Mathieu-Daudé wrote: >> To avoid leaking memory on the error path, reorder the >> code as: >> - check the parameters first >> - check resource already existing >> - finally allocate memory >> >> Rep

[PULL 15/37] s390x/tcg: Implement 32/128 bit for VECTOR (LOAD FP INTEGER|FP SQUARE ROOT)

From: David Hildenbrand Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-15-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/helper.h | 4 ++ target/s390x/translate_vx.c.inc | 74 ++--- targ

[PULL 08/37] s390x/tcg: Simplify vfma64() handling

From: David Hildenbrand Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-8-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/helper.h | 2 -- target/s390x/translate_vx.c.inc | 8 +++ target/s390x/vec_fpu_helper.c

[PULL 18/37] s390x/tcg: Implement 64 bit for VECTOR FP LOAD LENGTHENED

From: David Hildenbrand 64 bit -> 128 bit, there is only a single final element. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-18-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/helper.h | 1 + target/s390x/transl

[PULL 16/37] s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE *

From: David Hildenbrand In addition to 32/128bit variants, we also have to support the "Signal-on-QNaN (SQ)" bit. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-16-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/helper.h

[PULL 25/37] linux-user: elf: s390x: Prepare for Vector enhancements facility

From: David Hildenbrand Let's check for S390_FEAT_VECTOR_ENH and set HWCAP_S390_VXRS_EXT accordingly. Add all missing HWCAP defined in upstream Linux. Cc: Laurent Vivier Acked-by: Laurent Vivier Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-25-da...@redhat.com> Signed-off

[PULL 24/37] s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)

From: David Hildenbrand For IEEE functions, we can reuse the softfloat implementations. For the other functions, implement it generically for 32bit/64bit/128bit - carefully taking care of all weird special cases according to the tables defined in the PoP. Reviewed-by: Richard Henderson Signed-o

[PULL 11/37] s390x/tcg: Simplify wfc64() handling

From: David Hildenbrand ... and prepare for 32/128 bit support. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-11-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/vec_fpu_helper.c | 23 --- 1 file changed,

[PULL 27/37] s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z14 GA2

From: David Hildenbrand TCG implements everything we need to run basic z14 OS+software. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-27-da...@redhat.com> Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-ccw.c | 3 +++ target/s390x/c

[PULL 19/37] s390x/tcg: Implement 128 bit for VECTOR FP LOAD ROUNDED

From: David Hildenbrand 128 bit -> 64 bit, there is only a single element to process. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-19-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/helper.h | 1 + target/s390x/t

[PULL 26/37] s390x/tcg: We support Vector enhancements facility

From: David Hildenbrand Everything is wired up and all new instructions are implemented. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-26-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/gen-features.c | 1 + 1 file changed,

[PULL 14/37] s390x/tcg: Implement 32/128 bit for VECTOR FP (ADD|DIVIDE|MULTIPLY|SUBTRACT)

From: David Hildenbrand In case of 128bit, we always have a single element. Add new helpers for reading/writing 32/128 bit floats. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-14-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s3

[PULL 20/37] s390x/tcg: Implement 32/128 bit for VECTOR FP PERFORM SIGN OPERATION

From: David Hildenbrand Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-20-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/translate_vx.c.inc | 106 ++-- 1 file changed, 73 insertions(+), 33 deletion

[PULL 31/37] target/s390x: Improve s390_cpu_dump_state vs cc_op

From: Richard Henderson Use s390_cpu_get_psw_mask so that we print the correct architectural value of psw.mask. Do not print cc_op unless tcg_enabled. Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Tested-by: jonathan.albrecht Tested-by: Message-Id: <20210615030744.1252385-

[PULL 28/37] configure: Check whether we can compile the s390-ccw bios with -msoft-float

From: Thomas Huth The -msoft-float switch is not available in older versions of Clang. Since we rely on the compiler to not generate floating point instructions unexpectedly, we block those old compilers now via a test in the configure script. Note that for some weird reasons, the Clang compiler

[PULL 17/37] s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE (AND SIGNAL) SCALAR

From: David Hildenbrand Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-17-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/helper.h | 4 +++ target/s390x/translate_vx.c.inc | 38 ++-- target/s

[PULL 32/37] target/s390x: Use s390_cpu_{set_psw, get_psw_mask} in gdbstub

From: Richard Henderson No change in behaviour, as gdbstub was correctly written to install and extract the cc value. Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Tested-by: jonathan.albrecht Tested-by: Message-Id: <20210615030744.1252385-5-richard.hender...@linaro.org> Si

[PULL 22/37] s390x/tcg: Implement 32/128 bit for VECTOR FP MULTIPLY AND (ADD|SUBTRACT)

From: David Hildenbrand Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-22-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/helper.h | 4 +++ target/s390x/translate_vx.c.inc | 47 - tar

[PULL 30/37] target/s390x: Do not modify cpu state in s390_cpu_get_psw_mask

From: Richard Henderson We want to use this function for debugging, and debug should not modify cpu state (even non-architectural cpu state) lest we introduce heisenbugs. Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Tested-by: jonathan.albrecht Tested-by: Message-Id: <2021

[PULL 37/37] s390x/css: Add passthrough IRB

From: Eric Farman Wire in the subchannel callback for building the IRB ESW and ECW space for passthrough devices, and copy the hardware's ESW into the IRB we are building. If the hardware presented concurrent sense, then copy that sense data into the IRB's ECW space. Signed-off-by: Eric Farman

[PULL 29/37] target/s390x: Expose load_psw and get_psw_mask to cpu.h

From: Richard Henderson Rename to s390_cpu_set_psw and s390_cpu_get_psw_mask at the same time. Adjust so that they compile for user-only. Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: David Hildenbrand Tested-by: jonathan.albrecht Tested-by: Message-Id: <2021061503

[PULL 33/37] linux-user/s390x: Save and restore psw.mask properly

From: Richard Henderson At present, we're referencing env->psw.mask directly, which fails to ensure that env->cc_op is incorporated or updated. Use s390_cpu_{set_psw,get_psw_mask} to fix this. Mirror the kernel's cleaning of the psw.mask in save_sigregs and restore_sigregs. Ignore PSW_MASK_RI f

[PULL 35/37] s390x/css: Split out the IRB sense data

From: Eric Farman Let's move this logic into its own routine, so it can be reused later. Signed-off-by: Eric Farman Reviewed-by: Thomas Huth Message-Id: <20210617232537.1337506-3-far...@linux.ibm.com> Signed-off-by: Cornelia Huck --- hw/s390x/css.c | 19 --- 1 file changed, 1

Re: [PATCH v2] hw/virtio: Document *_should_notify() are called within rcu_read_lock()

ping? On 5/23/21 11:40 AM, Philippe Mathieu-Daudé wrote: > Such comments make reviewing this file somehow easier. > > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: only one space before end of comment (mst) > --- > hw/virtio/virtio.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

[PULL 34/37] s390x/css: Introduce an ESW struct

From: Eric Farman The Interrupt Response Block is comprised of several other structures concatenated together, but only the 12-byte Subchannel-Status Word (SCSW) is defined as a proper struct. Everything else is a simple array of 32-bit words. Let's define a proper struct for the 20-byte Extende

Re: [PATCH 2/6] block: block-status cache for data regions

On 19.06.21 12:20, Vladimir Sementsov-Ogievskiy wrote: 17.06.2021 18:52, Max Reitz wrote: As we have attempted before (https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06451.html, "file-posix: Cache lseek result for data regions"; https://lists.nongnu.org/archive/html/qemu-block/2021-02/

[PULL 36/37] s390x/css: Refactor IRB construction

From: Eric Farman Currently, all subchannel types have "sense data" copied into the IRB.ECW space, and a couple flags enabled in the IRB.SCSW and IRB.ESW. But for passthrough (vfio-ccw) subchannels, this data isn't populated in the first place, so enabling those flags leads to unexpected behavior

[PATCH v6 00/16] qemu_iotests: improve debugging options

This series adds the option to attach gdbserver and valgrind to the QEMU binary running in qemu_iotests. It also allows to redirect QEMU binaries output of the python tests to the stdout, instead of a log file. Patches 1-9 introduce the -gdb option to both python and bash tests, 10-14 extend the

Re: [PATCH v4 3/8] hw/intc: GICv3 ITS command queue framework

On 6/16/21 11:02 PM, shashi.mall...@linaro.org wrote: > Hi Eric, > > Please find my responses inline (below):- > > On Sun, 2021-06-13 at 16:13 +0200, Eric Auger wrote: >> Hi Sashi, >> >> On 6/2/21 8:00 PM, Shashi Mallela wrote: >>> Added functionality to trigger ITS command queue processing on

Re: [PATCH v7 0/6] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers

ping? On 6/14/21 9:32 PM, Philippe Mathieu-Daudé wrote: > Hi, > > The floppy disc controllers pulls in irrelevant devices (sysbus in > an ISA-only machine, ISA bus + isa devices on a sysbus-only machine). > > This series clean that by extracting each device in its own file, > adding the correspo

[PATCH v6 02/16] python: Reduce strictness of pylint's duplicate-code check

From: John Snow Pylint prior to 2.8.3 (We pin at >= 2.8.0) includes function and method signatures as part of its duplicate checking algorithm. This check does not listen to pragmas, so the only way to disable it is to turn it off completely or increase the minimum duplicate lines so that it does

Re: [PATCH v2] hw/pci-host/q35: Ignore write of reserved PCIEXBAR LENGTH field

ping? On 6/14/21 1:14 PM, Philippe Mathieu-Daudé wrote: > ping? > > On 5/26/21 4:24 PM, Philippe Mathieu-Daudé wrote: >> libFuzzer triggered the following assertion: >> >> cat << EOF | qemu-system-i386 -M pc-q35-5.0 \ >> -nographic -monitor none -serial none \ >> -qtest stdio -d guest_e

Re: [PATCH] memory: Display MemoryRegion name in read/write ops trace events

Le 21/06/2021 à 12:08, Philippe Mathieu-Daudé a écrit : > Hi Laurent, > > On 6/7/21 1:29 PM, Laurent Vivier wrote: >> Le 07/06/2021 à 10:28, Philippe Mathieu-Daudé a écrit : >>> On 6/7/21 9:33 AM, Laurent Vivier wrote: Le 02/06/2021 à 12:49, Philippe Mathieu-Daudé a écrit : > Cc'ing qemu-

[PATCH v6 06/16] qemu-iotests: delay QMP socket timers

Attaching gdbserver implies that the qmp socket should wait indefinitely for an answer from QEMU. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/

Re: [PATCH v4 4/8] hw/intc: GICv3 ITS Command processing

On 6/16/21 11:02 PM, shashi.mall...@linaro.org wrote: > Hi Eric, > > Please find my responses inline (below):- > > On Sun, 2021-06-13 at 17:55 +0200, Eric Auger wrote: >> Hi Shashi, >> >> On 6/2/21 8:00 PM, Shashi Mallela wrote: >>> Added ITS command queue handling for MAPTI,MAPI commands,hand

Re: [PATCH 05/26] target/arm: Use translator_use_goto_tb

On Mon, 21 Jun 2021 at 02:42, Richard Henderson wrote: > > Put a wrapper in translate.h, which also checks for ss_active. > The ss_active test was incorrectly missing from the a32 version. True, but we almost never call gen_goto_tb() when ss_active (which makes sense because we generate code to r

Re: [PULL v2 00/34] NBD patches through 2021-06-15

On Fri, 18 Jun 2021 at 18:34, Eric Blake wrote: > > The following changes since commit 3ccf6cd0e3e1dfd663814640b3b18b55715d7a75: > > Merge remote-tracking branch > 'remotes/kraxel/tags/audio-20210617-pull-request' into staging (2021-06-18 > 09:54:42 +0100) > > are available in the Git reposito

Re: [PATCH] memory: Display MemoryRegion name in read/write ops trace events

Hi Laurent, On 6/7/21 1:29 PM, Laurent Vivier wrote: > Le 07/06/2021 à 10:28, Philippe Mathieu-Daudé a écrit : >> On 6/7/21 9:33 AM, Laurent Vivier wrote: >>> Le 02/06/2021 à 12:49, Philippe Mathieu-Daudé a écrit : Cc'ing qemu-trivial@ On 3/18/21 4:39 PM, Philippe Mathieu-Daudé wrot

[PATCH v6 07/16] qemu_iotests: insert gdbserver command line as wrapper for qemu binary

Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index e176a84620..e7e3d92d3e 100644 --- a/test

  1   2   3   4   5   >