On Wed, May 26, 2021 at 10:12:48AM +0100, Stefan Hajnoczi wrote:
> If the size of a VD_AGENT_CLIPBOARD_GRAB message is invalid we leak info
> when returning early.
>
> Thanks to Coverity for spotting this:
>
> *** CID 1453266: Resource leaks (RESOURCE_LEAK)
> /qemu/ui/vdagent.c: 465 in vdagent_
On 18/05/2021 22:25, Mark Cave-Ayland wrote:
Following on from the ESP changes in QEMU 6.0 someone pointed out that the old
Linux 2.6 ESP driver as used in Aurelian's SPARC image at
https://people.debian.org/~aurel32/qemu/sparc/ emits a constant stream of
"esp0: STEP_ASEL for tgt 0" messages to
Peter Maydell 于2021年5月27日周四 上午2:19写道：
>
> On Wed, 26 May 2021 at 18:32, Swetha Joshi wrote:
> >
> > Hello,
> >
> > One of the qemu machines we use has KVM enabled, but we don't want the
> > CONFIG_ARM_VIRT enabled as it pulls in emulation of a variety of physical
> > hardware that we don't need
On 19/05/2021 11:07, Mark Cave-Ayland wrote:
This patchset contains more ESP fixes from my attempts to boot MacOS under
the QEMU q800 machine (along with a related NetBSD fix).
With these patches it is possible for the MacOS toolbox ROM and MacOS drivers
to detect and access SCSI drives and CDR
On Thu, 27 May 2021 14:56:02 -0300
"Bruno Larsen (billionai)" wrote:
> Documented the removal of the HMP command info cpustats
>
> Signed-off-by: Bruno Larsen (billionai)
> ---
Reviewed-by: Greg Kurz
> docs/system/removed-features.rst | 5 +
> 1 file changed, 5 insertions(+)
>
> diff -
On 26/05/21 19:18, Vladimir Sementsov-Ogievskiy wrote:
It's actually the original idea of block_copy_do_copy() function: do
only simple copy, don't interact with the state. It's a kind of wrapper
on top of bdrv_co.
So, actually updating s->use_copy_range here was a bad idea.
It's still mor
On 18/05/21 12:07, Emanuele Giuseppe Esposito wrote:
+qemu_mutex_lock(&call_state->s->calls_lock);
QLIST_INSERT_HEAD(&call_state->s->calls, call_state, list);
+qemu_mutex_unlock(&call_state->s->calls_lock);
Let's just use tasks_lock here (maybe even rename it to just "lock").
Pao
On 28/05/21 12:24, Paolo Bonzini wrote:
It's still more complicated, because you need to add some kind of
method = s->method;
This would even have to be a separate, one-line critical section...
Paolo
ret = block_copy_do_copy(..., method);
if (ret < 0 && method <= COPY_RANGE_
On 5/27/21 6:03 PM, Alex Bennée wrote:
> If you specify something like --cc="ccache gcc" on your configure line
> the summary output misses the rest of the cmd_array. Do some string
> joining to make it complete.
>
> Signed-off-by: Alex Bennée
> Tested-by: Thomas Huth
> ---
> meson.build | 8 ++
From: Niklas Cassel
In the Zoned Namespace Command Set Specification, chapter
2.5.1 Managing resources
"The controller may transition zones in the ZSIO:Implicitly Opened state
to the ZSC:Closed state for resource management purposes."
The word may in this sentence means that automatically trans
ping
On Mon, Apr 5, 2021 at 4:14 PM Basil Salman wrote:
> Currently Requester freeze times out after 10 seconds, while
> the default timeout for Writer Freeze is 60 seconds. according to
> VSS Documentation [1].
> [1]:
> https://docs.microsoft.com/en-us/windows/win32/vss/overview-of-processing-a
On May 28 11:05, Niklas Cassel wrote:
From: Niklas Cassel
In the Zoned Namespace Command Set Specification, chapter
2.5.1 Managing resources
"The controller may transition zones in the ZSIO:Implicitly Opened state
to the ZSC:Closed state for resource management purposes."
The word may in this
28.05.2021 14:01, Paolo Bonzini wrote:
On 28/05/21 12:24, Paolo Bonzini wrote:
It's still more complicated, because you need to add some kind of
method = s->method;
This would even have to be a separate, one-line critical section...
Or atomic operation.. What I don't like that all tr
11.08.2020 12:54, Max Reitz wrote:
On 11.08.20 11:39, Peter Maydell wrote:
On Tue, 11 Aug 2020 at 10:35, Max Reitz wrote:
Hi,
There is a bug in the backup job that breaks backups from images whose
size is not aligned to the job's cluster size (i.e., qemu crashes
because of a failed assertion
Signed-off-by: Luis Pires
---
Being new to QEMU, I went through the code to try to understand how
lookup_and_goto_ptr, goto_tb and exit_tb work, and when each should be used.
Thought I'd share what I learned by documenting it, as it might be
useful to other people starting to work on TCG, and wil
Without a single top-level header in the .rst file, the index ended
up linking to all of the top-level headers separately. Now the index
links to the top-level header at the beginning of the document and
any inner headers are correctly linked as sub-items in the index.
Signed-off-by: Luis Pires
-
28.05.2021 14:01, Paolo Bonzini wrote:
On 28/05/21 12:24, Paolo Bonzini wrote:
It's still more complicated, because you need to add some kind of
method = s->method;
This would even have to be a separate, one-line critical section...
Hm, so, we should set .use_copy_range in task, when
Without a single top-level header in the .rst file, the index ended
up linking to all of the top-level headers separately. Now the index
links to the top-level header at the beginning of the document and
any inner headers are correctly linked as sub-items in the index.
Signed-off-by: Luis Pires
-
Hi all!
This is my suggestion how to refactor block-copy to avoid extra atomic
operations in
"[PATCH v2 0/7] block-copy: protect block-copy internal structures"
Vladimir Sementsov-Ogievskiy (2):
block-copy: fix block_copy_task_entry() progress update
block-copy: refactor copy_range handling
Currently we update s->use_copy_range and s->copy_size in
block_copy_do_copy().
It's not very good:
1. block_copy_do_copy() is intended to be a simple function, that wraps
bdrv_co_ functions for need of block copy. That's why we don't pass
BlockCopyTask into it. So, block_copy_do_copy() is bad pl
Don't report successful progress on failure, when call_state->ret is
set.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/block-copy.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/block/block-copy.c b/block/block-copy.c
index c2e5090412..f9e871b64f 100644
---
From: Katsuhiro Ueno
Add support for the following keys: KATAKANAHIRAGANA, HENKAN, MUHENKAN,
RO, and YEN. Before this commit, these keys did not work as expected
when a jp106 keyboard was connected to the guest as a usb-kbd device.
Signed-off-by: Katsuhiro Ueno
Message-Id:
Signed-off-by: Gerd
The following changes since commit c8616fc7670b884de5f74d2767aade224c1c5c3a:
Merge remote-tracking branch 'remotes/philmd/tags/gitlab-ci-20210527' into
staging (2021-05-27 16:32:57 +0100)
are available in the Git repository at:
git://git.kraxel.org/qemu tags/usb-20210528-pull-re
From: Ruimei Yan
At present MSI / MSI-X interrupts are triggered regardless of the
irq level. We should have checked the level to determine whether
the interrupt needs to be delivered.
The level check logic was present in early versions of the xhci
model, but got dropped later by a rework of int
From: Ruimei Yan
Per xHCI spec v1.2 chapter 4.17.5 page 296:
If MSI or MSI-X interrupts are enabled, Interrupt Pending (IP)
shall be cleared automatically when the PCI dword write generated
by the interrupt assertion is complete.
Currently QEMU does not clear the IP flag in the MSI / MSI-
Luis Pires writes:
> Without a single top-level header in the .rst file, the index ended
> up linking to all of the top-level headers separately. Now the index
> links to the top-level header at the beginning of the document and
> any inner headers are correctly linked as sub-items in the index
On 5/28/21 5:30 AM, Luis Pires wrote:
+In its simplest, less optimized form, this is done by exiting from the
+current TB, going through the TB epilogue, and then back to the outer
+execution loop. That’s where QEMU looks for the next TB to execute,
+translating it from the guest architecture if
On Wed, 26 May 2021 at 21:15, Laurent Vivier wrote:
>
> The following changes since commit 0319ad22bd5789e1eaa8a2dd5773db2d2c372f20:
>
> Merge remote-tracking branch
> 'remotes/stsquad/tags/pull-testing-and-misc-updates-250521-2' into staging
> (2021-05-25 17:31:04 +0100)
>
> are available in
Peter Maydell writes:
> The official punctuation for Arm CPU names uses a hyphen, like
> "Cortex-A9". We mostly follow this, but in a few places usage
> without the hyphen has crept in. Fix those so we consistently
> use the same way of writing the CPU name.
>
> This commit was created with:
>
20.05.2021 17:21, Vladimir Sementsov-Ogievskiy wrote:
copy_range is not a default behavior since 6a30f663d4c0b3c, and it's
now available only though x-perf experimantal argument, so it's OK to
drop it.
Even when backup is used to copy disk to same filesystem, and
filesystem supports zero-copy co
Greg Kurz writes:
> On Thu, 27 May 2021 13:50:34 -0300
> "Bruno Larsen (billionai)" wrote:
>
>> Documented the removal of the HMP command cpustats
>>
>
> It is the 'info cpustats' command.
>
>> Signed-off-by: Bruno Larsen (billionai)
>> ---
>> docs/system/removed-features.rst | 6 ++
>>
On Thu, 27 May 2021 13:14:00 +0900,
Richard Henderson wrote:
>
> Both input and output denormals flush to zero when DN is set.
>
> Cc: Philippe Mathieu-Daudé
> Cc: Yoshinori Sato
> Signed-off-by: Richard Henderson
Reviewd-by: Yoshinori Sato
> ---
> target/rx/op_helper.c | 9 -
> 1
On Thu, 27 May 2021 13:14:02 +0900,
Richard Henderson wrote:
>
> The existing check was completely wrong, confused about the
> definition of the (previous) float_flag_{input,output}_denormal
> flags, then making sure that DN, the flush-to-zero bit, was off.
>
> Update for the introduction of floa
On Thu, 27 May 2021 13:14:01 +0900,
Richard Henderson wrote:
>
> Use the proper type for the roundmode array.
>
> Cc: Philippe Mathieu-Daudé
> Cc: Yoshinori Sato
> Signed-off-by: Richard Henderson
Reviewd-by: Yoshinori Sato
> ---
> target/rx/op_helper.c | 2 +-
> 1 file changed, 1 insertio
On 5/27/21 1:46 AM, Richard Henderson wrote:
> From: Philippe Mathieu-Daudé
>
> Only 2 headers require "exec/tb-context.h". Instead of having
> all files including "exec/exec-all.h" also including it, directly
> include it where it is required:
> - accel/tcg/cpu-exec.c
> - accel/tcg/translate-all
On 5/27/21 11:08 AM, Bruno Larsen (billionai) wrote:
since both, PPC_DO_STATISTICS and PPC_DUMP_CPU, are obsoleted as
target/ppc moves to decodetree, we can remove this ifdef based decision
tree, and only have what is now the standard option for the macro.
Suggested-by: Luis Pires
Signed-off-by:
On 5/27/21 11:08 AM, Bruno Larsen (billionai) wrote:
This feature will no longer be useful as ppc moves to using decotree for
decodetree
TCG. And building with it enabled is no longer possible, due to changes
in opc_handler_t. Since the last commit that mentions it happened in
2014, I think i
20.05.2021 10:52, Emanuele Giuseppe Esposito wrote:
Define -gdb flag and GDB_OPTIONS environment variable
to python tests to attach a gdbserver to each qemu instance.
This patch only adds and parses this flag, it does not yet add
the implementation for it.
if -gdb is not provided but $GDB_OPTION
While the default config works well enough it does end up enabling a
lot of stuff. For more minimal builds we can pass a slimmed down list
of devices and let Kconfig work out what we want. For example:
../../configure --without-default-features \
--target-list=arm-softmmu,aarch64-softmmu \
20.05.2021 10:52, Emanuele Giuseppe Esposito wrote:
Attaching gdbserver implies that the qmp socket
should wait indefinitely for an answer from QEMU.
Signed-off-by: Emanuele Giuseppe Esposito
---
tests/qemu-iotests/iotests.py | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
20.05.2021 10:52, Emanuele Giuseppe Esposito wrote:
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
20.05.2021 10:52, Emanuele Giuseppe Esposito wrote:
The only limitation here is that running a script with gdbserver
will make the test output mismatch with the expected
results, making the test fail.
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best
20.05.2021 10:52, Emanuele Giuseppe Esposito wrote:
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
docs/devel/testing.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index 8144e3
20.05.2021 10:52, Emanuele Giuseppe Esposito wrote:
Currently, the check script only parses the option and sets the
VALGRIND_QEMU environmental variable to "y".
Add another local python variable that prepares the command line,
identical to the one provided in the test scripts.
Because the python
20.05.2021 10:52, Emanuele Giuseppe Esposito wrote:
As with gdbserver, valgrind delays the test execution, so
the default QMP socket timeout timeout too soon.
First, "Timeout" class is a generic class for timeouts, not relying to sockets.
So, commit message lacks information about that we mod
20.05.2021 10:52, Emanuele Giuseppe Esposito wrote:
When using -valgrind on the script tests, it generates a log file
in $TEST_DIR that is either read (if valgrind finds problems) or
otherwise deleted. Provide the same exact behavior when using
-valgrind on the python tests.
Signed-off-by: Emanu
I'm probably missing something, but why do we need both
"float_flag_inorm_denormal" and "float_flag_iflush_denormal"?
Couldn't the code that sets these flags set just a single flag for all denormal
inputs and the code that checks these flags check that single flag
combined with the "flush_inputs
20.05.2021 10:52, Emanuele Giuseppe Esposito wrote:
The priority will be given to gdb command line, meaning if the -gdb
parameter and -valgrind are given, gdb will be wrapped around
the qemu binary.
I'd prefer just return an error immediately if user specify both -gdb and
-valgrind
Signed-o
20.05.2021 10:52, Emanuele Giuseppe Esposito wrote:
Reviewed-by: Max Reitz
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
20.05.2021 10:52, Emanuele Giuseppe Esposito wrote:
Using the flag -p, allow the qemu binary to print to stdout.
Reviewed-by: Max Reitz
Signed-off-by: Emanuele Giuseppe Esposito
---
tests/qemu-iotests/check | 4 +++-
tests/qemu-iotests/iotests.py | 9 +
tests/qemu-iotests/test
20.05.2021 10:52, Emanuele Giuseppe Esposito wrote:
Signed-off-by: Emanuele Giuseppe Esposito
I'd merge it to previous patch. anyway:
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
docs/devel/testing.rst | 4
1 file changed, 4 insertions(+)
diff --git a/docs/devel/testing.rst b/doc
Following the guidelines in tests/qtest/bios-tables-test.c, this
change adds empty placeholder files per step 1 for the new ERST
table, and excludes resulting changed files in bios-tables-test-allowed-diff.h
per step 2.
Signed-off-by: Eric DeVolder
---
tests/data/acpi/microvm/ERST
This change includes ERST in the build of ACPI.
Signed-off-by: Eric DeVolder
---
hw/acpi/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/acpi/meson.build b/hw/acpi/meson.build
index dd69577..262a8ee 100644
--- a/hw/acpi/meson.build
+++ b/hw/acpi/meson.build
@@ -4,6 +4,7 @@ acp
NOTE: Also, I wanted to push this v3 for review while alerting
that I will be on holiday through June 8 (possibly a few days
later).
NOTE: The patches are arranged such that each can be applied
in order and not break the build (except the 0001 patch). Igor
has hinted at changing this, but I'm unsu
This change implements the support for the ACPI ERST feature[1,2].
The size of the ACPI ERST storage is declared via the QEMU
global parameter acpi-erst.size. The size can range from 64KiB
to to 64MiB. The default is 64KiB.
The location of the ACPI ERST storage backing file is declared
via the QE
This change introduces the defintions for ACPI ERST.
Signed-off-by: Eric DeVolder
---
include/hw/acpi/erst.h | 82 ++
1 file changed, 82 insertions(+)
create mode 100644 include/hw/acpi/erst.h
diff --git a/include/hw/acpi/erst.h b/include/hw/acpi
This change enables ERST support for x86 guests.
ERST can be disabled at run-time, for example, with:
-machine q35,erst=off
Signed-off-by: Eric DeVolder
---
hw/i386/acpi-build.c | 7 +++
hw/i386/pc.c | 31 +++
include/hw/i386/pc.h | 1 +
3 files chang
Signed-off-by: Eric DeVolder
---
tests/data/acpi/pc/ERST | Bin 0 -> 976 bytes
tests/data/acpi/q35/ERST| Bin 0 -> 976 bytes
tests/qtest/bios-tables-test-allowed-diff.h | 4
3 files changed, 4 deletions(-)
diff --git a/tests/data/acpi/pc/ERST b/test
On Thu, 27 May 2021 at 00:47, Richard Henderson
wrote:
>
> The following changes since commit 0319ad22bd5789e1eaa8a2dd5773db2d2c372f20:
>
> Merge remote-tracking branch
> 'remotes/stsquad/tags/pull-testing-and-misc-updates-250521-2' into staging
> (2021-05-25 17:31:04 +0100)
>
> are available
This change provides a qtest that locates and then does a simple
interrogation of the ERST feature within the guest.
Signed-off-by: Eric DeVolder
---
tests/qtest/erst-test.c | 106
tests/qtest/meson.build | 2 +
2 files changed, 108 insertions(+
On 5/28/2021 7:34 AM, Kunkun Jiang wrote:
Hi Philippe,
On 2021/5/27 21:44, Philippe Mathieu-Daudé wrote:
On 5/27/21 2:31 PM, Kunkun Jiang wrote:
In the vfio_migration_init(), the SaveVMHandler is registered for
VFIO device. But it lacks the operation of 'unregister'. It will
lead to 'Segmen
Reviewed: https://review.opendev.org/c/openstack/nova/+/793219
Committed:
https://opendev.org/openstack/nova/commit/d5ed968826895d362f4f2aa21decfdebb9b1fd84
Submitter: "Zuul (22348)"
Branch:master
commit d5ed968826895d362f4f2aa21decfdebb9b1fd84
Author: Lee Yarwood
Date: Wed May 26 19:27:4
I apologize for the delay, here are the repro steps:
1. Remove CONFIG_ARM_VIRT=y from arm-softmmu.mak
2. In .gitlab-ci.yml, crossbuild.yml and in tests/vm/Makefile.include, in
all the places where we disable kvm using -disable-kvm, replace this
with -enable-kvm
3. Build
You should see errors point
From: Richard Henderson
> More completely, update the CPU state with any information that has been
> assumed constant. For most guests, this is just the PC. But e.g. for hppa
> this is both iaoq.f (cip) and iaoq.b (nip).
>
> It is very much up to the guest to determine the set of data that is p
QEMU is failing to launch a CGS pSeries guest in a host that has PEF
support:
qemu-system-ppc64: ../softmmu/vl.c:2585: qemu_machine_creation_done: Assertion
`machine->cgs->ready' failed.
Aborted
This is happening because we're not setting the cgs->ready flag that is
asserted in qemu_machine_crea
sys.exit(os.EX_USAGE)
+qemu_valgrind = []
+if os.environ.get('VALGRIND_QEMU') == "y" and \
+ os.environ.get('NO_VALGRIND') != "y":
+ valgrind_logfile = "--log-file=" + test_dir.strip()
a bit strange that you need to strip test_dir here.. Why?
Yep, it's unnecessary
+VALGRIND
On 28/05/2021 19:16, Vladimir Sementsov-Ogievskiy wrote:
20.05.2021 10:52, Emanuele Giuseppe Esposito wrote:
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
docs/devel/testing.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a
+
imgfmt = os.environ.get('IMGFMT', 'raw')
imgproto = os.environ.get('IMGPROTO', 'file')
output_dir = os.environ.get('OUTPUT_DIR', '.')
@@ -614,6 +616,13 @@ def _post_shutdown(self) -> None:
super()._post_shutdown()
self.subprocess_check_valgrind(qemu_valgrind)
+ de
On Fri, May 28, 2021 at 05:16:19PM -0300, Daniel Henrique Barboza wrote:
> QEMU is failing to launch a CGS pSeries guest in a host that has PEF
> support:
>
> qemu-system-ppc64: ../softmmu/vl.c:2585: qemu_machine_creation_done:
> Assertion `machine->cgs->ready' failed.
> Aborted
>
> This is happ
This patchset takes the original patch from Maxim,
https://www.mail-archive.com/qemu-devel@nongnu.org/msg569573.html
and updates it.
Option hostfwd is extended to support ipv6 addresses.
Commands hostfwd_add, hostfwd_remove are extended as well.
Changes from v6:
1/4: Update to use libslirp v4.5.
The parsing is moved into new function inet_parse_host_port.
Also split out is ipv4=flag, ipv6=flag processing into inet_parse_ipv46.
This is done in preparation for using these functions in net/slirp.c.
Signed-off-by: Doug Evans
Reviewed-by: Marc-André Lureau
---
Changes from v6:
No changes.
... in preparation for adding ipv6 host forwarding support.
Tested:
avocado run tests/acceptance/hostfwd.py
Signed-off-by: Doug Evans
---
Changes from v6:
Add support for --enable-slirp=system
Tested with system libslirp 4.4.0.
Changes from v5:
Use InetSocketAddress and getaddrinfo().
Use ne
5eraph (2):
disable_dns option
limit vnameserver_addr to port 53
Akihiro Suda (1):
libslirp.h: fix SlirpConfig v3 documentation
Doug Evans (11):
Add ipv6 host forward support
tcpx_listen: Pass sizeof(addr) to memset
Reject host forwarding to ipv6 "addr-any"
Net option "-hostfwd" now supports IPv6 addresses.
Commands hostfwd_add, hostfwd_remove now support IPv6 addresses.
Tested:
avocado run tests/acceptance/hostfwd.py
Signed-off-by: Doug Evans
---
Changes from v6:
No changes.
Changes from v5:
Recognize ipv4=,ipv6= options.
hmp-commands.hx
On Thu, May 27, 2021 at 08:01:56AM +0200, Greg Kurz wrote:
> On Wed, 26 May 2021 17:21:01 -0300
> "Bruno Larsen (billionai)" wrote:
>
> > This function requires surce code modification to be useful, which means
>
> s/surce/source
>
> > it probably is not used often, and the move to using decode
On Fri, May 28, 2021 at 05:16:19PM -0300, Daniel Henrique Barboza wrote:
> QEMU is failing to launch a CGS pSeries guest in a host that has PEF
> support:
>
> qemu-system-ppc64: ../softmmu/vl.c:2585: qemu_machine_creation_done:
> Assertion `machine->cgs->ready' failed.
> Aborted
>
> This is happ
On Thu, May 27, 2021 at 04:01:52PM +0200, Greg Kurz wrote:
> On Thu, 27 May 2021 10:22:50 -0300
> Bruno Piazera Larsen wrote:
>
> >
> > On 27/05/2021 01:35, David Gibson wrote:
> > > On Thu, May 27, 2021 at 11:20:01AM +1000, David Gibson wrote:
> > >> On Wed, May 26, 2021 at 05:21:01PM -0300, Br
77 matches
Mail list logo
