Re: [PATCH 2/5] target/ppc: remove ppc_cpu_dump_statistics

2021-05-27 Thread David Gibson
On Thu, May 27, 2021 at 11:20:01AM +1000, David Gibson wrote: > On Wed, May 26, 2021 at 05:21:01PM -0300, Bruno Larsen (billionai) wrote: > > This function requires surce code modification to be useful, which means > > it probably is not used often, and the move to using decodetree means > > the st

Re: [PATCH v5 1/4] target/ppc: used ternary operator when registering MAS

2021-05-27 Thread David Gibson
On Tue, May 25, 2021 at 08:53:52AM -0300, Bruno Larsen (billionai) wrote: > The write calback decision when registering the MAS SPR has been turned > into a ternary operation, rather than an if-then-else block. > > This was done because when building without TCG, even though the > compiler will op

Re: [PATCH 4/5] monitor: removed cpustats command

2021-05-27 Thread David Gibson
On Wed, May 26, 2021 at 02:28:48PM -0700, Richard Henderson wrote: > On 5/26/21 1:21 PM, Bruno Larsen (billionai) wrote: > > Since ppc was the last architecture to collect these statistics and > > it is currently phasing this collection out, the command that would query > > this information is bein

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

2021-05-27 Thread David Gibson
On Tue, May 25, 2021 at 11:55:43AM +0200, BALATON Zoltan wrote: > On Tue, 25 May 2021, David Gibson wrote: > > On Mon, May 24, 2021 at 02:42:30PM +0200, BALATON Zoltan wrote: > > > On Mon, 24 May 2021, David Gibson wrote: > > > > On Sun, May 23, 2021 at 07:09:26PM +0200, BALATON Zoltan wrote: > > >

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

2021-05-27 Thread David Gibson
On Tue, May 25, 2021 at 12:08:45PM +0200, BALATON Zoltan wrote: > On Tue, 25 May 2021, David Gibson wrote: > > On Mon, May 24, 2021 at 12:55:07PM +0200, BALATON Zoltan wrote: > > > On Mon, 24 May 2021, David Gibson wrote: > > > > On Sun, May 23, 2021 at 07:09:26PM +0200, BALATON Zoltan wrote: > > >

Re: [PATCH v5 4/4] target/ppc: updated meson.build to support disable-tcg

2021-05-27 Thread David Gibson
On Tue, May 25, 2021 at 08:53:55AM -0300, Bruno Larsen (billionai) wrote: > updated build file to not compile some sources that are unnecessary if > TCG is disabled on the system. > > Signed-off-by: Bruno Larsen (billionai) > Applied to ppc-for-6.1, thanks. > --- > target/ppc/meson.build | 7 +

Re: [PATCH v5 3/4] target/ppc: created tcg-stub.c file

2021-05-27 Thread David Gibson
On Tue, May 25, 2021 at 08:53:54AM -0300, Bruno Larsen (billionai) wrote: > Created a file with stubs needed to compile disabling TCG. *_ppc_opcodes > were created to make cpu_init.c have a few less ifdefs, since they are > not needed. softmmu_resize_hpt_* have to be created because the compiler >

Re: [PATCH] spapr: propagate LPCR to hot-plugged CPUs

2021-05-27 Thread David Gibson
On Mon, May 24, 2021 at 01:41:32PM +0200, Cédric Le Goater wrote: > Distros have started using the 'scv' instructions (glibc 2.33) which > relies on the LPCR AIL bits. Unfortunately, the LPCR of hot-plugged > CPUs is not synchronized with the rest of machine and it breaks the > guest OS. > > Fix t

Re: [PULL 19/19] gitlab: Split gprof-gcov job

2021-05-27 Thread Philippe Mathieu-Daudé
On 5/26/21 11:18 PM, Philippe Mathieu-Daudé wrote: > This job is hitting the 70min limit, so split it in 2 tasks. > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Willian Rampazzo > Message-Id: <20210525082556.4011380-7-f4...@amsat.org> > --- > .gitlab-ci.d/buildtest.yml | 17 ++

Re: [PATCH v5 2/4] target/ppc: added ifdefs around TCG-only code

2021-05-27 Thread David Gibson
On Wed, May 26, 2021 at 02:24:32PM -0300, Bruno Piazera Larsen wrote: > > On 25/05/2021 10:02, Philippe Mathieu-Daudé wrote: > > On 5/25/21 1:53 PM, Bruno Larsen (billionai) wrote: > > > excp_helper.c, mmu-hash64.c and mmu_helper.c have some function > > > declarations that are TCG-only, and could

Re: [PATCH 3/5] target/ppc: removed mentions to DO_PPC_STATISTICS

2021-05-27 Thread David Gibson
On Wed, May 26, 2021 at 05:21:02PM -0300, Bruno Larsen (billionai) wrote: > Removed the commented out definition and all ifdefs relating to > PPC_DUMP_STATISTICS, as it's hardly ever used. > > Suggested-by: Richard Henderson > Signed-off-by: Bruno Larsen (billionai) > Applied to ppc-for-6.1, th

Re: [PULL V2 0/3] Net patches

2021-05-27 Thread Jason Wang
在 2021/5/27 下午3:14, Bin Meng 写道: On Thu, May 27, 2021 at 2:35 PM Jason Wang wrote: 在 2021/5/27 下午2:13, Bin Meng 写道: Hi Jason, On Thu, May 27, 2021 at 12:24 PM Jason Wang wrote: The following changes since commit d90f154867ec0ec22fd719164b88716e8fd48672: Merge remote-tracking branch

Re: [PULL V2 0/3] Net patches

2021-05-27 Thread Bin Meng
On Thu, May 27, 2021 at 2:35 PM Jason Wang wrote: > > > 在 2021/5/27 下午2:13, Bin Meng 写道: > > Hi Jason, > > > > On Thu, May 27, 2021 at 12:24 PM Jason Wang wrote: > >> The following changes since commit > >> d90f154867ec0ec22fd719164b88716e8fd48672: > >> > >>Merge remote-tracking branch > >>

Re: [PATCH v6 10/19] i386: move eVMCS enablement to hyperv_init_vcpu()

2021-05-27 Thread Vitaly Kuznetsov
Eduardo Habkost writes: > On Mon, May 24, 2021 at 02:00:37PM +0200, Vitaly Kuznetsov wrote: > [...] >> >> @@ -1455,6 +1454,21 @@ static int hyperv_init_vcpu(X86CPU *cpu) >> >> } >> >> } >> >> >> >> +if (hyperv_feat_enabled(cpu, HYPERV_FEAT_EVMCS)) { >> >> +uint16_t evm

Re: [PATCH v6 15/19] i386: expand Hyper-V features during CPU feature expansion time

2021-05-27 Thread Vitaly Kuznetsov
Eduardo Habkost writes: > On Mon, May 24, 2021 at 02:13:09PM +0200, Vitaly Kuznetsov wrote: > [...] >> >> diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c >> >> index a42263b24fca..d5551c4ab5cf 100644 >> >> --- a/target/i386/kvm/kvm.c >> >> +++ b/target/i386/kvm/kvm.c >> >> @@ -1216,13

Re: [PATCH v6 17/19] i386: HV_HYPERCALL_AVAILABLE privilege bit is always needed

2021-05-27 Thread Vitaly Kuznetsov
Eduardo Habkost writes: > On Mon, May 24, 2021 at 02:22:47PM +0200, Vitaly Kuznetsov wrote: >> Eduardo Habkost writes: >> >> > On Thu, Apr 22, 2021 at 06:11:28PM +0200, Vitaly Kuznetsov wrote: >> >> According to TLFS, Hyper-V guest is supposed to check >> >> HV_HYPERCALL_AVAILABLE privilege bit

Re: [PATCH v6 00/19] i386: KVM: expand Hyper-V features early

2021-05-27 Thread Vitaly Kuznetsov
Eduardo Habkost writes: > On Thu, Apr 22, 2021 at 06:11:11PM +0200, Vitaly Kuznetsov wrote: >> Vitaly Kuznetsov (19): >> i386: keep hyperv_vendor string up-to-date >> i386: invert hyperv_spinlock_attempts setting logic with >> hv_passthrough >> i386: always fill Hyper-V CPUID feature le

Re: [PATCH v12 7/8] KVM: arm64: ioctl to fetch/store tags in a guest

2021-05-27 Thread Steven Price
On 24/05/2021 19:11, Catalin Marinas wrote: > On Fri, May 21, 2021 at 10:42:09AM +0100, Steven Price wrote: >> On 20/05/2021 18:27, Catalin Marinas wrote: >>> On Thu, May 20, 2021 at 04:58:01PM +0100, Steven Price wrote: On 20/05/2021 13:05, Catalin Marinas wrote: > On Mon, May 17, 2021 at

[Bug 1879672] Re: QEMU installer with WHPX support

2021-05-27 Thread Philippe Mathieu-Daudé
But looking at the latest pipeline: https://gitlab.com/qemu-project/qemu/-/pipelines/310113928 in particular the cross-win64-system job: https://gitlab.com/qemu-project/qemu/-/jobs/1296341064 WHPX isn't built anymore: Targets and accelerators KVM support: NO

Re: Windows fails to boot after rebase to QEMU master

2021-05-27 Thread Claudio Fontana
On 5/26/21 9:30 PM, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: >> On Fri, May 21, 2021 at 11:17:19AM +0200, Siddharth Chandrasekaran wrote: >>> After a rebase to QEMU master, I am having trouble booting windows VMs. >>> Git bisect indicates commit f5cc5a5c1686 ("i

Re: [PATCH 4/5] monitor: removed cpustats command

2021-05-27 Thread Dr. David Alan Gilbert
* Bruno Larsen (billionai) (bruno.lar...@eldorado.org.br) wrote: > Since ppc was the last architecture to collect these statistics and > it is currently phasing this collection out, the command that would query > this information is being removed. > > Suggested-by: Richard Henderson > Signed-off-

Re: [PATCH 4/5] monitor: removed cpustats command

2021-05-27 Thread Dr. David Alan Gilbert
* Greg Kurz (gr...@kaod.org) wrote: > On Wed, 26 May 2021 17:21:03 -0300 > "Bruno Larsen (billionai)" wrote: > > > Since ppc was the last architecture to collect these statistics and > > it is currently phasing this collection out, the command that would query > > this information is being remove

Re: [PATCH 4/5] monitor: removed cpustats command

2021-05-27 Thread Greg Kurz
On Thu, 27 May 2021 09:09:55 +0100 "Dr. David Alan Gilbert" wrote: > * Greg Kurz (gr...@kaod.org) wrote: > > On Wed, 26 May 2021 17:21:03 -0300 > > "Bruno Larsen (billionai)" wrote: > > > > > Since ppc was the last architecture to collect these statistics and > > > it is currently phasing this

[Bug 1929710] Re: virDomainGetBlockJobInfo fails during swap_volume as disk '$disk' not found in domain

2021-05-27 Thread Lee Yarwood
I've added the QEMU project directly to this bug to see if anyone can help us understand what the underlying block job failure is within QEMU and why it then appears to remove the entire device from the instance causing libvirt and Nova to fallover. ** Description changed: Description ===

Re: Windows fails to boot after rebase to QEMU master

2021-05-27 Thread Dr. David Alan Gilbert
* Claudio Fontana (cfont...@suse.de) wrote: > On 5/26/21 9:30 PM, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > >> On Fri, May 21, 2021 at 11:17:19AM +0200, Siddharth Chandrasekaran wrote: > >>> After a rebase to QEMU master, I am having trouble booting windows V

Re: [PATCH v3] target/riscv: fix VS interrupts forwarding to HS

2021-05-27 Thread LIU Zhiwei
On 5/26/21 7:50 PM, Jose Martins wrote: Hello Zhiwei, thank you for reviewing the patch. I'll split the patch in a series as you suggest. But first can you help me understand what the problems are with riscv_cpu_local_irq_pending? I think there are two errors in riscv_cpu_local_irq_pending.

Re: [PATCH 1/1] yank: Unregister function when using TLS migration

2021-05-27 Thread Daniel P . Berrangé
On Wed, May 26, 2021 at 05:58:58PM -0400, Peter Xu wrote: > On Wed, May 26, 2021 at 11:21:03PM +0200, Lukas Straub wrote: > > On Wed, 26 May 2021 16:40:35 -0400 > > Peter Xu wrote: > > > > > On Wed, May 26, 2021 at 05:05:40PM -0300, Leonardo Bras wrote: > > > > After yank feature was introduced,

[PATCH 1/1] target/riscv: Fix vsip vsie CSR ops in M and HS mode

2021-05-27 Thread LIU Zhiwei
When V=1, instructions that normally read or modify a supervisor CSR shall instead access the corresponding VS CSR. And the VS CSRs can be accessed as themselves from M-mode or HS-mode. In M and HS mode, VSIP or VSIE should be written normally instead of shift by 1. Signed-off-by: LIU Zhiwei ---

Re: Windows fails to boot after rebase to QEMU master

2021-05-27 Thread Philippe Mathieu-Daudé
On 5/27/21 10:31 AM, Dr. David Alan Gilbert wrote: > * Claudio Fontana (cfont...@suse.de) wrote: >> On 5/26/21 9:30 PM, Dr. David Alan Gilbert wrote: >>> * Michael S. Tsirkin (m...@redhat.com) wrote: On Fri, May 21, 2021 at 11:17:19AM +0200, Siddharth Chandrasekaran wrote: > After a rebase

Re: [PATCH v3 1/3] hw/arm/boot: Abort if set_kernel_args() fails

2021-05-27 Thread Peter Maydell
On Thu, 20 May 2021 at 06:15, Philippe Mathieu-Daudé wrote: > > If a address_space_write() call fails while calling > set_kernel_args(), the guest kernel will boot using > crap data. Avoid that by aborting if this ever occurs. > > Signed-off-by: Philippe Mathieu-Daudé > @@ -786,10 +811,16 @@ sta

Re: [PATCH v3 3/3] hw/core/loader: Warn if we fail to load ROM regions at reset

2021-05-27 Thread Peter Maydell
On Thu, 20 May 2021 at 06:15, Philippe Mathieu-Daudé wrote: > > If the user provides an ELF file that's been linked to a wrong > address, we try to load it, fails, and keep going silently. > Instead, > Display a warning instead, but keep going to not disrupt users > accidentally relying on this 'c

Re: Windows fails to boot after rebase to QEMU master

2021-05-27 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > On 5/27/21 10:31 AM, Dr. David Alan Gilbert wrote: > > * Claudio Fontana (cfont...@suse.de) wrote: > >> On 5/26/21 9:30 PM, Dr. David Alan Gilbert wrote: > >>> * Michael S. Tsirkin (m...@redhat.com) wrote: > On Fri, May 21, 2021 at 11:17:19

Re: [PATCH 1/3] hw/usb/Kconfig: Introduce USB_CHIPIDEA symbol

2021-05-27 Thread Peter Maydell
On Wed, 19 May 2021 at 21:09, Philippe Mathieu-Daudé wrote: > > Currently the TYPE_CHIPIDEA model is only built when the IMX > machines are built. Since it is not specific to IMX, add its > symbol to allow other machines to use it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/Kconfig

Re: [PATCH 2/3] hw/arm/Kconfig: Add missing dependency ZYNQ -> USB_CHIPIDEA

2021-05-27 Thread Peter Maydell
On Wed, 19 May 2021 at 21:09, Philippe Mathieu-Daudé wrote: > > When using a binary built using --without-default-devices we get: > > $ qemu-system-arm -M xilinx-zynq-a9 > ** > ERROR:qom/object.c:714:object_new_with_type: assertion failed: (type != > NULL) > Bail out! ERROR:qom/object.c:7

Re: [PATCH 3/3] hw/arm/Kconfig: Add missing dependency IMX_USBPHY -> FSL_IMX6UL

2021-05-27 Thread Peter Maydell
On Wed, 19 May 2021 at 21:10, Philippe Mathieu-Daudé wrote: > > We added IMX_USBPHY in commit 0701a5efa01 ("hw/usb: Add basic i.MX > USB Phy support") and had the FSL_IMX6 machine select it, however > this machine did not use the IMX_USBPHY until commit 49cd55789bb > ("hw/arm/fsl-imx6: Wire up USB

Re: [PATCH 1/2] hw/arm: add quanta-gbs-bmc machine

2021-05-27 Thread Peter Maydell
On Tue, 18 May 2021 at 20:54, Patrick Venture wrote: > > Adds initial quanta-gbs-bmc machine support. > > Tested: Boots to userspace. > Signed-off-by: Patrick Venture > Reviewed-by: Brandon Kim > Reviewed-by: Hao Wu > --- > hw/arm/npcm7xx_boards.c | 33 + > 1 fi

Re: Windows fails to boot after rebase to QEMU master

2021-05-27 Thread Claudio Fontana
On 5/27/21 11:15 AM, Dr. David Alan Gilbert wrote: > * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: >> On 5/27/21 10:31 AM, Dr. David Alan Gilbert wrote: >>> * Claudio Fontana (cfont...@suse.de) wrote: On 5/26/21 9:30 PM, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redh

[PATCH] arm: Consistently use "Cortex-Axx", not "Cortex Axx"

2021-05-27 Thread Peter Maydell
The official punctuation for Arm CPU names uses a hyphen, like "Cortex-A9". We mostly follow this, but in a few places usage without the hyphen has crept in. Fix those so we consistently use the same way of writing the CPU name. This commit was created with: git grep -z -l 'Cortex ' | xargs -0 s

Re: [PATCH] arm: Consistently use "Cortex-Axx", not "Cortex Axx"

2021-05-27 Thread Philippe Mathieu-Daudé
On 5/27/21 11:51 AM, Peter Maydell wrote: > The official punctuation for Arm CPU names uses a hyphen, like > "Cortex-A9". We mostly follow this, but in a few places usage > without the hyphen has crept in. Fix those so we consistently > use the same way of writing the CPU name. > > This commit was

Re: [PATCH v8 01/19] hvf: Move assert_hvf_ok() into common directory

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:35PM +0200, Alexander Graf wrote: > Until now, Hypervisor.framework has only been available on x86_64 systems. > With Apple Silicon shipping now, it extends its reach to aarch64. To > prepare for support for multiple architectures, let's start moving common > code out

Re: [PATCH v8 04/19] hvf: Move hvf internal definitions into common header

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:38PM +0200, Alexander Graf wrote: > Until now, Hypervisor.framework has only been available on x86_64 systems. > With Apple Silicon shipping now, it extends its reach to aarch64. To > prepare for support for multiple architectures, let's start moving common > code out

Re: [PATCH v8 05/19] hvf: Make hvf_set_phys_mem() static

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:39PM +0200, Alexander Graf wrote: > The hvf_set_phys_mem() function is only called within the same file. > Make it static. > > Signed-off-by: Alexander Graf > --- > accel/hvf/hvf-accel-ops.c | 2 +- > include/sysemu/hvf_int.h | 1 - > 2 files changed, 1 insertion(+

Re: [PATCH v8 02/19] hvf: Move vcpu thread functions into common directory

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:36PM +0200, Alexander Graf wrote: > Until now, Hypervisor.framework has only been available on x86_64 systems. > With Apple Silicon shipping now, it extends its reach to aarch64. To > prepare for support for multiple architectures, let's start moving common > code out

Re: [PATCH v8 07/19] hvf: Split out common code on vcpu init and destroy

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:41PM +0200, Alexander Graf wrote: > Until now, Hypervisor.framework has only been available on x86_64 systems. > With Apple Silicon shipping now, it extends its reach to aarch64. To > prepare for support for multiple architectures, let's start moving common > code out

Re: [PATCH v8 10/19] hvf: Remove hvf-accel-ops.h

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:44PM +0200, Alexander Graf wrote: > We can move the definition of hvf_vcpu_exec() into our internal > hvf header, obsoleting the need for hvf-accel-ops.h. > > Signed-off-by: Alexander Graf > --- > accel/hvf/hvf-accel-ops.c | 2 -- > accel/hvf/hvf-accel-ops.h | 17 -

Re: [PATCH v8 06/19] hvf: Remove use of hv_uvaddr_t and hv_gpaddr_t

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:40PM +0200, Alexander Graf wrote: > The ARM version of Hypervisor.framework no longer defines these two > types, so let's just revert to standard ones. > > Signed-off-by: Alexander Graf > --- > accel/hvf/hvf-accel-ops.c | 6 +++--- > 1 file changed, 3 insertions(+),

Re: [PATCH v8 03/19] hvf: Move cpu functions into common directory

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:37PM +0200, Alexander Graf wrote: > Until now, Hypervisor.framework has only been available on x86_64 systems. > With Apple Silicon shipping now, it extends its reach to aarch64. To > prepare for support for multiple architectures, let's start moving common > code out

Re: [PATCH v8 09/19] hvf: Make synchronize functions static

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:43PM +0200, Alexander Graf wrote: > The hvf accel synchronize functions are only used as input for local > callback functions, so we can make them static. > > Signed-off-by: Alexander Graf > --- > accel/hvf/hvf-accel-ops.c | 6 +++--- > accel/hvf/hvf-accel-ops.h | 3

Re: [PATCH v8 11/19] hvf: Introduce hvf vcpu struct

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:45PM +0200, Alexander Graf wrote: > We will need more than a single field for hvf going forward. To keep > the global vcpu struct uncluttered, let's allocate a special hvf vcpu > struct, similar to how hax does it. > > Signed-off-by: Alexander Graf > Reviewed-by: Rom

Re: [PATCH 0/2] vvfat: fix two crashes.

2021-05-27 Thread Kevin Wolf
Am 24.05.2021 um 12:12 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi! > > As reported by Programmingkid, command > > qemu-system-ppc -usb -device usb-storage,drive=fat16 -drive > file=fat:rw:fat-type=16:"",id=fat16,format=raw,if=none > > crashes. > > I tested it with qemu-system-x86_64 a

Re: [PATCH v8 08/19] hvf: Use cpu_synchronize_state()

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:42PM +0200, Alexander Graf wrote: > There is no reason to call the hvf specific hvf_cpu_synchronize_state() > when we can just use the generic cpu_synchronize_state() instead. This > allows us to have less dependency on internal function definitions and > allows us to

Re: [PATCH] linux-user: make process_pending_signals thread-safe

2021-05-27 Thread Hamza Mahfooz
On Thu, May 27 2021 at 11:16:56 AM +0100, Peter Maydell wrote: If we do want to change from sigprocmask() to pthread_sigmask(), we should be consistent about doing that, not just change this call only.) On that note, do you think it would worthwhile to have a Coccinelle script replace all

Re: [PATCH] linux-user: make process_pending_signals thread-safe

2021-05-27 Thread Peter Maydell
On Mon, 24 May 2021 at 03:48, Hamza Mahfooz wrote: > > Use pthread_sigmask instead of sigprocmask inside process_pending_signals > to ensure that race conditions aren't possible. > > Signed-off-by: Hamza Mahfooz > --- > linux-user/signal.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-

Re: [PATCH] linux-user: make process_pending_signals thread-safe

2021-05-27 Thread Peter Maydell
On Thu, 27 May 2021 at 11:37, Hamza Mahfooz wrote: > > > > On Thu, May 27 2021 at 11:16:56 AM +0100, Peter Maydell > wrote: > > If we do want to change from sigprocmask() to pthread_sigmask(), we > > should be consistent about doing that, not just change this call > > only.) > On that note, do yo

Re: [PATCH v8 12/19] hvf: Simplify post reset/init/loadvm hooks

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:46PM +0200, Alexander Graf wrote: > The hooks we have that call us after reset, init and loadvm really all > just want to say "The reference of all register state is in the QEMU > vcpu struct, please push it". > > We already have a working pushing mechanism though cal

Re: [PATCH v8 13/19] hvf: Add Apple Silicon support

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:47PM +0200, Alexander Graf wrote: > With Apple Silicon available to the masses, it's a good time to add support > for driving its virtualization extensions from QEMU. > > This patch adds all necessary architecture specific code to get basic VMs > working. It's still p

[Bug 1846816] Re: Booting error on AIX 6.1 "Illegal Trap Instruction Interrupt in Kernel""

2021-05-27 Thread David
Hello, I just wanted to confirm that this bug also affects me and that it also appears in qemu 6.0.0. When I try to boot up AIX 7.1 (and 6.1 as well), it prints the following line multiple times during boot: Unimplemented SPAPR hcall 0x02b8 followed by crash: Illegal Trap Instructio

Re: [PATCH v4 04/15] qemu-iotests: add option to attach gdbserver

2021-05-27 Thread Emanuele Giuseppe Esposito
On 26/05/2021 21:15, Vladimir Sementsov-Ogievskiy wrote: 20.05.2021 10:52, Emanuele Giuseppe Esposito wrote: Define -gdb flag and GDB_OPTIONS environment variable to python tests to attach a gdbserver to each qemu instance. This patch only adds and parses this flag, it does not yet add the im

Re: [PATCH v8 15/19] hvf: arm: Implement -cpu host

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:49PM +0200, Alexander Graf wrote: > Now that we have working system register sync, we push more target CPU > properties into the virtual machine. That might be useful in some > situations, but is not the typical case that users want. > > So let's add a -cpu host optio

Re: [PATCH v8 14/19] arm/hvf: Add a WFI handler

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:48PM +0200, Alexander Graf wrote: > From: Peter Collingbourne > > Sleep on WFI until the VTIMER is due but allow ourselves to be woken > up on IPI. > > In this implementation IPI is blocked on the CPU thread at startup and > pselect() is used to atomically unblock t

[Bug 1846816] Re: Booting error on AIX 6.1 "Illegal Trap Instruction Interrupt in Kernel""

2021-05-27 Thread Thomas Huth
** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1846816 Title: Booting error on AIX 6.1 "Illegal Trap Instruction Interrupt in Kernel"" Status

Re: [PATCH v8 17/19] arm: Add Hypervisor.framework build target

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:51PM +0200, Alexander Graf wrote: > Now that we have all logic in place that we need to handle > Hypervisor.framework > on Apple Silicon systems, let's add CONFIG_HVF for aarch64 as well so that we > can build it. > > Signed-off-by: Alexander Graf > Reviewed-by: Rom

Re: Windows fails to boot after rebase to QEMU master

2021-05-27 Thread Claudio Fontana
On 5/27/21 11:48 AM, Claudio Fontana wrote: > On 5/27/21 11:15 AM, Dr. David Alan Gilbert wrote: >> * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: >>> On 5/27/21 10:31 AM, Dr. David Alan Gilbert wrote: * Claudio Fontana (cfont...@suse.de) wrote: > On 5/26/21 9:30 PM, Dr. David Alan Gi

Re: Windows fails to boot after rebase to QEMU master

2021-05-27 Thread Claudio Fontana
On 5/27/21 12:53 PM, Claudio Fontana wrote: > On 5/27/21 11:48 AM, Claudio Fontana wrote: >> On 5/27/21 11:15 AM, Dr. David Alan Gilbert wrote: >>> * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: On 5/27/21 10:31 AM, Dr. David Alan Gilbert wrote: > * Claudio Fontana (cfont...@suse.de)

Re: [PATCH v8 19/19] hvf: arm: Handle Windows 10 SMC call

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:53PM +0200, Alexander Graf wrote: > Windows 10 calls an SMCCC call via SMC unconditionally on boot. It lives > in the trusted application call number space, but its purpose is unknown. > > In our current SMC implementation, we inject a UDEF for unknown SMC calls, > in

Re: [PATCH v8 16/19] hvf: arm: Implement PSCI handling

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:50PM +0200, Alexander Graf wrote: > We need to handle PSCI calls. Most of the TCG code works for us, > but we can simplify it to only handle aa64 mode and we need to > handle SUSPEND differently. > > This patch takes the TCG code as template and duplicates it in HVF.

Re: Windows fails to boot after rebase to QEMU master

2021-05-27 Thread Siddharth Chandrasekaran
On Thu, May 27, 2021 at 01:36:37PM +0200, Claudio Fontana wrote: > Just to check whether this is actually the issue we are talking about, > Sid et al, could you try this? > > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index c496bfa1c2..810c46281b 100644 > --- a/target/i386/cpu.c > +++

Re: [PATCH] linux-user: make process_pending_signals thread-safe

2021-05-27 Thread Hamza Mahfooz
On Thu, May 27 2021 at 11:45:26 AM +0100, Peter Maydell wrote: What issue are we trying to fix by making this change ? I suppose that it wouldn't fix any issues in the current state of affairs, maybe it is something to reconsider if glibc ever changes such that, sigprocmask is no longer MT

Re: [PATCH v8 18/19] arm: Enable Windows 10 trusted SMCCC boot call

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:52PM +0200, Alexander Graf wrote: > Windows 10 calls an SMCCC call via SMC unconditionally on boot. It lives > in the trusted application call number space, but its purpose is unknown. > > In our current SMC implementation, we inject a UDEF for unknown SMC calls, > in

[Bug 1846816] Re: Booting error on AIX 6.1 "Illegal Trap Instruction Interrupt in Kernel""

2021-05-27 Thread Greg Kurz
The only AIX version that _might_ run with QEMU is 7.2. Older ones don't have virtio AFAIK. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1846816 Title: Booting error on AIX 6.1 "Illegal Trap Instr

Re: [PATCH 4/5] monitor: removed cpustats command

2021-05-27 Thread Bruno Piazera Larsen
On 27/05/2021 05:30, Greg Kurz wrote: On Thu, 27 May 2021 09:09:55 +0100 "Dr. David Alan Gilbert" wrote: * Greg Kurz (gr...@kaod.org) wrote: On Wed, 26 May 2021 17:21:03 -0300 "Bruno Larsen (billionai)" wrote: Since ppc was the last architecture to collect these statistics and it is curre

Re: [PATCH v2 4/7] block-copy: add a CoMutex to the BlockCopyTask list

2021-05-27 Thread Stefan Hajnoczi
On Tue, May 18, 2021 at 12:07:54PM +0200, Emanuele Giuseppe Esposito wrote: > -static BlockCopyTask *find_conflicting_task(BlockCopyState *s, > -int64_t offset, int64_t bytes) > +/* Called with lock held */ s/lock/tasks_lock/ signature.asc Description:

Re: [PATCH v2 1/7] block-copy: streamline choice of copy_range vs. read/write

2021-05-27 Thread Stefan Hajnoczi
On Tue, May 18, 2021 at 12:07:51PM +0200, Emanuele Giuseppe Esposito wrote: > } else { > /* > * We enable copy-range, but keep small copy_size, until first > * successful copy_range (look at block_copy_do_copy). > */ Is this comment still correct? It app

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

2021-05-27 Thread BALATON Zoltan
On Thu, 27 May 2021, David Gibson wrote: On Tue, May 25, 2021 at 12:08:45PM +0200, BALATON Zoltan wrote: On Tue, 25 May 2021, David Gibson wrote: On Mon, May 24, 2021 at 12:55:07PM +0200, BALATON Zoltan wrote: On Mon, 24 May 2021, David Gibson wrote: On Sun, May 23, 2021 at 07:09:26PM +0200,

[PATCH] vfio: Fix unregister SaveVMHandler in vfio_migration_finalize

2021-05-27 Thread Kunkun Jiang
In the vfio_migration_init(), the SaveVMHandler is registered for VFIO device. But it lacks the operation of 'unregister'. It will lead to 'Segmentation fault (core dumped)' in qemu_savevm_state_setup(), if performing live migration after a VFIO device is hot deleted. Fixes: 7c2f5f75f94 (vfio: Reg

Re: [PATCH v2 0/7] block-copy: protect block-copy internal structures

2021-05-27 Thread Stefan Hajnoczi
On Tue, May 18, 2021 at 12:07:50PM +0200, Emanuele Giuseppe Esposito wrote: > This serie of patches aims to reduce the usage of the global > AioContexlock in block-copy, by introducing smaller granularity > locks thus on making the block layer thread safe. > > This serie depends on Paolo's corout

Re: [PATCH 1/1] yank: Unregister function when using TLS migration

2021-05-27 Thread Daniel P . Berrangé
On Thu, May 27, 2021 at 08:23:52AM -0400, Peter Xu wrote: > On Thu, May 27, 2021 at 09:46:54AM +0100, Daniel P. Berrangé wrote: > > On Wed, May 26, 2021 at 05:58:58PM -0400, Peter Xu wrote: > > > On Wed, May 26, 2021 at 11:21:03PM +0200, Lukas Straub wrote: > > > > On Wed, 26 May 2021 16:40:35 -040

Re: [PATCH v4 04/15] qemu-iotests: add option to attach gdbserver

2021-05-27 Thread Vladimir Sementsov-Ogievskiy
27.05.2021 14:06, Emanuele Giuseppe Esposito wrote: On 26/05/2021 21:15, Vladimir Sementsov-Ogievskiy wrote: 20.05.2021 10:52, Emanuele Giuseppe Esposito wrote: Define -gdb flag and GDB_OPTIONS environment variable to python tests to attach a gdbserver to each qemu instance. This patch only a

Re: [PATCH v12 7/8] KVM: arm64: ioctl to fetch/store tags in a guest

2021-05-27 Thread Catalin Marinas
On Thu, May 27, 2021 at 08:50:30AM +0100, Steven Price wrote: > On 24/05/2021 19:11, Catalin Marinas wrote: > > I had some (random) thoughts on how to make things simpler, maybe. I > > think most of these races would have been solved if we required PROT_MTE > > in the VMM but this has an impact on

[Bug 1829682] Re: QEMU PPC SYSTEM regression - 3.1.0 and GIT - Fail to boot AIX

2021-05-27 Thread Thomas Huth
*** This bug is a duplicate of bug 1874264 *** https://bugs.launchpad.net/bugs/1874264 We already have a different ticket to track the AIX 7.2 issue here: https://gitlab.com/qemu-project/qemu/-/issues/269 Please continue with the discussion there instead, thanks! ** This bug has been marked

Re: [PATCH 1/1] yank: Unregister function when using TLS migration

2021-05-27 Thread Peter Xu
On Thu, May 27, 2021 at 09:46:54AM +0100, Daniel P. Berrangé wrote: > On Wed, May 26, 2021 at 05:58:58PM -0400, Peter Xu wrote: > > On Wed, May 26, 2021 at 11:21:03PM +0200, Lukas Straub wrote: > > > On Wed, 26 May 2021 16:40:35 -0400 > > > Peter Xu wrote: > > > > > > > On Wed, May 26, 2021 at 05

Re: [PATCH 6/9] gitlab-ci: Split gprof-gcov job

2021-05-27 Thread Alex Bennée
Thomas Huth writes: > On 25/05/2021 12.21, Philippe Mathieu-Daudé wrote: >> On 5/25/21 10:25 AM, Philippe Mathieu-Daudé wrote: >>> This job is hitting the 70min limit, so split it in 2 tasks. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> .gitlab-ci.d/buildtest.yml | 17 ++

[Bug 1846816] Re: Booting error on AIX 6.1 "Illegal Trap Instruction Interrupt in Kernel""

2021-05-27 Thread Thomas Huth
Ok, so closing this ticket since AIX older than 7.2 cannot work. For AIX >= 7.2, we already have a different ticket opened instead: https://gitlab.com/qemu-project/qemu/-/issues/269 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #269 https://gitlab.com/qemu-project/qemu/-/issues/269

Re: [PATCH 1/1] yank: Unregister function when using TLS migration

2021-05-27 Thread Peter Xu
On Thu, May 27, 2021 at 01:37:42PM +0100, Daniel P. Berrangé wrote: > On Thu, May 27, 2021 at 08:23:52AM -0400, Peter Xu wrote: > > On Thu, May 27, 2021 at 09:46:54AM +0100, Daniel P. Berrangé wrote: > > > On Wed, May 26, 2021 at 05:58:58PM -0400, Peter Xu wrote: > > > > On Wed, May 26, 2021 at 11:

Re: [PATCH 1/1] yank: Unregister function when using TLS migration

2021-05-27 Thread Daniel P . Berrangé
On Thu, May 27, 2021 at 09:09:09AM -0400, Peter Xu wrote: > On Thu, May 27, 2021 at 01:37:42PM +0100, Daniel P. Berrangé wrote: > > On Thu, May 27, 2021 at 08:23:52AM -0400, Peter Xu wrote: > > > On Thu, May 27, 2021 at 09:46:54AM +0100, Daniel P. Berrangé wrote: > > > > On Wed, May 26, 2021 at 05:

Re: Windows fails to boot after rebase to QEMU master

2021-05-27 Thread Dr. David Alan Gilbert
* Claudio Fontana (cfont...@suse.de) wrote: > On 5/27/21 12:53 PM, Claudio Fontana wrote: > > On 5/27/21 11:48 AM, Claudio Fontana wrote: > >> On 5/27/21 11:15 AM, Dr. David Alan Gilbert wrote: > >>> * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > On 5/27/21 10:31 AM, Dr. David Alan Gilb

Re: Windows fails to boot after rebase to QEMU master

2021-05-27 Thread Claudio Fontana
On 5/27/21 1:36 PM, Claudio Fontana wrote: > On 5/27/21 12:53 PM, Claudio Fontana wrote: >> On 5/27/21 11:48 AM, Claudio Fontana wrote: >>> On 5/27/21 11:15 AM, Dr. David Alan Gilbert wrote: * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > On 5/27/21 10:31 AM, Dr. David Alan Gilbert w

Re: [PATCH 1/1] yank: Unregister function when using TLS migration

2021-05-27 Thread Peter Xu
On Thu, May 27, 2021 at 02:17:55PM +0100, Daniel P. Berrangé wrote: > On Thu, May 27, 2021 at 09:09:09AM -0400, Peter Xu wrote: > > On Thu, May 27, 2021 at 01:37:42PM +0100, Daniel P. Berrangé wrote: > > > On Thu, May 27, 2021 at 08:23:52AM -0400, Peter Xu wrote: > > > > On Thu, May 27, 2021 at 09:

Re: [PATCH 2/5] target/ppc: remove ppc_cpu_dump_statistics

2021-05-27 Thread Bruno Piazera Larsen
On 27/05/2021 01:35, David Gibson wrote: On Thu, May 27, 2021 at 11:20:01AM +1000, David Gibson wrote: On Wed, May 26, 2021 at 05:21:01PM -0300, Bruno Larsen (billionai) wrote: This function requires surce code modification to be useful, which means it probably is not used often, and the move

Re: [PATCH 0/5] linux-user changes to run docker

2021-05-27 Thread Alex Bennée
Takashi Yamamoto writes: > On Tue, May 25, 2021 at 8:22 AM Takashi Yamamoto > wrote: >> >> On Tue, May 25, 2021 at 2:49 AM Alex Bennée wrote: >> > >> > >> > YAMAMOTO Takashi writes: >> > >> > > These patches, along with a few more hacks [1] I didn't include >> > > in this patchset, allowed

Re: [PATCH 1/1] yank: Unregister function when using TLS migration

2021-05-27 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, May 27, 2021 at 09:09:09AM -0400, Peter Xu wrote: > > On Thu, May 27, 2021 at 01:37:42PM +0100, Daniel P. Berrangé wrote: > > > On Thu, May 27, 2021 at 08:23:52AM -0400, Peter Xu wrote: > > > > On Thu, May 27, 2021 at 09:46:54AM +0100, Dan

Re: [PULL v2 00/28] Misc patches for 2021-05-24

2021-05-27 Thread Peter Maydell
On Wed, 26 May 2021 at 17:51, Paolo Bonzini wrote: > > The following changes since commit 92f8c6fef13b31ba222c4d20ad8afd2b79c4c28e: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20210525' into staging (2021-05-25 > 16:17:06 +0100) > > are available in the Git reposi

Re: [PATCH] vfio: Fix unregister SaveVMHandler in vfio_migration_finalize

2021-05-27 Thread Philippe Mathieu-Daudé
On 5/27/21 2:31 PM, Kunkun Jiang wrote: > In the vfio_migration_init(), the SaveVMHandler is registered for > VFIO device. But it lacks the operation of 'unregister'. It will > lead to 'Segmentation fault (core dumped)' in > qemu_savevm_state_setup(), if performing live migration after a > VFIO dev

Re: [PATCH 0/5] stop collection of instruction usage statistics

2021-05-27 Thread Alex Bennée
"Bruno Larsen (billionai)" writes: > Based-on: <20210525115355.8254-1-bruno.lar...@eldorado.org.br> > > The functionality of counting how many instructions were being executed and > being able to show it through the monitor, although neat, was only > supported by ppc, and now that it is migrati

Re: [PATCH 1/1] tests/acceptance: change armbian archive to a faster host

2021-05-27 Thread Willian Rampazzo
On Wed, May 26, 2021 at 8:41 PM Cleber Rosa wrote: > > On Wed, May 26, 2021 at 05:56:01PM -0300, Willian Rampazzo wrote: > > The current host for the image > > Armbian_20.08.1_Orangepipc_bionic_current_5.8.5.img.xz > > (archive.armbian.com) is extremely slow in the last couple of weeks, > > making

Re: [PULL 00/19] gitlab-ci patches for 2021-05-26

2021-05-27 Thread Peter Maydell
On Wed, 26 May 2021 at 22:27, Philippe Mathieu-Daudé wrote: > > The following changes since commit 2ab2dad01f6dc3667c0d53d2b1ba46b511031207: > > Merge remote-tracking branch > 'remotes/kraxel/tags/input-20210526-pull-request' into staging (2021-05-26 > 15:27:20 +0100) > > are available in the

Re: [PATCH 2/5] target/ppc: remove ppc_cpu_dump_statistics

2021-05-27 Thread Greg Kurz
On Thu, 27 May 2021 10:22:50 -0300 Bruno Piazera Larsen wrote: > > On 27/05/2021 01:35, David Gibson wrote: > > On Thu, May 27, 2021 at 11:20:01AM +1000, David Gibson wrote: > >> On Wed, May 26, 2021 at 05:21:01PM -0300, Bruno Larsen (billionai) wrote: > >>> This function requires surce code mod

[PULL 00/23] Vga 20210527 patches

2021-05-27 Thread Gerd Hoffmann
The following changes since commit 2ab2dad01f6dc3667c0d53d2b1ba46b511031207: Merge remote-tracking branch 'remotes/kraxel/tags/input-20210526-pull-request' into staging (2021-05-26 15:27:20 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/vga-202

[PULL 03/23] vhost-user-gpu: fix memory leak in vg_resource_attach_backing (CVE-2021-3544)

2021-05-27 Thread Gerd Hoffmann
From: Li Qiang Check whether the 'res' has already been attach_backing to avoid memory leak. Fixes: CVE-2021-3544 Reported-by: Li Qiang virtio-gpu fix: 204f01b309 ("virtio-gpu: fix memory leak in resource attach backing") Signed-off-by: Li Qiang Reviewed-by: Marc-André Lureau Message-Id: <20

[PULL 04/23] vhost-user-gpu: fix memory leak while calling 'vg_resource_unref' (CVE-2021-3544)

2021-05-27 Thread Gerd Hoffmann
From: Li Qiang If the guest trigger following sequences, the attach_backing will be leaked: vg_resource_create_2d vg_resource_attach_backing vg_resource_unref This patch fix this by freeing 'res->iov' in vg_resource_destroy. Fixes: CVE-2021-3544 Reported-by: Li Qiang v

  1   2   3   4   >