Re: [PATCH v3] target/riscv: fix VS interrupts forwarding to HS

2021-05-26 Thread LIU Zhiwei
Hi Jose, For one patch, the commit message is too long and complex. I recommend to split this patch to a  patch set with 4 patches. The tremohread topic is 'target/riscv: Remove  force hs exception' 1) Define the right hsie to select pending_hs_irqs. diff --git a/target/riscv/cpu_helper.c b/t

Re: [PATCH 3/3] meson: List modules built in summary

2021-05-26 Thread Philippe Mathieu-Daudé
On 5/25/21 12:46 PM, Philippe Mathieu-Daudé wrote: > Instead of guessing the modules built, list them. Example: > > Modules > audio: spice > block: curl dmg-bz2 gluster iscsi rbd ssh > chardev : spice > hw-displ

Re: [PATCH v2] hw/display/artist: Fix bug in coordinate extraction in artist_vram_read() and artist_vram_write()

2021-05-26 Thread Philippe Mathieu-Daudé
On 5/25/21 10:12 PM, Helge Deller wrote: > The CDE desktop on HP-UX 10 shows wrongly rendered pixels when the local > screen > menu is closed. This bug was introduced by commit c7050f3f167b > ("hw/display/artist: Refactor x/y coordination extraction") which converted > the > coordinate extraction

Re: [PATCH v7 09/31] python: create qemu packages

2021-05-26 Thread Vladimir Sementsov-Ogievskiy
26.05.2021 03:24, John Snow wrote: move python/qemu/*.py to python/qemu/[machine, qmp, utils]/*.py and update import directives across the tree. This is done to create a PEP420 namespace package, in which we may create subpackages. To do this, the namespace directory ("qemu") should not have any

Re: [PATCH v7 07/31] python/machine: Trim line length to below 80 chars

2021-05-26 Thread Vladimir Sementsov-Ogievskiy
26.05.2021 03:24, John Snow wrote: One more little delinting fix that snuck in. Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

[PULL 0/3] Net patches

2021-05-26 Thread Jason Wang
The following changes since commit d90f154867ec0ec22fd719164b88716e8fd48672: Merge remote-tracking branch 'remotes/dg-gitlab/tags/ppc-for-6.1-20210504' into staging (2021-05-05 20:29:14 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request

[PULL 2/3] virtio-net: failover: add missing remove_migration_state_change_notifier()

2021-05-26 Thread Jason Wang
From: Laurent Vivier In the failover case configuration, virtio_net_device_realize() uses an add_migration_state_change_notifier() to add a state notifier, but this notifier is not removed by the unrealize function when the virtio-net card is unplugged. If the card is unplugged and a migration i

[PULL 3/3] tap-bsd: Remove special casing for older OpenBSD releases

2021-05-26 Thread Jason Wang
From: Brad Smith OpenBSD added support for tap(4) 10 releases ago. Remove the special casing for older releases. Signed-off-by: Brad Smith Signed-off-by: Jason Wang --- net/tap-bsd.c | 8 1 file changed, 8 deletions(-) diff --git a/net/tap-bsd.c b/net/tap-bsd.c index 77aaf67..59dfc

[PULL 1/3] hw/net/imx_fec: return 0xffff when accessing non-existing PHY

2021-05-26 Thread Jason Wang
From: Guenter Roeck If a PHY does not exist, attempts to read from it should return 0x. Otherwise the Linux kernel will believe that a PHY is there and select the non-existing PHY. This in turn will result in network errors later on since the real PHY is not selected or configured. Since rea

Re: [PATCH v7 10/31] python: add qemu package installer

2021-05-26 Thread Vladimir Sementsov-Ogievskiy
26.05.2021 03:24, John Snow wrote: Add setup.cfg and setup.py, necessary for installing a package via pip. Add a ReST document (PACKAGE.rst) explaining the basics of what this package is for and who to contact for more information. This document will be used as the landing page for the package on

Re: [PATCH v7 13/31] python: add MANIFEST.in

2021-05-26 Thread Vladimir Sementsov-Ogievskiy
26.05.2021 03:24, John Snow wrote: When creating a source or binary distribution via 'python3 setup.py ', the VERSION and PACKAGE.rst files aren't bundled by default. Create a MANIFEST.in file that instructs the build tools to include these so that installation from these files won't fail. This

Re: GSoC introduction: Rust vhost-user-scsi device

2021-05-26 Thread Gaelan Steele
> On May 19, 2021, at 2:14 AM, Stefan Hajnoczi wrote: > > I'd like to follow your project. Will you and Sergio use #qemu IRC to > communicate? Thanks for your interest! Besides the channels Sergio mentioned, I've also started a daily-ish progress report for anyone who wants to follow along:

Re: [PULL 1/3] hw/net/imx_fec: return 0xffff when accessing non-existing PHY

2021-05-26 Thread Philippe Mathieu-Daudé
On 5/26/21 10:24 AM, Jason Wang wrote: > From: Guenter Roeck > > If a PHY does not exist, attempts to read from it should return 0x. > Otherwise the Linux kernel will believe that a PHY is there and select > the non-existing PHY. This in turn will result in network errors later > on since the

Re: [PULL 0/3] Net patches

2021-05-26 Thread Philippe Mathieu-Daudé
On 5/26/21 10:24 AM, Jason Wang wrote: > The following changes since commit d90f154867ec0ec22fd719164b88716e8fd48672: > > Merge remote-tracking branch 'remotes/dg-gitlab/tags/ppc-for-6.1-20210504' > into staging (2021-05-05 20:29:14 +0100) > > are available in the git repository at: > > htt

[PATCH 0/3] vhost-user-blk-test and vdagent Coverity fixes

2021-05-26 Thread Stefan Hajnoczi
This patch series addresses recent Coverity reports. Please see the individual patches for details. Stefan Hajnoczi (3): vhost-user-blk-test: fix Coverity open(2) false positives vhost-user-blk-test: fix Coverity mkstemp(2) umask warning ui/vdagent: fix clipboard info memory leak in error pa

[PATCH 2/3] vhost-user-blk-test: fix Coverity mkstemp(2) umask warning

2021-05-26 Thread Stefan Hajnoczi
The Linux man page for mkstemp(3) states: In glibc versions 2.06 and earlier, the file is created with permissions 0666, that is, read and write for all users. This old behavior may be a security risk, especially since other UNIX flavors use 0600, and somebody might overlook this detail

[PATCH 3/3] ui/vdagent: fix clipboard info memory leak in error path

2021-05-26 Thread Stefan Hajnoczi
If the size of a VD_AGENT_CLIPBOARD_GRAB message is invalid we leak info when returning early. Thanks to Coverity for spotting this: *** CID 1453266: Resource leaks (RESOURCE_LEAK) /qemu/ui/vdagent.c: 465 in vdagent_chr_recv_clipboard() 459 info = qemu_clipboard_info_new(&vd->cbpeer

[PATCH 1/3] vhost-user-blk-test: fix Coverity open(2) false positives

2021-05-26 Thread Stefan Hajnoczi
Coverity checks that the file descriptor return value of open(2) is checked and used. Normally this is helpful in identifying real bugs but vhost-user-blk-test opens /dev/null as stdin and stdout after fork. In this case we don't need to look at the return value because these open(2) calls cannot

Re: [PATCH v7 17/31] python: add pylint to pipenv

2021-05-26 Thread Vladimir Sementsov-Ogievskiy
26.05.2021 03:24, John Snow wrote: We are specifying >= pylint 2.8.x for several reasons: 1. For setup.cfg support, added in pylint 2.5.x 2. To specify a version that has incompatibly dropped bad-whitespace checks (2.6.x) 3. 2.7.x fixes "unsubscriptable" warnings in Python 3.9 4. 2.8.x adds

[PATCH v1 0/3] ppc: LPCR synchronisation fixes

2021-05-26 Thread Nicholas Piggin
These incoherencies have been around for a while, but they've started to get noticed now because recent Linux guests crash when LPCR[AIL] is not set correctly (scv requires it). This series fixes at least AIL and DPFD incoherency between KVM and QEMU, and between different vCPUs. Thanks, Nick Nic

Re: [PATCH v7 29/31] python: add .gitignore

2021-05-26 Thread Vladimir Sementsov-Ogievskiy
26.05.2021 03:24, John Snow wrote: Ignore *Python* build and package output (build, dist, qemu.egg-info); these files are not created as part of a QEMU build. They are created by running the commands 'python3 setup.py ' when preparing tarballs to upload to e.g. PyPI. Ignore miscellaneous cached

[PATCH v1 1/3] spapr: Remove stale comment about power-saving LPCR bits

2021-05-26 Thread Nicholas Piggin
Commit 47a9b551547 ("spapr: Clean up handling of LPCR power-saving exit bits") moved this logic but did not remove the comment from the previous location. Signed-off-by: Nicholas Piggin --- hw/ppc/spapr_rtas.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_

[PATCH v1 2/3] spapr: Set LPCR to current AIL mode when starting a new CPU

2021-05-26 Thread Nicholas Piggin
TCG does not keep track of AIL mode in a central place, it's based on the current LPCR[AIL] bits. Synchronize the new CPU's LPCR to the current LPCR in rtas_start_cpu(), similarly to the way the ILE bit is synchronized. Open-code the ILE setting as well now that the caller's LPCR is available dire

[PATCH v1 3/3] target/ppc: Synchronize with KVM's LPCR value when creating a vCPU

2021-05-26 Thread Nicholas Piggin
Despite the suggestion from the comment, LPCR value set by KVM does not get propagated to QEMU SPR values. Instead, the KVM LPCR register is set from the inital QEMU values, of which KVM allows the DPFD, ILE, TC, AIL, LD fields to be modified. For the most part these get fixed up, but at least the

Re: [PATCH v7 31/31] gitlab: add python linters to CI

2021-05-26 Thread Vladimir Sementsov-Ogievskiy
26.05.2021 03:24, John Snow wrote: Add a python container that contains just enough juice for us to run the python code quality analysis tools. Base this container on fedora, because fedora has very convenient packaging for testing multiple python versions. Add two tests: check-python-pipenv u

Re: [Bug 1924912] VirtIO drivers don't work on Windows: "GLib: Too many handles to wait for!" crash

2021-05-26 Thread Michael S. Tsirkin
So it's a virtio console issue on a windows host. [#0 init_stage2(2:2)]: VirtIOConsole: Found @ PCI [:00:04:00] [#0 init_stage2(2:2)]: Trying to unregister unused handler (?) [#0 init_stage2(2:2)]: VirtIOConsole: Multi port is not yet supported! [#0 init_stage2(2:2)]: VirtIOConsole: cols: 0, r

[Bug 1891748] Re: qemu-arm-static 5.1 can't run gcc

2021-05-26 Thread Laurent Vivier
I think the output of "sysctl vm" could help to identify which parameter is involved in the problem. You can also compare the output of "sudo sysctl vm" and "sysctl vm" -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.laun

Re: [Bug 1924912] VirtIO drivers don't work on Windows: "GLib: Too many handles to wait for!" crash

2021-05-26 Thread Laurent Vivier
Le 26/05/2021 à 11:47, mst a écrit : > So it's a virtio console issue on a windows host. > > [#0 init_stage2(2:2)]: VirtIOConsole: Found @ PCI [:00:04:00] > [#0 init_stage2(2:2)]: Trying to unregister unused handler (?) > [#0 init_stage2(2:2)]: VirtIOConsole: Multi port is not yet supported! >

Re: [PATCH] configure: Check whether we can compile the s390-ccw bios with -msoft-float

2021-05-26 Thread Philippe Mathieu-Daudé
On 5/25/21 5:13 PM, Philippe Mathieu-Daudé wrote: > On 5/25/21 4:40 PM, Thomas Huth wrote: >> On 25/05/2021 16.31, Cornelia Huck wrote: >>> On Tue, 25 May 2021 16:20:32 +0200 >>> Thomas Huth wrote: >>> The -msoft-float switch is not available in older versions of Clang. Since we rely on

[Bug 1878323] Re: Assertion-failure in usb_detach

2021-05-26 Thread Thomas Huth
I can reproduce this crash with QEMU v5.0, but with the current version from the master branch, this does not trigger anymore. I assume this has been fixed. Could you please have a try and confirm that it does not happen anymore? ** Changed in: qemu Status: New => Incomplete -- You receiv

Re: [PATCH v4 01/15] python: qemu: add timer parameter for qmp.accept socket

2021-05-26 Thread Vladimir Sementsov-Ogievskiy
20.05.2021 10:52, Emanuele Giuseppe Esposito wrote: Alsp add a new _qmp_timer field to the QEMUMachine class. Let's change the default socket timeout to None, so that if a subclass needs to add a timer, it can be done by modifying this private field. At the same time, restore the timer to be 15

Re: [PATCH v4 02/15] python: qemu: pass the wrapper field from QEMUQtestmachine to QEMUMachine

2021-05-26 Thread Vladimir Sementsov-Ogievskiy
in subject: s/QEMUQtestmachine/QEMUQtestMachine 20.05.2021 10:52, Emanuele Giuseppe Esposito wrote: Reviewed-by: John Snow Reviewed-by: Max Reitz Signed-off-by: Emanuele Giuseppe Esposito Usually, r-b lines are placed below s-o-b line. Reviewed-by: Vladimir Sementsov-Ogievskiy --- p

Re: [PATCH v4 03/15] docs/devel/testing: add debug section to the QEMU iotests chapter

2021-05-26 Thread Vladimir Sementsov-Ogievskiy
20.05.2021 10:52, Emanuele Giuseppe Esposito wrote: Introduce the "Debugging a test case" section, in preparation to the additional flags that will be added in the next patches. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

[Bug 1878641] Re: Abort() in mch_update_pciexbar

2021-05-26 Thread Thomas Huth
Confirmed, this is not fixed yet. Philippe, what happened to your patch? ** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1878641 Title: Abort() in

Re: [PATCH v4 04/15] qemu-iotests: add option to attach gdbserver

2021-05-26 Thread Vladimir Sementsov-Ogievskiy
20.05.2021 10:52, Emanuele Giuseppe Esposito wrote: Define -gdb flag and GDB_OPTIONS environment variable Let's use --option notation for new long options to python tests to attach a gdbserver to each qemu instance. This patch only adds and parses this flag, it does not yet add the implementa

Re: [PATCH v2] migration/rdma: Fix cm_event used before being initialized

2021-05-26 Thread Dr. David Alan Gilbert
* Li Zhijian (lizhij...@cn.fujitsu.com) wrote: > A segmentation fault was triggered when i try to abort a postcopy + rdma > migration. > > since rdma_ack_cm_event releases a uninitialized cm_event in these case. > > like below: > 2496 ret = rdma_get_cm_event(rdma->channel, &cm_event); > 2497

Re: [PATCH v2 1/4] migration/rdma: cleanup rmda in rdma_start_incoming_migration error path

2021-05-26 Thread Dr. David Alan Gilbert
* Li Zhijian (lizhij...@cn.fujitsu.com) wrote: > the error path after calling qemu_rdma_dest_init() should do rdma cleanup > > Signed-off-by: Li Zhijian > Reviewed-by: Dr. David Alan Gilbert Queued > --- > migration/rdma.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > di

Re: [PATCH v4 00/15] qemu_iotests: improve debugging options

2021-05-26 Thread Vladimir Sementsov-Ogievskiy
20.05.2021 10:52, Emanuele Giuseppe Esposito wrote: This series adds the option to attach gdbserver and valgrind to the QEMU binary running in qemu_iotests. It also allows to redirect QEMU binaries output of the python tests to the stdout, instead of a log file. Patches 1-6 introduce the -gdb op

Re: [PATCH v3] target/riscv: fix VS interrupts forwarding to HS

2021-05-26 Thread Jose Martins
Hello Zhiwei, thank you for reviewing the patch. I'll split the patch in a series as you suggest. But first can you help me understand what the problems are with riscv_cpu_local_irq_pending? > I think there are two errors in riscv_cpu_local_irq_pending. > > 1) VS interrupts can't be forwarded to

Re: [PATCH 0/2] vvfat: fix two crashes.

2021-05-26 Thread Programmingkid
> On May 25, 2021, at 12:18 PM, Kevin Wolf wrote: > > Am 24.05.2021 um 18:06 hat Programmingkid geschrieben: > qemu-system-ppc -usb -device usb-storage,drive=fat16 -drive > file=fat:rw:fat-type=16:" folder>",id=fat16,format=raw,if=none > >> On a related topic would you know i

Re: [PATCH] gitignore: Update with some filetypes

2021-05-26 Thread Alex Bennée
Viresh Kumar writes: > Update .gitignore to ignore .swp and .patch files. > > Signed-off-by: Viresh Kumar Reviewed-by: Alex Bennée -- Alex Bennée

[PATCHv2 1/4] target/arm: fix missing exception class

2021-05-26 Thread Jamie Iles
The DAIF and PAC checks used raise_exception_ra to raise an exception and unwind CPU state but raise_exception_ra is currently designed for handling data aborts as the syndrome is partially precomputed and encoded in the TB and then merged in merge_syn_data_abort when handling the data abort. Usin

[PATCHv2 2/4] target/arm: fold do_raise_exception into raise_exception

2021-05-26 Thread Jamie Iles
Now that there are no other users of do_raise_exception, fold it into raise_exception. Cc: Richard Henderson Cc: Peter Maydell Signed-off-by: Jamie Iles --- target/arm/op_helper.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/target/arm/op_helper.c b/target/

[PATCHv2 3/4] target/arm: use raise_exception_ra for MTE check failure

2021-05-26 Thread Jamie Iles
Now that raise_exception_ra restores the state before raising the exception we can use restore_exception_ra to perform the state restore + exception raising without clobbering the syndrome. Cc: Richard Henderson Cc: Peter Maydell Signed-off-by: Jamie Iles --- target/arm/mte_helper.c | 11 ++---

[PATCHv2 0/4] target/arm: fix missing exception class

2021-05-26 Thread Jamie Iles
Thanks Peter for the suggestions, I also added a patch to switch a couple of cpu_restore_state+raise_exception pairs in stack limit exception handling for both v7m and v8m. v2: - fix raise_exception_ra to restore state before raising exception - remove redundant do_raise_exception - remove no

[PATCHv2 4/4] target/arm: use raise_exception_ra for stack limit exception

2021-05-26 Thread Jamie Iles
Now that raise_exception_ra restores the state before raising the exception we can use restore_exception_ra to perform the state restore + exception raising without clobbering the PC/condbits. Cc: Richard Henderson Cc: Peter Maydell Signed-off-by: Jamie Iles --- target/arm/m_helper.c | 5 +--

Re: [PATCH v4 04/15] qemu-iotests: add option to attach gdbserver

2021-05-26 Thread Paolo Bonzini
On 26/05/21 13:24, Vladimir Sementsov-Ogievskiy wrote: Define -gdb flag and GDB_OPTIONS environment variable Let's use --option notation for new long options Why make a mix of two styles? -- suggests that single-character options like -d and -v can be combined, is that the case? if -gdb

Re: [PATCH v4 04/15] qemu-iotests: add option to attach gdbserver

2021-05-26 Thread Vladimir Sementsov-Ogievskiy
26.05.2021 15:48, Paolo Bonzini wrote: On 26/05/21 13:24, Vladimir Sementsov-Ogievskiy wrote: Define -gdb flag and GDB_OPTIONS environment variable Let's use --option notation for new long options Why make a mix of two styles? -- suggests that single-character options like -d and -v can b

Re: [PATCH v2 03/28] softfloat: Move uint_to_float to softfloat-parts.c.inc

2021-05-26 Thread David Hildenbrand
On 25.05.21 17:06, Richard Henderson wrote: Rename to parts$N_uint_to_float. Reimplement uint64_to_float128 with FloatParts128. Signed-off-by: Richard Henderson --- fpu/softfloat.c | 83 --- fpu/softfloat-parts.c.inc | 23 +++ 2 files ch

Re: 9pfs: scope of rename_lock?

2021-05-26 Thread Christian Schoenebeck
On Dienstag, 25. Mai 2021 13:41:22 CEST Christian Schoenebeck wrote: > I started to work on a patch set on this. > > I try to get rid of that rename_lock entirely by letting the worker threads > only access temporary copies e.g. of the fid path instead of allowing the > worker threads to access ma

Re: [PATCH v2 04/28] softfloat: Move minmax_flags to softfloat-parts.c.inc

2021-05-26 Thread David Hildenbrand
On 25.05.21 17:06, Richard Henderson wrote: Rename to parts$N_minmax. Combine 3 bool arguments to a bitmask, return a tri-state value to indicate nan vs unchanged operand. Introduce ftype_minmax functions as a common optimization point. Fold bfloat16 expansions into the same macro as the other t

[Bug 1878651] Re: Assertion failure in e1000e_write_to_rx_buffers

2021-05-26 Thread Thomas Huth
While the crash with the original reproducer seems to be gone, the minimized reproducer from comment #2 still triggers this issue. Setting to "Confirmed". ** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which i

Re: RFC: IPv6 hostfwd command line syntax [was Re: [PATCH v6 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse]

2021-05-26 Thread Daniel P . Berrangé
On Tue, May 25, 2021 at 12:37:21PM -0700, Doug Evans wrote: > Hi. > > I want to confirm the command line syntax y'all want for ipv6 host > forwarding. > > IIUC, the command line syntax is required to be consistent with the use of > "ipv6=on|off" elsewhere. > Can you confirm that's correct? > > I

Re: [PATCH v2 02/28] softfloat: Move int_to_float to softfloat-parts.c.inc

2021-05-26 Thread David Hildenbrand
On 25.05.21 17:06, Richard Henderson wrote: Rename to parts$N_sint_to_float. Reimplement int{32,64}_to_float128 with FloatParts128. Signed-off-by: Richard Henderson --- fpu/softfloat.c | 136 +++--- fpu/softfloat-parts.c.inc | 32 + 2 files

[PULL 03/14] ps2: don't raise an interrupt if queue is full

2021-05-26 Thread Gerd Hoffmann
From: Volker Rümelin ps2_queue() behaves differently than the very similar functions ps2_queue_2() to ps2_queue_4(). The first one calls update_irq() even if the queue is full, the others don't. Change ps2_queue() to be consistent with the others. Reviewed-by: Philippe Mathieu-Daudé Signed-off-

[PULL 05/14] pckbd: split out interrupt line changing code

2021-05-26 Thread Gerd Hoffmann
From: Volker Rümelin Split out the interrupt line changing code from kbd_update_irq(). This is a preparation for the next patch. There is no functional change. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Volker Rümelin Message-Id: <20210525181441.27768-4-vr_q...@t-online.de> Signed-off-

[PULL 07/14] pckbd: PS/2 keyboard throttle

2021-05-26 Thread Gerd Hoffmann
From: Volker Rümelin Limit the keyboard data rate to the serial link speed. Some old DOS software relies on being able to read an incoming scan-code more than once. After reading keyboard data from the i8042 controller, the guest software has 1ms to read the same data again. Use -global i8042.kb

[PULL 00/14] Input 20210526 patches

2021-05-26 Thread Gerd Hoffmann
The following changes since commit 92f8c6fef13b31ba222c4d20ad8afd2b79c4c28e: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210525' into staging (2021-05-25 16:17:06 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/input-202

[PULL 01/14] hw/input: expand trace info reported for ps2 device

2021-05-26 Thread Gerd Hoffmann
From: Daniel P. Berrangé It is interesting to know if the PS2 keyboard is in translated mode, and which of the three scancode sets are in use. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé Message-Id: <20210309155804.306051-1-berra...@redhat.com> Signed-off-by: Gerd Hof

[PULL 04/14] ps2: don't deassert irq twice if queue is empty

2021-05-26 Thread Gerd Hoffmann
From: Volker Rümelin Don't deassert the irq twice if the queue is empty. While the second deassertion doesn't do any harm, it's unnecessary. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Volker Rümelin Message-Id: <20210525181441.27768-3-vr_q...@t-online.de> Signed-off-by: Gerd Hoffmann

[PULL 09/14] pckbd: add controller response queue

2021-05-26 Thread Gerd Hoffmann
From: Volker Rümelin Add a separate queue for PS/2 controller responses. The responses no longer get queued in the keyboard or mouse queues. The advantage of this can be seen after the next two patches, where the guest can disable the PS/2 communication with keyboard and mouse and still talk to t

[PULL 02/14] ps2: fix mouse stream corruption

2021-05-26 Thread Gerd Hoffmann
From: Volker Rümelin Commit 7abe7eb294 "ps2: Fix mouse stream corruption due to lost data" added code to avoid mouse stream corruptions but the calculation of the needed free queue size was wrong. Fix this. To reproduce, open a text file with the vim 7.3 32 bit for DOS exe- cutable in a FreeDOS

[PULL 06/14] pckbd: don't update OBF flags if KBD_STAT_OBF is set

2021-05-26 Thread Gerd Hoffmann
From: Volker Rümelin Don't update the OBF flags in the status register and the cor- responding IRQ lines if KBD_STAT_OBF is set. Otherwise this may change the PS/2 event type. If the guest ISR was already scheduled, the changed event type will be rather surprising for the guest. This fixes a mou

[PULL 08/14] pckbd: add state variable for interrupt source

2021-05-26 Thread Gerd Hoffmann
From: Volker Rümelin Currently there is only one flag to distinguish between two interrupt sources and there are no available flags for more sources. Add an internal state variable to store the interrupt source. The next patch will introduce an additional interrupt source. There is no functional

[PULL 13/14] pckbd: clear outport_present in outer pre_load()

2021-05-26 Thread Gerd Hoffmann
From: Volker Rümelin The variable outport_present is a flag to show if the outport subsection was loaded. Clear the outport_present flag in the outer pre_load() function. This method is recommended in the QEMU manual for developers in the chapter "Migration, Subsections". Signed-off-by: Volker R

[PULL 11/14] pckbd: correctly disable PS/2 communication

2021-05-26 Thread Gerd Hoffmann
From: Volker Rümelin Currently the PS/2 controller command KBD_CCMD_MOUSE_DISABLE doesn't disable the PS/2 mouse communication at all, and the PS/2 controller commands KBD_CCMD_KBD_DISABLE and KBD_CCMD_KBD_ENABLE only disable and enable the keyboard interrupt, which is very different from what a

[PULL 14/14] hw/input/ps2: Use ps2_raise_irq() instead of open coding it

2021-05-26 Thread Gerd Hoffmann
From: Philippe Mathieu-Daudé Inspired-by: Volker Rümelin Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Volker Rümelin Reviewed-by: Bin Meng Message-Id: <20210513171244.3940519-1-f4...@amsat.org> Signed-off-by: Gerd Hoffmann --- hw/input/ps2.c | 8 1 file changed, 4 insertions(

[PULL 10/14] pckbd: add function kbd_pending()

2021-05-26 Thread Gerd Hoffmann
From: Volker Rümelin Replace reads of the variable s->pending with a call to a new function kbd_pending() to ease the review of the next patch. There is no functional change. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Volker Rümelin Message-Id: <20210525181441.27768-9-vr_q...@t-online.

[PULL 12/14] pckbd: remove duplicated keyboard and mouse defines

2021-05-26 Thread Gerd Hoffmann
From: Volker Rümelin In 2005 the author of commit daa579632d "PS2 mouse and keyboard separation (Paul Brook)" and 0e43e99c04 "PS2 mouse and keyboard separation (Paul Brook)" separated the PS/2 controller code and the PS/2 keyboard and mouse code. It seems he forgot to remove a few defines. Remove

[Bug 1879223] Re: Assertion failure in e1000e_write_rx_descr

2021-05-26 Thread Thomas Huth
I can reproduce this problem with QEMU v5.0, but with the current version, it does not run into this assertion anymore. Seems like this problem got fixed in the course of time? Could you please check whether you could still reproduce this? ** Changed in: qemu Status: New => Incomplete --

Re: [Bug 1878641] Re: Abort() in mch_update_pciexbar

2021-05-26 Thread Philippe Mathieu-Daudé
On 5/26/21 1:06 PM, Thomas Huth wrote: > Confirmed, this is not fixed yet. Philippe, what happened to your patch? I was waiting someone suggest me how to propagate error from PCIConfigWriteFunc. Probably not very important.

[PATCH v2] hw/pci-host/q35: Ignore write of reserved PCIEXBAR LENGTH field

2021-05-26 Thread Philippe Mathieu-Daudé
libFuzzer triggered the following assertion: cat << EOF | qemu-system-i386 -M pc-q35-5.0 \ -nographic -monitor none -serial none \ -qtest stdio -d guest_errors -trace pci\* outl 0xcf8 0xf260 outl 0xcfc 0x8400056e EOF pci_cfg_write mch 00:0 @0x60 <- 0x8400056e Aborted (core

Re: [PULL v2 0/7] testing, gdbstub and plugin updates

2021-05-26 Thread Peter Maydell
On Tue, 25 May 2021 at 17:05, Alex Bennée wrote: > > Tweaked the rules so the needs: line is optional > > The following changes since commit 0dab1d36f55c3ed649bb8e4c74b9269ef3a63049: > > Merge remote-tracking branch > 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2021-05-24 >

[PATCH] target/ppc: fold ppc_store_ptcr into it's only caller

2021-05-26 Thread Bruno Larsen (billionai)
ppc_store_ptcr, defined in mmu_helper.c, was only used by helper_store_ptcr, in misc_helper.c. To avoid possible confusion, the function was folded into the helper. Signed-off-by: Bruno Larsen (billionai) --- target/ppc/cpu.h | 1 - target/ppc/misc_helper.c | 24 +++-

[Bug 1879227] Re: Assertion failure in e1000e_write_lgcy_rx_descr

2021-05-26 Thread Thomas Huth
I can reproduce this problem with QEMU v5.0, but with the current version, it does not run into this assertion anymore. Seems like this problem got fixed in the course of time? Could you please check whether you could still reproduce this? ** Changed in: qemu Status: New => Incomplete --

Re: [PATCH v3 2/3] tests/qtest/virtio-scsi-test: add unmap large LBA with 4k blocks test

2021-05-26 Thread Paolo Bonzini
On 25/05/21 21:46, Kit Westneat wrote: +static void *virtio_scsi_setup_4k(GString *cmd_line, void *arg) +{ +g_string_append(cmd_line, +" -drive file=blkdebug::null-co://," +"file.image.read-zeroes=on," +"if=none,id=dr1,format=raw,fil

[PATCH v2 0/4] target/i386/cpu: introduce new CPU models for x86-64 ABI levels

2021-05-26 Thread Daniel P . Berrangé
This series is motivated by this blog that describes how RHEL-9 will recommend use of the x86-64-v2 microarchitectural ABI level: https://developers.redhat.com/blog/2021/01/05/building-red-hat-enterprise-linux-9-for-the-x86-64-v2-microarchitecture-level/ The implication of compiling code with

[Bug 1886362] Re: Heap use-after-free in lduw_he_p through e1000e_write_to_rx_buffers

2021-05-26 Thread Thomas Huth
I can reproduce this problem with QEMU v5.0, but with the current version, it does not run into this assertion anymore. Seems like this problem got fixed in the course of time? Could you please check whether you could still reproduce this? ** Changed in: qemu Status: New => Incomplete --

[PATCH v2 3/4] scripts: helper to generate x86_64 CPU ABI compat info

2021-05-26 Thread Daniel P . Berrangé
This script is what is used to generate the docs data table in: docs/system/cpu-models-x86-abi.csv It can be useful to run if adding new CPU models / versions and the csv needs updating. Signed-off-by: Daniel P. Berrangé --- scripts/cpu-x86-uarch-abi.py | 194

[PATCH v2 2/4] target/i386: define CPU models to model x86-64 ABI levels

2021-05-26 Thread Daniel P . Berrangé
To paraphrase: https://developers.redhat.com/blog/2021/01/05/building-red-hat-enterprise-linux-9-for-the-x86-64-v2-microarchitecture-level/ In 2020, AMD, Intel, Red Hat, and SUSE worked together to define three microarchitecture levels on top of the historical x86-64 baseline: * x86-64:

[PATCH v2 1/4] docs: add a table showing x86-64 ABI compatibility levels

2021-05-26 Thread Daniel P . Berrangé
It is useful to know which CPUs satisfy each x86-64 ABI compatibility level, when dealing with guest OS that require something newer than the baseline ABI. These ABI levels are defined in: https://gitlab.com/x86-psABIs/x86-64-ABI/ and supported by GCC, Clang, glibc and more. Signed-off-by: Da

[PATCH v2 4/4] NOT FOR MERGE target/i386: use x86-64-abi1 CPU model as default on x86_64

2021-05-26 Thread Daniel P . Berrangé
The only differences between x86-64-abi1 and qemu64 is that the former does not have the 'vme' or 'svm' flags. In practice I don't think we should make this change, because it doesn't especially add any value as-is. The only possible case is around 'svm' because KVM already masks that feature, but

[Bug 1887306] Re: qemu-user deadlocks when forked in a multithreaded process

2021-05-26 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/358 ** Changed in: qemu Status: New => Expired ** Bug watch

Re: [PATCH v2 7/7] block-copy: protect BlockCopyState .method fields

2021-05-26 Thread Paolo Bonzini
On 25/05/21 13:00, Vladimir Sementsov-Ogievskiy wrote: Hmm. OK, let me think: First look at block_copy_do_copy(). It's called only from block_copy_task_entry. block_copy_task_entry() has mutex-critical-section anyway around handling return value. That means that we can simply move s->method

Re: [PATCH v2 5/7] block-copy: add QemuMutex lock for BlockCopyCallState list

2021-05-26 Thread Paolo Bonzini
On 25/05/21 12:58, Emanuele Giuseppe Esposito wrote: At this point, I would just rename the other lock (tasks_lock) in "lock" or "state_lock", and substitute it in the calls_lock usages of this patch. Depending on how it comes out, I may merge this with the previous patch. Renaming the lock

[Bug 1888606] Re: Heap-use-after-free in virtio_gpu_ctrl_response

2021-05-26 Thread Thomas Huth
I can reproduce this problem with QEMU v5.0, but with the current version, it does not run into this problem anymore. Seems like this problem got fixed in the course of time? Could you please check whether you could still reproduce this? ** Changed in: qemu Status: New => Incomplete -- Y

Re: [PATCH v2 4/7] block-copy: add a CoMutex to the BlockCopyTask list

2021-05-26 Thread Paolo Bonzini
On 25/05/21 12:25, Vladimir Sementsov-Ogievskiy wrote: Next, even if we take bitmaps lock in bdrv_dirty_bitmap_next_dirty_area() or around it, it doesn't bring thread-safety to block_copy_task_create(): The simplest solution here seems to protect bdrv_dirty_bitmap_next_dirty_area and also bdr

[Bug 721825] Re: VDI block driver bugs

2021-05-26 Thread Thomas Huth
** Changed in: qemu Assignee: Stefan Weil (ubuntu-weilnetz) => (unassigned) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/721825 Title: VDI block driver bugs Status in QEMU: Incomplete Bug

[Bug 1890157] Re: Assertion failure in net_tx_pkt_reset through vmxnet3

2021-05-26 Thread Thomas Huth
This can still be reproduced with the current version of QEMU. Marking as "Confirmed" ** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1890157 Title:

[Bug 1890155] Re: Abort in vmxnet3_validate_interrupt_idx

2021-05-26 Thread Thomas Huth
This still reproduces with the current version of QEMU. Marking as "Confirmed" ** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1890155 Title: Abor

[Bug 1890159] Re: Assertion failure in net_tx_pkt_add_raw_fragment through vmxnet3

2021-05-26 Thread Thomas Huth
This still triggers with the current version of QEMU. Marking as "Confirmed" ** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1890159 Title: Assert

Re: [PATCH v4 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed

2021-05-26 Thread Gustavo Noronha Silva
On Tue, May 18, 2021, at 7:14 AM, 'Gerd Hoffmann ' wrote: > On Tue, May 11, 2021 at 03:55:37PM -0300, gust...@noronha.eti.br wrote: > > From: Gustavo Noronha Silva > > > > Applications such as Gnome may use Alt-Tab and Super-Tab for different > > purposes, some use Ctrl-arrows so we want to allow

[Bug 1890160] Re: Abort in vmxnet3_validate_queues

2021-05-26 Thread Thomas Huth
Still reproduces with the current version of QEMU. Marking as "Confirmed" ** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1890160 Title: Abort in

Re: [PATCH v5 23/23] target/ppc: Move cmp/cmpi/cmpl/cmpli to decodetree

2021-05-26 Thread Matheus K. Ferst
On 24/05/2021 15:51, Richard Henderson wrote: On 5/21/21 10:25 AM, Matheus K. Ferst wrote: On 18/05/2021 07:12, Richard Henderson wrote: On 5/17/21 3:50 PM, matheus.fe...@eldorado.org.br wrote: +    if(a->l && (ctx->insns_flags & PPC_64B)) { Space after IF. > If I look back to the 6xx manual

Re: [PATCH v1 1/3] spapr: Remove stale comment about power-saving LPCR bits

2021-05-26 Thread Cédric Le Goater
On 5/26/21 11:16 AM, Nicholas Piggin wrote: > Commit 47a9b551547 ("spapr: Clean up handling of LPCR power-saving exit > bits") moved this logic but did not remove the comment from the > previous location. > > Signed-off-by: Nicholas Piggin Reviewed-by: Cédric Le Goater > --- > hw/ppc/spapr_r

Re: [PATCH v1 2/3] spapr: Set LPCR to current AIL mode when starting a new CPU

2021-05-26 Thread Cédric Le Goater
On 5/26/21 11:16 AM, Nicholas Piggin wrote: > TCG does not keep track of AIL mode in a central place, it's based on > the current LPCR[AIL] bits. Synchronize the new CPU's LPCR to the > current LPCR in rtas_start_cpu(), similarly to the way the ILE bit is > synchronized. > > Open-code the ILE sett

[Bug 1891354] Re: Heap-use-after-free in usb_packet_unmap

2021-05-26 Thread Thomas Huth
Still reproduces with current version of QEMU (if it has been built with Clang + asan enabled). Marking as "Confirmed" ** Changed in: qemu Status: New => Confirmed ** Tags added: fuzzer usb -- You received this bug notification because you are a member of qemu- devel-ml, which is subscri

Re: RFC: IPv6 hostfwd command line syntax [was Re: [PATCH v6 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse]

2021-05-26 Thread Doug Evans
On Wed, May 26, 2021 at 6:57 AM Daniel P. Berrangé wrote: > On Tue, May 25, 2021 at 12:37:21PM -0700, Doug Evans wrote: > > Hi. > > > > I want to confirm the command line syntax y'all want for ipv6 host > > forwarding. > > > > IIUC, the command line syntax is required to be consistent with the us

[PATCH] spapr: nvdimm: Fix the persistent-memory root node name in device tree

2021-05-26 Thread Shivaprasad G Bhat
The FDT code is adding the pmem root node by name "persistent-memory" which should have been "ibm,persistent-memory". The linux fetches the device tree nodes by type and it has been working correctly as the type is correct. If someone searches by its intended name it would fail, so fix that. Repo

Re: RFC: IPv6 hostfwd command line syntax [was Re: [PATCH v6 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse]

2021-05-26 Thread Daniel P . Berrangé
On Wed, May 26, 2021 at 08:26:33AM -0700, Doug Evans wrote: > On Wed, May 26, 2021 at 6:57 AM Daniel P. Berrangé > wrote: > > > On Tue, May 25, 2021 at 12:37:21PM -0700, Doug Evans wrote: > > > Hi. > > > > > > I want to confirm the command line syntax y'all want for ipv6 host > > > forwarding. >

  1   2   3   4   >