Re: [PATCH v2 01/21] qapi/parser: Don't try to handle file errors

2021-05-19 Thread Markus Armbruster
John Snow writes: > On 5/18/21 5:28 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> Remove the try/except block that handles file-opening errors in >>> QAPISchemaParser.__init__() and add one each to >>> QAPISchemaParser._include() and QAPISchema.__init__() respectively. >>> >>> >>> Th

Re: [PATCH 3/3] hw/block/nvme: add id ns metadata cap (mc) enum

2021-05-19 Thread Klaus Jensen
On Apr 21 18:32, Gollu Appalanaidu wrote: Add Idnetify Namespace Metadata Capablities (MC) enum. Signed-off-by: Gollu Appalanaidu --- hw/block/nvme-ns.c | 2 +- include/block/nvme.h | 5 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/block/nvme-ns.c b/hw/block/nvme-ns.c

Re: [PATCH 3/3] sensor: Move hardware sensors from misc to a sensor directory

2021-05-19 Thread Cédric Le Goater
On 5/19/21 2:03 AM, miny...@acm.org wrote: > From: Corey Minyard > > Lots of this are expected to be coming in, create a directory for them. > > Also move the tmp105.h file into the include directory where it > should be. > > Cc: Cédric Le Goater > Cc: Peter Maydell > Cc: Andrew Jeffery > Cc

Re: [PATCH v2] fdc: check null block pointer before r/w data transfer

2021-05-19 Thread P J P
+-- On Tue, 18 May 2021, John Snow wrote --+ | I assume it can be rolled into the most recent issue that actually grabbed | my attention: | | -> https://gitlab.com/qemu-project/qemu/-/issues/338 | | And we can credit both reporters (and Alexander) and solve all of these issues | all at once. |

Re: [PATCH] fdc: check drive block device before usage (CVE-2021-20196)

2021-05-19 Thread P J P
Hello John, +-- On Tue, 18 May 2021, John Snow wrote --+ | Annotated: | | # fdctrl->cur_drv starts at 0x00 | # fdctrl->dor starts at 0x0c (DMA, RESET#) | # fdctrl->dsr starts at 0x00 | | > outb 0x3f2 0x04 | fdc_ioport_write write reg 0x02 [DOR] Digital Output Register val 0x04 | DOR changed

RE: [RFC PATCH v2 5/6] hw/arm/virt-acpi-build: Add PPTT table

2021-05-19 Thread Salil Mehta
> From: wangyanan (Y) > Sent: Wednesday, May 19, 2021 4:18 AM > > > On 2021/5/19 3:22, Salil Mehta wrote: > >> From: Andrew Jones [mailto:drjo...@redhat.com] > >> Sent: Tuesday, May 18, 2021 8:06 PM > >> To: Salil Mehta > >> Cc: wangyanan (Y) ; Peter Maydell > >> ; Michael S . Tsirkin ; > >> Wa

[PATCH v2] migration/rdma: Fix cm_event used before being initialized

2021-05-19 Thread Li Zhijian
A segmentation fault was triggered when i try to abort a postcopy + rdma migration. since rdma_ack_cm_event releases a uninitialized cm_event in these case. like below: 2496 ret = rdma_get_cm_event(rdma->channel, &cm_event); 2497 if (ret) { 2498 perror("rdma_get_cm_event after rdm

Re: [PATCH v2] migration/rdma: Fix cm_event used before being initialized

2021-05-19 Thread Dr. David Alan Gilbert
* Li Zhijian (lizhij...@cn.fujitsu.com) wrote: > A segmentation fault was triggered when i try to abort a postcopy + rdma > migration. > > since rdma_ack_cm_event releases a uninitialized cm_event in these case. > > like below: > 2496 ret = rdma_get_cm_event(rdma->channel, &cm_event); > 2497

Re: [RFC PATCH v2 5/6] hw/arm/virt-acpi-build: Add PPTT table

2021-05-19 Thread Andrew Jones
On Wed, May 19, 2021 at 07:54:37AM +, Salil Mehta wrote: > > From: wangyanan (Y) > > Sent: Wednesday, May 19, 2021 4:18 AM > > > > > > On 2021/5/19 3:22, Salil Mehta wrote: > > >> From: Andrew Jones [mailto:drjo...@redhat.com] > > >> Sent: Tuesday, May 18, 2021 8:06 PM > > >> To: Salil Mehta

Re: [PATCH v5 1/6] hw/isa/Kconfig: Fix missing dependency ISA_SUPERIO -> FDC

2021-05-19 Thread Thomas Huth
On 18/05/2021 21.32, Philippe Mathieu-Daudé wrote: isa_superio_realize() calls isa_fdc_init_drives(), which is defined in hw/block/fdc.c, so ISA_SUPERIO needs to select the FDC symbol. If I get that right, not all superio chipsets provide a floppy drive (there's this "k->floppy.is_enabled" che

Re: [RFC PATCH v2 5/6] hw/arm/virt-acpi-build: Add PPTT table

2021-05-19 Thread Andrew Jones
On Tue, May 18, 2021 at 09:05:39PM +0200, Andrew Jones wrote: > The problem is that -smp 4,maxcpus=8 doesn't error out today, even though > it doesn't do anything. OTOH, -smp 4,cores=2 doesn't error out either, but > we're proposing that it should. Maybe we can start erroring out when > cpus != max

Re: [RFC PATCH v2 5/6] hw/arm/virt-acpi-build: Add PPTT table

2021-05-19 Thread wangyanan (Y)
On 2021/5/19 16:15, Andrew Jones wrote: On Wed, May 19, 2021 at 07:54:37AM +, Salil Mehta wrote: From: wangyanan (Y) Sent: Wednesday, May 19, 2021 4:18 AM On 2021/5/19 3:22, Salil Mehta wrote: From: Andrew Jones [mailto:drjo...@redhat.com] Sent: Tuesday, May 18, 2021 8:06 PM To: Salil M

[PATCH] qemu-io-cmds: assert that we don't have .perm requested in no-blk case

2021-05-19 Thread Vladimir Sementsov-Ogievskiy
Coverity things blk may be NULL. It's a false-positive, as described in a new comment. Fixes: Coverity CID 1453194 Signed-off-by: Vladimir Sementsov-Ogievskiy --- qemu-io-cmds.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c in

Re: [RFC PATCH 14/25] qemu/bswap: Introduce load/store for aligned pointer

2021-05-19 Thread Stefan Hajnoczi
On Wed, May 19, 2021 at 07:56:51AM +0200, Philippe Mathieu-Daudé wrote: > On 5/18/21 10:15 PM, Peter Maydell wrote: > > On Tue, 18 May 2021 at 19:38, Philippe Mathieu-Daudé > > wrote: > >> > >> When the pointer alignment is known to be safe, we can > >> directly swap the data in place, without ha

Re: GSoC introduction: Rust vhost-user-scsi device

2021-05-19 Thread Stefan Hajnoczi
On Tue, May 18, 2021 at 07:10:31PM -0700, Gaelan Steele wrote: > I'm Gaelan Steele, one of QEMU's Google Summer of Code students this > year. My mentor (Sergio Lopez) has asked me to introduce myself and my > project here. Welcome, Gaelan! I look forward to your vhost-user-scsi contributions. I'd

Re: [PATCH v12 3/8] arm64: mte: Sync tags for pages where PTE is untagged

2021-05-19 Thread Steven Price
On 17/05/2021 17:14, Marc Zyngier wrote: > On Mon, 17 May 2021 13:32:34 +0100, > Steven Price wrote: >> >> A KVM guest could store tags in a page even if the VMM hasn't mapped >> the page with PROT_MTE. So when restoring pages from swap we will >> need to check to see if there are any saved tags e

Re: [PATCH v6 9/9] ui/gtk: add clipboard support

2021-05-19 Thread Marc-André Lureau
On Wed, May 19, 2021 at 9:40 AM Gerd Hoffmann wrote: > This patch adds clipboard support to the qemu gtk ui. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Marc-André Lureau --- > include/ui/gtk.h | 10 +++ > ui/gtk-clipboard.c | 192 + > ui/gt

Re: [PATCH v6 6/9] ui/vdagent: add clipboard support

2021-05-19 Thread Marc-André Lureau
On Wed, May 19, 2021 at 9:40 AM Gerd Hoffmann wrote: > This patch adds support for clipboard messages to the qemu vdagent > implementation, which allows the guest exchange clipboard data with > qemu. Clipboard support can be enabled/disabled using the new > 'clipboard' parameter for the vdagent

Re: [PATCH v6 4/9] ui/vdagent: core infrastructure

2021-05-19 Thread Marc-André Lureau
On Wed, May 19, 2021 at 9:40 AM Gerd Hoffmann wrote: > The vdagent protocol allows the guest agent (spice-vdagent) and the > spice client exchange messages to implement features which require > guest cooperation, for example clipboard support. > > This is a qemu implementation of the spice client

Re: [PATCH v3] i386: Add ratelimit for bus locks acquired in guest

2021-05-19 Thread Chenyi Qiang
On 5/18/2021 3:46 AM, Eduardo Habkost wrote: +Stefan I have a question about ratelimit_set_speed() below: On Fri, Apr 30, 2021 at 06:33:05PM +0800, Chenyi Qiang wrote: A bus lock is acquired through either split locked access to writeback (WB) memory or any locked access to non-WB memory. I

RE: [RFC PATCH v2 5/6] hw/arm/virt-acpi-build: Add PPTT table

2021-05-19 Thread Salil Mehta
> From: Andrew Jones [mailto:drjo...@redhat.com] > Sent: Wednesday, May 19, 2021 9:15 AM > > On Wed, May 19, 2021 at 07:54:37AM +, Salil Mehta wrote: > > > From: wangyanan (Y) > > > Sent: Wednesday, May 19, 2021 4:18 AM > > > > > > > > > On 2021/5/19 3:22, Salil Mehta wrote: > > > >> From: And

[Bug 1761798] Re: live migration intermittently fails in CI with "VQ 0 size 0x80 Guest index 0x12c inconsistent with Host index 0x134: delta 0xfff8"

2021-05-19 Thread ignazio
I got same issue on centos 7 stein -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1761798 Title: live migration intermittently fails in CI with "VQ 0 size 0x80 Guest index 0x12c inconsistent with

[PATCH 2/5] esp: handle non-DMA transfers from the target one byte at a time

2021-05-19 Thread Mark Cave-Ayland
The initial implementation of non-DMA transfers was based upon analysis of traces from the MacOS toolbox ROM for handling unaligned reads but missed one key aspect - during a non-DMA transfer from the target, the bus service interrupt should be raised for every single byte received from the bus an

[PATCH 0/5] esp: fixes for MacOS toolbox ROM

2021-05-19 Thread Mark Cave-Ayland
This patchset contains more ESP fixes from my attempts to boot MacOS under the QEMU q800 machine (along with a related NetBSD fix). With these patches it is possible for the MacOS toolbox ROM and MacOS drivers to detect and access SCSI drives and CDROMs during the MacOS boot process. This patchse

[PATCH 3/5] esp: ensure PDMA write transfers are flushed from the FIFO to the target immediately

2021-05-19 Thread Mark Cave-Ayland
After each PDMA write transfer the MacOS CDROM driver waits until the FIFO is empty (i.e. its contents have been written out to the SCSI bus) by polling the FIFO count register until it reads 0. This doesn't work with the current PDMA write implementation which waits until either the FIFO is full

[PATCH 1/5] esp: allow non-DMA callback in esp_transfer_data() initial transfer

2021-05-19 Thread Mark Cave-Ayland
The current implementation only resumes DMA transfers when incoming data is received from the target device, but this is also required for non-DMA transfers with the next set of non-DMA changes. Rather than duplicate the DMA/non-DMA dispatch logic in the initial transfer section, update the code s

[PATCH 5/5] esp: correctly accumulate extended messages for PDMA

2021-05-19 Thread Mark Cave-Ayland
Commit 799d90d818 "esp: transition to message out phase after SATN and stop command" added logic to correctly handle extended messages for DMA requests but not for PDMA requests. Apply the same logic in esp_do_dma() to do_dma_pdma_cb() so that extended messages terminated with a PDMA request are a

[PATCH 4/5] esp: revert 75ef849696 "esp: correctly fill bus id with requested lun"

2021-05-19 Thread Mark Cave-Ayland
This commit from nearly 10 years ago no longer appears to be required and in its current form prevents the MacOS CDROM driver from detecting the CDROM drive. The error is caused by the MacOS CDROM driver sending this CDB without DMA: 0x12 0x00 0x00 0x00 0x05 0x00 (INQUIRY) This is a valid INQ

Re: [PATCH 01/21] block: introduce bdrv_replace_child_bs()

2021-05-19 Thread Vladimir Sementsov-Ogievskiy
17.05.2021 15:09, Max Reitz wrote: On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote: Add function to transactionally replace bs inside BdrvChild. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   include/block/block.h |  2 ++   block.c   | 36 ++

Re: [RFC PATCH] block/vpc: Support probing of fixed-size VHD images

2021-05-19 Thread Thomas Huth
On 29/03/2021 09.25, Thomas Huth wrote: Fixed-size VHD images don't have a header, only a footer. To be able to still detect them right, support probing via the file name, too. Without this change, images get detected as raw: $ qemu-img create -f vpc -o subformat=fixed test.vhd 2G Formatting 't

Re: [PATCH] block/file-posix: Fix problem with fallocate(PUNCH_HOLE) on GPFS

2021-05-19 Thread Thomas Huth
On 19/04/2021 07.06, Thomas Huth wrote: On 16/04/2021 22.34, Nir Soffer wrote: On Fri, Apr 16, 2021 at 8:23 AM Thomas Huth wrote: A customer reported that running   qemu-img convert -t none -O qcow2 -f qcow2 input.qcow2 output.qcow2 fails for them with the following error message when the i

Re: [PATCH] block/file-posix: Fix problem with fallocate(PUNCH_HOLE) on GPFS

2021-05-19 Thread Thomas Huth
On 19/05/2021 12.21, Thomas Huth wrote: On 19/04/2021 07.06, Thomas Huth wrote: On 16/04/2021 22.34, Nir Soffer wrote: On Fri, Apr 16, 2021 at 8:23 AM Thomas Huth wrote: A customer reported that running   qemu-img convert -t none -O qcow2 -f qcow2 input.qcow2 output.qcow2 fails for them wi

Re: [PATCH] qemu-io-cmds: assert that we don't have .perm requested in no-blk case

2021-05-19 Thread Kevin Wolf
Am 19.05.2021 um 11:05 hat Vladimir Sementsov-Ogievskiy geschrieben: > Coverity things blk may be NULL. It's a false-positive, as described in s/things/thinks/ > a new comment. > > Fixes: Coverity CID 1453194 > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qemu-io-cmds.c | 14 +++

Re: [PULL 17/20] configure: Poison all current target-specific #defines

2021-05-19 Thread Thomas Huth
On 16/05/2021 22.58, Philippe Mathieu-Daudé wrote: On 5/14/21 2:15 PM, Thomas Huth wrote: We are generating a lot of target-specific defines in the *-config-devices.h and *-config-target.h files. Using them in common code is wrong and leads to very subtle bugs since a "#ifdef CONFIG_SOMETHING" i

[PATCH] target/xtensa: fix access ring in l32ex

2021-05-19 Thread Max Filippov
l32ex does memory access as all regular load/store operations at CRING level. Fix apparent pasto from l32e that caused it to use RING instead. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Filippov --- target/xtensa/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: [PATCH v12 4/8] arm64: kvm: Introduce MTE VM feature

2021-05-19 Thread Steven Price
On 17/05/2021 17:45, Marc Zyngier wrote: > On Mon, 17 May 2021 13:32:35 +0100, > Steven Price wrote: >> >> Add a new VM feature 'KVM_ARM_CAP_MTE' which enables memory tagging >> for a VM. This will expose the feature to the guest and automatically >> tag memory pages touched by the VM as PG_mte_ta

[PATCH v4] target/xtensa: clean up unaligned access

2021-05-19 Thread Max Filippov
Xtensa cores may or may not have hardware support for unaligned memory access. Remove TARGET_ALIGNED_ONLY=y from all xtensa configurations and pass MO_ALIGN in memory access flags for all operations that would raise an exception. Simplify use of gen_load_store_alignment by passing access size and a

[PATCH] Update libslirp to v4.5.0

2021-05-19 Thread marcandre . lureau
From: Marc-André Lureau Switch from stable-4.2 branch to upstream v4.5.0 release. ## [4.5.0] - 2021-05-18 ### Added - IPv6 forwarding. !62 !75 !77 - slirp_neighbor_info() to dump the ARP/NDP tables. !71 ### Changed - Lazy guest address resolution for IPv6. !81 - Improve signal handling w

Re: [RFC PATCH] block/vpc: Support probing of fixed-size VHD images

2021-05-19 Thread Kevin Wolf
Am 29.03.2021 um 09:25 hat Thomas Huth geschrieben: > Fixed-size VHD images don't have a header, only a footer. To be able > to still detect them right, support probing via the file name, too. > > Without this change, images get detected as raw: > > $ qemu-img create -f vpc -o subformat=fixed tes

[PATCH] configure: Avoid error messages about missing *-config-*.h files

2021-05-19 Thread Thomas Huth
When compiling with --disable-system there is a harmless yet still annoying error message at the end of the "configure" step: sed: can't read *-config-devices.h: No such file or directory When only building the tools or docs, without any emulator at all, there is even an additional message about

Re: [PATCH v5 1/6] hw/isa/Kconfig: Fix missing dependency ISA_SUPERIO -> FDC

2021-05-19 Thread Philippe Mathieu-Daudé
On 5/19/21 10:23 AM, Thomas Huth wrote: > On 18/05/2021 21.32, Philippe Mathieu-Daudé wrote: >> isa_superio_realize() calls isa_fdc_init_drives(), which is defined >> in hw/block/fdc.c, so ISA_SUPERIO needs to select the FDC symbol. > > If I get that right, not all superio chipsets provide a flopp

Re: [PATCH] configure: Avoid error messages about missing *-config-*.h files

2021-05-19 Thread Philippe Mathieu-Daudé
On 5/19/21 12:57 PM, Thomas Huth wrote: > When compiling with --disable-system there is a harmless yet still > annoying error message at the end of the "configure" step: > > sed: can't read *-config-devices.h: No such file or directory > > When only building the tools or docs, without any emulat

Re: GSoC introduction: Rust vhost-user-scsi device

2021-05-19 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:14:36AM +0100, Stefan Hajnoczi wrote: > On Tue, May 18, 2021 at 07:10:31PM -0700, Gaelan Steele wrote: > > I'm Gaelan Steele, one of QEMU's Google Summer of Code students this > > year. My mentor (Sergio Lopez) has asked me to introduce myself and my > > project here. >

Re: [PATCH 01/21] block: introduce bdrv_replace_child_bs()

2021-05-19 Thread Max Reitz
On 19.05.21 12:12, Vladimir Sementsov-Ogievskiy wrote: 17.05.2021 15:09, Max Reitz wrote: On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote: Add function to transactionally replace bs inside BdrvChild. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   include/block/block.h |  2 ++   block

Re: [PATCH 01/21] block: introduce bdrv_replace_child_bs()

2021-05-19 Thread Vladimir Sementsov-Ogievskiy
19.05.2021 14:11, Max Reitz wrote: On 19.05.21 12:12, Vladimir Sementsov-Ogievskiy wrote: 17.05.2021 15:09, Max Reitz wrote: On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote: Add function to transactionally replace bs inside BdrvChild. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   i

Re: [PATCH v2 0/2] target/i386: Make sure that vsyscall's tb->size != 0

2021-05-19 Thread Cornelia Huck
On Wed, 19 May 2021 06:57:36 +0200 Ilya Leoshkevich wrote: > This series for the s390-next tree fixes [1]. Patch 1 is the fix, patch > 2 is the new test to avoid similar regressions in the future. > > [1] https://lists.nongnu.org/archive/html/qemu-devel/2021-05/msg02962.html > > v1: https://lis

Re: RFC: Qemu backup interface plans

2021-05-19 Thread Kevin Wolf
Am 19.05.2021 um 08:11 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > 2. Test, that we can start backup job with source = (target of > > > backup-top filter), so that we have "push backup with fleecing". > > > Make an option for backup to start without a filter, when we don't > > > need copy-b

[PATCH] MAINTAINERS: update block/rbd.c maintainer

2021-05-19 Thread Ilya Dryomov
Jason has moved on from working on RBD and Ceph. I'm taking over his role upstream. Signed-off-by: Ilya Dryomov --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index eab178aeee5e..3e77ac9030fa 100644 --- a/MAINTAINERS +++ b/MAINTAINE

Re: [PULL v3 0/1] Rtd patches

2021-05-19 Thread Philippe Mathieu-Daudé
On 5/16/21 6:03 PM, Peter Maydell wrote: > On Sat, 15 May 2021 at 20:02, Marc-André Lureau > wrote: >> Otherwise, you should get a warning and doc will be disabled. Mine is less >> ugly than yours, not sure why: > > I think that's a sphinx-version dependent thing. I requested that > they improve

Re: [PATCH] configure: Avoid error messages about missing *-config-*.h files

2021-05-19 Thread Thomas Huth
On 19/05/2021 13.08, Philippe Mathieu-Daudé wrote: On 5/19/21 12:57 PM, Thomas Huth wrote: When compiling with --disable-system there is a harmless yet still annoying error message at the end of the "configure" step: sed: can't read *-config-devices.h: No such file or directory When only bui

[PATCH] i386/kvm: The value passed to strerror should be positive

2021-05-19 Thread Dmitry Voronetskiy
From: Dmitry Voronetskiy Signed-off-by: Dmitry Voronetskiy --- hw/i386/kvm/apic.c | 2 +- hw/i386/kvm/clock.c | 4 ++-- hw/i386/kvm/i8254.c | 10 +- hw/i386/kvm/i8259.c | 4 ++-- hw/i386/kvm/ioapic.c | 4 ++-- 5 files changed, 12 insertions(+), 12 deletions(-) diff --git a/hw

[PATCH v2] configure: Avoid error messages about missing *-config-*.h files

2021-05-19 Thread Thomas Huth
When compiling with --disable-system there is a harmless yet still annoying error message at the end of the "configure" step: sed: can't read *-config-devices.h: No such file or directory When only building the tools or docs, without any emulator at all, there is even an additional message about

Re: Qemu block filter insertion/removal API

2021-05-19 Thread Kevin Wolf
Am 17.05.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > I'd like to be sure that we know where we are going to. > > In blockdev-era where qemu user is aware about block nodes, all nodes have > good names and controlled by user we can efficiently use block filters. > >

Re: RFC: Qemu backup interface plans

2021-05-19 Thread Vladimir Sementsov-Ogievskiy
19.05.2021 14:20, Kevin Wolf wrote: Am 19.05.2021 um 08:11 hat Vladimir Sementsov-Ogievskiy geschrieben: 2. Test, that we can start backup job with source = (target of backup-top filter), so that we have "push backup with fleecing". Make an option for backup to start without a filter, when we do

Re: RFC: Qemu backup interface plans

2021-05-19 Thread Kevin Wolf
Am 19.05.2021 um 13:49 hat Vladimir Sementsov-Ogievskiy geschrieben: > 19.05.2021 14:20, Kevin Wolf wrote: > > Am 19.05.2021 um 08:11 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > > > 2. Test, that we can start backup job with source = (target of > > > > > backup-top filter), so that we have

Re: [PATCH v6 5/9] ui/vdagent: add mouse support

2021-05-19 Thread Markus Armbruster
Gerd Hoffmann writes: > This patch adds support for mouse messages to the vdagent > implementation. This can be enabled/disabled using the new > 'mouse' parameter for the vdagent chardev. Default is on. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Marc-André Lureau QAPI schema Acked-by: M

Re: Qemu block filter insertion/removal API

2021-05-19 Thread Vladimir Sementsov-Ogievskiy
19.05.2021 14:44, Kevin Wolf wrote: Am 17.05.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: Hi all! I'd like to be sure that we know where we are going to. In blockdev-era where qemu user is aware about block nodes, all nodes have good names and controlled by user we can efficien

Re: [PATCH v4] plugins/syscall: Added a table-like summary output

2021-05-19 Thread Alex Bennée
Mahmoud Mandour writes: > Added a table-like output which contains the total number of calls > for each used syscall along with the number of errors that occurred. > > Per-call tracing is still available through supplying the argument > ``print`` to the plugin. > > Signed-off-by: Mahmoud Mandou

Re: [PATCH v2] configure: Avoid error messages about missing *-config-*.h files

2021-05-19 Thread Philippe Mathieu-Daudé
On 5/19/21 1:38 PM, Thomas Huth wrote: > When compiling with --disable-system there is a harmless yet still > annoying error message at the end of the "configure" step: > > sed: can't read *-config-devices.h: No such file or directory > > When only building the tools or docs, without any emulato

[PULL 03/48] target/ppc: Fold gen_*_xer into their callers

2021-05-19 Thread David Gibson
From: "Bruno Larsen (billionai)" folded gen_{read,write}_xer into their only callers, spr_{read,write}_xer Signed-off-by: Bruno Larsen (billionai) Reviewed-by: Richard Henderson Message-Id: <20210504140157.76066-2-bruno.lar...@eldorado.org.br> Signed-off-by: David Gibson --- target/ppc/trans

[PULL 01/48] hw/ppc/spapr.c: Extract MMU mode error reporting into a function

2021-05-19 Thread David Gibson
From: Fabiano Rosas A following patch will make use of it. Signed-off-by: Fabiano Rosas Message-Id: <20210505001130.368-2-faro...@linux.ibm.com> Signed-off-by: David Gibson --- hw/ppc/spapr.c | 16 hw/ppc/spapr_hcall.c | 14 ++ include/hw/ppc/spapr.h

[PULL 02/48] hw/ppc/spapr.c: Make sure the host supports the selected MMU mode

2021-05-19 Thread David Gibson
From: Fabiano Rosas Starting with Linux kernel v5.12 we dropped support[1] in KVM for hosts that can't have their threads running in different MMU modes (POWER9 < DD2.2). In these hosts, KVM will no longer report the KVM_CAP_PPC_MMU_HASH_V3 capability[2] when the host is running Radix. For guest

[PULL 04/48] target/ppc: renamed SPR registration functions

2021-05-19 Thread David Gibson
From: "Bruno Larsen (billionai)" Renamed all gen_spr_* and gen_* functions specifically related to registering SPRs to register_*_sprs and register_*, to avoid future confusion with other TCG related code. Signed-off-by: Bruno Larsen (billionai) Reviewed-by: Richard Henderson Message-Id: <2021

[PULL 00/48] ppc-for-6.1 queue 20210519

2021-05-19 Thread David Gibson
t tags/ppc-for-6.1-20210519 for you to fetch changes up to e543f946856da31c3a7a45ba193f106e042ad907: target/ppc: Remove type argument for mmubooke206_get_physical_address (2021-05-19 12:52:07 +1000) ppc patch queue 2021-05-19 Next

[PULL 08/48] target/ppc: moved ppc_store_lpcr to misc_helper.c

2021-05-19 Thread David Gibson
From: "Lucas Mateus Castro (alqotel)" Moved the function ppc_store from mmu-hash64.c to misc_helper.c and the prototype from mmu-hash64.h to cpu.h as it is a more appropriate place, but it will have to have its implementation moved to a new file as misc_helper.c should not be compiled in a !TCG e

[PULL 09/48] hw/ppc: moved has_spr to cpu.h

2021-05-19 Thread David Gibson
From: "Lucas Mateus Castro (alqotel)" Moved has_spr to cpu.h as ppc_has_spr and turned it into an inline function. Change spr verification in pnv.c and spapr.c to a version that can compile in a !TCG environment. Signed-off-by: Lucas Mateus Castro (alqotel) Message-Id: <20210507164146.67086-1-l

[PULL 10/48] target/ppc: turned SPR R/W callbacks not static

2021-05-19 Thread David Gibson
From: "Bruno Larsen (billionai)" To be able to compile translate_init.c.inc as a standalone file, we have to make the callbacks accessible outside of translate.c; This patch does exactly that Signed-off-by: Bruno Larsen (billionai) Message-Id: <20210507115512.11376-1-bruno.lar...@eldorado.org.b

[PULL 11/48] target/ppc: isolated cpu init from translation logic

2021-05-19 Thread David Gibson
From: "Bruno Larsen (billionai)" finished isolation of CPU initialization logic from translation logic. CPU initialization now only has common code and may or may not call accelerator-specific code, as the build options require. Signed-off-by: Bruno Larsen (billionai) Reviewed-by: David Gibson

[PULL 07/48] target/ppc: moved function out of mmu-hash64

2021-05-19 Thread David Gibson
From: "Lucas Mateus Castro (alqotel)" The function ppc_hash64_filter_pagesizes has been moved from a function with prototype in mmu-hash64.h and implemented in mmu-hash64.c to a static function in hw/ppc/spapr_caps.c as it's only used in that file. Signed-off-by: Lucas Mateus Castro (alqotel) M

[PULL 12/48] target/ppc: created ppc_{store, get}_vscr for generic vscr usage

2021-05-19 Thread David Gibson
From: "Bruno Larsen (billionai)" Some functions unrelated to TCG use helper_m{t,f}vscr, so generic versions of those functions were added to cpu.c, in preparation for compilation without TCG Signed-off-by: Bruno Larsen (billionai) Message-Id: <20210512140813.112884-2-bruno.lar...@eldorado.org.b

[PULL 06/48] hw/ppc: moved hcalls that depend on softmmu

2021-05-19 Thread David Gibson
From: "Lucas Mateus Castro (alqotel)" The hypercalls h_enter, h_remove, h_bulk_remove, h_protect, and h_read, have been moved to spapr_softmmu.c with the functions they depend on. The functions is_ram_address and push_sregs_to_kvm_pr are not static anymore as functions on both spapr_hcall.c and s

[PULL 05/48] target/ppc: move SPR R/W callbacks to translate.c

2021-05-19 Thread David Gibson
From: "Bruno Larsen (billionai)" Moved all read and write callbacks for SPRs away from translate_init.c.inc and into translate.c; these functions are TCG only, so this motion is required to enable building with the flag disable-tcg Signed-off-by: Bruno Larsen (billionai) Reviewed-by: Richard He

[PULL 15/48] target/ppc: moved ppc_cpu_dump_state to cpu_init.c

2021-05-19 Thread David Gibson
From: "Bruno Larsen (billionai)" This function was forgotten in the cpu_init code motion series, but it seems to be used regardless of TCG, and so needs to be moved to support disabling TCG. Signed-off-by: Bruno Larsen (billionai) Message-Id: <20210512140813.112884-4-bruno.lar...@eldorado.org.b

[PULL 16/48] target/ppc: Add cia field to DisasContext

2021-05-19 Thread David Gibson
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Bruno Larsen (billionai) Reviewed-by: Luis Pires Signed-off-by: Matheus Ferst Message-Id: <20210512185441.3619828-2-matheus.fe...@eldorado.org.br> Signed-off-by: David Gibson --- target/ppc/translate.c | 36 ++

[PULL 13/48] target/ppc: updated vscr manipulation in machine.c

2021-05-19 Thread David Gibson
From: "Bruno Larsen (billionai)" Updated the code in machine.c to use the generic ppc_{store,get}_vscr instead of helper style functions, so it can build without TCG Signed-off-by: Bruno Larsen (billionai) Message-Id: <20210512140813.112884-7-bruno.lar...@eldorado.org.br> Signed-off-by: David G

[PULL 14/48] target/ppc: moved ppc_store_sdr1 to cpu.c

2021-05-19 Thread David Gibson
From: "Bruno Larsen (billionai)" Moved this function that is required in !TCG cases into a common code file Signed-off-by: Bruno Larsen (billionai) Message-Id: <20210512140813.112884-3-bruno.lar...@eldorado.org.br> Reviewed-by: Richard Henderson [dwg: Fixed compile error with linux-user target

[PULL 19/48] target/ppc: Remove special case for POWERPC_SYSCALL

2021-05-19 Thread David Gibson
From: Richard Henderson Since POWERPC_SYSCALL is raised by gen_exception_err, we will have also set DISAS_NORETURN. Signed-off-by: Richard Henderson Reviewed-by: Luis Pires Signed-off-by: Matheus Ferst Message-Id: <20210512185441.3619828-5-matheus.fe...@eldorado.org.br> Signed-off-by: David G

[PULL 20/48] target/ppc: Remove special case for POWERPC_EXCP_TRAP

2021-05-19 Thread David Gibson
From: Richard Henderson Since POWERPC_EXCP_TRAP is raised by gen_exception_err, we will have also set DISAS_NORETURN. Signed-off-by: Richard Henderson Reviewed-by: Luis Pires Signed-off-by: Matheus Ferst Message-Id: <20210512185441.3619828-6-matheus.fe...@eldorado.org.br> Signed-off-by: David

[PULL 17/48] target/ppc: Split out decode_legacy

2021-05-19 Thread David Gibson
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Luis Pires Signed-off-by: Matheus Ferst Message-Id: <20210512185441.3619828-3-matheus.fe...@eldorado.org.br> Signed-off-by: David Gibson --- target/ppc/translate.c | 115 +++-- 1 file ch

[PULL 22/48] target/ppc: Introduce DISAS_{EXIT,CHAIN}{,_UPDATE}

2021-05-19 Thread David Gibson
From: Richard Henderson Rewrite ppc_tr_tb_stop to handle these new codes. Convert ctx->exception into these new codes at the end of ppc_tr_translate_insn, prior to pushing the change back throughout translate.c. Signed-off-by: Richard Henderson Signed-off-by: Matheus Ferst Message-Id: <202105

[PULL 26/48] target/ppc: Replace POWERPC_EXCP_STOP with DISAS_EXIT_UPDATE

2021-05-19 Thread David Gibson
From: Richard Henderson Remove the synthetic "exception" after no more uses. Signed-off-by: Richard Henderson Signed-off-by: Matheus Ferst Message-Id: <20210517205025.3777947-3-matheus.fe...@eldorado.org.br> Signed-off-by: David Gibson --- linux-user/ppc/cpu_loop.c | 3 --- target/ppc/cpu.h

[PULL 18/48] target/ppc: Move DISAS_NORETURN setting into gen_exception*

2021-05-19 Thread David Gibson
From: Richard Henderson There are other valid settings for is_jmp besides DISAS_NEXT and DISAS_NORETURN, so eliminating that dichotomy from ppc_tr_translate_insn is helpful. Signed-off-by: Richard Henderson Reviewed-by: Luis Pires Signed-off-by: Matheus Ferst Message-Id: <20210512185441.36198

[PULL 21/48] target/ppc: Simplify gen_debug_exception

2021-05-19 Thread David Gibson
From: Richard Henderson Two of the call sites that use gen_debug_exception have already updated NIP. Only ppc_tr_breakpoint_check requires the update. Signed-off-by: Richard Henderson Signed-off-by: Matheus Ferst Message-Id: <20210512185441.3619828-7-matheus.fe...@eldorado.org.br> Signed-off-

[PULL 24/48] target/ppc: Remove unnecessary gen_io_end calls

2021-05-19 Thread David Gibson
From: Richard Henderson Since ba3e7926691ed33, we switched the implementation of icount to always reset can_do_io at the start of the following TB. Most of them were removed in 9e9b10c64911, but some were missed. Signed-off-by: Richard Henderson Signed-off-by: Matheus Ferst Message-Id: <202105

[PULL 32/48] target/ppc: Use translator_loop_temp_check

2021-05-19 Thread David Gibson
From: Richard Henderson The special logging is unnecessary. It will have been done immediately before in the log file. Signed-off-by: Richard Henderson Signed-off-by: Matheus Ferst Reviewed-by: Bruno Larsen (billionai) Message-Id: <20210517205025.3777947-9-matheus.fe...@eldorado.org.br> Sign

[PULL 23/48] target/ppc: Replace POWERPC_EXCP_SYNC with DISAS_EXIT

2021-05-19 Thread David Gibson
From: Richard Henderson Remove the synthetic "exception" after no more uses. Signed-off-by: Richard Henderson Signed-off-by: Matheus Ferst Message-Id: <20210512185441.3619828-9-matheus.fe...@eldorado.org.br> Reviewed-by: Bruno Larsen (billionai) Signed-off-by: David Gibson --- target/ppc/cp

[PULL 27/48] target/ppc: Replace POWERPC_EXCP_BRANCH with DISAS_NORETURN

2021-05-19 Thread David Gibson
From: Richard Henderson The translation of branch instructions always results in exit from the TB. Remove the synthetic "exception" after no more uses. Signed-off-by: Richard Henderson Signed-off-by: Matheus Ferst Message-Id: <20210517205025.3777947-4-matheus.fe...@eldorado.org.br> Signed-off-

[PULL 28/48] target/ppc: Remove DisasContext.exception

2021-05-19 Thread David Gibson
From: Richard Henderson Now that we have removed all of the fake exceptions, and all real exceptions exit via DISAS_NORETURN, we can remove this field. Signed-off-by: Richard Henderson Signed-off-by: Matheus Ferst Message-Id: <20210517205025.3777947-5-matheus.fe...@eldorado.org.br> Signed-off-

[PULL 30/48] target/ppc: Tidy exception vs exit_tb

2021-05-19 Thread David Gibson
From: Richard Henderson We do not need to emit an exit_tb after an exception, as the latter will exit via longjmp. Signed-off-by: Richard Henderson Signed-off-by: Matheus Ferst Message-Id: <20210517205025.3777947-7-matheus.fe...@eldorado.org.br> Signed-off-by: David Gibson --- target/ppc/tra

[PULL 36/48] target/ppc: Use MMUAccessType in mmu-hash64.c

2021-05-19 Thread David Gibson
From: Richard Henderson We must leave the 'int rwx' parameter to ppc_hash64_handle_mmu_fault for now, but will clean that up later. Signed-off-by: Ricgard Henderson Message-Id: <20210518201146.794854-4-richard.hender...@linaro.org> Signed-off-by: David Gibson --- target/ppc/mmu-hash64.c | 61

[PULL 34/48] target/ppc: Introduce prot_for_access_type

2021-05-19 Thread David Gibson
From: Richard Henderson Use this in the three places we currently have a local array indexed by rwx (which happens to have the same values). The types will match up correctly with additional changes. Signed-off-by: Richard Henderson Message-Id: <20210518201146.794854-2-richard.hender...@linaro.

[PULL 29/48] target/ppc: Move single-step check to ppc_tr_tb_stop

2021-05-19 Thread David Gibson
From: Richard Henderson When single-stepping, force max_insns to 1 in init_disas so that we exit the translation loop immediately. Combine the single-step checks in tb_stop, and give the gdb exception priority over the cpu exception, just as we already do in gen_lookup_and_goto_ptr. Signed-off-

[PULL 42/48] target/ppc: Remove type argument from ppc6xx_tlb_check

2021-05-19 Thread David Gibson
From: Richard Henderson We can now use MMU_INST_FETCH from access_type for this. Signed-off-by: Richard Henderson Message-Id: <20210518201146.794854-10-richard.hender...@linaro.org> Signed-off-by: David Gibson --- target/ppc/mmu_helper.c | 10 -- 1 file changed, 4 insertions(+), 6 del

[PULL 33/48] target/ppc: Fix load endianness for lxvwsx/lxvdsx

2021-05-19 Thread David Gibson
From: Giuseppe Musacchio TARGET_WORDS_BIGENDIAN may not match the machine endianness if that's a runtime-configurable parameter. Fixes: bcb0b7b1a1c05707304f80ca6f523d557816f85c Fixes: afae37d98ae991c0792c867dbd9f32f988044318 Resolves: https://gitlab.com/qemu-project/qemu/-/issues/212 Signed-off

[PULL 25/48] target/ppc: Introduce gen_icount_io_start

2021-05-19 Thread David Gibson
From: Richard Henderson Create a function to handle the details for interacting with icount. Force the exit from the tb via DISAS_TOO_MANY, which allows chaining to the next tb, where the code emitted for gen_tb_start() will determine if we must exit. We can thus remove any matching conditional

[PULL 41/48] target/ppc: Remove type argument from ppc6xx_tlb_pte_check

2021-05-19 Thread David Gibson
From: Richard Henderson It is no longer used. Signed-off-by: Richard Henderson Message-Id: <20210518201146.794854-9-richard.hender...@linaro.org> Signed-off-by: David Gibson --- target/ppc/mmu_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/ppc/mmu_help

[PULL 31/48] target/ppc: Mark helper_raise_exception* as noreturn

2021-05-19 Thread David Gibson
From: Richard Henderson Signed-off-by: Richard Henderson Signed-off-by: Matheus Ferst Message-Id: <20210517205025.3777947-8-matheus.fe...@eldorado.org.br> Signed-off-by: David Gibson --- target/ppc/helper.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/ppc/hel

[PULL 35/48] target/ppc: Use MMUAccessType in mmu-radix64.c

2021-05-19 Thread David Gibson
From: Richard Henderson We must leave the 'int rwx' parameter to ppc_radix64_handle_mmu_fault for now, but will clean that up later. Signed-off-by: Richard Henderson Message-Id: <20210518201146.794854-3-richard.hender...@linaro.org> Signed-off-by: David Gibson --- target/ppc/mmu-radix64.c | 1

[PULL 38/48] target/ppc: Rename access_type to type in mmu_helper.c

2021-05-19 Thread David Gibson
From: Richard Henderson The variable that holds ACCESS_INT, ACCESS_FLOAT, etc is variously called 'int type' or 'int access_type' within this file. Standardize on 'int type' throughout. Signed-off-by: Richard Henderson Message-Id: <20210518201146.794854-6-richard.hender...@linaro.org> Signed-o

[PULL 37/48] target/ppc: Use MMUAccessType in mmu-hash32.c

2021-05-19 Thread David Gibson
From: Richard Henderson We must leave the 'int rwx' parameter to ppc_hash32_handle_mmu_fault for now, but will clean that up later. Signed-off-by: Richard Henderson Message-Id: <20210518201146.794854-5-richard.hender...@linaro.org> Signed-off-by: David Gibson --- target/ppc/mmu-hash32.c | 53

  1   2   3   4   5   >