Re: [PATCH] hw/display/qxl: Set pci rom address aligned with page size

2021-05-18 Thread Gerd Hoffmann
On Tue, May 18, 2021 at 09:06:31AM +0800, maobibo wrote: > Sorry I do not state the background clearly. > > Page size is 16K on my MIPS machine, and it supports running > guest OS in kvm mode and qxl vga card can used for VM. Ok. Please add that to the commit message. Also there is no need to r

RE: [RFC PATCH v3 4/9] hw/arm/virt: Initialize the present cpu members

2021-05-18 Thread Salil Mehta
> From: wangyanan (Y) > Sent: Tuesday, May 18, 2021 5:43 AM > > Hi Salil, > > On 2021/5/18 4:48, Salil Mehta wrote: > >> From: Qemu-arm > [mailto:qemu-arm-bounces+salil.mehta=huawei@nongnu.org] > >> On Behalf Of Yanan Wang > >> Sent: Sunday, May 16, 2021 11:29 AM > >> To: Peter Maydell ; Andr

Re: [PATCH] hw/display/qxl: Set pci rom address aligned with page size

2021-05-18 Thread maobibo
在 2021年05月18日 15:03, Gerd Hoffmann 写道: > On Tue, May 18, 2021 at 09:06:31AM +0800, maobibo wrote: >> Sorry I do not state the background clearly. >> >> Page size is 16K on my MIPS machine, and it supports running >> guest OS in kvm mode and qxl vga card can used for VM. > > Ok. Please add that

Re: [PATCH v4 0/9] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers

2021-05-18 Thread Philippe Mathieu-Daudé
Cc'ing Hervé, Aleksandar, Markus & Mark. On 5/17/21 11:11 PM, John Snow wrote: > On 5/17/21 4:50 PM, Philippe Mathieu-Daudé wrote: >> On 5/17/21 9:19 PM, John Snow wrote: >>> On 5/17/21 2:39 PM, Philippe Mathieu-Daudé wrote: The floppy disc controllers pulls in irrelevant devices (sysbus in

RE: [RFC PATCH v2 5/6] hw/arm/virt-acpi-build: Add PPTT table

2021-05-18 Thread Salil Mehta
> From: Qemu-arm [mailto:qemu-arm-bounces+salil.mehta=huawei@nongnu.org] > On Behalf Of wangyanan (Y) > Sent: Thursday, May 13, 2021 6:10 AM > > Hi Drew, > > I got a question below, and hope your reply. Thanks! > On 2021/4/13 16:07, Yanan Wang wrote: > > Add the Processor Properties Topology

[Bug 1824616] Re: Build succeeds despite flex/bison missing

2021-05-18 Thread Thomas Huth
Yes, let's mark this as fixed now. ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1824616 Title: Build succeeds despite flex/bison miss

Re: [PATCH] Signed-off-by: Dmitry Voronetskiy

2021-05-18 Thread Markus Armbruster
Dmitry Voronetskiy writes: > From: Dmitry Voronetskiy > > the value passed to strerror should be positive Your commit message is out of order :) With that fixed: Reviewed-by: Markus Armbruster How did you track these down?

Re: [PATCH] Fix `lxvdsx` (issue #212)

2021-05-18 Thread Greg Kurz
On Tue, 18 May 2021 08:40:36 +0200 Giuseppe Musacchio wrote: > The ISA [1] specifies the load order to be the target one, hence > the use of MO_TEQ in my patch (in both lxvwsx and lxvdsx). > > I believe the error is hidden in some of the .mak files: I could not > reproduce this problem with Qemu

Re: [PATCH] hw/display/qxl: Set pci rom address aligned with page size

2021-05-18 Thread Gerd Hoffmann
Hi, > > Is the host page size fixed on mips? > > No, it is not fixed on mips, and it can be selected by linux kernel config. Hmm. So the rom size can differ depending on host kernel config. Which is bad. It'll break live migration between hosts with different page sizes (or wouldn't that wor

Re: [RFC PATCH] block/io.c: Flush parent for quorum in generic code

2021-05-18 Thread Kevin Wolf
Am 18.05.2021 um 08:33 hat Lukas Straub geschrieben: > On Wed, 12 May 2021 15:49:57 +0800 > Zhang Chen wrote: > > > Fix the issue from this patch: > > [PATCH] block: Flush all children in generic code > > From 883833e29cb800b4d92b5d4736252f4004885191 > > > > Quorum driver do not have the primary

Re: [RFC PATCH v2 5/6] hw/arm/virt-acpi-build: Add PPTT table

2021-05-18 Thread Andrew Jones
On Tue, May 18, 2021 at 07:17:56AM +, Salil Mehta wrote: > > From: Qemu-arm [mailto:qemu-arm-bounces+salil.mehta=huawei@nongnu.org] > > On Behalf Of wangyanan (Y) > > Sent: Thursday, May 13, 2021 6:10 AM > > > > Hi Drew, > > > > I got a question below, and hope your reply. Thanks! > > On

Re: [RFC PATCH v3 3/9] hw/arm/virt: Add cpu-map to device tree

2021-05-18 Thread Andrew Jones
On Mon, May 17, 2021 at 11:00:07PM +0800, wangyanan (Y) wrote: > Hi Drew, > > On 2021/5/17 14:41, Andrew Jones wrote: > > On Sun, May 16, 2021 at 06:28:54PM +0800, Yanan Wang wrote: > > > From: Andrew Jones > > > > > > Support device tree CPU topology descriptions. > > > > > > In accordance wit

Re: [RFC PATCH v3 4/9] hw/arm/virt: Initialize the present cpu members

2021-05-18 Thread Andrew Jones
On Tue, May 18, 2021 at 07:04:51AM +, Salil Mehta wrote: > > From: wangyanan (Y) > > Sent: Tuesday, May 18, 2021 5:43 AM > > > > Hi Salil, > > > > On 2021/5/18 4:48, Salil Mehta wrote: > > >> From: Qemu-arm > > [mailto:qemu-arm-bounces+salil.mehta=huawei@nongnu.org] > > >> On Behalf Of Ya

Re: [PATCH] sockets: update SOCKET_ADDRESS_TYPE_FD listen(2) backlog

2021-05-18 Thread Richard W.M. Jones
On Tue, May 11, 2021 at 09:23:10AM +0100, Stefan Hajnoczi wrote: > On Tue, Mar 16, 2021 at 08:35:14AM -0500, Eric Blake wrote: > > On 3/16/21 4:10 AM, Stefan Hajnoczi wrote: > > > On Wed, Mar 10, 2021 at 05:30:04PM +, Stefan Hajnoczi wrote: > > >> socket_get_fd() fails with the error "socket_ge

Re: [ANNOUNCE] libblkio v0.1.0 preview release

2021-05-18 Thread Kevin Wolf
Am 17.05.2021 um 16:09 hat Stefan Hajnoczi geschrieben: > On Fri, May 14, 2021 at 05:55:13PM +0200, Kevin Wolf wrote: > > Am 13.05.2021 um 11:47 hat Stefan Hajnoczi geschrieben: > > > On Thu, May 06, 2021 at 12:33:24PM +0200, Kevin Wolf wrote: > > > > Am 06.05.2021 um 10:46 hat Stefan Hajnoczi gesc

Re: [RFC PATCH v3 6/9] hw/arm/virt-acpi-build: Use possible cpus in generation of MADT

2021-05-18 Thread Andrew Jones
On Tue, May 18, 2021 at 12:27:59AM +0800, wangyanan (Y) wrote: > Hi Drew, > > On 2021/5/17 15:42, Andrew Jones wrote: > > On Sun, May 16, 2021 at 06:28:57PM +0800, Yanan Wang wrote: > > > When building ACPI tables regarding CPUs we should always build > > > them for the number of possible CPUs, no

Re: [RFC PATCH v3 4/4] hw/arm/virt: Parse -smp cluster parameter in virt_smp_parse

2021-05-18 Thread Andrew Jones
On Tue, May 18, 2021 at 11:48:34AM +0800, wangyanan (Y) wrote: > Hi Salil, > > On 2021/5/17 23:17, Salil Mehta wrote: > > > From: Qemu-devel > > > [mailto:qemu-devel-bounces+salil.mehta=huawei@nongnu.org] On Behalf Of > > > Yanan Wang > > > Sent: Sunday, May 16, 2021 11:32 AM > > > To: Peter M

[Bug 1924603] Re: Incorrect feature negotiation for vhost-vdpa netdevice

2021-05-18 Thread Gautam Dawar
Thanks Thomas Huth. I couldn't find an option to assign the issue on gitlab to anyone. Can you please help with that? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1924603 Title: Incorrect feature

Re: [PATCH] hw/display/qxl: Set pci rom address aligned with page size

2021-05-18 Thread maobibo
在 2021年05月18日 15:37, Gerd Hoffmann 写道: > Hi, > >>> Is the host page size fixed on mips? >> >> No, it is not fixed on mips, and it can be selected by linux kernel config. > > Hmm. So the rom size can differ depending on host kernel config. > Which is bad. It'll break live migration between

[PATCH 0/5] block: file-posix queue

2021-05-18 Thread Paolo Bonzini
Hi Max/Kevin, this is a combination of two series that both affect host block device support in block/file-posix.c. I suspect both of them evaded your radar, so I'm grouping them together and sending them out again. Joelle van Dyne (3): block: feature detection for host block support block:

[PATCH 3/5] block: feature detection for host block support

2021-05-18 Thread Paolo Bonzini
From: Joelle van Dyne On Darwin (iOS), there are no system level APIs for directly accessing host block devices. We detect this at configure time. Signed-off-by: Joelle van Dyne Message-Id: <20210315180341.31638-...@getutm.app> Signed-off-by: Paolo Bonzini --- block/file-posix.c | 33 ++

[PATCH 5/5] block: detect DKIOCGETBLOCKCOUNT/SIZE before use

2021-05-18 Thread Paolo Bonzini
From: Joelle van Dyne iOS hosts do not have these defined so we fallback to the default behaviour. Co-authored-by: Warner Losh Reviewed-by: Peter Maydell Signed-off-by: Joelle van Dyne Message-Id: <20210315180341.31638-...@getutm.app> Signed-off-by: Paolo Bonzini --- block/file-posix.c | 21

RE: [RFC PATCH] block/io.c: Flush parent for quorum in generic code

2021-05-18 Thread Zhang, Chen
> -Original Message- > From: Kevin Wolf > Sent: Tuesday, May 18, 2021 3:39 PM > To: Lukas Straub > Cc: Zhang, Chen ; Max Reitz ; > Stefan Hajnoczi ; Fam Zheng ; > qemu-dev ; qemu-block bl...@nongnu.org>; Minghao Yuan ; Zhang Chen > > Subject: Re: [RFC PATCH] block/io.c: Flush parent f

[PATCH 1/5] file-posix: try BLKSECTGET on block devices too, do not round to power of 2

2021-05-18 Thread Paolo Bonzini
bs->sg is only true for character devices, but block devices can also be used with scsi-block and scsi-generic. Unfortunately BLKSECTGET returns bytes in an int for /dev/sgN devices, and sectors in a short for block devices, so account for that in the code. The maximum transfer also need not be a

[PATCH 0/3] Small CI improvements

2021-05-18 Thread Paolo Bonzini
Patch 1 adjusts cirrus-ci to also test installation, and thus entitlement application on macOS. Patch 2 and 3 tweak the number of jobs during "make". Paolo Bonzini (3): cirrus-ci: test installation ci: do not use #processors+1 jobs, #processors is enough ci: add -j to all "make" jobs .cir

[PATCH 2/5] file-posix: fix max_iov for /dev/sg devices

2021-05-18 Thread Paolo Bonzini
Even though it was only called for devices that have bs->sg set (which must be character devices), sg_get_max_segments looked at /sys/dev/block which only works for block devices. On Linux the sg driver has its own way to provide the maximum number of iovecs in a scatter/gather list. Signed-off-b

[PATCH 4/5] block: check for sys/disk.h

2021-05-18 Thread Paolo Bonzini
From: Joelle van Dyne Some BSD platforms do not have this header. Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Joelle van Dyne Message-Id: <20210315180341.31638-...@getutm.app> Signed-off-by: Paolo Bonzini --- block.c | 2 +- meson.build | 1 + 2 files c

[PATCH 2/3] ci: do not use #processors+1 jobs, #processors is enough

2021-05-18 Thread Paolo Bonzini
I could not reconstruct the origin of the $(($(nproc) + 1)) idiom, but I suspect it was there only to have a sensible result when nproc or getconf do not exist. This can be achieved also with an "||". Signed-off-by: Paolo Bonzini --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 dele

[PATCH 1/3] cirrus-ci: test installation

2021-05-18 Thread Paolo Bonzini
Entitlements are applied via an install script that runs at installation time. Test it in CI. Signed-off-by: Paolo Bonzini --- .cirrus.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index f4bf49b704..340fd395c0 100644 --- a/.cirrus.yml +++ b

[PATCH 3/3] ci: add -j to all "make" jobs

2021-05-18 Thread Paolo Bonzini
Run the tests in parallel, as that can greatly speed up the jobs. "meson test" is able to report failures to the terminal in a way that is readable enough even when tests are run in parallel. Signed-off-by: Paolo Bonzini --- .cirrus.yml| 18 +- .gitlab-ci.yml | 8 .

Re: [PATCH] remove qemu-options* from root directory

2021-05-18 Thread Markus Armbruster
Paolo Bonzini writes: > These headers are also included from softmmu/vl.c, so they should be > in include/. Removing qemu-options-wrapper.h, since elsewhere > we include "template" headers directly and #define the parameters in > the including file, and move qemu-options.h to include/. > > Signe

Re: [PATCH 2/3] ci: do not use #processors+1 jobs, #processors is enough

2021-05-18 Thread Philippe Mathieu-Daudé
On 5/18/21 10:41 AM, Paolo Bonzini wrote: > I could not reconstruct the origin of the $(($(nproc) + 1)) idiom, I guess it is the historical way make would aggressively use the most compute power it could? Then later this bad habit impact was reduced by the -l option to keep make under some system

Re: [PATCH 3/3] ci: add -j to all "make" jobs

2021-05-18 Thread Philippe Mathieu-Daudé
On 5/18/21 10:41 AM, Paolo Bonzini wrote: > Run the tests in parallel, as that can greatly speed up the jobs. > "meson test" is able to report failures to the terminal in a way > that is readable enough even when tests are run in parallel. > > Signed-off-by: Paolo Bonzini > --- > .cirrus.yml

Re: [PATCH] fdc: check drive block device before usage (CVE-2021-20196)

2021-05-18 Thread P J P
Hello John, +-- On Mon, 17 May 2021, John Snow wrote --+ | > /* Selected drive */ | > -fdctrl->cur_drv = value & FD_DOR_SELMASK; | > +if (fdctrl->drives[value & FD_DOR_SELMASK].blk) { | > +fdctrl->cur_drv = value & FD_DOR_SELMASK; | > +} | | I don't think this is corre

[PULL v2 01/29] tests/docker: fix copying of executable in "update"

2021-05-18 Thread Alex Bennée
We have the same symlink chasing problem when doing an "update" operation. Fix that. Based-on: 5e33f7fead ("tests/docker: better handle symlinked libs") Signed-off-by: Alex Bennée Reviewed-by: Willian Rampazzo Message-Id: <20210512102051.12134-3-alex.ben...@linaro.org> diff --git a/tests/docker

[PULL v2 08/29] tests/tcg: don't iterate through other arch compilers

2021-05-18 Thread Alex Bennée
There should only be one compiler per architecture. Those cases where the same compiler can deal with a different architecture should be explicitly set for both cross_cc and docker configurations. Otherwise you get strangeness like: --cross-cc-aarch64=/bin/false causing the logic to attempt to

[PULL v2 00/29] testing and plugin updates

2021-05-18 Thread Alex Bennée
The following changes since commit 367196caa07ac31443bc360145cc10fbef4fdf92: Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-for-6.1-pull-request' into staging (2021-05-17 16:44:47 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pu

[PULL v2 02/29] tests/docker: make executable an optional argument to "update"

2021-05-18 Thread Alex Bennée
We're going to extend the abilities of the command shortly. Reviewed-by: Willian Rampazzo Signed-off-by: Alex Bennée Message-Id: <20210512102051.12134-4-alex.ben...@linaro.org> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 9f464cb92c..820423d718 100644 --- a/

[PULL v2 03/29] tests/docker: allow "update" to add the current user

2021-05-18 Thread Alex Bennée
The current user functionality is used for cross compiling to avoid complications with permissions when building test programs. However for images that come from the registry we still need the ability to add the user after the fact. Reviewed-by: Willian Rampazzo Signed-off-by: Alex Bennée Messag

[PULL v2 04/29] tests/docker: add "fetch" sub-command

2021-05-18 Thread Alex Bennée
This simply wraps up fetching a build from the registry and tagging it as the local build. Reviewed-by: Willian Rampazzo Signed-off-by: Alex Bennée Message-Id: <20210512102051.12134-6-alex.ben...@linaro.org> diff --git a/tests/docker/docker.py b/tests/docker/docker.py index 7a14058801..4d9bb7c7

[PULL v2 05/29] docker: Add Hexagon image

2021-05-18 Thread Alex Bennée
From: Alessandro Di Federico This image is a little special because it takes a long time to build. As such most users don't want to be doing that and just pull random binaries from the ether as intended by the container gods. This involves someone with credentials and a beefy machine running:

[PULL v2 09/29] tests/docker: Added libbpf library to the docker files.

2021-05-18 Thread Alex Bennée
From: Andrew Melnychenko The series of patches for eBPF RSS adds libbpf dependency for qemu. https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg08887.html With this patch, libbpf added: Alpine - added libbpf-dev Centos 8 - added libbpf-devel Fedora - added libbpf-devel Signed-off-by

[PULL v2 11/29] tests/tcg: Run timeout cmds using --foreground

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann when trying to run successful short tests from the Makefile timeout would not terminate. Rather it would wait until the time runs out. Excerpt from the manpage: --foreground when not running timeout directly from a shell prompt, allow COMMAND to read from the TTY

[PULL v2 07/29] gitlab: add build-user-hexagon test

2021-05-18 Thread Alex Bennée
We special case this as the container with the cross compiler for the tests takes so long to build it is manually uploaded into the registry. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Willian Rampazzo Tested-by: Philipp

[PULL v2 10/29] tests/tcg: Add docker_as and docker_ld cmds

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann At least for the TriCore target no easily available c compiler exists. Thus we need to rely on "as" and "ld". This allows us to run them through the docker image. We don't test the generation capabilities of docker images as they are assumed to work. Reviewed-by: Philipp

[PULL v2 16/29] tests/tcg/tricore: Add bmerge test

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann Tested-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-8-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-18-alex.ben...@linaro.org> diff --git a/tests/tcg/tricore/macros.h b/tests/tcg/tr

[PULL v2 19/29] tests/tcg/tricore: Add fadd test

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann Tested-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-11-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-21-alex.ben...@linaro.org> diff --git a/tests/tcg/tricore/Makefile.softmmu-targe

[PULL v2 06/29] tests/tcg: Use Hexagon Docker image

2021-05-18 Thread Alex Bennée
From: Alessandro Di Federico [PMD: Split from 'Add Hexagon Docker image' patch] Signed-off-by: Alessandro Di Federico Signed-off-by: Philippe Mathieu-Daudé [AJB: add container_hosts] Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id:

[PULL v2 13/29] tests/tcg/tricore: Add build infrastructure

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann this includes the Makefile and linker script to build all the tests. Reviewed-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-5-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-15-alex.be

Re: [PATCH v2 01/50] target/i386: Split out gen_exception_gpf

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:12, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 68 - 1 file changed, 37 insertions(+), 31 deletions(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index db56a48343..

[PULL v2 26/29] tests/tcg/ppc64le: tests for brh/brw/brd

2021-05-18 Thread Alex Bennée
From: Matheus Ferst Tests for Byte-Reverse Halfword, Word and Doubleword Signed-off-by: Matheus Ferst Tested-by: Fabiano Rosas [AJB: tweak to make rules for skip/plugins] Signed-off-by: Alex Bennée Message-Id: <20210423205757.1752480-3-matheus.fe...@eldorado.org.br> Message-Id: <2021051210205

[PULL v2 12/29] hw/tricore: Add testdevice for tests in tests/tcg/

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann this device is used to verify the correctness of regression tests by allowing guests to write their exit status to this device. This is then used by qemu to exit using the written status. Reviewed-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Be

Re: [PATCH 04/21] qdev: allow setting drive property for realized device

2021-05-18 Thread Max Reitz
On 17.05.21 20:09, Vladimir Sementsov-Ogievskiy wrote: 17.05.2021 18:48, Max Reitz wrote: On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote: We need an ability to insert filters above top block node, attached to block device. It can't be achieved with blockdev-reopen command. So, we want do

Re: [PATCH v2 03/50] target/i386: Unify code paths for IRET

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:12, Richard Henderson wrote: In vm86 mode, we use the same helper as real-mode, but with an extra check for IOPL. All non-exceptional paths set EFLAGS. Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 16 ++-- 1 file changed, 6 insertions(+), 10 d

[PULL v2 20/29] tests/tcg/tricore: Add fmul test

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann Tested-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-12-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-22-alex.ben...@linaro.org> diff --git a/tests/tcg/tricore/Makefile.softmmu-targe

[PULL v2 15/29] tests/tcg/tricore: Add macros to create tests and first test 'abs'

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann This kind of tests is inspired by the riscv-tests repository. This adds macros that makes it easy to create single instruction self containing tests. It is achieved by macros that create a test sequence for an instruction and check for a supplied correct value. If the va

[PULL v2 25/29] tests/docker: gcc-10 based images for ppc64{, le} tests

2021-05-18 Thread Alex Bennée
From: Matheus Ferst A newer compiler is needed to build tests for Power10 instructions. As done for arm64 on c729a99d2701, a new '-test-cross' image is created for ppc64 and ppc64le. As done on 936fda4d771f, a test for compiler support is added to verify that the toolchain in use has '-mpower10'.

[PULL v2 18/29] tests/tcg/tricore: Add dvstep test

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann Tested-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-10-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-20-alex.ben...@linaro.org> diff --git a/tests/tcg/tricore/macros.h b/tests/tcg/t

Re: [PATCH v2 02/50] target/i386: Split out check_cpl0

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:12, Richard Henderson wrote: Split out the check for CPL != 0 and the raising of #GP. Signed-off-by: Richard Henderson Reviewed-by: Paolo Bonzini --- target/i386/tcg/translate.c | 79 ++--- 1 file changed, 30 insertions(+), 49 deletions(-)

Re: [PATCH v2 09/50] target/i386: Assert !VM86 for x86_64 user-only

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: For i386-linux-user, we can enter vm86 mode via the vm86(2) syscall. That syscall explicitly returns to 32-bit mode, and the syscall does not exist for a 64-bit x86_64 executable. Since we're adding an accessor macro, pull the value directly out of fla

[PULL v2 28/29] tests/tcg: don't allow clang as a cross compiler

2021-05-18 Thread Alex Bennée
Currently there are two problems. The first is clang generates a preamble (that is always executed) to stack xmm registers. This causes a ILLOP on the x86_64 softmmu tests as SSE isn't enabled. The second is the inline assembler in test-i386.c breaks clangs compiler and I don't know how to fix it

[PULL v2 29/29] configure: use cc, not host_cc to set cross_cc for build arch

2021-05-18 Thread Alex Bennée
Otherwise you run into hilarity like trying when cross compiling a 32 bit ARM build on a 64 bit system trying to use host_cc to build 32 bit test cases. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20210512102051.12134-32-alex.ben...@linaro.org> diff --git a/confi

Re: [PATCH v2 05/50] target/i386: Split out check_iopl

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:12, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) Reviewed-by: Paolo Bonzini

Re: [PATCH v2 15/50] target/i386: Introduce REX_PREFIX

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: The existing flag, x86_64_hregs, does not accurately describe its setting. It is true if and only if a REX prefix has been seen. Yes, that affects the "h" regs, but that's secondary. Add PREFIX_REX and include this bit in s->prefix. Add REX_PREFIX s

[PULL v2 24/29] tests/tcg/tricore: Add muls test

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann Tested-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-16-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-26-alex.ben...@linaro.org> diff --git a/tests/tcg/tricore/Makefile.softmmu-targe

Re: [PATCH v2 06/50] target/i386: Assert PE is set for user-only

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:12, Richard Henderson wrote: A user-mode executable is never in real-mode. Since we're adding an accessor macro, pull the value directly out of flags for sysemu. Signed-off-by: Richard Henderson Reviewed-by: Paolo Bonzini

[PULL v2 14/29] configure: Emit HOST_CC to config-host.mak

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann this is needed by the tricore-tcg-tests as tricore-gcc is not easily available. Thus we rely on the HOST_CC to do the preprocessing of the tricore assembly files. Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-6-kbast...

Re: [PATCH v2 17/50] target/i386: Move rex_r into DisasContext

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: Treat this flag exactly like we treat rex_b and rex_x. Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 84 - 1 file changed, 45 insertions(+), 39 deletions(-) Reviewed-by: Paolo Bonzini

[PULL v2 23/29] tests/tcg/tricore: Add msub test

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann Tested-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-15-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-25-alex.ben...@linaro.org> diff --git a/tests/tcg/tricore/Makefile.softmmu-targe

[PULL v2 22/29] tests/tcg/tricore: Add madd test

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann Tested-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-14-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-24-alex.ben...@linaro.org> diff --git a/tests/tcg/tricore/macros.h b/tests/tcg/t

Re: [PATCH v2 19/50] target/i386: Remove DisasContext.f_st as unused

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index 4222f09b6f..7e296b39f5 100644 --- a/target/i386/tcg/translate.c +++

[PULL v2 27/29] tests/tcg: fix missing return

2021-05-18 Thread Alex Bennée
This was picked up when clang built the test. Signed-off-by: Alex Bennée Message-Id: <20210512102051.12134-30-alex.ben...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé diff --git a/tests/tcg/multiarch/system/memory.c b/tests/tcg/multiarch/system/memory.c index eb0ec6f8eb..41c7f66e2e 100644 -

Re: [PATCH v2 07/50] target/i386: Assert CPL is 3 for user-only

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:12, Richard Henderson wrote: A user-mode executable always runs in ring 3. Signed-off-by: Richard Henderson Reviewed-by: Paolo Bonzini

Re: [PATCH v2 08/50] target/i386: Assert IOPL is 0 for user-only

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: On real hardware, the linux kernel has the iopl(2) syscall which can set IOPL to 3, to allow e.g. the xserver to briefly disable interrupts while programming the graphics card. However, QEMU cannot and does not implement this syscall, so the IOPL is ne

[PULL v2 17/29] tests/tcg/tricore: Add clz test

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann Tested-by: Alex Bennée Signed-off-by: Bastian Koppelmann [AJB: dropped duplicate Makefile] Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-9-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-19-alex.ben...@linaro.org> diff --git a/tests/t

Re: [PATCH v2 20/50] target/i386: Reduce DisasContext.flags to uint32_t

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: The value comes from tb->flags, which is uint32_t. Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index

Re: [PATCH v2 13/50] target/i386: Assert LMA for x86_64 user-only

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: LMA is a pre-requisite for CODE64, so there is no way to disable it for x86_64-linux-user, and there is no way to enable it for i386. Since we're adding an accessor macro, pull the value directly out of flags when we're not assuming a constant. Signed

Re: [RFC PATCH v2 5/6] hw/arm/virt-acpi-build: Add PPTT table

2021-05-18 Thread wangyanan (Y)
On 2021/5/18 15:17, Salil Mehta wrote: From: Qemu-arm [mailto:qemu-arm-bounces+salil.mehta=huawei@nongnu.org] On Behalf Of wangyanan (Y) Sent: Thursday, May 13, 2021 6:10 AM Hi Drew, I got a question below, and hope your reply. Thanks! On 2021/4/13 16:07, Yanan Wang wrote: Add the Proces

Re: [PATCH v2 10/50] target/i386: Assert CODE32 for x86_64 user-only

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: For user-only, CODE32 == !VM86, because we are never in real-mode. Since we cannot enter vm86 mode for x86_64 user-only, CODE32 is always set. Since we're adding an accessor macro, pull the value directly out of flags otherwise. Signed-off-by: Richard

Re: [PATCH v2 22/50] target/i386: Reduce DisasContext.prefix to uint8_t

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: The highest bit in this set is 0x40 (PREFIX_REX). Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index 4

Re: [PATCH v2 23/50] target/i386: Reduce DisasContext.vex_[lv] to uint8_t

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: Currently, vex_l is either {0,1}; if in the future we implement AVX-512, the max value will be 2. In vex_v we store a register number. This is 0-15 for SSE, and 0-31 for AVX-512. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson

Re: [PATCH v2 24/50] target/i386: Reduce DisasContext popl_esp_hack and rip_offset to uint8_t

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: Both of these fields store the size of a single memory access, so the range of values is 0-8. Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/tcg/t

Re: [PATCH v2 11/50] target/i386: Assert SS32 for x86_64 user-only

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: For user-only, SS32 == !VM86, because we are never in real-mode. Since we cannot enter vm86 mode for x86_64 user-only, SS32 is always set. Since we're adding an accessor macro, pull the value directly out of flags otherwise. Signed-off-by: Richard He

Re: [PATCH 04/21] qdev: allow setting drive property for realized device

2021-05-18 Thread Vladimir Sementsov-Ogievskiy
18.05.2021 12:09, Max Reitz wrote: On 17.05.21 20:09, Vladimir Sementsov-Ogievskiy wrote: 17.05.2021 18:48, Max Reitz wrote: On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote: We need an ability to insert filters above top block node, attached to block device. It can't be achieved with blo

Re: [PATCH v2 25/50] target/i386: Leave TF in DisasContext.flags

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: It's just as easy to clear the flag with AND than assignment. In two cases the test for the bit can be folded together with the test for HF_INHIBIT_IRQ_MASK. Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 14 ++ 1 fi

[PATCH v2 1/5] ratelimit: treat zero speed as unlimited

2021-05-18 Thread Emanuele Giuseppe Esposito
From: Paolo Bonzini Both users of RateLimit, block-copy.c and blockjob.c, treat a speed of zero as unlimited, while RateLimit treats it as "as slow as possible". The latter is nicer from the code point of view but pretty useless, so disable rate limiting if a speed of zero is provided. Reviewed

Re: [PATCH v2 14/50] target/i386: Assert !ADDSEG for x86_64 user-only

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: LMA disables traditional segmentation, exposing a flat address space. This means that ADDSEG is off. Since we're adding an accessor macro, pull the value directly out of flags otherwise. Signed-off-by: Richard Henderson --- target/i386/tcg/translat

[PATCH v2 0/5] block-copy: make helper APIs thread safe

2021-05-18 Thread Emanuele Giuseppe Esposito
This serie of patches bring thread safety to the smaller APIs used by block-copy, namely ratelimit, progressmeter, co-shared-resource and aiotask. The end goal is to reduce the usage of AioContexlock in block-copy, by introducing smaller granularity locks thus on making the block layer thread safe.

Re: [PATCH v2 12/50] target/i386: Assert CODE64 for x86_64 user-only

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: For x86_64 user-only, there is no way to leave 64-bit mode. Without x86_64, there is no way to enter 64-bit mode. There is an existing macro to aid with that; simply place it in the right place in the ifdef chain. Since we're adding an accessor macro

[PULL v2 21/29] tests/tcg/tricore: Add ftoi test

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann Tested-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-13-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-23-alex.ben...@linaro.org> diff --git a/tests/tcg/tricore/macros.h b/tests/tcg/t

[PATCH v2 2/5] block-copy: let ratelimit handle a speed of 0

2021-05-18 Thread Emanuele Giuseppe Esposito
From: Paolo Bonzini Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Paolo Bonzini Signed-off-by: Emanuele Giuseppe Esposito --- block/block-copy.c | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/block/block-copy.c b/block/block-copy.

Re: [PATCH v2 28/50] target/i386: Reorder DisasContext members

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: Sort all of the single-byte members to the same area of the structure, eliminating 8 bytes of padding. Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions

[PATCH] target/ppc: Fix load endianness for lxvwsx/lxvdsx

2021-05-18 Thread Giuseppe Musacchio
TARGET_WORDS_BIGENDIAN may not match the machine endianness if that's a runtime-configurable parameter. Fixes: bcb0b7b1a1c05707304f80ca6f523d557816f85c Resolves: https://gitlab.com/qemu-project/qemu/-/issues/212 Signed-off-by: Giuseppe Musacchio --- target/ppc/translate/vsx-impl.c.inc | 12

Re: [PATCH v2 16/50] target/i386: Tidy REX_B, REX_X definition

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: Change the storage from int to uint8_t since the value is in {0,8}. For x86_64 add 0 in the macros to (1) promote the type back to int, and (2) make the macro an rvalue. Signed-off-by: Richard Henderson Might be easier in the end to put all rex bits

[PATCH v2 5/5] co-shared-resource: protect with a mutex

2021-05-18 Thread Emanuele Giuseppe Esposito
co-shared-resource is currently not thread-safe, as also reported in co-shared-resource.h. Add a QemuMutex because co_try_get_from_shres can also be invoked from non-coroutine context. Signed-off-by: Emanuele Giuseppe Esposito --- include/qemu/co-shared-resource.h | 4 +--- util/qemu-co-shared-

Re: [PATCH v2 01/21] qapi/parser: Don't try to handle file errors

2021-05-18 Thread Markus Armbruster
John Snow writes: > Remove the try/except block that handles file-opening errors in > QAPISchemaParser.__init__() and add one each to > QAPISchemaParser._include() and QAPISchema.__init__() respectively. > > > The short-ish version of what motivates this patch is: > > - It's hard to write a good

Re: [PATCH v2 32/50] target/i386: Implement skinit in translate.c

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: Our sysemu implementation is a stub. We can already intercept instructions for vmexit, and raising #UD is trivial. Signed-off-by: Richard Henderson --- target/i386/helper.h| 1 - target/i386/tcg/sysemu/svm_helper.c | 7 --- ta

Re: [PATCH v2 18/50] target/i386: Move rex_w into DisasContext

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: Treat this flag exactly like we treat the other rex bits. The -1 initialization is unused; the two tests are > 0 and == 1, so the value can be reduced to a bool. Signed-off-by: Richard Henderson Reviewed-by: Paolo Bonzini

Re: [PATCH v2 21/50] target/i386: Reduce DisasContext.override to int8_t

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: The range of values is -1 (none) to 5 (R_GS). Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index ca7f0

[PATCH v2 4/5] progressmeter: protect with a mutex

2021-05-18 Thread Emanuele Giuseppe Esposito
Progressmeter is protected by the AioContext mutex, which is taken by the block jobs and their caller (like blockdev). We would like to remove the dependency of block layer code on the AioContext mutex, since most drivers and the core I/O code are already not relying on it. Create a new C file to

  1   2   3   4   5   >