Re: [PATCH 5/6] co-shared-resource: protect with a mutex

2021-05-15 Thread Vladimir Sementsov-Ogievskiy via
15.05.2021 00:53, Emanuele Giuseppe Esposito wrote: we want to get from shres here, after possible call to block_copy_task_shrink(), as task->bytes may be reduced. Ah right, I missed that. So I guess if we want the caller to protect co-shared-resource, get_from_shres stays where it is, and

[RFC PATCH v3] ppc/spapr: Add support for H_SCM_PERFORMANCE_STATS hcall

2021-05-15 Thread Vaibhav Jain
Add support for H_SCM_PERFORMANCE_STATS described at [1] for spapr nvdimms. This enables guest to fetch performance stats[2] like expected life of an nvdimm ('MemLife ') etc and display them to the user. Linux kernel support for fetching these performance stats and exposing them to the user-space w

[PATCH] hw/display/qxl: Set pci rom address aligned with page size

2021-05-15 Thread Bibo Mao
From: maobibo pci memory bar size should be aligned with page size, else it will not be effective memslot when running in kvm mode. This patch set qxl pci rom size aligned with page size of host machine. Signed-off-by: Bibo Mao --- hw/display/qxl.c | 8 1 file changed, 4 insertions(+

[Bug 1909823] Re: RDPMC check on PCE is backwards

2021-05-15 Thread Bruce Merry
It looks like this was fixed in c45b426. ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1909823 Title: RDPMC check on PCE is backwards

Re: [PATCH] fdc: check drive block device before usage (CVE-2021-20196)

2021-05-15 Thread Philippe Mathieu-Daudé
On 5/14/21 9:26 PM, John Snow wrote: > On 5/14/21 3:23 PM, Thomas Huth wrote: >> On 23/01/2021 11.03, P J P wrote: >>> From: Prasad J Pandit >>> >>> While processing ioport command in 'fdctrl_write_dor', device >>> controller may select a drive which is not initialised with a >>> block device. Thi

Re: [PATCH v6 23/26] tcg/tci: Split out tci_qemu_ld, tci_qemu_st

2021-05-15 Thread Philippe Mathieu-Daudé
On 5/3/21 1:57 AM, Richard Henderson wrote: > Expand the single-use macros into the new functions. > Use cpu_ldsb_mmuidx_ra and cpu_ldsw_le_mmuidx_ra so > that the trace event receives the correct sign flag. > > Signed-off-by: Richard Henderson > --- > tcg/tci.c | 215 +++

Re: [PATCH v6 06/26] tcg: Store the TCGHelperInfo in the TCGOp for call

2021-05-15 Thread Philippe Mathieu-Daudé
On 5/3/21 1:57 AM, Richard Henderson wrote: > This will give us both flags and typemask for use later. > > We also fix a dumping bug, wherein calls generated for plugins > fail tcg_find_helper and print (null) instead of either a name > or the raw function pointer. > > Signed-off-by: Richard Hend

Re: [PATCH v6 10/26] tcg/tci: Move call-return regs to end of tcg_target_reg_alloc_order

2021-05-15 Thread Philippe Mathieu-Daudé
On 5/3/21 1:57 AM, Richard Henderson wrote: > As the only call-clobbered regs for TCI, these should > receive the least priority. > > Signed-off-by: Richard Henderson > --- > tcg/tci/tcg-target.c.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v6 05/26] accel/tcg: Add tcg call flags to plugins helpers

2021-05-15 Thread Philippe Mathieu-Daudé
On 5/3/21 1:57 AM, Richard Henderson wrote: > As noted by qemu-plugins.h, plugins can neither read nor write > guest registers. > > Signed-off-by: Richard Henderson > --- > accel/tcg/plugin-helpers.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/accel/tcg/plugin-h

Re: [PATCH v6 01/26] tcg: Combine dh_is_64bit and dh_is_signed to dh_typecode

2021-05-15 Thread Philippe Mathieu-Daudé
On 5/3/21 1:57 AM, Richard Henderson wrote: > We will shortly be interested in distinguishing pointers > from integers in the helper's declaration, as well as a > true void return. We currently have two parallel 1 bit > fields; merge them and expand to a 3 bit field. > > Our current maximum is 7

Re: [PATCH v6 24/26] tests/tcg: Increase timeout for TCI

2021-05-15 Thread Philippe Mathieu-Daudé
On 5/3/21 1:57 AM, Richard Henderson wrote: > The longest test at the moment seems to be a (slower) > aarch64 host, for which test-mmap takes 64 seconds. > > Reviewed-by: Thomas Huth > Signed-off-by: Richard Henderson > --- > configure | 3 +++ > tests/tcg/Makefile.target | 6 ++

[Bug 1921092] Re: gdbstub debug of multi-cluster machines is undocumented and confusing

2021-05-15 Thread Thomas Huth
Ok, thanks, so I'm closing this ticket now. ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1921092 Title: gdbstub debug of multi-cluste

Re: [PATCH v6 17/26] tcg/tci: Implement movcond

2021-05-15 Thread Philippe Mathieu-Daudé
On 5/3/21 1:57 AM, Richard Henderson wrote: > When this opcode is not available in the backend, tcg middle-end > will expand this as a series of 5 opcodes. So implementing this > saves bytecode space. > > Signed-off-by: Richard Henderson > --- > tcg/tci/tcg-target.h | 4 ++-- > tcg/tci.c

Re: [RFC 1/1] Implement AVR watchdog timer

2021-05-15 Thread Philippe Mathieu-Daudé
+Pavel/Alex On 5/3/21 10:08 PM, Michael Rolnik wrote: > Hi all, > > I was about to make icount work. but, there is something I still don't > understand. I have this code  > > timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, avr_wdt_interrupt, s); > > and then > > void avr_wdt_interrupt(/* some argumen

[Bug 1879955] Re: target/i386/seg_helper.c: 16-bit TSS struct format wrong?

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1924603] Re: Incorrect feature negotiation for vhost-vdpa netdevice

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[PULL 00/16] Trivial branch for 6.1 patches

2021-05-15 Thread Laurent Vivier
gs/trivial-branch-for-6.1-pull-request for you to fetch changes up to 29f9c636894c462fa54fad08049e51877905e93b: target/avr: Ignore unimplemented WDR opcode (2021-05-13 19:18:42 +0200) Pull request trivial-branc

[PULL 02/16] hw/virtio: Pass virtio_feature_get_config_size() a const argument

2021-05-15 Thread Laurent Vivier
From: Philippe Mathieu-Daudé The VirtIOFeature structure isn't modified, mark it const. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Jason Wang Reviewed-by: Richard Henderson Reviewed-by: Stefan Hajnoczi Reviewed-by: Stefano Garzarella Message-Id: <20210511104157.2880306-2-phi...@redhat.

[PULL 01/16] backends/tpm: Replace qemu_mutex_lock calls with QEMU_LOCK_GUARD

2021-05-15 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Simplify the tpm_emulator_ctrlcmd() handler by replacing a pair of qemu_mutex_lock/qemu_mutex_unlock calls by the WITH_QEMU_LOCK_GUARD macro. Reviewed-by: Stefan Berger Reviewed-by: Christophe de Dinechin Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210512

[PULL 10/16] cutils: fix memory leak in get_relocated_path()

2021-05-15 Thread Laurent Vivier
From: Stefano Garzarella get_relocated_path() allocates a GString object and returns the character data (C string) to the caller without freeing the memory allocated for that object as reported by valgrind: 24 bytes in 1 blocks are definitely lost in loss record 2,805 of 6,532 at 0x483980

[PULL 03/16] virtio-blk: Constify VirtIOFeature feature_sizes[]

2021-05-15 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Acked-by: Jason Wang Reviewed-by: Richard Henderson Reviewed-by: Stefan Hajnoczi Reviewed-by: Stefano Garzarella Message-Id: <20210511104157.2880306-3-phi...@redhat.com> Signed-off-by: Laurent Vivier --- hw/block/virtio-blk

[PULL 06/16] qapi: spelling fix (addtional)

2021-05-15 Thread Laurent Vivier
From: Michael Tokarev Fixes: 3d0d3c30ae3a259bff176f85a3efa2d0816695af Signed-off-by: Michael Tokarev Reviewed-by: Kevin Wolf Message-Id: <20210508093315.393274-1-...@msgid.tls.msk.ru> Signed-off-by: Laurent Vivier --- qapi/qom.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

[PULL 05/16] virtiofsd: Fix check of chown()'s return value

2021-05-15 Thread Laurent Vivier
From: Greg Kurz Otherwise you always get this warning when using --socket-group=users vhost socket failed to set group to users (100) While here, print out the error if chown() fails. Fixes: f6698f2b03b0 ("tools/virtiofsd: add support for --socket-group") Signed-off-by: Greg Kurz Reviewed-by

[PULL 07/16] hw/gpio/aspeed: spelling fix (addtional)

2021-05-15 Thread Laurent Vivier
From: Michael Tokarev Fixes: 36d737ee82b2972167e97901c5271ba3f904ba71 Signed-off-by: Michael Tokarev Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210508093615.411920-1-...@msgid.tls.msk.ru> Signed-off-by: Laurent Vivier --- hw/gpio/aspeed_gpio.c | 2 +- 1 file changed, 1 insertion(+), 1

[PULL 11/16] hw/mem/meson: Fix linking sparse-mem device with fuzzer

2021-05-15 Thread Laurent Vivier
From: Philippe Mathieu-Daudé sparse-mem.c is added to the 'mem_ss' source set, which itself is conditionally added to softmmu_ss if CONFIG_MEM_DEVICE is selected. But if CONFIG_MEM_DEVICE isn't selected, we get a link failure even if CONFIG_FUZZ is selected: /usr/bin/ld: tests_qtest_fuzz_gener

[PULL 04/16] virtio-net: Constify VirtIOFeature feature_sizes[]

2021-05-15 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Acked-by: Jason Wang Reviewed-by: Richard Henderson Reviewed-by: Stefan Hajnoczi Reviewed-by: Stefano Garzarella Message-Id: <20210511104157.2880306-4-phi...@redhat.com> Signed-off-by: Laurent Vivier --- hw/net/virtio-net.c

[PULL 14/16] target/sh4: Return error if CPUClass::get_phys_page_debug() fails

2021-05-15 Thread Laurent Vivier
From: Philippe Mathieu-Daudé If the get_physical_address() call fails, the SH4 get_phys_page_debug() handler returns an uninitialized address. Instead return -1, which correspond to "no page found" (see cpu_get_phys_page_debug() doc string). This fixes a warning emitted when building with CFLAGS

[PULL 13/16] multi-process: Avoid logical AND of mutually exclusive tests

2021-05-15 Thread Laurent Vivier
From: Jagannathan Raman Fixes an if statement that performs a logical AND of mutually exclusive tests Buglink: https://bugs.launchpad.net/qemu/+bug/1926995 Reviewed-by: Thomas Huth Signed-off-by: Jagannathan Raman Reviewed-by: Thomas Huth Reviewed-by: Stefan Hajnoczi Message-Id: <1620402803-

[PULL 08/16] hw/timer/etraxfs_timer: Convert to 3-phase reset (Resettable interface)

2021-05-15 Thread Laurent Vivier
From: Philippe Mathieu-Daudé TYPE_ETRAX_FS_TIMER is a sysbus device, so its DeviceClass::reset() handler is called automatically when its qbus parent is reset (we don't need to register it manually). Convert the generic reset to a enter/hold resettable ones, and remove the qemu_register_reset()

[PULL 09/16] hw/rtc/mc146818rtc: Convert to 3-phase reset (Resettable interface)

2021-05-15 Thread Laurent Vivier
From: Philippe Mathieu-Daudé TYPE_MC146818_RTC is an ISA device, so its DeviceClass::reset() handler is called automatically when its qbus parent is reset (we don't need to register it manually). We have 2 reset() methods: a generic one and the qdev one. Merge them into a reset_enter handler (ke

[PULL 12/16] hw/pci-host: Do not build gpex-acpi.c if GPEX is not selected

2021-05-15 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Since its introduction in commit 5b85eabe68f ("acpi: add acpi_dsdt_add_gpex") we build gpex-acpi.c if ACPI is selected, even if the GPEX_HOST device isn't build. Add the missing Kconfig dependency. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis

[PULL 16/16] target/avr: Ignore unimplemented WDR opcode

2021-05-15 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Running the WDR opcode triggers a segfault: $ cat > foo.S << EOF > __start: > wdr > EOF $ avr-gcc -nostdlib -nostartfiles -mmcu=avr6 foo.S -o foo.elf $ qemu-system-avr -serial mon:stdio -nographic -no-reboot \ -M mega -bios foo.elf -d in_asm --sin

[PULL 15/16] hw/avr/atmega.c: use the avr51 cpu for atmega1280

2021-05-15 Thread Laurent Vivier
From: Frederic Konrad According to the as documentation: (https://sourceware.org/binutils/docs-2.36/as/AVR-Options.html) "Instruction set avr51 is for the enhanced AVR core with exactly 128K program memory space (MCU types: atmega128, atmega128a, atmega1280, atmega1281, atmega1284, atmega1284

[Bug 1923648] Re: macOS App Nap feature gradually freezes QEMU process

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1922430] Re: 3d accel does not take care of 1280x960 setting

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1923583] Re: colo: pvm flush failed after svm killed

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1922773] Re: RISCV32 illegal instruction exception

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1922391] Re: qemu-system-ppc assertion "!mr->container" failed

2021-05-15 Thread Thomas Huth
Philippe's fix has been merged here: https://gitlab.com/qemu-project/qemu/-/commit/03b3542ac93cb196bf6a6 ** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launch

[PATCH] accel/tcg: Align data dumped at end of TB

2021-05-15 Thread Philippe Mathieu-Daudé
To better visualize the data dumped at the end of a TB, left-align it (padding it with 0). Signed-off-by: Philippe Mathieu-Daudé --- accel/tcg/translate-all.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index ae7e

[Bug 1922325] Re: s390x-virtio-gpu-ccw module unnecessary?

2021-05-15 Thread Thomas Huth
How did you run the configure script? The virtio-gpu-ccw device is part of the qemu-system-s390x emulator, so unless you disabled that build, the module will of course be there. ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of

[Bug 1920934] Re: Heap-use-after-free in io_writex / cputlb.c results in Linux kernel crashes

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1920752] Re: USB SoundCard Passthrough not working on arm64

2021-05-15 Thread Thomas Huth
Closing as requested in comment #6 ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1920752 Title: USB SoundCard Passthrough not working on arm64 St

[Bug 1914117] Re: Short files returned via FTP on Qemu with various architectures and OSes

2021-05-15 Thread Thomas Huth
Could we close this ticket now if there is a workaround in libslirp now? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1914117 Title: Short fil

Re: [PULL 21/38] tcg/tci: Implement the disassembler properly

2021-05-15 Thread Philippe Mathieu-Daudé
Hi Richard, On 3/17/21 4:34 PM, Richard Henderson wrote: > Actually print arguments as opposed to simply the opcodes > and, uselessly, the argument counts. Reuse all of the helpers > developed as part of the interpreter. > > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Richard Henderson

[Bug 1917184] Re: qemu-user vm86() segfaults handling interrupt with ss:sp in same page as cs:ip

2021-05-15 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/314 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1916343] Re: -daemonize not working on macOS

2021-05-15 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/313 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1912934] Re: QEMU emulation of fmadds instruction on powerpc64le is buggy

2021-05-15 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/312 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1705118] Re: qemu user mode: rt signals not implemented for sparc guests

2021-05-15 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/311 ** Changed in: qemu Status: New => Expired ** Bug watch

Re: [PATCH v6 00/26] TCI fixes and cleanups

2021-05-15 Thread Philippe Mathieu-Daudé
On 5/3/21 1:57 AM, Richard Henderson wrote: > Richard Henderson (26): > tcg: Combine dh_is_64bit and dh_is_signed to dh_typecode > tcg: Add tcg_call_flags > accel/tcg/plugin-gen: Drop inline markers > plugins: Drop tcg_flags from struct qemu_plugin_dyn_cb > accel/tcg: Add tcg call flags t

[Bug 1922430] Re: 3d accel does not take care of 1280x960 setting

2021-05-15 Thread promeneur
done -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1922430 Title: 3d accel does not take care of 1280x960 setting Status in QEMU: Invalid Bug description: openSuse 15.2 kde plasma 5.21.3, f

[Bug 1922430] Re: 3d accel does not take care of 1280x960 setting

2021-05-15 Thread Thomas Huth
Ticket has been moved here (thanks!): https://gitlab.com/qemu-project/qemu/-/issues/315 ... so I'm closing this on Launchpad now. ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #315 https://gitlab.com/qemu-project/qemu/-/issues/315 ** Changed in: qemu Status: Incomplete => In

[Bug 1926952] Re: SPICE support broken with 6.0

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1926521] Re: QEMU-user ignores MADV_DONTNEED

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1926497] Re: dp83932 stops working after a short while

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1926782] Re: configure script --extra-cflags not passed to config-meson.cross

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1926596] Re: qemu-monitor-event command gets stuck randomly

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1926246] Re: chrome based apps can not be run under qemu user mode

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1924912] Re: VirtIO drivers don't work on Windows: "GLib: Too many handles to wait for!" crash

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1926231] Re: SCSI passthrough of SATA cdrom -> errors & performance issues

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1926202] Re: qemu-user can't run some ppc binaries

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1925109] Re: usbredirparser: bulk transfer length exceeds limits

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1925094] Re: DISCARD support for Crypto Block Devices

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1924987] Re: Storage | Two decimal digits precision

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1926174] Re: Laggy and/or displaced mouse input on CloudReady (Chrome OS) VM

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1925966] Re: Win10 guest freezes randomly

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[PATCH v3 00/11] PS/2 controller related fixes

2021-05-15 Thread Volker Rümelin
This patch series fixes two different PS/2 mouse stream corruptions and adds a feature that allows some old misbehaving DOS programs to have a working keyboard. With the last few patches, the PS/2 con- troller behaves more like a real controller. v2: Introduce the function kbd_pending() in a prel

[PATCH v3 01/11] ps2: fix mouse stream corruption

2021-05-15 Thread Volker Rümelin
Commit 7abe7eb294 "ps2: Fix mouse stream corruption due to lost data" added code to avoid mouse stream corruptions but the calculation of the needed free queue size was wrong. Fix this. To reproduce, open a text file with the vim 7.3 32 bit for DOS exe- cutable in a FreeDOS client started with -di

[Bug 1924914] Re: Running sway in a QEMU VM results in a GPU hang of the guest (virtio-gpu driver)

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[PATCH v3 04/11] pckbd: split out interrupt line changing code

2021-05-15 Thread Volker Rümelin
Split out the interrupt line changing code from kbd_update_irq(). This is a preparation for the next patch. There is no functional change. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Volker Rümelin --- hw/input/pckbd.c | 32 ++-- 1 file changed, 22 insertions(

[PATCH v3 08/11] pckbd: add controller response queue

2021-05-15 Thread Volker Rümelin
Add a separate queue for PS/2 controller responses. The responses no longer get queued in the keyboard or mouse queues. The advantage of this can be seen after the next two patches, where the guest can disable the PS/2 communication with keyboard and mouse and still talk to the PS/2 controller. Si

[PATCH v3 03/11] ps2: don't deassert irq twice if queue is empty

2021-05-15 Thread Volker Rümelin
Don't deassert the irq twice if the queue is empty. While the second deassertion doesn't do any harm, it's unnecessary. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Volker Rümelin --- hw/input/ps2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/input/ps2.c b/hw

[PATCH v3 05/11] pckbd: don't update OBF flags if KBD_STAT_OBF is set

2021-05-15 Thread Volker Rümelin
Don't update the OBF flags in the status register and the cor- responding IRQ lines if KBD_STAT_OBF is set. Otherwise this may change the PS/2 event type. If the guest ISR was already scheduled, the changed event type will be rather surprising for the guest. This fixes a mouse event stream corrupt

[PATCH v3 06/11] pckbd: PS/2 keyboard throttle

2021-05-15 Thread Volker Rümelin
Limit the keyboard data rate to the serial link speed. Some old DOS software relies on being able to read an incoming scan-code more than once. After reading keyboard data from the i8042 controller, the guest software has 1ms to read the same data again. Use -global i8042.kbd-throttle=on to enable

[PATCH v3 02/11] ps2: don't raise an interrupt if queue is full

2021-05-15 Thread Volker Rümelin
ps2_queue() behaves differently than the very similar functions ps2_queue_2() to ps2_queue_4(). The first one calls update_irq() even if the queue is full, the others don't. Change ps2_queue() to be consistent with the others. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Volker Rümelin ---

[PATCH v3 11/11] pckbd: remove duplicated keyboard and mouse defines

2021-05-15 Thread Volker Rümelin
In 2005 the author of commit daa579632d "PS2 mouse and keyboard separation (Paul Brook)" and 0e43e99c04 "PS2 mouse and keyboard separation (Paul Brook)" separated the PS/2 controller code and the PS/2 keyboard and mouse code. It seems he forgot to remove a few defines. Remove them now. Signed-off-

[PATCH v3 09/11] pckbd: add function kbd_pending()

2021-05-15 Thread Volker Rümelin
Replace reads of the variable s->pending with a call to a new function kbd_pending() to ease the review of the next patch. There is no functional change. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Volker Rümelin --- hw/input/pckbd.c | 21 ++--- 1 file changed, 14 inserti

[PATCH v3 07/11] pckbd: add state variable for interrupt source

2021-05-15 Thread Volker Rümelin
Currently there is only one flag to distinguish between two interrupt sources and there are no available flags for more sources. Add an internal state variable to store the interrupt source. The next patch will introduce an additional interrupt source. There is no functional change. Signed-off-by:

[PATCH v3 10/11] pckbd: correctly disable PS/2 communication

2021-05-15 Thread Volker Rümelin
Currently the PS/2 controller command KBD_CCMD_MOUSE_DISABLE doesn't disable the PS/2 mouse communication at all, and the PS/2 controller commands KBD_CCMD_KBD_DISABLE and KBD_CCMD_KBD_ENABLE only disable and enable the keyboard interrupt, which is very different from what a real PS/2 controller do

Re: [PATCH v3 00/11] PS/2 controller related fixes

2021-05-15 Thread Philippe Mathieu-Daudé
On 5/15/21 1:31 PM, Volker Rümelin wrote: > This patch series fixes two different PS/2 mouse stream corruptions > and adds a feature that allows some old misbehaving DOS programs to > have a working keyboard. With the last few patches, the PS/2 con- > troller behaves more like a real controller. >

Re: [Bug 1914117] Re: Short files returned via FTP on Qemu with various architectures and OSes

2021-05-15 Thread Chris Pinnock
If it’s included in qemu when one downloads the sources I’m happy. Sent from my iPhone > On 15 May 2021, at 11:55, Thomas Huth <1914...@bugs.launchpad.net> wrote: > > Could we close this ticket now if there is a workaround in libslirp now? > > ** Changed in: qemu > Status: New => Incompl

CFP Reminder: KVM Forum 2021

2021-05-15 Thread Paolo Bonzini
KVM Forum 2021 virtual experience September 15-16, 2021 (All submissions must be received before May 31, 2021 at 23:59 PST) = KVM Forum is an annual event that present

[Bug 1926246] Re: chrome based apps can not be run under qemu user mode

2021-05-15 Thread Wind Li
** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1926246 Title: chrome based apps can not be run under qemu user mode Status in QEMU: New Bug d

Re: [PULL v3 0/1] Rtd patches

2021-05-15 Thread Philippe Mathieu-Daudé
On 5/14/21 8:33 PM, Peter Maydell wrote: > On Fri, 14 May 2021 at 12:13, wrote: >> >> From: Marc-André Lureau >> >> The following changes since commit 2d3fc4e2b069494b1e9e2e4a1e3de24cbc036426: >> >> Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2021-05-12' >> into staging (2021-0

[PATCH 0/2] tests/acceptance: Add tests for the Pegasos2 machine

2021-05-15 Thread Philippe Mathieu-Daudé
Philippe Mathieu-Daudé (2): tests/acceptance: Ignore binary data sent on serial console tests/acceptance: Add tests for the Pegasos2 machine tests/acceptance/avocado_qemu/__init__.py | 7 +- tests/acceptance/machine_ppc_pegasos.py | 98 +++ 2 files changed, 103 insert

[PATCH 2/2] tests/acceptance: Add tests for the Pegasos2 machine

2021-05-15 Thread Philippe Mathieu-Daudé
Add a pair of tests for the Pegasos2 machine following the steps from: https://lists.nongnu.org/archive/html/qemu-devel/2021-01/msg01553.html $ PEGASOS2_ROM_PATH=/tmp/pegasos2.rom AVOCADO_ALLOW_UNTRUSTED_CODE=1 \ avocado --show=app,console,tesseract \ run -t machine:pegasos2 tests/acce

[PATCH 1/2] tests/acceptance: Ignore binary data sent on serial console

2021-05-15 Thread Philippe Mathieu-Daudé
If a guest sends binary data on the serial console, we get: File "tests/acceptance/avocado_qemu/__init__.py", line 92, in _console_interaction msg = console.readline().strip() File "/usr/lib64/python3.8/codecs.py", line 322, in decode (result, consumed) = self._buffer_decode(data, self.err

[PATCH v5 4/9] block: bdrv_reopen_parse_backing(): don't check frozen child

2021-05-15 Thread Vladimir Sementsov-Ogievskiy
bdrv_set_backing_noperm() takes care of it (actual check is in bdrv_set_file_or_backing_noperm()), so we don't need to check it here. While being here, improve error message a bit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c| 14 +- tests/qemu-iotests/245

[PATCH v5 7/9] block: BDRVReopenState: drop replace_backing_bs field

2021-05-15 Thread Vladimir Sementsov-Ogievskiy
It's used only in bdrv_reopen_commit(). "backing" is covered by the loop through all children except for case when we removed backing child during reopen. Make it more obvious and drop extra boolean field: qdict_del will not fail if there is no such entry. Signed-off-by: Vladimir Sementsov-Ogievs

[PATCH v5 1/9] block: introduce bdrv_remove_file_or_backing_child()

2021-05-15 Thread Vladimir Sementsov-Ogievskiy
To be used for reopen in future commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/block.c b/block.c index 9ad725d205..75565ce4d4 100644 --- a/block.c +++ b/block.c @@ -4770,16 +4770,14 @@

[PATCH v5 6/9] block: move supports_backing check to bdrv_set_file_or_backing_noperm()

2021-05-15 Thread Vladimir Sementsov-Ogievskiy
Move supports_backing check of bdrv_reopen_parse_backing to called (through bdrv_set_backing_noperm()) bdrv_set_file_or_backing_noperm() function. The check applies to general case, so it's appropriate for bdrv_set_file_or_backing_noperm(). We have to declare backing support for two test drivers,

[PATCH v5 3/9] block: bdrv_reopen_parse_backing(): don't check aio context

2021-05-15 Thread Vladimir Sementsov-Ogievskiy
We don't need this check: bdrv_set_backing_noperm() will do it anyway (actually in bdrv_attach_child_common()). Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 33 - 1 file changed, 33 deletions(-) diff --git a/block.c b/block.c index 5141c04815..4e18bc

[PATCH v5 0/9] Allow changing bs->file on reopen

2021-05-15 Thread Vladimir Sementsov-Ogievskiy
Hi all! Alberto, I'm sorry for not consulting with you about sending this. Actually, I wanted only one patch "block: Allow changing bs->file on reopen", as I'm going to send another series based on it. I started to work on updating this one patch it and it turned into a refactoring series below.

[PATCH v5 9/9] iotests: Test replacing files with x-blockdev-reopen

2021-05-15 Thread Vladimir Sementsov-Ogievskiy
From: Alberto Garcia This patch adds new tests in which we use x-blockdev-reopen to change bs->file Signed-off-by: Alberto Garcia --- tests/qemu-iotests/245 | 109 - tests/qemu-iotests/245.out | 11 +++- 2 files changed, 117 insertions(+), 3 deletions(-

[PATCH v5 8/9] block: Allow changing bs->file on reopen

2021-05-15 Thread Vladimir Sementsov-Ogievskiy
From: Alberto Garcia When the x-blockdev-reopen was added it allowed reconfiguring the graph by replacing backing files, but changing the 'file' option was forbidden. Because of this restriction some operations are not possible, notably inserting and removing block filters. This patch adds suppo

[PATCH v5 2/9] block: introduce bdrv_set_file_or_backing_noperm()

2021-05-15 Thread Vladimir Sementsov-Ogievskiy
To be used for reopen in future commit. Notes: - It seems OK to update inherits_from if new bs is recursively inherits from parent bs. Let's just not check for backing_chain_contains, to support file child of non-filters. - Simply check child->frozen instead of bdrv_is_backing_chain_frozen

[PATCH v5 5/9] block: bdrv_reopen_parse_backing(): simplify handling implicit filters

2021-05-15 Thread Vladimir Sementsov-Ogievskiy
The logic around finding overlay here is not obvious. Actually it does two simple things: 1. If new bs is already in backing chain, split from parent bs by several implicit filters we are done, do nothing. 2. Otherwise, don't try to replace implicit filter. Let's rewrite this in more obvious

[Bug 1914870] Re: libvixl compilation failure on Debian unstable

2021-05-15 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1920913] Re: Openjdk11+ fails to install on s390x

2021-05-15 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/319 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1921061] Re: Corsair iCUE Install Fails, qemu VM Reboots

2021-05-15 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/320 ** Changed in: qemu Status: Confirmed => Expired ** Bug

[Bug 1920602] Re: QEMU crash after a QuickBASIC program integer overflow

2021-05-15 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/318 ** Changed in: qemu Status: Confirmed => Expired ** Bug

  1   2   >