Re: [RFC 1/1] Implement AVR watchdog timer

2021-05-14 Thread Michael Rolnik
Ok, thanks. Sent from my cell phone, please ignore typos On Thu, May 13, 2021, 3:27 PM Pavel Dovgalyuk wrote: > On 06.05.2021 00:18, Michael Rolnik wrote: > > Signed-off-by: Michael Rolnik > > --- > > MAINTAINERS | 2 + > > hw/avr/Kconfig| 1 + > > hw/

Re: [PULL v2 0/1] readthedoc theme patch

2021-05-14 Thread Marc-André Lureau
Hi On Thu, May 13, 2021 at 9:17 PM Peter Maydell wrote: > On Thu, 13 May 2021 at 17:03, Marc-André Lureau > wrote: > > This should work, can you check?: > > > > diff --git a/docs/conf.py b/docs/conf.py > > index 3802b70d62..9e3d7cee0e 100644 > > --- a/docs/conf.py > > +++ b/docs/conf.py > > @@

Re: [PATCH 06/10] hw/riscv/Kconfig: Add missing dependency MICROCHIP_PFSOC -> SERIAL

2021-05-14 Thread Philippe Mathieu-Daudé
On 5/14/21 4:47 AM, Bin Meng wrote: > Hi Philippe, > > On Fri, May 14, 2021 at 12:57 AM Philippe Mathieu-Daudé > wrote: >> >> Commit a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART >> emulation") added a dependency on the SERIAL model, but forgot to >> add the Kconfig selector. Fix that

Re: [PATCH v3 01/15] python: qemu: add timer parameter for qmp.accept socket

2021-05-14 Thread Emanuele Giuseppe Esposito
On 13/05/2021 19:54, John Snow wrote: On 4/14/21 1:03 PM, Emanuele Giuseppe Esposito wrote: Add a new _qmp_timer field to the QEMUMachine class. The default timer is 15 sec, as per the default in the qmp accept() function. Fine enough for now. What's the exact need for this change, exactly

Re: [PATCH v3 10/15] qemu_iotests: extent QMP socket timeout when using valgrind

2021-05-14 Thread Emanuele Giuseppe Esposito
On 13/05/2021 20:47, John Snow wrote: On 4/14/21 1:03 PM, Emanuele Giuseppe Esposito wrote: As with gdbserver, valgrind delays the test execution, so the default QMP socket timeout timeout too soon. Signed-off-by: Emanuele Giuseppe Esposito ---   python/qemu/machine.py    | 2 +-   tests

Re: [PATCH] target/riscv: Remove unnecessary riscv_*_names[] declaration

2021-05-14 Thread Philippe Mathieu-Daudé
On 5/14/21 7:24 AM, Bin Meng wrote: > riscv_excp_names[] and riscv_intr_names[] are only referenced by > target/riscv/cpu.c locally. > > Signed-off-by: Bin Meng > --- > > target/riscv/cpu.h | 2 -- > target/riscv/cpu.c | 4 ++-- > 2 files changed, 2 insertions(+), 4 deletions(-) Reviewed-by: P

Re: [PATCH V3 06/22] vl: add helper to request re-exec

2021-05-14 Thread Daniel P . Berrangé
On Thu, May 13, 2021 at 04:19:22PM -0400, Steven Sistare wrote: > On 5/7/2021 10:31 AM, Eric Blake wrote: > > On 5/7/21 7:25 AM, Steve Sistare wrote: > >> Add a qemu_exec_requested() hook that causes the main loop to exit and > >> re-exec qemu using the same initial arguments. If /usr/bin/qemu-exe

Re: [RFC PATCH 4/5] hw/ppc/fdt: Drop dependency on libfdt

2021-05-14 Thread Philippe Mathieu-Daudé
On 5/14/21 7:29 AM, Paolo Bonzini wrote: > On 14/05/21 01:35, David Gibson wrote: >>> "FDT" is set by meson.build if the library is available, LIBFDT is >>> set by >>> the board to link with the library.  In other words CONFIG_FDT is >>> per-build, >>> while CONFIG_LIBFDT is per-target. >> Oof... t

Re: [PULL 0/5] Miscellaneous patches for 2021-05-12

2021-05-14 Thread Peter Maydell
On Wed, 12 May 2021 at 17:24, Markus Armbruster wrote: > > The following changes since commit a5ccdccc97d6e0d75282ede5b866cf694e9602b0: > > Merge remote-tracking branch > 'remotes/kraxel/tags/vga-20210510-pull-request' into staging (2021-05-12 > 14:45:21 +0100) > > are available in the Git rep

Re: [PULL v2 00/32] Misc (mostly i386) patches for 2021-05-11

2021-05-14 Thread Peter Maydell
On Thu, 13 May 2021 at 21:39, Paolo Bonzini wrote: > > On 13/05/21 21:12, Peter Maydell wrote: > > Something weird has happened here. > > > > I think I applied v1 of this pullreq (merge commit 31589644ba069ba06c5 > > now in master), and then when I came along to try to process this > > one the tag

Re: [PULL v2 0/1] readthedoc theme patch

2021-05-14 Thread Peter Maydell
On Fri, 14 May 2021 at 09:01, Marc-André Lureau wrote: > > Let me know if you want a new PR. If you could send a new PR that would be the easiest for me. thanks -- PMM

[Bug 1896754] Re: Performance degradation for WinXP boot time after b55f54bc

2021-05-14 Thread Thomas Huth
Ticket has been moved here (thanks, Maksim!): https://gitlab.com/qemu-project/qemu/-/issues/286 Thus closing this one at Launchpad now. ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #286 https://gitlab.com/qemu-project/qemu/-/issues/286 ** Changed in: qemu Status: Incomplete

Re: RFC: Memory region accesses where .valid.min_access_size < .impl.min_access_size

2021-05-14 Thread Jonathan Cameron
On Fri, 14 May 2021 11:35:57 +0930 "Andrew Jeffery" wrote: > On Thu, 13 May 2021, at 22:30, Jonathan Cameron wrote: > > On Thu, 13 May 2021 14:36:27 +0200 > > Philippe Mathieu-Daudé wrote: > > > > > On 5/13/21 2:23 PM, Peter Maydell wrote: > > > > On Thu, 13 May 2021 at 12:49, Jonathan Came

Re: [PATCH 3/3] pc-bios/s390-ccw: Add a proper prototype for main()

2021-05-14 Thread Thomas Huth
On 12/05/2021 21.54, Philippe Mathieu-Daudé wrote: On 5/12/21 7:15 PM, Thomas Huth wrote: Older versions of Clang complain if there is no prototype for main(). Add one, and while we're at it, make sure that we use the same type for main.c and netmain.c - since the return value does not matter, d

[Bug 1898011] Re: mmap MAP_NORESERVE of 2^42 bytes consumes 16Gb of actual RAM

2021-05-14 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/290 ** Changed in: qemu Status: Confirmed => Expired ** Bug

[Bug 1905037] Re: Qemu SPARC64 Panics on Sun Solaris 5.8 - BOP_ALLOC failed

2021-05-14 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/293 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1906948] Re: Enabling OpenGL for GUI doesn't work on old laptop

2021-05-14 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/296 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1914282] Re: block copy job sometimes hangs on the last block for minutes

2021-05-14 Thread Thomas Huth
Ticket has been moved to the gitlab issue tracker: https://gitlab.com/qemu-project/qemu/-/issues/287 ... thus I'm closing this on Launchpad now. ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #287 https://gitlab.com/qemu-project/qemu/-/issues/287 ** Changed in: qemu Status: I

[Bug 1906180] Re: Keyboard keys get stuck

2021-05-14 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/294 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1899539] Re: keyboard errors in DOS, found links to similar errors for reference

2021-05-14 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/292 ** Changed in: qemu Status: New => Expired ** Bug watch

Re: [PULL 00/10] Gitlab-CI, qtest, moxie removal and misc patches

2021-05-14 Thread Thomas Huth
On 14/05/2021 12.22, Philippe Mathieu-Daudé wrote: On 5/9/21 6:05 PM, Thomas Huth wrote: On 07/05/2021 14.41, Paolo Bonzini wrote: On 07/05/21 11:45, Thomas Huth wrote: diff --git a/Makefile b/Makefile index bcbbec71a1..3088502329 100644 --- a/Makefile +++ b/Makefile @@ -85,7 +85,8 @@ x := $

Re: [PULL 00/10] Gitlab-CI, qtest, moxie removal and misc patches

2021-05-14 Thread Philippe Mathieu-Daudé
On 5/9/21 6:05 PM, Thomas Huth wrote: > On 07/05/2021 14.41, Paolo Bonzini wrote: >> On 07/05/21 11:45, Thomas Huth wrote: >>> >>> >>> diff --git a/Makefile b/Makefile >>> index bcbbec71a1..3088502329 100644 >>> --- a/Makefile >>> +++ b/Makefile >>> @@ -85,7 +85,8 @@ x := $(shell rm -rf meson-priva

Re: [PATCH v2 0/4] iotests/297: Cover tests/

2021-05-14 Thread Max Reitz
On 12.05.21 19:43, Max Reitz wrote: v1: https://lists.nongnu.org/archive/html/qemu-block/2021-03/msg01471.html Hi, When reviewing Vladimir’s new addition to tests/, I noticed that 297 so far does not cover named tests. That isn’t so good. This series makes it cover them, and because tests/ i

Re: [PULL 0/4] tcg patch queue

2021-05-14 Thread Peter Maydell
On Thu, 13 May 2021 at 13:20, Richard Henderson wrote: > > The following changes since commit 3e9f48bcdabe57f8f90cf19f01bbbf3c86937267: > > Merge remote-tracking branch > 'remotes/alistair/tags/pull-riscv-to-apply-20210511' into staging (2021-05-12 > 17:31:52 +0100) > > are available in the Gi

[PULL v3 0/1] Rtd patches

2021-05-14 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit 2d3fc4e2b069494b1e9e2e4a1e3de24cbc036426: Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2021-05-12' into staging (2021-05-13 20:13:24 +0100) are available in the Git repository at: g...@gitlab.com:marcandre.lureau/qe

Re: [PATCH 07/11] target/ppc: added KVM fallback to fpscr manipulation

2021-05-14 Thread Bruno Piazera Larsen
On 13/05/2021 19:45, Richard Henderson wrote: On 5/13/21 11:36 AM, Bruno Piazera Larsen wrote: On 12/05/2021 15:20, Richard Henderson wrote: On 5/12/21 9:08 AM, Bruno Larsen (billionai) wrote: diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 104a308abb..a8a720eb48 100644 --- a/target/p

[PULL v3 1/1] sphinx: adopt kernel readthedoc theme

2021-05-14 Thread marcandre . lureau
From: Marc-André Lureau The default "alabaster" sphinx theme has a couple shortcomings: - the navbar moves along the page - the search bar is not always at the same place - it lacks some contrast and colours The "rtd" theme from readthedocs.org is a popular third party theme used notably by the

Re: [PATCH V3 07/22] cpr

2021-05-14 Thread Stefan Hajnoczi
On Thu, May 13, 2021 at 04:21:02PM -0400, Steven Sistare wrote: > On 5/12/2021 12:19 PM, Stefan Hajnoczi wrote: > > On Fri, May 07, 2021 at 05:25:05AM -0700, Steve Sistare wrote: > >> To use the restart mode, qemu must be started with the memfd-alloc machine > >> option. The memfd's are saved to t

[Bug 1916775] Re: Guest freezes until there is a keyboard input on Windows version

2021-05-14 Thread Thomas Huth
This ticket has been moved here (thanks, Abdurrahim): https://gitlab.com/qemu-project/qemu/-/issues/289 ... thus I'm closing this ticket on Launchpad now. ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #289 https://gitlab.com/qemu-project/qemu/-/issues/289 ** Changed in: qemu

[PATCH v8 0/7] eBPF RSS support for virtio-net.

2021-05-14 Thread Andrew Melnychenko
This set of patches introduces the usage of eBPF for packet steering and RSS hash calculation: * RSS(Receive Side Scaling) is used to distribute network packets to guest virtqueues by calculating packet hash * Additionally adding support for the usage of RSS with vhost The eBPF works on kernels 5.

[PATCH v8 1/7] net/tap: Added TUNSETSTEERINGEBPF code.

2021-05-14 Thread Andrew Melnychenko
Additional code that will be used for eBPF setting steering routine. Signed-off-by: Andrew Melnychenko --- net/tap-linux.h | 1 + 1 file changed, 1 insertion(+) diff --git a/net/tap-linux.h b/net/tap-linux.h index 2f36d100fc..1d06fe0de6 100644 --- a/net/tap-linux.h +++ b/net/tap-linux.h @@ -31,

[PATCH v8 6/7] docs: Added eBPF documentation.

2021-05-14 Thread Andrew Melnychenko
Signed-off-by: Yuri Benditovich Signed-off-by: Andrew Melnychenko --- docs/devel/ebpf_rss.rst | 125 docs/devel/index.rst| 1 + 2 files changed, 126 insertions(+) create mode 100644 docs/devel/ebpf_rss.rst diff --git a/docs/devel/ebpf_rss.rst b/do

[PATCH v8 2/7] net: Added SetSteeringEBPF method for NetClientState.

2021-05-14 Thread Andrew Melnychenko
For now, that method supported only by Linux TAP. Linux TAP uses TUNSETSTEERINGEBPF ioctl. Signed-off-by: Andrew Melnychenko --- include/net/net.h | 2 ++ net/tap-bsd.c | 5 + net/tap-linux.c | 13 + net/tap-solaris.c | 5 + net/tap-stub.c| 5 + net/tap.c

[PATCH v8 3/7] ebpf: Added eBPF RSS program.

2021-05-14 Thread Andrew Melnychenko
RSS program and Makefile to build it. The bpftool used to generate '.h' file. The data in that file may be loaded by libbpf. EBPF compilation is not required for building qemu. You can use Makefile if you need to regenerate rss.bpf.skeleton.h. Signed-off-by: Yuri Benditovich Signed-off-by: Andrew

[PATCH v8 5/7] virtio-net: Added eBPF RSS to virtio-net.

2021-05-14 Thread Andrew Melnychenko
When RSS is enabled the device tries to load the eBPF program to select RX virtqueue in the TUN. If eBPF can be loaded the RSS will function also with vhost (works with kernel 5.8 and later). Software RSS is used as a fallback with vhost=off when eBPF can't be loaded or when hash population request

[PATCH v8 7/7] MAINTAINERS: Added eBPF maintainers information.

2021-05-14 Thread Andrew Melnychenko
Signed-off-by: Yuri Benditovich Signed-off-by: Andrew Melnychenko --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 36055f14c5..c7e9a57cd9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3312,6 +3312,14 @@ F: include/hw/remote/proxy-memory

[PATCH v8 4/7] ebpf: Added eBPF RSS loader.

2021-05-14 Thread Andrew Melnychenko
Added function that loads RSS eBPF program. Added stub functions for RSS eBPF loader. Added meson and configuration options. By default, eBPF feature enabled if libbpf is present in the build system. libbpf checked in configuration shell script and meson script. Signed-off-by: Yuri Benditovich S

Re: [PATCH V3 00/22] Live Update

2021-05-14 Thread Stefan Hajnoczi
On Thu, May 13, 2021 at 04:21:15PM -0400, Steven Sistare wrote: > On 5/12/2021 12:42 PM, Stefan Hajnoczi wrote: > > On Fri, May 07, 2021 at 05:24:58AM -0700, Steve Sistare wrote: > >> Provide the cprsave and cprload commands for live update. These save and > >> restore VM state, with minimal guest

Re: [Bug 1910586] Re: SD card size constraint conceptually wrong

2021-05-14 Thread -
On Wed, May 12, 2021 at 11:08:09AM -, Thomas Huth wrote: > > If it is not fixed yet and you think that this bug report here is still > valid, then you have two options: Actually, you seem to have forgotten a third option: I simply don't care enough, especially after the patronizing response t

Re: [PATCH v8 0/7] eBPF RSS support for virtio-net.

2021-05-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210514114835.267316-1-and...@daynix.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210514114835.267316-1-and...@daynix.com Subject: [PATCH v8 0/7] eBPF RSS support for virt

[PATCH v2 01/12] gitlab: drop linux user build job for CentOS 7

2021-05-14 Thread Daniel P . Berrangé
It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. The build-user-centos7 job was to detect a failure specific to CentOS 7 and there are already other linux user jobs for other platforms. Thus we can

[PATCH v2 00/12] Wave goodbye to RHEL 7 vintage distros

2021-05-14 Thread Daniel P . Berrangé
The main motivation for this series is to eliminate some backcompat logic in the crypto code only needed for RHEL-7. I take the opportunity to also bump the min required versions of glib, gcc and clang since we have dropped many distros since they were last bumped. There are possibly some more cle

[PATCH v2 04/12] crypto: drop back compatibility typedefs for nettle

2021-05-14 Thread Daniel P . Berrangé
Now that we only support modern nettle, we don't need to have local typedefs to mask the real nettle types. Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: Daniel P. Berrangé --- crypto/cipher-nettle.c.inc | 60 -- crypto/hash-nettle.c

[PATCH v2 06/12] crypto: bump min gnutls to 3.5.18, dropping RHEL-7 support

2021-05-14 Thread Daniel P . Berrangé
It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. This lets us increment the minimum required gnutls version Per repology, current shipping versions are: RHEL-8: 3.6.14 Debian Bus

[PATCH v2 02/12] patchew: move quick build job from CentOS 7 to CentOS 8 container

2021-05-14 Thread Daniel P . Berrangé
It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. Signed-off-by: Daniel P. Berrangé --- .patchew.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.patchew.yml b/.patche

[PATCH v2 07/12] crypto: drop used conditional check

2021-05-14 Thread Daniel P . Berrangé
The condition being tested has never been set since the day the code was first introduced. Reviewed-by: Willian Rampazzo Reviewed-by: Richard Henderson Signed-off-by: Daniel P. Berrangé --- crypto/tlscredsx509.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/crypto/tlscredsx509.c b/crypt

[PATCH v2 08/12] tests/vm: convert centos VM recipe to CentOS 8

2021-05-14 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- tests/vm/centos | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/tests/vm/centos b/tests/vm/centos index efe3dbbb36..5c7bc1c1a9 100755 --- a/tests/vm/centos +++ b/tests/vm/centos @@ -26,24 +26,23 @@ class CentosVM(basevm.B

[PATCH v2 03/12] crypto: bump min nettle to 3.4, dropping RHEL-7 support

2021-05-14 Thread Daniel P . Berrangé
It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. This lets us increment the minimum required nettle version and drop a lot of backwards compatibility code for 2.x series of nettle. Per repology, cur

[PATCH v2 10/12] configure: bump min required glib version to 2.56

2021-05-14 Thread Daniel P . Berrangé
The glib version was not previously constrained by RHEL-7 since it rebases fairly often. Instead SLES 12 and Ubuntu 16.04 were the constraints in 00f2cfbbec63fb6f5a7789797a62ccedd22466ea. Both of these are old enough that they are outside our platform support matrix now. Per repology, current ship

[PATCH v2 09/12] tests/docker: drop CentOS 7 container

2021-05-14 Thread Daniel P . Berrangé
It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. Reviewed-by: Thomas Huth Acked-by: Alex Bennée Reviewed-by: Willian Rampazzo Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/containers.yml

[PATCH v2 05/12] crypto: bump min gcrypt to 1.8.0, dropping RHEL-7 support

2021-05-14 Thread Daniel P . Berrangé
It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. This lets us increment the minimum required gcrypt version and assume that HMAC is always supported Per repology, current shipping versions are:

Re: [PATCH v2 1/2] net/tap: fix FreeBSD portability problem receiving TAP FD

2021-05-14 Thread Daniel P . Berrangé
On Wed, May 12, 2021 at 06:35:57PM +0200, Philippe Mathieu-Daudé wrote: > On 5/12/21 5:36 PM, Daniel P. Berrangé wrote: > > The CMSG_LEN and CMSG_SPACE macros must not be assumed to return the > > same value. The msg_controllen field must be initialized using > > CMSG_SPACE when using SCM_RIGHTS. >

[PATCH v2 11/12] configure: bump min required GCC to 7.5.0

2021-05-14 Thread Daniel P . Berrangé
Several distros have been dropped since the last time we bumped the minimum required GCC version. Per repology, currently shipping versions are: RHEL-8: 8.3.1 Debian Buster: 8.3.0 openSUSE Leap 15.2: 7.5.0 Ubuntu LTS 18.04: 7.5.0 Ubuntu LTS 20.04: 9.3.0 FreeB

[PATCH v2 12/12] configure: bump min required CLang to 6.0 / XCode 10.0

2021-05-14 Thread Daniel P . Berrangé
Several distros have been dropped since the last time we bumped the minimum required CLang version. Per repology, currently shipping versions are: RHEL-8: 10.0.1 Debian Buster: 7.0.1 openSUSE Leap 15.2: 9.0.1 Ubuntu LTS 18.04: 6.0.0 Ubuntu LTS 20.04: 10.0.0 Free

[PULL 00/20] CI, qtest, and misc patches

2021-05-14 Thread Thomas Huth
Hi Peter! The following changes since commit 2d3fc4e2b069494b1e9e2e4a1e3de24cbc036426: Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2021-05-12' into staging (2021-05-13 20:13:24 +0100) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-reque

[PULL 01/20] tests/docker/dockerfiles: Add ccache to containers where it was missing

2021-05-14 Thread Thomas Huth
Make sure that ccache is available in all containers. Message-Id: <20210414081907.871437-2-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/docker/dockerfiles/alpine.docker | 1 + tests/docker/dockerfiles/fedora-i386-cross.docker | 1 + tests/docker/dockerfiles/fedora-win32-cr

[PULL 05/20] libqos/qgraph: fix "UNAVAILBLE" typo

2021-05-14 Thread Thomas Huth
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Message-Id: <20210412143437.727560-2-stefa...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Acked-by: Paolo Bonzini Signed-off-by: Thomas Huth --- tests/qtest/libqos/qgraph.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [PATCH v2 01/12] gitlab: drop linux user build job for CentOS 7

2021-05-14 Thread Thomas Huth
On 14/05/2021 14.04, Daniel P. Berrangé wrote: It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. The build-user-centos7 job was to detect a failure specific to CentOS 7 and there are already other

[PULL 03/20] gitlab-ci: Replace YAML anchors by extends (native_build_job)

2021-05-14 Thread Thomas Huth
From: Philippe Mathieu-Daudé 'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends Reviewed-by: Wainer dos Santos Moschetta Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210418233448.1267991-3-f4...

[PULL 02/20] gitlab-ci: Replace YAML anchors by extends (container_job)

2021-05-14 Thread Thomas Huth
From: Philippe Mathieu-Daudé 'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Message-Id: <2021

[PULL 11/20] tests/migration-test: Fix "true" vs true

2021-05-14 Thread Thomas Huth
From: "Dr. David Alan Gilbert" Accidental use of "true" as a boolean; spotted by coverity and Peter. Fixes: b99784ef6c3 Fixes: d795f47466e Reported-by: Peter Maydell Reported-by: Coverity (CID 1432373, 1432292, 1432288) Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Thomas Huth Reviewed-b

[PULL 04/20] gitlab-ci: Replace YAML anchors by extends (native_test_job)

2021-05-14 Thread Thomas Huth
From: Philippe Mathieu-Daudé 'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends Reviewed-by: Wainer dos Santos Moschetta Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210418233448.1267991-4-f4...

[PULL 10/20] tests/qtest/npcm7xx_pwm-test.c: Avoid g_assert_true() for non-test assertions

2021-05-14 Thread Thomas Huth
From: Peter Maydell In the glib API, the distinction between g_assert() and g_assert_true() is that the former is for "bug, terminate the application" and the latter is for "test check, on failure either terminate or just mark the testcase as failed". For QEMU, g_assert() is always fatal, so cod

Re: [PATCH v2 02/12] patchew: move quick build job from CentOS 7 to CentOS 8 container

2021-05-14 Thread Thomas Huth
On 14/05/2021 14.04, Daniel P. Berrangé wrote: It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. Signed-off-by: Daniel P. Berrangé --- .patchew.yml | 6 +++--- 1 file changed, 3 insertions(+),

[PULL 17/20] configure: Poison all current target-specific #defines

2021-05-14 Thread Thomas Huth
We are generating a lot of target-specific defines in the *-config-devices.h and *-config-target.h files. Using them in common code is wrong and leads to very subtle bugs since a "#ifdef CONFIG_SOMETHING" is not working there as expected. To avoid these issues, we are already poisoning many of the

[PULL 07/20] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm

2021-05-14 Thread Thomas Huth
From: Stefan Hajnoczi Some downstreams rename the QEMU binary to "qemu-kvm". This breaks qtest_get_arch(), which attempts to parse the target architecture from the QTEST_QEMU_BINARY environment variable. Print an error instead of returning the architecture "kvm". Things fail in weird ways when t

[PULL 09/20] tests/qtest/ahci-test.c: Calculate iso_size with 64-bit arithmetic

2021-05-14 Thread Thomas Huth
From: Peter Maydell Coverity notes that when calculating the 64-bit iso_size value in ahci_test_cdrom() we actually only do it with 32-bit arithmetic. This doesn't matter for the current test code because nsectors is always small; but adding the cast avoids the coverity complaints. Fixes: Coveri

Re: [PATCH v2 05/12] crypto: bump min gcrypt to 1.8.0, dropping RHEL-7 support

2021-05-14 Thread Thomas Huth
On 14/05/2021 14.04, Daniel P. Berrangé wrote: It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. This lets us increment the minimum required gcrypt version and assume that HMAC is always supported

Re: [PATCH v2 06/12] crypto: bump min gnutls to 3.5.18, dropping RHEL-7 support

2021-05-14 Thread Thomas Huth
On 14/05/2021 14.04, Daniel P. Berrangé wrote: It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. This lets us increment the minimum required gnutls version Per repology, current shipping versions a

[PULL 06/20] docs/devel/qgraph: add troubleshooting information

2021-05-14 Thread Thomas Huth
From: Stefan Hajnoczi It can be tricky to troubleshoot qos-test when a test won't execute. Add an explanation of how to trace qgraph node connectivity and find which node has the problem. Signed-off-by: Stefan Hajnoczi Message-Id: <20210412143437.727560-3-stefa...@redhat.com> Acked-by: Paolo Bo

[PULL 08/20] util/compatfd.c: Replaced a malloc call with g_malloc.

2021-05-14 Thread Thomas Huth
From: Mahmoud Mandour Replaced a call to malloc() and its respective call to free() with g_malloc() and g_free(). g_malloc() is preferred more than g_try_* functions, which return NULL on error, when the size of the requested allocation is small. This is because allocating few bytes should not

[PULL 13/20] tests/qtest/rtc-test: Remove pointless NULL check

2021-05-14 Thread Thomas Huth
From: Peter Maydell In rtc-test.c we know that s is non-NULL because qtest_start() will return a non-NULL value, and we assume this when we pass s to qtest_irq_intercept_in(). So we can drop the initial assignment of NULL and the "if (s)" condition at the end of the function. Fixes: Coverity CID

Re: [PATCH v2 12/12] configure: bump min required CLang to 6.0 / XCode 10.0

2021-05-14 Thread Philippe Mathieu-Daudé
On 5/14/21 2:04 PM, Daniel P. Berrangé wrote: > Several distros have been dropped since the last time we bumped the > minimum required CLang version. > > Per repology, currently shipping versions are: > > RHEL-8: 10.0.1 > Debian Buster: 7.0.1 > openSUSE Leap 15.2: 9.0.1 >U

[PULL 15/20] include/sysemu: Poison all accelerator CONFIG switches in common code

2021-05-14 Thread Thomas Huth
We are already poisoning CONFIG_KVM since this switch is not working in common code. Do the same with the other accelerator switches, too (except for CONFIG_TCG, which is special, since it is also defined in config-host.h). Message-Id: <20210414112004.943383-2-th...@redhat.com> Reviewed-by: Philip

[PULL 14/20] tests: Avoid side effects inside g_assert() arguments

2021-05-14 Thread Thomas Huth
From: Peter Maydell For us, assertions are always enabled, but side-effect expressions inside the argument to g_assert() are bad style anyway. Fix three occurrences in IPMI related tests, which will silence some Coverity nits. Fixes: CID 1432322, CID 1432287, CID 1432291 Signed-off-by: Peter May

[PULL 12/20] tests/qtest/tpm-util.c: Free memory with correct free function

2021-05-14 Thread Thomas Huth
From: Peter Maydell tpm_util_migration_start_qemu() allocates memory with g_strdup_printf() but frees it with free() rather than g_free(), which provokes Coverity complaints (CID 1432379, 1432350). Use the correct free function. Fixes: Coverity CID 1432379, CID 1432350 Signed-off-by: Peter Mayde

[PULL 16/20] migration: Move populate_vfio_info() into a separate file

2021-05-14 Thread Thomas Huth
The CONFIG_VFIO switch only works in target specific code. Since migration/migration.c is common code, the #ifdef does not have the intended behavior here. Move the related code to a separate file now which gets compiled via specific_ss instead. Fixes: 3710586caa ("qapi: Add VFIO devices migration

Re: [PATCH v2 0/6] vhost-user-blk: Error handling fixes during initialistion

2021-05-14 Thread Michael S. Tsirkin
On Thu, Apr 29, 2021 at 07:13:10PM +0200, Kevin Wolf wrote: > vhost-user-blk neglects for several properties to check whether the > configured value is even compatible with the backend. This results > sometimes in crashes because of buggy error handling code, and sometimes > in devices that are pre

[PULL 19/20] pc-bios/s390-ccw: Fix inline assembly for older versions of Clang

2021-05-14 Thread Thomas Huth
Clang versions before v11.0 insist on having the %rX or %cX register names instead of just a number. Since our Travis-CI is currently still using Clang v6.0, we have to fix this to avoid failing jobs. Message-Id: <20210512171550.476130-2-th...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signe

Re: [PATCH v2 10/12] configure: bump min required glib version to 2.56

2021-05-14 Thread Thomas Huth
On 14/05/2021 14.04, Daniel P. Berrangé wrote: The glib version was not previously constrained by RHEL-7 since it rebases fairly often. Instead SLES 12 and Ubuntu 16.04 were the constraints in 00f2cfbbec63fb6f5a7789797a62ccedd22466ea. Both of these are old enough that they are outside our platfor

[PULL 18/20] tests/qtest/migration-test: Use g_autofree to avoid leaks on error paths

2021-05-14 Thread Thomas Huth
From: Peter Maydell Coverity notices that several places in the migration-test code fail to free memory in error-exit paths. This is pretty unimportant in test case code, but we can avoid having to manually free the memory entirely by using g_autofree. The places where Coverity spotted a leak w

[PULL 20/20] cirrus.yml: Fix the MSYS2 task

2021-05-14 Thread Thomas Huth
The MSYS2 task in the Cirrus-CI is currently failing with error messages like this: warning: database file for 'ucrt64' does not exist (use '-Sy' to download) :: Starting core system upgrade... there is nothing to do :: Starting full system upgrade... error: failed to prepare transaction (co

Re: [PATCH v6 00/12] qtests: Check accelerator available at runtime via QMP 'query-accels'

2021-05-14 Thread Michael S. Tsirkin
On Mon, May 03, 2021 at 11:10:08PM +0200, Philippe Mathieu-Daudé wrote: > Missing review: 10-12 (bios-tables-test) So the main functional changes is ARM stuff I think? Pls use that tree to merge. Reviewed-by: Michael S. Tsirkin > Hi, > > This series aims at having accelerator-independent qt

Re: [PATCH v2 03/12] crypto: bump min nettle to 3.4, dropping RHEL-7 support

2021-05-14 Thread Thomas Huth
On 14/05/2021 14.04, Daniel P. Berrangé wrote: It has been over two years since RHEL-8 was released, and thus per the platform build policy, we no longer need to support RHEL-7 as a build target. This lets us increment the minimum required nettle version and drop a lot of backwards compatibility

Re: [PATCH v2] tcg: Use correct trap number for page faults on *BSD systems

2021-05-14 Thread Richard Henderson
On 5/6/21 12:53 PM, Warner Losh wrote: On Thu, May 6, 2021 at 11:51 AM Richard Henderson > wrote: On 5/6/21 10:38 AM, Warner Losh wrote: > The trap number for a page fault on BSD systems is T_PAGEFLT not 0xe. 0xe is > used by Linux and repre

Re: [Qemu-devel] [PATCH] MAINTAINERS: convert to JSON

2021-05-14 Thread Willian Rampazzo
On Fri, May 14, 2021 at 2:31 AM Paolo Bonzini wrote: > > On 13/05/21 23:02, Willian Rampazzo wrote: > > I think I understand why you brought this thread back now. Finding a way > > to correlate maintainers and tags is, indeed, a nice feature that can > > help with your idea about correlating tags

Re: [PATCH v2 11/12] configure: bump min required GCC to 7.5.0

2021-05-14 Thread Thomas Huth
On 14/05/2021 14.04, Daniel P. Berrangé wrote: Several distros have been dropped since the last time we bumped the minimum required GCC version. Per repology, currently shipping versions are: RHEL-8: 8.3.1 Debian Buster: 8.3.0 openSUSE Leap 15.2: 7.5.0 Ubuntu LTS 18.0

Re: [RFC PATCH 0/9] Initial support for machine creation via QMP

2021-05-14 Thread Mirela Grujic
Hi Paolo, Thanks for the feedback! On 5/13/21 7:52 PM, Paolo Bonzini wrote: Hi Mirela, this is very interesting! It's unfortunate that I completely missed the discussions in January/February.  You might have noticed that in the 5.2/6.0 timeframe I worked on cleaning up the machine initiali

[Bug 1910586] Re: SD card size constraint conceptually wrong

2021-05-14 Thread Philippe Mathieu-Daudé
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'invalid' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/297 ** Changed in: qemu Status: Incomplete => Confirmed **

[PATCH] linux-user: Handle EXCP10_COPR properly for i386

2021-05-14 Thread 邹旭
>From e805b793f7d4b3e8c37d540b7d6cc0c6ac682311 Mon Sep 17 00:00:00 2001 From: Xu Zou Date: Fri, 14 May 2021 15:55:07 +0800 Subject: [PATCH] linux-user: Handle EXCP10_COPR properly for i386 Handle EXCP10_COPR properly for i386 in cpu loop. NE flag is set to select native mode for handling floatin

Re: [RFC PATCH 7/9] qdev-monitor: Restructure and fix the check for command availability

2021-05-14 Thread Mirela Grujic
On 5/13/21 7:43 PM, Paolo Bonzini wrote: On 13/05/21 10:25, Mirela Grujic wrote: The existing code had to be restructured to make room for adding checks that are specific to the machine phases. The fix is related to the way that commands with the 'allow-preconfig' option are treated. Command

[PATCH] linux-user: Handle EXCP10_COPR properly for i386

2021-05-14 Thread Xu Zou
Handle EXCP10_COPR properly for i386 in cpu loop. NE flag is set to select native mode for handling floating-point exceptions. FWAIT instruction can raise EXCP10_COPR exception by using fpu_raise_exception() function. The code is based on kernel's function fpu__exception_code() in arch/x86/kernel

[PATCH] linux-user: Handle EXCP10_COPR properly for i386

2021-05-14 Thread Xu Zou
Handle EXCP10_COPR properly for i386 in cpu loop. NE flag is set to select native mode for handling floating-point exceptions. FWAIT instruction can raise EXCP10_COPR exception by using fpu_raise_exception() function. The code is based on kernel's function fpu__exception_code() in arch/x86/kernel

Re: [RFC PATCH 2/9] replace machine phase_check with machine_is_initialized/ready calls

2021-05-14 Thread Mirela Grujic
On 5/13/21 7:46 PM, Paolo Bonzini wrote: On 13/05/21 10:25, Mirela Grujic wrote: Once we define MachineInitPhase in qapi, the generated enumeration constants will be prefixed with the MACHINE_INIT_PHASE_. We need to define the MachineInitPhase enum in qapi in order to add the QMP command that

Re: [PULL 00/17] migration queue

2021-05-14 Thread Peter Maydell
On Thu, 13 May 2021 at 18:37, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > The following changes since commit dab59ce031228066eb95a9c518846fcacfb0dbbf: > > Merge remote-tracking branch 'remotes/philmd/tags/pflash-20210511' into > staging (2021-05-13 14:45:38 +0100

Re: [RFC PATCH 08/11] target/ppc: wrapped some TCG only logic with ifdefs

2021-05-14 Thread Bruno Piazera Larsen
On 12/05/2021 15:57, Bruno Piazera Larsen wrote: On 12/05/2021 15:33, Richard Henderson wrote: On 5/12/21 9:08 AM, Bruno Larsen (billionai) wrote: diff --git a/include/exec/helper-proto.h b/include/exec/helper-proto.h index ba100793a7..ce287222ee 100644 --- a/include/exec/helper-proto.h +++ b/

Re: [PATCH 0/6] pc: support user provided NIC naming/indexing

2021-05-14 Thread Michael S. Tsirkin
On Mon, Mar 15, 2021 at 02:00:56PM -0400, Igor Mammedov wrote: > > Changes since rfc: > * make sure that acpi-index unique > * use dedicated MMIO register for it > * drop syntetic acpi-label field in _DSM > * add more comments Could you rebase and repost please? Some comments in commit l

Re: [PATCH 2/6] pci: introduce apci-index property for PCI device

2021-05-14 Thread Michael S. Tsirkin
On Mon, Mar 15, 2021 at 02:00:58PM -0400, Igor Mammedov wrote: > In x86/ACPI world, linux distros are using predictable > network interface naming since systemd v197. Which on > QEMU based VMs results into path based naming scheme, > that names network interfaces based on PCI topology. > > With it

Re: [PATCH v5 0/7] eBPF RSS support for virtio-net

2021-05-14 Thread Michael S. Tsirkin
On Thu, Mar 25, 2021 at 05:35:22PM +0200, Andrew Melnychenko wrote: > This set of patches introduces the usage of eBPF for packet steering > and RSS hash calculation: > * RSS(Receive Side Scaling) is used to distribute network packets to > guest virtqueues by calculating packet hash > * Additionall

Re: [PATCH v4 0/1] Rework ACPI OEM fields handling to simplify code (was: acpi: Remove duplicated code handling OEM ID and OEM table ID fields)

2021-05-14 Thread Michael S. Tsirkin
On Thu, Apr 01, 2021 at 11:29:27PM +0300, Marian Postevca wrote: > This patch consolidates ACPI OEM fields handling > by: > - Moving common code in PC and MICROVM to X86. > - Changes unnecessary dynamic memory allocation to static allocation > - Uses dedicated structure to keep values of fields ins

  1   2   3   4   >