RE: [PATCH V6 0/6] Passthrough specific network traffic in COLO

2021-05-12 Thread Zhang, Chen
Hi Markus, Jason and Dave. This series has been modified according to previous suggestions. Please review it again to make sure I fully understand comments. Thanks Chen > -Original Message- > From: Qemu-devel bounces+chen.zhang=intel@nongnu.org> On Behalf Of Zhang, Chen > Sent: Wed

Re: [PATCH v3 31/33] block/nbd: add nbd_clinent_connected() helper

2021-05-12 Thread Paolo Bonzini
On 16/04/21 10:09, Vladimir Sementsov-Ogievskiy wrote: We already have two similar helpers for other state. Let's add another one for convenience. Signed-off-by: Vladimir Sementsov-Ogievskiy The whole usage of load-acquire for the connected state is completely meaningless, but that's not your

[PATCH] backends/tpm: Replace qemu_mutex_lock calls with QEMU_LOCK_GUARD

2021-05-12 Thread Philippe Mathieu-Daudé
Simplify the tpm_emulator_ctrlcmd() handler by replacing a pair of qemu_mutex_lock/qemu_mutex_unlock calls by the WITH_QEMU_LOCK_GUARD macro. Reviewed-by: Stefan Berger Reviewed-by: Christophe de Dinechin Signed-off-by: Philippe Mathieu-Daudé --- backends/tpm/tpm_emulator.c | 34 ++

Re: [PATCH 4/6] progressmeter: protect with a mutex

2021-05-12 Thread Vladimir Sementsov-Ogievskiy
11.05.2021 15:28, Paolo Bonzini wrote: On 10/05/21 13:28, Vladimir Sementsov-Ogievskiy wrote: Could we instead add a c file and add the structure private? Then we'll have progress_new() and progress_free() APIs instead. This way, it would be a lot simpler to control that nobady use structure

Re: [PATCH 0/3] hw/virtio: Constify VirtIOFeature

2021-05-12 Thread Stefano Garzarella
On Tue, May 11, 2021 at 12:41:54PM +0200, Philippe Mathieu-Daudé wrote: Trivial patches to keep VirtIOFeature arrays read-only (better safe than sorry). Philippe Mathieu-Daudé (3): hw/virtio: Pass virtio_feature_get_config_size() a const argument virtio-blk: Constify VirtIOFeature feature_size

Re: [PATCH v3 06/33] util/async: aio_co_schedule(): support reschedule in same ctx

2021-05-12 Thread Vladimir Sementsov-Ogievskiy
12.05.2021 09:56, Paolo Bonzini wrote: On 16/04/21 10:08, Vladimir Sementsov-Ogievskiy wrote: With the following patch we want to call wake coroutine from thread. And it doesn't work with aio_co_wake: Assume we have no iothreads. Assume we have a coroutine A, which waits in the yield point for e

Re: [PATCH v26 00/20] i386 cleanup PART 2

2021-05-12 Thread Philippe Mathieu-Daudé
On 5/6/21 11:33 AM, Philippe Mathieu-Daudé wrote: > On 5/6/21 11:10 AM, Philippe Mathieu-Daudé wrote: >> On 5/6/21 9:55 AM, Claudio Fontana wrote: >>> On 5/5/21 9:31 PM, Eduardo Habkost wrote: On Wed, May 05, 2021 at 02:15:29PM +0200, Philippe Mathieu-Daudé wrote: > On 5/5/21 12:04 PM, Ale

Re: [PATCH v3 31/33] block/nbd: add nbd_clinent_connected() helper

2021-05-12 Thread Vladimir Sementsov-Ogievskiy
12.05.2021 10:06, Paolo Bonzini wrote: On 16/04/21 10:09, Vladimir Sementsov-Ogievskiy wrote: We already have two similar helpers for other state. Let's add another one for convenience. Signed-off-by: Vladimir Sementsov-Ogievskiy The whole usage of load-acquire for the connected state is comp

Re: [PATCH] configure: Only clone softfloat-3 repositories if TCG is enabled

2021-05-12 Thread Paolo Bonzini
On 12/05/21 06:58, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- configure | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 5877a6b2bfe..e0e02623e3e 100755 --- a/configure +++ b/configure @@ -257,8 +257,6 @@ if te

Re: [RFC PATCH 5/5] meson: Do not use internal fdt library if user asked for the system one

2021-05-12 Thread Paolo Bonzini
On 11/05/21 17:53, Philippe Mathieu-Daudé wrote: diff --git a/meson.build b/meson.build index 0b41ff41188..1ffb4bccdb2 100644 --- a/meson.build +++ b/meson.build @@ -1612,7 +1612,7 @@ int main(void) { fdt_check_full(NULL, 0); return 0; }''', dependencies: fdt) fdt_opt

Re: [RFC PATCH 0/5] buildsys: Do not use internal fdt library when asked for the system one

2021-05-12 Thread Paolo Bonzini
On 12/05/21 05:56, Philippe Mathieu-Daudé wrote: qemu/meson.build:1352:4: ERROR: Running configure command failed. The following clauses were found for PSERIES CONFIG_PSERIES=y config PSERIES depends on FDT This is triggered with: fdt support: NO having: defa

Re: [PATCH v1 08/25] gitlab: add build-user-hexagon test

2021-05-12 Thread Alex Bennée
Sorted now. I had applied the patch but was running into trouble because although I'd pushed to the project registry when running on my gitlab project it was using the personal registry. Will post v3 later today. On Tue, 11 May 2021, 16:08 Brian Cain, wrote: > > -Original Message- > > Fr

Re: [RFC PATCH 2/5] Kconfig: Declare 'FDT' host symbol

2021-05-12 Thread Paolo Bonzini
On 11/05/21 17:53, Philippe Mathieu-Daudé wrote: The CONFIG_FDT symbol depends on the availability of the fdt library on the host. To be able to have other symbols depends on it, declare it symbol in Kconfig.host. Signed-off-by: Philippe Mathieu-Daudé --- Kconfig.host | 3 +++ 1 file changed

Re: [PATCH] scripts: add a script to list virtio devices in a system

2021-05-12 Thread Laurent Vivier
On 11/05/2021 11:17, Peter Maydell wrote: > On Thu, 6 May 2021 at 20:36, Laurent Vivier wrote: >> >> Add "lsvirtio" that lists all virtio devices in a system >> the same way lspci does for the PCI cards. > > This is cool, but it's not really QEMU specific -- it should > work on any Linux guest ru

Re: [RFC PATCH 3/5] hw/ppc: Have pSeries depends on libfdt (via host Kconfig FDT symbol)

2021-05-12 Thread Paolo Bonzini
On 11/05/21 17:53, Philippe Mathieu-Daudé wrote: Since commit fea35ca4b8e ("ppc/spapr: Receive and store device tree blob from SLOF") the pSeries machine depends on the libfdt fdt_check_full() call, which is available in libfdt v1.4.7. Add the corresponding Kconfig dependency. Signed-off-by: Ph

Re: [PULL 30/33] migration: do not restart VM after successful snapshot-load

2021-05-12 Thread Kevin Wolf
Am 11.05.2021 um 19:06 hat Daniel P. Berrangé geschrieben: > On Tue, May 11, 2021 at 04:13:47AM -0400, Paolo Bonzini wrote: > > The HMP loadvm code is calling load_snapshot rather than > > qmp_snapshot_load, in order to bypass the job infrastructure. The code > > around it is almost the same, with

Re: [PULL 0/9] s390-ccw bios update

2021-05-12 Thread Peter Maydell
On Mon, 10 May 2021 at 08:35, Thomas Huth wrote: > > Hi Peter, > > the following changes since commit d90f154867ec0ec22fd719164b88716e8fd48672: > > Merge remote-tracking branch 'remotes/dg-gitlab/tags/ppc-for-6.1-20210504' > into staging (2021-05-05 20:29:14 +0100) > > are available in the Git

[RFC PATCH] block/io.c: Flush parent for quorum in generic code

2021-05-12 Thread Zhang Chen
Fix the issue from this patch: [PATCH] block: Flush all children in generic code >From 883833e29cb800b4d92b5d4736252f4004885191 Quorum driver do not have the primary child. It will caused guest block flush issue when use quorum and NBD. The vm guest flushes failed,and then guest filesystem is shut

Re: [PULL v4 34/48] vhost-user: save features of multiqueues if chardev is closed

2021-05-12 Thread Michael S. Tsirkin
On Tue, Sep 29, 2020 at 03:22:25AM -0400, Michael S. Tsirkin wrote: > From: haibinzhang(张海斌) > > Fore-commit(c6beefd674) only saves features of queue0, > this makes wrong features of other queues in multiqueues > situation. > For examples: > qemu-system-aarch64 ... \ > -chardev socket,id=char

Re: [RFC PATCH 4/5] hw/ppc/fdt: Drop dependency on libfdt

2021-05-12 Thread Paolo Bonzini
On 12/05/21 04:30, David Gibson wrote: On Tue, May 11, 2021 at 05:53:53PM +0200, Philippe Mathieu-Daudé wrote: hw/ppc/fdt.c defines the ppc_create_page_sizes_prop() function, which is unrelated to the libfdt. Remove the incorrect library dependency on the file. Signed-off-by: Philippe Mathieu-D

Re: [RFC PATCH 3/5] hw/ppc: Have pSeries depends on libfdt (via host Kconfig FDT symbol)

2021-05-12 Thread Paolo Bonzini
On 12/05/21 04:27, David Gibson wrote: On Tue, May 11, 2021 at 05:53:52PM +0200, Philippe Mathieu-Daudé wrote: Since commit fea35ca4b8e ("ppc/spapr: Receive and store device tree blob from SLOF") the pSeries machine depends on the libfdt fdt_check_full() call, which is available in libfdt v1.4.7

Re: making a qdev bus available from a (non-qtree?) device

2021-05-12 Thread Peter Maydell
On Wed, 12 May 2021 at 04:39, Philippe Mathieu-Daudé wrote: > IIUC, while we can have unattached drives, we can't (by design) have > qdev unattached to qbus. You can (and we do), but it is a bit of a problem because a device not attached to a qbus will not get automatically reset, and so you need

Re: [RFC PATCH 1/5] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on'

2021-05-12 Thread Paolo Bonzini
On 11/05/21 17:53, Philippe Mathieu-Daudé wrote: Per the kconfig.rst: A device should be listed [...] ``imply`` if (depending on the QEMU command line) the board may or may not be started without it. This is the case with the NVDIMM device, so use the 'imply' weak reverse dependency t

Re: [PULL 30/33] migration: do not restart VM after successful snapshot-load

2021-05-12 Thread Paolo Bonzini
On 11/05/21 10:56, Dr. David Alan Gilbert wrote: * Paolo Bonzini (pbonz...@redhat.com) wrote: The HMP loadvm code is calling load_snapshot rather than qmp_snapshot_load, in order to bypass the job infrastructure. The code around it is almost the same, with one difference: hmp_loadvm is restarti

Re: [RFC PATCH 3/5] hw/ppc: Have pSeries depends on libfdt (via host Kconfig FDT symbol)

2021-05-12 Thread Philippe Mathieu-Daudé
On 5/12/21 9:45 AM, Paolo Bonzini wrote: > On 11/05/21 17:53, Philippe Mathieu-Daudé wrote: >> Since commit fea35ca4b8e ("ppc/spapr: Receive and store device >> tree blob from SLOF") the pSeries machine depends on the libfdt >> fdt_check_full() call, which is available in libfdt v1.4.7. >> >> Add t

[PULL v2 00/32] Misc (mostly i386) patches for 2021-05-11

2021-05-12 Thread Paolo Bonzini
The following changes since commit e58c7a3bba3076890592f02d2b0e596bf191b5c2: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210510-1' into staging (2021-05-10 17:28:11 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstrea

Re: [PATCH v3 19/33] block/nbd: split nbd_handle_updated_info out of nbd_client_handshake()

2021-05-12 Thread Roman Kagan
On Fri, Apr 16, 2021 at 11:08:57AM +0300, Vladimir Sementsov-Ogievskiy wrote: > To be reused in the following patch. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/nbd.c | 99 ++--- > 1 file changed, 57 insertions(+), 42 deletions(-)

Re: [PATCH v6 26/82] target/arm: Implement SVE2 SHRN, RSHRN

2021-05-12 Thread Peter Maydell
On Fri, 30 Apr 2021 at 21:49, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v2: Fix typo in gen_shrnb_vec (laurent desnogues) > v3: Replace DO_RSHR with an inline function > --- > target/arm/helper-sve.h| 16 > target/arm/sve.decode | 8 ++ > target/arm/s

Re: [PATCH v6 27/82] target/arm: Implement SVE2 SQSHRUN, SQRSHRUN

2021-05-12 Thread Peter Maydell
On Fri, 30 Apr 2021 at 21:44, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 16 +++ > target/arm/sve.decode | 4 ++ > target/arm/sve_helper.c| 35 ++ > target/arm/translate-sve.c | 98 +

Re: [PATCH v6 28/82] target/arm: Implement SVE2 UQSHRN, UQRSHRN

2021-05-12 Thread Peter Maydell
On Fri, 30 Apr 2021 at 21:47, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 16 +++ > target/arm/sve.decode | 4 ++ > target/arm/sve_helper.c| 24 ++ > target/arm/translate-sve.c | 93 +

Re: [PATCH v6 29/82] target/arm: Implement SVE2 SQSHRN, SQRSHRN

2021-05-12 Thread Peter Maydell
On Fri, 30 Apr 2021 at 21:50, Richard Henderson wrote: > > This completes the section "SVE2 bitwise shift right narrow". > > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 16 ++ > target/arm/sve.decode | 4 ++ > target/arm/sve_helper.c| 24 + > ta

Re: [PATCH v6 30/82] target/arm: Implement SVE2 WHILEGT, WHILEGE, WHILEHI, WHILEHS

2021-05-12 Thread Peter Maydell
On Fri, 30 Apr 2021 at 21:54, Richard Henderson wrote: > > Rename the existing sve_while (less-than) helper to sve_whilel > to make room for a new sve_whileg helper for greater-than. > > Signed-off-by: Richard Henderson > --- > v2: Use a new helper function to implement this. > v4: Update for PRE

Re: [PATCH v3 21/33] qemu-socket: pass monitor link to socket_get_fd directly

2021-05-12 Thread Roman Kagan
On Mon, Apr 19, 2021 at 10:34:49AM +0100, Daniel P. Berrangé wrote: > On Fri, Apr 16, 2021 at 11:08:59AM +0300, Vladimir Sementsov-Ogievskiy wrote: > > Detecting monitor by current coroutine works bad when we are not in > > coroutine context. And that's exactly so in nbd reconnect code, where > > q

Re: [PATCH v3 21/33] qemu-socket: pass monitor link to socket_get_fd directly

2021-05-12 Thread Daniel P . Berrangé
On Wed, May 12, 2021 at 12:40:03PM +0300, Roman Kagan wrote: > On Mon, Apr 19, 2021 at 10:34:49AM +0100, Daniel P. Berrangé wrote: > > On Fri, Apr 16, 2021 at 11:08:59AM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > Detecting monitor by current coroutine works bad when we are not in > > > c

[PATCH] add Visual Studio Code configuration

2021-05-12 Thread Paolo Bonzini
Add configurations to build files with Visual Studio Code and to retrieve the search path for headers from the compile_commands.json file. Using this configuration requires installing the Meson extension and using a build subdirectory that matches the one configured in the Meson extension itself.

[PATCH] linux-user: Add strace support for printing arguments of llseek

2021-05-12 Thread Kito Cheng
Some target are using llseek instead of _llseek like riscv, nios2, hexagon, and openrisc. Signed-off-by: Kito Cheng --- linux-user/strace.c| 3 ++- linux-user/strace.list | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index e9

[PATCH v3 09/31] tests/tcg: don't iterate through other arch compilers

2021-05-12 Thread Alex Bennée
There should only be one compiler per architecture. Those cases where the same compiler can deal with a different architecture should be explicitly set for both cross_cc and docker configurations. Otherwise you get strangeness like: --cross-cc-aarch64=/bin/false causing the logic to attempt to

[PATCH v3 00/31] testing/next pre-PR (hexagon, tricore, misc)

2021-05-12 Thread Alex Bennée
Hi, I was planning to cut the PR from v2 but I needed to squash a couple of remaining problems with the hexagon build and also when attempting to use clang to build the x86 tests. As a result here is a v3 that: - drops the signals stress test as it still triggers issues - sanitizier fail on

[PATCH v3 02/31] tests/docker: fix copying of executable in "update"

2021-05-12 Thread Alex Bennée
We have the same symlink chasing problem when doing an "update" operation. Fix that. Based-on: 5e33f7fead ("tests/docker: better handle symlinked libs") Signed-off-by: Alex Bennée Reviewed-by: Willian Rampazzo --- tests/docker/docker.py | 9 - 1 file changed, 8 insertions(+), 1 deletion

[PATCH v3 04/31] tests/docker: allow "update" to add the current user

2021-05-12 Thread Alex Bennée
The current user functionality is used for cross compiling to avoid complications with permissions when building test programs. However for images that come from the registry we still need the ability to add the user after the fact. Reviewed-by: Willian Rampazzo Signed-off-by: Alex Bennée --- t

[PATCH v3 05/31] tests/docker: add "fetch" sub-command

2021-05-12 Thread Alex Bennée
This simply wraps up fetching a build from the registry and tagging it as the local build. Reviewed-by: Willian Rampazzo Signed-off-by: Alex Bennée --- tests/docker/docker.py | 17 + 1 file changed, 17 insertions(+) diff --git a/tests/docker/docker.py b/tests/docker/docker.py i

[PATCH v3 01/31] checkpatch: Fix use of uninitialized value

2021-05-12 Thread Alex Bennée
From: Greg Kurz checkfilename() doesn't always set $acpi_testexpected. Fix the following warning: Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. Fixes: d2f1af0e4120 ("checkpatch: don't emit warning on newly created acpi data files") Signed-off

[PATCH v3 03/31] tests/docker: make executable an optional argument to "update"

2021-05-12 Thread Alex Bennée
We're going to extend the abilities of the command shortly. Reviewed-by: Willian Rampazzo Signed-off-by: Alex Bennée --- v2 - fix indention issue --- tests/docker/Makefile.include | 2 +- tests/docker/docker.py| 56 ++- 2 files changed, 30 insertions(

[PATCH v3 13/31] hw/tricore: Add testdevice for tests in tests/tcg/

2021-05-12 Thread Alex Bennée
From: Bastian Koppelmann this device is used to verify the correctness of regression tests by allowing guests to write their exit status to this device. This is then used by qemu to exit using the written status. Reviewed-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Be

[PATCH v3 08/31] gitlab: add build-user-hexagon test

2021-05-12 Thread Alex Bennée
We special case this as the container with the cross compiler for the tests takes so long to build it is manually uploaded into the registry. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Willian Rampazzo Tested-by: Philipp

[PATCH v3 10/31] tests/docker: Added libbpf library to the docker files.

2021-05-12 Thread Alex Bennée
From: Andrew Melnychenko The series of patches for eBPF RSS adds libbpf dependency for qemu. https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg08887.html With this patch, libbpf added: Alpine - added libbpf-dev Centos 8 - added libbpf-devel Fedora - added libbpf-devel Signed-off-by

Re: [PATCH v4 2/2] ui/cocoa: add option to swap Option and Command

2021-05-12 Thread Gustavo Noronha Silva
Hey, On Wed, May 12, 2021, at 12:06 AM, Akihiko Odaki wrote: > Reviewed-by: Akihiko Odaki > > I applied them to my personal tree: > https://github.com/akihikodaki/qemu/tree/macos Thank you for the review! That top one I am still to submit here, by the way. Will do once this series is through.

[PATCH v3 07/31] tests/tcg: Use Hexagon Docker image

2021-05-12 Thread Alex Bennée
From: Alessandro Di Federico [PMD: Split from 'Add Hexagon Docker image' patch] Signed-off-by: Alessandro Di Federico Signed-off-by: Philippe Mathieu-Daudé [AJB: add container_hosts] Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id:

[PATCH v3 24/31] tests/tcg/tricore: Add msub test

2021-05-12 Thread Alex Bennée
From: Bastian Koppelmann Tested-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-15-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/Makefile.softmmu-target | 1 + tests/tcg/tricore/test_msub.S | 9 + 2 fi

[PATCH v3 06/31] docker: Add Hexagon image

2021-05-12 Thread Alex Bennée
From: Alessandro Di Federico This image is a little special because it takes a long time to build. As such most users don't want to be doing that and just pull random binaries from the ether as intended by the container gods. This involves someone with credentials and a beefy machine running:

Re: [PATCH] 9pfs: add link to 9p developer docs

2021-05-12 Thread Christian Schoenebeck
On Dienstag, 11. Mai 2021 21:57:53 CEST Connor Kuehl wrote: > On 5/6/21 8:12 AM, Christian Schoenebeck wrote: > > To lower the entry level for new developers, add a link to the > > 9p developer docs (i.e. qemu wiki) at the beginning of 9p source > > files, that is to: https://wiki.qemu.org/Document

[PATCH v3 12/31] tests/tcg: Run timeout cmds using --foreground

2021-05-12 Thread Alex Bennée
From: Bastian Koppelmann when trying to run successful short tests from the Makefile timeout would not terminate. Rather it would wait until the time runs out. Excerpt from the manpage: --foreground when not running timeout directly from a shell prompt, allow COMMAND to read from the TTY

[PATCH v3 31/31] configure: use cc, not host_cc to set cross_cc for build arch

2021-05-12 Thread Alex Bennée
Otherwise you run into hilarity like trying when cross compiling a 32 bit ARM build on a 64 bit system trying to use host_cc to build 32 bit test cases. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 22/31] tests/tcg/tricore: Add ftoi test

2021-05-12 Thread Alex Bennée
From: Bastian Koppelmann Tested-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-13-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/macros.h| 7 +++ tests/tcg/tricore/Makefile.softmmu-target | 1 + test

[PATCH v3 19/31] tests/tcg/tricore: Add dvstep test

2021-05-12 Thread Alex Bennée
From: Bastian Koppelmann Tested-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-10-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/macros.h| 29 ++- tests/tcg/tricore/Makefile.softmmu-tar

[PATCH v3 15/31] configure: Emit HOST_CC to config-host.mak

2021-05-12 Thread Alex Bennée
From: Bastian Koppelmann this is needed by the tricore-tcg-tests as tricore-gcc is not easily available. Thus we rely on the HOST_CC to do the preprocessing of the tricore assembly files. Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-6-kbast...

[PATCH v3 29/31] tests/tcg: fix missing return

2021-05-12 Thread Alex Bennée
This was picked up when clang built the test. Signed-off-by: Alex Bennée --- tests/tcg/multiarch/system/memory.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/tcg/multiarch/system/memory.c b/tests/tcg/multiarch/system/memory.c index eb0ec6f8eb..41c7f66e2e 100644 --- a/tests/tcg/mult

[PATCH v3 20/31] tests/tcg/tricore: Add fadd test

2021-05-12 Thread Alex Bennée
From: Bastian Koppelmann Tested-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-11-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/Makefile.softmmu-target | 1 + tests/tcg/tricore/test_fadd.S | 16 +

[PATCH v3 14/31] tests/tcg/tricore: Add build infrastructure

2021-05-12 Thread Alex Bennée
From: Bastian Koppelmann this includes the Makefile and linker script to build all the tests. Reviewed-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-5-kbast...@mail.uni-paderborn.de> --- MAINTAINERS

[PATCH v3 30/31] tests/tcg: don't allow clang as a cross compiler

2021-05-12 Thread Alex Bennée
Currently there are two problems. The first is clang generates a preamble (that is always executed) to stack xmm registers. This causes a ILLOP on the x86_64 softmmu tests as SSE isn't enabled. The second is the inline assembler in test-i386.c breaks clangs compiler and I don't know how to fix it

[PATCH v3 21/31] tests/tcg/tricore: Add fmul test

2021-05-12 Thread Alex Bennée
From: Bastian Koppelmann Tested-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-12-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/Makefile.softmmu-target | 1 + tests/tcg/tricore/test_fmul.S | 8 2 fil

[PATCH v3 11/31] tests/tcg: Add docker_as and docker_ld cmds

2021-05-12 Thread Alex Bennée
From: Bastian Koppelmann At least for the TriCore target no easily available c compiler exists. Thus we need to rely on "as" and "ld". This allows us to run them through the docker image. We don't test the generation capabilities of docker images as they are assumed to work. Reviewed-by: Philipp

[PATCH v3 28/31] cirrus.yml: Fix the MSYS2 task

2021-05-12 Thread Alex Bennée
From: Thomas Huth The MSYS2 task in the Cirrus-CI is currently failing with error messages like this: warning: database file for 'ucrt64' does not exist (use '-Sy' to download) :: Starting core system upgrade... there is nothing to do :: Starting full system upgrade... error: failed to pre

[PATCH v3 18/31] tests/tcg/tricore: Add clz test

2021-05-12 Thread Alex Bennée
From: Bastian Koppelmann Tested-by: Alex Bennée Signed-off-by: Bastian Koppelmann [AJB: dropped duplicate Makefile] Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-9-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/Makefile.softmmu-target | 1 + tests/tcg/tricore/test_clz.S

[PATCH v3 25/31] tests/tcg/tricore: Add muls test

2021-05-12 Thread Alex Bennée
From: Bastian Koppelmann Tested-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-16-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/Makefile.softmmu-target | 1 + tests/tcg/tricore/test_muls.S | 9 + 2 fi

[PATCH v3 17/31] tests/tcg/tricore: Add bmerge test

2021-05-12 Thread Alex Bennée
From: Bastian Koppelmann Tested-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-8-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/macros.h| 24 +++ tests/tcg/tricore/Makefile.softmmu-targ

[PATCH v3 26/31] tests/docker: gcc-10 based images for ppc64{, le} tests

2021-05-12 Thread Alex Bennée
From: Matheus Ferst A newer compiler is needed to build tests for Power10 instructions. As done for arm64 on c729a99d2701, a new '-test-cross' image is created for ppc64 and ppc64le. As done on 936fda4d771f, a test for compiler support is added to verify that the toolchain in use has '-mpower10'.

[PATCH v3 16/31] tests/tcg/tricore: Add macros to create tests and first test 'abs'

2021-05-12 Thread Alex Bennée
From: Bastian Koppelmann This kind of tests is inspired by the riscv-tests repository. This adds macros that makes it easy to create single instruction self containing tests. It is achieved by macros that create a test sequence for an instruction and check for a supplied correct value. If the va

[PATCH v3 27/31] tests/tcg/ppc64le: tests for brh/brw/brd

2021-05-12 Thread Alex Bennée
From: Matheus Ferst Tests for Byte-Reverse Halfword, Word and Doubleword Signed-off-by: Matheus Ferst Tested-by: Fabiano Rosas [AJB: tweak to make rules for skip/plugins] Signed-off-by: Alex Bennée Message-Id: <20210423205757.1752480-3-matheus.fe...@eldorado.org.br> --- tests/tcg/ppc64le/byt

[PATCH v3 23/31] tests/tcg/tricore: Add madd test

2021-05-12 Thread Alex Bennée
From: Bastian Koppelmann Tested-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-14-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/macros.h| 18 ++ tests/tcg/tricore/Makefile.softmmu-target |

Re: [PATCH v3 00/31] testing/next pre-PR (hexagon, tricore, misc)

2021-05-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210512102051.12134-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210512102051.12134-1-alex.ben...@linaro.org Subject: [PATCH v3 00/31] testing/next

Re: [PATCH] add Visual Studio Code configuration

2021-05-12 Thread Peter Maydell
On Wed, 12 May 2021 at 11:10, Paolo Bonzini wrote: > > Add configurations to build files with Visual Studio Code and > to retrieve the search path for headers from the compile_commands.json > file. > > Using this configuration requires installing the Meson extension and > using a build subdirector

Re: [PULL 0/3] xen queue 2021-05-10

2021-05-12 Thread Peter Maydell
On Mon, 10 May 2021 at 13:53, Anthony PERARD wrote: > > The following changes since commit 4cc10cae64c51e17844dc4358481c393d7bf1ed4: > > Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' > into staging (2021-05-06 18:56:17 +0100) > > are available in the Git repository at:

Re: [PATCH] add Visual Studio Code configuration

2021-05-12 Thread Philippe Mathieu-Daudé
Hi Paolo, On 5/12/21 12:09 PM, Paolo Bonzini wrote: > Add configurations to build files with Visual Studio Code and > to retrieve the search path for headers from the compile_commands.json > file. > > Using this configuration requires installing the Meson extension maybe add "(@id:asabil.meson)"

[Bug 1885332] Re: Error in user-mode calculation of ELF aux vector's AT_PHDR

2021-05-12 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/275 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1888818] Re: Multi-queue vhost-user fails to reconnect with qemu version >=4.2

2021-05-12 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/277 ** Changed in: qemu Status: New => Expired ** Bug watch

Re: [PATCH 25/72] softfloat: Rearrange FloatParts64

2021-05-12 Thread Alex Bennée
Richard Henderson writes: > On 5/11/21 8:57 AM, Alex Bennée wrote: >>> +union { >>> +/* Routines that know the structure may reference the singular >>> name. */ >>> +uint64_t frac; >>> +/* >>> + * Routines expanded with multiple structures reference "hi" and

[Bug 1883733] Re: FIXME xhci_alloc_device_streams:972 guest streams config not identical for all eps

2021-05-12 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/274 ** Tags added: usb ** Changed in: qemu Status: New => E

[Bug 1886097] Re: Error in user-mode calculation of ELF program's brk

2021-05-12 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/276 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1883729] Re: xhci_find_stream: Assertion `streamid != 0' failed.

2021-05-12 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/273 ** Changed in: qemu Status: Confirmed => Expired ** Bug

Re: [PATCH] linux-user: Add strace support for printing arguments of llseek

2021-05-12 Thread Laurent Vivier
Le 12/05/2021 à 12:13, Kito Cheng a écrit : > Some target are using llseek instead of _llseek like riscv, > nios2, hexagon, and openrisc. > > Signed-off-by: Kito Cheng > --- > linux-user/strace.c| 3 ++- > linux-user/strace.list | 3 +++ > 2 files changed, 5 insertions(+), 1 deletion(-) > >

Re: [PATCH v3 29/31] tests/tcg: fix missing return

2021-05-12 Thread Philippe Mathieu-Daudé
On 5/12/21 12:20 PM, Alex Bennée wrote: > This was picked up when clang built the test. > > Signed-off-by: Alex Bennée > --- > tests/tcg/multiarch/system/memory.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé

[Bug 1910586] Re: SD card size constraint conceptually wrong

2021-05-12 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1911188] Re: qemu-system-x86_64 prints obscure error message and exits when encountering an empty argument

2021-05-12 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1910605] Re: qemu-arm-static ioctl USBDEVFS_BULK return -1 (EFAULT) Bad address

2021-05-12 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

Re: [PATCH] Constify bitmask_transtbl fcntl/mmap flags_tlb[]

2021-05-12 Thread Laurent Vivier
Le 11/05/2021 à 12:35, Philippe Mathieu-Daudé a écrit : > Keep bitmask_transtbl in .rodata by marking the arrays const. > > Signed-off-by: Philippe Mathieu-Daudé > --- > linux-user/syscall.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/linux-user/syscall.c b/linu

[Bug 1911216] Re: abort issue locates in hw/usb/hcd-ohci.c:1297:ohci_frame_boundary

2021-05-12 Thread Thomas Huth
Hi! Can you still reproduce this issue with QEMU v6.0 ? At least Alexander's reproducer does not seem to trigger this issue anymore... ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEM

Re: [PATCH 03/72] qemu/host-utils: Add wrappers for carry builtins

2021-05-12 Thread Alex Bennée
Richard Henderson writes: > On 5/10/21 7:57 AM, Alex Bennée wrote: >> Richard Henderson writes: >> >>> These builtins came in clang 3.8, but are not present in gcc through >>> version 11. Even in clang the optimization is not ideal except for >>> x86_64, but no worse than the hand-coding tha

Re: [PATCH 00/72] Convert floatx80 and float128 to FloatParts

2021-05-12 Thread Alex Bennée
Richard Henderson writes: > On 5/10/21 8:36 AM, Alex Bennée wrote: >> Richard Henderson writes: >> >>> Reorg everything using QEMU_GENERIC and multiple inclusion to >>> reduce the amount of code duplication between the formats. >>> >>> The use of QEMU_GENERIC means that we need to use pointer

[Bug 1911351] Re: x86-64 MTTCG Does not update page table entries atomically

2021-05-12 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1908626] Re: Atomic test-and-set instruction does not work on qemu-user

2021-05-12 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1912107] Re: Option to constrain linux-user exec() to emulated CPU only

2021-05-12 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1908781] Re: x86-64 not faulting when CS.L = 1 and CS.D = 1

2021-05-12 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1909823] Re: RDPMC check on PCE is backwards

2021-05-12 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1908832] Re: jack audio dev produces no sound

2021-05-12 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1909921] Re: Raspberry Pi 4 qemu:handle_cpu_signal received signal outside vCPU context @ pc=0xffff87709b0e

2021-05-12 Thread Thomas Huth
Sorry, apparently nobody got a clue what might have gone wrong here (or simply not enough spare time to look at this issue), but since it's working for you now with a different distro, I'm closing this ticket now. ** Changed in: qemu Status: New => Won't Fix -- You received this bug notif

Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2

2021-05-12 Thread Philippe Mathieu-Daudé
On 5/11/21 3:26 PM, Daniel P. Berrangé wrote: > Several distros have been dropped since the last time we bumped the > minimum required CLang version. > > Per repology, currently shipping versions are: > > RHEL-8: 10.0.1 > Debian Stretch: 7.0.1 > Debian Buster: 7.0.1 > ope

[Bug 1525123] Re: USB assert failure on hcd-uhci.c

2021-05-12 Thread Thomas Huth
** Tags added: fuzzer usb -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1525123 Title: USB assert failure on hcd-uhci.c Status in QEMU: Expired Bug description: When inserting the attached ke

[Bug 1907909] Re: assertion failure in am53c974

2021-05-12 Thread Thomas Huth
Can you still reproduce the issue with QEMU v6.0? For me, the attached reproducer does not cause a crash anymore... ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.lau

Re: [PULL 8/9] pc-bios/s390-ccw: Allow building with Clang, too

2021-05-12 Thread Philippe Mathieu-Daudé
On 5/10/21 9:35 AM, Thomas Huth wrote: > Clang unfortunately does not support generating code for the z900 > architecture level and starts with the z10 instead. Thus to be able > to support compiling with Clang, we have to check for the supported > compiler flags. The disadvantage is of course that

  1   2   3   4   5   >