Hi Alex,
On 4/19/21 5:11 PM, Alex Bennée wrote:
>
> Philippe Mathieu-Daudé writes:
>
>> Extract the build/test jobs run by default on the mainstream
>> CI into a new file (buildtest.yml) and their templates into
>> (buildtest-template.yml), to be able to reuse the templates
>> without having to
Hi,
Gitlab recommends to use job templates. To be able to re-use /
include templates, they can not use YAML anchors. All current jobs
has first to be converted to use the 'extends' keyworkd.
This is the first part of this series (already reviewed).
The second part extracts various generic jobs (w
From: Philippe Mathieu-Daudé
'extends' is an alternative to using YAML anchors
and is a little more flexible and readable. See:
https://docs.gitlab.com/ee/ci/yaml/#extends
Reviewed-by: Wainer dos Santos Moschetta
Signed-off-by: Philippe Mathieu-Daudé
---
.gitlab-ci.yml | 30 +++---
From: Philippe Mathieu-Daudé
The acceptance tests aren't accepting anything,
rename them as integration tests.
Reviewed-by: Wainer dos Santos Moschetta
Reviewed-by: Willian Rampazzo
Acked-by: Thomas Huth
Signed-off-by: Philippe Mathieu-Daudé
---
.gitlab-ci.yml | 20 ++--
1 f
Extract the DCO / checkpatch jobs to a new file (static_checks.yml)
to be able to run them without having to run all the jobs included
in the default .gitlab-ci.yml, which are mainly useful for the
mainstream CI.
Signed-off-by: Philippe Mathieu-Daudé
---
v2:
- renamed static_checks.yml (Wainer)
-
Extract the container job template to a new file
(container-template.yml) to be able to reuse it
without having to run all the jobs included, which
are mainly useful for mainstream CI.
Signed-off-by: Philippe Mathieu-Daudé
---
.gitlab-ci.d/container-template.yml | 22 ++
.git
Extract the build/test jobs run by default on the mainstream
CI into a new file (buildtest.yml).
Signed-off-by: Philippe Mathieu-Daudé
---
.gitlab-ci.d/buildtest.yml | 726 +
.gitlab-ci.yml | 726 +
2 files chang
To allow forks to easily decide which jobs they want to run,
but without disrupting the current default, move the current
set of jobs to a new file corresponding to the jobs run by
the mainstream project CI:
https://gitlab.com/qemu-project/qemu/-/pipelines
Signed-off-by: Philippe Mathieu-Daudé
--
Extract the crossbuild job templates to a new file
(crossbuild-template.yml) to be able to reuse them
without having to run all the jobs included, which
are mainly useful for mainstream CI.
Signed-off-by: Philippe Mathieu-Daudé
---
.gitlab-ci.d/crossbuild-template.yml | 41 ++
Cc'ing qemu-trivial@
On 4/30/21 3:48 PM, Connor Kuehl wrote:
> Connor Kuehl (2):
> sev: use explicit indices for mapping firmware error codes to strings
> sev: add missing firmware error conditions
>
> target/i386/sev.c | 48 ---
> 1 file changed,
Ever since commit e570768566 ("hw/block/nvme: support for shared
namespace in subsystem") NVMe PCI hotplug is broken, as the PCI
hotplug infrastructure will only work for the nvme devices (which
are PCI devices), but not for any attached namespaces.
So when re-adding the NVMe PCI device via 'device
Extract the build stages used by our job templates to a new file
(stages.yml) to be able to include it with the other templates,
without having to run all the jobs included in the default
.gitlab-ci.yml, which are mainly useful for mainstream CI.
Signed-off-by: Philippe Mathieu-Daudé
---
.gitlab
On Wed, 5 May 2021 at 14:09, Gerd Hoffmann wrote:
>
> The following changes since commit 15106f7dc3290ff3254611f265849a314a93eb0e:
>
> Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-hex-20210502'
> into staging (2021-05-02 16:23:05 +0100)
>
> are available in the Git repository at:
On 5/3/21 9:27 AM, Klaus Jensen wrote:
> On Apr 28 15:00, Max Reitz wrote:
>> On 28.04.21 12:12, Klaus Jensen wrote:
>>> On Apr 28 09:31, Oguz Bektas wrote:
> My understanding is that this is the expected behavior. The reason is
> that the drive cannot be deleted immediately when the device
To be able to reuse the mainstream build/test jobs templates,
extract them into a new file (buildtest-template.yml).
Signed-off-by: Philippe Mathieu-Daudé
---
.gitlab-ci.d/buildtest-template.yml | 69
.gitlab-ci.yml | 71 +
On Tue, 11 May 2021 at 06:59, Vladimir Sementsov-Ogievskiy
wrote:
>
> Hi!
>
> Kindly ping, or what's wrong with it?
You've never sent me a pullreq before. Pull requests from new
people are a pain and take more time to deal with, so I only
look at them when I have the time to do that. Pull request
It is not possible to use the previously extracted templates
without this set of core containers. Extract them into a new
file (container-core.yml) to be able to build them without
having to build all the other containers by default.
Reviewed-by: Thomas Huth
Signed-off-by: Philippe Mathieu-Daudé
On Mon, Mar 22, 2021 at 5:43 PM Eduardo Habkost wrote:
> On Mon, Mar 22, 2021 at 09:09:44AM -0500, Connor Kuehl wrote:
> > On 3/22/21 5:18 AM, Philippe Mathieu-Daudé wrote:
> > > On 3/15/21 3:08 PM, Connor Kuehl wrote:
> > > > On 2/18/21 9:16 AM, Connor Kuehl wrote:
> > > > > Connor Kuehl (2):
> >
Patchew URL: https://patchew.org/QEMU/20210511073511.32511-1-h...@suse.de/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210511073511.32511-1-h...@suse.de
Subject: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug
=
On Fri, 30 Apr 2021 at 21:26, Richard Henderson
wrote:
>
> Will be used for SVE2 isa subset enablement.
>
> Reviewed-by: Alex Bennée
> Signed-off-by: Richard Henderson
> ---
> v2: Do not read zfr0 from kvm unless sve is available.
> ---
> diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c
>
On Fri, 30 Apr 2021 at 21:29, Richard Henderson
wrote:
>
> For MUL, we can rely on generic support. For SMULH and UMULH,
> create some trivial helpers. For PMUL, back in a21bb78e5817,
> we organized helper_gvec_pmul_b in preparation for this use.
>
> Signed-off-by: Richard Henderson
> ---
> ta
On Fri, 30 Apr 2021 at 21:26, Richard Henderson
wrote:
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/helper-sve.h| 14
> target/arm/sve.decode | 5 +
> target/arm/sve_helper.c| 44 ++
> target/arm/translate-sve.c | 39 +
Cc'ing Klaus (maintainer)
On 5/11/21 9:35 AM, Hannes Reinecke wrote:
> Ever since commit e570768566 ("hw/block/nvme: support for shared
> namespace in subsystem") NVMe PCI hotplug is broken, as the PCI
> hotplug infrastructure will only work for the nvme devices (which
> are PCI devices), but not
The QEMU project is currently moving its bug tracking to another system.
For this we need to know which bugs are still valid and which could be
closed already. Thus we are setting the bug state to "Incomplete" now.
If the bug has already been fixed in the latest upstream version of QEMU,
then plea
The QEMU project is currently moving its bug tracking to another system.
For this we need to know which bugs are still valid and which could be
closed already. Thus we are setting the bug state to "Incomplete" now.
If the bug has already been fixed in the latest upstream version of QEMU,
then plea
The following changes since commit e58c7a3bba3076890592f02d2b0e596bf191b5c2:
Merge remote-tracking branch
'remotes/pmaydell/tags/pull-target-arm-20210510-1' into staging (2021-05-10
17:28:11 +0100)
are available in the Git repository at:
https://gitlab.com/bonzini/qemu.git tags/for-upstrea
From: Claudio Fontana
move the call to accel_cpu->cpu_realizefn to the general
cpu_exec_realizefn from target/i386, so it does not need to be
called for every target explicitly as we enable more targets.
Signed-off-by: Claudio Fontana
Reviewed-by: Alex Bennée
Reviewed-by: Richard Henderson
Me
From: Richard Henderson
The helper_* functions must use GETPC() to unwind from TCG.
The cpu_x86_* functions cannot, and directly calling the
helper_* functions is a bug. Split out new functions that
perform the work and can be used by both.
Signed-off-by: Richard Henderson
Reviewed-by: Philipp
On Fri, 30 Apr 2021 at 21:30, Richard Henderson
wrote:
>
> Signed-off-by: Richard Henderson
> ---
> v2: Fix sqabs, sqneg (laurent desnogues)
> ---
> target/arm/helper-sve.h| 13 +++
> target/arm/sve.decode | 7 ++
> target/arm/sve_helper.c| 29 +++
>
From: Richard Henderson
Change the prefix from "helper" to "do". The former should be
reserved for those functions that are called from TCG; the latter
is in use within the file already for those functions that are
called from the helper functions, adding a "retaddr" argument.
Signed-off-by: Ri
From: Claudio Fontana
move the check for phys_bits outside of host_cpu_adjust_phys_bits,
because otherwise it is impossible to return an error condition
explicitly.
Signed-off-by: Claudio Fontana
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
Reviewed-by: Richard Henderson
Mess
Signed-off-by: Claudio Fontana
Reviewed-by: Richard Henderson
Message-Id: <20210322132800.7470-11-cfont...@suse.de>
Signed-off-by: Paolo Bonzini
---
target/i386/meson.build| 2 +
target/i386/tcg/meson.build| 3 ++
target/i386/tcg/sysemu/meson.build | 3 ++
target/i386/tcg
From: Claudio Fontana
overall, all devices' realize functions take an Error **errp, but return void.
hw/core/qdev.c code, which realizes devices, therefore does:
local_err = NULL;
dc->realize(dev, &local_err);
if (local_err != NULL) {
goto fail;
}
However, we can improve at least accel_cpu
From: Claudio Fontana
smm is only really useful for sysemu, split in two modules
around the CONFIG_USER_ONLY, in order to remove the ifdef
and use the build system instead.
add cpu_abort() when detecting attempts to enter SMM mode via
SMI interrupt in user-mode, and assert that the cpu is not
in
From: Claudio Fontana
i386 is the first user of AccelCPUClass, allowing to split
cpu.c into:
cpu.ccpuid and common x86 cpu functionality
host-cpu.c host x86 cpu functions and "host" cpu type
kvm/kvm-cpu.cKVM x86 AccelCPUClass
hvf/hvf-cpu.cHVF x86 AccelCPUClass
tcg/tcg-c
From: Claudio Fontana
avoid open coding the accesses to cpu->accel_cpu interfaces,
and instead introduce:
accel_cpu_instance_init,
accel_cpu_realizefn
to be used by the targets/ initfn code,
and by cpu_exec_realizefn respectively.
Signed-off-by: Claudio Fontana
Reviewed-by: Alex Bennée
Revie
From: Claudio Fontana
For now we just copy over the previous user stubs, but really,
everything that requires s->cpl == 0 should be impossible
to trigger from user-mode emulation.
Later on we should add a check that asserts this easily f.e.:
static bool check_cpl0(DisasContext *s)
{
int c
From: Claudio Fontana
Signed-off-by: Claudio Fontana
Reviewed-by: Richard Henderson
[claudio]:
Rebased on commit b8184135 ("target/i386: allow modifying TCG phys-addr-bits")
Signed-off-by: Claudio Fontana
Message-Id: <20210322132800.7470-13-cfont...@suse.de>
Signed-off-by: Paolo Bonzini
---
From: Claudio Fontana
a number of registers are read as 64bit under the condition that
(hflags & HF_CS64_MASK) || TARGET_X86_64)
and a number of registers are written as 64bit under the condition that
(hflags & HF_CS64_MASK).
Provide some auxiliary functions that do that.
Signed-off-by: Claudi
From: Claudio Fontana
cpu_load_efer is now used only for sysemu code.
Therefore, move this function implementation to
sysemu-only section of helper.c
Signed-off-by: Claudio Fontana
Reviewed-by: Richard Henderson
Message-Id: <20210322132800.7470-22-cfont...@suse.de>
Signed-off-by: Paolo Bonzin
From: Claudio Fontana
for user-mode, assert that the hidden IOBPT flags are not set
while attempting to generate io_bpt helpers.
Signed-off-by: Claudio Fontana
Cc: Paolo Bonzini
Reviewed-by: Richard Henderson
Message-Id: <20210322132800.7470-14-cfont...@suse.de>
Signed-off-by: Paolo Bonzini
Unify the duplicate code between get_hphys and mmu_translate, by simply
making get_hphys call mmu_translate. This also fixes the support for
5-level nested page tables.
Signed-off-by: Paolo Bonzini
---
target/i386/tcg/sysemu/excp_helper.c | 243 ---
1 file changed, 36 in
From: Claudio Fontana
Signed-off-by: Claudio Fontana
Cc: Paolo Bonzini
Reviewed-by: Richard Henderson
Message-Id: <20210322132800.7470-21-cfont...@suse.de>
Signed-off-by: Paolo Bonzini
---
target/i386/gdbstub.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/target/i386/gdbst
From: Claudio Fontana
Signed-off-by: Claudio Fontana
Reviewed-by: Richard Henderson
[claudio]:
Rebased on commit 68775856 ("target/i386: svm: do not discard high 32 bits")
Signed-off-by: Claudio Fontana
Message-Id: <20210322132800.7470-18-cfont...@suse.de>
Signed-off-by: Paolo Bonzini
---
From: Claudio Fontana
Signed-off-by: Claudio Fontana
Reviewed-by: Richard Henderson
[claudio]:
Rebased on da3f3b02("target/i386: fail if toggling LA57 in 64-bitmode")
Signed-off-by: Claudio Fontana
Message-Id: <20210322132800.7470-15-cfont...@suse.de>
Signed-off-by: Paolo Bonzini
---
targe
From: Claudio Fontana
create a separate tcg/sysemu/fpu_helper.c for the sysemu-only parts.
For user mode, some small #ifdefs remain in tcg/fpu_helper.c
which do not seem worth splitting into their own user-mode module.
Signed-off-by: Claudio Fontana
Reviewed-by: Richard Henderson
Message-Id:
From: Claudio Fontana
move the call for sysemu specifically in machine_run_board_init,
mirror the calling sequence for user mode too.
Suggested-by: Paolo Bonzini
Signed-off-by: Claudio Fontana
Message-Id: <20210322132800.7470-23-cfont...@suse.de>
Signed-off-by: Paolo Bonzini
---
bsd-user/mai
Signed-off-by: Paolo Bonzini
---
target/i386/tcg/sysemu/excp_helper.c | 30 +---
1 file changed, 18 insertions(+), 12 deletions(-)
diff --git a/target/i386/tcg/sysemu/excp_helper.c
b/target/i386/tcg/sysemu/excp_helper.c
index 2b7baa0193..082ddbb911 100644
--- a/target/i3
From: Claudio Fontana
Signed-off-by: Claudio Fontana
Reviewed-by: Richard Henderson
Message-Id: <20210322132800.7470-19-cfont...@suse.de>
Signed-off-by: Paolo Bonzini
---
target/i386/cpu-internal.h | 70 +++
target/i386/cpu-sysemu.c | 352 +
target/i386/
We will reuse the page walker for both SVM and regular accesses. To do
so we will build a function that receives the currently active paging
mode; start by including in cpu.h the constants and the function to go
from cr4/hflags/efer to the paging mode.
Signed-off-by: Paolo Bonzini
---
target/i3
They are the same value, and are so by design.
Signed-off-by: Paolo Bonzini
---
target/i386/svm.h| 5 -
target/i386/tcg/sysemu/excp_helper.c | 10 +-
2 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/target/i386/svm.h b/target/i386/svm.h
index ae30f
First step in unifying the nested and regular page table walk.
Signed-off-by: Paolo Bonzini
---
target/i386/tcg/sysemu/excp_helper.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/target/i386/tcg/sysemu/excp_helper.c
b/target/i386/tcg/sysemu/excp_helper.c
index
Extract the page table lookup out of handle_mmu_fault, which only has
to invoke mmu_translate and either fill the TLB or deliver the page
fault.
Signed-off-by: Paolo Bonzini
---
target/i386/tcg/sysemu/excp_helper.c | 151 +++
1 file changed, 86 insertions(+), 65 deletions
"pkg-config --variable=gdbus_codegen gio-2.0" returns "gdbus-codegen",
and it does not pass test -x (which does not walk the path).
Meson 0.58.0 notices that something is iffy, as the dbus_vmstate1
assignment in tests/qtest/meson.build uses an empty string as the
command, and fails very eloquently
Signed-off-by: Paolo Bonzini
---
util/qemu-option.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/util/qemu-option.c b/util/qemu-option.c
index 9678d5b682..4944015a25 100644
--- a/util/qemu-option.c
+++ b/util/qemu-option.c
@@ -1056,7 +1056,8 @@ bool qemu_opts_absorb_qdict
From: Claudio Fontana
while on x86 all CPU classes can use the same set of TCGCPUOps,
on ARM the right accel behavior depends on the type of the CPU.
So we need a way to specialize the accel behavior according to
the CPU. Therefore, add a second initialization, after the
accel_cpu->cpu_class_ini
In order to unify the two stages of page table lookup, we need
mmu_translate to use either the host CR0/EFER/CR4 or the guest's.
To do so, make mmu_translate use the same pg_mode constants that
were used for the NPT lookup.
This also prepares for adding 5-level NPT support, which however does
not
Place all files that can be useful to rebuild the Coverity
configuration in scripts/coverity-scan: the existing model
file, and the components setup.
The Markdown syntax was tested with Pandoc (but in any case
is meant more as a human-readable reference than as a part
of documentation).
Suggested
qemu_add_child_watch is not called anywhere since commit 2bdb920ece
("slirp: simplify fork_exec()", 2019-01-14), remove it.
Signed-off-by: Paolo Bonzini
---
include/qemu/main-loop.h | 18
util/main-loop.c | 61
2 files changed, 79 del
The HMP loadvm code is calling load_snapshot rather than
qmp_snapshot_load, in order to bypass the job infrastructure. The code
around it is almost the same, with one difference: hmp_loadvm is
restarting the VM if load_snapshot fails, qmp_snapshot_load is doing so
if load_snapshot succeeds.
Fix t
This adds udmabuf header to standard headers so that the
relevant udmabuf objects can be accessed in subsequent
patches.
Based-on-patch-by: Gerd Hoffmann
Cc: Gerd Hoffmann
Signed-off-by: Vivek Kasireddy
---
include/standard-headers/linux/udmabuf.h | 32
scripts/update-
Instead of passing the attach_backing object to extract nr_entries
and offset, explicitly pass these as arguments to this function.
This will be helpful when adding create_blob API.
Cc: Gerd Hoffmann
Signed-off-by: Vivek Kasireddy
---
hw/display/virtio-gpu-virgl.c | 3 ++-
hw/display/virtio-g
Add helper functions to create a dmabuf for a resource and mmap it.
To be able to create a dmabuf using the udmabuf driver, Qemu needs
to be lauched with the memfd memory backend like this:
qemu-system-x86_64 -m 8192m -object memory-backend-memfd,id=mem1,size=8192M
-machine memory-backend=mem1
Ba
This API allows Qemu to set the blob allocated by the Guest as
the scanout buffer. If Opengl support is available, then the
scanout buffer would be submitted as a dmabuf to the UI; if not,
a pixman image is created from the scanout buffer and is
submitted to the UI via the display surface.
Based-o
Move finding the resource and validating its backing storage into one
function.
Based-on-patch-by: Gerd Hoffmann
Cc: Gerd Hoffmann
Signed-off-by: Vivek Kasireddy
---
hw/display/virtio-gpu.c | 66 +
1 file changed, 47 insertions(+), 19 deletions(-)
diff
These helpers can be useful for creating dmabuf objects from blobs
and submitting them to the UI.
Cc: Gerd Hoffmann
Signed-off-by: Vivek Kasireddy
---
hw/display/virtio-gpu-udmabuf.c | 74 +
include/hw/virtio/virtio-gpu.h | 15 +++
2 files changed, 89 insert
On 10.05.21 20:58, Dr. David Alan Gilbert wrote:
* David Hildenbrand (da...@redhat.com) wrote:
The bulk stage is kind of weird: migration_bitmap_find_dirty() will
indicate a dirty page, however, ram_save_host_page() will never save it, as
migration_bitmap_clear_dirty() detects that it is not dir
If a blob is available for the cursor, copy the data from the blob.
Based-on-patch-by: Gerd Hoffmann
Cc: Gerd Hoffmann
Signed-off-by: Vivek Kasireddy
---
hw/display/virtio-gpu.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/hw/display/virtio-gpu.c b/h
Enabling this feature would eliminate data copies from the resource
object in the Guest to the shadow resource in Qemu. This patch series
however adds support only for Blobs of type
VIRTIO_GPU_BLOB_MEM_GUEST with property VIRTIO_GPU_BLOB_FLAG_USE_SHAREABLE.
Most of the patches in this series are a
Creating a small helper function for updating the scanout
will be useful in the next patch where this needs to be
done early in do_set_scanout before returning.
Cc: Gerd Hoffmann
Signed-off-by: Vivek Kasireddy
---
hw/display/virtio-gpu.c | 35 +++
1 file changed,
On Mon, Mar 22, 2021 at 09:23:24AM +, Stefan Hajnoczi wrote:
> These patches add a qtest for the vhost-user-blk server. CI found several
> issues that caused these patches to be dropped from Michael Tsirkin and Kevin
> Wolf's pull requests in the past. Hopefully they will go in smoothly this
>
These helpers will be used in the next subsequent patches to
wait until a dmabuf object (via a texture) has been used
by the UI to render and submit its buffer.
Cc: Gerd Hoffmann
Signed-off-by: Vivek Kasireddy
---
hw/display/virtio-gpu-udmabuf.c | 42 +
include/h
This new command can be used by the Guest Compositor as a way to
synchronize its updates (repaint/redraw) with Host UI buffer
submissions (redraw). In other words, the Guest can wait until
the buffer it has submitted has been used by the Host before it
starts it new repaint cycle.
Cc: Gerd Hoffman
Add the property bit, configuration flag and other relevant
macros and definitions associated with this feature.
Based-on-patch-by: Gerd Hoffmann
Cc: Gerd Hoffmann
Signed-off-by: Vivek Kasireddy
---
hw/display/virtio-gpu-base.c | 3 +++
hw/display/virtio-gpu.c| 14 ++
in
On Wed, Mar 31, 2021 at 03:27:27PM +0100, Stefan Hajnoczi wrote:
> The checks in vu_blk_sect_range_ok() assume VIRTIO_BLK_SECTOR_SIZE is
> equal to BDRV_SECTOR_SIZE. This is true, but let's add a
> QEMU_BUILD_BUG_ON() to make it explicit.
>
> We might as well check that the request buffer size is
Instead of immediately drawing and submitting, queue and wait
for the draw signal if the dmabuf submitted is a blob.
Cc: Gerd Hoffmann
Signed-off-by: Vivek Kasireddy
---
include/ui/gtk.h | 2 ++
ui/gtk-egl.c | 14 ++
ui/gtk.c | 2 +-
3 files changed, 17 insertions(+),
On Mon, Feb 22, 2021 at 04:10:14PM +, Stefan Hajnoczi wrote:
> vhost-user requires -object memory-backend-*,share=on option so that QEMU uses
> mmap(MAP_SHARED) on guest RAM that is shared with the vhost-user device
> backend
> process. This is needed so the QEMU process sees changes made by t
Try to open the udmabuf dev node for the first time or return the
fd if the device was previously opened.
Based-on-patch-by: Gerd Hoffmann
Cc: Gerd Hoffmann
Signed-off-by: Vivek Kasireddy
---
include/ui/console.h | 3 +++
ui/meson.build | 1 +
ui/udmabuf.c | 40
Adding this callback provides a way to determine when the UI
has submitted the buffer to the Host windowing system. Making
the guest wait for this event will ensure that the dmabuf/buffer
updates are synchronized.
Cc: Gerd Hoffmann
Signed-off-by: Vivek Kasireddy
---
hw/display/virtio-gpu.c
Store the meta-data associated with a FB in a new object
(struct virtio_gpu_framebuffer) and pass the object to set_scanout.
Also move code in set_scanout into a do_set_scanout function.
This will be helpful when adding set_scanout_blob API.
Based-on-patch-by: Gerd Hoffmann
Cc: Gerd Hoffmann
Sig
On 10/05/21 13:40, Vladimir Sementsov-Ogievskiy wrote:
co-shared-resource is currently not thread-safe, as also reported
in co-shared-resource.h. Add a QemuMutex because co_try_get_from_shres
can also be invoked from non-coroutine context.
But it doesn't. It's called only from co_get_from_shr
Since the texture release mechanism is same for both gtk-egl
and gtk-glarea, move the helper from gtk-egl into common gtk
area so that it can be shared by both gtk backends.
Cc: Gerd Hoffmann
Signed-off-by: Vivek Kasireddy
---
include/ui/gtk.h | 2 --
ui/gtk-egl.c | 8
ui/gtk.c
On Tue, Mar 16, 2021 at 08:35:14AM -0500, Eric Blake wrote:
> On 3/16/21 4:10 AM, Stefan Hajnoczi wrote:
> > On Wed, Mar 10, 2021 at 05:30:04PM +, Stefan Hajnoczi wrote:
> >> socket_get_fd() fails with the error "socket_get_fd: too many
> >> connections" if the given listen backlog value is not
This API allows Qemu to register the blob allocated by the Guest
as a new resource and map its backing storage.
Based-on-patch-by: Gerd Hoffmann
Cc: Gerd Hoffmann
Signed-off-by: Vivek Kasireddy
---
hw/display/trace-events | 1 +
hw/display/virtio-gpu-udmabuf.c | 4 ++
hw/di
On Tue, May 11, 2021 at 01:55:18PM +0800, Li Zhijian wrote:
> Image below user cases:
> case 1:
> ```
> $ qemu-img create -f raw source.raw 1G
> $ qemu-img create -f qcow2 -F raw -b source.raw ./source.raw
> qemu-img info source.raw
> image: source.raw
> file format: qcow2
> virtual size: 193K (197
This new function to get the drm_format associated with a pixman
format will be useful while creating a dmabuf.
Based-on-patch-by: Gerd Hoffmann
Cc: Gerd Hoffmann
Signed-off-by: Vivek Kasireddy
---
include/ui/qemu-pixman.h | 1 +
ui/qemu-pixman.c | 35 -
> > +/* -- */
> > +/* send messages */
> > +
> > +static void vdagent_send_buf(VDAgentChardev *vd, void *ptr, uint32_t
> > msgsize)
> > +{
> > +uint8_t *msgbuf = ptr;
> > +ui
On Thu, May 06, 2021 at 09:33:41PM +0200, Laurent Vivier wrote:
> Add "lsvirtio" that lists all virtio devices in a system
> the same way lspci does for the PCI cards.
>
> For instance:
>
> $ ./lsvirtio
> :01:00.0 virtio0 Red Hat, Inc. (PCI) Virtio Network Card
>Subsystem: virtio
>
Add the property bit, conf flag and other relevant declarations
associated with this feature.
Cc: Gerd Hoffmann
Signed-off-by: Vivek Kasireddy
---
hw/display/virtio-gpu-base.c| 3 +++
hw/display/virtio-gpu.c | 9 +
include/hw/virtio/virtio-gpu.h
On 10/05/21 13:56, Vladimir Sementsov-Ogievskiy wrote:
+ }
- if (task->ret < 0 && pool->status == 0) {
- pool->status = task->ret;
+ if (ret < 0) {
+ qatomic_cmpxchg(&pool->status, 0, ret);
}
Can we just do it inside critical section above and avoid extra cmpxchg?
On 11/05/2021 10:37, Paolo Bonzini wrote:
On 07/05/21 17:29, Eric Blake wrote:
+ qemu_mutex_lock(&s->lock);
QLIST_FOREACH(r, &s->suspended_reqs, next) {
if (!strcmp(r->tag, tag)) {
+ qemu_mutex_unlock(&s->lock);
return true;
}
}
+
On Fri, May 07, 2021 at 08:17:33AM +0200, Laurent Vivier wrote:
> On 06/05/2021 21:50, Philippe Mathieu-Daudé wrote:
> > On 5/6/21 9:33 PM, Laurent Vivier wrote:
> >> Add "lsvirtio" that lists all virtio devices in a system
> >> the same way lspci does for the PCI cards.
> >>
> >> For instance:
> >
These egl helpers will be useful for creating a sync object
and waiting on it when called from the virtio-gpu wait_flush
API.
Cc: Gerd Hoffmann
Signed-off-by: Vivek Kasireddy
---
include/ui/console.h | 2 ++
include/ui/egl-helpers.h | 4
ui/egl-helpers.c | 44
On 07/05/21 17:29, Eric Blake wrote:
+qemu_mutex_lock(&s->lock);
QLIST_FOREACH(r, &s->suspended_reqs, next) {
if (!strcmp(r->tag, tag)) {
+qemu_mutex_unlock(&s->lock);
return true;
}
}
+qemu_mutex_unlock(&s->lock);
return fal
On Fri, 30 Apr 2021 at 21:30, Richard Henderson
wrote:
>
> Split these operations out into a header that can be shared
> between neon and sve. The "sat" pointer acts both as a boolean
> for control of saturating behavior and controls the difference
> in behavior between neon and sve -- QC bit or
On Thu, 6 May 2021 at 00:23, Alistair Francis wrote:
>
> The following changes since commit d45a5270d075ea589f0b0ddcf963a5fea1f500ac:
>
> Merge remote-tracking branch
> 'remotes/vivier2/tags/trivial-branch-for-6.1-pull-request' into staging
> (2021-05-05 13:52:00 +0100)
>
> are available in th
On Tue, May 11, 2021 at 04:13:47AM -0400, Paolo Bonzini wrote:
> The HMP loadvm code is calling load_snapshot rather than
> qmp_snapshot_load, in order to bypass the job infrastructure. The code
> around it is almost the same, with one difference: hmp_loadvm is
> restarting the VM if load_snapshot
Fixed in commit 69958d8a3d9
("usb: hcd-dwc2: change assert()s to qemu_log_mask(LOG_GUEST_ERROR...)")
** Changed in: qemu
Status: Incomplete => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad
This patch fixes calculation of number of the instructions
that fit the current page. It prevents creation of the translation
blocks that cross the page boundaries. It is required for deterministic
exception generation in icount mode.
Signed-off-by: Pavel Dovgalyuk
Reviewed-by: Richard Henderson
This patch enables reverse debugging with watchpoints.
Reverse continue scans the execution to find the breakpoints
and watchpoints that should fire. It uses helper function
replay_breakpoint() for that. But this function needs to access
icount, which can't be correct in the middle of TB.
Therefore
1 - 100 of 494 matches
Mail list logo
