Re: [PULL 00/10] Gitlab-CI, qtest, moxie removal and misc patches

2021-05-06 Thread Thomas Huth
On 05/05/2021 20.06, Peter Maydell wrote: On Mon, 3 May 2021 at 11:45, Thomas Huth wrote: Hi Peter, the following changes since commit 53c5433e84e8935abed8e91d4a2eb813168a0ecf: Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210501' into staging (2021-05-02 12:02:46 +0

Re: [RFC PATCH v2 2/4] hw/arm/virt: Parse -smp cluster parameter in virt_smp_parse

2021-05-06 Thread wangyanan (Y)
Hi Drew, On 2021/4/30 18:49, Andrew Jones wrote: On Fri, Apr 30, 2021 at 05:33:42PM +0800, wangyanan (Y) wrote: On 2021/4/30 15:01, Andrew Jones wrote: On Fri, Apr 30, 2021 at 08:41:25AM +0200, Andrew Jones wrote: On Fri, Apr 30, 2021 at 01:09:00PM +0800, wangyanan (Y) wrote: But I think the

Re: [PATCH 15/23] net: Avoid dynamic stack allocation

2021-05-06 Thread Jason Wang
在 2021/5/6 上午5:10, Philippe Mathieu-Daudé 写道: Use autofree heap allocation instead of variable-length array on the stack. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Jason Wang --- hw/net/fsl_etsec/rings.c | 9 - hw/net/rocker/rocker_of_dpa.c | 2 +- net/dump.c

[Bug 1865626] Re: qemu hang when ipl boot from a mdev dasd

2021-05-06 Thread Thomas Huth
Can you still reproduce this issue with the latest version of QEMU? Which kind of guest did you install? ** Tags added: s390x ** Changed in: qemu Status: New => Incomplete ** Summary changed: - qemu hang when ipl boot from a mdev dasd + s390x guest hang when ipl boot from a mdev dasd --

[Bug 1864814] Re: Improve UX for macOS when launching from a fullscreen app

2021-05-06 Thread Peter Vegh
** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1864814 Title: Improve UX for macOS when launching from a fullscreen app Status in QEMU: New B

[Bug 1865350] Re: fstrim not working with image mounted to path?

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the state back to

Re: [PATCH 0/2] vhost-vDPA: doorbell mapping support

2021-05-06 Thread Jason Wang
在 2021/5/4 下午4:38, Michael S. Tsirkin 写道: On Thu, Apr 15, 2021 at 04:04:42PM +0800, Jason Wang wrote: Hi All: This series tries to implement doorbell mapping support for vhost-vDPA. Tested with virtio-pci vDPA driver. BTW I'd rather we used the kick/call terminology from the virtio spec. doo

Re: [RESEND PATCH 13/32] linux-headers: Add placeholder for KVM_CAP_SGX_ATTRIBUTE

2021-05-06 Thread Yang Zhong
On Thu, May 06, 2021 at 02:17:21PM +1200, Kai Huang wrote: > On Fri, 2021-04-30 at 14:24 +0800, Yang Zhong wrote: > > From: Sean Christopherson > > > > KVM_CAP_SGX_ATTRIBUTE is a proposed capability for Intel SGX that can be > > used by userspace to enable privileged attributes, e.g. access to th

[Bug 1868055] Re: cannot run golang app with docker, version 17.09.1-ce, disabling core 0 and qemu-arm, version 2.7.

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the state back to

[Bug 1868617] Re: multiseat: route different spice tablet events to distinct vdagents

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the state back to

[Bug 1866792] Re: formating vdi-disk over nbd fails

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the state back to

[Bug 1867786] Re: Qemu PPC64 freezes with multi-core CPU

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the state back to

[Bug 1866577] Re: powerpc-none-eabi-gdb.exe GDB 9.1 with QEMU 4.2 gdb-stub comes with Reply contains invalid hex digit 79

2021-05-06 Thread Thomas Huth
Which parameters do you use to run QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1866577 Title: powerpc-none-eabi-gdb.exe GDB 9.1 with QE

[Bug 1873032] Re: After upgrade qemu to 5.0.0-0.3.rc2.fc33 the virtual machine with Windows 10 after a while starts to work very slowly

2021-05-06 Thread Thomas Huth
The patches mentioned in the previous comments have been released with QEMU v5.1, so I'm marking this bug as fixed now. If you still have problems, please open a new ticket. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of q

[Bug 1873335] Re: Dos Keypad is not working for numbers - numlock is not working

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the state back to

[Bug 1872644] Re: MacOS host qemu-system-x86_64 -cpu host not working

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the state back to

Re: [PULL 00/10] Gitlab-CI, qtest, moxie removal and misc patches

2021-05-06 Thread Peter Maydell
On Thu, 6 May 2021 at 08:01, Thomas Huth wrote: > > On 05/05/2021 20.06, Peter Maydell wrote: > > On Mon, 3 May 2021 at 11:45, Thomas Huth wrote: > >> > >> Hi Peter, > >> > >> the following changes since commit > >> 53c5433e84e8935abed8e91d4a2eb813168a0ecf: > >> > >>Merge remote-tracking b

Re: [PATCH v2 9/9] block/write-threshold: drop extra includes

2021-05-06 Thread Max Reitz
On 05.05.21 22:34, Vladimir Sementsov-Ogievskiy wrote: 05.05.2021 19:23, Max Reitz wrote: On 04.05.21 10:25, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy ---   block/write-threshold.c | 3 ---   1 file changed, 3 deletions(-) diff --git a/block/write-threshol

Re: [PATCH 1/7] vhost-user-gpu: fix memory disclosure in virgl_cmd_get_capset_info

2021-05-06 Thread Li Qiang
P J P 于2021年5月6日周四 下午1:53写道: > > +-- On Wed, 5 May 2021, Li Qiang wrote --+ > | P J P 于2021年5月5日周三 下午3:24写道: > | > - vg_ctrl_response(g, cmd, &resp.hdr, sizeof(resp)); > | > + vg_ctrl_response(g, cmd, &resp.hdr, sizeof(resp.hdr)); > | > > | > * While memset(3) is okay, should it also send hea

RE: [PATCH RFC v5 07/12] hw/riscv: PLIC update external interrupt by KVM when kvm enabled

2021-05-06 Thread Jiangyifei
> -Original Message- > From: Qemu-riscv > [mailto:qemu-riscv-bounces+jiangyifei=huawei@nongnu.org] On Behalf Of > Anup Patel > Sent: Friday, April 30, 2021 12:54 PM > To: Jiangyifei > Cc: Bin Meng ; open list:RISC-V > ; Sagar Karandikar ; > KVM General ; libvir-l...@redhat.com; Bastia

Re: [PATCH] target/sh4: Return error if CPUClass::get_phys_page_debug() fails

2021-05-06 Thread Yoshinori Sato
On Thu, 06 May 2021 01:10:46 +0900, Philippe Mathieu-Daudé wrote: > > If the get_physical_address() call fails, the SH4 get_phys_page_debug() > handler returns an uninitialized address. Instead return -1, which > correspond to "no page found" (see cpu_get_phys_page_debug() doc > string). > > This

[Bug 1871842] Re: AMD CPUID leaf 0x8000'0008 reported number of cores inconsistent with ACPI.MADT

2021-05-06 Thread Thomas Huth
If I got that right, there were some patches proposed for this bug ... has this been fixed already? Or is there still anything left to do? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Bug 1871270] Re: [Feature Request] add usbredir device reset blacklist options support to allow macOS guest to iOS device usbredir

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the state back to

Re: [PATCH v26 00/20] i386 cleanup PART 2

2021-05-06 Thread Claudio Fontana
On 5/5/21 9:31 PM, Eduardo Habkost wrote: > On Wed, May 05, 2021 at 02:15:29PM +0200, Philippe Mathieu-Daudé wrote: >> On 5/5/21 12:04 PM, Alex Bennée wrote: >>> Claudio Fontana writes: On 3/8/21 3:02 PM, Alex Bennée wrote: > Claudio Fontana writes: > >> Hi, >> >> anythin

Re: [for-6.1 2/4] virtio-blk: Configure all host notifiers in a single MR transaction

2021-05-06 Thread Michael S. Tsirkin
On Wed, May 05, 2021 at 01:15:51PM +0200, Greg Kurz wrote: > On Wed, 5 May 2021 11:14:23 +0100 > Stefan Hajnoczi wrote: > > > On Wed, Apr 07, 2021 at 04:34:59PM +0200, Greg Kurz wrote: > > > This allows the virtio-blk-pci device to batch the setup of all its > > > host notifiers. This significant

[Bug 1871267] Re: Multiple (Repeating) Keystrokes in macOS

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the state back to

[Bug 1869782] Re: qemu-arm-static crashes "segmentation fault" when running "svn checkout"

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the state back to

[Bug 1870477] Re: qemu-arm hangs when golang running test

2021-05-06 Thread Thomas Huth
Is this still reproducible with the latest version of QEMU? The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this b

[Bug 1870039] Re: windows qemu-img fails to convert vhdx, assertion failure

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the state back to

Re: [PATCH 11/23] hw/intc/xics: Avoid dynamic stack allocation

2021-05-06 Thread Greg Kurz
On Wed, 5 May 2021 23:10:35 +0200 Philippe Mathieu-Daudé wrote: > Use autofree heap allocation instead of variable-length > array on the stack. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/intc/xics.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/intc/xi

[Bug 1855617] Re: savevm with hax saves wrong register state

2021-05-06 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/188 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1855002] Re: Cannot boot arm kernel images on s390x

2021-05-06 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/187 ** Changed in: qemu Status: New => Expired ** Bug watch

Re: [PATCH 05/23] io/channel-websock: Replace strlen(const_str) by sizeof(const_str) - 1

2021-05-06 Thread Daniel P . Berrangé
On Wed, May 05, 2021 at 11:10:29PM +0200, Philippe Mathieu-Daudé wrote: > The combined_key[... QIO_CHANNEL_WEBSOCK_GUID_LEN ...] array in > qio_channel_websock_handshake_send_res_ok() expands to a call > to strlen(QIO_CHANNEL_WEBSOCK_GUID), and the compiler doesn't > realize the string is const, so

Re: [PATCH 5/5] target/ppc/kvm: Replace alloca() by g_malloc()

2021-05-06 Thread Greg Kurz
On Wed, 5 May 2021 19:00:55 +0200 Philippe Mathieu-Daudé wrote: > The ALLOCA(3) man-page mentions its "use is discouraged". > > Replace it by a g_malloc() call. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/ppc/kvm.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(

Re: [ANNOUNCE] libblkio v0.1.0 preview release

2021-05-06 Thread Stefan Hajnoczi
On Wed, May 05, 2021 at 06:46:36PM +0200, Kevin Wolf wrote: > Am 05.05.2021 um 18:19 hat Stefan Hajnoczi geschrieben: > > On Tue, May 04, 2021 at 03:44:23PM +0200, Kevin Wolf wrote: > > > Am 30.04.2021 um 17:49 hat Stefan Hajnoczi geschrieben: > > > > On Thu, Apr 29, 2021 at 05:51:16PM +0200, Kevin

[PATCH] qemu-iotests: fix pylint 2.8 consider-using-with error

2021-05-06 Thread Emanuele Giuseppe Esposito
pylint 2.8 introduces consider-using-with error, suggesting to use the 'with' block statement when possible. http://pylint.pycqa.org/en/latest/whatsnew/2.8.html Modify all subprocess.Popen calls to use the 'with' statement, except one in __init__ of QemuIoInteractive class, since the return value

Re: [PATCH v8] introduce vfio-user protocol specification

2021-05-06 Thread Stefan Hajnoczi
Thanks, I will review the rest of the spec early next week. Stefan signature.asc Description: PGP signature

Re: [PATCH 06/23] hw/block/dataplane/virtio-blk: Avoid dynamic stack allocation

2021-05-06 Thread Stefan Hajnoczi
On Wed, May 05, 2021 at 11:10:30PM +0200, Philippe Mathieu-Daudé wrote: > Use autofree heap allocation instead of variable-length > array on the stack. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/block/dataplane/virtio-blk.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-)

Re: [PATCH v5] i386/cpu_dump: support AVX512 ZMM regs dump

2021-05-06 Thread Robert Hoo
On Mon, 2021-04-19 at 17:59 -0400, Eduardo Habkost wrote: > On Mon, Apr 19, 2021 at 04:18:25PM -0400, Eduardo Habkost wrote: > > On Fri, Apr 16, 2021 at 10:08:24AM +0800, Robert Hoo wrote: > > > Since commit fa4518741e (target-i386: Rename struct XMMReg to > > > ZMMReg), > > > CPUX86State.xmm_regs[

Re: [RESEND PATCH 31/32] sgx-epc: Add the fill_device_info() callback support

2021-05-06 Thread Yang Zhong
On Mon, May 03, 2021 at 01:01:22PM -0500, Eric Blake wrote: > On 4/30/21 1:24 AM, Yang Zhong wrote: > > Since there is no fill_device_info() callback support, and when we > > execute "info memory-devices" command in the monitor, the segfault > > will be found. > > > > This patch will add this call

Re: [PATCH 06/23] hw/block/dataplane/virtio-blk: Avoid dynamic stack allocation

2021-05-06 Thread Philippe Mathieu-Daudé
On 5/6/21 10:53 AM, Stefan Hajnoczi wrote: > On Wed, May 05, 2021 at 11:10:30PM +0200, Philippe Mathieu-Daudé wrote: >> Use autofree heap allocation instead of variable-length >> array on the stack. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/block/dataplane/virtio-blk.c | 7 ---

Re: [PATCH v2 1/8] block: prepare write threshold code for thread safety

2021-05-06 Thread Stefan Hajnoczi
On Wed, May 05, 2021 at 12:54:09PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi Stefan! > > Note my "[PATCH v2 0/9] block: refactor write threshold", it's a kind of > counter-proposal for first half of this series. Thanks! Emanuele mentioned he will drop his patches. I took a look at your se

[PATCH v3 5/8] block/write-threshold: don't use aio context lock

2021-05-06 Thread Vladimir Sementsov-Ogievskiy
Instead of relying on aio context lock, let's make use of atomic operations. The tricky place is bdrv_write_threshold_check_write(): we want atomically unset bs->write_threshold_offset iff offset + bytes > bs->write_threshold_offset We don't have such atomic operation, so let's go in a loop: 1.

[PATCH v3 2/8] block: drop write notifiers

2021-05-06 Thread Vladimir Sementsov-Ogievskiy
They are unused now. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- include/block/block_int.h | 12 block.c | 1 - block/io.c| 6 -- 3 files changed, 19 deletions(-) diff --git a/include/block/block_int.h b/include/bl

[PATCH v3 7/8] test-write-threshold: drop extra TestStruct structure

2021-05-06 Thread Vladimir Sementsov-Ogievskiy
We don't need this extra logic: it doesn't make code simpler. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/unit/test-write-threshold.c | 20 +++- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/tests/unit/test-write-threshold.c b/t

[PATCH v3 0/8] block: refactor write threshold

2021-05-06 Thread Vladimir Sementsov-Ogievskiy
Hi all! v3: 01-04,06,07: add Max's r-b. 01: improve commit msg and comments 03: improve commit msg 05: add more comments and qemu/atomic.h include 08: new, replacement for v2:08,09 Vladimir Sementsov-Ogievskiy (8): block/write-threshold: don't use write notifiers block: drop write notifiers

[PATCH v3 3/8] test-write-threshold: rewrite test_threshold_(not_)trigger tests

2021-05-06 Thread Vladimir Sementsov-Ogievskiy
These tests use bdrv_write_threshold_exceeded() API, which is used only for test (since pre-previous commit). Better is testing real API, which is used in block.c as well. So, let's call bdrv_write_threshold_check_write(), and check is bs->write_threshold_offset cleared or not (it's cleared iff th

[PATCH v3 8/8] write-threshold: deal with includes

2021-05-06 Thread Vladimir Sementsov-Ogievskiy
"qemu/typedefs.h" is enough for include/block/write-threshold.h header with forward declaration of BlockDriverState. Also drop extra includes from block/write-threshold.c and tests/unit/test-write-threshold.c Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/write-threshold.h | 2 +

[PATCH v3 1/8] block/write-threshold: don't use write notifiers

2021-05-06 Thread Vladimir Sementsov-Ogievskiy
write-notifiers are used only for write-threshold. New code for such purpose should create filters. Let's better special-case write-threshold and drop write notifiers at all. (Actually, write-threshold is special-cased anyway, as the only user of write-notifiers) So, create a new direct interface

[Bug 1860575] Re: qemu64 CPU model is incorrect

2021-05-06 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/191 ** Changed in: qemu Status: New => Expired ** Bug watch

[PATCH v3 4/8] block/write-threshold: drop extra APIs

2021-05-06 Thread Vladimir Sementsov-Ogievskiy
bdrv_write_threshold_exceeded() is unused at all. bdrv_write_threshold_is_set() is used only to double check the value of bs->write_threshold_offset in tests. No real sense in it (both tests do check real value with help of bdrv_write_threshold_get()) Signed-off-by: Vladimir Sementsov-Ogievskiy

[PATCH v3 6/8] test-write-threshold: drop extra tests

2021-05-06 Thread Vladimir Sementsov-Ogievskiy
Testing set/get of one 64bit variable doesn't seem necessary. We have a lot of such variables. Also remaining tests do test set/get anyway. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/unit/test-write-threshold.c | 43 --- 1 file chang

[Bug 1860742] Re: xv6 Bootloop

2021-05-06 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/192 ** Changed in: qemu Status: New => Expired ** Bug watch

Re: [RESEND PATCH 29/32] qmp: Add the qmp_query_sgx_capabilities()

2021-05-06 Thread Yang Zhong
On Mon, May 03, 2021 at 01:00:37PM -0500, Eric Blake wrote: > On 4/30/21 1:24 AM, Yang Zhong wrote: > > The libvirt can use qmp_query_sgx_capabilities() to get the host > > s/The libvirt/Libvirt/ > > > sgx capabilitis. > > > > capabilities > Eric, thanks for your comments! I will change thos

[Bug 1861562] Re: piix crashes on mips when using multiple cpus

2021-05-06 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/193 ** Changed in: qemu Status: Triaged => Expired ** Bug w

Re: [RESEND PATCH 25/32] qmp: Add query-sgx command

2021-05-06 Thread Yang Zhong
On Mon, May 03, 2021 at 12:58:34PM -0500, Eric Blake wrote: > On 4/30/21 1:24 AM, Yang Zhong wrote: > > This QMP query command can be used by some userspaces to retrieve > > the SGX information when SGX is enabled on Intel platform. > > > > Signed-off-by: Yang Zhong > > --- > > monitor/qmp-cmds.

[Bug 1856399] Re: Intel GVT-g works in X11, segfaults in wayland

2021-05-06 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/189 ** Changed in: qemu Status: New => Expired ** Bug watch

[PATCH] virtio-gpu: handle partial maps properly

2021-05-06 Thread Gerd Hoffmann
dma_memory_map() may map only a part of the request. Happens if the request can't be mapped in one go, for example due to a iommu creating a linear dma mapping for scattered physical pages. Should that be the case virtio-gpu must call dma_memory_map() again with the remaining range instead of sim

[Bug 1857226] Re: 'set_link net0 off' not working with e1000e driver

2021-05-06 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/190 ** Changed in: qemu Status: New => Expired ** Bug watch

Re: [PATCH v7 10/15] hostmem: Wire up RAM_NORESERVE via "reserve" property

2021-05-06 Thread David Hildenbrand
On 04.05.21 11:58, Paolo Bonzini wrote: On 28/04/21 15:37, David Hildenbrand wrote: @@ -545,6 +545,9 @@ # @share: if false, the memory is private to QEMU; if true, it is shared # (default: false) # +# @reserve: if true, reserve swap space (or huge pages) if applicable +#

Re: [PATCH v26 00/20] i386 cleanup PART 2

2021-05-06 Thread Philippe Mathieu-Daudé
On 5/6/21 9:55 AM, Claudio Fontana wrote: > On 5/5/21 9:31 PM, Eduardo Habkost wrote: >> On Wed, May 05, 2021 at 02:15:29PM +0200, Philippe Mathieu-Daudé wrote: >>> On 5/5/21 12:04 PM, Alex Bennée wrote: Claudio Fontana writes: > On 3/8/21 3:02 PM, Alex Bennée wrote: >> Claudio Fontan

Re: [PATCH v2 1/8] block: prepare write threshold code for thread safety

2021-05-06 Thread Vladimir Sementsov-Ogievskiy
06.05.2021 12:04, Stefan Hajnoczi wrote: On Wed, May 05, 2021 at 12:54:09PM +0300, Vladimir Sementsov-Ogievskiy wrote: Hi Stefan! Note my "[PATCH v2 0/9] block: refactor write threshold", it's a kind of counter-proposal for first half of this series. Thanks! Emanuele mentioned he will drop h

Re: [PATCH v4 4/6] block: Support multiple reopening with x-blockdev-reopen

2021-05-06 Thread Vladimir Sementsov-Ogievskiy
05.05.2021 19:18, Kevin Wolf wrote: And then, bdrv_reopen_multiple() is called with no aio context acquired, and no drained section.. And it shoud be refactored to properly operate with acquiring and realeasing the contexts and drained sections when needed... The drained section shouldn't be a p

Re: [PATCH v26 00/20] i386 cleanup PART 2

2021-05-06 Thread Philippe Mathieu-Daudé
On 5/6/21 11:10 AM, Philippe Mathieu-Daudé wrote: > On 5/6/21 9:55 AM, Claudio Fontana wrote: >> On 5/5/21 9:31 PM, Eduardo Habkost wrote: >>> On Wed, May 05, 2021 at 02:15:29PM +0200, Philippe Mathieu-Daudé wrote: On 5/5/21 12:04 PM, Alex Bennée wrote: > Claudio Fontana writes: >> On

Re: [PATCH v2 2/3] docs/interop/bitmaps: use blockdev-backup

2021-05-06 Thread Kashyap Chamarthy
On Wed, May 05, 2021 at 04:58:02PM +0300, Vladimir Sementsov-Ogievskiy wrote: > We are going to deprecate drive-backup, so use modern interface here. > In examples where target image creation is shown, show blockdev-add as > well. If target creation omitted, omit blockdev-add as well. > > Signed-o

Re: [PATCH] virtio-gpu: handle partial maps properly

2021-05-06 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210506091001.1301250-1-kra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210506091001.1301250-1-kra...@redhat.com Subject: [PATCH] virtio-gpu: handle partial ma

Re: [PATCH v3 2/7] virtiofsd: Changed allocations of iovec to GLib's functions

2021-05-06 Thread Dr. David Alan Gilbert
* Mahmoud Mandour (ma.mando...@gmail.com) wrote: > Replaced the calls to malloc()/calloc() and their respective > calls to free() of iovec structs with GLib's allocation and > deallocation functions and used g_autofree when appropriate. > > Replaced the allocation of in_sg_cpy to g_new() instead o

Re: [PATCH v2 3/3] qapi: deprecate drive-backup

2021-05-06 Thread Kashyap Chamarthy
On Wed, May 05, 2021 at 04:58:03PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Modern way is using blockdev-add + blockdev-backup, which provides a > lot more control on how target is opened. > > As example of drive-backup problems consider the following: > > User of drive-backup expects that ta

Re: [PATCH v7 10/15] hostmem: Wire up RAM_NORESERVE via "reserve" property

2021-05-06 Thread David Hildenbrand
On 04.05.21 13:18, Daniel P. Berrangé wrote: On Tue, May 04, 2021 at 01:08:02PM +0200, David Hildenbrand wrote: On 04.05.21 12:12, Daniel P. Berrangé wrote: On Wed, Apr 28, 2021 at 03:37:49PM +0200, David Hildenbrand wrote: Let's provide a way to control the use of RAM_NORESERVE via memory bac

Re: [Virtio-fs] [PATCH 1/2] virtiofsd: Allow use "-o xattrmap" without "-o xattr"

2021-05-06 Thread Dr. David Alan Gilbert
* Greg Kurz (gr...@kaod.org) wrote: > On Wed, 14 Apr 2021 20:12:06 + > Carlos Venegas wrote: > > > When -o xattrmap is used, it will not work unless xattr is enabled. > > > > This patch enables xattr when -o xattrmap is used. > > > > Signed-off-by: Carlos Venegas > > --- > > tools/virtiof

Re: [PATCH] target/m68k: Remove unused variable in ABCD/SBCD memory opcodes

2021-05-06 Thread Laurent Vivier
Le 05/05/2021 à 18:43, Laurent Vivier a écrit : > Le 05/05/2021 à 18:03, Philippe Mathieu-Daudé a écrit : >> The ABCD / SBCD memory opcodes (introduced in commit fb5543d8200) >> don't use their "addr" variable. >> >> Remove the unused variable and pass a NULL argument instead to >> gen_ea_mode(). T

Re: [ANNOUNCE] libblkio v0.1.0 preview release

2021-05-06 Thread Kevin Wolf
Am 06.05.2021 um 10:46 hat Stefan Hajnoczi geschrieben: > On Wed, May 05, 2021 at 06:46:36PM +0200, Kevin Wolf wrote: > > Am 05.05.2021 um 18:19 hat Stefan Hajnoczi geschrieben: > > > On Tue, May 04, 2021 at 03:44:23PM +0200, Kevin Wolf wrote: > > > > Am 30.04.2021 um 17:49 hat Stefan Hajnoczi gesc

Re: [PATCH v3 01/16] tcg/s390x: Rename from tcg/s390

2021-05-06 Thread David Hildenbrand
On 03.05.21 20:35, Richard Henderson wrote: This emphasizes that we don't support s390, only 64-bit s390x hosts. Signed-off-by: Richard Henderson --- meson.build | 2 -- tcg/{s390 => s390x}/tcg-target-con-set.h | 0 tcg/{s390 => s390x}/tcg-target-con-str.h | 0

[Bug 1873337] Re: Arrow keys press is double in some programs in Dos

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the state back to

[Bug 1865160] Re: Unpredictable behaviour resulting in User process faults

2021-05-06 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/197 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1864814] Re: Improve UX for macOS when launching from a fullscreen app

2021-05-06 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/196 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1861692] Re: wavcapture does not record silence

2021-05-06 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/195 ** Changed in: qemu Status: New => Expired ** Bug watch

Re: [PATCH] virtio-gpu: handle partial maps properly

2021-05-06 Thread Auger Eric
Hi Gerd, On 5/6/21 11:10 AM, Gerd Hoffmann wrote: > dma_memory_map() may map only a part of the request. Happens if the > request can't be mapped in one go, for example due to a iommu creating > a linear dma mapping for scattered physical pages. Should that be the > case virtio-gpu must call dma

Re: [PATCH v2 00/15] linux-user/s390x: some signal fixes

2021-05-06 Thread Cornelia Huck
On Wed, 28 Apr 2021 12:33:53 -0700 Richard Henderson wrote: > Version 2 splits lazy do-it-all patch. > Patch 1 has an additional fix, so I dropped the r-b. > > r~ > > Richard Henderson (15): > linux-user/s390x: Fix sigframe types > linux-user/s390x: Use uint16_t for signal retcode > linux

Re: [PATCH 2/5] gdbstub: Constify GdbCmdParseEntry

2021-05-06 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v3 05/16] tcg/s390x: Implement tcg_out_ld/st for vector types

2021-05-06 Thread David Hildenbrand
On 03.05.21 20:35, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.c.inc | 117 + 1 file changed, 105 insertions(+), 12 deletions(-) diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc index 52df20a1ed..6

Re: [PATCH 3/5] gdbstub: Use fixed-size array in GdbCmdParseEntry instead of pointer

2021-05-06 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > GdbCmdParseEntry should have enough room with 20 chars for the command > string, and 8 for the schema. Add the GDB_CMD_PARSE_ENTRY_CMD_SIZE and > GDB_CMD_PARSE_ENTRY_SCHEMA_SIZE definitions. > > Do not use pointer to string of unknown length, but array of fixed

Re: [PATCH] virtio-gpu: handle partial maps properly

2021-05-06 Thread Gerd Hoffmann
Hi, > > +if (!(v % 16)) { > > +*iov = g_realloc(*iov, sizeof(struct iovec) * (v + 16)); > > +if (addr) { > > +*addr = g_realloc(*addr, sizeof(uint64_t) * (v + 16)); > nit: just wondering why you chose to do the alloc by slice of 16

Re: [PATCH 3/5] gdbstub: Use fixed-size array in GdbCmdParseEntry instead of pointer

2021-05-06 Thread Philippe Mathieu-Daudé
On 5/6/21 2:01 PM, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> GdbCmdParseEntry should have enough room with 20 chars for the command >> string, and 8 for the schema. Add the GDB_CMD_PARSE_ENTRY_CMD_SIZE and >> GDB_CMD_PARSE_ENTRY_SCHEMA_SIZE definitions. >> >> Do not use pointer

Re: [RESEND PATCH 03/32] qom: Add memory-backend-epc ObjectOptions support

2021-05-06 Thread Yang Zhong
On Mon, May 03, 2021 at 12:56:55PM -0500, Eric Blake wrote: > On 4/30/21 1:24 AM, Yang Zhong wrote: > > Add the new 'memory-backend-epc' user creatable QOM object in > > the ObjectOptions to support SGX, or the sgx backend object > > cannot bootup. > > > > Signed-off-by: Yang Zhong > > --- > > q

[question] The source cannot recover, if the destination fails in the last round of live migration

2021-05-06 Thread Kunkun Jiang
Hi all, Recently I am learning about the part of live migration. I have a question about the last round. When the pending_size is less than the threshold, it will enter the last round and call migration_completion(). It will stop the source and sent the remaining dirty pages and devices' status

Re: [question] The source cannot recover, if the destination fails in the last round of live migration

2021-05-06 Thread Dr. David Alan Gilbert
* Kunkun Jiang (jiangkun...@huawei.com) wrote: > Hi all, Hi, > Recently I am learning about the part of live migration. > I have a question about the last round. > > When the pending_size is less than the threshold, it will enter > the last round and call migration_completion(). It will stop the

Re: [PATCH 5/5] target/ppc/kvm: Replace alloca() by g_malloc()

2021-05-06 Thread Philippe Mathieu-Daudé
On 5/6/21 10:41 AM, Greg Kurz wrote: > On Wed, 5 May 2021 19:00:55 +0200 > Philippe Mathieu-Daudé wrote: > >> The ALLOCA(3) man-page mentions its "use is discouraged". >> >> Replace it by a g_malloc() call. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> target/ppc/kvm.c | 10 +-

[Bug 1873337] Re: Arrow keys press is double in some programs in Dos

2021-05-06 Thread ruthan
** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1873337 Title: Arrow keys press is double in some programs in Dos Status in QEMU: New Bug desc

[Bug 1873335] Re: Dos Keypad is not working for numbers - numlock is not working

2021-05-06 Thread ruthan
** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1873335 Title: Dos Keypad is not working for numbers - numlock is not working Status in QEMU: N

Re: [PATCH v1] migration/dirtyrate: make sample page count configurable

2021-05-06 Thread Dr. David Alan Gilbert
* huang...@chinatelecom.cn (huang...@chinatelecom.cn) wrote: > From: Hyman Huang(黄勇) > > introduce optional sample-pages argument in calc-dirty-rate, > making sample page count per GB configurable so that more > accurate dirtyrate can be calculated. > > Signed-off-by: Hyman Huang(黄勇) I think t

Re: [PATCH v2 00/15] linux-user/s390x: some signal fixes

2021-05-06 Thread Laurent Vivier
Le 06/05/2021 à 13:54, Cornelia Huck a écrit : > On Wed, 28 Apr 2021 12:33:53 -0700 > Richard Henderson wrote: > >> Version 2 splits lazy do-it-all patch. >> Patch 1 has an additional fix, so I dropped the r-b. >> >> r~ >> >> Richard Henderson (15): >> linux-user/s390x: Fix sigframe types >>

[PATCH v2 2/9] backends/tpm: Replace qemu_mutex_lock calls with QEMU_LOCK_GUARD

2021-05-06 Thread Philippe Mathieu-Daudé
Simplify the tpm_emulator_ctrlcmd() handler by replacing a pair of qemu_mutex_lock/qemu_mutex_unlock calls by the WITH_QEMU_LOCK_GUARD macro. Signed-off-by: Philippe Mathieu-Daudé --- backends/tpm/tpm_emulator.c | 34 +++--- 1 file changed, 15 insertions(+), 19 deleti

[PATCH v2 0/9] misc: Replace alloca() by g_malloc()

2021-05-06 Thread Philippe Mathieu-Daudé
The ALLOCA(3) man-page mentions its "use is discouraged". Replace few calls by equivalent GLib malloc(). Last call site is linux-user/. Since v1: - Converted more uses (alsaaudio, tpm, pca9552) - Reworked gdbstub (Alex) - Simplified PPC/KVM (Greg) Philippe Mathieu-Daudé (9): audio/alsaaudio: R

[PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new()

2021-05-06 Thread Philippe Mathieu-Daudé
The ALLOCA(3) man-page mentions its "use is discouraged". Replace it by a g_new() call. Signed-off-by: Philippe Mathieu-Daudé --- bsd-user/syscall.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/bsd-user/syscall.c b/bsd-user/syscall.c index 4abff796c76..dbee0385ceb 10064

[PATCH v2 1/9] audio/alsaaudio: Replace ALSA alloca() by malloc() equivalent

2021-05-06 Thread Philippe Mathieu-Daudé
The ALLOCA(3) man-page mentions its "use is discouraged". Define the cleanup functions for the snd_pcm_[hw/sw]_params_t types, and replace the ALSA alloca() calls by equivalent ALSA malloc(). Signed-off-by: Philippe Mathieu-Daudé --- audio/alsaaudio.c | 11 +++ 1 file changed, 7 inserti

[Bug 1875702] Re: madvise reports success, but doesn't implement WIPEONFORK.

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the state back to

[PATCH v2 5/9] gdbstub: Constify GdbCmdParseEntry

2021-05-06 Thread Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé --- gdbstub.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 9103ffc9028..83d47c67325 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1981,7 +1981,7 @@ static void handle_v_kill(Gdb

[PATCH v2 6/9] gdbstub: Only call cmd_parse_params() with non-NULL command schema

2021-05-06 Thread Philippe Mathieu-Daudé
Move the NULL check on command schema buffer from the callee cmd_parse_params() to the single caller, process_string_cmd(). This simplifies the process_string_cmd() logic. Signed-off-by: Philippe Mathieu-Daudé --- gdbstub.c | 27 --- 1 file changed, 12 insertions(+), 15

[PATCH v2 3/9] backends/tpm: Replace g_alloca() by g_malloc()

2021-05-06 Thread Philippe Mathieu-Daudé
The ALLOCA(3) man-page mentions its "use is discouraged". Replace a g_alloca() call by a g_malloc() one, moving the allocation before the MUTEX guarded block. Signed-off-by: Philippe Mathieu-Daudé --- backends/tpm/tpm_emulator.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --gi

  1   2   3   4   >