Igor,
I've rebased the original patches on to qemu-v6.0.0-rc4, and finally have
everything working as it previously did.
I've started now to work to incorporate the HostMemoryBackendFile; that is
progressing.
My question for you today is with regard to placing ERST device on PCI. The PCI
example
On Mon 03 May 2021 01:33:57 PM CEST, Vladimir Sementsov-Ogievskiy
wrote:
> @@ -2918,12 +2918,18 @@ BdrvChild *bdrv_root_attach_child(BlockDriverState
> *child_bs,
> child_role, perm, shared_perm, opaque,
> &child, tran, errp
On Mon 03 May 2021 01:33:58 PM CEST, Vladimir Sementsov-Ogievskiy
wrote:
> We have one path, where tran object is created, but we don't touch and
> don't free it in any way: "goto cleanup" in first loop with calls to
> bdrv_flush().
>
> Fix it simply moving tran_new() call below that loop.
>
> Re
This got resolved along the way and wasn't really a qemu bug anyway.
** Changed in: qemu
Status: Incomplete => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1762558
Title:
Many
On Mon 03 May 2021 01:33:59 PM CEST, Vladimir Sementsov-Ogievskiy
wrote:
> We have different types of parents: block nodes, block backends and
> jobs. So, it makes sense to specify type together with name.
>
> While being here also use g_autofree.
>
> iotest 307 output is updated.
>
> Signed-off-
On Mon 03 May 2021 01:34:01 PM CEST, Vladimir Sementsov-Ogievskiy
wrote:
> All existing parent types (block nodes, block devices, jobs) has the
> realization. So, drop unreachable code.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
With the updated description that you propose in your reply t
On Mon, 3 May 2021 14:44:32 +0200
Philippe Mathieu-Daudé wrote:
> Hi Igor,
>
> On 5/3/21 2:36 PM, Igor Mammedov wrote:
> > On Sun, 2 May 2021 00:36:36 +0200
> > Philippe Mathieu-Daudé wrote:
> >
> >> Now than we can probe if the TCG accelerator is available
> >> at runtime with a QMP comman
On 5/2/21 11:54 AM, Philippe Mathieu-Daudé wrote:
Introduce the TYPE_SUN4M_MACHINE and have all sun4m
machines inherit it.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sparc/sun4m.c | 30 +-
1 file changed, 21 insertions(+), 9 deletions(-)
Reviewed-by: Richard He
The QEMU project is currently considering to move its bug tracking to
another system. For this we need to know which bugs are still valid
and which could be closed already. Thus we are setting older bugs to
"Incomplete" now.
If you still think this bug report here is valid, then please switch
the
The QEMU project is currently considering to move its bug tracking to
another system. For this we need to know which bugs are still valid
and which could be closed already. Thus we are setting older bugs to
"Incomplete" now.
If you still think this bug report here is valid, then please switch
the
On Sun, May 2, 2021 at 9:24 PM Richard Henderson
wrote:
>
> Suggested-by: Thomas Huth
> Signed-off-by: Richard Henderson
> ---
> .gitlab-ci.d/crossbuilds.yml | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
Reviewed-by: Willian Rampazzo
> diff --git a/.gitlab-ci.d/crossbu
On Sun, May 2, 2021 at 9:14 PM Richard Henderson
wrote:
>
> We're currently only testing TCI with a 64-bit host -- also test
> with a 32-bit host. Enable a selection of softmmu and user-only
> targets, 32-bit LE, 64-bit LE, 32-bit BE, as there are ifdefs for each.
>
> Acked-by: Thomas Huth
> Rev
The QEMU project is currently considering to move its bug tracking to
another system. For this we need to know which bugs are still valid
and which could be closed already. Thus we are setting older bugs to
"Incomplete" now.
If you still think this bug report here is valid, then please switch
the
On 5/2/21 11:54 AM, Philippe Mathieu-Daudé wrote:
Factor out the class_init code common to all machines
to sun4m_machine_class_init().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sparc/sun4m.c | 103 ---
1 file changed, 8 insertions(+), 95 deletion
On 5/2/21 11:54 AM, Philippe Mathieu-Daudé wrote:
Instead of passing the sun4m_hwdef structure via
machine_init(), store it into the MachineClass.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sparc/sun4m.c | 50 +---
1 file changed, 39 insertions(+)
On 5/2/21 11:54 AM, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sparc/sun4m.c | 100 +--
1 file changed, 36 insertions(+), 64 deletions(-)
Reviewed-by: Richard Henderson
r~
On 5/2/21 11:54 AM, Philippe Mathieu-Daudé wrote:
We are going to move this code, fix its style first.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sparc/sun4m.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
Reviewed-by: Richard Henderson
r~
On 5/2/21 11:54 AM, Philippe Mathieu-Daudé wrote:
+static void ss5_class_init(ObjectClass *oc, void *data)
+{
+MachineClass *mc = MACHINE_CLASS(oc);
+Sun4mMachineClass *smc = SUN4M_MACHINE_CLASS(mc);
+
+mc->desc = "Sun4m platform, SPARCstation 5";
+mc->is_default = true;
+mc->
On 5/3/21 6:27 PM, Richard Henderson wrote:
> On 5/2/21 11:54 AM, Philippe Mathieu-Daudé wrote:
>> +static void ss5_class_init(ObjectClass *oc, void *data)
>> +{
>> + MachineClass *mc = MACHINE_CLASS(oc);
>> + Sun4mMachineClass *smc = SUN4M_MACHINE_CLASS(mc);
>> +
>> + mc->desc = "Sun4m pl
On 5/3/21 6:04 PM, Igor Mammedov wrote:
> On Mon, 3 May 2021 14:44:32 +0200
> Philippe Mathieu-Daudé wrote:
>
>> Hi Igor,
>>
>> On 5/3/21 2:36 PM, Igor Mammedov wrote:
>>> On Sun, 2 May 2021 00:36:36 +0200
>>> Philippe Mathieu-Daudé wrote:
>>>
Now than we can probe if the TCG accelerato
On 5/3/21 5:20 PM, Igor Mammedov wrote:
> On Tue, 13 Apr 2021 15:43:19 -0400
> Eduardo Habkost wrote:
>
>> On Mon, Apr 12, 2021 at 11:44:29AM +0100, Peter Maydell wrote:
>>> On Mon, 12 Apr 2021 at 11:31, Philippe Mathieu-Daudé
>>> wrote:
TIL MachineClass::reset().
- hw/hppa/mac
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/102
** Changed in: qemu
Status: Confirmed => Expired
** Bug
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/100
** Changed in: qemu
Status: New => Expired
** Bug watch
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/101
** Changed in: qemu
Status: Triaged => Expired
** Bug w
Place all files that can be useful to rebuild the Coverity
configuration in scripts/coverity-scan: the existing model
file, and the components setup.
The Markdown syntax was tested with Pandoc (but in any case
is meant more as a human-readable reference than as a part
of documentation).
Suggested
On Sun, May 02, 2021 at 06:39:30PM +0200, Philippe Mathieu-Daudé wrote:
> TYPE_ETRAX_FS_TIMER is a sysbus device, so its DeviceClass::reset()
> handler is called automatically when its qbus parent is reset
> (we don't need to register it manually).
>
> Convert the generic reset to a enter/hold res
Currently we generally assume that assertions are always present
and always fatal, and we tell Coverity this by putting this into
our model file:
void g_assertion_message_expr(const char *domain,
const char *file,
int
On Sun, May 02, 2021 at 06:39:31PM +0200, Philippe Mathieu-Daudé wrote:
> TYPE_MC146818_RTC is an ISA device, so its DeviceClass::reset()
> handler is called automatically when its qbus parent is reset
> (we don't need to register it manually).
>
> We have 2 reset() methods: a generic one and the
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/104
** Changed in: qemu
Status: Triaged => Expired
** Bug w
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/103
** Changed in: qemu
Status: Confirmed => Expired
** Bug
Hi Peter,
+Eduardo/Markus
On 5/3/21 5:18 PM, Peter Maydell wrote:
> The old function device_legacy_reset() (which was originally
> device_reset() and got renamed when 3-phase-reset landed) is
> deprecated, because it has slightly odd semantics -- it resets the
> device itself, but (unlike when a
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/107
** Changed in: qemu
Status: Confirmed => Expired
** Bug
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/106
** Changed in: qemu
Status: Triaged => Expired
** Bug w
tpm_util_migration_start_qemu() allocates memory with g_strdup_printf()
but frees it with free() rather than g_free(), which provokes Coverity
complaints (CID 1432379, 1432350). Use the correct free function.
Fixes: Coverity CID 1432379, CID 1432350
Signed-off-by: Peter Maydell
---
With newer gli
For us, assertions are always enabled, but side-effect expressions
inside the argument to g_assert() are bad style anyway. Fix three
occurrences in IPMI related tests, which will silence some Coverity
nits.
Fixes: CID 1432322, CID 1432287, CID 1432291
Signed-off-by: Peter Maydell
---
tests/qtest
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/109
** Changed in: qemu
Status: In Progress => Expired
** B
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/105
** Changed in: qemu
Status: Triaged => Expired
** Bug w
We recently started running Coverity on our tests/ code,
which has revealed a pile of issues that we were previously
blissfully unaware of. This series fixes three easy ones:
* use of free() where g_free() was meant
* unnecessary NULL check
* side effect inside g_assert() argument
thanks
-- PMM
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/110
** Changed in: qemu
Status: New => Expired
** Bug watch
In rtc-test.c we know that s is non-NULL because qtest_start()
will return a non-NULL value, and we assume this when we
pass s to qtest_irq_intercept_in(). So we can drop the
initial assignment of NULL and the "if (s)" condition at
the end of the function.
Fixes: Coverity CID 1432353
Signed-off-by
This is an automated cleanup. This bug report has been moved to QEMU's
new bug tracker on gitlab.com and thus gets marked as 'expired' now.
Please continue with the discussion here:
https://gitlab.com/qemu-project/qemu/-/issues/108
** Changed in: qemu
Status: New => Expired
** Bug watch
So we're not going with the suggestion to retry once or a fixed number
of times? Any reason why not?
On Thu, Apr 29, 2021 at 07:13:12PM +0200, Kevin Wolf wrote:
> This is a partial revert of commits 77542d43149 and bc79c87bcde.
>
> Usually, an error during initialisation means that the configurat
On 30/04/21 08:24, Yang Zhong wrote:
From: Sean Christopherson
Add a new RAMBlock flag to denote "protected" memory, i.e. memory that
looks and acts like RAM but is inaccessible via normal mechanisms,
including DMA. Use the flag to skip protected memory regions when
mapping RAM for DMA in VFIO
On Mon, 3 May 2021 15:49:28 +
Eric DeVolder wrote:
> Igor,
> I've rebased the original patches on to qemu-v6.0.0-rc4, and finally have
> everything working as it previously did.
> I've started now to work to incorporate the HostMemoryBackendFile; that is
> progressing.
> My question for you
On 5/3/21 12:55 PM, Peter Maydell wrote:
tpm_util_migration_start_qemu() allocates memory with g_strdup_printf()
but frees it with free() rather than g_free(), which provokes Coverity
complaints (CID 1432379, 1432350). Use the correct free function.
Fixes: Coverity CID 1432379, CID 1432350
Sig
Oliver, did you ever check this with a newer version of QEMU?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1368178
Title:
Windows ME falsely detects qemu's videocards as Number Nine Imagine
128
Missing review: 6
Hi Mark,
This series QOM'ify the sun4m machines.
I need it for a further memory maxsize check.
It is mostly code movement (and the diff-stat is good).
Since v2:
- use static const variable for hwdef (Richard)
- added Richard's R-b tag
Since v1:
- Full rewrite after Mark review
On 30/04/21 08:24, Yang Zhong wrote:
+void pc_machine_init_sgx_epc(PCMachineState *pcms)
+{
+SGXEPCState *sgx_epc;
+X86MachineState *x86ms = X86_MACHINE(pcms);
+
+sgx_epc = g_malloc0(sizeof(*sgx_epc));
+pcms->sgx_epc = sgx_epc;
+
+sgx_epc->base = 0x1ULL + x86ms->above_
Introduce the TYPE_SUN4M_MACHINE and have all sun4m
machines inherit it.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sparc/sun4m.c | 30 +-
1 file changed, 21 insertions(+), 9 deletions(-)
diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4
On 30/04/21 08:24, Yang Zhong wrote:
From: Sean Christopherson
Because SGX EPC is enumerated through CPUID, EPC "devices" need to be
realized prior to realizing the vCPUs themselves, i.e. long before
generic devices are parsed and realized. From a virtualization
perspective, the CPUID aspect a
On 4/29/21 12:13 PM, Kevin Wolf wrote:
> We have to set errp before jumping to virtio_err, otherwise the caller
> (virtio_device_realize()) will take this as success and crash when it
> later tries to access things that we've already freed in the error path.
>
> Fixes: 77542d431491788d1e8e79d93ce1
Instead of passing the sun4m_hwdef structure via
machine_init(), store it into the MachineClass.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sparc/sun4m.c | 50 +---
1 file changed, 39 insertions(+), 11 deletions(-)
di
On Fri, Apr 30, 2021 at 09:34:41PM +, cennedee wrote:
> From 447601c28d5ed0b1208a0560390f760e75ce5613 Mon Sep 17 00:00:00 2001
> From: Cenne Dee
> Date: Fri, 30 Apr 2021 15:52:28 -0400
> Subject: [PATCH] Add missing coroutine_fn function signature to functions
>
> Patch adds the signature for
On Mon, 3 May 2021 at 18:15, Richard Henderson
wrote:
>
> On 5/3/21 9:49 AM, Peter Maydell wrote:
> > (1) Expand "assertions always fatal" to test code, and add "panics"
> > models of the g_assertion_message* functions. Remove all the calls
> > to g_test_set_nonfatal_assertions().
>
> I vaguely pr
We are going to move this code, fix its style first.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sparc/sun4m.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c
index a625c41cd37..956216591b
Factor out the class_init code common to all machines
to sun4m_machine_class_init().
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sparc/sun4m.c | 103 ---
1 file changed, 8 insertions(+), 95 deletions(-)
diff --git a/hw
On Mon, 3 May 2021 at 17:55, Philippe Mathieu-Daudé wrote:
>
> Hi Peter,
>
> +Eduardo/Markus
>
> On 5/3/21 5:18 PM, Peter Maydell wrote:
> > The old function device_legacy_reset() (which was originally
> > device_reset() and got renamed when 3-phase-reset landed) is
> > deprecated, because it has
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sparc/sun4m.c | 100 +--
1 file changed, 36 insertions(+), 64 deletions(-)
diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c
index 56f927e66ca..a625c41cd37 100644
--- a/hw/spar
But is there any option to dynamically add/remove usb devices like from
spice client to vm that is powered up without using spice? As far I have
found there is no such option.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bu
Remove the sun4m_hwdefs[] array by moving assigning the
structure fields directly in each machine class_init()
function.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sparc/sun4m.c | 248 ++-
1 file changed, 118 insertions(+), 130 deletions(-)
diff --g
On 5/3/21 6:55 PM, Peter Maydell wrote:
> For us, assertions are always enabled, but side-effect expressions
> inside the argument to g_assert() are bad style anyway. Fix three
> occurrences in IPMI related tests, which will silence some Coverity
> nits.
>
> Fixes: CID 1432322, CID 1432287, CID 14
X86CPUDefinition[] is never written, move it to .rodata section
by marking it const.
Philippe Mathieu-Daudé (2):
target/i386/cpu: Constify CPUCaches
target/i386/cpu: Constify X86CPUDefinition
target/i386/cpu.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
--
On 5/3/21 9:49 AM, Peter Maydell wrote:
(1) Expand "assertions always fatal" to test code, and add "panics"
models of the g_assertion_message* functions. Remove all the calls
to g_test_set_nonfatal_assertions().
I vaguely prefer this. To me, "assert" means can't continue.
If we want tests tha
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/cpu.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index c7ded968e74..3a6f1c55ef3 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -1668,7 +1668,7 @@ typedef s
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/cpu.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index ad99cad0e7c..c7ded968e74 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -1655,7 +1655,7 @@ typedef struct
From: Giuseppe Musacchio
Signed-off-by: Giuseppe Musacchio
---
linux-user/strace.list | 3 +++
1 file changed, 3 insertions(+)
diff --git a/linux-user/strace.list b/linux-user/strace.list
index 084048ab96..b81f9964e3 100644
--- a/linux-user/strace.list
+++ b/linux-user/strace.list
@@ -1665,3 +
From: Giuseppe Musacchio
The implicit cast from abi_long to size_t may introduce an intermediate
unwanted sign-extension of the value for 32bit targets running on 64bit
hosts.
Signed-off-by: Giuseppe Musacchio
---
linux-user/syscall.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
di
From: Giuseppe Musacchio
An unwanted sign-extension is currently making the host kernel return EOVERFLOW
when calling copy_file_range with a count of 0x, despite the host being
a 64bit platform.
The fix is only affecting 32bit targets on 64bit hosts, it's a no-op when the
target bitness
Acked-by: Raphael Norwitz
On Thu, Apr 29, 2021 at 07:13:11PM +0200, Kevin Wolf wrote:
> We have to set errp before jumping to virtio_err, otherwise the caller
> (virtio_device_realize()) will take this as success and crash when it
> later tries to access things that we've already freed in the err
On 4/30/21 1:24 AM, Yang Zhong wrote:
> Add the new 'memory-backend-epc' user creatable QOM object in
> the ObjectOptions to support SGX, or the sgx backend object
> cannot bootup.
>
> Signed-off-by: Yang Zhong
> ---
> qapi/qom.json | 2 ++
> 1 file changed, 2 insertions(+)
Missing documentatio
On 4/30/21 1:24 AM, Yang Zhong wrote:
> This QMP query command can be used by some userspaces to retrieve
> the SGX information when SGX is enabled on Intel platform.
>
> Signed-off-by: Yang Zhong
> ---
> monitor/qmp-cmds.c | 6 ++
> qapi/misc.json | 42 +
Hi Elena,
+Mark
You asked to use the next KVM-external call slot to talk about
the ISA bus issues. I haven't scheduled the call because it seems
this thread helped to figure the problems and Markus's analysis
resumed them all. From here it should be clearer to see what has
to be done to go where
On 4/30/21 1:24 AM, Yang Zhong wrote:
> The libvirt can use qmp_query_sgx_capabilities() to get the host
s/The libvirt/Libvirt/
> sgx capabilitis.
>
capabilities
> Signed-off-by: Yang Zhong
> ---
> hw/i386/sgx-epc.c | 66 ++
> include/hw/i386/pc.h
On 4/30/21 1:24 AM, Yang Zhong wrote:
> Since there is no fill_device_info() callback support, and when we
> execute "info memory-devices" command in the monitor, the segfault
> will be found.
>
> This patch will add this callback support and "info memory-devices"
> will show sgx epc memory expose
On 4/29/21 4:59 AM, Markus Armbruster wrote:
> If you're cc'ed, you added a section to docs/system/deprecated.rst that
> is old enough to permit removal. This is *not* a demand to remove, it's
> a polite request to consider whether the time for removal has come.
> Extra points for telling us in a
On 4/28/21 10:48 PM, Shivaprasad G Bhat wrote:
> The subsequent patches add definitions which tend to
> get the compilation to cyclic dependency. So, prepare
> with forward declarations, move the defitions and clean up.
definitions
>
> Signed-off-by: Shivaprasad G Bhat
> ---
> hw/ppc/spapr_nvd
On 4/28/21 10:49 PM, Shivaprasad G Bhat wrote:
> The patch adds the 'sync-dax' property to the nvdimm device.
>
> When the sync-dax is 'direct' indicates the backend is synchronous DAX
> capable and no explicit flush requests are required. When the mode is
> set to 'writeback' it indicates the bac
This emphasizes that we don't support s390, only 64-bit s390x hosts.
Signed-off-by: Richard Henderson
---
meson.build | 2 --
tcg/{s390 => s390x}/tcg-target-con-set.h | 0
tcg/{s390 => s390x}/tcg-target-con-str.h | 0
tcg/{s390 => s390x}/tcg-target.h | 0
tcg
Signed-off-by: Richard Henderson
---
tcg/s390x/tcg-target.c.inc | 72 +++---
1 file changed, 68 insertions(+), 4 deletions(-)
diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc
index 6ed9a309c1..439ab5a359 100644
--- a/tcg/s390x/tcg-target.c.inc
Add registers and function stubs. The functionality
is disabled via squashing s390_facilities[2] to 0.
We must still include results for the mandatory opcodes in
tcg_target_op_def, as all opcodes are checked during tcg init.
Signed-off-by: Richard Henderson
---
tcg/s390x/tcg-target-con-set.h |
These logical and arithmetic operations are optional but trivial.
Signed-off-by: Richard Henderson
---
tcg/s390x/tcg-target-con-set.h | 1 +
tcg/s390x/tcg-target.h | 10 +-
tcg/s390x/tcg-target.c.inc | 34 +-
3 files changed, 39 insertions(+),
Signed-off-by: Richard Henderson
---
tcg/s390x/tcg-target.h | 2 +-
tcg/s390x/tcg-target.c.inc | 7 +++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/tcg/s390x/tcg-target.h b/tcg/s390x/tcg-target.h
index dd11972ed2..13b9918276 100644
--- a/tcg/s390x/tcg-target.h
+++ b/tcg/
Implementing add, sub, and, or, xor as the minimal set.
This allows us to actually enable vectors in query_s390_facilities.
Signed-off-by: Richard Henderson
---
tcg/s390x/tcg-target.c.inc | 154 -
1 file changed, 150 insertions(+), 4 deletions(-)
diff --git a
Signed-off-by: Richard Henderson
---
tcg/s390x/tcg-target.c.inc | 117 +
1 file changed, 105 insertions(+), 12 deletions(-)
diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc
index 52df20a1ed..6ed9a309c1 100644
--- a/tcg/s390x/tcg-target.c.in
Changes for v3:
* Rebase on master.
Changes for v2:
* Rebase on master, now that all prereq are upstream.
r~
Richard Henderson (16):
tcg/s390x: Rename from tcg/s390
tcg/s390x: Change FACILITY representation
tcg/s390x: Merge TCG_AREG0 and TCG_REG_CALL_STACK into TCGReg
tcg/s390x: Add
The unsigned saturations are handled via generic code
using min/max. The signed saturations are expanded using
double-sized arithmetic and a saturating pack.
Since all operations are done via expansion, do not
actually set TCG_TARGET_HAS_sat_vec.
Signed-off-by: Richard Henderson
---
tcg/s390x/
Signed-off-by: Richard Henderson
---
tcg/s390x/tcg-target.c.inc | 122 -
1 file changed, 119 insertions(+), 3 deletions(-)
diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc
index 439ab5a359..ff28d84f95 100644
--- a/tcg/s390x/tcg-target.c.inc
Signed-off-by: Richard Henderson
---
tcg/s390x/tcg-target-con-set.h | 1 +
tcg/s390x/tcg-target.h | 12 ++---
tcg/s390x/tcg-target.c.inc | 93 +-
3 files changed, 99 insertions(+), 7 deletions(-)
diff --git a/tcg/s390x/tcg-target-con-set.h b/tcg/s390x
Signed-off-by: Richard Henderson
---
tcg/s390x/tcg-target.h | 2 +-
tcg/s390x/tcg-target.c.inc | 25 +
2 files changed, 26 insertions(+), 1 deletion(-)
diff --git a/tcg/s390x/tcg-target.h b/tcg/s390x/tcg-target.h
index 3026a4d8c4..efa32f348c 100644
--- a/tcg/s390x/tc
We will shortly need to be able to check facilities beyond the
first 64. Instead of explicitly masking against s390_facilities,
create a HAVE_FACILITY macro that indexes an array.
Reviewed-by: David Hildenbrand
Signed-off-by: Richard Henderson
---
v2: Change name to HAVE_FACILITY (david)
---
t
For usadd, we only have to consider overflow. Since ~B + B == -1,
the maximum value for A that saturates is ~B.
For ussub, we only have to consider underflow. The minimum value
that saturates to 0 from A - B is B.
Signed-off-by: Richard Henderson
---
tcg/tcg-op-vec.c | 37
Signed-off-by: Richard Henderson
---
tcg/s390x/tcg-target-con-set.h | 1 +
tcg/s390x/tcg-target.h | 2 +-
tcg/s390x/tcg-target.c.inc | 20
3 files changed, 22 insertions(+), 1 deletion(-)
diff --git a/tcg/s390x/tcg-target-con-set.h b/tcg/s390x/tcg-target-con-se
Le 03/05/2021 à 19:41, LemonBoy a écrit :
> From: Giuseppe Musacchio
>
> Signed-off-by: Giuseppe Musacchio
> ---
> linux-user/strace.list | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/linux-user/strace.list b/linux-user/strace.list
> index 084048ab96..b81f9964e3 100644
> --- a/li
This is via expansion; don't actually set TCG_TARGET_HAS_cmpsel_vec.
Signed-off-by: Richard Henderson
---
tcg/s390x/tcg-target.c.inc | 24 +++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc
index 178b992b
They are rightly values in the same enumeration.
Reviewed-by: David Hildenbrand
Signed-off-by: Richard Henderson
---
tcg/s390x/tcg-target.h | 28 +++-
1 file changed, 7 insertions(+), 21 deletions(-)
diff --git a/tcg/s390x/tcg-target.h b/tcg/s390x/tcg-target.h
index c61
Le 03/05/2021 à 19:41, LemonBoy a écrit :
> From: Giuseppe Musacchio
>
> The implicit cast from abi_long to size_t may introduce an intermediate
> unwanted sign-extension of the value for 32bit targets running on 64bit
> hosts.
>
> Signed-off-by: Giuseppe Musacchio
> ---
> linux-user/syscall.c
Public bug reported:
hw/remote/mpqemu-link.c:221:36: warning: logical ‘and’ of mutually
exclusive tests is always false [-Wlogical-op]
Source code is
if (msg->cmd >= MPQEMU_CMD_MAX && msg->cmd < 0) {
return false;
}
Maybe better code:
if (msg->cmd >= MPQEMU_CMD_MAX || msg->cm
Public bug reported:
qemu-user fails to emulate clone() (https://linux.die.net/man/2/clone).
The architecture doesn't seem to matter, tho I've mostly been testing
aarch64.
Attached is clone_test.c that demonstrates the problem. Running it natively
looks like this:
$ bin/x86_64/clone_test
The va
clone_test (aarch64)
** Attachment added: "clone_test (aarch64)"
https://bugs.launchpad.net/qemu/+bug/1926996/+attachment/5494469/+files/clone_test
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1
clone_test x86_64 binary
** Description changed:
qemu-user fails to emulate clone() (https://linux.die.net/man/2/clone).
The architecture doesn't seem to matter, tho I've mostly been testing
aarch64.
Attached is clone_test.c that demonstrates the problem. Running it natively
looks li
201 - 300 of 471 matches
Mail list logo
