Re: Let's remove some deprecated stuff

2021-05-03 Thread Alistair Francis
On Mon, May 3, 2021 at 2:49 PM Thomas Huth wrote: > > On 03/05/2021 03.41, Alistair Francis wrote: > > On Thu, Apr 29, 2021 at 8:00 PM Markus Armbruster wrote: > >> > >> If you're cc'ed, you added a section to docs/system/deprecated.rst that > >> is old enough to permit removal. This is *not* a

Re: [Bug 1925496] Re: nvme disk cannot be hotplugged after removal

2021-05-03 Thread Klaus Jensen
On Apr 28 15:00, Max Reitz wrote: On 28.04.21 12:12, Klaus Jensen wrote: On Apr 28 09:31, Oguz Bektas wrote: My understanding is that this is the expected behavior. The reason is that the drive cannot be deleted immediately when the device is hot-unplugged, since it might not be safe (other par

Re: [PATCH 1/4] pc-bios/s390-ccw: Silence warning from Clang by marking panic() as noreturn

2021-05-03 Thread Philippe Mathieu-Daudé
On 5/3/21 6:53 AM, Thomas Huth wrote: > On 02/05/2021 20.57, Philippe Mathieu-Daudé wrote: >> On 5/2/21 7:48 PM, Thomas Huth wrote: >>> When compiling the s390-ccw bios with Clang, the compiler emits a >>> warning: >>> >>>   pc-bios/s390-ccw/main.c:210:5: warning: variable 'found' is used >>> unini

Re: [PATCH 4/4] pc-bios/s390-ccw: Allow building with Clang, too

2021-05-03 Thread David Hildenbrand
On 03.05.21 07:17, Thomas Huth wrote: On 03/05/2021 06.58, Markus Armbruster wrote: Thomas Huth writes: Clang unfortunately does not support generating code for the z900 architecture level and starts with the z10 instead. Thus to be able to support compiling with Clang, we have to check for t

[Bug 1920752] Re: USB SoundCard Passthrough not working on arm64

2021-05-03 Thread Ravishankar
One more point. The solution above is not usb passthrough. I just noticed that qemu needs to be configured for usb passthrough. I am trying that out now Configure with --enable-libusb libusb libusb (for usb passthrough) -- You received this bug notification because you are a member o

Re: [PATCH] block: simplify write-threshold and drop write notifiers

2021-05-03 Thread Vladimir Sementsov-Ogievskiy
30.04.2021 13:04, Max Reitz wrote: On 22.04.21 00:09, Vladimir Sementsov-Ogievskiy wrote: write-notifiers are used only for write-threshold. New code for such purpose should create filters. Let's handle write-threshold simply in generic code and drop write notifiers at all. Also move part of w

Re: [PATCH 4/4] pc-bios/s390-ccw: Allow building with Clang, too

2021-05-03 Thread Markus Armbruster
David Hildenbrand writes: > On 03.05.21 07:17, Thomas Huth wrote: >> On 03/05/2021 06.58, Markus Armbruster wrote: >>> Thomas Huth writes: >>> Clang unfortunately does not support generating code for the z900 architecture level and starts with the z10 instead. Thus to be able to s

Re: [PATCH] block: Drop the sheepdog block driver

2021-05-03 Thread Peter Krempa
On Sat, May 01, 2021 at 09:57:47 +0200, Markus Armbruster wrote: > It was deprecated in commit e1c4269763, v5.2.0. See that commit > message for rationale. > > Signed-off-by: Markus Armbruster > --- > docs/system/deprecated.rst |9 - > docs/system/device-url-syntax.rst.inc |

[PULL 00/23] Trivial branch for 6.1 patches

2021-05-03 Thread Laurent Vivier
branch-for-6.1-pull-request for you to fetch changes up to 9197b5d4b5f163455c891baec531ae73f5d3a73a: hw/rx/rx-gdbsim: Do not accept invalid memory size (2021-05-03 10:07:41 +0200) Trivial patches pull reques

[PULL 10/23] ui: Fix memory leak in qemu_xkeymap_mapping_table()

2021-05-03 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Refactor qemu_xkeymap_mapping_table() to have a single exit point, so we can easily free the memory allocated by XGetAtomName(). This fixes when running a binary configured with --enable-sanitizers: Direct leak of 22 byte(s) in 1 object(s) allocated from: #0

[PULL 05/23] Fix typo in CFI build documentation

2021-05-03 Thread Laurent Vivier
From: Serge Guelton Signed-off-by: Serge Guelton Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210430150745.ga1401...@sguelton.remote.csb> Signed-off-by: Laurent Vivier --- docs/devel/control-flow-integrity.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/

[PULL 01/23] accel: kvm: clarify that extra exit data is hexadecimal

2021-05-03 Thread Laurent Vivier
From: David Edmondson When dumping the extra exit data provided by KVM, make it clear that the data is hexadecimal. At the same time, zero-pad the output. Signed-off-by: David Edmondson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210428142431.266879-1-david.edmond...@oracle.com> Signed

[PULL 08/23] hw/display/qxl: Constify VMStateDescription

2021-05-03 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20210313171150.2122409-3-f4...@amsat.org> Signed-off-by: Laurent Vivier --- hw/display/qxl.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/display/qx

[PULL 02/23] hw/arm/pxa2xx: Declare PCMCIA bus with Kconfig

2021-05-03 Thread Laurent Vivier
From: Philippe Mathieu-Daudé The Intel XScale PXA chipsets provide a PCMCIA controller, which expose a PCMCIA bus. Express this dependency using the Kconfig 'select' expression. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Warner Losh Reviewed-by: Richard Henderson Message-Id: <20210424

[PULL 12/23] hw: Do not include hw/sysbus.h if it is not necessary

2021-05-03 Thread Laurent Vivier
From: Thomas Huth Many files include hw/sysbus.h without needing it. Remove the superfluous include statements. Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210327082804.2259480-1-th...@redhat.com> Signed-off-by: Laurent Vivier --- hw/arm/cubieboard.c

[PULL 15/23] Do not include sysemu/sysemu.h if it's not really necessary

2021-05-03 Thread Laurent Vivier
From: Thomas Huth Stop including sysemu/sysemu.h in files that don't need it. Signed-off-by: Thomas Huth Message-Id: <20210416171314.2074665-2-th...@redhat.com> Signed-off-by: Laurent Vivier --- accel/kvm/kvm-all.c | 1 - accel/tcg/user-exec-stub.c | 1 - backends/hostmem-file.c

[PULL 04/23] hw/pcmcia: Do not register PCMCIA type if not required

2021-05-03 Thread Laurent Vivier
From: Philippe Mathieu-Daudé If the Kconfig 'PCMCIA' value is not selected, it is pointless to build the PCMCIA core components. (Currently only one machine of the ARM targets requires this). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20210424222057.3434

[PULL 06/23] vmstate: Constify some VMStateDescriptions

2021-05-03 Thread Laurent Vivier
From: Keqian Zhu Constify vmstate_ecc_state and vmstate_x86_cpu. Signed-off-by: Keqian Zhu Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20210408140706.23412-1-zhukeqi...@huawei.com> Signed-off-by: Laurent Vivier --- hw/block/ecc.c | 2 +- include

[PATCH 0/2] Drop deprecated lm32 and unicore32

2021-05-03 Thread Markus Armbruster
Markus Armbruster (2): Drop the deprecated lm32 target Drop the deprecated unicore32 target docs/system/deprecated.rst| 16 - docs/system/removed-features.rst | 14 + configure |7 +- default-configs/devices/lm32-sof

[PULL 14/23] hw: Do not include qemu/log.h if it is not necessary

2021-05-03 Thread Laurent Vivier
From: Thomas Huth Many files include qemu/log.h without needing it. Remove the superfluous include statements. Signed-off-by: Thomas Huth Reviewed-by: Alistair Francis Message-Id: <20210328054833.2351597-1-th...@redhat.com> Signed-off-by: Laurent Vivier --- hw/arm/aspeed.c

[PULL 07/23] hw/arm: Constify VMStateDescription

2021-05-03 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20210313171150.2122409-2-f4...@amsat.org> Signed-off-by: Laurent Vivier --- hw/arm/highbank.c | 2 +- hw/arm/pxa2xx_pic.c | 2 +- hw/arm/spitz.c | 4 ++-- hw/arm/strongarm.c

[PULL 13/23] hw: Do not include hw/irq.h if it is not necessary

2021-05-03 Thread Laurent Vivier
From: Thomas Huth Many files include hw/irq.h without needing it. Remove the superfluous include statements. Signed-off-by: Thomas Huth Reviewed-by: Alistair Francis Message-Id: <20210327050236.2232347-1-th...@redhat.com> Signed-off-by: Laurent Vivier --- hw/arm/msf2-soc.c | 1 - h

[PULL 09/23] hw/usb: Constify VMStateDescription

2021-05-03 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20210313171150.2122409-4-f4...@amsat.org> Signed-off-by: Laurent Vivier --- hw/usb/ccid-card-passthru.c | 2 +- hw/usb/dev-smartcard-reader.c | 8 2 files changed, 5 inser

[PULL 11/23] hw: Remove superfluous includes of hw/hw.h

2021-05-03 Thread Laurent Vivier
From: Thomas Huth The include/hw/hw.h header only has a prototype for hw_error(), so it does not make sense to include this in files that do not use this function. Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210326151848.2217216-1-th...@redhat.com> Signed-off-

[PULL 23/23] hw/rx/rx-gdbsim: Do not accept invalid memory size

2021-05-03 Thread Laurent Vivier
From: Philippe Mathieu-Daudé We check the amount of RAM is enough, warn when it is not, but if so we neglect to bail out. Fix that by adding the missing exit() call. Fixes: bda19d7bb56 ("hw/rx: Add RX GDB simulator") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed

[PULL 18/23] Do not include exec/address-spaces.h if it's not really necessary

2021-05-03 Thread Laurent Vivier
From: Thomas Huth Stop including exec/address-spaces.h in files that don't need it. Signed-off-by: Thomas Huth Message-Id: <20210416171314.2074665-5-th...@redhat.com> Signed-off-by: Laurent Vivier --- accel/kvm/kvm-all.c | 1 - accel/tcg/cputlb.c| 1 - hw/acpi/ge

[PULL 03/23] hw/ide: Add Kconfig dependency MICRODRIVE -> PCMCIA

2021-05-03 Thread Laurent Vivier
From: Philippe Mathieu-Daudé The Microdrive Compact Flash can be plugged on a PCMCIA bus. Express the dependency using the 'depends on' Kconfig expression. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Warner Losh Reviewed-by: Richard Henderson Message-Id: <20210424222057.3434459-3-f4...

Re: [PATCH 0/1] Acceptance Tests: bump Avocado version requirement to 87.0

2021-05-03 Thread Philippe Mathieu-Daudé
On 5/3/21 3:50 AM, Cleber Rosa wrote: > - Original Message - >> From: "Philippe Mathieu-Daudé" >> On 4/14/21 6:11 PM, Cleber Rosa wrote: >>> This is being proposed as a separate single patch simply to show >>> that no known regressions have been introduced as far as the >>> acceptance test

[PULL 19/23] mc146818rtc: put it into the 'misc' category

2021-05-03 Thread Laurent Vivier
From: Gan Qixin The category of the mc146818rtc device is not set, put it into the 'misc' category. Signed-off-by: Gan Qixin Reviewed-by: Thomas Huth Message-Id: <20201130083630.2520597-6-ganqi...@huawei.com> Signed-off-by: Laurent Vivier --- hw/rtc/mc146818rtc.c | 1 + 1 file changed, 1 ins

[PULL 16/23] Do not include hw/boards.h if it's not really necessary

2021-05-03 Thread Laurent Vivier
From: Thomas Huth Stop including hw/boards.h in files that don't need it. Signed-off-by: Thomas Huth Message-Id: <20210416171314.2074665-3-th...@redhat.com> Signed-off-by: Laurent Vivier --- accel/tcg/tcg-accel-ops-icount.c | 1 - accel/tcg/tcg-accel-ops-rr.c | 1 - accel/tcg/tcg-accel-op

[PULL 21/23] scripts: fix generation update-binfmts templates

2021-05-03 Thread Laurent Vivier
From: Silvano Cirujano Cuesta This patch fixes the update-binfmts templates being used in the script scripts/qemu-binfmt-conf.sh when the option --debian is used. Fixed issues are: - Typo in flag 'credentials' (previously 'credential'). - Missing flags 'preserve' and 'fix_binary'. Reference: h

[PULL 17/23] Do not include cpu.h if it's not really necessary

2021-05-03 Thread Laurent Vivier
From: Thomas Huth Stop including cpu.h in files that don't need it. Signed-off-by: Thomas Huth Message-Id: <20210416171314.2074665-4-th...@redhat.com> Signed-off-by: Laurent Vivier --- accel/stubs/kvm-stub.c| 1 - accel/stubs/tcg-stub.c| 1 - accel/tcg/cpu-exec-common.

[PULL 22/23] docs: More precisely describe memory-backend-*::id's user

2021-05-03 Thread Laurent Vivier
From: Robert Hoo 'id' of memory-backend-{file,ram} is not only for '-numa''s reference, but also other parameters like '-device nvdimm'. More clearly call out this to avoid misinterpretation. Signed-off-by: Robert Hoo Reviewed-by: Markus Armbruster Message-Id: <1619080922-83527-1-git-send-emai

[PULL 20/23] docs/system: Document the removal of "compat" property for POWER CPUs

2021-05-03 Thread Laurent Vivier
From: Greg Kurz This is just an oversight. Fixes: f518be3aa35b ("target/ppc: Remove "compat" property of server class POWER CPUs") Cc: gr...@kaod.org Signed-off-by: Greg Kurz Reviewed-by: Laurent Vivier Message-Id: <161399328834.51902.14269239378658110394.st...@bahia.lan> Signed-off-by: Laure

Re: [PATCH 1/4] pc-bios/s390-ccw: Silence warning from Clang by marking panic() as noreturn

2021-05-03 Thread Cornelia Huck
On Sun, 2 May 2021 19:48:33 +0200 Thomas Huth wrote: > When compiling the s390-ccw bios with Clang, the compiler emits a warning: > > pc-bios/s390-ccw/main.c:210:5: warning: variable 'found' is used > uninitialized > whenever switch default is taken [-Wsometimes-uninitialized] > defaul

[PATCH 2/2] Drop the deprecated unicore32 target

2021-05-03 Thread Markus Armbruster
Target unicore32 was deprecated in commit 8e4ff4a8d2b, v5.2.0. See there for rationale. Cc: Guan Xuetao Signed-off-by: Markus Armbruster --- docs/system/deprecated.rst|8 - docs/system/removed-features.rst |9 +- configure

Re: [PATCH] spapr: Modify ibm, get-config-addr-info2 to set DEVNUM in PE config address.

2021-05-03 Thread Mahesh J Salgaonkar
On 2021-04-30 07:52:58 Fri, Daniel Henrique Barboza wrote: > > > On 4/29/21 6:02 AM, Mahesh J Salgaonkar wrote: > > On 2021-04-28 22:33:45 Wed, Oliver O'Halloran wrote: > > > On Tue, Apr 27, 2021 at 9:56 PM Mahesh Salgaonkar > > > wrote: > > > > > > > > With upstream kernel, especially after c

[PATCH 2/5] usb/redir: avoid dynamic stack allocation (CVE-2021-3527)

2021-05-03 Thread Gerd Hoffmann
Use autofree heap allocation instead. Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 17f06f34179a..db1a89a7cc92 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -818,7

Re: [PATCH 4/4] pc-bios/s390-ccw: Allow building with Clang, too

2021-05-03 Thread Cornelia Huck
On Mon, 03 May 2021 10:23:20 +0200 Markus Armbruster wrote: > David Hildenbrand writes: > > > On 03.05.21 07:17, Thomas Huth wrote: > >> On 03/05/2021 06.58, Markus Armbruster wrote: > >>> Thomas Huth writes: > >>> > Clang unfortunately does not support generating code for the z900

[PATCH 3/5] usb/mtp: avoid dynamic stack allocation

2021-05-03 Thread Gerd Hoffmann
Use autofree heap allocation instead. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-mtp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index bbb827434482..2a895a73b083 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -907,7 +907,8

Re: [PATCH 3/4] pc-bios/s390-ccw: Silence GCC 11 stringop-overflow warning

2021-05-03 Thread Cornelia Huck
On Sun, 2 May 2021 19:48:35 +0200 Thomas Huth wrote: > From: Philippe Mathieu-Daudé > > When building on Fedora 34 (gcc version 11.0.0 20210210) we get: > > In file included from pc-bios/s390-ccw/main.c:11: > In function ‘memset’, > inlined from ‘boot_setup’ at pc-bios/s390-ccw/main

[PATCH 5/5] usb: limit combined packets to 1 MiB

2021-05-03 Thread Gerd Hoffmann
usb-host and usb-redirect try to batch bulk transfers by combining many small usb packets into a single, large transfer request, to reduce the overhead and improve performance. This patch adds a size limit of 1 MiB for those combined packets to restrict the host resources the guest can bind that w

[PATCH 4/5] usb/xhci: sanity check packet size

2021-05-03 Thread Gerd Hoffmann
Make sure the usb packet size is within the bounds of the endpoint configuration. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 46212b1e695a..7acfb8137bc9 100644 --- a/hw/usb/hcd-xhci.c +++

[PATCH 0/5] usb: fix some memory allocation issues.

2021-05-03 Thread Gerd Hoffmann
Gerd Hoffmann (5): usb/hid: avoid dynamic stack allocation usb/redir: avoid dynamic stack allocation (CVE-2021-3527) usb/mtp: avoid dynamic stack allocation usb/xhci: sanity check packet size usb: limit combined packets to 1 MiB hw/usb/combined-packet.c | 4 +++- hw/usb/dev-hid.c

Re: [PATCH 4/4] pc-bios/s390-ccw: Allow building with Clang, too

2021-05-03 Thread David Hildenbrand
On 03.05.21 11:14, Cornelia Huck wrote: On Mon, 03 May 2021 10:23:20 +0200 Markus Armbruster wrote: David Hildenbrand writes: On 03.05.21 07:17, Thomas Huth wrote: On 03/05/2021 06.58, Markus Armbruster wrote: Thomas Huth writes: Clang unfortunately does not support generating code f

[PATCH 1/5] usb/hid: avoid dynamic stack allocation

2021-05-03 Thread Gerd Hoffmann
Use autofree heap allocation instead. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-hid.c | 2 +- hw/usb/dev-wacom.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index fc39bab79f94..1c7ae97c3033 100644 --- a/hw/usb/dev-hid.c +++ b/hw/

Re: [PATCH 04/15] gitlab-ci: Replace YAML anchors by extends (acceptance_test_job)

2021-05-03 Thread Thomas Huth
On 19/04/2021 01.34, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé 'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends Reviewed-by: Wainer dos Santos Moschetta Signed-off-by: Philippe Mathi

Re: [PATCH 4/4] pc-bios/s390-ccw: Allow building with Clang, too

2021-05-03 Thread Cornelia Huck
On Mon, 3 May 2021 11:17:54 +0200 David Hildenbrand wrote: > On 03.05.21 11:14, Cornelia Huck wrote: > > On Mon, 03 May 2021 10:23:20 +0200 > > Markus Armbruster wrote: > > > >> David Hildenbrand writes: > >> > >>> On 03.05.21 07:17, Thomas Huth wrote: > On 03/05/2021 06.58, Markus

Re: [PATCH 2/5] usb/redir: avoid dynamic stack allocation (CVE-2021-3527)

2021-05-03 Thread Philippe Mathieu-Daudé
On 5/3/21 11:14 AM, Gerd Hoffmann wrote: > Use autofree heap allocation instead. > > Signed-off-by: Gerd Hoffmann Fixes: 4f4321c11ff ("usb: use iovecs in USBPacket") Reviewed-by: Philippe Mathieu-Daudé > --- > hw/usb/redirect.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

Re: [PATCH 3/4] pc-bios/s390-ccw: Silence GCC 11 stringop-overflow warning

2021-05-03 Thread Philippe Mathieu-Daudé
On 5/3/21 11:00 AM, Cornelia Huck wrote: > On Sun, 2 May 2021 19:48:35 +0200 > Thomas Huth wrote: > >> From: Philippe Mathieu-Daudé >> >> When building on Fedora 34 (gcc version 11.0.0 20210210) we get: >> >> In file included from pc-bios/s390-ccw/main.c:11: >> In function ‘memset’, >>

Re: [PATCH 1/2] Drop the deprecated lm32 target

2021-05-03 Thread Michael Walle
Am 2021-05-03 10:40, schrieb Markus Armbruster: Target lm32 was deprecated in commit d8498005122, v5.2.0. See there for rationale. Some of its code lives on in device models derived from milkymist ones: hw/char/digic-uart.c and hw/display/bcm2835_fb.c. yaay ;) Cc: Michael Walle Signed-off-

Re: [PATCH v2 00/16] virtio-gpu: split into two devices.

2021-05-03 Thread Gerd Hoffmann
On Fri, Apr 30, 2021 at 07:32:58PM +0400, Marc-André Lureau wrote: > Hi > > On Fri, Apr 30, 2021 at 4:23 PM Gerd Hoffmann wrote: > > > Currently we have one virtio-gpu device. Problem with this approach is > > that if you compile a full-featured qemu you'll get a virtio-gpu device > > which dep

Re: [PATCH 4/4] pc-bios/s390-ccw: Allow building with Clang, too

2021-05-03 Thread Thomas Huth
On 03/05/2021 11.14, Cornelia Huck wrote: On Mon, 03 May 2021 10:23:20 +0200 Markus Armbruster wrote: David Hildenbrand writes: On 03.05.21 07:17, Thomas Huth wrote: On 03/05/2021 06.58, Markus Armbruster wrote: Thomas Huth writes: Clang unfortunately does not support generating code

Re: [PATCH 3/4] pc-bios/s390-ccw: Silence GCC 11 stringop-overflow warning

2021-05-03 Thread Thomas Huth
On 03/05/2021 11.30, Philippe Mathieu-Daudé wrote: On 5/3/21 11:00 AM, Cornelia Huck wrote: On Sun, 2 May 2021 19:48:35 +0200 Thomas Huth wrote: From: Philippe Mathieu-Daudé When building on Fedora 34 (gcc version 11.0.0 20210210) we get: In file included from pc-bios/s390-ccw/main.c:1

[Bug 811683] Re: 7400, 7410, 7450 cpus vector have wrong exception prefix at reset

2021-05-03 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/85 ** Changed in: qemu Status: Triaged => Expired ** Bug wa

[Bug 697510] Re: Machine shut off after tons of lsi_scsi: error: MSG IN data too long

2021-05-03 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/84 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 645662] Re: QEMU x87 emulation of trig and other complex ops is only at 64-bit precision, not 80-bit

2021-05-03 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/83 ** Changed in: qemu Status: Confirmed => Expired ** Bug

Re: [PULL 37/64] block/snapshot: Fix fallback

2021-05-03 Thread Kevin Wolf
Am 01.05.2021 um 00:30 hat Peter Maydell geschrieben: > On Mon, 7 Sept 2020 at 12:11, Kevin Wolf wrote: > > > > From: Max Reitz > > > > If the top node's driver does not provide snapshot functionality and we > > want to fall back to a node down the chain, we need to snapshot all > > non-COW child

Re: [PULL 37/64] block/snapshot: Fix fallback

2021-05-03 Thread Max Reitz
On 03.05.21 11:40, Kevin Wolf wrote: Am 01.05.2021 um 00:30 hat Peter Maydell geschrieben: On Mon, 7 Sept 2020 at 12:11, Kevin Wolf wrote: From: Max Reitz If the top node's driver does not provide snapshot functionality and we want to fall back to a node down the chain, we need to snapshot

Re: [PATCH 04/15] gitlab-ci: Replace YAML anchors by extends (acceptance_test_job)

2021-05-03 Thread Philippe Mathieu-Daudé
On 5/3/21 11:22 AM, Thomas Huth wrote: > On 19/04/2021 01.34, Philippe Mathieu-Daudé wrote: >> From: Philippe Mathieu-Daudé >> >> 'extends' is an alternative to using YAML anchors >> and is a little more flexible and readable. See: >> https://docs.gitlab.com/ee/ci/yaml/#extends >> >> Reviewed-by:

Re: [PATCH 0/5] usb: fix some memory allocation issues.

2021-05-03 Thread Philippe Mathieu-Daudé
On 5/3/21 11:14 AM, Gerd Hoffmann wrote: > > > Gerd Hoffmann (5): > usb/hid: avoid dynamic stack allocation > usb/redir: avoid dynamic stack allocation (CVE-2021-3527) > usb/mtp: avoid dynamic stack allocation > usb/xhci: sanity check packet size > usb: limit combined packets to 1 MiB

Re: [PATCH 3/4] pc-bios/s390-ccw: Silence GCC 11 stringop-overflow warning

2021-05-03 Thread Philippe Mathieu-Daudé
On 5/3/21 11:31 AM, Thomas Huth wrote: > On 03/05/2021 11.30, Philippe Mathieu-Daudé wrote: >> On 5/3/21 11:00 AM, Cornelia Huck wrote: >>> On Sun,  2 May 2021 19:48:35 +0200 >>> Thomas Huth wrote: >>> From: Philippe Mathieu-Daudé When building on Fedora 34 (gcc version 11.0.0 2021

[PATCH] block/snapshot: Clarify goto fallback behavior

2021-05-03 Thread Max Reitz
In the bdrv_snapshot_goto() fallback code, we work with a pointer to either bs->file or bs->backing. We close that child, close the node (with .bdrv_close()), apply the snapshot on the child node, and then re-open the node (with .bdrv_open()). In order for .bdrv_open() to attach the same child no

Re: [PATCH 4/4] pc-bios/s390-ccw: Allow building with Clang, too

2021-05-03 Thread Cornelia Huck
On Mon, 3 May 2021 11:31:00 +0200 Thomas Huth wrote: > On 03/05/2021 11.14, Cornelia Huck wrote: > > On Mon, 03 May 2021 10:23:20 +0200 > > Markus Armbruster wrote: > > > >> David Hildenbrand writes: > >> > >>> On 03.05.21 07:17, Thomas Huth wrote: > On 03/05/2021 06.58, Markus Armb

Re: [PATCH 2/5] usb/redir: avoid dynamic stack allocation (CVE-2021-3527)

2021-05-03 Thread Philippe Mathieu-Daudé
On 5/3/21 11:27 AM, Philippe Mathieu-Daudé wrote: > On 5/3/21 11:14 AM, Gerd Hoffmann wrote: >> Use autofree heap allocation instead. >> >> Signed-off-by: Gerd Hoffmann > > Fixes: 4f4321c11ff ("usb: use iovecs in USBPacket") > Reviewed-by: Philippe Mathieu-Daudé Hmm there is still another use:

Re: [PATCH 4/4] pc-bios/s390-ccw: Allow building with Clang, too

2021-05-03 Thread Cornelia Huck
On Sun, 2 May 2021 19:48:36 +0200 Thomas Huth wrote: > Clang unfortunately does not support generating code for the z900 > architecture level and starts with the z10 instead. Thus to be able > to support compiling with Clang, we have to check for the supported > compiler flags. The disadvantage

[Bug 922076] Re: doesn't clear screen on boot

2021-05-03 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/87 ** Changed in: qemu Status: Triaged => Expired ** Bug wa

[Bug 925405] Re: VNC server does not work with Mac Screen Sharing

2021-05-03 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/88 ** Changed in: qemu Status: Confirmed => Expired ** Bug

Re: [PATCH v2 2/3] hw/pci-host/raven: Manually reset the OR_IRQ device

2021-05-03 Thread Philippe Mathieu-Daudé
On 5/2/21 10:45 PM, Peter Maydell wrote: > On Sun, 2 May 2021 at 21:31, Philippe Mathieu-Daudé wrote: >> >> The OR_IRQ device is bus-less, thus isn't reset automatically. >> Add the raven_pcihost_reset() handler to manually reset the OR IRQ. >> >> Fixes: f40b83a4e31 ("40p: use OR gate to wire up r

[Bug 812398] Re: powerpc 7450 MMU initialization broken

2021-05-03 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/86 ** Changed in: qemu Status: Triaged => Expired ** Bug wa

[Bug 721825] Re: VDI block driver bugs

2021-05-03 Thread Thomas Huth
Hi Stefan (Weil) - this bug is now assigned to you since more than 10 years ... do you still plan to tackle it at some point in time? If not, I'd suggest to unassign it. Also, it's been four years again since the last comment ... should we maybe close this as "Wont Fix" ? ** Changed in: qemu

Re: [PATCH 4/4] pc-bios/s390-ccw: Allow building with Clang, too

2021-05-03 Thread Christian Borntraeger
On 03.05.21 11:31, Thomas Huth wrote: On 03/05/2021 11.14, Cornelia Huck wrote: On Mon, 03 May 2021 10:23:20 +0200 Markus Armbruster wrote: David Hildenbrand writes: On 03.05.21 07:17, Thomas Huth wrote: On 03/05/2021 06.58, Markus Armbruster wrote: Thomas Huth writes: Clang unfortu

Re: [PULL 37/64] block/snapshot: Fix fallback

2021-05-03 Thread Kevin Wolf
Am 03.05.2021 um 11:45 hat Max Reitz geschrieben: > On 03.05.21 11:40, Kevin Wolf wrote: > > Am 01.05.2021 um 00:30 hat Peter Maydell geschrieben: > > > On Mon, 7 Sept 2020 at 12:11, Kevin Wolf wrote: > > > > > > > > From: Max Reitz > > > > > > > > If the top node's driver does not provide snap

[Bug 1776478] Re: Getting qemu: uncaught target signal 6 when running lv2 plugin cross-compilation

2021-05-03 Thread Peter Maydell
Well, first try with QEMU 6.0 and see if it's still present... -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1776478 Title: Getting qemu: uncaught target signal 6 when running lv2 plugin cross-

Re: [PATCH 1/2] Drop the deprecated lm32 target

2021-05-03 Thread Markus Armbruster
Michael Walle writes: > Am 2021-05-03 10:40, schrieb Markus Armbruster: >> Target lm32 was deprecated in commit d8498005122, v5.2.0. See there >> for rationale. >> >> Some of its code lives on in device models derived from milkymist >> ones: hw/char/digic-uart.c and hw/display/bcm2835_fb.c. > >

[qemu-web PATCH] Update website to point to the new bug tracker at GitLab instead of Launchpad

2021-05-03 Thread Thomas Huth
We've started migrating the bug tickets from Launchpad to GitLab, so it does not make too much sense anymore that users open new tickets in the old system. Let's direct them now to the GitLab tracker instead. Signed-off-by: Thomas Huth --- contribute.md | 3 ++- contribute/report-a-

Re: [PATCH 0/2] Drop deprecated lm32 and unicore32

2021-05-03 Thread Markus Armbruster
Forgot to mention it's based on Thomas's "[PATCH] Remove the deprecated moxie target". Based-on: <20210430160355.698194-1-th...@redhat.com>

Re: Let's remove some deprecated stuff

2021-05-03 Thread Markus Armbruster
Peter Maydell writes: > On Thu, 29 Apr 2021 at 12:19, Thomas Huth wrote: >> >> On 29/04/2021 11.59, Markus Armbruster wrote: >> > If you're cc'ed, you added a section to docs/system/deprecated.rst that >> > is old enough to permit removal. This is *not* a demand to remove, it's >> > a polite re

Re: [PATCH 0/2] Drop deprecated lm32 and unicore32

2021-05-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210503084034.3804963-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210503084034.3804963-1-arm...@redhat.com Subject: [PATCH 0/2] Drop deprecated lm32 and

[PULL 00/10] Gitlab-CI, qtest, moxie removal and misc patches

2021-05-03 Thread Thomas Huth
Hi Peter, the following changes since commit 53c5433e84e8935abed8e91d4a2eb813168a0ecf: Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210501' into staging (2021-05-02 12:02:46 +0100) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-requ

[PULL 02/10] tests/docker/dockerfiles: Add ccache to containers where it was missing

2021-05-03 Thread Thomas Huth
Make sure that ccache is available in all containers. Message-Id: <20210414081907.871437-2-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/docker/dockerfiles/alpine.docker | 1 + tests/docker/dockerfiles/fedora-i386-cross.docker | 1 + tests/docker/dockerfiles/fedora-win32-cr

[PULL 04/10] gitlab-ci: Replace YAML anchors by extends (container_job)

2021-05-03 Thread Thomas Huth
From: Philippe Mathieu-Daudé 'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Message-Id: <2021

[PULL 10/10] util/compatfd.c: Replaced a malloc call with g_malloc.

2021-05-03 Thread Thomas Huth
From: Mahmoud Mandour Replaced a call to malloc() and its respective call to free() with g_malloc() and g_free(). g_malloc() is preferred more than g_try_* functions, which return NULL on error, when the size of the requested allocation is small. This is because allocating few bytes should not

[PULL 03/10] include/sysemu: Poison all accelerator CONFIG switches in common code

2021-05-03 Thread Thomas Huth
We are already poisoning CONFIG_KVM since this switch is not working in common code. Do the same with the other accelerator switches, too (except for CONFIG_TCG, which is special, since it is also defined in config-host.h). Message-Id: <20210414112004.943383-2-th...@redhat.com> Signed-off-by: Thom

[PULL 06/10] gitlab-ci: Replace YAML anchors by extends (native_test_job)

2021-05-03 Thread Thomas Huth
From: Philippe Mathieu-Daudé 'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends Reviewed-by: Wainer dos Santos Moschetta Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210418233448.1267991-4-f4...

[PULL 05/10] gitlab-ci: Replace YAML anchors by extends (native_build_job)

2021-05-03 Thread Thomas Huth
From: Philippe Mathieu-Daudé 'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends Reviewed-by: Wainer dos Santos Moschetta Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210418233448.1267991-3-f4...

Re: [qemu-web PATCH] Update website to point to the new bug tracker at GitLab instead of Launchpad

2021-05-03 Thread Philippe Mathieu-Daudé
Hi Thomas, On 5/3/21 12:30 PM, Thomas Huth wrote: > We've started migrating the bug tickets from Launchpad to GitLab, so > it does not make too much sense anymore that users open new tickets > in the old system. Let's direct them now to the GitLab tracker instead. We should document the user has

[PULL 01/10] Remove the deprecated moxie target

2021-05-03 Thread Thomas Huth
There are no known users of this CPU anymore, and there are no binaries available online which could be used for regression tests, so the code has likely completely bit-rotten already. It's been marked as deprecated since two releases now and nobody spoke up that there is still a need to keep it, t

[PULL 07/10] libqos/qgraph: fix "UNAVAILBLE" typo

2021-05-03 Thread Thomas Huth
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Message-Id: <20210412143437.727560-2-stefa...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Acked-by: Paolo Bonzini Signed-off-by: Thomas Huth --- tests/qtest/libqos/qgraph.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[PULL 08/10] docs/devel/qgraph: add troubleshooting information

2021-05-03 Thread Thomas Huth
From: Stefan Hajnoczi It can be tricky to troubleshoot qos-test when a test won't execute. Add an explanation of how to trace qgraph node connectivity and find which node has the problem. Signed-off-by: Stefan Hajnoczi Message-Id: <20210412143437.727560-3-stefa...@redhat.com> Acked-by: Paolo Bo

Re: [PATCH 2/2] Drop the deprecated unicore32 target

2021-05-03 Thread Thomas Huth
On 03/05/2021 10.40, Markus Armbruster wrote: Target unicore32 was deprecated in commit 8e4ff4a8d2b, v5.2.0. See there for rationale. Cc: Guan Xuetao Signed-off-by: Markus Armbruster --- [...] diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index e914d34298..2592c4fbd5

[PULL 09/10] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm

2021-05-03 Thread Thomas Huth
From: Stefan Hajnoczi Some downstreams rename the QEMU binary to "qemu-kvm". This breaks qtest_get_arch(), which attempts to parse the target architecture from the QTEST_QEMU_BINARY environment variable. Print an error instead of returning the architecture "kvm". Things fail in weird ways when t

Re: [qemu-web PATCH] Update website to point to the new bug tracker at GitLab instead of Launchpad

2021-05-03 Thread Thomas Huth
On 03/05/2021 12.47, Philippe Mathieu-Daudé wrote: Hi Thomas, On 5/3/21 12:30 PM, Thomas Huth wrote: We've started migrating the bug tickets from Launchpad to GitLab, so it does not make too much sense anymore that users open new tickets in the old system. Let's direct them now to the GitLab tr

[PATCH] hw/arm/raspi: Remove deprecated raspi2/raspi3 aliases

2021-05-03 Thread Philippe Mathieu-Daudé
Remove the raspi2/raspi3 machine aliases, deprecated since commit 155e1c82ed0. Signed-off-by: Philippe Mathieu-Daudé --- docs/system/deprecated.rst | 7 --- docs/system/removed-features.rst | 7 +++ hw/arm/raspi.c | 2 -- 3 files changed, 7 insertions(+), 9 deleti

[PATCH v4 2/5] qemu-iotests: allow passing unittest.main arguments to the test scripts

2021-05-03 Thread Paolo Bonzini
Python test scripts that use unittest consist of multiple tests. unittest.main allows selecting which tests to run, but currently this is not possible because the iotests wrapper ignores sys.argv. unittest.main command line options also allow the user to pick the desired options for verbosity, fai

[PATCH v4 1/5] qemu-iotests: do not buffer the test output

2021-05-03 Thread Paolo Bonzini
Instead of buffering the test output into a StringIO, patch it on the fly by wrapping sys.stdout's write method. This can be done unconditionally, even if using -d, which makes execute_unittest a bit simpler. Signed-off-by: Paolo Bonzini Reviewed-by: Vladimir Sementsov-Ogievskiy Tested-by: Eman

[PATCH v4 5/5] qemu-iotests: fix case of SOCK_DIR already in the environment

2021-05-03 Thread Paolo Bonzini
Due to a typo, in this case the SOCK_DIR was not being created. Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Paolo Bonzini Tested-by: Emanuele Giuseppe Esposito Message-Id: <20210323181928.311862-6-pbonz...@redhat.com> --- tests/qemu-iotests/testenv.py | 2 +- 1 file changed, 1 ins

[PATCH v4 3/5] qemu-iotests: move command line and environment handling from TestRunner to TestEnv

2021-05-03 Thread Paolo Bonzini
In the next patch, "check" will learn how to execute a test script without going through TestRunner. To enable this, keep only the text output and subprocess handling in the TestRunner; move into TestEnv the logic to prepare for running a subprocess. Reviewed-by: Vladimir Sementsov-Ogievskiy Sig

[PATCH v4 4/5] qemu-iotests: let "check" spawn an arbitrary test command

2021-05-03 Thread Paolo Bonzini
Right now there is no easy way for "check" to print a reproducer command. Because such a reproducer command line would be huge, we can instead teach check to start a command of our choice. This can be for example a Python unit test with arguments to only run a specific subtest. Move the trailing

Re: [PULL v2 00/31] target/hexagon patch queue

2021-05-03 Thread Peter Maydell
On Sun, 2 May 2021 at 15:44, Richard Henderson wrote: > > The following changes since commit 8f860d2633baf9c2b6261f703f86e394c6bc22ca: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2021-04-30' > into staging (2021-04-30 16:02:00 +0100) > > are available in the Git repository a

  1   2   3   4   5   >