[Bug 1785902] Re: local/9pfs: Too many levels of symbolic links

2021-05-02 Thread Christian Schoenebeck
Enrico, with security_model=mapped (a.k.a. security_model=mapped-xattr) 9p is not following symlinks on host. That's the expected behaviour. There are 2 distinct models: security_model=passthrough uses the ownership information, permissions and symlink info etc. directly from the host's file syst

Re: [PATCH v2 0/8] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers

2021-05-02 Thread Mark Cave-Ayland
On 28/04/2021 13:50, Philippe Mathieu-Daudé wrote: Hi, The floppy disc controllers pulls in irrelevant devices (sysbus in an ISA-only machine, ISA bus + isa devices on a sysbus-only machine). This series clean that by extracting each device in its own file, adding the corresponding Kconfig sym

Re: [PATCH v2 0/4] hw/sparc: Kconfig fixes to build with/without the leon3 machine

2021-05-02 Thread Mark Cave-Ayland
On 28/04/2021 15:16, Philippe Mathieu-Daudé wrote: Missing review: 2-4 Since v1: - move cpu_check_irqs() to target/sparc/ (rth) This series fixes link failure when building either the leon3 machine or the sun4m ones. The problem is we have hardware specific code in the architectural translati

Re: [PATCH] pc-bios/s390-ccw: Silence GCC 11 stringop-overflow warning

2021-05-02 Thread Thomas Huth
On 22/04/2021 16.59, Philippe Mathieu-Daudé wrote: When building on Fedora 34 (gcc version 11.0.0 20210210) we get: In file included from pc-bios/s390-ccw/main.c:11: In function ‘memset’, inlined from ‘boot_setup’ at pc-bios/s390-ccw/main.c:185:5, inlined from ‘main’ at pc-bi

Re: [PATCH] pc-bios/s390-ccw: Silence GCC 11 stringop-overflow warning

2021-05-02 Thread Thomas Huth
On 02/05/2021 12.39, Thomas Huth wrote: On 22/04/2021 16.59, Philippe Mathieu-Daudé wrote: When building on Fedora 34 (gcc version 11.0.0 20210210) we get:    In file included from pc-bios/s390-ccw/main.c:11:    In function ‘memset’,    inlined from ‘boot_setup’ at pc-bios/s390-ccw/main.c:1

[PATCH] pc-bios/s390-ccw: Fix the cc-option macro in the Makefile

2021-05-02 Thread Thomas Huth
The cc-option macro is not doing what it should - compared with the original from the rules.mak file that got removed with commit 660f793093 ("Makefile: inline the relevant parts of rules.mak"), the arguments got changed and thus the macro is rather doubling the QEMU_CFLAGS than adding the flag tha

Re: [PATCH-for-6.1 0/3] hw/sparc/sun4m: Introduce Sun4mMachineClass to access sun4m_hwdefs

2021-05-02 Thread Mark Cave-Ayland
On 07/04/2021 18:53, Philippe Mathieu-Daudé wrote: Hi Mark, This series QOM'ify a bit more the sun4m machines. I need it for a further memory maxsize check. It is mostly code movement (and the diff-stat is good). Philippe Mathieu-Daudé (3): hw/sparc/sun4m: Introduce TYPE_SUN4M_MACHINE and S

Re: [PULL 0/5] tcg patch queue

2021-05-02 Thread Peter Maydell
On Sat, 1 May 2021 at 19:51, Richard Henderson wrote: > > The following changes since commit 8f860d2633baf9c2b6261f703f86e394c6bc22ca: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2021-04-30' > into staging (2021-04-30 16:02:00 +0100) > > are available in the Git repository a

[PATCH] block/rbd: Add support for rbd image encryption

2021-05-02 Thread Or Ozeri
Starting from ceph Pacific, RBD has built-in support for image-level encryption. Currently supported formats are LUKS version 1 and 2. There are 2 new relevant librbd APIs for controlling encryption, both expect an open image context: rbd_encryption_format: formats an image (i.e. writes the LUKS

Re: [PATCH v3 3/4] hw/arm: sabrelite: Connect the Ethernet PHY at address 6

2021-05-02 Thread Guenter Roeck
On 5/1/21 6:37 PM, Guenter Roeck wrote: > On 5/1/21 5:24 PM, Bin Meng wrote: >> On Sun, May 2, 2021 at 7:21 AM Guenter Roeck wrote: >>> >>> On 5/1/21 2:40 PM, Philippe Mathieu-Daudé wrote: On 5/1/21 10:12 PM, Guenter Roeck wrote: > On 4/30/21 9:28 PM, Bin Meng wrote: >> On Fri, Apr 30

Re: [PATCH] block/rbd: Add support for rbd image encryption

2021-05-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210502073617.2978836-1-...@il.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210502073617.2978836-1-...@il.ibm.com Subject: [PATCH] block/rbd: Add support for rbd image

[Bug 1785485] Re: Mouse moves erratically when using scroll wheel on Windows NT 4, Windows 95, and Windows 3.1 guests

2021-05-02 Thread John Arbuckle
After doing tests with Windows 95, 3,1, NT 4.0, and 2000 I can say this bug appears to be fixed. ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net

[PULL v2 01/31] target/hexagon: translation changes

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Change cpu_ldl_code to translator_ldl. Don't end the TB after every packet when HEX_DEBUG is on. Make gen_check_store_width a simple call. Reported-by: Richard Henderson < Signed-off-by: Taylor Simpson Message-Id: <1615783984-25918-1-git-send-email-tsimp...@quicinc.com> Sig

[PULL v2 00/31] target/hexagon patch queue

2021-05-02 Thread Richard Henderson
The following changes since commit 8f860d2633baf9c2b6261f703f86e394c6bc22ca: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2021-04-30' into staging (2021-04-30 16:02:00 +0100) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-he

[PULL v2 11/31] Hexagon (target/hexagon) decide if pred has been written at TCG gen time

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Multiple writes to the same preg are and'ed together. Rather than generating a runtime check, we can determine at TCG generation time if the predicate has previously been written in the packet. Test added to tests/tcg/hexagon/misc.c Suggested-by: Richard Henderson Signed-

[PULL v2 10/31] Hexagon (target/hexagon) properly generate TB end for DISAS_NORETURN

2021-05-02 Thread Richard Henderson
From: Taylor Simpson When exiting a TB, generate all the code before returning from hexagon_tr_translate_packet so that nothing needs to be done in hexagon_tr_tb_stop. Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1617930474-31979-6-

[PULL v2 02/31] target/hexagon: remove unnecessary checks in find_iclass_slots

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Reported-by: Richard Henderson < Signed-off-by: Taylor Simpson Message-Id: <1615784037-26129-1-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/iclass.c | 4 1 file changed, 4 deletions(-) diff --git a/target/hexagon/iclass.c b

[PULL v2 15/31] Hexagon (target/hexagon) use softfloat default NaN and tininess

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1617930474-31979-11-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/cpu.c | 5 target/hexagon/op_helper.c

[PULL v2 04/31] target/hexagon: fix typo in comment

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Taylor Simpson Message-Id: <1615784115-26559-1-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/targe

[PULL v2 13/31] Hexagon (target/hexagon) remove unused carry_from_add64 function

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1617930474-31979-9-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/arch.h | 1 - target/hexagon/macros.h | 2 -- target/

[PULL v2 08/31] Hexagon (target/hexagon) remove unnecessary inline directives

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1617930474-31979-4-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/cpu.c | 9 - target/hexagon/decode.c|

[PULL v2 19/31] Hexagon (target/hexagon) cleanup reg_field_info definition

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Include size in declaration Remove {0, 0} entry Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1617930474-31979-15-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/reg_fie

[PULL v2 05/31] target/hexagon: remove unnecessary semicolons

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Reviewed-by: Philippe Mathieu-Daudé Reported-by: Richard Henderson < Signed-off-by: Taylor Simpson Message-Id: <1615784100-26459-1-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/gen_tcg.h | 4 ++-- 1 file changed, 2 insertions(+),

[PULL v2 16/31] Hexagon (target/hexagon) replace float32_mul_pow2 with float32_scalbn

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1617930474-31979-12-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/arch.c | 28 +++- 1 file changed

[PULL v2 03/31] target/hexagon: Change DECODE_MAPPED_REG operand name to OPNUM

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Reported-by: Richard Henderson < Signed-off-by: Taylor Simpson Message-Id: <1615784049-26215-1-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/decode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/h

[PULL v2 23/31] Hexagon (target/hexagon) add F2_sfinvsqrta

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Rd32,Pe4 = sfinvsqrta(Rs32) Square root approx The helper packs the 2 32-bit results into a 64-bit value, and the fGEN_TCG override unpacks them into the proper results. Test cases in tests/tcg/hexagon/multi_result.c FP exception tests added to tests/tcg/hexagon/fpstuff

[PULL v2 07/31] Hexagon (target/hexagon) cleanup gen_log_predicated_reg_write_pair

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Similar to previous cleanup of gen_log_predicated_reg_write Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1617930474-31979-3-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/genptr.c | 27 +--

[PULL v2 17/31] Hexagon (target/hexagon) use softfloat for float-to-int conversions

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Use the proper return for helpers that convert to unsigned Remove target/hexagon/conv_emu.[ch] Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1617930474-31979-13-git-send-email-tsimp...@quicinc.com> Signed-off-by:

[PULL v2 06/31] Hexagon (target/hexagon) TCG generation cleanup

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Simplify TCG generation of hex_reg_written Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1617930474-31979-2-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/genptr.c | 14

[PULL v2 24/31] Hexagon (target/hexagon) add A5_ACS (vacsh)

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Rxx32,Pe4 = vacsh(Rss32, Rtt32) Add compare and select elements of two vectors Test cases in tests/tcg/hexagon/multi_result.c Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1617930474-31979-20-git-send-email-tsimp...@quicinc.com> Signed-off-

[PULL v2 09/31] Hexagon (target/hexagon) use env_archcpu and env_cpu

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Remove hexagon_env_get_cpu and replace with env_archcpu Replace CPU(hexagon_env_get_cpu(env)) with env_cpu(env) Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1617930474-31979-5-git-send-email-tsimp...@quicinc.com

[PULL v2 21/31] Hexagon (target/hexagon) compile all debug code

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Change #if HEX_DEBUG to if (HEX_DEBUG) so the debug code doesn't bit rot Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1617930474-31979-17-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderso

[PULL v2 18/31] Hexagon (target/hexagon) cleanup ternary operators in semantics

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Change (cond ? (res = x) : (res = y)) to res = (cond ? x : y) This makes the semnatics easier to for idef-parser to deal with The following instructions are impacted C2_any8 C2_all8 C2_mux C2_muxii C2_muxir C2_muxri Signed-off-by: Taylor Simpson R

[PULL v2 28/31] Hexagon (target/hexagon) bit reverse (brev) addressing

2021-05-02 Thread Richard Henderson
From: Taylor Simpson The following instructions are added L2_loadrub_pbr Rd32 = memub(Rx32++Mu2:brev) L2_loadrb_pbr Rd32 = memb(Rx32++Mu2:brev) L2_loadruh_pbr Rd32 = memuh(Rx32++Mu2:brev) L2_loadrh_pbr Rd32 = memh(Rx32++Mu2:brev) L2_loadri

[PULL v2 14/31] Hexagon (target/hexagon) change type of softfloat_roundingmodes

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1617930474-31979-10-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/arch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PULL v2 26/31] Hexagon (target/hexagon) add A4_addp_c/A4_subp_c

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Rdd32 = add(Rss32, Rtt32, Px4):carry Add with carry Rdd32 = sub(Rss32, Rtt32, Px4):carry Sub with carry Test cases in tests/tcg/hexagon/multi_result.c Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1617930474-31979-22-git-send-email-tsim

[PULL v2 12/31] Hexagon (target/hexagon) change variables from int to bool when appropriate

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <1617930474-31979-8-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/cpu_bits.h | 2 +-

[PULL v2 29/31] Hexagon (target/hexagon) load and unpack bytes instructions

2021-05-02 Thread Richard Henderson
From: Taylor Simpson The following instructions are added L2_loadbzw2_io Rd32 = memubh(Rs32+#s11:1) L2_loadbzw4_io Rdd32 = memubh(Rs32+#s11:1) L2_loadbsw2_io Rd32 = membh(Rs32+#s11:1) L2_loadbsw4_io Rdd32 = membh(Rs32+#s11:1) L4_loadbzw2_ur

[PULL v2 20/31] Hexagon (target/hexagon) move QEMU_GENERATE to only be on during macros.h

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1617930474-31979-16-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/genptr.c | 3 ++- 1 file changed, 2 insertions(+),

[PULL v2 25/31] Hexagon (target/hexagon) add A6_vminub_RdP

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Rdd32,Pe4 = vminub(Rtt32, Rss32) Vector min of bytes Test cases in tests/tcg/hexagon/multi_result.c Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1617930474-31979-21-git-send-email-tsimp...@quicinc.com> Signed-off-by: Richard Henderson ---

[PULL v2 22/31] Hexagon (target/hexagon) add F2_sfrecipa instruction

2021-05-02 Thread Richard Henderson
From: Taylor Simpson Rd32,Pe4 = sfrecipa(Rs32, Rt32) Recripocal approx Test cases in tests/tcg/hexagon/multi_result.c FP exception tests added to tests/tcg/hexagon/fpstuff.c Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1617930474-31979-18-git-send-email-tsimp.

[PULL v2 30/31] Hexagon (target/hexagon) load into shifted register instructions

2021-05-02 Thread Richard Henderson
From: Taylor Simpson The following instructions are added L2_loadalignb_io Ryy32 = memb_fifo(Rs32+#s11:1) L2_loadalignh_io Ryy32 = memh_fifo(Rs32+#s11:1) L4_loadalignb_ur Ryy32 = memb_fifo(Rt32<<#u2+#U6) L4_loadalignh_ur Ryy32 = memh_fifo(Rt32<<

[PULL v2 31/31] Hexagon (target/hexagon) CABAC decode bin

2021-05-02 Thread Richard Henderson
From: Taylor Simpson The following instruction is added S2_cabacdecbinRdd32=decbin(Rss32,Rtt32) Test cases added to tests/tcg/hexagon/misc.c Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <1617930474-31979-27-git-send-email-tsimp...@quicinc.com> Signe

[PULL v2 27/31] Hexagon (target/hexagon) circular addressing

2021-05-02 Thread Richard Henderson
From: Taylor Simpson The following instructions are added L2_loadrub_pci Rd32 = memub(Rx32++#s4:0:circ(Mu2)) L2_loadrb_pci Rd32 = memb(Rx32++#s4:0:circ(Mu2)) L2_loadruh_pci Rd32 = memuh(Rx32++#s4:1:circ(Mu2)) L2_loadrh_pci Rd32 = memh(Rx32++#s

Re: [PATCH v2 1/2] hw/timer/etraxfs_timer: Convert to 3-phase reset (Resettable interface)

2021-05-02 Thread Philippe Mathieu-Daudé
Hi Edgar, +Damien/Luc/Markus On 5/2/21 8:21 AM, Edgar E. Iglesias wrote: > On Sun, May 02, 2021 at 12:13:49AM +0200, Philippe Mathieu-Daudé wrote: >> From: Philippe Mathieu-Daudé >> >> TYPE_ETRAX_FS_TIMER is a sysbus device, so its DeviceClass::reset() >> handler is called automatically when its

[Bug 1776478] Re: Getting qemu: uncaught target signal 6 when running lv2 plugin cross-compilation

2021-05-02 Thread guysoft
I am not currently actively building this. However since this has not been fixed we moved to pre-compiling this in order to avoid using QEMU. It means building needed dedcated hardware. See resolution at: https://github.com/zynthian/zynthian-sys/issues/59 ** Bug watch added: github.com/zynthian/z

Re: [PATCH 0/1] Acceptance Tests: bump Avocado version requirement to 87.0

2021-05-02 Thread Philippe Mathieu-Daudé
On 4/14/21 6:11 PM, Cleber Rosa wrote: > This is being proposed as a separate single patch simply to show > that no known regressions have been introduced as far as the > acceptance tests/jobs are related. CI job: > >https://gitlab.com/cleber.gnu/qemu/-/pipelines/286347312 > > This version (

[Bug 1776478] Re: Getting qemu: uncaught target signal 6 when running lv2 plugin cross-compilation

2021-05-02 Thread Peter Maydell
Which QEMU version did you re-test with? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1776478 Title: Getting qemu: uncaught target signal 6 when running lv2 plugin cross- compilation Status in

[PATCH] hw/net/imx_fec: return 0xffff when accessing non-existing PHY

2021-05-02 Thread Guenter Roeck
If a PHY does not exist, attempts to read from it should return 0x. Otherwise the Linux kernel will believe that a PHY is there and select the non-existing PHY. This in turn will result in network errors later on since the real PHY is not selected or configured. Since reading from or writing t

Re: [PATCH] hw/net/imx_fec: return 0xffff when accessing non-existing PHY

2021-05-02 Thread Bin Meng
On Mon, May 3, 2021 at 12:03 AM Guenter Roeck wrote: > > If a PHY does not exist, attempts to read from it should return 0x. > Otherwise the Linux kernel will believe that a PHY is there and select > the non-existing PHY. This in turn will result in network errors later > on since the real PHY

Re: [PATCH] hw/net/imx_fec: return 0xffff when accessing non-existing PHY

2021-05-02 Thread Philippe Mathieu-Daudé
On 5/2/21 6:03 PM, Guenter Roeck wrote: > If a PHY does not exist, attempts to read from it should return 0x. > Otherwise the Linux kernel will believe that a PHY is there and select > the non-existing PHY. This in turn will result in network errors later > on since the real PHY is not selected

Re: [PATCH] hw/net/imx_fec: return 0xffff when accessing non-existing PHY

2021-05-02 Thread Guenter Roeck
On 5/2/21 9:09 AM, Bin Meng wrote: > On Mon, May 3, 2021 at 12:03 AM Guenter Roeck wrote: >> >> If a PHY does not exist, attempts to read from it should return 0x. >> Otherwise the Linux kernel will believe that a PHY is there and select >> the non-existing PHY. This in turn will result in net

[PULL 00/36] MIPS patches for 2021-05-02

2021-05-02 Thread Philippe Mathieu-Daudé
The following changes since commit 53c5433e84e8935abed8e91d4a2eb813168a0ecf: Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210501' into staging (2021-05-02 12:02:46 +0100) are available in the Git repository at: https://github.com/philmd/qemu.git tags/mips-202

[PULL 08/36] target/mips: Move IEEE rounding mode array to new source file

2021-05-02 Thread Philippe Mathieu-Daudé
restore_msa_fp_status() is declared inlined in fpu_helper.h, and uses the ieee_rm[] array. Therefore any code calling restore_msa_fp_status() must have access to this ieee_rm[] array. kvm_mips_get_fpu_registers(), which is in target/mips/kvm.c, calls restore_msa_fp_status. Except this tiny array,

[PULL 02/36] target/mips: Fix CACHEE opcode (CACHE using EVA addressing)

2021-05-02 Thread Philippe Mathieu-Daudé
The CACHEE opcode "requires CP0 privilege". The pseudocode checks in the ISA manual is: if is_eva and not C0.Config5.EVA: raise exception('RI') if not IsCoprocessor0Enabled(): raise coprocessor_exception(0) Add the missing checks. Inspired-by: Richard Henderson Signed-off-

[PULL 01/36] hw/isa/piix4: Use qdev_get_gpio_in_named() to get ISA IRQ

2021-05-02 Thread Philippe Mathieu-Daudé
Since commit 078778c5a55 ("piix4: Add an i8259 Interrupt Controller") the TYPE_PIIX4_PCI_DEVICE exposes the ISA input IRQs as "isa" alias. Use this alias to get IRQ for the power management PCI function. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <202103241

[PULL 09/36] target/mips: Move msa_reset() to new source file

2021-05-02 Thread Philippe Mathieu-Daudé
mips_cpu_reset() is used by all accelerators, and calls msa_reset(), which is defined in msa_helper.c. Beside msa_reset(), the rest of msa_helper.c is only useful to the TCG accelerator. To be able to restrict this helper file to TCG, we need to move msa_reset() out of it. Reviewed-by: Richard He

[PULL 12/36] target/mips: Restrict mips_cpu_dump_state() to cpu.c

2021-05-02 Thread Philippe Mathieu-Daudé
As mips_cpu_dump_state() is only used once to initialize the CPUClass::dump_state handler, we can move it to cpu.c to keep it symbol local. Beside, this handler is used by all accelerators, while the translate.c file targets TCG. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud

[PULL 05/36] target/mips: Migrate missing CPU fields

2021-05-02 Thread Philippe Mathieu-Daudé
Add various missing fields to the CPU migration vmstate: - CP0_VPControl & CP0_GlobalNumber (01bc435b44b 2016-02-03) - CMGCRBase (c870e3f52ca 2016-03-15) - CP0_ErrCtl(0d74a222c27 2016-03-25) - MXU GPR[] & CR(eb555

[PULL 10/36] target/mips: Make CPU/FPU regnames[] arrays global

2021-05-02 Thread Philippe Mathieu-Daudé
The CPU/FPU regnames[] arrays is used in mips_tcg_init() and mips_cpu_dump_state(), which while being in translate.c is not specific to TCG. To be able to move mips_cpu_dump_state() to cpu.c, which is compiled for all accelerator, we need to make the regnames[] arrays global to target/mips/ by dec

[PULL 13/36] target/mips: Turn printfpr() macro into a proper function

2021-05-02 Thread Philippe Mathieu-Daudé
Turn printfpr() macro into a proper function: fpu_dump_fpr(). Suggested-by: Richard Henderson Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210428170410.479308-8-f4...@amsat.org> --- target/mips/cpu.c | 50 ++- 1

[PULL 23/36] target/mips: Move physical addressing code to sysemu/physaddr.c

2021-05-02 Thread Philippe Mathieu-Daudé
Declare get_physical_address() with local scope and move it along with mips_cpu_get_phys_page_debug() to sysemu/physaddr.c new file. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210428170410.479308-18-f4...@amsat.org> --- target/mips/internal.h |

[PULL 03/36] target/mips: Add missing CP0 check to nanoMIPS RDPGPR / WRPGPR opcodes

2021-05-02 Thread Philippe Mathieu-Daudé
Per the nanoMIPS32 Instruction Set Technical Reference Manual, Revision 01.01, Chapter 3. "Instruction Definitions": The Read/Write Previous GPR opcodes "require CP0 privilege". Add the missing CP0 checks. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <202104

[PULL 14/36] target/mips: Declare mips_env_set_pc() inlined in "internal.h"

2021-05-02 Thread Philippe Mathieu-Daudé
Rename set_pc() as mips_env_set_pc(), declare it inlined and use it in cpu.c and op_helper.c. Reported-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20210428170410.479308-9-f4...@amsat.org> --- target/mips/internal.h | 10 ++ t

[PULL 16/36] target/mips: Extract load/store helpers to ldst_helper.c

2021-05-02 Thread Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210428170410.479308-11-f4...@amsat.org> --- target/mips/ldst_helper.c | 288 ++ target/mips/op_helper.c | 259 -- target/mips/meson.build |

[PULL 24/36] target/mips: Restrict cpu_mips_get_random() / update_pagemask() to TCG

2021-05-02 Thread Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210428170410.479308-19-f4...@amsat.org> --- target/mips/internal.h | 4 target/mips/tcg/tcg-internal.h | 9 + 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/target/mips/intern

[PULL 04/36] target/mips: Remove spurious LOG_UNIMP of MTHC0 opcode

2021-05-02 Thread Philippe Mathieu-Daudé
When running with '-d unimp' all MTHC0 opcode executed are logged as unimplemented... Add the proper 'return' statement missed from commit 5204ea79ea7. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20210422081055.2349216-1-f4...@amsat.org> --- target/mips/tra

[PULL 25/36] target/mips: Move sysemu TCG-specific code to tcg/sysemu/ subfolder

2021-05-02 Thread Philippe Mathieu-Daudé
Move cp0_helper.c and mips-semi.c to the new tcg/sysemu/ folder, adapting the Meson machinery. Move the opcode definitions to tcg/sysemu_helper.h.inc. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210428170410.479308-20-f4...@amsat.org> --- target/mips/hel

[PULL 17/36] meson: Introduce meson_user_arch source set for arch-specific user-mode

2021-05-02 Thread Philippe Mathieu-Daudé
Similarly to the 'target_softmmu_arch' source set which allows to restrict target-specific sources to system emulation, add the equivalent 'target_user_arch' set for user emulation. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210428170410.479308-12-f4...@a

[PULL 06/36] target/mips: Make check_cp0_enabled() return a boolean

2021-05-02 Thread Philippe Mathieu-Daudé
To avoid callers to emit dead code if check_cp0_enabled() raise an exception, let it return a boolean value, whether CP0 is enabled or not. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20210420193453.1913810-4-f4...@amsat.org>

[PULL 30/36] target/mips: Move helper_cache() to tcg/sysemu/special_helper.c

2021-05-02 Thread Philippe Mathieu-Daudé
Move helper_cache() to tcg/sysemu/special_helper.c. The CACHE opcode is privileged and is not accessible in user emulation. However we get a link failure when restricting the symbol to sysemu. For now, add a stub helper to satisfy linking, which abort if ever called. Reviewed-by: Richard Henderso

[PULL 33/36] target/mips: Move CP0 helpers to sysemu/cp0.c

2021-05-02 Thread Philippe Mathieu-Daudé
Opcodes accessing Coprocessor 0 are privileged. Move the CP0 helpers to sysemu/ and simplify the #ifdef'ry. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210428170410.479308-28-f4...@amsat.org> --- target/mips/internal.h | 9 +-- target/mips/cpu.c

[PULL 18/36] target/mips: Introduce tcg-internal.h for TCG specific declarations

2021-05-02 Thread Philippe Mathieu-Daudé
We will gradually move TCG-specific declarations to a new local header: "tcg-internal.h". To keep review simple, first add this header with 2 TCG prototypes, which we are going to move in the next 2 commits. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <202104

[PULL 07/36] target/mips: Simplify meson TCG rules

2021-05-02 Thread Philippe Mathieu-Daudé
We already have the mips_tcg_ss source set for TCG-specific files, use it for mxu_translate.c and tx79_translate.c to simplify a bit. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210428170410.479308-2-f4...@amsat.org> --- target/mips/meson.build | 5 ++---

[PULL 32/36] target/mips: Move exception management code to exception.c

2021-05-02 Thread Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210428170410.479308-27-f4...@amsat.org> --- target/mips/internal.h | 13 --- target/mips/tcg/tcg-internal.h | 14 +++ target/mips/cpu.c | 113 -- target/mips/exception.c

[PULL 35/36] hw/mips: Restrict non-virtualized machines to TCG

2021-05-02 Thread Philippe Mathieu-Daudé
Only the malta and loongson3-virt machines support KVM. Restrict the other machines to TCG: - mipssim - magnum - pica61 - fuloong2e - boston Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210428170410.479308-30-f4...@amsat.org> --- hw/mips/meson.build

[PULL 19/36] target/mips: Add simple user-mode mips_cpu_do_interrupt()

2021-05-02 Thread Philippe Mathieu-Daudé
The #ifdef'ry hides that the user-mode implementation of mips_cpu_do_interrupt() simply sets exception_index = EXCP_NONE. Add this simple implementation to tcg/user/tlb_helper.c, and the corresponding Meson machinery to build this file when user emulation is configured. Reviewed-by: Richard Hende

[PULL 11/36] target/mips: Optimize CPU/FPU regnames[] arrays

2021-05-02 Thread Philippe Mathieu-Daudé
Since all entries are no more than 4 bytes (including nul terminator), can save space and pie runtime relocations by declaring regnames[] as array of 4 const char. Suggested-by: Richard Henderson Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210428170410.47

[PULL 34/36] target/mips: Move TCG source files under tcg/ sub directory

2021-05-02 Thread Philippe Mathieu-Daudé
To ease maintenance, move all TCG specific files under the tcg/ sub-directory. Adapt the Meson machinery. The following prototypes: - mips_tcg_init() - mips_cpu_do_unaligned_access() - mips_cpu_do_transaction_failed() can now be restricted to the "tcg-internal.h" header. Reviewed-by: Richard Hend

[PULL 15/36] target/mips: Merge do_translate_address into cpu_mips_translate_address

2021-05-02 Thread Philippe Mathieu-Daudé
Currently cpu_mips_translate_address() calls raise_mmu_exception(), and do_translate_address() calls cpu_loop_exit_restore(). This API split is dangerous, we could call cpu_mips_translate_address without returning to the main loop. As there is only one caller, it is trivial (and safer) to merge d

[PULL 28/36] target/mips: Restrict CPUMIPSTLBContext::map_address() handlers scope

2021-05-02 Thread Philippe Mathieu-Daudé
The 3 map_address() handlers are local to tlb_helper.c, no need to have their prototype declared publically. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210428170410.479308-23-f4...@amsat.org> --- target/mips/internal.h | 6 -- target/mi

[PULL 36/36] gitlab-ci: Add KVM mips64el cross-build jobs

2021-05-02 Thread Philippe Mathieu-Daudé
Add a new job to cross-build the mips64el target without the TCG accelerator (IOW: only KVM accelerator enabled). Only build the mips64el target which is known to work and has users. Reviewed-by: Richard Henderson Acked-by: Thomas Huth Reviewed-by: Willian Rampazzo Signed-off-by: Philippe Math

[PULL 20/36] target/mips: Add simple user-mode mips_cpu_tlb_fill()

2021-05-02 Thread Philippe Mathieu-Daudé
tlb_helper.c's #ifdef'ry hides a quite simple user-mode implementation of mips_cpu_tlb_fill(). Copy the user-mode implementation (without #ifdef'ry) to tcg/user/helper.c and simplify tlb_helper.c's #ifdef'ry. This will allow us to restrict tlb_helper.c to sysemu. Reviewed-by: Richard Henderson

Re: [PATCH 0/2] exec: Cover gen-icount.h in MAINTAINERS, add missing exec-all.h header

2021-05-02 Thread Richard Henderson
On 4/21/21 11:41 PM, Philippe Mathieu-Daudé wrote: Philippe Mathieu-Daudé (2): MAINTAINERS: Add include/exec/gen-icount.h to 'Main Loop' section exec/gen-icount.h: Add missing "exec/exec-all.h" include Queued, thanks. r~

[PULL 21/36] target/mips: Move cpu_signal_handler definition around

2021-05-02 Thread Philippe Mathieu-Daudé
We have 2 blocks guarded with #ifdef for sysemu, which are simply separated by the cpu_signal_handler definition. To simplify the following commits which involve various changes in internal.h, first join the sysemu-guarded blocks. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Da

[PULL 22/36] target/mips: Move sysemu specific files under sysemu/ subfolder

2021-05-02 Thread Philippe Mathieu-Daudé
Move sysemu-specific files under the new sysemu/ subfolder and adapt the Meson machinery. Update the KVM MIPS entry in MAINTAINERS. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210428170410.479308-17-f4...@amsat.org> --- target/mips/{ => sysemu}/addr.c

[PULL 26/36] target/mips: Restrict mmu_init() to TCG

2021-05-02 Thread Philippe Mathieu-Daudé
mmu_init() is only required by TCG accelerator. Restrict its declaration and call to TCG. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210428170410.479308-21-f4...@amsat.org> --- target/mips/internal.h | 3 --- target/mips/tcg/tcg-internal.h | 2 ++

[PATCH v3 2/2] hw/rtc/mc146818rtc: Convert to 3-phase reset (Resettable interface)

2021-05-02 Thread Philippe Mathieu-Daudé
TYPE_MC146818_RTC is an ISA device, so its DeviceClass::reset() handler is called automatically when its qbus parent is reset (we don't need to register it manually). We have 2 reset() methods: a generic one and the qdev one. Merge them into a reset_enter handler (keeping the IRQ lowering to a res

[PULL 27/36] target/mips: Move tlb_helper.c to tcg/sysemu/

2021-05-02 Thread Philippe Mathieu-Daudé
Move tlb_helper.c to the tcg/sysemu/ subdir, along with the following 3 declarations to tcg-internal.h: - cpu_mips_tlb_flush() - cpu_mips_translate_address() - r4k_invalidate_tlb() Simplify tlb_helper.c #ifdef'ry because files in tcg/sysemu/ are only build when sysemu mode is configured. Reviewed

[PULL 29/36] target/mips: Move Special opcodes to tcg/sysemu/special_helper.c

2021-05-02 Thread Philippe Mathieu-Daudé
Move the Special opcodes helpers to tcg/sysemu/special_helper.c. Since mips_io_recompile_replay_branch() is set as CPUClass::io_recompile_replay_branch handler in cpu.c, we need to declare its prototype in "tcg-internal.h". Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Me

[PULL 31/36] target/mips: Move TLB management helpers to tcg/sysemu/tlb_helper.c

2021-05-02 Thread Philippe Mathieu-Daudé
Move TLB management helpers to tcg/sysemu/tlb_helper.c. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210428170410.479308-26-f4...@amsat.org> --- target/mips/helper.h| 10 - target/mips/internal.h | 7 - target/mips/tcg/sysem

Re: [PATCH 0/2] exec: Cover gen-icount.h in MAINTAINERS, add missing exec-all.h header

2021-05-02 Thread Philippe Mathieu-Daudé
ping? On 4/22/21 8:41 AM, Philippe Mathieu-Daudé wrote: > include/exec/gen-icount.h is listed as unmaintained. > Add it to Main Loop (or should it be TCG? softmmu/icount.c > is already there). > > Add the missing "exec/exec-all.h" header. > > Philippe Mathieu-Daudé (2): > MAINTAINERS: Add incl

Re: [PULL 00/36] MIPS patches for 2021-05-02

2021-05-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210502161538.534038-1-f4...@amsat.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210502161538.534038-1-f4...@amsat.org Subject: [PULL 00/36] MIPS patches for 2021-05-02 ==

Re: [PATCH-for-6.0?] hw/rx/rx-gdbsim: Do not accept invalid memory size

2021-05-02 Thread Philippe Mathieu-Daudé
Hi Laurent, could you take this patch via your Trivial tree please? On 4/8/21 12:30 AM, Philippe Mathieu-Daudé wrote: > We check the amount of RAM is enough, warn when it is > not, but if so we neglect to bail out. Fix that by > adding the missing exit() call. > > Fixes: bda19d7bb56 ("hw/rx: Add

Re: [PATCH-for-6.0?] hw/arm/imx25_pdk: Fix error message for invalid RAM size

2021-05-02 Thread Philippe Mathieu-Daudé
Hi Peter, Could you take this patch via the ARM tree? It has been reviewed twice. Thanks, Phil. On 4/8/21 12:56 AM, Philippe Mathieu-Daudé wrote: > The i.MX25 PDK board has 2 banks for SDRAM, each can > address up to 256 MiB. So the total RAM usable for this > board is 512M. When we ask for mor

[PATCH v3 0/2] hw: Convert mc146818rtc & etraxfs_timer to 3-phase reset interface

2021-05-02 Thread Philippe Mathieu-Daudé
Remove qemu_register_reset() when a qdev type has a qbus parent, implementing the 3-phase Resettable interface. Since v2: - Lower IRQ in 'hold' phase, not 'exit' one (Edgar) Since v1: - Use 3-phase reset interface instead of qdev one (Laurent) Supersedes: <20210423233652.3042941-1-f4...@amsat.or

[PATCH v3 1/2] hw/timer/etraxfs_timer: Convert to 3-phase reset (Resettable interface)

2021-05-02 Thread Philippe Mathieu-Daudé
TYPE_ETRAX_FS_TIMER is a sysbus device, so its DeviceClass::reset() handler is called automatically when its qbus parent is reset (we don't need to register it manually). Convert the generic reset to a enter/hold resettable ones, and remove the qemu_register_reset() call. Signed-off-by: Philippe

Re: [PATCH-for-6.1 0/3] hw/sparc/sun4m: Introduce Sun4mMachineClass to access sun4m_hwdefs

2021-05-02 Thread Philippe Mathieu-Daudé
On 5/2/21 1:20 PM, Mark Cave-Ayland wrote: > On 07/04/2021 18:53, Philippe Mathieu-Daudé wrote: > >> Hi Mark, >> >> This series QOM'ify a bit more the sun4m machines. >> I need it for a further memory maxsize check. >> It is mostly code movement (and the diff-stat is good). >> >> Philippe Mathieu-

[PATCH 0/4] pc-bios/s390-ccw: Allow building with Clang, too

2021-05-02 Thread Thomas Huth
Clang can provide some additional warnings compared to GCC which can sometimes help to catch some more bugs. So it would be good to be able to build the s390-ccw bios with Clang, too. Only caveat: Clang does not support the z900 anymore which is the lowest guest CPU that could be used in QEMU, so w

[PATCH 4/4] pc-bios/s390-ccw: Allow building with Clang, too

2021-05-02 Thread Thomas Huth
Clang unfortunately does not support generating code for the z900 architecture level and starts with the z10 instead. Thus to be able to support compiling with Clang, we have to check for the supported compiler flags. The disadvantage is of course that the bios image will only run with z10 guest CP

  1   2   3   >