Re: [PATCH v3 01/15] python: qemu: add timer parameter for qmp.accept socket

On 14.04.21 19:03, Emanuele Giuseppe Esposito wrote: Add a new _qmp_timer field to the QEMUMachine class. The default timer is 15 sec, as per the default in the qmp accept() function. Signed-off-by: Emanuele Giuseppe Esposito --- python/qemu/machine.py | 3 ++- 1 file changed, 2 insertions(+

Re: [PATCH] ui: Fix memory leak in qemu_xkeymap_mapping_table()

On Fri, Apr 30, 2021 at 12:17:06PM +0200, Philippe Mathieu-Daudé wrote: > Refactor qemu_xkeymap_mapping_table() to have a single exit point, > so we can easily free the memory allocated by XGetAtomName(), > > This fixes when running a binary configured with --enable-sanitizers: > > Direct leak

[PATCH v2 12/16] virtio-gpu: drop use_virgl_renderer

Now that we have separated the gl and non-gl code flows to two different devices there is little reason turn on and off virglrenderer usage at runtime. The gl code can simply use virglrenderer unconditionally. So drop use_virgl_renderer field and just do that. Signed-off-by: Gerd Hoffmann ---

Re: [PATCH v3 02/15] python: qemu: pass the wrapper field from QEMUQtestmachine to QEMUMachine

On 14.04.21 19:03, Emanuele Giuseppe Esposito wrote: Signed-off-by: Emanuele Giuseppe Esposito --- python/qemu/qtest.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/python/qemu/qtest.py b/python/qemu/qtest.py index 39a0cf62fe..c18eae96c6 100644 --- a/python/qemu/qtes

Re: [PATCH v3 03/15] docs/devel/testing: add debug section to the QEMU iotests chapter

On 14.04.21 19:03, Emanuele Giuseppe Esposito wrote: Introduce the "Debugging a test case" section, in preparation to the additional flags that will be added in the next patches. Signed-off-by: Emanuele Giuseppe Esposito --- docs/devel/testing.rst | 8 1 file changed, 8 insertions(+

[PATCH v2 00/16] virtio-gpu: split into two devices.

Currently we have one virtio-gpu device. Problem with this approach is that if you compile a full-featured qemu you'll get a virtio-gpu device which depends on opengl and virgl, so these dependencies must be installed and the libraries will be loaded into memory even if you don't use virgl. Also

[PATCH v2 07/16] virtio-gpu: move virgl gl_flushed

Signed-off-by: Gerd Hoffmann --- hw/display/virtio-gpu-gl.c | 13 + hw/display/virtio-gpu.c| 15 --- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/hw/display/virtio-gpu-gl.c b/hw/display/virtio-gpu-gl.c index 6d0ce5bcd6f1..e976fb8d04c4 100644 --- a/h

[PULL 08/25] qapi/expr.py: Add casts in a few select cases

From: John Snow Casts are instructions to the type checker only, they aren't "safe" and should probably be avoided in general. In this case, when we perform type checking on a nested structure, the type of each field does not "stick". (See PEP 647 for an example of "type narrowing" that does "st

[PATCH v2 04/16] virtio-gpu: move virgl reset

Signed-off-by: Gerd Hoffmann --- include/hw/virtio/virtio-gpu.h | 1 + hw/display/virtio-gpu-gl.c | 17 + hw/display/virtio-gpu.c| 19 +-- 3 files changed, 19 insertions(+), 18 deletions(-) diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virt

[PATCH v2 14/16] virtio-gpu: add virtio-gpu-gl-pci

Add pci proxy for virtio-gpu-gl-device. Signed-off-by: Gerd Hoffmann --- hw/display/virtio-gpu-pci-gl.c | 55 ++ util/module.c | 2 ++ hw/display/meson.build | 5 3 files changed, 62 insertions(+) create mode 100644 hw/display/virt

[PULL 01/25] qapi/expr: Comment cleanup

From: John Snow The linter yaps after 0825f62c842. Fix this trivial issue to restore the linter baseline. (Yes, ideally -- and soon -- the linter will be part of CI so we don't clutter up the log with fixups. For now, though, the baseline is useful for testing intermediate commits as types are a

[PATCH v2 10/16] virtio-gpu: drop VIRGL() macro

Drops last virgl/opengl dependency from virtio-gpu-device. Signed-off-by: Gerd Hoffmann --- hw/display/virtio-gpu.c | 17 - 1 file changed, 17 deletions(-) diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index 2c0065277ffd..34cf35127a3d 100644 --- a/hw/display/vir

[PATCH v2 15/16] modules: add have_vga

Introduce a symbol which can be used to prevent display modules which need vga support being loaded into system emulators with CONFIG_VGA=n. Signed-off-by: Gerd Hoffmann --- include/hw/display/vga.h | 6 ++ hw/display/vga.c | 2 ++ 2 files changed, 8 insertions(+) diff --git a/inclu

[PULL 00/25] QAPI patches patches for 2021-04-30

The following changes since commit ccdf06c1db192152ac70a1dd974c624f566cb7d4: Open 6.1 development tree (2021-04-30 11:15:40 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2021-04-30 for you to fetch changes up to b54626e0b8f423e91b2e31fa7741e4

[PATCH v2 09/16] virtio-gpu: move update_cursor_data

Signed-off-by: Gerd Hoffmann --- include/hw/virtio/virtio-gpu.h | 6 ++ hw/display/virtio-gpu-gl.c | 30 +++ hw/display/virtio-gpu.c| 38 ++ 3 files changed, 42 insertions(+), 32 deletions(-) diff --git a/include/hw/virtio/

[PULL 19/25] qapi/error: Use Python3-style super()

From: John Snow Missed in commit 2cae67bcb5 "qapi: Use super() now we have Python 3". Signed-off-by: John Snow Reviewed-by: Markus Armbruster Message-Id: <20210421192233.3542904-3-js...@redhat.com> Signed-off-by: Markus Armbruster --- scripts/qapi/error.py | 2 +- 1 file changed, 1 insertion

[PATCH v2 16/16] virtio-gpu: add virtio-vga-gl

Add pci proxy for virtio-gpu-gl-device, with vga compatibility. Signed-off-by: Gerd Hoffmann --- hw/display/virtio-vga-gl.c | 47 ++ util/module.c | 2 ++ hw/display/meson.build | 5 3 files changed, 54 insertions(+) create mode 100644

[PATCH v2 13/16] virtio-gpu: move fields to struct VirtIOGPUGL

Move two virglrenderer state variables to struct VirtIOGPUGL. Signed-off-by: Gerd Hoffmann --- include/hw/virtio/virtio-gpu.h | 5 +++-- hw/display/virtio-gpu-gl.c | 15 +-- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/include/hw/virtio/virtio-gpu.h b/include/

[PATCH v2 01/16] virtio-gpu: rename virgl source file.

"3d" -> "virgl" as 3d is a rather broad term. Hopefully a bit less confusing. Signed-off-by: Gerd Hoffmann --- hw/display/{virtio-gpu-3d.c => virtio-gpu-virgl.c} | 0 hw/display/meson.build | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) rename hw/display/{vir

[PULL 15/25] qapi/expr.py: Add docstrings

From: John Snow Now with more :words:! Signed-off-by: John Snow Message-Id: <20210421182032.3521476-16-js...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- scripts/qapi/expr.py | 256 ++- 1 file changed, 251 insertions(

Re: [PATCH v3 04/15] qemu-iotests: add option to attach gdbserver

On 14.04.21 19:03, Emanuele Giuseppe Esposito wrote: Add -gdb flag and GDB_QEMU environmental variable to python tests to attach a gdbserver to each qemu instance. Well, this patch doesn’t do this, but OK. Out of interest: Why gdbserver and not “just” gdb? On Fedora, those are separate packa

[PATCH v2 02/16] virtio-gpu: add virtio-gpu-gl-device

Just a skeleton for starters, following patches will add more code. Signed-off-by: Gerd Hoffmann --- include/hw/virtio/virtio-gpu.h | 7 ++ hw/display/virtio-gpu-gl.c | 41 ++ util/module.c | 1 + hw/display/meson.build | 2 +-

[PULL 17/25] qapi/expr: Update authorship and copyright information

From: John Snow Signed-off-by: John Snow Message-Id: <20210421182032.3521476-18-js...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- scripts/qapi/expr.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/qapi/expr.py b/scripts/qapi/

[PULL 11/25] qapi/expr.py: Consolidate check_if_str calls in check_if

From: John Snow This is a small rewrite to address some minor style nits. Don't compare against the empty list to check for the empty condition, and move the normalization forward to unify the check on the now-normalized structure. With the check unified, the local nested function isn't needed

[Bug 1926759] [NEW] WFI instruction results in unhandled CPU exception

Public bug reported: Hi I refer to the WFI instruction. The bytecode is 0xe320f003. After the execution, qemu exit with the following crash log. qemu: unhandled CPU exception 0x10001 - aborting R00=0001 R01=40800b34 R02=40800b3c R03=000102ec R04=00010a28 R05=00010158 R06=00087460 R07=000101

[PATCH v2 03/16] virtio-gpu: move virgl realize + properties

Move device init (realize) and properties. Drop the virgl property, the virtio-gpu-gl-device has virgl enabled no matter what. Just use virtio-gpu-device instead if you don't want enable virgl and opengl. This simplifies the logic and reduces the test matrix. Signed-off-by: Gerd Hoffmann ---

[PULL 22/25] qapi/error.py: move QAPIParseError to parser.py

From: John Snow Keeping it in error.py will create some cyclic import problems when we add types to the QAPISchemaParser. Callers don't need to know the details of QAPIParseError unless they are parsing or dealing directly with the parser, so this won't create any harsh new requirements for calle

[PULL 05/25] qapi/expr.py: Add assertion for union type 'check_dict'

From: John Snow mypy isn't fond of allowing you to check for bool membership in a collection of str elements. Guard this lookup for precisely when we were given a name. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa Message-Id: <20210421182032.3521476-6-js...@r

[PATCH v2 05/16] virtio-gpu: use class function for ctrl queue handlers

Signed-off-by: Gerd Hoffmann --- include/hw/virtio/virtio-gpu.h | 8 +++- hw/display/virtio-gpu.c| 12 +--- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h index a7b7d78310ea..380aa7dd6322 100644

[PULL 13/25] qapi/expr.py: enable pylint checks

From: John Snow Signed-off-by: John Snow Tested-by: Eduardo Habkost Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa Message-Id: <20210421182032.3521476-14-js...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- scripts/qapi/pylint

[PULL 21/25] qapi/error: assert QAPISourceInfo is not None

From: John Snow Built-in stuff is not parsed from a source file, and therefore have no QAPISourceInfo. If such None info was used for reporting an error, built-in stuff would be broken. Programming error. Instead of reporting a confusing error with bogus source location then, we better crash. We

Re: [PATCH v3 05/15] qemu-iotests: delay QMP socket timers

On 14.04.21 19:03, Emanuele Giuseppe Esposito wrote: Attaching a gdbserver implies that the qmp socket should wait indefinitely for an answer from QEMU. Signed-off-by: Emanuele Giuseppe Esposito --- python/qemu/machine.py| 3 +++ tests/qemu-iotests/iotests.py | 10 +- 2 fil

[PATCH v2 06/16] virtio-gpu: move virgl handle_ctrl

Signed-off-by: Gerd Hoffmann --- hw/display/virtio-gpu-gl.c | 33 + hw/display/virtio-gpu.c| 13 - 2 files changed, 33 insertions(+), 13 deletions(-) diff --git a/hw/display/virtio-gpu-gl.c b/hw/display/virtio-gpu-gl.c index c3e562f835f7..6d0ce5bcd

[PULL 10/25] qapi/expr.py: add type hint annotations

From: John Snow Annotations do not change runtime behavior. This commit *only* adds annotations. Signed-off-by: John Snow Message-Id: <20210421182032.3521476-11-js...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- scripts/qapi/expr.py | 68 ++

Re: [PATCH v3 04/15] qemu-iotests: add option to attach gdbserver

On 14.04.21 19:03, Emanuele Giuseppe Esposito wrote: Add -gdb flag and GDB_QEMU environmental variable to python tests to attach a gdbserver to each qemu instance. if -gdb is not provided but $GDB_QEMU is set, ignore the environmental variable. Signed-off-by: Emanuele Giuseppe Esposito --- t

[PATCH v2 08/16] virtio-gpu: move virgl process_cmd

Signed-off-by: Gerd Hoffmann --- include/hw/virtio/virtio-gpu.h | 2 ++ hw/display/virtio-gpu-gl.c | 11 +++ hw/display/virtio-gpu.c| 9 + 3 files changed, 18 insertions(+), 4 deletions(-) diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h

[PULL 12/25] qapi/expr.py: Remove single-letter variable

From: John Snow Signed-off-by: John Snow Message-Id: <20210421182032.3521476-13-js...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- scripts/qapi/expr.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/scripts/qapi/expr.py b/

Re: [PATCH v3 09/15] qemu_iotests: extend the check script to support valgrind for python tests

On 14.04.21 19:03, Emanuele Giuseppe Esposito wrote: Currently, the check script only parses the option and sets the VALGRIND_QEMU environmental variable to "y". Add another local python variable that prepares the command line, identical to the one provided in the test scripts. Because the pytho

Re: [PATCH v3 07/15] qemu-iotests: add gdbserver option to script tests too

On 14.04.21 19:03, Emanuele Giuseppe Esposito wrote: The only limitation here is that running a script with gdbserver will make the test output mismatch with the expected results, making the test fail. Signed-off-by: Emanuele Giuseppe Esposito --- tests/qemu-iotests/common.rc | 8 +++- 1

[PATCH v2 11/16] virtio-gpu: move virtio-gpu-gl-device to separate module

Signed-off-by: Gerd Hoffmann --- util/module.c | 4 +++- hw/display/meson.build | 9 ++--- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/util/module.c b/util/module.c index 47bba1182841..c8f3e5a0a736 100644 --- a/util/module.c +++ b/util/module.c @@ -182,6 +182,8 @@

[PULL 25/25] qapi/error.py: enable mypy checks

From: John Snow Signed-off-by: John Snow Message-Id: <20210421192233.3542904-9-js...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- scripts/qapi/mypy.ini | 5 - 1 file changed, 5 deletions(-) diff --git a/scripts/qapi/mypy.ini b/scripts/qapi/mypy.ini ind

Re: [PATCH v2 07/12] virtio-gpu: Add virtio_gpu_resource_create_blob

Hi, > [Kasireddy, Vivek] Right, we don't. I was also going to slightly change the > names of some > of the new functions in v3 to keep them consistent with the rest of the code. > Do you have > any additional feedback for the other patches that I can include in v3? Looks fine to me otherwise.

[PULL 09/25] qapi/expr.py: Modify check_keys to accept any Collection

From: John Snow This is a minor adjustment that lets parameters @required and @optional take tuple arguments, in particular (). Later patches will make use of that. (Iterable would also have worked, but Iterable also includes things like generator expressions which are consumed upon iteration,

Re: [PULL 00/43] target-arm queue

tree (2021-04-30 11:15:40 +0100) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20210430 > > for you to fetch changes up to a6091108aa44e9017af4ca13c43f55a629e3744c: > > hw/pci-host/gpex: Don

[PULL 07/25] qapi/expr.py: Check type of union and alternate 'data' member

From: John Snow Prior to this commit, specifying a non-object value here causes the QAPI parser to crash in expr.py with a stack trace with (likely) an AttributeError when we attempt to call that value's items() method. This member needs to be an object (Dict), and not anything else. Add a check

RE: [PATCH v3 03/30] decodetree: Add support for 64-bit instructions

From: Richard Henderson > From: Luis Fernando Fujita Pires > > Allow '64' to be specified for the instruction width command line params and > use > the appropriate extract and deposit functions in that case. > > This will be used to implement the new 64-bit Power ISA 3.1 instructions. > > Rev

[PULL 04/25] qapi/expr.py: constrain incoming expression types

From: John Snow mypy does not know the types of values stored in Dicts that masquerade as objects. Help the type checker out by constraining the type. Signed-off-by: John Snow Message-Id: <20210421182032.3521476-5-js...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruste

Re: [PATCH v3 06/15] qemu_iotests: insert gdbserver command line as wrapper for qemu binary

On 14.04.21 19:03, Emanuele Giuseppe Esposito wrote: Signed-off-by: Emanuele Giuseppe Esposito --- tests/qemu-iotests/iotests.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Max Reitz

[PULL 03/25] qapi/expr.py: Check for dict instead of OrderedDict

From: John Snow OrderedDict is a subtype of dict, so we can check for a more general form. These functions do not themselves depend on it being any particular type. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa Message-Id: <20210421182032.3521476-4-js...@redha

Re: [PATCH v2 3/7] target/ppc: Isolated SPR read/write callbacks

On 30/04/2021 01:21, David Gibson wrote: On Thu, Apr 29, 2021 at 01:21:26PM -0300, Bruno Larsen (billionai) wrote: Moved all SPR read/write callback, and some related functions, to a new file specific for it. These callbacks are TCG only, so separating them is required to support the flag disabl

[PULL 14/25] qapi/expr: Only explicitly prohibit 'Kind' nor 'List' for type names

From: John Snow Per list review: qapi-code-gen.txt reserves suffixes Kind and List only for type names, but the code rejects them for events and commands, too. It turns out we reject them earlier anyway: In check_name_upper() for event names, and in check_name_lower() for command names. Still,

Re: [PATCH v2 00/16] virtio-gpu: split into two devices.

Patchew URL: https://patchew.org/QEMU/20210430113547.1816178-1-kra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210430113547.1816178-1-kra...@redhat.com Subject: [PATCH v2 00/16] virtio-gpu: split in

[PULL 06/25] qapi/expr.py: move string check upwards in check_type

From: John Snow For readability purposes only, shimmy the early return upwards to the top of the function, so cases proceed in order from least to most complex. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa Message-Id: <20210421182032.3521476-7-js...@redhat.co

Re: [PATCH v3 10/15] qemu_iotests: extent QMP socket timeout when using valgrind

On 14.04.21 19:03, Emanuele Giuseppe Esposito wrote: As with gdbserver, valgrind delays the test execution, so the default QMP socket timeout timeout too soon. I’m curious: The default timeouts should be long enough for slow systems, too, though (e.g. heavily-loaded CI systems). I would expec

Adjustments of NVDIMM devices and future data safety

Hi, I work on NVDIMM support in oVirt/RHV, I think other virtualization management software built on top of QEMU may have similar concerns. When a virtual NVDIMM device size is specified, it's not necessarily the eventual NVDIMM device size visible to the guest OS. As seen in https://github.com/

Re: [PATCH] accel: kvm: clarify that extra exit data is hexadecimal

Le 28/04/2021 à 16:24, David Edmondson a écrit : > When dumping the extra exit data provided by KVM, make it clear that > the data is hexadecimal. > > At the same time, zero-pad the output. > > Signed-off-by: David Edmondson > --- > accel/kvm/kvm-all.c | 2 +- > 1 file changed, 1 insertion(+),

[PULL 16/25] qapi/expr.py: Use tuples instead of lists for static data

From: John Snow It is -- maybe -- possibly -- three nanoseconds faster. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa Message-Id: <20210421182032.3521476-17-js...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- scripts/qapi/e

Re: [PATCH 1/3] hw/arm/pxa2xx: Declare PCMCIA bus with Kconfig

Le 25/04/2021 à 00:20, Philippe Mathieu-Daudé a écrit : > The Intel XScale PXA chipsets provide a PCMCIA controller, > which expose a PCMCIA (IDE) bus. Express this dependency using > the Kconfig 'select' expression. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/Kconfig | 1 + > 1 fil

[PULL 02/25] qapi/expr.py: Remove 'info' argument from nested check_if_str

From: John Snow The function can just use the argument from the scope above. Otherwise, we get shadowed argument errors because the parameter name clashes with the name of a variable already in-scope. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa Message-Id: <

Re: [PATCH v3 11/15] qemu_iotests: allow valgrind to read/delete the generated log file

On 14.04.21 19:03, Emanuele Giuseppe Esposito wrote: When using -valgrind on the script tests, it generates a log file in $TEST_DIR that is either read (if valgrind finds problems) or otherwise deleted. Provide the same exact behavior when using -valgrind on the python tests. Signed-off-by: Eman

Re: [PATCH] Fix typo in CFI build documentation

Le 22/04/2021 à 10:33, Serge Guelton a écrit : > From: serge-sans-paille > > Signed-off-by: Serge Guelton "If you wrote the patch, make sure your "From:" and "Signed-off-by:" lines use the same spelling." https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:

[PULL 23/25] qapi/error.py: enable pylint checks

From: John Snow Signed-off-by: John Snow Message-Id: <20210421192233.3542904-7-js...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- scripts/qapi/pylintrc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/qapi/pylintrc b/scripts/qapi

[PULL 20/25] qapi/error: Make QAPISourceError 'col' parameter optional

From: John Snow It's already treated as optional, with one direct caller and some subclass callers passing 'None'. Make it officially optional, which requires moving the position of the argument to come after all required parameters. QAPISemError becomes functionally identical to QAPISourceError

Re: [PATCH v3 13/15] docs/devel/testing: add -valgrind option to the debug section of QEMU iotests

On 14.04.21 19:03, Emanuele Giuseppe Esposito wrote: Signed-off-by: Emanuele Giuseppe Esposito --- docs/devel/testing.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 2ee77a057b..62902cfd2d 100644 --- a/docs/devel/testing.rst

[Bug 1926759] Re: WFI instruction results in unhandled CPU exception

cmd： ~/qemu-5.1.0/arm-linux-user/qemu-arm ~/test2 QEMU version: qemu-arm version 5.1.0 Sorry that I didn't test it on the latest version of QEMU. ** Attachment added: "test2" https://bugs.launchpad.net/qemu/+bug/1926759/+attachment/5493873/+files/test2 -- You received this bug notification

[PULL 24/25] qapi/error: Add type hints

From: John Snow No functional change. Note: QAPISourceError's info parameter is Optional[] because schema.py treats the info property of its various classes as Optional to accommodate built-in types, which have no source. See prior commit 'qapi/error: assert QAPISourceInfo is not None'. Signed-

[PATCH v2 04/13] target/arm: Split m-nocp trans functions into their own file

Currently the trans functions for m-nocp.decode all live in translate-vfp.inc.c; move them out into their own translation unit, translate-m-nocp.c. The trans_* functions here are pure code motion with no changes. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/transl

[PULL 18/25] qapi/error: Repurpose QAPIError as an abstract base exception class

From: John Snow Rename QAPIError to QAPISourceError, and then create a new QAPIError class that serves as the basis for all of our other custom exceptions, without specifying any class properties. This leaves QAPIError as a package-wide error class that's suitable for any current or future error

[PATCH v2 03/13] target/arm: Make functions used by m-nocp global

We want to split out the .c.inc files which are currently included into translate.c so they are separate compilation units. To do this we need to make some functions which are currently file-local to translate.c have global scope; create a translate-a32.h paralleling the existing translate-a64.h a

RE: [PATCH v3 04/30] decodetree: Extend argument set syntax to allow types

From: Richard Henderson > Rather than force all structure members to be 'int', allow the type of the > member to be specified. > > Signed-off-by: Richard Henderson > --- > docs/devel/decodetree.rst | 11 --- > tests/decode/succ_argset_type1.decode | 1 + > scripts/decodetree.py

[PATCH v2 01/13] target/arm: Move constant expanders to translate.h

Some of the constant expanders defined in translate.c are generically useful and will be used by the separate C files for VFP and Neon once they are created; move the expander definitions to translate.h. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Hender

[Bug 1926759] Re: WFI instruction results in unhandled CPU exception

Oh, and the QEMU version you're using as well, please. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1926759 Title: WFI instruction results in unhandled CPU exception Status in QEMU: New Bug de

[PATCH v2 12/13] target/arm: Make functions used by translate-neon global

Make the remaining functions needed by the translate-neon code global. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/arm/translate-a32.h | 8 target/arm/translate.c | 10 ++ 2 files changed, 10 insertions(+), 8

[Bug 1926759] Re: WFI instruction results in unhandled CPU exception

Please provide a test case binary and your QEMU command line. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1926759 Title: WFI instruction results in unhandled CPU exception Status in QEMU: New

Re: [PATCH 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed

Hey, On Fri, Apr 30, 2021, at 7:58 AM, Markus Armbruster wrote: > > I did not add a Since: here because I wasn't sure how that is handled. > > Should I add something or is that taken care of at the time of release > > somehow? > > You should add (since 6.1) at the end, like this > > # @full-gr

Re: [PATCH v3 12/15] qemu_iotests: insert valgrind command line as wrapper for qemu binary

On 14.04.21 19:03, Emanuele Giuseppe Esposito wrote: The priority will be given to gdb command line, meaning if the -gdb parameter and -valgrind are given, gdb will be wrapped around the qemu binary. Signed-off-by: Emanuele Giuseppe Esposito --- tests/qemu-iotests/iotests.py | 3 ++- 1 file

[PATCH v3 6/7] tests/acceptance: Add set_vm_arg() to the Test class

The set_vm_arg method is added to avocado_qemu.Test class on this change. Use that method to set (or replace) an argument to the list of arguments given to the QEMU binary. Suggested-by: Cleber Rosa Signed-off-by: Wainer dos Santos Moschetta --- tests/acceptance/avocado_qemu/__init__.py | 21 ++

[PATCH v3 2/7] tests/acceptance: Fix mismatch on cpu tagged tests

There are test cases on machine_mips_malta.py and tcg_plugins.py files where the cpu tag does not correspond to the value actually given to the QEMU binary. This fixed those tests tags. Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa Reviewed-by: Willian Rampazzo Signed-off-by: Wainer dos Santo

Re: [PATCH v3 08/15] docs/devel/testing: add -gdb option to the debugging section of QEMU iotests

On 14.04.21 19:03, Emanuele Giuseppe Esposito wrote: Signed-off-by: Emanuele Giuseppe Esposito --- docs/devel/testing.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index b7e2370e7e..2ee77a057b 100644 --- a/docs/devel/testing.rst

[PATCH v2 05/13] target/arm: Move gen_aa32 functions to translate-a32.h

Move the various gen_aa32* functions and macros out of translate.c and into translate-a32.h. Signed-off-by: Peter Maydell --- target/arm/translate-a32.h | 53 ++ target/arm/translate.c | 51 2 files changed, 69 insertio

[PATCH v3 1/7] tests/acceptance: Automatic set -cpu to the test vm

This introduces a new feature to the functional tests: automatic setting of the '-cpu VALUE' option to the created vm if the test is tagged with 'cpu:VALUE'. The 'cpu' property is made available to the test object as well. For example, for a simple test as: def test(self): """

[PATCH 2/2] [RESEND] sev: add missing firmware error conditions

The SEV userspace header[1] exports a couple of other error conditions that aren't listed in QEMU's SEV implementation, so let's just round out the list. [1] linux-headers/linux/psp-sev.h Signed-off-by: Connor Kuehl Reviewed-by: Philippe Mathieu-Daudé --- target/i386/sev.c | 2 ++ 1 file chang

[PATCH v2 09/13] target/arm: Move vfp_reg_ptr() to translate-neon.c.inc

The function vfp_reg_ptr() is used only in translate-neon.c.inc; move it there. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/arm/translate.c | 7 --- target/arm/translate-neon.c.inc | 7 +++ 2 files changed, 7 inser

Re: [PATCH v3 17/30] target/ppc: Remove DisasContext.exception

On 29/04/2021 22:15, Richard Henderson wrote: Now that we have removed all of the fake exceptions, and all real exceptions exit via DISAS_NORETURN, we can remove this field. Signed-off-by: Richard Henderson --- target/ppc/translate.c | 22 ++ 1 file changed, 2 insertions(

[PATCH v3 5/7] python/qemu: Add args property to the QEMUMachine class

This added the args property to QEMUMachine so that users of the class can access and handle the list of arguments to be given to the QEMU binary. Reviewed-by: Cleber Rosa Reviewed-by: Willian Rampazzo Signed-off-by: Wainer dos Santos Moschetta --- python/qemu/machine.py | 5 + 1 file chan

[PATCH v2 11/13] target/arm: Move NeonGenThreeOpEnvFn typedef to translate.h

Move the NeonGenThreeOpEnvFn typedef to translate.h together with the other similar typedefs. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/translate.h | 2 ++ target/arm/translate.c | 3 --- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/target/arm/

[PATCH v3 7/7] tests/acceptance: Handle cpu tag on x86_cpu_model_versions tests

Some test cases on x86_cpu_model_versions.py are corner cases because they need to pass extra options to the -cpu argument. Once the avocado_qemu framework will set -cpu automatically, the value should be reset. This changed those tests so to call set_vm_arg() to overwrite the -cpu value. Signed-o

[PATCH v2] Document qemu-img options data_file and data_file_raw

The contents of this patch were initially developed and posted by Han Han[1], however, it appears the original patch was not applied. Since then, the relevant documentation has been moved and adapted to a new format. I've taken most of the original wording and tweaked it according to some of the f

RE: [PATCH v3 01/30] decodetree: Introduce whex and whexC helpers

From: Richard Henderson > Form a hex constant of the appropriate insnwidth. > Begin using f-strings on changed lines. > > Signed-off-by: Richard Henderson > --- > scripts/decodetree.py | 66 +-- > 1 file changed, 38 insertions(+), 28 deletions(-) Reviewe

[PATCH v3 3/7] tests/acceptance: Let the framework handle "cpu:VALUE" tagged tests

The tests that are already tagged with "cpu:VALUE" don't need to add "-cpu VALUE" to the list of arguments of the vm object because the avocado_qemu framework is able to handle it automatically. Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa Reviewed-by: Willian Rampazzo Signed-off-by: Wainer

[PATCH 0/2] [RESEND] SEV firmware error list touchups

Connor Kuehl (2): sev: use explicit indices for mapping firmware error codes to strings sev: add missing firmware error conditions target/i386/sev.c | 48 --- 1 file changed, 25 insertions(+), 23 deletions(-) -- 2.30.2

RE: [PATCH v3 02/30] decodetree: More use of f-strings

From: Richard Henderson > Signed-off-by: Richard Henderson > --- > scripts/decodetree.py | 50 --- > 1 file changed, 23 insertions(+), 27 deletions(-) Reviewed-by: Luis Pires

Re: [PATCH] docs: fix link in sbsa description

On Wed, 28 Apr 2021 at 14:13, Alex Bennée wrote: > > A trailing _ makes all the difference to the rendered link. > > Signed-off-by: Alex Bennée > --- > docs/system/arm/sbsa.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to target-arm.next, thanks. -- PMM

[Bug 1926759] Re: WFI instruction results in unhandled CPU exception

Crash repros on current QEMU. This is a bug, in that we shouldn't crash like this. However, it doesn't really make any sense for a userspace program (which is what a binary run by qemu-arm is) to execute the WFI instruction, which is largely intended for OSes to use. If your guest binary needs to

[Bug 1926759] Re: WFI instruction results in unhandled CPU exception

The aarch64 kernel traps and handles WFI as a NOP: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c219bc4e9205 -- so that's probably the most sensible implementation for our linux-user mode. (The aarch32 kernel doesn't trap it, yet, but "WFI is a NOP" is a valid a

Re: [PATCH v3 14/15] qemu_iotests: add option to show qemu binary logs on stdout

On 14.04.21 19:03, Emanuele Giuseppe Esposito wrote: Using the flag -p, allow the qemu binary to print to stdout. This helps especially when doing print-debugging. I think this shouldn’t refer to prints but to qemu’s stdout/stderr in general, i.e Signed-off-by: Emanuele Giuseppe Esposit

Re: [PATCH] linux-user/aarch64: Enable hwcap for RND, BTI, and MTE

On Tue, 27 Apr 2021 at 22:41, Richard Henderson wrote: > > These three features are already enabled by TCG, but are missing > their hwcap bits. Update HWCAP2 from linux v5.12. > > Cc: qemu-sta...@nongnu.org (for 6.0.1) > Buglink: https://bugs.launchpad.net/bugs/1926044 > Signed-off-by: Richard He

Re: [PATCH v3 15/15] docs/devel/testing: add -p option to the debug section of QEMU iotests

On 14.04.21 19:03, Emanuele Giuseppe Esposito wrote: Signed-off-by: Emanuele Giuseppe Esposito --- docs/devel/testing.rst | 4 1 file changed, 4 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 62902cfd2d..0c18fc4571 100644 --- a/docs/devel/testing.rst ++

Re: [PATCH v3 25/30] target/ppc: Move ADDI, ADDIS to decodetree, implement PADDI

On 29/04/2021 22:15, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/ppc/insn32.decode | 12 +++ target/ppc/insn64.decode | 15 + target/ppc/translate.c | 29 target/ppc/translate/fixed

Re: [PATCH 2/3] hw/ide: Add Kconfig dependency MICRODRIVE -> PCMCIA

Le 25/04/2021 à 00:20, Philippe Mathieu-Daudé a écrit : > The Microdrive Compact Flash can be plugged on a PCMCIA bus. > Express the dependency using the 'depends on' Kconfig expression. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/ide/Kconfig | 1 + > 1 file changed, 1 insertion(+) > >

<    1   2   3   4   5   6   >