[RFC PATCH 02/27] virtio-snd: Add jack control structures

Added structures for handling jack control requests to the header file. Signed-off-by: Shreyansh Chouhan --- include/hw/virtio/virtio-snd.h | 40 ++ 1 file changed, 40 insertions(+) diff --git a/include/hw/virtio/virtio-snd.h b/include/hw/virtio/virtio-snd.h inde

[RFC PATCH 06/27] virtio-snd: Add PCI wrapper code for VirtIOSound

Added the virito-snd.c file which contains a wrapper for combining the device with the VirtIOPCIProxy. Signed-off-by: Shreyansh Chouhan --- hw/virtio/meson.build | 1 + hw/virtio/virtio-snd-pci.c | 72 ++ 2 files changed, 73 insertions(+) create mode 10

[RFC PATCH 15/27] virtio-snd: Add VIRTIO_SND_R_PCM_INFO handler

Signed-off-by: Shreyansh Chouhan --- hw/audio/virtio-snd.c | 88 ++- 1 file changed, 87 insertions(+), 1 deletion(-) diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c index 527eed6132..bc99cd58d6 100644 --- a/hw/audio/virtio-snd.c +++ b/hw/audio/v

[RFC PATCH 09/27] virtio-snd: Add code for set config function

Signed-off-by: Shreyansh Chouhan --- hw/audio/virtio-snd.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c index afa38adee7..edaeffd6b7 100644 --- a/hw/audio/virtio-snd.c +++ b/hw/audio/virtio-snd.c @@ -54,6 +54,14 @@ static void virtio_sn

[RFC PATCH 03/27] virtio-snd: Add PCM control structures

Added structures for handle PCM control requests to the heaer file. Signed-off-by: Shreyansh Chouhan --- include/hw/virtio/virtio-snd.h | 128 + 1 file changed, 128 insertions(+) diff --git a/include/hw/virtio/virtio-snd.h b/include/hw/virtio/virtio-snd.h index f

[RFC PATCH 07/27] virtio-snd: Add properties for class init

Added properties and function stubs for virtio sound device class init. Signed-off-by: Shreyansh Chouhan --- hw/audio/Kconfig | 5 ++ hw/audio/meson.build | 1 + hw/audio/virtio-snd.c | 126 ++ 3 files changed, 132 insertions(+) create mode 1006

[RFC PATCH 20/27] virtio-snd: Add VIRITO_SND_R_PCM_START handler

Signed-off-by: Shreyansh Chouhan --- hw/audio/virtio-snd.c | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c index e5042caf9c..65104baba8 100644 --- a/hw/audio/virtio-snd.c +++ b/hw/audio/virtio-snd.c

[RFC PATCH 11/27] virtio-snd: Add macros for logging

Signed-off-by: Shreyansh Chouhan --- hw/audio/virtio-snd.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c index caad157705..a93674ea72 100644 --- a/hw/audio/virtio-snd.c +++ b/hw/audio/virtio-snd.c @@ -39,6 +39,10 @@ #define VIRTIO_SOUND

[RFC PATCH 18/27] virtio-snd: Add default configs to realize fn

Added default configurations for streams and jacks in the realize function. Signed-off-by: Shreyansh Chouhan --- hw/audio/virtio-snd.c | 40 1 file changed, 40 insertions(+) diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c index dba90cc4a7..d0a

[RFC PATCH 08/27] virtio-snd: Add code for get config function

Signed-off-by: Shreyansh Chouhan --- hw/audio/virtio-snd.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c index ae438aa7ec..afa38adee7 100644 --- a/hw/audio/virtio-snd.c +++ b/hw/audio/virtio-snd.c @@ -41,6 +41,15 @@ static void virti

[RFC PATCH 21/27] virtio-snd: Add VIRTIO_SND_R_PCM_STOP handler

Signed-off-by: Shreyansh Chouhan --- hw/audio/virtio-snd.c | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c index 65104baba8..8be3fb9bf5 100644 --- a/hw/audio/virtio-snd.c +++ b/hw/audio/virtio-snd.c

[RFC PATCH 22/27] virtio-snd: Add VIRTIO_SND_R_PCM_RELEASE handler

Signed-off-by: Shreyansh Chouhan --- hw/audio/virtio-snd.c | 66 ++- 1 file changed, 65 insertions(+), 1 deletion(-) diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c index 8be3fb9bf5..56e07a41f8 100644 --- a/hw/audio/virtio-snd.c +++ b/hw/audio/v

[RFC PATCH 10/27] virtio-snd: Add code for the realize function

Signed-off-by: Shreyansh Chouhan --- hw/audio/virtio-snd.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c index edaeffd6b7..caad157705 100644 --- a/hw/audio/virtio-snd.c +++ b/hw/audio/virtio-snd.c @@ -97,8 +9

[RFC PATCH 26/27] virtio-snd: Add event vq and a handler stub

Signed-off-by: Shreyansh Chouhan --- hw/audio/virtio-snd.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c index be9ea05e3f..2d7b7ce39a 100644 --- a/hw/audio/virtio-snd.c +++ b/hw/audio/virtio-snd.c @@ -985,6 +985,18 @@ static void

[RFC PATCH 16/27] virtio-snd: Add VIRITO_SND_R_PCM_SET_PARAMS handle

Added handler for the VIRTIO_SND_R_PCM_SET_PARAMS control request. The handler was split up into two functions in so that the code could be reused in the realize function. Signed-off-by: Shreyansh Chouhan --- hw/audio/virtio-snd.c | 100 +- 1 file changed,

[RFC PATCH 24/27] virtio-snd: Add code to device unrealize function

Signed-off-by: Shreyansh Chouhan --- hw/audio/virtio-snd.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c index 5f12375d95..e2e47e9467 100644 --- a/hw/audio/virtio-snd.c +++ b/hw/audio/virtio-snd.c @@ -1006,8 +1006,34

[RFC PATCH 12/27] virtio-snd: Add control virtqueue handler

The handler prints the requests that came in the ctrl virtqueue. Signed-off-by: Shreyansh Chouhan --- hw/audio/virtio-snd.c | 71 +++ 1 file changed, 71 insertions(+) diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c index a93674ea72..435870e3ba

Re: socket.c added support for unix domain socket datagram transport

Daniel P. Berrangé writes: > On Tue, Apr 27, 2021 at 11:52:29PM +0200, Stefano Brivio wrote: >> On Mon, 26 Apr 2021 13:56:40 +0100 >> Daniel P. Berrangé wrote: >> > The pain we're feeling is largely because the design of the net >> > option syntax is one of the oldest parts of QEMU and has only

[RFC PATCH 14/27] virtio-snd: Add stub for VIRTIO_SND_R_JACK_REMAP handler

Signed-off-by: Shreyansh Chouhan --- hw/audio/virtio-snd.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c index d50234f9a8..527eed6132 100644 --- a/hw/audio/virtio-snd.c +++ b/hw/audio/virtio-snd.c @@ -175

[RFC PATCH 17/27] virtio-snd: Add VIRTIO_SND_R_PCM_PREPARE handler

The handler doesn't intialize the SWVoiceOut streams for now. Signed-off-by: Shreyansh Chouhan --- hw/audio/virtio-snd.c | 198 +- 1 file changed, 197 insertions(+), 1 deletion(-) diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c index 4e9764de08

[RFC PATCH 19/27] virtio-snd: Add callback for SWVoiceOut

Added the callback for writing audio using AUD_write. The callback uses two helper functions for reading the buffers from the streams and handling the buffers that were written. initialized the SWVoiceOut using this callback. Signed-off-by: Shreyansh Chouhan --- hw/audio/virtio-snd.c | 171 +

[RFC PATCH 23/27] virtio-snd: Replaced goto with if else

Removed goto from the ctrl vq handler and added an if else branch for error handling. Signed-off-by: Shreyansh Chouhan --- hw/audio/virtio-snd.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c index 56e07a4

[RFC PATCH 25/27] virtio-snd: Add tx vq and handler

The handler demultiplexes the buffers recieved in the tx virtqueue. It uses a helper function for adding these buffers, (along with the entire virtqueue element,) to their respective streams. Signed-off-by: Shreyansh Chouhan --- hw/audio/virtio-snd.c | 62

[RFC PATCH 27/27] virtio-snd: Add rx vq and stub handler

Signed-off-by: Shreyansh Chouhan --- hw/audio/virtio-snd.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c index 2d7b7ce39a..6a1d3e824c 100644 --- a/hw/audio/virtio-snd.c +++ b/hw/audio/virtio-snd.c @@ -997,6 +997,18 @@ static void

Re: Let's remove some deprecated stuff

Hi, > For this to go away, I'd rather have something like the -nic option that > provides an easy way to set up the front end and back end. > > In other words you would do something like -audiohw > ,model=xxx and it gets desugared automatically to either > >-audiodev ,id=foo -device devnam

Re: [PATCH 4/5] virtio: Fail if iommu_platform is requested, but unsupported

Got it - thanks for the clarification. Reviewed-by: Raphael Norwitz On Thu, Apr 29, 2021 at 11:34:11AM +0200, Kevin Wolf wrote: > Am 28.04.2021 um 21:24 hat Raphael Norwitz geschrieben: > > On Thu, Apr 22, 2021 at 07:02:20PM +0200, Kevin Wolf wrote: > > > Commit 2943b53f6 (' virtio: force VIRTIO

Re: [PATCH 1/5] vhost-user-blk: Don't reconnect during initialisation

Am 22.04.2021 um 19:02 hat Kevin Wolf geschrieben: > This is a partial revert of commits 77542d43149 and bc79c87bcde. > > Usually, an error during initialisation means that the configuration was > wrong. Reconnecting won't make the error go away, but just turn the > error condition into an endless

Re: [RFC PATCH 00/27] Virtio sound card implementation

Patchew URL: https://patchew.org/QEMU/20210429120445.694420-1-chouhan.shreyansh2...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210429120445.694420-1-chouhan.shreyansh2...@gmail.com Subject: [RFC PATCH

Re: [PATCH 2/5] vhost-user-blk: Use Error more consistently

Makes sense - I see why it makes reporting better at realize time. Thanks for the clarification. On Thu, Apr 29, 2021 at 11:26:29AM +0200, Kevin Wolf wrote: > Am 28.04.2021 um 20:08 hat Raphael Norwitz geschrieben: > > Code looks ok - question about the commit message. > > > > Acked-by: Raphael

Re: [PATCH v4 12/12] tests/meson: Only build softfloat objects if TCG is selected

On 4/28/21 9:12 PM, Philippe Mathieu-Daudé wrote: > On 4/28/21 9:04 PM, Alex Bennée wrote: >> >> Philippe Mathieu-Daudé writes: >> >>> On 4/28/21 7:06 PM, Alex Bennée wrote: Philippe Mathieu-Daudé writes: > Alex, Richard, do you mind reviewing this one please? Isn't it alr

Re: [PATCH] make vfio and DAX cache work together

On Thu, 29 Apr 2021 09:44:51 +0100 "Dr. David Alan Gilbert" wrote: > * Alex Williamson (alex.william...@redhat.com) wrote: > > On Wed, 28 Apr 2021 20:17:23 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Dev Audsin (dev.devaq...@gmail.com) wrote: > > > > Thanks Dave for your explanati

Re: Let's remove some deprecated stuff

Am 29.04.2021 um 14:40 hat Gerd Hoffmann geschrieben: > Hi, > > > For this to go away, I'd rather have something like the -nic option that > > provides an easy way to set up the front end and back end. > > > > In other words you would do something like -audiohw > > ,model=xxx and it gets desuga

Re: [PATCH v5 01/10] util: vfio-helpers: Factor out and fix processing of existing ram blocks

On 4/29/21 1:26 PM, David Hildenbrand wrote: > Factor it out into common code when a new notifier is registered, just > as done with the memory region notifier. This keeps logic about how to > process existing ram blocks at a central place. > > Just like when adding a new ram block, we have to reg

Re: [PATCH v2 2/2] gitlab-ci: Add a job to build virtiofsd standalone

Hi, On 4/29/21 5:33 AM, Philippe Mathieu-Daudé wrote: Add a job which builds virtiofsd without any emulation or tool. Signed-off-by: Philippe Mathieu-Daudé --- https://gitlab.com/philmd/qemu/-/jobs/1222007991 Duration: 7 minutes 48 seconds --- .gitlab-ci.yml | 13 + 1 file chang

Re: [PATCH v2 2/2] gitlab-ci: Add a job to build virtiofsd standalone

On 4/29/21 3:16 PM, Wainer dos Santos Moschetta wrote: > Hi, > > On 4/29/21 5:33 AM, Philippe Mathieu-Daudé wrote: >> Add a job which builds virtiofsd without any emulation or tool. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> https://gitlab.com/philmd/qemu/-/jobs/1222007991 >> Duration:

Re: [PATCH v4 10/12] qtest/qmp-cmd-test: Make test build-independent from accelerator

Philippe Mathieu-Daudé writes: > On 4/29/21 7:43 AM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> Now than we can probe if the TCG accelerator is available >>> at runtime with a QMP command, do it once at the beginning >>> and only register the tests we can run. >>> We can

[PATCH v3 0/9] qapi: untie 'if' conditions from C preprocessor

From: Marc-André Lureau Hi, This series makes the 'if' conditions less liberal, by formalizing a simple expression tree based on bare boolean logic of configure option identifiers. (this allows to express conditions in Rust in my QAPI-Rust PoC series) This is based on John Snow QAPI pt4: https

[PATCH v3 1/9] qapi: replace List[str] by QAPISchemaIfCond

From: Marc-André Lureau Wrap the 'if' condition in a higher-level object. Not only this allows more type safety but also further refactoring without too much churn. The following patches will change the syntax of the schema 'if' conditions to be predicate expressions, and will generate code for

[PATCH v3 2/9] qapi: move gen_if/gen_endif to QAPISchemaIfCond

From: Marc-André Lureau Move the generating function to the QAPISchemaIfCond class. Signed-off-by: Marc-André Lureau --- scripts/qapi/common.py | 20 +--- scripts/qapi/gen.py| 6 ++ scripts/qapi/introspect.py | 11 +++ scripts/qapi/schema.py | 18 ++

[PATCH v3 4/9] qapi: introduce IfPredicateList and IfAny

From: Marc-André Lureau Refactor IfAll class, to introduce a base class IfPredicateList and add IfAny for the 'any' conditions. Signed-off-by: Marc-André Lureau --- scripts/qapi/common.py | 32 +++- 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/scri

[PATCH v3 7/9] qapi: convert 'if' C-expressions to the new syntax tree

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- qapi/machine-target.json | 20 qapi/misc-target.json| 13 - 2 files changed, 28 insertions(+), 5 deletions(-) diff --git a/qapi/machine-target.json b/qapi/machine-target.json index e7811654b7..9b5

[PATCH v3 3/9] qapi: start building an 'if' predicate tree

From: Marc-André Lureau The following patches are going to express schema 'if' conditions in a target language agnostic way. For that, let's start building a predicate tree of the configuration options. This intermediary steps still uses C-preprocessor expressions as the predicates: "if: [STR,

[PATCH v3 8/9] qapi: make 'if' condition strings simple identifiers

From: Marc-André Lureau Change the 'if' condition strings to be C-agnostic and be simple identifiers. Signed-off-by: Marc-André Lureau --- docs/devel/qapi-code-gen.txt | 8 +-- qapi/block-core.json | 16 ++--- qapi/block-export.json

[PATCH v3 6/9] qapi: normalize 'if' condition to IfPredicate tree

From: Marc-André Lureau Modify check_if() to build an IfPredicate tree (the schema documentation is updated in a following patch). Signed-off-by: Marc-André Lureau --- tests/unit/test-qmp-cmds.c| 1 + scripts/qapi/expr.py | 62 ++-

[PATCH v3 5/9] qapi: add IfNot

From: Marc-André Lureau Introduce IfNot predicate class, for 'not' condition expressions. Signed-off-by: Marc-André Lureau --- scripts/qapi/common.py | 22 ++ 1 file changed, 22 insertions(+) diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py index 102d347348..62

[PATCH v3 9/9] docs: update the documentation about schema configuration

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- docs/devel/qapi-code-gen.txt | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt index edaaf7ec40..4a3fd02723 100644 --- a/docs/

Re: Let's remove some deprecated stuff

Hi, > Another option might be that you just nest things: > > { 'struct': 'AudioConfig', > 'data': { > 'model': 'AudioDevice', > 'backend': 'Audiodev' } } > > Possibly instead of 'model' on the top level, you'll actually want to > nest there, too, and accept device properties. Hm

Re: [PATCH v2 1/2] meson: Select 'have_system' when virtiofsd is enabled

On 4/29/21 3:33 AM, Philippe Mathieu-Daudé wrote: > When not explicitly select a sysemu target and building virtiofsd, > the seccomp/cap-ng libraries are not resolved, leading to this error: > > $ configure --target-list=i386-linux-user --disable-tools --enable-virtiofsd > tools/meson.build:12

Re: [PATCH v1 18/25] tests/tcg/tricore: Add clz test

On Mon, Apr 19, 2021 at 03:54:28PM +0100, Alex Bennée wrote: > From: Bastian Koppelmann > > Tested-by: Alex Bennée > Signed-off-by: Bastian Koppelmann > Signed-off-by: Alex Bennée > Message-Id: <20210305170045.869437-9-kbast...@mail.uni-paderborn.de> > --- > tests/tcg/tricore/Makefile.softmmu

Re: [RFC v9 15/29] vfio: Set up nested stage mappings

Hi Kunkun, On 4/28/21 11:51 AM, Kunkun Jiang wrote: > Hi Eric, > > On 2021/4/27 3:16, Auger Eric wrote: >> Hi Kunkun, >> >> On 4/15/21 4:03 AM, Kunkun Jiang wrote: >>> Hi Eric, >>> >>> On 2021/4/14 16:05, Auger Eric wrote: Hi Kunkun, On 4/14/21 3:45 AM, Kunkun Jiang wrote: > On

Re: [PATCH 2/2] spapr.h: increase FDT_MAX_SIZE

On 4/8/21 10:40 PM, Daniel Henrique Barboza wrote: > Certain SMP topologies stress, e.g. 1 thread/core, 2048 cores and > 1 socket, stress the current maximum size of the pSeries FDT: > > Calling ibm,client-architecture-support...qemu-system-ppc64: error > creating device tree: (fdt_setprop(fdt, of

[PATCH v3] migration: Drop redundant query-migrate result @blocked

Result @blocked is redundant. Unfortunately, we realized this too close to the release to risk dropping it, so we deprecated it instead, in commit e11ce6c06. Since it was deprecated from the start, we can delete it without the customary grace period. Do so. Signed-off-by: Markus Armbruster Rev

[ANNOUNCE] libblkio v0.1.0 preview release

Hi, A preview release of libblkio, a library for high-performance block I/O, is now available: https://gitlab.com/libblkio/libblkio/-/tree/v0.1.0 Applications are increasingly integrating high-performance I/O interfaces such as Linux io_uring, userspace device drivers, and vhost-user device sup

[PATCH v3 3/3] hw/core/loader: clear uninitialized ROM space

As for "hw/elf_ops: clear uninitialized segment space" we need to clear the uninitialized space when the ELF is set in ROM. Signed-off-by: Laurent Vivier --- hw/core/loader.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/core/loader.c b/hw/core/loader.c index d3e5f3b423f6..8146fdcbb

[PATCH v3 0/3] hw/elf_ops: clear uninitialized segment space

When the mem_size of the segment is bigger than the file_size, and if this space doesn't overlap another segment, it needs to be cleared. When the file is loaded in RAM, it is cleared by the loader (PATCH 2), when the file is loaded in a ROM, the space is cleared on reset, when the data of the fil

[PATCH v3 2/3] hw/elf_ops: clear uninitialized segment space

When the mem_size of the segment is bigger than the file_size, and if this space doesn't overlap another segment, it needs to be cleared. This bug is very similar to the one we had for linux-user, 22d113b52f41 ("linux-user: Fix loading of BSS segments"), where .bss section is encoded as an extensi

[PATCH v3 1/3] exec/memory: Extract address_space_set() from dma_memory_set()

From: Philippe Mathieu-Daudé dma_memory_set() does a DMA barrier, set the address space with a constant value. The constant value filling code is not specific to DMA and can be used for AddressSpace. Extract it as a new helper: address_space_set(). Signed-off-by: Philippe Mathieu-Daudé Reviewed

Re: [ANNOUNCE] libblkio v0.1.0 preview release

On Thu, Apr 29, 2021 at 03:05:50PM +0100, Stefan Hajnoczi wrote: > The purpose of this preview release is to discuss both the API design > and general direction of the project. API documentation is available > here: > > https://gitlab.com/libblkio/libblkio/-/blob/v0.1.0/docs/blkio.rst libvirt o

Re: [Bug 1926111] [NEW] Assertion `tx_queue_idx <= s->txq_num' failed in vmxnet3_io_bar0_write

Cc'ing maintainers. ./scripts/get_maintainer.pl -f hw/net/vmxnet3.c Dmitry Fleytman (maintainer:Vmware) Jason Wang (odd fixer:Network devices) On 4/26/21 5:19 AM, Alexander Bulekov wrote: > Public bug reported: > > === Stacktrace === > > qemu-fuzz-i386: ../hw/net/vmxnet3.c:1096: void vmxnet3_

Re: [ANNOUNCE] libblkio v0.1.0 preview release

On Thu, Apr 29, 2021 at 03:22:59PM +0100, Richard W.M. Jones wrote: > On Thu, Apr 29, 2021 at 03:05:50PM +0100, Stefan Hajnoczi wrote: > > The purpose of this preview release is to discuss both the API design > > and general direction of the project. API documentation is available > > here: > > >

Re: Let's remove some deprecated stuff

On Thu, Apr 29, 2021 at 11:59:41AM +0200, Markus Armbruster wrote: > Stefan Hajnoczi: > > ``-device virtio-blk,scsi=on|off`` (since 5.0.0) > > > The virtio-blk SCSI passthrough feature is a legacy VIRTIO feature. > VIRTIO 1.0 > an

Re: [PATCH v4 02/12] accel: Introduce 'query-accels' QMP command

Philippe Mathieu-Daudé writes: > Introduce the 'query-accels' QMP command which returns a list > of built-in accelerator names. > > - Accelerator is a QAPI enum of all existing accelerators, > > - AcceleratorInfo is a QAPI structure providing accelerator > specific information. Currently the

Re: [PATCH v4 03/12] tests/qtest: Add qtest_has_accel() method

Philippe Mathieu-Daudé writes: > Introduce the qtest_has_accel() method which allows a runtime > query on whether a QEMU instance has an accelerator built-in. > > Reviewed-by: Eric Blake > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v3 3/3] hw/core/loader: clear uninitialized ROM space

On 4/29/21 4:13 PM, Laurent Vivier wrote: > As for "hw/elf_ops: clear uninitialized segment space" we need to > clear the uninitialized space when the ELF is set in ROM. > > Signed-off-by: Laurent Vivier > --- > hw/core/loader.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/hw/co

Re: [PATCH v4 04/12] qtest/arm-cpu-features: Use generic qtest_has_accel() to check for KVM

Philippe Mathieu-Daudé writes: > Use the recently added generic qtest_has_accel() method to > check if KVM is available. > > Suggested-by: Claudio Fontana > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée -- Alex Bennée

Re: [ANNOUNCE] libblkio v0.1.0 preview release

On Thu, Apr 29, 2021 at 03:41:29PM +0100, Stefan Hajnoczi wrote: > On Thu, Apr 29, 2021 at 03:22:59PM +0100, Richard W.M. Jones wrote: > > On Thu, Apr 29, 2021 at 03:05:50PM +0100, Stefan Hajnoczi wrote: > > > The purpose of this preview release is to discuss both the API design > > > and general d

Re: Let's remove some deprecated stuff

On 4/29/21 3:46 PM, Gerd Hoffmann wrote: > Hmm. Not so easy I suspect. While most sound cards map to a single > device there are exceptions. pcspk is build-in and hda is two devices. What do you mean by "pcspk is build-in"? Do you mean "the 'pcspk' audiodev is build in the 8254 PIT device"? (

[Bug 1880518] Re: issue while installing docker inside s390x container

Looks like docker in docker for cross architectures is not yet supported in qemu. can be closed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1880518 Title: issue while installing docker inside s

Re: [ANNOUNCE] libblkio v0.1.0 preview release

On Thu, Apr 29, 2021 at 04:00:38PM +0100, Richard W.M. Jones wrote: > On Thu, Apr 29, 2021 at 03:41:29PM +0100, Stefan Hajnoczi wrote: > > On Thu, Apr 29, 2021 at 03:22:59PM +0100, Richard W.M. Jones wrote: > > > On Thu, Apr 29, 2021 at 03:05:50PM +0100, Stefan Hajnoczi wrote: > > > > The purpose o

Re: [PATCH v4 10/12] qtest/qmp-cmd-test: Make test build-independent from accelerator

On 4/29/21 3:22 PM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: Now than we can probe if the TCG accelerator is available at runtime with a QMP command, do it once at the beginning and only register the tests we can run. We can then replace the #ifdef'ry by a runt

Re: [PATCH v2 1/2] meson: Select 'have_system' when virtiofsd is enabled

On 4/29/21 3:50 PM, Connor Kuehl wrote: > On 4/29/21 3:33 AM, Philippe Mathieu-Daudé wrote: >> When not explicitly select a sysemu target and building virtiofsd, >> the seccomp/cap-ng libraries are not resolved, leading to this error: >> >> $ configure --target-list=i386-linux-user --disable-tool

Re: [PATCH v2 1/2] meson: Select 'have_system' when virtiofsd is enabled

* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > On 4/29/21 3:50 PM, Connor Kuehl wrote: > > On 4/29/21 3:33 AM, Philippe Mathieu-Daudé wrote: > >> When not explicitly select a sysemu target and building virtiofsd, > >> the seccomp/cap-ng libraries are not resolved, leading to this error: > >>

Re: [ANNOUNCE] libblkio v0.1.0 preview release

On Thu, Apr 29, 2021 at 04:08:22PM +0100, Daniel P. Berrangé wrote: > On Thu, Apr 29, 2021 at 04:00:38PM +0100, Richard W.M. Jones wrote: > > On Thu, Apr 29, 2021 at 03:41:29PM +0100, Stefan Hajnoczi wrote: > > > On Thu, Apr 29, 2021 at 03:22:59PM +0100, Richard W.M. Jones wrote: > > > > On Thu, Ap

Re: [ANNOUNCE] libblkio v0.1.0 preview release

On Thu, Apr 29, 2021 at 04:31:41PM +0100, Richard W.M. Jones wrote: > On Thu, Apr 29, 2021 at 04:08:22PM +0100, Daniel P. Berrangé wrote: > > On Thu, Apr 29, 2021 at 04:00:38PM +0100, Richard W.M. Jones wrote: > > > On Thu, Apr 29, 2021 at 03:41:29PM +0100, Stefan Hajnoczi wrote: > > > > On Thu, Ap

Re: [PATCH v3 06/26] DAX subprojects/libvhost-user: Add virtio-fs slave types

* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > Add virtio-fs definitions to libvhost-user > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: Stefan Hajnoczi I'm going to need to rework this > +/* Structures carried over the slave channe

[PATCH] virtio-blk: drop deprecated scsi=on|off property

The scsi=on|off property was deprecated in QEMU 5.0 and can be removed completely at this point. Drop the scsi=on|off option. It was only available on Legacy virtio-blk devices. Linux v5.6 already dropped support for it. Remove the hw_compat_2_4[] property assignment since scsi=on|off no longer e

Re: [ANNOUNCE] libblkio v0.1.0 preview release

Am 29.04.2021 um 16:05 hat Stefan Hajnoczi geschrieben: > Hi, > A preview release of libblkio, a library for high-performance block I/O, > is now available: > > https://gitlab.com/libblkio/libblkio/-/tree/v0.1.0 > > Applications are increasingly integrating high-performance I/O > interfaces suc

Re: [PATCH v4 0/3] nvdimm: Enable sync-dax property for nvdimm

On Wed, Apr 28, 2021 at 11:48:21PM -0400, Shivaprasad G Bhat wrote: > The nvdimm devices are expected to ensure write persistence during power > failure kind of scenarios. > > The libpmem has architecture specific instructions like dcbf on POWER > to flush the cache data to backend nvdimm device d

RE: [PATCH v4 11/12] target/hexagon: call idef-parser functions

> -Original Message- > From: Alessandro Di Federico > Sent: Thursday, April 15, 2021 11:35 AM > To: qemu-devel@nongnu.org > Cc: Taylor Simpson ; Brian Cain > ; bab...@rev.ng; ni...@rev.ng; phi...@redhat.com; > richard.hender...@linaro.org; Alessandro Di Federico > Subject: [PATCH v4 11

Re: [PATCH v11 1/6] arm64: mte: Sync tags for pages where PTE is untagged

On 27/04/2021 18:43, Catalin Marinas wrote: On Fri, Apr 16, 2021 at 04:43:04PM +0100, Steven Price wrote: A KVM guest could store tags in a page even if the VMM hasn't mapped the page with PROT_MTE. So when restoring pages from swap we will need to check to see if there are any saved tags even i

Re: [PATCH v11 5/6] KVM: arm64: ioctl to fetch/store tags in a guest

On 27/04/2021 18:58, Catalin Marinas wrote: On Fri, Apr 16, 2021 at 04:43:08PM +0100, Steven Price wrote: diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h index 24223adae150..2b85a047c37d 100644 --- a/arch/arm64/include/uapi/asm/kvm.h +++ b/arch/arm64/include/u

Re: [PATCH v11 2/6] arm64: kvm: Introduce MTE VM feature

On 28/04/2021 18:07, Catalin Marinas wrote: On Fri, Apr 16, 2021 at 04:43:05PM +0100, Steven Price wrote: diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c index 77cb2d28f2a4..5f8e165ea053 100644 --- a/arch/arm64/kvm/mmu.c +++ b/arch/arm64/kvm/mmu.c @@ -879,6 +879,26 @@ static int user_me

Re: [PATCH] virtio-blk: drop deprecated scsi=on|off property

On Thu, Apr 29, 2021 at 16:52:21 +0100, Stefan Hajnoczi wrote: > The scsi=on|off property was deprecated in QEMU 5.0 and can be removed > completely at this point. > > Drop the scsi=on|off option. It was only available on Legacy virtio-blk > devices. Linux v5.6 already dropped support for it. > >

[PATCH v2 0/7] target/ppc: untangle cpu init from translation

This patch series aims to remove the logic of initializing CPU from the file related to TCG translation. To achieve this, we have to make it so registering SPRs isn't directly tied to TCG, and move code only related to translation out of translate_init.c.inc and into translate.c. This is in prepara

[PATCH v2 3/7] target/ppc: Isolated SPR read/write callbacks

Moved all SPR read/write callback, and some related functions, to a new file specific for it. These callbacks are TCG only, so separating them is required to support the flag disable-tcg. Making the spr_noaccess function not static, and moving the define to internal.h is required, as spr_tcg.c.inc

[PATCH v2 4/7] target/ppc: turned SPR R/W callbacks not static

To be able to compile translate_init.c.inc as a standalone file, we have to make the callbacks accessible outside of translate.c; This patch does that, making the callbacks not static and creating a new .h file Signed-off-by: Bruno Larsen (billionai) --- target/ppc/spr_tcg.c.inc | 203 ++

[PATCH v2 1/7] target/ppc: move opcode table logic to translate.c

code motion to remove opcode callback table from translate_init.c.inc to translate.c in preparation to remove the #include from translate.c. Also created destroy_ppc_opcodes and removed that logic from ppc_cpu_unrealize Signed-off-by: Bruno Larsen (billionai) --- target/ppc/internal.h

[PATCH v2 7/7] target/ppc: isolated cpu init from translation logic

finished isolation of CPU initialization logic from translation logic. CPU initialization now only has common code which may or may not call accelerator-specific code, as the build options require, and is compiled separately. Signed-off-by: Bruno Larsen (billionai) --- target/ppc/{translate_init

[PATCH v2 2/7] target/ppc: Created !TCG SPR registration macro

Added macros for spr_register and spr_register_kvm that can ignore SPR RW callbacks, in preparation to support building without TCG. Signed-off-by: Bruno Larsen (billionai) --- target/ppc/translate_init.c.inc | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --g

[PATCH v2 5/7] target/ppc: removed VSCR from SPR registration

Since vscr is not an spr, its initialization was removed from the spr registration functions, and moved to the relevant init_procs. We may look into adding vscr to the reset path instead of the init path (as suggested by David Gibson), but this looked like a good enough solution for now. Signed-o

[PATCH v2 6/7] target/ttc: renamed SPR registration functions

Renamed all gen_spr_* and gen_* functions specifically related to registering SPRs to register_*_sprs and register_*, to avoid future confusion with other TCG related code. Signed-off-by: Bruno Larsen (billionai) --- target/ppc/translate_init.c.inc | 860 1 file

RE: [PATCH v2 04/15] target/ppc: Move DISAS_NORETURN setting into gen_exception*

> > -static inline void gen_stop_exception(DisasContext *ctx) > > +static inline void gen_end_tb_exception(DisasContext *ctx, uint32_t > > +excp) > > { > > -gen_update_nip(ctx, ctx->base.pc_next); > > -ctx->exception = POWERPC_EXCP_STOP; > > +/* No need to update nip for SYNC/BRANCH,

Re: [PATCH v4 0/3] nvdimm: Enable sync-dax property for nvdimm

On 4/29/21 9:25 PM, Stefan Hajnoczi wrote: On Wed, Apr 28, 2021 at 11:48:21PM -0400, Shivaprasad G Bhat wrote: The nvdimm devices are expected to ensure write persistence during power failure kind of scenarios. The libpmem has architecture specific instructions like dcbf on POWER to flush the c

[PATCH v2 6/6] vhost-user-blk: Check that num-queues is supported by backend

Creating a device with a number of queues that isn't supported by the backend is pointless, the device won't work properly and the error messages are rather confusing. Just fail to create the device if num-queues is higher than what the backend supports. Since the relationship between num-queues

[PATCH v2 0/6] vhost-user-blk: Error handling fixes during initialistion

vhost-user-blk neglects for several properties to check whether the configured value is even compatible with the backend. This results sometimes in crashes because of buggy error handling code, and sometimes in devices that are presented differently to the guest than the backend would expect and th

[PATCH v2 3/6] vhost-user-blk: Improve error reporting in realize

Now that vhost_user_blk_connect() is not called from an event handler any more, but directly from vhost_user_blk_device_realize(), we can actually make use of Error again instead of calling error_report() in the inner function and setting a more generic and therefore less useful error message in re

[PATCH v2 2/6] vhost-user-blk: Don't reconnect during initialisation

This is a partial revert of commits 77542d43149 and bc79c87bcde. Usually, an error during initialisation means that the configuration was wrong. Reconnecting won't make the error go away, but just turn the error condition into an endless loop. Avoid this and return errors again. Additionally, cal

Re: [PATCH 1/5] vhost-user-blk: Don't reconnect during initialisation

On Thu, Apr 29, 2021 at 02:48:52PM +0200, Kevin Wolf wrote: > So maybe patch 2 should come first and also fix the preexisting bug, and > of course this patch needs a v2 that doesn't introduce the new instances > of the bug. Sounds good to me. > > Kevin >

[PATCH v2 1/6] vhost-user-blk: Make sure to set Error on realize failure

We have to set errp before jumping to virtio_err, otherwise the caller (virtio_device_realize()) will take this as success and crash when it later tries to access things that we've already freed in the error path. Fixes: 77542d431491788d1e8e79d93ce10172ef207775 Signed-off-by: Kevin Wolf --- hw/b

Re: Incorrect NVMe DLFEAT?

On Apr 29 16:51, Harris, James R wrote: Hi, Hi Jim, I’m seeing SPDK test failures with QEMU NVMe controllers that I’ve bisected to QEMU commit 2605257a26 (“hw/block/nvme: add the dataset management command”). The failing tests are related to write zeroes handling. If an NVMe controller

<    1   2   3   4   >