Re: [PATCH] qapi: deprecate drive-backup

2021-04-26 Thread Peter Krempa
On Fri, Apr 23, 2021 at 15:59:00 +0300, Vladimir Sementsov-Ogievskiy wrote: > Modern way is using blockdev-add + blockdev-backup, which provides a > lot more control on how target is opened. > > As example of drive-backup problems consider the following: > > User of drive-backup expects that targ

Re: [PULL 1/2] amd_iommu: Fix pte_override_page_mask()

2021-04-26 Thread Jean-Philippe Brucker
On Fri, Apr 23, 2021 at 05:11:33PM +0100, Peter Maydell wrote: > > > Jean-Philippe, do you know if this is a regression since 5.2? > > > > I don't think so, I can reproduce it with v5.2.0. > > OK, thanks; I think I favour not putting this into rc5, then. No problem, please let me know if I should

[PATCH] hw/block/nvme: fix csi field for cns 0x00 and 0x11

2021-04-26 Thread Gollu Appalanaidu
As per the TP 4056d Namespace types CNS 0x00 and CNS 0x11 CSI field shouldn't use but it is being used for these two Identify command CNS values, fix that. Signed-off-by: Gollu Appalanaidu --- hw/nvme/ctrl.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/nvme/

Re: [PATCH 00/14] hw(/block/)nvme: spring cleaning

2021-04-26 Thread Klaus Jensen
On Apr 19 21:27, Klaus Jensen wrote: From: Klaus Jensen This series consists of various clean up patches. The final patch moves nvme emulation from hw/block to hw/nvme. Klaus Jensen (14): hw/block/nvme: rename __nvme_zrm_open hw/block/nvme: rename __nvme_advance_zone_wp hw/block/nvme: rena

[PATCH 1/1] amd_iommu: fix wrong MMIO operations

2021-04-26 Thread Roman Kapl
Address was swapped with value when writing MMIO registers, so the user saw garbage in lot of cases. The interrupt status was not correctly set. Signed-off-by: Roman Kapl --- hw/i386/amd_iommu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/i386/amd_iommu.c b/hw/i3

Re: [PATCH] hw/pci-host: Do not build gpex-acpi.c if GPEX is not selected

2021-04-26 Thread Gerd Hoffmann
On Sun, Apr 25, 2021 at 08:21:24PM +0200, Philippe Mathieu-Daudé wrote: > Since its introduction in commit 5b85eabe68f ("acpi: add > acpi_dsdt_add_gpex") we build gpex-acpi.c if ACPI is selected, > even if the GPEX_HOST device isn't build. Add the missing > Kconfig dependency. > > Signed-off-by: P

Re: [PATCH v3 06/33] util/async: aio_co_schedule(): support reschedule in same ctx

2021-04-26 Thread Vladimir Sementsov-Ogievskiy
23.04.2021 13:09, Roman Kagan wrote: On Fri, Apr 16, 2021 at 11:08:44AM +0300, Vladimir Sementsov-Ogievskiy wrote: With the following patch we want to call wake coroutine from thread. And it doesn't work with aio_co_wake: Assume we have no iothreads. Assume we have a coroutine A, which waits in

Re: [PULL 15/24] bsd-user: Fix commentary issues

2021-04-26 Thread Daniel P . Berrangé
On Fri, Apr 23, 2021 at 02:39:50PM -0600, i...@bsdimp.com wrote: > From: Warner Losh > > Lines > 80 or 90 characters > C++ comments > BSD /*- block comment convention removed. > > Signed-off-by: Warner Losh > --- > bsd-user/bsd-mman.h | 42 ++ > 1 file c

[Bug 1895305] Re: pthread_cancel fails with "RT33" with musl libc

2021-04-26 Thread Ariadne Conill
This was a downstream regression in Alpine caused by an attempt to make older Go binaries work under emulation. We have reverted the patch there. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1895305

Re: Resetting non-qdev children in a 3-phase reset device

2021-04-26 Thread Peter Maydell
On Mon, 26 Apr 2021 at 06:19, Markus Armbruster wrote: > device_legacy_reset() is deprecated: > > /** > * device_legacy_reset: > * > * Reset a single device (by calling the reset method). > * Note: This function is deprecated and will be removed when it becomes > unused. >

Re: [PATCH 03/11] block/block-gen.h: bind monitor

2021-04-26 Thread Vladimir Sementsov-Ogievskiy
24.04.2021 08:23, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: If we have current monitor, let's bind it to wrapper coroutine too. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/block-gen.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/block/block

Re: [PULL 15/24] bsd-user: Fix commentary issues

2021-04-26 Thread Peter Maydell
On Mon, 26 Apr 2021 at 10:01, Daniel P. Berrangé wrote: > > On Fri, Apr 23, 2021 at 02:39:50PM -0600, i...@bsdimp.com wrote: > > -#define TARGET_FREEBSD_MAP_RESERVED0080 0x0080 /* previously > > misimplemented MAP_INHERIT */ > > -#define TARGET_FREEBSD_MAP_RESERVED0100 0x0100 /* previously > >

[Bug 1749393] Re: sbrk() not working under qemu-user with a PIE-compiled binary?

2021-04-26 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/401771 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1749393 Title: sbrk() not working under q

Re: Resetting non-qdev children in a 3-phase reset device

2021-04-26 Thread Philippe Mathieu-Daudé
On 4/25/21 8:33 PM, Peter Maydell wrote: > On Sat, 24 Apr 2021 at 14:04, Philippe Mathieu-Daudé wrote: >> I now understand better the diag288 case, but I still don't understand >> the TYPE_APIC one. It has no DeviceClass::reset(), its abstract parent >> TYPE_APIC_COMMON register apic_reset_common(

Windows Cirrus Build broken

2021-04-26 Thread Alex Bennée
Hi Yonggang, It looks like the Windows msys2 build has been broken a while on Cirrus: Last working: https://cirrus-ci.com/task/6239849435889664 First broken: https://cirrus-ci.com/task/5344535250206720 History: https://cirrus-ci.com/github/qemu/qemu While the green to red points the f

Re: [PATCH for-6.0 v2 1/2] hw/block/nvme: fix invalid msix exclusive uninit

2021-04-26 Thread Philippe Mathieu-Daudé
On 4/26/21 6:40 AM, Klaus Jensen wrote: > On Apr 23 07:21, Klaus Jensen wrote: >> From: Klaus Jensen >> >> Commit 1901b4967c3f changed the nvme device from using a bar exclusive >> for MSI-x to sharing it on bar0. >> >> Unfortunately, the msix_uninit_exclusive_bar() call remains in >> nvme_exit()

[Bug 1749393] Re: sbrk() not working under qemu-user with a PIE-compiled binary?

2021-04-26 Thread Christian Ehrhardt 
** Description changed: + [Impact] + + * The current space reserved can be too small and we can end up +with no space at all for BRK. It can happen to any case, but is +much more likely with the now common PIE binaries. + + * Backport the upstream fix which reserves a bit more space wh

Re: Resetting non-qdev children in a 3-phase reset device

2021-04-26 Thread Peter Maydell
On Mon, 26 Apr 2021 at 10:23, Philippe Mathieu-Daudé wrote: > > On 4/25/21 8:33 PM, Peter Maydell wrote: > > On Sat, 24 Apr 2021 at 14:04, Philippe Mathieu-Daudé > > wrote: > >> I now understand better the diag288 case, but I still don't understand > >> the TYPE_APIC one. It has no DeviceClass::

First time patch not reflected in the mailing list

2021-04-26 Thread Edge NFV
Hi I sent a patch around four hours back but I doesn't seem to be reflected on to the mailing list. That patch was my first mail to this mail list. I understand that this a moderated list and the first message needs to be white listed by the moderator. Please let me know how long it will take to w

Re: [PATCH v1 13/25] hw/tricore: Add testdevice for tests in tests/tcg/

2021-04-26 Thread Philippe Mathieu-Daudé
On 4/19/21 4:54 PM, Alex Bennée wrote: > From: Bastian Koppelmann > > this device is used to verify the correctness of regression tests by > allowing guests to write their exit status to this device. This is then > used by qemu to exit using the written status. > > Reviewed-by: Alex Bennée > Si

[Bug 1925496] Re: nvme disk cannot be hotplugged after removal

2021-04-26 Thread Oguz Bektas
BTW Re: Regression, I think it's not, because this didn't work a year ago either, but I wasn't sure if it's a bug. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1925496 Title: nvme disk cannot be h

Re: [PATCH for-6.0 v2 1/2] hw/block/nvme: fix invalid msix exclusive uninit

2021-04-26 Thread Klaus Jensen
On Apr 26 11:27, Philippe Mathieu-Daudé wrote: On 4/26/21 6:40 AM, Klaus Jensen wrote: On Apr 23 07:21, Klaus Jensen wrote: From: Klaus Jensen Commit 1901b4967c3f changed the nvme device from using a bar exclusive for MSI-x to sharing it on bar0. Unfortunately, the msix_uninit_exclusive_bar(

[Bug 1749393] Re: sbrk() not working under qemu-user with a PIE-compiled binary?

2021-04-26 Thread Christian Ehrhardt 
For Focal: - SRU Template added to the bug - MP: https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/401771 - PPA: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4535/+packages (still building) I'd ask anyone affected by this on Focal to give it a try on the PP

Re: [PATCH 1/2] block/export: Free ignored Error

2021-04-26 Thread Vladimir Sementsov-Ogievskiy
22.04.2021 17:53, Max Reitz wrote: When invoking block-export-add with some iothread and fixed-iothread=false, and changing the node's iothread fails, the error is supposed to be ignored. However, it is still stored in *errp, which is wrong. If a second error occurs, the "*errp must be NULL" as

[PATCH] make vfio and DAX cache work together

2021-04-26 Thread Edge NFV
Signed-off-by: Edge NFV --- hw/vfio/common.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index ae5654fcdb..83e15bf7a3 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -668,6 +668,15 @@ static void vfio_listener_region_add(MemoryListener

Re: [PATCH v5 0/4] accel/tcg: Make sure that tb->size != 0 after translation

2021-04-26 Thread Cornelia Huck
On Fri, 23 Apr 2021 10:50:59 -0700 Richard Henderson wrote: > On 4/23/21 3:31 AM, Cornelia Huck wrote: > > So, what's the way forward here? I can pick this if I get an ack for > > the arm patch. If someone else wants to take this, I'll just ack the > > s390x patch. > > You've volunteered, so t

Re: [PATCH v5 0/4] accel/tcg: Make sure that tb->size != 0 after translation

2021-04-26 Thread Cornelia Huck
On Fri, 16 Apr 2021 17:49:35 +0200 Ilya Leoshkevich wrote: > If arch-specific code generates a translation block of size 0, > tb_gen_code() may generate a spurious exception. > > Fix s390x (patch 1), ARM (patch 2) and xtensa (patch 3) and add an > assertion in order to catch such situations earl

X on old (non-x86) Linux guests

2021-04-26 Thread Dr. David Alan Gilbert
Hi, Over the weekend I got a Red Hat 6.x (not RHEL!) for Alpha booting under QEMU which was pretty neat. But I failed to find a succesful combination to get X working; has anyone any suggestions? That distro was from around 2000; the challenge is since we don't have VESA on non-x86, we can't

Re: [PATCH v3 0/2] tests/docker: tests/tcg/ppc64le: Newer toolchain to build tests for PowerISA v3.1 instructions

2021-04-26 Thread Alex Bennée
matheus.fe...@eldorado.org.br writes: > From: Matheus Ferst > > This series adds gcc-10 based images to enable the build of tests with Power10 > instructions. Then, to put it to good use, a tests for the byte-reverse > instructions (implemented in 9d69cfa2faa7) is introduced. > > v3: > - Fixed

Re: [PATCH 0/2] iotests/qsd-jobs: Use common.qemu for the QSD

2021-04-26 Thread Stefan Hajnoczi
On Thu, Apr 01, 2021 at 03:28:13PM +0200, Max Reitz wrote: > (Alternative to: “iotests/qsd-jobs: Filter events in the first test”) > > Hi, > > The qsd-jobs test has kind of unreliable output, because sometimes the > job is ready before ‘quit’, and sometimes it is not. This series > presents one

Re: [PATCH 2/2] iotests/307: Test iothread conflict for exports

2021-04-26 Thread Vladimir Sementsov-Ogievskiy
22.04.2021 17:53, Max Reitz wrote: Passing fixed-iothread=true should make iothread conflicts fatal, whereas fixed-iothread=false should not. Combine the second case with an error condition that is checked after the iothread is handled, to verify that qemu does not crash if there is such an erro

Re: [PATCH v1 13/25] hw/tricore: Add testdevice for tests in tests/tcg/

2021-04-26 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 4/19/21 4:54 PM, Alex Bennée wrote: >> From: Bastian Koppelmann >> >> this device is used to verify the correctness of regression tests by >> allowing guests to write their exit status to this device. This is then >> used by qemu to exit using the written s

Re: [PATCH 1/2] block/export: Free ignored Error

2021-04-26 Thread Max Reitz
On 26.04.21 11:44, Vladimir Sementsov-Ogievskiy wrote: 22.04.2021 17:53, Max Reitz wrote: When invoking block-export-add with some iothread and fixed-iothread=false, and changing the node's iothread fails, the error is supposed to be ignored. However, it is still stored in *errp, which is wrong

Re: firmware selection for SEV-ES

2021-04-26 Thread Laszlo Ersek
On 04/23/21 19:36, Pavel Hrdina wrote: > On Fri, Apr 23, 2021 at 03:06:49PM +0200, Laszlo Ersek wrote: >> On 04/23/21 15:01, Pavel Hrdina wrote: >>> On Fri, Apr 23, 2021 at 02:34:02PM +0200, Laszlo Ersek wrote: On 04/23/21 12:31, Pavel Hrdina wrote: > On Fri, Apr 23, 2021 at 10:16:24AM +02

Re: [PATCH 1/2] block/export: Free ignored Error

2021-04-26 Thread Vladimir Sementsov-Ogievskiy
26.04.2021 13:33, Max Reitz wrote: On 26.04.21 11:44, Vladimir Sementsov-Ogievskiy wrote: 22.04.2021 17:53, Max Reitz wrote: When invoking block-export-add with some iothread and fixed-iothread=false, and changing the node's iothread fails, the error is supposed to be ignored. However, it is s

Re: [PATCH] hw/block/nvme: fix csi field for cns 0x00 and 0x11

2021-04-26 Thread Klaus Jensen
On Apr 26 13:16, Gollu Appalanaidu wrote: As per the TP 4056d Namespace types CNS 0x00 and CNS 0x11 CSI field shouldn't use but it is being used for these two Identify command CNS values, fix that. Signed-off-by: Gollu Appalanaidu --- hw/nvme/ctrl.c | 11 --- 1 file changed, 8 insertions

Re: Resetting non-qdev children in a 3-phase reset device

2021-04-26 Thread Philippe Mathieu-Daudé
On 4/26/21 11:33 AM, Peter Maydell wrote: > On Mon, 26 Apr 2021 at 10:23, Philippe Mathieu-Daudé wrote: >> On 4/25/21 8:33 PM, Peter Maydell wrote: >>> On Sat, 24 Apr 2021 at 14:04, Philippe Mathieu-Daudé >>> wrote: I now understand better the diag288 case, but I still don't understand

Re: socket.c added support for unix domain socket datagram transport

2021-04-26 Thread Ralph Schmieder
> On Apr 23, 2021, at 18:39, Stefano Brivio wrote: > > On Fri, 23 Apr 2021 17:48:08 +0200 > Ralph Schmieder wrote: > >> Hi, Stefano... Thanks for the detailed response... inline >> Thanks, >> -ralph >> >> >>> On Apr 23, 2021, at 17:29, Stefano Brivio >>> wrote: >>> >>> Hi Ralph, >>> >>>

Re: [PATCH v2 00/25] linux-user/sparc: Implement rt signals

2021-04-26 Thread Alex Bennée
Richard Henderson writes: > On 4/25/21 7:53 PM, Richard Henderson wrote: >> Supercedes:20210425155749.896330-1-richard.hender...@linaro.org >> ("linux-user/sparc64: Implement signals") >> This time, in the lead-up, merge the sparc and sparc64 directories. >> Implement rt signals for sparc32 as

RE: [RFC PATCH 0/4] target/ppc: code motion to compile translate_init

2021-04-26 Thread Bruno Piazera Larsen
> > The current patch series aims to isolate common code from > > translation-related > > code. This isolation is required to disable TCG at build time, and the > > final system still work. > > > > This patch series is still WIP, so comments are welcome > > > > Bruno Larsen (billionai) (4): > >

[PATCH v2 0/2] kvm: use KVM_{GET|SET}_SREGS2 when available

2021-04-26 Thread Maxim Levitsky
This implements support for using these new IOCTLS to migrate PDPTRS. Best regards, Maxim Levitsky Maxim Levitsky (2): kvm: update kernel headers for KVM_{GET|SET}_SREGS2 KVM: use KVM_{GET|SET}_SREGS2 when supported. accel/kvm/kvm-all.c | 5 ++ include/sysemu/kvm.h

[PATCH v2 1/2] kvm: update kernel headers for KVM_{GET|SET}_SREGS2

2021-04-26 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- linux-headers/asm-x86/kvm.h | 13 + linux-headers/linux/kvm.h | 5 + 2 files changed, 18 insertions(+) diff --git a/linux-headers/asm-x86/kvm.h b/linux-headers/asm-x86/kvm.h index 8e76d3701d..d61dc76e24 100644 --- a/linux-headers/asm-x86/kvm.h

[PATCH v2 2/2] KVM: use KVM_{GET|SET}_SREGS2 when supported.

2021-04-26 Thread Maxim Levitsky
This allows to make PDPTRs part of the migration stream and thus not reload them after migration which is against X86 spec. Signed-off-by: Maxim Levitsky --- accel/kvm/kvm-all.c | 5 ++ include/sysemu/kvm.h | 4 ++ target/i386/cpu.h | 3 ++ target/i386/kvm/kvm.c | 107 ++

Re: [PATCH v1 13/25] hw/tricore: Add testdevice for tests in tests/tcg/

2021-04-26 Thread Philippe Mathieu-Daudé
On 4/26/21 12:15 PM, Alex Bennée wrote: > Philippe Mathieu-Daudé writes: >> On 4/19/21 4:54 PM, Alex Bennée wrote: >>> From: Bastian Koppelmann >>> >>> this device is used to verify the correctness of regression tests by >>> allowing guests to write their exit status to this device. This is then

Re: socket.c added support for unix domain socket datagram transport

2021-04-26 Thread Ralph Schmieder
> On Apr 23, 2021, at 18:54, Stefano Brivio wrote: > > On Fri, 23 Apr 2021 17:21:38 +0100 > Daniel P. Berrangé wrote: > >> On Fri, Apr 23, 2021 at 05:29:40PM +0200, Stefano Brivio wrote: >>> Hi Ralph, >>> >>> On Fri, 23 Apr 2021 08:56:48 +0200 >>> Ralph Schmieder wrote: >>> Hey... n

Re: First time patch not reflected in the mailing list

2021-04-26 Thread Dr. David Alan Gilbert
* Edge NFV (edge...@gmail.com) wrote: > Hi > > I sent a patch around four hours back but I doesn't seem to be reflected on > to the mailing list. That patch was my first mail to this mail list. I > understand that this a moderated list and the first message needs to be > white listed by the modera

Re: [PATCH v2 1/3] doc: Fix some mistakes in the SEV documentation

2021-04-26 Thread Laszlo Ersek
On 04/23/21 22:08, Tom Lendacky wrote: > From: Tom Lendacky > > Fix some spelling and grammar mistakes in the amd-memory-encryption.txt > file. No new information added. > > Signed-off-by: Tom Lendacky > --- > docs/amd-memory-encryption.txt | 59 +- > 1 file cha

Re: [PATCH v6 00/12] qcow2: fix parallel rewrite and discard (lockless)

2021-04-26 Thread Vladimir Sementsov-Ogievskiy
22.04.2021 19:30, Vladimir Sementsov-Ogievskiy wrote: Hi all! It's an alternative lock-less solution to [PATCH v4 0/3] qcow2: fix parallel rewrite and discard (rw-lock) In v6 a lot of things are rewritten. What is changed: 1. rename the feature to host_range_refcnt, move it to separate fil

Re: [PATCH] make vfio and DAX cache work together

2021-04-26 Thread Dr. David Alan Gilbert
* Edge NFV (edge...@gmail.com) wrote: > Signed-off-by: Edge NFV Hi, I take it that 'Edge NFV' isn't your real name; apologies if it is. It's unusual not to use a real name; I would be interested to know why you feel uncomfortable not doing. > --- > hw/vfio/common.c | 9 + > 1 file ch

Re: [PATCH 03/11] block/block-gen.h: bind monitor

2021-04-26 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 24.04.2021 08:23, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> If we have current monitor, let's bind it to wrapper coroutine too. >>> >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>> --- >>> block/block-gen.h | 10

Re: [PATCH v2 5/5] sockets: Support multipath TCP

2021-04-26 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Wed, Apr 21, 2021 at 12:28:34PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Multipath TCP allows combining multiple interfaces/routes into a single > > socket, with very little work for the user/admin

Re: [RFC v9 15/29] vfio: Set up nested stage mappings

2021-04-26 Thread Auger Eric
Hi Kunkun, On 4/14/21 3:45 AM, Kunkun Jiang wrote: > On 2021/4/13 20:57, Auger Eric wrote: >> Hi Kunkun, >> >> On 4/13/21 2:10 PM, Kunkun Jiang wrote: >>> Hi Eric, >>> >>> On 2021/4/11 20:08, Eric Auger wrote: In nested mode, legacy vfio_iommu_map_notify cannot be used as there is no "ca

Re: [PATCH v2 2/3] docs: Add SEV-ES documentation to amd-memory-encryption.txt

2021-04-26 Thread Laszlo Ersek
On 04/23/21 22:08, Tom Lendacky wrote: > From: Tom Lendacky > > Update the amd-memory-encryption.txt file with information about SEV-ES, > including how to launch an SEV-ES guest and some of the differences > between SEV and SEV-ES guests in regards to launching and measuring the > guest. > > Si

Re: [PATCH v2] pc-bios/s390-ccw: Use reset_psw pointer instead of hard-coded null pointer

2021-04-26 Thread Janosch Frank
On 4/23/21 4:24 PM, Thomas Huth wrote: > When compiling the s390-ccw bios with clang, it emits a warning like this: > > pc-bios/s390-ccw/jump2ipl.c:86:9: warning: indirection of non-volatile null > pointer will be deleted, not trap [-Wnull-dereference] > if (*((uint64_t *)0) & RESET_PSW_MA

[Bug 1323758] Re: Mouse stops working when connected usb-storage-device

2021-04-26 Thread Lucas Kanashiro
@Kendrick could you please tell us which version of Ubuntu and qemu you are using? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1323758 Title: Mouse stops working when connected usb-storage-device

Re: [PATCH v2 3/3] docs/interop/firmware.json: Add SEV-ES support

2021-04-26 Thread Laszlo Ersek
On 04/23/21 22:08, Tom Lendacky wrote: > From: Tom Lendacky > > Create an enum definition, '@amd-sev-es', for SEV-ES and add documention > for the new enum. Add an example that shows some of the requirements for > SEV-ES, including not having SMM support and the requirement for an > X64-only buil

[Bug 1900122] Re: Unsupported ioctl: cmd=0xffffffff80685600 when accessing /dev/video* in aarch64 guest

2021-04-26 Thread Laurent Vivier
** Tags added: linux-user -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1900122 Title: Unsupported ioctl: cmd=0x80685600 when accessing /dev/video* in aarch64 guest Status in QEMU: New

Re: socket.c added support for unix domain socket datagram transport

2021-04-26 Thread Daniel P . Berrangé
On Fri, Apr 23, 2021 at 06:54:08PM +0200, Stefano Brivio wrote: > On Fri, 23 Apr 2021 17:21:38 +0100 > Daniel P. Berrangé wrote: > > The current IP socket impl for the net socket backend uses SOCK_DGRAM, > > so from a consistency POV it feels sensible todo the same for UNIX > > sockets too. > > T

Re: [PATCH v2] vfio-ccw: Permit missing IRQs

2021-04-26 Thread Cornelia Huck
On Fri, 23 Apr 2021 12:24:57 -0400 Eric Farman wrote: > On Fri, 2021-04-23 at 09:22 -0400, Matthew Rosato wrote: > > So, this looks OK to me. > > +1 (Thanks for doing the research, Matt) +1 to both the analysis and the thanks :) > > > > > > > > handle any ioctl failure gracefully), but

Re: [PATCH v2] vfio-ccw: Permit missing IRQs

2021-04-26 Thread Cornelia Huck
On Wed, 21 Apr 2021 17:20:53 +0200 Eric Farman wrote: > Commit 690e29b91102 ("vfio-ccw: Refactor ccw irq handler") changed > one of the checks for the IRQ notifier registration from saying > "the host needs to recognize the only IRQ that exists" to saying > "the host needs to recognize ANY IRQ th

[PATCH] cutils: Fix memleak in get_relocated_path()

2021-04-26 Thread Zhenzhong Duan
Valgrind complains definitely loss in get_relocated_path(), because GString is leaked in get_relocated_path() when returning with gchar *. Use g_string_free(, false) to free GString while preserving gchar *. Signed-off-by: Zhenzhong Duan --- util/cutils.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH v2] hw/i386: Expand the range of CPU topologies between smp and maxcpus

2021-04-26 Thread caodon...@kingsoft.com
Change the criteria for the initial CPU topology and maxcpus, user can have more settings Signed-off-by: Dongli Cao --- hw/i386/pc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 8a84b25..ef2e819 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @

Re: [PATCH for-6.0 v2 1/2] hw/block/nvme: fix invalid msix exclusive uninit

2021-04-26 Thread Michael S. Tsirkin
On Mon, Apr 26, 2021 at 11:27:04AM +0200, Philippe Mathieu-Daudé wrote: > On 4/26/21 6:40 AM, Klaus Jensen wrote: > > On Apr 23 07:21, Klaus Jensen wrote: > >> From: Klaus Jensen > >> > >> Commit 1901b4967c3f changed the nvme device from using a bar exclusive > >> for MSI-x to sharing it on bar0.

[PATCH] make vfio and DAX cache work together

2021-04-26 Thread Edge NFV
I am using Kata containers and create containers inside the virtual machine. The hypervisor used is QEMU. My workload is I/O and network intensive. So, I prefer SR-IOV VF (which provides better network isolation) and DAX caching to work together. However, I was unable to create a QEMU based vir

[PATCH] make vfio and DAX cache work together by skipping virtio fs cache section during vfio memory region add

2021-04-26 Thread Edge NFV
Signed-off-by: Edge NFV --- hw/vfio/common.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index ae5654fcdb..83e15bf7a3 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -668,6 +668,15 @@ static void vfio_listener_region_add(MemoryListener

Re: [PATCH] make vfio and DAX cache work together by skipping virtio fs cache section during vfio memory region add

2021-04-26 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210426054513.132980-2-edge...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210426054513.132980-2-edge...@gmail.com Subject: [PATCH] make vfio and DAX cache work tog

Re: [PATCH v2] hw/i386: Expand the range of CPU topologies between smp and maxcpus

2021-04-26 Thread Daniel P . Berrangé
On Mon, Apr 26, 2021 at 10:08:52AM +0800, caodon...@kingsoft.com wrote: > Change the criteria for the initial CPU topology and maxcpus, user can > have more settings Can you provide a better explanation of why this is needed. What valid usage scenario is blocked by the current check ? AFAICT, it

Re: [PATCH v3] multi-process: Initialize variables declared with g_auto*

2021-04-26 Thread Stefan Hajnoczi
On Tue, Apr 06, 2021 at 10:00:03PM +0800, Zenghui Yu wrote: > [+Stefan] > > On 2021/3/12 19:21, Zenghui Yu wrote: > > Quote docs/devel/style.rst (section "Automatic memory deallocation"): > > > > * Variables declared with g_auto* MUST always be initialized, > >otherwise the cleanup function w

Re: [PATCH] make vfio and DAX cache work together by skipping virtio fs cache section during vfio memory region add

2021-04-26 Thread Laurent Vivier
On 26/04/2021 07:45, Edge NFV wrote: > Signed-off-by: Edge NFV You must use your real name for a patch submission: https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/

[Bug 1437970] Re: qemu-system-x86_64 - two mouse pointers & fast scrolling problem

2021-04-26 Thread Thomas Huth
Hi! I'm currently looking through old bug reports. Big sorry, seems like this completely fell through the cracks... sometimes developers are just too busy with other stuff or nobody really has a clue how to tackle certain bug tickets... but it would have been good to have at least some reply here

Re: X on old (non-x86) Linux guests

2021-04-26 Thread Thomas Huth
On 26/04/2021 12.01, Dr. David Alan Gilbert wrote: Hi, Over the weekend I got a Red Hat 6.x (not RHEL!) for Alpha booting under QEMU which was pretty neat. But I failed to find a succesful combination to get X working; has anyone any suggestions? That distro was from around 2000; the chal

Re: X on old (non-x86) Linux guests

2021-04-26 Thread Laurent Vivier
On 26/04/2021 12:01, Dr. David Alan Gilbert wrote: > Hi, > Over the weekend I got a Red Hat 6.x (not RHEL!) for Alpha booting > under QEMU which was pretty neat. But I failed to find a succesful > combination to get X working; has anyone any suggestions? > > That distro was from around 2000;

Re: [RFC PATCH] scripts/tracetool: don't barf validating TCG types

2021-04-26 Thread Stefan Hajnoczi
On Tue, Apr 06, 2021 at 05:53:07PM +0100, Alex Bennée wrote: > TCG types will be transformed into the appropriate host types later on > in the tool. Try and work around this by detecting those cases and > pressing on. > > [AJB: this seems a bit too hacky - but the problem is validate_type is > bur

Re: [PATCH] cutils: Fix memleak in get_relocated_path()

2021-04-26 Thread Philippe Mathieu-Daudé
Hi, On 4/27/21 12:30 AM, Zhenzhong Duan wrote: > Valgrind complains definitely loss in get_relocated_path(), because > GString is leaked in get_relocated_path() when returning with gchar *. > Use g_string_free(, false) to free GString while preserving gchar *. > > Signed-off-by: Zhenzhong Duan >

Re: X on old (non-x86) Linux guests

2021-04-26 Thread Dr. David Alan Gilbert
* Thomas Huth (th.h...@posteo.de) wrote: > On 26/04/2021 12.01, Dr. David Alan Gilbert wrote: > > Hi, > >Over the weekend I got a Red Hat 6.x (not RHEL!) for Alpha booting > > under QEMU which was pretty neat. But I failed to find a succesful > > combination to get X working; has anyone any su

Re: X on old (non-x86) Linux guests

2021-04-26 Thread Dr. David Alan Gilbert
* Laurent Vivier (lviv...@redhat.com) wrote: > On 26/04/2021 12:01, Dr. David Alan Gilbert wrote: > > Hi, > > Over the weekend I got a Red Hat 6.x (not RHEL!) for Alpha booting > > under QEMU which was pretty neat. But I failed to find a succesful > > combination to get X working; has anyone any

Re: [PATCH v4] net/macos: implement vmnet-based netdev

2021-04-26 Thread Alessio Dionisi
Hello, I'm replying to this thread to let you know that I am available to help out on this patch as I have been working on the same feature for a few weeks. AD > On 3 Mar 2021, at 12:24, Phillip Tennen > wrote: > > Thanks very much for your help and feedback! >

Re: [PULL 46/46] accel: introduce AccelCPUClass extending CPUClass

2021-04-26 Thread Philippe Mathieu-Daudé
Hi Claudio, +Eduardo/Paolo On 2/5/21 11:56 PM, Richard Henderson wrote: > From: Claudio Fontana > > add a new optional interface to CPUClass, which allows accelerators > to extend the CPUClass with additional accelerator-specific > initializations. > > This will allow to separate the target cp

Re: [PATCH 2/3] vhost-blk: Add vhost-blk-common abstraction

2021-04-26 Thread Stefan Hajnoczi
On Thu, Apr 08, 2021 at 06:12:51PM +0800, Xie Yongji wrote: > diff --git a/hw/block/vhost-blk-common.c b/hw/block/vhost-blk-common.c > new file mode 100644 > index 00..96500f6c89 > --- /dev/null > +++ b/hw/block/vhost-blk-common.c > @@ -0,0 +1,291 @@ > +/* > + * Parent class for vhost based

Re: X on old (non-x86) Linux guests

2021-04-26 Thread Laurent Vivier
On 26/04/2021 16:18, Dr. David Alan Gilbert wrote: > * Laurent Vivier (lviv...@redhat.com) wrote: >> On 26/04/2021 12:01, Dr. David Alan Gilbert wrote: >>> Hi, >>> Over the weekend I got a Red Hat 6.x (not RHEL!) for Alpha booting >>> under QEMU which was pretty neat. But I failed to find a succ

Re: [PATCH] make vfio and DAX cache work together

2021-04-26 Thread Alex Williamson
On Mon, 26 Apr 2021 13:19:05 +0100 "Dr. David Alan Gilbert" wrote: > * Edge NFV (edge...@gmail.com) wrote: > > Signed-off-by: Edge NFV > > Hi, > I take it that 'Edge NFV' isn't your real name; apologies if it is. > It's unusual not to use a real name; I would be interested to know > why yo

Re: [PATCH 3/3] vhost-vdpa-blk: Introduce vhost-vdpa-blk host device

2021-04-26 Thread Stefan Hajnoczi
On Thu, Apr 08, 2021 at 06:12:52PM +0800, Xie Yongji wrote: > +static const int vdpa_feature_bits[] = { > +VIRTIO_BLK_F_SIZE_MAX, > +VIRTIO_BLK_F_SEG_MAX, > +VIRTIO_BLK_F_GEOMETRY, > +VIRTIO_BLK_F_BLK_SIZE, > +VIRTIO_BLK_F_TOPOLOGY, > +VIRTIO_BLK_F_MQ, > +VIRTIO_BLK_F_RO

Re: [PULL 15/24] bsd-user: Fix commentary issues

2021-04-26 Thread Warner Losh
On Mon, Apr 26, 2021 at 3:13 AM Peter Maydell wrote: > On Mon, 26 Apr 2021 at 10:01, Daniel P. Berrangé > wrote: > > > > On Fri, Apr 23, 2021 at 02:39:50PM -0600, i...@bsdimp.com wrote: > > > -#define TARGET_FREEBSD_MAP_RESERVED0080 0x0080 /* previously > misimplemented MAP_INHERIT */ > > > -#d

Re: [PATCH 2/5] hw/pcmcia/microdrive: Register machine reset handler

2021-04-26 Thread Philippe Mathieu-Daudé
On 4/25/21 8:36 PM, Peter Maydell wrote: > On Sat, 24 Apr 2021 at 17:22, Philippe Mathieu-Daudé wrote: >> >> The abstract PCMCIA_CARD is a bus-less TYPE_DEVICE, so devices >> implementing it are not reset automatically. >> Register a reset handler so children get reset on machine reset. >> >> Note

[for-6.1 v2 2/2] virtiofsd: Add support for FUSE_SYNCFS request

2021-04-26 Thread Greg Kurz
Honor the expected behavior of syncfs() to synchronously flush all data and metadata on linux systems. Flushing is done with syncfs(). This is suboptimal as it will also flush writes performed by any other process on the same file system, and thus add an unbounded time penalty to syncfs(). This ma

[for-6.1 v2 0/2] virtiofsd: Add support for FUSE_SYNCFS request

2021-04-26 Thread Greg Kurz
FUSE_SYNCFS allows the client to flush the host page cache. This isn't available in upstream linux yet, but the following tree can be used to test: https://gitlab.com/gkurz/linux/-/tree/virtio-fs-sync v2: - based on new version of FUSE_SYNCFS https://listman.redhat.com/archives/virtio-fs/20

[for-6.1 v2 1/2] Update linux headers to 5.12-rc8 + FUSE_SYNCFS

2021-04-26 Thread Greg Kurz
NOT YET IN UPSTREAM LINUX. DO NOT MERGE. Signed-off-by: Greg Kurz --- include/standard-headers/drm/drm_fourcc.h | 23 - include/standard-headers/linux/ethtool.h | 54 ++- include/standard-headers/linux/fuse.h | 13 ++- include/standard-headers/linux/input.h|

Re: [PATCH for-6.0 v2 1/2] hw/block/nvme: fix invalid msix exclusive uninit

2021-04-26 Thread Peter Maydell
On Fri, 23 Apr 2021 at 06:21, Klaus Jensen wrote: > > From: Klaus Jensen > > Commit 1901b4967c3f changed the nvme device from using a bar exclusive > for MSI-x to sharing it on bar0. > > Unfortunately, the msix_uninit_exclusive_bar() call remains in > nvme_exit() which causes havoc when the devic

Re: X on old (non-x86) Linux guests

2021-04-26 Thread BALATON Zoltan
Hello, On Mon, 26 Apr 2021, Dr. David Alan Gilbert wrote: Over the weekend I got a Red Hat 6.x (not RHEL!) for Alpha booting under QEMU which was pretty neat. But I failed to find a succesful combination to get X working; has anyone any suggestions? Adding Andrew who has experimented with ol

Re: [PATCH 0/3] Introduce vhost-vdpa block device

2021-04-26 Thread Stefan Hajnoczi
On Thu, Apr 08, 2021 at 06:12:49PM +0800, Xie Yongji wrote: > Since we already have some ways to emulate vDPA block device > in kernel[1] or userspace[2]. This series tries to introduce a > new vhost-vdpa block device for that. To use it, we can add > something like: > > qemu-system-x86_64 \ >

Re: [PATCH v8] introduce vfio-user protocol specification

2021-04-26 Thread Stefan Hajnoczi
On Wed, Apr 14, 2021 at 04:41:22AM -0700, Thanos Makatos wrote: > This patch introduces the vfio-user protocol specification (formerly > known as VFIO-over-socket), which is designed to allow devices to be > emulated outside QEMU, in a separate process. vfio-user reuses the > existing VFIO defines,

Re: [PATCH v3] target/ppc: code motion from translate_init.c.inc to gdbstub.c

2021-04-26 Thread Fabiano Rosas
David Gibson writes: > On Wed, Apr 14, 2021 at 01:09:19PM -0700, Richard Henderson wrote: >> On 4/14/21 7:59 AM, Bruno Larsen (billionai) wrote: >> > All the code related to gdb has been moved from translate_init.c.inc >> > file to the gdbstub.c file, where it makes more sense. >> > >> > This ne

Re: X on old (non-x86) Linux guests

2021-04-26 Thread Gerd Hoffmann
On Mon, Apr 26, 2021 at 11:01:26AM +0100, Dr. David Alan Gilbert wrote: > Hi, > Over the weekend I got a Red Hat 6.x (not RHEL!) for Alpha booting > under QEMU which was pretty neat. But I failed to find a succesful > combination to get X working; has anyone any suggestions? > > That distro w

[Bug 1926174] [NEW] Laggy and/or displaced mouse input on CloudReady (Chrome OS) VM

2021-04-26 Thread Michael Monreal
Public bug reported: This weekend I tried to get a CloudReady (Chrome OS) VM running on qemu 5.2. This seems to wok quite well, performance seems to be great in fact. Only problem is mouse input. Using SDL display, there is no visible mouse unless I set "show- cursor=on". After that the mouse poi

Re: [PATCH v3 18/36] block: add bdrv_attach_child_common() transaction action

2021-04-26 Thread Kevin Wolf
Am 17.03.2021 um 15:35 hat Vladimir Sementsov-Ogievskiy geschrieben: > Split out no-perm part of bdrv_root_attach_child() into separate > transaction action. bdrv_root_attach_child() now moves to new > permission update paradigm: first update graph relations then update > permissions. > > Signed-o

Re: [PATCH v6 06/18] cpu: Assert DeviceClass::vmsd is NULL on user emulation

2021-04-26 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (f4...@amsat.org) wrote: > Migration is specific to system emulation. > > Restrict current DeviceClass::vmsd to sysemu using #ifdef'ry, > and assert in cpu_exec_realizefn() that dc->vmsd not set under > user emulation. > > Signed-off-by: Philippe Mathieu-Daudé > --- > c

Re: [PATCH v3 22/36] block: add bdrv_remove_filter_or_cow transaction action

2021-04-26 Thread Kevin Wolf
Am 17.03.2021 um 15:35 hat Vladimir Sementsov-Ogievskiy geschrieben: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block.c | 78 +++-- > 1 file changed, 76 insertions(+), 2 deletions(-) > > diff --git a/block.c b/block.c > index 11f7ad0

Re: [RFC] tcg plugin: Additional plugin interface

2021-04-26 Thread Min-Yih Hsu
Hi Alex, > On Apr 23, 2021, at 8:44 AM, Alex Bennée wrote: > > > Min-Yih Hsu writes: > >> Hi Alex and QEMU developers, >> >> Recently I was working with the TCG plugin. I found that >> `qemu_plugin_cb_flags` seems to reserve the functionality to >> read / write CPU register state, I'm wonde

Re: [PATCH 2/2] plugins: Move all typedef and type declaration to the front of the qemu-plugin.h

2021-04-26 Thread Alex Bennée
Yonggang Luo writes: What's the rationale for moving everything around in the file. As it currently stands the typedefs are create as we get to each new set of helpers/plugin points. Doing it all up front seems like a lot of churn for not particular reason. > Signed-off-by: Yonggang Luo > ---

[PATCH v5 cxl2.0-v3-doe 0/6] QEMU PCIe DOE for PCIe 4.0/5.0 and CXL 2.0

2021-04-26 Thread Chris Browy
This patch implements the PCIe Data Object Exchange (DOE) for PCIe 4.0/5.0 and later and CXL 2.0 "type-3" memory devices supporting the following protocols: 1: PCIe DOE Discovery protocol 2: CXL DOE Compliance Mode protocol 3: CXL DOE CDAT protocol Implementation is based on QEMU version which

  1   2   3   >