[Bug 1925512] Re: UNDEFINED case for instruction BLX

2021-04-23 Thread JIANG Muhui
Hi Thanks for your reply. I don't think return false is the right behavior here. H is related to decoding rather than encoding phase. The value of symbol *H* should not be used to check whether the (encoding) pattern is matched or not. In other words, whatever value H is, if the bytecode meet the

Re: [PATCH 1/5] vhost-user-blk: Don't reconnect during initialisation

2021-04-23 Thread Denis Plotnikov
Reviewed-by: Denis Plotnikov On 22.04.2021 20:02, Kevin Wolf wrote: This is a partial revert of commits 77542d43149 and bc79c87bcde. Usually, an error during initialisation means that the configuration was wrong. Reconnecting won't make the error go away, but just turn the error condition into

[Bug 1880518] Re: issue while installing docker inside s390x container

2021-04-23 Thread Nayana
Looks like for docker in docker in cross architectures is not yet supported. if we use -v /var/run/docker.sock:/var/run/docker.sock , docker will always run as client in s390x container and server from amd64. -- You received this bug notification because you are a member of qemu- devel-ml, which

Compiling the s390-ccw bios with clang (was: Re: s390-ccw: warning: writing 1 byte into a region of size 0)

2021-04-23 Thread Thomas Huth
On 23/04/2021 08.52, Christian Borntraeger wrote: [...] We can of course discuss if we compile the BIOS for z10 instead of z900. TCG in the mean time can handle up to z13 and z10 is now also 13 years old. I'd really like to see us supporting Clang in the s390-ccw bios, too, since it provides a

Re: [PATCH RFC 1/1] msix: add hmp interface to dump MSI-X info

2021-04-23 Thread Jason Wang
在 2021/4/23 下午12:47, Dongli Zhang 写道: This patch is to add the HMP interface to dump MSI-X table and PBA, in order to help diagnose the loss of IRQ issue in VM (e.g., if an MSI-X vector is erroneously masked permanently). Here is the example with vhost-scsi: (qemu) info msix /machine/periphera

Re: Compiling the s390-ccw bios with clang

2021-04-23 Thread Christian Borntraeger
On 23.04.21 09:57, Thomas Huth wrote: On 23/04/2021 08.52, Christian Borntraeger wrote: [...] We can of course discuss if we compile the BIOS for z10 instead of z900. TCG in the mean time can handle up to z13 and z10 is now also 13 years old. I'd really like to see us supporting Clang in th

Re: Compiling the s390-ccw bios with clang (was: Re: s390-ccw: warning: writing 1 byte into a region of size 0)

2021-04-23 Thread Cornelia Huck
On Fri, 23 Apr 2021 09:57:08 +0200 Thomas Huth wrote: > On 23/04/2021 08.52, Christian Borntraeger wrote: > [...] > > We can of course discuss if we compile the BIOS for z10 instead of z900. TCG > > in the mean time can handle up to z13 and z10 is now also 13 years old. > > I'd really like to

Re: firmware selection for SEV-ES

2021-04-23 Thread Michal Privoznik
On 4/22/21 4:13 PM, Laszlo Ersek wrote: On 04/21/21 13:51, Pavel Hrdina wrote: On Wed, Apr 21, 2021 at 11:54:24AM +0200, Laszlo Ersek wrote: Hi Brijesh, Tom, in QEMU's "docs/interop/firmware.json", the @FirmwareFeature enumeration has a constant called @amd-sev. We should introduce an @amd-sev

Re: Compiling the s390-ccw bios with clang (was: Re: s390-ccw: warning: writing 1 byte into a region of size 0)

2021-04-23 Thread Thomas Huth
On 23/04/2021 10.07, Cornelia Huck wrote: On Fri, 23 Apr 2021 09:57:08 +0200 Thomas Huth wrote: On 23/04/2021 08.52, Christian Borntraeger wrote: [...] We can of course discuss if we compile the BIOS for z10 instead of z900. TCG in the mean time can handle up to z13 and z10 is now also 13 yea

[PATCH v4 4/9] ui/vdagent: core infrastructure

2021-04-23 Thread Gerd Hoffmann
The vdagent protocol allows the guest agent (spice-vdagent) and the spice client exchange messages to implement features which require guest cooperation, for example clipboard support. This is a qemu implementation of the spice client side. This allows the spice guest agent talk to qemu directly

[PATCH v4 1/9] build: add separate spice-protocol config option

2021-04-23 Thread Gerd Hoffmann
When implementing spice vdagent protocol in qemu we only need the spice-protocol package for that, spice-server is not needed. So go split those two build dependencies. Signed-off-by: Gerd Hoffmann --- configure | 36 meson.build | 4 2 files changed

[PATCH v4 0/9] ui: add vdagent implementation and clipboard support.

2021-04-23 Thread Gerd Hoffmann
Fist sketch of cut+paste support for vnc. On the guest side we are going to reuse the spice vdagent, so things should work out-of-the-box with guests in the wild. So this patch set brings a qemu implemenation of the vdagent protocol. Beside that there is the clipboard infrastructure of course.

[PATCH v4 7/9] ui/vnc: clipboard support

2021-04-23 Thread Gerd Hoffmann
This patch adds support for cut+paste to the qemu vnc server, which allows the vnc client exchange clipbaord data with qemu and other peers like the qemu vdagent implementation. Signed-off-by: Gerd Hoffmann --- ui/vnc.h | 24 ui/vnc-clipboard.c | 323 +

[PATCH v4 2/9] ui: add clipboard infrastructure

2021-04-23 Thread Gerd Hoffmann
Add some infrastructure to manage the clipboard in qemu. Signed-off-by: Gerd Hoffmann --- include/ui/clipboard.h | 62 ui/clipboard.c | 92 ++ ui/meson.build | 1 + 3 files changed, 155 insertions(+) create mo

[PATCH v4 8/9] ui/gtk: move struct GtkDisplayState to ui/gtk.h

2021-04-23 Thread Gerd Hoffmann
Want place gtk clipboard code in a separate C file, which in turn requires GtkDisplayState being in a header file. So move it. No functional change. Signed-off-by: Gerd Hoffmann --- include/ui/gtk.h | 57 ui/gtk.c | 55 --

[PATCH v4 5/9] ui/vdagent: add mouse support

2021-04-23 Thread Gerd Hoffmann
This patch adds support for mouse messages to the vdagent implementation. This can be enabled/disabled using the new 'mouse' parameter for the vdagent chardev. Default is on. Signed-off-by: Gerd Hoffmann --- chardev/char.c | 3 + ui/vdagent.c | 150 +

[PATCH v4 6/9] ui/vdagent: add clipboard support

2021-04-23 Thread Gerd Hoffmann
This patch adds support for clipboard messages to the qemu vdagent implementation, which allows the guest exchange clipboard data with qemu. Clipboard support can be enabled/disabled using the new 'clipboard' parameter for the vdagent chardev. Default is off. Signed-off-by: Gerd Hoffmann --- c

[PATCH v4 9/9] ui/gtk: add clipboard support

2021-04-23 Thread Gerd Hoffmann
This patch adds clipboard support to the qemu gtk ui. Signed-off-by: Gerd Hoffmann --- include/ui/gtk.h | 10 +++ ui/gtk-clipboard.c | 192 + ui/gtk.c | 1 + ui/meson.build | 2 +- 4 files changed, 204 insertions(+), 1 deletion(-)

[PATCH v4 3/9] ui: add clipboard documentation

2021-04-23 Thread Gerd Hoffmann
Document clipboard infrastructure in qemu. Signed-off-by: Gerd Hoffmann --- include/ui/clipboard.h | 133 - docs/devel/index.rst | 1 + docs/devel/ui.rst | 8 +++ 3 files changed, 141 insertions(+), 1 deletion(-) create mode 100644 docs/devel/u

Re: [PATCH v3 00/36] block: update graph permissions update

2021-04-23 Thread Kevin Wolf
Am 18.03.2021 um 09:04 hat Vladimir Sementsov-Ogievskiy geschrieben: > 17.03.2021 20:33, Eric Blake wrote: > > On 3/17/21 10:38 AM, Vladimir Sementsov-Ogievskiy wrote: > > > > > > 6/36 Checking commit 5780b805277e (block: drop ctx argument from > > > > bdrv_root_attach_child) > > > > 7/36 Checking

[PATCH] pc-bios/s390-ccw: Use reset_psw pointer instead of hard-coded null pointer

2021-04-23 Thread Thomas Huth
When compiling the s390-ccw bios with clang, it emits a warning like this: pc-bios/s390-ccw/jump2ipl.c:86:9: warning: indirection of non-volatile null pointer will be deleted, not trap [-Wnull-dereference] if (*((uint64_t *)0) & RESET_PSW_MASK) { ^~~~ pc-bios/s390-ccw

Re: Compiling the s390-ccw bios with clang (was: Re: s390-ccw: warning: writing 1 byte into a region of size 0)

2021-04-23 Thread Daniel P . Berrangé
On Fri, Apr 23, 2021 at 10:22:28AM +0200, Thomas Huth wrote: > On 23/04/2021 10.07, Cornelia Huck wrote: > > On Fri, 23 Apr 2021 09:57:08 +0200 > > Thomas Huth wrote: > > > > > On 23/04/2021 08.52, Christian Borntraeger wrote: > > > [...] > > > > We can of course discuss if we compile the BIOS fo

Re: [PATCH v4 0/9] ui: add vdagent implementation and clipboard support.

2021-04-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210423083351.2096734-1-kra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210423083351.2096734-1-kra...@redhat.com Subject: [PATCH v4 0/9] ui: add vdagent implem

Re: Compiling the s390-ccw bios with clang (was: Re: s390-ccw: warning: writing 1 byte into a region of size 0)

2021-04-23 Thread Thomas Huth
On 23/04/2021 10.47, Daniel P. Berrangé wrote: On Fri, Apr 23, 2021 at 10:22:28AM +0200, Thomas Huth wrote: On 23/04/2021 10.07, Cornelia Huck wrote: On Fri, 23 Apr 2021 09:57:08 +0200 Thomas Huth wrote: On 23/04/2021 08.52, Christian Borntraeger wrote: [...] We can of course discuss if we

Re: [PULL 0/2] pc: last minute bugfixes

2021-04-23 Thread Peter Maydell
On Thu, 22 Apr 2021 at 23:24, Michael S. Tsirkin wrote: > > The following changes since commit d83f46d189a26fa32434139954d264326f199a45: > > virtio-pci: compat page aligned ATS (2021-04-06 07:11:36 -0400) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst

Re: Compiling the s390-ccw bios with clang (was: Re: s390-ccw: warning: writing 1 byte into a region of size 0)

2021-04-23 Thread Daniel P . Berrangé
On Fri, Apr 23, 2021 at 10:52:35AM +0200, Thomas Huth wrote: > On 23/04/2021 10.47, Daniel P. Berrangé wrote: > > On Fri, Apr 23, 2021 at 10:22:28AM +0200, Thomas Huth wrote: > > > On 23/04/2021 10.07, Cornelia Huck wrote: > > > > On Fri, 23 Apr 2021 09:57:08 +0200 > > > > Thomas Huth wrote: > > >

Re: [PULL 0/2] pc: last minute bugfixes

2021-04-23 Thread Daniel P . Berrangé
On Thu, Apr 22, 2021 at 06:24:48PM -0400, Michael S. Tsirkin wrote: > The following changes since commit d83f46d189a26fa32434139954d264326f199a45: > > virtio-pci: compat page aligned ATS (2021-04-06 07:11:36 -0400) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/

Re: socket.c added support for unix domain socket datagram transport

2021-04-23 Thread Daniel P . Berrangé
On Fri, Apr 23, 2021 at 08:56:48AM +0200, Ralph Schmieder wrote: > Hey... new to this list. I was looking for a way to use Unix domain sockets > as a network transport between local VMs. > > I'm part of a team where we run dozens if not hundreds of VMs on a single > compute instance which are

Re: [PATCH] pc-bios/s390-ccw: Use reset_psw pointer instead of hard-coded null pointer

2021-04-23 Thread Philippe Mathieu-Daudé
On 4/23/21 10:36 AM, Thomas Huth wrote: > When compiling the s390-ccw bios with clang, it emits a warning like this: > > pc-bios/s390-ccw/jump2ipl.c:86:9: warning: indirection of non-volatile null > pointer will be deleted, not trap [-Wnull-dereference] > if (*((uint64_t *)0) & RESET_PSW_M

Re: [PATCH v4 4/9] ui/vdagent: core infrastructure

2021-04-23 Thread Markus Armbruster
Gerd Hoffmann writes: > The vdagent protocol allows the guest agent (spice-vdagent) and the > spice client exchange messages to implement features which require > guest cooperation, for example clipboard support. > > This is a qemu implementation of the spice client side. This allows > the spice

Re: [PATCH v2 1/2] block: Add BDRV_O_NO_SHARE for blk_new_open()

2021-04-23 Thread Vladimir Sementsov-Ogievskiy
22.04.2021 19:43, Kevin Wolf wrote: Normally, blk_new_open() just shares all permissions. This was fine originally when permissions only protected against uses in the same process because no other part of the code would actually get to access the block nodes opened with blk_new_open(). However, s

Re: qemu/kvm tianocore restart stuck

2021-04-23 Thread Philippe Mathieu-Daudé
On 4/22/21 10:04 PM, VoidCC wrote: > Hello, > > I'm hitting a hard wall with qemu and efi. > I'm running multiple windows server 2019 vms which usually reboot on > updates. > > The issue is, efi breaks on reboot. > It randomly(race condition?, does not occur consistently) ends up in a > blackscre

Re: [PATCH v2 1/7] linux-user/alpha: Fix rt sigframe return

2021-04-23 Thread Alex Bennée
Richard Henderson writes: > We incorrectly used the offset of the non-rt sigframe. > > Reviewed-by: Laurent Vivier > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v3 06/33] util/async: aio_co_schedule(): support reschedule in same ctx

2021-04-23 Thread Roman Kagan
On Fri, Apr 16, 2021 at 11:08:44AM +0300, Vladimir Sementsov-Ogievskiy wrote: > With the following patch we want to call wake coroutine from thread. > And it doesn't work with aio_co_wake: > Assume we have no iothreads. > Assume we have a coroutine A, which waits in the yield point for > external a

Re: [PATCH] pc-bios/s390-ccw: Use reset_psw pointer instead of hard-coded null pointer

2021-04-23 Thread Cornelia Huck
On Fri, 23 Apr 2021 10:36:04 +0200 Thomas Huth wrote: > When compiling the s390-ccw bios with clang, it emits a warning like this: > > pc-bios/s390-ccw/jump2ipl.c:86:9: warning: indirection of non-volatile null > pointer will be deleted, not trap [-Wnull-dereference] > if (*((uint64_t *)

Re: [PATCH v2 4/7] linux-user: Honor TARGET_ARCH_HAS_SA_RESTORER in do_syscall

2021-04-23 Thread Philippe Mathieu-Daudé
On 4/23/21 1:02 AM, Richard Henderson wrote: > Do not access a field that may not be present. This will > become an issue when sharing more code in the next patch. > > Signed-off-by: Richard Henderson > --- > linux-user/syscall.c | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Philipp

Re: [PATCH v2 2/7] linux-user/alpha: Rename the sigaction restorer field

2021-04-23 Thread Alex Bennée
Richard Henderson writes: > Use ka_restorer, in line with TARGET_ARCH_HAS_KA_RESTORER > vs TARGET_ARCH_HAS_SA_RESTORER, since Alpha passes this > field as a syscall argument. I'm still slightly confused - but that's to be expected from signals :-/ Anyway I understand that the SA_RESTORER poin

Re: [PATCH v2 7/7] linux-user: Tidy TARGET_NR_rt_sigaction

2021-04-23 Thread Philippe Mathieu-Daudé
On 4/23/21 1:02 AM, Richard Henderson wrote: > Initialize variables instead of elses. > Use an else instead of a goto. > Add braces. > > Signed-off-by: Richard Henderson > --- > linux-user/syscall.c | 32 +--- > 1 file changed, 13 insertions(+), 19 deletions(-) Revie

Re: qemu/kvm tianocore restart stuck

2021-04-23 Thread Laszlo Ersek
On 04/22/21 22:04, VoidCC wrote: > Hello, > > I'm hitting a hard wall with qemu and efi. > I'm running multiple windows server 2019 vms which usually reboot on > updates. > > The issue is, efi breaks on reboot. > It randomly(race condition?, does not occur consistently) ends up in a > blackscreen

Re: firmware selection for SEV-ES

2021-04-23 Thread Laszlo Ersek
On 04/23/21 10:16, Michal Privoznik wrote: > On 4/22/21 4:13 PM, Laszlo Ersek wrote: >> On 04/21/21 13:51, Pavel Hrdina wrote: >>> On Wed, Apr 21, 2021 at 11:54:24AM +0200, Laszlo Ersek wrote: Hi Brijesh, Tom, in QEMU's "docs/interop/firmware.json", the @FirmwareFeature enumerat

Re: [PATCH v5 0/4] accel/tcg: Make sure that tb->size != 0 after translation

2021-04-23 Thread Cornelia Huck
On Fri, 16 Apr 2021 17:49:35 +0200 Ilya Leoshkevich wrote: > If arch-specific code generates a translation block of size 0, > tb_gen_code() may generate a spurious exception. > > Fix s390x (patch 1), ARM (patch 2) and xtensa (patch 3) and add an > assertion in order to catch such situations earl

Re: firmware selection for SEV-ES

2021-04-23 Thread Pavel Hrdina
On Fri, Apr 23, 2021 at 10:16:24AM +0200, Michal Privoznik wrote: > On 4/22/21 4:13 PM, Laszlo Ersek wrote: > > On 04/21/21 13:51, Pavel Hrdina wrote: > > > On Wed, Apr 21, 2021 at 11:54:24AM +0200, Laszlo Ersek wrote: > > > > Hi Brijesh, Tom, > > > > > > > > in QEMU's "docs/interop/firmware.json"

Re: [PATCH v6 00/15] RAM_NORESERVE, MAP_NORESERVE and hostmem "reserve" property

2021-04-23 Thread David Hildenbrand
On 21.04.21 23:06, Eduardo Habkost wrote: On Wed, Apr 21, 2021 at 02:26:09PM +0200, David Hildenbrand wrote: Based-on: 20210406080126.24010-1-da...@redhat.com Some cleanups previously sent in other context (resizeable allocations), followed by RAM_NORESERVE, implementing it under Linux using MA

Re: [PATCH for-6.0 v2 0/2] hw/block/nvme: fix msix uninit

2021-04-23 Thread Klaus Jensen
On Apr 23 07:21, Klaus Jensen wrote: From: Klaus Jensen First patch fixes a regression where msix is not correctly uninit'ed when an nvme device is hotplugged with device_del. When viewed in conjunction with the commit that introduced the bug (commit 1901b4967c3f), I think the fix looks relativ

Re: [PATCH for-6.0 v2 0/2] hw/block/nvme: fix msix uninit

2021-04-23 Thread Peter Maydell
On Fri, 23 Apr 2021 at 11:38, Klaus Jensen wrote: > > On Apr 23 07:21, Klaus Jensen wrote: > >From: Klaus Jensen > > > >First patch fixes a regression where msix is not correctly uninit'ed > >when an nvme device is hotplugged with device_del. When viewed in > >conjunction with the commit that int

Re: [PATCH v6 11/15] qmp: Clarify memory backend properties returned via query-memdev

2021-04-23 Thread Markus Armbruster
David Hildenbrand writes: > We return information on the currently configured memory backends and > don't configure them, so decribe what the currently set properties > express. > > Reviewed-by: Philippe Mathieu-Daudé > Suggested-by: Markus Armbruster > Cc: Eric Blake > Cc: Markus Armbruster

Re: [PATCH v6 14/15] qmp: Include "reserve" property of memory backends

2021-04-23 Thread Markus Armbruster
David Hildenbrand writes: > Let's include the new property. > > Reviewed-by: Philippe Mathieu-Daudé > Cc: Eric Blake > Cc: Markus Armbruster > Cc: Igor Mammedov > Signed-off-by: David Hildenbrand > --- > hw/core/machine-qmp-cmds.c | 1 + > qapi/machine.json | 4 > 2 files chan

Re: [PATCH v6 14/15] qmp: Include "reserve" property of memory backends

2021-04-23 Thread David Hildenbrand
On 23.04.21 13:00, Markus Armbruster wrote: David Hildenbrand writes: Let's include the new property. Reviewed-by: Philippe Mathieu-Daudé Cc: Eric Blake Cc: Markus Armbruster Cc: Igor Mammedov Signed-off-by: David Hildenbrand --- hw/core/machine-qmp-cmds.c | 1 + qapi/machine.json

Re: [PATCH v6 10/15] hostmem: Wire up RAM_NORESERVE via "reserve" property

2021-04-23 Thread Markus Armbruster
David Hildenbrand writes: > Let's provide a way to control the use of RAM_NORESERVE via memory > backends using the "reserve" property which defaults to true (old > behavior). > > Only Linux currently supports clearing the flag (and support is checked at > runtime, depending on the setting of "/p

Re: [PATCH v6 12/15] qmp: Include "share" property of memory backends

2021-04-23 Thread Markus Armbruster
David Hildenbrand writes: > Let's include the property, which can be helpful when debugging, > for example, to spot misuse of MAP_PRIVATE which can result in some ugly > corner cases (e.g., double-memory consumption on shmem). > > Use the same description we also use for describing the property.

Re: [PATCH v6 13/15] hmp: Print "share" property of memory backends with "info memdev"

2021-04-23 Thread Markus Armbruster
David Hildenbrand writes: > Let's print the property. > > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Dr. David Alan Gilbert > Cc: Markus Armbruster > Cc: Eric Blake > Cc: Igor Mammedov > Signed-off-by: David Hildenbrand > --- > hw/core/machine-hmp-cmds.c | 2 ++ > 1 file changed, 2

Re: [PATCH v6 15/15] hmp: Print "reserve" property of memory backends with "info memdev"

2021-04-23 Thread Markus Armbruster
David Hildenbrand writes: > Let's print the new property. > > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Dr. David Alan Gilbert > Cc: Markus Armbruster > Cc: Eric Blake > Cc: Igor Mammedov > Signed-off-by: David Hildenbrand > --- > hw/core/machine-hmp-cmds.c | 2 ++ > 1 file change

Re: [PATCH v6 10/15] hostmem: Wire up RAM_NORESERVE via "reserve" property

2021-04-23 Thread David Hildenbrand
On 23.04.21 13:14, Markus Armbruster wrote: David Hildenbrand writes: Let's provide a way to control the use of RAM_NORESERVE via memory backends using the "reserve" property which defaults to true (old behavior). Only Linux currently supports clearing the flag (and support is checked at runt

Re: [PATCH v2 5/5] sockets: Support multipath TCP

2021-04-23 Thread Daniel P . Berrangé
On Wed, Apr 21, 2021 at 12:28:34PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Multipath TCP allows combining multiple interfaces/routes into a single > socket, with very little work for the user/admin. > > It's enabled by 'mptcp' on most socket addresses: >

Re: [PATCH v2 5/5] sockets: Support multipath TCP

2021-04-23 Thread Markus Armbruster
"Dr. David Alan Gilbert (git)" writes: > From: "Dr. David Alan Gilbert" > > Multipath TCP allows combining multiple interfaces/routes into a single > socket, with very little work for the user/admin. > > It's enabled by 'mptcp' on most socket addresses: > >./qemu-system-x86_64 -nographic -in

Re: [PATCH v6 10/15] hostmem: Wire up RAM_NORESERVE via "reserve" property

2021-04-23 Thread David Hildenbrand
diff --git a/backends/hostmem.c b/backends/hostmem.c index c6c1ff5b99..58fdc1b658 100644 --- a/backends/hostmem.c +++ b/backends/hostmem.c @@ -217,6 +217,11 @@ static void host_memory_backend_set_prealloc(Object *obj, bool value, Error *local_err = NULL; HostMemoryBackend *backend = M

Re: [PATCH v6 14/15] qmp: Include "reserve" property of memory backends

2021-04-23 Thread Markus Armbruster
David Hildenbrand writes: > On 23.04.21 13:00, Markus Armbruster wrote: >> David Hildenbrand writes: >> >>> Let's include the new property. >>> >>> Reviewed-by: Philippe Mathieu-Daudé >>> Cc: Eric Blake >>> Cc: Markus Armbruster >>> Cc: Igor Mammedov >>> Signed-off-by: David Hildenbrand >>

Re: [PATCH v6 14/15] qmp: Include "reserve" property of memory backends

2021-04-23 Thread David Hildenbrand
On 23.04.21 13:21, Markus Armbruster wrote: David Hildenbrand writes: On 23.04.21 13:00, Markus Armbruster wrote: David Hildenbrand writes: Let's include the new property. Reviewed-by: Philippe Mathieu-Daudé Cc: Eric Blake Cc: Markus Armbruster Cc: Igor Mammedov Signed-off-by: David H

Re: [PATCH v2] vfio-ccw: Permit missing IRQs

2021-04-23 Thread Cornelia Huck
On Wed, 21 Apr 2021 17:20:53 +0200 Eric Farman wrote: > Commit 690e29b91102 ("vfio-ccw: Refactor ccw irq handler") changed > one of the checks for the IRQ notifier registration from saying > "the host needs to recognize the only IRQ that exists" to saying > "the host needs to recognize ANY IRQ th

Re: [PATCH v6 10/15] hostmem: Wire up RAM_NORESERVE via "reserve" property

2021-04-23 Thread Markus Armbruster
David Hildenbrand writes: >>> diff --git a/backends/hostmem.c b/backends/hostmem.c >>> index c6c1ff5b99..58fdc1b658 100644 >>> --- a/backends/hostmem.c >>> +++ b/backends/hostmem.c >>> @@ -217,6 +217,11 @@ static void host_memory_backend_set_prealloc(Object >>> *obj, bool value, >>> Error

Re: [PULL 0/2] pc: last minute bugfixes

2021-04-23 Thread Igor Mammedov
On Fri, 23 Apr 2021 10:01:49 +0100 Daniel P. Berrangé wrote: > On Thu, Apr 22, 2021 at 06:24:48PM -0400, Michael S. Tsirkin wrote: > > The following changes since commit d83f46d189a26fa32434139954d264326f199a45: > > > > virtio-pci: compat page aligned ATS (2021-04-06 07:11:36 -0400) > > > > a

Re: [PATCH v6 10/15] hostmem: Wire up RAM_NORESERVE via "reserve" property

2021-04-23 Thread Markus Armbruster
David Hildenbrand writes: > On 23.04.21 13:14, Markus Armbruster wrote: >> David Hildenbrand writes: >> >>> Let's provide a way to control the use of RAM_NORESERVE via memory >>> backends using the "reserve" property which defaults to true (old >>> behavior). >>> >>> Only Linux currently suppor

Re: [PATCH v6 14/15] qmp: Include "reserve" property of memory backends

2021-04-23 Thread Markus Armbruster
David Hildenbrand writes: > On 23.04.21 13:21, Markus Armbruster wrote: >> David Hildenbrand writes: >> >>> On 23.04.21 13:00, Markus Armbruster wrote: David Hildenbrand writes: > Let's include the new property. > > Reviewed-by: Philippe Mathieu-Daudé > Cc: Eric Blak

Re: [PATCH] target/s390x: fix s390_probe_access to check PAGE_WRITE_ORG for writeability

2021-04-23 Thread Cornelia Huck
On Thu, 22 Apr 2021 16:44:27 +0100 Alex Bennée wrote: > We can remove PAGE_WRITE when (internally) marking a page read-only > because it contains translated code. This can get confused when we are > executing signal return code on signal stacks. > > Fixes: e56552cf07 ("target/s390x: Implement th

Re: [PATCH v3 01/36] tests/test-bdrv-graph-mod: add test_parallel_exclusive_write

2021-04-23 Thread Kevin Wolf
Am 17.03.2021 um 15:34 hat Vladimir Sementsov-Ogievskiy geschrieben: > Add the test that shows that concept of ignore_children is incomplete. > Actually, when we want to update something, ignoring permission of some > existing BdrvChild, we should ignore also the propagated effect of this > child t

Re: [PATCH v6 14/15] qmp: Include "reserve" property of memory backends

2021-04-23 Thread David Hildenbrand
On 23.04.21 14:13, Markus Armbruster wrote: David Hildenbrand writes: On 23.04.21 13:21, Markus Armbruster wrote: David Hildenbrand writes: On 23.04.21 13:00, Markus Armbruster wrote: David Hildenbrand writes: Let's include the new property. Reviewed-by: Philippe Mathieu-Daudé Cc: Er

Re: firmware selection for SEV-ES

2021-04-23 Thread Laszlo Ersek
On 04/23/21 12:31, Pavel Hrdina wrote: > On Fri, Apr 23, 2021 at 10:16:24AM +0200, Michal Privoznik wrote: >> On 4/22/21 4:13 PM, Laszlo Ersek wrote: >>> On 04/21/21 13:51, Pavel Hrdina wrote: >>> Should we file a libvirtd Feature Request (where?) for recognizing the >>> @amd-sev-es feature flag?

Re: [PATCH v3 01/36] tests/test-bdrv-graph-mod: add test_parallel_exclusive_write

2021-04-23 Thread Vladimir Sementsov-Ogievskiy
23.04.2021 15:25, Kevin Wolf wrote: Am 17.03.2021 um 15:34 hat Vladimir Sementsov-Ogievskiy geschrieben: Add the test that shows that concept of ignore_children is incomplete. Actually, when we want to update something, ignoring permission of some existing BdrvChild, we should ignore also the pr

Re: [PATCH v2 1/2] tests/docker: gcc-10 based images for ppc64{, le} tests

2021-04-23 Thread Fabiano Rosas
matheus.fe...@eldorado.org.br writes: > From: Matheus Ferst > > A newer compiler is needed to build tests for Power10 instructions. As > done for arm64 on c729a99d2701, a new '-test-cross' image is created for > ppc64 and ppc64le. As done on 936fda4d771f, a test for compiler support > is added to

Re: [PATCH v2 2/2] tests/tcg/ppc64le: tests for brh/brw/brd

2021-04-23 Thread Fabiano Rosas
matheus.fe...@eldorado.org.br writes: > From: Matheus Ferst > > Tests for Byte-Reverse Halfword, Word and Doubleword > > Signed-off-by: Matheus Ferst Tested in x86_64 with the new container image. Tested-by: Fabiano Rosas > --- > tests/tcg/ppc64/Makefile.target | 7 +++ > tests/tcg/p

Re: [PATCH v2 3/7] linux-user: Pass ka_restorer to do_sigaction

2021-04-23 Thread Alex Bennée
Richard Henderson writes: > The value of ka_restorer needs to be saved in sigact_table. It would be nice to add a comment to sigact_table to describe what it is. This is some of the oldest code in the tree so there seems to be a fair bit of implicit knowledge is the way things are done. > At

[PATCH] qapi: deprecate drive-backup

2021-04-23 Thread Vladimir Sementsov-Ogievskiy
Modern way is using blockdev-add + blockdev-backup, which provides a lot more control on how target is opened. As example of drive-backup problems consider the following: User of drive-backup expects that target will be opened in the same cache and aio mode as source. Corresponding logic is in dr

Re: [PATCH v3 01/36] tests/test-bdrv-graph-mod: add test_parallel_exclusive_write

2021-04-23 Thread Kevin Wolf
Am 23.04.2021 um 14:46 hat Vladimir Sementsov-Ogievskiy geschrieben: > 23.04.2021 15:25, Kevin Wolf wrote: > > Am 17.03.2021 um 15:34 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > Add the test that shows that concept of ignore_children is incomplete. > > > Actually, when we want to update som

Re: firmware selection for SEV-ES

2021-04-23 Thread Pavel Hrdina
On Fri, Apr 23, 2021 at 02:34:02PM +0200, Laszlo Ersek wrote: > On 04/23/21 12:31, Pavel Hrdina wrote: > > On Fri, Apr 23, 2021 at 10:16:24AM +0200, Michal Privoznik wrote: > >> On 4/22/21 4:13 PM, Laszlo Ersek wrote: > >>> On 04/21/21 13:51, Pavel Hrdina wrote: > > >>> Should we file a libvirtd F

Re: [PATCH v3 01/36] tests/test-bdrv-graph-mod: add test_parallel_exclusive_write

2021-04-23 Thread Vladimir Sementsov-Ogievskiy
23.04.2021 15:59, Kevin Wolf wrote: Am 23.04.2021 um 14:46 hat Vladimir Sementsov-Ogievskiy geschrieben: 23.04.2021 15:25, Kevin Wolf wrote: Am 17.03.2021 um 15:34 hat Vladimir Sementsov-Ogievskiy geschrieben: Add the test that shows that concept of ignore_children is incomplete. Actually, whe

Re: [PULL 1/2] amd_iommu: Fix pte_override_page_mask()

2021-04-23 Thread Peter Maydell
On Thu, 22 Apr 2021 at 23:24, Michael S. Tsirkin wrote: > > From: Jean-Philippe Brucker > > AMD IOMMU PTEs have a special mode allowing to specify an arbitrary page > size. Quoting the AMD IOMMU specification: "When the Next Level bits [of > a pte] are 7h, the size of the page is determined by th

Re: firmware selection for SEV-ES

2021-04-23 Thread Laszlo Ersek
On 04/23/21 15:01, Pavel Hrdina wrote: > On Fri, Apr 23, 2021 at 02:34:02PM +0200, Laszlo Ersek wrote: >> On 04/23/21 12:31, Pavel Hrdina wrote: >>> On Fri, Apr 23, 2021 at 10:16:24AM +0200, Michal Privoznik wrote: On 4/22/21 4:13 PM, Laszlo Ersek wrote: > On 04/21/21 13:51, Pavel Hrdina w

Re: [PATCH for 6.0] net: check the existence of peer before trying to pad

2021-04-23 Thread Peter Maydell
On Fri, 23 Apr 2021 at 04:18, Jason Wang wrote: > > There could be case that peer is NULL. This can happen when during > network device hot-add where net device needs to be added first. So > the patch check the existence of peer before trying to do the pad. > > Fixes: 969e50b61a285 ("net: Pad shor

Re: [PATCH] target/s390x: fix s390_probe_access to check PAGE_WRITE_ORG for writeability

2021-04-23 Thread Peter Maydell
On Fri, 23 Apr 2021 at 13:22, Cornelia Huck wrote: > > On Thu, 22 Apr 2021 16:44:27 +0100 > Alex Bennée wrote: > > > We can remove PAGE_WRITE when (internally) marking a page read-only > > because it contains translated code. This can get confused when we are > > executing signal return code on s

Re: [PATCH] qapi: deprecate drive-backup

2021-04-23 Thread Daniel P . Berrangé
On Fri, Apr 23, 2021 at 03:59:00PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Modern way is using blockdev-add + blockdev-backup, which provides a > lot more control on how target is opened. > > As example of drive-backup problems consider the following: > > User of drive-backup expects that ta

Re: [PATCH v2 4/7] linux-user: Honor TARGET_ARCH_HAS_SA_RESTORER in do_syscall

2021-04-23 Thread Alex Bennée
Richard Henderson writes: > Do not access a field that may not be present. This will > become an issue when sharing more code in the next patch. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v2 1/2] tests/docker: gcc-10 based images for ppc64{, le} tests

2021-04-23 Thread Matheus K. Ferst
On 23/04/2021 09:54, Fabiano Rosas wrote: matheus.fe...@eldorado.org.br writes: From: Matheus Ferst A newer compiler is needed to build tests for Power10 instructions. As done for arm64 on c729a99d2701, a new '-test-cross' image is created for ppc64 and ppc64le. As done on 936fda4d771f, a tes

Re: [PATCH v2 5/7] linux-user/alpha: Define TARGET_ARCH_HAS_KA_RESTORER

2021-04-23 Thread Alex Bennée
Richard Henderson writes: > This means that we can share the TARGET_NR_rt_sigaction code, > and the target_rt_sigaction structure is unused. Untangling > the ifdefs so that target_sigaction can be shared will wait > until the next patch. > > Signed-off-by: Richard Henderson Reviewed-by: Alex

Re: [PATCH] qapi: deprecate drive-backup

2021-04-23 Thread Vladimir Sementsov-Ogievskiy
23.04.2021 16:09, Daniel P. Berrangé wrote: On Fri, Apr 23, 2021 at 03:59:00PM +0300, Vladimir Sementsov-Ogievskiy wrote: Modern way is using blockdev-add + blockdev-backup, which provides a lot more control on how target is opened. As example of drive-backup problems consider the following: U

Re: [PATCH v2] vfio-ccw: Permit missing IRQs

2021-04-23 Thread Matthew Rosato
On 4/23/21 7:42 AM, Cornelia Huck wrote: On Wed, 21 Apr 2021 17:20:53 +0200 Eric Farman wrote: Commit 690e29b91102 ("vfio-ccw: Refactor ccw irq handler") changed one of the checks for the IRQ notifier registration from saying "the host needs to recognize the only IRQ that exists" to saying "th

Re: [PATCH for-6.0 v2 2/2] hw/block/nvme: disable hotplugging for subsystem-linked controllers

2021-04-23 Thread Peter Maydell
On Fri, 23 Apr 2021 at 06:21, Klaus Jensen wrote: > > From: Klaus Jensen > > If a controller is linked to a subsystem, do not allow it to be > hotplugged since this will mess up the (possibly shared) namespaces. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 4 > 1 file changed,

Re: [PATCH for-6.0 v2 2/2] hw/block/nvme: disable hotplugging for subsystem-linked controllers

2021-04-23 Thread Klaus Jensen
On Apr 23 14:21, Peter Maydell wrote: On Fri, 23 Apr 2021 at 06:21, Klaus Jensen wrote: From: Klaus Jensen If a controller is linked to a subsystem, do not allow it to be hotplugged since this will mess up the (possibly shared) namespaces. Signed-off-by: Klaus Jensen --- hw/block/nvme.c |

Re: [PATCH for-6.0 v2 2/2] hw/block/nvme: disable hotplugging for subsystem-linked controllers

2021-04-23 Thread Peter Maydell
On Fri, 23 Apr 2021 at 14:25, Klaus Jensen wrote: > > On Apr 23 14:21, Peter Maydell wrote: > >On Fri, 23 Apr 2021 at 06:21, Klaus Jensen wrote: > >> > >> From: Klaus Jensen > >> > >> If a controller is linked to a subsystem, do not allow it to be > >> hotplugged since this will mess up the (pos

Re: [PATCH 1/4] target/ppc: Code motion required to build disabling tcg

2021-04-23 Thread Fabiano Rosas
David Gibson writes: > On Thu, Apr 22, 2021 at 04:35:34PM -0300, Fabiano Rosas wrote: >> Bruno Piazera Larsen writes: >> >> >> > You are correct! I've just tweaked the code that defines spr_register >> >> > and >> >> > it should be working now. I'm still working in splitting the SPR >> >> > f

Re: [PATCH] target/s390x: fix s390_probe_access to check PAGE_WRITE_ORG for writeability

2021-04-23 Thread Thomas Huth
On 23/04/2021 15.06, Peter Maydell wrote: On Fri, 23 Apr 2021 at 13:22, Cornelia Huck wrote: On Thu, 22 Apr 2021 16:44:27 +0100 Alex Bennée wrote: We can remove PAGE_WRITE when (internally) marking a page read-only because it contains translated code. This can get confused when we are execu

Re: [PATCH for-6.0 v2 2/2] hw/block/nvme: disable hotplugging for subsystem-linked controllers

2021-04-23 Thread Klaus Jensen
On Apr 23 14:25, Peter Maydell wrote: On Fri, 23 Apr 2021 at 14:25, Klaus Jensen wrote: On Apr 23 14:21, Peter Maydell wrote: >On Fri, 23 Apr 2021 at 06:21, Klaus Jensen wrote: >> >> From: Klaus Jensen >> >> If a controller is linked to a subsystem, do not allow it to be >> hotplugged since

Re: [PULL 1/2] amd_iommu: Fix pte_override_page_mask()

2021-04-23 Thread Jean-Philippe Brucker
On Fri, Apr 23, 2021 at 02:01:19PM +0100, Peter Maydell wrote: > On Thu, 22 Apr 2021 at 23:24, Michael S. Tsirkin wrote: > > > > From: Jean-Philippe Brucker > > > > AMD IOMMU PTEs have a special mode allowing to specify an arbitrary page > > size. Quoting the AMD IOMMU specification: "When the Ne

Re: trace_FOO_tcg bit-rotted?

2021-04-23 Thread Vilanova, Lluis
El dt. 13 de 04 de 2021 a les 10:25 +0100, en/na Alex Bennée va escriure: > Stefan Hajnoczi writes: > > > On Mon, Apr 12, 2021 at 08:06:57PM +0100, Alex Bennée wrote: > > > > > > Stefan Hajnoczi writes: > > > > > > > On Fri, Apr 09, 2021 at 05:29:08PM +0100, Alex Bennée wrote: > > > > > > > >

Re: socket.c added support for unix domain socket datagram transport

2021-04-23 Thread Ralph Schmieder
> On Apr 23, 2021, at 11:16, Daniel P. Berrangé wrote: > > On Fri, Apr 23, 2021 at 08:56:48AM +0200, Ralph Schmieder wrote: >> Hey... new to this list. I was looking for a way to use Unix domain >> sockets as a network transport between local VMs. >> >> I'm part of a team where we run doze

[PATCH v2] monitor: hmp_qemu_io: acquire aio contex, fix crash

2021-04-23 Thread Vladimir Sementsov-Ogievskiy
Max reported the following bug: $ ./qemu-img create -f raw src.img 1G $ ./qemu-img create -f raw dst.img 1G $ (echo ' {"execute":"qmp_capabilities"} {"execute":"blockdev-mirror", "arguments":{"job-id":"mirror", "device":"source", "target":"target",

[Bug 1721788] Re: Failed to get shared "write" lock with 'qemu-img info'

2021-04-23 Thread Jan Heidbrink
Ah ok, I think this bug can be closed then. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1721788 Title: Failed to get shared "write" lock wi

Re: [PATCH] target/s390x: fix s390_probe_access to check PAGE_WRITE_ORG for writeability

2021-04-23 Thread Cornelia Huck
On Fri, 23 Apr 2021 15:28:19 +0200 Thomas Huth wrote: > On 23/04/2021 15.06, Peter Maydell wrote: > > On Fri, 23 Apr 2021 at 13:22, Cornelia Huck wrote: > >> > >> On Thu, 22 Apr 2021 16:44:27 +0100 > >> Alex Bennée wrote: > >> > >>> We can remove PAGE_WRITE when (internally) marking a page

Re: [PATCH] target/s390x: fix s390_probe_access to check PAGE_WRITE_ORG for writeability

2021-04-23 Thread Peter Maydell
On Fri, 23 Apr 2021 at 14:52, Cornelia Huck wrote: > > On Fri, 23 Apr 2021 15:28:19 +0200 > Thomas Huth wrote: > > > On 23/04/2021 15.06, Peter Maydell wrote: > > > On Fri, 23 Apr 2021 at 13:22, Cornelia Huck wrote: > > >> What's the verdict on this one? I plan to queue this to s390-next; but >

Re: [PATCH v2 1/2] block: Add BDRV_O_NO_SHARE for blk_new_open()

2021-04-23 Thread Kevin Wolf
Am 23.04.2021 um 11:43 hat Vladimir Sementsov-Ogievskiy geschrieben: > 22.04.2021 19:43, Kevin Wolf wrote: > > Normally, blk_new_open() just shares all permissions. This was fine > > originally when permissions only protected against uses in the same > > process because no other part of the code wo

Re: [PATCH v3 04/36] block: bdrv_append(): don't consume reference

2021-04-23 Thread Kevin Wolf
Am 17.03.2021 um 15:34 hat Vladimir Sementsov-Ogievskiy geschrieben: > We have too much comments for this feature. It seems better just don't > do it. Most of real users (tests don't count) have to create additional > reference. > > Drop also comment in external_snapshot_prepare: > - bdrv_append

  1   2   3   >