Re: [PATCH] docs: Add a QEMU Code of Conduct and Conflict Resolution Policy document

On 29/03/2021 22.59, Paolo Bonzini wrote: Il lun 29 mar 2021, 20:33 Daniel P. Berrangé > ha scritto: The obvious alternative is to import the contributor covenant https://www.contributor-covenant.org/ The Contr

Re: [PATCH for-6.0 1/7] hw/block/nvme: fix pi constraint check

On Mar 29 19:52, Gollu Appalanaidu wrote: > On Wed, Mar 24, 2021 at 09:09:01PM +0100, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Protection Information can only be enabled if there is at least 8 bytes > > of metadata. > > > > Signed-off-by: Klaus Jensen > > --- > > hw/block/nvme-ns.c |

Re: [PATCH 0/6] Add debug interface to kick/call on purpose

On 3/28/21 8:56 PM, Jason Wang wrote: > > 在 2021/3/27 上午5:16, Dongli Zhang 写道: >> Hi Jason, >> >> On 3/26/21 12:24 AM, Jason Wang wrote: >>> 在 2021/3/26 下午1:44, Dongli Zhang 写道: The virtio device/driver (e.g., vhost-scsi or vhost-net) may hang due to the loss of doorbell kick, e.g., >

[PATCH] target/xtensa: make xtensa_modules static on import

xtensa_modules variable defined in each xtensa-modules.c.inc is only used locally by the including file. Make it static. Signed-off-by: Max Filippov --- target/xtensa/import_core.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/target/xtensa/import_core.sh b/target/xtensa/import_core.sh in

[PATCH] target/xtensa: fix core import to meson.build

import_core.sh was not updated to change meson.build when new xtensa core is imported. Fix that. Cc: qemu-sta...@nongnu.org # v5.2.0 Signed-off-by: Max Filippov --- target/xtensa/import_core.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/xtensa/import_core.sh b

Re: [PATCH v2 0/6] esp: fix asserts/segfaults discovered by fuzzer

On 18/03/2021 18:13, Paolo Bonzini wrote: On 18/03/21 00:02, Mark Cave-Ayland wrote: Recently there have been a number of issues raised on Launchpad as a result of fuzzing the am53c974 (ESP) device. I spent some time over the past couple of days checking to see if anything had improved since my

Re: [RFC 1/8] memory: Allow eventfd add/del without starting a transaction

On Mon, 29 Mar 2021 18:03:49 +0100 Stefan Hajnoczi wrote: > On Thu, Mar 25, 2021 at 04:07:28PM +0100, Greg Kurz wrote: > > diff --git a/include/exec/memory.h b/include/exec/memory.h > > index 5728a681b27d..98ed552e001c 100644 > > --- a/include/exec/memory.h > > +++ b/include/exec/memory.h > > @@

Re: [PATCH v7 4/4] tests: Add tests for yank with the chardev-change case

Hi Lukas, On Mon, Mar 29, 2021 at 10:55 PM Lukas Straub wrote: > Add tests for yank with the chardev-change case. > > Signed-off-by: Lukas Straub > Reviewed-by: Marc-André Lureau > Tested-by: Li Zhang > --- > MAINTAINERS| 1 + > tests/unit/meson.build | 3 +- > tests/unit/tes

Re: [PATCH] docs: Add a QEMU Code of Conduct and Conflict Resolution Policy document

On Mon, Mar 29, 2021 at 10:59:23PM +0200, Paolo Bonzini wrote: > Il lun 29 mar 2021, 20:33 Daniel P. Berrangé ha > scritto: > > > The obvious alternative is to import the contributor covenant > > > > https://www.contributor-covenant.org/ > > > The Contributor Covenant 1.x and 2.x are very dif

Re: [PATCH] replay: fix recursive checkpoints

On 29.03.2021 14:25, Alex Bennée wrote: Pavel Dovgalyuk writes: Record/replay uses checkpoints to synchronize the execution of the threads and timers. Hardware events such as BH are processed at the checkpoints too. Event processing can cause refreshing the virtual timers and calling the icou

Re: [PULL 00/10] For 6.0 patches

Hi On Mon, Mar 29, 2021 at 9:54 PM Peter Maydell wrote: > On Mon, 29 Mar 2021 at 17:30, Marc-André Lureau > wrote: > > > > Hi > > > > On Mon, Mar 29, 2021 at 7:56 PM Peter Maydell > wrote: > >> > >> On Mon, 29 Mar 2021 at 15:17, Marc-André Lureau > >> wrote: > >> > ../docs/meson.build:30: WAR

Re: [PATCH] ppc/spapr: Add support for implement support for H_SCM_HEALTH

Hi Shiva, Thanks for reviweing this patch. My responses inline below; Shivaprasad G Bhat writes: >> >> +static target_ulong h_scm_health(PowerPCCPU *cpu, SpaprMachineState *spapr, >> + target_ulong opcode, target_ulong *args) >> +{ >> +uint32_t drc_inde

[Bug 1862874] Re: java may stuck for a long time in system mode with "-cpu max"

** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1862874 Title: java may stuck for a long time in system mode with "-cpu max" Status in QEMU: Con

[Bug 1920913] Re: Openjdk11+ fails to install on s390x

Same BUG as https://bugs.launchpad.net/qemu/+bug/1862874 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1920913 Title: Openjdk11+ fails to install on s390x Status in QEMU: New Bug description:

[PATCH v2] docs: Add a QEMU Code of Conduct and Conflict Resolution Policy document

In an ideal world, we would all get along together very well, always be polite and never end up in huge conflicts. And even if there are conflicts, we would always handle each other fair and respectfully. Unfortunately, this is not an ideal world and sometimes people forget how to interact with eac

Re: [PATCH v5 5/5] virtiofsd: Switch creds, drop FSETID for system.posix_acl_access xattr

On Mon, Mar 29, 2021 at 03:51:51PM -0400, Vivek Goyal wrote: > On Mon, Mar 29, 2021 at 04:35:57PM +0100, Luis Henriques wrote: > > On Thu, Mar 25, 2021 at 11:38:52AM -0400, Vivek Goyal wrote: > > > When posix access acls are set on a file, it can lead to adjusting file > > > permissions (mode) as w

Re: [PATCH v2] qapi: introduce 'query-cpu-model-cpuid' action

On Tue, Mar 30, 2021 at 02:15:10AM +0200, Igor Mammedov wrote: > On Thu, 25 Mar 2021 19:57:05 +0300 > Valeriy Vdovin wrote: > > > Introducing new qapi method 'query-cpu-model-cpuid'. This method can be > > used to > > get virtualized cpu model info generated by QEMU during VM initialization in >

Re: [PATCH v4 for-6.0? 0/3] qcow2: fix parallel rewrite and discard (rw-lock)

On 25.03.21 20:12, Vladimir Sementsov-Ogievskiy wrote: ping. Do we want it for 6.0? I’d rather wait. I think the conclusion was that guests shouldn’t hit this because they serialize discards? There’s also something Kevin wrote on IRC a couple of weeks ago, for which I had hoped he’d sent a

[PATCH v3 2/3] ppc: Rename current DAWR macros and variables

Power10 is introducing second DAWR. Use real register names (with suffix 0) from ISA for current macros and variables used by Qemu. One exception to this is KVM_REG_PPC_DAWR[X]. This is from kernel uapi header and thus not changed in kernel as well as Qemu. Signed-off-by: Ravi Bangoria --- incl

[PATCH v3 0/3] ppc: Enable 2nd DAWR support on Power10

This series enables 2nd DAWR support on p10 qemu guest. 2nd DAWR is new watchpoint added in Power10 processor. Kernel/kvm patches are already in[1]. Watchpoint on powerpc TCG guest is not supported and thus 2nd DAWR is not enabled for TCG mode. Patches apply fine on qemu/master branch (9e2e9fe3df9

[PATCH v3 3/3] ppc: Enable 2nd DAWR support on p10

As per the PAPR, bit 0 of byte 64 in pa-features property indicates availability of 2nd DAWR registers. i.e. If this bit is set, 2nd DAWR is present, otherwise not. Use KVM_CAP_PPC_DAWR1 capability to find whether kvm supports 2nd DAWR or not. If it's supported, allow user to set the pa-feature bit

[PATCH v3 1/3] Linux headers: update from 5.12-rc3

Update against Linux 5.12-rc3 Signed-off-by: Ravi Bangoria --- include/standard-headers/drm/drm_fourcc.h | 23 - include/standard-headers/linux/input.h| 2 +- .../standard-headers/rdma/vmw_pvrdma-abi.h| 7 ++ linux-headers/asm-generic/unistd.h| 4 +- linux-head

Re: [PATCH] docs: Add a QEMU Code of Conduct and Conflict Resolution Policy document

On 30/03/21 09:13, Thomas Huth wrote: Contributor Covenant 1.x is certainly an option, too, but it has IMHO already quite rigorous language ("Project maintainers have the [...] responsibility to remove, edit, or reject comments, commits, code, wiki edits ...", "Project maintainers who do not [.

Re: [PATCH v2 0/6] esp: fix asserts/segfaults discovered by fuzzer

On 30/03/21 09:34, Mark Cave-Ayland wrote: Hi Paolo, I had a quick look at Alex's updated test cases and most of them are based on an incorrect assumption I made around the behaviour of fifo8_pop_buf(). Can you drop these for now, and I will submit a v3 shortly once I've given it a full run t

[Bug 1920913] Re: Openjdk11+ fails to install on s390x

Tried building jdk 11 from source, the generated executable still crashes(fastdebug as well as release mode): ``` root@24d396a17e00:~/jdk# build/linux-s390x-normal-server-release/jdk/bin/java -version # # A fatal error has been detected by the Java Runtime Environment: # # SIGILL (0x4) at pc=0x0

Re: [PATCH v10 1/6] arm64: mte: Sync tags for pages where PTE is untagged

On Mon, Mar 29, 2021 at 04:55:29PM +0100, Steven Price wrote: > On 26/03/2021 18:56, Catalin Marinas wrote: > > On Fri, Mar 12, 2021 at 03:18:57PM +, Steven Price wrote: > > > A KVM guest could store tags in a page even if the VMM hasn't mapped > > > the page with PROT_MTE. So when restoring pa

Re: [RFC 1/8] memory: Allow eventfd add/del without starting a transaction

On Tue, Mar 30, 2021 at 09:47:49AM +0200, Greg Kurz wrote: > On Mon, 29 Mar 2021 18:03:49 +0100 > Stefan Hajnoczi wrote: > > > On Thu, Mar 25, 2021 at 04:07:28PM +0100, Greg Kurz wrote: > > > diff --git a/include/exec/memory.h b/include/exec/memory.h > > > index 5728a681b27d..98ed552e001c 100644

Re: [RFC 3/8] virtio: Add API to batch set host notifiers

On Mon, 29 Mar 2021 18:10:57 +0100 Stefan Hajnoczi wrote: > On Thu, Mar 25, 2021 at 04:07:30PM +0100, Greg Kurz wrote: > > Introduce VirtioBusClass methods to begin and commit a transaction > > of setting/unsetting host notifiers. These handlers will be implemented > > by virtio-pci to batch addi

Re: [PATCH] hw/block/nvme: remove description for zoned.append_size_limit

On Tue, Mar 23, 2021 at 12:20:32PM +0100, Klaus Jensen wrote: > On Mar 23 11:18, Niklas Cassel wrote: > > From: Niklas Cassel > > > > The description was originally removed in commit 578d914b263c > > ("hw/block/nvme: align zoned.zasl with mdts") together with the removal > > of the zoned.append_s

Re: [RFC 4/8] virtio-pci: Batch add/del ioeventfds in a single MR transaction

On Mon, 29 Mar 2021 18:24:40 +0100 Stefan Hajnoczi wrote: > On Thu, Mar 25, 2021 at 04:07:31PM +0100, Greg Kurz wrote: > > diff --git a/softmmu/memory.c b/softmmu/memory.c > > index 1b1942d521cc..0279e5671bcb 100644 > > --- a/softmmu/memory.c > > +++ b/softmmu/memory.c > > @@ -2368,7 +2368,7 @@ v

Re: [PATCH v10 2/6] arm64: kvm: Introduce MTE VM feature

On Mon, Mar 29, 2021 at 05:06:51PM +0100, Steven Price wrote: > On 28/03/2021 13:21, Catalin Marinas wrote: > > On Sat, Mar 27, 2021 at 03:23:24PM +, Catalin Marinas wrote: > > > On Fri, Mar 12, 2021 at 03:18:58PM +, Steven Price wrote: > > > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64

Re: [RFC v1] hw/smbios: support for type 41 (onboard devices extended information)

On Sun, Mar 28, 2021 at 10:57:26PM +0200, Vincent Bernat wrote: > Type 41 defines the attributes of devices that are onboard. The > original intent was to imply the BIOS had some level of control over > the enablement of the associated devices. > > If network devices are present in this table, by

Re: [PATCH v3 4/5] qemu-iotests: let "check" spawn an arbitrary test command

On 26.03.21 16:05, Max Reitz wrote: On 26.03.21 15:23, Paolo Bonzini wrote: Right now there is no easy way for "check" to print a reproducer command. Because such a reproducer command line would be huge, we can instead teach check to start a command of our choice.  This can be for example a Py

Re: [PATCH v3 4/5] qemu-iotests: let "check" spawn an arbitrary test command

On 30.03.21 12:38, Max Reitz wrote: On 26.03.21 16:05, Max Reitz wrote: On 26.03.21 15:23, Paolo Bonzini wrote: Right now there is no easy way for "check" to print a reproducer command. Because such a reproducer command line would be huge, we can instead teach check to start a command of our c

Re: [PATCH v4 for-6.0? 0/3] qcow2: fix parallel rewrite and discard (rw-lock)

30.03.2021 12:49, Max Reitz wrote: On 25.03.21 20:12, Vladimir Sementsov-Ogievskiy wrote: ping. Do we want it for 6.0? I’d rather wait.  I think the conclusion was that guests shouldn’t hit this because they serialize discards? I think, that we never had bugs, so we of course can wait. T

Re: [PATCH v2] docs: Add a QEMU Code of Conduct and Conflict Resolution Policy document

On 30/03/21 11:08, Thomas Huth wrote: I've picked the Django Code of Conduct as a base, since it sounds rather friendly and still welcoming to me, but I'm open for other suggestions, too (but we should maybe pick one where the conflict resolution policy is separated from the CoC itself so

Re: [PATCH v3 4/5] qemu-iotests: let "check" spawn an arbitrary test command

On 30.03.21 12:44, Max Reitz wrote: On 30.03.21 12:38, Max Reitz wrote: On 26.03.21 16:05, Max Reitz wrote: On 26.03.21 15:23, Paolo Bonzini wrote: Right now there is no easy way for "check" to print a reproducer command. Because such a reproducer command line would be huge, we can instead te

Re: [PATCH v2 0/2] qcow2: Force preallocation with data-file-raw

On 26.03.21 15:55, Max Reitz wrote: v1: https://lists.nongnu.org/archive/html/qemu-block/2020-06/msg00992.html Hi, I think that qcow2 images with data-file-raw should always have preallocated 1:1 L1/L2 tables, so that the image always looks the same whether you respect or ignore the qcow2 meta

Re: [PATCH v3 4/5] qemu-iotests: let "check" spawn an arbitrary test command

On 30/03/21 12:57, Max Reitz wrote: 297 says: check:125: error: Argument 1 to "Path" has incompatible type "Optional[str]"; expected "Union[str, _PathLike[str]]" Found 1 error in 1 file (checked 1 source file) Weird, I had tested this and I cannot reproduce it. diff --git a/tests/qemu-iot

Re: Serious doubts about Gitlab CI

On Mon, Mar 29, 2021 at 03:10:36PM +0100, Stefan Hajnoczi wrote: > Hi, > I wanted to follow up with a summary of the CI jobs: > > 1. Containers & Containers Layer2 - ~3 minutes/job x 39 jobs > 2. Builds - ~50 minutes/job x 61 jobs > 3. Tests - ~12 minutes/job x 20 jobs > 4. Deploy - 52 minutes x 1

Re: Ways to deal with broken machine types

On Tuesday, 2021-03-23 at 15:40:24 -04, Michael S. Tsirkin wrote: > On Tue, Mar 23, 2021 at 05:40:36PM +, Daniel P. Berrangé wrote: >> On Tue, Mar 23, 2021 at 05:54:47PM +0100, Igor Mammedov wrote: >> > Let me hijack this thread for beyond this case scope. >> > >> > I agree that for this part

Re: [PATCH v3 0/5] qemu-iotests: quality of life improvements

On 26.03.21 15:23, Paolo Bonzini wrote: This series adds a few usability improvements to qemu-iotests, in particular: - arguments can be passed to Python unittests scripts, for example to run only a subset of the test cases (patches 1-2) - it is possible to do "./check -- ../../../tests/qemu

Re: [PATCH v3 0/5] qemu-iotests: quality of life improvements

On 30.03.21 13:32, Max Reitz wrote: On 26.03.21 15:23, Paolo Bonzini wrote: This series adds a few usability improvements to qemu-iotests, in particular: - arguments can be passed to Python unittests scripts, for example    to run only a subset of the test cases (patches 1-2) - it is possible

Re: [PATCH v2] i386: Make migration fail when Hyper-V reenlightenment was enabled but 'user_tsc_khz' is unset

"Dr. David Alan Gilbert" writes: > * Vitaly Kuznetsov (vkuzn...@redhat.com) wrote: >> "Dr. David Alan Gilbert" writes: >> >> > * Vitaly Kuznetsov (vkuzn...@redhat.com) wrote: >> >> KVM doesn't fully support Hyper-V reenlightenment notifications on >> >> migration. In particular, it doesn't supp

Re: [PATCH v3 0/5] qemu-iotests: quality of life improvements

On 30/03/21 13:44, Max Reitz wrote: On 30.03.21 13:32, Max Reitz wrote: On 26.03.21 15:23, Paolo Bonzini wrote: This series adds a few usability improvements to qemu-iotests, in particular: - arguments can be passed to Python unittests scripts, for example    to run only a subset of the test c

Re: Ways to deal with broken machine types

On Tue, Mar 30, 2021 at 12:21:37PM +0100, David Edmondson wrote: > > Unfortunately I do not think this is practical :(. > > > > All examples of breakage I am aware of, we did not > > realise some part of interface was part of guest ABI > > and unsafe to change. We simply would not know to write a >

Re: Serious doubts about Gitlab CI

On 30/03/2021 13.19, Daniel P. Berrangé wrote: On Mon, Mar 29, 2021 at 03:10:36PM +0100, Stefan Hajnoczi wrote: Hi, I wanted to follow up with a summary of the CI jobs: 1. Containers & Containers Layer2 - ~3 minutes/job x 39 jobs 2. Builds - ~50 minutes/job x 61 jobs 3. Tests - ~12 minutes/job

Re: [PATCH v5 4/6] qcow2: introduce inflight-write-counters

26.03.2021 23:00, Vladimir Sementsov-Ogievskiy wrote: We have a bug in qcow2: assume we've started data write into host cluster A. s->lock is unlocked. During the write the refcount of cluster A may become zero, cluster may be reallocated for other needs, and our in-flight write become a use-afte

Re: [PULL for-6.0 0/2] emulated nvme fixes

On Mon, 29 Mar 2021 at 18:04, Klaus Jensen wrote: > > From: Klaus Jensen > > Hi Peter, > > The following changes since commit ec2e6e016d24bd429792d08cf607e4c5350dcdaa: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-6.0-pull-request' into staging > (2021-03-28 19:49:57

Re: Serious doubts about Gitlab CI

On 30/03/21 13:55, Thomas Huth wrote: Since the build system has been converted to meson, I think the configure script prefers to use the submodules instead of the distro packages. I've tried to remedy this a little bit here: https://gitlab.com/qemu-project/qemu/-/commit/db0108d5d846e9a8 ..

Re: Serious doubts about Gitlab CI

On 30/03/21 13:55, Thomas Huth wrote: Since the build system has been converted to meson, I think the configure script prefers to use the submodules instead of the distro packages. I've tried to remedy this a little bit here: https://gitlab.com/qemu-project/qemu/-/commit/db0108d5d846e9a8 ..

Re: [PULL 00/10] For 6.0 patches

On Tue, 30 Mar 2021 at 09:29, Marc-André Lureau wrote: > > Hi > > On Mon, Mar 29, 2021 at 9:54 PM Peter Maydell > wrote: >> aarch64 CI machine, which has python 3.8.5 and sphinx-build 1.8.5. >> My guess is that it might be the sphinx-build version here. I vaguely >> recall that Sphinx is kind of

Re: [PATCH] target/xtensa: make xtensa_modules static on import

On 3/30/21 9:30 AM, Max Filippov wrote: > xtensa_modules variable defined in each xtensa-modules.c.inc is only > used locally by the including file. Make it static. > Reported-by: Yury Gribov > Signed-off-by: Max Filippov Reviewed-by: Philippe Mathieu-Daudé > --- > target/xtensa/import_cor

Re: Serious doubts about Gitlab CI

On Tue, 30 Mar 2021 at 12:56, Thomas Huth wrote: > Right, I think we should also work more towards consolidating the QEMU > binaries, to avoid that we have to always build sooo many target binaries > again and again. E.g.: > > - Do we still need to support 32-bit hosts? If not we could >finall

Re: Serious doubts about Gitlab CI

On 3/30/21 2:09 PM, Paolo Bonzini wrote: > On 30/03/21 13:55, Thomas Huth wrote: >> >> Also I wonder whether we could maybe even get rid of the capstone and >> slirp submodules in QEMU now > > At least for slirp, we probably want to stay more on the bleeding edge > which implies having to keep the

Re: Serious doubts about Gitlab CI

On 3/30/21 1:55 PM, Thomas Huth wrote: > On 30/03/2021 13.19, Daniel P. Berrangé wrote: >> On Mon, Mar 29, 2021 at 03:10:36PM +0100, Stefan Hajnoczi wrote: >>> Traditionally ccache (https://ccache.dev/) was used to detect >>> recompilation of the same compiler input files. This is trickier to do >

[PATCH] i386: Make 'hv-reenlightenment' require explicit 'tsc-frequency' setting

Commit 561dbb41b1d7 "i386: Make migration fail when Hyper-V reenlightenment was enabled but 'user_tsc_khz' is unset" forbade migrations with when guest has opted for reenlightenment notifications but 'tsc-frequency' wasn't set explicitly on the command line. This works but the migration fail late a

Re: [PATCH] hw/block/nvme: remove description for zoned.append_size_limit

On Mar 30 10:19, Niklas Cassel wrote: > On Tue, Mar 23, 2021 at 12:20:32PM +0100, Klaus Jensen wrote: > > On Mar 23 11:18, Niklas Cassel wrote: > > > From: Niklas Cassel > > > > > > The description was originally removed in commit 578d914b263c > > > ("hw/block/nvme: align zoned.zasl with mdts") t

[PULL 0/9] Block patches for 6.0-rc1

The following changes since commit ec2e6e016d24bd429792d08cf607e4c5350dcdaa: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-6.0-pull-request' into staging (2021-03-28 19:49:57 +0100) are available in the Git repository at: https://github.com/XanClic/qemu.git tags/pull-bl

[PULL 3/9] iotests/116: Fix reference output

15ce94a68ca ("block/qed: bdrv_qed_do_open: deal with errp") has improved the qed driver's error reporting, though sadly did not add a test for it. The good news are: There already is such a test, namely 116. The bad news are: Its reference output was not adjusted, and so now it fails. Let's fix th

[PULL 1/9] iotests: Fix typo in iotest 051

From: Tao Xu There is an typo in iotest 051, correct it. Signed-off-by: Tao Xu Message-Id: <20210324084321.90952-1-tao3...@intel.com> Signed-off-by: Max Reitz --- tests/qemu-iotests/051| 2 +- tests/qemu-iotests/051.pc.out | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) di

[PULL 6/9] block/mirror: Fix mirror_top's permissions

mirror_top currently shares all permissions, and takes only the WRITE permission (if some parent has taken that permission, too). That is wrong, though; mirror_top is a filter, so it should take permissions like any other filter does. For example, if the parent needs CONSISTENT_READ, we need to t

[PULL 4/9] qcow2: use external virtual timers

From: Pavel Dovgalyuk Regular virtual timers are used to emulate timings related to vCPU and peripheral states. QCOW2 uses timers to clean the cache. These timers should have external flag. In the opposite case they affect the execution and it can't be recorded and replayed. This patch adds exter

[PULL 7/9] qsd: Document FUSE exports

Implementing FUSE exports required no changes to the storage daemon, so we forgot to document them there. Considering that both NBD and vhost-user-blk exports are documented in its man page (and NBD exports in its --help text), we should probably do the same for FUSE. Signed-off-by: Max Reitz Me

Re: An error due to installation that require binutils package

Hi John, On Mon, Mar 29, 2021 at 09:46:49PM +0300, John Simpson wrote: Hello, Kindly ask you to have a look at this bug. Thank you for your replies. It's already fixed in QEMU upstream and the fix will be released with the 6.0 version next month (the rc0 is already available): https://gitla

[PULL 2/9] iotests: fix 051.out expected output after error text touchups

From: Connor Kuehl A patch was recently applied that touched up some error messages that pertained to key names like 'node-name'. The trouble is it only updated tests/qemu-iotests/051.pc.out and not tests/qemu-iotests/051.out as well. Do that now. Fixes: 785ec4b1b9 ("block: Clarify error messag

[PULL 5/9] iotests/046: Filter request length

For its concurrent requests, 046 has always filtered the offset, probably because concurrent requests may settle in any order. However, it did not filter the request length, and so if requests with different lengths settle in an unexpected order (notably the longer request before the shorter reque

Re: [PATCH v4 for-6.0? 0/3] qcow2: fix parallel rewrite and discard (rw-lock)

On 30.03.21 12:51, Vladimir Sementsov-Ogievskiy wrote: 30.03.2021 12:49, Max Reitz wrote: On 25.03.21 20:12, Vladimir Sementsov-Ogievskiy wrote: ping. Do we want it for 6.0? I’d rather wait.  I think the conclusion was that guests shouldn’t hit this because they serialize discards? I think

[PULL 8/9] qcow2: Force preallocation with data-file-raw

Setting the qcow2 data-file-raw bit means that you can ignore the qcow2 metadata when reading from the external data file. It does not mean that you have to ignore it, though. Therefore, the data read must be the same regardless of whether you interpret the metadata or whether you ignore it, and

[PULL 9/9] iotests/244: Test preallocation for data-file-raw

Three test cases: (1) Adding a qcow2 (metadata) file to an existing data file, see whether we can read the existing data through the qcow2 image. (2) Append data to the data file, grow the qcow2 image accordingly, see whether we can read the new data through the qcow2 image. (3) At runtime,

Re: [PATCH for-6.0 5/7] hw/block/nvme: fix warning about legacy namespace configuration

On Wed, Mar 24, 2021 at 09:09:05PM +0100, Klaus Jensen wrote: From: Klaus Jensen Remove the unused BlockConf from the controller structure and fix the constraint checking to actually check the right BlockConf and issue the warning. Signed-off-by: Klaus Jensen --- hw/block/nvme.h | 1 - hw/bloc

Re: [PATCH for-6.0 6/7] hw/block/nvme: update dmsrl limit on namespace detachment

On Wed, Mar 24, 2021 at 09:09:06PM +0100, Klaus Jensen wrote: From: Klaus Jensen The Non-MDTS DMSRL limit must be recomputed when namespaces are detached. Fixes: 645ce1a70cb6 ("hw/block/nvme: support namespace attachment command") Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 17 +

Re: Serious doubts about Gitlab CI

On 30/03/21 14:23, Philippe Mathieu-Daudé wrote: On 3/30/21 2:09 PM, Paolo Bonzini wrote: On 30/03/21 13:55, Thomas Huth wrote: Also I wonder whether we could maybe even get rid of the capstone and slirp submodules in QEMU now At least for slirp, we probably want to stay more on the bleeding

Re: [PATCH v2] docs: Add a QEMU Code of Conduct and Conflict Resolution Policy document

On Tue, Mar 30, 2021 at 12:53:04PM +0200, Paolo Bonzini wrote: > On 30/03/21 11:08, Thomas Huth wrote: > > I've picked the Django Code of Conduct as a base, since it sounds rather > > friendly and still welcoming to me, but I'm open for other suggestions, > > too > > (but we should maybe pic

Re: [PATCH for-6.0 1/7] hw/block/nvme: fix pi constraint check

On Tue, Mar 30, 2021 at 09:24:59AM +0200, Klaus Jensen wrote: On Mar 29 19:52, Gollu Appalanaidu wrote: On Wed, Mar 24, 2021 at 09:09:01PM +0100, Klaus Jensen wrote: > From: Klaus Jensen > > Protection Information can only be enabled if there is at least 8 bytes > of metadata. > > Signed-off-by

Re: [RFC v1] hw/smbios: support for type 41 (onboard devices extended information)

❦ 30 mars 2021 11:35 +01, Daniel P. Berrangé: >> If network devices are present in this table, by default, udev will >> name the corresponding interfaces enoX, X being the instance number. >> Without such information, udev will fallback to using the PCI ID and >> this usually gives ens3 or ens4.

Re: Serious doubts about Gitlab CI

On Tue, Mar 30, 2021 at 02:09:38PM +0200, Paolo Bonzini wrote: > On 30/03/21 13:55, Thomas Huth wrote: > > > > Since the build system has been converted to meson, I think the > > configure script prefers to use the submodules instead of the distro > > packages. I've tried to remedy this a little b

Re: Serious doubts about Gitlab CI

On Tue, Mar 30, 2021 at 02:45:43PM +0200, Paolo Bonzini wrote: > On 30/03/21 14:23, Philippe Mathieu-Daudé wrote: > > On 3/30/21 2:09 PM, Paolo Bonzini wrote: > > > On 30/03/21 13:55, Thomas Huth wrote: > > > > > > > > Also I wonder whether we could maybe even get rid of the capstone and > > > > s

Re: [RFC 0/8] virtio: Improve boot time of virtio-scsi-pci and virtio-blk-pci

On Mon, 29 Mar 2021 18:35:16 +0100 Stefan Hajnoczi wrote: > On Thu, Mar 25, 2021 at 04:07:27PM +0100, Greg Kurz wrote: > > Now that virtio-scsi-pci and virtio-blk-pci map 1 virtqueue per vCPU, > > a serious slow down may be observed on setups with a big enough number > > of vCPUs. > > > > Exempl

Re: Serious doubts about Gitlab CI

On Tue, Mar 30, 2021 at 01:55:48PM +0200, Thomas Huth wrote: > On 30/03/2021 13.19, Daniel P. Berrangé wrote: > > Another example, is that we test builds on centos7 with > > three different combos of crypto backend settings. This was > > to exercise bugs we've seen in old crypto packages in RHEL-7

Re: Serious doubts about Gitlab CI

On 30/03/21 15:12, Daniel P. Berrangé wrote: Now, but that may change already in 6.1 in order to add CFI support. We can bundle a newer version, but we don't need to require a newer version. Simply conditional compile for the bits we need. If distro slirp is too old, then sorry, you can't enable

Re: [PATCH v4 for-6.0? 0/3] qcow2: fix parallel rewrite and discard (rw-lock)

30.03.2021 15:51, Max Reitz wrote: On 30.03.21 12:51, Vladimir Sementsov-Ogievskiy wrote: 30.03.2021 12:49, Max Reitz wrote: On 25.03.21 20:12, Vladimir Sementsov-Ogievskiy wrote: ping. Do we want it for 6.0? I’d rather wait.  I think the conclusion was that guests shouldn’t hit this becaus

[PULL 0/5] target-arm queue

ydell/qemu-arm.git pull-target-arm-20210330 for you to fetch changes up to b9e3f1579a4b06fc63dfa8cdb68df1c58eeb0cf1: hw/timer/renesas_tmr: Add default-case asserts in read_tcnt() (2021-03-30 14:05:34 +0100) * net/npcm7xx_emc.c: Fix h

[PULL 2/5] hw/display/xlnx_dp: Free FIFOs adding xlnx_dp_finalize()

From: Philippe Mathieu-Daudé When building with --enable-sanitizers we get: Direct leak of 16 byte(s) in 1 object(s) allocated from: #0 0x5618479ec7cf in malloc (qemu-system-aarch64+0x233b7cf) #1 0x7f675745f958 in g_malloc (/lib64/libglib-2.0.so.0+0x58958) #2 0x561847c2dcc9 i

[PULL 4/5] target/arm: Make number of counters in PMCR follow the CPU

Currently we give all the v7-and-up CPUs a PMU with 4 counters. This means that we don't provide the 6 counters that are required by the Arm BSA (Base System Architecture) specification if the CPU supports the Virtualization extensions. Instead of having a single PMCR_NUM_COUNTERS, make each CPU

[PULL 3/5] hw/arm/smmuv3: Drop unused CDM_VALID() and is_cd_valid()

From: Zenghui Yu They were introduced in commit 9bde7f0674fe ("hw/arm/smmuv3: Implement translate callback") but never actually used. Drop them. Signed-off-by: Zenghui Yu Acked-by: Eric Auger Message-id: 20210325142702.790-1-yuzeng...@huawei.com Reviewed-by: Peter Maydell Signed-off-by: Peter

[PULL 5/5] hw/timer/renesas_tmr: Add default-case asserts in read_tcnt()

In commit 81b3ddaf8772ec we fixed a use of uninitialized data in read_tcnt(). However this change wasn't enough to placate Coverity, which is not smart enough to see that if we read a 2 bit field and then handle cases 0, 1, 2 and 3 then there cannot be a flow of execution through the switch default

[PULL 1/5] net/npcm7xx_emc.c: Fix handling of receiving packets when RSDR not set

From: Doug Evans Turning REG_MCMDR_RXON is enough to start receiving packets. Signed-off-by: Doug Evans Message-id: 20210319195044.741821-1-...@google.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/net/npcm7xx_emc.c | 4 +++- tests/qtest/npcm7xx_emc-test.c | 30

Re: Serious doubts about Gitlab CI

On Tue, Mar 30, 2021 at 03:19:49PM +0200, Paolo Bonzini wrote: > On 30/03/21 15:12, Daniel P. Berrangé wrote: > > > Now, but that may change already in 6.1 in order to add CFI support. > > We can bundle a newer version, but we don't need to require a newer > > version. Simply conditional compile fo

Re: [PATCH 3/5] tools/vhost-user-i2c: Add backend driver

Viresh Kumar writes: > On 25-03-21, 13:09, Jie Deng wrote: >> >> On 2021/3/24 15:33, Viresh Kumar wrote: > >> > +/* vhost-user-i2c definitions */ >> > + >> > +#ifndef container_of >> > +#define container_of(ptr, type, member) ({ \ >> > +const typeof(((type *) 0)

Re: [RFC 3/8] virtio: Add API to batch set host notifiers

On Tue, Mar 30, 2021 at 12:17:40PM +0200, Greg Kurz wrote: > On Mon, 29 Mar 2021 18:10:57 +0100 > Stefan Hajnoczi wrote: > > On Thu, Mar 25, 2021 at 04:07:30PM +0100, Greg Kurz wrote: > > > @@ -315,6 +338,10 @@ static void > > > virtio_bus_unset_and_cleanup_host_notifiers(VirtioBusState *bus, > >

Re: [PATCH v2] docs: Add a QEMU Code of Conduct and Conflict Resolution Policy document

On 30/03/21 15:02, Daniel P. Berrangé wrote: Consider someone is kicked out from another project for violation of that project's CoC, that would also be considered a violation under QEMU's CoC. This qualifier is explicitly stating that the CoC violation in the other project has no bearing on whet

[PATCH v6 2/5] virtiofsd: Add capability to change/restore umask

When parent directory has default acl and a file is created in that directory, then umask is ignored and final file permissions are determined using default acl instead. (man 2 umask). Currently, fuse applies the umask and sends modified mode in create request accordingly. fuse server can set FUSE

Re: Serious doubts about Gitlab CI

On Tue, Mar 30, 2021 at 12:19:38PM +0100, Daniel P. Berrangé wrote: > On Mon, Mar 29, 2021 at 03:10:36PM +0100, Stefan Hajnoczi wrote: > > Hi, > > I wanted to follow up with a summary of the CI jobs: > > > > 1. Containers & Containers Layer2 - ~3 minutes/job x 39 jobs > > 2. Builds - ~50 minutes/j

[PATCH v6 3/5] virtiofsd: Add an option to enable/disable posix acls

fuse has an option FUSE_POSIX_ACL which needs to be opted in by fuse server to enable posix acls. As of now we are not opting in for this, so posix acls are disabled on virtiofs by default. Add virtiofsd option "-o posix_acl/no_posix_acl" to let users enable/disable posix acl support. By default i

[PATCH v6 1/5] virtiofsd: Add umask to seccom allow list

Patches in this series are going to make use of "umask" syscall. So allow it. Signed-off-by: Vivek Goyal Reviewed-by: Stefan Hajnoczi --- tools/virtiofsd/passthrough_seccomp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virtiofsd/passthrough_seccomp.c b/tools/virtiofsd/passthrou

[PATCH v6 0/5] virtiofsd: Add support to enable/disable posix acl

Hi, This is V6 of the patches. Changes since V5: - If user asked to enable posix acl and if it can't be enabled, give a clear message before failure. (Luis). - Took care of some coding style issues. Corresponding kernel patches are posted here. https://lore.kernel.org/linux-fsdevel/202103251

[PATCH v6 4/5] virtiofsd: Add support for setxattr_v2

Add the bits to enable support for setxattr_v2 if fuse offers it. Signed-off-by: Vivek Goyal --- include/standard-headers/linux/fuse.h | 12 +++- tools/virtiofsd/fuse_common.h | 6 tools/virtiofsd/fuse_lowlevel.c | 42 ++- tools/virtiofsd/fuse_lowl

Re: [RFC 3/8] virtio: Add API to batch set host notifiers

On Tue, 30 Mar 2021 14:55:42 +0100 Stefan Hajnoczi wrote: > On Tue, Mar 30, 2021 at 12:17:40PM +0200, Greg Kurz wrote: > > On Mon, 29 Mar 2021 18:10:57 +0100 > > Stefan Hajnoczi wrote: > > > On Thu, Mar 25, 2021 at 04:07:30PM +0100, Greg Kurz wrote: > > > > @@ -315,6 +338,10 @@ static void > >

Re: Serious doubts about Gitlab CI

On Tue, Mar 30, 2021 at 01:55:48PM +0200, Thomas Huth wrote: > On 30/03/2021 13.19, Daniel P. Berrangé wrote: > > On Mon, Mar 29, 2021 at 03:10:36PM +0100, Stefan Hajnoczi wrote: > > > Hi, > > > I wanted to follow up with a summary of the CI jobs: > > > > > > 1. Containers & Containers Layer2 - ~3

  1   2   3   >