Re: [PATCH v3 0/8] [RfC] fix tracing for modules

2021-03-29 Thread Stefan Hajnoczi
On Mon, Mar 22, 2021 at 11:46:55AM +, Daniel P. Berrangé wrote: > On Mon, Mar 22, 2021 at 11:36:39AM +, Stefan Hajnoczi wrote: > > On Mon, Feb 22, 2021 at 04:13:32PM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > > > TODO: > > > > > Enabling modular tracepoints via -trace cmd line doe

Re: [PATCH] target/alpha: fix icount handling for timer instructions

2021-03-29 Thread Richard Henderson
On 3/29/21 1:42 AM, Pavel Dovgalyuk wrote: This patch handles icount mode for timer read/write instructions, because it is required to call gen_io_start in such cases. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Richard Henderson Queued for 6.0. r~

[PATCH v6 0/4] yank: Add chardev tests and fixes

2021-03-29 Thread Lukas Straub
Hello Everyone, These patches increase test coverage for yank, add tests and fix bugs and crashes in yank in combination with chardev-change. Please Review. Regards, Lukas Straub Changes: -v6: -test: (hopefully) fix test on OSX by using qio_net_listener on the dummy server socket so new client

[PATCH v6 4/4] tests: Add tests for yank with the chardev-change case

2021-03-29 Thread Lukas Straub
Add tests for yank with the chardev-change case. Signed-off-by: Lukas Straub Reviewed-by: Marc-André Lureau Tested-by: Li Zhang --- MAINTAINERS| 1 + tests/unit/meson.build | 3 +- tests/unit/test-yank.c | 200 + 3 files changed, 203 inse

[PATCH v6 1/4] chardev/char.c: Move object_property_try_add_child out of chardev_new

2021-03-29 Thread Lukas Straub
Move object_property_try_add_child out of chardev_new into it's callers. This is a preparation for the next patches to fix yank with the chardev-change case. Signed-off-by: Lukas Straub Reviewed-by: Marc-André Lureau Tested-by: Li Zhang --- chardev/char.c | 42 -

[PATCH v6 2/4] chardev/char.c: Always pass id to chardev_new

2021-03-29 Thread Lukas Straub
Always pass the id to chardev_new, since it is needed to register the yank instance for the chardev. Also, after checking that nothing calls chardev_new with id=NULL, assert() that id!=NULL. This fixes a crash when using chardev-change to change a chardev to chardev-socket, which attempts to regis

[PATCH v6 3/4] chardev: Fix yank with the chardev-change case

2021-03-29 Thread Lukas Straub
When changing from chardev-socket (which supports yank) to chardev-socket again, it fails, because the new chardev attempts to register a new yank instance. This in turn fails, as there still is the yank instance from the current chardev. Also, the old chardev shouldn't unregister the yank instance

[Bug 1639394] Re: Unable to boot Solaris 8/9 x86 under Fedora 24

2021-03-29 Thread John Snow
I have to admit that my time budget for IDE is quite low, so I will be unable to look into this. If you'd like to help debug it further and you have the time, you can try building QEMU 6.0 (RC0 or so, something quite modern) and enabling the IDE tracing options and trying to boot Solaris as you ha

Re: [PATCH for-6.0] hw/timer/renesas_tmr: Add default-case asserts in read_tcnt()

2021-03-29 Thread Philippe Mathieu-Daudé
Hi Peter, If you are preparing a qemu-arm pull request, can you squeeze this patch in? On 3/26/21 7:49 PM, Philippe Mathieu-Daudé wrote: > On 3/26/21 2:34 PM, Peter Maydell wrote: >> ping for review? > > FYI: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg790977.html > >> On Fri, 19 Ma

Re: [RFC 1/8] memory: Allow eventfd add/del without starting a transaction

2021-03-29 Thread Stefan Hajnoczi
On Thu, Mar 25, 2021 at 04:07:28PM +0100, Greg Kurz wrote: > diff --git a/include/exec/memory.h b/include/exec/memory.h > index 5728a681b27d..98ed552e001c 100644 > --- a/include/exec/memory.h > +++ b/include/exec/memory.h > @@ -1848,13 +1848,25 @@ void memory_region_clear_flush_coalesced(MemoryRegi

[PULL for-6.0 0/2] emulated nvme fixes

2021-03-29 Thread Klaus Jensen
From: Klaus Jensen Hi Peter, The following changes since commit ec2e6e016d24bd429792d08cf607e4c5350dcdaa: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-6.0-pull-request' into staging (2021-03-28 19:49:57 +0100) are available in the Git repository at: git://git.infrad

[PULL for-6.0 1/2] hw/block/nvme: fix resource leak in nvme_dif_rw

2021-03-29 Thread Klaus Jensen
From: Klaus Jensen If nvme_map_dptr() fails, nvme_dif_rw() will leak the bounce context. Fix this by using the same error handling as everywhere else in the function. Reported-by: Coverity (CID 1451080) Fixes: 146f720c5563 ("hw/block/nvme: end-to-end data protection") Signed-off-by: Klaus Jensen

[PATCH 1/8] hw/riscv: sifive_u: Switch to use qemu_fdt_setprop_string_array() helper

2021-03-29 Thread Bin Meng
From: Bin Meng Since commit 78da6a1bca22 ("device_tree: add qemu_fdt_setprop_string_array helper"), we can use the new helper to set the clock name for the ethernet controller node. Signed-off-by: Bin Meng --- hw/riscv/sifive_u.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) d

Re: [RFC 2/8] virtio: Introduce virtio_bus_set_host_notifiers()

2021-03-29 Thread Stefan Hajnoczi
On Thu, Mar 25, 2021 at 04:07:29PM +0100, Greg Kurz wrote: > Multiqueue devices such as virtio-scsi or virtio-blk, all open-code the > same pattern to setup/tear down host notifiers of the request virtqueues. > Consolidate the pattern in a new virtio_bus_set_host_notifiers() API. > Since virtio-scs

[PATCH 4/8] hw/riscv: Support the official PLIC DT bindings

2021-03-29 Thread Bin Meng
From: Bin Meng The official DT bindings of PLIC uses "sifive,plic-1.0.0" as the compatible string in the upstream Linux kernel. "riscv,plic0" is now legacy and has to be kept for backward compatibility of legacy systems. Signed-off-by: Bin Meng --- hw/riscv/sifive_u.c | 4 +++- hw/riscv/virt.

[PATCH 3/8] hw/riscv: Support the official CLINT DT bindings

2021-03-29 Thread Bin Meng
From: Bin Meng Linux kernel commit a2770b57d083 ("dt-bindings: timer: Add CLINT bindings") adds the official DT bindings for CLINT, which uses "sifive,clint0" as the compatible string. "riscv,clint0" is now legacy and has to be kept for backward compatibility of legacy systems. Signed-off-by: Bi

[PATCH 8/8] hw/riscv: microchip_pfsoc: Support direct kernel boot

2021-03-29 Thread Bin Meng
From: Bin Meng At present the Microchip Icicle Kit machine only supports using '-bios' to load the HSS, and does not support '-kernel' for direct kernel booting just like other RISC-V machines do. One has to use U-Boot which is chain-loaded by HSS, to load a kernel for testing. This is not so con

[PATCH 2/8] hw/riscv: virt: Switch to use qemu_fdt_setprop_string_array() helper

2021-03-29 Thread Bin Meng
From: Bin Meng Since commit 78da6a1bca22 ("device_tree: add qemu_fdt_setprop_string_array helper"), we can use the new helper to set the compatible strings for the SiFive test device node. Signed-off-by: Bin Meng --- hw/riscv/virt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

[PATCH 5/8] docs/system/riscv: Correct the indentation level of supported devices

2021-03-29 Thread Bin Meng
From: Bin Meng The supported device bullet list has an additional space before each entry, which makes a wrong indentation level. Correct it. Signed-off-by: Bin Meng --- docs/system/riscv/microchip-icicle-kit.rst | 20 +++ docs/system/riscv/sifive_u.rst | 30 ++

[PULL for-6.0 2/2] hw/block/nvme: fix ref counting in nvme_format_ns

2021-03-29 Thread Klaus Jensen
From: Klaus Jensen Max noticed that since blk_aio_pwrite_zeroes() may invoke the callback before returning, the callbacks will never see *count == 0 and thus never free the count variable or decrement num_formats causing a CQE to never be posted. Coverity (CID 1451082) also picked up on the fact

[PATCH 7/8] hw/riscv: Use macros for BIOS image names

2021-03-29 Thread Bin Meng
From: Bin Meng The OpenSBI BIOS image names are used by many RISC-V machines. Let's define macros for them. Signed-off-by: Bin Meng --- include/hw/riscv/boot.h | 5 + hw/riscv/sifive_u.c | 6 ++ hw/riscv/spike.c| 6 ++ hw/riscv/virt.c | 6 ++ 4 files change

Re: [PATCH v6 0/4] yank: Add chardev tests and fixes

2021-03-29 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1617035720.git.lukasstra...@web.de/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1617035720.git.lukasstra...@web.de Subject: [PATCH v6 0/4] yank: Add chardev tests and

Re: [RFC 5/8] virtio-blk: Fix rollback path in virtio_blk_data_plane_start()

2021-03-29 Thread Stefan Hajnoczi
On Thu, Mar 25, 2021 at 04:07:32PM +0100, Greg Kurz wrote: > When dataplane multiqueue support was added in QEMU 2.7, the path > that would rollback guest notifiers assignment in case of error > simply got dropped. > > Later on, when Error was added to blk_set_aio_context() in QEMU 4.1, > another

Re: [RFC 4/8] virtio-pci: Batch add/del ioeventfds in a single MR transaction

2021-03-29 Thread Stefan Hajnoczi
On Thu, Mar 25, 2021 at 04:07:31PM +0100, Greg Kurz wrote: > diff --git a/softmmu/memory.c b/softmmu/memory.c > index 1b1942d521cc..0279e5671bcb 100644 > --- a/softmmu/memory.c > +++ b/softmmu/memory.c > @@ -2368,7 +2368,7 @@ void memory_region_add_eventfd_full(MemoryRegion *mr, > if (size) {

Re: [RFC 6/8] virtio-blk: Use virtio_bus_set_host_notifiers()

2021-03-29 Thread Stefan Hajnoczi
On Thu, Mar 25, 2021 at 04:07:33PM +0100, Greg Kurz wrote: > This allows the virtio-blk-pci device to batch additions and deletions > of host notifiers. This significantly improves boot time of VMs with a > high number of vCPUs, e.g. from 3m26.408s down to 0m59.923s for a pseries > machine with 384

[PATCH 6/8] docs/system/riscv: sifive_u: Document '-dtb' usage

2021-03-29 Thread Bin Meng
From: Bin Meng Update the 'sifive_u' machine documentation to mention the '-dtb' option that can be used to pass a custom DTB to QEMU. Signed-off-by: Bin Meng --- docs/system/riscv/sifive_u.rst | 47 +- 1 file changed, 41 insertions(+), 6 deletions(-) diff --g

Re: [RFC 8/8] virtio-scsi: Use virtio_bus_set_host_notifiers()

2021-03-29 Thread Stefan Hajnoczi
On Thu, Mar 25, 2021 at 04:07:35PM +0100, Greg Kurz wrote: > This allows the virtio-scsi-pci device to batch additions and deletions > of host notifiers. This significantly improves boot time of VMs with a > high number of vCPUs, e.g. from 6m13.969s down to 1m4.268s for a pseries > machine with 384

Re: [RFC 3/8] virtio: Add API to batch set host notifiers

2021-03-29 Thread Stefan Hajnoczi
On Thu, Mar 25, 2021 at 04:07:30PM +0100, Greg Kurz wrote: > Introduce VirtioBusClass methods to begin and commit a transaction > of setting/unsetting host notifiers. These handlers will be implemented > by virtio-pci to batch addition and deletion of ioeventfds for multiqueue > devices like virtio

Re: [RFC 0/8] virtio: Improve boot time of virtio-scsi-pci and virtio-blk-pci

2021-03-29 Thread Stefan Hajnoczi
On Thu, Mar 25, 2021 at 04:07:27PM +0100, Greg Kurz wrote: > Now that virtio-scsi-pci and virtio-blk-pci map 1 virtqueue per vCPU, > a serious slow down may be observed on setups with a big enough number > of vCPUs. > > Exemple with a pseries guest on a bi-POWER9 socket system (128 HW threads): >

Re: [PULL 00/10] For 6.0 patches

2021-03-29 Thread Peter Maydell
On Mon, 29 Mar 2021 at 17:30, Marc-André Lureau wrote: > > Hi > > On Mon, Mar 29, 2021 at 7:56 PM Peter Maydell > wrote: >> >> On Mon, 29 Mar 2021 at 15:17, Marc-André Lureau >> wrote: >> > ../docs/meson.build:30: WARNING: /usr/bin/sphinx-build-3: >> > Configuration error: >> > The Sphinx 'sphi

Re: [PATCH for-6.0] hw/timer/renesas_tmr: Add default-case asserts in read_tcnt()

2021-03-29 Thread Peter Maydell
On Mon, 29 Mar 2021 at 18:03, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > If you are preparing a qemu-arm pull request, can you > squeeze this patch in? Yep, that was my plan. thanks -- PMM

[PATCH] docs: Add a QEMU Code of Conduct and Conflict Resolution Policy document

2021-03-29 Thread Thomas Huth
In an ideal world, we would all get along together very well, always be polite and never end up in huge conflicts. And even if there are conflicts, we would always handle each other fair and respectfully. Unfortunately, this is not an ideal world and sometimes people forget how to interact with eac

Re: [PATCH v6 0/4] yank: Add chardev tests and fixes

2021-03-29 Thread Marc-André Lureau
Hi Lukas On Mon, Mar 29, 2021 at 8:38 PM Lukas Straub wrote: > Hello Everyone, > These patches increase test coverage for yank, add tests and fix bugs and > crashes in yank in combination with chardev-change. > Please Review. > > Regards, > Lukas Straub > > Changes: > -v6: > -test: (hopefully)

Re: [PATCH 1/2] spapr: number of SMP sockets must be equal to NUMA nodes

2021-03-29 Thread Daniel Henrique Barboza
On 3/29/21 12:32 PM, Cédric Le Goater wrote: On 3/29/21 6:20 AM, David Gibson wrote: On Thu, Mar 25, 2021 at 09:56:04AM +0100, Cédric Le Goater wrote: On 3/25/21 3:10 AM, David Gibson wrote: On Tue, Mar 23, 2021 at 02:21:33PM -0300, Daniel Henrique Barboza wrote: On 3/22/21 10:03 PM, Dav

Re: [PATCH] docs: Add a QEMU Code of Conduct and Conflict Resolution Policy document

2021-03-29 Thread Daniel P . Berrangé
On Mon, Mar 29, 2021 at 08:01:40PM +0200, Thomas Huth wrote: > In an ideal world, we would all get along together very well, always be > polite and never end up in huge conflicts. And even if there are conflicts, > we would always handle each other fair and respectfully. Unfortunately, > this is no

Re: [PATCH v6 0/4] yank: Add chardev tests and fixes

2021-03-29 Thread Lukas Straub
On Mon, 29 Mar 2021 22:19:17 +0400 Marc-André Lureau wrote: > Hi Lukas > > On Mon, Mar 29, 2021 at 8:38 PM Lukas Straub wrote: > > > Hello Everyone, > > These patches increase test coverage for yank, add tests and fix bugs and > > crashes in yank in combination with chardev-change. > > Please

[PATCH v7 3/4] chardev: Fix yank with the chardev-change case

2021-03-29 Thread Lukas Straub
When changing from chardev-socket (which supports yank) to chardev-socket again, it fails, because the new chardev attempts to register a new yank instance. This in turn fails, as there still is the yank instance from the current chardev. Also, the old chardev shouldn't unregister the yank instance

[PATCH v7 1/4] chardev/char.c: Move object_property_try_add_child out of chardev_new

2021-03-29 Thread Lukas Straub
Move object_property_try_add_child out of chardev_new into it's callers. This is a preparation for the next patches to fix yank with the chardev-change case. Signed-off-by: Lukas Straub Reviewed-by: Marc-André Lureau Tested-by: Li Zhang --- chardev/char.c | 42 -

[PATCH v7 0/4] yank: Add chardev tests and fixes

2021-03-29 Thread Lukas Straub
Hello Everyone, These patches increase test coverage for yank, add tests and fix bugs and crashes in yank in combination with chardev-change. Please Review. Regards, Lukas Straub Changes: -v7: -test: fix patchew error by not using macros -v6: -test: (hopefully) fix test on OSX by using qio_net

[PATCH v7 2/4] chardev/char.c: Always pass id to chardev_new

2021-03-29 Thread Lukas Straub
Always pass the id to chardev_new, since it is needed to register the yank instance for the chardev. Also, after checking that nothing calls chardev_new with id=NULL, assert() that id!=NULL. This fixes a crash when using chardev-change to change a chardev to chardev-socket, which attempts to regis

[PATCH v7 4/4] tests: Add tests for yank with the chardev-change case

2021-03-29 Thread Lukas Straub
Add tests for yank with the chardev-change case. Signed-off-by: Lukas Straub Reviewed-by: Marc-André Lureau Tested-by: Li Zhang --- MAINTAINERS| 1 + tests/unit/meson.build | 3 +- tests/unit/test-yank.c | 227 + 3 files changed, 230 inse

[PATCH] ppc/spapr: Add support for implement support for H_SCM_HEALTH

2021-03-29 Thread Vaibhav Jain
Add support for H_SCM_HEALTH hcall described at [1] for spapr nvdimms. This enables guest to detect the 'unarmed' status of a specific spapr nvdimm identified by its DRC and if its unarmed, mark the region backed by the nvdimm as read-only. The patch adds h_scm_health() to handle the H_SCM_HEALTH

Re: An error due to installation that require binutils package

2021-03-29 Thread John Simpson
Hello, Kindly ask you to have a look at this bug. Thank you for your replies. On Mon, Mar 29, 2021 at 7:07 PM George Dunlap wrote: > John, > > Thanks for your report. Can you post your bug report > xen-de...@lists.xenproject.org ? > > The bug is in the compilation of QEMU, which is an external

Re: An error due to installation that require binutils package

2021-03-29 Thread Peter Maydell
On Mon, 29 Mar 2021 at 20:20, John Simpson wrote: > > Hello, > > Kindly ask you to have a look at this bug. > Thank you for your replies. >> > On Sun, Mar 28, 2021 at 12:55:23PM +0300, John Simpson via Binutils wrote: >> > > BUILD pc-bios/optionrom/kvmvapic.img >> > > ld: Error: unable to dis

Re: [PATCH] linux-user: NETLINK_LIST_MEMBERSHIPS: Allow bad ptr if its length is 0

2021-03-29 Thread Laurent Vivier
Le 28/03/2021 à 20:01, Frédéric Fortier via a écrit : > getsockopt(fd, SOL_NETLINK, NETLINK_LIST_MEMBERSHIPS, *optval, *optlen) > syscall allows optval to be NULL/invalid if optlen points to a size of > zero. This allows userspace to query the length of the array they should > use to get the full m

Re: [PATCH v5 5/5] virtiofsd: Switch creds, drop FSETID for system.posix_acl_access xattr

2021-03-29 Thread Vivek Goyal
On Mon, Mar 29, 2021 at 04:35:57PM +0100, Luis Henriques wrote: > On Thu, Mar 25, 2021 at 11:38:52AM -0400, Vivek Goyal wrote: > > When posix access acls are set on a file, it can lead to adjusting file > > permissions (mode) as well. If caller does not have CAP_FSETID and it > > also does not have

Re: [PATCH v3 6/6] block/qcow2: use seqcache for compressed writes

2021-03-29 Thread Vladimir Sementsov-Ogievskiy
12.03.2021 21:15, Max Reitz wrote: On 05.03.21 18:35, Vladimir Sementsov-Ogievskiy wrote: Compressed writes are unaligned to 512, which works very slow in O_DIRECT mode. Let's use the cache. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   block/coroutines.h |   3 +   block/qcow2.h   

Re: Ways to deal with broken machine types

2021-03-29 Thread Igor Mammedov
On Mon, 29 Mar 2021 15:46:53 +0100 "Dr. David Alan Gilbert" wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Tue, 23 Mar 2021 17:40:36 + > > Daniel P. Berrangé wrote: > > > > > On Tue, Mar 23, 2021 at 05:54:47PM +0100, Igor Mammedov wrote: > > > > Let me hijack this thread f

Re: [PATCH] tap-bsd: Remove special casing for older OpenBSD releases

2021-03-29 Thread Brad Smith
On 3/28/2021 11:58 PM, Jason Wang wrote: 在 2021/3/29 上午11:03, Brad Smith 写道: It very much is correct. We don't care about such releases anymore. So is there a doc/wiki to say Qemu doesn't support those OpenBSD release? The (OpenBSD itself and QEMU) project only makes a concerted effort to

Re: [PATCH] docs: Add a QEMU Code of Conduct and Conflict Resolution Policy document

2021-03-29 Thread Paolo Bonzini
Il lun 29 mar 2021, 20:33 Daniel P. Berrangé ha scritto: > The obvious alternative is to import the contributor covenant > > https://www.contributor-covenant.org/ The Contributor Covenant 1.x and 2.x are very different in that 2.x also includes conflict resolution. Unlike the code of conduct,

Re: AUTIA authentication sometimes fails

2021-03-29 Thread Peter Maydell
On Mon, 29 Mar 2021 at 21:07, Derrick McKee wrote: > > Hi, > > I am running across a scenario where a PAC signed code pointer (using > pacia) sometimes does not successfully authenticate despite the signed > pointer and the salt used to sign the pointer are correctly given to a > autia instruction

Re: [PATCH] hw/misc: Add an iBT device model

2021-03-29 Thread Joel Stanley
On Mon, 29 Mar 2021 at 12:19, Cédric Le Goater wrote: > > Implement an IPMI BT interface model using a chardev backend to > communicate with an external PowerNV machine. It uses the OpenIPMI > simulator protocol for virtual machines described in : > > https://github.com/cminyard/openipmi/blob/

RE: [PATCH 10/15] Hexagon (target/hexagon) instructions with multiple definitions

2021-03-29 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Thursday, March 25, 2021 11:25 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; a...@rev.ng; Brian Cain > Subject: Re: [PATCH 10/15] Hexagon (target/hexagon) instructions with > multiple definitions > > On 3/

Re: [PATCH 0/4] DEVICE_NOT_DELETED/DEVICE_UNPLUG_ERROR QAPI events

2021-03-29 Thread Igor Mammedov
On Wed, 24 Mar 2021 16:09:59 -0300 Daniel Henrique Barboza wrote: > On 3/23/21 10:40 PM, David Gibson wrote: > > On Tue, Mar 23, 2021 at 02:10:22PM -0300, Daniel Henrique Barboza wrote: > >> > >> > >> On 3/22/21 10:12 PM, David Gibson wrote: > >>> On Fri, Mar 12, 2021 at 05:07:36PM -0300, Dan

Re: [PATCH 1/2] spapr: number of SMP sockets must be equal to NUMA nodes

2021-03-29 Thread Igor Mammedov
On Tue, 23 Mar 2021 12:03:58 +1100 David Gibson wrote: > On Fri, Mar 19, 2021 at 03:34:52PM -0300, Daniel Henrique Barboza wrote: > > Kernel commit 4bce545903fa ("powerpc/topology: Update > > topology_core_cpumask") cause a regression in the pseries machine when > > defining certain SMP topologie

Re: [PATCH 1/2] spapr: number of SMP sockets must be equal to NUMA nodes

2021-03-29 Thread Igor Mammedov
On Mon, 29 Mar 2021 15:32:37 -0300 Daniel Henrique Barboza wrote: > On 3/29/21 12:32 PM, Cédric Le Goater wrote: > > On 3/29/21 6:20 AM, David Gibson wrote: > >> On Thu, Mar 25, 2021 at 09:56:04AM +0100, Cédric Le Goater wrote: > >>> On 3/25/21 3:10 AM, David Gibson wrote: > On Tue, Ma

Re: [PATCH v2] qapi: introduce 'query-cpu-model-cpuid' action

2021-03-29 Thread Igor Mammedov
On Thu, 25 Mar 2021 19:57:05 +0300 Valeriy Vdovin wrote: > Introducing new qapi method 'query-cpu-model-cpuid'. This method can be used > to > get virtualized cpu model info generated by QEMU during VM initialization in > the form of cpuid representation. > > Diving into more details about virt

Re: [PATCH for-6.0 1/7] hw/block/nvme: fix pi constraint check

2021-03-29 Thread Gollu Appalanaidu
On Wed, Mar 24, 2021 at 09:09:01PM +0100, Klaus Jensen wrote: From: Klaus Jensen Protection Information can only be enabled if there is at least 8 bytes of metadata. Signed-off-by: Klaus Jensen --- hw/block/nvme-ns.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/

Re: [PATCH for-6.0 2/7] hw/block/nvme: fix missing string representation for ns attachment

2021-03-29 Thread Gollu Appalanaidu
On Wed, Mar 24, 2021 at 09:09:02PM +0100, Klaus Jensen wrote: From: Klaus Jensen Add the missing nvme_adm_opc_str entry for the Namespace Attachment command. Signed-off-by: Klaus Jensen --- hw/block/nvme.h | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/block/nvme.h b/hw/block/nvme.h in

RE: [PATCH V4 3/7] qapi/net: Add new QMP command for COLO passthrough

2021-03-29 Thread Zhang, Chen
> -Original Message- > From: Qemu-devel bounces+chen.zhang=intel@nongnu.org> On Behalf Of Markus > Armbruster > Sent: Tuesday, March 23, 2021 5:58 PM > To: Zhang, Chen > Cc: Lukas Straub ; Li Zhijian > ; Jason Wang ; qemu- > dev ; Dr. David Alan Gilbert > ; Zhang Chen > Subject: R

Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR

2021-03-29 Thread David Gibson
On Mon, Mar 29, 2021 at 10:26:02AM -0600, Richard Henderson wrote: > On 3/29/21 7:05 AM, Greg Kurz wrote: > > On Wed, 24 Mar 2021 11:03:02 +1100 > > David Gibson wrote: > > > > > On Tue, Mar 23, 2021 at 12:43:32PM -0600, Richard Henderson wrote: > > > > Copying flags directly from msr has drawbac

Re: [PATCH] ppc/spapr: Add support for implement support for H_SCM_HEALTH

2021-03-29 Thread Shivaprasad G Bhat
Hi Vaibhav, Some comments inline.. On 3/29/21 9:52 PM, Vaibhav Jain wrote: Add support for H_SCM_HEALTH hcall described at [1] for spapr nvdimms. This enables guest to detect the 'unarmed' status of a specific spapr nvdimm identified by its DRC and if its unarmed, mark the region backed by the

[Bug 1090604] Re: RFE: Implement support for SMBIOS Type 41 structures

2021-03-29 Thread Vincent Bernat
I have sent a first patch around this: https://lists.nongnu.org/archive/html/qemu-devel/2021-03/msg09391.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1090604 Title: RFE: Implement support for

[PING] [PATCH] [NFC] Mark locally used symbols as static.

2021-03-29 Thread Yuri Gribov
Hi all, This patch makes locally used symbols static to enable more compiler optimizations on them. Some of the symbols turned out to not be used at all so I marked them with ATTRIBUTE_UNUSED (as I wasn't sure if they were ok to delete). The symbols have been identified with a pet project of mine

<    1   2