On 3/23/21 9:45 AM, Claudio Fontana wrote:
move work is needed later on to split things into
tcg-specific portions and kvm-specific portions of this
Signed-off-by: Claudio Fontana
Reviewed-by: Alex Bennée
---
target/arm/internals.h | 8 ++-
target/arm/cpu-sysemu.c | 105 +++
On 3/23/21 9:45 AM, Claudio Fontana wrote:
in the process remove a few CONFIG_TCG that are superfluous now.
Signed-off-by: Claudio Fontana
---
target/arm/tcg/m_helper.h | 21 +
target/arm/tcg/m_helper.c | 2766 +
target/arm/tcg/sysemu/m_helper.c
Couple commit message NITs but otherwise I'm happy with this.
Reviewed-by: Raphael Norwitz
On Wed, Mar 24, 2021 at 12:38:28PM +0300, Denis Plotnikov wrote:
> It is useful to use different connect/disconnect event handlers
> on device initialization and operation as seen from the further
> commit
On 3/23/21 9:45 AM, Claudio Fontana wrote:
get_phys_addr is needed for KVM too, and in turn it requires
the aa64_va_parameter* family of functions.
Create cpu-mmu and cpu-mmu-sysemu to store these and
other mmu-related functions.
Signed-off-by: Claudio Fontana
---
Reviewed-by: Richard Henders
* Jonah Palmer (jonah.pal...@oracle.com) wrote:
> From: Laurent Vivier
>
> --- /dev/null
> +++ b/qapi/virtio.json
> @@ -0,0 +1,68 @@
> +##
> +# = Virtio devices
> +##
> +
> +##
> +# @VirtioType:
> +#
> +# An enumeration of Virtio device types.
> +#
> +# Since: 6.0
> +##
> +{ 'enum': 'VirtioTyp
Since commit 078778c5a55 ("piix4: Add an i8259 Interrupt Controller")
the TYPE_PIIX4_PCI_DEVICE exposes the ISA input IRQs as "isa" alias.
Use this alias to get IRQ for the power management PCI function.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/isa/piix4.c | 5 +++--
1 file changed, 3 inser
On 3/23/21 9:45 AM, Claudio Fontana wrote:
Signed-off-by: Claudio Fontana
---
target/arm/cpu-mmu.h| 3 +-
target/arm/cpu-mmu-sysemu.c | 149
2 files changed, 101 insertions(+), 51 deletions(-)
Surely this should go before the code movement. I
On 3/24/21 7:01 PM, Philippe Mathieu-Daudé wrote:
> Hi,
>
> Peter's current workflow is push to /staging and if his
> testing succeeds, he pushes the same commit as /master.
>
> IMO there is no point in building /master branch, as it
> has already been built earlier as /staging.
Also this might
This is v6 of the qemu dirty ring interface support.
v6:
- Fix slots_lock init [Keqian, Paolo]
- Comment above KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2 on todo (to enable
KVM_CLEAR_DIRTY_LOG for dirty ring too) [Keqian, Paolo]
- Fix comment for CPUState [Keqian]
v5:
- rebase
- dropped patch "update-li
Provide a helper kvm_slot_get_dirty_log() to make the function
kvm_physical_sync_dirty_bitmap() clearer. We can even cache the as_id
into KVMSlot when it is created, so that we don't even need to pass it
down every time.
Since at it, remove return value of kvm_physical_sync_dirty_bitmap()
because
Some of the memory listener may want to do log synchronization without
being able to specify a range of memory to sync but always globally.
Such a memory listener should provide this new method instead of the
log_sync() method.
Obviously we can also achieve similar thing when we put the global
syn
Previously we have two places that will create the per KVMSlot dirty
bitmap:
1. When a newly created KVMSlot has dirty logging enabled,
2. When the first log_sync() happens for a memory slot.
The 2nd case is lazy-init, while the 1st case is not (which is a fix
of what the 2nd case missed).
T
KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2 is for KVM_CLEAR_DIRTY_LOG, which is only
useful for KVM_GET_DIRTY_LOG. Skip enabling it for kvm dirty ring.
More importantly, KVM_DIRTY_LOG_INITIALLY_SET will not wr-protect all the pages
initially, which is against how kvm dirty ring is used - there's no way fo
KVM dirty ring is a new interface to pass over dirty bits from kernel to the
userspace. Instead of using a bitmap for each memory region, the dirty ring
contains an array of dirtied GPAs to fetch (in the form of offset in slots).
For each vcpu there will be one dirty ring that binds to it.
kvm_di
Per-kml slots_lock will bring some trouble if we want to take all slots_lock of
all the KMLs, especially when we're in a context that we could have taken some
of the KML slots_lock, then we even need to figure out what we've taken and
what we need to take.
Make this simple by merging all KML slots
Cache it too because we'll reference it more frequently in the future.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
---
accel/kvm/kvm-all.c | 1 +
include/sysemu/kvm_int.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index e
On 3/23/21 9:45 AM, Claudio Fontana wrote:
give them their own common module cpregs.c, and an interface cpregs.h.
Extract the raw cpustate list to its own module.
This is more or less needed for KVM too.
For the tcg-specific registers, stuff them into tcg/cpregs.c
As a result, the monster that
On 3/23/21 9:46 AM, Claudio Fontana wrote:
at least the armv7m one should go away with proper
configuration changes (only enabling possible boards for KVM).
Signed-off-by: Claudio Fontana
---
target/arm/kvm/helper-stubs.c | 27 +++
target/arm/kvm/meson.build| 3 ++
kvm_physical_sync_dirty_bitmap() on the whole section is inaccurate, because
the section can be a superset of the memslot that we're working on. The result
is that if the section covers multiple kvm memslots, we could be doing the
synchronization for multiple times for each kvmslot in the section.
Add a parameter for dirty gfn count for dirty rings. If zero, dirty ring is
disabled. Otherwise dirty ring will be enabled with the per-vcpu gfn count as
specified. If dirty ring cannot be enabled due to unsupported kernel or
illegal parameter, it'll fallback to dirty logging.
By default, dirty
On 3/23/21 9:46 AM, Claudio Fontana wrote:
of note, cpreg lists were previously initialized by TCG first,
and then thrown away and replaced with the data coming from KVM.
Now we just initialize once, either for TCG or for KVM.
Signed-off-by: Claudio Fontana
---
target/arm/cpu.c | 32 +
kvm_physical_sync_dirty_bitmap() calculates the ramblock offset in an
awkward way from the MemoryRegionSection that passed in from the
caller. The truth is for each KVMSlot the ramblock offset never
change for the lifecycle. Cache the ramblock offset for each KVMSlot
into the structure when the K
On 3/23/21 9:45 AM, Claudio Fontana wrote:
Signed-off-by: Claudio Fontana
---
target/arm/cpu-common.c | 41 +
target/arm/tcg/helper.c | 29 -
target/arm/meson.build | 1 +
3 files changed, 42 insertions(+), 29 deletions(-)
On 3/24/21 6:53 PM, Laurent Vivier wrote:
> Le 24/03/2021 à 16:55, Andreas Krebbel a écrit :
>> When setting up the pointer for the sigreturn stub in the return
>> address register (r14) we have to use the guest frame pointer instead
>> of the host frame pointer.
>>
>> Note: This only caused proble
On 3/23/21 9:45 AM, Claudio Fontana wrote:
Signed-off-by: Claudio Fontana
---
target/arm/cpregs.h | 54 ++---
target/arm/cpregs.c | 60 ++
target/arm/tcg/cpregs.c | 253 ++--
3 files changed, 241 insertions(+), 126 deletions(-)
Agai
When setting up the pointer for the sigreturn stub in the return
address register (r14) we currently use the host frame address instead
of the guest frame address.
Note: This only caused problems if Qemu has been built with
--disable-pie (as it is in distros nowadays). Otherwise guest_base
default
On 3/23/21 9:46 AM, Claudio Fontana wrote:
+/* return the effective value of HCR_EL2. For KVM, always 0. */
+uint64_t arm_hcr_el2_eff(CPUARMState *env)
+{
+return 0;
+}
Oh, amusingly, patches for kvm nested virtualization,
https://patchew.org/QEMU/cover.1616052889.git.haibo...@linaro.org/
Looks good, just clean up the commit message to reflect the way you've
now split the patches.
Reviewed-by: Raphael Norwitz
On Wed, Mar 24, 2021 at 12:38:29PM +0300, Denis Plotnikov wrote:
> Commit 4bcad76f4c39 ("vhost-user-blk: delay vhost_user_blk_disconnect")
> introduced postponing vhost_dev
On 3/23/21 9:46 AM, Claudio Fontana wrote:
this should go away once the configuration and hw/arm is clean
Signed-off-by: Claudio Fontana
---
hw/arm/boot.c | 5 -
target/arm/arm-powerctl.c | 8 +---
target/arm/kvm/helper-stubs.c | 6 ++
3 files changed, 15 ins
On 3/23/21 9:46 AM, Claudio Fontana wrote:
we need as a result to move switch_mode too,
so we put an implementation into cpu_user and cpu_sysemu.
Signed-off-by: Claudio Fontana
---
target/arm/cpu.h| 2 +
target/arm/cpu-common.c | 192 +++
target/arm/
On Wed, Mar 24, 2021 at 05:35:44PM +, Dr. David Alan Gilbert wrote:
> * Peter Xu (pet...@redhat.com) wrote:
> > On Tue, Mar 23, 2021 at 08:21:43PM +0300, Andrey Gruzdev wrote:
> > > > For the long term I think we'd better have a helper:
> > > >
> > > > qemu_put_qio_channel_buffer(QEMU
On Mon, Mar 22, 2021 at 6:40 PM Stefan Hajnoczi wrote:
>
> On Mon, Mar 22, 2021 at 04:55:13PM +0100, Eugenio Perez Martin wrote:
> > On Mon, Mar 22, 2021 at 11:51 AM Stefan Hajnoczi
> > wrote:
> > >
> > > On Thu, Mar 11, 2021 at 07:53:53PM +0100, Eugenio Perez Martin wrote:
> > > > On Fri, Jan 2
On 3/23/21 10:40 PM, David Gibson wrote:
On Tue, Mar 23, 2021 at 02:10:22PM -0300, Daniel Henrique Barboza wrote:
On 3/22/21 10:12 PM, David Gibson wrote:
On Fri, Mar 12, 2021 at 05:07:36PM -0300, Daniel Henrique Barboza wrote:
Hi,
This series adds 2 new QAPI events, DEVICE_NOT_DELETED a
When adding the Reset register in commit 5790b757cfb we
forgot to migrate it.
While it is possible a VM using the PIIX4 is migrated just
after requesting a system shutdown, it is very unlikely.
However when restoring a migrated VM, we might have the
RCR bit #4 set on the stack and when the VM resu
* Philippe Mathieu-Daudé (f4...@amsat.org) wrote:
> When adding the Reset register in commit 5790b757cfb we
> forgot to migrate it.
>
> While it is possible a VM using the PIIX4 is migrated just
> after requesting a system shutdown, it is very unlikely.
> However when restoring a migrated VM, we m
On Tue, Mar 23, 2021 at 7:15 PM Cleber Rosa wrote:
>
> If the vmlinuz variable is set to anything that evaluates to True,
> then the respective arguments should be set. If the variable contains
> an empty string, than it will evaluate to False, and the extra
> arguments will not be set.
>
> This
On Wed, Mar 24, 2021 at 08:04:07PM +0100, Eugenio Perez Martin wrote:
> On Mon, Mar 22, 2021 at 6:40 PM Stefan Hajnoczi wrote:
> >
> > On Mon, Mar 22, 2021 at 04:55:13PM +0100, Eugenio Perez Martin wrote:
> > > On Mon, Mar 22, 2021 at 11:51 AM Stefan Hajnoczi
> > > wrote:
> > > >
> > > > On Thu,
On 3/24/21 8:40 PM, Dr. David Alan Gilbert wrote:
> * Philippe Mathieu-Daudé (f4...@amsat.org) wrote:
>> When adding the Reset register in commit 5790b757cfb we
>> forgot to migrate it.
>>
>> While it is possible a VM using the PIIX4 is migrated just
>> after requesting a system shutdown, it is ver
When adding the Reset register in commit 5790b757cfb we
forgot to migrate it.
While it is possible a VM using the PIIX4 is migrated just
after requesting a system shutdown, it is very unlikely.
However when restoring a migrated VM, we might have the
RCR bit #4 set on the stack and when the VM resu
On Mar 22 13:09, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Fix two issues reported by coverity (CID 1451080 and 1451082).
>
> v2:
> - replace [2/2] with a fix for the bad reference counting noticed by
> Max
>
> Klaus Jensen (2):
> hw/block/nvme: fix resource leak in nvme_dif_rw
> h
From: Klaus Jensen
Various fixes for 6.0.
Klaus Jensen (7):
hw/block/nvme: fix pi constraint check
hw/block/nvme: fix missing string representation for ns attachment
hw/block/nvme: fix the nsid 'invalid' value
hw/block/nvme: fix controller namespaces array indexing
hw/block/nvme: fix w
From: Klaus Jensen
Protection Information can only be enabled if there is at least 8 bytes
of metadata.
Signed-off-by: Klaus Jensen
---
hw/block/nvme-ns.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/nvme-ns.c b/hw/block/nvme-ns.c
index 7f8d139a8663..ca04ee1bacf
From: Klaus Jensen
The `nvme_nsid()` function returns '-1' (h) when the given
namespace is NULL. Since h is actually a valid namespace
identifier (the "broadcast" value), change this to be '0' since that
actually *is* the invalid value.
Signed-off-by: Klaus Jensen
---
hw/block/
On 3/24/21 2:22 AM, Markus Armbruster wrote:
John Snow writes:
On 3/23/21 5:40 AM, Markus Armbruster wrote:
Event names should be ALL_CAPS with words separated by underscore.
Enforce this. The only offenders are in tests/. Fix them. Existing
test event-case covers the new error.
Signed-off
From: Klaus Jensen
Prior to this patch, if a private nvme-ns device (that is, a namespace
that is not linked to a subsystem) is wired up to an nvme-subsys linked
nvme controller device, the device fails to verify that the namespace id
is unique within the subsystem. NVM Express v1.4b, Section 6.1
From: Klaus Jensen
Add the missing nvme_adm_opc_str entry for the Namespace Attachment
command.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/block/nvme.h b/hw/block/nvme.h
index 5b0031b11db2..9edc86d79e98 100644
--- a/hw/block/nvme.h
++
From: Klaus Jensen
Remove the unused BlockConf from the controller structure and fix the
constraint checking to actually check the right BlockConf and issue the
warning.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.h | 1 -
hw/block/nvme.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(
From: Klaus Jensen
The controller namespaces array being 0-indexed requires 'nsid - 1'
everywhere. Something that is easy to miss. Align the controller
namespaces array with the subsystem namespaces array such that both are
1-indexed.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.h | 8 ---
From: Klaus Jensen
The Non-MDTS DMSRL limit must be recomputed when namespaces are
detached.
Fixes: 645ce1a70cb6 ("hw/block/nvme: support namespace attachment command")
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/hw/blo
24.03.2021 21:05, Peter Maydell wrote:
On Wed, 24 Mar 2021 at 14:52, Stefan Hajnoczi wrote:
The following changes since commit 67c1115edd98f388ca89dd38322ea3fadf034523:
Merge remote-tracking branch 'remotes/kraxel/tags/ui-20210323-pull-request'
into staging (2021-03-23 23:47:30 +)
ar
On 3/23/21 9:46 AM, Claudio Fontana wrote:
cpu-vfp.c: vfp_get_fpsr and vfp_set_fpsr are needed also for KVM,
so create a new cpu-vfp.c
tcg/cpu-vfp.c: vfp_get_fpscr_from_host and vv are TCG-only, so we
move the implementation to tcg/cpu-vfp.c
kvm/helper-stubs.c: vfp_g
On 3/23/21 9:46 AM, Claudio Fontana wrote:
Signed-off-by: Claudio Fontana
---
target/arm/cpu-mmu.c| 95 +
target/arm/tcg/helper.c | 95 -
2 files changed, 95 insertions(+), 95 deletions(-)
Reviewed-by: Richa
On 3/24/21 1:57 AM, Markus Armbruster wrote:
John Snow writes:
On 3/23/21 5:40 AM, Markus Armbruster wrote:
Naming rules differ for the various kinds of names. To prepare
enforcing them, define functions to check them: check_name_upper(),
check_name_lower(), and check_name_camel(). For now,
On Tue, Mar 23, 2021 at 7:16 PM Cleber Rosa wrote:
>
> Slightly different versions for the same utility code are currently
> present on different locations. This unifies them all, giving
> preference to the version from virtiofs_submounts.py, because of the
> last tweaks added to it.
>
> While at
On Tue, Mar 23, 2021 at 7:16 PM Cleber Rosa wrote:
>
> For users of the LinuxTest class, let's set up the VM with the port
> redirection for SSH, instead of requiring each test to set the same
> arguments.
>
> Signed-off-by: Cleber Rosa
> ---
> tests/acceptance/avocado_qemu/__init__.py | 4 +++-
On Wed, 24 Mar 2021 at 20:18, Vladimir Sementsov-Ogievskiy
wrote:
>
> 24.03.2021 21:05, Peter Maydell wrote:
> > On Wed, 24 Mar 2021 at 14:52, Stefan Hajnoczi wrote:
> >>
> >> Vladimir Sementsov-Ogievskiy (2):
> >>migration/block-dirty-bitmap: make incoming disabled bitmaps busy
> >>migra
On Tue, Mar 23, 2021 at 7:16 PM Cleber Rosa wrote:
>
> This makes the username/password used for authentication configurable,
> because some guest operating systems may have restrictions on accounts
> to be used for logins, and it just makes it better documented.
>
> Signed-off-by: Cleber Rosa
>
On Tue, Mar 23, 2021 at 7:16 PM Cleber Rosa wrote:
>
> The LinuxTest specifically targets users that need to interact with Linux
> guests. So, it makes sense to give a connection by default, and avoid
> requiring it as boiler-plate code.
>
> Signed-off-by: Cleber Rosa
> ---
> tests/acceptance/a
On 3/23/21 12:47 PM, Thomas Huth wrote:
Recent QEMU versions now sometimes exit cleanly with an error message
that a bus is not available for a specified device. Don't flag those
as an error in the device-crash-test script.
Signed-off-by: Thomas Huth
---
scripts/device-crash-test | 1 +
1 fi
On Tue, Mar 23, 2021 at 7:16 PM Cleber Rosa wrote:
>
> The LinuxTest class' launch_and_wait() method now behaves the same way
> as this test's custom launch_vm(), so let's just use the upper layer
> (common) method.
>
> Signed-off-by: Cleber Rosa
> ---
> tests/acceptance/virtiofs_submounts.py |
Hi all!
Here is part II of 64bit block-layer, when part I already landed
([PATCH v4 00/16] 64bit block-layer: part I
<20201211183934.169161-1-vsement...@virtuozzo.com>)
This is called v4 too, because it follows old
([PATCH v3 00/17] 64bit block-layer
<20200430111033.29980-1-vsement...@virtu
We modify the request by adding an offset to vmstate. Let's check the
modified request. It will help us to safely move .bdrv_co_preadv_part
and .bdrv_co_pwritev_part to int64_t type of offset and bytes.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/block_int.h | 3 +++
block/io.
We are generally moving to int64_t for both offset and bytes parameters
on all io paths.
Main motivation is realization of 64-bit write_zeroes operation for
fast zeroing large disk chunks, up to the whole disk.
We chose signed type, to be consistent with off_t (which is signed) and
with possibili
We are generally moving to int64_t for both offset and bytes parameters
on all io paths.
Main motivation is realization of 64-bit write_zeroes operation for
fast zeroing large disk chunks, up to the whole disk.
We chose signed type, to be consistent with off_t (which is signed) and
with possibili
We are generally moving to int64_t for both offset and bytes parameters
on all io paths.
Main motivation is realization of 64-bit write_zeroes operation for
fast zeroing large disk chunks, up to the whole disk.
We chose signed type, to be consistent with off_t (which is signed) and
with possibili
There are only two drivers supporting vmstate: qcow2 and sheepdog.
Sheepdog is deprecated. In qcow2 these requests go through
.bdrv_co_p{read,write}v_part handlers.
So, let's do our basic check for the request on vmstate generic
handlers.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/io
We are going to support 64 bit discard requests. Now update the
limit variable. It's absolutely safe. The variable is set in some
drivers, and used in bdrv_co_pdiscard().
Update also max_pdiscard variable in bdrv_co_pdiscard(), so that
bdrv_co_pdiscard() is now prepared to 64bit requests. The rema
We are going to convert .bdrv_co_preadv_part and .bdrv_co_pwritev_part
to int64_t type for offset and bytes parameters (as it's already done
for generic block/io.c layer).
In qcow2 .bdrv_co_preadv_part is used in some places, so let's add
corresponding checks and assertions.
Signed-off-by: Vladim
Now, when all drivers are updated by previous commit, we can drop two
last limiters on write-zeroes path: INT_MAX in
bdrv_co_do_pwrite_zeroes() and bdrv_check_request32() in
bdrv_co_pwritev_part().
Now everything is prepared for implementing incredibly cool and fast
big-write-zeroes in NBD and qco
We are going to support 64 bit write-zeroes requests. Now update the
limit variable. It's absolutely safe. The variable is set in some
drivers, and used in bdrv_co_do_pwrite_zeroes().
Update also max_write_zeroes variable in bdrv_co_do_pwrite_zeroes(), so
that bdrv_co_do_pwrite_zeroes() is now pre
We are generally moving to int64_t for both offset and bytes parameters
on all io paths.
Main motivation is realization of 64-bit write_zeroes operation for
fast zeroing large disk chunks, up to the whole disk.
We chose signed type, to be consistent with off_t (which is signed) and
with possibili
Now, when all drivers are updated by previous commit, we can drop the
last limiter on pdiscard path: INT_MAX in bdrv_co_pdiscard().
Now everything is prepared for implementing incredibly cool and fast
big-discard requests in NBD and qcow2. And any other driver which wants
it of course.
Signed-off
On 2/24/21 5:35 AM, Markus Armbruster wrote:
John Snow writes:
mypy isn't fond of allowing you to check for bool membership in a
collection of str elements. Guard this lookup for precisely when we were
given a name.
Signed-off-by: John Snow
Reviewed-by: Eduardo Habkost
Reviewed-by: Cleber R
Public bug reported:
I'm using QEMU version 5.2.0 on macOS, and running the "OpenIndiana
Hipster 2020.10 Text Install DVD (64-bit x86)" ISO:
qemu-system-x86_64 -cdrom ~/Downloads/OI-hipster-text-20201031.iso -m
2048 -accel hvf -cpu host
It gets to "Booting...", stays there for a bit, and then re
Patchew URL:
https://patchew.org/QEMU/20210324205132.464899-1-vsement...@virtuozzo.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210324205132.464899-1-vsement...@virtuozzo.com
Subject: [PATCH v4 00/11] 64bit bl
I pulled the latest it got a bit further :-)
In file included from ../disas/arm-a64.cc:21:
In file included from /opt/build/build/stage/qemu/include/qemu/osdep.h:126:
In file included from /opt/build/build/stage/qemu/include/glib-compat.h:32:
In file included from
/opt/serverplus/dependencies/gli
Thanks for the answer,
indeed the second cluster of the board has been halted when I was
starting gdb the "normal" way - not adding the second inferior. In my
own research I did not find out about these inferiors, so I was
wondering why "info threads" did only show one cpu. Maybe gdb could
inform
On 3/24/21 7:33 PM, Philippe Mathieu-Daudé wrote:
> On 3/24/21 7:01 PM, Philippe Mathieu-Daudé wrote:
>> Hi,
>>
>> Peter's current workflow is push to /staging and if his
>> testing succeeds, he pushes the same commit as /master.
>>
>> IMO there is no point in building /master branch, as it
>> has
On 3/23/21 9:46 AM, Claudio Fontana wrote:
it is required by arch-dump.c and cpu.c, so apparently
we need this for KVM too
Signed-off-by: Claudio Fontana
Reviewed-by: Richard Henderson
+/*
+ * these are AARCH64-only, but due to the chain of dependencies,
+ * between HELPER prototypes, hf
On 3/23/21 9:46 AM, Claudio Fontana wrote:
this function is used for kvm too, add it to the
cpu-common module.
Signed-off-by: Claudio Fontana
Reviewed-by: Richard Henderson
/* #endif TARGET_AARCH64 , see matching comment above */
+
+uint64_t arm_sctlr(CPUARMState *env, int el)
+{
+/*
On 3/23/21 9:46 AM, Claudio Fontana wrote:
+
+
+
Watch the excessive whitespace. Otherwise,
Reviewed-by: Richard Henderson
r~
On 3/23/21 9:46 AM, Claudio Fontana wrote:
-static void arm_cpu_dump_state(CPUState *cs, FILE *f, int flags)
-{
-ARMCPU *cpu = ARM_CPU(cs);
-CPUARMState *env = &cpu->env;
-int i;
-
-if (is_a64(env)) {
-aarch64_cpu_dump_state(cs, f, flags);
-return;
-}
You've
On 3/23/21 9:46 AM, Claudio Fontana wrote:
we need this for KVM too.
Signed-off-by: Claudio Fontana
---
target/arm/cpu-sysemu.c | 60
target/arm/cpu-user.c | 5
target/arm/tcg/helper.c | 61 -
3 files c
On 3/23/21 9:46 AM, Claudio Fontana wrote:
move exception code out of tcg/
as we need part of it for KVM too.
put the exception code into separate cpu modules as appropriate,
including:
cpu-sysemu.c
tcg/tcg-cpu.c
tcg/sysemu/tcg-cpu.c
to avoid naming confusion with the existing cpu_tcg.c,
conta
On 3/23/21 9:46 AM, Claudio Fontana wrote:
Signed-off-by: Claudio Fontana
Reviewed-by: Philippe Mathieu-Daudé
---
target/arm/cpu-sysemu.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
Obviously, this should be done before the code moves.
r~
On 3/23/21 9:46 AM, Claudio Fontana wrote:
After this patch it is possible to build only kvm:
./configure --disable-tcg --enable-kvm
Signed-off-by: Claudio Fontana
---
target/arm/cpu-sysemu.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
Reviewed-by: Richard Henderson
On 3/23/21 9:46 AM, Claudio Fontana wrote:
The QEMU PSCI implementation is not used for KVM,
we do not need the kvm constants header.
Signed-off-by: Claudio Fontana
---
target/arm/arm-powerctl.h | 2 --
target/arm/psci.c | 1 -
2 files changed, 3 deletions(-)
Reviewed-by: Richard H
On 3/23/21 9:46 AM, Claudio Fontana wrote:
target/arm/kvm-stub.c | 24
Can you really get rid of this?
If so, I think this should be a separate step.
--- a/target/arm/kvm/meson.build
+++ b/target/arm/kvm/meson.build
@@ -1,3 +1,8 @@
arm_ss.add(when: 'CO
On 3/23/21 9:46 AM, Claudio Fontana wrote:
@@ -296,7 +297,8 @@ void arm_cpu_sve_finalize(ARMCPU *cpu, Error **errp)
*/
bitmap_andnot(tmp, kvm_supported, cpu->sve_vq_init, max_vq);
bitmap_or(cpu->sve_vq_map, cpu->sve_vq_map, tmp, max_vq);
-} else
This series adds support for scatter-gather sha256 and sha512 operations
on Aspeed's HACE (Hash And Crypto Engine) to the Aspeed model. These
operations are supported on AST2600 series of machines.
-Klaus
Basically using camelCase for some variables...
Signed-off-by: Klaus Heinrich Kiwi
---
hw/misc/aspeed_hace.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c
index 6e5b447a48..93313d2b80 100644
--- a/hw/mis
Complement the Aspeed HACE support with Scatter-Gather hash support for
sha256 and sha512. Scatter-Gather is only supported on AST2600-series.
Signed-off-by: Klaus Heinrich Kiwi
---
hw/misc/aspeed_hace.c | 127 --
include/hw/misc/aspeed_hace.h | 6 ++
2
Expand current Aspeed HACE testsuite to also include Scatter-Gather of
sha256 and sha512 operations.
Signed-off-by: Klaus Heinrich Kiwi
---
tests/qtest/aspeed_hace-test.c | 164 ++---
1 file changed, 153 insertions(+), 11 deletions(-)
diff --git a/tests/qtest/aspeed_
On Wed, 24 Mar 2021, Philippe Mathieu-Daudé wrote:
The motivation behind this series is to remove the
isa_get_irq(NULL) call to simplify the ISA generic model.
Could you please wait with this until after my pegasos2 series is merged?
Otherwise I'll have to rewrite that again for which I don't
On 3/24/21 11:38 PM, Klaus Heinrich Kiwi wrote:
> Basically using camelCase for some variables...
I don't think CamelCase applies to variables, only types.
https://qemu.readthedocs.io/en/latest/devel/style.html#variable-naming-conventions
C.
>
> Signed-off-by: Klaus Heinrich Kiwi
> ---
>
On Wed, Mar 24, 2021 at 10:22:47AM +0100, Auger Eric wrote:
> Hi Cleber,
>
> On 3/23/21 11:15 PM, Cleber Rosa wrote:
> > The LinuxTest specifically targets users that need to interact with Linux
> > guests. So, it makes sense to give a connection by default, and avoid
> > requiring it as boiler-p
On Wed, Mar 24, 2021 at 10:07:31AM +0100, Auger Eric wrote:
> Hi Cleber,
>
> On 3/23/21 11:15 PM, Cleber Rosa wrote:
> > Both the virtiofs submounts and the linux ssh mips malta tests
> > contains useful methods related to ssh that deserve to be made
> > available to other tests. Let's move them
On Wed, Mar 24, 2021 at 12:30:18PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Wed, Mar 24, 2021 at 2:23 AM Cleber Rosa wrote:
>
> > For users of the LinuxTest class, let's set up the VM with the port
> > redirection for SSH, instead of requiring each test to set the same
> > arguments.
> >
> >
On Wed, Mar 24, 2021 at 07:01:12PM +0100, Philippe Mathieu-Daudé wrote:
> Hi,
>
> Peter's current workflow is push to /staging and if his
> testing succeeds, he pushes the same commit as /master.
>
> IMO there is no point in building /master branch, as it
> has already been built earlier as /stag
On Wed, Mar 24, 2021 at 10:10:50AM +0100, Auger Eric wrote:
> Hi Cleber,
>
> On 3/23/21 11:15 PM, Cleber Rosa wrote:
> > For users of the LinuxTest class, let's set up the VM with the port
> > redirection for SSH, instead of requiring each test to set the same
> also sets the network device to vir
201 - 300 of 383 matches
Mail list logo
