Right now there is no easy way for "check" to print a reproducer command.
Because such a reproducer command line would be huge, we can instead teach
check to start a command of our choice. This can be for example a Python
unit test with arguments to only run a specific subtest.
Signed-off-by: Pao
In the next patch, "check" will learn how to execute a test script without
going through TestRunner. To enable this, keep only the text output
and subprocess handling in the TestRunner; move into TestEnv the logic
to prepare for running a subprocess.
Signed-off-by: Paolo Bonzini
---
tests/qemu-
On Tue, 23 Mar 2021 14:33:28 +1100
David Gibson wrote:
> On Mon, Mar 22, 2021 at 01:06:53PM +0100, Paolo Bonzini wrote:
> > On 22/03/21 07:39, David Gibson wrote:
> > > > QEMU doesn't really keep track of "in flight" unplug requests, and as
> > > > long as that's the case, its timeout even will
On 3/23/21 5:40 AM, Markus Armbruster wrote:
Commit 0426d53c65 "qapi: Simplify visiting of alternate types"
eliminated the implicit alternate enum, but neglected to update a
comment about it in a test. Do that now.
Signed-off-by: Markus Armbruster
Reviewed-by: John Snow
---
tests/qapi-s
Hi,
Any comments about this patch?
Thanks
Li
On Mon, Mar 15, 2021 at 6:07 PM Li Zhang wrote:
> From: Li Zhang
>
> For some scenarios, it needs to hot-add a monitor device.
> But QEMU doesn't support hotplug yet. It also works by adding
> a monitor with null backend by default and then change
On 3/23/21 5:40 AM, Markus Armbruster wrote:
Simple unions don't need more features, they need to die.
I'm willing to defer to your will here.
(And I'm not willing to implement enum discriminators to spite you.)
Signed-off-by: Markus Armbruster
Reviewed-by: John Snow
---
tests/qapi-
On 3/23/21 5:40 AM, Markus Armbruster wrote:
Member name 'u' and names starting with 'has-' or 'has_' are reserved
for the generator. check_type() enforces this, covered by tests
reserved-member-u and reserved-member-has.
These tests neglect to cover optional members, where the name starts
with
On 3/23/21 5:40 AM, Markus Armbruster wrote:
check_type() fails to reject optional members with reserved names,
because it neglects to strip off the leading '*'. Fix that.
The stripping in check_name_str() is now useless. Drop.
Also drop the "no leading '*'" assertion, because valid_name.matc
On Tue, 23 Mar 2021, David Gibson wrote:
On Wed, Mar 17, 2021 at 02:17:51AM +0100, BALATON Zoltan wrote:
The Marvell Discovery II aka. MV64361 is a PowerPC system controller
chip that is used on the pegasos2 PPC board. This adds emulation of it
that models the device enough to boot guests on thi
On Mon, Mar 22, 2021 at 10:55:42PM +0300, Yuri Gribov wrote:
> diff --git a/scripts/tracetool/format/c.py b/scripts/tracetool/format/c.py
> index c390c18..7e89ba3 100644
> --- a/scripts/tracetool/format/c.py
> +++ b/scripts/tracetool/format/c.py
> @@ -49,7 +49,7 @@ def generate(events, backend, gro
On Mon, Mar 22, 2021 at 10:55:42PM +0300, Yuri Gribov wrote:
> scripts/tracetool/format/c.py | 2 +-
My Reviewed-by is specifically for this tracetool file.
Stefan
signature.asc
Description: PGP signature
On Mon, Mar 22, 2021 at 04:13:26PM -0400, Vivek Goyal wrote:
> On Mon, Mar 22, 2021 at 11:00:52AM +, Stefan Hajnoczi wrote:
> > On Wed, Mar 17, 2021 at 08:32:31PM +0800, Jiachen Zhang wrote:
> > > On Wed, Mar 17, 2021 at 6:05 PM Stefan Hajnoczi
> > > wrote:
> > > > On Fri, Dec 18, 2020 at 05:
The nvdimm devices are expected to ensure write persistence during power
failure kind of scenarios.
The libpmem has architecture specific instructions like dcbf on power
to flush the cache data to backend nvdimm device during normal writes.
Qemu - virtual nvdimm devices are memory mapped. The dcb
The subsequent patches add definitions which tend to
get the compilation to cyclic dependency. So, prepare
with forward declarations, move the defitions and clean up.
Signed-off-by: Shivaprasad G Bhat
---
hw/ppc/spapr_nvdimm.c | 12
include/hw/ppc/spapr_nvdimm.h | 21 +++
The patch adds the 'sync-dax' property to the nvdimm device.
When the sync-dax is 'off', the device tree property
"hcall-flush-required" is added to the nvdimm node which makes the
guest to issue H_SCM_FLUSH hcalls to request for flushes explicitly.
This would be the default behaviour without sync
Hi all!
Here are some improvements to simplebench lib, to support my
"qcow2: compressed write cache" series.
v3:
01: use simpler logic
02,04-06: add John's r-b
07: use BooleanOptionalAction and
initial_run=args.initial_run
08: rewrite so that we have a new --drop-caches option
Vladimir Semen
The patch adds support for the SCM flush hcall for the nvdimm devices.
To be available for exploitation by guest through the next patch.
The hcall expects the semantics such that the flush to return
with H_BUSY when the operation is expected to take longer time along
with a continue_token. The hca
Sometimes one of cells in a testing table runs too slow. And we really
don't want to wait so long. Limit number of runs in this case.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
scripts/simplebench/simplebench.py | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --gi
statistics.stdev raises if sequence length is less than two. Support
that case by hand.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
---
scripts/simplebench/simplebench.py | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/scripts/simplebench/simpleben
Allow bench compressed backup.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
scripts/simplebench/bench-backup.py| 55 ++
scripts/simplebench/bench_block_job.py | 23 +++
2 files changed, 62 insertions(+), 16 deletions(-)
diff --git a/scripts/simplebench/ben
Add support for qcow2 source. New option says to use test-source.qcow2
instead of test-source. Of course, test-source.qcow2 should be
precreated.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
---
scripts/simplebench/bench-backup.py| 5 +
scripts/simplebench/bench_bl
Allow benchmark with different kinds of target cache.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
---
scripts/simplebench/bench-backup.py| 33 --
scripts/simplebench/bench_block_job.py | 10 +---
2 files changed, 33 insertions(+), 10 deleti
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9147e9a429..7d83d64d14 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2531,6 +2531,7 @@ Benchmark util
M: Vladimir Sementsov-Ogievskiy
S: Maintained
Hi Huacai,
We are going to tag QEMU v6.0-rc0 today.
I only have access to a 64-bit MIPS in little-endian to
test KVM.
Can you test the other configurations please?
- 32-bit BE
- 32-bit LE
- 64-bit BE
Thanks!
Phil.
On 11/22/20 4:31 AM, Huacai Chen wrote:
> +CC Jiaxun
>
> Hi, Jiaxun,
>
> What
On Fri, Mar 19, 2021 at 03:25:20PM +0200, Mahmoud Mandour wrote:
> Replaced the allocation and deallocation of fuse_req structs
> using calloc()/free() call pairs to a GLib's g_try_new0()
> and g_free().
>
> Signed-off-by: Mahmoud Mandour
> ---
> tools/virtiofsd/fuse_lowlevel.c | 6 +++---
> 1 f
We should not report success if there is an error in final event.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
---
scripts/simplebench/bench_block_job.py | 4
1 file changed, 4 insertions(+)
diff --git a/scripts/simplebench/bench_block_job.py
b/scripts/simplebench/b
On 3/23/21 8:00 AM, John Snow wrote:
> On 3/23/21 5:40 AM, Markus Armbruster wrote:
>> +# event 'data' member with dict value is (longhand) argument
>> +# definition, not inline complex type
>
> I have to be a weenie and say I don't know exactly what this comment is
> telling me.
>
> (1) What's a
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> A few old comments talk about "desired future use of defaults" and
> "anonymous inline branch types". Kind of misleading since commit
> 87adbbffd4 "qapi: add a dictionary form for TYPE" added longhand
> member definitions. Talk about that instead.
>
On Tue, Mar 23, 2021 at 05:09:45AM -0700, no-re...@patchew.org wrote:
> ERROR: Author email address is mangled by the mailing list
> #2:
> Author: Anthony PERARD via
The actual commit in the pull request is fine.
I didn't work around the email issue when sending pull request, but I've
worked ar
Add arguments to set number of test runs per table cell and to disable
initial run that is not counted in results.
It's convenient to set --count 1 --no-initial-run to fast run test
onece, and to set --count to some large enough number for good
precision of the results.
Signed-off-by: Vladimir Se
Add an option to drop caches before each test run. It may probably
improve reliability of results when testing in cached mode.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
scripts/simplebench/bench-backup.py | 6 +-
scripts/simplebench/simplebench.py | 11 ++-
2 files changed, 1
On Fri, Mar 19, 2021 at 03:25:21PM +0200, Mahmoud Mandour wrote:
> @@ -629,9 +628,6 @@ int fuse_reply_ioctl_retry(fuse_req_t req, const struct
> iovec *in_iov,
>
> res = send_reply_iov(req, 0, iov, count);
> out:
> -free(in_fiov);
> -free(out_fiov);
> -
> return res;
>
> en
On Fri, Mar 19, 2021 at 03:25:23PM +0200, Mahmoud Mandour wrote:
> Replaced the allocation and deallocation of fuse_session structs
> from calloc() and free() calls to g_new0() and g_free().
>
> Removed the NULL-check and used g_new0() mainly because fuse_session
> creation is critical and an exit
On Fri, Mar 19, 2021 at 03:25:25PM +0200, Mahmoud Mandour wrote:
> Changed the allocations of fv_VuDev structs, VuDev structs, and
> fv_QueueInfo strcuts from using calloc()/realloc() & free() to using
> the equivalent functions from GLib.
>
> In instances, removed the pair of allocation and asser
On Fri, Mar 19, 2021 at 03:25:22PM +0200, Mahmoud Mandour wrote:
> Changed allocation of fuse_pollhandle structs to GLib's g_new().
>
> Removed the null checking as allocating such a small memory segment
> should always succeed on a healthy system. Otherwise, the system
> is already in a critical
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> Flat union tag values get checked twice: as enum member name, and as
> union branch name. The former accepts leading digits, the latter
> doesn't. The restriction feels arbitrary. Skip the latter check.
>
> This can expose c_name() to input it can'
On Fri, Mar 19, 2021 at 03:25:26PM +0200, Mahmoud Mandour wrote:
> Changed the allocations of some local variables to GLib's allocation
> functions, such as g_try_malloc0(), and annotated those variables
> as g_autofree. Subsequently, I was able to remove the calls to free().
>
> Signed-off-by: Ma
On Mon, 22 Mar 2021 at 14:10, Peter Maydell wrote:
>
> On Sat, 20 Mar 2021 at 00:06, Richard Henderson
> wrote:
> >
> > Pretend the fault always happens at page table level 3.
> >
> > Failure to set this leaves level = 0, which is impossible for
> > ARMFault_Permission, and produces an invalid sy
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> check_name_str() masks leading digits when passed enum_member=True.
> Only check_enum() does. Lift the masking into check_enum().
>
> Signed-off-by: Markus Armbruster
> ---
> scripts/qapi/expr.py | 23 ++-
> 1 file changed, 10 i
On Tue, Mar 23, 2021 at 10:50:05AM +, Peter Maydell wrote:
> On Mon, 22 Mar 2021 at 22:56, Michael S. Tsirkin wrote:
> > On Mon, Mar 22, 2021 at 06:46:06PM +, Peter Maydell wrote:
> > > This happens because pm_update_sci() calls pci_irq_handler(),
> > > which calls pci_intx(pci_dev), which
On Fri, Mar 19, 2021 at 03:25:24PM +0200, Mahmoud Mandour wrote:
> Replaced (re)allocation of lo_map_elem structs from realloc() to
> GLib's g_try_realloc_n() and replaced the respective free() call
> with a g_free().
>
> Signed-off-by: Mahmoud Mandour
> ---
> tools/virtiofsd/passthrough_ll.c |
On Fri, Mar 19, 2021 at 03:25:27PM +0200, Mahmoud Mandour wrote:
> @@ -588,7 +587,7 @@ out:
> }
>
> pthread_mutex_destroy(&req->ch.lock);
> -free(fbuf.mem);
> +g_free(fbuf.mem);
> free(req);
^--- was FVRequest allocation changed in a previous patch?
Mayb
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> Naming rules differ for the various kinds of names. To prepare
> enforcing them, define functions to check them: check_name_upper(),
> check_name_lower(), and check_name_camel(). For now, these merely
> wrap around check_name_str(), but that will cha
This patch fixes the update-binfmts templates being used in the script
scripts/qemu-binfmt-conf.sh when the option --debian is used.
Fixed issues are:
- Typo in flag 'credentials' (previously 'credential').
- Missing flags 'preserve' and 'fix_binary'.
Reference:
https://manpages.debian.org/buste
On 3/23/21 9:58 AM, Eric Blake wrote:
On 3/23/21 8:00 AM, John Snow wrote:
On 3/23/21 5:40 AM, Markus Armbruster wrote:
+# event 'data' member with dict value is (longhand) argument
+# definition, not inline complex type
I have to be a weenie and say I don't know exactly what this comment is
The function flatview_for_each_range() calls a callback for each
range in a FlatView. Currently the callback gets the start and
length of the range and the MemoryRegion involved, but not the offset
within the MemoryRegion. Add this to the callback's arguments; we're
going to want it for a new use
:
https://git.linaro.org/people/pmaydell/qemu-arm.git
tags/pull-target-arm-20210323
for you to fetch changes up to dad90de78e9e9d47cefcbcd30115706b98e6ec87:
target/arm: Set ARMMMUFaultInfo.level in user-only arm_cpu_tlb_fill
(2021-03-23 14:0
For accesses to rom blob data before or during reset, we have a
function rom_ptr() which looks for a rom blob that would be loaded to
the specified address, and returns a pointer into the rom blob data
corresponding to that address. This allows board or CPU code to say
"what is the data that is go
On Tue, Mar 23, 2021 at 01:54:46PM +0100, Christian Schoenebeck wrote:
> On Montag, 22. März 2021 11:54:56 CET Stefan Hajnoczi wrote:
> > > > Thanks, Christian. I am still trying to figure out the details of the
> > > > ROP
> > > > attacks.
> > > >
> > > > However, QEMU's vhost-user reconnection i
For Arm M-profile CPUs, on reset the CPU must load its initial PC and
SP from a vector table in guest memory. Because we can't guarantee
reset ordering, we have to handle the possibility that the ROM blob
loader's reset function has not yet run when the CPU resets, in which
case the data in an ELF
From: Gavin Shan
A clock is added by commit aac63e0e6ea3 ("hw/char/pl011: add a clock
input") since v5.2.0 which corresponds to virt-5.2 machine type. It
causes backwards migration failure from upstream to downstream (v5.1.0)
when the machine type is specified with virt-5.1.
This fixes the issue
Add a documentation comment describing flatview_for_each_range().
Signed-off-by: Peter Maydell
Reviewed-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
Message-id: 20210318174823.18066-3-peter.mayd...@linaro.org
---
include/exec/memory.h | 26 --
1 file change
The return value of the flatview_cb callback passed to the
flatview_for_each_range() function is zero if the iteration through
the ranges should continue, or non-zero to break out of it. Use a
bool for this rather than int.
Signed-off-by: Peter Maydell
Reviewed-by: Richard Henderson
Reviewed-by
Keqian,
On Tue, Mar 23, 2021 at 02:40:43PM +0800, Keqian Zhu wrote:
> >> The second question is that you observed longer migration time (55s->73s)
> >> when guest
> >> has 24G ram and dirty rate is 800M/s. I am not clear about the reason. As
> >> with dirty
> >> ring enabled, Qemu can get dirty
From: Richard Henderson
Pretend the fault always happens at page table level 3.
Failure to set this leaves level = 0, which is impossible for
ARMFault_Permission, and produces an invalid syndrome, which
reaches g_assert_not_reached in cpu_loop.
Fixes: 8db94ab4e5db ("linux-user/aarch64: Pass syn
On 3/23/21 5:40 AM, Markus Armbruster wrote:
A few old comments talk about "desired future use of defaults" and
"anonymous inline branch types". Kind of misleading since commit
87adbbffd4 "qapi: add a dictionary form for TYPE" added longhand
member definitions. Talk about that instead.
Signed-
23.03.2021 16:06, Paolo Bonzini wrote:
Python test scripts that use unittest consist of multiple tests.
unittest.main allows selecting which tests to run, but currently this
is not possible because the iotests wrapper ignores sys.argv.
unittest.main command line options also allow the user to pi
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> Event names should be ALL_CAPS with words separated by underscore.
> Enforce this. The only offenders are in tests/. Fix them. Existing
> test event-case covers the new error.
>
> Signed-off-by: Markus Armbruster
> ---
Reviewed-by: Eric Blake
-
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> check_name_lower() is the only user of check_name_str() using
> permit_upper=False. Move the associated code from check_name_str() to
> check_name_lower(), and drop the parameter.
>
> Signed-off-by: Markus Armbruster
> ---
> scripts/qapi/expr.py |
On 3/23/21 9:30 AM, John Snow wrote:
> On 3/23/21 10:20 AM, Eric Blake wrote:
>>> -valid_name = re.compile(r'^(__[a-zA-Z0-9.-]+_)?'
>>> - '[a-zA-Z][a-zA-Z0-9_-]*$')
>> I'm assuming python concatenates r'' with '' in the obvious manner...
>>
>
> FWIW, I don't think it does, a
On 3/23/21 10:20 AM, Eric Blake wrote:
-valid_name = re.compile(r'^(__[a-zA-Z0-9.-]+_)?'
-'[a-zA-Z][a-zA-Z0-9_-]*$')
I'm assuming python concatenates r'' with '' in the obvious manner...
FWIW, I don't think it does, actually. I believe you do need to spell
out each in
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> We require lowercase __RFQDN_ downstream prefixes only where we
> require the prefixed name to be lowercase. Don't; permit any case in
> __RFQDN_ prefixes anywhere.
>
> Signed-off-by: Markus Armbruster
> ---
> scripts/qapi/expr.py | 2 +-
> 1 file
On 3/23/21 1:27 PM, Peter Maydell wrote:
> On Sat, 13 Mar 2021 at 17:01, Philippe Mathieu-Daudé wrote:
>>
>> When QDev objects have their DeviceReset handler set, they
>> shouldn't worry about calling it at realization stage (it
>> is handled by hw/core/qdev.c::device_set_realized).
>>
>> Remove t
The issue is with people who installed a VM using 5.1 qemu,
migrated to 5.2, booted there and set a config on a device
e.g. IP on a NIC.
They now have a 5.1 machine type but changing uid back
like we do will break these VMs.
Unlikley to be common but let's at least create a way for these people
to
On 3/23/21 5:40 AM, Markus Armbruster wrote:
Flat union tag values get checked twice: as enum member name, and as
union branch name. The former accepts leading digits, the latter
doesn't. The restriction feels arbitrary. Skip the latter check.
This can expose c_name() to input it can't handle
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> Type names should be CamelCase. Enforce this. The only offenders are
> in tests/. Fix them. Add test type-case to cover the new error.
>
> Signed-off-by: Markus Armbruster
> ---
> +++ b/scripts/qapi/expr.py
> @@ -61,7 +61,8 @@ def check_name_low
I might be spoiled by the s390x-POP style to define instructions, but in
the following doc about the PowerISA unfortunately there is no list of
reasons-for-SIGILL. Therefore I'm out of options on this waiting for
someone - most likely IBM - to chime in.
https://wiki.raptorcs.com/w/images/f/f5/Powe
Public bug reported:
qemu version: git 5ca634afcf83215a9a54ca6e66032325b5ffb5f6; 5.2.0
We've encountered that booting the Linux kernel in TCG mode, results in
a racy heap-use-after-free. The bug can be detected by ASan [A], but in
the majority of runs results in a crashing kernel [B].
To reprodu
On Tue, 23 Mar 2021 05:46:24 +0100
Thomas Huth wrote:
> On 22/03/2021 18.48, Lukas Straub wrote:
> > On Mon, 22 Mar 2021 17:00:23 +0100
> > Thomas Huth wrote:
> >
> >> On 22/03/2021 08.35, Lukas Straub wrote:
> >>> On Mon, 22 Mar 2021 06:20:50 +0100
> >>> Thomas Huth wrote:
> >>>
> >
They can simply set the 5.2 VM version in such a case. I do not want to let
this legacy hack to be enabled in any modern QEMU VM version, as it violates
ACPI specification and makes the life more difficult for various other software
like bootloaders and operating systems.
> 23 марта 2021 г., в
On Tue, Mar 23, 2021 at 10:51:57AM +0300, Andrey Gruzdev wrote:
> On 22.03.2021 23:17, Peter Xu wrote:
> > On Fri, Mar 19, 2021 at 05:52:47PM +0300, Andrey Gruzdev wrote:
> > > Added missing qemu_fflush() on buffer file holding precopy device state.
> > > Increased initial QIOChannelBuffer allocati
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> The previous commit changed this test to clash with a predefined enum
> type, not a built-in type. Adjust its name.
>
> Signed-off-by: Markus Armbruster
> ---
> tests/qapi-schema/meson.build | 2 +-
> tests/qapi-sc
> -Original Message-
> From: Yuri Gribov
> Sent: Monday, March 22, 2021 2:56 PM
> To: qemu-devel@nongnu.org
> Cc: Richard Henderson ; Laurent Vivier
> ; Philippe Mathieu-Daudé ; Chris
> Wulff ; David Gibson ;
> Palmer Dabbelt ; Taylor Simpson
> ; Paolo Bonzini ; Cornelia
> Huck ; Max Fil
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> scripts/qapi/parser.py | 19 +--
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> Rename pragma-doc-required-crap to pragma-not-bool,
> pragma-returns-whitelist-crap to pragma-value-not-list, and
> pragma-name-case-whitelist-crap to pragma-value-not-list-of-str.
>
> Signed-off-by: Markus Armbruster
> ---
Reviewed-by: Eric Blake
On 23.03.21 15:55, Vitaly Cheptsov wrote:
>> 23 марта 2021 г., в 17:48, Michael S. Tsirkin написал(а):
>>
>> The issue is with people who installed a VM using 5.1 qemu,
>> migrated to 5.2, booted there and set a config on a device
>> e.g. IP on a NIC.
>> They now have a 5.1 machine type but changi
Jessica Clarke wrote:
> Commit 3eacf70bb5a83e4775ad8003cbca63a40f70c8c2 neglected to fix this
> for softmmu configs, which pull in migration's use of gnutls.
>
> This fixes the following compilation failure on Arm-based Macs:
>
> In file included from migration/multifd.c:23:
> In file included
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> This test covers returning "bad" types. Pragma returns-whitelist is
> just one aspect. Naming it returns-whitelist is suboptimal. Rename
> to returns-bad-type.
>
> Signed-off-by: Markus Armbruster
> ---
Reviewed-by: Eric Blake
--
Eric Blake, P
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> Rename pragma returns-whitelist to command-returns-exceptions, and
> name-case-whitelist to member-name-case-exceptions.
>
> Signed-off-by: Markus Armbruster
> ---
Doesn't mention anything about the motivation for this including the
desire to move aw
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> qapi/pragma.json | 16 +---
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
Reviewed-by: Eric Blake
> diff --git a/qapi/pragma.json b/qapi/pragma.json
> index 4895848c5e..4c47c802d1 100644
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> Commit 967c885108 "qapi: add 'if' to top-level expressions" added
> command TestIfCmd with an 'if' condition. It also added the
> qmp_TestIfCmd() to go with it, guarded by the corresponding #if.
> Commit ccadd6bcba "qapi: Add 'if' to implicit struct m
On Tue, Mar 23, 2021 at 04:04:48PM +0100, Juan Quintela wrote:
> Jessica Clarke wrote:
> > Commit 3eacf70bb5a83e4775ad8003cbca63a40f70c8c2 neglected to fix this
> > for softmmu configs, which pull in migration's use of gnutls.
> >
> > This fixes the following compilation failure on Arm-based Macs:
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> Command names and member names within a type should be all lower case
> with words separated by a hyphen. We also accept underscore. Rework
> check_name_lower() to optionally reject underscores, but don't use
> that option, yet.
>
> Update expected
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> Feature names should use '-', not '_'. Enforce this.
>
> Signed-off-by: Markus Armbruster
> ---
> scripts/qapi/expr.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thankfully no offenders ;)
Reviewed-by: Eric Blake
>
> diff --git a/
Here a new version of the series that enables kvm-only builds.
The goal here is to enable the KVM-only build, but there is
some additional cleanup too.
In this iteration we split helpers in tcg/ into user and sysemu
parts, to put into the respective directories.
I also had to actually remove the
Signed-off-by: Claudio Fontana
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
---
target/arm/{ => tcg}/translate-a64.h | 0
target/arm/{ => tcg}/translate.h | 0
target/arm/{ => tcg}/a32-uncond.decode| 0
target/arm/{ => tcg}/a32.decode | 0
target/arm/{
Signed-off-by: Claudio Fontana
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
---
meson.build | 1 +
target/arm/{ => tcg}/op_addsub.h | 0
target/arm/tcg/trace.h | 1 +
target/arm/{ => tcg}/vec_internal.h | 0
target/arm/{ => tcg}/crypto_
Signed-off-by: Claudio Fontana
Reviewed-by: Alex Bennée
---
target/arm/tcg/meson.build| 3 +++
target/arm/tcg/sysemu/meson.build | 3 +++
target/arm/tcg/user/meson.build | 3 +++
3 files changed, 9 insertions(+)
create mode 100644 target/arm/tcg/sysemu/meson.build
create mode 100644
move sysemu-only parts of debug_helper to sysemu/
Signed-off-by: Claudio Fontana
---
target/arm/tcg/debug_helper.c| 27 ---
target/arm/tcg/sysemu/debug_helper.c | 33
target/arm/tcg/sysemu/meson.build| 1 +
3 files changed, 34 inserti
Signed-off-by: Claudio Fontana
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
---
target/arm/tcg/meson.build | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target/arm/tcg/meson.build b/target/arm/tcg/meson.build
index 0bd4e9d954..3b4146d079 100644
--- a/targe
Signed-off-by: Claudio Fontana
---
target/arm/tcg/tlb_helper.h| 17 ++
target/arm/tcg/sysemu/tlb_helper.c | 83 ++
target/arm/tcg/tlb_helper.c| 96 ++
target/arm/tcg/user/tlb_helper.c | 31 ++
target/arm/tcg/sysemu/
I just got this running 'make check-acceptance': does it
ring a bell with anybody?
[etc]
Fetching asset from
tests/acceptance/replay_kernel.py:ReplayKernelSlow.test_mips64el_malta_5KEc_cpio
Fetching asset from
tests/acceptance/replay_kernel.py:ReplayKernelSlow.test_mips64el_malta_5KEc_cpio
Fetchin
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> Command names should be lower-case. Enforce this. Fix the fixable
> offenders (all in tests/), and add the remainder to pragma
> command-name-exceptions.
>
> Signed-off-by: Markus Armbruster
> ---
> +++ b/qapi/pragma.json
> @@ -4,6 +4,24 @@
> # a
allocation_tag_mem has a different implementation for
user-only and sysemu, so move the two implementations into
the dedicated subdirs.
Signed-off-by: Claudio Fontana
---
target/arm/tcg/mte_helper.h| 52
target/arm/tcg/mte_helper.c| 191 +
ta
Does this repro with current-head-of-git QEMU ?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1920934
Title:
Heap-use-after-free in io_writex / cputlb.c results in Linux kernel
crashes
Status in
On Mon, 22 Mar 2021 at 22:59, Michael S. Tsirkin wrote:
>
> Changes from v1:
> dropped an acpi patch causing regressions reported by clang
>
> The following changes since commit f0f20022a0c744930935fdb7020a8c18347d391a:
>
> Merge remote-tracking branch
> 'remotes/thuth-gitlab/tags/pull-requ
On 23/03/21 15:34, Vladimir Sementsov-Ogievskiy wrote:
+ def __init__(self, *args, **kwargs):
+ super().__init__(stream=ReproducibleTextTestRunner.output,
*args, **kwargs)
over-79 line (PEP8)
Ok, thanks.
+
+def execute_unittest(argv, debug=False):
+ """Executes unittests withi
The following changes since commit c95bd5ff1660883d15ad6e0005e4c8571604f51a:
Merge remote-tracking branch 'remotes/philmd/tags/mips-fixes-20210322' into=
staging (2021-03-22 14:26:13 +)
are available in the Git repository at:
git://git.kraxel.org/qemu tags/ui-20210323-pull-re
From: Peter Maydell
The function is_surface_bgr() is no longer used anywhere,
so we can delete it.
Signed-off-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20210314163927.1184-1-peter.mayd...@linaro.org>
Signed-off-by: Gerd Hoffmann
---
include/ui/console.h | 10
From: Zihao Chang
This patch adds reload interface for QCryptoTLSCredsClass and implements
the interface for QCryptoTLSCredsX509.
Signed-off-by: Zihao Chang
Acked-by: Daniel P. Berrangé
Message-Id: <20210316075845.1476-2-changzih...@huawei.com>
Signed-off-by: Gerd Hoffmann
---
include/crypto
101 - 200 of 562 matches
Mail list logo
