Re: [PATCH 0/3] target/arm: Add nested virtualization support

2021-03-23 Thread Haibo Xu
On Tue, 23 Mar 2021 at 00:32, Andrew Jones wrote: > > On Mon, Mar 22, 2021 at 04:42:23PM +0100, Andrea Bolognani wrote: > > On Mon, 2021-03-22 at 10:07 +, Haibo Xu wrote: > > > This series add support for ARMv8.3/8.4 nested virtualization support > > > in KVM mode. It's based on Marc Zyngier's

Re: [PATCH] i386/cpu_dump: support AVX512 ZMM regs dump

2021-03-23 Thread Robert Hoo
On Mon, 2021-03-22 at 15:06 -0600, Richard Henderson wrote: > On 3/22/21 4:59 AM, Robert Hoo wrote: > > Since commit fa4518741e (target-i386: Rename struct XMMReg to > > ZMMReg), > > CPUX86State.xmm_regs[] has already been extended to 512bit to > > support > > AVX512. > > Also, other qemu level sup

Re: [PATCH 3/3] Enable nested virtualization support in arm64 KVM mode

2021-03-23 Thread Haibo Xu
On Mon, 22 Mar 2021 at 18:49, Andrew Jones wrote: > > On Mon, Mar 22, 2021 at 10:07:26AM +, Haibo Xu wrote: > > Add support for arm64 el2 in qemu KVM mode(nested virtualization). > > This feature is disabled by default, just as that in TCG mode, and > > can be enabled by "-M virt,accel=kvm,vir

Re: [RFC v5 1/6] qmp: add QMP command x-debug-query-virtio

2021-03-23 Thread Jonah Palmer
On 3/18/21 4:46 PM, Eric Blake wrote: On 3/18/21 11:29 AM, Jonah Palmer wrote: From: Laurent Vivier This new command lists all the instances of VirtIODevice with their path and virtio type Signed-off-by: Laurent Vivier Reviewed-by: Eric Blake Signed-off-by: Jonah Palmer --- We've missed

[PATCH v2] docs: simplify each section title

2021-03-23 Thread marcandre . lureau
From: Marc-André Lureau Now that we merged into one doc, it makes the nav looks nicer. Signed-off-by: Marc-André Lureau --- v2: - Developers -> Developer Information (suggested by Peter) docs/devel/index.rst | 4 ++-- docs/interop/index.rst | 4 ++-- docs/specs/index.rst | 4 ++-- docs/s

Re: [RFC Qemu PATCH v2 1/2] spapr: drc: Add support for async hcalls at the drc level

2021-03-23 Thread Shivaprasad G Bhat
Hi David, Sorry about the delay. On 2/8/21 11:51 AM, David Gibson wrote: On Tue, Jan 19, 2021 at 12:40:31PM +0530, Shivaprasad G Bhat wrote: Thanks for the comments! On 12/28/20 2:08 PM, David Gibson wrote: On Mon, Dec 21, 2020 at 01:08:53PM +0100, Greg Kurz wrote: ... The overall idea l

Re: [RFC] accel: add cpu_reset

2021-03-23 Thread Paolo Bonzini
On 22/03/21 14:51, Claudio Fontana wrote: It is possible to include calls from one sourceset to another (including from common to specific) as long as the conditions ensure that the symbol is defined. I guess this last sentence is the more tricky for me to get: "as long as the conditions ensu

Re: [PATCH v1 1/3] migration: Fix missing qemu_fflush() on buffer file in bg_migration_thread

2021-03-23 Thread Andrey Gruzdev
On 22.03.2021 23:17, Peter Xu wrote: On Fri, Mar 19, 2021 at 05:52:47PM +0300, Andrey Gruzdev wrote: Added missing qemu_fflush() on buffer file holding precopy device state. Increased initial QIOChannelBuffer allocation to 512KB to avoid reallocs. Typical configurations often require >200KB for

Re: [PATCH 00/15] virtio-gpu: split into two devices.

2021-03-23 Thread Gerd Hoffmann
On Mon, Mar 22, 2021 at 06:41:47PM +, Kasireddy, Vivek wrote: > Hi Gerd, > > > On Fri, Mar 19, 2021 at 03:48:42PM +0400, Marc-André Lureau wrote: > > > Hi Gerd > > > > > > On Fri, Mar 19, 2021 at 3:22 PM Gerd Hoffmann wrote: > > > > > > > Currently we have one virtio-gpu device. Problem with

Re: [PATCH 07/11] hw/gpio/avr_gpio: Add tracing for reads and writes

2021-03-23 Thread Philippe Mathieu-Daudé
Hi Niteesh, On 3/23/21 3:42 AM, Niteesh G. S. wrote: > Hii Phil, > > A gentle reminder to push these patches. Unfortunately the series is blocked by a legal issue in a previous patch: https://www.mail-archive.com/qemu-devel@nongnu.org/msg791443.html We are pending an update from Heecheol Yang.

Re: [RFC] accel: add cpu_reset

2021-03-23 Thread Philippe Mathieu-Daudé
On 3/22/21 2:54 PM, Claudio Fontana wrote: > On 3/22/21 2:42 PM, Philippe Mathieu-Daudé wrote: >> On 3/22/21 2:27 PM, Claudio Fontana wrote: >>> XXX >>> --- >>> accel/accel-common.c| 9 + >>> hw/core/cpu.c | 3 ++- >>> include/hw/core/accel-cpu.h | 2 ++ >>> include/q

RE: [PATCH V4 2/7] qapi/net.json: Add L4_Connection definition

2021-03-23 Thread Zhang, Chen
> -Original Message- > From: Markus Armbruster > Sent: Monday, March 22, 2021 8:31 PM > To: Zhang, Chen > Cc: Lukas Straub ; Li Zhijian > ; Jason Wang ; qemu- > dev ; Dr. David Alan Gilbert > ; Zhang Chen > Subject: Re: [PATCH V4 2/7] qapi/net.json: Add L4_Connection definition > > "

RE: [PATCH V4 3/7] qapi/net: Add new QMP command for COLO passthrough

2021-03-23 Thread Zhang, Chen
> -Original Message- > From: Markus Armbruster > Sent: Monday, March 22, 2021 8:16 PM > To: Zhang, Chen > Cc: Lukas Straub ; Li Zhijian > ; Jason Wang ; qemu- > dev ; Dr. David Alan Gilbert > ; Zhang Chen > Subject: Re: [PATCH V4 3/7] qapi/net: Add new QMP command for COLO > passthrou

[PATCH] target/riscv: Align the data type of reset vector address

2021-03-23 Thread Dylan Jhong
Although the AE350 has not been upstream (preparing for v2), the reset vector of the AE350 is known to be at the 2G position, so this patch is corrected in advance. Signed-off-by: Dylan Jhong Signed-off-by: Ruinland ChuanTzu Tsai --- target/riscv/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1

RE: [PATCH V4 3/7] qapi/net: Add new QMP command for COLO passthrough

2021-03-23 Thread Zhang, Chen
> -Original Message- > From: Markus Armbruster > Sent: Monday, March 22, 2021 8:36 PM > To: Zhang, Chen > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Eric Blake ; Dr. David Alan > Gilbert ; Li Zhijian ; Lukas > Straub ; Zhang Chen > Subject: Re: [PATCH V4 3/7] qapi/net: Add new QMP

[PATCH v2 1/2] optionrom: add memcmp() implementation

2021-03-23 Thread Stefano Garzarella
Provide memcmp() implementation that can be used by optionroms. Signed-off-by: Stefano Garzarella --- pc-bios/optionrom/optrom.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/pc-bios/optionrom/optrom.h b/pc-bios/optionrom/optrom.h index 357819259a..b98436e413 100644 --- a/

[PATCH v2 2/2] optionrom/pvh: use memcmp() to find the RSDP signature

2021-03-23 Thread Stefano Garzarella
New versions of gcc report a potential error and there may be alignment issues using uint64_t pointer to check the RSDP signature: gcc 10.2.1 "cc (Alpine 10.2.1_pre2) 10.2.1 20210313" reports: pc-bios/optionrom/pvh_main.c: In function 'search_rsdp': pc-bios/optionrom/pvh_main.c:61:21:

[PATCH v2 0/2] optionrom/pvh: use memcmp() to find the RSDP signature

2021-03-23 Thread Stefano Garzarella
In this version I added a memcmp() implementation. In v1 I tried with __builtin_memcmp() but CI failed with clang [1] and gcc 4.8.5. v2: - added patch 1 to provide a memcmp() implementation - made 'rsdp_signature' static const [Phil] - uses memcmp() instead of __builtin_memcmp() - added pvh.bin bi

[PATCH 00/28] qapi: Enforce naming rules

2021-03-23 Thread Markus Armbruster
This will save us pointless review - fix up cycles. We should've done it long ago. The whole series could be considered bug fixes. Not particularly urgent ones, though. Options: * Take them all. * Take PATCH 01-07 now, queue the rest for 6.1. * Queue all for 6.1. Let me know your preference

[PATCH 03/28] tests/qapi-schema: Rework comments on longhand member definitions

2021-03-23 Thread Markus Armbruster
A few old comments talk about "desired future use of defaults" and "anonymous inline branch types". Kind of misleading since commit 87adbbffd4 "qapi: add a dictionary form for TYPE" added longhand member definitions. Talk about that instead. Signed-off-by: Markus Armbruster --- tests/qapi-sche

[PATCH 11/28] qapi: Move uppercase rejection to check_name_lower()

2021-03-23 Thread Markus Armbruster
check_name_lower() is the only user of check_name_str() using permit_upper=False. Move the associated code from check_name_str() to check_name_lower(), and drop the parameter. Signed-off-by: Markus Armbruster --- scripts/qapi/expr.py | 15 +++ 1 file changed, 7 insertions(+), 8 dele

[PATCH 04/28] tests/qapi-schema: Belatedly update comment on alternate clash

2021-03-23 Thread Markus Armbruster
Commit 0426d53c65 "qapi: Simplify visiting of alternate types" eliminated the implicit alternate enum, but neglected to update a comment about it in a test. Do that now. Signed-off-by: Markus Armbruster --- tests/qapi-schema/alternate-clash.err | 2 +- tests/qapi-schema/alternate-clash.json |

[PATCH 01/28] qapi/pragma: Tidy up after removal of deprecated commands

2021-03-23 Thread Markus Armbruster
Commit cbde7be900 "migrate: remove QMP/HMP commands for speed, downtime and cache size" neglected to remove query-migrate-cache-size from pragma returns-whitelist. Commit 8af54b9172 "machine: remove 'query-cpus' QMP command" neglected to remove CpuInfo & friends from pragma name-case-exceptions.

[PATCH 20/28] qapi/pragma: Streamline comments on member-name-exceptions

2021-03-23 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qapi/pragma.json | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/qapi/pragma.json b/qapi/pragma.json index 4895848c5e..4c47c802d1 100644 --- a/qapi/pragma.json +++ b/qapi/pragma.json @@ -10,11 +10,13 @@ 'query-tpm-

[PATCH 05/28] tests/qapi-schema: Drop TODO comment on simple unions

2021-03-23 Thread Markus Armbruster
Simple unions don't need more features, they need to die. Signed-off-by: Markus Armbruster --- tests/qapi-schema/flat-union-no-base.err | 2 +- tests/qapi-schema/flat-union-no-base.json | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/qapi-schema/flat-union-no-base.err

[PATCH 02/28] tests/qapi-schema: Drop redundant flat-union-inline test

2021-03-23 Thread Markus Armbruster
flat-union-inline.json covers longhand branch definition with an invalid type value. It's redundant: longhand branch definition is covered by flat-union-inline-invalid-dict.json, and invalid type value is covered by nested-struct-data.json. Drop the test. Signed-off-by: Markus Armbruster --- t

[PATCH 14/28] qapi: Enforce type naming rules

2021-03-23 Thread Markus Armbruster
Type names should be CamelCase. Enforce this. The only offenders are in tests/. Fix them. Add test type-case to cover the new error. Signed-off-by: Markus Armbruster --- scripts/qapi/expr.py | 3 ++- tests/qapi-schema/doc-bad-union-member.json | 4 ++-- tes

[PATCH 09/28] qapi: Lift enum-specific code out of check_name_str()

2021-03-23 Thread Markus Armbruster
check_name_str() masks leading digits when passed enum_member=True. Only check_enum() does. Lift the masking into check_enum(). Signed-off-by: Markus Armbruster --- scripts/qapi/expr.py | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/scripts/qapi/ex

[PATCH 24/28] qapi: Enforce command naming rules

2021-03-23 Thread Markus Armbruster
Command names should be lower-case. Enforce this. Fix the fixable offenders (all in tests/), and add the remainder to pragma command-name-exceptions. Signed-off-by: Markus Armbruster --- docs/devel/qapi-code-gen.txt| 8 ++-- qapi/pragma.json| 18 +++

[PATCH 07/28] qapi: Fix to reject optional members with reserved names

2021-03-23 Thread Markus Armbruster
check_type() fails to reject optional members with reserved names, because it neglects to strip off the leading '*'. Fix that. The stripping in check_name_str() is now useless. Drop. Also drop the "no leading '*'" assertion, because valid_name.match() ensures it can't fail. Fixes: 9fb081e0b984

[PATCH 06/28] tests/qapi-schema: Tweak to demonstrate buggy member name check

2021-03-23 Thread Markus Armbruster
Member name 'u' and names starting with 'has-' or 'has_' are reserved for the generator. check_type() enforces this, covered by tests reserved-member-u and reserved-member-has. These tests neglect to cover optional members, where the name starts with '*'. Tweak reserved-member-u to fix that. Th

[PATCH 25/28] tests/qapi-schema: Switch member name clash test to struct

2021-03-23 Thread Markus Armbruster
Test args-name-clash covers command parameter name clash. This effectively covers struct member name clash as well. The next commit will make paramater name clash impossible. Convert args-name-clash from testing command to testing a struct, and rename it to struct-member-name-clash. Signed-off-

[PATCH 16/28] qapi: Factor out QAPISchemaParser._check_pragma_list_of_str()

2021-03-23 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- scripts/qapi/parser.py | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py index 116afe549a..8eed69333f 100644 --- a/scripts/qapi/parser.py +++ b/scripts/qapi/parser.py @@ -11

[PATCH 08/28] qapi: Support flat unions tag values with leading digit

2021-03-23 Thread Markus Armbruster
Flat union tag values get checked twice: as enum member name, and as union branch name. The former accepts leading digits, the latter doesn't. The restriction feels arbitrary. Skip the latter check. This can expose c_name() to input it can't handle: a name starting with a digit. Improve it to

[PATCH 10/28] qapi: Rework name checking in preparation of stricter checking

2021-03-23 Thread Markus Armbruster
Naming rules differ for the various kinds of names. To prepare enforcing them, define functions to check them: check_name_upper(), check_name_lower(), and check_name_camel(). For now, these merely wrap around check_name_str(), but that will change shortly. Replace the other uses of check_name_st

[PATCH 13/28] qapi: Enforce event naming rules

2021-03-23 Thread Markus Armbruster
Event names should be ALL_CAPS with words separated by underscore. Enforce this. The only offenders are in tests/. Fix them. Existing test event-case covers the new error. Signed-off-by: Markus Armbruster --- tests/unit/test-qmp-event.c | 6 +++--- scripts/qapi/expr.py

[PATCH 22/28] qapi: Prepare for rejecting underscore in command and member names

2021-03-23 Thread Markus Armbruster
Command names and member names within a type should be all lower case with words separated by a hyphen. We also accept underscore. Rework check_name_lower() to optionally reject underscores, but don't use that option, yet. Update expected test output for the changed error message. Signed-off-by

[PATCH 15/28] tests/qapi-schema: Rename redefined-builtin to redefined-predefined

2021-03-23 Thread Markus Armbruster
The previous commit changed this test to clash with a predefined enum type, not a built-in type. Adjust its name. Signed-off-by: Markus Armbruster --- tests/qapi-schema/meson.build | 2 +- tests/qapi-schema/redefined-builtin.err | 2 --

[PATCH 27/28] qapi: Enforce enum member naming rules

2021-03-23 Thread Markus Armbruster
Enum members should use '-', not '_'. Enforce this. Fix the fixable offenders (all in tests/), and add the remainder to pragma member-name-exceptions. Signed-off-by: Markus Armbruster --- qapi/pragma.json | 8 scripts/qapi/expr.py | 5 +++--

[PATCH 17/28] tests/qapi-schema: Rename pragma-*-crap to pragma-value-not-*

2021-03-23 Thread Markus Armbruster
Rename pragma-doc-required-crap to pragma-not-bool, pragma-returns-whitelist-crap to pragma-value-not-list, and pragma-name-case-whitelist-crap to pragma-value-not-list-of-str. Signed-off-by: Markus Armbruster --- tests/qapi-schema/meson.build | 6 +++--- tests/qapi

[PATCH 26/28] qapi: Enforce struct member naming rules

2021-03-23 Thread Markus Armbruster
Struct members, including command arguments, event data, and union inline base members, should use '-', not '_'. Enforce this. Fix the fixable offenders (all in tests/), and add the remainder to pragma member-name-exceptions. Signed-off-by: Markus Armbruster --- docs/devel/qapi-code-gen.txt

[PATCH 18/28] tests/qapi-schema: Rename returns-whitelist to returns-bad-type

2021-03-23 Thread Markus Armbruster
This test covers returning "bad" types. Pragma returns-whitelist is just one aspect. Naming it returns-whitelist is suboptimal. Rename to returns-bad-type. Signed-off-by: Markus Armbruster --- tests/qapi-schema/meson.build | 2 +- tests/qapi-schema/returns-ba

[PATCH 28/28] qapi: Enforce union and alternate branch naming rules

2021-03-23 Thread Markus Armbruster
Union branche names should use '-', not '_'. Enforce this. The only offenders are in tests/. Fix them. Signed-off-by: Markus Armbruster --- scripts/qapi/expr.py| 4 ++-- tests/qapi-schema/alternate-clash.err | 2 +- tests/qapi-schema/alternate-clash.json | 6

[PATCH 23/28] qapi: Enforce feature naming rules

2021-03-23 Thread Markus Armbruster
Feature names should use '-', not '_'. Enforce this. Signed-off-by: Markus Armbruster --- scripts/qapi/expr.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py index ce37b426c9..01a994412d 100644 --- a/scripts/qapi/expr.py +++ b/scr

[PATCH 21/28] tests-qmp-cmds: Drop unused and incorrect qmp_TestIfCmd()

2021-03-23 Thread Markus Armbruster
Commit 967c885108 "qapi: add 'if' to top-level expressions" added command TestIfCmd with an 'if' condition. It also added the qmp_TestIfCmd() to go with it, guarded by the corresponding #if. Commit ccadd6bcba "qapi: Add 'if' to implicit struct members" changed the command, but not the function. C

[PATCH 12/28] qapi: Consistently permit any case in downstream prefixes

2021-03-23 Thread Markus Armbruster
We require lowercase __RFQDN_ downstream prefixes only where we require the prefixed name to be lowercase. Don't; permit any case in __RFQDN_ prefixes anywhere. Signed-off-by: Markus Armbruster --- scripts/qapi/expr.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/

[PATCH 19/28] qapi: Rename pragma *-whitelist to *-exceptions

2021-03-23 Thread Markus Armbruster
Rename pragma returns-whitelist to command-returns-exceptions, and name-case-whitelist to member-name-case-exceptions. Signed-off-by: Markus Armbruster --- docs/devel/qapi-code-gen.txt | 21 ++- qapi/pragma.json | 4 ++-- qga/qapi-sc

Re: [PATCH v2] docs: simplify each section title

2021-03-23 Thread Daniel P . Berrangé
On Tue, Mar 23, 2021 at 11:47:04AM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Now that we merged into one doc, it makes the nav looks nicer. > > Signed-off-by: Marc-André Lureau > --- > v2: > - Developers -> Developer Information (suggested by Peter) > > docs/dev

Re: [PATCH V4 2/7] qapi/net.json: Add L4_Connection definition

2021-03-23 Thread Markus Armbruster
"Zhang, Chen" writes: >> -Original Message- >> From: Markus Armbruster [...] >> Naming the argument type L4_Connection is misleading. >> >> Even naming the match arguments L4_Connection would be misleading. >> "Connection" has a specific meaning in networking. There are TCP >> connecti

Re: [PATCH] yank: Avoid linking into executables that don't want it

2021-03-23 Thread Markus Armbruster
Thomas Huth writes: > On 16/03/2021 14.59, Markus Armbruster wrote: >> util/yank.c and stubs/yank.c are both in libqemuutil.a, even though >> their external symbols conflict. The linker happens to pick the >> former. This links a bunch of unneeded code into the executables that >> actually want

Re: [PATCH V4 3/7] qapi/net: Add new QMP command for COLO passthrough

2021-03-23 Thread Markus Armbruster
"Zhang, Chen" writes: >> -Original Message- >> From: Markus Armbruster [...] >> Now let's look at colo-passthrough-del. I figure it is for deleting the >> kind of >> things colo-passthrough-add adds. >> > > Yes. > >> What exactly is deleted? The thing created with the exact same argu

[PATCH] block: Remove monitor command block_passwd

2021-03-23 Thread Markus Armbruster
Command block_passwd always fails since Commit c01c214b69 "block: remove all encryption handling APIs" (v2.10.0) turned block_passwd into a stub that always fails, and hardcoded encryption_key_missing to false in query-named-block-nodes and query-block. Commit ad1324e044 "block: remove 'encryptio

Re: [PATCH v4] sphinx: adopt kernel readthedoc theme

2021-03-23 Thread Daniel P . Berrangé
On Mon, Mar 22, 2021 at 02:52:34PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The default "alabaster" sphinx theme has a couple shortcomings: > - the navbar moves along the page > - the search bar is not always at the same place > - it lacks some contrast and colours

Re: [PATCH] block: Remove monitor command block_passwd

2021-03-23 Thread Daniel P . Berrangé
On Tue, Mar 23, 2021 at 11:19:51AM +0100, Markus Armbruster wrote: > Command block_passwd always fails since > > Commit c01c214b69 "block: remove all encryption handling APIs" > (v2.10.0) turned block_passwd into a stub that always fails, and > hardcoded encryption_key_missing to false in query-na

Re: [PULL 0/7] SD/MMC patches for 2021-03-21

2021-03-23 Thread Peter Maydell
On Mon, 22 Mar 2021 at 17:23, Philippe Mathieu-Daudé wrote: > > The following changes since commit b184750926812cb78ac0caf4c4b2b13683b5bde3: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (2021-03-22 11:24:55 +) > > are available in the Git reposito

Re: [PULL 00/20] pc,virtio,pci: fixes, features

2021-03-23 Thread Peter Maydell
On Mon, 22 Mar 2021 at 22:56, Michael S. Tsirkin wrote: > On Mon, Mar 22, 2021 at 06:46:06PM +, Peter Maydell wrote: > > This happens because pm_update_sci() calls pci_irq_handler(), > > which calls pci_intx(pci_dev), which returns -1, which is not > > a valid interrupt number to call pci_irq_

Re: [PATCH] hw/pci-host/gpex: Don't fault for unmapped parts of MMIO and PIO windows

2021-03-23 Thread Peter Maydell
On Mon, 22 Mar 2021 at 22:35, Michael S. Tsirkin wrote: > > On Mon, Mar 22, 2021 at 08:13:36PM +, Peter Maydell wrote: > > Currently the gpex PCI controller implements no special behaviour for > > guest accesses to areas of the PIO and MMIO where it has not mapped > > any PCI devices, which me

Re: [PATCH v4] sphinx: adopt kernel readthedoc theme

2021-03-23 Thread Peter Maydell
On Tue, 23 Mar 2021 at 10:27, Daniel P. Berrangé wrote: > > On Mon, Mar 22, 2021 at 02:52:34PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > The default "alabaster" sphinx theme has a couple shortcomings: > > - the navbar moves along the page > > - the search bar i

[Bug 1880518] Re: issue while installing docker inside s390x container

2021-03-23 Thread Nayana
As we are facing issue with service docker start ( for docker in docker s390x container under qemu) time="2021-03-23T07:29:07.645278866Z" level=warning msg="Running modprobe nf_nat failed with message: ``, error: exec: \"modprobe\": executable file not found in $PATH" time="2021-03-23T07:29:07.6

Re: [PATCH v4] sphinx: adopt kernel readthedoc theme

2021-03-23 Thread Marc-André Lureau
Hi On Tue, Mar 23, 2021 at 2:28 PM Daniel P. Berrangé wrote: > On Mon, Mar 22, 2021 at 02:52:34PM +0400, marcandre.lur...@redhat.com > wrote: > > From: Marc-André Lureau > > > > The default "alabaster" sphinx theme has a couple shortcomings: > > - the navbar moves along the page > > - the searc

[PATCH] qcow2: use external virtual timers

2021-03-23 Thread Pavel Dovgalyuk
Regular virtual timers are used to emulate timings related to vCPU and peripheral states. QCOW2 uses timers to clean the cache. These timers should have external flag. In the opposite case they affect the execution and it can't be recorded and replayed. This patch adds external flag to the timer fo

Re: [PATCH v4] sphinx: adopt kernel readthedoc theme

2021-03-23 Thread Marc-André Lureau
Hi On Tue, Mar 23, 2021 at 3:01 PM Peter Maydell wrote: > On Tue, 23 Mar 2021 at 10:27, Daniel P. Berrangé > wrote: > > > > On Mon, Mar 22, 2021 at 02:52:34PM +0400, marcandre.lur...@redhat.com > wrote: > > > From: Marc-André Lureau > > > > > > The default "alabaster" sphinx theme has a couple

[Bug 1920784] Re: qemu-system-ppc64le fails with kvm acceleration

2021-03-23 Thread Christian Ehrhardt 
Hi Sadoon, thanks for the report! There isn't much to find about this issue yet. One automatic syscaller crash report [1]. On the emulation side there is [2][3]. On the glibc side we have [4][5] adding the use of it with [6] being a fix. All those seem to be in glibc 2.33 - so I'd expect with [6]

[Bug 1920784] Re: qemu-system-ppc64le fails with kvm acceleration

2021-03-23 Thread Christian Ehrhardt 
Since this seems to be broken on all Distributions as soon as the triggering combination of kernel/glibc is present I think we'd want to open that up to upstream qemu for a wider discussion and to also hit the ppc64 architecture experts. Furthermore I'm not entirely sure if this needs to be fixed

[Bug 1920784] Re: qemu-system-ppc64le fails with kvm acceleration

2021-03-23 Thread Christian Ehrhardt 
[10] outlined to use PPC_FEATURE2_SCV but [4] does just that. In addition [6] added power9 machine settings as only on this ISA it is available - like: + .machine "push" + .machine "power9" scv 0 + .machine "pop" Maybe there is some generated "scv 0" left that needs t

[Bug 1920784] Re: qemu-system-ppc64le fails with kvm acceleration

2021-03-23 Thread Christian Ehrhardt 
qemu calls this ioctl on ppc64 as: sysdeps/unix/sysv/linux/powerpc/ioctl.c result = INLINE_SYSCALL (ioctl, 3, fd, request, arg); The mapping of macros in sysdeps/unix/sysv/linux/powerpc/sysdep.h seems to be: INTERNAL_SYSCALL -> INTERNAL_SYSCALL_NCS -> TRY_SYSCALL_SCV -> SYSCALL_SCV 76 #define

[PATCH] hw/block/nvme: remove description for zoned.append_size_limit

2021-03-23 Thread Niklas Cassel
From: Niklas Cassel The description was originally removed in commit 578d914b263c ("hw/block/nvme: align zoned.zasl with mdts") together with the removal of the zoned.append_size_limit parameter itself. However, it was (most likely accidentally), re-added in commit f7dcd31885cb ("hw/block/nvme:

Re: [PATCH] hw/block/nvme: remove description for zoned.append_size_limit

2021-03-23 Thread Klaus Jensen
On Mar 23 11:18, Niklas Cassel wrote: > From: Niklas Cassel > > The description was originally removed in commit 578d914b263c > ("hw/block/nvme: align zoned.zasl with mdts") together with the removal > of the zoned.append_size_limit parameter itself. > > However, it was (most likely accidentally

[Bug 1920784] Re: qemu-system-ppc64le fails with kvm acceleration

2021-03-23 Thread Frank Heimes
** Also affects: ubuntu-power-systems Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1920784 Title: qemu-system-ppc64le fails with kvm acceleration Statu

Re: [PATCH v4] sphinx: adopt kernel readthedoc theme

2021-03-23 Thread Daniel P . Berrangé
On Tue, Mar 23, 2021 at 11:00:29AM +, Peter Maydell wrote: > On Tue, 23 Mar 2021 at 10:27, Daniel P. Berrangé wrote: > > > > On Mon, Mar 22, 2021 at 02:52:34PM +0400, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > The default "alabaster" sphinx theme has a couple

[Bug 1920784] Re: qemu-system-ppc64le fails with kvm acceleration

2021-03-23 Thread Christian Ehrhardt 
As my other repro-code didn't trigger the issue I looked at qemu again and found that before the failing ioctl->scv call there are plenty other even some very similar (same?) calls that work just fine. I wonder if on guest setup qemu (or e.g. the rom we load) might set some arch-bits or such which

Re: [PATCH v4] sphinx: adopt kernel readthedoc theme

2021-03-23 Thread Peter Maydell
On Tue, 23 Mar 2021 at 11:29, Daniel P. Berrangé wrote: > The theme is pre-packaged for Fedora, Debian, Ubuntu, which gives me > confidence for Linux distros in general. > > BSD / macOS / Windows, who knows ? Mmm, good point. Marc-André's the one who's been doing the work here, so I'm happy to le

Re: [PATCH v4] sphinx: adopt kernel readthedoc theme

2021-03-23 Thread Marc-André Lureau
Hi On Tue, Mar 23, 2021 at 3:36 PM Peter Maydell wrote: > On Tue, 23 Mar 2021 at 11:29, Daniel P. Berrangé > wrote: > > The theme is pre-packaged for Fedora, Debian, Ubuntu, which gives me > > confidence for Linux distros in general. > > > > BSD / macOS / Windows, who knows ? > > Mmm, good poin

[PATCH v5] sphinx: adopt kernel readthedoc theme

2021-03-23 Thread marcandre . lureau
From: Marc-André Lureau The default "alabaster" sphinx theme has a couple shortcomings: - the navbar moves along the page - the search bar is not always at the same place - it lacks some contrast and colours The "rtd" theme from readthedocs.org is a popular third party theme used notably by the

[Bug 1920913] [NEW] Openjdk11+ fails to install on s390x

2021-03-23 Thread Namrata Bhave
Public bug reported: While installing openjdk11 or higher from repo, it crashes while configuring ca-certificates-java. Although `java -version` passes, `jar -version` crashes. Detailed logs attached to this issue. ``` # A fatal error has been detected by the Java Runtime Environment: # # SIGI

[PULL 1/1] xen-block: Fix removal of backend instance via xenstore

2021-03-23 Thread Anthony PERARD via
Whenever a Xen block device is detach via xenstore, the image associated with it remained open by the backend QEMU and an error is logged: qemu-system-i386: failed to destroy drive: Node xvdz-qcow2 is in use This happened since object_unparent() doesn't immediately frees the object and thus ke

[PULL 0/1] xen queue 2021-03-23

2021-03-23 Thread Anthony PERARD via
.git tags/pull-xen-20210323 for you to fetch changes up to b807ca3fa0ca29ec015adcf4045e716337cd3635: xen-block: Fix removal of backend instance via xenstore (2021-03-23 11:18:20 +) Xen patch - Fix Xen backend block detach vi

Re: [PULL 0/1] xen queue 2021-03-23

2021-03-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210323120439.563855-1-anthony.per...@citrix.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210323120439.563855-1-anthony.per...@citrix.com Subject: [PULL 0/1] xen queue 20

Re: [PATCH v2] docs: simplify each section title

2021-03-23 Thread John Snow
On 3/23/21 3:47 AM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Now that we merged into one doc, it makes the nav looks nicer. Signed-off-by: Marc-André Lureau Reviewed-by: John Snow --- v2: - Developers -> Developer Information (suggested by Peter) docs/devel/index.r

Re: [PATCH] i386/cpu_dump: support AVX512 ZMM regs dump

2021-03-23 Thread Richard Henderson
On 3/23/21 1:00 AM, Robert Hoo wrote: On Mon, 2021-03-22 at 15:06 -0600, Richard Henderson wrote: On 3/22/21 4:59 AM, Robert Hoo wrote: Since commit fa4518741e (target-i386: Rename struct XMMReg to ZMMReg), CPUX86State.xmm_regs[] has already been extended to 512bit to support AVX512. Also, othe

[Bug 1920913] Re: Openjdk11+ fails to install on s390x

2021-03-23 Thread Peter Maydell
You don't say how you're invoking QEMU (system emulation? usermode? what command line?) Please give the full commandline, repro steps, and any files/images we would need to reproduce the failure. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [PATCH v5] sphinx: adopt kernel readthedoc theme

2021-03-23 Thread Thomas Lamprecht
On 23.03.21 12:53, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > Just saw this patch by accident and as we also use the alabaster theme for the Proxmox Backup project I wanted to share some insights from our usage, as I checked that theme out closely a few months ago and did som

Re: [PATCH] hw/display/bcm2835_fb: Remove DeviceReset() call in DeviceRealize()

2021-03-23 Thread Peter Maydell
On Sat, 13 Mar 2021 at 17:01, Philippe Mathieu-Daudé wrote: > > When QDev objects have their DeviceReset handler set, they > shouldn't worry about calling it at realization stage (it > is handled by hw/core/qdev.c::device_set_realized). > > Remove the pointless/confusing bcm2835_fb_reset() call. >

Re: [PATCH v5] sphinx: adopt kernel readthedoc theme

2021-03-23 Thread Marc-André Lureau
Hi On Tue, Mar 23, 2021 at 4:27 PM Thomas Lamprecht wrote: > On 23.03.21 12:53, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Just saw this patch by accident and as we also use the alabaster theme > for the Proxmox Backup project I wanted to share some insights from our

Re: "make check" broken with everything but tools disabled

2021-03-23 Thread Claudio Fontana
On 3/18/21 11:03 AM, Paolo Bonzini wrote: > On 18/03/21 10:16, Claudio Fontana wrote: >> my experience with the new build system (meson-based), is that I have to do: >> >> make >> >> first, and then >> >> make check >> >> later, or bugs start happening > > This shouldn't be needed. > > Paolo >

Re: [PATCH] qcow2: use external virtual timers

2021-03-23 Thread Paolo Bonzini
On 23/03/21 12:08, Pavel Dovgalyuk wrote: Regular virtual timers are used to emulate timings related to vCPU and peripheral states. QCOW2 uses timers to clean the cache. These timers should have external flag. In the opposite case they affect the execution and it can't be recorded and replayed. T

Re: [PATCH 1/1] Set TARGET_PAGE_BITS to be 10 instead of 8 bits

2021-03-23 Thread Dr. David Alan Gilbert
* Michael Rolnik (mrol...@gmail.com) wrote: > Signed-off-by: Michael Rolnik > --- > target/avr/cpu-param.h | 8 +--- > target/avr/helper.c| 2 -- > 2 files changed, 1 insertion(+), 9 deletions(-) > > diff --git a/target/avr/cpu-param.h b/target/avr/cpu-param.h > index 7ef4e7c679..9765a9d

Re: [PATCH 01/28] qapi/pragma: Tidy up after removal of deprecated commands

2021-03-23 Thread John Snow
On 3/23/21 5:39 AM, Markus Armbruster wrote: Commit cbde7be900 "migrate: remove QMP/HMP commands for speed, downtime and cache size" neglected to remove query-migrate-cache-size from pragma returns-whitelist. Commit 8af54b9172 "machine: remove 'query-cpus' QMP command" neglected to remove CpuInf

[Bug 1920913] Re: Openjdk11+ fails to install on s390x

2021-03-23 Thread Namrata Bhave
Please find below steps to reproduce the issue(Running on amd64 VM): ``` apt-get install -y qemu qemu-user-static docker run --rm --privileged multiarch/qemu-user-static --reset -p yes docker run -it s390x/ubuntu:20.04 bash --> apt-get update && apt-get install -y openjdk-11-jdk jar --version

Re: [PATCH] docs/system/generic-loader.rst: Fix style

2021-03-23 Thread Alistair Francis
On Mon, Mar 22, 2021 at 3:40 PM Axel Heider wrote: > > Fix style to have a proper description of the parameter 'force-raw'. > > Signed-off-by: Axel Heider Reviewed-by: Alistair Francis Alistair > --- > docs/system/generic-loader.rst | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletio

Re: [PATCH v7 1/8] vt82c686: Implement control of serial port io ranges via config regs

2021-03-23 Thread BALATON Zoltan
On Wed, 10 Mar 2021, BALATON Zoltan wrote: In VIA super south bridge the io ranges of superio components (parallel and serial ports and FDC) can be controlled by superio config registers to set their base address and enable/disable them. This is not easy to implement in QEMU because ISA emulation

Re: [PATCH 02/28] tests/qapi-schema: Drop redundant flat-union-inline test

2021-03-23 Thread John Snow
On 3/23/21 5:39 AM, Markus Armbruster wrote: flat-union-inline.json covers longhand branch definition with an invalid type value. It's redundant: longhand branch definition is covered by flat-union-inline-invalid-dict.json, and invalid type value is covered by nested-struct-data.json. Drop the

Re: [PATCH v8] drivers/misc: sysgenid: add system generation id driver

2021-03-23 Thread Greg KH
On Mon, Mar 08, 2021 at 05:03:58PM +0100, Alexander Graf wrote: > > > On 08.03.21 15:36, Greg KH wrote: > > > > On Mon, Mar 08, 2021 at 04:18:03PM +0200, Adrian Catangiu wrote: > > > +static struct miscdevice sysgenid_misc = { > > > + .minor = MISC_DYNAMIC_MINOR, > > > + .name = "sysgeni

Re: [External] Re: [RFC PATCH 0/9] Support for Virtio-fs daemon crash reconnection

2021-03-23 Thread Christian Schoenebeck
On Montag, 22. März 2021 11:54:56 CET Stefan Hajnoczi wrote: > > > Thanks, Christian. I am still trying to figure out the details of the > > > ROP > > > attacks. > > > > > > However, QEMU's vhost-user reconnection is based on chardev socket > > > reconnection. The socket reconnection can be enable

Re: [PATCH v10 0/7] Pegasos2 emulation

2021-03-23 Thread BALATON Zoltan
On Tue, 23 Mar 2021, David Gibson wrote: On Wed, Mar 17, 2021 at 02:17:51AM +0100, BALATON Zoltan wrote: Hello, This is adding a new PPC board called pegasos2. More info on it can be found at: https://osdn.net/projects/qmiga/wiki/SubprojectPegasos2 Currently it needs a firmware ROM image that

Re: [PATCH 03/28] tests/qapi-schema: Rework comments on longhand member definitions

2021-03-23 Thread John Snow
On 3/23/21 5:40 AM, Markus Armbruster wrote: +# event 'data' member with dict value is (longhand) argument +# definition, not inline complex type I have to be a weenie and say I don't know exactly what this comment is telling me. (1) What's a longhand argument? (2) What's an inline complex t

Re: [PATCH v10 7/7] hw/ppc: Add emulation of Genesi/bPlan Pegasos II

2021-03-23 Thread BALATON Zoltan
On Tue, 23 Mar 2021, David Gibson wrote: On Wed, Mar 17, 2021 at 02:17:51AM +0100, BALATON Zoltan wrote: Add new machine called pegasos2 emulating the Genesi/bPlan Pegasos II, a PowerPC board based on the Marvell MV64361 system controller and the VIA VT8231 integrated south bridge/superio chips.

[PATCH 1/4] qemu-iotests: allow passing unittest.main arguments to the test scripts

2021-03-23 Thread Paolo Bonzini
Python test scripts that use unittest consist of multiple tests. unittest.main allows selecting which tests to run, but currently this is not possible because the iotests wrapper ignores sys.argv. unittest.main command line options also allow the user to pick the desired options for verbosity, fai

[PATCH 0/4] qemu-iotests: quality of life improvements

2021-03-23 Thread Paolo Bonzini
This series adds a few usability improvements to qemu-iotests, in particular: - arguments can be passed to Python unittests scripts, for example to run only a subset of the test cases (patch 1) - it is possible to do "./check -- ../../../tests/qemu-iotests/055 args..." and specify arbitrary a

[PATCH 4/4] qemu-iotests: fix case of SOCK_DIR already in the environment

2021-03-23 Thread Paolo Bonzini
Due to a typo, in this case the SOCK_DIR was not being created. Signed-off-by: Paolo Bonzini --- tests/qemu-iotests/testenv.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/testenv.py b/tests/qemu-iotests/testenv.py index 6767eeeb25..169268f61a 100644 ---

  1   2   3   4   5   6   >