On 19.03.2021 13:34, Philippe Mathieu-Daudé wrote:
Hi Pavel,
The "normal" test_mips_malta timeouted on acceptance-system-fedora job:
(23/36)
tests/acceptance/replay_kernel.py:ReplayKernelNormal.test_mips_malta:
INTERRUPTED: Test interrupted by SIGTERM\nRunner error occurred: Timeout
reached\n
在 2021/3/17 下午2:26, Bin Meng 写道:
The minimum Ethernet frame length is 60 bytes. For short frames with
smaller length like ARP packets (only 42 bytes), on a real world NIC
it can choose either padding its length to the minimum required 60
bytes, or sending it out directly to the wire. Such behav
在 2021/3/11 上午2:31, Philippe Mathieu-Daudé 写道:
I had a look at the patch from Miroslav trying to silence a
compiler warning which in fact is a nasty bug. Here is a fix.
https://www.mail-archive.com/qemu-devel@nongnu.org/msg772735.html
Since v5:
- addressed Stefano's review comments:
- add now
On Mon, 22 Mar 2021 06:20:50 +0100
Thomas Huth wrote:
> On 22/03/2021 00.31, Lukas Straub wrote:
> > Use the normal yank code instead of stubs in relevant tests to
> > increase coverage and to ensure that registering and unregistering
> > of yank instances and functions is done correctly.
> >
>
From: Bin Meng
Since HSS commit c20a89f8dcac, the Icicle Kit reference design has
been updated to use a register mapped at 0x4f00 instead of a
GPIO to control whether eMMC or SD card is to be used. With this
support the same HSS image can be used for both eMMC and SD card
boot flow, while pre
From: Bin Meng
This adds the documentation to describe what is supported for the
'microchip-icicle-kit' machine, and how to boot the machine in QEMU.
Signed-off-by: Bin Meng
---
docs/system/riscv/microchip-icicle-kit.rst | 89 ++
docs/system/target-riscv.rst
Hi Richard and Paolo,
On 3/22/21 5:23 AM, Richard Henderson wrote:
On 3/21/21 11:46 AM, Paolo Bonzini wrote:
HRM, what about biting the bullet and making exec-vary.c a C++ source?... Then
instead of making it conditional an attribute((alias)), we make it conditional
on having a C++ compiler.
On Fri, Mar 12, 2021 at 09:12:53AM +0100, Markus Armbruster wrote:
> David Gibson writes:
>
> > On Thu, Mar 11, 2021 at 05:50:42PM -0300, Daniel Henrique Barboza wrote:
> >>
> >>
> >> On 3/9/21 3:22 AM, Markus Armbruster wrote:
> >> > Cc: Paolo and Julia in addition to Igor, because the thread
On Fri, Mar 12, 2021 at 08:38:47AM -0500, Laine Stump wrote:
> On 3/11/21 8:19 PM, David Gibson wrote:
> > On Thu, Mar 11, 2021 at 05:50:42PM -0300, Daniel Henrique Barboza wrote:
> > >
> > >
> > > On 3/9/21 3:22 AM, Markus Armbruster wrote:
> > > > Cc: Paolo and Julia in addition to Igor, becaus
On Mon, Mar 22, 2021 at 3:31 AM Lukas Straub wrote:
> Add tests for yank with the chardev-change case.
>
> Signed-off-by: Lukas Straub
> ---
> MAINTAINERS| 1 +
> tests/unit/meson.build | 3 +-
> tests/unit/test-yank.c | 240 +
> 3 files c
On Fri, Mar 19, 2021 at 03:48:42PM +0400, Marc-André Lureau wrote:
> Hi Gerd
>
> On Fri, Mar 19, 2021 at 3:22 PM Gerd Hoffmann wrote:
>
> > Currently we have one virtio-gpu device. Problem with this approach is
> > that if you compile a full-featured qemu you'll get a virtio-gpu device
> > whic
ping!
On 11.03.2021 11:10, Denis Plotnikov wrote:
Commit a1a20d06b73e "vhost-user-blk: delay vhost_user_blk_disconnect"
introduced postponing vhost_dev cleanup aiming to eliminate qemu aborts
because of connection problems with vhost-blk daemon.
However, it introdues a new problem. Now, any co
The check for `n->namespace.blkconf.blk` always fails because
this is in the initialization function.
Signed-off-by: Joelle van Dyne
---
hw/block/nvme.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 6842b01ab5..42605fc55d 1006
On 3/22/21 8:15 AM, Richard Henderson wrote:
In bbc17caf81f, we used an alias attribute to allow target_page
to be declared const, and yet be initialized late.
This fails when using LTO with several versions of gcc.
The compiler looks through the alias and decides that the const
variable is stat
Hi
On Mon, Mar 22, 2021 at 3:32 AM Lukas Straub wrote:
> When changing from chardev-socket (which supports yank) to
> chardev-socket again, it fails, because the new chardev attempts
> to register a new yank instance. This in turn fails, as there
> still is the yank instance from the current cha
On Mon, Mar 22, 2021 at 3:31 AM Lukas Straub wrote:
> Always pass the id to chardev_new, since it is needed to register
> the yank instance for the chardev. Also, after checking that
> nothing calls chardev_new with id=NULL, assert() that id!=NULL.
>
> This fixes a crash when using chardev-change
20.03.2021 12:32, Patrik Janoušek wrote:
Current implementation of dirty bitmaps for raw format is very
limited, because those bitmaps cannot be persistent. Basically it
makes sense, because the raw format doesn't have space where could
be dirty bitmap stored when QEMU is offline. This patch solv
Hi
On Mon, Mar 22, 2021 at 3:31 AM Lukas Straub wrote:
> Move object_property_try_add_child out of chardev_new into it's
> callers. This is a preparation for the next patches to fix yank
> with the chardev-change case.
>
> Signed-off-by: Lukas Straub
> ---
> chardev/char.c | 42 +++
Hi Patrik!
20.03.2021 12:32, Patrik Janoušek wrote:
Currently, QEMU doesn't support persistent dirty bitmaps for raw format
That's right, we don't have such feature now.
and also dirty bitmaps are for internal use only, and cannot be accessed
using third-party applications.
And that's is n
Hello, thank you for the quick reply.
On 3/22/21 9:29 AM, Vladimir Sementsov-Ogievskiy wrote:
> Hi Patrik!
>
> 20.03.2021 12:32, Patrik Janoušek wrote:
>> Currently, QEMU doesn't support persistent dirty bitmaps for raw format
>
> That's right, we don't have such feature now.
>
>> and also dirty b
20.03.2021 12:32, Patrik Janoušek wrote:
Currently, dirty bitmaps are for internal use only
As I said, that's not correct: for external use we have bitmap export through
NBD protocol.
Protocol description is here
https://github.com/NetworkBlockDevice/nbd/blob/master/doc/proto.md (you need
Hi Peter,
On 2021/3/11 4:33, Peter Xu wrote:
> KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2 is for KVM_CLEAR_DIRTY_LOG, which is only
> useful for KVM_GET_DIRTY_LOG. Skip enabling it for kvm dirty ring.
>
> More importantly, KVM_DIRTY_LOG_INITIALLY_SET will not wr-protect all the
> pages
> initially, whic
These patches add a qtest for the vhost-user-blk server. CI found several
issues that caused these patches to be dropped from Michael Tsirkin and Kevin
Wolf's pull requests in the past. Hopefully they will go in smoothly this time!
Coiby Xu (1):
test: new qTest case to test the vhost-user-blk-se
From: Coiby Xu
This test case has the same tests as tests/virtio-blk-test.c except for
tests have block_resize. Since the vhost-user-blk export only serves one
client one time, two exports are started by qemu-storage-daemon for the
hotplug test.
Suggested-by: Thomas Huth
Signed-off-by: Coiby Xu
For Linux 5.10/5.11, qemu write zeros to a multipath device using
ioctl(fd, BLKZEROOUT, range) with cache none or directsync return -EBUSY
permanently. Fallback to pwritev instead of exit for -EBUSY error.
The issue was introduced in Linux 5.10:
https://git.kernel.org/pub/scm/linux/kernel/git/stab
Signed-off-by: Stefan Hajnoczi
Message-Id: <20210309094106.196911-4-stefa...@redhat.com>
Signed-off-by: Kevin Wolf
---
tests/qtest/vhost-user-blk-test.c | 81 +--
1 file changed, 76 insertions(+), 5 deletions(-)
diff --git a/tests/qtest/vhost-user-blk-test.c
b/tests
Exercise input validation code paths in
block/export/vhost-user-blk-server.c.
Signed-off-by: Stefan Hajnoczi
Message-Id: <20210309094106.196911-5-stefa...@redhat.com>
Signed-off-by: Kevin Wolf
---
tests/qtest/vhost-user-blk-test.c | 124 ++
1 file changed, 124 insert
Hi all! Accidentally we found on use-after-free. Normally user should
not remove bitmaps during migration.. But some wrong user actions may
simply lead to Qemu crash and that's not good.
Vladimir Sementsov-Ogievskiy (2):
migration/block-dirty-bitmap: make incoming disabled bitmaps busy
migrate
Check that we can't remove bitmaps being migrated on destination vm.
The new check proves that previous commit helps.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test | 10 ++
1 file changed, 10 insertions(+)
diff --git a/tests/qemu-
Incoming enabled bitmaps are busy, because we do
bdrv_dirty_bitmap_create_successor() for them. But disabled bitmaps
being migrated are not marked busy, and user can remove them during the
incoming migration. Then we may crash in cancel_incoming_locked() when
try to remove the bitmap that was alrea
On 3/22/21 9:24 AM, Joelle van Dyne wrote:
> The check for `n->namespace.blkconf.blk` always fails because
> this is in the initialization function.
This usually mean the code depends to some state only available
during the QOM 'realization' step, so this code should be in
nvme_realize(). Maybe in
> -Original Message-
> From: Markus Armbruster
> Sent: Saturday, March 20, 2021 12:03 AM
> To: Zhang, Chen
> Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Eric Blake ; Dr. David Alan
> Gilbert ; Li Zhijian ; Lukas
> Straub ; Zhang Chen
> Subject: Re: [PATCH V4 3/7] qapi/net: Add new Q
> -Original Message-
> From: Markus Armbruster
> Sent: Friday, March 19, 2021 11:47 PM
> To: Zhang, Chen
> Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Eric Blake ; Dr. David Alan
> Gilbert ; Li Zhijian ; Lukas
> Straub ; Zhang Chen
> Subject: Re: [PATCH V4 1/7] qapi/net.json: Add IP
> -Original Message-
> From: Markus Armbruster
> Sent: Friday, March 19, 2021 11:48 PM
> To: Zhang, Chen
> Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Eric Blake ; Dr. David Alan
> Gilbert ; Markus Armbruster ;
> Li Zhijian ; Lukas Straub ;
> Zhang Chen
> Subject: Re: [PATCH V4 2/7]
On 22.03.21 07:19, Klaus Jensen wrote:
From: Klaus Jensen
In nvme_format_ns(), if the namespace is of zero size (which might be
useless, but not invalid), the `count` variable will leak. Fix this by
returning early in that case.
When looking at the Coverity report, something else caught my ey
On 3/20/21 5:57 PM, Richard Henderson wrote:
> There's a change in mprotect() behaviour [1] in the latest macOS
> on M1 and it's not yet clear if it's going to be fixed by Apple.
>
> As a short-term fix, ignore failures setting up the guard pages.
>
> [1] https://gist.github.com/hikalium/75ae8224
Uses the new VGIC KVM device attribute to set the maintenance IRQ.
This is fixed to use IRQ 25(PPI 9), as a platform decision matching
the arm64 SBSA recommendation.
Signed-off-by: Haibo Xu
---
hw/intc/arm_gicv3_common.c | 1 +
hw/intc/arm_gicv3_kvm.c| 16
i
This series add support for ARMv8.3/8.4 nested virtualization support
in KVM mode. It's based on Marc Zyngier's kernel KVM patches[1], and
has been tested on a FVP model to run a L2 guest with Qemu. Now the
feature can be enabled by "-M virt,accel=kvm,virtualization=on" when
starting a VM.
[1]
ht
From: Bin Meng
For virtio-net, there is no need to pad the Ethernet frame size to
60 bytes before sending to it.
Signed-off-by: Bin Meng
Signed-off-by: Jason Wang
---
hw/net/virtio-net.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 96
From: Philippe Mathieu-Daudé
The 'offset' argument represents the offset to the ip6_ext_hdr
header, rename it as 'ext_hdr_offset'.
Reviewed-by: Stefano Garzarella
Reviewed-by: Miroslav Rezanina
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: Jason Wang
---
net/eth.c | 6 +++---
1 file
Add support for arm64 el2 in qemu KVM mode(nested virtualization).
This feature is disabled by default, just as that in TCG mode, and
can be enabled by "-M virt,accel=kvm,virtualization=on" when starting
a VM.
Signed-off-by: Haibo Xu
---
hw/arm/virt.c| 11 ---
target/arm/cpu.h
From: Philippe Mathieu-Daudé
The length field is already contained in the ip6_ext_hdr structure.
Check it direcly in eth_parse_ipv6_hdr() before calling
_eth_get_rss_ex_dst_addr(), which gets a bit simplified.
Reviewed-by: Miroslav Rezanina
Reviewed-by: Stefano Garzarella
Signed-off-by: Philip
On 3/20/21 3:15 PM, Reinoud Zandijk wrote:
> Hi,
>
> a quick question. I forgot to add my accel/stubs/nvmm-stub.h
Stub ending in .h? Suspicious... Rename it .c?
> to
> accel/stubs/meson.build but even when I disable NVMM explicitly or build it on
> a NetBSD platform that does not support NVMM,
+Wainer
On 3/19/21 11:44 AM, Philippe Mathieu-Daudé wrote:
> Hi Daniel,
>
> I'm getting this error sometimes in the check-dco job:
>
> Using docker image
> sha256:96fcfc3ceb2d65689c2918c1c501c45b2bd815d82e7fb3381048c9f252e7b046
> for registry.gitlab.com/philmd/qemu2/qemu/centos8:latest with dige
From: Philippe Mathieu-Daudé
Reviewed-by: Stefano Garzarella
Reviewed-by: Miroslav Rezanina
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: Jason Wang
---
net/eth.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/net/eth.c b/net/eth.c
index 5eb05bd..08
Signed-off-by: Haibo Xu
---
linux-headers/asm-arm64/kvm.h | 2 ++
linux-headers/linux/kvm.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/linux-headers/asm-arm64/kvm.h b/linux-headers/asm-arm64/kvm.h
index b6a0eaa32a..77b995a26c 100644
--- a/linux-headers/asm-arm64/kvm.h
+++ b/linux-h
The following changes since commit bdee969c0e65d4d509932b1d70e3a3b2ffbff6d5:
Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into
staging (2021-03-19 18:01:17 +)
are available in the git repository at:
https://github.com/jasowang/qemu.git tags/net-pull-request
f
From: Philippe Mathieu-Daudé
We can't know the caller read enough data in the memory pointed
by ext_hdr to cast it as a ip6_ext_hdr_routing.
Declare rt_hdr on the stack and fill it again from the iovec.
Since we already checked there is enough data in the iovec buffer,
simply add an assert() cal
From: Bin Meng
The minimum Ethernet frame length is 60 bytes. For short frames with
smaller length like ARP packets (only 42 bytes), on a real world NIC
it can choose either padding its length to the minimum required 60
bytes, or sending it out directly to the wire. Such behavior can be
hardcoded
From: Bin Meng
Add a helper to pad a short Ethernet frame to the minimum required
length, which can be used by backends' code.
Signed-off-by: Bin Meng
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Jason Wang
---
include/net/eth.h | 17 +
net/eth.c | 17 ++
From: Philippe Mathieu-Daudé
To simplify the function body, invert the if() statement, returning
earlier.
Since we already checked there is enough data in the iovec buffer,
simply add an assert() call to consume the bytes_read variable.
Reviewed-by: Stefano Garzarella
Reviewed-by: Miroslav Reza
From: Bin Meng
This adds a flag in NetClientState, so that a net client can tell
its peer that the packets do not need to be padded to the minimum
size of an Ethernet frame (60 bytes) before sending to it.
Signed-off-by: Bin Meng
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Jason Wang
-
From: Lukas Straub
Additional to removing the packet from the secondary queue,
we also need to free it.
Signed-off-by: Lukas Straub
Signed-off-by: Zhang Chen
Reviewed-by: Zhang Chen
Signed-off-by: Jason Wang
---
net/colo-compare.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/colo
This isn't silent: the log says:
BUILD multiboot.img
ld: Error: unable to disambiguate: -no-pie (did you mean --no-pie ?)
Which version of QEMU are you trying to build? Does this happen with
head-of-git ?
--
You received this bug notification because you are a member of qemu-
devel-ml, whic
From: Lukas Straub
g_queue_remove needs to look up the list entry first, but we
already have it as result and can remove it directly with
g_queue_delete_link.
Signed-off-by: Lukas Straub
Signed-off-by: Zhang Chen
Reviewed-by: Zhang Chen
Signed-off-by: Jason Wang
---
net/colo-compare.c | 2 +
From: Philippe Mathieu-Daudé
We want to check fields from ip6_ext_hdr_routing structure
and if correct read the full in6_address. Let's directly check
if our iovec contains enough data for everything, else return
early.
Suggested-by: Stefano Garzarella
Reviewed-by: Miroslav Rezanina
Signed-off
+Linaro folks
On 3/19/21 2:12 PM, Philippe Mathieu-Daudé wrote:
> Hi,
>
> I'm seeing an odd "GLib-FATAL-ERROR: GLib requires working
> CLOCK_MONOTONIC" error in the cross-i386-user job...
>
> The runner console output is:
>
> Running with gitlab-runner 13.9.0 (2ebc4dc4)
> Using Docker executor
From: Philippe Mathieu-Daudé
The in6_address comes after the ip6_ext_hdr_routing header,
not after the ip6_ext_hdr one. Fix the offset.
Cc: qemu-sta...@nongnu.org
Reported-by: Stefano Garzarella
Fixes: eb700029c78 ("net_pkt: Extend packet abstraction as required by e1000e
functionality")
Revie
On 3/22/21 9:41 AM, Vladimir Sementsov-Ogievskiy wrote:
> 20.03.2021 12:32, Patrik Janoušek wrote:
>> Current implementation of dirty bitmaps for raw format is very
>> limited, because those bitmaps cannot be persistent. Basically it
>> makes sense, because the raw format doesn't have space where c
Hi Connor,
On 3/15/21 3:08 PM, Connor Kuehl wrote:
> On 2/18/21 9:16 AM, Connor Kuehl wrote:
>> Connor Kuehl (2):
>> sev: use explicit indices for mapping firmware error codes to strings
>> sev: add missing firmware error conditions
>>
>> target/i386/sev.c | 48
On 3/16/21 2:13 PM, Peter Maydell wrote:
> Coverity reported (CID 1450831) an array overrun in
> gen_mxu_D16MAX_D16MIN():
>
> 1103 } else if (unlikely((XRb == 0) || (XRa == 0))) {
>
> 1112 if (opc == OPC_MXU_D16MAX) {
> 1113 tcg_gen_smax_i32(mxu_gpr[XRa - 1], t
On 3/17/21 2:12 AM, Jiaxun Yang wrote:
> Upstream kernel had removed both host[1] and guest[2] support.
>
> [1]:
> https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/commit/?id=45c7e8af4a5e3f0bea4ac209eea34118dd57ac64
> [2]:
> https://git.kernel.org/pub/scm/linux/kernel/git/mips/linu
Hi,
> > +if (vd->msgsize != msg->size + sizeof(*msg)) {
> > +/* FIXME: handle parse messages splitted into multiple chunks */
> > +fprintf(stderr, "%s: size mismatch: chunk %d, msg %d (+%zd)\n",
> > +__func__, vd->msgsize, msg->size, sizeof(*msg));
> >
>
> No
22.03.2021 13:18, Patrik Janoušek wrote:
On 3/22/21 9:41 AM, Vladimir Sementsov-Ogievskiy wrote:
20.03.2021 12:32, Patrik Janoušek wrote:
Current implementation of dirty bitmaps for raw format is very
limited, because those bitmaps cannot be persistent. Basically it
makes sense, because the raw
Hi,
On 20.03.21 11:01, Patrik Janoušek wrote:
I'm sorry, but I forgot to add you to the cc, so I'm forwarding the
patch to you additionally. I don't want to spam the mailing list
unnecessarily.
I think it’s better to still CC the list. It’s so full of mail, one
more won’t hurt. :)
(Re-add
On Mar 22 11:02, Max Reitz wrote:
> On 22.03.21 07:19, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > In nvme_format_ns(), if the namespace is of zero size (which might be
> > useless, but not invalid), the `count` variable will leak. Fix this by
> > returning early in that case.
>
> When lo
Hi Peter,
On 2021/3/11 4:32, Peter Xu wrote:
> Per-kml slots_lock will bring some trouble if we want to take all slots_lock
> of
> all the KMLs, especially when we're in a context that we could have taken some
> of the KML slots_lock, then we even need to figure out what we've taken and
> what we
On Mon, Mar 22, 2021 at 10:07:26AM +, Haibo Xu wrote:
> Add support for arm64 el2 in qemu KVM mode(nested virtualization).
> This feature is disabled by default, just as that in TCG mode, and
> can be enabled by "-M virt,accel=kvm,virtualization=on" when starting
> a VM.
>
> Signed-off-by: Hai
On Thu, Mar 11, 2021 at 07:53:53PM +0100, Eugenio Perez Martin wrote:
> On Fri, Jan 22, 2021 at 7:18 PM Eugenio Perez Martin
> wrote:
> >
> > On Thu, Dec 10, 2020 at 12:55 PM Stefan Hajnoczi
> > wrote:
> > >
> > > On Wed, Dec 09, 2020 at 07:41:23PM +0100, Eugenio Perez Martin wrote:
> > > > On T
From: Marc-André Lureau
The default "alabaster" sphinx theme has a couple shortcomings:
- the navbar moves along the page
- the search bar is not always at the same place
- it lacks some contrast and colours
The "rtd" theme from readthedocs.org is a popular third party theme used
notably by the
On Thu, 18 Mar 2021 at 09:30, Daniel P. Berrangé wrote:
>
> Remove many old deprecated features
>
> The following features have been deprecated for well over the 2
> release cycle we promise
>
> ``-drive file=json:{...{'driver':'fi
On Fri, Mar 19, 2021 at 11:44:24AM +0100, Philippe Mathieu-Daudé wrote:
> Hi Daniel,
>
> I'm getting this error sometimes in the check-dco job:
>
> Using docker image
> sha256:96fcfc3ceb2d65689c2918c1c501c45b2bd815d82e7fb3381048c9f252e7b046
> for registry.gitlab.com/philmd/qemu2/qemu/centos8:late
On Fri, Mar 19, 2021 at 7:25 PM Stefano Garzarella wrote:
>
> On Fri, Mar 19, 2021 at 7:20 PM Stefano Garzarella
> wrote:
> >
> > On Fri, Mar 19, 2021 at 06:52:39PM +0100, Paolo Bonzini wrote:
> > >It's likely that the compiler will online it. But indeed it's better to add
> > >-minline-all-stri
Since commit fa4518741e (target-i386: Rename struct XMMReg to ZMMReg),
CPUX86State.xmm_regs[] has already been extended to 512bit to support
AVX512.
Also, other qemu level supports for AVX512 registers are there for
years.
But in x86_cpu_dump_state(), still only dump XMM registers.
This patch is ju
On Thu, Mar 18, 2021 at 12:58:46PM +0100, Christian Schoenebeck wrote:
> On Mittwoch, 17. März 2021 13:57:47 CET Jiachen Zhang wrote:
> > On Wed, Mar 17, 2021 at 7:50 PM Christian Schoenebeck <
> >
> > qemu_...@crudebyte.com> wrote:
> > > On Mittwoch, 17. März 2021 11:05:32 CET Stefan Hajnoczi wro
On Wed, Mar 17, 2021 at 08:32:31PM +0800, Jiachen Zhang wrote:
> On Wed, Mar 17, 2021 at 6:05 PM Stefan Hajnoczi wrote:
> > On Fri, Dec 18, 2020 at 05:39:34PM +0800, Jiachen Zhang wrote:
> I agreed with you that a virtiofsd must be launched by a software like
> systemd. So we are planning to defin
Hi
On Mon, Mar 22, 2021 at 2:52 PM wrote:
> From: Marc-André Lureau
>
> The default "alabaster" sphinx theme has a couple shortcomings:
> - the navbar moves along the page
> - the search bar is not always at the same place
> - it lacks some contrast and colours
>
> The "rtd" theme from readthed
On 22.03.21 11:48, Klaus Jensen wrote:
On Mar 22 11:02, Max Reitz wrote:
On 22.03.21 07:19, Klaus Jensen wrote:
From: Klaus Jensen
In nvme_format_ns(), if the namespace is of zero size (which might be
useless, but not invalid), the `count` variable will leak. Fix this by
returning early in th
On 3/21/21 10:15 PM, Richard Henderson wrote:
> In bbc17caf81f, we used an alias attribute to allow target_page
> to be declared const, and yet be initialized late.
>
> This fails when using LTO with several versions of gcc.
> The compiler looks through the alias and decides that the const
> varia
On Thu, Mar 18, 2021 at 02:35:50PM +0100, Stefan Reiter wrote:
> If OOB is disabled, events received in monitor_qmp_event will be handled
> in the main context. Thus, we must not acquire a qmp_queue_lock there,
> as the dispatcher coroutine holds one over a yield point, where it
> expects to be res
22.03.2021 13:46, Vladimir Sementsov-Ogievskiy wrote:
22.03.2021 13:18, Patrik Janoušek wrote:
On 3/22/21 9:41 AM, Vladimir Sementsov-Ogievskiy wrote:
20.03.2021 12:32, Patrik Janoušek wrote:
Current implementation of dirty bitmaps for raw format is very
limited, because those bitmaps cannot b
On 22/03/21 06:02, Thomas Huth wrote:
On 19/03/2021 15.39, Paolo Bonzini wrote:
The following changes since commit
cf6b56d4f2107259f52413f979a1d474dad0c1e1:
Merge remote-tracking branch 'remotes/philmd/tags/pflash-20210318'
into staging (2021-03-18 23:04:41 +)
are available in the Gi
Hi,
While reviewing Richard's original patch, I split it in 3
to make it more digestible to my review taste. I then simply
filled the patch descriptions. Feel free to keep Richard's v1
if this isn't worth it.
What is still missing is adding the new files to a MAINTAINERS
section.
Regards,
Phil.
From: Richard Henderson
exec-vary.c is about variable page size handling,
rename it page-vary.c. Currently this file is target
specific (built once for each target), comment this.
Signed-off-by: Philippe Mathieu-Daudé
---
meson.build| 3 ++-
exec-vary.c => page-vary.c | 2 +-
2
On Sun, 21 Mar 2021 at 17:18, Thomas Huth wrote:
>
> Hi Peter!
>
> The following changes since commit 2e1293cbaac75e84f541f9acfa8e26749f4c3562:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2021-03-16-v4'
> into staging (2021-03-19 16:40:00 +)
>
> are available in the Git
From: Richard Henderson
In the next commit we will extract the generic code out of
page-vary.c, only keeping the target specific code. Both
files will use the same TargetPageBits structure, so make
its declaration in a shared header.
As the common header can not use target specific types,
use a
From: Richard Henderson
In bbc17caf81f, we used an alias attribute to allow target_page
to be declared const, and yet be initialized late.
This fails when using LTO with several versions of gcc.
The compiler looks through the alias and decides that the const
variable is statically initialized to
On 3/22/21 11:48 AM, Max Reitz wrote:
> Hi,
>
> On 20.03.21 11:01, Patrik Janoušek wrote:
>> I'm sorry, but I forgot to add you to the cc, so I'm forwarding the
>> patch to you additionally. I don't want to spam the mailing list
>> unnecessarily.
>
> I think it’s better to still CC the list. It’s
On Fri, Mar 19, 2021 at 11:41:22PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> Bitmaps on source are marked busy during migration.
>
> Enabled bitmaps on target have successor, so they are busy.
>
> But disabled migrated bitmaps are not protected on target. User can
> simple remove
On Mon, Mar 22, 2021 at 10:52:02AM +, Peter Maydell wrote:
> On Thu, 18 Mar 2021 at 09:30, Daniel P. Berrangé wrote:
> >
> > Remove many old deprecated features
> >
> > The following features have been deprecated for well over th
On Sat, Mar 20, 2021 at 12:18:54PM +0800, Gavin Shan wrote:
> This fixes the following build error with gcc v11.0.0:
>
> # gcc --version
> gcc (GCC) 11.0.0 20210210 (Red Hat 11.0.0-0)
>
> [969/2604] Compiling C++ object libcommon.fa.p/disas_arm-a64.cc.o
> FAILED: libcommon.fa.p/disas_arm-
On Mon, Mar 22, 2021 at 2:59 PM Marc-André Lureau <
marcandre.lur...@redhat.com> wrote:
> Hi
>
> On Mon, Mar 22, 2021 at 2:52 PM wrote:
>
>> From: Marc-André Lureau
>>
>> The default "alabaster" sphinx theme has a couple shortcomings:
>> - the navbar moves along the page
>> - the search bar is n
On Mon, Feb 22, 2021 at 04:13:32PM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > > TODO:
> > > Enabling modular tracepoints via -trace cmd line doesn't work yet.
> > > Guess we need to store the list somewhere for later re-processing.
> > > Error handling is tricky, specifically the "tracepoint doesn'
On 3/22/21 12:18 PM, Vladimir Sementsov-Ogievskiy wrote:
> 22.03.2021 13:46, Vladimir Sementsov-Ogievskiy wrote:
>> 22.03.2021 13:18, Patrik Janoušek wrote:
>>> On 3/22/21 9:41 AM, Vladimir Sementsov-Ogievskiy wrote:
20.03.2021 12:32, Patrik Janoušek wrote:
> Current implementation of di
22.03.2021 14:28, Stefan Hajnoczi wrote:
On Fri, Mar 19, 2021 at 11:41:22PM +0300, Vladimir Sementsov-Ogievskiy wrote:
Hi all!
Bitmaps on source are marked busy during migration.
Enabled bitmaps on target have successor, so they are busy.
But disabled migrated bitmaps are not protected on tar
On Thu, Jan 21, 2021 at 01:50:24PM +0100, Gerd Hoffmann wrote:
> Move qxl trace events to separate trace-events-qxl file.
>
> Signed-off-by: Gerd Hoffmann
> ---
> hw/display/qxl-render.c | 1 +
> hw/display/qxl.c| 1 +
> hw/display/meson.build | 5 +++
> hw/display/trace-
On Sat, Mar 20, 2021 at 01:36:56PM +, Alex Bennée wrote:
> I confused myself wandering if this had been merged by looking at the
> help output. It seems fuse_opt doesn't automagically add to help
> output so lets do it now.
>
> Signed-off-by: Alex Bennée
> Reviewed-by: Connor Kuehl
> Updates
The previous attempt (commit f77147cd4de) doesn't work as
expected, as we still have CONFIG_TCG=1 when using:
configure --disable-system --disable-user
Use Meson's get_option() instead to remove the softfloat tests
when building with --disable-tcg.
Suggested-by: Claudio Fontana
Signed-off-by:
On Mon, Mar 22, 2021 at 11:36:39AM +, Stefan Hajnoczi wrote:
> On Mon, Feb 22, 2021 at 04:13:32PM +0100, Gerd Hoffmann wrote:
> > Hi,
> >
> > > > TODO:
> > > > Enabling modular tracepoints via -trace cmd line doesn't work yet.
> > > > Guess we need to store the list somewhere for later re-pr
New versions of gcc report a potential error and there may be alignment
issues using uint64_t pointer to check the RSDP signature:
gcc 10.2.1 "cc (Alpine 10.2.1_pre2) 10.2.1 20210313" reports:
pc-bios/optionrom/pvh_main.c: In function 'search_rsdp':
pc-bios/optionrom/pvh_main.c:61:21:
1 - 100 of 476 matches
Mail list logo