On 3/17/21 1:36 PM, Cédric Le Goater wrote:
> On 3/17/21 12:47 PM, Philippe Mathieu-Daudé wrote:
>> On 3/12/21 11:57 AM, Joel Stanley wrote:
>>> The HACE (Hash and Crypto Engine) is a device that offloads MD5, SHA1,
>>> SHA2, RSA and other cryptographic algorithms.
>>>
>>> This initial model imp
On Wed, Mar 17, 2021 at 01:44:05PM +0100, Thomas Huth wrote:
> On 17/03/2021 12.16, Peter Maydell wrote:
> > On Wed, 17 Mar 2021 at 11:09, Thomas Huth wrote:
> > >
> > > FreeBSD version 12.1 is out of service now, and the task in the
> > > Cirrus-CI is failing. Update to 12.2 to get it working ag
On 3/17/21 1:13 PM, Alex Bennée wrote:
> Philippe Mathieu-Daudé writes:
>
>> Hi Alex,
>>
>> On 3/17/21 8:22 AM, Alex Bennée wrote:
>>> From: Richard Henderson
>>>
>>> Once we've parsed the fractional value, extract it into an integral
>>> 64-bit fraction. Perform the scaling with integer arithm
On Wed, 17 Mar 2021 at 12:55, Andrew Jones wrote:
> I'm also curious what the state of mach-virt's machine types are for
> migration.
Probably not great -- I don't think anybody is really testing
cross-version migration, and I don't think there's a great
deal of in-practice use of it for Arm eith
On Wed, 17 Mar 2021 at 13:16, Roman Bolshakov wrote:
> result = asn1_der_coding (asn1_element, "", NULL, &der_len,
> errorDescription);
>
> The result should be ASN1_MEM_ERROR.
>
> Something like this should work as configure-time test.
Unfortunately at configure time you can't run code, only
Patchew URL:
https://patchew.org/QEMU/20210317125457.5733-1-arkaisp2...@gmail.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210317125457.5733-1-arkaisp2...@gmail.com
Subject: [PATCH v2] block: increased maximum
On 3/17/21 2:08 PM, Wainer dos Santos Moschetta wrote:> On 3/15/21 8:08
PM, Philippe Mathieu-Daudé wrote:
>> The Avocado Test::fetch_asset() is handy to download artifacts
>> before running tests. The current class is named Test but only
>> tests system emulation. As we want to test user emulation,
On 3/12/21 6:14 AM, mreza...@redhat.com wrote:
From: Miroslav Rezanina
There are two different versions of prototype for tcg_out_op and
tcg_out_vec_op functions:
1) using const TCGArg *args and const int *const_args arguments
2) using const TCGArg args[TCG_MAX_OP_ARGS] and const int
const_args
Hi,
On 3/15/21 8:08 PM, Philippe Mathieu-Daudé wrote:
Make pick_default_qemu_bin() generic to find qemu-system or
qemu-user binaries.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/acceptance/avocado_qemu/__init__.py | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --
On 3/16/21 11:07 PM, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> tcg/tcg.c | 79 +++
> 1 file changed, 79 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé
On Mon, 15 Mar 2021 at 20:45, Laurent Vivier wrote:
>
> The following changes since commit e7c6a8cf9f5c82aa152273e1c9e80d07b1b0c32c:
>
> Merge remote-tracking branch 'remotes/philmd/tags/avr-20210315' into stagin=
> g (2021-03-15 16:59:55 +)
>
> are available in the Git repository at:
>
>
On Mon, 15 Mar 2021 at 23:37, Philippe Mathieu-Daudé wrote:
>
> The following changes since commit 2615a5e433aeb812c300d3a48e1a88e1303e2339:
>
> Merge remote-tracking branch
> 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2021-03-15
> 19:23:00 +)
>
> are available in the
On 3/17/21 10:26 AM, Philippe Mathieu-Daudé wrote:
On 3/17/21 2:08 PM, Wainer dos Santos Moschetta wrote:> On 3/15/21 8:08
PM, Philippe Mathieu-Daudé wrote:
The Avocado Test::fetch_asset() is handy to download artifacts
before running tests. The current class is named Test but only
tests syste
On 3/17/21 8:16 AM, Philippe Mathieu-Daudé wrote:
> Yes, the problem is your series doesn't apply on top of 7625a1ed013
> ("utils: Use fixed-point arithmetic in qemu_strtosz")
>
> $ git am v2_20210317_alex_bennee_misc_fixes_strtoz_plugins_guest_loader.mbx
> Applying: utils: Use fixed-point arithm
Align the Reserved fields declaration in NvmeBar
Signed-off-by: Gollu Appalanaidu
---
include/block/nvme.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/block/nvme.h b/include/block/nvme.h
index fc65cfcb01..e5bd00bb85 100644
--- a/include/block/nvme.h
+++ b/include/
Make uniform hexadecimal numbers format.
Signed-off-by: Gollu Appalanaidu
---
hw/block/nvme.c | 30 +++---
include/block/nvme.h | 10 +-
2 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index d439e44db8..21e85
Hi,
On 3/15/21 8:08 PM, Philippe Mathieu-Daudé wrote:
Similarly to the 'System' Test base class with methods for testing
system emulation, the QemuUserTest class contains methods useful to
test user-mode emulation.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/acceptance/avocado_qemu/__ini
On 3/17/21 2:44 PM, Wainer dos Santos Moschetta wrote:> On 3/17/21 10:26
AM, Philippe Mathieu-Daudé wrote:
>> On 3/17/21 2:08 PM, Wainer dos Santos Moschetta wrote:> On 3/15/21 8:08
>> PM, Philippe Mathieu-Daudé wrote:
The Avocado Test::fetch_asset() is handy to download artifacts
before
Hi,
could this fix be merged in QEMU 6.0?
Thanks,
Laurent
Le 14/03/2021 à 21:03, Laurent Vivier a écrit :
> Both functions don't check the personality of the interface (legacy or
> modern) before accessing the configuration memory and always use
> virtio_config_readX()/virtio_config_writeX().
>
On Wed, Mar 17, 2021 at 08:28:33AM +, Kasireddy, Vivek wrote:
> Hi Gerd,
> Sorry for the delayed response. I wanted to wait until I finished my
> proof-of-concept --
> that included adding synchronization -- to ask follow up questions.
>
> > >
> > > Does your work above not count for anythin
On 3/17/21 2:37 PM, Peter Maydell wrote:
> On Mon, 15 Mar 2021 at 23:37, Philippe Mathieu-Daudé
> wrote:
>>
>> The following changes since commit 2615a5e433aeb812c300d3a48e1a88e1303e2339:
>>
>> Merge remote-tracking branch
>> 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2021
$ qemu-arm --version
qemu-arm version 5.2.0 (Debian 1:5.2+dfsg-6)
Copyright (c) 2003-2020 Fabrice Bellard and the QEMU Project developers
I’m seeing this error on a totally different file:
I’ve made a short test program (hello world-ish) and compiled it with
the OpenWrt toolchain but added -stati
Heh, even if I omit -static …
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1891748
Title:
qemu-arm-static 5.1 can't run gcc
Status in QEMU:
Fix Released
Status in Juju Charms Collection:
New
It works with sudo, but that can’t be the fix…
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1891748
Title:
qemu-arm-static 5.1 can't run gcc
Status in QEMU:
Fix Released
Status in Juju Charms C
The MSYS2 build exposed a latent problem in qemu_strto*l, which in
turn now causes failures ever since test-utils added tests for
qemu_strtosz that depends on a particular behavior when parsing "0x".
https://cirrus-ci.com/task/5180846782021632?command=test#L543
Eric Blake (2):
utils: Tighter te
Mingw recognizes that "0x" has value 0 without setting errno, but
fails to advance endptr to the trailing garbage 'x'. This in turn
showed up in our recent testsuite additions for qemu_strtosz (commit
1657ba44b4 utils: Enhance testsuite for do_strtosz()); adjust our
remaining tests to show that we
Our tests were not validating the return value in all cases, nor was
it guaranteeing our documented claim that 'res' is unchanged on error.
For that matter, it wasn't as thorough as the existing tests for
qemu_strtoi() and friends for proving that endptr and res are sanely
set. Enhancing the test
Philippe Mathieu-Daudé writes:
> On 3/17/21 1:13 PM, Alex Bennée wrote:
>> Philippe Mathieu-Daudé writes:
>>
>>> Hi Alex,
>>>
>>> On 3/17/21 8:22 AM, Alex Bennée wrote:
From: Richard Henderson
Once we've parsed the fractional value, extract it into an integral
64-bit frac
bdrv_append() is not quite good for inserting filters: it does extra
permission update in intermediate state, where filter get it filtered
child but is not yet replace it in a backing chain.
Some filters (for example backup-top) may want permissions even when
have no parents. And described interme
Add the test that shows that concept of ignore_children is incomplete.
Actually, when we want to update something, ignoring permission of some
existing BdrvChild, we should ignore also the propagated effect of this
child to the other children. But that's not done. Better approach
(update permission
Hi all!
Finally, I finished v3. Phew.
Missed a soft-freeze. Should we consider it a bugfix? There are bugfixes
here but they are mostly theoretical. So, up to Kevin, should it go to
current release or to the next..
The main point of the series is fixing some permission update problems
(see patch
These functions are called only from bdrv_reopen_multiple() in block.c.
No reason to publish them.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
Reviewed-by: Kevin Wolf
---
include/block/block.h | 4
block.c | 13 +
2 files changed, 9 i
We have too much comments for this feature. It seems better just don't
do it. Most of real users (tests don't count) have to create additional
reference.
Drop also comment in external_snapshot_prepare:
- bdrv_append doesn't "remove" old bs in common sense, it sounds
strange
- the fact that bd
Add test to show that simple DFS recursion order is not correct for
permission update. Correct order is topological-sort order, which will
be introduced later.
Consider the block driver which has two filter children: one active
with exclusive write access and one inactive with no specific
permissi
Split out no-perm part of bdrv_root_attach_child() into separate
transaction action. bdrv_root_attach_child() now moves to new
permission update paradigm: first update graph relations then update
permissions.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 189 +
Add new handler to get aio context and implement it in all child
classes. Add corresponding public interface to be used soon.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/block.h | 2 ++
include/block/block_int.h | 2 ++
block.c | 13 +
block/
Add simple transaction API to use in further update of block graph
operations.
Supposed usage is:
- "prepare" is main function of the action and it should make the main
effect of the action to be visible for the following actions, keeping
possibility of roll-back, saving necessary things in a
Passing parent aio context is redundant, as child_class and parent
opaque pointer are enough to retrieve it. Drop the argument and use new
bdrv_child_get_parent_aio_context() interface.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/block_int.h | 1 -
block.c | 8
Split out non-recursive parts, and refactor as block graph transaction
action.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 79 ++---
1 file changed, 59 insertions(+), 20 deletions(-)
diff --git a/block.c b/block.c
index 69db01c2e
Add additional check that node parents do not interfere with each
other. This should not hurt existing callers and allows in further
patch use bdrv_refresh_perms() to update a subtree of changed
BdrvChild (check that change is correct).
New check will substitute bdrv_check_update_perm() in followi
Each of them has only one caller. Open-coding simplifies further
pemission-update system changes.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
---
block.c | 59 +
1 file changed, 17 insertions(+), 42 deletions(-)
inore_children thing doesn't help to track all propagated permissions
of children we want to ignore. The simplest way to correctly update
permissions is update graph first and then do permission update. In
this case we just referesh permissions for the whole subgraph (in
topological-sort defined or
We are going to drop recursive bdrv_child_* functions, so stop use them
in bdrv_child_try_set_perm() as a first step.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/block.c b/block.c
index 2d64c498fc..1f1
Rewrite bdrv_check_perm(), bdrv_abort_perm_update() and bdrv_set_perm()
to update nodes in topological sort order instead of simple DFS. With
topologically sorted nodes, we update a node only when all its parents
already updated. With DFS it's not so.
Consider the following example:
A -+
bdrv_append is not very good for inserting filters: it does extra
permission update as part of bdrv_set_backing_hd(). During this update
filter may conflict with other parents of top_bs.
Instead, let's first do all graph modifications and after it update
permissions.
append-greedy-filter test-cas
Split no-perm part of bdrv_attach_child as separate transaction action.
It will be used in later commits.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 71 ++---
1 file changed, 58 insertions(+), 13 deletions(-)
diff --git a/block.
Split part of bdrv_replace_node_common() to be used separately.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 50 +++---
1 file changed, 31 insertions(+), 19 deletions(-)
diff --git a/block.c b/block.c
index d810915684..433cae1181 100644
-
Refactor calling driver callbacks to a separate transaction action to
be used later.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 70 -
1 file changed, 54 insertions(+), 16 deletions(-)
diff --git a/block.c b/block.c
index 143
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 78 +++--
1 file changed, 76 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
index 11f7ad0818..2fca1f2ad5 100644
--- a/block.c
+++ b/block.c
@@ -2929,12 +2929,19 @@ static v
Using bdrv_replace_node() for removing filter is not good enough: it
keeps child reference of the filter, which may conflict with original
top node during permission update.
Instead let's create new interface, which will do all graph
modifications first and then update permissions.
Let's modify b
To be used in further commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/block.h | 3 ++-
block.c | 9 -
block/io.c| 31 +--
3 files changed, 35 insertions(+), 8 deletions(-)
diff --git a/include/block/block.h b/
This argument is always NULL. Drop it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 38 +++---
1 file changed, 11 insertions(+), 27 deletions(-)
diff --git a/block.c b/block.c
index bf60f1ea2c..922df82952 100644
--- a/block.c
+++ b/block.c
@@ -1954,7
bdrv_check_perm_common() has only one caller, so no more sense in
"common".
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 32 +++-
1 file changed, 3 insertions(+), 29 deletions(-)
diff --git a/block.c b/block.c
index b39e6455b2..29e00c4708 100644
--- a/bl
We don't need this workaround anymore: bdrv_append is already smart
enough and we can use new bdrv_drop_filter().
This commit efficiently reverts also recent 705dde27c6c53b73, which
checked .active on io path. Still it said that the problem should be
theoretical. And the logic of filter removement
To be used in the further commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 46 ++
1 file changed, 42 insertions(+), 4 deletions(-)
diff --git a/block.c b/block.c
index 922df82952..3b9681a738 100644
--- a/block.c
+++ b/block.c
@@ -3170
Could you check the result of "sysctl vm.mmap_min_addr"
65536 is the value that works for me.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1891748
Title:
qemu-arm-static 5.1 can't run gcc
Status
Split out no-perm part of bdrv_set_backing_hd() as a separate
transaction action. Note the in case of existing BdrvChild we reuse it,
not recreate, just to do less actions.
We don't need to create extra reference to backing_hd as we don't lose
it in bdrv_attach_child().
Signed-off-by: Vladimir Se
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 103
1 file changed, 103 deletions(-)
diff --git a/block.c b/block.c
index 53a8af301a..b39e6455b2 100644
--- a/block.c
+++ b/block.c
@@ -1953,11 +1953,6 @@ static int bdrv_fill_opti
bdrv_replace_child() has only one caller, the second argument is
unused. Inline it now. This triggers deletion of some more unused
interfaces.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 101 ++--
1 file changed, 18 insertions(+),
Add new interface, allowing use of existing node list. It will be used
to fix bdrv_replace_node() in the further commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 106 +---
1 file changed, 71 insertions(+), 35 deletions(-)
diff
We don't have bdrv_replace_child(), so it's time for
bdrv_replace_child_safe() to take its place.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block.c b/block.c
index b7cded9826..b61ac9ff19 100644
--- a/blo
To be used in the following commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 54 ++
1 file changed, 54 insertions(+)
diff --git a/block.c b/block.c
index 31a4e4fa5c..4f9d67a6a2 100644
--- a/block.c
+++ b/block.c
@@ -83,6 +83,9
During reopen we may add backing bs from other aio context, which may
lead to changing original context of top bs.
We are going to move graph modification to prepare stage. So, it will
be possible that bdrv_flush() in bdrv_reopen_prepare called on bs in
non-original aio context, which we didn't aq
Move bdrv_reopen_multiple to new paradigm of permission update:
first update graph relations, then do refresh the permissions.
We have to modify reopen process in file-posix driver: with new scheme
we don't have prepared permissions in raw_reopen_prepare(), so we
should reconfigure fd in raw_check
On 3/15/21 8:08 PM, Philippe Mathieu-Daudé wrote:
Move the useful has_cmd()/has_cmds() helpers from the virtiofs
test to the avocado_qemu public class.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/acceptance/avocado_qemu/__init__.py | 57 ++
tests/acceptance/virtiofs
Old interfaces dropped, nobody directly calls
bdrv_child_set_perm_abort() and bdrv_child_set_perm_commit(), so we can
use personal state structure for the action and stop exploiting
BdrvChild structure. Also, drop "_safe" suffix which is redundant now.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Now, bdrv_node_check_perm() is called only with fresh cumulative
permissions, so its actually "refresh_perm".
Move permission calculation to the function. Also, drop unreachable
error message and rewrite the remaining one to be more generic (as now
we don't know which node is added and which was a
On Wed, Mar 17, 2021 at 3:51 AM Jason Wang wrote:
>
>
> 在 2021/3/17 上午12:05, Eugenio Perez Martin 写道:
> > On Tue, Mar 16, 2021 at 9:15 AM Jason Wang wrote:
> >>
> >> 在 2021/3/16 上午3:48, Eugenio Pérez 写道:
> >>> Initial version of shadow virtqueue that actually forward buffers.
> >>>
> >>> It reuse
On Tue, 16 Mar 2021 at 05:38, Gerd Hoffmann wrote:
>
> The following changes since commit 6157b0e19721aadb4c7fdcfe57b2924af6144b14:
>
> Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-6.0-pull-=
> request' into staging (2021-03-14 17:47:49 +)
>
> are available in the Git re
From: NDNF
This fixes the problem of the impossibility to create
FAT16 disks larger than 504 mb:
The change CHS made it possible to obtain a larger disk.
Also, auto-detection of disk parameters was added depending
on the volume of the connected files:
The size of all folders and files on the crea
On Wednesday, 2021-03-17 at 13:16:39 +01, Paolo Bonzini wrote:
> An invariant of the current rwlock is that if multiple coroutines hold a
> reader lock, all must be runnable. The unlock implementation relies on
> this, choosing to wake a single coroutine when the final read lock
> holder exits the
OSS-Fuzz says this issue has been fixed.
** Changed in: qemu
Status: New => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1910826
Title:
[OSS-Fuzz] Issue 29224 rtl8139: Stack-
On 17/03/2021 15.33, Eric Blake wrote:
Our tests were not validating the return value in all cases, nor was
it guaranteeing our documented claim that 'res' is unchanged on error.
For that matter, it wasn't as thorough as the existing tests for
qemu_strtoi() and friends for proving that endptr and
On 3/11/21 3:39 PM, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> tcg/tci/tcg-target.c.inc | 84 +++-
> 1 file changed, 39 insertions(+), 45 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
Patchew URL:
https://patchew.org/QEMU/20210317143529.615584-1-vsement...@virtuozzo.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210317143529.615584-1-vsement...@virtuozzo.com
Subject: [PATCH v3 00/36] block: u
On Wednesday, 2021-03-17 at 13:16:40 +01, Paolo Bonzini wrote:
> Test that rwlock upgrade is fair, and readers go back to sleep if a writer
> is in line.
>
> Signed-off-by: Paolo Bonzini
Reviewed-by: David Edmondson
> ---
> tests/unit/test-coroutine.c | 62
On Tue, Mar 16, 2021 at 09:34:08PM +0100, Igor Mammedov wrote:
> Thanks for reporting it before it was released
> please test/review fix that I've just posted:
>
> "[PATCH for-6.0] x86:acpi:piix4: reinitialize PM1.CNT on reset"
Reported-by: Reinoud Zandijk
Tested-by: Reinoud Zandijk
On Wed, Mar 17, 2021 at 09:58:25AM +0100, Reinoud Zandijk wrote:
> On Tue, Mar 16, 2021 at 09:34:08PM +0100, Igor Mammedov wrote:
> > Thanks for reporting it before it was released
> > please test/review fix that I've just posted:
> >
> > "[PATCH for-6.0] x86:acpi:piix4: reinitialize PM1.CNT on r
On 3/17/21 5:05 AM, Thomas Huth wrote:
The test for 128-bit atomics is causing trouble with FreeBSD 12.2 and
--enable-werror:
cc -Werror -fPIE -DPIE -std=gnu99 -Wall -m64 -mcx16 -D_GNU_SOURCE
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes
-Wredundant-decls -Wundef -Wwrite-str
Each vCPU core exposes its timebase frequency in the DT. When running
under KVM, this means parsing /proc/cpuinfo in order to get the timebase
frequency of the host CPU.
The parsing appears to slow down the boot quite a bit with higher number
of cores:
# of cores seconds spent in spapr_dt_cpu
On 210316 2330, Mark Cave-Ayland wrote:
> If a guest sends a TI (Transfer Information) command without previously
> sending
> any message out/command phase data then cmdfifo will underflow triggering an
> assert reading the IDENTIFY byte.
>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1919035
Patchew URL:
https://patchew.org/QEMU/20210317143325.2165821-1-ebl...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210317143325.2165821-1-ebl...@redhat.com
Subject: [PATCH 0/2] More qemu_strtosz fixes
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
tcg/tci.c | 154 --
1 file changed, 57 insertions(+), 97 deletions(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index e5aba3a9fa..1c879a2536 100644
--- a/tcg/tci.c
+++ b/tcg/tci
Begin splitting out functions that do pure argument decode,
without actually loading values from the register set.
This means that decoding need not concern itself between
input and output registers. We can assert that the register
number is in range during decode, so that it is safe to
simply de
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
tcg/tci.c | 24 ++--
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index 1c879a2536..dd9bcd74f3 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@ -180,6 +180,7 @@ static t
This makes the curl driver more consistent with file-posix in that it
doesn't return errors any more for reading after the end of the remote
file. Instead, zeros are returned for these areas.
This inconsistency was reported in:
https://bugzilla.redhat.com/show_bug.cgi?id=1935061
Note that the ima
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
tcg/tci.c | 67 +--
1 file changed, 31 insertions(+), 36 deletions(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index 5acf5c38c3..e5aba3a9fa 100644
--- a/tcg/tci.c
+++ b/tcg/tci
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
tcg/tci.c | 31 ---
1 file changed, 20 insertions(+), 11 deletions(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index 53e49ccf8e..91c5f71065 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@ -260,6 +260,17 @@
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
tcg/tci.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index dd9bcd74f3..e323351b75 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@ -181,10 +181,16 @@ static tcg_target_ulon
This performs the size check while reading the arguments,
which means that we don't have to arrange for it to be
done after the operation. Which tidies all of the branches.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
tcg/tci.c | 87 +
On 3/17/21 10:15 AM, no-re...@patchew.org wrote:
> Patchew URL:
> https://patchew.org/QEMU/20210317143325.2165821-1-ebl...@redhat.com/
>
> === OUTPUT BEGIN ===
> 1/2 Checking commit 81af63e53841 (utils: Tighter tests for qemu_strtosz)
> 2/2 Checking commit 36c9a8f42010 (utils: Work around mingw
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
tcg/tci.c | 25 +++--
1 file changed, 19 insertions(+), 6 deletions(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index e323351b75..22ede4016d 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@ -223,6 +223,19 @@ static
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
tcg/tci.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index 9bb529c5ae..0f8f606808 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@ -437,30 +43
On 3/17/21 10:17 AM, Kevin Wolf wrote:
> This makes the curl driver more consistent with file-posix in that it
> doesn't return errors any more for reading after the end of the remote
> file. Instead, zeros are returned for these areas.
>
> This inconsistency was reported in:
> https://bugzilla.re
We're about to split out bytecode output into helpers, but
we can't do that one at a time if tcg_out_op_t is being done
outside of the switch.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
tcg/tci/tcg-target.c.inc | 35 ---
1 file chang
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
tcg/tci.c | 52
1 file changed, 32 insertions(+), 20 deletions(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index 22ede4016d..854fc8df5d 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
tcg/tci.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index 91c5f71065..2fcf5a2473 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@ -239,6 +239,15 @@ static void tci_
Convert to indirect jumps, as it's less complicated.
Then we just have a pointer to the tb address at which
the chain is stored, from which we read.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
tcg/tci/tcg-target.h | 11 +++
tcg/tci.c| 8
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
tcg/tci/tcg-target.c.inc | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/tcg/tci/tcg-target.c.inc b/tcg/tci/tcg-target.c.inc
index 3320ec1088..d4207818cf 100644
--- a/tcg/tci/tcg-t
These operations are always available under different names:
INDEX_op_ext_i32_i64 and INDEX_op_extu_i32_i64, so we remove
no code with the ifdef.
Reviewed-by: Stefan Weil
Signed-off-by: Richard Henderson
---
tcg/tci.c | 4
1 file changed, 4 deletions(-)
diff --git a/tcg/tci.c b/tcg/tci.c
201 - 300 of 450 matches
Mail list logo
