在 2021/3/16 上午3:48, Eugenio Pérez 写道:
Shadow virtqueue notifications forwarding is disabled when vhost_dev
stops, so code flow follows usual cleanup.
Signed-off-by: Eugenio Pérez
---
hw/virtio/vhost-shadow-virtqueue.h | 7 ++
include/hw/virtio/vhost.h | 4 +
hw/virtio/vhost-s
On Mar 16 15:53, Minwoo Im wrote:
> On 21-03-10 10:53:43, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Provide a more flexible nlbas helper.
> >
> > Signed-off-by: Klaus Jensen
> > ---
> > hw/block/nvme-ns.h | 14 ++
> > 1 file changed, 10 insertions(+), 4 deletions(-)
> >
>
On 15/03/21 23:04, Peter Maydell wrote:
../../meson.build:1:0: ERROR: Value "true" (of type "string") for
combo option "Localization of the GTK+ user interface" is not one of
the choices. Possible choices are (as string): "enabled", "disabled",
"auto".
This probably dates back to
commit 0e
在 2021/3/16 上午3:48, Eugenio Pérez 写道:
On one hand it uses a mutex to synchronize guest masking with SVQ start
and stop, because otherwise guest mask could race with the SVQ
stop code, sending an incorrect call notifier to vhost device. This
would prevent further communication.
Is this becuas
在 2021/3/16 上午3:48, Eugenio Pérez 写道:
This method is already present in vhost-user. This commit adapts it to
vhost-net, so SVQ can use.
vhost_kernel_set_enable stops the device, so qemu can ask for its status
(next available idx the device was going to consume). When SVQ starts it
can resume c
On 21-03-16 08:19:08, Klaus Jensen wrote:
> On Mar 16 15:53, Minwoo Im wrote:
> > On 21-03-10 10:53:43, Klaus Jensen wrote:
> > > From: Klaus Jensen
> > >
> > > Provide a more flexible nlbas helper.
> > >
> > > Signed-off-by: Klaus Jensen
> > > ---
> > > hw/block/nvme-ns.h | 14 ++
在 2021/3/16 上午3:48, Eugenio Pérez 写道:
It reports the shadow virtqueue address from qemu virtual address space
Note that to be used by vDPA, we can't use qemu VA directly here.
Signed-off-by: Eugenio Pérez
---
hw/virtio/vhost-shadow-virtqueue.h | 2 ++
hw/virtio/vhost-shadow-virtqueu
This series supports reload x509 certificates for vnc
1. Support reload x509 certificates.
2. Support reload vnc certificates.
3. Add new qmp display-reload and implement reload x509 certificates for vnc.
Example:
{"execute": "display-reload", "arguments":{"type": "vnc", "tls-certs": true}}
Zihao
This patch adds reload interface for QCryptoTLSCredsClass and implements
the interface for QCryptoTLSCredsX509.
Signed-off-by: Zihao Chang
Acked-by: Daniel P. Berrang??
---
crypto/tlscredsx509.c | 48 +++
include/crypto/tlscreds.h | 8 ---
2 files ch
This patch provides a new qmp to reload display configuration
without restart VM, but only reloading the vnc tls certificates
is implemented.
Example:
{"execute": "display-reload", "arguments":{"type": "vnc", "tls-certs": true}}
Signed-off-by: Zihao Chang
---
monitor/qmp-cmds.c | 17
This patch add vnc_display_reload_certs() to support
update x509 certificates.
Signed-off-by: Zihao Chang
Reviewed-by: Daniel P. Berrang??
---
include/ui/console.h | 1 +
ui/vnc.c | 28
2 files changed, 29 insertions(+)
diff --git a/include/ui/console.
在 2021/3/16 上午3:48, Eugenio Pérez 写道:
Signed-off-by: Eugenio Pérez
---
hw/virtio/vhost-shadow-virtqueue.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/vhost-shadow-virtqueue.c
b/hw/virtio/vhost-shadow-virtqueue.c
index 68ed0f2740..7df98fc43f 100
在 2021/3/16 上午3:48, Eugenio Pérez 写道:
Signed-off-by: Eugenio Pérez
---
hw/virtio/vhost-shadow-virtqueue.c | 28 +++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/vhost-shadow-virtqueue.c
b/hw/virtio/vhost-shadow-virtqueue.c
index 7df98fc43
Hello,
I gave this series a try on some PPC machines : mac99, g3beige,
sam460ex, pseries, powernv, with linux, macos, darwin, aix and
didn't see any regression. Migration seems to work for pseries.
C.
On 3/15/21 7:45 PM, Richard Henderson wrote:
> Changes for v4:
> * Use hregs_recompute_hflag
On 3/15/21 7:45 PM, Richard Henderson wrote:
> Move the functions to a new file, helper_regs.c.
>
> Note int_helper.c was relying on helper_regs.h to
> indirectly include qemu/log.h.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Cédric Le Goater
Thanks,
C.
> ---
> target/ppc/helper_re
The minimum Ethernet frame length is 60 bytes. For short frames with
smaller length like ARP packets (only 42 bytes), on a real world NIC
it can choose either padding its length to the minimum required 60
bytes, or sending it out directly to the wire. Such behavior can be
hardcoded or controled by
This adds a flag in NetClientState, so that a net client can tell
its peer that the packets do not need to be padded to the minimum
size of an Ethernet frame (60 bytes) before sending to it.
Signed-off-by: Bin Meng
Reviewed-by: Philippe Mathieu-Daudé
---
Changes in v3:
- add a comment to 'do_n
The minimum Ethernet frame length is 60 bytes. For short frames with
smaller length like ARP packets (only 42 bytes), on a real world NIC
it can choose either padding its length to the minimum required 60
bytes, or sending it out directly to the wire. Such behavior can be
hardcoded or controled by
On 3/15/21 7:46 PM, Richard Henderson wrote:
> Keep all hflags computation in one place, as this will be
> especially important later.
>
> Introduce a new POWERPC_FLAG_HID0_LE bit to indicate when
> LE should be taken from HID0. This appears to be set if
> and only if POWERPC_FLAG_RTC_CLK is set,
Do the same for tap backend as what we did for slirp.
Signed-off-by: Bin Meng
---
Changes in v3:
- use the pad_short_frame() helper for tap
net/tap-win32.c | 9 +
net/tap.c | 9 +
2 files changed, 18 insertions(+)
diff --git a/net/tap-win32.c b/net/tap-win32.c
index 2b5
For virtio-net, there is no need to pad the Ethernet frame size to
60 bytes before sending to it.
Signed-off-by: Bin Meng
---
(no changes since v1)
hw/net/virtio-net.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 96a3cc8357..66b9ff4511
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
Signed-off-by: Bin Meng
---
(no changes since v1)
hw/net/i82596.c | 18 --
1 file changed, 18 deletions(-)
diff --git a/hw/net/i82596.c b/hw/net/i825
Add a helper to pad a short ethernet frame to the minimum required
length, which can be used by backend codes.
Signed-off-by: Bin Meng
---
Changes in v3:
- use 'without' instead of 'sans'
- add a helper to pad short frames
include/net/eth.h | 25 +
1 file changed, 25 i
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
This actually reverts commit 78aeb23eded2d0b765bf9145c71f80025b568acd.
Signed-off-by: Bin Meng
---
(no changes since v1)
hw/net/e1000.c | 11 +--
1 file chan
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
This actually reverts commit 40a87c6c9b11ef9c14e0301f76abf0eb2582f08e.
Signed-off-by: Bin Meng
---
(no changes since v1)
hw/net/vmxnet3.c | 10 --
1 file cha
On 2021/3/16 2:07, Gerd Hoffmann wrote:
> On Mon, Mar 15, 2021 at 09:16:06PM +0800, Zihao Chang wrote:
>> This series supports reload x509 certificates for vnc
>> 1. Support reload x509 certificates.
>> 2. Support reload vnc certificates.
>> 3. Add new qmp display-reload and implement reload x50
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
Signed-off-by: Bin Meng
---
(no changes since v1)
hw/net/ne2000.c | 12
1 file changed, 12 deletions(-)
diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c
i
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
Signed-off-by: Bin Meng
---
(no changes since v1)
hw/net/pcnet.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c
index f3f
On 3/15/21 7:46 PM, Richard Henderson wrote:
> It will be stored in tb->flags, which is also uint32_t,
> so let's use the correct size.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Cédric Le Goater
Thanks,
C.
> ---
> target/ppc/cpu.h | 4 ++--
> target/ppc/misc_helper.c | 2 +-
On 3/15/21 7:46 PM, Richard Henderson wrote:
> Match cpu_post_load in using ppc_store_msr to set all of
> the cpu state implied by the value of msr. Do not restore
> hflags or hflags_nmsr, as we recompute them in ppc_store_msr.
>
> Signed-off-by: Richard Henderson
Could we add a common routine
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
Signed-off-by: Bin Meng
---
(no changes since v1)
hw/net/sungem.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/hw/net/sungem.c b/hw/net/sungem.c
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
Signed-off-by: Bin Meng
---
(no changes since v1)
hw/net/rtl8139.c | 12
1 file changed, 12 deletions(-)
diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.
On 16/03/21 07:51, Markus Armbruster wrote:
The query command could be made more useful than introspection if it
reflected run time state, i.e. it showed an accelerator only when the
host system actually supports it. Can't say how practical that would
be.
At least for KVM there is runtime stat
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
Signed-off-by: Bin Meng
---
(no changes since v1)
hw/net/sunhme.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/hw/net/sunhme.c b/hw/net/sunhme.c
i
As the comment of tx_padding_and_crc() says: "Never add CRC in QEMU",
min_frame_len should excluce CRC, so it should be 60 instead of 64.
Signed-off-by: Bin Meng
---
hw/net/fsl_etsec/rings.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/fsl_etsec/rings.c b/hw/net/fs
On 3/15/21 7:46 PM, Richard Henderson wrote:
> As per hreg_compute_hflags:
>
> We 'forget' FE0 & FE1: we'll never generate imprecise exceptions
>
> remove the hflags marker from the respective comments.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Cédric Le Goater
Thanks,
C.
> ---
>
在 2021/3/16 上午3:48, Eugenio Pérez 写道:
Initial version of shadow virtqueue that actually forward buffers.
It reuses the VirtQueue code for the device part. The driver part is
based on Linux's virtio_ring driver, but with stripped functionality
and optimizations so it's easier to review.
These
On 3/15/21 7:46 PM, Richard Henderson wrote:
> In ppc_store_msr we call hreg_compute_hflags, which itself
> calls hreg_compute_mem_idx. Rely on ppc_store_msr to update
> everything required by the msr update.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Cédric Le Goater
Thanks,
C.
> ---
在 2021/3/16 上午3:48, Eugenio Pérez 写道:
This series enable shadow virtqueue for vhost-net devices. This is a
new method of vhost devices migration: Instead of relay on vhost
device's dirty logging capability, SW assisted LM intercepts dataplane,
forwarding the descriptors between VM and device. I
On 3/15/21 7:46 PM, Richard Henderson wrote:
> We have eliminated all normal uses of hflags_nmsr. We need
> not even compute it except when we want to migrate. Rename
> the field to emphasize this.
>
> Remove the fixme comment for migrating access_type. This value
> is only ever used with the c
On 3/16/21 9:12 AM, Bin Meng wrote:
> Add a helper to pad a short ethernet frame to the minimum required
> length, which can be used by backend codes.
>
> Signed-off-by: Bin Meng
>
> ---
>
> Changes in v3:
> - use 'without' instead of 'sans'
> - add a helper to pad short frames
>
> include/ne
On Tue, Mar 16, 2021 at 4:49 PM Philippe Mathieu-Daudé
wrote:
>
> On 3/16/21 9:12 AM, Bin Meng wrote:
> > Add a helper to pad a short ethernet frame to the minimum required
> > length, which can be used by backend codes.
> >
> > Signed-off-by: Bin Meng
> >
> > ---
> >
> > Changes in v3:
> > - use
Le 15/03/2021 à 13:33, BALATON Zoltan a écrit :
> On Sat, 13 Mar 2021, BALATON Zoltan wrote:
>> On Wed, 10 Mar 2021, BALATON Zoltan wrote:
>>> Hello,
>>
>> I've started posting this series well in advance to get it into 6.0 and yet
>> it seems like it may
>> be missing it due to organisational iss
On 3/16/21 7:51 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> On 3/11/21 5:11 PM, Philippe Mathieu-Daudé wrote:
> [...]
>>> diff --git a/accel/accel-qmp.c b/accel/accel-qmp.c
>>> new file mode 100644
>>> index 000..f16e49b8956
>>> --- /dev/null
>>> +++ b/accel/accel-qmp.c
>>> @@
I rebased my "[PATCH v6 00/10] Configurable policy for handling
deprecated interfaces" to master, and it surprisingly fails to link
several utility programs. Here's the first error:
gcc -o tests/bench/benchmark-crypto-hmac
tests/bench/benchmark-crypto-hmac.p/benchmark-crypto-hmac.c.o -Wl,--
On Wed, Mar 10, 2021 at 05:30:04PM +, Stefan Hajnoczi wrote:
> socket_get_fd() fails with the error "socket_get_fd: too many
> connections" if the given listen backlog value is not 1.
>
> Not all callers set the backlog to 1. For example, commit
> 582d4210eb2f2ab5baac328fe4b479cd86da1647 ("qem
* Pavel Dovgalyuk (pavel.dovgal...@ispras.ru) wrote:
> On 15.03.2021 23:13, Dr. David Alan Gilbert wrote:
> > * Pavel Dovgalyuk (pavel.dovgal...@ispras.ru) wrote:
> > > QEMU timer of channel 0 in i8254 is used to raise irq
> > > at the specified moment of time. This irq can be disabled
> > > with i
On 16/03/2021 10.07, Markus Armbruster wrote:
I rebased my "[PATCH v6 00/10] Configurable policy for handling
deprecated interfaces" to master, and it surprisingly fails to link
several utility programs. Here's the first error:
gcc -o tests/bench/benchmark-crypto-hmac
tests/bench/benchma
On 16/03/21 10:07, Markus Armbruster wrote:
I suspect the linker happens to pick the one that makes things work,
until something in my patch makes it pick the other one.
Ouch. Fortunately the stub is unnecessary and can be removed.
--- 8<
From fe45350cc11434efe3461c540bb0
Daniel P. Berrangé writes:
> On Mon, Mar 15, 2021 at 06:04:10PM +0100, Thomas Huth wrote:
>> On 15/03/2021 17.57, Peter Maydell wrote:
>> > On Mon, 15 Mar 2021 at 16:53, Alex Bennée wrote:
>> > > -Prefer g_new(T, n) instead of g_malloc(sizeof(T) ``*`` n) for the
>> > > following
>> > > +Care sh
On 16/03/21 10:24, Thomas Huth wrote:
A very, very quick-n-dirty band-aid is likely to mark the function in
stubs as weak:
This probably does not work on some of our porting targets (OS X)? The
static library was introduced as a low-tech alternative to weak symbols,
IIRC.
Paolo
Hi Marc-André,
The new chardev can get the same label. It is assigned after the function
ChardevReturn *qmp_chardev_change(const char *id, ChardevBackend *backend,
Error **errp)
{
.
chr_new = chardev_new(NULL, object_class_get_name(OBJECT_CLASS(cc))
Paolo Bonzini writes:
> On 16/03/21 10:07, Markus Armbruster wrote:
>> I suspect the linker happens to pick the one that makes things work,
>> until something in my patch makes it pick the other one.
>
> Ouch. Fortunately the stub is unnecessary and can be removed.
>
> --- 8< ---
tags/s390x-20210316
for you to fetch changes up to 5793f5aafb05dae30e9dcb57d0d1c8f1a9633f6d:
s390x/pci: Add missing initialization for g_autofree variables (2021-03-15
15:47:18 +0100)
s390x updates:
- get rid of legacy_s390_a
From: David Hildenbrand
The PoP states:
When EDAT-1 does not apply, and a program interruption due to a
page-translation exception is recognized by the MOVE PAGE
instruction, the contents of the R1 field of the instruction are
stored in bit positions 0-3 of location 162, and the
From: Miroslav Rezanina
When declaring g_autofree variable without initialization, compiler
will raise "may be used uninitialized in this function" warning due
to automatic free handling.
This is mentioned in docs/devel/style.rst (quote from section
"Automatic memory deallocation"):
* Variabl
From: David Hildenbrand
legacy_s390_alloc() was required for dealing with the absence of the ESOP
feature -- on old HW (< gen 10) and old z/VM versions (< 6.3).
As z/VM v6.2 (and even v6.3) is no longer supported since 2017 [1]
and we don't expect to have real users on such old hardware, let's d
From: David Hildenbrand
As the last user is gone, we can get rid of phys_mem_set_alloc() and
simplify.
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Halil Pasic
Cc: Cornelia Huck
Cc: Christian Borntraeger
Cc: Thomas Huth
Cc: Igor Mammedov
Cc: Peter Xu
Signed-off-by: David Hildenbrand
Revi
From: Richard Henderson
If the CCO bit is set, MVPG should not generate an exception but
report page translation faults via a CC code.
Create a new helper, access_prepare_nf, which can use probe_access_flags
in non-faulting mode, and then handle watchpoints.
Reviewed-by: Richard Henderson
Sign
The single-frame z15 is called "z15 T02" (and the multi-frame z15
"z15 T01").
Signed-off-by: Cornelia Huck
Reviewed-by: David Hildenbrand
Acked-by: Christian Borntraeger
Message-Id: <20210311132746.154-1-coh...@redhat.com>
---
target/s390x/cpu_models.c | 4 ++--
1 file changed, 2 insertion
On 16/03/21 11:09, Markus Armbruster wrote:
Paolo Bonzini writes:
On 16/03/21 10:07, Markus Armbruster wrote:
I suspect the linker happens to pick the one that makes things work,
until something in my patch makes it pick the other one.
Ouch. Fortunately the stub is unnecessary and can be r
On 3/16/21 9:12 AM, Bin Meng wrote:
> Do the same for tap backend as what we did for slirp.
You explained SLiRP/TAP in the previous patch. IMO these
changes could be squashed there directly (besides, same
maintainer entry).
>
> Signed-off-by: Bin Meng
>
> ---
>
> Changes in v3:
> - use the pa
On 3/16/21 10:02 AM, Philippe Mathieu-Daudé wrote:
> On 3/16/21 7:51 AM, Markus Armbruster wrote:
>> Eric Blake writes:
>>
>>> On 3/11/21 5:11 PM, Philippe Mathieu-Daudé wrote:
>> [...]
diff --git a/accel/accel-qmp.c b/accel/accel-qmp.c
new file mode 100644
index 000..f16e49
On Tue, Mar 16, 2021 at 8:18 AM Jason Wang wrote:
>
>
> 在 2021/3/16 上午3:48, Eugenio Pérez 写道:
> > Shadow virtqueue notifications forwarding is disabled when vhost_dev
> > stops, so code flow follows usual cleanup.
> >
> > Signed-off-by: Eugenio Pérez
> > ---
> > hw/virtio/vhost-shadow-virtqueue
From: Paolo Bonzini
libqemuutil has two definitions of qemu_set_fd_handler. This
is not needed since the only users of the function are
qemu-io.c and the emulators, both of which already include
util/main-loop.c.
Signed-off-by: Paolo Bonzini
Message-Id:
Tested-by: Markus Armbruster
Signed-of
This policy suppresses deprecated bits in output, and thus permits
"testing the future". Implement it for QMP event data: suppress
deprecated members.
No QMP event data is deprecated right now.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20210312153210.2810514-5-arm..
QMP commands return their response as a generated QAPI type, which the
monitor core converts to JSON via QObject.
query-qmp-schema's response is the generated introspection data. This
is a QLitObject since commit 7d0f982bfb "qapi: generate a literal
qobject for introspection", v2.12). Before, it
This policy suppresses deprecated bits in output, and thus permits
"testing the future". Implement it for QMP command results. Example:
when QEMU is run with -compat deprecated-output=hide, then
{"execute": "query-cpus-fast"}
yields
{"return": [{"thread-id": 9805, "props": {"core-id":
This policy suppresses deprecated bits in output, and thus permits
"testing the future". Implement it for QMP events: suppress
deprecated ones.
No QMP event is deprecated right now.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20210312153210.2810514-4-arm...@redhat.com
New option -compat lets you configure what to do when deprecated
interfaces get used. This is intended for testing users of the
management interfaces. It is experimental.
-compat deprecated-input= configures what to do when
deprecated input is received. Input policy can be "accept" (accept
sile
Policy "crash" calls abort() when deprecated input is received.
Bugs in integration tests may mask the error from policy "reject".
Provide a larger hammer: crash outright. Masking that seems unlikely.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20210312153210.2810514-
This policy suppresses deprecated bits in output, and thus permits
"testing the future". Implement it for QMP command query-qmp-schema:
suppress information on deprecated commands, events and object type
members, i.e. anything that has the special feature flag "deprecated".
Signed-off-by: Markus
This policy rejects deprecated input, and thus permits "testing the
future". Implement it for QMP command arguments: reject commands with
deprecated ones. Example: when QEMU is run with -compat
deprecated-input=reject, then
{"execute": "eject", "arguments": {"device": "cd"}}
fails like this
The following changes since commit 2615a5e433aeb812c300d3a48e1a88e1303e2339:
Merge remote-tracking branch
'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2021-03-15
19:23:00 +)
are available in the Git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2021-
Without this stub, the next commit fails to link. I suspect the real
cause is 947e47448d "monitor: Use getter/setter functions for
cur_mon".
Cc: Kevin Wolf
Signed-off-by: Markus Armbruster
Message-Id: <20210312153210.2810514-8-arm...@redhat.com>
Reviewed-by: Eric Blake
---
tests/unit/test-uti
This policy rejects deprecated input, and thus permits "testing the
future". Implement it for QMP commands: make deprecated ones fail.
Example: when QEMU is run with -compat deprecated-input=reject, then
{"execute": "query-cpus"}
fails like this
{"error": {"class": "CommandNotFound", "d
Philippe Mathieu-Daudé writes:
> On 3/16/21 10:02 AM, Philippe Mathieu-Daudé wrote:
>> On 3/16/21 7:51 AM, Markus Armbruster wrote:
>>> Eric Blake writes:
>>>
On 3/11/21 5:11 PM, Philippe Mathieu-Daudé wrote:
>>> [...]
> diff --git a/accel/accel-qmp.c b/accel/accel-qmp.c
> new file
On Tue, Mar 16, 2021 at 8:30 AM Jason Wang wrote:
>
>
> 在 2021/3/16 上午3:48, Eugenio Pérez 写道:
> > This method is already present in vhost-user. This commit adapts it to
> > vhost-net, so SVQ can use.
> >
> > vhost_kernel_set_enable stops the device, so qemu can ask for its status
> > (next availab
From: Akihiko Odaki
An output device change can occur when plugging or unplugging an
earphone.
Signed-off-by: Akihiko Odaki
Message-Id: <20210311151512.22096-3-akihiko.od...@gmail.com>
Signed-off-by: Gerd Hoffmann
---
audio/coreaudio.c | 206 --
1 f
From: Akihiko Odaki
This change prepare to support dynamic device changes, which requires to
perform device initialization/deinitialization multiple times.
Signed-off-by: Akihiko Odaki
Message-Id: <20210311151512.22096-2-akihiko.od...@gmail.com>
Signed-off-by: Gerd Hoffmann
---
audio/coreaudi
The following changes since commit 2615a5e433aeb812c300d3a48e1a88e1303e2339:
Merge remote-tracking branch 'remotes/stefanha-gitlab/tags/block-pull-reque=
st' into staging (2021-03-15 19:23:00 +)
are available in the Git repository at:
git://git.kraxel.org/qemu tags/audio-202
From: Akihiko Odaki
Mac OS X 10.6 was released in 2009.
Signed-off-by: Akihiko Odaki
Reviewed-by: Peter Maydell
Message-Id: <20210311151512.22096-1-akihiko.od...@gmail.com>
Signed-off-by: Gerd Hoffmann
---
audio/coreaudio.c | 103 --
1 file changed
Philippe Mathieu-Daudé writes:
> Add a Kconfig entry for guest-loader so we can optionally deselect
> it (default is built in), and add a Meson dependency on libfdt.
>
> This fixes when building with --disable-fdt:
>
> /usr/bin/ld: libcommon.fa.p/hw_core_guest-loader.c.o: in function
> `load
On Mon, 15 Mar 2021 at 22:39, Philippe Mathieu-Daudé wrote:
>
> Coverity reported (CID 1450831) an array overrun in
> gen_mxu_D16MAX_D16MIN():
>
> 1103 } else if (unlikely((XRb == 0) || (XRa == 0))) {
>
> 1112 if (opc == OPC_MXU_D16MAX) {
> 1113 tcg_gen_smax_i3
On 3/16/21 11:26 AM, Philippe Mathieu-Daudé wrote:
> On 3/16/21 10:02 AM, Philippe Mathieu-Daudé wrote:
>> On 3/16/21 7:51 AM, Markus Armbruster wrote:
>>> Eric Blake writes:
>>>
On 3/11/21 5:11 PM, Philippe Mathieu-Daudé wrote:
>>> [...]
> diff --git a/accel/accel-qmp.c b/accel/accel-qmp
Patchew URL:
https://patchew.org/QEMU/20210316104745.2196286-1-kra...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210316104745.2196286-1-kra...@redhat.com
Subject: [PULL 0/3] Audio 20210316 patches
On Mon, 15 Mar 2021 at 22:04, Peter Maydell wrote:
>
> On Mon, 15 Mar 2021 at 17:47, Paolo Bonzini wrote:
> >
> > The following changes since commit 51204c2f188ec1e2a38f14718d38a3772f850a4b:
> >
> > Merge remote-tracking branch
> > 'remotes/bkoppelmann2/tags/pull-tricore-20210314' into staging
TYPE_VIA_PM calls apm_init() in via_pm_realize(), so
requires APM to be selected.
Reported-by: BALATON Zoltan
Signed-off-by: Philippe Mathieu-Daudé
---
Rebased on usb-20210315-pull-request
Based-on: <20210315180240.1597240-1-kra...@redhat.com>
---
hw/isa/Kconfig | 1 +
1 file changed, 1 inserti
* Thomas Huth (th...@redhat.com) wrote:
> On 15/03/2021 22.05, Philippe Mathieu-Daudé wrote:
> > Hi Thomas,
> >
> > +Alex
> >
> > On 3/15/21 8:07 PM, Thomas Huth wrote:
> > > The CONFIG_VFIO switch only works in target specific code. Since
> > > migration/migration.c is common code, the #ifdef do
tags/pull-9p-20210316
for you to fetch changes up to e4fd889f51094a8e76274ca1e9e0ed70375166f0:
hw/9pfs/9p-synth: Replaced qemu_mutex_lock with QEMU_LOCK_GUARD (2021-03-16
11:41:49 +0100)
9pfs: code cleanup
* Use lock-guard desi
From: Mahmoud Mandour
Replaced a call to qemu_mutex_lock and its respective call to
qemu_mutex_unlock and used QEMU_LOCK_GUARD macro in their place.
This simplifies the code by removing the call required to unlock
and also eliminates goto paths.
Signed-off-by: Mahmoud Mandour
Acked-by: Greg Kur
On 3/16/21 10:01 AM, Laurent Vivier wrote:
> Le 15/03/2021 à 13:33, BALATON Zoltan a écrit :
>> On Sat, 13 Mar 2021, BALATON Zoltan wrote:
>>> On Wed, 10 Mar 2021, BALATON Zoltan wrote:
Hello,
>>>
>>> I've started posting this series well in advance to get it into 6.0 and yet
>>> it seems lik
Any pointers about this issue? Any other steps needs to be followed to
resolve the issue?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1880518
Title:
issue while installing docker inside s390x con
On 3/16/21 11:51 AM, Peter Maydell wrote:
> On Mon, 15 Mar 2021 at 22:39, Philippe Mathieu-Daudé wrote:
>>
>> Coverity reported (CID 1450831) an array overrun in
>> gen_mxu_D16MAX_D16MIN():
>>
>> 1103 } else if (unlikely((XRb == 0) || (XRa == 0))) {
>>
>> 1112 if (opc == OPC
Add a helper to pad a short Ethernet frame to the minimum required
length, which can be used by backend codes.
Signed-off-by: Bin Meng
---
Changes in v4:
- change 'ethernet' to 'Ethernet'
- do not inline the helper
- check the padded buffer size to avoid buffer overflow
Changes in v3:
- use 'w
The minimum Ethernet frame length is 60 bytes. For short frames with
smaller length like ARP packets (only 42 bytes), on a real world NIC
it can choose either padding its length to the minimum required 60
bytes, or sending it out directly to the wire. Such behavior can be
hardcoded or controled by
This adds a flag in NetClientState, so that a net client can tell
its peer that the packets do not need to be padded to the minimum
size of an Ethernet frame (60 bytes) before sending to it.
Signed-off-by: Bin Meng
Reviewed-by: Philippe Mathieu-Daudé
---
(no changes since v3)
Changes in v3:
-
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
Signed-off-by: Bin Meng
---
(no changes since v1)
hw/net/i82596.c | 18 --
1 file changed, 18 deletions(-)
diff --git a/hw/net/i82596.c b/hw/net/i825
The minimum Ethernet frame length is 60 bytes. For short frames with
smaller length like ARP packets (only 42 bytes), on a real world NIC
it can choose either padding its length to the minimum required 60
bytes, or sending it out directly to the wire. Such behavior can be
hardcoded or controled by
For virtio-net, there is no need to pad the Ethernet frame size to
60 bytes before sending to it.
Signed-off-by: Bin Meng
---
(no changes since v1)
hw/net/virtio-net.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 96a3cc8357..66b9ff4511
1 - 100 of 590 matches
Mail list logo
