[PULL 23/39] hw/timer/sse-timer: Propagate eventual error in sse_timer_realize()

2021-03-12 Thread Peter Maydell
From: Philippe Mathieu-Daudé If the SSECounter link is absent, we set an error message in sse_timer_realize() but forgot to propagate this error. Add the missing 'return'. Fixes: CID 1450755 (Null pointer dereferences) Signed-off-by: Philippe Mathieu-Daudé Message-id: 20210312001845.1562670-1-f

[PULL 20/39] tests/acceptance/boot_linux_console: change URL for test_arm_orangepi_bionic_20_08

2021-03-12 Thread Peter Maydell
From: Niek Linnenbank Update the download URL of the Armbian 20.08 Bionic image for test_arm_orangepi_bionic_20_08 of the orangepi-pc machine. The archive.armbian.com URL contains more images and should keep stable for a longer period of time than dl.armbian.com. Signed-off-by: Niek Linnenbank

[PULL 18/39] hw/net/allwinner-sun8i-emac: traverse transmit queue using TX_CUR_DESC register value

2021-03-12 Thread Peter Maydell
From: Niek Linnenbank Currently the emulated EMAC for sun8i always traverses the transmit queue from the head when transferring packets. It searches for a list of consecutive descriptors whichs are flagged as ready for processing and transmits their payloads accordingly. The controller stops pro

[PULL 14/39] target/arm: Update BRKA, BRKB, BRKN for PREDDESC

2021-03-12 Thread Peter Maydell
From: Richard Henderson Since b64ee454a4a0, all predicate operations should be using these field macros for predicates. Signed-off-by: Richard Henderson Message-id: 20210309155305.11301-6-richard.hender...@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/sve_

[PULL 22/39] tests/acceptance: drop ARMBIAN_ARTIFACTS_CACHED condition for orangepi-pc, cubieboard tests

2021-03-12 Thread Peter Maydell
From: Niek Linnenbank Previously the ARMBIAN_ARTIFACTS_CACHED pre-condition was added to allow running tests that have already existing armbian.com artifacts stored in the local avocado cache, but do not have working URLs to download a fresh copy. At this time of writing the URLs for artifacts

[PULL 21/39] tests/acceptance: update sunxi kernel from armbian to 5.10.16

2021-03-12 Thread Peter Maydell
From: Niek Linnenbank The linux kernel 4.20.7 binary for sunxi has been removed from apt.armbian.com: $ ARMBIAN_ARTIFACTS_CACHED=yes AVOCADO_ALLOW_LARGE_STORAGE=yes avocado --show=app,console run -t machine:orangepi-pc tests/acceptance/boot_linux_console.py Fetching asset from tests/accep

[PULL 24/39] accel: kvm: Fix kvm_type invocation

2021-03-12 Thread Peter Maydell
From: Andrew Jones Prior to commit f2ce39b4f067 a MachineClass kvm_type method only needed to be registered to ensure it would be executed. With commit f2ce39b4f067 a kvm-type machine property must also be specified. hw/arm/virt relies on the kvm_type method to pass its selected IPA limit to KVM,

[PULL 08/39] hw/arm/smmuv3: Fix SMMU_CMD_CFGI_STE_RANGE handling

2021-03-12 Thread Peter Maydell
From: Eric Auger If the whole SID range (32b) is invalidated (SMMU_CMD_CFGI_ALL), @end overflows and we fail to handle the command properly. Once this gets fixed, the current code really is awkward in the sense it loops over the whole range instead of removing the currently cached configs throug

[PULL 35/39] hw/display/pxa2xx_lcd: Remove dest_width state field

2021-03-12 Thread Peter Maydell
Since the dest_width is now always 4 because the output surface is 32bpp, we can replace the dest_width state field with a constant. Signed-off-by: Peter Maydell Acked-by: Gerd Hoffmann Message-id: 20210211141515.8755-6-peter.mayd...@linaro.org --- hw/display/pxa2xx_lcd.c | 20 +++--

[PULL 29/39] hw/arm: Connect PWM fans in NPCM7XX boards

2021-03-12 Thread Peter Maydell
From: Hao Wu This patch adds fan_splitters (split IRQs) in NPCM7XX boards. Each fan splitter corresponds to 1 PWM output and can connect to multiple fan inputs (MFT devices). In NPCM7XX boards(NPCM750 EVB and Quanta GSJ boards), we initializes these splitters and connect them to their correspondi

[PULL 19/39] tests/acceptance/boot_linux_console: remove Armbian 19.11.3 bionic test for orangepi-pc machine

2021-03-12 Thread Peter Maydell
From: Niek Linnenbank The image for Armbian 19.11.3 bionic has been removed from the armbian server. Without the image as input the test arm_orangepi_bionic_19_11 cannot run. This commit removes the test completely and merges the code of the generic function do_test_arm_orangepi_uboot_armbian b

[PULL 10/39] target/arm: Fix sve_uzp_p vs odd vector lengths

2021-03-12 Thread Peter Maydell
From: Richard Henderson Missed out on compressing the second half of a predicate with length vl % 512 > 256. Adjust all of the x + (y << s) to x | (y << s) as a general style fix. Drop the extract64 because the input uint64_t are known to be already zero-extended from the current size of the pr

[PULL 28/39] hw/arm: Add MFT device to NPCM7xx Soc

2021-03-12 Thread Peter Maydell
From: Hao Wu This patch adds the recently implemented MFT device to the NPCM7XX SoC file. Reviewed-by: Doug Evans Reviewed-by: Tyrone Ting Signed-off-by: Hao Wu Message-id: 20210311180855.149764-4-wuhao...@google.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- docs/system/a

[PULL 34/39] hw/display/pxa2xx_lcd: Remove dead code for non-32-bpp surfaces

2021-03-12 Thread Peter Maydell
For a long time now the UI layer has guaranteed that the console surface is always 32 bits per pixel. Remove the legacy dead code from the pxa2xx_lcd display device which was handling the possibility that the console surface was some other format. Signed-off-by: Peter Maydell Acked-by: Gerd Hoff

[PULL 26/39] hw/misc: Add GPIOs for duty in NPCM7xx PWM

2021-03-12 Thread Peter Maydell
From: Hao Wu This patch adds GPIOs in NPCM7xx PWM module for its duty values. The purpose of this is to connect it to the MFT module to provide an input for measuring a PWM fan's RPM. Each PWM module has NPCM7XX_PWM_PER_MODULE of GPIOs, each one corresponds to one PWM instance and can connect to

[PULL 25/39] hw/arm/virt: KVM: The IPA lower bound is 32

2021-03-12 Thread Peter Maydell
From: Andrew Jones The virt machine already checks KVM_CAP_ARM_VM_IPA_SIZE to get the upper bound of the IPA size. If that bound is lower than the highest possible GPA for the machine, then QEMU will error out. However, the IPA is set to 40 when the highest GPA is less than or equal to 40, even w

[PULL 36/39] hw/display/pxa2xx: Remove use of BITS in pxa2xx_template.h

2021-03-12 Thread Peter Maydell
Now that BITS is always 32, expand out all its uses in the template header, including removing now-useless uses of the glue() macro. Signed-off-by: Peter Maydell Acked-by: Gerd Hoffmann Message-id: 20210211141515.8755-7-peter.mayd...@linaro.org --- hw/display/pxa2xx_template.h | 110 +++

[PULL 27/39] hw/misc: Add NPCM7XX MFT Module

2021-03-12 Thread Peter Maydell
From: Hao Wu This patch implements Multi Function Timer (MFT) module for NPCM7XX. This module is mainly used to configure PWM fans. It has just enough functionality to make the PWM fan kernel module work. The module takes two input, the max_rpm of a fan (modifiable via QMP) and duty cycle (a GPI

Re: [PULL 00/20] ppc-for-6.0 queue 20210310

2021-03-12 Thread Peter Maydell
On Wed, 10 Mar 2021 at 04:10, David Gibson wrote: > > The following changes since commit b2ae1009d7cca2701e17eae55ae2d44fd22c942a: > > Merge remote-tracking branch 'remotes/mcayland/tags/qemu-sparc-20210307' > into staging (2021-03-09 13:50:35 +) > > are available in the Git repository at:

[PULL 30/39] tests/qtest: Test PWM fan RPM using MFT in PWM test

2021-03-12 Thread Peter Maydell
From: Hao Wu This patch adds testing of PWM fan RPMs in the existing npcm7xx pwm test. It tests whether the MFT module can measure correct fan values for a PWM fan in NPCM7XX boards. Reviewed-by: Doug Evans Reviewed-by: Tyrone Ting Signed-off-by: Hao Wu Reviewed-by: Peter Maydell Message-id:

[PULL 32/39] hw/display/pl110: Pull included-once parts of template header into pl110.c

2021-03-12 Thread Peter Maydell
The pl110_template.h header has a doubly-nested multiple-include pattern: * pl110.c includes it once for each host bit depth (now always 32) * every time it is included, it includes itself 6 times, to account for multiple guest device pixel and byte orders Now we only have to deal with 32-bit

Re: [PATCH] qom: Support JSON in user_creatable_parse_str()

2021-03-12 Thread Eric Blake
On 3/12/21 7:19 AM, Kevin Wolf wrote: > Support JSON for --object in all tools and in HMP object_add in the same > way as it is supported in qobject_input_visitor_new_str(). > > Signed-off-by: Kevin Wolf > --- > Based-on: <20210311144811.313451-1-kw...@redhat.com> > > qom/object_interfaces.c |

[PULL 31/39] hw/display/pl110: Remove dead code for non-32-bpp surfaces

2021-03-12 Thread Peter Maydell
For a long time now the UI layer has guaranteed that the console surface is always 32 bits per pixel. Remove the legacy dead code from the pl110 display device which was handling the possibility that the console surface was some other format. Signed-off-by: Peter Maydell Acked-by: Gerd Hoffmann

[PULL 33/39] hw/display/pl110: Remove use of BITS from pl110_template.h

2021-03-12 Thread Peter Maydell
BITS is always 32, so remove all uses of it from the template header, by dropping the trailing '32' from the draw function names and not constructing the name of rgb_to_pixel32() via the glue() macro. Signed-off-by: Peter Maydell Acked-by: Gerd Hoffmann Message-id: 20210211141515.8755-4-peter.ma

[PATCH 0/3] virtiofsd: Deal with empty filenames

2021-03-12 Thread Greg Kurz
There's no such thing as an empty file name in POSIX-compliant file systems. The current code base doesn't ensure the client doesn't send requests with such empty names. I've audited the code and only found one place where the behavior is somewhat altered in lookup_name() : res = do_statx(lo,

[PULL 38/39] hw/display/pxa2xx: Apply whitespace-only coding style fixes to template header

2021-03-12 Thread Peter Maydell
We're about to move code from the template header into pxa2xx_lcd.c. Before doing that, make coding style fixes so checkpatch doesn't complain about the patch which moves the code. This commit is whitespace changes only: * avoid hard-coded tabs * fix ident on function prototypes * no newline bef

[PULL 37/39] hw/display/pxa2xx: Apply brace-related coding style fixes to template header

2021-03-12 Thread Peter Maydell
We're about to move code from the template header into pxa2xx_lcd.c. Before doing that, make coding style fixes so checkpatch doesn't complain about the patch which moves the code. This commit fixes missing braces in the SKIP_PIXEL() macro definition and in if() statements. Signed-off-by: Peter Ma

[PATCH 3/3] virtiofsd: Don't allow empty filenames

2021-03-12 Thread Greg Kurz
POSIX.1-2017 clearly stipulates that empty filenames aren't allowed ([1] and [2]). Since virtiofsd is supposed to mirror the host file system hierarchy and the host can be assumed to be linux, we don't really expect clients to pass requests with an empty path in it. If they do so anyway, this would

Re: [PULL 03/16] net: validate that ids are well formed

2021-03-12 Thread Paolo Bonzini
On 12/03/21 14:26, Jason Wang wrote: On 2021/3/12 4:44 下午, Paolo Bonzini wrote: On 12/03/21 07:16, Jason Wang wrote: From: Paolo Bonzini When a network or network device is created from the command line or HMP, QemuOpts ensures that the id passes the id_wellformed check. However, QMP skips

[PULL 39/39] hw/display/pxa2xx: Inline template header

2021-03-12 Thread Peter Maydell
The template header is now included only once; just inline its contents in hw/display/pxa2xx_lcd.c. Signed-off-by: Peter Maydell Acked-by: Gerd Hoffmann Message-id: 20210211141515.8755-10-peter.mayd...@linaro.org --- hw/display/pxa2xx_template.h | 434 --- hw/dis

Re: [PATCH v2] net/macos: implement vmnet-based network device

2021-03-12 Thread Phillip Tennen
Markus, thanks for the review. I apologize for my lateness in getting back to you. I've integrated most of your suggestions, and will submit a v5 that incorporates them. I've left a couple comments and questions for you below. Aside: I haven't responded inline to emails like this before, I'm hopi

Re: [PATCH v3] multi-process: Initialize variables declared with g_auto*

2021-03-12 Thread Philippe Mathieu-Daudé
Cc'ing Miroslav On 3/12/21 12:21 PM, Zenghui Yu wrote: > Quote docs/devel/style.rst (section "Automatic memory deallocation"): > > * Variables declared with g_auto* MUST always be initialized, > otherwise the cleanup function will use uninitialized stack memory > > Initialize @name properly to

Re: [PATCH] s390x/cpu_model: use official name for 8562

2021-03-12 Thread Cornelia Huck
On Fri, 12 Mar 2021 14:48:17 +0100 Christian Borntraeger wrote: > On 11.03.21 14:27, Cornelia Huck wrote: > > The single-frame z15 is called "z15 T02". > > > > Signed-off-by: Cornelia Huck > > Acked-by: Christian Borntraeger > > --- > > target/s390x/cpu_models.c | 2 +- > > 1 file change

Re: all class init functions for all types in QEMU are called in select_machine(). Expected?

2021-03-12 Thread Claudio Fontana
On 3/12/21 2:40 PM, Claudio Fontana wrote: > On 3/12/21 1:02 PM, Paolo Bonzini wrote: >> On 12/03/21 12:51, Claudio Fontana wrote: >>> seems to me we already have, as the accel class init, fe, for x86/tcg: >>> >>> static void tcg_cpu_accel_class_init(ObjectClass *oc, void *data) >>> { >>> Acce

[PATCH 1/3] virtiofsd: Don't allow empty paths in lookup_name()

2021-03-12 Thread Greg Kurz
When passed an empty filename, lookup_name() returns the inode of the parent directory, unless the parent is the root in which case the st_dev doesn't match and lo_find() returns NULL. This is because lookup_name() passes AT_EMPTY_PATH down to fstatat() or statx(). This behavior doesn't quite make

Re: [PATCH v3 4/6] util: implement seqcache

2021-03-12 Thread Vladimir Sementsov-Ogievskiy
12.03.2021 16:41, Max Reitz wrote: On 05.03.21 18:35, Vladimir Sementsov-Ogievskiy wrote: Implement cache for small sequential unaligned writes, so that they may be cached until we get a complete cluster and then write it. The cache is intended to be used for backup to qcow2 compressed target o

[PATCH 2/3] virtiofsd: Convert some functions to return bool

2021-03-12 Thread Greg Kurz
Both currently only return 0 or 1. Signed-off-by: Greg Kurz --- tools/virtiofsd/passthrough_ll.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c index 27a6c636dcaf..f63016d35626 100644 --- a/tools/virti

Re: [PATCH v5 5/5] tests/tcg: add HeapInfo checking to semihosting test

2021-03-12 Thread Alex Bennée
Peter Maydell writes: > On Fri, 12 Mar 2021 at 11:24, Alex Benn=C3=A9e wro= > te: >> >> >> Peter Maydell writes: >> >> > On Fri, 12 Mar 2021 at 10:31, Alex Benn=3DC3=3DA9e org> wro=3D >> > te: >> >> >> >> Query the SYS_HEAPINFO semicall and do some basic verification of the >> >> information

Re: [PATCH] s390x/cpu_model: use official name for 8562

2021-03-12 Thread David Hildenbrand
On 12.03.21 14:55, Cornelia Huck wrote: On Fri, 12 Mar 2021 14:48:17 +0100 Christian Borntraeger wrote: On 11.03.21 14:27, Cornelia Huck wrote: The single-frame z15 is called "z15 T02". Signed-off-by: Cornelia Huck Acked-by: Christian Borntraeger --- target/s390x/cpu_models.c | 2 +-

[Bug 1918917] Re: synchronous about on accessing unused I/O ports on aarch64

2021-03-12 Thread Arnd Bergmann
That seems correct, and could probably be improved. In this case, I know that _outb() only writes within the PCI PIO virtual address between fbfffe80 and fb80, which according to the boot log (https://gist.githubusercontent.com/dvyukov/084890d9b4aa7cd54f468e652a9b5881/raw/54c122

Re: [PATCH] qom: Support JSON in user_creatable_parse_str()

2021-03-12 Thread Paolo Bonzini
On 12/03/21 14:59, Eric Blake wrote: On 3/12/21 7:19 AM, Kevin Wolf wrote: Support JSON for --object in all tools and in HMP object_add in the same way as it is supported in qobject_input_visitor_new_str(). Signed-off-by: Kevin Wolf --- Based-on: <20210311144811.313451-1-kw...@redhat.com> q

Re: [PATCH 00/27] Add D-Bus display backend

2021-03-12 Thread Gerd Hoffmann
> On Fri, Mar 12, 2021 at 3:18 PM Gerd Hoffmann wrote: > > > On Fri, Mar 12, 2021 at 02:00:41PM +0400, marcandre.lur...@redhat.com > > wrote: > > > From: Marc-André Lureau > > > > The whole series calls for a splitup. First the bugfixes, which we > > should be able to fast-track for 6.0. Next

[PATCH v2] net: validate that ids are well formed

2021-03-12 Thread Paolo Bonzini
When a network or network device is created from the command line or HMP, QemuOpts ensures that the id passes the id_wellformed check. However, QMP skips this: $ qemu-system-x86_64 -qmp stdio -S -nic user,id=123/456 qemu-system-x86_64: -nic user,id=123/456: Parameter id expects an identifie

Re: [PATCH 00/27] Add D-Bus display backend

2021-03-12 Thread Marc-André Lureau
Hi On Fri, Mar 12, 2021 at 6:37 PM Gerd Hoffmann wrote: > > On Fri, Mar 12, 2021 at 3:18 PM Gerd Hoffmann wrote: > > > > > On Fri, Mar 12, 2021 at 02:00:41PM +0400, marcandre.lur...@redhat.com > > > wrote: > > > > From: Marc-André Lureau > > > > > > The whole series calls for a splitup. First

Re: [PATCH v3 3/6] block/qcow2: introduce inflight writes counters: fix discard

2021-03-12 Thread Max Reitz
On 12.03.21 13:32, Vladimir Sementsov-Ogievskiy wrote: 12.03.2021 14:17, Max Reitz wrote: On 12.03.21 10:09, Vladimir Sementsov-Ogievskiy wrote: 11.03.2021 22:58, Max Reitz wrote: On 05.03.21 18:35, Vladimir Sementsov-Ogievskiy wrote: There is a bug in qcow2: host cluster can be discarded (re

Re: [PATCH v3 3/6] block/qcow2: introduce inflight writes counters: fix discard

2021-03-12 Thread Max Reitz
On 12.03.21 13:42, Vladimir Sementsov-Ogievskiy wrote: 12.03.2021 15:32, Vladimir Sementsov-Ogievskiy wrote: 12.03.2021 14:17, Max Reitz wrote: On 12.03.21 10:09, Vladimir Sementsov-Ogievskiy wrote: 11.03.2021 22:58, Max Reitz wrote: On 05.03.21 18:35, Vladimir Sementsov-Ogievskiy wrote: The

Re: [PATCH v3 3/6] block/qcow2: introduce inflight writes counters: fix discard

2021-03-12 Thread Max Reitz
On 12.03.21 13:46, Vladimir Sementsov-Ogievskiy wrote: 12.03.2021 15:32, Vladimir Sementsov-Ogievskiy wrote: 12.03.2021 14:17, Max Reitz wrote: On 12.03.21 10:09, Vladimir Sementsov-Ogievskiy wrote: 11.03.2021 22:58, Max Reitz wrote: On 05.03.21 18:35, Vladimir Sementsov-Ogievskiy wrote: The

Re: [PULL v2 36/38] hw/block/nvme: support namespace attachment command

2021-03-12 Thread Klaus Jensen
On Mar 12 13:12, Peter Maydell wrote: > On Tue, 9 Mar 2021 at 11:46, Klaus Jensen wrote: > > > > From: Minwoo Im > > > > This patch supports Namespace Attachment command for the pre-defined > > nvme-ns device nodes. Of course, attach/detach namespace should only be > > supported in case 'subsys'

[Bug 1918917] Re: synchronous about on accessing unused I/O ports on aarch64

2021-03-12 Thread Peter Maydell
Is there a test case (all necessary images/files/QEMU command line) I can repro this with ? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1918917 Title: synchronous about on accessing unused I/O po

Re: [RFC PATCH 32/42] docker: Add gentoo-mipsr5900el-cross image

2021-03-12 Thread Philippe Mathieu-Daudé
On 2/20/21 9:01 PM, Philippe Mathieu-Daudé wrote: > On 2/15/21 2:45 PM, Fredrik Noring wrote: >> On Mon, Feb 15, 2021 at 11:59:57AM +, Daniel P. Berrangé wrote: >>> On Sun, Feb 14, 2021 at 06:59:02PM +0100, Philippe Mathieu-Daudé wrote: Add a Docker image providing cross toolchain for the

Re: [PATCH v3 4/6] util: implement seqcache

2021-03-12 Thread Max Reitz
On 12.03.21 15:37, Vladimir Sementsov-Ogievskiy wrote: 12.03.2021 16:41, Max Reitz wrote: On 05.03.21 18:35, Vladimir Sementsov-Ogievskiy wrote: Implement cache for small sequential unaligned writes, so that they may be cached until we get a complete cluster and then write it. The cache is int

Re: [Virtio-fs] [PATCH 2/3] virtiofsd: Convert some functions to return bool

2021-03-12 Thread Connor Kuehl
On 3/12/21 8:10 AM, Greg Kurz wrote: Both currently only return 0 or 1. Signed-off-by: Greg Kurz --- tools/virtiofsd/passthrough_ll.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c index 27a6c636dc

[Bug 1918302] Re: qemu-system-arm segfaults while servicing SYS_HEAPINFO

2021-03-12 Thread Peter Maydell
Note that this only happens for M-profile in system emulation mode. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1918302 Title: qemu-system-arm segfaults while servicing SYS_HEAPINFO Status in QE

Re: [Virtio-fs] [PATCH 1/3] virtiofsd: Don't allow empty paths in lookup_name()

2021-03-12 Thread Connor Kuehl
On 3/12/21 8:10 AM, Greg Kurz wrote: When passed an empty filename, lookup_name() returns the inode of the parent directory, unless the parent is the root in which case the st_dev doesn't match and lo_find() returns NULL. This is because lookup_name() passes AT_EMPTY_PATH down to fstatat() or sta

[Bug 1918302] Re: qemu-system-arm segfaults while servicing SYS_HEAPINFO

2021-03-12 Thread Peter Maydell
...oh, and also for A-profile where we do a boot of firmware and not a Linux-kernel style boot. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1918302 Title: qemu-system-arm segfaults while servicin

Re: [PATCH 14/27] ui: add a D-Bus display backend

2021-03-12 Thread Gerd Hoffmann
> On Fri, Mar 12, 2021 at 3:03 PM Gerd Hoffmann wrote: > > > Hi, > > > > > The "dbus" ui/display backend exports the QEMU consoles over a currently > > > unstable D-Bus protocol defined in ui/dbus-display1.xml (it is subject > > > to changes at each releases, so only client shipped with the sam

[PATCH v10 1/6] arm64: mte: Sync tags for pages where PTE is untagged

2021-03-12 Thread Steven Price
A KVM guest could store tags in a page even if the VMM hasn't mapped the page with PROT_MTE. So when restoring pages from swap we will need to check to see if there are any saved tags even if !pte_tagged(). However don't check pages which are !pte_valid_user() as these will not have been swapped o

Re: [Virtio-fs] [PATCH 3/3] virtiofsd: Don't allow empty filenames

2021-03-12 Thread Connor Kuehl
On 3/12/21 8:10 AM, Greg Kurz wrote: POSIX.1-2017 clearly stipulates that empty filenames aren't allowed ([1] and [2]). Since virtiofsd is supposed to mirror the host file system hierarchy and the host can be assumed to be linux, we don't really expect clients to pass requests with an empty path

Re: [PULL v2 19/38] hw/block/nvme: align zoned.zasl with mdts

2021-03-12 Thread Klaus Jensen
On Mar 12 13:07, Peter Maydell wrote: > On Tue, 9 Mar 2021 at 11:45, Klaus Jensen wrote: > > > > From: Klaus Jensen > > > > ZASL (Zone Append Size Limit) is defined exactly like MDTS (Maximum Data > > Transfer Size), that is, it is a value in units of the minimum memory > > page size (CAP.MPSMIN)

[PATCH v10 5/6] KVM: arm64: ioctl to fetch/store tags in a guest

2021-03-12 Thread Steven Price
The VMM may not wish to have it's own mapping of guest memory mapped with PROT_MTE because this causes problems if the VMM has tag checking enabled (the guest controls the tags in physical RAM and it's unlikely the tags are correct for the VMM). Instead add a new ioctl which allows the VMM to easi

[PATCH v10 2/6] arm64: kvm: Introduce MTE VM feature

2021-03-12 Thread Steven Price
Add a new VM feature 'KVM_ARM_CAP_MTE' which enables memory tagging for a VM. This will expose the feature to the guest and automatically tag memory pages touched by the VM as PG_mte_tagged (and clear the tag storage) to ensure that the guest cannot see stale tags, and so that the tags are correctl

[PATCH v10 6/6] KVM: arm64: Document MTE capability and ioctl

2021-03-12 Thread Steven Price
A new capability (KVM_CAP_ARM_MTE) identifies that the kernel supports granting a guest access to the tags, and provides a mechanism for the VMM to enable it. A new ioctl (KVM_ARM_MTE_COPY_TAGS) provides a simple way for a VMM to access the tags of a guest without having to maintain a PROT_MTE map

[PATCH v10 4/6] arm64: kvm: Expose KVM_ARM_CAP_MTE

2021-03-12 Thread Steven Price
It's now safe for the VMM to enable MTE in a guest, so expose the capability to user space. Signed-off-by: Steven Price --- arch/arm64/kvm/arm.c | 9 + arch/arm64/kvm/sys_regs.c | 3 +++ 2 files changed, 12 insertions(+) diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c inde

Re: [PATCH v3 3/6] block/qcow2: introduce inflight writes counters: fix discard

2021-03-12 Thread Vladimir Sementsov-Ogievskiy
12.03.2021 18:10, Max Reitz wrote: On 12.03.21 13:46, Vladimir Sementsov-Ogievskiy wrote: 12.03.2021 15:32, Vladimir Sementsov-Ogievskiy wrote: 12.03.2021 14:17, Max Reitz wrote: On 12.03.21 10:09, Vladimir Sementsov-Ogievskiy wrote: 11.03.2021 22:58, Max Reitz wrote: On 05.03.21 18:35, Vlad

Re: [PATCH v2(RFC) 0/3] qcow2: fix parallel rewrite and discard

2021-03-12 Thread Kevin Wolf
Am 25.02.2021 um 12:52 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! It occurs that nothing prevents discarding and reallocating host > cluster during data writing. This way data writing will pollute another > newly allocated cluster of data or metadata. > > OK, v2 is a try to solve the

[PATCH] tests/tcg: Run tests on arch variants again

2021-03-12 Thread Philippe Mathieu-Daudé
We used to run the TCG tests for various QEMU targets, but at some points it got restricted to base directories in tests/tcg/. For example, armeb/mipsel/mips64/... targets are currently skipped. The configuration Makefiles in default-configs/targets/ provide all the required information, in partic

Re: [PATCH v1] configure: add option to implicitly enable/disable libgio

2021-03-12 Thread Paolo Bonzini
On 12/03/21 16:14, Denis Plotnikov wrote: Now, compilation of util/dbus is implicit and depends on libgio presence on the building host. The patch adds options to manage libgio dependencies explicitly. Signed-off-by: Denis Plotnikov --- configure | 60 -

[PATCH v1] configure: add option to implicitly enable/disable libgio

2021-03-12 Thread Denis Plotnikov
Now, compilation of util/dbus is implicit and depends on libgio presence on the building host. The patch adds options to manage libgio dependencies explicitly. Signed-off-by: Denis Plotnikov --- configure | 60 --- 1 file changed, 39 insertions

[PATCH v6 09/10] qapi: Implement deprecated-input=reject for QMP command arguments

2021-03-12 Thread Markus Armbruster
This policy rejects deprecated input, and thus permits "testing the future". Implement it for QMP command arguments: reject commands with deprecated ones. Example: when QEMU is run with -compat deprecated-input=reject, then {"execute": "eject", "arguments": {"device": "cd"}} fails like this

[PATCH v6 04/10] qapi: Implement deprecated-output=hide for QMP event data

2021-03-12 Thread Markus Armbruster
This policy suppresses deprecated bits in output, and thus permits "testing the future". Implement it for QMP event data: suppress deprecated members. No QMP event data is deprecated right now. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/test-qmp-event.c

[PATCH v6 01/10] qemu-options: New -compat to set policy for deprecated interfaces

2021-03-12 Thread Markus Armbruster
New option -compat lets you configure what to do when deprecated interfaces get used. This is intended for testing users of the management interfaces. It is experimental. -compat deprecated-input= configures what to do when deprecated input is received. Input policy can be "accept" (accept sile

[PATCH v10 0/6] MTE support for KVM guest

2021-03-12 Thread Steven Price
This series adds support for using the Arm Memory Tagging Extensions (MTE) in a KVM guest. This version is rebased on v5.12-rc2. Changes since v9[1]: * Check fault_status in user_mem_abort() to avoid unnecessarily checking if tags need clearing when handling permission faults. * The MTE CPU

[PATCH v6 03/10] qapi: Implement deprecated-output=hide for QMP events

2021-03-12 Thread Markus Armbruster
This policy suppresses deprecated bits in output, and thus permits "testing the future". Implement it for QMP events: suppress deprecated ones. No QMP event is deprecated right now. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/test-qmp-event.c | 20

Re: [PATCH v3 3/6] block/qcow2: introduce inflight writes counters: fix discard

2021-03-12 Thread Vladimir Sementsov-Ogievskiy
12.03.2021 17:58, Max Reitz wrote: On 12.03.21 13:32, Vladimir Sementsov-Ogievskiy wrote: 12.03.2021 14:17, Max Reitz wrote: On 12.03.21 10:09, Vladimir Sementsov-Ogievskiy wrote: 11.03.2021 22:58, Max Reitz wrote: On 05.03.21 18:35, Vladimir Sementsov-Ogievskiy wrote: There is a bug in qcow

[PATCH v10 3/6] arm64: kvm: Save/restore MTE registers

2021-03-12 Thread Steven Price
Define the new system registers that MTE introduces and context switch them. The MTE feature is still hidden from the ID register as it isn't supported in a VM yet. Signed-off-by: Steven Price --- arch/arm64/include/asm/kvm_host.h | 6 ++ arch/arm64/include/asm/kvm_mte.h | 66

[PATCH v6 05/10] monitor: Drop query-qmp-schema 'gen': false hack

2021-03-12 Thread Markus Armbruster
QMP commands return their response as a generated QAPI type, which the monitor core converts to JSON via QObject. query-qmp-schema's response is the generated introspection data. This is a QLitObject since commit 7d0f982bfb "qapi: generate a literal qobject for introspection", v2.12). Before, it

[PATCH v6 06/10] qapi: Implement deprecated-output=hide for QMP introspection

2021-03-12 Thread Markus Armbruster
This policy suppresses deprecated bits in output, and thus permits "testing the future". Implement it for QMP command query-qmp-schema: suppress information on deprecated commands, events and object type members, i.e. anything that has the special feature flag "deprecated". Signed-off-by: Markus

Re: [PATCH v2(RFC) 0/3] qcow2: fix parallel rewrite and discard

2021-03-12 Thread Vladimir Sementsov-Ogievskiy
12.03.2021 18:24, Kevin Wolf wrote: Am 25.02.2021 um 12:52 hat Vladimir Sementsov-Ogievskiy geschrieben: Hi all! It occurs that nothing prevents discarding and reallocating host cluster during data writing. This way data writing will pollute another newly allocated cluster of data or metadata.

[PATCH v6 08/10] qapi: Implement deprecated-input=reject for QMP commands

2021-03-12 Thread Markus Armbruster
This policy rejects deprecated input, and thus permits "testing the future". Implement it for QMP commands: make deprecated ones fail. Example: when QEMU is run with -compat deprecated-input=reject, then {"execute": "query-cpus"} fails like this {"error": {"class": "CommandNotFound", "d

Re: [PATCH v3 3/6] block/qcow2: introduce inflight writes counters: fix discard

2021-03-12 Thread Max Reitz
On 12.03.21 16:24, Vladimir Sementsov-Ogievskiy wrote: 12.03.2021 18:10, Max Reitz wrote: On 12.03.21 13:46, Vladimir Sementsov-Ogievskiy wrote: 12.03.2021 15:32, Vladimir Sementsov-Ogievskiy wrote: 12.03.2021 14:17, Max Reitz wrote: On 12.03.21 10:09, Vladimir Sementsov-Ogievskiy wrote: 11.

[PATCH 1/2] MAINTAINERS: Mark RX hardware emulation orphan

2021-03-12 Thread Philippe Mathieu-Daudé
Yoshinori Sato doesn't have time to manage QEMU reviews. The code is in good shape and hasn't started to bitrot, so mark the RX target and hardware as orphan to give the possibility to any contributor to step in and fill the gap. Cc: Yoshinori Sato Signed-off-by: Philippe Mathieu-Daudé --- MAI

Re: [Virtio-fs] [PATCH 1/3] virtiofsd: Don't allow empty paths in lookup_name()

2021-03-12 Thread Greg Kurz
On Fri, 12 Mar 2021 09:13:36 -0600 Connor Kuehl wrote: > On 3/12/21 8:10 AM, Greg Kurz wrote: > > When passed an empty filename, lookup_name() returns the inode of > > the parent directory, unless the parent is the root in which case > > the st_dev doesn't match and lo_find() returns NULL. This i

[PATCH v6 02/10] qapi: Implement deprecated-output=hide for QMP command results

2021-03-12 Thread Markus Armbruster
This policy suppresses deprecated bits in output, and thus permits "testing the future". Implement it for QMP command results. Example: when QEMU is run with -compat deprecated-output=hide, then {"execute": "query-cpus-fast"} yields {"return": [{"thread-id": 9805, "props": {"core-id":

[PATCH 2/2] MAINTAINERS: Mark SH-4 hardware emulation orphan

2021-03-12 Thread Philippe Mathieu-Daudé
Yoshinori Sato doesn't have time to manage QEMU reviews. The code is in good shape and hasn't started to bitrot, so mark the SH-4 hardware as orphan to give the possibility to any contributor to step in and fill the gap. CC: Magnus Damm Cc: Aurelien Jarno Cc: Yoshinori Sato Signed-off-by: Phil

[PATCH v6 10/10] qapi: New -compat deprecated-input=crash

2021-03-12 Thread Markus Armbruster
Policy "crash" calls abort() when deprecated input is received. Bugs in integration tests may mask the error from policy "reject". Provide a larger hammer: crash outright. Masking that seems unlikely. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- qapi/compat.json |

[PATCH 0/2] MAINTAINERS: Mark Renesas hardware emulation orphan

2021-03-12 Thread Philippe Mathieu-Daudé
Yoshinori Sato doesn't have time to manage QEMU reviews. The code is in good shape and hasn't started to bitrot, so mark the corresponding sections as orphan to give the possibility to any contributor to step in and fill the gap. Philippe Mathieu-Daudé (2): MAINTAINERS: Mark RX hardware emulati

[PATCH v6 07/10] test-util-sockets: Add stub for monitor_set_cur()

2021-03-12 Thread Markus Armbruster
Without this stub, the next commit fails to link. I suspect the real cause is 947e47448d "monitor: Use getter/setter functions for cur_mon". Cc: Kevin Wolf Signed-off-by: Markus Armbruster --- tests/test-util-sockets.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-util-sockets

[PATCH v6 00/10] Configurable policy for handling deprecated interfaces

2021-03-12 Thread Markus Armbruster
New option -compat lets you configure what to do when deprecated interfaces get used. This is intended for testing users of the management interfaces. It is experimental. -compat deprecated-input= configures what to do when deprecated input is received. Available policies: * accept: Accept dep

finding all the places in an AddressSpace that alias a specific address

2021-03-12 Thread Peter Maydell
I'm trying to fix an issue in Arm M-profile, where on reset the CPU is supposed to load its initial PC and SP from a vector table. This goes wrong if the vector table is in a guest image file (loaded by the rom-blob loader) at address X which is not the same as the vector table address Y but which

Re: [PATCH 05/27] ui: factor out qemu_console_set_display_gl_ctx()

2021-03-12 Thread Philippe Mathieu-Daudé
On 3/12/21 11:00 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The next patch will make use of this function to dissociate > DisplayChangeListener from GL context. > > Signed-off-by: Marc-André Lureau > --- > include/ui/console.h | 2 ++ > ui/console.c | 21

[Bug 1918917] Re: synchronous about on accessing unused I/O ports on aarch64

2021-03-12 Thread Dmitry Vyukov
Uploaded the binary reproducer as: https://storage.googleapis.com/syzkaller/temp/arm64-tty-crash -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1918917 Title: synchronous about on accessing unused I

[PATCH v3 4/5] target/mips: Reintroduce the R5900 CPU

2021-03-12 Thread Philippe Mathieu-Daudé
Now that we have the minimum prerequisites to support the R5900 CPU, we can reintroduce it. While we are reverting commit 823f2897bdd ("Disable R5900 support"), we effectively cherry-pick commit ed4f49ba9bb ("target/mips: Define the R5900 CPU"). This reverts commit 823f2897bdd78185f3ba33292a25105

Re: [PATCH v6 3/3] qmp: add new qmp display-reload

2021-03-12 Thread Markus Armbruster
Zihao Chang writes: > This patch provides a new qmp to reload display configuration > without restart VM, but only reloading the vnc tls certificates > is implemented. > Example: > {"execute": "display-reload", "arguments":{"type": "vnc", "tls-certs": true}} > > Signed-off-by: Zihao Chang > ---

[PATCH v3 0/5] target/mips: Reintroduce the R5900 CPU

2021-03-12 Thread Philippe Mathieu-Daudé
I'm running out of time to address Richard's comments on the new opcodes, so let's KISS and only fix RDHWR (after adding LQ/SQ). Missing review: 3 & 5 - target/mips/tx79: Move RDHWR usermode kludge to trans_SQ() - tests/tcg/mips: Test user mode DMULT for the R5900 Based-on: mips-next Supersedes:

Re: [PATCH] qom: Support JSON in user_creatable_parse_str()

2021-03-12 Thread Markus Armbruster
Is this an alternative to Paolo's "[PATCH 0/3] vl: QAPIfy -object", and if not, how do the two play together?

[PATCH v3 1/5] target/mips/tx79: Introduce LQ opcode (Load Quadword)

2021-03-12 Thread Philippe Mathieu-Daudé
Introduce the LQ opcode (Load Quadword) and remove unreachable code. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20210214175912.732946-26-f4...@amsat.org> Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tx79.decode | 8 target/mips/tra

[PATCH v3 3/5] target/mips/tx79: Move RDHWR usermode kludge to trans_SQ()

2021-03-12 Thread Philippe Mathieu-Daudé
Now than SQ is properly implemented, we can move the RDHWR kludge required to have usermode working with recent glibc. Signed-off-by: Philippe Mathieu-Daudé --- v2: { RDHWR_user } (rth) Fredrik, I'm not understanding fully your discussion with Maciej: https://www.mail-archive.com/qemu-devel@nong

Re: [PATCH v3 3/6] block/qcow2: introduce inflight writes counters: fix discard

2021-03-12 Thread Vladimir Sementsov-Ogievskiy
12.03.2021 18:52, Max Reitz wrote: On 12.03.21 16:24, Vladimir Sementsov-Ogievskiy wrote: 12.03.2021 18:10, Max Reitz wrote: On 12.03.21 13:46, Vladimir Sementsov-Ogievskiy wrote: 12.03.2021 15:32, Vladimir Sementsov-Ogievskiy wrote: 12.03.2021 14:17, Max Reitz wrote: On 12.03.21 10:09, Vlad

[PATCH v3 2/5] target/mips/tx79: Introduce SQ opcode (Store Quadword)

2021-03-12 Thread Philippe Mathieu-Daudé
Introduce the SQ opcode (Store Quadword). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20210214175912.732946-27-f4...@amsat.org> Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tx79.decode | 1 + target/mips/tx79_translate.c | 27 +++

Re: [PATCH] qom: Support JSON in user_creatable_parse_str()

2021-03-12 Thread Kevin Wolf
Am 12.03.2021 um 17:01 hat Markus Armbruster geschrieben: > Is this an alternative to Paolo's "[PATCH 0/3] vl: QAPIfy -object", and > if not, how do the two play together? Paolo's patch adds JSON support to the system emulator CLI (using QemuOpts to stay compatible with the list magic), this patch

<    1   2   3   4   5   >