Re: [PATCH v5 5/7] net/eth: Check iovec has enough data earlier

On Wed, Mar 10, 2021 at 07:26:19PM +0100, Philippe Mathieu-Daudé wrote: On 3/10/21 6:57 PM, Philippe Mathieu-Daudé wrote: On 3/10/21 5:53 PM, Stefano Garzarella wrote: On Wed, Mar 10, 2021 at 05:01:33PM +0100, Philippe Mathieu-Daudé wrote: We want to check fields from ip6_ext_hdr_routing struc

Re: [PATCH v6 1/7] net/eth: Use correct in6_address offset in _eth_get_rss_ex_dst_addr()

On Wed, Mar 10, 2021 at 07:31:17PM +0100, Philippe Mathieu-Daudé wrote: The in6_address comes after the ip6_ext_hdr_routing header, not after the ip6_ext_hdr one. Fix the offset. Cc: qemu-sta...@nongnu.org Reported-by: Stefano Garzarella Fixes: eb700029c78 ("net_pkt: Extend packet abstraction a

[PATCH v1] vhost-user-blk: use different event handlers on init and operation

Commit a1a20d06b73e "vhost-user-blk: delay vhost_user_blk_disconnect" introduced postponing vhost_dev cleanup aiming to eliminate qemu aborts because of connection problems with vhost-blk daemon. However, it introdues a new problem. Now, any communication errors during execution of vhost_dev_init(

Re: [PATCH v3 00/30] qapi/qom: QAPIfy --object and object-add

On 10/03/21 18:30, Kevin Wolf wrote: Am 10.03.2021 um 15:31 hat Paolo Bonzini geschrieben: On 10/03/21 15:22, Peter Krempa wrote: I've stumbled upon a regression with this patchset applied: error: internal error: process exited while connecting to monitor: qemu-system-x86_64: -object memory-

[RESEND PATCH] hw/ppc: e500: Add missing #address-cells and #size-cells in the eTSEC node

From: Bin Meng Per devicetree spec v0.3 [1] chapter 2.3.5: The #address-cells and #size-cells properties are not inherited from ancestors in the devicetree. They shall be explicitly defined. If missing, a client program should assume a default value of 2 for #address-cells, and a value of 1 for

Re: [PATCH v3 00/30] qapi/qom: QAPIfy --object and object-add

On 11/03/21 08:47, Peter Krempa wrote: And for an interleaved list: -object memory-backend-ram,id=ram-node2,size=24578621440,host-nodes=1-2,host-nodes=5,host-nodes=7,policy=bind Uhm, I doubt this works? I would have expected "host-nodes=1-2,,5,,7" instead. Paolo

Re: [PATCH v2] hw/block: m25p80: Support fast read for SST flashes

On Sat, Mar 6, 2021 at 2:01 PM Bin Meng wrote: > > From: Bin Meng > > Per SST25VF016B datasheet [1], SST flash requires a dummy byte after > the address bytes. Note only SPI mode is supported by SST flashes. > > [1] http://ww1.microchip.com/downloads/en/devicedoc/s71271_04.pdf > > Signed-off-by:

Re: [PATCH 2/2] ui/cocoa: Do not rely on the first argument

Hi, > > Having a fallback would still be nice, even if it is just the fixed > > string "qemu". Starting a fresh build without installing it first is > > common while developing. > > > > take care, > > Gerd > > > > It shows "QEMU emulator version %s" just below. Also, it can show the > name e

Re: [PATCH v3 00/30] qapi/qom: QAPIfy --object and object-add

Am 11.03.2021 um 08:47 hat Peter Krempa geschrieben: > On Wed, Mar 10, 2021 at 18:30:44 +0100, Kevin Wolf wrote: > > Am 10.03.2021 um 15:31 hat Paolo Bonzini geschrieben: > > > On 10/03/21 15:22, Peter Krempa wrote: > > [...] > > > The keyval parser would create a list if multiple values are give

Re: [PATCH 3/4] usb: Un-deprecate -usbdevice (except for -usbdevice audio which gets removed)

Thomas Huth writes: > When trying to remove the -usbdevice option, there were complaints that > "-usbdevice braille" is still a very useful shortcut for some people. > Thus we never remove this option. Since it's not such a big burden to > keep it around, and it's also convenient in the sense tha

Re: [PATCH 0/4] Clean up the -usbdevice mess

On Wed, Mar 10, 2021 at 06:33:19PM +0100, Thomas Huth wrote: > "-usbdevice" is still useful for some users. Thus let's clean up the > unwanted parts and make sure that the rest is in a better shape again. > > Paolo Bonzini (2): > usb: remove support for -usbdevice parameters > usb: remove '-us

Re: [PATCH v3 00/30] qapi/qom: QAPIfy --object and object-add

Am 11.03.2021 um 09:14 hat Paolo Bonzini geschrieben: > On 10/03/21 18:30, Kevin Wolf wrote: > > Am 10.03.2021 um 15:31 hat Paolo Bonzini geschrieben: > > > On 10/03/21 15:22, Peter Krempa wrote: > > > > I've stumbled upon a regression with this patchset applied: > > > > > > > > error: internal er

Re: [PATCH v3 00/30] qapi/qom: QAPIfy --object and object-add

On 11/03/21 09:45, Kevin Wolf wrote: I think it's only patch 29 and 30 that we would have to drop, actually. Unfortunately, that still removes one of the most immediately useful features, which is non-scalar properties for -object in the system emulator. But of course, a lot better than not merg

Re: [PATCH v3] ui/cocoa: Clear modifiers whenever possible

Hi, > +switch ([event keyCode]) { > +case kVK_Shift: > +if (!!(modifiers & NSEventModifierFlagShift)) { > +[self toggleKey:Q_KEY_CODE_SHIFT]; > +} Ah, nice, this should get left-shift toggles while holdi

Re: [PATCH] ui/cocoa: Mark variables static

On Thu, Feb 25, 2021 at 05:42:02PM +0900, Akihiko Odaki wrote: > Signed-off-by: Akihiko Odaki Added to UI queue. thanks, Gerd

Re: [PATCH v2] ui/cocoa: Fix mouse association state

On Tue, Feb 23, 2021 at 12:07:14AM +0900, Akihiko Odaki wrote: > ui/cocoa deassociates the mouse input and the mouse cursor > position only when relative movement inputs are expected. Such > inputs may let the mouse cursor leave the view and cause undesired > side effects if they are associated. On

[PATCH v1] softmmu/vl: make default prealloc-threads work w/o -mem-prealloc

Preallocation in memory backends can be specified with either global QEMU option "-mem-prealloc", or with per-backend property "prealloc=true". In the latter case, however, the default for the number of preallocation threads is not set to the number of vcpus, but remains at 1 instead. Fix it by s

Re: [PATCH 6/7] mac_via: fix 60Hz VIA1 timer interval

On 11/03/2021 00:15, BALATON Zoltan wrote: On Wed, 10 Mar 2021, Mark Cave-Ayland wrote: On 10/03/2021 13:24, Laurent Vivier wrote: Le 10/03/2021 à 14:10, Laurent Vivier a écrit : Le 10/03/2021 à 13:56, Laurent Vivier a écrit : Le 10/03/2021 à 13:32, BALATON Zoltan a écrit : On Wed, 10 Mar 2

Re: [PATCH 3/4] usb: Un-deprecate -usbdevice (except for -usbdevice audio which gets removed)

On 11/03/2021 09.38, Markus Armbruster wrote: Thomas Huth writes: When trying to remove the -usbdevice option, there were complaints that "-usbdevice braille" is still a very useful shortcut for some people. Thus we never remove this option. Since it's not such a big burden to keep it around,

IMX FEC model- modification in interrupts

Dear QEMU Team, We have tried to up and running QNX 7.0 on QEMU 5.2.0 Sabrelite model. The QNX reach the prompt and was responsive to user command. However, starting the network caused a QNX freeze. After debugging the problem at QNX and QEMU sites we end up with a solution which requires a sligh

[PATCH 1/9] tpm: Changed a qemu_mutex_lock to QEMU_LOCK_GUARD

Removed a qemu_mutex_lock() and its respective qemu_mutex_unlock() and used QEMU_LOCK_GUARD instead. This simplifies the code by eliminiating gotos and removing the qemu_mutex_unlock() calls. Signed-off-by: Mahmoud Mandour --- backends/tpm/tpm_emulator.c | 8 +++- 1 file changed, 3 insertion

[PATCH 0/9] Changing qemu_mutex_locks to lock guard macros

Hello, This is my first contribution to the qemu project, in which I attempt to replace some usages of qemu_mutex_lock calls and the respective qemu_mutex_unlock calls with QEMU_LOCK_GUARD macros. As it is a matter of subjectivity on which we should base whether we would change qemu_mutex_loc

[PATCH 2/9] block: Replaced qemu_mutex_lock calls with QEMU_LOCK_GUARD

Replaced various qemu_mutex_lock/qemu_mutex_unlock calls with lock guard macros (QEMU_LOCK_GUARD() and WITH_QEMU_LOCK_GUARD). This slightly simplifies the code by eliminating calls to qemu_mutex_unlock and eliminates goto paths. Signed-off-by: Mahmoud Mandour --- block/curl.c | 13 ++-- block/n

[PATCH 5/9] monitor: Replaced qemu_mutex_lock calls with QEMU_LOCK_GUARD

Removed various qemu_mutex_lock and their respective qemu_mutex_unlock calls and used lock guard macros (QEMU_LOCK_GUARD and WITH_QEMU_LOCK_GUARD). This simplifies the code by eliminating qemu_mutex_unlock calls. Signed-off-by: Mahmoud Mandour --- monitor/monitor.c | 8 ++-- monitor/qmp.c

[PATCH 9/9] hw/hyperv/vmbus: replaced qemu_mutex_lock with QEMU_LOCK_GUARD

Replaced some calls to qemu_mutex_lock and their respective qemu_mutex_unlock calls with QEMU_LOCK_GUARD macro. This simplifies the code by removing the calls to qemu_mutex_unlock and eliminates goto paths. Signed-off-by: Mahmoud Mandour --- hw/hyperv/vmbus.c | 13 + 1 file changed,

[PATCH 3/9] char: Replaced a qemu_mutex_lock with QEMU_LOCK_GUARD

Removed a pair of qemu_mutex_lock and its respective qemu_mutex_unlock and used a QEMU_LOCK_GUARD instead. This improves readability by removing the call to qemu_mutex_unlock. Signed-off-by: Mahmoud Mandour --- chardev/char.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/

[PATCH 5/4] usb: Remove "-usbdevice ccid"

"-usbdevice ccid" was not documented and -usbdevice itself was marked as deprecated before QEMU v6.0. And searching for "-usbdevice ccid" in the internet does not show any useful results, so likely nobody was using the ccid device via the -usbdevice option. Remove it now. Signed-off-by: Thomas Hut

[PATCH 4/9] util: Replaced qemu_mutex_lock with QEMU_LOCK_GUARDs

Removed various qemu_mutex_lock calls and their respective qemu_mutex_unlock calls and used QEMU_LOCK_GUARD. This simplifies the code by eliminating various goto paths and removes qemu_mutex_unlock calls. Signed-off-by: Mahmoud Mandour --- util/filemonitor-inotify.c | 24

[PATCH 6/9] migration: Replaced qemu_mutex_lock calls with QEMU_LOCK_GUARD

Replaced various qemu_mutex_lock calls and their respective qemu_mutex_unlock calls with QEMU_LOCK_GUARD macro. This simplifies the code by eliminating the respective qemu_mutex_unlock calls. Signed-off-by: Mahmoud Mandour --- migration/migration.c | 6 ++ migration/ram.c | 6 ++ 2

[PATCH 7/9] virtio-iommu: Replaced qemu_mutex_lock calls with QEMU_LOCK_GUARD

In various places, qemu_mutex_lock calls and their respective calls to qemu_mutex_unlock are replaced with QEMU_LOCK_GUARD macros. This simplifies the code by removing the calls to qemu_mutex_unlock and eliminates goto paths. Signed-off-by: Mahmoud Mandour --- hw/virtio/virtio-iommu.c | 78 +

[PATCH 8/9] hw/9pfs/9p-synth: Replaced qemu_mutex_lock with QEMU_LOCK_GUARD

Replaced a call to qemu_mutex_lock and its respective call to qemu_mutex_unlock and used QEMU_LOCK_GUARD macro in their place. This simplifies the code by removing the call required to unlock and also eliminates goto paths. Signed-off-by: Mahmoud Mandour --- hw/9pfs/9p-synth.c | 12

Re: Question about edge-triggered interrupt

On Thu, 11 Mar 2021 at 02:59, LIU Zhiwei wrote: > Currently, I am writing an interrupt controller (CLIC) for RISC-V. I can't > find a good way to process edge-triggered interrupt. > > According to edge-triggered definition, if I select an edge-triggered > interrupt to serve , it will clean its

Re: [PATCH v2 1/1] docs/devel: Add VFIO device migration documentation

On Thu, Mar 11, 2021 at 12:50:09AM +0530, Tarun Gupta wrote: > Document interfaces used for VFIO device migration. Added flow of state > changes > during live migration with VFIO device. Tested by building docs with the new > vfio-migration.rst file. > > v2: > - Included the new vfio-migration.rs

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On Thu, 11 Mar 2021 at 03:01, Jason Wang wrote: > > > On 2021/3/9 6:13 下午, Peter Maydell wrote: > > On Tue, 9 Mar 2021 at 09:01, Bin Meng wrote: > >> Ah, so we want this: > >> > >> if (sender->info->type != NET_CLIENT_DRIVER_NIC) > >> > >> correct? > > No, option (2) is "always pad short packets

Re: [PATCH 6/7] mac_via: fix 60Hz VIA1 timer interval

Le 11/03/2021 à 10:04, Mark Cave-Ayland a écrit : > On 11/03/2021 00:15, BALATON Zoltan wrote: > >> On Wed, 10 Mar 2021, Mark Cave-Ayland wrote: >>> On 10/03/2021 13:24, Laurent Vivier wrote: Le 10/03/2021 à 14:10, Laurent Vivier a écrit : > Le 10/03/2021 à 13:56, Laurent Vivier a écrit :

Re: [PATCH 6/9] migration: Replaced qemu_mutex_lock calls with QEMU_LOCK_GUARD

* Mahmoud Mandour (ma.mando...@gmail.com) wrote: > Replaced various qemu_mutex_lock calls and their respective > qemu_mutex_unlock calls with QEMU_LOCK_GUARD macro. This simplifies > the code by eliminating the respective qemu_mutex_unlock calls. > > Signed-off-by: Mahmoud Mandour Reviewed-by: D

Re: [PATCH v4 4/4] blockdev: Drop deprecated bogus -drive interface type

On Thu, Mar 11, 2021 at 08:52:21AM +0100, Markus Armbruster wrote: > Drop the crap deprecated in commit a1b40bda08 "blockdev: Deprecate > -drive with bogus interface type" (v5.1.0). > > drive_check_orphaned() no longer depends on qemu_create_cli_devices(). > Call it right after board initializatio

[PATCH] target/riscv: Fix read and write accesses to vsip and vsie

The previous implementation was broken in many ways: - Used mideleg instead of hideleg to mask accesses - Used MIP_VSSIP instead of VS_MODE_INTERRUPTS to mask writes to vsie - Did not shift between S bits and VS bits (VSEIP <-> SEIP, ...) Signed-off-by: Georg Kotheimer --- target/riscv/csr.c

[PATCH] target/riscv: Make VSTIP and VSEIP read-only in hip

Signed-off-by: Georg Kotheimer --- target/riscv/csr.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target/riscv/csr.c b/target/riscv/csr.c index fd2e6363f3..00a3ab72af 100644 --- a/target/riscv/csr.c +++ b/target/riscv/csr.c @@ -420,7 +420,8 @@ static const target_ul

Re: [PATCH 5/9] monitor: Replaced qemu_mutex_lock calls with QEMU_LOCK_GUARD

* Mahmoud Mandour (ma.mando...@gmail.com) wrote: > Removed various qemu_mutex_lock and their respective qemu_mutex_unlock > calls and used lock guard macros (QEMU_LOCK_GUARD and > WITH_QEMU_LOCK_GUARD). This simplifies the code by > eliminating qemu_mutex_unlock calls. > > Signed-off-by: Mahmoud M

Re: [PATCH 6/7] mac_via: fix 60Hz VIA1 timer interval

On 11/03/2021 09:44, Laurent Vivier wrote: Yes indeed, depending upon the documentation it is referred to as either the 60Hz or the 60.15Hz timer. Certainly that's enough information for anyone familiar with Mac internals to understand exactly what you are referring to. There are also plenty o

Re: [PULL v2 00/38] emulated nvme device updates

On Tue, 9 Mar 2021 at 11:45, Klaus Jensen wrote: > > From: Klaus Jensen > > The following changes since commit 229a834518b950d56fd1bc94923276504d0ee9d4: > > Merge remote-tracking branch 'remotes/philmd-gitlab/tags/renesas-20210306' > into staging (2021-03-08 15:45:48 +) > > are available i

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On Thu, Mar 11, 2021 at 5:43 PM Peter Maydell wrote: > > On Thu, 11 Mar 2021 at 03:01, Jason Wang wrote: > > > > > > On 2021/3/9 6:13 下午, Peter Maydell wrote: > > > On Tue, 9 Mar 2021 at 09:01, Bin Meng wrote: > > >> Ah, so we want this: > > >> > > >> if (sender->info->type != NET_CLIENT_DRIVER_

Re: [PATCH v2 2/2] hw/arm/virt: KVM: The IPA lower bound is 32

On Wed, 10 Mar 2021 13:52:18 +, Andrew Jones wrote: > > The virt machine already checks KVM_CAP_ARM_VM_IPA_SIZE to get the > upper bound of the IPA size. If that bound is lower than the highest > possible GPA for the machine, then QEMU will error out. However, the > IPA is set to 40 when the

Re: [PATCH 1/9] tpm: Changed a qemu_mutex_lock to QEMU_LOCK_GUARD

On Thu, Mar 11, 2021 at 1:26 PM Mahmoud Mandour wrote: > Removed a qemu_mutex_lock() and its respective qemu_mutex_unlock() > and used QEMU_LOCK_GUARD instead. This simplifies the code by > eliminiating gotos and removing the qemu_mutex_unlock() calls. > > Signed-off-by: Mahmoud Mandour > Revie

[PATCH v2 0/7] mac_via: fixes and improvements

This patchset consists of a number of mac_via fixes and improvements taken from my attempts to boot MacOS on the q800 machine. Signed-off-by: Mark Cave-Ayland v2: - Rebase on master - Add R-B tags from Laurent - Add VIA_60HZ_TIMER_PERIOD_NS define in patch 6 along with a comment referencing G

[PATCH v2 1/7] mac_via: switch rtc pram trace-events to use hex rather than decimal for addresses

Since all the documentation uses the hex offsets, this makes it much easier to see what is going on. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier --- hw/misc/trace-events | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/trace-events b/hw/misc/trace-

[PATCH v2 2/7] mac_via: fix up adb_via_receive() trace events

The use of the post-increment operator on adb_data_in_index meant that the trace-event was accidentally displaying the next byte in the incoming ADB data buffer rather than the current byte. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier --- hw/misc/mac_via.c | 41 +

[PATCH v2 5/7] mac_via: rename VBL timer to 60Hz timer

According to the "Guide To The Macintosh Family Hardware", the 60Hz VIA1 timer on newer Macs such as the Quadra only exists for compatibility with old software and is no longer synced to the VBL interval. Rename the VBL timer to 60Hz timer to emphasise this and to prevent confusion when the real V

Re: [PATCH 3/9] char: Replaced a qemu_mutex_lock with QEMU_LOCK_GUARD

On Thu, Mar 11, 2021 at 1:28 PM Mahmoud Mandour wrote: > Removed a pair of qemu_mutex_lock and its respective qemu_mutex_unlock > and used a QEMU_LOCK_GUARD instead. This improves readability by > removing the call to qemu_mutex_unlock. > > Signed-off-by: Mahmoud Mandour > Reviewed-by: Marc-And

[PATCH v2 3/7] mac_via: allow long accesses to VIA registers

The MacOS SCSI driver uses a long access to read the VIA registers rather than just a single byte during the message out phase. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier --- hw/misc/mac_via.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/mac_v

[PATCH v2 6/7] mac_via: fix 60Hz VIA1 timer interval

The 60Hz timer is initialised using timer_new_ns() meaning that the timer interval should be measured in ns, and therefore its period is a thousand times too short. Use a define for the 60Hz timer period taking the more precise value as documented in the Guide To The Macintosh Family Hardware. Si

[PATCH v2 4/7] mac_via: don't re-inject ADB response when switching to IDLE state

The current workaround for the Linux ADB state machine in kernels < 5.6 switching the VIA back to IDLE state between send and receive modes is to re-inject the first byte of the response in the IDLE state, and then force the state machine into generating an autopoll reply. In fact what is happeni

[PATCH v2 7/7] mac_via: remove VIA1 timer optimisations

The original implementation of the Macintosh VIA devices in commit 6dca62a000 "hw/m68k: add VIA support" used timer optimisations to reduce high CPU usage on the host when booting Linux. These optimisations worked by waiting until VIA1 port B was accessed before re-arming the timers. The MacOS too

Re: [PATCH v4] target/s390x: Implement the MVPG condition-code-option bit

On Wed, 10 Mar 2021 21:49:22 +0100 David Hildenbrand wrote: > > Am 09.03.2021 um 22:05 schrieb Thomas Huth : > > > > On 04/03/2021 09.10, David Hildenbrand wrote: > >>> On 03.03.21 22:36, Richard Henderson wrote: > >>> On 3/3/21 1:22 PM, David Hildenbrand wrote: > > > Am 03.03.2

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On Thu, 11 Mar 2021 at 09:58, Bin Meng wrote: > > On Thu, Mar 11, 2021 at 5:43 PM Peter Maydell > wrote: > > > > On Thu, 11 Mar 2021 at 03:01, Jason Wang wrote: > > > And after a discussion 10 years ago [1]. Michael (cced) seems to want to > > > keep the padding logic in the NIC itself (probabl

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On Thu, Mar 11, 2021 at 6:22 PM Peter Maydell wrote: > > On Thu, 11 Mar 2021 at 09:58, Bin Meng wrote: > > > > On Thu, Mar 11, 2021 at 5:43 PM Peter Maydell > > wrote: > > > > > > On Thu, 11 Mar 2021 at 03:01, Jason Wang wrote: > > > > And after a discussion 10 years ago [1]. Michael (cced) se

Re: [PATCH 3/4] usb: Un-deprecate -usbdevice (except for -usbdevice audio which gets removed)

On 11/03/21 09:38, Markus Armbruster wrote: If we decide we want something else, keep -usbdevice braille deprecated until something else is ready, then keep it deprecated for a sensible grace period, then remove it. Flip-flopping deprecation in between is not helpful. If we can't make up our m

Re: [PATCH v2] plugins: Expose physical addresses instead of device offsets

Aaron Lindsay writes: > This allows plugins to query for full virtual-to-physical address > translation for a given `qemu_plugin_hwaddr` and stops exposing the > offset within the device itself. As this change breaks the API, > QEMU_PLUGIN_VERSION is incremented. > > Signed-off-by: Aaron Lindsa

[PATCH] target/riscv: Add proper two-stage lookup exception detection

The current two-stage lookup detection in riscv_cpu_do_interrupt falls short of its purpose, as all it checks is whether two-stage address translation either via the hypervisor-load store instructions or the MPRV feature would be allowed. What we really need instead is whether two-stage address tr

[PATCH] target/riscv: Adjust privilege level for HLV(X)/HSV instructions

According to the specification the "field SPVP of hstatus controls the privilege level of the access" for the hypervisor virtual-machine load and store instructions HLV, HLVX and HSV. Signed-off-by: Georg Kotheimer --- target/riscv/cpu_helper.c | 25 ++--- 1 file changed, 14

[PATCH] target/riscv: Use background registers also for MSTATUS_MPV

The current condition for the use of background registers only considers the hypervisor load and store instructions, but not accesses from M mode via MSTATUS_MPRV+MPV. Signed-off-by: Georg Kotheimer --- target/riscv/cpu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 2/7] docs: vhost-user: rewrite section on ring state machine

This section is using the word "back-end" to refer to the "slave's back-end", and talking about the "client" for what the rest of the document calls the "slave". Rework it to free the use of the term "back-end", which in the next patch will replace "slave". Signed-off-by: Paolo Bonzini ---

[PATCH 1/7] docs: vhost-user: clean up request/reply description

It is not necessary to mention which side is sending/receiving each payload; it is more interesting to say which is the request and which is the reply. This also matches what vhost-user-gpu.rst already does. While at it, ensure that all messages list both the request and the reply payload. Signe

Re: [PATCH v1] softmmu/vl: make default prealloc-threads work w/o -mem-prealloc

On 11/03/21 09:59, Denis Plotnikov wrote: Preallocation in memory backends can be specified with either global QEMU option "-mem-prealloc", or with per-backend property "prealloc=true". In the latter case, however, the default for the number of preallocation threads is not set to the number of v

[PATCH v2 0/7] vhost: replace master/slave with more accurate wording

Compared to v1, which only affected the prose of the documentation, I am also changing the message names in the docs and code now. Patch 2 was also adjusted according to Stefan's documentation, and "frontend/backend" (with no hyphen) is used consistently. Paolo Supersedes: <20210226143413.188046

[PATCH 5/7] vhost-user: rename message names from "SLAVE" to "BACKEND"

Follow the terminology that is used in the specification. Signed-off-by: Paolo Bonzini --- hw/virtio/vhost-user.c | 96 +- 1 file changed, 48 insertions(+), 48 deletions(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 2fdd5daf74..dff

[PATCH 6/7] libvhost-user: rename message names from "SLAVE" to "BACKEND"

Follow the terminology that is used in the specification. The old names are preserved for API compatibility. Signed-off-by: Paolo Bonzini --- subprojects/libvhost-user/libvhost-user.c | 20 ++-- subprojects/libvhost-user/libvhost-user.h | 39 --- 2 files changed, 37

[PATCH 3/7] docs: vhost-user: replace master/slave with frontend/backend

This matches the nomenclature that is generally used. Also commonly used is client/server, but it is not as clear because sometimes the frontend exposes a passive (server) socket that the backend connects to. Signed-off-by: Paolo Bonzini --- v1->v2: use frontend/backend instead of the ve

[PATCH 7/7] libvhost-user: rename struct VuDev fields from "slave" to "backend"

Technically these are parts of the API, but the file descriptor seems to be managed by libvhost-user itself only. Nevertheless, I am keeping this as a separate change. Signed-off-by: Paolo Bonzini --- subprojects/libvhost-user/libvhost-user.c | 46 +++ subprojects/libvhost-u

[PATCH 4/7] docs: vhost-user: rename message names from "SLAVE" to "BACKEND"

Follow the terminology that is used in the rest of the document. Signed-off-by: Paolo Bonzini --- docs/interop/vhost-user.rst | 40 ++--- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/docs/interop/vhost-user.rst b/docs/interop/vhost-user.rst inde

Re: [PATCH v3 00/30] qapi/qom: QAPIfy --object and object-add

Kevin Wolf writes: > Am 10.03.2021 um 15:31 hat Paolo Bonzini geschrieben: >> On 10/03/21 15:22, Peter Krempa wrote: >> > I've stumbled upon a regression with this patchset applied: >> > >> > error: internal error: process exited while connecting to monitor: >> > qemu-system-x86_64: -object >>

Re: [PATCH 0/4] ui: add support for 'secret' object to provide VNC/SPICE passwords

Ping On Fri, Feb 19, 2021 at 06:45:52PM +, Daniel P. Berrangé wrote: > This fixes a long standing limitation of the VNC/SPICE code which was > unable to securely accept passswords on the CLI, instead requiring use > of separate monitor commands after startup. > > This takes the opportunity to

Re: [PATCH v2 5/7] mac_via: rename VBL timer to 60Hz timer

On Thu, 11 Mar 2021, Mark Cave-Ayland wrote: According to the "Guide To The Macintosh Family Hardware", the 60Hz VIA1 timer on newer Macs such as the Quadra only exists for compatibility with old software and is no longer synced to the VBL interval. Rename the VBL timer to 60Hz timer to emphasis

Re: [PATCH v2 3/3] target/arm: Restrict v7A TCG cpus to TCG accel

On 2/21/21 11:26 PM, Philippe Mathieu-Daudé wrote: > KVM requires the target cpu to be at least ARMv8 architecture > (support on ARMv7 has been dropped in commit 82bf7ae84ce: > "target/arm: Remove KVM support for 32-bit Arm hosts"). > > A KVM-only build won't be able to run TCG cpus, move the > v7

Re: [PATCH v2 6/7] mac_via: fix 60Hz VIA1 timer interval

On Thu, 11 Mar 2021, Mark Cave-Ayland wrote: The 60Hz timer is initialised using timer_new_ns() meaning that the timer interval should be measured in ns, and therefore its period is a thousand times too short. Use a define for the 60Hz timer period taking the more precise value as documented in

Re: [PATCH v2 0/7] vhost: replace master/slave with more accurate wording

Patchew URL: https://patchew.org/QEMU/20210311103250.532191-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210311103250.532191-1-pbonz...@redhat.com Subject: [PATCH v2 0/7] vhost: replace maste

Re: [PATCH 10/14] hw/scsi: remove 'scsi-disk' device

On Wed, Feb 24, 2021 at 03:26:59PM +0100, Thomas Huth wrote: > On 24/02/2021 14.11, Daniel P. Berrangé wrote: > > The 'scsi-hd' and 'scsi-cd' devices provide suitable alternatives. > > > > Signed-off-by: Daniel P. Berrangé > > --- > > docs/system/deprecated.rst | 9 - > > docs/syste

Re: [PATCH 8/9] hw/9pfs/9p-synth: Replaced qemu_mutex_lock with QEMU_LOCK_GUARD

On Donnerstag, 11. März 2021 04:15:37 CET Mahmoud Mandour wrote: > Replaced a call to qemu_mutex_lock and its respective call to > qemu_mutex_unlock and used QEMU_LOCK_GUARD macro in their place. > This simplifies the code by removing the call required to unlock > and also eliminates goto paths. >

Re: [PATCH v2 0/7] vhost: replace master/slave with more accurate wording

Hi On Thu, Mar 11, 2021 at 2:33 PM Paolo Bonzini wrote: > Compared to v1, which only affected the prose of the documentation, I > am also changing the message names in the docs and code now. > > Patch 2 was also adjusted according to Stefan's documentation, and > "frontend/backend" (with no hyph

[PATCH v5 0/3] vnc: support reload x509 certificates

This series supports reload x509 certificates for vnc 1. Support reload x509 certificates. 2. Support reload vnc certificates. 3. Add new qmp display-reload and implement reload x509 certificates for vnc. Example: {"execute": "display-reload", "arguments":{"vnc-tls-certs": true}} Zihao Chang (3)

[PATCH v5 1/3] crypto: add reload for QCryptoTLSCredsClass

This patch adds reload interface for QCryptoTLSCredsClass and implements the interface for QCryptoTLSCredsX509. Signed-off-by: Zihao Chang --- crypto/tlscredsx509.c | 117 ++ include/crypto/tlscreds.h | 8 ++- 2 files changed, 122 insertions(+), 3 deleti

[PATCH v5 3/3] qmp: add new qmp display-reload

This patch provides a new qmp to reload display configuration without restart VM, but only reloading the vnc tls certificates is implemented. Example: {"execute": "display-reload", "arguments":{"vnc-tls-certs": true}} Signed-off-by: Zihao Chang --- monitor/qmp-cmds.c | 13 + qapi/ui.

[PATCH v5 2/3] vnc: support reload x509 certificates for vnc

This patch add vnc_display_reload_certs() to support update x509 certificates. Signed-off-by: Zihao Chang --- include/ui/console.h | 1 + ui/vnc.c | 28 2 files changed, 29 insertions(+) diff --git a/include/ui/console.h b/include/ui/console.h index c96

Re: [PATCH v3 00/30] qapi/qom: QAPIfy --object and object-add

On 11/03/21 11:38, Markus Armbruster wrote: Here's a differently terrible hack. We have keyval_parse() visitor optarg > QObject > QAPI type Idea: hack the QObject. If we're working for -object, and QObject maps key "qom-type" to value "memory-backend-ram",

Re: [PATCH 1/3] qapi, audio: add query-audiodev command

On Fri, Mar 05, 2021 at 02:01:14PM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > Way back in QEMU 4.0, the -audiodev command line option was introduced > > for configuring audio backends. This CLI option does not use QemuOpts > > so it is not visible for introspection in 'que

Re: [PATCH v4 3/3] qmp: add new qmp display-reload

On 2021/3/9 17:35, Markus Armbruster wrote: > Sorry for the delay, I missed this one. > > Zihao Chang writes: > >> This patch provides a new qmp to reload display configuration >> without restart VM, but only reloading the vnc tls certificates >> is implemented. >> Example: >> {"execute": "di

Re: [PATCH 2/3] qapi, audio: respect build time conditions in audio schema

On Fri, Mar 05, 2021 at 11:56:13AM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Wed, Mar 03, 2021 at 08:00:59AM +0100, Gerd Hoffmann wrote: > >> On Tue, Mar 02, 2021 at 05:55:23PM +, Daniel P. Berrangé wrote: > >> > Currently the -audiodev accepts any audiodev type re

Re: [PATCH v2 0/7] vhost: replace master/slave with more accurate wording

On 11/03/21 11:51, Marc-André Lureau wrote: What about renaming  VhostUserSlaveRequest too ? (subprojects/libvhost-user/libvhost-user.h & hw/virtio/vhost-user.c) I missed it in vhost-user.c (I did rename the values but not the enum), while in libvhost-user.h I'm keeping it for backwards com

Re: [PATCH v5 1/3] crypto: add reload for QCryptoTLSCredsClass

On Thu, Mar 11, 2021 at 06:54:22PM +0800, Zihao Chang wrote: > This patch adds reload interface for QCryptoTLSCredsClass and implements > the interface for QCryptoTLSCredsX509. > > Signed-off-by: Zihao Chang > --- > crypto/tlscredsx509.c | 117 ++ > includ

Re: [PATCH v5 2/3] vnc: support reload x509 certificates for vnc

On Thu, Mar 11, 2021 at 06:54:23PM +0800, Zihao Chang wrote: > This patch add vnc_display_reload_certs() to support > update x509 certificates. > > Signed-off-by: Zihao Chang > --- > include/ui/console.h | 1 + > ui/vnc.c | 28 > 2 files changed, 29 inse

Re: [PATCH 0/4] ui: add support for 'secret' object to provide VNC/SPICE passwords

On Thu, Mar 11, 2021 at 10:37:45AM +, Daniel P. Berrangé wrote: > Ping Looks good but doesn't apply cleanly, can you rebase? (current ui queue is gitlab.com/kraxel/qemu queue/ui, there are no spice/vnc changes queued so it probably doesn't make a difference compared to latest master) take ca

Re: [PATCH v5 3/3] qmp: add new qmp display-reload

On Thu, Mar 11, 2021 at 06:54:24PM +0800, Zihao Chang wrote: > This patch provides a new qmp to reload display configuration > without restart VM, but only reloading the vnc tls certificates > is implemented. > Example: > {"execute": "display-reload", "arguments":{"vnc-tls-certs": true}} > > Signe

Re: [PATCH v2 0/7] vhost: replace master/slave with more accurate wording

Hi On Thu, Mar 11, 2021 at 3:08 PM Paolo Bonzini wrote: > On 11/03/21 11:51, Marc-André Lureau wrote: > > > > > > What about renaming VhostUserSlaveRequest too ? > > (subprojects/libvhost-user/libvhost-user.h & hw/virtio/vhost-user.c) > > > > I missed it in vhost-user.c (I did rename the values

Re: [PATCH 0/4] ui: add support for 'secret' object to provide VNC/SPICE passwords

On Thu, Mar 11, 2021 at 12:13:42PM +0100, Gerd Hoffmann wrote: > On Thu, Mar 11, 2021 at 10:37:45AM +, Daniel P. Berrangé wrote: > > Ping > > Looks good but doesn't apply cleanly, can you rebase? > > (current ui queue is gitlab.com/kraxel/qemu queue/ui, there are no > spice/vnc changes queued

Re: [PATCH v3 00/30] qapi/qom: QAPIfy --object and object-add

On Thu, Mar 11, 2021 at 09:37:11 +0100, Kevin Wolf wrote: > Am 11.03.2021 um 08:47 hat Peter Krempa geschrieben: > > On Wed, Mar 10, 2021 at 18:30:44 +0100, Kevin Wolf wrote: > > > Am 10.03.2021 um 15:31 hat Paolo Bonzini geschrieben: > > > > On 10/03/21 15:22, Peter Krempa wrote: [...] > > -obje

Re: [PATCH v2 0/7] vhost: replace master/slave with more accurate wording

On 11/03/21 12:18, Marc-André Lureau wrote: Hi On Thu, Mar 11, 2021 at 3:08 PM Paolo Bonzini > wrote: On 11/03/21 11:51, Marc-André Lureau wrote: > > > What about renaming  VhostUserSlaveRequest too ? > (subprojects/libvhost-user/libvhost-use

[PATCH] MAINTAINERS: replace Huawei's email to personal one

In order to conveniently receive email, replace the Huawei email address with my personal one. Signed-off-by: Dongjiu Geng --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index e04ae21..823b98b 100644 --- a/MAINTAINERS +++ b/MAINTAINE

Re: [PATCH 3/4] usb: Un-deprecate -usbdevice (except for -usbdevice audio which gets removed)

Hi, > > It is arguably the case for disk, > > serial, net, and host, yet we removed those anyway, to make the regular > > and more expressive interface the only one. > > The problem with those devices was that they used their own parameter > parsing code, Yes, that was IMHO the most important

Re: [PATCH v3 00/30] qapi/qom: QAPIfy --object and object-add

Am 11.03.2021 um 12:24 hat Peter Krempa geschrieben: > On Thu, Mar 11, 2021 at 09:37:11 +0100, Kevin Wolf wrote: > > Am 11.03.2021 um 08:47 hat Peter Krempa geschrieben: > > > On Wed, Mar 10, 2021 at 18:30:44 +0100, Kevin Wolf wrote: > > > > Am 10.03.2021 um 15:31 hat Paolo Bonzini geschrieben: > >

  1   2   3   4   5   6   >