Re: [PATCH 3/4] vhost-user: Monitor slave channel in vhost_user_read()

2021-03-09 Thread Stefan Hajnoczi
On Mon, Mar 08, 2021 at 01:31:40PM +0100, Greg Kurz wrote: > @@ -363,8 +367,30 @@ static int vhost_user_read(struct vhost_dev *dev, > VhostUserMsg *msg) > qemu_chr_be_update_read_handlers(chr->chr, ctxt); > qemu_chr_fe_add_watch(chr, G_IO_IN | G_IO_HUP, vhost_user_read_cb, > &data); >

Re: [PATCH RESEND 3/6] hw/mips/gt64xxx: Fix typos in qemu_log_mask() formats

2021-03-09 Thread BALATON Zoltan
On Tue, 9 Mar 2021, Philippe Mathieu-Daudé wrote: Fix the following typos: - GT_PCI1_CFGDATA is not a timer register but a PCI one, - zero-padding flag is out of the format Fixes: 641ca2bfcd5 ("hw/mips/gt64xxx_pci: Use qemu_log_mask() instead of debug printf()") Signed-off-by: Philippe Mathi

Re: [PATCH RESEND 4/6] hw/mips/gt64xxx: Rename trace events related to interrupt registers

2021-03-09 Thread BALATON Zoltan
On Tue, 9 Mar 2021, Philippe Mathieu-Daudé wrote: We want to trace all register accesses. First rename the current gt64120_read / gt64120_write events with '_intreg' suffix, as they are restricted to interrupt registers. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: BALATON Zoltan ---

[PATCH] hexagon: do not specify inputs to semantics_generated.pyinc generation

2021-03-09 Thread Paolo Bonzini
gen_semantics is an executable, not an input. Meson 0.57 special cases the first argument and @INPUT@ is not expanded there. Fix that by not including it in the input, only in the command. Signed-off-by: Paolo Bonzini --- target/hexagon/meson.build | 3 +-- 1 file changed, 1 insertion(+), 2 de

[PATCH v2] hw/char: disable ibex uart receive if the buffer is full

2021-03-09 Thread Alexander Wagner
Not disabling the UART leads to QEMU overwriting the UART receive buffer with the newest received byte. The rx_level variable is added to allow the use of the existing OpenTitan driver libraries. Signed-off-by: Alexander Wagner --- hw/char/ibex_uart.c | 23 ++- includ

Re: [PATCH RESEND 5/6] hw/mips/gt64xxx: Trace accesses to ISD registers

2021-03-09 Thread BALATON Zoltan
On Tue, 9 Mar 2021, Philippe Mathieu-Daudé wrote: Trace all accesses to Internal Space Decode (ISD) registers. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: BALATON Zoltan --- hw/mips/gt64xxx_pci.c | 2 ++ hw/mips/trace-events | 2 ++ 2 files changed, 4 insertions(+) diff --git a/hw/m

Re: [PATCH RESEND 5/6] hw/mips/gt64xxx: Trace accesses to ISD registers

2021-03-09 Thread BALATON Zoltan
On Tue, 9 Mar 2021, Philippe Mathieu-Daudé wrote: Trace all accesses to Internal Space Decode (ISD) registers. Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/gt64xxx_pci.c | 2 ++ hw/mips/trace-events | 2 ++ 2 files changed, 4 insertions(+) diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64x

Re: [PATCH] hw/char: disable ibex uart receive if the buffer is full

2021-03-09 Thread Alexander Wagner
On 09.03.21 15:29, Alistair Francis wrote: On Tue, Mar 9, 2021 at 2:27 AM Alexander Wagner wrote: On 08.03.21 14:47, Alistair Francis wrote: hw/char/ibex_uart.c | 20 +++- include/hw/char/ibex_uart.h | 4 2 files changed, 19 insertions(+), 5 deletions(-)

Re: [PATCH] virtio-gpu: Add spaces around operator

2021-03-09 Thread Eric Blake
On 3/9/21 1:42 AM, lijiejun wrote: > Fix code style. Operator needs spaces forend sides, and delete line space. What operator? 'break' is a statement, not an operator. > > Signed-off-by: lijiejun > --- > hw/display/virtio-gpu-3d.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >

Re: [PATCH RESEND 2/6] hw/mips/gt64xxx: Simplify ISD MemoryRegion read/write handlers

2021-03-09 Thread BALATON Zoltan
On Tue, 9 Mar 2021, Philippe Mathieu-Daudé wrote: The ISD MemoryRegion is implemented for 32-bit accesses. Simplify it by setting the MemoryRegionOps::impl min/max access size fields. Since the region is registered with a size of 0x1000 bytes, we can remove the hwaddr mask. Signed-off-by: Phili

[PULL 03/17] utils: Enhance testsuite for do_strtosz()

2021-03-09 Thread Eric Blake
Enhance our testsuite coverage of do_strtosz() to cover some things we know that existing users want to continue working (hex bytes), as well as some things that accidentally work but shouldn't (hex fractions) or accidentally fail but that users want to work (64-bit precision on byte values). This

[PATCH] tests/acceptance: Print expected message on wait_for_console_pattern

2021-03-09 Thread Wainer dos Santos Moschetta
For the sake of improve debuggability of tests which use the wait_for_console_pattern(), this changed the _console_interaction() so that the expected message is printed if the test fail. Signed-off-by: Wainer dos Santos Moschetta --- While I was testing "[PATCH v2 2/2] tests/acceptance: Test ast

[PULL 01/17] MAINTAINERS: add Vladimir as co-maintainer of NBD

2021-03-09 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20210304103503.21008-1-vsement...@virtuozzo.com> Reviewed-by: Eric Blake Signed-off-by: Eric Blake --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[PULL 04/17] utils: Improve qemu_strtosz() to have 64 bits of precision

2021-03-09 Thread Eric Blake
We have multiple clients of qemu_strtosz (qemu-io, the opts visitor, the keyval visitor), and it gets annoying that edge-case testing is impacted by implicit rounding to 53 bits of precision due to parsing with strtod(). As an example posted by Rich Jones: $ nbdkit memory $(( 2**63 - 2**30 )) --r

Re: [PATCH RESEND 1/6] hw/mips/gt64xxx: Initialize ISD I/O memory region in DeviceRealize()

2021-03-09 Thread BALATON Zoltan
On Tue, 9 Mar 2021, Philippe Mathieu-Daudé wrote: The ISD I/O region belongs to the TYPE_GT64120_PCI_HOST_BRIDGE, so initialize it before it is realized, not after. Rename the region as 'gt64120-isd' so it is clearer to realize it belongs to the GT64120 in the memory tree view. Signed-off-by: Ph

[PULL 06/17] block: check return value of bdrv_open_child and drop error propagation

2021-03-09 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy This patch is generated by cocci script: @@ symbol bdrv_open_child, errp, local_err; expression file; @@ file = bdrv_open_child(..., -&local_err +errp ); - if (local_err) + if (!file)

[PULL 07/17] blockdev: fix drive_backup_prepare() missed error

2021-03-09 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy We leak local_err and don't report failure to the caller. It's definitely wrong, let's fix. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Greg Kurz Reviewed-by: Alberto Garcia Message-Id: <20210202124956.63146-5-vsement...@virtuozzo.com> Signed-of

[PULL 09/17] block/mirror: drop extra error propagation in commit_active_start()

2021-03-09 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Let's check return value of mirror_start_job to check for failure instead of local_err. Rename ret to job, as ret is usually integer variable. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Greg Kurz Reviewed-by: Alberto Garcia Message-Id: <202102

[Bug 1918302] [NEW] qemu-system-arm segfaults while servicing SYS_HEAPINFO

2021-03-09 Thread Simon Tatham
Public bug reported: I compiled QEMU version 5.2.0 from source on Ubuntu 18.04, and tried to use it to run the attached bare-metal Arm hello-world image, using the command line qemu-system-arm -M microbit -semihosting -nographic -device loader,file=hello.hex The result was that qemu-system-arm i

[PULL 12/17] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface

2021-03-09 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy It's recommended for bool functions with errp to return true on success and false on failure. Non-standard interfaces don't help to understand the code. The change is also needed to reduce error propagation. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed

[PULL 13/17] block/qcow2-bitmap: return status from qcow2_store_persistent_dirty_bitmaps

2021-03-09 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy It's better to return status together with setting errp. It makes possible to avoid error propagation. While being here, put ERRP_GUARD() to fix error_prepend(errp, ...) usage inside qcow2_store_persistent_dirty_bitmaps() (see the comment above ERRP_GUARD() def

[PULL 10/17] blockjob: return status from block_job_set_speed()

2021-03-09 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Better to return status together with setting errp. It allows to avoid error propagation in the caller. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Greg Kurz Reviewed-by: Alberto Garcia Message-Id: <20210202124956.63146-8-vsement...@virtuozzo.co

[PULL 02/17] nbd: server: Report holes for raw images

2021-03-09 Thread Eric Blake
From: Nir Soffer When querying image extents for raw image, qemu-nbd reports holes as zero: $ qemu-nbd -t -r -f raw empty-6g.raw $ qemu-img map --output json nbd://localhost [{ "start": 0, "length": 6442450944, "depth": 0, "zero": true, "data": true, "offset": 0}] $ qemu-img map --output json

[PULL 11/17] block/qcow2: qcow2_get_specific_info(): drop error propagation

2021-03-09 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Don't use error propagation in qcow2_get_specific_info(). For this refactor qcow2_get_bitmap_info_list, its current interface is rather weird. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20210202124956.63146-9-vsement...@virtuozzo.com> Reviewed-by

Re: [PATCH RESEND 6/6] hw/mips/gt64xxx: Let the GT64120 manage the lower 512MiB hole

2021-03-09 Thread BALATON Zoltan
On Tue, 9 Mar 2021, Philippe Mathieu-Daudé wrote: Per the comment in the Malta board, the [0x.-0x2000.] range is decoded by the GT64120, so move the "empty_slot" there. I don't know anything about it to be able to review but is this a feature of the GT64120 chip (in which case the

[PULL 14/17] block/qcow2: read_cache_sizes: return status value

2021-03-09 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy It's better to return status together with setting errp. It allows to reduce error propagation. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Greg Kurz Reviewed-by: Alberto Garcia Message-Id: <20210202124956.63146-12-vsement...@virtuozzo.com> Sign

[PULL 00/17] NBD patches through 2021-03-09

2021-03-09 Thread Eric Blake
The following changes since commit 0436c55edf6b357ff56e2a5bf688df8636f83456: Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into staging (2021-03-08 13:51:41 +) are available in the Git repository at: https://repo.or.cz/qemu/ericb.git tags/pull-nbd-2021-03-09 f

[PULL 16/17] block/qed: bdrv_qed_do_open: deal with errp

2021-03-09 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Always set errp on failure. The generic bdrv_open_driver supports driver functions which can return a negative value but forget to set errp. That's a strange thing. Let's improve bdrv_qed_do_open to not behave this way. This allows the simplification of code in

[PATCH v4 2/8] target/arm: Fix sve_zip_p vs odd vector lengths

2021-03-09 Thread Richard Henderson
Wrote too much with low-half zip (zip1) with vl % 512 != 0. Adjust all of the x + (y << s) to x | (y << s) as a style fix. We only ever have exact overlap between D, M, and N. Therefore we only need a single temporary, and we do not need to check for partial overlap. Reported-by: Laurent Desnog

[PULL 05/17] utils: Deprecate hex-with-suffix sizes

2021-03-09 Thread Eric Blake
Supporting '0x20M' looks odd, particularly since we have a 'B' suffix that is ambiguous for bytes, as well as a less-frequently-used 'E' suffix for extremely large exibytes. In practice, people using hex inputs are specifying values in bytes (and would have written 0x200, or possibly relied on

Re: [PATCH v5 4/8] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt82c686b_isa on it

2021-03-09 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Thu, Mar 04, 2021 at 11:42:10PM +0100, Philippe Mathieu-Daudé wrote: > > On 3/4/21 9:16 PM, BALATON Zoltan wrote: > > > On Thu, 4 Mar 2021, Philippe Mathieu-Daudé wrote: > > >> On 3/2/21 10:11 PM, BALATON Zoltan wrote: > > >>> To allow reusin

[PULL 15/17] block/qcow2: simplify qcow2_co_invalidate_cache()

2021-03-09 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy qcow2_do_open correctly sets errp on each failure path. So, we can simplify code in qcow2_co_invalidate_cache() and drop explicit error propagation. Add ERRP_GUARD() as mandated by the documentation in include/qapi/error.h so that error_prepend() is actually ca

[PATCH v4 3/8] target/arm: Fix sve_punpk_p vs odd vector lengths

2021-03-09 Thread Richard Henderson
Wrote too much with punpk1 with vl % 512 != 0. Reviewed-by: Peter Maydell Reported-by: Laurent Desnogues Signed-off-by: Richard Henderson --- target/arm/sve_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c index

[PULL 08/17] block: drop extra error propagation for bdrv_set_backing_hd

2021-03-09 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy bdrv_set_backing_hd now returns status, let's use it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Greg Kurz Reviewed-by: Alberto Garcia Message-Id: <20210202124956.63146-6-vsement...@virtuozzo.com> Signed-off-by: Eric Blake --- block.c | 6 ++-

[PATCH v4 0/8] target/arm: sve1 fixes

2021-03-09 Thread Richard Henderson
Three of these have been hanging around on a queue for ages; the rest are new. The WHILE and reduction bugs were found by RISU triggering an assertion on 384-bit (vq=3) vectors. r~ Richard Henderson (8): target/arm: Fix sve_uzp_p vs odd vector lengths target/arm: Fix sve_zip_p vs odd vecto

[PATCH] tests/migration: fix unix socket migration

2021-03-09 Thread huangy81
From: Hyman The test aborts and error message as the following be throwed: "No such file or directory: '/var/tmp/qemu-migrate-{pid}.migrate", when the unix socket migration test nearly done. The reason is qemu removes the unix socket file after migration before guestperf.py script do it. So pre-c

[PATCH v4 4/8] target/arm: Update find_last_active for PREDDESC

2021-03-09 Thread Richard Henderson
Since b64ee454a4a0, all predicate operations should be using these field macros for predicates. Signed-off-by: Richard Henderson --- target/arm/sve_helper.c| 6 +++--- target/arm/translate-sve.c | 7 +++ 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/target/arm/sve_helper

[PULL 17/17] block/qcow2: refactor qcow2_update_options_prepare error paths

2021-03-09 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Keep setting ret close to setting errp and don't merge different error paths into one. This way it's more obvious that we don't return error without setting errp. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Message-Id: <20210202124

Re: [PULL 00/42] qemu-sparc queue 20210307

2021-03-09 Thread Peter Maydell
On Sun, 7 Mar 2021 at 12:09, Mark Cave-Ayland wrote: > > The following changes since commit 91e92cad67caca3bc4b8e920ddb5c8ca64aac9e1: > > Merge remote-tracking branch 'remotes/cohuck-gitlab/tags/s390x-20210305' > into staging (2021-03-05 19:04:47 +) > > are available in the Git repository a

[PATCH v4 1/8] target/arm: Fix sve_uzp_p vs odd vector lengths

2021-03-09 Thread Richard Henderson
Missed out on compressing the second half of a predicate with length vl % 512 > 256. Adjust all of the x + (y << s) to x | (y << s) as a general style fix. Drop the extract64 because the input uint64_t are known to be already zero-extended from the current size of the predicate. Reported-by: Lau

[PATCH v4 6/8] target/arm: Update CNTP for PREDDESC

2021-03-09 Thread Richard Henderson
Since b64ee454a4a0, all predicate operations should be using these field macros for predicates. Signed-off-by: Richard Henderson --- target/arm/sve_helper.c| 6 +++--- target/arm/translate-sve.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/arm/sve_helper.

Re: [PATCH v3 4/4] blockdev: Drop deprecated bogus -drive interface type

2021-03-09 Thread Daniel P . Berrangé
On Tue, Mar 09, 2021 at 05:12:13PM +0100, Markus Armbruster wrote: > Drop the crap deprecated in commit a1b40bda08 "blockdev: Deprecate > -drive with bogus interface type" (v5.1.0). > > Signed-off-by: Markus Armbruster > --- > docs/system/deprecated.rst | 7 -- > docs/system/removed-f

[PATCH v4 8/8] target/arm: Update sve reduction vs simd_desc

2021-03-09 Thread Richard Henderson
With the reduction operations, we intentionally increase maxsz to the next power of 2, so as to fill out the reduction tree correctly. Since e2e7168a214b, oprsz must equal maxsz, with exceptions for small vectors, so this triggers an assertion for vector sizes > 32 that are not themselves a power o

[PATCH v4 5/8] target/arm: Update BRKA, BRKB, BRKN for PREDDESC

2021-03-09 Thread Richard Henderson
Since b64ee454a4a0, all predicate operations should be using these field macros for predicates. Signed-off-by: Richard Henderson --- target/arm/sve_helper.c| 30 ++ target/arm/translate-sve.c | 4 ++-- 2 files changed, 16 insertions(+), 18 deletions(-) diff --gi

[PATCH v2] hw/input: expand trace info reported for ps2 device

2021-03-09 Thread Daniel P . Berrangé
It is interesting to know if the PS2 keyboard is in translated mode, and which of the three scancode sets are in use. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- hw/input/ps2.c| 3 ++- hw/input/trace-events | 2 +- 2 files changed, 3 insertions(+), 2 deleti

[PATCH v4 03/78] target/arm: Implement SVE2 integer pairwise add and accumulate long

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 14 target/arm/sve.decode | 5 + target/arm/sve_helper.c| 44 ++ target/arm/translate-sve.c | 39 + 4 files changed, 102 insertions(+)

Re: Malfunctionning qemu-system-arm ?

2021-03-09 Thread vincent Dupaquis
Alistair, I am pretty sure that stepping-in somehow solves the issue, I did want to see where the problem appeared and this behaviour was making it very difficult to spot :/ Regards, Vincent. Le 09/03/2021 à 15:19, Alistair Francis a écrit : On Mon, Feb 15, 2021 at 11:37 AM vincent Dupaqui

[PATCH v4 7/8] target/arm: Update WHILE for PREDDESC

2021-03-09 Thread Richard Henderson
Since b64ee454a4a0, all predicate operations should be using these field macros for predicates. Signed-off-by: Richard Henderson --- target/arm/sve_helper.c| 4 ++-- target/arm/translate-sve.c | 7 --- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/target/arm/sve_helper.c

Re: Malfunctionning qemu-system-arm ?

2021-03-09 Thread vincent Dupaquis
Liviu, Thanks for the responses, I'll have a check on this. The issue not testing with the HAL is that as most people use it, qemu on these platforms is a bit useless for emulation. On the other hand, it would be more on ST to invest on making those emulations running ... Best regards, Vi

[PATCH v4 04/78] target/arm: Implement SVE2 integer unary operations (predicated)

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- v2: Fix sqabs, sqneg (laurent desnogues) --- target/arm/helper-sve.h| 13 +++ target/arm/sve.decode | 7 ++ target/arm/sve_helper.c| 29 +++ target/arm/translate-sve.c | 47 ++ 4

Re: [PATCH v2 2/2] accel: kvm: Add aligment assert for kvm_log_clear_one_slot

2021-03-09 Thread Peter Xu
On Tue, Mar 09, 2021 at 02:57:53PM +, Dr. David Alan Gilbert wrote: > * Thomas Huth (th...@redhat.com) wrote: > > On 09/03/2021 15.05, Keqian Zhu wrote: > > > > > > > > > On 2021/3/9 21:48, Thomas Huth wrote: > > > > On 17/12/2020 02.49, Keqian Zhu wrote: > > > > > The parameters start and si

Re: [PATCH RFC 1/4] hw/block/nvme: convert dsm to aiocb

2021-03-09 Thread Stefan Hajnoczi
On Mon, Mar 08, 2021 at 07:05:40PM +0100, Klaus Jensen wrote: > On Mar 8 16:37, Stefan Hajnoczi wrote: > > On Tue, Mar 02, 2021 at 12:10:37PM +0100, Klaus Jensen wrote: > > > +static void nvme_dsm_cancel(BlockAIOCB *aiocb) > > > +{ > > > +NvmeDSMAIOCB *iocb = container_of(aiocb, NvmeDSMAIOCB,

[PATCH v4 06/78] target/arm: Implement SVE2 saturating/rounding bitwise shift left (predicated)

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- v2: Shift values are always signed (laurent desnogues). --- target/arm/helper-sve.h| 54 ++ target/arm/sve.decode | 17 + target/arm/sve_helper.c| 78 ++ target/arm/translate-sve.

[PATCH v3 4/4] blockdev: Drop deprecated bogus -drive interface type

2021-03-09 Thread Markus Armbruster
Drop the crap deprecated in commit a1b40bda08 "blockdev: Deprecate -drive with bogus interface type" (v5.1.0). Signed-off-by: Markus Armbruster --- docs/system/deprecated.rst | 7 -- docs/system/removed-features.rst | 7 ++ include/sysemu/blockdev.h| 1 - blockdev.c

Re: Malfunctionning qemu-system-arm ?

2021-03-09 Thread Liviu Ionescu
> On 9 Mar 2021, at 17:58, vincent Dupaquis > wrote: > > Thanks for the responses, I'll have a check on this. It is based on a bit old version of QEMU, but it is fully functional for the peripherals used by the CubeMX initialisations. I use it to run unit-tests, as semihosted applications,

[PATCH v4 07/78] target/arm: Implement SVE2 integer halving add/subtract (predicated)

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 54 ++ target/arm/sve.decode | 11 target/arm/sve_helper.c| 39 +++ target/arm/translate-sve.c | 8 ++ 4 files changed, 112 insertions(+) diff --gi

[PATCH v3 0/4] Drop deprecated floppy config & bogus -drive if=T

2021-03-09 Thread Markus Armbruster
v3: * PATCH 1: New [Daniel] v2: * Rebased, straightforward conflict with commit f5d33dd51f "hw/block/fdc: Remove the check_media_rate property" resolved * PATCH 2: Commit message fixed [Kevin] Markus Armbruster (3): fdc: Drop deprecated floppy configuration fdc: Inline fdctrl_connect_drives

[PATCH v3 3/4] fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common()

2021-03-09 Thread Markus Armbruster
The previous commit rendered the name fdctrl_connect_drives() somewhat misleading. Get rid of it by inlining the (now pretty simple) function into its only caller. Signed-off-by: Markus Armbruster --- hw/block/fdc.c | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-)

[PATCH v4 08/78] target/arm: Implement SVE2 integer pairwise arithmetic

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- v2: Load all inputs before writing any output (laurent desnogues) --- target/arm/helper-sve.h| 45 ++ target/arm/sve.decode | 8 target/arm/sve_helper.c| 76 ++ target/arm/translate-sve

Re: [PATCH v3 2/3] migration/ram: Reduce unnecessary rate limiting

2021-03-09 Thread Peter Xu
On Tue, Mar 09, 2021 at 10:33:04PM +0800, Kunkun Jiang wrote: > Hi, > > On 2021/3/9 5:12, Peter Xu wrote: > > On Mon, Mar 08, 2021 at 06:34:58PM +0800, Kunkun Jiang wrote: > > > Hi, > > > > > > On 2021/3/5 22:22, Peter Xu wrote: > > > > Kunkun, > > > > > > > > On Fri, Mar 05, 2021 at 03:50:34PM

[PATCH v3 1/4] docs/system/deprecated: Fix note on fdc drive properties

2021-03-09 Thread Markus Armbruster
Commit 4a27a638e7 "fdc: Deprecate configuring floppies with -global isa-fdc" actually deprecated any use of floppy controller driver properties, not just with -global. Correct the deprecation note accordingly. Fixes: 4a27a638e718b445648de6b27c709353551d9b44 Signed-off-by: Markus Armbruster ---

[PATCH v4 09/78] target/arm: Implement SVE2 saturating add/subtract (predicated)

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 54 +++ target/arm/sve.decode | 11 +++ target/arm/sve_helper.c| 194 ++--- target/arm/translate-sve.c | 7 ++ 4 files changed, 210 insertions(+), 56 deletions(-) diff --git a/t

Re: [PATCH v3 2/4] fdc: Drop deprecated floppy configuration

2021-03-09 Thread Daniel P . Berrangé
On Tue, Mar 09, 2021 at 05:12:11PM +0100, Markus Armbruster wrote: > Drop the crap deprecated in commit 4a27a638e7 "fdc: Deprecate > configuring floppies with -global isa-fdc" (v5.1.0). > > Signed-off-by: Markus Armbruster > --- > docs/system/deprecated.rst | 49 --- > docs/system/removed

Re: [PATCH v3 3/4] fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common()

2021-03-09 Thread Daniel P . Berrangé
On Tue, Mar 09, 2021 at 05:12:12PM +0100, Markus Armbruster wrote: > The previous commit rendered the name fdctrl_connect_drives() somewhat > misleading. Get rid of it by inlining the (now pretty simple) > function into its only caller. > > Signed-off-by: Markus Armbruster > --- > hw/block/fdc.

[PATCH v3 2/4] fdc: Drop deprecated floppy configuration

2021-03-09 Thread Markus Armbruster
Drop the crap deprecated in commit 4a27a638e7 "fdc: Deprecate configuring floppies with -global isa-fdc" (v5.1.0). Signed-off-by: Markus Armbruster --- docs/system/deprecated.rst | 49 --- docs/system/removed-features.rst | 49 +++ hw/block/fdc.c | 54 +-- tests/qemu-i

Re: [PATCH v5 4/8] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt82c686b_isa on it

2021-03-09 Thread BALATON Zoltan
On Tue, 9 Mar 2021, Dr. David Alan Gilbert wrote: * David Gibson (da...@gibson.dropbear.id.au) wrote: On Thu, Mar 04, 2021 at 11:42:10PM +0100, Philippe Mathieu-Daudé wrote: On 3/4/21 9:16 PM, BALATON Zoltan wrote: On Thu, 4 Mar 2021, Philippe Mathieu-Daudé wrote: On 3/2/21 10:11 PM, BALATON

[PATCH v4 12/78] target/arm: Implement SVE2 integer add/subtract wide

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- v2: Fix select offsets (laurent desnogues). --- target/arm/helper-sve.h| 16 target/arm/sve.decode | 12 target/arm/sve_helper.c| 30 ++ target/arm/translate-sve.c | 20

Re: [PATCH v2 2/2] accel: kvm: Add aligment assert for kvm_log_clear_one_slot

2021-03-09 Thread Thomas Huth
On 09/03/2021 15.57, Dr. David Alan Gilbert wrote: * Thomas Huth (th...@redhat.com) wrote: On 09/03/2021 15.05, Keqian Zhu wrote: On 2021/3/9 21:48, Thomas Huth wrote: On 17/12/2020 02.49, Keqian Zhu wrote: The parameters start and size are transfered from QEMU memory emulation layer. It ca

Re: [PATCH v3 1/4] docs/system/deprecated: Fix note on fdc drive properties

2021-03-09 Thread Daniel P . Berrangé
On Tue, Mar 09, 2021 at 05:12:10PM +0100, Markus Armbruster wrote: > Commit 4a27a638e7 "fdc: Deprecate configuring floppies with -global > isa-fdc" actually deprecated any use of floppy controller driver > properties, not just with -global. Correct the deprecation note > accordingly. > > Fixes: 4

[PATCH v4 14/78] target/arm: Implement PMULLB and PMULLT

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu.h | 10 ++ target/arm/helper-sve.h| 1 + target/arm/sve.decode | 2 ++ target/arm/translate-sve.c | 22 ++ target/arm/vec_helper.c| 24 5 files changed, 59 insertions(

[PATCH v4 01/78] target/arm: Add ID_AA64ZFR0 fields and isar_feature_aa64_sve2

2021-03-09 Thread Richard Henderson
Will be used for SVE2 isa subset enablement. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- v2: Do not read zfr0 from kvm unless sve is available. --- target/arm/cpu.h| 16 target/arm/helper.c | 3 +-- target/arm/kvm64.c | 11 +++ 3 files changed, 2

[PATCH v4 02/78] target/arm: Implement SVE2 Integer Multiply - Unpredicated

2021-03-09 Thread Richard Henderson
For MUL, we can rely on generic support. For SMULH and UMULH, create some trivial helpers. For PMUL, back in a21bb78e5817, we organized helper_gvec_pmul_b in preparation for this use. Signed-off-by: Richard Henderson --- target/arm/helper.h| 10 target/arm/sve.decode | 10 +++

Re: [PATCH v2] hw/char: disable ibex uart receive if the buffer is full

2021-03-09 Thread Alistair Francis
On Tue, Mar 9, 2021 at 10:56 AM Alexander Wagner wrote: > > Not disabling the UART leads to QEMU overwriting the UART receive buffer with > the newest received byte. The rx_level variable is added to allow the use of > the existing OpenTitan driver libraries. > > Signed-off-by: Alexander Wagner

[PATCH v4 20/78] target/arm: Implement SVE2 integer add/subtract long with carry

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- v2: Fix sel indexing and argument order (laurent desnogues). --- target/arm/helper-sve.h| 3 +++ target/arm/sve.decode | 6 ++ target/arm/sve_helper.c| 34 ++ target/arm/translate-sve.c | 23 ++

[PATCH v4 11/78] target/arm: Implement SVE2 integer add/subtract interleaved long

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/sve.decode | 6 ++ target/arm/translate-sve.c | 4 2 files changed, 10 insertions(+) diff --git a/target/arm/sve.decode b/target/arm/sve.decode index fbfd57b23a..12be0584a8 100644 --- a/target/arm/sve.decode +++ b/target/arm/sve.decod

[PATCH v4 22/78] target/arm: Implement SVE2 bitwise shift and insert

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/sve.decode | 5 + target/arm/translate-sve.c | 10 ++ 2 files changed, 15 insertions(+) diff --git a/target/arm/sve.decode b/target/arm/sve.decode index d3c4ec6dd1..695a16551e 100644 --- a/target/arm/sve.decode +++ b/target/arm/sv

[PATCH v4 00/78] target/arm: Implement SVE2

2021-03-09 Thread Richard Henderson
After a 6-month hiatus, sve2 is back. This time, with RISU testing vs FVP 11.13.36. Based-on: 20210309155305.11301-1-richard.hender...@linaro.org ("target/arm: sve1 fixes") r~ Richard Henderson (60): target/arm: Add ID_AA64ZFR0 fields and isar_feature_aa64_sve2 target/arm: Implement SVE2

[PATCH v4 10/78] target/arm: Implement SVE2 integer add/subtract long

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- v2: Fix select offsets (laurent desnogues). --- target/arm/helper-sve.h| 24 target/arm/sve.decode | 19 target/arm/sve_helper.c| 43 +++ target/arm/translate-sve.c | 46 +++

[PATCH v4 19/78] target/arm: Implement SVE2 integer absolute difference and accumulate long

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- v2: Fix select offsetting and argument order (laurent desnogues). --- target/arm/helper-sve.h| 14 ++ target/arm/sve.decode | 12 + target/arm/sve_helper.c| 23 target/arm/translate-sve.c | 55 +

[PATCH v4 05/78] target/arm: Split out saturating/rounding shifts from neon

2021-03-09 Thread Richard Henderson
Split these operations out into a header that can be shared between neon and sve. The "sat" pointer acts both as a boolean for control of saturating behavior and controls the difference in behavior between neon and sve -- QC bit or no QC bit. Widen the shift operand in the new helpers, as the SVE

[PATCH v4 13/78] target/arm: Implement SVE2 integer multiply long

2021-03-09 Thread Richard Henderson
Exclude PMULL from this category for the moment. Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 15 +++ target/arm/sve.decode | 9 + target/arm/sve_helper.c| 31 +++ target/arm/translate-sve.c | 9 + 4 files ch

[PATCH v4 32/78] target/arm: Implement SVE2 bitwise ternary operations

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 6 ++ target/arm/sve.decode | 12 +++ target/arm/sve_helper.c| 50 + target/arm/translate-sve.c | 213 + 4 files changed, 281 insertions(+) diff --git a/target/arm/helper-sv

[PATCH v4 21/78] target/arm: Implement SVE2 bitwise shift right and accumulate

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/sve.decode | 8 target/arm/translate-sve.c | 34 ++ 2 files changed, 42 insertions(+) diff --git a/target/arm/sve.decode b/target/arm/sve.decode index 79046d81e3..d3c4ec6dd1 100644 --- a/target/arm/sve

[PATCH v4 17/78] target/arm: Implement SVE2 bitwise permute

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu.h | 5 +++ target/arm/helper-sve.h| 15 target/arm/sve.decode | 6 target/arm/sve_helper.c| 73 ++ target/arm/translate-sve.c | 36 +++ 5 files changed, 1

[PATCH v4 16/78] target/arm: Implement SVE2 bitwise exclusive-or interleaved

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 5 + target/arm/sve.decode | 5 + target/arm/sve_helper.c| 20 target/arm/translate-sve.c | 19 +++ 4 files changed, 49 insertions(+) diff --git a/target/arm/helper-sve.h b/t

[PATCH v4 33/78] target/arm: Implement SVE2 MATCH, NMATCH

2021-03-09 Thread Richard Henderson
From: Stephen Long Reviewed-by: Richard Henderson Signed-off-by: Stephen Long Message-Id: <20200415145915.2859-1-stepl...@quicinc.com> [rth: Expanded comment for do_match2] Signed-off-by: Richard Henderson --- v2: Apply esz_mask to input pg to fix output flags. --- target/arm/helper-sve.h

[PATCH v4 25/78] target/arm: Implement SVE2 floating-point pairwise

2021-03-09 Thread Richard Henderson
From: Stephen Long Signed-off-by: Stephen Long Reviewed-by: Richard Henderson Signed-off-by: Richard Henderson --- v2: Load all inputs before writing any output (laurent desnogues) --- target/arm/helper-sve.h| 35 + target/arm/sve.decode | 8 +++ targ

[PATCH v4 18/78] target/arm: Implement SVE2 complex integer add

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- v2: Fix subtraction ordering (laurent desnogues). --- target/arm/helper-sve.h| 10 + target/arm/sve.decode | 9 target/arm/sve_helper.c| 42 ++ target/arm/translate-sve.c | 31 +

[PATCH v4 15/78] target/arm: Implement SVE2 bitwise shift left long

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 8 ++ target/arm/sve.decode | 8 ++ target/arm/sve_helper.c| 26 ++ target/arm/translate-sve.c | 159 + 4 files changed, 201 insertions(+) diff --git a/target/arm/helper-sve.h

[PATCH v4 26/78] target/arm: Implement SVE2 SHRN, RSHRN

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- v2: Fix typo in gen_shrnb_vec (laurent desnogues) v3: Replace DO_RSHR with an inline function --- target/arm/helper-sve.h| 16 target/arm/sve.decode | 8 ++ target/arm/sve_helper.c| 54 - target/arm/translate-sve.c | 160 +

[PATCH v4 42/78] target/arm: Implement SVE2 HISTCNT, HISTSEG

2021-03-09 Thread Richard Henderson
From: Stephen Long Signed-off-by: Stephen Long Message-Id: <20200416173109.8856-1-stepl...@quicinc.com> Signed-off-by: Richard Henderson --- v2: Fix overlap between output and input vectors. v4: Fix histseg counting (zhiwei). --- target/arm/helper-sve.h| 7 ++ target/arm/sve.decode

[PATCH v4 28/78] target/arm: Implement SVE2 UQSHRN, UQRSHRN

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 16 +++ target/arm/sve.decode | 4 ++ target/arm/sve_helper.c| 24 ++ target/arm/translate-sve.c | 93 ++ 4 files changed, 137 insertions(+) diff --git a/target/arm/helper-

[PATCH v4 23/78] target/arm: Implement SVE2 integer absolute difference and accumulate

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/sve.decode | 6 ++ target/arm/translate-sve.c | 21 + 2 files changed, 27 insertions(+) diff --git a/target/arm/sve.decode b/target/arm/sve.decode index 695a16551e..32b15e4192 100644 --- a/target/arm/sve.decode +++ b/t

[PATCH v4 35/78] target/arm: Implement SVE2 saturating multiply-add high

2021-03-09 Thread Richard Henderson
SVE2 has two additional sizes of the operation and unlike NEON, there is no saturation flag. Create new entry points for SVE2 that do not set QC. Signed-off-by: Richard Henderson --- target/arm/helper.h| 17 target/arm/sve.decode | 5 ++ target/arm/translate-sve.c | 18 +++

[PATCH v4 46/78] target/arm: Implement SVE2 FMMLA

2021-03-09 Thread Richard Henderson
From: Stephen Long Signed-off-by: Stephen Long Message-Id: <20200422165503.13511-1-stepl...@quicinc.com> [rth: Fix indexing in helpers, expand macro to straight functions.] Signed-off-by: Richard Henderson --- target/arm/cpu.h | 10 ++ target/arm/helper-sve.h| 3 ++ target/a

[PATCH v4 30/78] target/arm: Implement SVE2 WHILEGT, WHILEGE, WHILEHI, WHILEHS

2021-03-09 Thread Richard Henderson
Rename the existing sve_while (less-than) helper to sve_whilel to make room for a new sve_whileg helper for greater-than. Signed-off-by: Richard Henderson --- v2: Use a new helper function to implement this. v4: Update for PREDDESC. --- target/arm/helper-sve.h| 3 +- target/arm/sve.decode

[PATCH v4 27/78] target/arm: Implement SVE2 SQSHRUN, SQRSHRUN

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 16 +++ target/arm/sve.decode | 4 ++ target/arm/sve_helper.c| 35 ++ target/arm/translate-sve.c | 98 ++ 4 files changed, 153 insertions(+) diff --git a/target/arm/hel

[PATCH v4 48/78] target/arm: Pass separate addend to {U, S}DOT helpers

2021-03-09 Thread Richard Henderson
For SVE, we potentially have a 4th argument coming from the movprfx instruction. Currently we do not optimize movprfx, so the problem is not visible. Signed-off-by: Richard Henderson --- v4: Fix double addition (zhiwei). --- target/arm/helper.h | 20 +++--- target/arm/sve.decode

[PATCH v4 41/78] target/arm: Implement SVE2 RSUBHNB, RSUBHNT

2021-03-09 Thread Richard Henderson
From: Stephen Long This completes the section 'SVE2 integer add/subtract narrow high part' Signed-off-by: Stephen Long Message-Id: <20200417162231.10374-5-stepl...@quicinc.com> Signed-off-by: Richard Henderson --- v2: Fix round bit type (laurent desnogues) --- target/arm/helper-sve.h| 8

[PATCH v4 34/78] target/arm: Implement SVE2 saturating multiply-add long

2021-03-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 14 ++ target/arm/sve.decode | 14 ++ target/arm/sve_helper.c| 30 + target/arm/translate-sve.c | 54 ++ 4 files changed, 112 insertions(+) diff --gi

<    1   2   3   4   5   6   7   >