Hi Gerd,
> Yes, it surely makes sense to go into that direction.
> The patch as-is doesn't, it breaks the guest/host interface.
> That's ok-ish for a quick proof-of-concept, but clearly not merge-able.
>
> > TODO:
> > - Use Blob resources for getting meta-data such as modifier, format, etc.
>
>
On 2021/3/8 6:22 下午, Peter Maydell wrote:
On Mon, 8 Mar 2021 at 03:48, Jason Wang wrote:
Do we need to care about other type of networking backends? E.g socket.
Or at least we should keep the padding logic if we can't audit all of
the backends.
I think the key thing we need to do here is ma
Hi Marc-Andre,
+create = g_malloc0(sizeof(*create) +
+ res->iov_cnt * sizeof (struct udmabuf_create_item));
+if (!create)
+return NULL;
Pointless allocation check (g_malloc will abort if it failed to allocate)
[Kasireddy, Vivek] Ok, will remove it in v2.
+
Fix code style. Operator needs spaces forend sides, and delete line space.
Signed-off-by: lijiejun
---
hw/display/virtio-gpu-3d.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c
index 9eb4890..d989648 100644
--- a/hw/d
Hi Jason,
On Tue, Mar 9, 2021 at 4:23 PM Jason Wang wrote:
>
>
> On 2021/3/8 6:22 下午, Peter Maydell wrote:
> > On Mon, 8 Mar 2021 at 03:48, Jason Wang wrote:
> >> Do we need to care about other type of networking backends? E.g socket.
> >>
> >> Or at least we should keep the padding logic if we
Hi Peter,
On 3/8/21 5:37 PM, Peter Maydell wrote:
> On Thu, 25 Feb 2021 at 09:15, Eric Auger wrote:
>>
>> If the asid is not set, do not attempt to locate the key directly
>> as all inserted keys have a valid asid.
>>
>> Use g_hash_table_foreach_remove instead.
>>
>> Signed-off-by: Eric Auger
>>
Ping?
Is this patch set being reviewed? Who can help to do this?
Thanks
Zihao
On 2021/2/24 20:34, Zihao Chang wrote:
> This series supports reload x509 certificates for vnc
> 1. Support reload x509 certificates.
> 2. Support reload vnc certificates.
> 3. Add new qmp display-reload and implement
On 3/8/21 6:48 PM, Philippe Mathieu-Daudé wrote:
> On 3/8/21 5:46 PM, Stefan Hajnoczi wrote:
>> On Wed, Feb 24, 2021 at 10:35:15PM +0100, Philippe Mathieu-Daudé wrote:
>>> We don't need to generate trace files for targets we
>>> are not building. Restrict the the ones selected.
>>>
>>> Signed-off-b
On 3/9/21 5:23 AM, Jason Wang wrote:
> Currently, the default msix vectors for virtio-net-pci is 3 which is
> obvious not suitable for multiqueue guest, so we depends on the user
> or management tools to pass a correct vectors parameter. In fact, we
> can simplifying this by calculating the number
On 2021/3/9 4:35 下午, Bin Meng wrote:
Hi Jason,
On Tue, Mar 9, 2021 at 4:23 PM Jason Wang wrote:
On 2021/3/8 6:22 下午, Peter Maydell wrote:
On Mon, 8 Mar 2021 at 03:48, Jason Wang wrote:
Do we need to care about other type of networking backends? E.g socket.
Or at least we should keep the
Hi Jason,
On Tue, Mar 9, 2021 at 4:57 PM Jason Wang wrote:
>
>
> On 2021/3/9 4:35 下午, Bin Meng wrote:
> > Hi Jason,
> >
> > On Tue, Mar 9, 2021 at 4:23 PM Jason Wang wrote:
> >>
> >> On 2021/3/8 6:22 下午, Peter Maydell wrote:
> >>> On Mon, 8 Mar 2021 at 03:48, Jason Wang wrote:
> Do we need
Hi Jason,
On Tue, Mar 9, 2021 at 5:00 PM Bin Meng wrote:
>
> Hi Jason,
>
> On Tue, Mar 9, 2021 at 4:57 PM Jason Wang wrote:
> >
> >
> > On 2021/3/9 4:35 下午, Bin Meng wrote:
> > > Hi Jason,
> > >
> > > On Tue, Mar 9, 2021 at 4:23 PM Jason Wang wrote:
> > >>
> > >> On 2021/3/8 6:22 下午, Peter Mayd
(Cc'ing qemu-trivial@)
On 3/9/21 8:42 AM, lijiejun wrote:
> Fix code style. Operator needs spaces forend sides, and delete line space.
"forend"?
Otherwise:
Reviewed-by: Philippe Mathieu-Daudé
>
> Signed-off-by: lijiejun
> ---
> hw/display/virtio-gpu-3d.c | 3 +--
> 1 file changed, 1 inserti
Hi Zoltan,
On 3/5/21 5:21 PM, Philippe Mathieu-Daudé wrote:
> Trivial fixes extracted from another series which became too big,
> so I prefer to send them in a previous step.
I just realized I meant to Cc you on this series but forgot :/
As this model is pretty close to your MV64361 one, and this
On 3/5/21 2:02 AM, David Gibson wrote:
> On Thu, Mar 04, 2021 at 11:42:10PM +0100, Philippe Mathieu-Daudé wrote:
>> On 3/4/21 9:16 PM, BALATON Zoltan wrote:
>>> On Thu, 4 Mar 2021, Philippe Mathieu-Daudé wrote:
On 3/2/21 10:11 PM, BALATON Zoltan wrote:
> To allow reusing ISA bridge emulati
On Mon, Mar 08, 2021 at 05:54:13PM +0100, Kevin Wolf wrote:
> This adds a QAPI schema for the properties of the authz-* objects.
>
> Signed-off-by: Kevin Wolf
> Acked-by: Peter Krempa
> Reviewed-by: Eric Blake
> ---
> qapi/authz.json | 61 +---
> qa
On Tue, Mar 09, 2021 at 12:23:14PM +0800, Jason Wang wrote:
> Currently, the default msix vectors for virtio-net-pci is 3 which is
> obvious not suitable for multiqueue guest, so we depends on the user
> or management tools to pass a correct vectors parameter. In fact, we
> can simplifying this by
On 3/9/21 9:41 AM, Claudio Fontana wrote:
> On 3/8/21 6:48 PM, Philippe Mathieu-Daudé wrote:
>> On 3/8/21 5:46 PM, Stefan Hajnoczi wrote:
>>> On Wed, Feb 24, 2021 at 10:35:15PM +0100, Philippe Mathieu-Daudé wrote:
We don't need to generate trace files for targets we
are not building. Rest
On Mon, Mar 08, 2021 at 05:54:19PM +0100, Kevin Wolf wrote:
> This adds a QAPI schema for the properties of the secret* objects.
>
> The 'loaded' property doesn't seem to make sense as an external
> interface: It is automatically set to true in ucc->complete, and
> explicitly setting it to true ea
On Mon, Mar 08, 2021 at 05:54:20PM +0100, Kevin Wolf wrote:
> This adds a QAPI schema for the properties of the tls-* objects.
>
> The 'loaded' property doesn't seem to make sense as an external
> interface: It is automatically set to true in ucc->complete, and
> explicitly setting it to true earl
On Mon, Mar 08, 2021 at 03:40:23PM -0700, Warner Losh wrote:
> The FreeBSD project has a number of enhancements to bsd-user. These changes
> have
> evolved over the past 10 year, and aren't currently updated to the latest
> version of qemu due to fluxuations in staffing causing us to fall behind i
Sorry for the delay, I missed this one.
Zihao Chang writes:
> This patch provides a new qmp to reload display configuration
> without restart VM, but only reloading the vnc tls certificates
> is implemented.
> Example:
> {"execute": "display-reload", "arguments":{"vnc-tls-certs": true}}
>
> Sign
Am 09.03.2021 um 05:52 hat Akihiko Odaki geschrieben:
> 2021年3月9日(火) 0:37 Akihiko Odaki :
> >
> > 2021年3月9日(火) 0:17 Stefan Hajnoczi :
> > >
> > > The live migration compatibility issue is still present. Migrating to
> > > another host might not work if the block limits are different.
> > >
> > > He
On Mon, Mar 08, 2021 at 07:26:36PM -0800, Joelle van Dyne wrote:
> iOS does not support ucontext natively for aarch64 and the sigaltstack is
> also unsupported (even worse, it fails silently, see:
> https://openradar.appspot.com/13002712 )
>
> As a workaround we include a library implementation of
Hi Peter,
On 3/9/21 12:40 AM, Peter Xu wrote:> On Sat, Mar 06, 2021 at 12:54:13AM
+0100, Philippe Mathieu-Daudé wrote:
>> @@ -3188,14 +3188,15 @@ void mtree_info(bool flatview, bool dispatch_tree,
>> bool owner, bool disabled)
>>
>> QTAILQ_FOREACH(as, &address_spaces, address_spaces_link)
Hi,
> > That is pretty much mandatory. Without blob resources there is no concept
> > of resources
> > shared between host and guest in virtio-gpu, all data is explicitly copied
> > with transfer
> > commands.
> [Kasireddy, Vivek] My understanding of virtio-gpu and the concept of
> resources
These patches were dropped from Kevin's last block pull request due to a GitLab
CI failure. The old CentOS 7 and opensuse Leap build images lack
memfd_create(2) (introduced in Linux around 2014). The vhost-user-blk server
had a dependency on memfd_create(2) due to VHOST_USER_PROTOCOL_F_INFLIGHT_SHM
Exercise input validation code paths in
block/export/vhost-user-blk-server.c.
Signed-off-by: Stefan Hajnoczi
---
tests/qtest/vhost-user-blk-test.c | 124 ++
1 file changed, 124 insertions(+)
diff --git a/tests/qtest/vhost-user-blk-test.c
b/tests/qtest/vhost-user-blk
From: Coiby Xu
This test case has the same tests as tests/virtio-blk-test.c except for
tests have block_resize. Since the vhost-user-blk export only serves one
client one time, two exports are started by qemu-storage-daemon for the
hotplug test.
Suggested-by: Thomas Huth
Signed-off-by: Coiby Xu
On 3/3/21 8:03 AM, Joel Stanley wrote:
> The HACE (Hash and Crpyto Engine) is a device that offloads MD5, SHA1,
Typo "Crypto"
> SHA2, RSA and other cryptographic algorithms.
>
> This initial model implements a subset of the device's functionality;
> currently only direct access (non-scatter gath
The vhost-user in-flight shmfd feature has not been tested with
qemu-storage-daemon's vhost-user-blk server. Disable this optional
feature for now because it requires MFD_ALLOW_SEALING, which is not
available in some CI environments.
If we need this feature in the future it can be re-enabled after
On Sat, Dec 26, 2020 at 03:11:53PM +0800, Keqian Zhu wrote:
>
> [...]
>
> >>> -for (j = old_num_blocks; j < new_num_blocks; j++) {
> >>> -new_blocks->blocks[j] = bitmap_new(DIRTY_MEMORY_BLOCK_SIZE);
> >>> +if (extend) {
> >>> +for (j = cpy_num_blocks; j < n
Signed-off-by: Stefan Hajnoczi
---
tests/qtest/vhost-user-blk-test.c | 81 +--
1 file changed, 76 insertions(+), 5 deletions(-)
diff --git a/tests/qtest/vhost-user-blk-test.c
b/tests/qtest/vhost-user-blk-test.c
index f0fb09893e..61beee52d3 100644
--- a/tests/qtest/vh
Hi,
> Of course, reading the current code more carefully, usb_host_get_port
> is never actually called with a hub device (let alone a root hub),
Ah, the root hub itself. I've assumed you mean a device plugged into
the root hub. That explains the confusion.
Yes, passing through hubs is simply
+Alex
On 3/5/21 4:38 PM, Cédric Le Goater wrote:
> On 3/5/21 4:12 PM, Peter Maydell wrote:
>> On Thu, 4 Mar 2021 at 12:40, Joel Stanley wrote:
>>>
>>> v2: Fix ast2600 test, thanks Cédric for the review.
>>>
>>> This adds tests for the Aspeed ARM SoCs. The AST2400 and AST2500 tests
>>> use OpenBMC
On Mon, Mar 08, 2021 at 11:07:13PM +0900, Akihiko Odaki wrote:
> c821a58ee7 ("ui/console: Pass placeholder surface to display")
> eliminated the possibility that NULL is passed as surface to
> dpy_gfx_switch and removed some NULL checks from gd_switch, but the
> removal was not thoroughly. Remainin
On Tue, Mar 9, 2021 at 1:36 AM Daniel P. Berrangé wrote:
>
> On Mon, Mar 08, 2021 at 07:26:36PM -0800, Joelle van Dyne wrote:
> > iOS does not support ucontext natively for aarch64 and the sigaltstack is
> > also unsupported (even worse, it fails silently, see:
> > https://openradar.appspot.com/13
On Mon, 8 Mar 2021 at 20:14, Aaron Lindsay wrote:
>
> This allows plugins to query for full virtual-to-physical address
> translation for a given `qemu_plugin_hwaddr` and stops exposing the
> offset within the device itself. As this change breaks the API,
> QEMU_PLUGIN_VERSION is incremented.
>
>
On Tue, 9 Mar 2021 at 00:30, Joelle van Dyne wrote:
>
> Replace Windows specific macro with a more generic feature detection
> macro. Allows slirp smb feature to be disabled manually as well.
>
> Signed-off-by: Joelle van Dyne
> ---
Reviewed-by: Peter Maydell
thanks
-- PMM
On Tue, 9 Mar 2021 at 09:01, Bin Meng wrote:
>
> Hi Jason,
>
> On Tue, Mar 9, 2021 at 5:00 PM Bin Meng wrote:
> >
> > Hi Jason,
> >
> > On Tue, Mar 9, 2021 at 4:57 PM Jason Wang wrote:
> > >
> > >
> > > On 2021/3/9 4:35 下午, Bin Meng wrote:
> > > > Hi Jason,
> > > >
> > > > On Tue, Mar 9, 2021 at
On Mon, 8 Mar 2021 at 22:43, Warner Losh wrote:
>
> The FreeBSD project has a number of enhancements to bsd-user. These changes
> have
> evolved over the past 10 year, and aren't currently updated to the latest
> version of qemu due to fluxuations in staffing causing us to fall behind in
> the
>
Hi Peter,
On Tue, Mar 9, 2021 at 6:13 PM Peter Maydell wrote:
>
> On Tue, 9 Mar 2021 at 09:01, Bin Meng wrote:
> >
> > Hi Jason,
> >
> > On Tue, Mar 9, 2021 at 5:00 PM Bin Meng wrote:
> > >
> > > Hi Jason,
> > >
> > > On Tue, Mar 9, 2021 at 4:57 PM Jason Wang wrote:
> > > >
> > > >
> > > > On
On Tue, 9 Mar 2021 at 09:59, Joelle van Dyne wrote:
>
> On Tue, Mar 9, 2021 at 1:36 AM Daniel P. Berrangé wrote:
> > The README here:
> >
> > https://github.com/kaniini/libucontext
> >
> > indicates that it is intentionally limiting what registers it saves
> > and restores, explicitly excluding
A feature of the current rwlock is that if multiple coroutines hold a
reader lock, all must be runnable. The unlock implementation relies on
this, choosing to wake a single coroutine when the final read lock
holder exits the critical section, assuming that it will wake a
coroutine attempting to acq
When taking the slow path for mutex acquisition, set the coroutine
value in the CoWaitRecord in push_waiter(), rather than both there and
in the caller.
Signed-off-by: David Edmondson
---
util/qemu-coroutine-lock.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/util/qemu-coroutine-lock.c b/u
Given that the block size is read from the header of the VDI file, a
wide variety of sizes might be seen. Rather than re-using a block
sized memory region when writing the VDI header, allocate an
appropriately sized buffer.
Signed-off-by: David Edmondson
---
block/vdi.c | 10 ++
1 file c
If a new bitmap entry is allocated, requiring the entire block to be
written, avoiding leaking the buffer allocated for the block should
the write fail.
Signed-off-by: David Edmondson
---
block/vdi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/vdi.c b/block/vdi.c
index 5627e7d764..
RFC because changing the coroutine code is scary and I'm new to it.
Stressing the VDI code with qemu-img:
qemu-img convert -p -W -m 16 -O vdi input.qcow2 output.vdi
leads to a hang relatively quickly on a machine with sufficient
CPUs. A similar test targetting either raw or qcow2 formats, or
a
On 09/03/21 10:59, Joelle van Dyne wrote:
Does it make a difference if this is provided as an option and not as
a replacement? Would it make sense to add some warning at configure
time? Right now none of the concurrency backends are supported on iOS
and it's possible support will go away on macOS
On Tue, Mar 09, 2021 at 10:37:18AM +0100, Kevin Wolf wrote:
> Am 09.03.2021 um 05:52 hat Akihiko Odaki geschrieben:
> > 2021年3月9日(火) 0:37 Akihiko Odaki :
> > >
> > > 2021年3月9日(火) 0:17 Stefan Hajnoczi :
> > > >
> > > > The live migration compatibility issue is still present. Migrating to
> > > > ano
On 09/03/21 09:41, Claudio Fontana wrote:
In any case, I agree that just recursing all directories in target/
looking for trace.h / traceevents files could be better.
Using the directory structure to find source files is a bad idea because
you don't notice that you haven't "git add"ed a file u
Hi,
Here is a set of vIOMMU fixes:
SMMUv3:
- top SID computation overflow when handling SMMU_CMD_CFGI_ALL
- internal IOTLB handling (changes related to range invalidation)
- smmu_iotlb_inv_iova with asid = -1
- non power of 2 invalidation range handling.
VIRTIO-IOMMU:
- non power of 2 inva
As of today, the driver can invalidate a number of pages that is
not a power of 2. However IOTLB unmap notifications and internal
IOTLB invalidations work with masks leading to erroneous
invalidations.
In case the range is not a power of 2, split invalidations into
power of 2 invalidations.
When
Currently get_naturally_aligned_size() is used by the intel iommu
to compute the maximum invalidation range based on @size which is
a power of 2 while being aligned with the @start address and less
than the maximum range defined by @gaw.
This helper is also useful for other iommu devices (virtio-i
With -Werror=maybe-uninitialized configuration we get
../hw/i386/intel_iommu.c: In function ‘vtd_context_device_invalidate’:
../hw/i386/intel_iommu.c:1888:10: error: ‘mask’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
1888 | mask = ~mask;
| ~^~~
A
Unmap notifiers work with an address mask assuming an
invalidation range of a power of 2. Nothing mandates this
in the VIRTIO-IOMMU spec.
So in case the range is not a power of 2, split it into
several invalidations.
Signed-off-by: Eric Auger
Reviewed-by: Peter Xu
---
v2 -> v3:
- added Peter'
If the whole SID range (32b) is invalidated (SMMU_CMD_CFGI_ALL),
@end overflows and we fail to handle the command properly.
Once this gets fixed, the current code really is awkward in the
sense it loops over the whole range instead of removing the
currently cached configs through a hash table look
If the asid is not set, do not attempt to locate the key directly
as all inserted keys have a valid asid.
Use g_hash_table_foreach_remove instead.
Signed-off-by: Eric Auger
---
hw/arm/smmu-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/smmu-common.c b/hw/arm
Aaron Lindsay writes:
> Alex,
>
> I've now tested this change, and it is giving what appear to be valid
> and correct physical addresses for both RAM and IO accesses in all the
> cases I've thrown at it. My main concern with this patch at this point
> is that I am concerned I may be breaking yo
On Tue, Mar 09, 2021 at 11:24:08AM +0100, Paolo Bonzini wrote:
> On 09/03/21 10:59, Joelle van Dyne wrote:
> > Does it make a difference if this is provided as an option and not as
> > a replacement? Would it make sense to add some warning at configure
> > time? Right now none of the concurrency ba
Convert all sid printouts to sid=0x%x.
Signed-off-by: Eric Auger
Reviewed-by: Philippe Mathieu-Daudé
---
v2 -> v3:
- added Philippe's R-b
---
hw/arm/trace-events | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/hw/arm/trace-events b/hw/arm/trace-e
On Fri, Mar 05, 2021 at 02:48:11PM +, Peter Maydell wrote:
> Ping for review?
Looks all sane from ui point of view.
Acked-by: Gerd Hoffmann
I suspect we still have some code duplication here due to each display
device having its own set of line render functions. We should be able
to share
On Tue, Mar 09, 2021 at 10:20:07AM +, Peter Maydell wrote:
> On Tue, 9 Mar 2021 at 09:59, Joelle van Dyne wrote:
> >
> > On Tue, Mar 9, 2021 at 1:36 AM Daniel P. Berrangé
> > wrote:
> > > The README here:
> > >
> > > https://github.com/kaniini/libucontext
> > >
> > > indicates that it is i
Hi
On Tue, Mar 9, 2021 at 2:36 PM Daniel P. Berrangé
wrote:
> On Tue, Mar 09, 2021 at 11:24:08AM +0100, Paolo Bonzini wrote:
> > On 09/03/21 10:59, Joelle van Dyne wrote:
> > > Does it make a difference if this is provided as an option and not as
> > > a replacement? Would it make sense to add s
Hi, everyone! Do you have any suggestions? Please help review these
patches, thanks very much.
On 2021/2/27 16:33, Wang Xingang wrote:
From: Xingang Wang
These patches add support for configure iommu on/off for pci root bus,
including primary bus and pxb root bus. At present, All root bus wil
From: Philippe Mathieu-Daudé
Add missing dependency build-opensbi -> docker-opensbi.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20210303130646.1494015-4-phi...@redhat.com>
Reviewed-by: Willian Rampazzo
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
---
.gitlab-ci.d/opens
From: Philippe Mathieu-Daudé
Add missing dependency build-system-alpine -> amd64-alpine-container.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20210303130646.1494015-2-phi...@redhat.com>
Reviewed-by: Willian Rampazzo
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
---
.git
From: Chen Qun
There are 23 files that include the "sysemu/qtest.h",
but they do not use any qtest functions.
Signed-off-by: Chen Qun
Acked-by: Markus Armbruster
Message-Id: <20210226081414.205946-1-kuhn.chen...@huawei.com>
Signed-off-by: Thomas Huth
---
accel/tcg/cpu-exec.c| 1 -
From: Philippe Mathieu-Daudé
Add missing dependency build-edk2 -> docker-edk2.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20210303130646.1494015-3-phi...@redhat.com>
Reviewed-by: Willian Rampazzo
Reviewed-by: Daniel P. Berrangé
Acked-by: Laszlo Ersek
Signed-off-by: Thomas Huth
---
Hi Peter,
the following changes since commit 229a834518b950d56fd1bc94923276504d0ee9d4:
Merge remote-tracking branch 'remotes/philmd-gitlab/tags/renesas-20210306'
into staging (2021-03-08 15:45:48 +)
are available in the Git repository at:
https://gitlab.com/thuth/qemu.git tags/pull-re
From: Cleber Rosa
This simply splits out the code that does an HTTP GET so that it
can be used for other API requests.
Signed-off-by: Cleber Rosa
Reviewed-by: Alex Bennée
Reviewed-by: Wainer dos Santos Moschetta
Message-Id: <20210222193240.921250-2-cr...@redhat.com>
Signed-off-by: Thomas Huth
"make check SPEED=slow" got lost in the conversion of the build
system to meson - the tests were always running in "quick" mode.
Fix it by passing the "-m" parameter to the test harness at the
right spot in scripts/mtest2make.py.
Signed-off-by: Thomas Huth
Message-Id: <20210218172313.2217440-1-th
From: Emanuele Giuseppe Esposito
Improve current qgraph documentation with a more concrete example
and clearer motivation.
This patch depends on the previous serie
"libqos/qgraph: format qgraph comments for sphinx documentation"
Signed-off-by: Emanuele Giuseppe Esposito
Message-Id: <2021030109
From: Cleber Rosa
This includes both input parameters (project id and commit) in the
message so to make it easier to debug returned API calls.
Signed-off-by: Cleber Rosa
Reviewed-by: Wainer dos Santos Moschetta
Message-Id: <20210222193240.921250-4-cr...@redhat.com>
Signed-off-by: Thomas Huth
From: Cleber Rosa
When an HTTP GET request fails, it's useful to go beyond the "not
successful" message, and show the code returned by the server.
Signed-off-by: Cleber Rosa
Reviewed-by: Alex Bennée
Reviewed-by: Wainer dos Santos Moschetta
Message-Id: <20210222193240.921250-3-cr...@redhat.com
From: Cleber Rosa
Previously, tests were being filtered by the matching target
architectures to be built. The benefit, compared to the current
situation, is a more concise test job that won't show tests canceled
because a matching QEMU binary was not found (those tests won't even
be attempted).
On 3/9/21 11:26 AM, Paolo Bonzini wrote:
> On 09/03/21 09:41, Claudio Fontana wrote:
>> In any case, I agree that just recursing all directories in target/
>> looking for trace.h / traceevents files could be better.
>
> Using the directory structure to find source files is a bad idea because
> yo
From: Cleber Rosa
The "get-vm-images" target defined in tests/Makefile.include is a
prerequisite for "check-acceptance", so that those files get
downloaded before the Avocado job even starts.
It looks like on c401c058a1c a TARGETS variable was introduced with a
different content than it was prev
From: Warner Losh
The FreeBSD project has a number of enhancements to bsd-user. These changes have
evolved over the past 10 year, and aren't currently updated to the latest
version of qemu due to fluxuations in staffing causing us to fall behind in the
past. We're working on porting all the chang
From: Emanuele Giuseppe Esposito
Change documentation style and fix minor typos in tests/qtest/libqos/qgraph.h
to automatically generate sphinx documentation in docs/devel/qgraph.rst
The mechanism explanation that once was in qgraph.h is now moved to qgraph.rst
There is no functional change int
On 09/03/21 11:21, David Edmondson wrote:
When taking the slow path for mutex acquisition, set the coroutine
value in the CoWaitRecord in push_waiter(), rather than both there and
in the caller.
Signed-off-by: David Edmondson
---
util/qemu-coroutine-lock.c | 1 -
1 file changed, 1 deletion(-
Am 09.03.2021 um 11:26 hat Daniel P. Berrangé geschrieben:
> On Tue, Mar 09, 2021 at 10:37:18AM +0100, Kevin Wolf wrote:
> > Am 09.03.2021 um 05:52 hat Akihiko Odaki geschrieben:
> > > 2021年3月9日(火) 0:37 Akihiko Odaki :
> > > >
> > > > 2021年3月9日(火) 0:17 Stefan Hajnoczi :
> > > > >
> > > > > The live
On 3/9/21 11:26 AM, Paolo Bonzini wrote:
> On 09/03/21 09:41, Claudio Fontana wrote:
>> In any case, I agree that just recursing all directories in target/
>> looking for trace.h / traceevents files could be better.
>
> Using the directory structure to find source files is a bad idea because
> you
On 09/03/21 11:42, Marc-André Lureau wrote:
If I remember correctly, there were objections because we wanted to have
an implementation close to QEMU, so we could easily extend it, or add
custom optimizations.
I think it's quite mature now. The code that needs to stay close to
QEMU is the loc
Am 08.03.2021 um 17:12 hat Stefano Garzarella geschrieben:
> QemuOpts is usually created merging the QemuOptsList of format
> and protocol. So, when the format calls bdr_create_file(), the 'opts'
> parameter contains a QemuOptsList with a combination of format and
> protocol default values.
>
> Th
On Mon, 1 Mar 2021 at 14:23, Steven Price wrote:
>
> A new capability (KVM_CAP_ARM_MTE) identifies that the kernel supports
> granting a guest access to the tags, and provides a mechanism for the
> VMM to enable it.
>
> A new ioctl (KVM_ARM_MTE_COPY_TAGS) provides a simple way for a VMM to
> acces
On 3/8/21 11:40 PM, Warner Losh wrote:
> The FreeBSD project has a number of enhancements to bsd-user. These changes
> have
> evolved over the past 10 year, and aren't currently updated to the latest
> version of qemu due to fluxuations in staffing causing us to fall behind in
> the
> past. We're
2021年3月9日(火) 19:26 Daniel P. Berrangé :
>
> On Tue, Mar 09, 2021 at 10:37:18AM +0100, Kevin Wolf wrote:
> > Am 09.03.2021 um 05:52 hat Akihiko Odaki geschrieben:
> > > 2021年3月9日(火) 0:37 Akihiko Odaki :
> > > >
> > > > 2021年3月9日(火) 0:17 Stefan Hajnoczi :
> > > > >
> > > > > The live migration compat
Patchew URL: https://patchew.org/QEMU/20210309104617.714908-1-th...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210309104617.714908-1-th...@redhat.com
Subject: [PULL 00/14] Gitlab, testing and misc patc
Michael, Paolo, if you Ack this patch I can queue the series
via pflash-next.
On 3/7/21 11:26 PM, Philippe Mathieu-Daudé wrote:
> TYPE_PFLASH_CFI01 is a TYPE_SYS_BUS_DEVICE which registers its romd
> MemoryRegion with sysbus_init_mmio(), so we can use the generic
> sysbus_mmio_get_region() to get
On 09/03/21 11:21, David Edmondson wrote:
A feature of the current rwlock is that if multiple coroutines hold a
reader lock, all must be runnable. The unlock implementation relies on
this, choosing to wake a single coroutine when the final read lock
holder exits the critical section, assuming tha
On 09/03/21 11:21, David Edmondson wrote:
-/* The critical section started in qemu_co_rwlock_wrlock. */
-qemu_co_queue_restart_all(&lock->queue);
+/* The critical section started in qemu_co_rwlock_wrlock or
+ * qemu_co_rwlock_upgrade.
+ */
+qemu_co
On 3/9/21 11:21 AM, David Edmondson wrote:
> When taking the slow path for mutex acquisition, set the coroutine
> value in the CoWaitRecord in push_waiter(), rather than both there and
> in the caller.
>
> Signed-off-by: David Edmondson
> ---
> util/qemu-coroutine-lock.c | 1 -
> 1 file changed,
On Tue, 23 Feb 2021 at 11:06, Akihiko Odaki wrote:
>
> The first argument of the executable was used to get its path, but it is
> not reliable because the executer can specify any arbitrary string. Use the
> interfaces provided by QEMU and the platform to get those paths.
>
> This change also chan
On 3/9/21 11:21 AM, David Edmondson wrote:
> If a new bitmap entry is allocated, requiring the entire block to be
> written, avoiding leaking the buffer allocated for the block should
> the write fail.
>
> Signed-off-by: David Edmondson
Reviewed-by: Philippe Mathieu-Daudé
> ---
> block/vdi.c
An assorted set of spelling fixes in various places.
Signed-off-by: Michael Tokarev
Reviewed-by: Stefan Weil
---
V1: https://lists.nongnu.org/archive/html/qemu-devel/2020-12/msg05959.html
Changes: incorporated suggestions by Stefan Weil and added his R-b.
Please note: this also patches one file
On Tue, Mar 09, 2021 at 12:23:14PM +0800, Jason Wang wrote:
Currently, the default msix vectors for virtio-net-pci is 3 which is
obvious not suitable for multiqueue guest, so we depends on the user
or management tools to pass a correct vectors parameter. In fact, we
can simplifying this by calcul
On Sat, 6 Mar 2021 at 21:36, Richard Henderson
wrote:
>
> The following changes since commit 91e92cad67caca3bc4b8e920ddb5c8ca64aac9e1:
>
> Merge remote-tracking branch 'remotes/cohuck-gitlab/tags/s390x-20210305'
> into staging (2021-03-05 19:04:47 +)
>
> are available in the Git repository
The status of the gitlab-CI files is currently somewhat confusing, and
it is often not quite clear whether a patch should go via my tree or
via the testing tree of Alex. That situation has grown historically...
Initially, I was the only one using the gitlab-CI, just for my private
repository there.
On Fri, Mar 05, 2021 at 09:19:09PM +0900, Akihiko Odaki wrote:
> ui/cocoa does not receive NSEventTypeFlagsChanged when it is not active,
> and the modifier state can be desynchronized in such a situation.
>
> [NSEvent -modifierFlags] tells whether a modifier is *not* pressed, so
> check it whenev
1 - 100 of 690 matches
Mail list logo
