Re: About libfuzzer in qemu

2021-03-05 Thread Qiuhao Li
On Thu, 2021-03-04 at 10:23 -0500, Alexander Bulekov wrote: > On 210304 1843, Yan Zhiqiang wrote: > > Hello Alex, > > I'm learning the fuzz in QEMU recently, I review the fuzz code > > under > > /tests/qtest/fuzz which is written by you. > > I learn a lot from it, but I stuck when I want to debug t

Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration

2021-03-05 Thread Markus Armbruster
Markus Armbruster writes: > Daniel P. Berrangé writes: > >> On Thu, Mar 04, 2021 at 11:00:57AM +0100, Markus Armbruster wrote: >>> Drop the crap deprecated in commit 4a27a638e7 "fdc: Deprecate >>> configuring floppies with -global isa-fdc" (v5.1.0). >>> >>> Signed-off-by: Markus Armbruster [..

[Bug 1916655] Re: Compilation fails due to zstd qcow2 compression

2021-03-05 Thread Dantali0n
Seems I had an old version (1.3.5) of zstd floating around in /usr/local. Consider this issue resolved. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs

Re: [RFC v1 00/38] arm cleanup experiment for kvm-only build

2021-03-05 Thread Claudio Fontana
On 3/4/21 8:24 PM, Peter Maydell wrote: > On Thu, 4 Mar 2021 at 16:39, Philippe Mathieu-Daudé wrote: >> >> On 3/3/21 7:54 PM, Richard Henderson wrote: >>> On 3/3/21 10:45 AM, Claudio Fontana wrote: It is a bit weird that qemu-system-aarch64 runs with a cortex-a15 model tbh, as cortex-a15

Re: [PATCH v2 7/8] simplebench/bench-backup: add --count and --no-initial-run

2021-03-05 Thread Vladimir Sementsov-Ogievskiy
05.03.2021 04:37, John Snow wrote: On 3/4/21 5:17 AM, Vladimir Sementsov-Ogievskiy wrote: Add arguments to set number of test runs per table cell and to disable initial run that is not counted in results. It's convenient to set --count 1 --no-initial-run to fast run test onece, and to set --cou

Re: [PATCH v2 8/8] simplebench/bench_block_job: drop caches before test run

2021-03-05 Thread Vladimir Sementsov-Ogievskiy
05.03.2021 04:30, John Snow wrote: On 3/4/21 5:17 AM, Vladimir Sementsov-Ogievskiy wrote: It probably may improve reliability of results when testing in cached mode. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   scripts/simplebench/bench_block_job.py | 2 ++   1 file changed, 2 insertions(+

Re: QEMU RBD is slow with QCOW2 images

2021-03-05 Thread Kevin Wolf
Am 04.03.2021 um 18:32 hat Stefano Garzarella geschrieben: > On Thu, Mar 04, 2021 at 03:59:17PM +0100, Kevin Wolf wrote: > > Am 04.03.2021 um 15:08 hat Stefano Garzarella geschrieben: > > > On Thu, Mar 04, 2021 at 01:05:02PM +0100, Kevin Wolf wrote: > > > > Am 03.03.2021 um 18:40 hat Stefano Garzar

Re: [PATCH v2 1/8] simplebench: bench_one(): add slow_limit argument

2021-03-05 Thread Vladimir Sementsov-Ogievskiy
05.03.2021 04:22, John Snow wrote: On 3/4/21 5:17 AM, Vladimir Sementsov-Ogievskiy wrote: Sometimes one of cells in a testing table runs too slow. And we really don't want to wait so long. Limit number of runs in this case. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   scripts/simplebench/

[PATCH v1 1/9] docs/devel: re-organise the developers guide into sections

2021-03-05 Thread Alex Bennée
The list of sub-sections was getting a bit long and sporadically organised. Let's try and impose some order on this hairball of documentation. [AJB: RFC because I wonder if we should make a more concerted effort to move bits of the wiki into a canonical maintained document. There is also probably

[PATCH v1 8/9] gitlab-ci.yml: Add jobs to test CFI flags

2021-03-05 Thread Alex Bennée
From: Daniele Buono QEMU has had options to enable control-flow integrity features for a few months now. Add two sets of build/check/acceptance jobs to ensure the binary produced is working fine. The three sets allow testing of x86_64 binaries for x86_64, s390x, ppc64 and aarch64 targets Signed

[PATCH v1 4/9] docker: Add Hexagon image

2021-03-05 Thread Alex Bennée
From: Alessandro Di Federico [PMD: Base on qemu/debian10, add missing EXTRA_FILES, remove X86] Signed-off-by: Alessandro Di Federico Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Brian Cain Message-Id: <20210228222314.304787-2-f4...@amsat.org> [AJB: add build-dep for QEMU, include in MAI

[PATCH v1 2/9] docs/system: add a gentle prompt for the complexity to come

2021-03-05 Thread Alex Bennée
We all know the QEMU command line can become a fiendishly complex beast. Lets gently prepare our user for the horrors to come by referencing where other example command lines can be found in the manual. Signed-off-by: Alex Bennée Reviewed-by: Stefan Hajnoczi Reviewed-by: John Snow Reviewed-by:

[PATCH v1 5/9] tests/tcg: Use Hexagon Docker image

2021-03-05 Thread Alex Bennée
From: Alessandro Di Federico [PMD: Split from 'Add Hexagon Docker image' patch] Signed-off-by: Alessandro Di Federico Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210228222314.304787-5-f4...@amsat.org> Signed-off-by: Alex Bennée --- tests/tcg/configure.sh | 4 1 file changed, 4

[PATCH v1 7/9] gitlab-ci.yml: Allow custom # of parallel linkers

2021-03-05 Thread Alex Bennée
From: Daniele Buono Define a new variable LD_JOBS, that can be used to select the maximum number of linking jobs to be executed in parallel. If the variable is not defined, maintain the default given by make -j Currently, make parallelism at build time is based on the number of cpus available.

[PATCH v1 0/9] testing/next (docs, hexagon, cfi, docker)

2021-03-05 Thread Alex Bennée
Hi, Another week another testing/next roll. The series includes a couple of my proposed documentation tweaks (including the re-org of the devel manual). We also enable testing for the hexagon linux-user target to avoid bitrot. I've documented the process for manually updating the registry at: ht

[PATCH v1 3/9] tests/docker: add a test-tcg for building then running check-tcg

2021-03-05 Thread Alex Bennée
This is mostly useful for verifying containers will work on the CI setup. Signed-off-by: Alex Bennée --- tests/docker/test-tcg | 22 ++ 1 file changed, 22 insertions(+) create mode 100755 tests/docker/test-tcg diff --git a/tests/docker/test-tcg b/tests/docker/test-tcg new f

[PATCH v1 6/9] gitlab: add build-user-hexagon test

2021-03-05 Thread Alex Bennée
We special case this as the container with the cross compiler for the tests takes so long to build it is manually uploaded into the registry. Signed-off-by: Alex Bennée --- .gitlab-ci.yml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 8b6d4

Re: [PATCH] linux-user: add missing MULTICAST_IF get/setsockopt option

2021-03-05 Thread Philippe Mathieu-Daudé
On 3/5/21 4:46 AM, Jiaxun Yang wrote: > 在 2021/3/5 上午11:35, Jiaxun Yang 写道: > >> {IP,IPV6}_MULTICAST_IF was not supported. > >> > >> Reported-by: Yunqiang Su > >> Signed-off-by: Jiaxun Yang > >> --- > >>   linux-user/syscall.c  | 4 + > >>   linux-user/syscall.c.orig | 13305 > +

[PATCH v1 9/9] tests/docker: Use --arch-only when building Debian cross image

2021-03-05 Thread Alex Bennée
From: Philippe Mathieu-Daudé When building a Docker image based on debian10.docker on a non-x86 host, we get: [2/4] RUN apt update && DEBIAN_FRONTEND=noninteractive eatmydata apt build-dep -yy qemu Reading package lists... Done Building dependency tree Reading state information... D

Re: [PATCH v2] linux-user: add missing MULTICAST_IF get/setsockopt option

2021-03-05 Thread Philippe Mathieu-Daudé
On 3/5/21 5:05 AM, Jiaxun Yang wrote: > {IP,IPV6}_MULTICAST_IF was not supported. > FWIW in v1 you had "Reported-by: Yunqiang Su " > Signed-off-by: Jiaxun Yang > --- > linux-user/syscall.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c

Re: [PATCH V4 00/10] Detect reentrant RX casued by loopback

2021-03-05 Thread Philippe Mathieu-Daudé
On 3/5/21 7:26 AM, Jason Wang wrote: > Hi All: > > Followed by commit 22dc8663d9 ("net: forbid the reentrant RX"), we > still need to fix the issues casued by loopback mode where the NIC > usually it via calling nc->info->receive() directly. > > The fix is to introduce new network helper and chec

Re: [PATCH v1 1/9] docs/devel: re-organise the developers guide into sections

2021-03-05 Thread Philippe Mathieu-Daudé
On 3/5/21 10:23 AM, Alex Bennée wrote: > The list of sub-sections was getting a bit long and sporadically > organised. Let's try and impose some order on this hairball of > documentation. > > [AJB: RFC because I wonder if we should make a more concerted effort > to move bits of the wiki into a can

Re: [PATCH v1 3/9] tests/docker: add a test-tcg for building then running check-tcg

2021-03-05 Thread Philippe Mathieu-Daudé
On 3/5/21 10:23 AM, Alex Bennée wrote: > This is mostly useful for verifying containers will work on the CI > setup. > > Signed-off-by: Alex Bennée > --- > tests/docker/test-tcg | 22 ++ > 1 file changed, 22 insertions(+) > create mode 100755 tests/docker/test-tcg Reviewed-

Re: [PATCH v1 6/9] gitlab: add build-user-hexagon test

2021-03-05 Thread Philippe Mathieu-Daudé
On 3/5/21 10:23 AM, Alex Bennée wrote: > We special case this as the container with the cross compiler for the > tests takes so long to build it is manually uploaded into the > registry. > > Signed-off-by: Alex Bennée > --- > .gitlab-ci.yml | 11 +++ > 1 file changed, 11 insertions(+) R

Re: [PATCH v1 0/9] testing/next (docs, hexagon, cfi, docker)

2021-03-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210305092328.31792-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210305092328.31792-1-alex.ben...@linaro.org Subject: [PATCH v1 0/9] testing/next (d

Re: [PATCH v1 8/9] gitlab-ci.yml: Add jobs to test CFI flags

2021-03-05 Thread Philippe Mathieu-Daudé
On 3/5/21 10:23 AM, Alex Bennée wrote: > From: Daniele Buono > > QEMU has had options to enable control-flow integrity features > for a few months now. Add two sets of build/check/acceptance > jobs to ensure the binary produced is working fine. > > The three sets allow testing of x86_64 binaries

Re: [PATCH RFC] migrate/ram: remove "ram_bulk_stage" and "fpo_enabled"

2021-03-05 Thread David Hildenbrand
On 16.02.21 11:50, David Hildenbrand wrote: The bulk stage is kind of weird: migration_bitmap_find_dirty() will indicate a dirty page, however, ram_save_host_page() will never save it, as migration_bitmap_clear_dirty() detects that it is not dirty. We already fill the bitmap in ram_list_init_bit

Re: QEMU RBD is slow with QCOW2 images

2021-03-05 Thread Stefano Garzarella
On Fri, Mar 05, 2021 at 10:16:41AM +0100, Kevin Wolf wrote: Am 04.03.2021 um 18:32 hat Stefano Garzarella geschrieben: On Thu, Mar 04, 2021 at 03:59:17PM +0100, Kevin Wolf wrote: > Am 04.03.2021 um 15:08 hat Stefano Garzarella geschrieben: > > On Thu, Mar 04, 2021 at 01:05:02PM +0100, Kevin Wolf

Re: [PATCH v7 00/13] virtio-mem: vfio support

2021-03-05 Thread David Hildenbrand
On 02.03.21 17:46, David Hildenbrand wrote: On 24.02.21 10:48, David Hildenbrand wrote: A virtio-mem device manages a memory region in guest physical address space, represented as a single (currently large) memory region in QEMU, mapped into system memory address space. Before the guest is allow

Re: [PATCH v2 2/2] memory: Drop "qemu:" prefix from QOM memory region type names

2021-03-05 Thread Philippe Mathieu-Daudé
On 3/4/21 3:02 PM, Markus Armbruster wrote: > Almost all QOM type names consist only of letters, digits, '-', '_', > and '.'. Just two contain ':': "qemu:memory-region" and > "qemu:iommu-memory-region". Neither can be plugged with -object. > Rename them to "memory-region" and "iommu-memory-region

[PATCH] docs: qsd: Explain --export nbd,name=... default

2021-03-05 Thread Kevin Wolf
The 'name' option for NBD exports is optional. Add a note that the default for the option is the node name (people could otherwise expect that it's the empty string like for qemu-nbd). Signed-off-by: Kevin Wolf --- docs/tools/qemu-storage-daemon.rst | 5 +++-- 1 file changed, 3 insertions(+), 2

Re: [PATCH 0/2] semihosting: Move it out of hw/

2021-03-05 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > In order to reduce CONFIG_USER_ONLY uses in hw/, move > semihosting out of it, being a generic feature. Queued to semihosting/next, thanks. -- Alex Bennée

Re: [PATCH v5 0/4] GitLab Custom Runners and Jobs (was: QEMU Gating CI)

2021-03-05 Thread Philippe Mathieu-Daudé
Hi Cleber, On 2/19/21 10:58 PM, Cleber Rosa wrote: > TL;DR: this should allow the QEMU maintainer to push to the staging > branch, and have custom jobs running on the project's aarch64 and > s390x machines. Jobs in this version are allowed to fail, to allow > for the inclusion of the novel machin

[PATCH v2 0/9] RAM_NORESERVE, MAP_NORESERVE and hostmem "reserve" property

2021-03-05 Thread David Hildenbrand
Some cleanups previously sent in other context (resizeable allocations), followed by RAM_NORESERVE, implementing it under POSIX using MAP_NORESERVE, and letting users configure it for memory backens using the "reserve" property (default: true). MAP_NORESERVE under Linux has in the context of QEMU

[PATCH v2 1/9] softmmu/physmem: Drop "shared" parameter from ram_block_add()

2021-03-05 Thread David Hildenbrand
Properly store it in the flags of the ram block instead (and the flag even already exists and is used). E.g., qemu_ram_is_shared() now properly succeeds on all ram blocks that are actually shared. Reviewed-by: Igor Kotrasinski Reviewed-by: Richard Henderson Reviewed-by: Peter Xu Signed-off-by:

[PATCH v2 2/9] util/mmap-alloc: Factor out calculation of the pagesize for the guard page

2021-03-05 Thread David Hildenbrand
Let's factor out calculating the size of the guard page and rename the variable to make it clearer that this pagesize only applies to the guard page. Reviewed-by: Peter Xu Acked-by: Murilo Opsfelder Araujo Cc: Igor Kotrasinski Signed-off-by: David Hildenbrand --- util/mmap-alloc.c | 31 ++

[PATCH v2 5/9] softmmu/memory: Pass ram_flags into qemu_ram_alloc_from_fd()

2021-03-05 Thread David Hildenbrand
Let's pass in ram flags just like we do with qemu_ram_alloc_from_file(), to clean up and prepare for more flags. Simplify the documentation of passed ram flags: Looking at our documentation of RAM_SHARED and RAM_PMEM is sufficient, no need to be repetitive. Reviewed-by: Peter Xu Signed-off-by: D

[PATCH v2 3/9] util/mmap-alloc: Factor out reserving of a memory region to mmap_reserve()

2021-03-05 Thread David Hildenbrand
We want to reserve a memory region without actually populating memory. Let's factor that out. Reviewed-by: Igor Kotrasinski Acked-by: Murilo Opsfelder Araujo Reviewed-by: Richard Henderson Reviewed-by: Peter Xu Signed-off-by: David Hildenbrand --- util/mmap-alloc.c | 58 +

[PATCH v2 6/9] softmmu/memory: Pass ram_flags into memory_region_init_ram_shared_nomigrate()

2021-03-05 Thread David Hildenbrand
Let's forward ram_flags instead, renaming memory_region_init_ram_shared_nomigrate() into memory_region_init_ram_flags_nomigrate(). Forward flags to qemu_ram_alloc() and qemu_ram_alloc_internal(). Reviewed-by: Peter Xu Signed-off-by: David Hildenbrand --- backends/hostmem-ram.c

[PATCH v2 8/9] util/mmap-alloc: Support RAM_NORESERVE via MAP_NORESERVE

2021-03-05 Thread David Hildenbrand
Let's support RAM_NORESERVE via MAP_NORESERVE. At least on Linux, the flag has no effect on shared mappings - except for hugetlbfs. Linux man page: "MAP_NORESERVE: Do not reserve swap space for this mapping. When swap space is reserved, one has the guarantee that it is possible to modify the

[PATCH v2 4/9] util/mmap-alloc: Factor out activating of memory to mmap_activate()

2021-03-05 Thread David Hildenbrand
We want to activate memory within a reserved memory region, to make it accessible. Let's factor that out. Reviewed-by: Richard Henderson Acked-by: Murilo Opsfelder Araujo Reviewed-by: Peter Xu Signed-off-by: David Hildenbrand --- util/mmap-alloc.c | 94 +---

[PATCH v2 9/9] hostmem: Wire up RAM_NORESERVE via "reserve" property

2021-03-05 Thread David Hildenbrand
Let's provide a way to control the use of RAM_NORESERVE via memory backends using the "reserve" property which defaults to true (old behavior). Only POSIX supports setting the flag (and Linux support is checked at runtime, depending on the setting of "/proc/sys/vm/overcommit_memory"). Windows will

Re: [PATCH 43/44] docs/system/arm/mps2.rst: Document the new mps3-an547 board

2021-03-05 Thread Peter Maydell
On Fri, 5 Mar 2021 at 01:28, Richard Henderson wrote: > > On 2/19/21 6:46 AM, Peter Maydell wrote: > > @@ -1,5 +1,5 @@ > > -Arm MPS2 and MPS3 boards (``mps2-an385``, ``mps2-an386``, ``mps2-an500``, > > ``mps2-an505``, ``mps2-an511``, ``mps2-an521``, ``mps3-an524``) > > -==

[PATCH v2 7/9] memory: introduce RAM_NORESERVE and wire it up in qemu_ram_mmap()

2021-03-05 Thread David Hildenbrand
Let's introduce RAM_NORESERVE, allowing mmap'ing with MAP_NORESERVE. The new flag has the following semantics: RAM is mmap-ed with MAP_NORESERVE. When set, reserving swap space (or huge pages on Linux) is skipped: will bail out if not supported. When not set, the OS might reserve swap space

Re: [PULL 0/8] Ui 20210304 patches

2021-03-05 Thread Peter Maydell
On Thu, 4 Mar 2021 at 12:52, Gerd Hoffmann wrote: > > The following changes since commit cbcf09872a936ccefef6a34298046d3b9aefc148: > > Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-updates-240= > 221-1' into staging (2021-02-25 19:07:58 +) > > are available in the Git repos

Re: [PATCH v5 0/4] GitLab Custom Runners and Jobs (was: QEMU Gating CI)

2021-03-05 Thread Philippe Mathieu-Daudé
On 3/5/21 11:14 AM, Philippe Mathieu-Daudé wrote: > Hi Cleber, > > On 2/19/21 10:58 PM, Cleber Rosa wrote: >> TL;DR: this should allow the QEMU maintainer to push to the staging >> branch, and have custom jobs running on the project's aarch64 and >> s390x machines. Jobs in this version are allowe

Re: [PATCH 31/44] hw/arm/armsse: Indirect irq_is_common[] through ARMSSEInfo

2021-03-05 Thread Philippe Mathieu-Daudé
On 3/4/21 9:19 PM, Philippe Mathieu-Daudé wrote: > On 2/19/21 3:46 PM, Peter Maydell wrote: >> The SSE-300 has a slightly different set of shared-per-CPU interrupts, >> allow the irq_is_common[] array to be different per SSE variant. >> >> Signed-off-by: Peter Maydell >> --- >> hw/arm/armsse.c |

Re: [PATCH 2/3] qapi, audio: respect build time conditions in audio schema

2021-03-05 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Mar 03, 2021 at 08:00:59AM +0100, Gerd Hoffmann wrote: >> On Tue, Mar 02, 2021 at 05:55:23PM +, Daniel P. Berrangé wrote: >> > Currently the -audiodev accepts any audiodev type regardless of what is >> > built in to QEMU. An error only occurs later at runt

Re: [PATCH 44/44] tests/qtest/sse-timer-test: Add simple tests of the SSE timer and counter

2021-03-05 Thread Philippe Mathieu-Daudé
Hi Peter, On 2/19/21 3:46 PM, Peter Maydell wrote: > Add a simple qtest to exercise the new system counter and > system timer device in the SSE-300. > > Signed-off-by: Peter Maydell > --- > tests/qtest/sse-timer-test.c | 240 +++ > MAINTAINERS |

Re: [PATCH v3 0/2] sbsa-ref: update list of supported cpus

2021-03-05 Thread Peter Maydell
On Tue, 16 Feb 2021 at 15:01, Marcin Juszkiewicz wrote: > > Cortex-A53 goes away due to 40-bit address space (so below sbsa-ref > default memory map) and 'max' goes in as we want to be able to test SVE > support. > > Marcin Juszkiewicz (2): > sbsa-ref: remove cortex-a53 from list of supported cp

Re: [PATCH v2 0/3] target/arm: Add support for FEAT_SSBS

2021-03-05 Thread Peter Maydell
On Tue, 16 Feb 2021 at 22:45, Rebecca Cran wrote: > > > Add support for FEAT_SSBS, Speculative Store Bypass Safe. SSBS is an > optional feature in ARMv8.0 and is mandatory in ARMv8.5. > > Changes from v1 to v2: > > o Removed changes to cpsr_write_from_spsr_elx and cpsr_read_for_spsr_elx. > o Moved

Re: [PATCH v5 0/3] Add npcm7xx emc model

2021-03-05 Thread Peter Maydell
On Thu, 18 Feb 2021 at 21:24, Doug Evans wrote: > > This is a 10/100 ethernet device that has several features. > Only the ones needed by the Linux driver have been implemented. > See npcm7xx_emc.c for a list of unimplemented features. > > Doug Evans (3): > hw/net: Add npcm7xx emc model > hw/a

Re: [PATCH v2] hw/arm/xlnx-zynqmp: Remove obsolete 'has_rpu' property

2021-03-05 Thread Peter Maydell
On Fri, 19 Feb 2021 at 14:43, Philippe Mathieu-Daudé wrote: > > We hint the 'has_rpu' property is no longer required since commit > 6908ec448b4 ("xlnx-zynqmp: Properly support the smp command line > option") which was released in QEMU v2.11.0. > > Beside, this device is marked 'user_creatable = fa

Re: [PATCH v3 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-03-05 Thread Halil Pasic
On Tue, 2 Mar 2021 18:35:44 +0100 Halil Pasic wrote: > Since the virtio-gpu-ccw device depends on the hw-display-virtio-gpu > module, which provides the type virtio-gpu-device, packaging the > hw-display-virtio-gpu module as a separate package that may or may not > be installed along with the qe

Re: [PATCH v2 3/3] target/arm: Set ID_PFR2.SSBS to 1 for "max" 32-bit CPU

2021-03-05 Thread Peter Maydell
On Tue, 16 Feb 2021 at 22:45, Rebecca Cran wrote: > > Enable FEAT_SSBS for the "max" 32-bit CPU. > > Signed-off-by: Rebecca Cran > Reviewed-by: Richard Henderson > --- > target/arm/cpu.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/target/arm/cpu.c b/target/arm/cpu.c > index 5cf

Re: [PATCH v2] target/arm: Speed up aarch64 TBL/TBX

2021-03-05 Thread Peter Maydell
On Thu, 25 Feb 2021 at 09:54, Alex Bennée wrote: > > > Richard Henderson writes: > > > Always perform one call instead of two for 16-byte operands. > > Use byte loads/stores directly into the vector register file > > instead of extractions and deposits to a 64-bit local variable. > > > > In order

Re: [PATCH] hw/i2c/npcm7xx_smbus: Simplify npcm7xx_smbus_init()

2021-03-05 Thread Peter Maydell
On Sun, 28 Feb 2021 at 22:50, Philippe Mathieu-Daudé wrote: > > The STATUS register will be reset to IDLE in > cnpcm7xx_smbus_enter_reset(), no need to preset > it in instance_init(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i2c/npcm7xx_smbus.c | 1 - > 1 file changed, 1 deletion(-)

Re: [PATCH] tcg/aarch64: Fix constant subtraction in tcg_out_addsub2

2021-03-05 Thread Peter Maydell
On Sun, 28 Feb 2021 at 23:55, Richard Henderson wrote: > > An hppa guest executing > > 0xe05c: ldil L%1,r4 > 0xe060: ldo 0(r4),r4 > 0xe064: sub r3,r4,sp > > produces > > e064 e068 > sub2_i32 tmp0,tmp4,r3,$0x1,$0x1,$0x0 >

Re: [PATCH v2 1/1] tricore: fixed faulty conditions for extr and imask

2021-03-05 Thread Bastian Koppelmann
On Thu, Feb 11, 2021 at 12:53:29PM +0100, David Brenken wrote: > From: Andreas Konopik > > Signed-off-by: Andreas Konopik > Signed-off-by: Georg Hofstetter > Signed-off-by: David Brenken > --- > target/tricore/translate.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Review

Re: [PATCH v2 00/24] hw/arm: New board model mps3-an524

2021-03-05 Thread Philippe Mathieu-Daudé
On 2/15/21 12:51 PM, Peter Maydell wrote: > This patchseries implements a new board model in the mps2/mps3 family, > based on Application Note AN524: > https://developer.arm.com/documentation/dai0524/latest/ > Peter Maydell (24): > hw/arm/mps2-tz: Make SYSCLK frequency board-specific > hw/misc

Re: [PATCH v2 14/24] hw/arm/mps2-tz: Size the uart-irq-orgate based on the number of UARTs

2021-03-05 Thread Philippe Mathieu-Daudé
On 2/15/21 12:51 PM, Peter Maydell wrote: > We create an OR gate to wire together the overflow IRQs for all the > UARTs on the board; this has to have twice the number of inputs as > there are UARTs, since each UART feeds it a TX overflow and an RX > overflow interrupt line. Replace the hardcoded

Re: [PATCH v2 18/24] hw/arm/mps2-tz: Support ROMs as well as RAMs

2021-03-05 Thread Philippe Mathieu-Daudé
On 2/15/21 12:51 PM, Peter Maydell wrote: > The AN505 and AN521 don't have any read-only memory, but the AN524 > does; add a flag to ROMInfo to mark a region as ROM. > > Signed-off-by: Peter Maydell > --- > hw/arm/mps2-tz.c | 6 ++ > 1 file changed, 6 insertions(+) Reviewed-by: Philippe Mat

Re: [PATCH v3 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-03-05 Thread Cornelia Huck
On Tue, 2 Mar 2021 18:35:44 +0100 Halil Pasic wrote: > Since the virtio-gpu-ccw device depends on the hw-display-virtio-gpu > module, which provides the type virtio-gpu-device, packaging the > hw-display-virtio-gpu module as a separate package that may or may not > be installed along with the qe

Re: [PATCH 00/44] hw/arm: New board model mps3-an547

2021-03-05 Thread Philippe Mathieu-Daudé
On 2/19/21 3:45 PM, Peter Maydell wrote: > This patchseries implements a model of the AN547 FPGA image for the > MPS3 board. The main benefit of this new board is that it uses the > Cortex-M55 CPU and so it allows running guests which use a v8.1M CPU. > Peter Maydell (44): > clock: Add ClockEve

Re: [PATCH v2 24/24] hw/arm/mps2: Update old infocenter.arm.com URLs

2021-03-05 Thread Philippe Mathieu-Daudé
On 2/15/21 12:51 PM, Peter Maydell wrote: > Update old infocenter.arm.com URLs to the equivalent developer.arm.com > ones (the old URLs should redirect, but we might as well avoid the > redirection notice, and the new URLs are pleasantly shorter). > > This commit covers the links to the MPS2 board

Re: [PATCH v4] virtio-mmio: improve virtio-mmio get_dev_path alog

2021-03-05 Thread Peter Maydell
On Thu, 25 Feb 2021 at 05:36, schspa wrote: > > At the moment the following QEMU command line triggers an assertion > failure On xlnx-versal SOC: > qemu-system-aarch64 \ > -machine xlnx-versal-virt -nographic -smp 2 -m 128 \ > -fsdev local,id=shareid,path=${HOME}/work,security_model=

Re: [PATCH v3 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-03-05 Thread Halil Pasic
On Fri, 5 Mar 2021 12:54:42 +0100 Cornelia Huck wrote: > On Tue, 2 Mar 2021 18:35:44 +0100 > Halil Pasic wrote: > > > Since the virtio-gpu-ccw device depends on the hw-display-virtio-gpu > > module, which provides the type virtio-gpu-device, packaging the > > hw-display-virtio-gpu module as a

Re: [PATCH 2/3] qapi, audio: respect build time conditions in audio schema

2021-03-05 Thread Markus Armbruster
Daniel P. Berrangé writes: > Currently the -audiodev accepts any audiodev type regardless of what is > built in to QEMU. An error only occurs later at runtime when a sound > device tries to use the audio backend. > > With this change QEMU will immediately reject -audiodev args that are > not comp

[PATCH v4] ui/cocoa: Use kCGColorSpaceSRGB

2021-03-05 Thread Akihiko Odaki
kCGColorSpaceGenericRGB | Apple Developer Documentation https://developer.apple.com/documentation/coregraphics/kcgcolorspacegenericrgb > Deprecated > Use kCGColorSpaceSRGB instead. This change also removes the legacy color space specification for PowerPC. Signed-off-by: Akihiko Odaki --- ui/coc

[PATCH v2] block/file-posix: Optimize for macOS

2021-03-05 Thread Akihiko Odaki
This commit introduces "punch hole" operation and optimizes transfer block size for macOS. This commit introduces two additional members, discard_granularity and opt_io to BlockSizes type in include/block/block.h. Also, the members of the type are now optional. Set -1 to discard_granularity and 0

[PATCH] ui/cocoa: Clear modifiers whenever possible

2021-03-05 Thread Akihiko Odaki
ui/cocoa does not receive NSEventTypeFlagsChanged when it is not active, and the modifier state can be desynchronized in such a situation. [NSEvent -modifierFlags] tells whether a modifier is *not* pressed, so check it whenever receiving an event and clear the modifier if it is not pressed. Note

Re: [PATCH v2] block/file-posix: Optimize for macOS

2021-03-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210305121748.65173-1-akihiko.od...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210305121748.65173-1-akihiko.od...@gmail.com Subject: [PATCH v2] block/file-posix:

Re: [PATCH] target/arm: Use TCF0 and TFSRE0 for unprivileged tag checks

2021-03-05 Thread Peter Maydell
On Sat, 20 Feb 2021 at 16:19, Richard Henderson wrote: > > On 2/19/21 12:18 PM, Peter Collingbourne wrote: > > Section D6.7 of the ARM ARM states: > > > > For the purpose of determining Tag Check Fault handling, unprivileged > > load and store instructions are treated as if executed at EL0 when >

Re: [PATCH v2 1/1] tricore: fixed faulty conditions for extr and imask

2021-03-05 Thread Bastian Koppelmann
On Thu, Feb 11, 2021 at 01:49:14PM +, Konopik, Andreas (EFS-GH2) wrote: > Hi Philippe, > > > From: Philippe Mathieu-Daudé On > > Behalf Of Philippe Mathieu-Daudé > > Sent: Thursday, February 11, 2021 13:10 > > Hi David and Andreas, > > > > On 2/11/21 12:53 PM, David Brenken wrote: > > > From

Re: [PATCH 1/3] qapi, audio: add query-audiodev command

2021-03-05 Thread Markus Armbruster
Daniel P. Berrangé writes: > Way back in QEMU 4.0, the -audiodev command line option was introduced > for configuring audio backends. This CLI option does not use QemuOpts > so it is not visible for introspection in 'query-command-line-options', > instead using the QAPI Audiodev type. Unfortunat

Re: [PATCH 3/3] qapi: provide a friendly string representation of QAPI classes

2021-03-05 Thread Markus Armbruster
Daniel P. Berrangé writes: > If printing a QAPI schema object for debugging we get the classname and > a hex value for the instance. With this change we instead get the > classname and the human friendly name of the QAPI type instance. > > Signed-off-by: Daniel P. Berrangé > --- > scripts/qapi/

[PATCH 0/2] tricore: IMASK/EXTR corner case fixes

2021-03-05 Thread Bastian Koppelmann
Hi, while testing Andreas' patch [1], I found two more bugs in IMASK and EXTR which I fixed here. [1] https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg03916.html Cheers, Bastian Bastian Koppelmann (2): target/tricore: Fix imask OPC2_32_RRPW_IMASK for r3+1 == r2 target/tricore: Fix O

[PATCH 1/2] target/tricore: Fix imask OPC2_32_RRPW_IMASK for r3+1 == r2

2021-03-05 Thread Bastian Koppelmann
if r3+1 and r2 are the same then we would overwrite r2 with our first move and use the wrong result for the shift. Thus we store the result from the mov in a temp. Signed-off-by: Bastian Koppelmann --- target/tricore/translate.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff

[PATCH 2/2] target/tricore: Fix OPC2_32_RRPW_EXTR for width=0

2021-03-05 Thread Bastian Koppelmann
if width was 0 we would run into the assertion: qemu-system-tricore: ../upstream/tcg/tcg-op.c:217: tcg_gen_sari_i32: Assertion `arg2 >= 0 && arg2 < 32' failed.o The instruction manuel specifies undefined behaviour for this case. So we bring this in line with the golden Infineon simlator 'tsim',

Re: [PATCH 2/2] target/tricore: Fix OPC2_32_RRPW_EXTR for width=0

2021-03-05 Thread Philippe Mathieu-Daudé
On 3/5/21 2:26 PM, Bastian Koppelmann wrote: > if width was 0 we would run into the assertion: > > qemu-system-tricore: ../upstream/tcg/tcg-op.c:217: tcg_gen_sari_i32: > Assertion `arg2 >= 0 && arg2 < 32' failed.o Maybe strip "../upstream/" > > The instruction manuel specifies undefined behavi

Re: [PATCH v1 1/9] docs/devel: re-organise the developers guide into sections

2021-03-05 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 3/5/21 10:23 AM, Alex Bennée wrote: >> The list of sub-sections was getting a bit long and sporadically >> organised. Let's try and impose some order on this hairball of >> documentation. >> >> [AJB: RFC because I wonder if we should make a more concerted ef

[Bug 1915925] Re: ARM semihosting HEAPINFO results wrote to wrong address

2021-03-05 Thread Alex Bennée
** Changed in: qemu Assignee: (unassigned) => Alex Bennée (ajbennee) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1915925 Title: ARM semihosting HEAPINFO results wrote to wrong address Statu

Re: [PATCH v3 2/5] monitor: drain requests queue with 'channel closed' event

2021-03-05 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 02.03.2021 16:53, Markus Armbruster wrote: >> Andrey Shinkevich via writes: >> >>> When CHR_EVENT_CLOSED comes, the QMP requests queue may still contain >>> unprocessed commands. It can happen with QMP capability OOB enabled. >>> Let the dispatcher complet

[PATCH v1 0/3] semihosting/next (move from hw, heapinfo)

2021-03-05 Thread Alex Bennée
Hi, Not much in this series apart from moving semihosting out of hw (where it sat a bit weirdly) and an attempt at fixing a bug in the SYS_HEAPINFO code. It works AFAICT but still seems a little fugly to me. See: - semihosting/arg-compat: fix up handling of SYS_HEAPINFO Alex Bennée (1): semih

[PATCH v1 2/3] semihosting: Move hw/semihosting/ -> semihosting/

2021-03-05 Thread Alex Bennée
From: Philippe Mathieu-Daudé With the exception of hw/core/, the hw/ directory only contains device models used in system emulation. Semihosting is also used by user emulation. As a generic feature, move it out of hw/ directory. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée

[PATCH v1 3/3] semihosting/arg-compat: fix up handling of SYS_HEAPINFO

2021-03-05 Thread Alex Bennée
I'm not sure this every worked properly and it's certainly not exercised by check-tcg or Peter's semihosting tests. Hoist it into it's own helper function and attempt to validate the results in the linux-user semihosting test at the least. Bug: https://bugs.launchpad.net/bugs/1915925 Cc: Bug 19159

[PATCH v1 1/3] semihosting: Move include/hw/semihosting/ -> include/semihosting/

2021-03-05 Thread Alex Bennée
From: Philippe Mathieu-Daudé We want to move the semihosting code out of hw/ in the next patch. This patch contains the mechanical steps, created using: $ git mv include/hw/semihosting/ include/ $ sed -i s,hw/semihosting,semihosting, $(git grep -l hw/semihosting) Signed-off-by: Philippe Ma

Re: [PATCH v3 1/3] migration/ram: Modify the code comment of ram_save_host_page()

2021-03-05 Thread Peter Xu
On Fri, Mar 05, 2021 at 03:50:33PM +0800, Kunkun Jiang wrote: > The ram_save_host_page() has been modified several times > since its birth. But the comment hasn't been modified as it should > be. It'd better to modify the comment to explain ram_save_host_page() > more clearly. > > Signed-off-by: K

Re: [PATCH v3 2/5] monitor: drain requests queue with 'channel closed' event

2021-03-05 Thread Vladimir Sementsov-Ogievskiy
05.03.2021 16:41, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 02.03.2021 16:53, Markus Armbruster wrote: Andrey Shinkevich via writes: When CHR_EVENT_CLOSED comes, the QMP requests queue may still contain unprocessed commands. It can happen with QMP capability OOB enabled

Re: [Qemu-devel] [PATCH] monitor: increase amount of data for monitor to read

2021-03-05 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 24.11.2020 18:44, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> This patch isn't outdated, it applies on master with a little conflict >> atomic_mb_read -> qatomic_mb_read >> >> We have new series "[PATCH v2 0/2] Increase amount of data for monitor

Re: [PATCH v1 3/3] semihosting/arg-compat: fix up handling of SYS_HEAPINFO

2021-03-05 Thread Peter Maydell
On Fri, 5 Mar 2021 at 13:54, Alex Bennée wrote: > > I'm not sure this every worked properly and it's certainly not > exercised by check-tcg or Peter's semihosting tests. Hoist it into > it's own helper function and attempt to validate the results in the > linux-user semihosting test at the least.

Re: [PATCH] linux-user: Adjust pgd_find_hole_fallback result with guest_loaddr

2021-03-05 Thread Alex Bennée
Ivan A. Melnikov writes: > While pgd_find_hole_fallback returns the beginning of the > hole found, pgb_find_hole returns guest_base, which > is somewhat different as the binary qemu-user is loading > usually has non-zero load address. > > Failing to take this into account leads to random crashe

Re: [PATCH 02/27] tcg/aarch64: Fix I3617_CMLE0

2021-03-05 Thread Peter Maydell
On Tue, 2 Mar 2021 at 18:05, Richard Henderson wrote: > > Fix a typo in the encodeing of the cmle (zero) instruction. > > Fixes: 14e4c1e2355 ("tcg/aarch64: Add vector operations") > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c.inc | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH v3 2/3] migration/ram: Reduce unnecessary rate limiting

2021-03-05 Thread Peter Xu
Kunkun, On Fri, Mar 05, 2021 at 03:50:34PM +0800, Kunkun Jiang wrote: > When the host page is a huge page and something is sent in the > current iteration, the migration_rate_limit() should be executed. > If not, this function can be omitted to save time. > > Rename tmppages to pages_this_iterati

Re: [PATCH v3 3/3] migration/ram: Optimize ram_save_host_page()

2021-03-05 Thread Peter Xu
On Fri, Mar 05, 2021 at 03:50:35PM +0800, Kunkun Jiang wrote: > Starting from pss->page, ram_save_host_page() will check every page > and send the dirty pages up to the end of the current host page or > the boundary of used_length of the block. If the host page size is > a huge page, the step "chec

Re: [PATCH 03/27] tcg/aarch64: Fix generation of "scalar" vector operations

2021-03-05 Thread Peter Maydell
On Tue, 2 Mar 2021 at 18:00, Richard Henderson wrote: > > For some vector operations, "1D" is not a valid type, and there > are separate instructions for the 64-bit scalar operation. > > Tested-by: Stefan Weil > Buglink: https://bugs.launchpad.net/qemu/+bug/1916112 > Fixes: 14e4c1e2355 ("tcg/aarc

Re: [PATCH v2 0/3] target/arm: Restrict v7A TCG cpus to TCG accel

2021-03-05 Thread Peter Maydell
On Sun, 21 Feb 2021 at 22:26, Philippe Mathieu-Daudé wrote: > > KVM requires the target cpu to be at least ARMv8 architecture. > > Restrict the last ARMv7 CPUs (A-profile) to TCG. > > Series almost fully reviewed (missing review is trivial code style). > > Since v1: Only include patches which don'

Re: [PATCH] hw/sh4/sh7750_regs: Replace link to license by its full content

2021-03-05 Thread Peter Maydell
On Thu, 4 Mar 2021 at 13:47, Philippe Mathieu-Daudé wrote: > > ping? > > On 2/22/21 7:56 PM, Philippe Mathieu-Daudé wrote: > > This file is borrowed from the RTEMS source code, which comes > > with a GPL-2.0-or-later license with a header exception. > > > > Expand the GPL-2.0-or-later license in p

Re: [Qemu-devel] [PATCH] monitor: increase amount of data for monitor to read

2021-03-05 Thread Vladimir Sementsov-Ogievskiy
05.03.2021 17:10, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 24.11.2020 18:44, Vladimir Sementsov-Ogievskiy wrote: Hi all! This patch isn't outdated, it applies on master with a little conflict atomic_mb_read -> qatomic_mb_read We have new series "[PATCH v2 0/2] Increase

[RFC PATCH] .editorconfig: update the automatic mode setting for Emacs

2021-03-05 Thread Alex Bennée
It seems the editor specific keywords have been deprecated in the main editorconfig plugin: https://github.com/editorconfig/editorconfig-emacs#file-type-file_type_ext-file_type_emacs Update the keywords to the suggested one and point users at the extension. Signed-off-by: Alex Bennée Cc: Mar

  1   2   3   4   >