[PATCH v2 1/2] storage-daemon: report unexpected arguments on the fly

2021-03-01 Thread Paolo Bonzini
If the first character of optstring is '-', then each nonoption argv element is handled as if it were the argument of an option with character code 1. This removes the reordering of the argv array, and enables usage of loc_set_cmdline to provide better error messages. Signed-off-by: Paolo Bonzini

Re: [PATCH 1/2] i386/acpi: fix inconsistent QEMU/OVMF device paths

2021-03-01 Thread Michael S. Tsirkin
On Mon, Mar 01, 2021 at 08:45:53AM +0100, Thomas Lamprecht wrote: > On 01.03.21 08:20, Michael S. Tsirkin wrote: > > On Mon, Mar 01, 2021 at 08:12:35AM +0100, Thomas Lamprecht wrote: > >> On 28.02.21 21:43, Michael S. Tsirkin wrote: > >>> Sure. The way to do that is to tie old behaviour to old mach

[PATCH] docs: show how to spawn qemu-storage-daemon with fd passing

2021-03-01 Thread Stefan Hajnoczi
The QMP monitor, NBD server, and vhost-user-blk export all support file descriptor passing. This is a useful technique because it allows the parent process to spawn and wait for qemu-storage-daemon without busy waiting, which may delay startup due to arbitrary sleep() calls. This Python example is

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-03-01 Thread Igor Mammedov
On Wed, 24 Feb 2021 18:00:43 +0100 Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > > On Tue, 23 Feb 2021 19:08:42 +0100 > > Vitaly Kuznetsov wrote: > > > >> Igor Mammedov writes: > >> > >> > On Tue, 23 Feb 2021 16:46:50 +0100 > >> > Vitaly Kuznetsov wrote: > >> > > >> >> Igor Ma

[PATCH] pcnet: switch to use qemu_receive_packet() for loopback

2021-03-01 Thread Alexander Bulekov
This patch switches to use qemu_receive_packet() which can detect reentrancy and return early. Buglink: https://bugs.launchpad.net/qemu/+bug/1917085 Signed-off-by: Alexander Bulekov --- Here's another one, that looks like the same issue. -Alex hw/net/pcnet.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH v2 5/5] hw/block/nvme: report non-mdts command size limit for dsm

2021-03-01 Thread Keith Busch
On Mon, Mar 01, 2021 at 12:15:26PM +0100, Klaus Jensen wrote: > On Feb 22 22:12, Klaus Jensen wrote: > > On Feb 23 05:55, Keith Busch wrote: > > > On Mon, Feb 22, 2021 at 07:47:59PM +0100, Klaus Jensen wrote: > > > > +typedef struct NvmeIdCtrlNvm { > > > > +uint8_t vsl; > > > > +uint8_t

Re: [PATCH v2 1/2] storage-daemon: report unexpected arguments on the fly

2021-03-01 Thread Eric Blake
On 3/1/21 9:28 AM, Paolo Bonzini wrote: > If the first character of optstring is '-', then each nonoption argv > element is handled as if it were the argument of an option with character > code 1. This removes the reordering of the argv array, and enables usage > of loc_set_cmdline to provide bett

Re: [PATCH] docs: show how to spawn qemu-storage-daemon with fd passing

2021-03-01 Thread Richard W.M. Jones
On Mon, Mar 01, 2021 at 03:31:59PM +, Stefan Hajnoczi wrote: > The QMP monitor, NBD server, and vhost-user-blk export all support file > descriptor passing. This is a useful technique because it allows the > parent process to spawn and wait for qemu-storage-daemon without busy > waiting, which

Re: [PATCH] docs: show how to spawn qemu-storage-daemon with fd passing

2021-03-01 Thread Daniel P . Berrangé
On Mon, Mar 01, 2021 at 03:31:59PM +, Stefan Hajnoczi wrote: > The QMP monitor, NBD server, and vhost-user-blk export all support file > descriptor passing. This is a useful technique because it allows the > parent process to spawn and wait for qemu-storage-daemon without busy > waiting, which

Re: [PATCH] docs: show how to spawn qemu-storage-daemon with fd passing

2021-03-01 Thread Daniel P . Berrangé
On Mon, Mar 01, 2021 at 03:39:06PM +, Richard W.M. Jones wrote: > On Mon, Mar 01, 2021 at 03:31:59PM +, Stefan Hajnoczi wrote: > > The QMP monitor, NBD server, and vhost-user-blk export all support file > > descriptor passing. This is a useful technique because it allows the > > parent proc

Re: [PATCH] docs: show how to spawn qemu-storage-daemon with fd passing

2021-03-01 Thread Eric Blake
On 3/1/21 9:41 AM, Daniel P. Berrangé wrote: > On Mon, Mar 01, 2021 at 03:31:59PM +, Stefan Hajnoczi wrote: >> The QMP monitor, NBD server, and vhost-user-blk export all support file >> descriptor passing. This is a useful technique because it allows the >> parent process to spawn and wait for

Re: [RFC PATCH 4/5] hw/acpi/aml-build: add processor hierarchy node structure

2021-03-01 Thread Michael S. Tsirkin
On Mon, Mar 01, 2021 at 10:39:19AM +0100, Andrew Jones wrote: > On Fri, Feb 26, 2021 at 10:23:03AM +0800, Ying Fang wrote: > > > > > > On 2/25/2021 7:47 PM, Andrew Jones wrote: > > > On Thu, Feb 25, 2021 at 04:56:26PM +0800, Ying Fang wrote: > > > > Add the processor hierarchy node structures to

Re: [RFC]migration: stop/start device at the end of live migration concurrently

2021-03-01 Thread Dr. David Alan Gilbert
* Wangxin (Alexander) (wangxinxin.w...@huawei.com) wrote: > Hi all, (copying in Michael for vhost user maintainer). > We found that the downtime of migration will reach a few seconds when live > migrating a huge VM with 224vCPU/180GiB/16 vhost-user nics (x32 queues)/ > 24 vhost-user-blk disks(x4

About '-readconfig' [Was: Re: [PULL 27/29] vl: deprecate -writeconfig]

2021-03-01 Thread Kashyap Chamarthy
On Fri, Feb 26, 2021 at 09:05:24AM +0100, Paolo Bonzini wrote: > The functionality of -writeconfig is limited and the code > does not even try to detect cases where it prints incorrect > syntax (for example if values have a quote in them, since > qemu_config_parse does not support any kind of escap

Re: [PATCH] docs: show how to spawn qemu-storage-daemon with fd passing

2021-03-01 Thread Daniel P . Berrangé
On Mon, Mar 01, 2021 at 09:49:21AM -0600, Eric Blake wrote: > On 3/1/21 9:41 AM, Daniel P. Berrangé wrote: > > On Mon, Mar 01, 2021 at 03:31:59PM +, Stefan Hajnoczi wrote: > >> The QMP monitor, NBD server, and vhost-user-blk export all support file > >> descriptor passing. This is a useful tech

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-03-01 Thread Doug Evans
On Sun, Feb 28, 2021 at 1:40 PM Samuel Thibault wrote: > Hello, > > Daniel P. Berrangé, le lun. 22 févr. 2021 09:39:41 +, a ecrit: > > > The is_v6 flag is only needed > > for the legacy compat needs in slirp, even that is only if we want to > > have strict equivalence with historical behaviou

[PATCH] qemu-storage-daemon: add --pidfile option

2021-03-01 Thread Stefan Hajnoczi
Daemons often have a --pidfile option where the pid is written to a file so that scripts can stop the daemon by sending a signal. The pid file also acts as a lock to prevent multiple instances of the daemon from launching for a given pid file. QEMU, qemu-nbd, qemu-ga, virtiofsd, and qemu-pr-helpe

Re: [PATCH RFC v3 12/12] hw/block/nvme: add support for the format nvm command

2021-03-01 Thread Keith Busch
On Wed, Feb 17, 2021 at 09:26:37AM +0100, Klaus Jensen wrote: > On Feb 16 15:16, Keith Busch wrote: > > On Mon, Feb 15, 2021 at 12:02:40AM +0100, Klaus Jensen wrote: > > > From: Minwoo Im > > > > > > Format NVM admin command can make a namespace or namespaces to be > > > with different LBA size a

checkpatch: Use of uninitialized value $acpi_testexpected

2021-03-01 Thread Claudio Fontana
Hi all, just wanted to mention this warning from checkpatch: Use of uninitialized value $acpi_testexpected in string eq at scripts/checkpatch.pl line 1529. I saw in process { my $acpi_testexpected; my $acpi_nontestexpected; which looked a bit weird to me, "nontestexpected"? A

[PATCH v2 0/5] softmmu/memory_mapping: optimize dump/tpm for virtio-mem

2021-03-01 Thread David Hildenbrand
Minor fixes and cleanups, followed by an optimization for virtio-mem regarding guest dumps and tpm. virtio-mem logically plugs/unplugs memory within a sparse memory region and notifies via the RamDiscardMgr interface when parts become plugged (populated) or unplugged (discarded). Currently, guest

[PATCH v2 5/5] softmmu/memory_mapping: optimize for RamDiscardManager sections

2021-03-01 Thread David Hildenbrand
virtio-mem logically plugs/unplugs memory within a sparse memory region and notifies via the RamDiscardManager interface when parts become plugged (populated) or unplugged (discarded). Currently, we end up (via the two users) 1) zeroing all logically unplugged/discarded memory during TPM resets. 2

[PATCH v2 3/5] softmmu/memory_mapping: never merge ranges accross memory regions

2021-03-01 Thread David Hildenbrand
Let's make sure to not merge when different memory regions are involved. Unlikely, but theoretically possible. Cc: Marc-André Lureau Cc: Paolo Bonzini Cc: "Michael S. Tsirkin" Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Claudio Fontana Cc: Thomas Huth Cc: "Alex Ben

[PATCH v2 1/5] tpm: mark correct memory region range dirty when clearing RAM

2021-03-01 Thread David Hildenbrand
We might not start at the beginning of the memory region. We could also calculate via the difference in the host address; however, memory_region_set_dirty() also relies on memory_region_get_ram_addr() internally, so let's just use that. Acked-by: Stefan Berger Fixes: ffab1be70692 ("tpm: clear RAM

[PATCH v2 2/5] softmmu/memory_mapping: reuse qemu_get_guest_simple_memory_mapping()

2021-03-01 Thread David Hildenbrand
Let's reuse qemu_get_guest_simple_memory_mapping(), which does exactly what we want. Cc: Marc-André Lureau Cc: Paolo Bonzini Cc: "Michael S. Tsirkin" Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Claudio Fontana Cc: Thomas Huth Cc: "Alex Bennée" Cc: Peter Xu Cc: La

Re: [PATCH] qemu-storage-daemon: add --pidfile option

2021-03-01 Thread Daniel P . Berrangé
On Mon, Mar 01, 2021 at 04:08:57PM +, Stefan Hajnoczi wrote: > Daemons often have a --pidfile option where the pid is written to a file > so that scripts can stop the daemon by sending a signal. > > The pid file also acts as a lock to prevent multiple instances of the > daemon from launching f

Re: [PATCH] docs: move CODING_STYLE into the developer documentation

2021-03-01 Thread Stefan Hajnoczi
On Wed, Feb 24, 2021 at 03:33:41PM +, Daniel P. Berrangé wrote: > On Wed, Feb 24, 2021 at 03:25:41PM +, Stefan Hajnoczi wrote: > > On Wed, Feb 24, 2021 at 12:19:25PM +, Daniel P. Berrangé wrote: > > > On Wed, Feb 24, 2021 at 12:15:05PM +, Stefan Hajnoczi wrote: > > > > On Tue, Feb 2

[PATCH v2 4/5] softmmu/memory_mapping: factor out adding physical memory ranges

2021-03-01 Thread David Hildenbrand
Let's factor out adding a MemoryRegionSection to the list, to be reused in RamDiscardManager context next. Cc: Marc-André Lureau Cc: Paolo Bonzini Cc: "Michael S. Tsirkin" Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Claudio Fontana Cc: Thomas Huth Cc: "Alex Bennée"

Re: [PATCH 1/2] i386/acpi: fix inconsistent QEMU/OVMF device paths

2021-03-01 Thread Michael S. Tsirkin
On Mon, Mar 01, 2021 at 02:28:19PM +0100, Igor Mammedov wrote: > On Sun, 28 Feb 2021 15:43:40 -0500 > "Michael S. Tsirkin" wrote: > > > On Sat, Feb 27, 2021 at 08:41:11PM +0100, Thomas Lamprecht wrote: > > > On 30.07.20 17:58, Michael S. Tsirkin wrote: > > > > macOS uses ACPI UIDs to build the

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-03-01 Thread Vitaly Kuznetsov
Igor Mammedov writes: > On Wed, 24 Feb 2021 18:00:43 +0100 > Vitaly Kuznetsov wrote: > >> Igor Mammedov writes: >> >> > On Tue, 23 Feb 2021 19:08:42 +0100 >> > Vitaly Kuznetsov wrote: >> > >> >> Igor Mammedov writes: >> >> >> >> > On Tue, 23 Feb 2021 16:46:50 +0100 >> >> > Vitaly Kuznet

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-03-01 Thread Doug Evans
On Sun, Feb 28, 2021 at 1:40 PM Samuel Thibault wrote: > [...] > > Note that one issue I am leaving for later (i.e., I don't want to drag > this > > patch series out to include it), is whether and how to support > ipv4-host-> > > ipv6-guest forwarding and vice versa. Can libslirp support this? >

Re: About '-readconfig' [Was: Re: [PULL 27/29] vl: deprecate -writeconfig]

2021-03-01 Thread Paolo Bonzini
On 01/03/21 17:03, Kashyap Chamarthy wrote: On Fri, Feb 26, 2021 at 09:05:24AM +0100, Paolo Bonzini wrote: The functionality of -writeconfig is limited and the code does not even try to detect cases where it prints incorrect syntax (for example if values have a quote in them, since qemu_config_p

Re: [PATCH] qemu-storage-daemon: add --pidfile option

2021-03-01 Thread Richard W.M. Jones
On Mon, Mar 01, 2021 at 04:15:47PM +, Daniel P. Berrangé wrote: > On Mon, Mar 01, 2021 at 04:08:57PM +, Stefan Hajnoczi wrote: > > Daemons often have a --pidfile option where the pid is written to a file > > so that scripts can stop the daemon by sending a signal. > > > > The pid file also

Re: [PATCH v2 06/10] target/hexagon: prepare input for the idef-parser

2021-03-01 Thread Paolo Montesel via
> > +/* Copy rules */ > > +#define fLSBOLD(VAL) (fGETBIT(0, VAL)) > > +#define fSATH(VAL) fSATN(16, VAL) > > +#define fSATUH(VAL) fSATUN(16, VAL) > > +#define fVSATH(VAL) fVSATN(16, VAL) > > +#define fVSATUH(VAL) fVSATUN(16, VAL) > > +#define fSATUB(VAL) fSATUN(8, VAL) > > +#define fSATB(VAL) fSATN

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-03-01 Thread Samuel Thibault
Doug Evans, le lun. 01 mars 2021 08:07:19 -0800, a ecrit: > Are there any users that this functional change would break? > [Previously the empty address meant qemu would only listen on ipv4 addr-any.] One case that could be broken would be a user having already another service listening on ipv6-on

Re: [RFC v1 00/38] arm cleanup experiment for kvm-only build

2021-03-01 Thread Alex Bennée
Claudio Fontana writes: > On 2/23/21 10:18 AM, Philippe Mathieu-Daudé wrote: >> On 2/22/21 8:00 PM, Alex Bennée wrote: >>> >>> Claudio Fontana writes: >>> Hi all, this is an experiment, a cleanup based on and requiring the series "i386 cleanup PART 2": https://lis

Re: [PATCH v2 1/2] storage-daemon: report unexpected arguments on the fly

2021-03-01 Thread Paolo Bonzini
On 01/03/21 16:38, Eric Blake wrote: On 3/1/21 9:28 AM, Paolo Bonzini wrote: If the first character of optstring is '-', then each nonoption argv element is handled as if it were the argument of an option with character code 1. This removes the reordering of the argv array, and enables usage of

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-03-01 Thread Samuel Thibault
Doug Evans, le lun. 01 mars 2021 08:23:03 -0800, a ecrit: > On Sun, Feb 28, 2021 at 1:40 PM Samuel Thibault <[1]samuel.thiba...@gnu.org> > wrote: > > [...] > > Note that one issue I am leaving for later (i.e., I don't want to drag > this > > patch series out to include it), is whet

Re: [PATCH 1/2] i386/acpi: fix inconsistent QEMU/OVMF device paths

2021-03-01 Thread Laszlo Ersek
On 03/01/21 17:14, Michael S. Tsirkin wrote: > On Mon, Mar 01, 2021 at 02:28:19PM +0100, Igor Mammedov wrote: >> How about: >> * buggy ACPI for 5.1 machine types and older >> * fixed ACPI for 5.2 and newer? > > Exactly. Sounds OK to me as well (even though it's quite unfortunate that this is o

Re: [virtio-dev] [VHOST USER SPEC PATCH] vhost-user.rst: add clarifying language about protocol negotiation

2021-03-01 Thread Stefan Hajnoczi
On Mon, Mar 01, 2021 at 11:38:47AM +, Alex Bennée wrote: > Stefan Hajnoczi writes: > > On Fri, Feb 26, 2021 at 11:16:19AM +, Alex Bennée wrote: > >> +However as the protocol negotiation something that only occurs between > > > > Missing "is". Shortening the sentence fixes that without losi

Re: [PATCH v3 02/16] qapi/expr.py: Check for dict instead of OrderedDict

2021-03-01 Thread Markus Armbruster
John Snow writes: > On 2/25/21 5:40 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 2/24/21 4:30 AM, Markus Armbruster wrote: John Snow writes: > OrderedDict is a subtype of dict, so we can check for a more general > form. These functions do not themselves depend

Re: [PATCH] docs: show how to spawn qemu-storage-daemon with fd passing

2021-03-01 Thread Stefan Hajnoczi
On Mon, Mar 01, 2021 at 03:44:42PM +, Daniel P. Berrangé wrote: > On Mon, Mar 01, 2021 at 03:39:06PM +, Richard W.M. Jones wrote: > > On Mon, Mar 01, 2021 at 03:31:59PM +, Stefan Hajnoczi wrote: > > > The QMP monitor, NBD server, and vhost-user-blk export all support file > > > descript

Re: [PATCH] iotests: Fix up python style in 300

2021-03-01 Thread John Snow
On 2/26/21 2:04 AM, Vladimir Sementsov-Ogievskiy wrote: 16.02.2021 02:21, John Snow wrote: On 2/15/21 5:05 PM, Eric Blake wrote: Break some long lines, and relax our type hints to be more generic to any JSON, in order to more easily permit the additional JSON depth now possible in migration par

Re: [PATCH] docs: show how to spawn qemu-storage-daemon with fd passing

2021-03-01 Thread Stefan Hajnoczi
On Mon, Mar 01, 2021 at 03:39:06PM +, Richard W.M. Jones wrote: > On Mon, Mar 01, 2021 at 03:31:59PM +, Stefan Hajnoczi wrote: > > The QMP monitor, NBD server, and vhost-user-blk export all support file > > descriptor passing. This is a useful technique because it allows the > > parent proc

Re: [PATCH] docs: show how to spawn qemu-storage-daemon with fd passing

2021-03-01 Thread Stefan Hajnoczi
On Mon, Mar 01, 2021 at 04:06:47PM +, Daniel P. Berrangé wrote: > On Mon, Mar 01, 2021 at 09:49:21AM -0600, Eric Blake wrote: > > On 3/1/21 9:41 AM, Daniel P. Berrangé wrote: > > > On Mon, Mar 01, 2021 at 03:31:59PM +, Stefan Hajnoczi wrote: > > >> The QMP monitor, NBD server, and vhost-use

Re: [PATCH] docs: show how to spawn qemu-storage-daemon with fd passing

2021-03-01 Thread Daniel P . Berrangé
On Mon, Mar 01, 2021 at 04:50:14PM +, Stefan Hajnoczi wrote: > On Mon, Mar 01, 2021 at 03:44:42PM +, Daniel P. Berrangé wrote: > > On Mon, Mar 01, 2021 at 03:39:06PM +, Richard W.M. Jones wrote: > > > On Mon, Mar 01, 2021 at 03:31:59PM +, Stefan Hajnoczi wrote: > > > > The QMP monit

[PATCH 1/1] i386: Add support for AMD new-style boot mechanism.

2021-03-01 Thread Danny Milosavljevic
This introduces a new generic-loader setting "csbaseaddr" that allows you to set the segment base address of CS. Signed-off-by: Danny Milosavljevic --- hw/core/generic-loader.c | 5 - include/hw/core/cpu.h| 1 + include/hw/core/generic-loader.h | 1 + target/i386/cpu.c

Re: [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors

2021-03-01 Thread Pankaj Gupta
Hi Babu, I tried to test below patch for AMD EPYC Rome CPU and I got below error [1]: Also, I noticed SSBD CPU flag for guest was still available even without this patch, I noticed that for the guest, AMD_SSBD not got set. Guest: 0x8008 0x00: eax=0x3028 ebx=0x9205 ecx=0x2003 edx=

[PATCH 0/1] Add support for AMD new-style boot mechanism.

2021-03-01 Thread Danny Milosavljevic
A lot of AMD CPUs boot the bootstrap processor using a new mechanism. According to https://doc.coreboot.org/soc/amd/family17h.html [1] that means that the flash header specifies a destination and size in RAM (!), and the bootstrap processor will start using a CS segment descriptor set up in such a

Re: [PATCH RFC v3 12/12] hw/block/nvme: add support for the format nvm command

2021-03-01 Thread Klaus Jensen
On Mar 2 01:09, Keith Busch wrote: > On Wed, Feb 17, 2021 at 09:26:37AM +0100, Klaus Jensen wrote: > > On Feb 16 15:16, Keith Busch wrote: > > > On Mon, Feb 15, 2021 at 12:02:40AM +0100, Klaus Jensen wrote: > > > > From: Minwoo Im > > > > > > > > Format NVM admin command can make a namespace or

[PATCH v2 0/2] docs: show how to spawn qemu-storage-daemon with fd passing

2021-03-01 Thread Stefan Hajnoczi
Add an example of how to spawn qemu-storage-daemon with fd passing. This approach eliminates the need to busy wait for the QMP, NBD, or vhost-user socket to become available. v2: * Use /var/run/qmp.sock instead of /tmp/qmp-$PID.sock to prevent security issues with world-writeable directories [

[PATCH v2 1/2] docs: show how to spawn qemu-storage-daemon with fd passing

2021-03-01 Thread Stefan Hajnoczi
The QMP monitor, NBD server, and vhost-user-blk export all support file descriptor passing. This is a useful technique because it allows the parent process to spawn and wait for qemu-storage-daemon without busy waiting, which may delay startup due to arbitrary sleep() calls. This Python example is

[PATCH v2 2/2] docs: replace insecure /tmp examples in qsd docs

2021-03-01 Thread Stefan Hajnoczi
World-writeable directories have security issues. Avoid showing them in the documentation since someone might accidentally use them in situations where they are insecure. There tend to be 3 security problems: 1. Denial of service. An adversary may be able to create the file beforehand, consume

Re: [PATCH] hw/i2c/npcm7xx_smbus: Simplify npcm7xx_smbus_init()

2021-03-01 Thread Hao Wu
On Sun, Feb 28, 2021 at 2:50 PM Philippe Mathieu-Daudé wrote: > The STATUS register will be reset to IDLE in > cnpcm7xx_smbus_enter_reset(), no need to preset > it in instance_init(). > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Hao Wu > --- > hw/i2c/npcm7xx_smbus.c | 1 - > 1 fil

Re: [PATCH 0/1] Add support for AMD new-style boot mechanism.

2021-03-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210301161432.22554-1-danny.m...@datacom.wien/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210301161432.22554-1-danny.m...@datacom.wien Subject: [PATCH 0/1] Add support for A

Re: [virtio-dev] [VHOST USER SPEC PATCH] vhost-user.rst: add clarifying language about protocol negotiation

2021-03-01 Thread Michael S. Tsirkin
On Mon, Mar 01, 2021 at 04:35:51PM +, Stefan Hajnoczi wrote: > On Mon, Mar 01, 2021 at 11:38:47AM +, Alex Bennée wrote: > > Stefan Hajnoczi writes: > > > On Fri, Feb 26, 2021 at 11:16:19AM +, Alex Bennée wrote: > > >> +However as the protocol negotiation something that only occurs betw

Some more questions with regards to QEMU clock record and replay

2021-03-01 Thread Arnabjyoti Kalita
Hello all, I am really thankful for the wonderful answers in my last post linked below- https://lists.nongnu.org/archive/html/qemu-discuss/2021-02/msg00131.html In continuation with the last post, I have a few more questions to ask - My experiment is still, mostly the same. I record clock value

Re: [PATCH] docs: show how to spawn qemu-storage-daemon with fd passing

2021-03-01 Thread Stefan Hajnoczi
On Mon, Mar 01, 2021 at 04:56:17PM +, Daniel P. Berrangé wrote: > On Mon, Mar 01, 2021 at 04:50:14PM +, Stefan Hajnoczi wrote: > > On Mon, Mar 01, 2021 at 03:44:42PM +, Daniel P. Berrangé wrote: > > > On Mon, Mar 01, 2021 at 03:39:06PM +, Richard W.M. Jones wrote: > > > > On Mon, Ma

[PATCH v3 0/2] docs: show how to spawn qemu-storage-daemon with fd passing

2021-03-01 Thread Stefan Hajnoczi
v3: * Explain how to detect launch errors and that the listen socket must be closed in the parent process in order for this to work [Daniel] v2: * Use /var/run/qmp.sock instead of /tmp/qmp-$PID.sock to prevent security issues with world-writeable directories [Rich, Daniel] * Add Patch 2 t

[PATCH v3 2/2] docs: replace insecure /tmp examples in qsd docs

2021-03-01 Thread Stefan Hajnoczi
World-writeable directories have security issues. Avoid showing them in the documentation since someone might accidentally use them in situations where they are insecure. There tend to be 3 security problems: 1. Denial of service. An adversary may be able to create the file beforehand, consume

[PATCH v3 1/2] docs: show how to spawn qemu-storage-daemon with fd passing

2021-03-01 Thread Stefan Hajnoczi
The QMP monitor, NBD server, and vhost-user-blk export all support file descriptor passing. This is a useful technique because it allows the parent process to spawn and wait for qemu-storage-daemon without busy waiting, which may delay startup due to arbitrary sleep() calls. This Python example is

[PATCH] Document qemu-img options data_file and data_file_raw

2021-03-01 Thread Connor Kuehl
The contents of this patch were initially developed and posted by Han Han[1], however, it appears the original patch was not applied. Since then, the relevant documentation has been moved and adapted to a new format. I've taken most of the original wording and tweaked it according to some of the f

Re: [PATCH] Document qemu-img options data_file and data_file_raw

2021-03-01 Thread Eric Blake
On 3/1/21 11:28 AM, Connor Kuehl wrote: > The contents of this patch were initially developed and posted by Han > Han[1], however, it appears the original patch was not applied. Since > then, the relevant documentation has been moved and adapted to a new > format. > > I've taken most of the origin

Re: [PATCH RFC] hw/misc/pc-testdev: add support for ioregionfd testing

2021-03-01 Thread Stefan Hajnoczi
On Mon, Mar 01, 2021 at 04:16:28PM +0300, Elena Afanasova wrote: Thanks for posting this piece of the ioregionfd testing infrastructure! Please include a commit description even if it's just an RFC patch. People on qemu-devel may not be aware of ioregionfd or the purpose of this patch. Something

Re: [RFC PATCH v2 3/3] hw/block/pflash: use memory_region_init_rom_device_from_file()

2021-03-01 Thread Stefan Hajnoczi
On Mon, Mar 01, 2021 at 12:53:29PM +0100, Philippe Mathieu-Daudé wrote: > If the block drive is read-only we will model a "protected" flash > device. We can thus use memory_region_init_rom_device_from_file() > which mmap the backing file when creating the MemoryRegion. > If the same backing file is

Re: [RFC v2 04/24] target/arm: move psci.c into tcg/sysemu/

2021-03-01 Thread Richard Henderson
On 3/1/21 8:49 AM, Claudio Fontana wrote: diff --git a/target/arm/internals.h b/target/arm/internals.h index 05cebc8597..e18d475572 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -292,21 +292,15 @@ vaddr arm_adjust_watchpoint_address(CPUState *cs, vaddr addr, int len); /*

Re: [PATCH v2 0/2] docs: show how to spawn qemu-storage-daemon with fd passing

2021-03-01 Thread Stefan Hajnoczi
On Mon, Mar 01, 2021 at 05:11:05PM +, Stefan Hajnoczi wrote: > Add an example of how to spawn qemu-storage-daemon with fd passing. This > approach eliminates the need to busy wait for the QMP, NBD, or vhost-user > socket to become available. > > v2: > * Use /var/run/qmp.sock instead of /tmp/q

Re: [RFC v1 34/38] target/arm: cpu: only initialize TCG gt timers under CONFIG_TCG

2021-03-01 Thread Olaf Hering
Am Sun, 21 Feb 2021 14:59:38 +0100 schrieb Claudio Fontana : > On 2/21/21 10:55 AM, Philippe Mathieu-Daudé wrote: > > On 2/21/21 10:24 AM, Claudio Fontana wrote: > >> @@ -1347,7 +1348,8 @@ static void arm_cpu_realizefn(DeviceState *dev, > >> Error **errp) > >> cpu->gt_timer[GTIMER_HYP

Re: [PATCH v2 0/2] storage-daemon: include current command line option in the errors

2021-03-01 Thread Kevin Wolf
Am 01.03.2021 um 16:28 hat Paolo Bonzini geschrieben: > Use the location management facilities that the emulator uses, so that > the current command line option appears in the error message. > > Before: > > $ storage-daemon/qemu-storage-daemon --nbd key..= > qemu-storage-daemon: Invalid param

Re: [PATCH v3 1/2] docs: show how to spawn qemu-storage-daemon with fd passing

2021-03-01 Thread Daniel P . Berrangé
On Mon, Mar 01, 2021 at 05:27:27PM +, Stefan Hajnoczi wrote: > The QMP monitor, NBD server, and vhost-user-blk export all support file > descriptor passing. This is a useful technique because it allows the > parent process to spawn and wait for qemu-storage-daemon without busy > waiting, which

Re: [PATCH v3 2/2] docs: replace insecure /tmp examples in qsd docs

2021-03-01 Thread Daniel P . Berrangé
On Mon, Mar 01, 2021 at 05:27:28PM +, Stefan Hajnoczi wrote: > World-writeable directories have security issues. Avoid showing them in > the documentation since someone might accidentally use them in > situations where they are insecure. > > There tend to be 3 security problems: > 1. Denial of

Re: [RFC v2 07/24] target/arm: move physical address translation to new modules

2021-03-01 Thread Richard Henderson
On 3/1/21 8:49 AM, Claudio Fontana wrote: --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -1023,9 +1023,6 @@ typedef struct ARMVAParameters { bool using64k : 1; } ARMVAParameters; -ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va, -

Re: [PATCH v4 00/12] hw/block/nvme: metadata and end-to-end data protection support

2021-03-01 Thread Keith Busch
On Mon, Mar 01, 2021 at 03:00:35PM +0100, Klaus Jensen wrote: > From: Klaus Jensen > > This is v4 (RFC removed) of a series that adds support for metadata and > end-to-end data protection. > > First, on the subject of metadata, in v1, support was restricted to > extended logical blocks, which wa

Re: [PATCH v3 2/2] docs: replace insecure /tmp examples in qsd docs

2021-03-01 Thread Richard W.M. Jones
For the series: Reviewed-by: Richard W.M. Jones Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows insta

Re: [PATCH v2 0/7] acpi: Error Record Serialization Table, ERST, support for QEMU

2021-03-01 Thread Eric Devolder
Hi, A friendly request to review and/or provide feedback on this patchset. Thanks, eric From: Eric Devolder Sent: Monday, February 8, 2021 2:58 PM To: m...@redhat.com ; imamm...@redhat.com ; marcel.apfelb...@gmail.com ; pbonz...@redhat.com ; r...@twiddle.net ; e

Re: [PATCH 1/2] i386/acpi: fix inconsistent QEMU/OVMF device paths

2021-03-01 Thread Igor Mammedov
On Mon, 1 Mar 2021 17:28:05 +0100 Laszlo Ersek wrote: > On 03/01/21 17:14, Michael S. Tsirkin wrote: > > On Mon, Mar 01, 2021 at 02:28:19PM +0100, Igor Mammedov wrote: > > >> How about: > >> * buggy ACPI for 5.1 machine types and older > >> * fixed ACPI for 5.2 and newer? > > > > Exactly.

Re: [PATCH] pcnet: switch to use qemu_receive_packet() for loopback

2021-03-01 Thread Philippe Mathieu-Daudé
On 3/1/21 4:33 PM, Alexander Bulekov wrote: > This patch switches to use qemu_receive_packet() which can detect > reentrancy and return early. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1917085 > Signed-off-by: Alexander Bulekov > --- > > Here's another one, that looks like the same issue

[Bug 1913341] Re: Chardev behavior breaks polling based devices

2021-03-01 Thread Iris Johnson
** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1913341 Title: Chardev behavior breaks polling based devices Status in QEMU: Fix Committed

[Bug 1913344] Re: Exynos4210 UART peripheral data loss

2021-03-01 Thread Iris Johnson
** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1913344 Title: Exynos4210 UART peripheral data loss Status in QEMU: Fix Committed Bug desc

[PATCH v2 1/1] i386: Add support for AMD new-style boot mechanism.

2021-03-01 Thread Danny Milosavljevic
This introduces a new generic-loader setting "csbaseaddr" that allows you to set the segment base address of CS. Signed-off-by: Danny Milosavljevic --- hw/core/generic-loader.c | 6 +- include/hw/core/cpu.h| 1 + include/hw/core/generic-loader.h | 1 + target/i386/cpu.

[PATCH v2 0/1] Add support for AMD new-style boot mechanism.

2021-03-01 Thread Danny Milosavljevic
A lot of AMD CPUs boot the bootstrap processor using a new mechanism. According to https://doc.coreboot.org/soc/amd/family17h.html [1] that means that the flash header specifies a destination and size in RAM (!), and the bootstrap processor will start using a CS segment descriptor set up in such a

[Bug 1914117] Re: Short files returned via FTP on Qemu with various architectures and OSes

2021-03-01 Thread Chris Pinnock
libslirp now has a workaround for this in slirp.c. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1914117 Title: Short files returned via FTP on Qemu with various architectures and OSes Status in

[PATCH] cadence_gem: switch to use qemu_receive_packet() for loopback

2021-03-01 Thread Alexander Bulekov
This patch switches to use qemu_receive_packet() which can detect reentrancy and return early. Signed-off-by: Alexander Bulekov --- hw/net/cadence_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index 9a4474a084..1c576a130c 10

[PATCH] lan9118: switch to use qemu_receive_packet() for loopback

2021-03-01 Thread Alexander Bulekov
This patch switches to use qemu_receive_packet() which can detect reentrancy and return early. Signed-off-by: Alexander Bulekov --- I think this is the last one that directly calls its own receive function to do loopback (or the last one within my grepping capapbilities). -Alex hw/net/lan9118.

Re: [PATCH v2 01/42] esp: checkpatch fixes

2021-03-01 Thread Laurent Vivier
Le 09/02/2021 à 20:29, Mark Cave-Ayland a écrit : > Signed-off-by: Mark Cave-Ayland > Reviewed-by: Philippe Mathieu-Daudé > --- > hw/scsi/esp.c | 52 ++- > 1 file changed, 31 insertions(+), 21 deletions(-) > > diff --git a/hw/scsi/esp.c b/hw/scsi/

[PATCH] vfio-ccw: Do not read region ret_code after write

2021-03-01 Thread Eric Farman
A pwrite() call returns the number of bytes written (or -1 on error), and vfio-ccw compares this number with the size of the region to determine if an error had occurred or not. If they are equal, the code reads the ret_code field from the region. However, while the kernel sets the ret_code field a

Re: [PATCH v2 02/42] esp: rename existing ESP QOM type to SYSBUS_ESP

2021-03-01 Thread Laurent Vivier
Le 09/02/2021 à 20:29, Mark Cave-Ayland a écrit : > The existing ESP QOM type currently represents a sysbus device with an > embedded > ESP state. Rename the type to SYSBUS_ESP accordingly. > > Signed-off-by: Mark Cave-Ayland > --- > hw/dma/sparc32_dma.c | 4 ++-- > hw/m68k/q800.c| 4 +

RE: [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors

2021-03-01 Thread Babu Moger
Pankaj, > -Original Message- > From: Pankaj Gupta > Sent: Monday, March 1, 2021 10:46 AM > To: Pankaj Gupta > Cc: Moger, Babu ; Paolo Bonzini > ; richard.hender...@linaro.org; Eduardo Habkost > ; Qemu Developers > Subject: Re: [PATCH v2] i386: Add the support for AMD EPYC 3rd generation

Re: [PATCH 1/2] i386/acpi: fix inconsistent QEMU/OVMF device paths

2021-03-01 Thread vit9696
I provided the initial version of the patch to the mailing list: [PATCH] i386/acpi: restore device paths for pre-5.1 vms Unfortunately I do not have easy access to a VM where I can test it at the moment. Please make sure that it works for you and reply with `Tested-by`. Thanks, Vitaly > 1 марта

Re: [PATCH v2 03/42] esp: QOMify the internal ESP device state

2021-03-01 Thread Laurent Vivier
Le 15/02/2021 à 23:29, Mark Cave-Ayland a écrit : > On 12/02/2021 18:51, Philippe Mathieu-Daudé wrote: > >> On 2/9/21 8:29 PM, Mark Cave-Ayland wrote: >>> Make this new QOM device state a child device of both the sysbus-esp and >>> esp-pci >>> implementations. >>> >>> Signed-off-by: Mark Cave-Ayl

Re: [PATCH 1/2] i386/acpi: fix inconsistent QEMU/OVMF device paths

2021-03-01 Thread Igor Mammedov
On Mon, 1 Mar 2021 15:27:38 +0100 Thomas Lamprecht wrote: > On 01.03.21 15:20, Igor Mammedov wrote: > > On Mon, 1 Mar 2021 08:45:53 +0100 > > Thomas Lamprecht wrote: > >> On 01.03.21 08:20, Michael S. Tsirkin wrote: > >>> There are various testing efforts the reason this got undetected is >

Re: [PATCH v2 04/42] esp: add vmstate_esp version to embedded ESPState

2021-03-01 Thread Laurent Vivier
Le 09/02/2021 à 20:29, Mark Cave-Ayland a écrit : > The QOM object representing ESPState is currently embedded within both the > SYSBUS_ESP and PCI_ESP devices with migration state handled by embedding > vmstate_esp within each device using VMSTATE_STRUCT. > > Since the vmstate_esp fields are embe

Re: [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors

2021-03-01 Thread Pankaj Gupta
> > Hi Babu, > > > > I tried to test below patch for AMD EPYC Rome CPU and I got below error [1]: > > > > Also, I noticed SSBD CPU flag for guest was still available even without > > this > > patch, I noticed that for the guest, AMD_SSBD not got set. > > > > Guest: > > 0x8008 0x00: eax=0x3

Re: [PATCH 1/2] acpi: Move setters/getters of oem fields to X86MachineState

2021-03-01 Thread Igor Mammedov
On Sun, 21 Feb 2021 02:17:36 +0200 Marian Postevca wrote: > The code that sets/gets oem fields is duplicated in both PC and MICROVM > variants. This commit moves it to X86MachineState so that all x86 > variants can use it and duplication is removed. > > Signed-off-by: Marian Postevca nice clean

Re: [PATCH v2 05/42] esp: add trace event when receiving a TI command

2021-03-01 Thread Laurent Vivier
Le 09/02/2021 à 20:29, Mark Cave-Ayland a écrit : > This enables us to determine whether the command being issued is for a DMA or > a > non-DMA transfer. > > Signed-off-by: Mark Cave-Ayland > Reviewed-by: Philippe Mathieu-Daudé > --- > hw/scsi/esp.c| 1 + > hw/scsi/trace-events | 1 + >

RE: [PATCH 0/4] hexagon: Add Docker image & testing to gitlab-ci

2021-03-01 Thread Taylor Simpson
> -Original Message- > From: Philippe Mathieu-Daudé On > Behalf Of Philippe Mathieu-Daudé > Sent: Sunday, February 28, 2021 4:23 PM > To: qemu-devel@nongnu.org > Cc: Fam Zheng ; Taylor Simpson > ; Philippe Mathieu-Daudé ; > Alex Bennée ; Alessandro Di Federico > ; Brian Cain ; Philippe M

Re: [PATCH 2/2] acpi: Consolidate the handling of OEM ID and OEM Table ID fields

2021-03-01 Thread Igor Mammedov
On Sun, 21 Feb 2021 02:17:37 +0200 Marian Postevca wrote: > Introduces structure AcpiBuildOem to hold the value of OEM fields and > uses dedicated macros to initialize/set the values. > Unnecessary dynamically allocated OEM fields are re-factored to static > allocation. looks fine to me. Though

Re: [PATCH v2 06/42] esp: fix esp_reg_read() trace event

2021-03-01 Thread Laurent Vivier
Le 09/02/2021 à 20:29, Mark Cave-Ayland a écrit : > Move the trace event to the end of the function so that it correctly reports > the returned value if it doesn't come directly from the rregs array. > > Signed-off-by: Mark Cave-Ayland > Reviewed-by: Philippe Mathieu-Daudé > --- > hw/scsi/esp.c

Re: [PATCH v2 07/42] esp: add PDMA trace events

2021-03-01 Thread Laurent Vivier
Le 09/02/2021 à 20:29, Mark Cave-Ayland a écrit : > This will become more useful later when trying to debug mixed FIFO and PDMA > requests. > > Signed-off-by: Mark Cave-Ayland > Reviewed-by: Philippe Mathieu-Daudé > --- > hw/scsi/esp.c| 6 ++ > hw/scsi/trace-events | 4 > 2 fil

RE: [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors

2021-03-01 Thread Babu Moger
> -Original Message- > From: Pankaj Gupta > Sent: Monday, March 1, 2021 2:22 PM > To: Moger, Babu > Cc: Pankaj Gupta ; Paolo Bonzini > ; richard.hender...@linaro.org; Eduardo Habkost > ; Qemu Developers > Subject: Re: [PATCH v2] i386: Add the support for AMD EPYC 3rd generation > proc

Re: [PATCH v2 0/2] gitlab-ci.yml: Add jobs to test CFI

2021-03-01 Thread Daniele Buono
Hi Daniel, On 3/1/2021 10:08 AM, Daniel P. Berrangé wrote: What are the unique failure scenarios for CFI that these jobs are likely to expose ? Is it likely that we'll have cases where CFI succeeds in say, x86_64 target, but fails in aarch64 target ? For CFI to fail (even if it shouldn't) you'

<    1   2   3   4   5   >