[PATCH] chardev: do not use short form boolean options in non-QemuOpts character device descriptions

2021-02-25 Thread Paolo Bonzini
Options such as "-gdb" or "-serial" accept a part-QemuOpts part-parsed-by-hand character device description. Do not use short form boolean options in the QemuOpts part. Signed-off-by: Paolo Bonzini --- chardev/char-socket.c | 10 +- qapi/char.json| 4 ++-- tests

[RFC v8 03/28] header update against 5.11-rc2 and IOMMU/VFIO nested stage APIs

2021-02-25 Thread Eric Auger
Signed-off-by: Eric Auger --- .../infiniband/hw/vmw_pvrdma/pvrdma_ring.h| 14 +- linux-headers/linux/iommu.h | 395 ++ linux-headers/linux/vfio.h| 141 ++- 3 files changed, 542 insertions(+), 8 deletions(-) create mode 100644 linux-h

Re: [RFC PATCH 2/5] hw/arm/virt: Add cpu-map to device tree

2021-02-25 Thread Andrew Jones
Hi Ying Fang, The only difference between this and what I have in my tree[*] is the removal of the socket node (which has been in the Linux docs since June 2019). Any reason why you removed that node? In any case, I think I deserve a bit more credit for this patch. [*] https://github.com/rhdrjon

Re: [RFC PATCH 1/5] device_tree: Add qemu_fdt_add_path

2021-02-25 Thread Andrew Jones
Hi Ying Fang, I don't see any change in this patch from what I have in my tree, so this should be From: Andrew Jones Thanks, drew On Thu, Feb 25, 2021 at 04:56:23PM +0800, Ying Fang wrote: > qemu_fdt_add_path() works like qemu_fdt_add_subnode(), except > it also adds any missing parent nodes.

[RFC v8 22/28] hw/arm/smmuv3: Fill the IOTLBEntry arch_id on NH_VA invalidation

2021-02-25 Thread Eric Auger
When the guest invalidates one S1 entry, it passes the asid. When propagating this invalidation downto the host, the asid information also must be passed. So let's fill the arch_id field introduced for that purpose and accordingly set the flags to indicate its presence. Signed-off-by: Eric Auger

Re: [PATCH v3 3/3] virtio-gpu: Do not distinguish the primary console

2021-02-25 Thread Gerd Hoffmann
Hi, > > I think we should call dpy_gfx_replace_surface(..., NULL) > > unconditionally here instead of removing the call. > > graphic_console_init will set a placeholder anyway so it does not need > an additional call. Ah, right, with the initial surface being tagged as placeholder too this sho

[RFC v8 07/28] memory: Add IOMMU_ATTR_MSI_TRANSLATE IOMMU memory region attribute

2021-02-25 Thread Eric Auger
We introduce a new IOMMU Memory Region attribute, IOMMU_ATTR_MSI_TRANSLATE which tells whether the virtual IOMMU translates MSIs. ARM SMMU will expose this attribute since, as opposed to Intel DMAR, MSIs are translated as any other DMA requests. Signed-off-by: Eric Auger --- include/exec/memory.

[PATCH] vl: deprecate -writeconfig

2021-02-25 Thread Paolo Bonzini
The functionality of -writeconfig is limited and the code does not even try to detect cases where it prints incorrect syntax (for example if values have a quote in them, since qemu_config_parse does not support any kind of escaping) so remove it. Signed-off-by: Paolo Bonzini --- docs/system/depr

[RFC v8 25/28] hw/arm/smmuv3: Implement fault injection

2021-02-25 Thread Eric Auger
We convert iommu_fault structs received from the kernel into the data struct used by the emulation code and record the evnts into the virtual event queue. Signed-off-by: Eric Auger --- v3 -> v4: - fix compil issue on mingw Exhaustive mapping remains to be done --- hw/arm/smmuv3.c | 71 +++

Re: [PATCH v23 06/17] meson: add target_user_arch

2021-02-25 Thread Philippe Mathieu-Daudé
On 2/25/21 11:49 AM, Claudio Fontana wrote: > the lack of target_user_arch makes it hard to fully leverage the > build system in order to separate user code from sysemu code. > > Provide it, so that we can avoid the proliferation of #ifdef > in target code. > > Signed-off-by: Claudio Fontana > R

[RFC v8 10/28] pci: introduce PCIPASIDOps to PCIDevice

2021-02-25 Thread Eric Auger
From: Liu Yi L This patch introduces PCIPASIDOps for IOMMU related operations. https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg00078.html https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg00940.html So far, to setup virt-SVA for assigned SVA capable device, needs to configure ho

Re: [PATCH v23 00/17] i386 cleanup PART 2

2021-02-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210225104941.15688-1-cfont...@suse.de/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210225104941.15688-1-cfont...@suse.de Subject: [PATCH v23 00/17] i386 cleanup PART 2 === T

[RFC v8 11/28] vfio: Force nested if iommu requires it

2021-02-25 Thread Eric Auger
In case we detect the address space is translated by a virtual IOMMU which requires HW nested paging to integrate with VFIO, let's set up the container with the VFIO_TYPE1_NESTING_IOMMU iommu_type. Signed-off-by: Eric Auger --- v7 -> v8 - remove as != &address_space_memory as memory_region_is

Re: [PATCH] chardev: do not use short form boolean options in non-QemuOpts character device descriptions

2021-02-25 Thread Philippe Mathieu-Daudé
On 2/25/21 12:11 PM, Paolo Bonzini wrote: > Options such as "-gdb" or "-serial" accept a part-QemuOpts part-parsed-by-hand > character device description. Do not use short form boolean options in the > QemuOpts part. > > Signed-off-by: Paolo Bonzini > --- > chardev/char-socket.c | 10 ++

Re: [RFC PATCH 3/5] hw/arm/virt-acpi-build: distinguish possible and present cpus

2021-02-25 Thread Andrew Jones
On Thu, Feb 25, 2021 at 04:56:25PM +0800, Ying Fang wrote: > When building ACPI tables regarding CPUs we should always build > them for the number of possible CPUs, not the number of present > CPUs. We then ensure only the present CPUs are enabled in madt. > Furthermore, it is also needed if we are

[RFC v8 14/28] vfio: Set up nested stage mappings

2021-02-25 Thread Eric Auger
In nested mode, legacy vfio_iommu_map_notify cannot be used as there is no "caching" mode and we do not trap on map. On Intel, vfio_iommu_map_notify was used to DMA map the RAM through the host single stage. With nested mode, we need to setup the stage 2 and the stage 1 separately. This patch int

[RFC v8 18/28] vfio/pci: Set up the DMA FAULT region

2021-02-25 Thread Eric Auger
Set up the fault region which is composed of the actual fault queue (mmappable) and a header used to handle it. The fault queue is mmapped. Signed-off-by: Eric Auger --- v4 -> v5: - use a single DMA FAULT region. No version selection anymore --- hw/vfio/pci.c | 64 +

[RFC v8 24/28] hw/arm/smmuv3: Pass stage 1 configurations to the host

2021-02-25 Thread Eric Auger
In case PASID PciOps are set for the device we call the set_pasid_table() callback on each STE update. This allows to pass the guest stage 1 configuration to the host and apply it at physical level. Signed-off-by: Eric Auger --- v4 -> v5: - Use PciOps instead of config notifiers v3 -> v4: - f

[RFC v8 26/28] hw/arm/smmuv3: Allow MAP notifiers

2021-02-25 Thread Eric Auger
We now have all bricks to support nested paging. This uses MAP notifiers to map the MSIs. So let's allow MAP notifiers to be registered. Signed-off-by: Eric Auger --- hw/arm/smmuv3.c | 8 1 file changed, 8 deletions(-) diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c index a61c1129d9..77

[RFC v8 27/28] pci: Add return_page_response pci ops

2021-02-25 Thread Eric Auger
Add a new PCI operation that allows to return page responses to registered VFIO devices Signed-off-by: Eric Auger --- hw/pci/pci.c | 16 include/hw/iommu/iommu.h | 8 include/hw/pci/pci.h | 4 3 files changed, 28 insertions(+) diff --git a/hw/pci

Re: [PATCH] hw/riscv: Add basic fw_cfg support to virt

2021-02-25 Thread Philippe Mathieu-Daudé
Hi Asherah, You forgot to Cc the maintainers (doing it now): ./scripts/get_maintainer.pl -f hw/riscv/virt.c Palmer Dabbelt Alistair Francis Sagar Karandikar Bastian Koppelmann qemu-ri...@nongnu.org qemu-devel@nongnu.org On 2/25/21 11:13 AM, Asherah Connor wrote: > Provides a minimal fw_cfg f

Re: [RFC PATCH 5/5] hw/arm/virt-acpi-build: add PPTT table

2021-02-25 Thread Andrew Jones
This is just [*] with some minor code changes [*] https://github.com/rhdrjones/qemu/commit/439b38d67ca1f2cbfa5b9892a822b651ebd05c11 so it's disappointing that my name is nowhere to be found on it. Also, the explanation of the DT and ACPI differences has been dropped from the commit message of

Re: [PATCH] virtio-gpu: Respect graphics update interval for EDID

2021-02-25 Thread Gerd Hoffmann
Hi, > > Because of the wasted frames I'd like this to be an option you can > > enable when needed. For the majority of use cases this seems to be > > no problem ... > > I see blinks with GNOME on Wayland on Ubuntu 20.04 and virtio-gpu with > the EDID change included in this patch. /me looks c

Re: [RFC PATCH 4/5] hw/acpi/aml-build: add processor hierarchy node structure

2021-02-25 Thread Andrew Jones
On Thu, Feb 25, 2021 at 04:56:26PM +0800, Ying Fang wrote: > Add the processor hierarchy node structures to build ACPI information > for CPU topology. Since the private resources may be used to describe > cache hierarchy and it is variable among different topology level, > three helpers are introdu

[PATCH v2(RFC) 0/3] qcow2: fix parallel rewrite and discard

2021-02-25 Thread Vladimir Sementsov-Ogievskiy
Hi all! It occurs that nothing prevents discarding and reallocating host cluster during data writing. This way data writing will pollute another newly allocated cluster of data or metadata. OK, v2 is a try to solve the problem with CoRwlock.. And it is marked RFC, because of a lot of iotest failur

[PATCH v2 1/3] qemu-io: add aio_discard

2021-02-25 Thread Vladimir Sementsov-Ogievskiy
Add aio_discard command like existing aio_write. It will be used in further test. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qemu-io-cmds.c | 117 + 1 file changed, 117 insertions(+) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index 97611969

[PATCH v2 2/3] iotests: add qcow2-discard-during-rewrite

2021-02-25 Thread Vladimir Sementsov-Ogievskiy
Simple test: - start writing to allocated cluster A - discard this cluster - write to another unallocated cluster B (it's allocated in same place where A was allocated) - continue writing to A For now last action pollutes cluster B which is a bug fixed by the following commit. For now, add

[PATCH v2 3/3] block/qcow2: introduce inflight writes counters: fix discard

2021-02-25 Thread Vladimir Sementsov-Ogievskiy
There is a bug in qcow2: host cluster can be discarded (refcount becomes 0) and reused during data write. In this case data write may pollute another cluster (recently allocated) or even metadata. To fix the issue introduce rw-lock: take read-lock on data writing and write-lock on discard. Enable

Re: [PATCH] hw/riscv: Add basic fw_cfg support to virt

2021-02-25 Thread Asherah Connor
Hi Philippe, On 21/02/25 12:02:p, Philippe Mathieu-Daudé wrote: > Hi Asherah, > > You forgot to Cc the maintainers (doing it now): Ah, my bad. Thank you! > What is missing here is why do you need this, what problem > does this patch solve. I would eventually like to use qemu ramfb on RISC-V (

Re: [PATCH v3 03/16] qapi/expr.py: constrain incoming expression types

2021-02-25 Thread Markus Armbruster
John Snow writes: > On 2/24/21 5:01 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> mypy does not know the types of values stored in Dicts that masquerade >>> as objects. Help the type checker out by constraining the type. >>> >>> Signed-off-by: John Snow >>> Reviewed-by: Eduardo Habk

Re: [PATCH v3 06/16] qapi/expr.py: Check type of 'data' member

2021-02-25 Thread Markus Armbruster
John Snow writes: > On 2/24/21 5:39 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> Iterating over the members of data isn't going to work if it's not some >>> form of dict anyway, but for the sake of mypy, formalize it. >>> >>> Signed-off-by: John Snow >>> Reviewed-by: Eduardo Habkos

Re: [RFC PATCH 0/5] hw/arm/virt: Introduce cpu topology support

2021-02-25 Thread Andrew Jones
On Thu, Feb 25, 2021 at 04:56:22PM +0800, Ying Fang wrote: > An accurate cpu topology may help improve the cpu scheduler's decision > making when dealing with multi-core system. So cpu topology description > is helpful to provide guest with the right view. Dario Faggioli's talk > in [0] also shows

Re: [PATCH v3 07/16] qapi/expr.py: Add casts in a few select cases

2021-02-25 Thread Markus Armbruster
John Snow writes: > On 2/24/21 7:32 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> Casts are instructions to the type checker only, they aren't "safe" and >>> should probably be avoided in general. In this case, when we perform >>> type checking on a nested structure, the type of each

Re: [PATCH v3 08/16] qapi/expr.py: add type hint annotations

2021-02-25 Thread Markus Armbruster
John Snow writes: > On 2/24/21 10:27 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> Annotations do not change runtime behavior. >>> This commit *only* adds annotations. >>> >>> Signed-off-by: John Snow >>> Reviewed-by: Eduardo Habkost >>> Reviewed-by: Cleber Rosa >>> --- >>> scri

Re: [PATCH] tcg/i386: rdpmc: use the the condtions

2021-02-25 Thread Paolo Bonzini
On 25/02/21 11:13, Philippe Mathieu-Daudé wrote: Hi Paolo, On 2/25/21 11:07 AM, Paolo Bonzini wrote: On 25/02/21 06:47, Zheng Zhan Liang wrote: Signed-off-by: Zheng Zhan Liang ---   target/i386/tcg/misc_helper.c | 3 ++-   1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/i

Re: [PATCH] multiprocess: move feature to meson_options.txt

2021-02-25 Thread Paolo Bonzini
On 25/02/21 11:38, Philippe Mathieu-Daudé wrote: On 2/24/21 1:23 PM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- configure | 12 meson.build | 9 +++-- meson_options.txt | 2 ++ 3 files changed, 13 insertions(+), 10 deletions(-) ... @@ -2535,6

[PATCH v2] libqos/qgraph: format qgraph comments for sphinx documentation

2021-02-25 Thread Emanuele Giuseppe Esposito
Change documentation style and fix minor typos in tests/qtest/libqos/qgraph.h to automatically generate sphinx documentation in docs/devel/qgraph.rst The mechanism explanation that once was in qgraph.h is now moved to qgraph.rst There is no functional change intended. v2: - qgraph link visible i

Bogus "is either too old or uses too old a Python version" from docs/meson.build

2021-02-25 Thread Markus Armbruster
I just chanced on this one: Program sphinx-build-3 found: YES ../docs/meson.build:30: WARNING: /usr/bin/sphinx-build-3 is either too old or uses too old a Python version ../docs/meson.build:33:6: ERROR: Problem encountered: Install a Python 3 version of python-sphinx A full log

Re: [PATCH] vl: deprecate -writeconfig

2021-02-25 Thread Daniel P . Berrangé
On Thu, Feb 25, 2021 at 12:11:48PM +0100, Paolo Bonzini wrote: > The functionality of -writeconfig is limited and the code > does not even try to detect cases where it prints incorrect > syntax (for example if values have a quote in them, since > qemu_config_parse does not support any kind of escap

Re: [PATCH 06/14] machine: remove 'query-cpus' QMP command

2021-02-25 Thread Wainer dos Santos Moschetta
Hi, On 2/24/21 10:11 AM, Daniel P. Berrangé wrote: The newer 'query-cpus-fast' command avoids side effects on the guest execution. Note that some of the field names are different in the 'query-cpus-fast' command. Signed-off-by: Daniel P. Berrangé --- docs/system/deprecated.rst

Re: [PATCH 3/3] migration/ram: Optimize ram_save_host_page()

2021-02-25 Thread David Edmondson
On Tuesday, 2021-02-23 at 10:16:45 +08, Kunkun Jiang wrote: > Starting from pss->page, ram_save_host_page() will check every page > and send the dirty pages up to the end of the current host page or > the boundary of used_length of the block. If the host page size is > a huge page, the step "check

Re: [RFC PATCH 1/5] device_tree: Add qemu_fdt_add_path

2021-02-25 Thread Ying Fang
On 2/25/2021 7:03 PM, Andrew Jones wrote: Hi Ying Fang, I don't see any change in this patch from what I have in my tree, so this should be From: Andrew Jones Thanks, drew Yes, I picked it from your qemu branch: https://github.com/rhdrjones/qemu/commit/ecfc1565f22187d2c715a99bbcd35cf3

Re: Bogus "is either too old or uses too old a Python version" from docs/meson.build

2021-02-25 Thread Peter Maydell
On Thu, 25 Feb 2021 at 12:23, Markus Armbruster wrote: > > I just chanced on this one: > > Program sphinx-build-3 found: YES > ../docs/meson.build:30: WARNING: /usr/bin/sphinx-build-3 is either too > old or uses too old a Python version > > ../docs/meson.build:33:6: ERROR: Problem enc

Re: who's using the ozlabs patchwork install for QEMU patches ?

2021-02-25 Thread Jeremy Kerr
Hi Greg, > > The standard process is to send me an email :) > > Is this standard process mentioned somewhere ? No, not really. I usually let the folks who request the project in the first place know though. > > You're wanting to add user 'groug' to the qemu project, is that > > correct? > > >

Re: [PATCH v2 0/7] Xen guest loader (to boot Xen+Kernel under TCG)

2021-02-25 Thread Alex Bennée
Alex Bennée writes: > Hi, > > These patches have been sitting around as part of a larger series to > improve the support of Xen on AArch64. The second part of the work is > currently awaiting other re-factoring and build work to go in to make > the building of a pure-Xen capable QEMU easier. As

[PATCH v2] vl: deprecate -writeconfig

2021-02-25 Thread Paolo Bonzini
The functionality of -writeconfig is limited and the code does not even try to detect cases where it prints incorrect syntax (for example if values have a quote in them, since qemu_config_parse does not support any kind of escaping) so remove it. Signed-off-by: Paolo Bonzini --- v1->v2: d

Re: [RFC PATCH 2/5] hw/arm/virt: Add cpu-map to device tree

2021-02-25 Thread Ying Fang
On 2/25/2021 7:16 PM, Andrew Jones wrote: Hi Ying Fang, The only difference between this and what I have in my tree[*] is the removal of the socket node (which has been in the Linux docs since June 2019). Any reason why you removed that node? In any case, I think I deserve a bit more credit f

Re: [PATCH v2] vl: deprecate -writeconfig

2021-02-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210225131316.631940-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210225131316.631940-1-pbonz...@redhat.com Subject: [PATCH v2] vl: deprecate -writeconf

Re: [RFC PATCH 1/5] device_tree: Add qemu_fdt_add_path

2021-02-25 Thread Andrew Jones
On Thu, Feb 25, 2021 at 08:54:40PM +0800, Ying Fang wrote: > > > On 2/25/2021 7:03 PM, Andrew Jones wrote: > > Hi Ying Fang, > > > > I don't see any change in this patch from what I have in my > > tree, so this should be > > > > From: Andrew Jones > > > > Thanks, > > drew > > > > Yes, I p

Re: [RFC PATCH 1/5] device_tree: Add qemu_fdt_add_path

2021-02-25 Thread Ying Fang
On 2/25/2021 9:25 PM, Andrew Jones wrote: On Thu, Feb 25, 2021 at 08:54:40PM +0800, Ying Fang wrote: On 2/25/2021 7:03 PM, Andrew Jones wrote: Hi Ying Fang, I don't see any change in this patch from what I have in my tree, so this should be From: Andrew Jones Thanks, drew Yes, I

Re: QEMU CI failed due to canceled download

2021-02-25 Thread Wainer dos Santos Moschetta
Hi, On 2/25/21 1:51 AM, Thomas Huth wrote:  Hi, I just faced this failure in the CI:  https://gitlab.com/thuth/qemu/-/jobs/1053467007#L73 I thought we'd handle CANCEL as "skipped"? Why did this cause the CI to fail? Yes, CANCEL'ed tests should not change the job status (same semantic of S

Re: Bogus "is either too old or uses too old a Python version" from docs/meson.build

2021-02-25 Thread Markus Armbruster
Peter Maydell writes: > On Thu, 25 Feb 2021 at 12:23, Markus Armbruster wrote: >> >> I just chanced on this one: >> >> Program sphinx-build-3 found: YES >> ../docs/meson.build:30: WARNING: /usr/bin/sphinx-build-3 is either too >> old or uses too old a Python version >> >> ../docs/me

Re: [PATCH] hvf: Sign the code after installation

2021-02-25 Thread Paolo Bonzini
On 25/02/21 01:06, Akihiko Odaki wrote: Before this change, the code signed during the build was installed directly. However, the signature gets invalidated because meson modifies the code to fix dynamic library install names during the install process. It also prevents meson to strip the code

Re: [PATCH 1/5] iotests: Update 241 to expose backing layer fragmentation

2021-02-25 Thread Vladimir Sementsov-Ogievskiy
18.02.2021 23:15, Eric Blake wrote: Previous commits (such as 6e280648, 75d34eb9) have mentioned that our NBD server still sends unaligned fragments when an active layer with large advertised minimum block size is backed by another layer with a smaller block size. Expand the test to actually cove

Re: [PATCH v3 08/16] qapi/expr.py: add type hint annotations

2021-02-25 Thread Markus Armbruster
John Snow writes: > Annotations do not change runtime behavior. > This commit *only* adds annotations. > > Signed-off-by: John Snow > Reviewed-by: Eduardo Habkost > Reviewed-by: Cleber Rosa > --- > scripts/qapi/expr.py | 71 --- > scripts/qapi/mypy.ini

Re: [PATCH 1/6] net: introduce qemu_receive_packet()

2021-02-25 Thread P J P
+-- On Wed, 24 Feb 2021, Philippe Mathieu-Daudé wrote --+ | On 2/24/21 2:17 PM, Jason Wang wrote: | > On 2021/2/24 6:11 下午, Philippe Mathieu-Daudé wrote: | >> IIUC the guest could trigger an infinite loop and brick the emulated | >> device model. Likely exhausting the stack, so either SEGV by corr

Re: Bogus "is either too old or uses too old a Python version" from docs/meson.build

2021-02-25 Thread Peter Maydell
On Thu, 25 Feb 2021 at 13:41, Markus Armbruster wrote: > Peter Maydell writes: > > I'm not sure what could reasonably be done. The Sphinx test is just > > "try building a trivial document with our config (which is what > > enforces the version requirement)". > > This question is almost certainly

Re: [PATCH v3 10/16] qapi/expr.py: Remove single-letter variable

2021-02-25 Thread Markus Armbruster
Why? Is it to appease a style checker? I disagree with a blanket ban of single-letter variable names. If @f is deemed too terrible to live, then I'd prefer @feat over @feature, because it's more visually distant to @features. John Snow writes: > Signed-off-by: John Snow > Reviewed-by: Eduard

Re: [PATCH v2] vl: deprecate -writeconfig

2021-02-25 Thread Daniel P . Berrangé
On Thu, Feb 25, 2021 at 02:13:16PM +0100, Paolo Bonzini wrote: > The functionality of -writeconfig is limited and the code > does not even try to detect cases where it prints incorrect > syntax (for example if values have a quote in them, since > qemu_config_parse does not support any kind of escap

Re: [PATCH v2] vl: deprecate -writeconfig

2021-02-25 Thread Paolo Bonzini
On 25/02/21 15:03, Daniel P. Berrangé wrote: FWIW, we've rarely kept exactly to our 2 cycle plan. In practice it has become more of a minimum bar, rather than an exact deadline. If you want to promise death in 6.2 though I'll defer to your judgement :=) Reviewed-by: Daniel P. Berrangé Well, I

Re: [RFC v10 00/25] intel_iommu: expose Shared Virtual Addressing to VMs

2021-02-25 Thread Zenghui Yu
Hi Yi, On 2020/9/10 18:56, Liu Yi L wrote: The high-level architecture for SVA virtualization is as below, the key design of vSVA support is to utilize the dual-stage IOMMU translation ( also known as IOMMU nesting translation) capability in host IOMMU. .-. .--

Re: [PATCH v3 09/16] qapi/expr.py: Consolidate check_if_str calls in check_if

2021-02-25 Thread Markus Armbruster
John Snow writes: > This is a small rewrite to address some minor style nits. > > Don't compare against the empty list to check for the empty condition, and > move the normalization forward to unify the check on the now-normalized > structure. > > With the check unified, the local nested function

Re: [PATCH] linux-user/elfload: do not assume MAP_FIXED_NOREPLACE kernel support

2021-02-25 Thread Vincent Fazio
On 2/15/21 3:52 AM, Alex Bennée wrote: Vincent Fazio writes: Ahh right so I think this is a case of binaries being built on a different platform than kernel they are running on. In which case the flag would be defined but the underlying kernel fails to identify it. Is this a container lik

Re: [PATCH v2] vl: deprecate -writeconfig

2021-02-25 Thread Markus Armbruster
Paolo Bonzini writes: > On 25/02/21 15:03, Daniel P. Berrangé wrote: >> FWIW, we've rarely kept exactly to our 2 cycle plan. In practice it has >> become more of a minimum bar, rather than an exact deadline. If you want >> to promise death in 6.2 though I'll defer to your judgement :=) >> Review

Re: [RFC PATCH 2/5] hw/arm/virt: Add cpu-map to device tree

2021-02-25 Thread Andrew Jones
On Thu, Feb 25, 2021 at 09:18:22PM +0800, Ying Fang wrote: > > > On 2/25/2021 7:16 PM, Andrew Jones wrote: > > Hi Ying Fang, > > > > The only difference between this and what I have in my tree[*] > > is the removal of the socket node (which has been in the Linux > > docs since June 2019). Any re

Re: [PATCH 1/6] net: introduce qemu_receive_packet()

2021-02-25 Thread Philippe Mathieu-Daudé
On 2/24/21 6:53 AM, Jason Wang wrote: > Some NIC supports loopback mode and this is done by calling > nc->info->receive() directly which in fact suppresses the effort of > reentrancy check that is done in qemu_net_queue_send(). > > Unfortunately we can use qemu_net_queue_send() here since for loop

Re: [PATCH 6/6] tx_pkt: switch to use qemu_receive_packet_iov() for loopback

2021-02-25 Thread Philippe Mathieu-Daudé
On 2/24/21 6:54 AM, Jason Wang wrote: > This patch switches to use qemu_receive_receive_iov() which can detect > reentrancy and return early. > > Signed-off-by: Jason Wang > --- > hw/net/net_tx_pkt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 4/6] msf2-mac: switch to use qemu_receive_packet() for loopback

2021-02-25 Thread Philippe Mathieu-Daudé
On 2/24/21 6:53 AM, Jason Wang wrote: > This patch switches to use qemu_receive_packet() which can detect > reentrancy and return early. > > Signed-off-by: Jason Wang > --- > hw/net/msf2-emac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 2/6] e1000: switch to use qemu_receive_packet() for loopback

2021-02-25 Thread Philippe Mathieu-Daudé
On 2/24/21 6:53 AM, Jason Wang wrote: > This patch switches to use qemu_receive_packet() which can detect > reentrancy and return early. > > Signed-off-by: Jason Wang > --- > hw/net/e1000.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH qemu] spapr: Fix typo in the patb_entry comment

2021-02-25 Thread Daniel Henrique Barboza
On 2/25/21 12:23 AM, Alexey Kardashevskiy wrote: There is no H_REGISTER_PROCESS_TABLE, it is H_REGISTER_PROC_TBL handler for which is still called h_register_process_table() though. Signed-off-by: Alexey Kardashevskiy --- Reviewed-by: Daniel Henrique Barboza include/hw/ppc/spapr.h | 2

Re: [PATCH 3/6] dp8393x: switch to use qemu_receive_packet() for loopback packet

2021-02-25 Thread Philippe Mathieu-Daudé
On 2/24/21 7:13 AM, Stefan Weil wrote: > Am 24.02.21 um 06:53 schrieb Jason Wang: > >> This patch switches to use qemu_receive_packet() which can detect >> reentrancy and return early. >> >> Signed-off-by: Jason Wang >> --- >>   hw/net/dp8393x.c | 2 +- >>   1 file changed, 1 insertion(+), 1 delet

Re: [PATCH 5/6] sungem: switch to use qemu_receive_packet() for loopback

2021-02-25 Thread Philippe Mathieu-Daudé
On 2/24/21 6:54 AM, Jason Wang wrote: > This patch switches to use qemu_receive_packet() which can detect > reentrancy and return early. > > Signed-off-by: Jason Wang > --- > hw/net/sungem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 3/6] dp8393x: switch to use qemu_receive_packet() for loopback packet

2021-02-25 Thread Stefan Weil
Am 25.02.21 um 15:36 schrieb Philippe Mathieu-Daudé: On 2/24/21 7:13 AM, Stefan Weil wrote: Am 24.02.21 um 06:53 schrieb Jason Wang: This patch switches to use qemu_receive_packet() which can detect reentrancy and return early. Signed-off-by: Jason Wang ---   hw/net/dp8393x.c | 2 +-   1 f

Re: [PATCH v2] vl: deprecate -writeconfig

2021-02-25 Thread Paolo Bonzini
On 25/02/21 15:28, Markus Armbruster wrote: Paolo Bonzini writes: On 25/02/21 15:03, Daniel P. Berrangé wrote: FWIW, we've rarely kept exactly to our 2 cycle plan. In practice it has become more of a minimum bar, rather than an exact deadline. If you want to promise death in 6.2 though I'll

Re: [PATCH v2 01/22] block: add eMMC block device type

2021-02-25 Thread Cédric Le Goater
On 2/24/21 8:13 PM, Sai Pavan Boddu wrote: > Hi Cedric, > > >> -Original Message- >> From: Cédric Le Goater >> Sent: Wednesday, February 24, 2021 7:25 PM >> To: Stefan Hajnoczi ; Sai Pavan Boddu >> >> Cc: Philippe Mathieu-Daudé ; Markus Armbruster >> ; Kevin Wolf ; Max Reitz >> ; Vladim

Re: [PATCH 2/5] block: Fix BDRV_BLOCK_RAW status to honor alignment

2021-02-25 Thread Vladimir Sementsov-Ogievskiy
18.02.2021 23:15, Eric Blake wrote: Previous patches mentioned how the blkdebug filter driver demonstrates a bug present in our NBD server (for example, commit b0245d64); the bug is also present with the raw format driver when probing occurs. Basically, if we specify a particular alignment > 1, b

Re: [PATCH 1/5] iotests: Update 241 to expose backing layer fragmentation

2021-02-25 Thread Vladimir Sementsov-Ogievskiy
25.02.2021 16:50, Vladimir Sementsov-Ogievskiy wrote: 18.02.2021 23:15, Eric Blake wrote: Previous commits (such as 6e280648, 75d34eb9) have mentioned that our NBD server still sends unaligned fragments when an active layer with large advertised minimum block size is backed by another layer with

[PATCH] tcg/i386: rdpmc: use the the condtions

2021-02-25 Thread Zheng Zhan Liang
Signed-off-by: Zheng Zhan Liang --- target/i386/tcg/misc_helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/i386/tcg/misc_helper.c b/target/i386/tcg/misc_helper.c index f02e4fd400..90b87fdef0 100644 --- a/target/i386/tcg/misc_helper.c +++ b/target/i386/tcg/misc_

[PATCH v2 00/10] target/hexagon: introduce idef-parser

2021-02-25 Thread Alessandro Di Federico via
From: Alessandro Di Federico This patchset introduces the idef-parser for target/hexagon. It's the second iteration of the patchset and includes fixes suggested in the previous iteration. `idef-parser` is a build-time tool built using flex and bison. Its aim is to generate a large part of the t

[PATCH v2 03/10] target/hexagon: make helper functions non-static

2021-02-25 Thread Alessandro Di Federico via
From: Paolo Montesel Make certain helper functions non-static, making them available outside genptr.c. These functions are required by code generated by the idef-parser. Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/genptr.c | 13 ++--- target/

[PATCH v2 01/10] target/hexagon: update MAINTAINERS for idef-parser

2021-02-25 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9b2aa18e1f..9a6878b970 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -192,11 +192,19 @@ Hexagon TCG CPUs M: Taylor Simp

[PATCH v2 06/10] target/hexagon: prepare input for the idef-parser

2021-02-25 Thread Alessandro Di Federico via
From: Alessandro Di Federico Introduce infrastructure necessary to produce a file suitable for being parsed by the idef-parser. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_idef_parser_funcs.py | 114 target/hexagon/idef-parser/macros.inc | 166 ++

[PATCH v2 04/10] target/hexagon: introduce new helper functions

2021-02-25 Thread Alessandro Di Federico via
From: Niccolò Izzo These helpers will be employed by the idef-parser generated code. Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- target/hexagon/genptr.c | 227 +++- target/hexagon/genptr.h | 19 target/hexagon/macros.h | 2

[PATCH v2 09/10] target/hexagon: call idef-parser functions

2021-02-25 Thread Alessandro Di Federico via
From: Alessandro Di Federico Extend gen_tcg_funcs.py in order to emit calls to the functions emitted by the idef-parser, if available. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_tcg_funcs.py | 28 ++-- target/hexagon/hex_common.py| 10 ++ t

[PATCH v2 05/10] target/hexagon: expose next PC in DisasContext

2021-02-25 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/translate.c | 4 +++- target/hexagon/translate.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index eeaad5

[PATCH v2 02/10] target/hexagon: import README for idef-parser

2021-02-25 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico --- target/hexagon/README | 5 + target/hexagon/idef-parser/README.rst | 447 ++ 2 files changed, 452 insertions(+) create mode 100644 target/hexagon/idef-parser/README.rst diff --git

[PATCH v2 08/10] target/hexagon: import parser for idef-parser

2021-02-25 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.y | 1250 +++ target/hexagon/idef-parser/parser-helpers.c | 1925 + target/hexagon/idef-parser/parser-helpers.h | 293 +++ targe

Re: [RFC PATCH 08/10] target/hexagon: import parser for idef-parser

2021-02-25 Thread Alessandro Di Federico via
On Sun, 14 Feb 2021 08:56:11 -0800 Richard Henderson wrote: > What version of bison are you using? We were using a rather recent version of bison (3.7.5), but it's not strictly required. Fixed in v2. -- Alessandro Di Federico rev.ng

Re: [RFC PATCH 00/10] target/hexagon: introduce idef-parser

2021-02-25 Thread Alessandro Di Federico via
On Sun, 14 Feb 2021 13:52:25 -0800 Richard Henderson wrote: > Well, first off, this fails to build with our gitlab CI. > > There are several problems, apart from the new bison parse.error > option previously reported: > > (1) bison and flex not added to dockerfiles, so the packages are not > av

[PATCH v2 07/10] target/hexagon: import lexer for idef-parser

2021-02-25 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.h | 245 +++ target/hexagon/idef-parser/idef-parser.lex| 647 ++ target/hexagon/meson.build| 4 + tests/docker/

[PATCH v2 10/10] target/hexagon: import additional tests

2021-02-25 Thread Alessandro Di Federico via
From: Niccolò Izzo Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- tests/tcg/hexagon/Makefile.target | 35 - tests/tcg/hexagon/crt.S| 28 + tests/tcg/hexagon/first.S | 24 ++-- tests/tcg/hexagon/test_abs.S |

Re: [PATCH v3 15/16] qapi/expr.py: move related checks inside check_xxx functions

2021-02-25 Thread Markus Armbruster
John Snow writes: > There's not a big obvious difference between the types of checks that > happen in the main function versus the kind that happen in the > functions. Now they're in one place for each of the main types. > > As part of the move, spell out the required and optional keywords so > t

Re: [PATCH v3 13/16] qapi/expr.py: Modify check_keys to accept any Collection

2021-02-25 Thread Markus Armbruster
John Snow writes: > This is a minor adjustment that allows the 'required' and 'optional' > keys fields to take a default value of an empty, immutable sequence (the > empty tuple). Quite marginal, but simple enough for me not to say no to it. > This reveals a quirk of this function, which is tha

Re: [PATCH v2 1/7] intel_iommu: Fix mask may be uninitialized in vtd_context_device_invalidate

2021-02-25 Thread Peter Xu
On Thu, Feb 25, 2021 at 10:14:29AM +0100, Eric Auger wrote: > With -Werror=maybe-uninitialized configuration we get > ../hw/i386/intel_iommu.c: In function ‘vtd_context_device_invalidate’: > ../hw/i386/intel_iommu.c:1888:10: error: ‘mask’ may be used > uninitialized in this function [-Werror=maybe-

Re: QEMU Clock record and replay

2021-02-25 Thread Philippe Mathieu-Daudé
Cc'ing Pavel/Alex. On 2/25/21 4:09 PM, Arnabjyoti Kalita wrote: > Hello all, > > I am trying to understand how the clock values are recorded and replayed > in QEMU (when it runs in TCG mode). I have been specifically following > the document that has been provided here - > https://github.com/qemu

Re: [RFC PATCH 0/5] Experimenting with tb-lookup tweaks

2021-02-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210224165811.11567-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210224165811.11567-1-alex.ben...@linaro.org Subject: [RFC PATCH 0/5] Experimenting

Re: [PATCH 1/5] iotests: Update 241 to expose backing layer fragmentation

2021-02-25 Thread Eric Blake
On 2/25/21 7:50 AM, Vladimir Sementsov-Ogievskiy wrote: > 18.02.2021 23:15, Eric Blake wrote: >> Previous commits (such as 6e280648, 75d34eb9) have mentioned that our >> NBD server still sends unaligned fragments when an active layer with >> large advertised minimum block size is backed by another

Re: [PATCH] tcg/i386: rdpmc: use the the condtions

2021-02-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210225054756.35962-1-linuxma...@163.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210225054756.35962-1-linuxma...@163.com Subject: [PATCH] tcg/i386: rdpmc: use the the con

Re: [PATCH 12/14] block: remove dirty bitmaps 'status' field

2021-02-25 Thread Vladimir Sementsov-Ogievskiy
24.02.2021 16:11, Daniel P. Berrangé wrote: The same information is available via the 'recording' and 'busy' fields. Signed-off-by: Daniel P. Berrangé Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 1/5] iotests: Update 241 to expose backing layer fragmentation

2021-02-25 Thread Eric Blake
On 2/25/21 8:57 AM, Vladimir Sementsov-Ogievskiy wrote: > 25.02.2021 16:50, Vladimir Sementsov-Ogievskiy wrote: >> 18.02.2021 23:15, Eric Blake wrote: >>> Previous commits (such as 6e280648, 75d34eb9) have mentioned that our >>> NBD server still sends unaligned fragments when an active layer with >

<    1   2   3   4   >