Re: [PATCH 2/2] gitlab-ci.yml: Add jobs to test CFI flags

2021-02-23 Thread Paolo Bonzini
On 23/02/21 00:01, Daniele Buono wrote: +# Set JOBS=1 because this requires LTO and ld consumes a large amount of memory. +# On gitlab runners, default JOBS of 2 sometimes end up calling 2 lds concurrently +# and triggers an Out-Of-Memory error Does it make sense to test only one target inste

Re: [PATCH 1/2] gitlab-ci.yml: Allow custom make parallelism

2021-02-23 Thread Paolo Bonzini
On 23/02/21 00:01, Daniele Buono wrote: Currently, make parallelism at build time is defined as #cpus+1. Some build jobs may need (or benefit from) a different number. An example is builds with LTO where, because of the huge demand of memory at link time, gitlab runners fails if two linkers are

Re: Editing QEMU POWER Platform wiki page

2021-02-23 Thread Mark Cave-Ayland
On 23/02/2021 07:59, Greg Kurz wrote: On Tue, 23 Feb 2021 15:51:19 +1100 David Gibson wrote: On Mon, Feb 22, 2021 at 06:18:08PM -0300, Leonardo Augusto Guimarães Garcia wrote: On 2/22/21 8:01 AM, Greg Kurz wrote: On Thu, 18 Feb 2021 10:16:25 -0300 Leonardo Augusto Guimarães Garcia wrote:

[PATCH v2] target/riscv: fix TB_FLAGS bits overlapping bug for rvv/rvh

2021-02-23 Thread frank . chang
From: Frank Chang TB_FLAGS mem_idx bits was extended from 2 bits to 3 bits in commit: c445593, but other TB_FLAGS bits for rvv and rvh were not shift as well so these bits may overlap with each other when rvv is enabled. Signed-off-by: Frank Chang --- target/riscv/cpu.h | 12 ++--

Re: [PATCH v2 30/42] esp: add 4 byte PDMA read and write transfers

2021-02-23 Thread Mark Cave-Ayland
On 16/02/2021 07:30, Philippe Mathieu-Daudé wrote: Are you planning to review any more of this series? I'm keen to put out a (hopefully final) v3 soon, but I'll hold off for little while if you want more time to look over the remaining patches. I talked about this series with Laurent on Sunday

Re: [RFC v1 04/38] target/arm: move psci.c into tcg/softmmu/

2021-02-23 Thread Claudio Fontana
On 2/22/21 6:22 PM, Alex Bennée wrote: > > Claudio Fontana writes: > >> From: Claudio Fontana >> >> Signed-off-by: Claudio Fontana >> --- >> target/arm/internals.h | 23 ++- >> target/arm/tcg/helper.c | 2 ++ >> target/arm/{ => tcg/softmmu}/psci.c

Re: [PATCH v2 0/2] block: Use 'read-zeroes=true' mode by default with 'null-co' driver

2021-02-23 Thread Max Reitz
On 22.02.21 19:15, Daniel P. Berrangé wrote: On Fri, Feb 19, 2021 at 03:09:43PM +0100, Philippe Mathieu-Daudé wrote: On 2/19/21 12:07 PM, Max Reitz wrote: On 13.02.21 22:54, Fam Zheng wrote: On 2021-02-11 15:26, Philippe Mathieu-Daudé wrote: The null-co driver doesn't zeroize buffer in its de

Re: [RFC v1 05/38] target/arm: wrap arm_cpu_exec_interrupt in CONFIG_TCG

2021-02-23 Thread Claudio Fontana
On 2/22/21 4:54 PM, Richard Henderson wrote: > On 2/22/21 12:31 AM, Claudio Fontana wrote: >> actually this is a fix for an error I introduced when adding TCGOps: >> >> arm_cpu_exec_interrupt should be wrapped in the ifdef, as it uses tcg_ops, >> which is TCG-only. >> Maybe I should extract this a

Re: Plugin Address Translations Inconsistent/Incorrect?

2021-02-23 Thread Alex Bennée
Peter Maydell writes: > On Mon, 22 Feb 2021 at 19:53, Alex Bennée wrote: >> It certainly is by design. The comment for the helper states: >> >> /* >>* The following additional queries can be run on the hwaddr structure >>* to return information about it. For non-IO accesses the devic

Re: [RFC v1 06/38] target/arm: split off cpu-softmmu.c

2021-02-23 Thread Claudio Fontana
On 2/22/21 6:29 PM, Alex Bennée wrote: > > Claudio Fontana writes: > >> From: Claudio Fontana >> >> Signed-off-by: Claudio Fontana >> --- >> target/arm/internals.h | 9 ++- >> target/arm/cpu-softmmu.c | 134 +++ >> target/arm/cpu.c | 95 ---

Re: [PATCH v4 2/5] hw/arm: xlnx-zynqmp: Clean up coding convention issues

2021-02-23 Thread Edgar E. Iglesias
On Mon, Feb 22, 2021 at 09:05:11PM +0800, Bin Meng wrote: > From: Xuzhou Cheng > > There are some coding convention warnings in xlnx-zynqmp.c and > xlnx-zynqmp.h, as reported by: > > $ ./scripts/checkpatch.pl include/hw/arm/xlnx-zynqmp.h > $ ./scripts/checkpatch.pl hw/arm/xlnx-zynqmp.c > >

Re: [PATCH v4 3/5] hw/arm: xlnx-zynqmp: Connect a Xilinx CSU DMA module for QSPI

2021-02-23 Thread Edgar E. Iglesias
On Mon, Feb 22, 2021 at 09:05:12PM +0800, Bin Meng wrote: > From: Xuzhou Cheng > > Add a Xilinx CSU DMA module to ZynqMP SoC, and connent the stream > link of GQSPI to CSU DMA. > > Signed-off-by: Xuzhou Cheng > Signed-off-by: Bin Meng > > --- > > Changes in v4: > - Rename "csu_dma" to "qspi_

Re: [PATCH v6 09/12] softmmu/physmem: Don't use atomic operations in ram_block_discard_(disable|require)

2021-02-23 Thread David Hildenbrand
On 22.02.21 18:32, Paolo Bonzini wrote: On 22/02/21 16:38, David Hildenbrand wrote: On 22.02.21 15:02, Paolo Bonzini wrote: On 22/02/21 14:33, David Hildenbrand wrote: Also, uncoordinated require is unused, and therefore uncoordinated disable is also never going to block anything.  Does it mak

Re: [PATCH v4 5/5] hw/ssi: xilinx_spips: Remove DMA related dead codes from zynqmp_spips

2021-02-23 Thread Edgar E. Iglesias
On Mon, Feb 22, 2021 at 09:05:14PM +0800, Bin Meng wrote: > From: Xuzhou Cheng > > Now that the Xilinx CSU DMA model is implemented, the existing > DMA related dead codes in the ZynqMP QSPI are useless and should > be removed. The maximum register number is also updated to only > include the QSPI

Re: A brief look at deprecating our JSON extensions over RFC 8259

2021-02-23 Thread Markus Armbruster
Paolo Bonzini writes: > On 22/02/21 16:24, Daniel P. Berrangé wrote: >> This problem isn't unique to QEMU. Any app using JSON from the >> shell will have the tedium of quote escaping. JSON is incredibly >> widespread and no other apps felt it neccessary to introduce single >> quoting support, bec

Re: [PATCH qemu v13] spapr: Implement Open Firmware client interface

2021-02-23 Thread BALATON Zoltan
On Tue, 23 Feb 2021, David Gibson wrote: On Tue, Feb 23, 2021 at 04:01:00PM +1100, Alexey Kardashevskiy wrote: On 23/02/2021 14:07, David Gibson wrote: On Tue, Feb 09, 2021 at 10:02:52PM +1100, Alexey Kardashevskiy wrote: #endif /* HW_SPAPR_H */ VOF is pretty much inherently papr specific,

Re: [RFC v1 34/38] target/arm: cpu: only initialize TCG gt timers under CONFIG_TCG

2021-02-23 Thread Claudio Fontana
On 2/22/21 4:34 PM, Alex Bennée wrote: > > Claudio Fontana writes: > >> From: Claudio Fontana >> >> KVM has its own cpu->kvm_vtime. >> >> Adjust cpu vmstate by putting unused fields instead of the >> VMSTATE_TIMER_PTR when TCG is not available. >> >> Signed-off-by: Claudio Fontana >> --- >> t

Re: [PATCH v3 5/6] hw/pci-host: Add emulation of Marvell MV64361 PPC system controller

2021-02-23 Thread BALATON Zoltan
On Tue, 23 Feb 2021, David Gibson wrote: On Mon, Feb 22, 2021 at 04:22:06PM +0100, BALATON Zoltan wrote: The Marvell Discovery II aka. MV64361 is a PowerPC system controller chip that is used on the pegasos2 PPC board. This adds emulation of it that models the device enough to boot guests on thi

Re: [RFC v1 06/38] target/arm: split off cpu-softmmu.c

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/23/21 9:55 AM, Claudio Fontana wrote: > On 2/22/21 6:29 PM, Alex Bennée wrote: >> >> Claudio Fontana writes: >> >>> From: Claudio Fontana >>> >>> Signed-off-by: Claudio Fontana >>> --- >>> target/arm/internals.h | 9 ++- >>> target/arm/cpu-softmmu.c | 134 ++

Re: [RFC v1 00/38] arm cleanup experiment for kvm-only build

2021-02-23 Thread Claudio Fontana
On 2/22/21 5:08 PM, Richard Henderson wrote: > On 2/22/21 12:43 AM, Claudio Fontana wrote: >> Regarding terminology, I think the mismatch is throughout the code right? > > Yes, e.g. the top-level softmmu/. > > >> So many of the existing "softmmu" files and directories should actually be >> calle

Re: [PATCH v3 1/6] vt82c686: Implement control of serial port io ranges via config regs

2021-02-23 Thread BALATON Zoltan
On Tue, 23 Feb 2021, David Gibson wrote: On Mon, Feb 22, 2021 at 04:22:06PM +0100, BALATON Zoltan wrote: In VIA super south bridge the io ranges of superio components (parallel and serial ports and FDC) can be controlled by superio config registers to set their base address and enable/disable th

Re: [RFC v1 00/38] arm cleanup experiment for kvm-only build

2021-02-23 Thread Claudio Fontana
On 2/22/21 8:00 PM, Alex Bennée wrote: > > Claudio Fontana writes: > >> Hi all, >> >> this is an experiment, a cleanup based on and requiring the series >> "i386 cleanup PART 2": >> >> https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg05935.html >> >> The goal is to split the code between

Re: [RFC v1 00/38] arm cleanup experiment for kvm-only build

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/22/21 8:00 PM, Alex Bennée wrote: > > Claudio Fontana writes: > >> Hi all, >> >> this is an experiment, a cleanup based on and requiring the series >> "i386 cleanup PART 2": >> >> https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg05935.html >> >> The goal is to split the code between

Re: [PATCH v4 3/5] hw/arm: xlnx-zynqmp: Connect a Xilinx CSU DMA module for QSPI

2021-02-23 Thread Bin Meng
Hi Edgar, On Tue, Feb 23, 2021 at 5:01 PM Edgar E. Iglesias wrote: > > On Mon, Feb 22, 2021 at 09:05:12PM +0800, Bin Meng wrote: > > From: Xuzhou Cheng > > > > Add a Xilinx CSU DMA module to ZynqMP SoC, and connent the stream > > link of GQSPI to CSU DMA. > > > > Signed-off-by: Xuzhou Cheng > >

Re: [PATCH v4 1/5] hw/dma: xlnx_csu_dma: Implement a Xilinx CSU DMA model

2021-02-23 Thread Edgar E. Iglesias
On Mon, Feb 22, 2021 at 09:05:10PM +0800, Bin Meng wrote: > From: Xuzhou Cheng > > ZynqMP QSPI supports SPI transfer using DMA mode, but currently this > is unimplemented. When QSPI is programmed to use DMA mode, QEMU will > crash. This is observed when testing VxWorks 7. > > This adds a Xilinx

Re: [PATCH v2 0/2] block: Use 'read-zeroes=true' mode by default with 'null-co' driver

2021-02-23 Thread Fam Zheng
On 2021-02-22 18:55, Philippe Mathieu-Daudé wrote: > On 2/22/21 6:35 PM, Fam Zheng wrote: > > On 2021-02-19 15:09, Philippe Mathieu-Daudé wrote: > >> On 2/19/21 12:07 PM, Max Reitz wrote: > >>> On 13.02.21 22:54, Fam Zheng wrote: > On 2021-02-11 15:26, Philippe Mathieu-Daudé wrote: > > The

Re: [RESEND PATCH v4 3/5] hw/arm: xlnx-zynqmp: Connect a Xilinx CSU DMA module for QSPI

2021-02-23 Thread Edgar E. Iglesias
On Mon, Feb 22, 2021 at 09:15:00PM +0800, Bin Meng wrote: > From: Xuzhou Cheng > > Add a Xilinx CSU DMA module to ZynqMP SoC, and connent the stream > link of GQSPI to CSU DMA. > > Signed-off-by: Xuzhou Cheng > Signed-off-by: Bin Meng Reviewed-by: Edgar E. Iglesias > > --- > RESEND this

Re: [PATCH v4 1/5] hw/dma: xlnx_csu_dma: Implement a Xilinx CSU DMA model

2021-02-23 Thread Bin Meng
Hi Edgar, On Tue, Feb 23, 2021 at 5:21 PM Edgar E. Iglesias wrote: > > On Mon, Feb 22, 2021 at 09:05:10PM +0800, Bin Meng wrote: > > From: Xuzhou Cheng > > > > ZynqMP QSPI supports SPI transfer using DMA mode, but currently this > > is unimplemented. When QSPI is programmed to use DMA mode, QEMU

Re: [PATCH v4 3/5] hw/arm: xlnx-zynqmp: Connect a Xilinx CSU DMA module for QSPI

2021-02-23 Thread Edgar E. Iglesias
On Tue, Feb 23, 2021 at 05:20:36PM +0800, Bin Meng wrote: > Hi Edgar, > > On Tue, Feb 23, 2021 at 5:01 PM Edgar E. Iglesias > wrote: > > > > On Mon, Feb 22, 2021 at 09:05:12PM +0800, Bin Meng wrote: > > > From: Xuzhou Cheng > > > > > > Add a Xilinx CSU DMA module to ZynqMP SoC, and connent the s

Re: [PATCH v3 1/6] vt82c686: Implement control of serial port io ranges via config regs

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/23/21 10:18 AM, BALATON Zoltan wrote: > On Tue, 23 Feb 2021, David Gibson wrote: >> On Mon, Feb 22, 2021 at 04:22:06PM +0100, BALATON Zoltan wrote: >>> In VIA super south bridge the io ranges of superio components >>> (parallel and serial ports and FDC) can be controlled by superio >>> config

Re: [PATCH v3 0/6] Pegasos2 emulation

2021-02-23 Thread BALATON Zoltan
On Tue, 23 Feb 2021, David Gibson wrote: On Mon, Feb 22, 2021 at 04:22:06PM +0100, BALATON Zoltan wrote: Hello, This is adding a new PPC board called pegasos2. More info on it can be found at: https://osdn.net/projects/qmiga/wiki/SubprojectPegasos2 Currently it needs a firmware ROM image that

Re: [PATCH v2 0/2] block: Use 'read-zeroes=true' mode by default with 'null-co' driver

2021-02-23 Thread Daniel P . Berrangé
On Tue, Feb 23, 2021 at 09:44:51AM +0100, Max Reitz wrote: > On 22.02.21 19:15, Daniel P. Berrangé wrote: > > On Fri, Feb 19, 2021 at 03:09:43PM +0100, Philippe Mathieu-Daudé wrote: > > > On 2/19/21 12:07 PM, Max Reitz wrote: > > > > On 13.02.21 22:54, Fam Zheng wrote: > > > > > On 2021-02-11 15:26

Re: [PATCH v4 1/5] hw/dma: xlnx_csu_dma: Implement a Xilinx CSU DMA model

2021-02-23 Thread Edgar E. Iglesias
On Tue, Feb 23, 2021 at 05:23:43PM +0800, Bin Meng wrote: > Hi Edgar, > > On Tue, Feb 23, 2021 at 5:21 PM Edgar E. Iglesias > wrote: > > > > On Mon, Feb 22, 2021 at 09:05:10PM +0800, Bin Meng wrote: > > > From: Xuzhou Cheng > > > > > > ZynqMP QSPI supports SPI transfer using DMA mode, but curren

Re: A brief look at deprecating our JSON extensions over RFC 8259

2021-02-23 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Feb 22, 2021 at 06:47:30PM +0100, Paolo Bonzini wrote: >> On 22/02/21 16:24, Daniel P. Berrangé wrote: >> > This problem isn't unique to QEMU. Any app using JSON from the >> > shell will have the tedium of quote escaping. JSON is incredibly >> > widespread and

Re: [RFC v1 06/38] target/arm: split off cpu-softmmu.c

2021-02-23 Thread Claudio Fontana
On 2/23/21 10:16 AM, Philippe Mathieu-Daudé wrote: > On 2/23/21 9:55 AM, Claudio Fontana wrote: >> On 2/22/21 6:29 PM, Alex Bennée wrote: >>> >>> Claudio Fontana writes: >>> From: Claudio Fontana Signed-off-by: Claudio Fontana --- target/arm/internals.h | 9 ++-

Re: romfile resize

2021-02-23 Thread Philippe Mathieu-Daudé
Cc'ing qemu-devel@ On 2/23/21 1:45 AM, Jiatong Shen wrote: > Hello, > >   we are faced with an issue where a changed sized romfile > (efi-virtio.rom) fails live migration. Do qemu load this rom from its > current host only? If yes, why cannot sync this from source vm? > > thank you. > > -- >

Re: A brief look at deprecating our JSON extensions over RFC 8259

2021-02-23 Thread Markus Armbruster
Markus Armbruster writes: [...] > A bigger stumbling block for replacement is our need for a streaming > interface: we feed the parser characters, and expect to be called back > when an expression is complete. Another stumbling block: check-qjson.c test case "/literals/string/utf8" and "/literal

Re: [PATCH v5 0/9] block: Add retry for werror=/rerror= mechanism

2021-02-23 Thread Stefan Hajnoczi
On Fri, Feb 05, 2021 at 06:13:06PM +0800, Jiahui Cen wrote: > This patch series propose to extend the werror=/rerror= mechanism to add > a 'retry' feature. It can automatically retry failed I/O requests on error > without sending error back to guest, and guest can get back running smoothly > when I

Re: romfile resize

2021-02-23 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > Cc'ing qemu-devel@ > > On 2/23/21 1:45 AM, Jiatong Shen wrote: > > Hello, > > > >   we are faced with an issue where a changed sized romfile > > (efi-virtio.rom) fails live migration. Do qemu load this rom from its > > current host only? If ye

Re: who's using the ozlabs patchwork install for QEMU patches ?

2021-02-23 Thread Greg Kurz
On Tue, 23 Feb 2021 14:57:21 +0800 Bin Meng wrote: > On Mon, Feb 22, 2021 at 10:43 PM Greg Kurz wrote: > > > > On Mon, 22 Feb 2021 13:59:34 + > > Peter Maydell wrote: > > > > > On Mon, 22 Feb 2021 at 07:21, Greg Kurz wrote: > > > > > > > > On Fri, 19 Feb 2021 17:51:02 +0100 > > > > Thomas

[PATCH] docs: move CODING_STYLE into the developer documentation

2021-02-23 Thread Alex Bennée
There is no particular reason to keep this on it's own in the root of the tree. Move it into the rest of the fine developer manual and fixup any links to it. The only tweak I've made is to fix the code-block annotations to mention the language C. Signed-off-by: Alex Bennée --- docs/devel/index.r

Re: [RFC v1 24/38] target/arm: move aa64_va_parameter_tbi,tbid,tcma and arm_rebuild_hflags

2021-02-23 Thread Claudio Fontana
On 2/22/21 7:02 AM, Richard Henderson wrote: > On 2/21/21 1:24 AM, Claudio Fontana wrote: >> From: Claudio Fontana >> >> they are needed for KVM too, move them out of TCG helpers. >> >> Signed-off-by: Claudio Fontana >> --- >> target/arm/internals.h | 37 + >> target/arm/tcg/helper-tcg

Re: [PATCH v5 0/9] block: Add retry for werror=/rerror= mechanism

2021-02-23 Thread Jiahui Cen
Hi Stefan, On 2021/2/23 17:40, Stefan Hajnoczi wrote: > On Fri, Feb 05, 2021 at 06:13:06PM +0800, Jiahui Cen wrote: >> This patch series propose to extend the werror=/rerror= mechanism to add >> a 'retry' feature. It can automatically retry failed I/O requests on error >> without sending error bac

Re: romfile resize

2021-02-23 Thread Dr. David Alan Gilbert
* Jiatong Shen (yshxxsjt...@gmail.com) wrote: > Hi, > > Thank you very much for the answer. so if romfile on destination got a > larger size than source, why romfile check still does not > pass? because dest got enough space to hold romfile. Right. Dave > thank you. > > Jiatong Shen > > On

Re: [Rust-VMM] vhost reply_ack negotiation (a.k.a differences in vhost-user behaviour with libvhost-user and vhost-user-backend.rs)

2021-02-23 Thread Jiang Liu
I just found this thread in my email junk box:( I do have found some bugs in the vhost_rs crate, related to handle the need_reply flag. But that bug only affects virtio-fs fs_map operations. Please refer to: https://github.com/rust-vmm/vhost/pull/19 https://github.com/rust-vmm/vhost/pull/19/commit

Re: romfile resize

2021-02-23 Thread Paolo Bonzini
On 23/02/21 10:57, Jiatong Shen wrote:   Thank you very much for the answer. so if romfile on destination got a larger size than source, why romfile check still does not pass? because dest got enough space to hold romfile. Because QEMU checks that memory areas have the same size on the sour

Re: [PATCH v2 00/15] tests/tcg: Add TriCore tests

2021-02-23 Thread Bastian Koppelmann
Hi Thomas, On Mon, Feb 22, 2021 at 10:23:23AM +0100, Thomas Huth wrote: > On 04/06/2020 10.54, Bastian Koppelmann wrote: > > Hi Alex, > > > > I managed to update the series to successfully run make check-tcg. This > > required > > some changes to the makefiles. I tried running the riscv64 and ar

Re: who's using the ozlabs patchwork install for QEMU patches ?

2021-02-23 Thread Bin Meng
On Tue, Feb 23, 2021 at 5:55 PM Greg Kurz wrote: > > On Tue, 23 Feb 2021 14:57:21 +0800 > Bin Meng wrote: > > > On Mon, Feb 22, 2021 at 10:43 PM Greg Kurz wrote: > > > > > > On Mon, 22 Feb 2021 13:59:34 + > > > Peter Maydell wrote: > > > > > > > On Mon, 22 Feb 2021 at 07:21, Greg Kurz wrot

[Bug 1916394] Re: [git] Cannot build qemu: FAILED: target/hexagon/semantics_generated.pyinc

2021-02-23 Thread Frederic Bezies
Sorry for the late reply. Tried patch... Here is the output: Option b_staticpic is: false [default: false] Found ninja-1.10.2 at /usr/bin/ninja [658/9072] Generating iset.py with a custom command FAILED: target/hexagon/iset.py @INPUT@ target/hexagon/iset.py /bin/sh: line 1: @INPUT@: command not f

Re: What prevents discarding a cluster during rewrite?

2021-02-23 Thread Kevin Wolf
Am 22.02.2021 um 22:42 hat Vladimir Sementsov-Ogievskiy geschrieben: > 23.02.2021 00:30, Vladimir Sementsov-Ogievskiy wrote: > > Thinking of how to prevent dereferencing to zero (and discard) of > > host cluster during flush of compressed cache (which I'm working on > > now), I have a question.. Wh

Re: [PATCH v2 01/11] accel/kvm: Check MachineClass kvm_type() return value

2021-02-23 Thread Cornelia Huck
On Tue, 23 Feb 2021 10:37:01 +1100 David Gibson wrote: > On Tue, Feb 23, 2021 at 10:33:55AM +1100, David Gibson wrote: > > On Mon, Feb 22, 2021 at 06:50:44PM +0100, Cornelia Huck wrote: > > > On Mon, 22 Feb 2021 18:41:07 +0100 > > > Philippe Mathieu-Daudé wrote: > > > > > > > On 2/22/21 6:2

Re: [PATCH v6 01/12] memory: Introduce RamDiscardMgr for RAM memory regions

2021-02-23 Thread David Hildenbrand
On 22.02.21 20:43, David Hildenbrand wrote: The main motivation is to let listener decide how it wants to handle the memory region. For example, for vhost, vdpa, kvm, ... I only want a single region, not separate ones for each and every populated range, punching out discarded ranges. Note that th

[RFC PATCH] docs/devel: re-organise the developers guide into sections

2021-02-23 Thread Alex Bennée
The list of sub-sections was getting a bit long and sporadically organised. Let's try and impose some order on this hairball of documentation. [AJB: RFC because I wonder if we should make a more concerted effort to move bits of the wiki into a canonical maintained document. There is also probably

Re: [PATCH] vhost: simplify vhost_dev_init() fail_busyloop label

2021-02-23 Thread Stefano Garzarella
On Mon, Feb 22, 2021 at 11:49:31AM +, Stefan Hajnoczi wrote: Requiring a conditional for every goto is tedious: if (busyloop_timeout) { goto fail_busyloop; } else { goto fail; } Move the conditional to into the fail_busyloop label so that it's safe to jump to this label uncondi

Re: [PATCH 2/2] hw/nvme: move device-scoped functions

2021-02-23 Thread Minwoo Im
On 21-02-09 12:08:26, Klaus Jensen wrote: > From: Klaus Jensen > > Move a bunch of functions that are internal to a device out of the > shared header. > > Signed-off-by: Klaus Jensen > --- > hw/nvme/nvme.h | 110 + > hw/nvme/ctrl.c | 90

Re: Plugin Address Translations Inconsistent/Incorrect?

2021-02-23 Thread Peter Maydell
On Tue, 23 Feb 2021 at 08:55, Alex Bennée wrote: > > > Peter Maydell writes: > > > On Mon, 22 Feb 2021 at 19:53, Alex Bennée wrote: > >> It certainly is by design. The comment for the helper states: > >> > >> /* > >>* The following additional queries can be run on the hwaddr structure > >>

Re: A brief look at deprecating our JSON extensions over RFC 8259

2021-02-23 Thread Paolo Bonzini
On 23/02/21 10:06, Markus Armbruster wrote: Markus, did you rebuild the qtests after disabling single-quoted strings? "make check-qtest-x86_64" would have rebuilt them, but I'm confused by the results. I ran "make check" and looked at the failures: Still confused? Yes. What's the patch that

Re: A brief look at deprecating our JSON extensions over RFC 8259

2021-02-23 Thread Peter Maydell
On Tue, 23 Feb 2021 at 09:33, Markus Armbruster wrote: > Misunderstanding: our JSON interpolation feature is *not* string > interpolation! It interpolates *objects* into the QObject built by the > parser. Given that it's basically undocumented except in a scattered handful of comments inside the

Re: [RFC v1 34/38] target/arm: cpu: only initialize TCG gt timers under CONFIG_TCG

2021-02-23 Thread Alex Bennée
Claudio Fontana writes: > On 2/22/21 4:34 PM, Alex Bennée wrote: >> >> Claudio Fontana writes: >> >>> From: Claudio Fontana >>> >>> KVM has its own cpu->kvm_vtime. >>> >>> Adjust cpu vmstate by putting unused fields instead of the >>> VMSTATE_TIMER_PTR when TCG is not available. >>> >>> Sig

Re: [PATCH] docs: move CODING_STYLE into the developer documentation

2021-02-23 Thread Claudio Fontana
On 2/23/21 10:59 AM, Alex Bennée wrote: > There is no particular reason to keep this on it's own in the root of > the tree. Move it into the rest of the fine developer manual and fixup > any links to it. The only tweak I've made is to fix the code-block > annotations to mention the language C. > >

Re: [PATCH v2 00/12] block/export: vhost-user-blk server tests and input validation

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/19/21 11:38 PM, Peter Maydell wrote: > On Mon, 15 Feb 2021 at 10:41, Kevin Wolf wrote: >> >> Am 07.12.2020 um 18:20 hat Stefan Hajnoczi geschrieben: >>> v2: >>> * Add abrt handler that terminates qemu-storage-daemon to >>>vhost-user-blk-test. No more orphaned processes on test failure. [

[PATCH] ui/cocoa: Do not rely on the first argument

2021-02-23 Thread Akihiko Odaki
The first argument of the executable was used to get its path, but it is not reliable because the executer can specify any arbitrary string. Use the interfaces provided by QEMU and the platform to get those paths. This change also changes the icon shown in the "about" window to QEMU's cute one. S

Re: [PATCH] docs: move CODING_STYLE into the developer documentation

2021-02-23 Thread Peter Maydell
On Tue, 23 Feb 2021 at 10:02, Alex Bennée wrote: > > There is no particular reason to keep this on it's own in the root of > the tree. Move it into the rest of the fine developer manual and fixup > any links to it. The only tweak I've made is to fix the code-block > annotations to mention the lang

Re: who's using the ozlabs patchwork install for QEMU patches ?

2021-02-23 Thread Peter Maydell
On Mon, 22 Feb 2021 at 14:43, Greg Kurz wrote: > My understanding is that users must be "maintainer" to edit other's > patches. Only three 'maintainers' are currently listed at ozlabs for > QEMU: > > https://patchwork.ozlabs.org/api/1.0/projects/14/ > > We had a discussion about that a few months

[PATCH] target/hexagon/opcodes: Add missing varargs cleanup

2021-02-23 Thread Philippe Mathieu-Daudé
Fix a trivial incorrect usage of variable argument macros detected by Coverity (missing_va_end: va_end was not called for ap). Fixes: Coverity CID 1446720 (VARARGS) Fixes: e3c00c2ed75 ("Hexagon (target/hexagon) opcode data structures") Signed-off-by: Philippe Mathieu-Daudé --- target/hexagon/opc

Re: [RFC PATCH] docs/devel: re-organise the developers guide into sections

2021-02-23 Thread Peter Maydell
On Tue, 23 Feb 2021 at 10:51, Alex Bennée wrote: > > The list of sub-sections was getting a bit long and sporadically > organised. Let's try and impose some order on this hairball of > documentation. Yeah, the 'devel' section has always been just a grab-bag of whatever docs we had to hand. On the

Re: [PATCH] vhost: simplify vhost_dev_init() fail_busyloop label

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/22/21 12:49 PM, Stefan Hajnoczi wrote: > Requiring a conditional for every goto is tedious: > > if (busyloop_timeout) { > goto fail_busyloop; > } else { > goto fail; > } > > Move the conditional to into the fail_busyloop label so that it's safe > to jump to this label uncon

Re: [PATCH v5 1/4] Jobs based on custom runners: documentation and configuration placeholder

2021-02-23 Thread Alex Bennée
Cleber Rosa writes: > As described in the included documentation, the "custom runner" jobs > extend the GitLab CI jobs already in place. One of their primary > goals of catching and preventing regressions on a wider number of host > systems than the ones provided by GitLab's shared runners. >

Re: [PATCH v2 01/11] accel/kvm: Check MachineClass kvm_type() return value

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/23/21 11:36 AM, Cornelia Huck wrote: > On Tue, 23 Feb 2021 10:37:01 +1100 > David Gibson wrote: > >> On Tue, Feb 23, 2021 at 10:33:55AM +1100, David Gibson wrote: >>> On Mon, Feb 22, 2021 at 06:50:44PM +0100, Cornelia Huck wrote: On Mon, 22 Feb 2021 18:41:07 +0100 Philippe Mathie

Re: [PATCH v2] virtio-blk: Respect discard granularity

2021-02-23 Thread Stefano Garzarella
On Tue, Feb 23, 2021 at 02:36:16PM +0900, Akihiko Odaki wrote: Signed-off-by: Akihiko Odaki --- hw/block/virtio-blk.c | 8 +++- hw/core/machine.c | 9 - include/hw/virtio/virtio-blk.h | 1 + 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/hw/block/v

Re: [PATCH v5 1/4] Jobs based on custom runners: documentation and configuration placeholder

2021-02-23 Thread Thomas Huth
On 19/02/2021 22.58, Cleber Rosa wrote: As described in the included documentation, the "custom runner" jobs extend the GitLab CI jobs already in place. One of their primary goals of catching and preventing regressions on a wider number of host systems than the ones provided by GitLab's shared r

Re: [PATCH] docs: move CODING_STYLE into the developer documentation

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/23/21 12:07 PM, Peter Maydell wrote: > On Tue, 23 Feb 2021 at 10:02, Alex Bennée wrote: >> >> There is no particular reason to keep this on it's own in the root of >> the tree. Move it into the rest of the fine developer manual and fixup >> any links to it. The only tweak I've made is to fix

Re: [PATCH] docs: move CODING_STYLE into the developer documentation

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/23/21 12:29 PM, Philippe Mathieu-Daudé wrote: > On 2/23/21 12:07 PM, Peter Maydell wrote: >> On Tue, 23 Feb 2021 at 10:02, Alex Bennée wrote: >>> >>> There is no particular reason to keep this on it's own in the root of >>> the tree. Move it into the rest of the fine developer manual and fixu

Re: [RFC v1 34/38] target/arm: cpu: only initialize TCG gt timers under CONFIG_TCG

2021-02-23 Thread Claudio Fontana
On 2/23/21 12:01 PM, Alex Bennée wrote: > > Claudio Fontana writes: > >> On 2/22/21 4:34 PM, Alex Bennée wrote: >>> >>> Claudio Fontana writes: >>> From: Claudio Fontana KVM has its own cpu->kvm_vtime. Adjust cpu vmstate by putting unused fields instead of the VMS

Re: who's using the ozlabs patchwork install for QEMU patches ?

2021-02-23 Thread Greg Kurz
On Tue, 23 Feb 2021 11:09:05 + Peter Maydell wrote: > On Mon, 22 Feb 2021 at 14:43, Greg Kurz wrote: > > My understanding is that users must be "maintainer" to edit other's > > patches. Only three 'maintainers' are currently listed at ozlabs for > > QEMU: > > > > https://patchwork.ozlabs.org

Re: QEMU hosting

2021-02-23 Thread Philippe Mathieu-Daudé
Updating this thread for the list, I have been told that Cleber is looking at all these options for mainstream CI, and is already in contact with fosshost.org. I'll let him follow these ideas. Regards, Phil. On 2/22/21 5:11 PM, Philippe Mathieu-Daudé wrote: > On 2/22/21 5:07 PM, Philippe Mathie

Re: vhost reply_ack negotiation (a.k.a differences in vhost-user behaviour with libvhost-user and vhost-user-backend.rs)

2021-02-23 Thread Michael S. Tsirkin
Cc: Raphael On Fri, Feb 19, 2021 at 04:04:34PM +, Alex Bennée wrote: > Hi, > > I finally got a chance to get down into the guts of vhost-user while > attempting to port my original C RPMB daemon to Rust using the > vhost-user-backend and related crates. I ended up with this hang during > nego

Re: who's using the ozlabs patchwork install for QEMU patches ?

2021-02-23 Thread Peter Maydell
On Tue, 23 Feb 2021 at 11:39, Greg Kurz wrote: > > On Tue, 23 Feb 2021 11:09:05 + > Peter Maydell wrote: > > > On Mon, 22 Feb 2021 at 14:43, Greg Kurz wrote: > > > My understanding is that users must be "maintainer" to edit other's > > > patches. Only three 'maintainers' are currently listed

Re: [PATCH v6 01/11] hvf: Add hypervisor entitlement to output binaries

2021-02-23 Thread Akihiko Odaki
Hi, I use your patches when running QEMU on M1 MacBook Air. I noticed that the installation process corrupts the code signature because meson modifies the file to fix dynamic shared library install names. Also, stripping apparently does not work because the signed file is not considered as "e

Re: [PATCH] docs: move CODING_STYLE into the developer documentation

2021-02-23 Thread Alex Bennée
Peter Maydell writes: > On Tue, 23 Feb 2021 at 10:02, Alex Bennée wrote: >> >> There is no particular reason to keep this on it's own in the root of >> the tree. Move it into the rest of the fine developer manual and fixup >> any links to it. The only tweak I've made is to fix the code-block >

[PATCH v3] virtio-blk: Respect discard granularity

2021-02-23 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- hw/block/virtio-blk.c | 8 +++- hw/core/machine.c | 4 +++- include/hw/virtio/virtio-blk.h | 1 + 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index bac2d6fa2b2..f4378e61182

Re: [PATCH v2 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-02-23 Thread Halil Pasic
On Mon, 22 Feb 2021 17:30:50 + Daniel P. Berrangé wrote: > > Paolo, Daniel, > > I am in general (s390 unrelated) a bit puzzled about the scenario of QEMU > > being modularized. > > Libvirt probes QEMU executables for their capabilities and creates a > > capabilities cache of the probed QEMU b

Re: [PATCH qemu v13] spapr: Implement Open Firmware client interface

2021-02-23 Thread Alexey Kardashevskiy
On 23/02/2021 14:07, David Gibson wrote: On Tue, Feb 09, 2021 at 10:02:52PM +1100, Alexey Kardashevskiy wrote: The PAPR platform which describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaboration between the firmwa

Re: who's using the ozlabs patchwork install for QEMU patches ?

2021-02-23 Thread Christian Schoenebeck
On Dienstag, 23. Februar 2021 12:54:47 CET Peter Maydell wrote: > On Tue, 23 Feb 2021 at 11:39, Greg Kurz wrote: > > On Tue, 23 Feb 2021 11:09:05 + > > > > Peter Maydell wrote: > > > On Mon, 22 Feb 2021 at 14:43, Greg Kurz wrote: > > > > My understanding is that users must be "maintainer" t

Re: A brief look at deprecating our JSON extensions over RFC 8259

2021-02-23 Thread Markus Armbruster
Paolo Bonzini writes: > On 23/02/21 10:06, Markus Armbruster wrote: >>> Markus, did you rebuild the qtests after disabling single-quoted >>> strings? "make check-qtest-x86_64" would have rebuilt them, but I'm >>> confused by the results. >> I ran "make check" and looked at the failures: >> Still

Re: [RFC v1 34/38] target/arm: cpu: only initialize TCG gt timers under CONFIG_TCG

2021-02-23 Thread Claudio Fontana
On 2/23/21 12:36 PM, Claudio Fontana wrote: > On 2/23/21 12:01 PM, Alex Bennée wrote: >> >> Claudio Fontana writes: >> >>> On 2/22/21 4:34 PM, Alex Bennée wrote: Claudio Fontana writes: > From: Claudio Fontana > > KVM has its own cpu->kvm_vtime. > > Adjust cpu

Re: who's using the ozlabs patchwork install for QEMU patches ?

2021-02-23 Thread Alexey Kardashevskiy
On 23/02/2021 23:24, Christian Schoenebeck wrote: On Dienstag, 23. Februar 2021 12:54:47 CET Peter Maydell wrote: On Tue, 23 Feb 2021 at 11:39, Greg Kurz wrote: On Tue, 23 Feb 2021 11:09:05 + Peter Maydell wrote: On Mon, 22 Feb 2021 at 14:43, Greg Kurz wrote: My understanding is th

Re: A brief look at deprecating our JSON extensions over RFC 8259

2021-02-23 Thread Markus Armbruster
Peter Maydell writes: > On Tue, 23 Feb 2021 at 09:33, Markus Armbruster wrote: >> Misunderstanding: our JSON interpolation feature is *not* string >> interpolation! It interpolates *objects* into the QObject built by the >> parser. > > Given that it's basically undocumented except in a scattere

[PATCH] ui/cocoa: Replace fprintf with error_report

2021-02-23 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 0ef5fdf3b7a..900bc984733 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -270,7 +270,7 @@ static bool bool_with_iothread_lock(BoolCodeBlock block) stati

[PATCH] blockjob: report a better error message

2021-02-23 Thread Stefano Garzarella
When a block job fails, we report 'strerror(-job->job.ret)' error message, also if the job set an error object. Let's report a better error message using 'error_get_pretty(job->job.err)'. If an error object was not set, strerror(-job->ret) is used as fallback, as explained in include/qemu/job.h:

Re: [PATCH] ui/cocoa: Replace fprintf with error_report

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/23/21 2:11 PM, Akihiko Odaki wrote: > Signed-off-by: Akihiko Odaki > --- > ui/cocoa.m | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ui/cocoa.m b/ui/cocoa.m > index 0ef5fdf3b7a..900bc984733 100644 > --- a/ui/cocoa.m > +++ b/ui/cocoa.m > @@ -270,7 +270,7 @@ st

Re: Can not set high msize with virtio-9p (Was: Re: virtiofs vs 9p performance)

2021-02-23 Thread Christian Schoenebeck
On Montag, 22. Februar 2021 18:11:59 CET Greg Kurz wrote: > On Mon, 22 Feb 2021 16:08:04 +0100 > Christian Schoenebeck wrote: > > [...] > > > I did not ever have a kernel crash when I boot a Linux guest with a 9pfs > > root fs and 100 MiB msize. > > Interesting. > > > Should we ask virtio or 9

Re: [PATCH v5 0/9] block: Add retry for werror=/rerror= mechanism

2021-02-23 Thread Eric Blake
On 2/23/21 3:40 AM, Stefan Hajnoczi wrote: > On Fri, Feb 05, 2021 at 06:13:06PM +0800, Jiahui Cen wrote: >> This patch series propose to extend the werror=/rerror= mechanism to add >> a 'retry' feature. It can automatically retry failed I/O requests on error >> without sending error back to guest,

Re: [PATCH v5 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/19/21 10:58 PM, Cleber Rosa wrote: > To have the jobs dispatched to custom runners, gitlab-runner must > be installed, active as a service and properly configured. The > variables file and playbook introduced here should help with those > steps. > > The playbook introduced here covers a numb

Re: [PATCH] docs: move CODING_STYLE into the developer documentation

2021-02-23 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 2/23/21 12:29 PM, Philippe Mathieu-Daudé wrote: >> On 2/23/21 12:07 PM, Peter Maydell wrote: >>> On Tue, 23 Feb 2021 at 10:02, Alex Bennée wrote: There is no particular reason to keep this on it's own in the root of the tree. Move it into the

Re: [PATCH v5 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/19/21 10:58 PM, Cleber Rosa wrote: > To have the jobs dispatched to custom runners, gitlab-runner must > be installed, active as a service and properly configured. The > variables file and playbook introduced here should help with those > steps. > > The playbook introduced here covers a numb

Re: Can not set high msize with virtio-9p (Was: Re: virtiofs vs 9p performance)

2021-02-23 Thread Michael S. Tsirkin
On Tue, Feb 23, 2021 at 02:39:48PM +0100, Christian Schoenebeck wrote: > On Montag, 22. Februar 2021 18:11:59 CET Greg Kurz wrote: > > On Mon, 22 Feb 2021 16:08:04 +0100 > > Christian Schoenebeck wrote: > > > > [...] > > > > > I did not ever have a kernel crash when I boot a Linux guest with a 9

Re: [PATCH v5 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/19/21 10:58 PM, Cleber Rosa wrote: > To have the jobs dispatched to custom runners, gitlab-runner must > be installed, active as a service and properly configured. The > variables file and playbook introduced here should help with those > steps. > > The playbook introduced here covers a numb

Re: [RFC PATCH 0/6] vhost-user: Shutdown/Flush slave channel properly

2021-02-23 Thread Michael S. Tsirkin
On Mon, Jan 25, 2021 at 01:01:09PM -0500, Vivek Goyal wrote: > Hi, > > We are working on DAX support in virtiofs and have some patches out of > the tree hosted here. > > https://gitlab.com/virtio-fs/qemu/-/commits/virtio-fs-dev any plans to post a non RFC version? > These patches have not been

Re: [PATCH v3] virtio-blk: Respect discard granularity

2021-02-23 Thread Michael S. Tsirkin
On Tue, Feb 23, 2021 at 09:09:40PM +0900, Akihiko Odaki wrote: > Signed-off-by: Akihiko Odaki Acked-by: Michael S. Tsirkin whoever knows more about the detail here, feel free to merge. > --- > hw/block/virtio-blk.c | 8 +++- > hw/core/machine.c | 4 +++- > include/

  1   2   3   >