[PATCH v2 00/22] eMMC support

2021-02-22 Thread Sai Pavan Boddu
Hi, This patch series add support for eMMC cards. This work was previosly submitted by Vincent, rebased few changes on top. Cedric & Joel has helped to added boot partition access support. I expect them to make a follow-up series to use it with aspeed machines. Present series adds eMMC support t

[PATCH v2 04/22] sd: emmc: update OCR fields for eMMC

2021-02-22 Thread Sai Pavan Boddu
From: Vincent Palatin eMMC OCR register doesn't has UHS-II field and voltage fields are different. Signed-off-by: Sai Pavan Boddu --- hw/sd/sd.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 42ee49c..430bea5 10064

[PATCH v2 18/22] sd: emmc: Subtract bootarea size from blk

2021-02-22 Thread Sai Pavan Boddu
From: Joel Stanley The userdata size is derived from the file the user passes on the command line, but we must take into account the boot areas. Signed-off-by: Joel Stanley Signed-off-by: Cédric Le Goater --- hw/sd/sd.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/sd/sd.c b/hw/

[PATCH v2 02/22] sd: sd: Remove usage of tabs in the file

2021-02-22 Thread Sai Pavan Boddu
Set tabstop as 4 and used expandtabs Signed-off-by: Sai Pavan Boddu --- hw/sd/sd.c | 190 ++--- 1 file changed, 95 insertions(+), 95 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 8517dbc..74b9162 100644 --- a/hw/sd/sd.c +++ b/hw/

[PATCH v2 03/22] sd: emmc: Add support for eMMC cards

2021-02-22 Thread Sai Pavan Boddu
From: Vincent Palatin This patch adds support for eMMC cards, change SET_RELATIVE_ADDR command to assign relative address as requested by user. Signed-off-by: Vincent Palatin Signed-off-by: Joel Stanley Signed-off-by: Cédric Le Goater [spb: Split original patch series] Signed-off-by: Sai Pava

[PATCH v2 09/22] sd: emmc: Update CMD1 definition for eMMC

2021-02-22 Thread Sai Pavan Boddu
Add support to Power up the card and send response r3 in case of eMMC. Signed-off-by: Sai Pavan Boddu Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis --- hw/sd/sd.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 9835f5

[PATCH v2 20/22] arm: xlnx-versal: Add emmc to versal

2021-02-22 Thread Sai Pavan Boddu
Configuring SDHCI-0 to act as eMMC controller. Signed-off-by: Sai Pavan Boddu --- include/hw/arm/xlnx-versal.h | 1 + hw/arm/xlnx-versal-virt.c| 30 +- hw/arm/xlnx-versal.c | 13 +++-- 3 files changed, 37 insertions(+), 7 deletions(-) diff --git

[PATCH v2 15/22] sd: emmc: Update CID structure for eMMC

2021-02-22 Thread Sai Pavan Boddu
CID structure is little different for eMMC, w.r.t to product name and manufacturing date. Signed-off-by: Sai Pavan Boddu Signed-off-by: Edgar E. Iglesias --- hw/sd/sd.c | 47 ++- 1 file changed, 30 insertions(+), 17 deletions(-) diff --git a/hw/sd/sd

[PATCH v2 13/22] sd: emmc: Make ACMD41 illegal for mmc

2021-02-22 Thread Sai Pavan Boddu
ACMD41 is not applicable for eMMC. Signed-off-by: Sai Pavan Boddu Signed-off-by: Edgar E. Iglesias --- hw/sd/sd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index d702027..df82b61 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -1729,6 +1729,9 @@ static sd_rsp_ty

[PATCH v2 12/22] sd: emmc: add CMD21 tuning sequence

2021-02-22 Thread Sai Pavan Boddu
eMMC cards support tuning sequence for entering HS200 mode. Signed-off-by: Sai Pavan Boddu Signed-off-by: Edgar E. Iglesias --- hw/sd/sd.c | 47 +++ 1 file changed, 47 insertions(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index e50d40b..d702027 100644 -

[PATCH v2 01/22] block: add eMMC block device type

2021-02-22 Thread Sai Pavan Boddu
From: Vincent Palatin Add new block device type. Signed-off-by: Vincent Palatin [SPB: Rebased over 5.1 version] Signed-off-by: Sai Pavan Boddu Signed-off-by: Joel Stanley Signed-off-by: Cédric Le Goater Reviewed-by: Alistair Francis --- include/sysemu/blockdev.h | 1 + blockdev.c

[PATCH v2 07/22] sd: sdmmc-internal: Add command string for SEND_OP_CMD

2021-02-22 Thread Sai Pavan Boddu
From: Cédric Le Goater This adds extra info to trace log. Signed-off-by: Sai Pavan Boddu --- hw/sd/sdmmc-internal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sd/sdmmc-internal.c b/hw/sd/sdmmc-internal.c index 2053def..8648a78 100644 --- a/hw/sd/sdmmc-internal.c +++

[PATCH v2 11/22] sd: emmc: Add mmc switch function support

2021-02-22 Thread Sai Pavan Boddu
switch operation in eMMC card updates the ext_csd register to request changes in card operations. Here we implement similar sequence but requests are mostly dummy and make no change. Implement SWITCH_ERROR if the write operation extends goes beyond length of ext_csd. Signed-off-by: Sai Pavan Bodd

[PATCH v2 05/22] sd: emmc: Add support for EXT_CSD & CSD for eMMC

2021-02-22 Thread Sai Pavan Boddu
From: Vincent Palatin eMMC CSD is similar to SD with an option to refer EXT_CSD for larger devices. Signed-off-by: Sai Pavan Boddu --- hw/sd/sd.c | 57 +++-- 1 file changed, 55 insertions(+), 2 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd

Re: [PATCH] MAINTAINERS: Cover docs/igd-assign.txt in VFIO section

2021-02-22 Thread Philippe Mathieu-Daudé
ping? On 2/2/21 4:56 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index bcd88668bcd..838d0f14a59 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1768,6 +176

[PATCH v2 16/22] sd: emmc: Add Extended CSD register definitions

2021-02-22 Thread Sai Pavan Boddu
From: Cédric Le Goater Add user friendly macros for EXT_CSD register. Signed-off-by: Cédric Le Goater [spb: Rebased over versal emmc series, updated commit message] Signed-off-by: Sai Pavan Boddu --- hw/sd/sdmmc-internal.h | 97 ++ hw/sd/s

[PATCH v2 22/22] docs: arm: xlnx-versal-virt: Add eMMC support documentation

2021-02-22 Thread Sai Pavan Boddu
Add details of eMMC specific machine property. Signed-off-by: Sai Pavan Boddu --- docs/system/arm/xlnx-versal-virt.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/system/arm/xlnx-versal-virt.rst b/docs/system/arm/xlnx-versal-virt.rst index 2602d0f..a48a88d 100644 --- a/

[PATCH v2 17/22] sd: emmc: Support boot area in emmc image

2021-02-22 Thread Sai Pavan Boddu
From: Joel Stanley This assumes a specially constructued image: dd if=/dev/zero of=mmc-bootarea.img count=2 bs=1M dd if=u-boot-spl.bin of=mmc-bootarea.img conv=notrunc dd if=u-boot.bin of=mmc-bootarea.img conv=notrunc count=64 bs=1K cat mmc-bootarea.img obmc-phosphor-image.wic > mmc.img

[PATCH v2 10/22] sd: emmc: support idle state in CMD2

2021-02-22 Thread Sai Pavan Boddu
eMMC is expected to be in idle-state post CMD1. Ready state is an intermediate stage which we don't come across in Device identification mode. Signed-off-by: Sai Pavan Boddu Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis --- hw/sd/sd.c | 4 1 file changed, 4 insertions(+)

[PATCH v2 21/22] docs: devel: emmc: Add a doc for emmc card emulation

2021-02-22 Thread Sai Pavan Boddu
Add few simple steps to create emmc card with boot and user data partitions. Signed-off-by: Sai Pavan Boddu --- docs/devel/emmc.txt | 16 1 file changed, 16 insertions(+) create mode 100644 docs/devel/emmc.txt diff --git a/docs/devel/emmc.txt b/docs/devel/emmc.txt new file mod

Re: [RFC v1 05/38] target/arm: wrap arm_cpu_exec_interrupt in CONFIG_TCG

2021-02-22 Thread Claudio Fontana
On 2/22/21 7:21 AM, Richard Henderson wrote: > On 2/21/21 1:24 AM, Claudio Fontana wrote: >> +#ifdef CONFIG_TCG >> bool arm_cpu_exec_interrupt(CPUState *cs, int interrupt_request) >> { >> CPUClass *cc = CPU_GET_CLASS(cs); >> @@ -607,6 +608,7 @@ bool arm_cpu_exec_interrupt(CPUState *cs, int

[PATCH v2 08/22] sd: emmc: Dont not update CARD_CAPACITY for eMMC cards

2021-02-22 Thread Sai Pavan Boddu
OCR.CARD_CAPACITY field is only valid for sd cards, So skip it for eMMC. Signed-off-by: Sai Pavan Boddu Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis --- hw/sd/sd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index a4f93b5..983

[PATCH v5] target/cris: Plug leakage of TCG temporaries

2021-02-22 Thread Stefan Sandström
From: Stefan Sandstrom Add and fix deallocation of temporary TCG registers in CRIS code generation. Tested-by: Edgar E. Iglesias Reviewed-by: Edgar E. Iglesias Reviewed-by: Richard Henderson Change-Id: I17fce5d95bdc4418337ba885d53ba97afb1bafcc Signed-off-by: Stefan Sandström --- target/cris

Re: [PATCH v5] target/cris: Plug leakage of TCG temporaries

2021-02-22 Thread Stefan Sandström
Hi, The last version just adds Richards Reviewed-by tag to the commit message. Thanks for all the input! -stefan > On 22 Feb 2021, at 09:23, Stefan Sandström wrote: > > From: Stefan Sandstrom > > Add and fix deallocation of temporary TCG registers in CRIS code > generation. > > Tested-by: E

[PULL v1 1/3] target/cris: Use MMUAccessType enum type when possible

2021-02-22 Thread Edgar E. Iglesias
From: Philippe Mathieu-Daudé Replace the 0/1/2 magic values by the corresponding MMUAccessType. We can remove a comment as enum names are self explicit. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Edgar E. Iglesias Message-Id: <20210128003223.3561108-2-f4

[PATCH v2 06/22] sd: emmc: Update CMD8 to send EXT_CSD register

2021-02-22 Thread Sai Pavan Boddu
From: Vincent Palatin Sends the EXT_CSD register as response to CMD8. Signed-off-by: Sai Pavan Boddu --- hw/sd/sd.c | 52 1 file changed, 36 insertions(+), 16 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 4c211ba..a4f93b5 100644 -

[PULL v1 2/3] target/cris: Let cris_mmu_translate() use MMUAccessType access_type

2021-02-22 Thread Edgar E. Iglesias
From: Philippe Mathieu-Daudé All callers of cris_mmu_translate() provide a MMUAccessType type. Let the prototype use it as argument, as it is stricter than an integer. We can remove the documentation as enum names are self explicit. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Hen

Re: [PATCH RFC] pvrdma: wean code off pvrdma_ring.h kernel header

2021-02-22 Thread Marcel Apfelbaum
Hi Jason. On Tue, Feb 9, 2021 at 5:47 AM Jason Wang wrote: > > On 2021/2/9 上午1:28, Paolo Bonzini wrote: > > On 08/02/21 18:17, Cornelia Huck wrote: > >> On Fri, 29 Jan 2021 16:27:19 +0100 > >> Cornelia Huck wrote: > >> > >>> On Fri, 22 Jan 2021 19:00:29 +0100 > >>> Cornelia Huck wrote: > >>> >

[PULL v1 0/3] CRIS queue

2021-02-22 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" The following changes since commit 00d8ba9e0d62ea1c7459c25aeabf9c8bb7659462: Merge remote-tracking branch 'remotes/philmd-gitlab/tags/mips-20210221' into staging (2021-02-21 19:52:58 +) are available in the Git repository at: g...@github.com:edgarigl/qemu.git

[PATCH v2 14/22] sd: emmc: Add support for emmc erase

2021-02-22 Thread Sai Pavan Boddu
Add CMD35 and CMD36 which sets the erase start and end. Signed-off-by: Sai Pavan Boddu Signed-off-by: Edgar E. Iglesias --- hw/sd/sd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index df82b61..6d2ef2b 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -1544,6 +1544,7

[PULL v1 3/3] target/cris: Plug leakage of TCG temporaries

2021-02-22 Thread Edgar E. Iglesias
From: Stefan Sandstrom Add and fix deallocation of temporary TCG registers in CRIS code generation. Tested-by: Edgar E. Iglesias Reviewed-by: Edgar E. Iglesias Change-Id: I17fce5d95bdc4418337ba885d53ba97afb1bafcc Signed-off-by: Stefan Sandström Reviewed-by: Richard Henderson Message-Id: <202

[PATCH v2 19/22] sd: sdhci: Support eMMC devices

2021-02-22 Thread Sai Pavan Boddu
Embedded device slots should be allowed as support of eMMC is available. Signed-off-by: Sai Pavan Boddu --- hw/sd/sdhci.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 8ffa539..771212a 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -99,10 +99,6 @@

Re: tests: n810 arm failing

2021-02-22 Thread Philippe Mathieu-Daudé
On 2/22/21 7:25 AM, Thomas Huth wrote: > On 21/02/2021 20.33, Peter Maydell wrote: >> On Sun, 21 Feb 2021 at 17:26, Philippe Mathieu-Daudé >> wrote: >>> >>> Hi, >>> >>> The n810 arm test failed on latest master: >>> >>> https://gitlab.com/qemu-project/qemu/-/jobs/1045015424/artifacts/browse/build/

Re: [RFC v1 34/38] target/arm: cpu: only initialize TCG gt timers under CONFIG_TCG

2021-02-22 Thread Claudio Fontana
On 2/21/21 2:59 PM, Claudio Fontana wrote: > On 2/21/21 10:55 AM, Philippe Mathieu-Daudé wrote: >> On 2/21/21 10:24 AM, Claudio Fontana wrote: >>> From: Claudio Fontana >>> >>> KVM has its own cpu->kvm_vtime. >>> >>> Adjust cpu vmstate by putting unused fields instead of the >>> VMSTATE_TIMER_PTR

Re: [PATCH RFC] pvrdma: wean code off pvrdma_ring.h kernel header

2021-02-22 Thread Jason Wang
- 原始邮件 - > Hi Jason. > > On Tue, Feb 9, 2021 at 5:47 AM Jason Wang wrote: > > > > > On 2021/2/9 上午1:28, Paolo Bonzini wrote: > > > On 08/02/21 18:17, Cornelia Huck wrote: > > >> On Fri, 29 Jan 2021 16:27:19 +0100 > > >> Cornelia Huck wrote: > > >> > > >>> On Fri, 22 Jan 2021 19:00:29

Re: [PULL v1 3/3] target/cris: Plug leakage of TCG temporaries

2021-02-22 Thread Philippe Mathieu-Daudé
Hi Edgar, On 2/22/21 9:33 AM, Edgar E. Iglesias wrote: > From: Stefan Sandstrom > > Add and fix deallocation of temporary TCG registers in CRIS code > generation. > > Tested-by: Edgar E. Iglesias > Reviewed-by: Edgar E. Iglesias > Change-Id: I17fce5d95bdc4418337ba885d53ba97afb1bafcc Out of c

Re: [PATCH] gitlab-ci: Remove unused container images

2021-02-22 Thread Alex Bennée
Thomas Huth writes: > On 20/02/2021 22.10, Alex Bennée wrote: >> >> Thomas Huth writes: >> >>> We're building a lot of containers in the gitlab-CI that we never use. >>> This takes away network bandwidth and CPU time from other jobs for no >>> use, so let's remove them for now. The individua

Re: [RFC v1 00/38] arm cleanup experiment for kvm-only build

2021-02-22 Thread Claudio Fontana
On 2/22/21 6:35 AM, Richard Henderson wrote: > On 2/21/21 1:24 AM, Claudio Fontana wrote: >> target/arm: move psci.c into tcg/softmmu/ > > Terminology: the opposite of user-only is not "softmmu" but "system". > > One glorious day in the far future user-only will, as an option, use softmmu. > It

Re: [PULL v1 3/3] target/cris: Plug leakage of TCG temporaries

2021-02-22 Thread Stefan Sandström
Hi, > On 22 Feb 2021, at 09:41, Philippe Mathieu-Daudé wrote: > > Hi Edgar, > > On 2/22/21 9:33 AM, Edgar E. Iglesias wrote: >> From: Stefan Sandstrom >> >> Add and fix deallocation of temporary TCG registers in CRIS code >> generation. >> >> Tested-by: Edgar E. Iglesias >> Reviewed-by: Edg

Re: [PULL v1 3/3] target/cris: Plug leakage of TCG temporaries

2021-02-22 Thread Edgar E. Iglesias
On Mon, Feb 22, 2021 at 09:41:16AM +0100, Philippe Mathieu-Daudé wrote: > Hi Edgar, > > On 2/22/21 9:33 AM, Edgar E. Iglesias wrote: > > From: Stefan Sandstrom > > > > Add and fix deallocation of temporary TCG registers in CRIS code > > generation. > > > > Tested-by: Edgar E. Iglesias > > Revi

[RFC PATCH v2 1/3] hw/pflash_cfi*: Replace DPRINTF with trace events

2021-02-22 Thread David Edmondson
Rather than having a device specific debug implementation in pflash_cfi01.c and pflash_cfi02.c, use the standard tracing facility. Signed-off-by: David Edmondson --- hw/block/pflash_cfi01.c | 78 + hw/block/pflash_cfi02.c | 75 +++--

[RFC PATCH v2 3/3] hw/pflash_cfi01: Allow devices to have a smaller backing device

2021-02-22 Thread David Edmondson
Allow the backing device to be smaller than the extent of the flash device by mapping it as a subregion of the flash device region. Return zeroes for all reads of the flash device beyond the extent of the backing device. For writes beyond the extent of the underlying device, fail on read-only dev

[RFC PATCH v2 2/3] hw/pflash_cfi01: Correct the type of PFlashCFI01.ro

2021-02-22 Thread David Edmondson
PFlashCFI01.ro is a bool, declare it as such. Signed-off-by: David Edmondson --- hw/block/pflash_cfi01.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c index 9e1f3b42c6..6b21b4af52 100644 --- a/hw/block/pflash_cfi01.c +++

[RFC PATCH v2 0/3] hw/flash_cfi01: Reduce memory consumption when flash image is smaller than region

2021-02-22 Thread David Edmondson
As described in https://lore.kernel.org/r/20201116104216.439650-1-david.edmond...@oracle.com, I'd like to reduce the amount of memory consumed by QEMU mapping UEFI images on aarch64. To recap: > Currently ARM UEFI images are typically built as 2MB/768kB flash > images for code and variables respe

[Bug 1915682] Re: i386-linux-user wine exception regression tests fail

2021-02-22 Thread Dirk A Niggemann
That was a complete misdiaagnsis. The IRET works fine in user space, at the lowest privlege level. The wrong thread is not restarted. The correct thread continues execution, at the correct address, but with the wrong thread-local data. Thread-local data is accessed via the segment loaded in the f

Re: [PATCH v2 00/15] tests/tcg: Add TriCore tests

2021-02-22 Thread Thomas Huth
On 04/06/2020 10.54, Bastian Koppelmann wrote: Hi Alex, I managed to update the series to successfully run make check-tcg. This required some changes to the makefiles. I tried running the riscv64 and arm tests and so far I didn't break anything. You can find the full tree here: https://github.c

Re: [RFC PATCH 11/15] sd: emmc: Add Extended CSD register definitions

2021-02-22 Thread Cédric Le Goater
On 2/16/21 12:11 PM, Sai Pavan Boddu wrote: > Hi Luc, >> -Original Message- >> From: Luc Michel >> Sent: Saturday, February 13, 2021 6:26 PM >> To: Sai Pavan Boddu ; Markus Armbruster >> ; Kevin Wolf ; Max Reitz >> ; Vladimir Sementsov-Ogievskiy >> ; Eric Blake ; Joel Stanley >> ; Cédric L

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-02-22 Thread Daniel P . Berrangé
On Fri, Feb 19, 2021 at 02:17:42PM -0800, Doug Evans wrote: > On Fri, Feb 19, 2021 at 2:00 AM Daniel P. Berrangé > wrote: > > > On Thu, Feb 18, 2021 at 12:15:36PM -0800, Doug Evans wrote: > > > The parsing is moved into new function inet_parse_host_and_port. > > > This is done in preparation for

[PATCH v6 1/2] drivers/misc: sysgenid: add system generation id driver

2021-02-22 Thread Adrian Catangiu
- Background and problem The System Generation ID feature is required in virtualized or containerized environments by applications that work with local copies or caches of world-unique data such as random values, uuids, monotonically increasing counters, etc. Such applications can be negatively af

[PATCH v6 0/2] System Generation ID driver and VMGENID backend

2021-02-22 Thread Adrian Catangiu
This feature is aimed at virtualized or containerized environments where VM or container snapshotting duplicates memory state, which is a challenge for applications that want to generate unique data such as request IDs, UUIDs, and cryptographic nonces. The patch set introduces a mechanism that pro

[PATCH v6 2/2] drivers/virt: vmgenid: add vm generation id driver

2021-02-22 Thread Adrian Catangiu
The VM Generation ID is a feature defined by Microsoft (paper: http://go.microsoft.com/fwlink/?LinkId=260709) and supported by multiple hypervisor vendors. The feature can be used to drive the `sysgenid` mechanism required in virtualized environments by software that works with local copies and ca

Re: [RFC PATCH 4/5] Add migration support for KVM guest with MTE

2021-02-22 Thread Haibo Xu
On Tue, 16 Feb 2021 at 23:31, Richard Henderson wrote: > > On 2/7/21 7:20 PM, Haibo Xu wrote: > > +if (kvm_physical_memory_addr_from_host(kvm_state, addr, &ipa)) { > > +/* Buffer for the page tags(one byte per tag) */ > > +tag_buf = g_try_malloc0(size); > > +if (!tag_bu

Re: [PATCH v2 04/22] sd: emmc: update OCR fields for eMMC

2021-02-22 Thread Cédric Le Goater
On 2/22/21 9:20 AM, Sai Pavan Boddu wrote: > From: Vincent Palatin > > eMMC OCR register doesn't has UHS-II field and voltage fields are > different. Can a patch be "From" a person without a "Signed-off-by" of the same person ? C. > Signed-off-by: Sai Pavan Boddu > > --- > hw/sd/sd.c | 27

Re: [PATCH v6 1/2] drivers/misc: sysgenid: add system generation id driver

2021-02-22 Thread Greg KH
On Mon, Feb 22, 2021 at 11:41:25AM +0200, Adrian Catangiu wrote: > The driver also generates a `SYSGENID=%u` uevent containing the new > system generation counter/id value every time it changes. Unlike the > filesystem interface, the uevent has no synchronization guarantees > therefore it should no

Re: [PATCH v2 16/22] sd: emmc: Add Extended CSD register definitions

2021-02-22 Thread Cédric Le Goater
On 2/22/21 9:20 AM, Sai Pavan Boddu wrote: > From: Cédric Le Goater > > Add user friendly macros for EXT_CSD register. > > Signed-off-by: Cédric Le Goater > [spb: Rebased over versal emmc series, > updated commit message] > Signed-off-by: Sai Pavan Boddu You can merge this patch in pat

RE: [PATCH v2 04/22] sd: emmc: update OCR fields for eMMC

2021-02-22 Thread Sai Pavan Boddu
Hi Cedric > -Original Message- > From: Cédric Le Goater > Sent: Monday, February 22, 2021 3:22 PM > To: Sai Pavan Boddu ; Markus Armbruster > ; Kevin Wolf ; Max Reitz > ; Vladimir Sementsov-Ogievskiy > ; Eric Blake ; Joel Stanley > ; Vincent Palatin ; Dr. David Alan > Gilbert ; Thomas Hut

[PATCH v2 1/6] meson.build: expose TCG cross compiler information in summary

2021-02-22 Thread Alex Bennée
Blink and you miss the cross TCG compiler stuff so lets display it with the rest of the compiler information. Signed-off-by: Alex Bennée Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Acked-by: Paolo Bonzini Message-Id: <20210216102522.6279-1-alex.ben...@linaro.org> Mess

[PATCH v2 2/6] docker: Bump Fedora images to release 33

2021-02-22 Thread Alex Bennée
From: Philippe Mathieu-Daudé Fedora 33 was released on October 27, 2020. Update all the Fedora 32 images to this new release. Suggested-by: Daniel Berrangé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20210118181255.314672-1-phi...@redhat.com> Message-Id: <20

[PATCH v2 4/6] docs/devel: expand on use of containers to build tests

2021-02-22 Thread Alex Bennée
Expand on the usage of containers for building tests and why we have some that are not used to build QEMU itself. Signed-off-by: Alex Bennée Cc: Thomas Huth --- docs/devel/testing.rst | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/docs/devel/testing.r

[PATCH v2 3/6] tests/acceptance: allow a "graceful" failing for virtio-gpu test

2021-02-22 Thread Alex Bennée
This is a band-aid with a TODO for cases when QEMU doesn't start due to missing VirGL. Longer term we could do with some proper feature probing. Signed-off-by: Alex Bennée Reviewed-by: Marc-André Lureau Reviewed-by: Willian Rampazzo Cc: Marc-André Lureau Message-Id: <20210217121932.19986-7-ale

[PATCH v2 0/6] testing/next (meson check-tcg, fedora bump, docs)

2021-02-22 Thread Alex Bennée
Hi, A few patches dropped off as Thomas merged them. I've added some additional documentation patches for testing.rst. I guess I'll wrap this up into a PR later this week. The docs patches need review: - docs/devel: add forward reference to check-tcg - docs/devel: update the container based tes

[PATCH v2 6/6] docs/devel: add forward reference to check-tcg

2021-02-22 Thread Alex Bennée
For completeness reference the check-tcg tests in the container preamble text. Signed-off-by: Alex Bennée Cc: Thomas Huth --- docs/devel/testing.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index e43c992f21..3124ee2470 100644 --- a

[PATCH v2 5/6] docs/devel: update the container based tests

2021-02-22 Thread Alex Bennée
This section has grown a little stale so clean-up the language and examples for current usage: - refer to containers at the top - mention podman can also be used - add podman prerequisites section - move to using "docker-help" for online help - mention the registry and it's purpose - d

Re: [PULL v1 3/3] target/cris: Plug leakage of TCG temporaries

2021-02-22 Thread Edgar E. Iglesias
On Mon, Feb 22, 2021 at 08:50:46AM +, Stefan Sandström wrote: > Hi, > > > On 22 Feb 2021, at 09:41, Philippe Mathieu-Daudé wrote: > > > > Hi Edgar, > > > > On 2/22/21 9:33 AM, Edgar E. Iglesias wrote: > >> From: Stefan Sandstrom > >> > >> Add and fix deallocation of temporary TCG register

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-22 Thread Vitaly Kuznetsov
Vitaly Kuznetsov writes: > Igor Mammedov writes: > >>> >>> We need to distinguish because that would be sane. >>> >>> Enlightened VMCS is an extension to VMX, it can't be used without >>> it. Genuine Hyper-V doesn't have a knob for enabling and disabling it, >> ... >>> That bein said, if >>> g

Re: [PULL v1 3/3] target/cris: Plug leakage of TCG temporaries

2021-02-22 Thread Philippe Mathieu-Daudé
Le lun. 22 févr. 2021 11:19, Edgar E. Iglesias a écrit : > On Mon, Feb 22, 2021 at 08:50:46AM +, Stefan Sandström wrote: > > Hi, > > > > > On 22 Feb 2021, at 09:41, Philippe Mathieu-Daudé > wrote: > > > > > > Hi Edgar, > > > > > > On 2/22/21 9:33 AM, Edgar E. Iglesias wrote: > > >> From: Ste

Re: [PATCH] configure: Do not require GBM for OpenGL

2021-02-22 Thread Gerd Hoffmann
On Fri, Feb 19, 2021 at 08:31:52PM +0900, Akihiko Odaki wrote: > Signed-off-by: Akihiko Odaki Breaks windows build: https://gitlab.com/kraxel/qemu/-/jobs/1046112682 # ls /usr/x86_64-w64-mingw32/sys-root/mingw/include/epoxy/ common.h gl.h gl_generated.h wgl.h wgl_generated.h Seems windows ha

Re: [PATCH v2] ui/cocoa: Remove the uses of full screen APIs

2021-02-22 Thread Gerd Hoffmann
Hi, > The detections of [NSView -enterFullScreen:] and > [NSView -exitFullScreen:] were wrong. A detection is coded as: > [NSView respondsToSelector:@selector(exitFullScreenModeWithOptions:)] > but it should be: > [NSView instancesRespondToSelector:@selector(exitFullScreenModeWithOptions:)] > >

Re: [PATCH v3] ui/cocoa: Use kCGColorSpaceSRGB

2021-02-22 Thread Gerd Hoffmann
On Sat, Feb 20, 2021 at 01:29:29PM +0900, Akihiko Odaki wrote: > kCGColorSpaceGenericRGB | Apple Developer Documentation > https://developer.apple.com/documentation/coregraphics/kcgcolorspacegenericrgb > > Deprecated > > Use kCGColorSpaceSRGB instead. > > This change also removes the legacy color

Re: [PATCH 4/4] ui, monitor: remove deprecated VNC ACL option and HMP commands

2021-02-22 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > The VNC ACL concept has been replaced by the pluggable "authz" framework > which does not use monitor commands. > > Signed-off-by: Daniel P. Berrangé This looks OK to me, so: Reviewed-by: Dr. David Alan Gilbert however, can you explicitly ad

[PATCH] linux-user: manage binfmt-misc preserve-arg[0] flag

2021-02-22 Thread Laurent Vivier
Add --preserve-argv0 in qemu-binfmt-conf.sh to configure the preserve-argv0 flag. This patch allows to use new flag in AT_FLAGS to detect if preserve-argv0 is configured for this interpreter: argv[0] (the full pathname provided by binfmt-misc) is removed and replaced by argv[1] (the original argv[

Re: [PATCH v2] ui/console: Pass placeholder surface to displays

2021-02-22 Thread Gerd Hoffmann
Hi, > #define QEMU_ALLOCATED_FLAG 0x01 > +#define QEMU_PLACEHOLDER_FLAG 0x02 > +static inline int is_placeholder(DisplaySurface *surface) > +{ > +return surface->flags & QEMU_PLACEHOLDER_FLAG; > +} Interesting idea. That approach makes sense too. > +if (!placeholder) { > +

Re: [PATCH] virtio-gpu: Respect graphics update interval for EDID

2021-02-22 Thread Gerd Hoffmann
On Sun, Feb 21, 2021 at 10:34:14PM +0900, Akihiko Odaki wrote: > This change introduces an additional member, refresh_rate to > qemu_edid_info in include/hw/display/edid.h. > > This change also isolates the graphics update interval from the > display update interval. The guest will update the fram

Re: [PATCH] linux-user: manage binfmt-misc preserve-arg[0] flag

2021-02-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210222105004.1642234-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210222105004.1642234-1-laur...@vivier.eu Subject: [PATCH] linux-user: manage binfmt-mis

Re: [PATCH] linux-user: manage binfmt-misc preserve-arg[0] flag

2021-02-22 Thread John Paul Adrian Glaubitz
Hi Laurent! On 2/22/21 11:50 AM, Laurent Vivier wrote: > Add --preserve-argv0 in qemu-binfmt-conf.sh to configure the preserve-argv0 > flag. > > This patch allows to use new flag in AT_FLAGS to detect if > preserve-argv0 is configured for this interpreter: > argv[0] (the full pathname provided by

Re: [PATCH v5 0/9] block: Add retry for werror=/rerror= mechanism

2021-02-22 Thread Stefan Hajnoczi
On Wed, Feb 10, 2021 at 09:22:38AM +0800, Jiahui Cen wrote: > Kindly ping. > Any comments and reviews are wellcome :) I lost track of this series. Sorry! Feel free to ping me on #qemu IRC (my nick is "stefanha") if I'm not responding to emails. I will review the series now. Stefan signature.a

[Bug 1916394] Re: [git] Cannot build qemu: FAILED: target/hexagon/semantics_generated.pyinc

2021-02-22 Thread Frederic Bezies
Last commit which build is going to its end: https://git.qemu.org/?p=qemu.git;a=commit;h=08895cda3a57fe2d72ef621800606ddc2f5eb612 Will try to see later with hexagon patches to see which one is breaking the build process. Here are the configure options I'm using: --prefix=/usr --sysconfdir=/etc

Re: Editing QEMU POWER Platform wiki page

2021-02-22 Thread Greg Kurz
On Thu, 18 Feb 2021 10:16:25 -0300 Leonardo Augusto Guimarães Garcia wrote: > Hi there, > > I would like to edit the wiki page at [0] as it contains some outdated > information. Could anyone that has access to the wiki please help me > create a user so that I can edit it? > > 0. https://wiki.

Re: [PATCH v2 0/1] css: SCHIB measurement block origin must be aligned

2021-02-22 Thread Cornelia Huck
On Fri, 19 Feb 2021 14:39:32 +0100 Pierre Morel wrote: > Hi, > > By testing Measurement with KVM unit tests I fall on this: > we forgot to test the alignment of the MBO for measurement format 1. > > The last 6 bits of the MBO must be null, i.e. an aligned on 64 bytes > of the MBO, otherwise an

Re: Editing QEMU POWER Platform wiki page

2021-02-22 Thread Cédric Le Goater
On 2/22/21 12:01 PM, Greg Kurz wrote: > On Thu, 18 Feb 2021 10:16:25 -0300 > Leonardo Augusto Guimarães Garcia wrote: > >> Hi there, >> >> I would like to edit the wiki page at [0] as it contains some outdated >> information. Could anyone that has access to the wiki please help me >> create a u

[PATCH] docs/system: Document the removal of "compat" property for POWER CPUs

2021-02-22 Thread Greg Kurz
This is just an oversight. Fixes: f518be3aa35b ("target/ppc: Remove "compat" property of server class POWER CPUs") Cc: gr...@kaod.org Signed-off-by: Greg Kurz --- docs/system/removed-features.rst |6 ++ 1 file changed, 6 insertions(+) diff --git a/docs/system/removed-features.rst b/doc

Re: [PATCH v5 03/11] virtio-mem: Implement RamDiscardMgr interface

2021-02-22 Thread David Hildenbrand
+if (ret) { +/* Could be a mapping attempt resulted in memory getting populated. */ +ret2 = ram_block_discard_range(vmem->memdev->mr.ram_block, offset, + size); +if (ret2) { +error_report("Unexpected error discarding RAM

Re: [PATCH v2 6/6] docs/devel: add forward reference to check-tcg

2021-02-22 Thread Philippe Mathieu-Daudé
On 2/22/21 11:14 AM, Alex Bennée wrote: > For completeness reference the check-tcg tests in the container > preamble text. > > Signed-off-by: Alex Bennée > Cc: Thomas Huth > --- > docs/devel/testing.rst | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] ui/gtk: vte: fix sending multiple characeters

2021-02-22 Thread Gerd Hoffmann
On Sun, Feb 21, 2021 at 10:06:13AM -0700, Zack Marvel wrote: > When using the GTK UI with libvte, multicharacter keystrokes are not > sent correctly (such as arrow keys). gd_vc_in should check the > CharBackend's can_receive instead of assuming multiple characters can be > received. This is not an

Re: [PATCH v2 4/6] docs/devel: expand on use of containers to build tests

2021-02-22 Thread Thomas Huth
On 22/02/2021 11.14, Alex Bennée wrote: Expand on the usage of containers for building tests and why we have some that are not used to build QEMU itself. Signed-off-by: Alex Bennée Cc: Thomas Huth --- docs/devel/testing.rst | 21 ++--- 1 file changed, 14 insertions(+), 7 del

Re: Interactive launch over QMP socket?

2021-02-22 Thread Kevin Wolf
Am 10.02.2021 um 19:01 hat Connor Kuehl geschrieben: > Hello, > > Does QEMU have an internal API which would allow VM construction to wait at > a *very specific point* until specific data/QMP message(s) are supplied via > the QMP socket? > > For some additional context: QEMU supports launching AM

Re: [PATCH v2 5/6] docs/devel: update the container based tests

2021-02-22 Thread Thomas Huth
On 22/02/2021 11.14, Alex Bennée wrote: This section has grown a little stale so clean-up the language and examples for current usage: - refer to containers at the top - mention podman can also be used - add podman prerequisites section - move to using "docker-help" for online help

Re: [PATCH qemu v13] spapr: Implement Open Firmware client interface

2021-02-22 Thread Alexey Kardashevskiy
Ping? I need community support here :) I am hearing that having this mode helps heaps with development in fully emulated environments as this skips SLOF entirely, for example. Another rumour I am hearing is that there is interest in running grub in the userspace which this VOF thing makes han

[PATCH] vhost: simplify vhost_dev_init() fail_busyloop label

2021-02-22 Thread Stefan Hajnoczi
Requiring a conditional for every goto is tedious: if (busyloop_timeout) { goto fail_busyloop; } else { goto fail; } Move the conditional to into the fail_busyloop label so that it's safe to jump to this label unconditionally. This change makes the migrate_add_blocker() error c

Re: [RFC v1 00/38] arm cleanup experiment for kvm-only build

2021-02-22 Thread Philippe Mathieu-Daudé
On 2/22/21 9:43 AM, Claudio Fontana wrote: > On 2/22/21 6:35 AM, Richard Henderson wrote: >> On 2/21/21 1:24 AM, Claudio Fontana wrote: >>> target/arm: move psci.c into tcg/softmmu/ >> >> Terminology: the opposite of user-only is not "softmmu" but "system". >> >> One glorious day in the far futur

[PATCH v6 00/12] virtio-mem: vfio support

2021-02-22 Thread David Hildenbrand
@Paolo, I have acks for most things - what's missing seems to be an ack from you on patch #1. As I want to make use of RamDiscardMgr also to handle virtio-mem+guest-memory-dump/tpm [1] and properly handle all kinds of migration (precopy, background snapshots, postcopy), could you have a look at pat

[PATCH v6 01/12] memory: Introduce RamDiscardMgr for RAM memory regions

2021-02-22 Thread David Hildenbrand
We have some special RAM memory regions (managed by virtio-mem), whereby the guest agreed to only use selected memory ranges. "unused" parts are discarded so they won't consume memory - to logically unplug these memory ranges. Before the VM is allowed to use such logically unplugged memory again, c

[PATCH v6 02/12] virtio-mem: Factor out traversing unplugged ranges

2021-02-22 Thread David Hildenbrand
Let's factor out the core logic, to be reused soon. Reviewed-by: Pankaj Gupta Acked-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin Cc: Paolo Bonzini Cc: "Michael S. Tsirkin" Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Pankaj Gupta Cc: Peter Xu Cc: Auger E

[PATCH v2] iotests: Drop deprecated 'props' from object-add

2021-02-22 Thread Alberto Garcia
Signed-off-by: Alberto Garcia --- v2: Don't use the x-* interface to specify limits [Kevin] tests/qemu-iotests/087 | 8 ++-- tests/qemu-iotests/184 | 18 ++ tests/qemu-iotests/218 | 2 +- tests/qemu-iotests/235 | 2 +- tests/qemu-iotests/245 | 4 ++--

[PATCH v6 06/12] vfio: Query and store the maximum number of possible DMA mappings

2021-02-22 Thread David Hildenbrand
Let's query the maximum number of possible DMA mappings by querying the available mappings when creating the container (before any mappings are created). We'll use this informaton soon to perform some sanity checks and warn the user. Reviewed-by: Alex Williamson Acked-by: Alex Williamson Acked-b

[PATCH v6 03/12] virtio-mem: Don't report errors when ram_block_discard_range() fails

2021-02-22 Thread David Hildenbrand
Any errors are unexpected and ram_block_discard_range() already properly prints errors. Let's stop manually reporting errors. Cc: Paolo Bonzini Cc: "Michael S. Tsirkin" Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Pankaj Gupta Cc: Peter Xu Cc: Auger Eric Cc: Wei Yan

[PATCH v6 05/12] vfio: Support for RamDiscardMgr in the !vIOMMU case

2021-02-22 Thread David Hildenbrand
Implement support for RamDiscardMgr, to prepare for virtio-mem support. Instead of mapping the whole memory section, we only map "populated" parts and update the mapping when notified about discarding/population of memory via the RamDiscardListener. Similarly, when syncing the dirty bitmaps, sync o

[PATCH v6 04/12] virtio-mem: Implement RamDiscardMgr interface

2021-02-22 Thread David Hildenbrand
Let's properly notify when (un)plugging blocks, after discarding memory and before allowing the guest to consume memory. Handle errors from notifiers gracefully (e.g., no remaining VFIO mappings) when plugging, rolling back the change and telling the guest that the VM is busy. One special case to

[PATCH v6 07/12] vfio: Sanity check maximum number of DMA mappings with RamDiscardMgr

2021-02-22 Thread David Hildenbrand
Although RamDiscardMgr can handle running into the maximum number of DMA mappings by propagating errors when creating a DMA mapping, we want to sanity check and warn the user early that there is a theoretical setup issue and that virtio-mem might not be able to provide as much memory towards a VM a

[PATCH v6 12/12] vfio: Disable only uncoordinated discards for VFIO_TYPE1 iommus

2021-02-22 Thread David Hildenbrand
We support coordinated discarding of RAM using the RamDiscardMgr for the VFIO_TYPE1 iommus. Let's unlock support for coordinated discards, keeping uncoordinated discards (e.g., via virtio-balloon) disabled if possible. This unlocks virtio-mem + vfio on x86-64. Note that vfio used via "nvme://" by

  1   2   3   4   5   >