[PATCH 36/44] hw/arm/mps2-tz: Make UART overflow IRQ board-specific

The AN547 puts the combined UART overflow IRQ at 48, not 47 like the other images. Make this setting board-specific. Signed-off-by: Peter Maydell --- hw/arm/mps2-tz.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/arm/mps2-tz.c b/hw/arm/mps2-tz.c index aca8efba6cf..7

[PATCH 30/44] hw/arm/armsse: Add missing SSE-200 SYS_PPU

We forgot to implement a TYPE_UNIMPLEMENTED_DEVICE stub for the SYS_PPU in the SSE-200, which is at 0x50022000. Signed-off-by: Peter Maydell --- include/hw/arm/armsse.h | 2 +- hw/arm/armsse.c | 9 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/include/hw/arm/ar

[PATCH 35/44] hw/arm/armsse: Add SSE-300 support

Now we have sufficiently parameterised the code, we can add SSE-300 support by adding a new entry to the armsse_variants[] array. Note that the main watchdog (unlike the s32k watchdog) in the SSE-300 is a different device from the CMSDK watchdog; we don't have a model of it so we leave it as a TYP

[PULL 07/18] qapi/introspect.py: replace 'extra' dict with 'comment' argument

From: John Snow This is only used to pass in a dictionary with a comment already set, so skip the runaround and just accept the (optional) comment. Signed-off-by: John Snow Message-Id: <20210216021809.134886-8-js...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster -

[PATCH 38/44] hw/misc/mps2-fpgaio: Support AN547 DBGCTRL register

For the AN547 image, the FPGAIO block has an extra DBGCTRL register, which is used to control the SPNIDEN, SPIDEN, NPIDEN and DBGEN inputs to the CPU. These signals control when the CPU permits use of the external debug interface. Our CPU models don't implement the external debug interface, so we

[PATCH 37/44] hw/misc/mps2-fpgaio: Fold counters subsection into main vmstate

We've already broken migration compatibility for all the MPS boards, so we might as well take advantage of this to simplify the vmstate for the FPGAIO device by folding the counters subsection into the main vmstate description. Signed-off-by: Peter Maydell --- hw/misc/mps2-fpgaio.c | 30 +---

[PATCH 43/44] docs/system/arm/mps2.rst: Document the new mps3-an547 board

Add brief documentation of the new mps3-an547 board. Signed-off-by: Peter Maydell --- docs/system/arm/mps2.rst | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/system/arm/mps2.rst b/docs/system/arm/mps2.rst index 601ccea15cb..f83b1517871 100644 --- a/docs/system/arm

[PULL 06/18] qapi/introspect.py: Unify return type of _make_tree()

From: John Snow Returning two different types conditionally can be complicated to type. Return one type for consistency. Signed-off-by: John Snow Message-Id: <20210216021809.134886-7-js...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- scripts/qapi/introspect

[PATCH 40/44] hw/arm/mps2-tz: Support running APB peripherals on different clock

The AN547 runs the APB peripherals outside the SSE-300 on a different and slightly slower clock than it runs the SSE-300 with. Support making the APB peripheral clock frequency board-specific. (For our implementation only the UARTs actually take a clock.) Signed-off-by: Peter Maydell --- hw/ar

[PATCH 41/44] hw/arm/mps2-tz: Make initsvtor0 setting board-specific

The AN547 configures the SSE-300 with a different initsvtor0 setting from its default; make this a board-specific setting. Signed-off-by: Peter Maydell --- hw/arm/mps2-tz.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/arm/mps2-tz.c b/hw/arm/mps2-tz.c index 47215f1b97c..bb72f78fb55

Re: [PATCH 00/18] QAPI patches patches for 2021-02-18

Subject wrong, will resend.

[PULL 04/18] qapi/introspect.py: add _gen_features helper

From: John Snow _make_tree might receive a dict (a SchemaInfo object) or some other type (usually, a string) for its obj parameter. Adding features information should arguably be performed by the caller at such a time when we know the type of the object and don't have to re-interrogate it. Signe

Re: [PATCH 0/2] SEV firmware error list touchups

On 2/18/21 9:48 AM, Philippe Mathieu-Daudé wrote: On 2/18/21 4:16 PM, Connor Kuehl wrote: Connor Kuehl (2): sev: use explicit indices for mapping firmware error codes to strings sev: add missing firmware error conditions target/i386/sev.c | 48 ---

[PATCH 42/44] hw/arm/mps2-tz: Add new mps3-an547 board

Add support for the mps3-an547 board; this is an SSE-300 based FPGA image that runs on the MPS3. Signed-off-by: Peter Maydell --- hw/arm/mps2-tz.c | 146 ++- 1 file changed, 144 insertions(+), 2 deletions(-) diff --git a/hw/arm/mps2-tz.c b/hw/arm/mps2

[PULL 02/18] qapi/introspect.py: assert schema is not None

From: John Snow The introspect visitor is stateful, but expects that it will have a schema to refer to. Add assertions that state this. Signed-off-by: John Snow Message-Id: <20210216021809.134886-3-js...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- scripts/

[PULL 12/18] qapi/introspect.py: improve readability of _tree_to_qlit

From: John Snow Subjective, but I find getting rid of the comprehensions helps. Also, divide the sections into scalar and non-scalar sections, and remove old-style string formatting. Signed-off-by: John Snow Message-Id: <20210216021809.134886-13-js...@redhat.com> Reviewed-by: Markus Armbruster

[PULL 11/18] qapi/introspect.py: improve _tree_to_qlit error message

From: John Snow Trivial; make the error message just a pinch more explicit in case we trip this by accident in the future. Signed-off-by: John Snow Message-Id: <20210216021809.134886-12-js...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- scripts/qapi/introsp

[PATCH 44/44] tests/qtest/sse-timer-test: Add simple tests of the SSE timer and counter

Add a simple qtest to exercise the new system counter and system timer device in the SSE-300. Signed-off-by: Peter Maydell --- tests/qtest/sse-timer-test.c | 240 +++ MAINTAINERS | 1 + tests/qtest/meson.build | 1 + 3 files changed, 242

[PULL 01/18] qapi: Replace List[str] with Sequence[str] for ifcond

From: John Snow It does happen to be a list (as of now), but we can describe it in more general terms with no loss in accuracy to allow tuples and other constructs. In the future, we can write "ifcond: Sequence[str] = ()" as a default parameter, which we could not do safely with a Mutable type l

[PULL 13/18] qapi/introspect.py: remove _gen_variants helper

From: John Snow It is easier to give a name to all of the dictly-typed objects we pass around in introspect.py by removing this helper, as it does not return an object that has any knowable type by itself. Inline it into its only caller instead. Signed-off-by: John Snow Message-Id: <2021021602

[PULL 05/18] qapi/introspect.py: guard against ifcond/comment misuse

From: John Snow _tree_to_qlit is called recursively on dict values (isolated from their keys); at such a point in generating output it is too late to apply an ifcond. Similarly, comments do not necessarily have a "tidy" place they can be printed in such a circumstance. Forbid this usage by renam

[PULL 09/18] qapi/introspect.py: Introduce preliminary tree typing

From: John Snow The types will be used in forthcoming patches to add typing. These types describe the layout and structure of the objects passed to _tree_to_qlit, but lack the power to describe annotations until the next commit. Signed-off-by: John Snow Message-Id: <20210216021809.134886-10-js.

[PULL 00/18] QAPI patches patches for 2021-02-18

The following changes since commit 91416a4254015e1e3f602f2b241b9ddb7879c10b: Merge remote-tracking branch 'remotes/stsquad/tags/pull-plugin-updates-180221-1' into staging (2021-02-18 13:27:03 +) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-202

[PULL 15/18] qapi/introspect.py: Add docstrings to _gen_tree and _tree_to_qlit

From: John Snow Signed-off-by: John Snow Message-Id: <20210216021809.134886-16-js...@redhat.com> Reviewed-by: Markus Armbruster [Doc string improvements squashed in] Signed-off-by: Markus Armbruster --- scripts/qapi/introspect.py | 20 1 file changed, 20 insertions(+) di

[PATCH 2/3] backup-top: Refuse I/O in inactive state

When the backup-top node transitions from active to inactive in bdrv_backup_top_drop(), the BlockCopyState is freed and the filtered child is removed, so the node effectively becomes unusable. However, noone told its I/O functions this, so they will happily continue accessing bs->backing and s->bc

[PULL 14/18] qapi/introspect.py: add type hint annotations

From: John Snow NB: The type aliases (SchemaInfo et al) declare intent for some of the "dictly-typed" objects we pass around in introspect.py. They do not enforce the shape of those objects, and cannot, until Python 3.7 or later. (And even then, it may not be "worth it".) Annotations are also ad

[PULL 18/18] qapi/introspect.py: set _gen_tree's default ifcond argument to ()

From: John Snow We don't need to create an empty, mutable list to pass to _gen_tree; since it is now typed as a Sequence, we can use the empty tuple as a default and omit the argument. Signed-off-by: John Snow Message-Id: <20210216021809.134886-19-js...@redhat.com> Reviewed-by: Markus Armbruste

[PULL 10/18] qapi/introspect.py: create a typed 'Annotated' data strutcure

From: John Snow Presently, we use a tuple to attach a dict containing annotations (comments and compile-time conditionals) to a tree node. This is undesirable because dicts are difficult to strongly type; promoting it to a real class allows us to name the values and types of the annotations we ar

[PULL 08/18] qapi/introspect.py: Always define all 'extra' dict keys

From: John Snow This mimics how a typed object works, where 'if' and 'comment' are always set, regardless of if they have a value set or not. It is safe to do this because of the way that _tree_to_qlit processes these values (using dict.get with a default of None), resulting in no change of outp

[PULL 03/18] qapi/introspect.py: use _make_tree for features nodes

From: John Snow At present, we open-code this in _make_tree itself; but if the structure of the tree changes, this is brittle. Use an explicit recursive call to _make_tree when appropriate to help keep the interior node typing consistent. A consequence of doing this is that the 'ifcond' key of t

[PATCH v2 0/4] hw/riscv: Clean-ups and map high mmio for PCIe of 'virt' machine

From: Bin Meng This series does the following clean-ups: - Drop 'struct MemmapEntry' - virt: Drop the 'link_up' parameter of gpex_pcie_init() It also adds the following small enhancement to 'virt' machine: - Limit RAM size in a 32-bit system - Map high mmio for PCIe Changes in v2: - Use a #if s

[PULL 16/18] qapi/introspect.py: Update copyright and authors list

From: John Snow To reflect the work that went into strictly typing introspect.py, punish myself by claiming credit. Signed-off-by: John Snow Message-Id: <20210216021809.134886-17-js...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- scripts/qapi/introspect.py

Re: [PULL 0/3] Machine and x86 queue, 2021-02-18

On Thu, 18 Feb 2021 at 23:38, Eduardo Habkost wrote: > > On Thu, Feb 18, 2021 at 06:24:12PM -0500, Eduardo Habkost wrote: > > I'm hugely behind in backlog of qemu-devel messages and patches > > to queue/review (my apologies to all waiting for something from > > me). I'm flushing the few patches I

Re: [PATCH] ui/cocoa: Do not exit immediately after shutdown

> Gerd: I notice that the only ui frontends that try to do this > SHUTDOWN_CAUSE_HOST_UI thing are the Cocoa UI and the SDL2 UI. > The GTK UI does > qmp_quit() > instead; the SDL2 UI does > shutdown_action = SHUTDOWN_ACTION_POWEROFF; > qemu_system_shutdown_request(SHUTDOWN_C

Re: FreeBSD build regressions

On Fri, Feb 19, 2021, 3:59 AM Alex Bennée wrote: > > Peter Maydell writes: > > > On Fri, 19 Feb 2021 at 10:39, Alex Bennée > wrote: > >> > >> > >> Hi, > >> > >> It looks like the build has been broken on Cirrus since at least 7b2c4c: > >> > >> https://cirrus-ci.com/github/qemu/qemu > >> > >>

Re: FreeBSD build regressions

On Fri, Feb 19, 2021 at 10:41:44AM +, Peter Maydell wrote: > On Fri, 19 Feb 2021 at 10:39, Alex Bennée wrote: > > > > > > Hi, > > > > It looks like the build has been broken on Cirrus since at least 7b2c4c: > > > > https://cirrus-ci.com/github/qemu/qemu > > > > I did attempt to have a look b

[PATCH v2 2/4] hw/riscv: virt: Drop the 'link_up' parameter of gpex_pcie_init()

From: Bin Meng `link_up` is never used in gpex_pcie_init(). Drop it. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis --- (no changes since v1) hw/riscv/virt.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index cfd

[PATCH 2/2] target/riscv: Call check_access() before tcg_temp_new()

--- target/riscv/insn_trans/trans_rvh.c.inc | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvh.c.inc b/target/riscv/insn_trans/trans_rvh.c.inc index 203a620723..b0a9ea1dca 100644 --- a/target/riscv/insn_trans/trans_rvh.c.inc +++ b/t

[PATCH 1/3] backup: Remove nodes from job in .clean()

The block job holds a reference to the backup-top node (because it is passed as the main job BDS to block_job_create()). Therefore, bdrv_backup_top_drop() cannot delete the backup-top node (replacing it by its child does not affect the job parent, because that has .stay_at_node set). That is a pr

[PATCH v2 1/4] hw/riscv: Drop 'struct MemmapEntry'

From: Bin Meng There is already a MemMapEntry type defined in hwaddr.h. Let's drop the RISC-V defined `struct MemmapEntry` and use the existing one. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé --- (no changes since v1) hw/riscv/microchip_pfsoc.

Re: [PATCH] tests/acceptance: linux-related tests fix

On Fri, Feb 19, 2021 at 8:07 AM Pavel Dovgalyuk wrote: > > This patch allows cloudinit images download when ssh > key is not specified. > > Signed-off-by: Pavel Dovgalyuk > --- > tests/acceptance/avocado_qemu/__init__.py |6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > Reviewe

[PATCH 0/3] backup-top: Don't crash on post-finalize accesses

Hi, After job-finalize, the backup-top node generally stays around. That’s quite a problem, because its BlockCopyState is already freed then, and it has no filtered child. We really want the node to be gone. The only reference that realistically can keep it alive is that of the backup job (thou

[PATCH 1/2] target/riscv: Reduce duplicated code in trans_rvh.c.inc

I rencently merged CHERI QEMU up to 5.2, and we have to modify all functions that perform memory accesses. Factoring these almost-indentical functions into two shared helpers makes our changes a lot smaller and should also make this code easier to maintain. --- target/riscv/insn_trans/trans_rvh.c.

Re: [PATCH 2/7] hw/boards: Introduce 'kvm_supported' field to MachineClass

On Fri, Feb 19, 2021 at 12:08:05 +, Peter Maydell wrote: > On Fri, 19 Feb 2021 at 11:58, Daniel P. Berrangé wrote: > > Is the behaviour reported really related to KVM specifically, as opposed > > to all hardware based virt backends ? > > > > eg is it actually a case of some machine types being

[PATCH 3/3] iotests/283: Check that finalize drops backup-top

Without any of HEAD^ or HEAD^^ applied, qemu will most likely crash on the qemu-io invocation, for a variety of immediate reasons. The underlying problem is generally a use-after-free access into backup-top's BlockCopyState. With only HEAD^ applied, qemu-io will run into an EIO (which is not capt

Re: [PATCH v1 6/6] tests/acceptance: allow a "graceful" failing for virtio-gpu test

On Wed, Feb 17, 2021 at 9:21 AM Alex Bennée wrote: > > This is a band-aid with a TODO for cases when QEMU doesn't start due > to missing VirGL. Longer term we could do with some proper feature > probing. > > Signed-off-by: Alex Bennée > Cc: Marc-André Lureau > --- > tests/acceptance/virtio-gpu.

[PATCH v2 3/4] hw/riscv: virt: Limit RAM size in a 32-bit system

From: Bin Meng RV32 supports 34-bit physical address hence the maximum RAM size should be limitted. Limit the RAM size to 10 GiB, which leaves some room for PCIe high mmio space. For 32-bit host, this is not needed as machine->ram_size cannot represent a RAM size that big. Use a #if size test to

Re: meson, NEED_CPU_H, CONFIG_TCG and tests/

On 19/02/21 14:30, Thomas Huth wrote: But how could tests see this? The test are generic, not target-specific code, so they can not see things like NEED_CPU_H, of course. But CONFIG_TCG seems to be defined in config-host.h, so you should be able to use that define, shouldn't you? Yes, CON

[PATCH v2 4/4] hw/riscv: virt: Map high mmio for PCIe

From: Bin Meng Some peripherals require 64-bit PCI address, so let's map the high mmio space for PCIe. For RV32, the address is hardcoded to below 4 GiB from the highest accessible physical address. For RV64, the base address depends on top of RAM and is aligned to its size which is using 16 GiB

Re: [PATCH 00/44] hw/arm: New board model mps3-an547

Patchew URL: https://patchew.org/QEMU/20210219144617.4782-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210219144617.4782-1-peter.mayd...@linaro.org Subject: [PATCH 00/44] hw/arm: New boa

Re: FreeBSD build regressions

First off, sorry for the hassles this caused... The problem is a failure to upgrade for reasons explained below... While the reasons make sense, it's still a bit of a hassle, for which I apologize. On Fri, Feb 19, 2021 at 8:51 AM Gerd Hoffmann wrote: > On Fri, Feb 19, 2021 at 10:41:44AM +, P

Re: [PATCH v2 0/3] virtiofsd: Add options to enable/disable posix acl

On Fri, Feb 19, 2021 at 3:34 PM Vivek Goyal wrote: > > On Fri, Feb 19, 2021 at 11:50:54AM +, Luis Henriques wrote: > > Vivek Goyal writes: > > > > > Hi, > > > > > > This is V2 of the patches. Changes since v1 are. > > > > > > - Rebased on top of latest master. > > > - Took care of Miklos's co

Can not set high msize with virtio-9p (Was: Re: virtiofs vs 9p performance)

On Fri, Sep 25, 2020 at 10:06:41AM +0200, Christian Schoenebeck wrote: > On Freitag, 25. September 2020 00:10:23 CEST Vivek Goyal wrote: > > In my testing, with cache=none, virtiofs performed better than 9p in > > all the fio jobs I was running. For the case of cache=auto for virtiofs > > (with xa

Re: [PATCH 3/3] iotests/283: Check that finalize drops backup-top

On 19.02.21 16:33, Max Reitz wrote: Without any of HEAD^ or HEAD^^ applied, qemu will most likely crash on the qemu-io invocation, for a variety of immediate reasons. The underlying problem is generally a use-after-free access into backup-top's BlockCopyState. With only HEAD^ applied, qemu-io w

Re: [PATCH] target/riscv: fix TB_FLAGS bits overlapping bug for rvv/rvh

On 2/19/21 1:59 AM, frank.ch...@sifive.com wrote: > +/* Skip mem_idx bits */ > +FIELD(TB_FLAGS, VL_EQ_VLMAX, 3, 1) Why not just add the mem_idx field to the list? The separation between the FIELDs and TB_FLAG_*_MASK is unfortunate, and will be a continuing source of errors. r~

[PATCH] nbd: server: Report holes for raw images

When querying image extents for raw image, qemu-nbd reports holes as zero: $ qemu-nbd -t -r -f raw empty-6g.raw $ qemu-img map --output json nbd://localhost [{ "start": 0, "length": 6442450944, "depth": 0, "zero": true, "data": true, "offset": 0}] $ qemu-img map --output json empty-6g.raw [{ "s

Re: [PULL 00/19] riscv-to-apply queue

On Fri, Feb 19, 2021 at 02:31:20PM +0100, Philippe Mathieu-Daudé wrote: > Hi Peter, > > [+John/Richards/Paolo/Gueunter] > > On 2/18/21 3:22 PM, Peter Maydell wrote: > > On Thu, 18 Feb 2021 at 14:07, Bin Meng wrote: > >> On Thu, Feb 18, 2021 at 9:26 PM Peter Maydell > >> wrote: > >>> Fails to c

Re: [PATCH v2 0/3] virtiofsd: Add options to enable/disable posix acl

Miklos Szeredi writes: > On Fri, Feb 19, 2021 at 3:34 PM Vivek Goyal wrote: >> >> On Fri, Feb 19, 2021 at 11:50:54AM +, Luis Henriques wrote: >> > Vivek Goyal writes: >> > >> > > Hi, >> > > >> > > This is V2 of the patches. Changes since v1 are. >> > > >> > > - Rebased on top of latest mast

Re: FreeBSD build regressions

On Fri, 19 Feb 2021 at 16:08, Warner Losh wrote: > FreeBSD builds packages on the oldest supported version in the stable branch. > Due to forward compatibility, that means all supported versions of FreeBSD > 12.x will work. Recently, FreeBSD 12.1 became unsupported, so the build > machines clic

who's using the ozlabs patchwork install for QEMU patches ?

Does anybody use the ozlabs patchwork install for QEMU patches, either occasionally or on a regular basis ? http://patchwork.ozlabs.org/project/qemu-devel/list/ The admins for that system are trying to identify which of the various projects are really using their patchwork instances, so I figured I

RE: [PULL v2 00/35] hexagon initial commit

I requested access to scan.coverity.com. Once it is granted, I'll take a look. Thanks, Taylor > -Original Message- > From: Peter Maydell > Sent: Friday, February 19, 2021 4:52 AM > To: Richard Henderson > Cc: QEMU Developers ; Taylor Simpson > > Subject: Re: [PULL v2 00/35] hexagon i

[Bug 1916112] Re: Illegal instruction crash of QEMU on Jetson Nano

Can you use gdb to display what the instruction that provoked the SIGILL is ? ("disas $pc-32,$pc+32" or similar should do it). Re "Why is TCG used as the accelerator when KVM is present?", the answer is that only certain board types and CPU types work with KVM. The simple answer is "only the 'virt

Re: [PATCH] nbd: server: Report holes for raw images

On 2/19/21 10:07 AM, Nir Soffer wrote: > When querying image extents for raw image, qemu-nbd reports holes as > zero: > > $ qemu-nbd -t -r -f raw empty-6g.raw > > $ qemu-img map --output json nbd://localhost > [{ "start": 0, "length": 6442450944, "depth": 0, "zero": true, "data": true, > "offset

Re: who's using the ozlabs patchwork install for QEMU patches ?

On 19/02/2021 17.26, Peter Maydell wrote: Does anybody use the ozlabs patchwork install for QEMU patches, either occasionally or on a regular basis ? http://patchwork.ozlabs.org/project/qemu-devel/list/ The admins for that system are trying to identify which of the various projects are really usi

Re: [PULL v2 00/35] hexagon initial commit

On 2/19/21 8:30 AM, Taylor Simpson wrote: > I requested access to scan.coverity.com. Once it is granted, I'll take a > look. I took a quick look. Quite a lot of the errors are related to > #define fASHIFTL(SRC, SHAMT, REGSTYPE) \ > (((SHAMT) >= 64) ? 0 : (fCAST##REGSTYPE##s(SRC) << (SHAMT)

Re: [PATCH] nbd: server: Report holes for raw images

On 2/19/21 10:42 AM, Eric Blake wrote: >> To me, data=false looks compatible with NBD_STATE_HOLE. From user point >> of view, getting same results from qemu-nbd and qemu-img is more >> important than being more correct about allocation status. > > More to the point, here is our inconsistency: >

RE: [PATCH] exec: Poison Hexagon target-specific definitions

> -Original Message- > From: Philippe Mathieu-Daudé On > Behalf Of Philippe Mathieu-Daudé > Sent: Friday, February 19, 2021 7:58 AM > To: qemu-devel@nongnu.org; Richard Henderson > > Cc: Taylor Simpson ; Philippe Mathieu-Daudé > > Subject: [PATCH] exec: Poison Hexagon target-specific d

[Bug 1914535] Re: PL110 8-bit mode is not emulated correctly

Lucky I looked at your screenshot, as half the repro instructions are only given in that! When the guest gets to a shell prompt, one needs to type: # fbset -depth 8 # fbset # dd if=/dev/urandom of=/dev/fb0 -- You received this bug notification because you are a member of qemu- devel-ml, which i

Re: [PATCH] virtio-ccw: commands on revision-less devices

On Fri, 19 Feb 2021 12:21:36 +0100 Cornelia Huck wrote: > On Tue, 16 Feb 2021 12:18:30 +0100 > Cornelia Huck wrote: > > > The virtio standard specifies that any non-transitional device must > > reject commands prior to revision setting (which we do) and else > > assume revision 0 (legacy) if th

Re: [PATCH v4] target/cris: Plug leakage of TCG temporaries

+ Richard (Since he had comments on v1) On Fri, 19 Feb 2021, 13:44 Stefan Sandström, wrote: > From: Stefan Sandstrom > > Add and fix deallocation of temporary TCG registers in CRIS code > generation. > > Tested-by: Edgar E. Iglesias > Reviewed-by: Edgar E. Iglesias > Change-Id: I17fce5d95bdc4

vhost reply_ack negotiation (a.k.a differences in vhost-user behaviour with libvhost-user and vhost-user-backend.rs)

Hi, I finally got a chance to get down into the guts of vhost-user while attempting to port my original C RPMB daemon to Rust using the vhost-user-backend and related crates. I ended up with this hang during negotiation: startup vhost_user_write req:1 flags:0x1 vhost_user_read_start vhos

[Bug 1916269] [NEW] TCG: QEMU raises exception on SSE4.2 CRC32 instruction in kernel

Public bug reported: If I run FreeBSD on QEMU 5.2 with TCG acceleration -cpu Nehalem, I get a FPU exception when executing crc32 (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253617). This is not a problem with the default CPU (or KVM) since that does not support SSE 4.2. Attaching GDB shows

Re: [PULL 00/10] gitlab and qtest patches

On Fri, 19 Feb 2021 at 07:57, Thomas Huth wrote: > > Hi Peter! > > The following changes since commit c79f01c9450bcf90c08a77f13fbf67bdba59a316: > > Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-hex-20210218' > into staging (2021-02-18 16:33:36 +) > > are available in the Git r

Re: meson, NEED_CPU_H, CONFIG_TCG and tests/

On 2/19/21 5:04 PM, Paolo Bonzini wrote: > On 19/02/21 14:30, Thomas Huth wrote: >>> But how could tests see this? >> >> The test are generic, not target-specific code, so they can not see >> things like NEED_CPU_H, of course. >> >> But CONFIG_TCG seems to be defined in config-host.h, so you shoul

[Bug 1914535] Re: PL110 8-bit mode is not emulated correctly

So, were you able to reproduce it? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1914535 Title: PL110 8-bit mode is not emulated correctly Status in QEMU: New Bug description: When the emulat

[Bug 1914535] Re: PL110 8-bit mode is not emulated correctly

Anyway, on first investigation I'm not sure what QEMU's pl11x model is doing wrong. The 8-bit mode is a palette-based setup, where the guest must program in the RGB values it wants to use into the palatte registers as RGB555 data: https://developer.arm.com/documentation/ddi0293/c/programmer-s-m

Re: Can not set high msize with virtio-9p (Was: Re: virtiofs vs 9p performance)

On Freitag, 19. Februar 2021 17:08:48 CET Vivek Goyal wrote: > On Fri, Sep 25, 2020 at 10:06:41AM +0200, Christian Schoenebeck wrote: > > On Freitag, 25. September 2020 00:10:23 CEST Vivek Goyal wrote: > > > In my testing, with cache=none, virtiofs performed better than 9p in > > > all the fio jobs

Re: [PATCH 0/7] hw/kvm: Exit gracefully when KVM is not supported

On 2/19/21 1:34 PM, Claudio Fontana wrote: > On 2/19/21 12:44 PM, Philippe Mathieu-Daudé wrote: >> Hi, >> >> This series aims to improve user experience by providing >> a better error message when the user tries to enable KVM >> on machines not supporting it. >> >> Regards, >> >> Phil. > > Hi Phil

[PATCH v2 00/11] hw/accel: Exit gracefully when accelerator is invalid

Hi, This series aims to improve user experience by providing a better error message when the user tries to enable KVM on machines not supporting it. Since v1: - added missing x86 arch (Peter) - consider all accelerators (Daniel and Peter) - do not enable KVM on sbsa-ref (Leif) - updated 'query-ma

[PATCH v2 01/11] accel/kvm: Check MachineClass kvm_type() return value

MachineClass::kvm_type() can return -1 on failure. Document it, and add a check in kvm_init(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/boards.h | 3 ++- accel/kvm/kvm-all.c | 6 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/include/hw/boards.h b/include/hw/boa

[PATCH v2 05/11] hw/mips: Restrict KVM to the malta & virt machines

Restrit KVM to the following MIPS machines: - malta - loongson3-virt Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/loongson3_virt.c | 5 + hw/mips/malta.c | 5 + 2 files changed, 10 insertions(+) diff --git a/hw/mips/loongson3_virt.c b/hw/mips/loongson3_virt.c index d4a82fa

[PATCH v2 03/11] hw/core: Restrict 'query-machines' to those supported by current accel

Do not let 'query-machines' return machines not valid with the current accelerator. Suggested-by: Daniel Berrangé Signed-off-by: Philippe Mathieu-Daudé --- hw/core/machine-qmp-cmds.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c

[PATCH v2 02/11] hw/boards: Introduce machine_class_valid_for_accelerator()

Introduce the valid_accelerators[] field to express the list of valid accelators a machine can use, and add the machine_class_valid_for_current_accelerator() and machine_class_valid_for_accelerator() methods. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/boards.h | 24

[RFC PATCH v2 06/11] hw/ppc: Restrict KVM to various PPC machines

Restrit KVM to the following PPC machines: - 40p - bamboo - g3beige - mac99 - mpc8544ds - ppce500 - pseries - sam460ex - virtex-ml507 Signed-off-by: Philippe Mathieu-Daudé --- RFC: I'm surprise by this list, but this is the result of auditing calls to kvm_enabled() checks. hw/ppc/e500plat.

[PATCH v2 04/11] hw/arm: Restrit KVM to the virt & versal machines

Restrit KVM to the following ARM machines: - virt - xlnx-versal-virt Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/virt.c | 5 + hw/arm/xlnx-versal-virt.c | 5 + 2 files changed, 10 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 371147f3ae9..8e9861b61a9 10

[PATCH v2 07/11] hw/s390x: Explicit the s390-ccw-virtio machines support TCG and KVM

All s390-ccw-virtio machines support TCG and KVM. Signed-off-by: Philippe Mathieu-Daudé --- hw/s390x/s390-virtio-ccw.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 2972b607f36..1f168485066 100644 --- a/hw/s390x/s390-virtio

[PATCH v2 09/11] hw/xenpv: Restrict Xen Para-virtualized machine to Xen accelerator

When started with other accelerator than Xen, the XenPV machine fails with a criptic message: $ qemu-system-x86_64 -M xenpv,accel=kvm xen be core: can't connect to xenstored qemu-system-x86_64: xen_init_pv: xen backend core setup failed By restricting it to Xen, we display a clearer error m

[RFC PATCH v2 08/11] hw/i386: Explicit x86 machines support all current accelerators

x86 machines currently support all accelerators. Signed-off-by: Philippe Mathieu-Daudé --- RFC: not sure about this, x86 is not my cup of tea hw/i386/x86.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/i386/x86.c b/hw/i386/x86.c index 6329f90ef90..2dc10e7d386 100644 --- a/hw/i386/

[PATCH v2 11/11] softmmu/vl: Exit gracefully when accelerator is not supported

Before configuring an accelerator, check it is valid for the current machine. Doing so we can return a simple error message instead of criptic one. Before: $ qemu-system-arm -M raspi2b -enable-kvm qemu-system-arm: /build/qemu-ETIdrs/qemu-4.2/exec.c:865: cpu_address_space_init: Assertion `asi

[PATCH v2 10/11] hw/board: Only allow TCG accelerator by default

By default machines can only use the TCG and QTest accelerators. If a machine can use another accelerator, it has to explicitly list it in its MachineClass valid_accelerators[]. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/boards.h | 4 ++-- hw/core/machine.c | 8 2 files cha

Re: [PATCH 0/2] SEV firmware error list touchups

On 2/19/21 3:46 PM, Connor Kuehl wrote: > On 2/18/21 9:48 AM, Philippe Mathieu-Daudé wrote: >> On 2/18/21 4:16 PM, Connor Kuehl wrote: >>> Connor Kuehl (2): >>>    sev: use explicit indices for mapping firmware error codes to strings >>>    sev: add missing firmware error conditions >>> >>>   targe

[PATCH] target/i386/sev: Ensure sev_fw_errlist is sync with update-linux-headers

Ensure sev_fw_errlist[] is updated after running the update-linux-headers.sh script. Signed-off-by: Philippe Mathieu-Daudé --- Based-on: <20210218151633.215374-1-cku...@redhat.com> --- target/i386/sev.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/target/i386/sev.c b/t

Re: who's using the ozlabs patchwork install for QEMU patches ?

On Fri, 19 Feb 2021, Peter Maydell wrote: Does anybody use the ozlabs patchwork install for QEMU patches, either occasionally or on a regular basis ? http://patchwork.ozlabs.org/project/qemu-devel/list/ The admins for that system are trying to identify which of the various projects are really usi

Re: [PATCH v2 09/11] hw/xenpv: Restrict Xen Para-virtualized machine to Xen accelerator

On 19/02/2021 17:38, Philippe Mathieu-Daudé wrote: When started with other accelerator than Xen, the XenPV machine fails with a criptic message: $ qemu-system-x86_64 -M xenpv,accel=kvm xen be core: can't connect to xenstored qemu-system-x86_64: xen_init_pv: xen backend core setup failed

Re: [PATCH 0/2] Allwinner H3 fixes for EMAC and acceptance tests

Hi Niek, On 2/17/21 9:57 PM, Niek Linnenbank wrote: > Hi Daniel, Philippe, > > Op di 16 feb. 2021 10:49 schreef Daniel P. Berrangé >: > > On Fri, Feb 12, 2021 at 03:10:00PM +0100, Philippe Mathieu-Daudé wrote: > > Hi Niek and QEMU community, > > > > O

Re: who's using the ozlabs patchwork install for QEMU patches ?

On 2/19/21 7:07 PM, BALATON Zoltan wrote: > On Fri, 19 Feb 2021, Peter Maydell wrote: >> Does anybody use the ozlabs patchwork install for QEMU patches, >> either occasionally or on a regular basis ? >> http://patchwork.ozlabs.org/project/qemu-devel/list/ >> The admins for that system are trying to

Re: FreeBSD build regressions

On Fri, Feb 19, 2021 at 9:14 AM Peter Maydell wrote: > On Fri, 19 Feb 2021 at 16:08, Warner Losh wrote: > > FreeBSD builds packages on the oldest supported version in the stable > branch. Due to forward compatibility, that means all supported versions of > FreeBSD 12.x will work. Recently, FreeB

link to User documentation of https://wiki.qemu.org/Features/Tracing is broken currently

Hi all, the link to User documentation of https://wiki.qemu.org/Features/Tracing is broken currently: it points to: http://git.qemu-project.org/?p=qemu.git;a=blob_plain;f=docs/devel/tracing.txt;hb=HEAD and that to me gives a 404 - Cannot find file. Ciao, Claudio -- Claudio Fontana Engineer

[PATCH 1/4] ui: introduce "password-secret" option for VNC servers

Currently when using VNC the "password" flag turns on password based authentication. The actual password has to be provided separately via the monitor. This introduces a "password-secret" option which lets the password be provided up front. $QEMU --object secret,id=vncsec0,file=passwd.txt \

[PATCH 3/4] ui: deprecate "password" option for SPICE server

With the new "password-secret" option, there is no reason to use the old inecure "password" option with -spice, so it can be deprecated. Signed-off-by: Daniel P. Berrangé --- docs/system/deprecated.rst | 8 qemu-options.hx| 4 ui/spice-core.c| 4 3 file

<    1   2   3   4   >