Re: [PATCH RFC v3 08/12] hw/block/nvme: end-to-end data protection

2021-02-17 Thread Klaus Jensen
On Feb 16 15:08, Keith Busch wrote: > On Mon, Feb 15, 2021 at 12:02:36AM +0100, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Add support for namespaces formatted with protection information. The > > type of end-to-end data protection (i.e. Type 1, Type 2 or Type 3) is > > selected with the

[PATCH] util: fix use-after-free in module_load_one

2021-02-17 Thread marcandre . lureau
From: Marc-André Lureau Spotted by ASAN: ==2407186==ERROR: AddressSanitizer: heap-use-after-free on address 0x6020003ac4f0 at pc 0x7766659c bp 0x7fffd1d0 sp 0x7fffc980 READ of size 1 at 0x6020003ac4f0 thread T0 #0 0x7766659b (/lib64/libasan.so.6+0x8a59b) #1 0x76bfa8

[Bug 1816189] Re: Unable to create or revert snapshots

2021-02-17 Thread Thomas Huth
Can you still reproduce this issue with the latest version of QEMU and libvirt? Anyway, since the problem occurs with libvirt, have you already tried to report this issue to the libvirt project instead? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification be

Re: [PATCH RFC v3 12/12] hw/block/nvme: add support for the format nvm command

2021-02-17 Thread Klaus Jensen
On Feb 16 15:16, Keith Busch wrote: > On Mon, Feb 15, 2021 at 12:02:40AM +0100, Klaus Jensen wrote: > > From: Minwoo Im > > > > Format NVM admin command can make a namespace or namespaces to be > > with different LBA size and metadata size with protection information > > types. > > > > This patc

Re: [PATCH v2 20/20] tests: add some virtio-gpu & vhost-user-gpu acceptance test

2021-02-17 Thread Marc-André Lureau
Hi On Tue, Feb 16, 2021 at 9:43 PM Cleber Rosa wrote: > On Tue, Feb 16, 2021 at 04:34:06PM +, Alex Bennée wrote: > > > > marcandre.lur...@redhat.com writes: > > > > > From: Marc-André Lureau > > > > > > This will check virtio/vhost-user-vga & virgl are correctly initialized > > > by the Lin

Re: [PATCH 1/3] virtiofsd: Add an option to enable/disable posix acls

2021-02-17 Thread Miklos Szeredi
On Wed, Feb 17, 2021 at 12:36 AM Vivek Goyal wrote: > > fuse has an option FUSE_POSIX_ACL which needs to be opted in by fuse > server to enable posix acls. > > Add virtiofsd option "-o posix_acl/no_posix_acl" to let users enable/disable > posix acl support. By default it is disabled as of now. If

Re: [PATCH RFC v3 09/12] hw/block/nvme: add verify command

2021-02-17 Thread Klaus Jensen
On Feb 16 15:12, Keith Busch wrote: > On Mon, Feb 15, 2021 at 12:02:37AM +0100, Klaus Jensen wrote: > > From: Gollu Appalanaidu > > > > See NVM Express 1.4, section 6.14 ("Verify Command"). > > > > Signed-off-by: Gollu Appalanaidu > > [k.jensen: rebased, refactored for e2e] > > Signed-off-by: K

Re: [PATCH RFC v3 00/12] hw/block/nvme: metadata and end-to-end data protection support

2021-02-17 Thread Klaus Jensen
On Feb 16 16:19, Keith Busch wrote: > On Mon, Feb 15, 2021 at 12:02:28AM +0100, Klaus Jensen wrote: > > From: Klaus Jensen > > > > This is RFC v3 of a series that adds support for metadata and end-to-end > > data > > protection. > > > > First, on the subject of metadata, in v1, support was rest

Re: [PATCH v6 14/19] qapi/introspect.py: add type hint annotations

2021-02-17 Thread Markus Armbruster
John Snow writes: > On 2/16/21 11:08 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 2/16/21 3:55 AM, Markus Armbruster wrote: John Snow writes: [...] > diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py > index 353e8020a27..ff16578f6de 100644 > --- a/scr

Re: [PATCH RFC v3 12/12] hw/block/nvme: add support for the format nvm command

2021-02-17 Thread Klaus Jensen
On Feb 17 09:26, Klaus Jensen wrote: > On Feb 16 15:16, Keith Busch wrote: > > On Mon, Feb 15, 2021 at 12:02:40AM +0100, Klaus Jensen wrote: > > > From: Minwoo Im > > > > > > Format NVM admin command can make a namespace or namespaces to be > > > with different LBA size and metadata size with pro

Re: [PATCH v6 15/19] qapi/introspect.py: Add docstrings to _gen_tree and _tree_to_qlit

2021-02-17 Thread Markus Armbruster
John Snow writes: > Signed-off-by: John Snow > --- > scripts/qapi/introspect.py | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/scripts/qapi/introspect.py b/scripts/qapi/introspect.py > index 45284af1330..5d4f5e23f7e 100644 > --- a/scripts/qapi/introspect.py > +++ b

Re: [PATCH] fuzz-test: remove unneccessary debugging flags

2021-02-17 Thread Philippe Mathieu-Daudé
On 2/16/21 7:13 PM, Alexander Bulekov wrote: > These flags cause the output to look strange for 'make check', and > they aren't needed to reproduce bugs, if they reappear. > > Suggested-by: Peter Maydell > Signed-off-by: Alexander Bulekov > --- > tests/qtest/fuzz-test.c | 3 +-- > 1 file change

[qemu-web PATCH] Add Outreachy and GSoC announcement

2021-02-17 Thread Stefan Hajnoczi
QEMU is participating in Outreachy May-August and is applying for GSoC 2021. It's time to publish information on these internship programs and how to apply. Signed-off-by: Stefan Hajnoczi --- _posts/2021-02-17-gsoc-and-outreachy-2021.md | 43 1 file changed, 43 insertions(+)

Re: [PATCH 02/10] qemu-options: update to show preferred boolean syntax for -chardev

2021-02-17 Thread Daniel P . Berrangé
On Tue, Feb 16, 2021 at 09:08:39PM +, Peter Maydell wrote: > On Tue, 16 Feb 2021 at 19:10, Daniel P. Berrangé wrote: > > > > The preferred syntax is to use "foo=on|off", rather than a bare > > "foo" or "nofoo". > > > > Signed-off-by: Daniel P. Berrangé > > -"-chardev > > socket,id=id[,ho

[PATCH] travis.yml: Limit simultaneous jobs to 3

2021-02-17 Thread Thomas Huth
Even though the host machines that run the Travis CI jobs have quite a lot of CPUs (e.g. nproc in an aarch64 job reports 32), the containers on Travis are still limited to 2 vCPUs according to: https://docs.travis-ci.com/user/reference/overview/#approx-boot-time So we do not gain much when compi

Re: [PATCH v13 0/5] UFFD write-tracking migration/snapshots

2021-02-17 Thread David Hildenbrand
On 17.02.21 00:35, Peter Xu wrote: Hi, Andrey, On Sat, Feb 13, 2021 at 12:34:07PM +0300, Andrey Gruzdev wrote: On 12.02.2021 19:11, Peter Xu wrote: On Fri, Feb 12, 2021 at 09:52:52AM +0100, David Hildenbrand wrote: On 12.02.21 04:06, Peter Xu wrote: On Thu, Feb 11, 2021 at 10:09:58PM +0100,

Re: [PATCH] travis.yml: Limit simultaneous jobs to 3

2021-02-17 Thread Philippe Mathieu-Daudé
On 2/17/21 11:25 AM, Thomas Huth wrote: > Even though the host machines that run the Travis CI jobs have > quite a lot of CPUs (e.g. nproc in an aarch64 job reports 32), the > containers on Travis are still limited to 2 vCPUs according to: > > https://docs.travis-ci.com/user/reference/overview/#a

[Bug 1815445] Re: change and eject commands are not working on an overlay

2021-02-17 Thread Thomas Huth
** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1815445 Title: change and eject commands are not working on an overlay Status in QEMU: Incomple

[Bug 1815009] Re: Qemu evdev multiple guests/host switch

2021-02-17 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1815009 Title: Qemu evdev multiple guests/host switch Status in QEMU: New Bug description:

[Bug 1815263] Re: hvf accelerator crashes on quest boot

2021-02-17 Thread Thomas Huth
Looking through old bug tickets... is this still an issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH] util: fix use-after-free in module_load_one

2021-02-17 Thread Daniel P . Berrangé
On Wed, Feb 17, 2021 at 12:24:03PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Spotted by ASAN: > > ==2407186==ERROR: AddressSanitizer: heap-use-after-free on address > 0x6020003ac4f0 at pc 0x7766659c bp 0x7fffd1d0 sp 0x7fffc980 > READ of size 1 at 0x6020

Re: [PATCH v3 3/7] spapr_drc.c: use spapr_drc_release() in isolate_physical/set_unusable

2021-02-17 Thread Greg Kurz
On Thu, 11 Feb 2021 19:52:42 -0300 Daniel Henrique Barboza wrote: > When moving a physical DRC to "Available", drc_isolate_physical() will > move the DRC state to STATE_PHYSICAL_POWERON and, if the DRC is marked > for unplug, call spapr_drc_detach(). For physical DRCs, drck->empty_state > is STAT

Re: [PATCH v3 4/7] spapr: rename spapr_drc_detach() to spapr_drc_unplug_request()

2021-02-17 Thread Greg Kurz
On Thu, 11 Feb 2021 19:52:43 -0300 Daniel Henrique Barboza wrote: > spapr_drc_detach() is not the best name for what the function does. > The function does not detach the DRC, it makes an uncommited attempt > to do it. It'll mark the DRC as pending unplug, via the 'unplug_request' > flag, and onl

Re: [PATCH v4 0/3] Add npcm7xx emc model

2021-02-17 Thread Peter Maydell
On Tue, 16 Feb 2021 at 14:28, Peter Maydell wrote: > > On Sat, 13 Feb 2021 at 00:25, Doug Evans wrote: > > > > This is a 10/100 ethernet device that has several features. > > Only the ones needed by the Linux driver have been implemented. > > See npcm7xx_emc.c for a list of unimplemented features

Re: [qemu-web PATCH] Add Outreachy and GSoC announcement

2021-02-17 Thread Thomas Huth
On 17/02/2021 11.07, Stefan Hajnoczi wrote: QEMU is participating in Outreachy May-August and is applying for GSoC 2021. It's time to publish information on these internship programs and how to apply. Thanks, it's online now: https://www.qemu.org/2021/02/17/gsoc-and-outreachy-2021/ Thomas

[PULL v2 00/37] target-arm queue

2021-02-17 Thread Peter Maydell
otes/kevin/tags/for-upstream' into staging (2021-02-15 17:13:57 +) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20210217 for you to fetch changes up to 59c7a187dd8bd8ef675768dd8af9de11528ea7e2: MAINTAINERS: add m

Re: [PATCH] pc-bios/s390-ccw: Use memory barriers in virtio code

2021-02-17 Thread Peter Maydell
On Wed, 17 Feb 2021 at 04:31, Richard Henderson wrote: > On 2/16/21 8:15 AM, Thomas Huth wrote: > With > > diff --git a/tcg/aarch64/tcg-target.c.inc b/tcg/aarch64/tcg-target.c.inc > index 1376cdc404..3c5f38be62 100644 > --- a/tcg/aarch64/tcg-target.c.inc > +++ b/tcg/aarch64/tcg-target.c.inc > @@ -

Re: [Rust-VMM] Call for Google Summer of Code 2021 project ideas

2021-02-17 Thread Stefan Hajnoczi
Thanks, I have published the rust-vmm project ideas on the wiki: https://wiki.qemu.org/Google_Summer_of_Code_2021 Please see Sergio's reply about virtio-consoile is libkrun. Maybe it affects the project idea? Stefan

Re: [PATCH] travis.yml: Limit simultaneous jobs to 3

2021-02-17 Thread Alex Bennée
Thomas Huth writes: > Even though the host machines that run the Travis CI jobs have > quite a lot of CPUs (e.g. nproc in an aarch64 job reports 32), the > containers on Travis are still limited to 2 vCPUs according to: > > https://docs.travis-ci.com/user/reference/overview/#approx-boot-time >

[PATCH] qsd: Document FUSE exports

2021-02-17 Thread Max Reitz
Implementing FUSE exports required no changes to the storage daemon, so we forgot to document them there. Considering that both NBD and vhost-user-blk exports are documented in its man page (and NBD exports in its --help text), we should probably do the same for FUSE. Signed-off-by: Max Reitz --

Re: [PATCH v6 05/19] qapi/introspect.py: guard against ifcond/comment misuse

2021-02-17 Thread Markus Armbruster
John Snow writes: > _tree_to_qlit is called recursively on dict values (isolated from their > keys); at such a point in generating output it is too late to apply an > ifcond. Similarly, comments do not necessarily have a "tidy" place they > can be printed in such a circumstance. > > Forbid this u

Re: [PATCH] gitlab-ci: Display Avocado log content when tests timeout

2021-02-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Since commit ba2232bae6d ("gitlab-ci: Refactor code that show logs > of failed acceptances") we display the log content of failing tests > (Avocado "FAIL" event). > > Since we are also interested in tests timeouting, update our global > Avocado config to display

Re: [PATCH] gitlab-ci.yml: Run check-tcg with TCI

2021-02-17 Thread Alex Bennée
Thomas Huth writes: > It's now possible to also run the non-x86 TCG tests with TCI. > > Signed-off-by: Thomas Huth Queued to testing/next, thanks. > --- > Based-on: 20210126192518.2019885-1...@weilnetz.de > CI-run: https://gitlab.com/huth/qemu/-/jobs/988742434#L5200 > > .gitlab-ci.yml | 4

Re: [PATCH] docker: Bump Fedora images to release 33

2021-02-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Fedora 33 was released on October 27, 2020. > > Update all the Fedora 32 images to this new release. Queued to testing/next, thanks. > > Suggested-by: Daniel Berrangé > Signed-off-by: Philippe Mathieu-Daudé > --- > Based-on: <20210118181115.313742-1-phi...@re

Re: [PATCH v2 20/20] tests: add some virtio-gpu & vhost-user-gpu acceptance test

2021-02-17 Thread Alex Bennée
Marc-André Lureau writes: > Hi > > On Tue, Feb 16, 2021 at 9:43 PM Cleber Rosa wrote: > >> On Tue, Feb 16, 2021 at 04:34:06PM +, Alex Bennée wrote: >> > >> > marcandre.lur...@redhat.com writes: >> > >> > > From: Marc-André Lureau >> > > >> > > This will check virtio/vhost-user-vga & virgl

[PATCH v1 4/6] docker: Bump Fedora images to release 33

2021-02-17 Thread Alex Bennée
From: Philippe Mathieu-Daudé Fedora 33 was released on October 27, 2020. Update all the Fedora 32 images to this new release. Suggested-by: Daniel Berrangé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20210118181255.314672-1-phi...@redhat.com> --- tests/dock

[PATCH v1 6/6] tests/acceptance: allow a "graceful" failing for virtio-gpu test

2021-02-17 Thread Alex Bennée
This is a band-aid with a TODO for cases when QEMU doesn't start due to missing VirGL. Longer term we could do with some proper feature probing. Signed-off-by: Alex Bennée Cc: Marc-André Lureau --- tests/acceptance/virtio-gpu.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff

[PATCH v1 0/6] my current testing/next queue (meson/gitlab/fedora bump)

2021-02-17 Thread Alex Bennée
Hi, Currently the my queue is fairly short and mainly contains little quality of life improvements to the testing and CI bits. I'm mainly posting to roll-up the random patches into a series. The only patch in need of review is: - tests/acceptance: allow a "graceful" failing for virtio-gpu test

[PATCH v1 3/6] gitlab-ci.yml: Run check-tcg with TCI

2021-02-17 Thread Alex Bennée
From: Thomas Huth It's now possible to also run the non-x86 TCG tests with TCI. Signed-off-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20210127055903.40148-1-th...@redhat.com> --- .gitlab-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.yml

[PATCH v1 2/6] gitlab-ci: Display Avocado log content when tests timeout

2021-02-17 Thread Alex Bennée
From: Philippe Mathieu-Daudé Since commit ba2232bae6d ("gitlab-ci: Refactor code that show logs of failed acceptances") we display the log content of failing tests (Avocado "FAIL" event). Since we are also interested in tests timeouting, update our global Avocado config to display log content fo

[PATCH v1 1/6] meson.build: expose TCG cross compiler information in summary

2021-02-17 Thread Alex Bennée
Blink and you miss the cross TCG compiler stuff so lets display it with the rest of the compiler information. Signed-off-by: Alex Bennée Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Acked-by: Paolo Bonzini Message-Id: <20210216102522.6279-1-alex.ben...@linaro.org> ---

[PATCH v1 5/6] travis.yml: Limit simultaneous jobs to 3

2021-02-17 Thread Alex Bennée
From: Thomas Huth Even though the host machines that run the Travis CI jobs have quite a lot of CPUs (e.g. nproc in an aarch64 job reports 32), the containers on Travis are still limited to 2 vCPUs according to: https://docs.travis-ci.com/user/reference/overview/#approx-boot-time So we do not

Re: [PATCH v2 6/6] tests/qapi-schema: Test cases for aliases

2021-02-17 Thread Markus Armbruster
Markus Armbruster writes: > Kevin Wolf writes: > >> Am 16.02.2021 um 16:14 hat Markus Armbruster geschrieben: >>> Kevin Wolf writes: >>> >>> > Signed-off-by: Kevin Wolf >>> [...] >>> > diff --git a/tests/qapi-schema/alias-name-bad-type.err >>> > b/tests/qapi-schema/alias-name-bad-type.err >>

[Bug 1915925] [NEW] ARM semihosting HEAPINFO results wrote to wrong address

2021-02-17 Thread iNvEr7
Public bug reported: This affects latest development branch of QEMU. According to the ARM spec of the HEAPINFO semihosting call: https://developer.arm.com/documentation/100863/0300/Semihosting- operations/SYS-HEAPINFO--0x16-?lang=en > the PARAMETER REGISTER contains the address of a pointer to

Re: [PATCH 1/2] spice: flush on GL update before notifying client

2021-02-17 Thread Gerd Hoffmann
On Tue, Feb 16, 2021 at 01:20:55PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Since the introduction of spice/virgl support in commit > 474114b7 ("spice: add opengl/virgl/dmabuf support"), the drawing isn't > being flushed before notifying the client. This results in

Re: [PATCH] ui/cocoa: Support unique keys of JIS keyboards

2021-02-17 Thread Gerd Hoffmann
> +// JIS keyboards only > +[kVK_JIS_Yen] = Q_KEY_CODE_YEN, > +[kVK_JIS_Underscore] = Q_KEY_CODE_RO, > +[kVK_JIS_KeypadComma] = Q_KEY_CODE_KP_COMMA, > +[kVK_JIS_Eisu] = Q_KEY_CODE_MUHENKAN, > +[kVK_JIS_Kana] = Q_KEY_CODE_HENKAN, Added to UI patch queue. thanks, Gerd

Re: [RFC v2 2/7] virtio: Add virtio_queue_host_notifier_status

2021-02-17 Thread Stefan Hajnoczi
On Tue, Feb 09, 2021 at 04:37:52PM +0100, Eugenio Pérez wrote: > This allows shadow virtqueue code to assert the queue status before > making changes. > > Signed-off-by: Eugenio Pérez > --- > include/hw/virtio/virtio.h | 1 + > hw/virtio/virtio.c | 5 + > 2 files changed, 6 insertion

Re: [RFC v2 3/7] vhost: Save masked_notifier state

2021-02-17 Thread Stefan Hajnoczi
On Tue, Feb 09, 2021 at 04:37:53PM +0100, Eugenio Pérez wrote: > It will be used to recover call eventfd. > > Signed-off-by: Eugenio Pérez > --- > include/hw/virtio/vhost.h | 1 + > hw/virtio/vhost.c | 2 ++ > 2 files changed, 3 insertions(+) Reviewed-by: Stefan Hajnoczi signature.as

Re: [PATCH 1/1] qga-vss: Use dynamic linking for GLib

2021-02-17 Thread Konstantin Kostiuk
ping On Tue, Feb 9, 2021 at 4:54 PM Kostiantyn Kostiuk wrote: > The current GLib version implements the DllMain function. DllMain is also > present in the provider.cpp code. So in the case of static linking, the > DllMain redefinition error occurs. For now, just switch to dynamic linking > and r

Re: [RFC v2 4/7] vhost: Add VhostShadowVirtqueue

2021-02-17 Thread Stefan Hajnoczi
On Tue, Feb 09, 2021 at 04:37:54PM +0100, Eugenio Pérez wrote: > +/* > + * Creates vhost shadow virtqueue, and instruct vhost device to use the > shadow > + * methods and file descriptors. > + */ > +VhostShadowVirtqueue *vhost_shadow_vq_new(struct vhost_dev *dev, int idx) > +{ > +g_autofree Vh

Re: [PULL v2 00/37] target-arm queue

2021-02-17 Thread Peter Maydell
llowing changes since commit 8ba4bca570ace1e60614a0808631a517cf5df67a: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2021-02-15 17:13:57 +) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > ta

Re: [PATCH] ui/cocoa: Do not copy members of pixman image

2021-02-17 Thread Gerd Hoffmann
On Fri, Feb 12, 2021 at 09:06:29AM +0900, Akihiko Odaki wrote: > The old CocoaView had an idea of synchronizing the host window > configuration and the guest screen configuration. Here, the guest screen > actually means pixman image given ui/cocoa display implementation. > > However, [CocoaView -d

Re: [PATCH] ui/cocoa: Remove the uses of full screen APIs

2021-02-17 Thread Gerd Hoffmann
On Fri, Feb 12, 2021 at 09:05:40AM +0900, Akihiko Odaki wrote: > The detections of full screen APIs were wrong. A detection is coded as: > [NSView respondsToSelector:@selector(exitFullScreenModeWithOptions:)] > but it should be: > [NSView instancesRespondToSelector:@selector(exitFullScreenModeWithO

Re: [PATCH] ui/cocoa: Interpret left button down as is when command is pressed

2021-02-17 Thread Gerd Hoffmann
On Fri, Feb 12, 2021 at 09:07:06AM +0900, Akihiko Odaki wrote: > Old Macs were not equipped with mice with an ability to perform > "right clicks" and ui/cocoa interpreted left button down with > left command key pressed as right button down as a workaround. > > The workaround has an obvious downsi

Re: [PATCH v1 6/6] tests/acceptance: allow a "graceful" failing for virtio-gpu test

2021-02-17 Thread Marc-André Lureau
On Wed, Feb 17, 2021 at 4:19 PM Alex Bennée wrote: > This is a band-aid with a TODO for cases when QEMU doesn't start due > to missing VirGL. Longer term we could do with some proper feature > probing. > > Signed-off-by: Alex Bennée > Cc: Marc-André Lureau > Reviewed-by: Marc-André Lureau --

Re: [PATCH v3 3/3] qmp: add new qmp display-reload

2021-02-17 Thread Gerd Hoffmann
> +## > +# @DiaplayReloadInfo: Display > +{ 'struct': 'DiaplayReloadInfo', Same here. take care, Gerd

Re: [PATCH] util: fix use-after-free in module_load_one

2021-02-17 Thread Marc-André Lureau
On Wed, Feb 17, 2021 at 2:48 PM Daniel P. Berrangé wrote: > On Wed, Feb 17, 2021 at 12:24:03PM +0400, marcandre.lur...@redhat.com > wrote: > > From: Marc-André Lureau > > > > Spotted by ASAN: > > > > ==2407186==ERROR: AddressSanitizer: heap-use-after-free on address > 0x6020003ac4f0 at pc 0x7fff

Re: [PATCH v3 2/3] vnc: support reload x509 certificates for vnc

2021-02-17 Thread Gerd Hoffmann
> +if (!vd) { > +error_setg(errp, "Can not find Vnc Display"); Can we make this "vnc display" please? > +error_setg(errp, "Vnc tls is not enable"); Same. thanks, Gerd

Re: [PATCH] spice-app: avoid crash when core spice module doesn't loaded

2021-02-17 Thread Gerd Hoffmann
On Fri, Feb 12, 2021 at 08:23:18PM -0700, Bruce Rogers wrote: > When qemu is built with modules, but a given module doesn't load > qemu should handle that gracefully. When ui-spice-core.so isn't > able to be loaded and qemu is invoked with -display spice-app or > -spice, qemu will dereference a nul

Re: [PATCH 0/3] virtiofsd: Add options to enable/disable posix acl

2021-02-17 Thread Luis Henriques
Vivek Goyal writes: > Luis Henriques reported that fstest generic/099 fails with virtiofs. > Little debugging showed that we don't enable acl support. So this > patch series provides option to enable/disable posix acl support. By > default it is disabled. > > I have run blogbench and pjdfstests w

Re: [PATCH v1 2/6] gitlab-ci: Display Avocado log content when tests timeout

2021-02-17 Thread Thomas Huth
On 17/02/2021 13.19, Alex Bennée wrote: From: Philippe Mathieu-Daudé Since commit ba2232bae6d ("gitlab-ci: Refactor code that show logs of failed acceptances") we display the log content of failing tests (Avocado "FAIL" event). Since we are also interested in tests timeouting, update our globa

Measuring the impact of buffer copy for virtio-gpu guests

2021-02-17 Thread Alex Bennée
Hi Gerd, I was in a discussion with the AGL folks today talking about approaches to achieving zero-copy when running VirGL virtio guests. AIUI (which is probably not very much) the reasons for copy can be due to a number of reasons: - the GPA not being mapped to a HPA that is accessible to the

Re: [PATCH v8 00/35] Hexagon patch series

2021-02-17 Thread Philippe Mathieu-Daudé
On 2/16/21 10:17 PM, Peter Maydell wrote: > On Tue, 16 Feb 2021 at 20:59, Taylor Simpson wrote: >>> -Original Message- >>> From: Richard Henderson >>> I've completed review of this round, and there are some nits. But they're >>> minor enough that I wouldn't even mind them being addressed

Re: [PATCH v2 7/7] tests/avocado: add boot_xen tests

2021-02-17 Thread Philippe Mathieu-Daudé
On 2/11/21 6:19 PM, Alex Bennée wrote: > These tests make sure we can boot the Xen hypervisor with a Dom0 > kernel using the guest-loader. We currently have to use a kernel I > built myself because there are issues using the Debian kernel images. > > Signed-off-by: Alex Bennée > --- > MAINTAINER

Re: [PATCH] virtio-ccw: commands on revision-less devices

2021-02-17 Thread Halil Pasic
On Tue, 16 Feb 2021 16:54:05 +0100 Cornelia Huck wrote: > On Tue, 16 Feb 2021 15:19:45 +0100 > Halil Pasic wrote: > > > On Tue, 16 Feb 2021 12:18:30 +0100 > > Cornelia Huck wrote: > > > > > The virtio standard specifies that any non-transitional device must > > > reject commands prior to re

Re: [PULL v2 00/21] i386, qgraph patches for 2020-02-15

2021-02-17 Thread Peter Maydell
On Tue, 16 Feb 2021 at 18:29, Paolo Bonzini wrote: > > The following changes since commit 8ba4bca570ace1e60614a0808631a517cf5df67a: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2021-02-15 17:13:57 +) > > are available in the Git repository at: > > htt

Re: Measuring the impact of buffer copy for virtio-gpu guests

2021-02-17 Thread François Ozog
On Wed, 17 Feb 2021 at 15:13, Alex Bennée wrote: > Hi Gerd, > > I was in a discussion with the AGL folks today talking about approaches > to achieving zero-copy when running VirGL virtio guests. AIUI (which is > probably not very much) the reasons for copy can be due to a number of > reasons: > >

Re: [PATCH] event_notifier: Set ->initialized earlier in event_notifier_init()

2021-02-17 Thread Maxim Levitsky
On Tue, 2021-02-16 at 13:02 +0100, Greg Kurz wrote: > Otherwise the call to event_notifier_set() is a nop, which causes > the SLOF firmware on POWER to hang when booting from a virtio-scsi > device: > > virtio_scsi_dataplane_start() > virtio_scsi_vring_init() > virtio_bus_set_host_notifier() <-

[Bug 1915925] Re: ARM semihosting HEAPINFO results wrote to wrong address

2021-02-17 Thread Peter Maydell
Broken in commit 3c37cfe0b1e8a49, I think. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1915925 Title: ARM semihosting HEAPINFO results wrote to wrong address Status in QEMU: New Bug descripti

Re: [PULL 24/30] semihosting: Change internal common-semi interfaces to use CPUState *

2021-02-17 Thread Peter Maydell
On Fri, 15 Jan 2021 at 13:33, Alex Bennée wrote: > > From: Keith Packard > > This makes all of the internal interfaces architecture-independent and > renames the internal functions to use the 'common_semi' prefix instead > of 'arm' or 'arm_semi'. Hi; it looks like this commit broke the implement

Re: [PATCH 1/3] virtiofsd: Add an option to enable/disable posix acls

2021-02-17 Thread Vivek Goyal
On Wed, Feb 17, 2021 at 09:53:04AM +0100, Miklos Szeredi wrote: > On Wed, Feb 17, 2021 at 12:36 AM Vivek Goyal wrote: > > > > fuse has an option FUSE_POSIX_ACL which needs to be opted in by fuse > > server to enable posix acls. > > > > Add virtiofsd option "-o posix_acl/no_posix_acl" to let users

[Bug 1915925] Re: ARM semihosting HEAPINFO results wrote to wrong address

2021-02-17 Thread Peter Maydell
** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1915925 Title: ARM semihosting HEAPINFO results wrote to wrong address Status in QEMU: Confirmed

Re: [PATCH] pc-bios/s390-ccw: Use memory barriers in virtio code

2021-02-17 Thread Richard Henderson
On 2/17/21 3:15 AM, Peter Maydell wrote: > This isn't aarch64-host-specific, though, is it? It's going to be > the situation for any host with a relaxed memory model. Yes. I intend to make the code-generation changes generic. > Do we really > want to make all loads and stores lower-performance b

Re: [PATCH v2 5/6] qapi: Add support for aliases

2021-02-17 Thread Markus Armbruster
Kevin Wolf writes: > Introduce alias definitions for object types (structs and unions). This > allows using the same QAPI type and visitor for many syntax variations > that exist in the external representation, like between QMP and the > command line. It also provides a new tool for evolving the

Re: [PATCH 1/3] virtiofsd: Add an option to enable/disable posix acls

2021-02-17 Thread Miklos Szeredi
On Wed, Feb 17, 2021 at 4:07 PM Vivek Goyal wrote: > > On Wed, Feb 17, 2021 at 09:53:04AM +0100, Miklos Szeredi wrote: > > On Wed, Feb 17, 2021 at 12:36 AM Vivek Goyal wrote: > > > > > > fuse has an option FUSE_POSIX_ACL which needs to be opted in by fuse > > > server to enable posix acls. > > >

Re: [RFC v2 5/7] vhost: Add x-vhost-enable-shadow-vq qmp

2021-02-17 Thread Stefan Hajnoczi
On Tue, Feb 09, 2021 at 04:37:55PM +0100, Eugenio Pérez wrote: > diff --git a/qapi/net.json b/qapi/net.json > index c31748c87f..a1cdffb0f9 100644 > --- a/qapi/net.json > +++ b/qapi/net.json > @@ -77,6 +77,28 @@ > ## > { 'command': 'netdev_del', 'data': {'id': 'str'} } > > +## > +# @x-vhost-enab

Re: [PATCH v2 4/6] qapi: Apply aliases in qobject-input-visitor

2021-02-17 Thread Markus Armbruster
Kevin Wolf writes: > When looking for an object in a struct in the external representation, > check not only the currently visited struct, but also whether an alias > in the current StackObject matches and try to fetch the value from the > alias then. Providing two values for the same object thro

Re: [PATCH v2 4/6] hw/sd: sdhci: Simplify updating s->prnsts in sdhci_sdma_transfer_multi_blocks()

2021-02-17 Thread Alexander Bulekov
On 210216 1146, Bin Meng wrote: > s->prnsts is updated in both branches of the if () else () statement. > Move the common bits outside so that it is cleaner. > > Signed-off-by: Bin Meng Reviewed-by: Alexander Bulekov > --- > > (no changes since v1) > > hw/sd/sdhci.c | 7 +++ > 1 file ch

Re: Measuring the impact of buffer copy for virtio-gpu guests

2021-02-17 Thread Alex Bennée
François Ozog writes: > On Wed, 17 Feb 2021 at 15:13, Alex Bennée wrote: > >> Hi Gerd, >> >> I was in a discussion with the AGL folks today talking about approaches >> to achieving zero-copy when running VirGL virtio guests. AIUI (which is >> probably not very much) the reasons for copy can be

Re: [PATCH v6 15/19] qapi/introspect.py: Add docstrings to _gen_tree and _tree_to_qlit

2021-02-17 Thread John Snow
On 2/17/21 4:39 AM, Markus Armbruster wrote: John Snow writes: Signed-off-by: John Snow --- scripts/qapi/introspect.py | 18 ++ 1 file changed, 18 insertions(+) diff --git a/scripts/qapi/introspect.py b/scripts/qapi/introspect.py index 45284af1330..5d4f5e23f7e 100644 --- a

Re: [PATCH v2 5/6] qapi: Add support for aliases

2021-02-17 Thread Kevin Wolf
Am 17.02.2021 um 16:23 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Introduce alias definitions for object types (structs and unions). This > > allows using the same QAPI type and visitor for many syntax variations > > that exist in the external representation, like between QMP a

[Bug 1915925] Re: ARM semihosting HEAPINFO results wrote to wrong address

2021-02-17 Thread Philippe Mathieu-Daudé
** Tags added: testcase -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1915925 Title: ARM semihosting HEAPINFO results wrote to wrong address Status in QEMU: Confirmed Bug description: This af

Re: [PATCH] qsd: Document FUSE exports

2021-02-17 Thread Eric Blake
On 2/17/21 5:58 AM, Max Reitz wrote: > Implementing FUSE exports required no changes to the storage daemon, so > we forgot to document them there. Considering that both NBD and > vhost-user-blk exports are documented in its man page (and NBD exports > in its --help text), we should probably do the

Re: [PATCH v2 20/21] accel/tcg: allow plugin instrumentation to be disable via cflags

2021-02-17 Thread Aaron Lindsay via
On Feb 16 10:34, Alex Bennée wrote: > > Aaron Lindsay writes: > > > On Feb 12 16:04, Alex Bennée wrote: > >> Do you see two stores or one store? I think I got the sense the wrong > >> way around because the store is instrumented before the mmu code, > >> hence should be skipped on a re-instrumen

Re: [PATCH v6 15/19] qapi/introspect.py: Add docstrings to _gen_tree and _tree_to_qlit

2021-02-17 Thread Markus Armbruster
John Snow writes: > On 2/17/21 4:39 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> Signed-off-by: John Snow >>> --- >>> scripts/qapi/introspect.py | 18 ++ >>> 1 file changed, 18 insertions(+) >>> >>> diff --git a/scripts/qapi/introspect.py b/scripts/qapi/introspec

Re: [PATCH v1 3/6] gitlab-ci.yml: Run check-tcg with TCI

2021-02-17 Thread Philippe Mathieu-Daudé
On 2/17/21 1:19 PM, Alex Bennée wrote: > From: Thomas Huth > > It's now possible to also run the non-x86 TCG tests with TCI. > > Signed-off-by: Thomas Huth > Signed-off-by: Alex Bennée > Message-Id: <20210127055903.40148-1-th...@redhat.com> > --- > .gitlab-ci.yml | 4 ++-- > 1 file changed, 2

Re: [PATCH 01/10] gdbstub: use preferred boolean option syntax

2021-02-17 Thread Paolo Bonzini
On 16/02/21 20:10, Daniel P. Berrangé wrote: Signed-off-by: Daniel P. Berrangé --- gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbstub.c b/gdbstub.c index 759bb00bcf..3ee40479b6 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -3505,7 +3505,7 @@ int gdbserver_start(

Re: [PATCH v4 15/24] python: add mypy to pipenv

2021-02-17 Thread John Snow
On 2/16/21 11:38 PM, Cleber Rosa wrote: On Thu, Feb 11, 2021 at 01:58:47PM -0500, John Snow wrote: 0.730 appears to be about the oldest version that works with the features we want, including nice human readable output (to make sure iotest 297 passes), and type-parameterized Popen generics. 0.7

Re: [PATCH v4 18/24] python/qemu: add qemu package itself to pipenv

2021-02-17 Thread John Snow
On 2/16/21 11:47 PM, Cleber Rosa wrote: On Thu, Feb 11, 2021 at 01:58:50PM -0500, John Snow wrote: This adds the python qemu packages themselves to the pipenv manifest. 'pipenv sync' will create a virtual environment sufficient to use the SDK. 'pipenv sync --dev' will create a virtual environmen

Re: [RFC PATCH v3 02/31] hw/cxl/component: Introduce CXL components (8.1.x, 8.2.5)

2021-02-17 Thread Ben Widawsky
On 21-02-11 17:08:45, Jonathan Cameron wrote: > On Mon, 1 Feb 2021 16:59:19 -0800 > Ben Widawsky wrote: > > > A CXL 2.0 component is any entity in the CXL topology. All components > > have a analogous function in PCIe. Except for the CXL host bridge, all > > have a PCIe config space that is acces

Re: [PATCH v3 20/23] accel/tcg: allow plugin instrumentation to be disable via cflags

2021-02-17 Thread Aaron Lindsay via
On Feb 13 13:03, Alex Bennée wrote: > When icount is enabled and we recompile an MMIO access we end up > double counting the instruction execution. To avoid this we introduce > the CF_MEMI cflag which only allows memory instrumentation for the > next TB (which won't yet have been counted). As this

Re: [PATCH v6 15/19] qapi/introspect.py: Add docstrings to _gen_tree and _tree_to_qlit

2021-02-17 Thread John Snow
On 2/17/21 11:35 AM, Markus Armbruster wrote: John Snow writes: On 2/17/21 4:39 AM, Markus Armbruster wrote: John Snow writes: Signed-off-by: John Snow --- scripts/qapi/introspect.py | 18 ++ 1 file changed, 18 insertions(+) diff --git a/scripts/qapi/introspect.py b/

Re: [RFC v2 6/7] vhost: Route guest->host notification through shadow virtqueue

2021-02-17 Thread Stefan Hajnoczi
On Tue, Feb 09, 2021 at 04:37:56PM +0100, Eugenio Pérez wrote: > diff --git a/include/hw/virtio/vhost.h b/include/hw/virtio/vhost.h > index ac963bf23d..884818b109 100644 > --- a/include/hw/virtio/vhost.h > +++ b/include/hw/virtio/vhost.h > @@ -55,6 +55,8 @@ struct vhost_iommu { > QLIST_ENTRY(v

Re: [PATCH v8 00/35] Hexagon patch series

2021-02-17 Thread Richard Henderson
On 2/16/21 12:59 PM, Taylor Simpson wrote: >>> This series assumes int128_or() is implemented. >>> https://lists.nongnu.org/archive/html/qemu-devel/2020-10/msg06004.html >>> > > What's the status of this patch? Could you go ahead and merge it ahead of > the rest of the series that it's in? The

Re: [PATCH v8 00/35] Hexagon patch series

2021-02-17 Thread Richard Henderson
On 2/17/21 6:23 AM, Philippe Mathieu-Daudé wrote: > I'm very pleased with how this series evolved over the time, > and Taylor interaction with the community during the long > review process. > > Patches 1-34 are OK but I don't think patch 35 (Dockerfile hexagon) > should enter mainstream that way.

Re: [PATCH] IOMMU and ATS not supported by vhost-user filesystem.

2021-02-17 Thread Leonardo Augusto Guimarães Garcia
On 1/27/21 8:19 AM, Stefan Hajnoczi wrote: On Tue, Jan 26, 2021 at 03:23:38PM -0300, lagar...@linux.ibm.com wrote: From: Leonardo Garcia Currently, as IOMMU and ATS are not supported, if a user mistakenly set any of them and tries to mount the vhost-user filesystem inside the guest, whenever t

Re: [PATCH v8 35/35] Add Dockerfile for hexagon

2021-02-17 Thread Alessandro Di Federico via
On Sun, 14 Feb 2021 19:50:41 +0100 Philippe Mathieu-Daudé wrote: > Hi Alessandro! Hi Philippe! > I had to add this to build your image with QEMU build system: > > -- >8 -- > > diff --git a/tests/docker/Makefile.include > b/tests/docker/Makefile.include index 93b29ad823e..ba73fb4b1f0 100644 >

Re: [RFC v2 7/7] vhost: Route host->guest notification through shadow virtqueue

2021-02-17 Thread Stefan Hajnoczi
On Tue, Feb 09, 2021 at 04:37:57PM +0100, Eugenio Pérez wrote: > @@ -40,6 +42,26 @@ static void vhost_handle_guest_kick(EventNotifier *n) > } > } > > +/* Forward vhost notifications */ > +static void vhost_handle_call(EventNotifier *n) The name vhost_shadow_vq_handle_call() expresses the p

Re: [PATCH v3 70/70] gitlab: Enable cross-i386 builds of TCI

2021-02-17 Thread Philippe Mathieu-Daudé
On 2/8/21 3:37 AM, Richard Henderson wrote: > We're currently only testing TCI with a 64-bit host -- also test > with a 32-bit host. Enable a selection of softmmu and user-only > targets, 32-bit LE, 64-bit LE, 32-bit BE, as there are ifdefs for each. > > Signed-off-by: Richard Henderson > --- >

Re: [PATCH v4 08/24] python: Add pipenv support

2021-02-17 Thread John Snow
On 2/16/21 10:02 PM, Cleber Rosa wrote: On Tue, Feb 16, 2021 at 09:59:47PM -0500, Cleber Rosa wrote: On Thu, Feb 11, 2021 at 01:58:40PM -0500, John Snow wrote: pipenv is a tool used for managing virtual environments with pinned, explicit dependencies. It is used for precisely recreating python

  1   2   3   >