[PULL 23/27] migration: wire up support for snapshot device selection

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé Modify load_snapshot/save_snapshot to accept the device list and vmstate node name parameters previously added to the block layer. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé Message-Id: <20210204124834.774401-9-berra...@redhat.com> Signed-off-by: Dr. Dav

[PULL 05/27] migration: introduce 'background-snapshot' migration capability

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Andrey Gruzdev Add new capability to 'qapi/migration.json' schema. Update migrate_caps_check() to validate enabled capability set against introduced one. Perform checks for required kernel features and compatibility with guest memory backends. Signed-off-by: Andrey Gruzdev Reviewed-by: Pe

[PULL 07/27] migration: support UFFD write fault processing in ram_save_iterate()

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Andrey Gruzdev In this particular implementation the same single migration thread is responsible for both normal linear dirty page migration and procesing UFFD page fault events. Processing write faults includes reading UFFD file descriptor, finding respective RAM block and saving faulting

[PULL 02/27] savevm: Fix memory leak of vmstate_configuration

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Jinhao Gao When VM migrate VMState of configuration, the fields(name and capabilities) of configuration having a flag of VMS_ALLOC need to allocate memory. If the src doesn't free memory of capabilities in SaveState after save VMState of configuration, or the dst doesn't free memory of name

[PATCH] migration: only check page size match if RAM postcopy is enabled

2021-02-04 Thread Stefan Reiter
Postcopy may also be advised for dirty-bitmap migration only, in which case the remote page size will not be available and we'll instead read bogus data, blocking migration with a mismatch error if the VM uses hugepages. Fixes: 58110f0acb ("migration: split common postcopy out of ram postcopy") Si

[PULL 06/27] migration: introduce UFFD-WP low-level interface helpers

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Andrey Gruzdev Glue code to the userfaultfd kernel implementation. Querying feature support, createing file descriptor, feature control, memory region registration, IOCTLs on registered registered regions. Signed-off-by: Andrey Gruzdev Reviewed-by: Peter Xu Message-Id: <20210129101407.10

[PULL 12/27] migration: Fix cache_init()'s "Failed to allocate" error messages

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Markus Armbruster cache_init() attempts to handle allocation failure. The two error messages are garbage, as untested error messages commonly are: Parameter 'cache size' expects Failed to allocate cache Parameter 'cache size' expects Failed to allocate page cache Fix them to just

Re: [PULL 11/24] tcg/optimize: Use tcg_constant_internal with constant folding

2021-02-04 Thread Eric Blake
On 2/4/21 10:04 AM, Philippe Mathieu-Daudé wrote: >>> Isn't it kind of weird that this would only affect an s390 host?  I >>> don't understand why the host would make a difference if we're doing >>> TCG. >> >> I assume an existing BUG in the s390x TCG backend ... which makes it >> harder to debug

[PULL 08/27] migration: implementation of background snapshot thread

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Andrey Gruzdev Introducing implementation of 'background' snapshot thread which in overall follows the logic of precopy migration while internally utilizes completely different mechanism to 'freeze' vmstate at the start of snapshot creation. This mechanism is based on userfault_fd with wr-

[PULL 11/27] migration: Clean up signed vs. unsigned XBZRLE cache-size

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Markus Armbruster 73af8dd8d7 "migration: Make xbzrle_cache_size a migration parameter" (v2.11.0) made the new parameter unsigned (QAPI type 'size', uint64_t in C). It neglected to update existing code, which continues to use int64_t. migrate_xbzrle_cache_size() returns the new parameter.

[PULL 13/27] migration: Fix a few absurdly defective error messages

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Markus Armbruster migrate_params_check() has a number of error messages of the form Parameter 'NAME' expects is invalid, it should be ... Fix them to something like Parameter 'NAME' expects a ... Signed-off-by: Markus Armbruster Reviewed-by: Dr. David Alan Gilbert Message-Id:

[PULL 10/27] migration: Fix migrate-set-parameters argument validation

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Markus Armbruster Commit 741d4086c8 "migration: Use proper types in json" (v2.12.0) switched MigrationParameters to narrower integer types, and removed the simplified qmp_migrate_set_parameters()'s argument checking accordingly. Good idea, except qmp_migrate_set_parameters() takes MigrateS

Re: [PATCH v14 0/5] UFFD write-tracking migration/snapshots

2021-02-04 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Andrey Gruzdev (andrey.gruz...@virtuozzo.com) wrote: > > This patch series is a kind of 'rethinking' of Denis Plotnikov's ideas he's > > implemented in his series '[PATCH v0 0/4] migration: add background > > snapshot'. > > > > Currently t

[PULL 14/27] migration: Add blocker information

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Modify query-migrate so that it has a flag indicating if outbound migration is blocked, and if it is a list of reasons. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20210202135522.127380-2-dgilb...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Peter Xu

[PULL 18/27] migration: stop returning errno from load_snapshot()

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé None of the callers care about the errno value since there is a full Error object populated. This gives consistency with save_snapshot() which already just returns a boolean value. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé [PMD: Return false

Re: [PATCH v3 1/3] slirp: Placeholder for libslirp ipv6 hostfwd support

2021-02-04 Thread Marc-André Lureau
Hi, On Thu, Feb 4, 2021 at 3:38 AM dje--- via wrote: > > This commit is intended to only contain the slirp submodule change > that adds ipv6 hostfwd support. > --- > slirp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > It's generally recommended to include the shortlog of some sort i

Re: [PATCH] migration: only check page size match if RAM postcopy is enabled

2021-02-04 Thread Dr. David Alan Gilbert
* Stefan Reiter (s.rei...@proxmox.com) wrote: > Postcopy may also be advised for dirty-bitmap migration only, in which > case the remote page size will not be available and we'll instead read > bogus data, blocking migration with a mismatch error if the VM uses > hugepages. > > Fixes: 58110f0acb (

[PATCH v2] target/s390x/arch_dump: Fixes for the name field in the PT_NOTE section

2021-02-04 Thread Thomas Huth
According to the "ELF-64 Object File Format" specification: "The first word in the entry, namesz, identifies the length, in bytes, of a name identifying the entry’s owner or originator. The name field contains a null-terminated string, with padding as necessary to ensure 8- byte alignment for t

[PULL 19/27] block: add ability to specify list of blockdevs during snapshot

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé When running snapshot operations, there are various rules for which blockdevs are included/excluded. While this provides reasonable default behaviour, there are scenarios that are not well handled by the default logic. Some of the conditions do not have a single correct a

[PULL 22/27] migration: control whether snapshots are ovewritten

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé The traditional HMP "savevm" command will overwrite an existing snapshot if it already exists with the requested name. This new flag allows this to be controlled allowing for safer behaviour with a future QMP command. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Ber

[PULL 16/27] block: push error reporting into bdrv_all_*_snapshot functions

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé The bdrv_all_*_snapshot functions return a BlockDriverState pointer for the invalid backend, which the callers then use to report an error message. In some cases multiple callers are reporting the same error message, but with slightly different text. In the future there w

[PULL 25/27] iotests: add support for capturing and matching QMP events

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé When using the _launch_qemu and _send_qemu_cmd functions from common.qemu, any QMP events get mixed in with the output from the commands and responses. This makes it difficult to write a test case as the ordering of events in the output is not stable. This introduces a

[PULL 20/27] block: allow specifying name of block device for vmstate storage

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé Currently the vmstate will be stored in the first block device that supports snapshots. Historically this would have usually been the root device, but with UEFI it might be the variable store. There needs to be a way to override the choice of block device to store the sta

Re: [PATCH v5 1/3] virtiofsd: extract lo_do_open() from lo_open()

2021-02-04 Thread Greg Kurz
On Thu, 4 Feb 2021 15:02:06 + Stefan Hajnoczi wrote: > Both lo_open() and lo_create() have similar code to open a file. Extract > a common lo_do_open() function from lo_open() that will be used by > lo_create() in a later commit. > > Since lo_do_open() does not otherwise need fuse_req_t req

[PULL 21/27] block: rename and alter bdrv_all_find_snapshot semantics

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé Currently bdrv_all_find_snapshot() will return 0 if it finds a snapshot, -1 if an error occurs, or if it fails to find a snapshot. New callers to be added want to distinguish between the error scenario and failing to find a snapshot. Rename it to bdrv_all_has_snapshot an

[PULL 24/27] migration: introduce a delete_snapshot wrapper

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé Make snapshot deletion consistent with the snapshot save and load commands by using a wrapper around the blockdev layer. The main difference is that we get upfront validation of the passed in device list (if any). Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrang

[PATCH 04/33] migration: push Error **errp into qemu_load_device_state()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/colo.c | 3 +-- migration/savevm.c | 4 ++-- migration/savevm.h | 2 +- 3 files changed, 4 insertions(

[PULL 26/27] iotests: fix loading of common.config from tests/ subdir

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé common.rc assumes it is being sourced from the same directory and so also tries to source common.config from the current working directory. With the ability to now have named tests in the tests/ subdir we need to check two locations for common.config. Reviewed-by: Vladim

iotest 30 failing

2021-02-04 Thread Philippe Mathieu-Daudé
Hi, Based on commit 1ed9228f63e (ericb/tags/pull-nbd-2021-02-02-v2) I got: TEST iotest-qcow2: 030 [fail] --- /builds/philmd/qemu/tests/qemu-iotests/030.out +++ 030.out.bad @@ -1,5 +1,47 @@ -... +WARNING:qemu.machine:qemu received signal 11; command: "/builds/philmd/qem

[PULL 27/27] migration: introduce snapshot-{save, load, delete} QMP commands

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé savevm, loadvm and delvm are some of the few HMP commands that have never been converted to use QMP. The reasons for the lack of conversion are that they blocked execution of the event thread, and the semantics around choice of disks were ill-defined. Despite this downsi

[PATCH 12/33] migration: push Error **errp into loadvm_postcopy_handle_listen()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/migrati

Re: [PULL 11/24] tcg/optimize: Use tcg_constant_internal with constant folding

2021-02-04 Thread Richard W.M. Jones
On Thu, Feb 04, 2021 at 05:04:22PM +0100, Philippe Mathieu-Daudé wrote: > On 2/4/21 10:37 AM, David Hildenbrand wrote: > > On 04.02.21 10:29, Richard W.M. Jones wrote: > commit 8f17a975e60b773d7c366a81c0d9bbe304f30859 > Author: Richard Henderson > Date:   Mon Mar 30 19:52:02 2020 -0

[PATCH 1/2] build: add configure flag to indicate when the host is Darwin

2021-02-04 Thread phillip . ennen
From: Phillip Tennen Although we already have CONFIG_BSD, I added this flag to be sure that we could rely on various macOS-specific subsystems, such as vmnet.framework. Signed-off-by: Phillip Tennen --- configure | 4 1 file changed, 4 insertions(+) diff --git a/configure b/configure in

Re: [PATCH v2] target/s390x/arch_dump: Fixes for the name field in the PT_NOTE section

2021-02-04 Thread Christian Borntraeger
On 04.02.21 17:41, Thomas Huth wrote: > According to the "ELF-64 Object File Format" specification: > > "The first word in the entry, namesz, identifies the length, in > bytes, of a name identifying the entry’s owner or originator. The name field > contains a null-terminated string, with padding

[PATCH 11/33] migration: push Error **errp into ram_postcopy_incoming_init()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/postcopy-ram.c | 8 ++-- migration/postcopy-ram.h | 2 +- migration/ram.c | 6 +++--- migra

[PATCH 2/2] net: implement vmnet-based netdev

2021-02-04 Thread phillip . ennen
From: Phillip Tennen This patch implements a new netdev device, reachable via -netdev vmnet-macos, that’s backed by macOS’s vmnet framework. The vmnet framework provides native bridging support, and its usage in this patch is intended as a replacement for attempts to use a tap device via the tun

[PATCH 13/33] migration: push Error **errp into loadvm_postcopy_handle_run()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/migration/savev

[PATCH 05/33] migration: push Error **errp into qemu_loadvm_state_main()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/colo.c | 3 +- migration/savevm.c | 73 +++--- migration/save

[PATCH 16/33] migration: push Error **errp into loadvm_handle_recv_bitmap()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git

[PATCH 06/33] migration: push Error **errp into qemu_loadvm_section_start_full()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. This is particularly useful for loading snapshots as this is a likely error scenario to hit when the source and dest VM configs do not match. This is illu

Re: [PULL 11/24] tcg/optimize: Use tcg_constant_internal with constant folding

2021-02-04 Thread Eric Blake
On 2/4/21 10:29 AM, David Hildenbrand wrote: >> +++ b/tcg/s390/tcg-target.c.inc >> @@ -1094,10 +1094,16 @@ static int tgen_cmp(TCGContext *s, TCGType type, >> TCGCond c, TCGReg r1, >>   op = (is_unsigned ? RIL_CLFI : RIL_CFI); >>   tcg_out_insn_RIL(s, op, r1, c2); >

[PATCH 17/33] migration: push Error **errp into loadvm_process_enable_colo()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- include/migration/colo.h | 2 +- migration/migration.c| 6 +++--- migration/savevm.c | 25 +++-

[PATCH 08/33] migration: push Error **errp into loadvm_process_command()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 87 ++ 1 file changed, 64 insertions(+), 23 delet

Re: [RFC PATCH v4 0/7] eBPF RSS support for virtio-net

2021-02-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210204170951.91805-1-and...@daynix.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210204170951.91805-1-and...@daynix.com Subject: [RFC PATCH v4 0/7] eBPF RSS support for vi

[PATCH 25/33] migration: push Error **errp into qemu_savevm_state_complete_precopy()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/migration/save

Re: [PATCH v5 3/3] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-02-04 Thread Greg Kurz
On Thu, 4 Feb 2021 15:02:08 + Stefan Hajnoczi wrote: > A well-behaved FUSE client does not attempt to open special files with > FUSE_OPEN because they are handled on the client side (e.g. device nodes > are handled by client-side device drivers). > > The check to prevent virtiofsd from open

[PATCH 09/33] migration: push Error **errp into loadvm_handle_cmd_packaged()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/m

[PATCH 22/33] migration: push Error **errp into qemu_savevm_state_iterate()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/migration.c | 8 +++- migration/savevm.c| 47 ++- migra

[PATCH 01/33] migration: push Error **errp into qemu_loadvm_state()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/migration.c | 4 ++-- migration/savevm.c| 36 migration/savevm

[PATCH 00/33] migration: capture error reports into Error object

2021-02-04 Thread Daniel P . Berrangé
Due to its long term heritage most of the migration code just invokes 'error_report' when problems hit. This was fine for HMP, since the messages get redirected from stderr, into the HMP console. It is not OK for QMP because the errors will not be fed back to the QMP client. This wasn't a terrible

[PATCH 15/33] migration: make loadvm_postcopy_handle_resume() void

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/migration/s

[PATCH 29/33] migration: push Error **errp into qemu_savevm_live_state()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/colo.c | 4 +++- migration/savevm.c | 8 migration/savevm.h | 2 +- 3 files changed, 8 insert

[PATCH 03/33] migration: push Error **errp into qemu_loadvm_state_setup()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/migration/savevm.c b

[PATCH 02/33] migration: push Error **errp into qemu_loadvm_state_header()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff -

[PATCH 18/33] migration: push Error **errp into colo_init_ram_cache()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/ram.c| 11 ++- migration/ram.h| 2 +- migration/savevm.c | 8 +++- 3 files changed

[PATCH 27/33] migration: push Error **errp into qemu_savevm_state_complete_precopy()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/migration.c | 14 +++--- migration/savevm.c| 18 +++--- migration/savevm.h|

[PATCH 10/33] migration: push Error **errp into loadvm_postcopy_handle_advise()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 43 +-- 1 file changed, 21 insertions(+), 22 deletion

[PATCH 07/33] migration: push Error **errp into qemu_loadvm_section_part_end()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git

[PATCH 20/33] migration: push Error **errp into global_state_store()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- include/migration/global_state.h | 2 +- migration/global_state.c | 6 +++--- migration/migration.c

[PATCH 33/33] migration: push Error **errp into postcopy_do_resume()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/migration.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/migrati

[PATCH 21/33] migration: remove error reporting from qemu_fopen_bdrv() callers

2021-02-04 Thread Daniel P . Berrangé
This method cannot fail since it merely allocates a single struct, so the only possible failure (ENOMEM) will cause an abort() already. Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/migration/savevm.c b/migrat

[PATCH 14/33] migration: push Error **errp into loadvm_postcopy_ram_handle_discard()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff -

[PATCH 24/33] migration: push Error **errp into qemu_savevm_state_setup()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. In doing this the callers now actually honour the failures that can be reported instead of carrying on as if everything was normal. Signed-off-by: Daniel

[PATCH 0/2] net/macos: implement vmnet-based network device

2021-02-04 Thread phillip . ennen
From: Phillip Tennen This patch series implements a new netdev device, reachable via -netdev vmnet-macos, that’s backed by macOS’s vmnet framework. The vmnet framework provides native bridging support, and its usage in this patch is intended as a replacement for attempts to use a tap device via

[PATCH 19/33] migration: push Error **errp into check_section_footer()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/mi

[PATCH 23/33] migration: simplify some error reporting in save_snapshot()

2021-02-04 Thread Daniel P . Berrangé
Re-arrange code to remove need for a separate 'ret2' variable, accepting the duplicated qemu_fclose() call as resulting in clearer code to follow the flow of. Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --

[PATCH 28/33] migration: push Error **errp into qemu_savevm_send_packaged()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/migration.c | 4 +++- migration/savevm.c| 9 + migration/savevm.h| 3 ++- 3 files change

Re: [PATCH v14 0/5] UFFD write-tracking migration/snapshots

2021-02-04 Thread Andrey Gruzdev
On 04.02.2021 18:01, Dr. David Alan Gilbert wrote: * Andrey Gruzdev (andrey.gruz...@virtuozzo.com) wrote: This patch series is a kind of 'rethinking' of Denis Plotnikov's ideas he's implemented in his series '[PATCH v0 0/4] migration: add background snapshot'. Currently the only way to make (ex

[PATCH 31/33] migration: push Error **errp into qemu_savevm_state_resume_prepare()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/migration.c | 9 - migration/savevm.c| 5 +++-- migration/savevm.h| 2 +- 3 files change

[PATCH 32/33] migration: push Error **errp into postcopy_resume_handshake()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/migration.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/migration/m

[Bug 1914638] [NEW] [OSS-Fuzz] Issue 30219: Global-buffer-overflow in mode_sense_page

2021-02-04 Thread Alexander Bulekov
Public bug reported: == Reproducer (build with --enable-sanitizers) == cat << EOF | ./qemu-system-i386 -machine q35 -nodefaults \ -device megasas -device scsi-cd,drive=null0 \ -blockdev driver=null-co,read-zeroes=on,node-name=null0 \ -nographic -qtest stdio outl 0xcf8 0x8818 outl 0xcfc 0xc000

[PATCH 26/33] migration: push Error **errp into qemu_savevm_state_complete_precopy_non_iterable()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a

[PATCH 30/33] migration: push Error **errp into qemu_save_device_state()

2021-02-04 Thread Daniel P . Berrangé
This is an incremental step in converting vmstate loading code to report via Error objects instead of printing directly to the console/monitor. Signed-off-by: Daniel P. Berrangé --- migration/colo.c | 2 +- migration/savevm.c | 51 -- migration/save

Re: [PULL 11/24] tcg/optimize: Use tcg_constant_internal with constant folding

2021-02-04 Thread Richard Henderson
On 2/4/21 6:29 AM, David Hildenbrand wrote: > On 04.02.21 17:04, Philippe Mathieu-Daudé wrote: >> On 2/4/21 10:37 AM, David Hildenbrand wrote: >>> On 04.02.21 10:29, Richard W.M. Jones wrote: >> commit 8f17a975e60b773d7c366a81c0d9bbe304f30859 >> Author: Richard Henderson >> Date:   Mon

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Philippe Mathieu-Daudé
On 2/4/21 3:40 PM, Paolo Bonzini wrote: > On 04/02/21 15:22, Wainer dos Santos Moschetta wrote: -F: docs/interop/virtfs-proxy-helper.rst +F: docs/tools/virtfs-proxy-helper.rst >>> >>> Unrelated, but Paolo once said helpers are not tools. > > I think helpers is not a good word.  However,

Re: [PATCH v14 0/5] UFFD write-tracking migration/snapshots

2021-02-04 Thread Andrey Gruzdev
On 04.02.2021 19:53, Dr. David Alan Gilbert wrote: * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: * Andrey Gruzdev (andrey.gruz...@virtuozzo.com) wrote: This patch series is a kind of 'rethinking' of Denis Plotnikov's ideas he's implemented in his series '[PATCH v0 0/4] migration: add ba

Re: [PULL v2 00/27] Block patches

2021-02-04 Thread Peter Maydell
On Thu, 4 Feb 2021 at 15:43, Stefan Hajnoczi wrote: > > The following changes since commit db754f8ccaf2f073c9aed46a4389e9c0c2080399: > > Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210202' > into staging (2021-02-03 19:35:57 +) > > are available in the Git repository at

Re: gitlab containers are broken

2021-02-04 Thread Daniel P . Berrangé
On Thu, Feb 04, 2021 at 07:36:19AM -1000, Richard Henderson wrote: > On 2/4/21 12:00 AM, Daniel P. Berrangé wrote: > >>> Hmm. Is there any way to get the full output of the container build? At > >>> present it's being truncated: > >>> > >>> #7 [4/5] RUN yum install -y bzip2 bzip2-devel cc

Re: gitlab containers are broken

2021-02-04 Thread Richard Henderson
On 2/4/21 12:00 AM, Daniel P. Berrangé wrote: >>> Hmm. Is there any way to get the full output of the container build? At >>> present it's being truncated: >>> >>> #7 [4/5] RUN yum install -y bzip2 bzip2-devel ccache >>> csnappy-de... >>> >>> >>> In particular, I'm trying to add a ne

Re: [PATCH v5 0/3] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-02-04 Thread Dr. David Alan Gilbert
* no-re...@patchew.org (no-re...@patchew.org) wrote: > Patchew URL: > https://patchew.org/QEMU/20210204150208.367837-1-stefa...@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20210204150

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Paolo Bonzini
On 04/02/21 18:37, Philippe Mathieu-Daudé wrote: - elf2dmp and rdmacm-mux should be in tools/, probably it's in contrib/ because nobody uses it and there's no tests so it might bitrot. Why keep something nobody uses? Well, not really nobody but no maintainer. Paolo

Re: [PATCH v2 04/93] tcg: Manage splitwx in tc_ptr_to_region_tree by hand

2021-02-04 Thread Richard Henderson
On 2/4/21 5:01 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> The use in tcg_tb_lookup is given a random pc that comes from the pc >> of a signal handler. Do not assert that the pointer is already within >> the code gen buffer at all, much less the writable mirror of it. > > Surely

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Philippe Mathieu-Daudé
On 2/4/21 4:06 PM, Daniel P. Berrangé wrote: > On Thu, Feb 04, 2021 at 04:02:01PM +0100, Paolo Bonzini wrote: >> On 04/02/21 15:50, Peter Maydell wrote: >>> On Thu, 4 Feb 2021 at 14:47, Daniel P. Berrangé wrote: The distinction of contrib/ vs tools/ is supposed to be more a reflection on

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Paolo Bonzini
On 04/02/21 18:42, Philippe Mathieu-Daudé wrote: On 2/4/21 3:40 PM, Paolo Bonzini wrote: On 04/02/21 15:22, Wainer dos Santos Moschetta wrote: -F: docs/interop/virtfs-proxy-helper.rst +F: docs/tools/virtfs-proxy-helper.rst Unrelated, but Paolo once said helpers are not tools. I think helper

Re: iotest 30 failing

2021-02-04 Thread Peter Maydell
On Thu, 4 Feb 2021 at 17:48, Philippe Mathieu-Daudé wrote: > > Hi, > > Based on commit 1ed9228f63e (ericb/tags/pull-nbd-2021-02-02-v2) > I got: > > TEST iotest-qcow2: 030 [fail] Yes; see also this thread: https://lore.kernel.org/qemu-devel/9e71568c-ce4a-f844-fbd3-a4a59f850...@redhat.com/ Can

Re: [PATCH v2 29/93] tcg/tci: Remove TCG_CONST

2021-02-04 Thread Richard Henderson
On 2/4/21 5:39 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> Only allow registers or constants, but not both, in any >> given position. > > Aren't we switching to all registers (there are no more _i functions > after this)? I guess you mean the registers can have constants in them?

Re: [PATCH] Set icon for QEMU binary on Mac OS

2021-02-04 Thread Paolo Bonzini
On 04/02/21 16:42, Peter Maydell wrote: On Thu, 4 Feb 2021 at 15:39, Programmingkid wrote: On Feb 4, 2021, at 3:54 AM, Paolo Bonzini wrote: On 02/02/21 14:44, John Arbuckle wrote: Before switching the build system over to Meson, an icon was added to the QEMU binary on Mac OS. This patch

Re: [PATCH v2 79/93] tcg/tci: Split out tcg_out_op_{rrm,rrrm,rrrrm}

2021-02-04 Thread Richard Henderson
On 2/4/21 4:54 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> Signed-off-by: Richard Henderson >> --- >> tcg/tci/tcg-target.c.inc | 70 >> ++-- > > Hmm duplicate patch tripped up my mail tools, did send-email have a > brain fart at 79/93? > Send

[PATCH] exec/cpu-defs: Remove TCG backends dependency

2021-02-04 Thread Philippe Mathieu-Daudé
"exec/cpu-defs.h" contains common CPU definitions for accelerators, which is not related to the TCG backends. See tcg/README description: 4) Backend tcg-target.h contains the target specific definitions. tcg-target.c.inc contains the target specific code; it is #included by tcg/tcg.c, rathe

Re: [PATCH v5 0/3] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-02-04 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > v4: > * Patch 1: Return positive errno if openat(2) fails in lo_do_open() [Greg] > * Patch 3: Return -fd instead or -errno after lo_inode_open() in > lo_do_open() [Greg] > * Patch 3: Use De Morgan's Law to simplify the boolean expression in > lo

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Eric Blake
On 2/4/21 8:22 AM, Wainer dos Santos Moschetta wrote: > Unrelated too, but allow me to ask: > > Should we move the tools (qemu-img, qemu-io, qemu-nbd...etc) to the > tools directory (virtiofsd seems to feel alone there)? No complaint by me for qemu-nbd (I had floated the idea before the meson co

Re: [PATCH] exec/cpu-defs: Remove TCG backends dependency

2021-02-04 Thread Paolo Bonzini
On 04/02/21 19:03, Philippe Mathieu-Daudé wrote: "exec/cpu-defs.h" contains common CPU definitions for accelerators, which is not related to the TCG backends. See tcg/README description: Most of the definitions are actually for TCG, not for all accelerators (the TLB mostly). However, they're

Re: [PATCH 00/33] migration: capture error reports into Error object

2021-02-04 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > Due to its long term heritage most of the migration code just invokes > 'error_report' when problems hit. This was fine for HMP, since the > messages get redirected from stderr, into the HMP console. It is not > OK for QMP because the errors will

[PATCH] tcg/s390: Fix compare instruction from extended-immediate facility

2021-02-04 Thread Philippe Mathieu-Daudé
The code is currently comparing c2 to the type promotion of uint32_t and int32_t. That is, the conversion rules are as: (common_type) c2 == (common_type) (uint32_t) (is_unsigned ? (uint32_t)c2 : (uint32_t)(int32_t)c2) In th

Re: [PATCH v3 0/3]

2021-02-04 Thread Doug Evans
On Thu, Feb 4, 2021 at 2:03 AM Daniel P. Berrangé wrote: > On Wed, Feb 03, 2021 at 03:35:36PM -0800, dje--- via wrote: > > Add support for ipv6 host forwarding > > > > This patchset takes the original patch from Maxim, > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg569573.html > > and

Re: [PATCH V6 0/6] hw/block/nvme: support multi-path for ctrl/ns

2021-02-04 Thread Klaus Jensen
On Jan 24 11:54, Minwoo Im wrote: > > Minwoo Im (6): > hw/block/nvme: introduce nvme-subsys device > hw/block/nvme: support to map controller to a subsystem > hw/block/nvme: add CMIC enum value for Identify Controller > hw/block/nvme: support for multi-controller in subsystem > hw/block/

Re: [PATCH V6 0/6] hw/block/nvme: support multi-path for ctrl/ns

2021-02-04 Thread Klaus Jensen
On Feb 4 19:31, Klaus Jensen wrote: > On Jan 24 11:54, Minwoo Im wrote: > > > > Minwoo Im (6): > > hw/block/nvme: introduce nvme-subsys device > > hw/block/nvme: support to map controller to a subsystem > > hw/block/nvme: add CMIC enum value for Identify Controller > > hw/block/nvme: supp

Re: gitlab containers are broken

2021-02-04 Thread Richard Henderson
On 2/4/21 7:37 AM, Daniel P. Berrangé wrote: > On Thu, Feb 04, 2021 at 07:36:19AM -1000, Richard Henderson wrote: >> On 2/4/21 12:00 AM, Daniel P. Berrangé wrote: > Hmm. Is there any way to get the full output of the container build? At > present it's being truncated: > > #7 [4/5]

[PULL 2/5] virtiofsd: optionally return inode pointer from lo_do_lookup()

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Stefan Hajnoczi lo_do_lookup() finds an existing inode or allocates a new one. It increments nlookup so that the inode stays alive until the client releases it. Existing callers don't need the struct lo_inode so the function doesn't return it. Extend the function to optionally return the i

[PULL 0/5] virtiofs queue: Security fix

2021-02-04 Thread Dr. David Alan Gilbert (git)
s://gitlab.com/dagrh/qemu.git tags/pull-virtiofs-20210204 for you to fetch changes up to cf269ff8032392bbdd700e7bfd21823ad9eee3a9: virtiofsd: Add restart_syscall to the seccomp whitelist (2021-02-04 17:50:08 +) virtiofs: Secu

<    1   2   3   4   5   6   >