Re: [PATCH v2 27/93] tcg/tci: Fix TCG_REG_R4 misusage

2021-02-04 Thread Alex Bennée
Richard Henderson writes: > This was removed from tcg_target_reg_alloc_order and > tcg_target_call_iarg_regs on the assumption that it > was the stack. This was incorrectly copied from i386. > For tci, the stack is R15. > > By adding R4 back to tcg_target_call_iarg_regs, adjust the other > ent

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Daniel P . Berrangé
On Thu, Feb 04, 2021 at 02:50:08PM +, Peter Maydell wrote: > On Thu, 4 Feb 2021 at 14:47, Daniel P. Berrangé wrote: > > The distinction of contrib/ vs tools/ is supposed to be more a > > reflection on the quality of the program. > > > > contrib/ should be considered demo-ware, no back compat g

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Daniel P . Berrangé
On Thu, Feb 04, 2021 at 04:02:01PM +0100, Paolo Bonzini wrote: > On 04/02/21 15:50, Peter Maydell wrote: > > On Thu, 4 Feb 2021 at 14:47, Daniel P. Berrangé wrote: > > > The distinction of contrib/ vs tools/ is supposed to be more a > > > reflection on the quality of the program. > > > > > > cont

Re: [PATCH v2 0/4] migration: Fixes and cleanups aroung migrate-set-parameters

2021-02-04 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > v2: > * Rebased > * PATCH 1 dropped. Fixes a crash bug. Daniel asked me to modify the > fix. Unfortunately, I don't understand this anymore, and don't have > the time & energy to start over. > * PATCH 4 dropped. Plugs a hole in input validati

Re: [PATCH v2 26/93] tcg/tci: Restrict TCG_TARGET_NB_REGS to 16

2021-02-04 Thread Alex Bennée
Richard Henderson writes: > As noted in several comments, 8 regs is not enough for 32-bit > to perform calls, as currently implemented. Shortly, we will > rearrange the encoding which will make 32 regs impossible. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Benné

Re: [PULL 0/9] QMP patches patches for 2021-02-04

2021-02-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210204140136.2769065-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210204140136.2769065-1-arm...@redhat.com Subject: [PULL 0/9] QMP patches patches for 20

Re: [PATCH v4 04/14] qapi/introspect.py: guard against ifcond/comment misuse

2021-02-04 Thread Markus Armbruster
John Snow writes: > On 2/3/21 9:08 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> _tree_to_qlit is called recursively on dict values alone; at such a >>> point in generating output it is too late to apply an ifcond. Similarly, >>> comments do not necessarily have a "tidy" place they c

Re: [PATCH v2 28/93] tcg/tci: Use bool in tcg_out_ri*

2021-02-04 Thread Alex Bennée
Richard Henderson writes: > This is the intended behavior. Remove the assert on > the specific value passed, which can now never be > anything besides false/true (0/1). > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v11 00/12] migration: bring improved savevm/loadvm/delvm to QMP

2021-02-04 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00866.html > v2: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg07523.html > v3: https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg07076.html > v4: https://lists.gnu

Re: [PATCH 0/2] migration blocker information

2021-02-04 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > Hi, > This is a rework of 'migration: Provide a test for migratability', > based on Eric's feedback this is now an addition to the existing > info/query migrate commands rather than a new command. >

Re: [PULL 0/9] QMP patches patches for 2021-02-04

2021-02-04 Thread Peter Maydell
On Thu, 4 Feb 2021 at 14:01, Markus Armbruster wrote: > > The following changes since commit db754f8ccaf2f073c9aed46a4389e9c0c2080399: > > Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210202' > into staging (2021-02-03 19:35:57 +) > > are available in the Git repository

Re: iotest failures in head [was: [PATCH v4 00/16] 64bit block-layer: part I]

2021-02-04 Thread Peter Maydell
On Wed, 3 Feb 2021 at 10:45, Peter Maydell wrote: > > On Tue, 2 Feb 2021 at 22:47, Peter Maydell wrote: > > > > On Tue, 2 Feb 2021 at 17:09, Vladimir Sementsov-Ogievskiy > > wrote: > > > Note that 30 is known to crash sometimes. Look at > > > > > > "[PATCH RFC 0/5] Fix accidental crash in iotest

Re: TCG and MTTCG questions

2021-02-04 Thread Shinkevich Andrey
+ qemu-arm@, qemu-devel@, richard.henderson@ Dear Alex, Thank you so much for your quick response and for answering my questions. It was helpful.I would like to subscribe for the mailing list regarding the TCG, MTTCG and ARM development progress in QEMU.To see what I could contribute, I will want t

Re: [PATCH v2 28/93] tcg/tci: Use bool in tcg_out_ri*

2021-02-04 Thread Alex Bennée
Richard Henderson writes: > This is the intended behavior. Remove the assert on > the specific value passed, which can now never be > anything besides false/true (0/1). > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v11 12/12] migration: introduce snapshot-{save, load, delete} QMP commands

2021-02-04 Thread Dr. David Alan Gilbert
This is (intermittently?) failing for me because of ordering issues: --- /home/dgilbert/git/migpull/tests/qemu-iotests/tests/internal-snapshots-qapi.out +++ internal-snapshots-qapi.out.bad @@ -344,8 +344,8 @@ "vmstate": "diskfmt0",

Re: [PATCH v11 12/12] migration: introduce snapshot-{save, load, delete} QMP commands

2021-02-04 Thread Daniel P . Berrangé
On Thu, Feb 04, 2021 at 03:34:33PM +, Dr. David Alan Gilbert wrote: > This is (intermittently?) failing for me because of ordering issues: > > --- > /home/dgilbert/git/migpull/tests/qemu-iotests/tests/internal-snapshots-qapi.out > +++ internal-snapshots-qapi.out.bad > @@ -344,8 +344,8 @@ >

Re: [PATCH] Set icon for QEMU binary on Mac OS

2021-02-04 Thread Programmingkid
> On Feb 4, 2021, at 3:54 AM, Paolo Bonzini wrote: > > On 02/02/21 14:44, John Arbuckle wrote: >> Before switching the build system over to Meson, an icon was >> added to the QEMU binary on Mac OS. This patch adds back that >> feature. >> Signed-off-by: John Arbuckle >> --- >> meson.build |

Re: [PATCH v4 08/14] qapi/introspect.py: create a typed 'Annotated' data strutcure

2021-02-04 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, Feb 03, 2021 at 03:47:36PM +0100, Markus Armbruster wrote: >> John Snow writes: >> >> > Presently, we use a tuple to attach a dict containing annotations >> > (comments and compile-time conditionals) to a tree node. This is >> > undesirable because dicts are di

[PATCH] linux-user: add TARGET_SO_{DOMAIN,PROTOCOL}

2021-02-04 Thread Jason A. Donenfeld
These were defined for other platforms but mistakenly left out of mips and generic, so this commit adds them to the places missing. Then it makes them be translated in getsockopt. Signed-off-by: Jason A. Donenfeld --- linux-user/generic/sockbits.h | 3 +++ linux-user/mips/sockbits.h| 2 ++ l

Re: [PATCH v2 29/93] tcg/tci: Remove TCG_CONST

2021-02-04 Thread Alex Bennée
Richard Henderson writes: > Only allow registers or constants, but not both, in any > given position. Aren't we switching to all registers (there are no more _i functions after this)? I guess you mean the registers can have constants in them? > Removing this difference in input will > allow m

[PULL v2 01/27] .github: point Repo Lockdown bot to GitLab repo

2021-02-04 Thread Stefan Hajnoczi
Use the GitLab repo URL as the main repo location in order to reduce load on qemu.org. Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Message-id: 2021015017.156802-2-stefa...@redhat.com Signed-off-by: Stefan Hajnoczi --- .github/lockdown.y

Re: [PATCH] Set icon for QEMU binary on Mac OS

2021-02-04 Thread Peter Maydell
On Thu, 4 Feb 2021 at 15:39, Programmingkid wrote: > > > > > On Feb 4, 2021, at 3:54 AM, Paolo Bonzini wrote: > > > > On 02/02/21 14:44, John Arbuckle wrote: > >> Before switching the build system over to Meson, an icon was > >> added to the QEMU binary on Mac OS. This patch adds back that > >> f

[PULL v2 07/27] multi-process: add the concept description to docs/devel/qemu-multiprocess

2021-02-04 Thread Stefan Hajnoczi
From: John G Johnson Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Message-id: 02a68adef99f5df6a380bf8fd7b90948777e411c.1611938319.git.jag.ra...@oracle.com Signed-off-by: Stefan Hajnoczi --- MAINTAINERS

Re: [PATCH v11 12/12] migration: introduce snapshot-{save,load,delete} QMP commands

2021-02-04 Thread Eric Blake
On 2/4/21 6:48 AM, Daniel P. Berrangé wrote: > savevm, loadvm and delvm are some of the few HMP commands that have never > been converted to use QMP. The reasons for the lack of conversion are > that they blocked execution of the event thread, and the semantics > around choice of disks were ill-def

[PULL v2 04/27] docs: update README to use GitLab repo URLs

2021-02-04 Thread Stefan Hajnoczi
qemu.org is running out of bandwidth and the QEMU project is moving towards a gating CI on GitLab. Use the GitLab repos instead of qemu.org (they will become mirrors). Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-

[PULL v2 10/27] multi-process: Add config option for multi-process QEMU

2021-02-04 Thread Stefan Hajnoczi
From: Jagannathan Raman Add configuration options to enable or disable multiprocess QEMU code Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva Reviewed-by: Stefan Hajnoczi Message-id: 6cc37253e35418ebd7b675a31a3df6e3c7a12dc1.1611938319.git.jag.ra

[PULL v2 00/27] Block patches

2021-02-04 Thread Stefan Hajnoczi
The following changes since commit db754f8ccaf2f073c9aed46a4389e9c0c2080399: Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210202' into staging (2021-02-03 19:35:57 +) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request

[PULL v2 13/27] io: add qio_channel_writev_full_all helper

2021-02-04 Thread Stefan Hajnoczi
From: Elena Ufimtseva Adds qio_channel_writev_full_all() to transmit both data and FDs. Refactors existing code to use this helper. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Acked-by: Daniel P. Berrangé Message

[PULL v2 05/27] pc-bios: update mirror URLs to GitLab

2021-02-04 Thread Stefan Hajnoczi
qemu.org is running out of bandwidth and the QEMU project is moving towards a gating CI on GitLab. Use the GitLab repos instead of qemu.org (they will become mirrors). Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-

[PULL v2 14/27] io: add qio_channel_readv_full_all_eof & qio_channel_readv_full_all helpers

2021-02-04 Thread Stefan Hajnoczi
From: Elena Ufimtseva Adds qio_channel_readv_full_all_eof() and qio_channel_readv_full_all() to read both data and FDs. Refactors existing code to use these helpers. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Acked-by: Daniel P. Berrangé Mes

[PULL v2 02/27] gitmodules: use GitLab repos instead of qemu.org

2021-02-04 Thread Stefan Hajnoczi
qemu.org is running out of bandwidth and the QEMU project is moving towards a gating CI on GitLab. Use the GitLab repos instead of qemu.org (they will become mirrors). Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-

[PULL v2 03/27] gitlab-ci: remove redundant GitLab repo URL command

2021-02-04 Thread Stefan Hajnoczi
It is no longer necessary to point .gitmodules at GitLab repos when running in GitLab CI since they are now used all the time. Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-id: 2021015017.156802-

[PULL v2 15/27] multi-process: define MPQemuMsg format and transmission functions

2021-02-04 Thread Stefan Hajnoczi
From: Elena Ufimtseva Defines MPQemuMsg, which is the message that is sent to the remote process. This message is sent over QIOChannel and is used to command the remote process to perform various tasks. Define transmission functions used by proxy and by remote. Signed-off-by: Jagannathan Raman

[PULL v2 23/27] multi-process: Synchronize remote memory

2021-02-04 Thread Stefan Hajnoczi
From: Jagannathan Raman Add ProxyMemoryListener object which is used to keep the view of the RAM in sync between QEMU and remote process. A MemoryListener is registered for system-memory AddressSpace. The listener sends SYNC_SYSMEM message to the remote process when memory listener commits the ch

[PULL v2 06/27] get_maintainer: update repo URL to GitLab

2021-02-04 Thread Stefan Hajnoczi
qemu.org is running out of bandwidth and the QEMU project is moving towards a gating CI on GitLab. Use the GitLab repos instead of qemu.org (they will become mirrors). Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-

[PULL v2 08/27] multi-process: add configure and usage information

2021-02-04 Thread Stefan Hajnoczi
From: Elena Ufimtseva Adds documentation explaining the command-line arguments needed to use multi-process. Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Reviewed-by: Stefan Hajnoczi Message-id: 49f757a84e5dd6fae14b22544897d1124c5fdbad.1611938

[PULL v2 17/27] multi-process: Associate fd of a PCIDevice with its object

2021-02-04 Thread Stefan Hajnoczi
From: Jagannathan Raman Associate the file descriptor for a PCIDevice in remote process with DeviceState object. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Message-id: f405a2ed5d7518b87bea7c59cfdf334d67e5ee51.16

[PULL v2 24/27] multi-process: create IOHUB object to handle irq

2021-02-04 Thread Stefan Hajnoczi
From: Jagannathan Raman IOHUB object is added to manage PCI IRQs. It uses KVM_IRQFD ioctl to create irqfd to injecting PCI interrupts to the guest. IOHUB object forwards the irqfd to the remote process. Remote process uses this fd to directly send interrupts to the guest, bypassing QEMU. Signed-

[PULL v2 09/27] memory: alloc RAM from file at offset

2021-02-04 Thread Stefan Hajnoczi
From: Jagannathan Raman Allow RAM MemoryRegion to be created from an offset in a file, instead of allocating at offset of 0 by default. This is needed to synchronize RAM between QEMU & remote process. Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva

[PULL v2 11/27] multi-process: setup PCI host bridge for remote device

2021-02-04 Thread Stefan Hajnoczi
From: Jagannathan Raman PCI host bridge is setup for the remote device process. It is implemented using remote-pcihost object. It is an extension of the PCI host bridge setup by QEMU. Remote-pcihost configures a PCI bus which could be used by the remote PCI device to latch on to. Signed-off-by:

[PULL v2 21/27] multi-process: Forward PCI config space acceses to the remote process

2021-02-04 Thread Stefan Hajnoczi
From: Elena Ufimtseva The Proxy Object sends the PCI config space accesses as messages to the remote process over the communication channel Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Reviewed-by: Stefan Hajnoczi Message-id: d3c94f4618813234

[PULL v2 12/27] multi-process: setup a machine object for remote device process

2021-02-04 Thread Stefan Hajnoczi
From: Jagannathan Raman x-remote-machine object sets up various subsystems of the remote device process. Instantiate PCI host bridge object and initialize RAM, IO & PCI memory regions. Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva Reviewed-by: S

[PULL v2 25/27] multi-process: Retrieve PCI info from remote process

2021-02-04 Thread Stefan Hajnoczi
From: Jagannathan Raman Retrieve PCI configuration info about the remote device and configure the Proxy PCI object based on the returned information Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Message-id: 85ee367

[PULL v2 16/27] multi-process: Initialize message handler in remote device

2021-02-04 Thread Stefan Hajnoczi
From: Jagannathan Raman Initializes the message handler function in the remote process. It is called whenever there's an event pending on QIOChannel that registers this function. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan

[PULL v2 27/27] docs: fix Parallels Image "dirty bitmap" section

2021-02-04 Thread Stefan Hajnoczi
From: "Denis V. Lunev" Original specification says that l1 table size if 64 * l1_size, which is obviously wrong. The size of the l1 entry is 64 _bits_, not bytes. Thus 64 is to be replaces with 8 as specification says about bytes. There is also minor tweak, field name is renamed from l1 to l1_ta

Re: [PULL 11/24] tcg/optimize: Use tcg_constant_internal with constant folding

2021-02-04 Thread Philippe Mathieu-Daudé
On 2/4/21 10:37 AM, David Hildenbrand wrote: > On 04.02.21 10:29, Richard W.M. Jones wrote: commit 8f17a975e60b773d7c366a81c0d9bbe304f30859 Author: Richard Henderson Date:   Mon Mar 30 19:52:02 2020 -0700 tcg/optimize: Adjust TempOptInfo allocation The image

[PULL v2 18/27] multi-process: setup memory manager for remote device

2021-02-04 Thread Stefan Hajnoczi
From: Jagannathan Raman SyncSysMemMsg message format is defined. It is used to send file descriptors of the RAM regions to remote device. RAM on the remote device is configured with a set of file descriptors. Old RAM regions are deleted and new regions, each with an fd, is added to the RAM. Sign

Re: getting the console output for s390 cdrom-test?

2021-02-04 Thread Thomas Huth
On 22/01/2021 21.32, Peter Maydell wrote: Hi; I've been looking at why the s390 cdrom test has an intermittent failure on my aarch64 box. Looking at some TCG debug log output I think what is happening is that sometimes execution diverges from a successful run inside virtio_scsi_setup() and we end

[PULL v2 20/27] multi-process: add proxy communication functions

2021-02-04 Thread Stefan Hajnoczi
From: Elena Ufimtseva Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Reviewed-by: Stefan Hajnoczi Message-id: d54edb4176361eed86b903e8f27058363b6c83b3.1611938319.git.jag.ra...@oracle.com Signed-off-by: Stefan Hajnoczi --- include/hw/remote/mpq

[PULL v2 19/27] multi-process: introduce proxy object

2021-02-04 Thread Stefan Hajnoczi
From: Elena Ufimtseva Defines a PCI Device proxy object as a child of TYPE_PCI_DEVICE. Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Reviewed-by: Stefan Hajnoczi Message-id: b5186ebfedf8e557044d09a768846c59230ad3a7.1611938319.git.jag.ra...@ora

Re: [PULL 11/24] tcg/optimize: Use tcg_constant_internal with constant folding

2021-02-04 Thread David Hildenbrand
On 04.02.21 17:04, Philippe Mathieu-Daudé wrote: On 2/4/21 10:37 AM, David Hildenbrand wrote: On 04.02.21 10:29, Richard W.M. Jones wrote: commit 8f17a975e60b773d7c366a81c0d9bbe304f30859 Author: Richard Henderson Date:   Mon Mar 30 19:52:02 2020 -0700 tcg/optimize: Adjust TempOptInfo al

[PULL v2 22/27] multi-process: PCI BAR read/write handling for proxy & remote endpoints

2021-02-04 Thread Stefan Hajnoczi
From: Jagannathan Raman Proxy device object implements handler for PCI BAR writes and reads. The handler uses BAR_WRITE/BAR_READ message to communicate to the remote process with the BAR address and value to be written/read. The remote process implements handler for BAR_WRITE/BAR_READ message. S

Re: [PATCH v4 08/14] qapi/introspect.py: create a typed 'Annotated' data strutcure

2021-02-04 Thread John Snow
On 2/4/21 10:37 AM, Markus Armbruster wrote: Eduardo Habkost writes: On Wed, Feb 03, 2021 at 03:47:36PM +0100, Markus Armbruster wrote: John Snow writes: Presently, we use a tuple to attach a dict containing annotations (comments and compile-time conditionals) to a tree node. This is undes

Re: [PATCH v3 1/3] slirp: Placeholder for libslirp ipv6 hostfwd support

2021-02-04 Thread Eric Blake
On 2/3/21 5:35 PM, dje--- via wrote: > This commit is intended to only contain the slirp submodule change > that adds ipv6 hostfwd support. Missing your signed-off-by, and as written, your authorship would be based on the From: dje--- via header (that looks like our mailing list rewrote things d

[PULL v2 26/27] multi-process: perform device reset in the remote process

2021-02-04 Thread Stefan Hajnoczi
From: Elena Ufimtseva Perform device reset in the remote process when QEMU performs device reset. This is required to reset the internal state (like registers, etc...) of emulated devices Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by

Re: [PATCH 4/4] hw/usb/bus: Remove the "full-path" property

2021-02-04 Thread Thomas Huth
On 04/02/2021 09.36, Gerd Hoffmann wrote: Hi, enum USBDeviceFlags { -USB_DEV_FLAG_FULL_PATH, +USB_DEV_FLAG_FULL_PATH, /* unused since QEMU v6.0 */ Why not just drop it? Any remaining users? I didn't want to change the values of the other members of the enum ... but

Re: [PATCH v4 08/14] qapi/introspect.py: create a typed 'Annotated' data strutcure

2021-02-04 Thread Eduardo Habkost
On Thu, Feb 04, 2021 at 04:37:45PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Wed, Feb 03, 2021 at 03:47:36PM +0100, Markus Armbruster wrote: > >> John Snow writes: > >> > >> > Presently, we use a tuple to attach a dict containing annotations > >> > (comments and compile

[RFC PATCH v4 1/7] net/tap: Added TUNSETSTEERINGEBPF code.

2021-02-04 Thread Andrew Melnychenko
From: Andrew Additional code that will be used for eBPF setting steering routine. Signed-off-by: Andrew Melnychenko --- net/tap-linux.h | 1 + 1 file changed, 1 insertion(+) diff --git a/net/tap-linux.h b/net/tap-linux.h index 2f36d100fc..1d06fe0de6 100644 --- a/net/tap-linux.h +++ b/net/tap-

Re: [PULL 11/24] tcg/optimize: Use tcg_constant_internal with constant folding

2021-02-04 Thread Philippe Mathieu-Daudé
On Thu, Feb 4, 2021 at 5:04 PM Philippe Mathieu-Daudé wrote: > On 2/4/21 10:37 AM, David Hildenbrand wrote: > > On 04.02.21 10:29, Richard W.M. Jones wrote: > commit 8f17a975e60b773d7c366a81c0d9bbe304f30859 > Author: Richard Henderson > Date: Mon Mar 30 19:52:02 2020 -0700 >

[RFC PATCH v4 0/7] eBPF RSS support for virtio-net

2021-02-04 Thread Andrew Melnychenko
This set of patches introduces the usage of eBPF for packet steering and RSS hash calculation: * RSS(Receive Side Scaling) is used to distribute network packets to guest virtqueues by calculating packet hash * Additionally adding support for the usage of RSS with vhost The eBPF works on kernels 5.

[RFC PATCH v4 5/7] virtio-net: Added eBPF RSS to virtio-net.

2021-02-04 Thread Andrew Melnychenko
From: Andrew When RSS is enabled the device tries to load the eBPF program to select RX virtqueue in the TUN. If eBPF can be loaded the RSS will function also with vhost (works with kernel 5.8 and later). Software RSS is used as a fallback with vhost=off when eBPF can't be loaded or when hash pop

Re: [PATCH v5 0/3] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-02-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210204150208.367837-1-stefa...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210204150208.367837-1-stefa...@redhat.com Subject: [PATCH v5 0/3] virtiofsd: prevent o

[PATCH v16 10/23] cpu: move cc->transaction_failed to tcg_ops

2021-02-04 Thread Claudio Fontana
Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson [claudio: wrap target code around CONFIG_TCG and !CONFIG_USER_ONLY] Note: need to be careful with the use of CONFIG_USER_ONLY, avoiding its use in headers used by common_

[PATCH v16 02/23] target/riscv: remove CONFIG_TCG, as it is always TCG

2021-02-04 Thread Claudio Fontana
for now only TCG is allowed as an accelerator for riscv, so remove the CONFIG_TCG use. Signed-off-by: Claudio Fontana Reviewed-by: Alistair Francis Reviewed-by: Alex Bennée --- target/riscv/cpu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/riscv/cpu.c b/target/

[RFC PATCH v4 7/7] MAINTAINERS: Added eBPF maintainers information.

2021-02-04 Thread Andrew Melnychenko
From: Andrew Signed-off-by: Yuri Benditovich Signed-off-by: Andrew Melnychenko --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 00626941f1..5ca9e8f304 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3194,6 +3194,14 @@ S: Maintained F:

Re: [PULL 11/24] tcg/optimize: Use tcg_constant_internal with constant folding

2021-02-04 Thread David Hildenbrand
On 04.02.21 17:04, Philippe Mathieu-Daudé wrote: On 2/4/21 10:37 AM, David Hildenbrand wrote: On 04.02.21 10:29, Richard W.M. Jones wrote: commit 8f17a975e60b773d7c366a81c0d9bbe304f30859 Author: Richard Henderson Date:   Mon Mar 30 19:52:02 2020 -0700 tcg/optimize: Adjust TempOptInfo al

[PATCH v16 18/23] accel: introduce AccelCPUClass extending CPUClass

2021-02-04 Thread Claudio Fontana
add a new optional interface to CPUClass, which allows accelerators to extend the CPUClass with additional accelerator-specific initializations. This will allow to separate the target cpu code that is specific to each accelerator, and register it automatically with object hierarchy lookup dependin

[PATCH v16 00/23] i386 cleanup PART 2

2021-02-04 Thread Claudio Fontana
v15 -> v16: * cpu: Move synchronize_from_tb() to tcg_ops: - adjusted comments (Alex) * cpu: tcg_ops: move to tcg-cpu-ops.h, keep a pointer in CPUClass: - remove forward decl. of AccelCPUClass, should be in a later patch. (Alex) - simplified comment about tcg_ops in struct CPUClass (Alex)

[RFC PATCH v4 6/7] docs: Added eBPF documentation.

2021-02-04 Thread Andrew Melnychenko
From: Andrew Signed-off-by: Yuri Benditovich Signed-off-by: Andrew Melnychenko --- docs/ebpf_rss.rst | 125 ++ 1 file changed, 125 insertions(+) create mode 100644 docs/ebpf_rss.rst diff --git a/docs/ebpf_rss.rst b/docs/ebpf_rss.rst new file mode 1

[RFC PATCH v4 2/7] net: Added SetSteeringEBPF method for NetClientState.

2021-02-04 Thread Andrew Melnychenko
From: Andrew For now, that method supported only by Linux TAP. Linux TAP uses TUNSETSTEERINGEBPF ioctl. Signed-off-by: Andrew Melnychenko --- include/net/net.h | 2 ++ net/tap-bsd.c | 5 + net/tap-linux.c | 13 + net/tap-solaris.c | 5 + net/tap-stub.c| 5

[PATCH v16 20/23] cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn

2021-02-04 Thread Claudio Fontana
move the call to accel_cpu->cpu_realizefn to the general cpu_exec_realizefn from target/i386, so it does not need to be called for every target explicitly as we enable more targets. Signed-off-by: Claudio Fontana --- cpu.c | 6 ++ target/i386/cpu.c | 20 +++- 2 f

[PATCH v16 03/23] accel/tcg: split TCG-only code from cpu_exec_realizefn

2021-02-04 Thread Claudio Fontana
move away TCG-only code, make it compile only on TCG. Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson [claudio: moved the prototypes from hw/core/cpu.h to exec/cpu-all.h] --- include/exec/cpu-all.h | 11 +-- include/hw/core/cpu.h | 2 ++ accel/tcg/

[RFC PATCH v4 4/7] ebpf: Added eBPF RSS loader.

2021-02-04 Thread Andrew Melnychenko
From: Andrew Added function that loads RSS eBPF program. Added stub functions for RSS eBPF loader. Added meson and configuration options. By default, eBPF feature enabled if libbpf is present in the build system. libbpf checked in configuration shell script and meson script. Signed-off-by: Yuri

[RFC PATCH v4 3/7] ebpf: Added eBPF RSS program.

2021-02-04 Thread Andrew Melnychenko
From: Andrew RSS program and Makefile to build it. The bpftool used to generate '.h' file. The data in that file may be loaded by libbpf. EBPF compilation is not required for building qemu. You can use Makefile if you need to regenerate rss.bpf.skeleton.h. Signed-off-by: Yuri Benditovich Signed

[PATCH v16 21/23] accel: introduce new accessor functions

2021-02-04 Thread Claudio Fontana
avoid open coding the accesses to cpu->accel_cpu interfaces, and instead introduce: accel_cpu_instance_init, accel_cpu_realizefn to be used by the targets/ initfn code, and by cpu_exec_realizefn respectively. Signed-off-by: Claudio Fontana --- include/qemu/accel.h | 13 + accel/acc

[PATCH v16 04/23] cpu: Move synchronize_from_tb() to tcg_ops

2021-02-04 Thread Claudio Fontana
From: Eduardo Habkost Signed-off-by: Eduardo Habkost [claudio: wrapped target code in CONFIG_TCG, reworded comments] Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée --- include/hw/core/cpu.h | 22 +- accel/tcg/cpu-exec.c | 4 ++-- target/arm/cpu.c

[PULL 01/27] spapr_pci: Fix memory leak of vmstate_spapr_pci

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Jinhao Gao When VM migrate VMState of spapr_pci, the field(msi_devs) of spapr_pci having a flag of VMS_ALLOC need to allocate memory. If the src doesn't free memory of msi_devs in SaveStateEntry of spapr_pci after QEMUFile save VMState of spapr_pci, it may result in memory leak of msi_devs.

[PATCH v16 01/23] cpu: Introduce TCGCpuOperations struct

2021-02-04 Thread Claudio Fontana
From: Eduardo Habkost The TCG-specific CPU methods will be moved to a separate struct, to make it easier to move accel-specific code outside generic CPU code in the future. Start by moving tcg_initialize(). The new CPUClass.tcg_opts field may eventually become a pointer, but keep it an embedded

[PATCH v16 05/23] cpu: Move cpu_exec_* to tcg_ops

2021-02-04 Thread Claudio Fontana
From: Eduardo Habkost Signed-off-by: Eduardo Habkost [claudio: wrapped target code in CONFIG_TCG] Signed-off-by: Claudio Fontana Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- include/hw/core/cpu.h | 12 ++-- accel/tcg/cpu-

[PATCH v16 08/23] target/arm: do not use cc->do_interrupt for KVM directly

2021-02-04 Thread Claudio Fontana
cc->do_interrupt is in theory a TCG callback used in accel/tcg only, to prepare the emulated architecture to take an interrupt as defined in the hardware specifications, but in reality the _do_interrupt style of functions in targets are also occasionally reused by KVM to prepare the architecture s

[PULL 04/27] migration/qemu-file: Fix maybe uninitialized on qemu_get_buffer_in_place()

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Wainer dos Santos Moschetta Fixed error when compiling migration/qemu-file.c with -Werror=maybe-uninitialized as shown here: ../migration/qemu-file.c: In function 'qemu_get_buffer_in_place': ../migration/qemu-file.c:604:18: error: 'src' may be used uninitialized in this function [-Werror

[PATCH v16 09/23] cpu: move cc->do_interrupt to tcg_ops

2021-02-04 Thread Claudio Fontana
Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- include/hw/core/cpu.h | 4 ++-- accel/tcg/cpu-exec.c| 4 ++-- target/alpha/cpu.c | 2 +- target/arm/cpu.c| 4 ++-- target/arm/cpu_tcg.c|

[PATCH v16 07/23] cpu: Move debug_excp_handler to tcg_ops

2021-02-04 Thread Claudio Fontana
From: Eduardo Habkost Signed-off-by: Eduardo Habkost Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- include/hw/core/cpu.h | 4 ++-- accel/tcg/cpu-exec.c | 4 ++-- target/arm/cpu.c | 2 +- target/i386/tcg/tcg-cpu.c | 2 +- target/l

[PATCH v16 11/23] cpu: move do_unaligned_access to tcg_ops

2021-02-04 Thread Claudio Fontana
make it consistently SOFTMMU-only. Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson [claudio: make the field presence in cpu.h unconditional, removing the ifdefs] --- include/hw/core/cpu.h | 13 +++--

[PULL 09/27] migration: introduce 'userfaultfd-wrlat.py' script

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Andrey Gruzdev Add BCC/eBPF script to analyze userfaultfd write fault latency distribution. Signed-off-by: Andrey Gruzdev Reviewed-by: Peter Xu Message-Id: <20210129101407.103458-6-andrey.gruz...@virtuozzo.com> Signed-off-by: Dr. David Alan Gilbert --- scripts/userfaultfd-wrlat.py | 12

[PATCH v16 13/23] cpu: move adjust_watchpoint_address to tcg_ops

2021-02-04 Thread Claudio Fontana
commit 40612000599e ("arm: Correctly handle watchpoints for BE32 CPUs") introduced this ARM-specific, TCG-specific hack to adjust the address, before checking it with cpu_check_watchpoint. Make adjust_watchpoint_address optional and move it to tcg_ops. Signed-off-by: Claudio Fontana Reviewed-by

[PATCH v16 06/23] cpu: Move tlb_fill to tcg_ops

2021-02-04 Thread Claudio Fontana
From: Eduardo Habkost Signed-off-by: Eduardo Habkost [claudio: wrapped target code in CONFIG_TCG] Signed-off-by: Claudio Fontana Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- include/hw/core/cpu.h | 21 - accel/

[PATCH v16 12/23] physmem: make watchpoint checking code TCG-only

2021-02-04 Thread Claudio Fontana
cpu_check_watchpoint, watchpoint_address_matches are TCG-only. Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée --- softmmu/physmem.c | 141 +++--- 1 file changed, 72 insertions(+), 69 deletions(-) diff --git a/softmmu/physmem.c b/softmmu/physmem.

Re: [PATCH v3 1/3] slirp: Placeholder for libslirp ipv6 hostfwd support

2021-02-04 Thread Doug Evans
On Thu, Feb 4, 2021 at 8:02 AM Eric Blake wrote: > On 2/3/21 5:35 PM, dje--- via wrote: > > This commit is intended to only contain the slirp submodule change > > that adds ipv6 hostfwd support. > > > Missing your signed-off-by, and as written, your authorship would be > based on the From: dje---

[PATCH v16 16/23] accel: extend AccelState and AccelClass to user-mode

2021-02-04 Thread Claudio Fontana
Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée [claudio: rebased on Richard's splitwx work] Signed-off-by: Claudio Fontana --- include/hw/boards.h| 2 +- include/{sysemu => qemu}/accel.h | 14 + include/sysemu/hvf.h | 2 +- include/sysemu/kvm.

[PATCH v16 14/23] cpu: move debug_check_watchpoint to tcg_ops

2021-02-04 Thread Claudio Fontana
commit 568496c0c0f1 ("cpu: Add callback to check architectural") and commit 3826121d9298 ("target-arm: Implement checking of fired") introduced an ARM-specific hack for cpu_check_watchpoint. Make debug_check_watchpoint optional, and move it to tcg_ops. Signed-off-by: Claudio Fontana Reviewed-by:

[PATCH v16 19/23] i386: split cpu accelerators from cpu.c, using AccelCPUClass

2021-02-04 Thread Claudio Fontana
i386 is the first user of AccelCPUClass, allowing to split cpu.c into: cpu.ccpuid and common x86 cpu functionality host-cpu.c host x86 cpu functions and "host" cpu type kvm/kvm-cpu.cKVM x86 AccelCPUClass hvf/hvf-cpu.cHVF x86 AccelCPUClass tcg/tcg-cpu.cTCG x86 AccelCPU

[PULL 15/27] migration: Display the migration blockers

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Update 'info migrate' to display migration blocking information. If the outbound migration is not blocked, there is no change, however if it is blocked a message is displayed with a list of reasons why, e.g. qemu-system-x86_64 -nographic -smp 4 -m 4G -M pc,usb=on

[PATCH v16 22/23] target/i386: fix host_cpu_adjust_phys_bits error handling

2021-02-04 Thread Claudio Fontana
move the check for phys_bits outside of host_cpu_adjust_phys_bits, because otherwise it is impossible to return an error condition explicitly. Signed-off-by: Claudio Fontana Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- target/i386/host-cpu.c | 22 -- 1 f

[PATCH v16 17/23] accel: replace struct CpusAccel with AccelOpsClass

2021-02-04 Thread Claudio Fontana
This will allow us to centralize the registration of the cpus.c module accelerator operations (in accel/accel-softmmu.c), and trigger it automatically using object hierarchy lookup from the new accel_init_interfaces() initialization step, depending just on which accelerators are available in the

[PULL 03/27] vmstate: Fix memory leak in vmstate_handle_alloc()

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Jinhao Gao Some memory allocated for fields having a flag of VMS_ALLOC in SaveState may not free before VM load vmsd in migration. So we pre-free memory before allocation in vmstate_handle_alloc() to avoid memleaks. Reported-by: Euler Robot Signed-off-by: Jinhao Gao Signed-off-by: Michae

[PATCH v16 15/23] cpu: tcg_ops: move to tcg-cpu-ops.h, keep a pointer in CPUClass

2021-02-04 Thread Claudio Fontana
we cannot in principle make the TCG Operations field definitions conditional on CONFIG_TCG in code that is included by both common_ss and specific_ss modules. Therefore, what we can do safely to restrict the TCG fields to TCG-only builds, is to move all tcg cpu operations into a separate header fi

[PULL 17/27] migration: Make save_snapshot() return bool, not 0/-1

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: Philippe Mathieu-Daudé Just for consistency, following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), return a boolean value indicating an error is set or not. Reviewed-by: Dr. David Alan Gilbert Acked-by: Pavel Dovgalyuk Signed-off-by: Philippe

[PULL 00/27] migration queue

2021-02-04 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit 1ba089f2255bfdb071be3ce6ac6c3069e8012179: Merge remote-tracking branch 'remotes/armbru/tags/pull-qmp-2021-02-04' into staging (2021-02-04 14:15:35 +) are available in the Git repository at: git://github.com/dagrh/qemu.g

[PATCH v16 23/23] accel-cpu: make cpu_realizefn return a bool

2021-02-04 Thread Claudio Fontana
overall, all devices' realize functions take an Error **errp, but return void. hw/core/qdev.c code, which realizes devices, therefore does: local_err = NULL; dc->realize(dev, &local_err); if (local_err != NULL) { goto fail; } However, we can improve at least accel_cpu to return a meaningful

<    1   2   3   4   5   6   >