[PATCH 0/4] ACPI related fixes

2021-02-04 Thread isaku . yamahata
From: Isaku Yamahata Miscellaneous bug fixes related to ACPI to play nice with guest BIOSes/OSes by conforming to ACPI spec better. Isaku Yamahata (3): acpi/core: always set SCI_EN when SMM isn't supported acpi: set fadt.smi_cmd to zero when SMM is not supported hw/i386: declare ACPI mothe

[PATCH 2/4] acpi: set fadt.smi_cmd to zero when SMM is not supported

2021-02-04 Thread isaku . yamahata
From: Isaku Yamahata >From table 5.9 SMI_CMD of ACPI spec > This field is reserved and must be zero on system > that does not support System Management mode. So when smm is not enabled, set it to zero to comform to the spec. Signed-off-by: Isaku Yamahata --- hw/i386/acpi-build.c | 8 +---

[PATCH 3/4] hw/i386: declare ACPI mother board resource for MMCONFIG region

2021-02-04 Thread isaku . yamahata
From: Isaku Yamahata Declare PNP0C01 device to reserve MMCONFIG region to conform to the spec better and play nice with guest BIOSes/OSes. According to PCI Firmware Specification, MMCONFIG region must be reserved by declaring a motherboard resource. It's optional to reserve the region in memory

[PATCH 1/4] acpi/core: always set SCI_EN when SMM isn't supported

2021-02-04 Thread isaku . yamahata
From: Isaku Yamahata If SMM is not supported, ACPI fixed hardware doesn't support legacy-mode. ACPI-only platform. Where SCI_EN in PM1_CNT register is always set. The bit tells OS legacy mode(SCI_EN cleared) or ACPI mode(SCI_EN set). ACPI spec 4.8.10.1 PM1 Event Grouping PM1 Eanble Registers > F

Re: gitlab containers are broken

2021-02-04 Thread Thomas Huth
On 04/02/2021 07.27, Richard Henderson wrote: On 2/3/21 8:03 PM, Thomas Huth wrote: On 04/02/2021 00.04, Richard Henderson wrote: Something has gone wrong with the building of the containers in gitlab, because *all* off them are installing Alpine Linux. https://gitlab.com/rth7680/qemu/-/jobs/1

[PATCH 4/4] i386: acpi: Don't build HPET ACPI entry if HPET is disabled

2021-02-04 Thread isaku . yamahata
From: Sean Christopherson Omit HPET AML if the HPET is disabled, QEMU is not emulating it and the guest may get confused by seeing HPET in the ACPI tables without a "physical" device present. Signed-off-by: Sean Christopherson --- hw/i386/acpi-build.c | 8 ++-- 1 file changed, 6 insertions

Re: [PATCH 0/4] ACPI related fixes

2021-02-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1612424814.git.isaku.yamah...@intel.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1612424814.git.isaku.yamah...@intel.com Subject: [PATCH 0/4] ACPI related fixes

Re: [PATCH] arm: xlnx-versal: fix virtio-mmio base address assignment

2021-02-04 Thread Philippe Mathieu-Daudé
Hi, Please Cc the maintainers when posting your patch: ./scripts/get_maintainer.pl -f hw/arm/xlnx-versal-virt.c Alistair Francis (maintainer:Xilinx ZynqMP and...) "Edgar E. Iglesias" (maintainer:Xilinx ZynqMP and...) Peter Maydell (maintainer:Xilinx ZynqMP and...) qemu-...@nongnu.org (open lis

Re: [PATCH v4 2/3] virtiofsd: optionally return inode pointer from lo_do_lookup()

2021-02-04 Thread Greg Kurz
On Wed, 3 Feb 2021 17:00:06 + Stefan Hajnoczi wrote: > On Wed, Feb 03, 2021 at 03:20:14PM +0100, Greg Kurz wrote: > > On Wed, 3 Feb 2021 11:37:18 + > > Stefan Hajnoczi wrote: > > > > > lo_do_lookup() finds an existing inode or allocates a new one. It > > > increments nlookup so that th

Re: [PATCH v2 23/36] block: adapt bdrv_append() for inserting filters

2021-02-04 Thread Vladimir Sementsov-Ogievskiy
04.02.2021 00:33, Kevin Wolf wrote: Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: bdrv_append is not very good for inserting filters: it does extra permission update as part of bdrv_set_backing_hd(). During this update filter may conflict with other parents of top_bs. Ins

Re: [PATCH 11/20] ui: add an optional get_flags callback to GraphicHwOps

2021-02-04 Thread Gerd Hoffmann
On Thu, Feb 04, 2021 at 02:21:02AM +0400, Marc-André Lureau wrote: > On Wed, Feb 3, 2021 at 7:48 PM Gerd Hoffmann wrote: > > > > +static int > > > +virtio_gpu_get_flags(void *opaque) > > > +{ > > > +VirtIOGPUBase *g = opaque; > > > +int flags = GRAPHIC_FLAGS_NONE; > > > + > > > +if (v

Re: [PATCH 4/4] hw/usb/bus: Remove the "full-path" property

2021-02-04 Thread Gerd Hoffmann
Hi, > enum USBDeviceFlags { > -USB_DEV_FLAG_FULL_PATH, > +USB_DEV_FLAG_FULL_PATH, /* unused since QEMU v6.0 */ Why not just drop it? Any remaining users? take care, Gerd

Re: [PATCH v4 06/14] qapi/introspect.py: replace 'extra' dict with 'comment' argument

2021-02-04 Thread Markus Armbruster
John Snow writes: > On 2/3/21 9:23 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> This is only used to pass in a dictionary with a comment already set, so >>> skip the runaround and just accept the comment. >>> >>> This works because _tree_to_qlit() treats 'if': None; 'comment': None

Re:Re: [PATCH] blockjob: Fix crash with IOthread when block commit after snapshot

2021-02-04 Thread Michael Qiu
Hi, Kevin Any comments about this patch? The lock release action is added by the commit 132ada80 "block: Adjust AioContexts when attaching nodes" My patch is to avoid some crash case., and indeed touch the code about that commit. Thanks, Michael At 2021-02-03 15:45:07, "Vladimir Sementsov-

Re: [PULL 11/24] tcg/optimize: Use tcg_constant_internal with constant folding

2021-02-04 Thread David Hildenbrand
On 04.02.21 08:55, David Hildenbrand wrote: On 04.02.21 07:41, David Hildenbrand wrote: Am 04.02.2021 um 03:22 schrieb Richard Henderson : On 2/1/21 10:45 AM, Richard W.M. Jones wrote: This commit breaks running certain s390x binaries, at least the "mount" command (or a library it uses) bre

Re: [PATCH 1/3] tests/acceptance: Move the pseries test to a separate file

2021-02-04 Thread Philippe Mathieu-Daudé
Hi Thomas, On 1/13/21 6:30 AM, Thomas Huth wrote: > On 12/01/2021 19.50, Wainer dos Santos Moschetta wrote: >> Hi, >> >> On 1/12/21 1:40 PM, Thomas Huth wrote: >>> Let's gather the POWER-related tests in a separate file. >> >> >> Did you consider having others ppc/ppc64 boot tests together too? >>

Re: [PATCH 4/4] i386: acpi: Don't build HPET ACPI entry if HPET is disabled

2021-02-04 Thread Philippe Mathieu-Daudé
On 2/4/21 9:04 AM, isaku.yamah...@gmail.com wrote: > From: Sean Christopherson > > Omit HPET AML if the HPET is disabled, QEMU is not emulating it and the > guest may get confused by seeing HPET in the ACPI tables without a > "physical" device present. > > Signed-off-by: Sean Christopherson > -

Re: [RFC 08/10] vhost: Add x-vhost-enable-shadow-vq qmp

2021-02-04 Thread Eugenio Perez Martin
On Tue, Feb 2, 2021 at 4:38 PM Eric Blake wrote: > > On 1/29/21 2:54 PM, Eugenio Pérez wrote: > > Command to enable shadow virtqueue looks like: > > > > { "execute": "x-vhost-enable-shadow-vq", "arguments": { "name": "dev0", > > "enable": true } } > > > > Signed-off-by: Eugenio Pérez > > --- > >

Re: [PULL 11/24] tcg/optimize: Use tcg_constant_internal with constant folding

2021-02-04 Thread Richard W.M. Jones
On Thu, Feb 04, 2021 at 09:38:45AM +0100, David Hildenbrand wrote: > On 04.02.21 08:55, David Hildenbrand wrote: > >On 04.02.21 07:41, David Hildenbrand wrote: > >> > >>>Am 04.02.2021 um 03:22 schrieb Richard Henderson > >>>: > >>> > >>>On 2/1/21 10:45 AM, Richard W.M. Jones wrote: > This com

Re: [PATCH 01/12] ui: Replace the word 'whitelist'

2021-02-04 Thread Philippe Mathieu-Daudé
On 2/3/21 11:04 AM, Daniel P. Berrangé wrote: > On Tue, Feb 02, 2021 at 09:58:13PM +0100, Philippe Mathieu-Daudé wrote: >> Follow the inclusive terminology from the "Conscious Language in your >> Open Source Projects" guidelines [*] and replace the words "whitelist" >> appropriately. >> >> [*] http

Re: [PATCH] arm: xlnx-versal: fix virtio-mmio base address assignment

2021-02-04 Thread schspa
On Thu, 2021-02-04 at 09:19 +0100, Philippe Mathieu-Daudé wrote: > Hi, > > Please Cc the maintainers when posting your patch: > > ./scripts/get_maintainer.pl -f hw/arm/xlnx-versal-virt.c > Alistair Francis (maintainer:Xilinx ZynqMP > and...) > "Edgar E. Iglesias" (maintainer:Xilinx > ZynqMP > a

Re: [PATCH v2 23/36] block: adapt bdrv_append() for inserting filters

2021-02-04 Thread Kevin Wolf
Am 04.02.2021 um 09:30 hat Vladimir Sementsov-Ogievskiy geschrieben: > 04.02.2021 00:33, Kevin Wolf wrote: > > Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > int bdrv_append(BlockDriverState *bs_new, BlockDriverState *bs_top, > > > Error **errp) > > >

Re: [PATCH 09/12] qemu-options: Replace the word 'blacklist'

2021-02-04 Thread Philippe Mathieu-Daudé
On 2/3/21 11:25 AM, Daniel P. Berrangé wrote: > On Tue, Feb 02, 2021 at 09:58:21PM +0100, Philippe Mathieu-Daudé wrote: >> Follow the inclusive terminology from the "Conscious Language in your >> Open Source Projects" guidelines [*] and replace the word "blacklist" >> appropriately. >> >> [*] https

Re: [PULL 11/24] tcg/optimize: Use tcg_constant_internal with constant folding

2021-02-04 Thread David Hildenbrand
On 04.02.21 10:03, Richard W.M. Jones wrote: On Thu, Feb 04, 2021 at 09:38:45AM +0100, David Hildenbrand wrote: On 04.02.21 08:55, David Hildenbrand wrote: On 04.02.21 07:41, David Hildenbrand wrote: Am 04.02.2021 um 03:22 schrieb Richard Henderson : On 2/1/21 10:45 AM, Richard W.M. Jones

[Bug 1912224] Re: qemu may freeze during drive-mirroring on fragmented FS

2021-02-04 Thread Alexandre arents
It helps a lot, and it goes fast ! live block migration of 400GB raw disk: master 1130s (362MB/s) qemu unstable/frozen master+fix 445s (920MB/s) qemu stable Thanks Max, It will be nice to have this one merged. -- You received this bug notification because you are a member of qemu- deve

Re: [RFC 05/10] vhost: Add vhost_dev_from_virtio

2021-02-04 Thread Eugenio Perez Martin
On Thu, Feb 4, 2021 at 4:14 AM Jason Wang wrote: > > > On 2021/2/2 下午6:17, Eugenio Perez Martin wrote: > > On Tue, Feb 2, 2021 at 4:31 AM Jason Wang wrote: > >> > >> On 2021/2/1 下午4:28, Eugenio Perez Martin wrote: > >>> On Mon, Feb 1, 2021 at 7:13 AM Jason Wang wrote: > On 2021/1/30 上午4:54,

Re: [PULL 11/24] tcg/optimize: Use tcg_constant_internal with constant folding

2021-02-04 Thread Richard W.M. Jones
> > commit 8f17a975e60b773d7c366a81c0d9bbe304f30859 > > Author: Richard Henderson > > Date: Mon Mar 30 19:52:02 2020 -0700 > > > > tcg/optimize: Adjust TempOptInfo allocation > > > > The image boots just fine on s390x/TCG as well. > > Let me try this in a minute on my original test machin

Re: [PULL 11/24] tcg/optimize: Use tcg_constant_internal with constant folding

2021-02-04 Thread Richard W.M. Jones
I have this s390 machine for another 99 hours now, so if you want me to test patches then send them my way. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit vir

Re: [PATCH v2] virtiofsd: vu_dispatch locking should never fail

2021-02-04 Thread Stefan Hajnoczi
On Wed, Feb 03, 2021 at 07:24:34PM +0100, Greg Kurz wrote: > pthread_rwlock_rdlock() and pthread_rwlock_wrlock() can fail if a > deadlock condition is detected or the current thread already owns > the lock. They can also fail, like pthread_rwlock_unlock(), if the > mutex wasn't properly initialized

Re: [PULL 11/24] tcg/optimize: Use tcg_constant_internal with constant folding

2021-02-04 Thread David Hildenbrand
On 04.02.21 10:29, Richard W.M. Jones wrote: commit 8f17a975e60b773d7c366a81c0d9bbe304f30859 Author: Richard Henderson Date: Mon Mar 30 19:52:02 2020 -0700 tcg/optimize: Adjust TempOptInfo allocation The image boots just fine on s390x/TCG as well. Let me try this in a minute on my ori

Re: [PULL 16/21] hw/timer: Refactor NPCM7XX Timer to use CLK clock

2021-02-04 Thread Philippe Mathieu-Daudé
Hi, On Tue, Jan 12, 2021 at 6:20 PM Peter Maydell wrote: > > From: Hao Wu > > This patch makes NPCM7XX Timer to use a the timer clock generated by the > CLK module instead of the magic number TIMER_REF_HZ. > > Reviewed-by: Havard Skinnemoen > Reviewed-by: Tyrone Ting > Signed-off-by: Hao Wu >

Re: [PATCH 02/12] qga: Rename config key 'blacklist' as 'denylist'

2021-02-04 Thread Michal Suchánek
Hello, On Tue, Feb 02, 2021 at 09:58:14PM +0100, Philippe Mathieu-Daudé wrote: > Follow the inclusive terminology from the "Conscious Language in your > Open Source Projects" guidelines [*] and replace the word "blacklist" > appropriately. > > [*] https://github.com/conscious-lang/conscious-lang-

Re: [PATCH v4 2/3] virtiofsd: optionally return inode pointer from lo_do_lookup()

2021-02-04 Thread Stefan Hajnoczi
On Thu, Feb 04, 2021 at 09:25:28AM +0100, Greg Kurz wrote: > On Wed, 3 Feb 2021 17:00:06 + > Stefan Hajnoczi wrote: > > > On Wed, Feb 03, 2021 at 03:20:14PM +0100, Greg Kurz wrote: > > > On Wed, 3 Feb 2021 11:37:18 + > > > Stefan Hajnoczi wrote: > > > > > > > lo_do_lookup() finds an ex

Re: [PATCH v15 00/23] i386 cleanup PART 2

2021-02-04 Thread Claudio Fontana
On 2/3/21 11:07 PM, Alex Bennée wrote: > For patch 17 on onwards it was just seeing what the actual benefit of > the derived class was - I think I get it later on but you should > mention it up front. > > I do think we need to address the ordering constraint in 21 - are we > introducing one or jus

Re: [PATCH v4 3/3] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-02-04 Thread Stefan Hajnoczi
On Wed, Feb 03, 2021 at 04:14:41PM -0500, Vivek Goyal wrote: > On Wed, Feb 03, 2021 at 05:05:14PM +, Stefan Hajnoczi wrote: > > On Wed, Feb 03, 2021 at 11:08:58AM -0500, Vivek Goyal wrote: > > > On Wed, Feb 03, 2021 at 05:02:37PM +0100, Greg Kurz wrote: > > > > On Wed, 3 Feb 2021 10:28:50 -0500

Re: [PATCH v3] target/i386/hvf: add vmware-cpuid-freq cpu feature

2021-02-04 Thread Roman Bolshakov
On Fri, Jan 22, 2021 at 06:05:18PM +0300, yaroshchuk2...@gmail.com wrote: > From: Vladislav Yaroshchuk > > For `-accel hvf` cpu_x86_cpuid() is wrapped with hvf_cpu_x86_cpuid() to > add paravirtualization cpuid leaf 0x4010 > https://lkml.org/lkml/2008/10/1/246 > > Leaf 0x4010, Timing Info

Re: [PATCH] trace: add meson custom_target() depend_files for tracetool

2021-02-04 Thread Philippe Mathieu-Daudé
On 1/27/21 9:56 PM, Philippe Mathieu-Daudé wrote: > Hi Stefan, > > On Mon, Jan 25, 2021 at 5:40 PM Philippe Mathieu-Daudé > wrote:> >> On 1/25/21 12:09 PM, Stefan Hajnoczi wrote: >>> Re-generate tracetool output when the tracetool source code changes. Use >>> the same approach as qapi_gen_depends

Re: [PATCH v21 00/20] Initial support for multi-process Qemu

2021-02-04 Thread Daniel P . Berrangé
On Wed, Feb 03, 2021 at 12:02:05PM -0800, Elena Ufimtseva wrote: > On Wed, Feb 03, 2021 at 04:11:50PM +, Stefan Hajnoczi wrote: > > On Fri, Jan 29, 2021 at 11:46:01AM -0500, Jagannathan Raman wrote: > > > This is the v21 of the patchset. This version has the following changes: > > > > The docs

[PULL 00/27] Block patches

2021-02-04 Thread Stefan Hajnoczi
The following changes since commit 77f3804ab7ed94b471a14acb260e5aeacf26193f: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2021-02-02 16:47:51 +) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request for you

Re: [PATCH v2 2/2] net: Add -ipv6-hostfwd option, ipv6_hostfwd_add/remove commands

2021-02-04 Thread Daniel P . Berrangé
On Wed, Feb 03, 2021 at 01:37:29PM -0800, dje--- via wrote: > These are identical to their ipv4 counterparts, but for ipv6. > > Signed-off-by: Doug Evans > --- > hmp-commands.hx | 28 ++ > include/net/slirp.h | 2 + > net/slirp.c | 129 +

[PULL 01/27] .github: point Repo Lockdown bot to GitLab repo

2021-02-04 Thread Stefan Hajnoczi
Use the GitLab repo URL as the main repo location in order to reduce load on qemu.org. Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Message-id: 2021015017.156802-2-stefa...@redhat.com Signed-off-by: Stefan Hajnoczi --- .github/lockdown.y

[PULL 15/27] multi-process: define MPQemuMsg format and transmission functions

2021-02-04 Thread Stefan Hajnoczi
From: Elena Ufimtseva Defines MPQemuMsg, which is the message that is sent to the remote process. This message is sent over QIOChannel and is used to command the remote process to perform various tasks. Define transmission functions used by proxy and by remote. Signed-off-by: Jagannathan Raman

[PULL 02/27] gitmodules: use GitLab repos instead of qemu.org

2021-02-04 Thread Stefan Hajnoczi
qemu.org is running out of bandwidth and the QEMU project is moving towards a gating CI on GitLab. Use the GitLab repos instead of qemu.org (they will become mirrors). Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-

Re: [PATCH v2 00/93] TCI fixes and cleanups

2021-02-04 Thread Peter Maydell
On Thu, 4 Feb 2021 at 01:49, Richard Henderson wrote: > > Almost 7 years ago I detailed 5 major problems in tci[1], of > which three still remain: > > * Unaligned accesses to the bytecode stream, which means > that we immediately SIGBUS on any host requiring alignment. > * Non-portable cal

[PULL 03/27] gitlab-ci: remove redundant GitLab repo URL command

2021-02-04 Thread Stefan Hajnoczi
It is no longer necessary to point .gitmodules at GitLab repos when running in GitLab CI since they are now used all the time. Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-id: 2021015017.156802-

[PULL 16/27] multi-process: Initialize message handler in remote device

2021-02-04 Thread Stefan Hajnoczi
From: Jagannathan Raman Initializes the message handler function in the remote process. It is called whenever there's an event pending on QIOChannel that registers this function. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan

[PULL 05/27] pc-bios: update mirror URLs to GitLab

2021-02-04 Thread Stefan Hajnoczi
qemu.org is running out of bandwidth and the QEMU project is moving towards a gating CI on GitLab. Use the GitLab repos instead of qemu.org (they will become mirrors). Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-

[PULL 11/27] multi-process: setup PCI host bridge for remote device

2021-02-04 Thread Stefan Hajnoczi
From: Jagannathan Raman PCI host bridge is setup for the remote device process. It is implemented using remote-pcihost object. It is an extension of the PCI host bridge setup by QEMU. Remote-pcihost configures a PCI bus which could be used by the remote PCI device to latch on to. Signed-off-by:

[PULL 04/27] docs: update README to use GitLab repo URLs

2021-02-04 Thread Stefan Hajnoczi
qemu.org is running out of bandwidth and the QEMU project is moving towards a gating CI on GitLab. Use the GitLab repos instead of qemu.org (they will become mirrors). Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-

[PULL 26/27] multi-process: perform device reset in the remote process

2021-02-04 Thread Stefan Hajnoczi
From: Elena Ufimtseva Perform device reset in the remote process when QEMU performs device reset. This is required to reset the internal state (like registers, etc...) of emulated devices Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by

[PULL 08/27] multi-process: add configure and usage information

2021-02-04 Thread Stefan Hajnoczi
From: Elena Ufimtseva Adds documentation explaining the command-line arguments needed to use multi-process. Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Reviewed-by: Stefan Hajnoczi Message-id: 49f757a84e5dd6fae14b22544897d1124c5fdbad.1611938

[PULL 10/27] multi-process: Add config option for multi-process QEMU

2021-02-04 Thread Stefan Hajnoczi
From: Jagannathan Raman Add configuration options to enable or disable multiprocess QEMU code Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva Reviewed-by: Stefan Hajnoczi Message-id: 6cc37253e35418ebd7b675a31a3df6e3c7a12dc1.1611938319.git.jag.ra

[PULL 06/27] get_maintainer: update repo URL to GitLab

2021-02-04 Thread Stefan Hajnoczi
qemu.org is running out of bandwidth and the QEMU project is moving towards a gating CI on GitLab. Use the GitLab repos instead of qemu.org (they will become mirrors). Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-

Re: gitlab containers are broken

2021-02-04 Thread Daniel P . Berrangé
On Thu, Feb 04, 2021 at 09:08:13AM +0100, Thomas Huth wrote: > On 04/02/2021 07.27, Richard Henderson wrote: > > On 2/3/21 8:03 PM, Thomas Huth wrote: > > > On 04/02/2021 00.04, Richard Henderson wrote: > > > > Something has gone wrong with the building of the containers > > > > in gitlab, because

[PULL 18/27] multi-process: setup memory manager for remote device

2021-02-04 Thread Stefan Hajnoczi
From: Jagannathan Raman SyncSysMemMsg message format is defined. It is used to send file descriptors of the RAM regions to remote device. RAM on the remote device is configured with a set of file descriptors. Old RAM regions are deleted and new regions, each with an fd, is added to the RAM. Sign

[PULL 07/27] multi-process: add the concept description to docs/devel/qemu-multiprocess

2021-02-04 Thread Stefan Hajnoczi
From: John G Johnson Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Message-id: 02a68adef99f5df6a380bf8fd7b90948777e411c.1611938319.git.jag.ra...@oracle.com Signed-off-by: Stefan Hajnoczi --- MAINTAINERS

[PULL 12/27] multi-process: setup a machine object for remote device process

2021-02-04 Thread Stefan Hajnoczi
From: Jagannathan Raman x-remote-machine object sets up various subsystems of the remote device process. Instantiate PCI host bridge object and initialize RAM, IO & PCI memory regions. Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva Reviewed-by: S

[PULL 19/27] multi-process: introduce proxy object

2021-02-04 Thread Stefan Hajnoczi
From: Elena Ufimtseva Defines a PCI Device proxy object as a child of TYPE_PCI_DEVICE. Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Reviewed-by: Stefan Hajnoczi Message-id: b5186ebfedf8e557044d09a768846c59230ad3a7.1611938319.git.jag.ra...@ora

[PULL 09/27] memory: alloc RAM from file at offset

2021-02-04 Thread Stefan Hajnoczi
From: Jagannathan Raman Allow RAM MemoryRegion to be created from an offset in a file, instead of allocating at offset of 0 by default. This is needed to synchronize RAM between QEMU & remote process. Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva

[PULL 17/27] multi-process: Associate fd of a PCIDevice with its object

2021-02-04 Thread Stefan Hajnoczi
From: Jagannathan Raman Associate the file descriptor for a PCIDevice in remote process with DeviceState object. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Message-id: f405a2ed5d7518b87bea7c59cfdf334d67e5ee51.16

[PULL 21/27] multi-process: Forward PCI config space acceses to the remote process

2021-02-04 Thread Stefan Hajnoczi
From: Elena Ufimtseva The Proxy Object sends the PCI config space accesses as messages to the remote process over the communication channel Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Reviewed-by: Stefan Hajnoczi Message-id: d3c94f4618813234

Re: [PATCH v4 17/18] migration/rdma: send data for both rdma-pin-all and NOT rdma-pin-all mode

2021-02-04 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > Signed-off-by: Zhimin Feng > Signed-off-by: Chuan Zheng > --- > migration/rdma.c | 65 > > 1 file changed, 61 insertions(+), 4 deletions(-) > > diff --git a/migration/rdma.c b/migration/rdma

Re: [PULL 00/24] tcg patch queue

2021-02-04 Thread Peter Maydell
On Wed, 3 Feb 2021 at 02:15, Richard Henderson wrote: > > The following changes since commit 77f3804ab7ed94b471a14acb260e5aeacf26193f: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2021-02-02 16:47:51 +) > > are available in the Git repository at: > >

[PULL 20/27] multi-process: add proxy communication functions

2021-02-04 Thread Stefan Hajnoczi
From: Elena Ufimtseva Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Reviewed-by: Stefan Hajnoczi Message-id: d54edb4176361eed86b903e8f27058363b6c83b3.1611938319.git.jag.ra...@oracle.com Signed-off-by: Stefan Hajnoczi --- include/hw/remote/mpq

[PULL 23/27] multi-process: Synchronize remote memory

2021-02-04 Thread Stefan Hajnoczi
From: Jagannathan Raman Add ProxyMemoryListener object which is used to keep the view of the RAM in sync between QEMU and remote process. A MemoryListener is registered for system-memory AddressSpace. The listener sends SYNC_SYSMEM message to the remote process when memory listener commits the ch

[PULL 13/27] io: add qio_channel_writev_full_all helper

2021-02-04 Thread Stefan Hajnoczi
From: Elena Ufimtseva Adds qio_channel_writev_full_all() to transmit both data and FDs. Refactors existing code to use this helper. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Acked-by: Daniel P. Berrangé Message

[PULL 22/27] multi-process: PCI BAR read/write handling for proxy & remote endpoints

2021-02-04 Thread Stefan Hajnoczi
From: Jagannathan Raman Proxy device object implements handler for PCI BAR writes and reads. The handler uses BAR_WRITE/BAR_READ message to communicate to the remote process with the BAR address and value to be written/read. The remote process implements handler for BAR_WRITE/BAR_READ message. S

Re: [PATCH] qemu-storage-daemon: Enable object-add

2021-02-04 Thread Daniel P . Berrangé
On Thu, Feb 04, 2021 at 08:21:37AM +0100, Kevin Wolf wrote: > As we don't have a fully QAPIfied version of object-add yet and it still > has 'gen': false in the schema, it needs to be registered explicitly in > init_qmp_commands() to be available for users. > > Fixes: 2af282ec51a27116d0402cab237b8

[PULL 14/27] io: add qio_channel_readv_full_all_eof & qio_channel_readv_full_all helpers

2021-02-04 Thread Stefan Hajnoczi
From: Elena Ufimtseva Adds qio_channel_readv_full_all_eof() and qio_channel_readv_full_all() to read both data and FDs. Refactors existing code to use these helpers. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Acked-by: Daniel P. Berrangé Mes

Re: [PULL 00/27] Block patches

2021-02-04 Thread Peter Maydell
On Thu, 4 Feb 2021 at 09:58, Stefan Hajnoczi wrote: > > The following changes since commit 77f3804ab7ed94b471a14acb260e5aeacf26193f: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2021-02-02 16:47:51 +) > > are available in the Git repository at: > > ht

Re: [PATCH v4 15/18] migration/rdma: only register the memory for multifd channels

2021-02-04 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > All data is sent by multifd Channels, so we only register its for > multifd channels and main channel don't register its. > > Signed-off-by: Zhimin Feng > Signed-off-by: Chuan Zheng > --- > migration/rdma.c | 8 > 1 file changed, 8 inserti

[PULL 25/27] multi-process: Retrieve PCI info from remote process

2021-02-04 Thread Stefan Hajnoczi
From: Jagannathan Raman Retrieve PCI configuration info about the remote device and configure the Proxy PCI object based on the returned information Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Message-id: 85ee367

[PULL 24/27] multi-process: create IOHUB object to handle irq

2021-02-04 Thread Stefan Hajnoczi
From: Jagannathan Raman IOHUB object is added to manage PCI IRQs. It uses KVM_IRQFD ioctl to create irqfd to injecting PCI interrupts to the guest. IOHUB object forwards the irqfd to the remote process. Remote process uses this fd to directly send interrupts to the guest, bypassing QEMU. Signed-

[PULL 27/27] docs: fix Parallels Image "dirty bitmap" section

2021-02-04 Thread Stefan Hajnoczi
From: "Denis V. Lunev" Original specification says that l1 table size if 64 * l1_size, which is obviously wrong. The size of the l1 entry is 64 _bits_, not bytes. Thus 64 is to be replaces with 8 as specification says about bytes. There is also minor tweak, field name is renamed from l1 to l1_ta

Re: [PATCH 1/6] travis.yml: Move gprof/gcov test across to gitlab

2021-02-04 Thread Alex Bennée
Thomas Huth writes: > On 03/02/2021 20.32, Wainer dos Santos Moschetta wrote: >> Hi, >> >> On 2/3/21 8:32 AM, Thomas Huth wrote: >>> From: Philippe Mathieu-Daudé >>> >>> Similarly to commit 8cdb2cef3f1, move the gprof/gcov test to GitLab. >>> >>> The coverage-summary.sh script is not Travis-C

Re: [PATCH v3 0/3]

2021-02-04 Thread Daniel P . Berrangé
On Wed, Feb 03, 2021 at 03:35:36PM -0800, dje--- via wrote: > Add support for ipv6 host forwarding > > This patchset takes the original patch from Maxim, > https://www.mail-archive.com/qemu-devel@nongnu.org/msg569573.html > and updates it. > > New option: -ipv6-hostfwd > > New commands: ipv6_hos

Re: [PATCH v15 21/23] hw/core/cpu: call qemu_init_vcpu in cpu_common_realizefn

2021-02-04 Thread Claudio Fontana
On 2/3/21 5:51 PM, Alex Bennée wrote: > > Claudio Fontana writes: > >> move the call to qemu_init_vcpu inside cpu_common_realizefn, >> so it does not need to be done explicitly in each target cpu. >> >> Despite this, the way cpu realize is done continues to be not ideal; >> >> ideally the cpu_li

Re: [PATCH v4 18/18] migration/rdma: RDMA cleanup for multifd migration

2021-02-04 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > Signed-off-by: Chuan Zheng > --- > migration/multifd.c | 6 ++ > migration/multifd.h | 1 + > migration/rdma.c| 16 +++- > 3 files changed, 22 insertions(+), 1 deletion(-) > > diff --git a/migration/multifd.c b/migration/multif

Re: [PATCH 01/22] tests/acceptance/boot_linux.py: fix typo on cloudinit error message

2021-02-04 Thread Alex Bennée
Cleber Rosa writes: > Signed-off-by: Cleber Rosa Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 01/22] tests/acceptance/boot_linux.py: fix typo on cloudinit error message

2021-02-04 Thread Beraldo Leal
On Wed, Feb 03, 2021 at 12:23:36PM -0500, Cleber Rosa wrote: > Signed-off-by: Cleber Rosa > --- > tests/acceptance/boot_linux.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Beraldo Leal

Re: [PATCH 02/22] tests/acceptance/boot_linux.py: rename misleading cloudinit method

2021-02-04 Thread Alex Bennée
Cleber Rosa writes: > There's no downloading happening on that method, so let's call it > "prepare" instead. While at it, and because of it, the current > "prepare_boot" and "prepare_cloudinit" are also renamed. > > The reasoning here is that "prepare_" methods will just work on the > images,

Re: [PATCH 03/22] Acceptance Tests: remove unnecessary tag from documentation example

2021-02-04 Thread Alex Bennée
Cleber Rosa writes: > The ":avocado: enable" is not necessary and was removed in 9531d26c, > so let's remove from the docs. > > Signed-off-by: Cleber Rosa Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 02/22] tests/acceptance/boot_linux.py: rename misleading cloudinit method

2021-02-04 Thread Beraldo Leal
On Wed, Feb 03, 2021 at 12:23:37PM -0500, Cleber Rosa wrote: > There's no downloading happening on that method, so let's call it > "prepare" instead. While at it, and because of it, the current > "prepare_boot" and "prepare_cloudinit" are also renamed. > > The reasoning here is that "prepare_" me

Re: [PATCH 04/22] tests/acceptance/virtiofs_submounts.py: use workdir property

2021-02-04 Thread Alex Bennée
Cleber Rosa writes: > For Avocado Instrumented based tests, it's a better idea to just use > the property. The environment variable is a fall back for tests not > written using that Python API. > > Reference: > https://avocado-framework.readthedocs.io/en/84.0/api/test/avocado.html#avocado.Tes

[PATCH v2 01/20] vhost-user-gpu: check backend for EDID support

2021-02-04 Thread marcandre . lureau
From: Marc-André Lureau EDID has been enabled by default, but the backend may not implement it (such as the contrib backend). This results in extra warnings and potentially other issues in the guest. The option shouldn't probably have been added to VIRTIO_GPU_BASE, but it's a bit too late now, r

[PATCH v2 02/20] vhost-user-gpu: handle vhost-user-gpu features in a callback

2021-02-04 Thread marcandre . lureau
From: Marc-André Lureau Fixes a deadlock where the backend calls QEMU, while QEMU also calls the backend simultaneously, both ends waiting for each other. Signed-off-by: Marc-André Lureau --- contrib/vhost-user-gpu/vugpu.h | 2 +- contrib/vhost-user-gpu/vhost-user-gpu.c | 37

[PATCH v2 06/20] ui: remove gl_ctx_get_current

2021-02-04 Thread marcandre . lureau
From: Marc-André Lureau There are no users left. Signed-off-by: Marc-André Lureau --- include/ui/console.h | 2 -- include/ui/egl-context.h | 1 - include/ui/sdl2.h| 1 - ui/console.c | 6 -- ui/egl-context.c | 5 - ui/egl-headless.c| 1 - ui/gtk

Re: [PATCH 04/22] tests/acceptance/virtiofs_submounts.py: use workdir property

2021-02-04 Thread Beraldo Leal
On Wed, Feb 03, 2021 at 12:23:39PM -0500, Cleber Rosa wrote: > For Avocado Instrumented based tests, it's a better idea to just use > the property. The environment variable is a fall back for tests not > written using that Python API. > > Reference: > https://avocado-framework.readthedocs.io/en/

[PATCH v2 04/20] vhost-user-gpu: handle display-info in a callback

2021-02-04 Thread marcandre . lureau
From: Marc-André Lureau Fixes a deadlock where the backend calls QEMU, while QEMU also calls the backend simultaneously, both ends waiting for each other. Signed-off-by: Marc-André Lureau --- contrib/vhost-user-gpu/vhost-user-gpu.c | 33 - 1 file changed, 27 insertions(

[PATCH v2 03/20] vhost-user-gpu: use an extandable state enum for commands

2021-02-04 Thread marcandre . lureau
From: Marc-André Lureau Introduce a pending state for commands which aren't finished yet, but are being handled. See following patch. Signed-off-by: Marc-André Lureau --- contrib/vhost-user-gpu/vugpu.h | 8 +++- contrib/vhost-user-gpu/vhost-user-gpu.c | 8 contrib/vhost-u

[PATCH v2 08/20] ui: annotate DCLOps callback requirements

2021-02-04 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- include/ui/console.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/ui/console.h b/include/ui/console.h index ce6c72e37c..bea2b6329a 100644 --- a/include/ui/console.h +++ b/include/ui/console.h @@ -17

[PATCH v2 00/20] Various vhost-user-gpu & UI fixes

2021-02-04 Thread marcandre . lureau
From: Marc-André Lureau Hi, Here is a collection of fixes and improvements mostly around vhost-user-gpu. In combination with spice, they work best with the previously sent fixes ("[PATCH 0/2] Fix (non-vga) QXL async screendump" & "[PATCH v2] spice: delay starting until display are initialized").

[PATCH v2 11/20] ui: add an optional get_flags callback to GraphicHwOps

2021-02-04 Thread marcandre . lureau
From: Marc-André Lureau Those flags can be used to express different requirements for the display or other needs. Signed-off-by: Marc-André Lureau --- include/ui/console.h | 9 + hw/display/virtio-gpu-base.c | 18 ++ hw/display/virtio-vga.c | 9 +

[PATCH v2 12/20] ui: add a DCLOps callback to check dmabuf support

2021-02-04 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- include/ui/console.h | 2 ++ ui/console.c | 13 + 2 files changed, 15 insertions(+) diff --git a/include/ui/console.h b/include/ui/console.h index 0595aa9953..875885d9c7 100644 --- a/include/ui/console.h +++ b/in

[PATCH v2 10/20] vhost-user-gpu: add a configuration flag for dmabuf usage

2021-02-04 Thread marcandre . lureau
From: Marc-André Lureau Let's inform VirtioGPUBase that vhost-user-gpu require DMABUF messages. Signed-off-by: Marc-André Lureau --- include/hw/virtio/virtio-gpu.h | 3 +++ hw/display/vhost-user-gpu.c| 2 ++ 2 files changed, 5 insertions(+) diff --git a/include/hw/virtio/virtio-gpu.h b/in

[PATCH v2 05/20] ui: remove extra #ifdef CONFIG_OPENGL

2021-02-04 Thread marcandre . lureau
From: Marc-André Lureau Since commit 5cb69566daa8081abb82a13403dcc0fffed02007 ("gtk: remove CONFIG_GTK_GL"), some #ifdef are redundants. Signed-off-by: Marc-André Lureau --- ui/gtk.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 26665cd2e

[PATCH v2 13/20] ui: check hw requirements during DCL registration

2021-02-04 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/console.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/ui/console.c b/ui/console.c index a645418ada..d8cc640c28 100644 --- a/ui/console.c +++ b/ui/console.c @@ -1476,12 +1476,37 @@ static bool

[PATCH v2 15/20] ui: check gtk-egl dmabuf support

2021-02-04 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- include/ui/gtk.h | 1 + ui/gtk.c | 9 + 2 files changed, 10 insertions(+) diff --git a/include/ui/gtk.h b/include/ui/gtk.h index 7569d090fa..aaef884b95 100644 --- a/include/ui/gtk.h +++ b/include/ui/gtk.h @@ -48,6 +48

[PATCH v2 14/20] ui: add qemu_egl_has_dmabuf helper

2021-02-04 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- include/ui/egl-helpers.h | 1 + ui/egl-helpers.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/include/ui/egl-helpers.h b/include/ui/egl-helpers.h index 94a4b3e6f3..5b1f7fafe0 100644 --- a/include/ui/egl-he

[PATCH v2 17/20] virtio-gpu: avoid re-entering cmdq processing

2021-02-04 Thread marcandre . lureau
From: Marc-André Lureau The next patch will notify the GL context got flush, which will resume the queue processing. However, if this happens within the caller context, it will end up with a stack overflow flush/update loop. Signed-off-by: Marc-André Lureau --- include/hw/virtio/virtio-gpu.h |

  1   2   3   4   5   6   >