On 2/3/21 7:59 PM, Richard Henderson wrote:
> This is more descriptive than 'unsigned long'.
> No functional change, since these match on all linux+bsd hosts.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Richard Henderson
> ---
> include/exec/cpu-all.h | 2 +-
> bsd-user/main.c| 4 ++
On 02/03/21 14:18, Paolo Bonzini wrote:
> This property can be useful for distros to set up known-good ROM sizes for
> migration purposes. The VM will fail to start if the ROM is too large,
> and migration compatibility will not be broken if the ROM is too small.
>
> Note that even though romsize
We were fudging TBI1 enabled to speed up the generated code.
Now that we've improved the code generation, remove this.
Also, tidy the comment to reflect the current code.
The pauth test was testing a kernel address (-1) and making
incorrect assumptions about TBI1; stick to userland addresses.
Rev
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
linux-user/aarch64/target_signal.h | 2 ++
linux-user/aarch64/cpu_loop.c | 3 +++
2 files changed, 5 insertions(+)
diff --git a/linux-user/aarch64/target_signal.h
b/linux-user/aarch64/target_signal.h
index ddd73169f0..777fb66
On 2/3/21 9:08 AM, Philippe Mathieu-Daudé wrote:
> On 2/3/21 7:59 PM, Richard Henderson wrote:
>> This is more descriptive than 'unsigned long'.
>> No functional change, since these match on all linux+bsd hosts.
>>
>> Reviewed-by: Peter Maydell
>> Signed-off-by: Richard Henderson
>> ---
>> inclu
A proper syndrome is required to fill in the proper si_code.
Use page_get_flags to determine permission vs translation for user-only.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
linux-user/aarch64/cpu_loop.c | 24 +---
target/arm/tlb_helper.c | 15 +
On Sun, Jan 10, 2021 at 10:56 AM Alexey Baturo wrote:
>
> Signed-off-by: Alexey Baturo
> ---
> target/riscv/cpu.c | 3 +
> target/riscv/cpu.h | 12 ++
> target/riscv/cpu_bits.h | 66 ++
> target/riscv/csr.c | 271
> 4 files chan
On Sun, Jan 10, 2021 at 10:51 AM Alexey Baturo wrote:
>
> Signed-off-by: Alexey Baturo
Reviewed-by: Alistair Francis
Alistair
> ---
> target/riscv/insn_trans/trans_rva.c.inc | 3 +++
> target/riscv/insn_trans/trans_rvd.c.inc | 2 ++
> target/riscv/insn_trans/trans_rvf.c.inc | 2 ++
> targ
Hi,
On 2/3/21 8:32 AM, Thomas Huth wrote:
It's only about compile-testing (there is too much noise when running
the tests), so let's simply add the -fsanitize=thread flag to a job that
only compiles the sources. The "build-gprof-gcov" seems to be a good
candidate.
Signed-off-by: Thomas Huth
--
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/cpu.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index db81a12418..43933550c3 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -204,6 +204,21 @@ static
On Wed, Feb 3, 2021 at 8:10 PM Richard Henderson
wrote:
> On 2/3/21 9:08 AM, Philippe Mathieu-Daudé wrote:
> > On 2/3/21 7:59 PM, Richard Henderson wrote:
> >> This is more descriptive than 'unsigned long'.
> >> No functional change, since these match on all linux+bsd hosts.
> >>
> >> Reviewed-by:
Hi,
On 2/3/21 8:32 AM, Thomas Huth wrote:
From: Philippe Mathieu-Daudé
Similarly to commit 8cdb2cef3f1, move the gprof/gcov test to GitLab.
The coverage-summary.sh script is not Travis-CI specific, make it
generic.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20201108204535.2319870-10
Use the now-saved PAGE_ANON and PAGE_MTE bits,
and the per-page saved data.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/mte_helper.c | 29 +++--
1 file changed, 27 insertions(+), 2 deletions(-)
diff --git a/target/arm/mte_helper.c b/target
On Sun, Jan 10, 2021 at 10:54 AM Alexey Baturo wrote:
>
> Hi folks,
>
> Sorry it took me almost 3 month to provide the reply and fixes: it was a
> really busy EOY.
> This series contains fixed @Alistair suggestion on enabling J-ext.
>
> As for @Richard comments:
> - Indeed I've missed appending r
On Sun, Jan 10, 2021 at 10:53 AM Alexey Baturo wrote:
>
> From: Anatoly Parshintsev
>
> Signed-off-by: Anatoly Parshintsev
> Reviewed-by: Richard Henderson
> ---
> target/riscv/cpu.h | 19 +++
> target/riscv/translate.c | 34 --
> 2 files c
On Wed, 3 Feb 2021 at 14:28, Eric Blake wrote:
>
> The following changes since commit 8360ebeb4f4a707984cafd1a22c049ec82ddcb4c:
>
> Merge remote-tracking branch
> 'remotes/ehabkost-gl/tags/machine-next-pull-request' into staging (2021-02-03
> 09:54:21 +)
>
> are available in the Git reposi
Patchew URL:
https://patchew.org/QEMU/20210203190010.759771-1-richard.hender...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210203190010.759771-1-richard.hender...@linaro.org
Subject: [PATCH v5 00/31]
* Chuan Zheng (zhengch...@huawei.com) wrote:
> Signed-off-by: Chuan Zheng
> ---
> migration/multifd.c | 4 ++--
> migration/multifd.h | 2 ++
> migration/rdma.c| 57
> +
> 3 files changed, 61 insertions(+), 2 deletions(-)
>
> diff --git
On 03.02.21 18:18, Thomas Huth wrote:
This property was only required for compatibility reasons in the
pc-1.0 machine type and earlier. Now that these machine types have
been removed, the property is not useful anymore.
Signed-off-by: Thomas Huth
---
hw/virtio/virtio-balloon-pci.c | 11 +-
On Wed, Feb 03, 2021 at 04:11:50PM +, Stefan Hajnoczi wrote:
> On Fri, Jan 29, 2021 at 11:46:01AM -0500, Jagannathan Raman wrote:
> > This is the v21 of the patchset. This version has the following changes:
>
> The docs/multi-process.rst file caused Sphinx to fail with "document
> isn't includ
On Wed, Feb 03, 2021 at 11:13:40AM -0500, Aaron Lindsay wrote:
> As feature flags are added or removed, the meanings of bits in the
> `features` field can change between QEMU versions, causing migration
> failures. Additionally, migrating the field is not useful because it is
> a constant function
* Chuan Zheng (zhengch...@huawei.com) wrote:
> Add the 'qemu_rdma_registration' function, multifd send threads
> call it to register memory.
This function is a copy of the code out of qemu_rdma_registration_stop;
with some of the comments removed.
It's OK to split this code out so you can use it a
* Chuan Zheng (zhengch...@huawei.com) wrote:
> Signed-off-by: Zhimin Feng
> Signed-off-by: Chuan Zheng
This could do with a description in the commit message of the sequence;
I think you're waiting for the semaphore; doing the registratin, then
waiting again to say that everyone has finished???
On 2/3/21 4:23 PM, Wainer dos Santos Moschetta wrote:
Hi,
On 2/3/21 8:32 AM, Thomas Huth wrote:
It's only about compile-testing (there is too much noise when running
the tests), so let's simply add the -fsanitize=thread flag to a job that
only compiles the sources. The "build-gprof-gcov" seem
* Chuan Zheng (zhengch...@huawei.com) wrote:
> Multifd RDMA is need to poll when we send data, record it.
This looks like it's trying to be the equivalent of the 'static int
next_channel' in multifd_send_pages.
If so, why not mkae this 'multifd_channel' and make the function
'multifd_next_channel
On Wed, Feb 03, 2021 at 07:24:34PM +0100, Greg Kurz wrote:
> pthread_rwlock_rdlock() and pthread_rwlock_wrlock() can fail if a
> deadlock condition is detected or the current thread already owns
> the lock. They can also fail, like pthread_rwlock_unlock(), if the
> mutex wasn't properly initialized
On 2/3/21 10:17 AM, Richard Henderson wrote:
On 2/2/21 6:58 PM, Rebecca Cran wrote:
if (!arm_singlestep_active(env)) {
-env->uncached_cpsr &= ~PSTATE_SS;
+env->pstate &= ~PSTATE_SS;
+} else {
+env->pstate |= PSTATE_SS;
}
Where did
On 2/3/21 10:28 AM, Rebecca Cran wrote:
> On 2/3/21 10:17 AM, Richard Henderson wrote:
>> On 2/2/21 6:58 PM, Rebecca Cran wrote:
>>> if (!arm_singlestep_active(env)) {
>>> - env->uncached_cpsr &= ~PSTATE_SS;
>>> + env->pstate &= ~PSTATE_SS;
>>> + } else {
>>>
On 2/3/21 9:08 AM, Markus Armbruster wrote:
John Snow writes:
_tree_to_qlit is called recursively on dict values alone; at such a
point in generating output it is too late to apply an ifcond. Similarly,
comments do not necessarily have a "tidy" place they can be printed in
such a circumstance.
On 12:30 Mon 01 Feb , Peter Maydell wrote:
> Add a clock_ns_to_ticks() function which does the opposite of
> clock_ticks_to_ns(): given a duration in nanoseconds, it returns the
> number of clock ticks that would happen in that time. This is useful
> for devices that have a free running counte
Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Split out no-perm part of bdrv_root_attach_child() into separate
> transaction action. bdrv_root_attach_child() now moves to new
> permission update paradigm: first update graph relations then update
> permissions.
>
> Signed-o
On Thu, Jan 28, 2021 at 12:51:20PM +0100, Thomas Huth wrote:
> On 19/10/2020 03.49, Cleber Rosa wrote:
> > TL;DR: this should allow the QEMU maintainer to push to the staging
> > branch, and have custom jobs running on the project's aarch64 and
> > s390x machines. Simple usage looks like:
> >
> >
On 12:30 Mon 01 Feb , Peter Maydell wrote:
[snip]
>
> Side note: there is currently no MAINTAINERS entry for the
> clock framework. Any volunteers? It would cover
>
> F: include/hw/clock.h
> F: include/hw/qdev-clock.h
> F: hw/core/clock.c
> F: hw/core/qdev-clock.c
> F: docs/devel/clocks.rst
On Wed, Feb 03, 2021 at 05:05:14PM +, Stefan Hajnoczi wrote:
> On Wed, Feb 03, 2021 at 11:08:58AM -0500, Vivek Goyal wrote:
> > On Wed, Feb 03, 2021 at 05:02:37PM +0100, Greg Kurz wrote:
> > > On Wed, 3 Feb 2021 10:28:50 -0500
> > > Vivek Goyal wrote:
> > >
> > > > On Wed, Feb 03, 2021 at 11:
Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Split part of bdrv_replace_node_common() to be used separately.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> @@ -4909,7 +4936,6 @@ static int bdrv_replace_node_common(BlockDriverState
> *from,
>
On Wed, Feb 03, 2021 at 03:42:54PM -0500, John Snow wrote:
> On 2/3/21 9:08 AM, Markus Armbruster wrote:
> > John Snow writes:
> >
> > > _tree_to_qlit is called recursively on dict values alone; at such a
> > > point in generating output it is too late to apply an ifcond. Similarly,
> > > comment
The virtiofsd.rst file was moved to docs/tools, so this update
MAINTAINERS accordingly.
Fixes: a08b4a9fe6c ("docs: Move tools documentation to tools manual")
Signed-off-by: Wainer dos Santos Moschetta
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINER
On 2/3/21 9:23 AM, Markus Armbruster wrote:
John Snow writes:
This is only used to pass in a dictionary with a comment already set, so
skip the runaround and just accept the comment.
This works because _tree_to_qlit() treats 'if': None; 'comment': None
exactly like absent 'if'; 'comment'.
C
Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben:
> bdrv_append is not very good for inserting filters: it does extra
> permission update as part of bdrv_set_backing_hd(). During this update
> filter may conflict with other parents of top_bs.
>
> Instead, let's first do all grap
This patchset takes the original patch from Maxim,
https://www.mail-archive.com/qemu-devel@nongnu.org/msg569573.html
and updates it.
New option: -ipv6-hostfwd
New commands: ipv6_hostfwd_add, ipv6_hostfwd_remove
These are the ipv6 equivalents of their ipv4 counterparts.
The libslirp part of the
These are identical to their ipv4 counterparts, but for ipv6.
Signed-off-by: Doug Evans
---
hmp-commands.hx | 28 ++
include/net/slirp.h | 2 +
net/slirp.c | 129 +++-
qapi/net.json | 4 ++
4 files changed, 161 insertions(+),
... in preparation for adding ipv6 host forwarding support.
---
net/slirp.c | 200 +---
slirp | 2 +-
2 files changed, 130 insertions(+), 72 deletions(-)
diff --git a/net/slirp.c b/net/slirp.c
index be914c0be0..a21a313302 100644
--- a/net/sl
On 2/3/21 9:30 AM, Markus Armbruster wrote:
John Snow writes:
The types will be used in forthcoming patches to add typing. These types
describe the layout and structure of the objects passed to
_tree_to_qlit, but lack the power to describe annotations until the next
commit.
Signed-off-by: Joh
On Wed, Feb 3, 2021 at 1:37 PM Doug Evans wrote:
> ... in preparation for adding ipv6 host forwarding support.
> ---
> net/slirp.c | 200 +---
> slirp | 2 +-
> 2 files changed, 130 insertions(+), 72 deletions(-)
>
> diff --git a/net/slirp.
Greetings Philippe,
> Sent: Wednesday, February 03, 2021 at 6:48 PM
> From: "Philippe Mathieu-Daudé"
> To: "daggs" , qemu-disc...@nongnu.org
> Cc: "qemu-devel" , "Qemu-block"
> Subject: Re: cdrom scsi passthough not working well
>
> Cc'ing qemu-block@ developers.
>
> On 10/28/20 6:18 AM, daggs
Patchew URL: https://patchew.org/QEMU/20210203213729.1940893-1-...@google.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210203213729.1940893-1-...@google.com
Subject: [PATCH v2 0/2] Add support for ipv6 host for
For patch 17 on onwards it was just seeing what the actual benefit of
the derived class was - I think I get it later on but you should
mention it up front.
I do think we need to address the ordering constraint in 21 - are we
introducing one or just formalising what has been created? If we are
intr
Doug Evans, le mer. 03 févr. 2021 13:37:28 -0800, a ecrit:
> ... in preparation for adding ipv6 host forwarding support.
Reviewed-by: Samuel Thibault
except
> diff --git a/slirp b/slirp
> index 8f43a99191..358c0827d4 16
> --- a/slirp
> +++ b/slirp
> @@ -1 +1 @@
> -Subproject commit 8f43a991
Doug Evans, le mer. 03 févr. 2021 13:37:29 -0800, a ecrit:
> @@ -1392,6 +1392,34 @@ SRST
>Remove host-to-guest TCP or UDP redirection.
> ERST
>
> +#ifdef CONFIG_SLIRP
> +{
> +.name = "ipv6_hostfwd_add",
> +.args_type = "arg1:s,arg2:s?",
> +.params = "[n
On Wed, Feb 03, 2021 at 03:47:36PM +0100, Markus Armbruster wrote:
> John Snow writes:
>
> > Presently, we use a tuple to attach a dict containing annotations
> > (comments and compile-time conditionals) to a tree node. This is
> > undesirable because dicts are difficult to strongly type; promoti
On Wed, Feb 3, 2021 at 7:48 PM Gerd Hoffmann wrote:
> > +static int
> > +virtio_gpu_get_flags(void *opaque)
> > +{
> > +VirtIOGPUBase *g = opaque;
> > +int flags = GRAPHIC_FLAGS_NONE;
> > +
> > +if (virtio_gpu_virgl_enabled(g->conf))
> > +flags |= GRAPHIC_FLAGS_GL;
> > +
> > +
On Wed, Feb 3, 2021 at 2:20 PM Samuel Thibault
wrote:
> Doug Evans, le mer. 03 févr. 2021 13:37:29 -0800, a ecrit:
> > @@ -1392,6 +1392,34 @@ SRST
> >Remove host-to-guest TCP or UDP redirection.
> > ERST
> >
> > +#ifdef CONFIG_SLIRP
> > +{
> > +.name = "ipv6_hostfwd_add",
>
On Wed, Feb 3, 2021 at 2:15 PM Samuel Thibault
wrote:
> Doug Evans, le mer. 03 févr. 2021 13:37:28 -0800, a ecrit:
> > ... in preparation for adding ipv6 host forwarding support.
>
> Reviewed-by: Samuel Thibault
>
> except
>
> > diff --git a/slirp b/slirp
> > index 8f43a99191..358c0827d4 16
Something has gone wrong with the building of the containers
in gitlab, because *all* off them are installing Alpine Linux.
https://gitlab.com/rth7680/qemu/-/jobs/1006336396#L155
I presume that IMAGE is not actually being passed through, and alpine.docker is
lexicographically first.
I have a str
On 2/3/21 9:47 AM, Markus Armbruster wrote:
John Snow writes:
Presently, we use a tuple to attach a dict containing annotations
(comments and compile-time conditionals) to a tree node. This is
undesirable because dicts are difficult to strongly type; promoting it
to a real class allows us to n
On 2/3/21 10:15 AM, Markus Armbruster wrote:
John Snow writes:
Signed-off-by: John Snow
---
scripts/qapi/introspect.py | 115 ++---
scripts/qapi/mypy.ini | 5 --
scripts/qapi/schema.py | 2 +-
3 files changed, 82 insertions(+), 40 deletions(-)
Add support for ipv6 host forwarding
This patchset takes the original patch from Maxim,
https://www.mail-archive.com/qemu-devel@nongnu.org/msg569573.html
and updates it.
New option: -ipv6-hostfwd
New commands: ipv6_hostfwd_add, ipv6_hostfwd_remove
These are the ipv6 equivalents of their ipv4 co
This commit is intended to only contain the slirp submodule change
that adds ipv6 hostfwd support.
---
slirp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/slirp b/slirp
index 8f43a99191..358c0827d4 16
--- a/slirp
+++ b/slirp
@@ -1 +1 @@
-Subproject commit 8f43a99191afb47c
... in preparation for adding ipv6 host forwarding support.
Signed-off-by: Doug Evans
---
net/slirp.c | 200 +---
1 file changed, 129 insertions(+), 71 deletions(-)
diff --git a/net/slirp.c b/net/slirp.c
index be914c0be0..a21a313302 100644
--- a/n
These are identical to their ipv4 counterparts, but for ipv6.
Signed-off-by: Doug Evans
---
hmp-commands.hx | 32 +++
include/net/slirp.h | 2 +
net/slirp.c | 128 +++-
qapi/net.json | 4 ++
4 files changed, 164 insertions(+)
Patchew URL: https://patchew.org/QEMU/20210203233539.1990032-1-...@google.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210203233539.1990032-1-...@google.com
Subject: [PATCH v3 0/3]
=== TEST SCRIPT BEGIN ===
#!
The introspect visitor is stateful, but expects that it will have a
schema to refer to. Add assertions that state this.
Signed-off-by: John Snow
---
scripts/qapi/introspect.py | 5 +
1 file changed, 5 insertions(+)
diff --git a/scripts/qapi/introspect.py b/scripts/qapi/introspect.py
index f
At present, we open-code this in _make_tree itself; but if the structure
of the tree changes, this is brittle. Use an explicit recursive call to
_make_tree when appropriate to help keep the interior node typing
consistent.
A consequence of doing this is that the 'ifcond' key of the features
dict w
Trivial; make the error message just a pinch more explicit in case we
trip this by accident in the future.
Signed-off-by: John Snow
---
scripts/qapi/introspect.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/scripts/qapi/introspect.py b/scripts/qapi/introspect.py
index
_tree_to_qlit is called recursively on dict values (isolated from their
keys); at such a point in generating output it is too late to apply an
ifcond. Similarly, comments do not necessarily have a "tidy" place they
can be printed in such a circumstance.
Forbid this usage by renaming "suppress_firs
_make_tree might receive a dict (a SchemaInfo object) or some other type
(usually, a string) for its obj parameter. Adding features information
should arguably be performed by the caller at such a time when we know
the type of the object and don't have to re-interrogate it.
Signed-off-by: John Sno
Hi, this series adds static type hints to the QAPI module.
This is part two, and covers introspect.py.
Part 2: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt2
Everything: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt6
- Requires Python 3.6+
- Requires mypy 0.770 or newe
The types will be used in forthcoming patches to add typing. These types
describe the layout and structure of the objects passed to
_tree_to_qlit, but lack the power to describe annotations until the next
commit.
Signed-off-by: John Snow
---
scripts/qapi/introspect.py | 30 ++
Presently, we use a tuple to attach a dict containing annotations
(comments and compile-time conditionals) to a tree node. This is
undesirable because dicts are difficult to strongly type; promoting it
to a real class allows us to name the values and types of the
annotations we are expecting.
In t
This is only used to pass in a dictionary with a comment already set, so
skip the runaround and just accept the (optional) comment.
Signed-off-by: John Snow
---
scripts/qapi/introspect.py | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/scripts/qapi/introspect.
Returning two different types conditionally can be complicated to
type. Return one type for consistency.
Signed-off-by: John Snow
---
scripts/qapi/introspect.py | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/scripts/qapi/introspect.py b/scripts/qapi/introspect.py
index a7
Subjective, but I find getting rid of the comprehensions helps. Also,
divide the sections into scalar and non-scalar sections, and remove
old-style string formatting.
Signed-off-by: John Snow
---
scripts/qapi/introspect.py | 33 ++---
1 file changed, 18 insertions(+),
Add some aliases that declare intent for some of the "dictly-typed"
objects we pass around in introspect.py.
Signed-off-by: John Snow
---
This patch is optional, it can be dropped if desired. If it's taken,
it's probably best to squash it with the prior patch. It is purely for
the sake of demo
This mimics how a typed object works, where 'if' and 'comment' are
always set, regardless of if they have a value set or not.
It is safe to do this because of the way that _tree_to_qlit processes
these values (using dict.get with a default of None), resulting in no
change of output from _tree_to_q
Signed-off-by: John Snow
---
See the next patch for an optional amendment that helps to clarify what
_DObject is meant to be.
Signed-off-by: John Snow
---
scripts/qapi/introspect.py | 117 ++---
scripts/qapi/mypy.ini | 5 --
scripts/qapi/schema.py |
Signed-off-by: John Snow
---
scripts/qapi/introspect.py | 8
1 file changed, 8 insertions(+)
diff --git a/scripts/qapi/introspect.py b/scripts/qapi/introspect.py
index 2a39726f40a..2b338abe2cf 100644
--- a/scripts/qapi/introspect.py
+++ b/scripts/qapi/introspect.py
@@ -97,6 +97,14 @@ de
Signed-off-by: John Snow
---
scripts/qapi/introspect.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/qapi/introspect.py b/scripts/qapi/introspect.py
index 2b338abe2cf..fd0ca0aba21 100644
--- a/scripts/qapi/introspect.py
+++ b/scripts/qapi/introspect.py
@@ -1,10 +1
Almost 7 years ago I detailed 5 major problems in tci[1], of
which three still remain:
* Unaligned accesses to the bytecode stream, which means
that we immediately SIGBUS on any host requiring alignment.
* Non-portable calls to helper functions.
* Full of useless ifdefs and TODOs.
To my
The use in tcg_tb_lookup is given a random pc that comes from the pc
of a signal handler. Do not assert that the pointer is already within
the code gen buffer at all, much less the writable mirror of it.
Fixes: db0c51a3803
Signed-off-by: Richard Henderson
---
For TCI, this indicates a bug in ha
Each thread must have its own pc, even under TCI.
Remove the GETPC ifdef, because GETPC is always available for
helpers, and thus is always required. Move the assignment
under INDEX_op_call, because the value is only visible when
we make a call to a helper function.
Signed-off-by: Richard Hender
Allow other places in tcg to restart with a smaller tb.
Signed-off-by: Richard Henderson
---
tcg/tcg.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index 63a12b197b..bbe3dcee03 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -346,6 +346,12 @@ stati
The main problem was that we were treating a guest address
as a host address with a mere cast.
Use the correct interface for accessing guest memory. Do not
allow offset == auxv_len, which would result in an empty packet.
Fixes: 51c623b0de1 ("gdbstub: add support to Xfer:auxv:read: packet")
Signe
From: Stefan Weil
That TCG opcode is used by debian-buster (arm64) running ffmpeg:
qemu-aarch64 /usr/bin/ffmpeg -i theora.mkv theora.webm
Tested-by: Alex Bennée
Reviewed-by: Alex Bennée
Reported-by: Alex Bennée
Signed-off-by: Stefan Weil
Message-Id: <20210128024814.2056958-1...@weilnetz
Tested-by: Alex Bennée
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
tcg/tci.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index 740244cc54..005d2946c4 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@ -117,14 +117,6 @@ tci_write_r
Note that we had two functions of the same name: a 32-bit version
which took two register numbers and a 64-bit version which was a
no-op wrapper for tcg_write_reg. After this, we are left with
only the 32-bit version.
Tested-by: Alex Bennée
Reviewed-by: Alex Bennée
Signed-off-by: Richard Hender
The configure option was backward, and we failed to
pass the value on to meson.
Fixes: 23a77b2d18b ("build-system: clean up TCG/TCI configury")
Tested-by: Stefan Weil
Reviewed-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Philippe Mathieu-Da
For a 64-bit TCI, the upper bits of a 32-bit operation are
undefined (much like a native ppc64 32-bit operation). It
simplifies everything if we don't force-extend the result.
Tested-by: Alex Bennée
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
tcg/tci.c | 66 +
From: Stefan Weil
That TCG opcode is used by debian-buster (arm64) running ffmpeg:
qemu-aarch64 /usr/bin/ffmpeg -i theora.mkv theora.webm
Tested-by: Alex Bennée
Reviewed-by: Alex Bennée
Reported-by: Alex Bennée
Signed-off-by: Stefan Weil
Message-Id: <20210128020425.2055454-1...@weilnetz
Eliminating a TODO for ld16u_i32.
Tested-by: Alex Bennée
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
tcg/tci.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index c31be1a1f4..b64d611ec9 100644
--- a/tcg/tci.c
+++ b/tcg
Tested-by: Alex Bennée
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
tcg/tci.c | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index 0f56702b93..7e108bcbb3 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@ -455,6 +455,18 @@
Tested-by: Alex Bennée
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
tcg/tci.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index e8023b5384..740244cc54 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@ -117,11 +117,6 @@ tci_write_re
Tested-by: Alex Bennée
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
tcg/tci.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index c3a8511dfe..e8023b5384 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@ -117,14 +117,6 @@ tci_write_r
Trivially implemented like other arithmetic.
Tested via check-tcg and the ppc64 target.
Tested-by: Alex Bennée
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
tcg/tci/tcg-target.h | 4 ++--
tcg/tci.c| 28 ++--
tcg/tci/tcg-target.c.inc
We do not simultaneously support div and div2 -- it's one
or the other. TCI is already using div, so remove div2.
Tested-by: Alex Bennée
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
tcg/tci.c| 12
tcg/tci/tcg-target.c.inc | 8
2 files ch
Eliminating a TODO for ld16s_i64.
Tested-by: Alex Bennée
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
tcg/tci.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index b64d611ec9..259a8538bf 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@
Eliminating a TODO for ld8s_i32.
Tested-by: Alex Bennée
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
tcg/tci.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index 7e108bcbb3..c31be1a1f4 100644
--- a/tcg/tci.c
+++ b/tcg/
Use CASE_32_64 and CASE_64 to reduce ifdefs and merge
cases that are identical between 32-bit and 64-bit hosts.
Signed-off-by: Richard Henderson
---
tcg/tci/tcg-target.c.inc | 204 ++-
1 file changed, 73 insertions(+), 131 deletions(-)
diff --git a/tcg/tci/tc
Tested-by: Alex Bennée
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
tcg/tci.c | 8
1 file changed, 8 deletions(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index 5c84a1c979..e0d815e4b2 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@ -33,14 +33,6 @@
#include "tcg/tcg-op.h"
#inclu
Tested-by: Alex Bennée
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
tcg/tci.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index 259a8538bf..55863f76a7 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@ -606,6 +606,7 @@ uintptr_t QEMU_D
Tested-by: Alex Bennée
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
tcg/tci.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index ee2cd7dfa2..eb70672efb 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@ -625,6 +625,7 @@ uintptr_t QEMU_D
301 - 400 of 509 matches
Mail list logo
