On Wed, Feb 03, 2021 at 03:20:14PM +0100, Greg Kurz wrote:
> On Wed, 3 Feb 2021 11:37:18 +
> Stefan Hajnoczi wrote:
>
> > lo_do_lookup() finds an existing inode or allocates a new one. It
> > increments nlookup so that the inode stays alive until the client
> > releases it.
> >
> > Existing
On Wed, Feb 03, 2021 at 11:08:58AM -0500, Vivek Goyal wrote:
> On Wed, Feb 03, 2021 at 05:02:37PM +0100, Greg Kurz wrote:
> > On Wed, 3 Feb 2021 10:28:50 -0500
> > Vivek Goyal wrote:
> >
> > > On Wed, Feb 03, 2021 at 11:37:19AM +, Stefan Hajnoczi wrote:
> > >
> > > [..]
> > > > @@ -1727,36 +
On Wed, Feb 03, 2021 at 04:57:59PM +0100, Greg Kurz wrote:
> On Wed, 3 Feb 2021 11:37:19 +
> Stefan Hajnoczi wrote:
> > static int lo_do_open(struct lo_data *lo, struct lo_inode *inode,
> > - struct fuse_file_info *fi)
> > + int existing_fd, struct f
The pc-1.x machine types have been deprecated since QEMU v5.0 already, and
nobody complained, so they can now be removed. While we're at it, also
remove some compatibility switches and related code that are now not
necessary anymore after these machine types have been removed.
(We could maybe even
On 2/2/21 6:58 PM, Rebecca Cran wrote:
> if (!arm_singlestep_active(env)) {
> -env->uncached_cpsr &= ~PSTATE_SS;
> +env->pstate &= ~PSTATE_SS;
> +} else {
> +env->pstate |= PSTATE_SS;
> }
Where did this addition come from?
r~
On 03.02.21 17:55, Philippe Mathieu-Daudé wrote:
On 1/11/21 3:50 PM, Luc Michel wrote:
Hi,
We would like to work on improving QEMU to be able to create custom
machines from the command line. The goal here is to get feedback from
the community and shape the future developments.
Cc'ing John
On 2/2/21 6:58 PM, Rebecca Cran wrote:
> @@ -9433,8 +9448,9 @@ static void take_aarch32_exception(CPUARMState *env,
> int new_mode,
> * For exceptions taken to AArch32 we must clear the SS bit in both
> * PSTATE and in the old-state value we save to SPSR_, so zero it
> now.
> */
This property was only required for the pc-1.0 and earlier machine
types. Since these have been removed now, we can delete the property
as well.
Signed-off-by: Thomas Huth
---
hw/usb/bus.c | 7 +--
include/hw/usb.h | 2 +-
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/hw
The ":avocado: enable" is not necessary and was removed in 9531d26c,
so let's remove from the docs.
Signed-off-by: Cleber Rosa
---
docs/devel/testing.rst | 3 ---
1 file changed, 3 deletions(-)
diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index 809af69725..209f9d8172 100644
---
This was only required for the pc-1.0 and earlier machine types.
Now that these have been removed, we can also drop the corresponding
code from the FDC device.
Signed-off-by: Thomas Huth
---
hw/block/fdc.c | 17 ++---
tests/qemu-iotests/172.out | 35 --
They have been deprecated since QEMU v5.0, time to remove them now.
Signed-off-by: Thomas Huth
---
docs/system/deprecated.rst | 6 --
docs/system/removed-features.rst | 6 ++
hw/i386/pc_piix.c| 94
3 files changed, 6 insertions(+), 100 del
Tests are supposed to be non-interactive, and ssh-keygen is asking for
a password when creating a key. Let's set an empty key, which prevents
ssh-keygen for asking for a password.
Signed-off-by: Cleber Rosa
---
tests/acceptance/virtiofs_submounts.py | 2 +-
1 file changed, 1 insertion(+), 1 del
Instead of having to cast it whenever it's going to be used, let's
standardize it as an integer, which is the data type that will be
used most often.
Given that the regex will only match digits, it's safe that we'll
end up getting a integer, but, it could as well be a zero.
Signed-off-by: Cleber
This introduces a base class for tests that need to interact with a
Linux guest. It generalizes the "boot_linux.py" code, already been
used by the "virtiofs_submounts.py" and also SSH related code being
used by that and "linux_ssh_mips_malta.py".
While at it, a number of fixes on hopeful improvem
This property was only required for compatibility reasons in the
pc-1.0 machine type and earlier. Now that these machine types have
been removed, the property is not useful anymore.
Signed-off-by: Thomas Huth
---
hw/virtio/virtio-balloon-pci.c | 11 +--
1 file changed, 1 insertion(+), 10
AFAICT, there should not be a situation where IP and port do not have
at least one whitespace character separating them.
This may be true for other '\s*' patterns in the same regex too.
Signed-off-by: Cleber Rosa
---
tests/acceptance/virtiofs_submounts.py | 2 +-
1 file changed, 1 insertion(+),
Signed-off-by: Cleber Rosa
---
tests/acceptance/linux_ssh_mips_malta.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/acceptance/linux_ssh_mips_malta.py
b/tests/acceptance/linux_ssh_mips_malta.py
index 275659c785..ab6cb94aef 100644
--- a/tests/acceptance/linux_ssh
Some tests explicitly require a QEMU accelerator to be available.
Given that this depends on some runtime aspects not known before
the test is started, such as the currently set QEMU binary, it's
left to be checked also at runtime.
Signed-off-by: Cleber Rosa
---
tests/acceptance/avocado_qemu/__i
On Fri, Jan 29, 2021 at 10:15:40AM +0100, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Add new data structures and types for the Simple Copy command.
>
> Signed-off-by: Klaus Jensen
> Reviewed-by: Minwoo Im
> Acked-by: Stefan Hajnoczi
> ---
> include/block/nvme.h | 45 +++
Which is useful to select tests that depend/use a particular feature.
Signed-off-by: Cleber Rosa
---
tests/acceptance/virtiofs_submounts.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/acceptance/virtiofs_submounts.py
b/tests/acceptance/virtiofs_submounts.py
index c998b297ee..1e745
Currently the path of the ssh public key is being set, but its
content is obviously what's needed.
Signed-off-by: Cleber Rosa
---
tests/acceptance/avocado_qemu/__init__.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/acceptance/avocado_qemu/__init__.py
b/tests/ac
This is intende to be replaced by a bump to Avocado 85.0, to be
released by Feb 8 2021.
Latest master contains an improvement to "avocado.utils.vmimage" that
let's it download older Fedora images from the archive locations.
That allows the currently set Fedora 31 images to continue being used.
Re
There's no downloading happening on that method, so let's call it
"prepare" instead. While at it, and because of it, the current
"prepare_boot" and "prepare_cloudinit" are also renamed.
The reasoning here is that "prepare_" methods will just work on the
images, while "set_up_" will make them effe
For users of the LinuxTest class, let's set up the VM with the port
redirection for SSH, instead of requiring each test to set the same
arguments.
Signed-off-by: Cleber Rosa
---
tests/acceptance/avocado_qemu/__init__.py | 2 ++
tests/acceptance/virtiofs_submounts.py| 4
2 files changed,
If the connection to the ssh server fails, it may indeed be a "sshd"
issue, but it may also not be that. Let's state what we know: the
establishment of the connection from the client side was not possible.
Signed-off-by: Cleber Rosa
---
tests/acceptance/linux_ssh_mips_malta.py | 2 +-
tests/acc
Slightly different versions for the same utility code are currently
present on different locations. This unifies them all, giving
preference to the version from virtiofs_submounts.py, because of the
last tweaks added to it.
While at it, this adds a "qemu.util" module to host the utility
function
Signed-off-by: Cleber Rosa
---
docs/devel/testing.rst | 26 ++
1 file changed, 26 insertions(+)
diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index 209f9d8172..fe0112b21c 100644
--- a/docs/devel/testing.rst
+++ b/docs/devel/testing.rst
@@ -790,6 +790,32 @@
On 2/3/21 6:23 PM, Cleber Rosa wrote:
> The ":avocado: enable" is not necessary and was removed in 9531d26c,
> so let's remove from the docs.
>
> Signed-off-by: Cleber Rosa
> ---
> docs/devel/testing.rst | 3 ---
> 1 file changed, 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
Just had the one comment on patch 4, which is really no big deal. I need
to integrate tooling and/or kernel support in order to properly test
this, but just from code inspection, I think it's good.
Reviewed-by: Keith Busch
Signed-off-by: Cleber Rosa
---
tests/acceptance/boot_linux.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/acceptance/boot_linux.py b/tests/acceptance/boot_linux.py
index 1da4a53d6a..2ac3e57587 100644
--- a/tests/acceptance/boot_linux.py
+++ b/tests/acceptance/boot_li
I've started a barebones project plan:
https://gitlab.com/bwidawsk/qemu/-/snippets/2070304
Jonathan, if you have a moment, perhaps you can send a MR summarizing CDAT/DOE
work from you and Chris?
If folks feel priorities are drastically off, we can discuss it in the snippet
comments.
As for wider
Even though there are qtest based tests for hotplugging CPUs (from
which this test took some inspiration from), this one adds checks
from a Linux guest point of view.
It should also serve as an example for tests that follow a similar
pattern and need to interact with QEMU (via qmp) and with the Li
On 2/3/21 6:23 PM, Cleber Rosa wrote:
> Signed-off-by: Cleber Rosa
> ---
> tests/acceptance/boot_linux.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé
In a virtiofs based tests, it seems safe to assume that the guest will
be capable of a virtio-net device.
Signed-off-by: Cleber Rosa
---
tests/acceptance/virtiofs_submounts.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/acceptance/virtiofs_submounts.py
b/tests/acce
For Avocado Instrumented based tests, it's a better idea to just use
the property. The environment variable is a fall back for tests not
written using that Python API.
Reference:
https://avocado-framework.readthedocs.io/en/84.0/api/test/avocado.html#avocado.Test.workdir
Signed-off-by: Cleber Ros
On 2/3/21 6:23 PM, Cleber Rosa wrote:
> If the connection to the ssh server fails, it may indeed be a "sshd"
> issue, but it may also not be that. Let's state what we know: the
> establishment of the connection from the client side was not possible.
>
> Signed-off-by: Cleber Rosa
> ---
> tests/
On Mon, 1 Feb 2021 23:16:25 +0800
Jonathan Cameron wrote:
> Whilst I know others are working on an implementation of at least some of
> this, a desire to work on the kernel user of this required an
> implementation so I threw this together in the meantime and am sending
> it out on the basis that
This is basically the infrastructure around "boot_linux.py" tests, but
now made into a base class for general use.
Signed-off-by: Cleber Rosa
---
tests/acceptance/avocado_qemu/__init__.py | 87 +
tests/acceptance/boot_linux.py| 94 ++-
tests/ac
* Chuan Zheng (zhengch...@huawei.com) wrote:
> Add enabled_rdma_migration into MigrationState to judge
> whether or not the RDMA is used for migration.
>
> Signed-off-by: Zhimin Feng
> Signed-off-by: Chuan Zheng
I'd rather see a separate flag added to each of the MigrationState and
MigrationInc
*** This bug is a duplicate of bug 1914353 ***
https://bugs.launchpad.net/bugs/1914353
** This bug has been marked a duplicate of bug 1914353
QEMU: aarch64: :GIC: out-of-bounds access via interrupt ID
--
You received this bug notification because you are a member of qemu-
devel-ml, which
Both the virtiofs submounts and the linux ssh mips malta tests
contains useful methods related to ssh that deserve to be made
available to other tests. Let's move them to the base LinuxTest
class.
The method that helps with setting up an ssh connection will now
support both key and password based
On Wed, 3 Feb 2021 16:45:10 +0100
Greg Kurz wrote:
> On Wed, 3 Feb 2021 14:47:30 +
> "Dr. David Alan Gilbert" wrote:
>
> > * Greg Kurz (gr...@kaod.org) wrote:
> > > On Wed, 3 Feb 2021 11:37:17 +
> > > Stefan Hajnoczi wrote:
> > >
> > > > Both lo_open() and lo_create() have similar co
* Chuan Zheng (zhengch...@huawei.com) wrote:
> Signed-off-by: Chuan Zheng
> ---
> migration/multifd.c | 6 +
> migration/multifd.h | 5
> migration/rdma.c| 71
> +
> 3 files changed, 82 insertions(+)
I think that's OK, although
openstack nova, qemu, and libvirtd log excerpts
** Attachment added: "bug1914282_log_excerpts.txt"
https://bugs.launchpad.net/qemu/+bug/1914282/+attachment/5459433/+files/bug1914282_log_excerpts.txt
--
You received this bug notification because you are a member of qemu-
devel-ml, which is su
If the vmlinuz variable is set to anything that evaluates to True,
then the respective arguments should be set. If the variable contains
an empty string, than it will evaluate to False, and the extra
arguments will not be set.
This keeps the same logic, but improves readability a bit.
Signed-off
On Tue, 2 Feb 2021 15:13:12 +1100
David Gibson wrote:
> Some upcoming POWER machines have a system called PEF (Protected
> Execution Facility) which uses a small ultravisor to allow guests to
> run in a way that they can't be eavesdropped by the hypervisor. The
> effect is roughly similar to AM
*** This bug is a duplicate of bug 1914353 ***
https://bugs.launchpad.net/bugs/1914353
** This bug is no longer a duplicate of bug 1913917
aarch64-virt: heap-use-after-free in gic_dist_writeb
** This bug has been marked a duplicate of bug 1914353
QEMU: aarch64: :GIC: out-of-bounds access
It's questionable wether it's necessary to create one brand new pair
for each test. It's not questionable that it takes less time and
resources to just use the keys available at "tests/keys" that exist
for that exact reason.
If a location for the public key is not given explicitly, the
LinuxTest
On 2/3/21 6:46 PM, Philippe Mathieu-Daudé wrote:
> On 2/3/21 6:23 PM, Cleber Rosa wrote:
>> For users of the LinuxTest class, let's set up the VM with the port
>> redirection for SSH, instead of requiring each test to set the same
>> arguments.
>>
>> Signed-off-by: Cleber Rosa
>> ---
>> tests/acc
On Wed, 3 Feb 2021 08:10:32 -0800
Ben Widawsky wrote:
> On 21-02-01 23:26:55, Jonathan Cameron wrote:
> > This is currently needed to avoid an issue in the Linux RFC
> > in which a read is issued that is not a multiple of DW.
> > On arm64 that results in byte reads being issued and a bus
> > erro
This patch needs to explain why the sync isn't needed for RDMA.
Dave
* Chuan Zheng (zhengch...@huawei.com) wrote:
> Signed-off-by: Zhimin Feng
> Signed-off-by: Chuan Zheng
> ---
> migration/multifd.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/migration/multifd.c b/migrat
On Wed, Feb 03, 2021 at 06:18:29PM +0100, Thomas Huth wrote:
> They have been deprecated since QEMU v5.0, time to remove them now.
>
> Signed-off-by: Thomas Huth
> ---
> docs/system/deprecated.rst | 6 --
> docs/system/removed-features.rst | 6 ++
> hw/i386/pc_piix.c| 94
* Stefan Hajnoczi (stefa...@redhat.com) wrote:
> On Wed, Feb 03, 2021 at 11:08:58AM -0500, Vivek Goyal wrote:
> > On Wed, Feb 03, 2021 at 05:02:37PM +0100, Greg Kurz wrote:
> > > On Wed, 3 Feb 2021 10:28:50 -0500
> > > Vivek Goyal wrote:
> > >
> > > > On Wed, Feb 03, 2021 at 11:37:19AM +, Ste
On 2/3/21 6:23 PM, Cleber Rosa wrote:
> For users of the LinuxTest class, let's set up the VM with the port
> redirection for SSH, instead of requiring each test to set the same
> arguments.
>
> Signed-off-by: Cleber Rosa
> ---
> tests/acceptance/avocado_qemu/__init__.py | 2 ++
> tests/acceptan
** Changed in: qemu
Status: New => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1914353
Title:
QEMU: aarch64: :GIC: out-of-bounds access via interrupt ID
Status in QEMU:
Fi
QMP exchange on the destination, as captured by `grep -E
'QEMU_MONITOR_(SEND_MSG|RECV_REPLY)' libvirtd.log`
Attaching it so that libvirt/QEMU devs can look for the QMP
request/responses.
(Extracted file size is ~26MB.)
** Attachment added: "QMP_exchange_libvirtd_22Jan2021_NovaCI_dest.tar.xz"
Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben:
> inore_children thing doesn't help to track all propagated permissions
> of children we want to ignore. The simplest way to correctly update
> permissions is update graph first and then do permission update. In
> this case we jus
pthread_rwlock_rdlock() and pthread_rwlock_wrlock() can fail if a
deadlock condition is detected or the current thread already owns
the lock. They can also fail, like pthread_rwlock_unlock(), if the
mutex wasn't properly initialized. None of these are ever expected
to happen with fv_VuDev::vu_dispa
I’ve attached a patch to make file-posix cache the information about the
last queried hole, does it help?
** Patch added: "0001-file-posix-Cache-next-hole.patch"
https://bugs.launchpad.net/qemu/+bug/1912224/+attachment/5459438/+files/0001-file-posix-Cache-next-hole.patch
--
You received this
On Tue, 2 Feb 2021 09:54:11 -0800
Ben Widawsky wrote:
> This was a bit more complicated than I was anticipating :-)
>
> On 21-02-01 23:16:27, Jonathan Cameron wrote:
> > This implements the ECN to the PCI 5.0 specification available at
> > https://members.pcisig.com/wg/PCI-SIG/document/14143
> >
On 2/3/21 6:55 AM, michael.nawrocki--- via wrote:
> The FW and AW bits of SCR_EL3 are RES1 only in some contexts. Force them
> to 1 only when there is no support for AArch32 at EL1 or above.
>
> The reset value will be 0x30 only if the CPU is AArch64-only; if there
> is support for AArch32 at EL1
On Sun, Jan 31, 2021 at 11:30 PM Thomas Huth wrote:
> On 30/01/2021 17.46, Warner Losh wrote:
> > bsd-user: Add new mainatiners
> >
> > The FreeBSD project has a number of enhancements to bsd-user. Add myself
> > as maintainer and Kyle Evans as a reviewer. Also add our github repo.
> >
> > Signed
* Chuan Zheng (zhengch...@huawei.com) wrote:
> Note we do want to export any rdma struct, take void * instead.
You don't need to make this a void *; add a typedef struct RDMAContext
into include/qemu/typedefs.h and then you can use the right type here
without actually exporting the interesting co
* Chuan Zheng (zhengch...@huawei.com) wrote:
> MultiFDSendParams and MultiFDRecvParams is need for rdma, export it
>
> Signed-off-by: Zhimin Feng
> Signed-off-by: Chuan Zheng
I think these become simpler if you just return a NULL on error,
also I think you can make 'id' unsigned and then you do
Am 28.01.2021 um 19:04 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 28.01.2021 20:13, Kevin Wolf wrote:
> > Am 28.01.2021 um 10:34 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > 27.01.2021 21:38, Kevin Wolf wrote:
> > > > Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben:
On 2/3/21 8:32 AM, Thomas Huth wrote:
Simply add the flag to an existing job, no need for yet another
job here.
Signed-off-by: Thomas Huth
---
.gitlab-ci.yml | 1 +
.travis.yml| 6 --
2 files changed, 1 insertion(+), 6 deletions(-)
Reviewed-by: Wainer dos Santos Moschetta
* Chuan Zheng (zhengch...@huawei.com) wrote:
> Signed-off-by: Zhimin Feng
> Signed-off-by: Chuan Zheng
> ---
> migration/qemu-file.c | 5 +
> migration/qemu-file.h | 1 +
> 2 files changed, 6 insertions(+)
>
> diff --git a/migration/qemu-file.c b/migration/qemu-file.c
> index be21518..37f62
On Feb 3 09:21, Keith Busch wrote:
> On Fri, Jan 29, 2021 at 10:15:40AM +0100, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Add new data structures and types for the Simple Copy command.
> >
> > Signed-off-by: Klaus Jensen
> > Reviewed-by: Minwoo Im
> > Acked-by: Stefan Hajnoczi
> > --
Hi,
On 2/3/21 8:32 AM, Thomas Huth wrote:
We already have such jobs in the gitlab-CI ("build-some-softmmu" and
"build-user-plugins"), so we can simply drop these from the Travis-CI.
Those jobs --enable-debug-tcg. Shouldn't at least one --enable-debug?
- Wainer
Signed-off-by: Thomas Huth
-
On Feb 3 09:27, Keith Busch wrote:
> Just had the one comment on patch 4, which is really no big deal. I need
> to integrate tooling and/or kernel support in order to properly test
> this, but just from code inspection, I think it's good.
>
> Reviewed-by: Keith Busch
>
Thanks Keith!
Actually,
The kernel abi was finally merged into 5.10.
Changes for v5:
* Actually include the revamp for TARGET_TAGGED_ADDRESSES,
which got lost at some point before posting v4.
Patches lacking review are only the new ones:
0011-exec-Introduce-cpu_untagged_addr.patch
0012-exec-Use-cpu_unt
This is more descriptive than 'unsigned long'.
No functional change, since these match on all linux+bsd hosts.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
include/exec/cpu-all.h | 2 +-
bsd-user/main.c| 4 ++--
linux-user/elfload.c | 4 ++--
linux-user/main.c
On Mon, Feb 1, 2021 at 4:46 AM Yifei Jiang wrote:
>
> Add the support needed for creating prstatus elf notes. This allows
> us to use QMP dump-guest-memory.
>
> Now ELF notes of RISC-V only contain prstatus elf notes.
>
> Signed-off-by: Yifei Jiang
> Signed-off-by: Mingwang Li
> Reviewed-by: Ali
This is the only use of guest_addr_valid that does not begin
with a guest address, but a host address being transformed to
a guest address.
We will shortly adjust guest_addr_valid to handle guest memory
tags, and the host address should not be subjected to that.
Move h2g_valid adjacent to the oth
We must always use GUEST_ADDR_MAX, because even 32-bit hosts can
use -R to restrict the memory address of the guest.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
include/exec/cpu_ldst.h | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/include/exec
* Chuan Zheng (zhengch...@huawei.com) wrote:
> We still don't transmit anything through them, and we only build
> the RDMA connections.
>
> Signed-off-by: Zhimin Feng
> Signed-off-by: Chuan Zheng
> ---
> migration/rdma.c | 69
> ++--
> 1 file
The places that use these are better off using untagged
addresses, so do not provide a tagged versions. Rename
to make it clear about the address type.
Signed-off-by: Richard Henderson
---
include/exec/cpu_ldst.h | 4 ++--
linux-user/qemu.h | 4 ++--
accel/tcg/user-exec.c | 9 ++-
Provide an identity fallback for target that do not
use tagged addresses.
Signed-off-by: Richard Henderson
---
include/exec/cpu_ldst.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/exec/cpu_ldst.h b/include/exec/cpu_ldst.h
index e62f4fba00..d9dc1de414 100644
--- a/include/ex
Record whether the backing page is anonymous, or if it has file
backing. This will allow us to get close to the Linux AArch64
ABI for MTE, which allows tag memory only on ram-backed VMAs.
The real ABI allows tag memory on files, when those files are
on ram-backed filesystems, such as tmpfs. We w
This data can be allocated by page_alloc_target_data() and
released by page_set_flags(start, end, prot | PAGE_RESET).
This data will be used to hold tag memory for AArch64 MTE.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
include/exec/cpu-all.h| 42 ++
For copy_*_user, only 0 and -TARGET_EFAULT are returned; no need
to involve abi_long. Use size_t for lengths. Use bool for the
lock_user copy argument. Use ssize_t for target_strlen, because
we can't overflow the host memory space.
Signed-off-by: Richard Henderson
---
linux-user/qemu.h| 1
Verify that addr + size - 1 does not wrap around.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
linux-user/qemu.h | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/linux-user/qemu.h b/linux-user/qemu.h
index 17aa992165..441ba6a78b 100644
--
Provide both tagged and untagged versions of access_ok.
In a few places use thread_cpu, as the user is several
callees removed from do_syscall1.
Signed-off-by: Richard Henderson
---
linux-user/qemu.h | 11 +--
linux-user/elfload.c | 2 +-
linux-user/hppa/cpu_loop.c | 8 +
Return bool not int; pass abi_ulong not 'unsigned long'.
All callers use abi_ulong already, so the change in type
has no effect.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
include/exec/cpu_ldst.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/ex
These constants are only ever used with access_ok, and friends.
Rather than translating them to PAGE_* bits, let them equal
the PAGE_* bits to begin.
Reviewed-by: Warner Losh
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
bsd-user/qemu.h | 9 -
1 file changed, 4 insert
These functions are not small, except for unlock_user
without debugging enabled. Move them out of line, and
add missing braces on the way.
Signed-off-by: Richard Henderson
---
linux-user/qemu.h| 45 ++-
linux-user/uaccess.c | 46 ++
Remember the PROT_MTE bit as PAGE_MTE/PAGE_TARGET_2.
Otherwise this does not yet have effect.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
include/exec/cpu-all.h| 1 +
linux-user/syscall_defs.h | 1 +
target/arm/cpu.h | 1 +
linux-user/mmap.c | 22
This is more descriptive than 'unsigned long'.
No functional change, since these match on all linux+bsd hosts.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
include/exec/cpu_ldst.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/exec/cpu_ldst.
These constants are only ever used with access_ok, and friends.
Rather than translating them to PAGE_* bits, let them equal
the PAGE_* bits to begin.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
linux-user/qemu.h | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
Move everything related to syndromes to a new file,
which can be shared with linux-user.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/internals.h | 245 +---
target/arm/syndrome.h | 273 +
2 f
This is the prctl bit that controls whether syscalls accept tagged
addresses. See Documentation/arm64/tagged-address-abi.rst in the
linux kernel.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
linux-user/aarch64/target_syscall.h | 4
target/arm/cpu-param.h |
We define target_mmap et al as untagged, so that they can be
used from the binary loaders. Explicitly call cpu_untagged_addr
for munmap, mprotect, mremap syscall entry points.
Add a few comments for the syscalls that are exempted by the
kernel's tagged-address-abi.rst.
Signed-off-by: Richard Hen
We're currently open-coding the range check in access_ok;
use guest_range_valid when size != 0.
Signed-off-by: Richard Henderson
---
linux-user/qemu.h | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/linux-user/qemu.h b/linux-user/qemu.h
index 9fbc5edc4b..ba122a7903 1
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
tests/tcg/aarch64/mte.h | 60 +++
tests/tcg/aarch64/mte-1.c | 28 +++
tests/tcg/aarch64/mte-2.c | 45 +++
tests/tcg/aarch64/mte-3.c | 51 +
These prctl fields are required for the function of MTE.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
linux-user/aarch64/target_syscall.h | 9 ++
linux-user/syscall.c| 43 +
2 files changed, 52 insertions(+)
diff --git a/linux
Use g2h_untagged in contexts that have no cpu, e.g. the binary
loaders that operate before the primary cpu is created. As a
collolary, target_mmap and friends must use untagged addresses,
since they are used by the loaders.
Use g2h_untagged on values returned from target_mmap, as the
kernel never
The real kernel collects _TIF_MTE_ASYNC_FAULT into the current thread's
state on any kernel entry (interrupt, exception etc), and then delivers
the signal in advance of resuming the thread.
This means that while the signal won't be delivered immediately, it will
not be delayed forever -- at minimu
* Chuan Zheng (zhengch...@huawei.com) wrote:
> Signed-off-by: Chuan Zheng
> ---
> migration/migration.c | 1 +
> migration/migration.h | 3 +++
> migration/rdma.c | 3 +++
> 3 files changed, 7 insertions(+)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 129c81a..b8f4
Resolve the untagged address once, using thread_cpu.
Tidy the DEBUG_REMAP code using glib routines.
Signed-off-by: Richard Henderson
---
linux-user/uaccess.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/linux-user/uaccess.c b/linux-user/uacc
Use simple arithmetic instead of a conditional
move when tbi0 != tbi1.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/translate-a64.c | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/target/arm/translate-a64.c b/target/a
201 - 300 of 509 matches
Mail list logo
