Re: [PATCH v3 13/24] tcg/sparc: Split out target constraints to tcg-target-con-str.h

2021-01-31 Thread Philippe Mathieu-Daudé
On 1/29/21 9:10 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/sparc/tcg-target-con-str.h | 23 ++ > tcg/sparc/tcg-target.h | 5 +-- > tcg/sparc/tcg-target.c.inc | 81 +- > 3 files changed, 55 insertions(+), 54 dele

Re: [PATCH v3 6/6] hw/arm: Display CPU type in machine description

2021-01-31 Thread Niek Linnenbank
For Orange Pi PC: Reviewed-by: Niek Linnenbank Op zo 31 jan. 2021 19:45 schreef Philippe Mathieu-Daudé : > Most of ARM machines display their CPU when QEMU list the available > machines (-M help). Some machines do not. Fix to unify the help > output. > > Signed-off-by: Philippe Mathieu-Daudé >

[Bug 1913969] [NEW] unable to migrate non shared storage when TLS is used

2021-01-31 Thread Vjaceslavs Klimovs
Public bug reported: Operating system: Gentoo Architecture: x86_64 kernel version: 5.4.72, 5.10.11 libvirt version: at least 6.9.0, 6.10.0, 7.0.0 Hypervisor and version: qemu 5.1.0, 5.2.0 With software versions described above and following configurations: libvirt: key_file = "/etc/ssl/libvirt/se

Re: [QUESTION] tcg: Is concurrent storing and code translation of the same code page considered as racing in MTTCG?

2021-01-31 Thread Richard Henderson
On 1/31/21 1:38 AM, Liren Wei wrote: > However, similar to the situation described in: > https://lists.nongnu.org/archive/html/qemu-devel/2018-02/msg02529.html > > When we have 2 vCPUs with one of them writing to the code page while > the other just translated some code within that same page, the

Re: [PATCH 4/7] ppc/pnv: Simplify pnv_bmc_create()

2021-01-31 Thread Andrew Jeffery
On Fri, 29 Jan 2021, at 19:09, Cédric Le Goater wrote: > On 1/28/21 11:40 PM, David Gibson wrote: > > On Thu, Jan 28, 2021 at 08:46:01AM +0100, Cédric Le Goater wrote: > >> On 1/28/21 1:46 AM, Joel Stanley wrote: > >>> On Tue, 26 Jan 2021 at 17:14, Cédric Le Goater wrote: > > and reus

[PATCH 3/6] m68k: improve comments on m68k_move_to/from helpers

2021-01-31 Thread BALATON Zoltan
From: Lucien Murray-Pitts Add more detailed comments to each case of m68k_move_to/from helpers to list the supported CPUs for that CR as they were wrong in some cases, and missing some cpu classes in other cases. Signed-off-by: Lucien Murray-Pitts Signed-off-by: BALATON Zoltan --- target/m68k

[PATCH 0/6] m68k: Overhaul of MOVEC instruction to support exception/MSP

2021-01-31 Thread BALATON Zoltan
Hello, This is Lucien's m68k series rebased on and fixed up to work with current master as per previous discussion: https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg02840.html I've left previous Reviewed-by tags for reference but these should probably be reviewed again. I've only lightly

[PATCH 1/6] m68k: improve cpu instantiation comments

2021-01-31 Thread BALATON Zoltan
From: Lucien Murray-Pitts Improvement in comments for the instantiation functions. This is to highlight what each cpu class, in the 68000 series, contains in terms of instructions/features. Signed-off-by: Lucien Murray-Pitts Signed-off-by: BALATON Zoltan --- target/m68k/cpu.c | 44 +++

[PATCH 4/6] m68k: add missing BUSCR/PCR CR defines, and BUSCR/PCR/CAAR CR to m68k_move_to/from

2021-01-31 Thread BALATON Zoltan
From: Lucien Murray-Pitts The BUSCR/PCR CR defines were missing for 68060, and the move_to/from helper functions were also missing a decode for the 68060 M68K_CR_CAAR CR register. Added missing defines, and respective decodes for all three CR registers to the helpers. Although this patch define

[PATCH 6/6] m68k: add MSP detection support for stack pointer swap helpers

2021-01-31 Thread BALATON Zoltan
From: Lucien Murray-Pitts On m68k there are two varities of stack pointers: USP with SSP or ISP/MSP. Only the 68020/30/40 support the MSP register the stack swap helpers don't support this feature. This patch adds this support, as well as comments to CPUM68KState to make it clear how stacks are

[PATCH 5/6] m68k: MOVEC insn. should generate exception if wrong CR is accessed

2021-01-31 Thread BALATON Zoltan
From: Lucien Murray-Pitts Add CPU class detection for each CR type in the m68k_move_to/from helpers, so that it throws and exception if an unsupported register is requested for that CPU class. Reclassified MOVEC insn. as only supported from 68010. Signed-off-by: Lucien Murray-Pitts Signed-off-

[PATCH 2/6] m68k: cascade m68k_features by m680xx_cpu_initfn() to improve readability

2021-01-31 Thread BALATON Zoltan
From: Lucien Murray-Pitts The m680XX_cpu_initfn functions have been rearranged to cascade starting from the base 68000, so that the 68010 then inherits from this, and so on until the 68060. This makes it simpler to track features since in most cases the m68k were product enhancements on each oth

RE: [PATCH v4] blockjob: Fix crash with IOthread when block commit after snapshot

2021-01-31 Thread 仇大玉
Any comments? It's really a bug and can cause the qemu to segmentfault. Thanks, Michael -Original Message- From: 仇大玉 Sent: 2021年1月28日 13:16 To: qemu-bl...@nongnu.org; qemu-devel@nongnu.org Cc: kw...@redhat.com; mre...@redhat.com; js...@redhat.com; 08005...@163.com Subject: RE: [PATCH v4

Re: [RFC PATCH v2 3/3] vfio: Avoid disabling and enabling vectors repeatedly in VFIO migration

2021-01-31 Thread Shenming Lu
On 2021/1/27 22:21, Alex Williamson wrote: > On Wed, 27 Jan 2021 19:27:35 +0800 > Shenming Lu wrote: > >> On 2021/1/27 5:36, Alex Williamson wrote: >>> On Wed, 9 Dec 2020 16:09:19 +0800 >>> Shenming Lu wrote: >>> Different from the normal situation when the guest starts, we can know

Re: [PATCH v2] ppc/pnv: Set default RAM size to 1 GB

2021-01-31 Thread David Gibson
On Fri, Jan 29, 2021 at 12:17:19PM +0100, Cédric Le Goater wrote: 65;6201;1c> The memory layout of the PowerNV machine is defined as : > > #define KERNEL_LOAD_BASE((void *)0x2000) > #define KERNEL_LOAD_SIZE0x0800 > > #define INITRAMFS_LOAD_BASE KERNEL_LOAD_BASE + KERNEL_LOAD

[PATCH v2 2/2] target/i386: add kvm_exact_match_flags to FeatureWordInfo

2021-01-31 Thread Like Xu
Eduardo has a suggestion: instead of hardcoding the PERF_CAPABILITIES rules in this loop, this could become a FeatureWordInfo field. It would be very useful for other features like intel-pt, where we need some bits to match the host too. Suggested-by: Eduardo Habkost Signed-off-by: Like Xu ---

[PATCH v2 1/2] target/i386: add "-cpu, lbr-fmt=*" support to enable guest LBR

2021-01-31 Thread Like Xu
The last branch recording (LBR) is a performance monitor unit (PMU) feature on Intel processors that records a running trace of the most recent branches taken by the processor in the LBR stack. The QEMU could configure whether it's enabled or not for each guest via CLI. The LBR feature would be en

Re: [PATCH] vhost: Check for valid vdev in vhost_backend_handle_iotlb_msg

2021-01-31 Thread Jason Wang
On 2021/1/29 下午5:07, Eugenio Pérez wrote: Not checking this can lead to invalid dev->vdev member access in vhost_device_iotlb_miss if backend issue an iotlb message in a bad timing, either maliciously or by a bug. Reproduced rebooting a guest with testpmd in txonly forward mode. #0 0x55

Re: [RFC 03/10] virtio: Add virtio_queue_get_idx

2021-01-31 Thread Jason Wang
On 2021/1/30 上午4:54, Eugenio Pérez wrote: Signed-off-by: Eugenio Pérez --- include/hw/virtio/virtio.h | 2 ++ hw/virtio/virtio.c | 5 + 2 files changed, 7 insertions(+) diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h index 9988c6d5c9..9013c03424 100644 ---

Re: [RFC 05/10] vhost: Add vhost_dev_from_virtio

2021-01-31 Thread Jason Wang
On 2021/1/30 上午4:54, Eugenio Pérez wrote: Signed-off-by: Eugenio Pérez --- include/hw/virtio/vhost.h | 1 + hw/virtio/vhost.c | 17 + 2 files changed, 18 insertions(+) diff --git a/include/hw/virtio/vhost.h b/include/hw/virtio/vhost.h index 4a8bc75415..fca076e3f0

Re: [PATCH 0/4] Fix some style problems in qobject

2021-01-31 Thread zhanghan (J)
ping?This patch set about code style problem in qobject receives no replies. Did I miss any response? The link follows: http://patchwork.ozlabs.org/project/qemu-devel/cover/20201228071129.24563-1-zhangha...@huawei.com/

Re: [PATCH 0/9] Fix some style problems in net

2021-01-31 Thread zhanghan (J)
ping?This patch set about code style problem in net receives no replies. Did I miss any response? The link follows: http://patchwork.ozlabs.org/project/qemu-devel/cover/20201222082340.67405-1-zhangha...@huawei.com/

Re: [PATCH] MAINTAINERS: update bsd-user maintainers

2021-01-31 Thread Thomas Huth
On 30/01/2021 17.46, Warner Losh wrote: bsd-user: Add new mainatiners s/mainatiners/maintainers/ The FreeBSD project has a number of enhancements to bsd-user. Add myself as maintainer and Kyle Evans as a reviewer. Also add our github repo. Thanks for taking care of this! Signed-off-by: Wa

Re: [RFC 09/10] vhost: Route guest->host notification through shadow virtqueue

2021-01-31 Thread Jason Wang
On 2021/1/30 上午4:54, Eugenio Pérez wrote: Shadow virtqueue notifications forwarding is disabled when vhost_dev stops. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.h | 5 ++ include/hw/virtio/vhost.h | 4 + hw/virtio/vhost-shadow-virtqueue.c | 123

Re: [PATCH] MAINTAINERS: update bsd-user maintainers

2021-01-31 Thread Thomas Huth
On 30/01/2021 17.46, Warner Losh wrote: bsd-user: Add new mainatiners The FreeBSD project has a number of enhancements to bsd-user. Add myself as maintainer and Kyle Evans as a reviewer. Also add our github repo. Signed-off-by: Warner Losh mailto:i...@bsdimp.com>> ---  MAINTAINERS | 5 -  

[PATCH v2] replay: fix replay of the interrupts

2021-01-31 Thread Pavel Dovgalyuk
Sometimes interrupt event comes at the same time with the virtual timers. In this case replay tries to proceed the timers, because deadline for them is zero. This patch allows processing interrupts and exceptions by entering the vCPU execution loop, when deadline is zero, but checkpoint associated

Re: [PATCH] util/log: flush TB cache when log level changes

2021-01-31 Thread Pavel Dovgalyuk
On 25.01.2021 14:09, Alex Bennée wrote: Pavel Dovgalyuk writes: On 22.01.2021 14:42, Alex Bennée wrote: Pavel Dovgalyuk writes: Sometimes we need to collect the translation logs starting from some point of the execution. Some TB listings may be missed in this case, when blocks were trans

Re: [RFC 03/10] virtio: Add virtio_queue_get_idx

2021-01-31 Thread Eugenio Perez Martin
On Mon, Feb 1, 2021 at 7:10 AM Jason Wang wrote: > > > On 2021/1/30 上午4:54, Eugenio Pérez wrote: > > Signed-off-by: Eugenio Pérez > > --- > > include/hw/virtio/virtio.h | 2 ++ > > hw/virtio/virtio.c | 5 + > > 2 files changed, 7 insertions(+) > > > > diff --git a/include/hw/virti

Re: [PATCH 4/6] m68k: add missing BUSCR/PCR CR defines, and BUSCR/PCR/CAAR CR to m68k_move_to/from

2021-01-31 Thread Philippe Mathieu-Daudé
On 2/1/21 1:01 AM, BALATON Zoltan wrote: > From: Lucien Murray-Pitts > > The BUSCR/PCR CR defines were missing for 68060, and the move_to/from helper > functions were also missing a decode for the 68060 M68K_CR_CAAR CR register. > > Added missing defines, and respective decodes for all three CR

Re: [Bug 1913923] [NEW] assert issue locates in hw/net/vmxnet3.c:1793:vmxnet3_io_bar1_write: code should not be reach

2021-01-31 Thread Philippe Mathieu-Daudé
Cc'ing Dmitry Fleytman On 1/31/21 5:29 AM, Gaoning Pan wrote: > Public bug reported: > > Hello, > > I found an assertion failure in hw/net/vmxnet3.c:1793 > > This was found in latest version 5.2.0. > > my reproduced is as follows: > > > cat << EOF | ./qemu-system-x86_64 \ > -device vmxnet3 \

[Bug 1890152] Re: malloc 0xff0000030 bytes with vmxnet3

2021-01-31 Thread Philippe Mathieu-Daudé
*** This bug is a duplicate of bug 1913873 *** https://bugs.launchpad.net/bugs/1913873 Chronogically speaking #1913873 is a duplicate of #1890152... -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/

Re: [PATCH v2 2/2] pci: add romsize property

2021-01-31 Thread Gerd Hoffmann
Hi, > +DEFINE_PROP_UINT32("romsize", PCIDevice, romsize, -1), IIRC we have a DEFINE_PROP_SIZE() which can parse units and therefore accepts -- for example -- "512k" or "1M". take care, Gerd

<    1   2