Re: [PATCH 8/8] configure: automatically parse command line for meson -D options

2021-01-22 Thread Yonggang Luo
Hi Paolo, as python and meson are required dependencies to building qemu now, can we detecting python/meson at the very begining of configure, even before the --help parameter. On Wed, Jan 13, 2021 at 6:08 AM Paolo Bonzini wrote: > > On 13/01/21 11:31, Daniel P. Berrangé wrote: > >> meson-build

Re: [PATCHv8 2/3] arm-virt: refactor gpios creation

2021-01-22 Thread Andrew Jones
On Wed, Jan 20, 2021 at 12:27:47PM +0300, Maxim Uvarov wrote: > No functional change. Just refactor code to better > support secure and normal world gpios. > > Signed-off-by: Maxim Uvarov > --- > hw/arm/virt.c | 64 ++- > 1 file changed, 43 inserti

Re: [RFC PATCH 2/2] gitlab-ci: Add a job building TCI with Clang

2021-01-22 Thread Thomas Huth
On 21/01/2021 21.46, Wainer dos Santos Moschetta wrote: On 1/21/21 3:28 PM, Thomas Huth wrote: On 21/01/2021 19.13, Daniel P. Berrangé wrote: On Thu, Jan 21, 2021 at 03:05:43PM -0300, Wainer dos Santos Moschetta wrote: Hi, On 1/21/21 7:08 AM, Thomas Huth wrote: On 10/01/2021 17.27, Philippe

Re: [PATCHv8 3/3] arm-virt: add secure pl061 for reset/power down

2021-01-22 Thread Andrew Jones
On Wed, Jan 20, 2021 at 12:27:48PM +0300, Maxim Uvarov wrote: > Add secure pl061 for reset/power down machine from > the secure world (Arm Trusted Firmware). Connect it > with gpio-pwr driver. > > Signed-off-by: Maxim Uvarov > --- > hw/arm/Kconfig| 1 + > hw/arm/virt.c | 47

Re: [PATCH 04/25] keyval: accept escaped commas in implied option

2021-01-22 Thread Markus Armbruster
Paolo Bonzini writes: [...] > diff --git a/util/keyval.c b/util/keyval.c > index be34928813..eb9b9c55ec 100644 > --- a/util/keyval.c > +++ b/util/keyval.c > @@ -16,8 +16,8 @@ > * key-vals = [ key-val { ',' key-val } [ ',' ] ] > * key-val = key '=' val | help > * key

Re: [PULL 10/11] vnc: move initialization to framebuffer_update_request

2021-01-22 Thread Gerd Hoffmann
> This patch breaks QEMU for me. > The symptom is the following: in virt-manager, the display remains dead > (black), when I start an OVMF guest. At the same time, unusually high > CPU load can be seen on the host; it makes me think that virt-manager is > trying, in a busy loop, to complete the VN

Re: Thread safety of coroutine-sigaltstack

2021-01-22 Thread Max Reitz
On 20.01.21 18:25, Laszlo Ersek wrote: [...] A simple grep for SIGUSR2 seems to indicate that SIGUSR2 is not used by system emulation for anything else, in practice. Is it possible to dedicate SIGUSR2 explicitly to coroutine-sigaltstack, and set up the action beforehand, from some init function

[PATCH] vnc: drop vnc_colordepth() call.

2021-01-22 Thread Gerd Hoffmann
With gtk-vnc (which supports VNC_FEATURE_WMVI) this results in sending a VNC_ENCODING_WMVi message to the client. Which in turn seems to make gtk-vnc respond with another non-incremental update request. Hello endless loop ... Drop the call. Fixes: 9e1632ad07ca ("vnc: move initialization to fram

[PATCH 0/2] meson: Try to clarify TCG / TCI options for new users

2021-01-22 Thread Philippe Mathieu-Daudé
Some new users get confused between 'TCG' and 'TCI' and enable TCI when TCG is better for they needs. Try to clarify it is better to not use TCI when native backend is available. Note, before Meson, warnings were summarized at the end of ./configure. Now they are displayed earlier, and likely miss

[PATCH 2/2] meson: Warn when TCI is selected but TCG backend is available

2021-01-22 Thread Philippe Mathieu-Daudé
Some new users get confused with 'TCG' and 'TCI', and enable TCI support expecting to enable TCG. Emit a warning when native TCG backend is available on the host architecture, mentioning this is a suboptimal configuration. Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 3 +++ 1 file ch

[PATCH 1/2] meson: Explicit TCG backend used

2021-01-22 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 8535a83fb70..0a645e54662 100644 --- a/meson.build +++ b/meson.build @@ -2419,8 +2419,12 @@ endif summary_info += {'TCG support': c

Re: [PATCH] linux-user/mmap: Avoid asserts for out of range mremap calls

2021-01-22 Thread Richard Purdie
On Fri, 2021-01-08 at 17:42 +, Richard Purdie wrote: > If mremap() is called without the MREMAP_MAYMOVE flag with a start address > just before the end of memory (reserved_va) where new_size would exceed > it (and GUEST_ADDR_MAX), the assert(end - 1 <= GUEST_ADDR_MAX) in  > page_set_flags() wo

Re: [RFC PATCH] linux-user/mmap: Return EFAULT for invalid addresses

2021-01-22 Thread Richard Purdie
On Fri, 2021-01-08 at 17:46 +, Richard Purdie wrote: > When using qemu-i386 to run gobject introspection parts of a webkitgtk  > build using musl as libc on a 64 bit host, it sits in an infinite loop  > of mremap calls of ever decreasing/increasing addresses. > > I suspect something in the mus

Re: [PATCH 1/2] meson: Explicit TCG backend used

2021-01-22 Thread Thomas Huth
On 22/01/2021 10.22, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 8535a83fb70..0a645e54662 100644 --- a/meson.build +++ b/meson.build @@ -2419,8 +241

Re: [PATCH 2/2] meson: Warn when TCI is selected but TCG backend is available

2021-01-22 Thread Thomas Huth
On 22/01/2021 10.22, Philippe Mathieu-Daudé wrote: Some new users get confused with 'TCG' and 'TCI', and enable TCI support expecting to enable TCG. Emit a warning when native TCG backend is available on the host architecture, mentioning this is a suboptimal configuration. Signed-off-by: Philip

Re: [PATCH 2/2] meson: Warn when TCI is selected but TCG backend is available

2021-01-22 Thread Philippe Mathieu-Daudé
On Fri, Jan 22, 2021 at 10:43 AM Thomas Huth wrote: > On 22/01/2021 10.22, Philippe Mathieu-Daudé wrote: > > Some new users get confused with 'TCG' and 'TCI', and enable TCI > > support expecting to enable TCG. > > > > Emit a warning when native TCG backend is available on the > > host architectur

Re: [PATCH 2/2] meson: Warn when TCI is selected but TCG backend is available

2021-01-22 Thread Thomas Huth
On 22/01/2021 10.46, Philippe Mathieu-Daudé wrote: On Fri, Jan 22, 2021 at 10:43 AM Thomas Huth wrote: On 22/01/2021 10.22, Philippe Mathieu-Daudé wrote: Some new users get confused with 'TCG' and 'TCI', and enable TCI support expecting to enable TCG. Emit a warning when native TCG backend is

Re: [PATCH 2/2] meson: Warn when TCI is selected but TCG backend is available

2021-01-22 Thread Stefan Weil
Am 22.01.21 um 10:47 schrieb Thomas Huth: On 22/01/2021 10.46, Philippe Mathieu-Daudé wrote: On Fri, Jan 22, 2021 at 10:43 AM Thomas Huth wrote: On 22/01/2021 10.22, Philippe Mathieu-Daudé wrote: Some new users get confused with 'TCG' and 'TCI', and enable TCI support expecting to enable TCG

[PATCH] util/log: flush TB cache when log level changes

2021-01-22 Thread Pavel Dovgalyuk
Sometimes we need to collect the translation logs starting from some point of the execution. Some TB listings may be missed in this case, when blocks were translated before. This patch clears TB cache to allow re-translation of such code blocks. Signed-off-by: Pavel Dovgalyuk --- accel/tcg/trans

[PATCH] gitlab-ci.yml: Use the whole tree as artifacts to speed up the CI

2021-01-22 Thread Thomas Huth
Currently, our check-system-* jobs are recompiling the whole sources again. This happens due to the fact that the jobs are checking out the whole source tree and required submodules again, and only try to use the "build" directory with the binaries and object files as an artifact from the previous

Re: [PATCHv8 3/3] arm-virt: add secure pl061 for reset/power down

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 08:29, Andrew Jones wrote: > > On Wed, Jan 20, 2021 at 12:27:48PM +0300, Maxim Uvarov wrote: > > Add secure pl061 for reset/power down machine from > > the secure world (Arm Trusted Firmware). Connect it > > with gpio-pwr driver. > > > > Signed-off-by: Maxim Uvarov > > ---

Re: Thread safety of coroutine-sigaltstack

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 08:50, Max Reitz wrote: > > On 20.01.21 18:25, Laszlo Ersek wrote: > > [...] > > > A simple grep for SIGUSR2 seems to indicate that SIGUSR2 is not used by > > system emulation for anything else, in practice. Is it possible to > > dedicate SIGUSR2 explicitly to coroutine-siga

Re: Thread safety of coroutine-sigaltstack

2021-01-22 Thread Max Reitz
On 22.01.21 11:14, Peter Maydell wrote: On Fri, 22 Jan 2021 at 08:50, Max Reitz wrote: On 20.01.21 18:25, Laszlo Ersek wrote: [...] A simple grep for SIGUSR2 seems to indicate that SIGUSR2 is not used by system emulation for anything else, in practice. Is it possible to dedicate SIGUSR2 exp

Re: [PATCHv8 3/3] arm-virt: add secure pl061 for reset/power down

2021-01-22 Thread Andrew Jones
On Fri, Jan 22, 2021 at 10:09:35AM +, Peter Maydell wrote: > On Fri, 22 Jan 2021 at 08:29, Andrew Jones wrote: > > > > On Wed, Jan 20, 2021 at 12:27:48PM +0300, Maxim Uvarov wrote: > > > Add secure pl061 for reset/power down machine from > > > the secure world (Arm Trusted Firmware). Connect i

Re: [PATCH] gitlab-ci.yml: Use the whole tree as artifacts to speed up the CI

2021-01-22 Thread Daniel P . Berrangé
On Fri, Jan 22, 2021 at 11:07:22AM +0100, Thomas Huth wrote: > Currently, our check-system-* jobs are recompiling the whole sources > again. This happens due to the fact that the jobs are checking out > the whole source tree and required submodules again, and only try > to use the "build" directory

[PATCH] coroutine-sigaltstack: Keep SIGUSR2 handler up

2021-01-22 Thread Max Reitz
Modifying signal handlers is a process-global operation. When two threads run coroutine-sigaltstack's qemu_coroutine_new() concurrently, they may interfere with each other: One of them may revert the SIGUSR2 handler back to the default between the other thread setting up coroutine_trampoline() as

Re: [PATCH] gitlab-ci.yml: Use the whole tree as artifacts to speed up the CI

2021-01-22 Thread Daniel P . Berrangé
On Fri, Jan 22, 2021 at 10:18:33AM +, Daniel P. Berrangé wrote: > On Fri, Jan 22, 2021 at 11:07:22AM +0100, Thomas Huth wrote: > > Currently, our check-system-* jobs are recompiling the whole sources > > again. This happens due to the fact that the jobs are checking out > > the whole source tre

Re: [PATCH] linux-user/mmap: Avoid asserts for out of range mremap calls

2021-01-22 Thread Philippe Mathieu-Daudé
On 1/22/21 10:37 AM, Richard Purdie wrote: > On Fri, 2021-01-08 at 17:42 +, Richard Purdie wrote: >> If mremap() is called without the MREMAP_MAYMOVE flag with a start address >> just before the end of memory (reserved_va) where new_size would exceed >> it (and GUEST_ADDR_MAX), the assert(end

Re: [RFC PATCH] linux-user/mmap: Return EFAULT for invalid addresses

2021-01-22 Thread Philippe Mathieu-Daudé
Cc'ing maintainer On 1/22/21 10:37 AM, Richard Purdie wrote: > On Fri, 2021-01-08 at 17:46 +, Richard Purdie wrote: >> When using qemu-i386 to run gobject introspection parts of a webkitgtk  >> build using musl as libc on a 64 bit host, it sits in an infinite loop  >> of mremap calls of ever d

Re: [PATCH] gitlab-ci.yml: Use the whole tree as artifacts to speed up the CI

2021-01-22 Thread Philippe Mathieu-Daudé
On 1/22/21 11:18 AM, Daniel P. Berrangé wrote: > On Fri, Jan 22, 2021 at 11:07:22AM +0100, Thomas Huth wrote: >> Currently, our check-system-* jobs are recompiling the whole sources >> again. This happens due to the fact that the jobs are checking out >> the whole source tree and required submodule

Re: [PATCH] util/log: flush TB cache when log level changes

2021-01-22 Thread Philippe Mathieu-Daudé
Hi Pavel, On 1/22/21 11:03 AM, Pavel Dovgalyuk wrote: > Sometimes we need to collect the translation logs starting > from some point of the execution. Some TB listings may > be missed in this case, when blocks were translated before. > This patch clears TB cache to allow re-translation of such > c

Re: [PULL 0/9] s390x updates

2021-01-22 Thread Peter Maydell
On Thu, 21 Jan 2021 at 12:16, Cornelia Huck wrote: > > The following changes since commit 954b83f13236d21b4116b93a726ea36b5dc2d303: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2021-01-20' into staging (2021-01-20 > 17:44:31 +) > > are available in the Git repo

[PATCH v2] hw/core/resettable: make in-reset state false during exit phase call

2021-01-22 Thread Damien Hedde
Move the reset count decrement from "just after" to "just before" calling the exit phase handler. The goal is to make resettable_is_in_reset() returning false during the handler execution. This simplifies reset handling in resettable devices. Typically, a function that updates the device state wi

Re: [PATCH] replay: fix replay of the interrupts

2021-01-22 Thread Philippe Mathieu-Daudé
On 1/19/21 1:39 PM, Pavel Dovgalyuk wrote: > Sometimes interrupt event comes at the same time with > the virtual timers. In this case replay tries to proceed > the timers, because deadline for them is zero. > This patch allows processing interrupts and exceptions > by entering the vCPU execution lo

Re: [PATCH] util/log: flush TB cache when log level changes

2021-01-22 Thread Pavel Dovgalyuk
On 22.01.2021 13:32, Philippe Mathieu-Daudé wrote: Hi Pavel, On 1/22/21 11:03 AM, Pavel Dovgalyuk wrote: Sometimes we need to collect the translation logs starting from some point of the execution. Some TB listings may be missed in this case, when blocks were translated before. This patch clear

Re: [PATCH v2 2/8] nbd: allow reconnect on open, with corresponding new options

2021-01-22 Thread Vladimir Sementsov-Ogievskiy
21.01.2021 04:44, Eric Blake wrote: On 11/30/20 7:40 AM, Vladimir Sementsov-Ogievskiy wrote: Note: currently, using new option with long timeout in qmp command blockdev-add is not good idea, as qmp interface is blocking, so, don't add it now, let's add it later after "monitor: Optionally run han

[PATCH v2 0/4] meson: Try to clarify TCG / TCI options for new users

2021-01-22 Thread Philippe Mathieu-Daudé
Since v2: - Included Thomas suggestions Some new users get confused between 'TCG' and 'TCI' and enable TCI when TCG is better for they needs. Try to clarify it is better to not use TCI when native backend is available. Note, before Meson, warnings were summarized at the end of ./configure. Now th

[PATCH v2 1/4] meson: Explicit TCG backend used

2021-01-22 Thread Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth Reviewed-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 8535a83fb70..d5b76150e49 100644 --- a/meson.build +++ b/meson.build @@ -229,7 +229,

[PATCH v2 3/4] configure: Improve TCI feature description

2021-01-22 Thread Philippe Mathieu-Daudé
Users might want to enable all features, without realizing some features have negative effect. Mention the TCI feature is slow and experimental, hoping it will be selected knowingly. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- configure | 2 +- 1 file changed, 1 insertio

[PATCH v2 2/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-22 Thread Philippe Mathieu-Daudé
Some new users get confused with 'TCG' and 'TCI', and enable TCI support expecting to enable TCG. Emit a warning when native TCG backend is available on the host architecture, mentioning this is a suboptimal configuration. Reviewed-by: Stefan Weil Reviewed-by: Thomas Huth Signed-off-by: Philipp

[RFC PATCH v2 4/4] configure: Reword --enable-tcg-interpreter as --disable-native-tcg

2021-01-22 Thread Philippe Mathieu-Daudé
Users might want to enable all features, without realizing some features have negative effect. Rename '--enable-tcg-interpreter' as '--disable-native-tcg' to avoid user selecting this feature without understanding it. '--enable-tcg-interpreter' is kept in for backward compability with scripts. Sug

Re: [PATCH v2 06/36] block: BdrvChildClass: add .get_parent_aio_context handler

2021-01-22 Thread Vladimir Sementsov-Ogievskiy
19.01.2021 19:38, Kevin Wolf wrote: Am 18.01.2021 um 18:36 hat Vladimir Sementsov-Ogievskiy geschrieben: 18.01.2021 18:13, Kevin Wolf wrote: Am 27.11.2020 um 15:44 hat Vladimir Sementsov-Ogievskiy geschrieben: Add new handler to get aio context and implement it in all child classes. Add corres

Re: [PATCH v2 06/36] block: BdrvChildClass: add .get_parent_aio_context handler

2021-01-22 Thread Kevin Wolf
Am 22.01.2021 um 12:04 hat Vladimir Sementsov-Ogievskiy geschrieben: > 19.01.2021 19:38, Kevin Wolf wrote: > > Am 18.01.2021 um 18:36 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > 18.01.2021 18:13, Kevin Wolf wrote: > > > > Am 27.11.2020 um 15:44 hat Vladimir Sementsov-Ogievskiy geschrieben:

Re: [PATCH v2 06/36] block: BdrvChildClass: add .get_parent_aio_context handler

2021-01-22 Thread Vladimir Sementsov-Ogievskiy
22.01.2021 14:18, Kevin Wolf wrote: Am 22.01.2021 um 12:04 hat Vladimir Sementsov-Ogievskiy geschrieben: 19.01.2021 19:38, Kevin Wolf wrote: Am 18.01.2021 um 18:36 hat Vladimir Sementsov-Ogievskiy geschrieben: 18.01.2021 18:13, Kevin Wolf wrote: Am 27.11.2020 um 15:44 hat Vladimir Sementsov-O

Re: [Qemu-devel] [PATCH v2 07/11] chardev: Let IOReadHandler use unsigned type

2021-01-22 Thread Richard Purdie
On Fri, 2018-10-12 at 02:22 +0200, Philippe Mathieu-Daudé wrote: > The number of bytes can not be negative nor zero. > > Fixed 2 format string: > - hw/char/spapr_vty.c > - hw/usb/ccid-card-passthru.c > > Suggested-by: Paolo Bonzini > Signed-off-by: Philippe Mathieu-Daudé > Acked-by: Alberto Gar

Re: [PATCH v7 00/11] Rework iotests/check

2021-01-22 Thread Kevin Wolf
Am 20.01.2021 um 21:52 hat Eric Blake geschrieben: > On 1/16/21 7:44 AM, Vladimir Sementsov-Ogievskiy wrote: > > Hi all! > > > > These series has 3 goals: > > > > - get rid of group file (to forget about rebase and in-list conflicts) > > - introduce human-readable names for tests > > - rewrite

Re: [PATCH v2 3/4] configure: Improve TCI feature description

2021-01-22 Thread Thomas Huth
On 22/01/2021 11.58, Philippe Mathieu-Daudé wrote: Users might want to enable all features, without realizing some features have negative effect. Mention the TCI feature is slow and experimental, hoping it will be selected knowingly. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Dau

Re: [RFC PATCH v2 4/4] configure: Reword --enable-tcg-interpreter as --disable-native-tcg

2021-01-22 Thread Thomas Huth
On 22/01/2021 11.58, Philippe Mathieu-Daudé wrote: Users might want to enable all features, without realizing some features have negative effect. Rename '--enable-tcg-interpreter' as '--disable-native-tcg' to avoid user selecting this feature without understanding it. '--enable-tcg-interpreter' i

Re: [PATCH v7 00/11] Rework iotests/check

2021-01-22 Thread Vladimir Sementsov-Ogievskiy
22.01.2021 14:27, Kevin Wolf wrote: Am 20.01.2021 um 21:52 hat Eric Blake geschrieben: On 1/16/21 7:44 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all! These series has 3 goals: - get rid of group file (to forget about rebase and in-list conflicts) - introduce human-readable names for test

Re: [PATCH v3 12/21] linux-user/aarch64: Implement PR_TAGGED_ADDR_ENABLE

2021-01-22 Thread Peter Maydell
On Fri, 15 Jan 2021 at 22:47, Richard Henderson wrote: > > This is the prctl bit that controls whether syscalls accept tagged > addresses. See Documentation/arm64/tagged-address-abi.rst in the > linux kernel. > > Signed-off-by: Richard Henderson > --- > linux-user/aarch64/target_syscall.h | 4

Re: [PATCH] util/log: flush TB cache when log level changes

2021-01-22 Thread Alex Bennée
Pavel Dovgalyuk writes: > Sometimes we need to collect the translation logs starting > from some point of the execution. Some TB listings may > be missed in this case, when blocks were translated before. > This patch clears TB cache to allow re-translation of such > code blocks. > > Signed-off-

Re: [PATCH v7 07/11] iotests: add findtests.py

2021-01-22 Thread Kevin Wolf
Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > Add python script with new logic of searching for tests: > > Current ./check behavior: > - tests are named [0-9][0-9][0-9] > - tests must be registered in group file (even if test doesn't belong >to any group, like 142) >

Re: [PATCH v3 13/21] linux-user/aarch64: Implement PR_MTE_TCF and PR_MTE_TAG

2021-01-22 Thread Peter Maydell
On Fri, 15 Jan 2021 at 22:47, Richard Henderson wrote: > > These prctl fields are required for the function of MTE. > > Signed-off-by: Richard Henderson > --- > linux-user/aarch64/target_syscall.h | 9 ++ > linux-user/syscall.c| 44 + > 2 files ch

Re: [PATCH v7 07/11] iotests: add findtests.py

2021-01-22 Thread Kevin Wolf
Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > +if 'disabled' not in groups and 'disabled' not in exclude_groups: > +# Don't want to modify function argument, so create new list. > +exclude_groups = exclude_groups + ['disabled'] Oops, forgot

Re: [PATCH v3 12/21] linux-user/aarch64: Implement PR_TAGGED_ADDR_ENABLE

2021-01-22 Thread Peter Maydell
On Fri, 15 Jan 2021 at 22:47, Richard Henderson wrote: > > This is the prctl bit that controls whether syscalls accept tagged > addresses. See Documentation/arm64/tagged-address-abi.rst in the > linux kernel. > +#ifdef TARGET_TAGGED_ADDRESSES > +/** > + * cpu_untagged_addr: > + * @cs: CPU contex

Re: [Qemu-devel] [PATCH v2 07/11] chardev: Let IOReadHandler use unsigned type

2021-01-22 Thread P J P
+-- On Fri, 22 Jan 2021, Richard Purdie wrote --+ | If so can anyone point me at that change? | | I ask since CVE-2018-18438 is marked as affecting all qemu versions | (https://nvd.nist.gov/vuln/detail/CVE-2018-18438). | | If it was fixed, the version mask could be updated. If the fix wasn't deem

Re: [PATCH v7 07/11] iotests: add findtests.py

2021-01-22 Thread Vladimir Sementsov-Ogievskiy
22.01.2021 14:48, Kevin Wolf wrote: Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: Add python script with new logic of searching for tests: Current ./check behavior: - tests are named [0-9][0-9][0-9] - tests must be registered in group file (even if test doesn't belong

Re: [PATCH v7 07/11] iotests: add findtests.py

2021-01-22 Thread Vladimir Sementsov-Ogievskiy
22.01.2021 14:49, Kevin Wolf wrote: Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: +if 'disabled' not in groups and 'disabled' not in exclude_groups: +# Don't want to modify function argument, so create new list. +exclude_groups = exclude_gro

Re: [PATCH v3 12/21] linux-user/aarch64: Implement PR_TAGGED_ADDR_ENABLE

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 11:53, Peter Maydell wrote: > The kernel's "untagged_addr()" implementation: > https://elixir.bootlin.com/linux/latest/source/arch/arm64/include/asm/memory.h#L203 > slightly confusingly does "untag the addr if it's in the userspace > half, leave the tag bits alone if in the

Re: [PATCH v3 17/21] linux-user/aarch64: Signal SEGV_MTESERR for sync tag check fault

2021-01-22 Thread Peter Maydell
On Fri, 15 Jan 2021 at 22:47, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > linux-user/aarch64/target_signal.h | 2 ++ > linux-user/aarch64/cpu_loop.c | 3 +++ > 2 files changed, 5 insertions(+) > > diff --git a/linux-user/aarch64/target_signal.h > b/linux-user/aarc

[PATCH V5 1/6] hw/block/nvme: introduce nvme-subsys device

2021-01-22 Thread Minwoo Im
To support multi-path in QEMU NVMe device model, We need to have NVMe subsystem hierarchy to map controllers and namespaces to a NVMe subsystem. This patch introduced a simple nvme-subsys device model. The subsystem will be prepared with subsystem NQN with provided in nvme-subsys device: ex)

[PATCH V5 0/6] hw/block/nvme: support multi-path for ctrl/ns

2021-01-22 Thread Minwoo Im
Hello, Here's fifth patch series for the support of NVMe subsystem scheme with multi-controller and namespace sharing in a subsystem. This series has applied review comments from the previous series, mostly from Keith's review. Thanks Keith! Here's test result with a simple 'nvme list -v' comma

[PATCH V5 3/6] hw/block/nvme: add CMIC enum value for Identify Controller

2021-01-22 Thread Minwoo Im
Added Controller Multi-path I/O and Namespace Sharing Capabilities (CMIC) field to support multi-controller in the following patches. This field is in Identify Controller data structure in [76]. Signed-off-by: Minwoo Im --- include/block/nvme.h | 4 1 file changed, 4 insertions(+) diff --

[PATCH V5 4/6] hw/block/nvme: support for multi-controller in subsystem

2021-01-22 Thread Minwoo Im
We have nvme-subsys and nvme devices mapped together. To support multi-controller scheme to this setup, controller identifier(id) has to be managed. Earlier, cntlid(controller id) used to be always 0 because we didn't have any subsystem scheme that controller id matters. This patch introduced 'c

[PATCH V5 6/6] hw/block/nvme: support for shared namespace in subsystem

2021-01-22 Thread Minwoo Im
nvme-ns device is registered to a nvme controller device during the initialization in nvme_register_namespace() in case that 'bus' property is given which means it's mapped to a single controller. This patch introduced a new property 'subsys' just like the controller device instance did to map a n

[PATCH V5 2/6] hw/block/nvme: support to map controller to a subsystem

2021-01-22 Thread Minwoo Im
nvme controller(nvme) can be mapped to a NVMe subsystem(nvme-subsys). This patch maps a controller to a subsystem by adding a parameter 'subsys' to the nvme device. To map a controller to a subsystem, we need to put nvme-subsys first and then maps the subsystem to the controller: -device nvme-s

[PATCH V5 5/6] hw/block/nvme: add NMIC enum value for Identify Namespace

2021-01-22 Thread Minwoo Im
Added Namespace Multi-path I/O and Namespace Sharing Capabilities (NMIC) field to support shared namespace from controller(s). This field is in Identify Namespace data structure in [30]. Signed-off-by: Minwoo Im --- include/block/nvme.h | 4 1 file changed, 4 insertions(+) diff --git a/in

Re: Thread safety of coroutine-sigaltstack

2021-01-22 Thread Laszlo Ersek
On 01/22/21 11:14, Peter Maydell wrote: > On Fri, 22 Jan 2021 at 08:50, Max Reitz wrote: >> >> On 20.01.21 18:25, Laszlo Ersek wrote: >> >> [...] >> >>> A simple grep for SIGUSR2 seems to indicate that SIGUSR2 is not used >>> by system emulation for anything else, in practice. Is it possible >>> t

[PATCH] hw/mips: loongson3: Drop 'struct MemmapEntry'

2021-01-22 Thread Bin Meng
From: Bin Meng There is already a MemMapEntry type defined in hwaddr.h. Let's drop the loongson3 defined `struct MemmapEntry` and use the existing one. Signed-off-by: Bin Meng --- hw/mips/loongson3_bootp.h | 7 +-- hw/mips/loongson3_virt.c | 6 +++--- 2 files changed, 4 insertions(+), 9

[PATCH 0/4] hw/riscv: Clean-ups and map high mmio for PCIe of 'virt' machine

2021-01-22 Thread Bin Meng
From: Bin Meng This series does the following clean-ups: - Drop 'struct MemmapEntry' - virt: Drop the 'link_up' parameter of gpex_pcie_init() It also adds the following small enhancement to 'virt' machine: - Limit RAM size in a 32-bit system - Map high mmio for PCIe Bin Meng (4): hw/riscv: D

[PATCH 1/4] hw/riscv: Drop 'struct MemmapEntry'

2021-01-22 Thread Bin Meng
From: Bin Meng There is already a MemMapEntry type defined in hwaddr.h. Let's drop the RISC-V defined `struct MemmapEntry` and use the existing one. Signed-off-by: Bin Meng --- hw/riscv/microchip_pfsoc.c | 9 +++-- hw/riscv/opentitan.c | 9 +++-- hw/riscv/sifive_e.c|

[PATCH 2/4] hw/riscv: virt: Drop the 'link_up' parameter of gpex_pcie_init()

2021-01-22 Thread Bin Meng
From: Bin Meng `link_up` is never used in gpex_pcie_init(). Drop it. Signed-off-by: Bin Meng --- hw/riscv/virt.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index cfd52bc59b..1d05bb3ef9 100644 --- a/hw/riscv/virt.c +++ b

[PATCH 3/4] hw/riscv: virt: Limit RAM size in a 32-bit system

2021-01-22 Thread Bin Meng
From: Bin Meng RV32 supports 34-bit physical address hence the maximum RAM size should be limitted. Limit the RAM size to 10 GiB, which leaves some room for PCIe high mmio space. Signed-off-by: Bin Meng --- hw/riscv/virt.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/

[PATCH 4/4] hw/riscv: virt: Map high mmio for PCIe

2021-01-22 Thread Bin Meng
From: Bin Meng Some peripherals require 64-bit PCI address, so let's map the high mmio space for PCIe. For RV32, the address is hardcoded to below 4 GiB from the highest accessible physical address. For RV64, the base address depends on top of RAM and is aligned to its size which is using 16 GiB

Re: [PATCH v7 07/11] iotests: add findtests.py

2021-01-22 Thread Kevin Wolf
Am 22.01.2021 um 12:57 hat Vladimir Sementsov-Ogievskiy geschrieben: > 22.01.2021 14:48, Kevin Wolf wrote: > > Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > +def add_group_file(self, fname: str) -> None: > > > +with open(fname) as f: > > > +for l

Re: [PULL 10/11] vnc: move initialization to framebuffer_update_request

2021-01-22 Thread Laszlo Ersek
On 01/22/21 09:46, Gerd Hoffmann wrote: >> This patch breaks QEMU for me. > >> The symptom is the following: in virt-manager, the display remains dead >> (black), when I start an OVMF guest. At the same time, unusually high >> CPU load can be seen on the host; it makes me think that virt-manager i

Re: [PATCH v2] 9pfs: Improve unreclaim loop

2021-01-22 Thread Christian Schoenebeck
On Donnerstag, 21. Januar 2021 19:15:10 CET Greg Kurz wrote: > If a fid was actually re-opened by v9fs_reopen_fid(), we re-traverse the > fid list from the head in case some other request created a fid that > needs to be marked unreclaimable as well (ie. the client opened a new That's "i.e.". Not

Re: [PULL 0/5] Linux user for 6.0 patches

2021-01-22 Thread Peter Maydell
On Thu, 21 Jan 2021 at 12:43, Laurent Vivier wrote: > > The following changes since commit 48202c712412c803ddb56365c7bca322aa4e7506: > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-2021011= > 9-1' into staging (2021-01-19 15:47:23 +) > > are available in the Git repos

Re: About 'qemu-security' list subscription process

2021-01-22 Thread P J P
+-- On Fri, 15 Jan 2021, Daniel P. Berrangé wrote --+ | IOW ideally there should be some web of trust whereby some existing | member(s) knows the person/entity who is requesting acces. Other cases would | have to be evaluated case-by-case basis. * True, sounds reasonable. I'll probably start a t

Re: [PATCH v7 07/11] iotests: add findtests.py

2021-01-22 Thread Vladimir Sementsov-Ogievskiy
22.01.2021 15:45, Kevin Wolf wrote: Am 22.01.2021 um 12:57 hat Vladimir Sementsov-Ogievskiy geschrieben: 22.01.2021 14:48, Kevin Wolf wrote: Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: +def add_group_file(self, fname: str) -> None: +with open(fname) as f: +

Re: [PATCH] arm: rename xlnx-zcu102.canbusN properties

2021-01-22 Thread Peter Maydell
Just noticed this wasn't cc'd to the Xilinx folks. Would one of you like to review it? thanks -- PMM On Mon, 18 Jan 2021 at 16:25, Paolo Bonzini wrote: > > The properties to attach a CANBUS object to the xlnx-zcu102 machine have > a period in them. We want to use periods in properties for compo

[Bug 1912224] Re: qemu may freeze during drive-mirroring on fragmented FS

2021-01-22 Thread Alexandre arents
Seems a regression introduce in commit : (2.7.0) commit 0965a41e998ab820b5d660c8abfc8c819c97bc1b Author: Vladimir Sementsov-Ogievskiy Date: Thu Jul 14 20:19:01 2016 +0300 mirror: double performance of the bulk stage if the disc is full Mirror can do up to 16 in-flight requ

[PATCH v3 0/4] meson: Try to clarify TCG / TCI options for new users

2021-01-22 Thread Philippe Mathieu-Daudé
Since v2: - Included Thomas suggestions Some new users get confused between 'TCG' and 'TCI' and enable TCI when TCG is better for they needs. Try to clarify it is better to not use TCI when native backend is available. Note, before Meson, warnings were summarized at the end of ./configure. Now th

[PATCH v3 2/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-22 Thread Philippe Mathieu-Daudé
Some new users get confused with 'TCG' and 'TCI', and enable TCI support expecting to enable TCG. Emit a warning when native TCG backend is available on the host architecture, mentioning this is a suboptimal configuration. Reviewed-by: Stefan Weil Reviewed-by: Thomas Huth Signed-off-by: Philipp

[PATCH v3 1/4] meson: Explicit TCG backend used

2021-01-22 Thread Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth Reviewed-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 8535a83fb70..d5b76150e49 100644 --- a/meson.build +++ b/meson.build @@ -229,7 +229,

[PATCH v3 3/4] configure: Improve TCI feature description

2021-01-22 Thread Philippe Mathieu-Daudé
Users might want to enable all features, without realizing some features have negative effect. Mention the TCI feature is slow and experimental, hoping it will be selected knowingly. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- configure | 2 +- 1 file changed, 1 insertio

Re: [PATCH v7 07/11] iotests: add findtests.py

2021-01-22 Thread Kevin Wolf
Am 22.01.2021 um 14:16 hat Vladimir Sementsov-Ogievskiy geschrieben: > 22.01.2021 15:45, Kevin Wolf wrote: > > Am 22.01.2021 um 12:57 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > 22.01.2021 14:48, Kevin Wolf wrote: > > > > Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben:

[PATCH v3 4/4] configure: Reword --enable-tcg-interpreter as --disable-native-tcg

2021-01-22 Thread Philippe Mathieu-Daudé
Users might want to enable all features, without realizing some features have negative effect. Rename '--enable-tcg-interpreter' as '--disable-native-tcg' to avoid user selecting this feature without understanding it. '--enable-tcg-interpreter' is kept in for backward compability with scripts. Sug

Re: [PATCH v8 00/10] hw/ssi: imx_spi: Fix various bugs in the imx_spi model

2021-01-22 Thread Bin Meng
On Tue, Jan 19, 2021 at 9:40 PM Bin Meng wrote: > > From: Bin Meng > > This v8 series is based on the following 2 versions: > > - v5 series sent from Bin > http://patchwork.ozlabs.org/project/qemu-devel/list/?series=223919 > - v7 series sent from Philippe > http://patchwork.ozlabs.org/project

Re: [PATCH] hw/mips: loongson3: Drop 'struct MemmapEntry'

2021-01-22 Thread Philippe Mathieu-Daudé
On 1/22/21 1:24 PM, Bin Meng wrote: > From: Bin Meng > > There is already a MemMapEntry type defined in hwaddr.h. Let's drop > the loongson3 defined `struct MemmapEntry` and use the existing one. Not really... based on 0e324626306: $ git grep MemmapEntry origin/master -- include $ What tree ar

Re: [PULL 10/11] vnc: move initialization to framebuffer_update_request

2021-01-22 Thread Gerd Hoffmann
On Fri, Jan 22, 2021 at 01:49:38PM +0100, Laszlo Ersek wrote: > On 01/22/21 09:46, Gerd Hoffmann wrote: > >> This patch breaks QEMU for me. > > > >> The symptom is the following: in virt-manager, the display remains dead > >> (black), when I start an OVMF guest. At the same time, unusually high >

Re: [PATCH] hw/mips: loongson3: Drop 'struct MemmapEntry'

2021-01-22 Thread Bin Meng
On Fri, Jan 22, 2021 at 9:37 PM Philippe Mathieu-Daudé wrote: > > On 1/22/21 1:24 PM, Bin Meng wrote: > > From: Bin Meng > > > > There is already a MemMapEntry type defined in hwaddr.h. Let's drop > > the loongson3 defined `struct MemmapEntry` and use the existing one. > > Not really... based on

Re: [PATCH] hw/mips: loongson3: Drop 'struct MemmapEntry'

2021-01-22 Thread Philippe Mathieu-Daudé
On 1/22/21 2:37 PM, Philippe Mathieu-Daudé wrote: > On 1/22/21 1:24 PM, Bin Meng wrote: >> From: Bin Meng >> >> There is already a MemMapEntry type defined in hwaddr.h. Let's drop >> the loongson3 defined `struct MemmapEntry` and use the existing one. > > Not really... based on 0e324626306: > >

Re: [PATCH 05/25] keyval: simplify keyval_parse_one

2021-01-22 Thread Markus Armbruster
Paolo Bonzini writes: > Now that the key is NULL terminated, we can remove some of the contortions > that were done to operate on possibly '='-terminated strings in > keyval_parse_one. > > Signed-off-by: Paolo Bonzini Alright, I'm now ready to discuss the third argument: nicer code. I think th

Re: [PATCH v7 07/11] iotests: add findtests.py

2021-01-22 Thread Vladimir Sementsov-Ogievskiy
22.01.2021 16:34, Kevin Wolf wrote: Am 22.01.2021 um 14:16 hat Vladimir Sementsov-Ogievskiy geschrieben: 22.01.2021 15:45, Kevin Wolf wrote: Am 22.01.2021 um 12:57 hat Vladimir Sementsov-Ogievskiy geschrieben: 22.01.2021 14:48, Kevin Wolf wrote: Am 16.01.2021 um 14:44 hat Vladimir Sementsov-O

Re: [PATCH v7 10/11] iotests: rewrite check into python

2021-01-22 Thread Vladimir Sementsov-Ogievskiy
16.01.2021 16:44, Vladimir Sementsov-Ogievskiy wrote: Just use classes introduced in previous three commits. Behavior difference is described in these three commits. Drop group file, as it becomes unused. Drop common.env: now check is in python, and for tests we use same python interpreter that

Re: [PATCH] vnc: drop vnc_colordepth() call.

2021-01-22 Thread Laszlo Ersek
Hi Gerd, On 01/22/21 09:55, Gerd Hoffmann wrote: > With gtk-vnc (which supports VNC_FEATURE_WMVI) this results in > sending a VNC_ENCODING_WMVi message to the client. Which in turn > seems to make gtk-vnc respond with another non-incremental update > request. Hello endless loop ... > > Drop the

Re: [Qemu-devel] [PATCH v2 07/11] chardev: Let IOReadHandler use unsigned type

2021-01-22 Thread Philippe Mathieu-Daudé
Hi Prasad, Richard. On 1/22/21 12:52 PM, P J P wrote: > +-- On Fri, 22 Jan 2021, Richard Purdie wrote --+ > | If so can anyone point me at that change? > | > | I ask since CVE-2018-18438 is marked as affecting all qemu versions > | (https://nvd.nist.gov/vuln/detail/CVE-2018-18438). > | > | If it

Re: [PATCH v3 18/21] linux-user/aarch64: Signal SEGV_MTEAERR for async tag check error

2021-01-22 Thread Peter Maydell
On Fri, 15 Jan 2021 at 22:47, Richard Henderson wrote: > > Signed-off-by: Richard Henderson So when does the real kernel report async MTE exceptions to userspace? The commit message would be a good place to briefly describe the kernel's strategy and where QEMU differs from it (if anywhere)... >

Re: [PATCH v3 20/21] target/arm: Enable MTE for user-only

2021-01-22 Thread Peter Maydell
On Fri, 15 Jan 2021 at 22:47, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.c | 16 > 1 file changed, 16 insertions(+) > > diff --git a/target/arm/cpu.c b/target/arm/cpu.c > index abc0affd00..5e613a747a 100644 > --- a/target/arm/cpu.c > +++

  1   2   3   4   >