On 18/01/2021 07.37, Jiaxun Yang wrote:
Alpine Linux is a security-oriented, lightweight Linux distribution
based on musl libc and busybox.
It it popular among Docker guests and embedded applications.
Adding it to test against different libc.
Patches pending review at v2 are: 7, 8, 9
Tree avi
On Mon, 18 Jan 2021 14:03:08 +1100
David Gibson wrote:
> On Fri, Jan 15, 2021 at 02:24:25PM +0100, Cornelia Huck wrote:
> > On Thu, 14 Jan 2021 10:58:06 +1100
> > David Gibson wrote:
> >
> > > While we've abstracted some (potential) differences between mechanisms for
> > > securing guest memo
On 17/01/2021 19.48, Philippe Mathieu-Daudé wrote:
On 11/11/20 10:18 AM, Philippe Mathieu-Daudé wrote:
On 11/10/20 4:35 PM, Daniel P. Berrangé wrote:
On Tue, Nov 10, 2020 at 01:16:06PM +0100, Philippe Mathieu-Daudé wrote:
The EDK2 jobs use the 'changes' keyword, which "makes it
possible to def
On 17/01/21 21:10, Alexander Bulekov wrote:
This is useful for building reproducers. Instead checking the code or
the QEMU_FUZZ_ARGS, the arguments are at the top of the crash log.
Signed-off-by: Alexander Bulekov
---
tests/qtest/fuzz/fuzz.c | 11 ++-
1 file changed, 10 insertions(+)
On 18/01/21 07:32, P J P wrote:
From: Prasad J Pandit
While processing ATAPI cmd_read/cmd_read_cd commands,
Logical Block Address (LBA) maybe invalid OR closer to the last block,
leading to an OOB access issues. Add range check to avoid it.
Fixes: CVE-2020-29443
Reported-by: Wenxiang Qian
Fix
Public bug reported:
I created system with 7 NUMA nodes where nodes 0-3 should have 268435456 bytes
size and nodes 4-6 exactly 1610612736 bytes size, but when I run "numactl -H" I
got different (smaller) sizes.
It is essential for me to be able to emulate a system with nodes of exact size
- is
On 1/17/21 5:48 PM, Philippe Mathieu-Daudé wrote:
> cpu_loop_exit*() functions are declared in accel/tcg/cpu-exec-common.c,
> and are not available when TCG accelerator is not built. Add stubs so
> linking without TCG succeed.
>
> Problematic files:
>
> - hw/semihosting/console.c in qemu_semihost
On 1/17/21 5:48 PM, Philippe Mathieu-Daudé wrote:
> As cpu_io_recompile() is only called within TCG accelerator
> in cputlb.c, declare it locally.
>
> Signed-off-by: Philippe Mathieu-Daudé
It's only used in accel/tcg/cputlb.c, should it be a static function there?
> ---
> RFC because not sure
Hi Jiaxun,
On 1/18/21 2:17 AM, Jiaxun Yang wrote:
> Loongson IPI controller is a MMIO based simple level triggered
> interrupt controller. It will trigger IRQ to it's upstream
> processor when set register is written.
>
> It also has 4 64bit mailboxes to pass boot information to
> secondary proce
On 1/18/21 2:17 AM, Jiaxun Yang wrote:
> loongson3_virt has KVM SMP support in kenrel.
> This patch adds TCG SMP support by enable IPI controller
> for machine.
>
> Also add definition about IRQs to enhance readability.
>
> Note that TCG SMP can only support up to 4 CPUs as we
> didn't implement
On 1/17/21 5:48 PM, Philippe Mathieu-Daudé wrote:
> Watchpoint funtions use cpu_restore_state() which is only
> available when TCG accelerator is built. Restrict them
> to TCG.
>
> Signed-off-by: Philippe Mathieu-Daudé
I am doing some of this in my series, and I did not notice that
cpu_watchpoin
On 1/17/21 5:48 PM, Philippe Mathieu-Daudé wrote:
> cpu_gen_init() is TCG specific, only used in tcg/translate-all.c.
> No need to export it to other accelerators, declare it statically.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> We could also inline the 1-line call..
> ---
> include/exec
On 1/17/21 5:48 PM, Philippe Mathieu-Daudé wrote:
> tb_gen_code() is only called within TCG accelerator,
> declare it locally.
Is this used only in accel/tcg/cpu-exec.c ? Should it be a static function
there?
Ciao,
Claudio
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> accel/tcg/internal
On 1/17/21 5:48 PM, Philippe Mathieu-Daudé wrote:
> tb_flush_jmp_cache() is only called within TCG accelerator,
> declare it locally.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> We could also inline it in cputlb.c, the single user.
That is what I was thinking, I would be more inclined to p
Ping :-)
On Fri, Jan 08, 2021 at 06:12:52PM +0100, Stefano Garzarella wrote:
Commit 9d7bd0826f introduced a new 'use-disabled-flag' property
set to true by default.
To allow the migration, we set this property to false in the hw_compat,
but in the wrong place (hw_compat_4_1).
Since commit 9d7bd
On 1/17/21 5:48 PM, Philippe Mathieu-Daudé wrote:
> Hi,
>
> I've prepared some patches to have KVM-only builds.
> Some patches are generic - well kind of, instead they are
> TCG specific =) - so I'm sending them as a separate series.
>
> Please review,
>
> Phil.
I am wondering the best way to c
Hi Laurent,
On 1/18/21 8:33 AM, Laurent Vivier wrote:
> Le 14/01/2021 à 16:49, Philippe Mathieu-Daudé a écrit :
>> On 7/9/20 9:19 PM, Peter Maydell wrote:
>>> On Fri, 3 Jul 2020 at 21:19, Philippe Mathieu-Daudé wrote:
This is a proof-of-concept after chatting with Peter Maydell
on
On Fri, Jan 15, 2021 at 04:11:24PM +0100, Philippe Mathieu-Daudé wrote:
> I had a look at the patch from Miroslav trying to silence a
> compiler warning which in fact is a nasty bug. Here is a fix.
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg772735.html
>
> v2: Restrict tests so they
On 18/01/2021 00.09, Alexander Bulekov wrote:
For some device configurations, it is useful to configure some
resources, and adjust QEMU arguments at runtime, prior to fuzzing. This
patch adds an "argfunc" to generic the generic_fuzz_config. When
specified, it is responsible for configuring the re
On 1/18/21 9:30 AM, Thomas Huth wrote:
> On 17/01/2021 19.48, Philippe Mathieu-Daudé wrote:
>> On 11/11/20 10:18 AM, Philippe Mathieu-Daudé wrote:
>>> On 11/10/20 4:35 PM, Daniel P. Berrangé wrote:
On Tue, Nov 10, 2020 at 01:16:06PM +0100, Philippe Mathieu-Daudé wrote:
> The EDK2 jobs use
On 1/17/21 5:48 PM, Philippe Mathieu-Daudé wrote:
> cpu_loop_exit*() functions are declared in accel/tcg/cpu-exec-common.c,
> and are not available when TCG accelerator is not built. Add stubs so
> linking without TCG succeed.
The reason why stubs are needed here at all seems to be that that the c
On 18/01/2021 09.43, Paolo Bonzini wrote:
On 17/01/21 21:10, Alexander Bulekov wrote:
This is useful for building reproducers. Instead checking the code or
the QEMU_FUZZ_ARGS, the arguments are at the top of the crash log.
Signed-off-by: Alexander Bulekov
---
tests/qtest/fuzz/fuzz.c | 11 +++
On Jan 15 11:26, zhenwei pi wrote:
> v3 -> v4:
> - Drop "Fix overwritten bar.cap". (Already fixed)
>
> - Avoid to enqueue the duplicate event.
>
> - Several minor changes for coding style & function/variable name.
>
> v2 -> v3:
> - Introduce "Persistent Memory Region has become read-only or
>
On 1/18/21 10:10 AM, Claudio Fontana wrote:
> On 1/17/21 5:48 PM, Philippe Mathieu-Daudé wrote:
>> Watchpoint funtions use cpu_restore_state() which is only
>> available when TCG accelerator is built. Restrict them
>> to TCG.
>>
>> Signed-off-by: Philippe Mathieu-Daudé
>
> I am doing some of this
On 1/18/21 10:29 AM, Claudio Fontana wrote:
> On 1/17/21 5:48 PM, Philippe Mathieu-Daudé wrote:
>> cpu_loop_exit*() functions are declared in accel/tcg/cpu-exec-common.c,
>> and are not available when TCG accelerator is not built. Add stubs so
>> linking without TCG succeed.
>
> The reason why stu
On 1/18/21 7:38 AM, Jiaxun Yang wrote:
> Musl libc complains about it's wrong usage.
>
> In file included from ../subprojects/libvhost-user/libvhost-user.h:20,
> from ../subprojects/libvhost-user/libvhost-user-glib.h:19,
> from ../subprojects/libvhost-user/libvhos
On 1/18/21 7:38 AM, Jiaxun Yang wrote:
> From: Michael Forney
>
> Prior to 2a4b472c3c, sys/signal.h was only included on OpenBSD
> (apart from two .c files). The POSIX standard location for this
> header is just and in fact, OpenBSD's signal.h includes
> sys/signal.h itself.
>
> Unconditionally
On 1/18/21 7:38 AM, Jiaxun Yang wrote:
> As per POSIX specification of limits.h [1], OS libc may define
> PAGE_SIZE in limits.h.
>
> To prevent collosion of definition, we rename PAGE_SIZE here.
>
> [1]: https://pubs.opengroup.org/onlinepubs/7908799/xsh/limits.h.html
>
> Signed-off-by: Jiaxun Ya
On 1/18/21 7:38 AM, Jiaxun Yang wrote:
> As per POSIX specification of limits.h [1], OS libc may define
> PAGE_SIZE in limits.h.
>
> To prevent collosion of definition, we rename PAGE_SIZE here.
>
> [1]: https://pubs.opengroup.org/onlinepubs/7908799/xsh/limits.h.html
>
> Signed-off-by: Jiaxun Ya
From: Klaus Jensen
This is a resend of "hw/block/nvme: allow cmb and pmr to coexist" with
some more PMR work added (PMR RDS/WDS support).
This includes a resurrection of Andrzej's series[1] from back July.
Andrzej's main patch basically moved the CMB from BAR 2 into an offset
in BAR 4 (located
From: Klaus Jensen
Add the size of the mmio read/write to the trace event.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 4 ++--
hw/block/trace-events | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 47da73ce2364..bd7e25
From: Padmakar Kalghatgi
Implement v1.4 logic for configuring the Controller Memory Buffer. This
is not backward compatible with v1.3, so drivers that only support v1.3
will not be able to use the CMB anymore.
Signed-off-by: Padmakar Kalghatgi
Signed-off-by: Klaus Jensen
---
hw/block/nvme.h
From: Andrzej Jakowski
This patch sets CMBS bit in controller capabilities register when user
configures NVMe driver with CMB support, so capabilites are correctly
reported to guest OS.
Signed-off-by: Andrzej Jakowski
Reviewed-by: Maxim Levitsky
Signed-off-by: Klaus Jensen
---
include/block/
From: Klaus Jensen
64 bit registers like ASQ and ACQ should be writable by both a hi/lo 32
bit write combination as well as a plain 64 bit write. The spec does not
define ordering on the hi/lo split, but the code currently assumes that
the low order bits are written first. Additionally, the code
From: Klaus Jensen
Use the correct field names.
Signed-off-by: Klaus Jensen
---
include/block/nvme.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/include/block/nvme.h b/include/block/nvme.h
index 86d7fc2f905c..f3cbe17d0971 100644
--- a/include/block/nvme
From: Klaus Jensen
With BAR 4 now free to use, allow PMR and CMB to be enabled
simultaneously.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index ec2104fcf3b6..f3bea582b3c
From: Klaus Jensen
With the new CMB logic in place, bump the implemented specification
version to v1.4.
This requires adding the setting the CNTRLTYPE field and modifying the
VWC field since 0x00 is no longer a valid value for bits 2:1.
Signed-off-by: Klaus Jensen
---
include/block/nvme.h | 3
From: Klaus Jensen
The PMR should not be enabled at boot up. Disable the PMR MemoryRegion
initially and implement MMIO for PMRCTL, allowing the host to enable the
PMR explicitly.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(
From: Klaus Jensen
In the interest of supporting both CMB and PMR to be enabled on the same
device, move the MSI-X table and pending bit array out of BAR 4 and into
BAR 0.
This is a simplified version of the patch contributed by Andrzej
Jakowski (see [1]). Leaving the CMB at offset 0 removes the
From: Klaus Jensen
The controller registers are initially zero. Remove the redundant
zeroing.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 35 ---
1 file changed, 35 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index f3bea582b3c0..9ee9570bb6
From: Naveen Nagar
Add support for the PMRMSCL and PMRMSCU MMIO registers. This allows
adding RDS/WDS support for PMR as well.
Signed-off-by: Naveen Nagar
Signed-off-by: Klaus Jensen
---
hw/block/nvme.h | 1 +
include/block/nvme.h | 1 +
hw/block/nvme.c | 89 ++
Am 16.01.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 15.01.2021 16:30, Vladimir Sementsov-Ogievskiy wrote:
> > 15.01.2021 16:20, Kevin Wolf wrote:
> > > Am 15.01.2021 um 14:10 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > > 15.01.2021 15:45, Kevin Wolf wrote:
> > > > > Am 15
Hi Bin,
On [2021 Jan 15] Fri 22:38:18, Bin Meng wrote:
> Hi Francisco,
>
> On Fri, Jan 15, 2021 at 8:26 PM Francisco Iglesias
> wrote:
> >
> > Hi Bin,
> >
> > On [2021 Jan 15] Fri 10:07:52, Bin Meng wrote:
> > > Hi Francisco,
> > >
> > > On Fri, Jan 15, 2021 at 2:13 AM Francisco Iglesias
> > >
On 1/18/21 7:38 AM, Jiaxun Yang wrote:
> As per POSIX specification of limits.h [1], OS libc may define
> PAGE_SIZE in limits.h.
>
> Self defined PAGE_SIZE is frequently used in tests, to prevent
> collosion of definition, we give PAGE_SIZE definitons reasonable
> prefixs.
>
> [1]: https://pubs.o
On 15.01.21 20:27, Willian Rampazzo wrote:
On Fri, Jan 15, 2021 at 2:43 PM Max Reitz wrote:
Instead of checking iotests.py only, check all Python files in the
qemu-iotests/ directory. Of course, most of them do not pass, so there
is an extensive skip list for now. (The only files that do pas
On Mon, Jan 18, 2021 at 10:26:15AM +0100, Philippe Mathieu-Daudé wrote:
> On 1/18/21 9:30 AM, Thomas Huth wrote:
> > On 17/01/2021 19.48, Philippe Mathieu-Daudé wrote:
> >> On 11/11/20 10:18 AM, Philippe Mathieu-Daudé wrote:
> >>> On 11/10/20 4:35 PM, Daniel P. Berrangé wrote:
> On Tue, Nov 10
From: Klaus Jensen
The controller now implements v1.4 and we can lift the restrictions on
CMB Data Pointer and Command Independent Locations Support (CDPCILS) and
CMB Data Pointer Mixed Locations Support (CDPMLS) since the device
really does not care about mixed host/cmb pointers in those cases.
On Mon, Jan 18, 2021 at 02:38:08PM +0800, Jiaxun Yang wrote:
> We only run build test and check-acceptance as their are too many
> failures in checks due to minor string mismatch.
Can you give real examples of what's broken here, as that sounds
rather suspicious, and I'm not convinced it should be
On 1/18/21 7:32 AM, P J P wrote:
> From: Prasad J Pandit
>
> While processing ATAPI cmd_read/cmd_read_cd commands,
> Logical Block Address (LBA) maybe invalid OR closer to the last block,
> leading to an OOB access issues. Add range check to avoid it.
>
> Fixes: CVE-2020-29443
> Reported-by: Wen
15.01.2021 16:02, Alberto Garcia wrote:
When the x-blockdev-reopen was added it allowed reconfiguring the
graph by replacing backing files, but changing the 'file' option was
forbidden. Because of this restriction some operations are not
possible, notably inserting and removing block filters.
Th
> --- a/docs/specs/pci-ids.txt
> +++ b/docs/specs/pci-ids.txt
> @@ -64,6 +64,7 @@ PCI devices (other than virtio):
> 1b36:000d PCI xhci usb host adapter
> 1b36:000f mdpy (mdev sample device), linux/samples/vfio-mdev/mdpy.c
> 1b36:0010 PCIe NVMe device (-device nvme)
> +1b36:0011 PCI PVPanic
On 1/18/21 10:39 AM, Philippe Mathieu-Daudé wrote:
> On 1/18/21 10:29 AM, Claudio Fontana wrote:
>> On 1/17/21 5:48 PM, Philippe Mathieu-Daudé wrote:
>>> cpu_loop_exit*() functions are declared in accel/tcg/cpu-exec-common.c,
>>> and are not available when TCG accelerator is not built. Add stubs so
On 18/01/2021 11.11, Daniel P. Berrangé wrote:
On Mon, Jan 18, 2021 at 02:38:08PM +0800, Jiaxun Yang wrote:
We only run build test and check-acceptance as their are too many
failures in checks due to minor string mismatch.
Can you give real examples of what's broken here, as that sounds
rather
15.01.2021 16:02, Alberto Garcia wrote:
Hi,
during the past months we talked about making x-blockdev-reopen stable
API, and one of the missing things was having support for changing
bs->file. See here for the discusssion (I can't find the message from
Kashyap that started the thread in the web a
On Mon, Jan 18, 2021 at 11:22:47AM +0100, Thomas Huth wrote:
> On 18/01/2021 11.11, Daniel P. Berrangé wrote:
> > On Mon, Jan 18, 2021 at 02:38:08PM +0800, Jiaxun Yang wrote:
> > > We only run build test and check-acceptance as their are too many
> > > failures in checks due to minor string mismatc
On Sun, 17 Jan 2021 at 11:46, Michael S. Tsirkin wrote:
>
> The following changes since commit f8e1d8852e393b3fd524fb005e38590063d99bc0:
>
> Merge remote-tracking branch
> 'remotes/pmaydell/tags/pull-target-arm-20210112-1' into staging (2021-01-12
> 21:23:25 +)
>
> are available in the Git
On 1/17/21 10:18 PM, David Gibson wrote:
On Fri, Jan 15, 2021 at 03:52:56PM -0300, Daniel Henrique Barboza wrote:
On 1/15/21 2:22 PM, Greg Kurz wrote:
On Thu, 14 Jan 2021 15:06:28 -0300
Daniel Henrique Barboza wrote:
The only restriction we have when unplugging CPUs is to forbid unplug
Am 17.01.2021 um 17:48 hat Paolo Bonzini geschrieben:
> On 02/12/20 10:02, Paolo Bonzini wrote:
> > This series switches -object, -M and -accel from QemuOpts to keyval.
> > Monitor commands device_add and netdev_add are also switched to keyval,
> > though -device and -netdev for now are not.
> >
>
On 1/15/21 7:34 PM, Mihai Carabas wrote:
> Add pvpanic PCI device support details in docs/specs/pvpanic.txt.
>
> Signed-off-by: Mihai Carabas
> ---
> docs/specs/pvpanic.txt | 13 -
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/docs/specs/pvpanic.txt b/docs/specs
On Mon, Jan 18, 2021 at 02:38:07PM +0800, Jiaxun Yang wrote:
> Alpine Linux[1] is a security-oriented, lightweight Linux distribution
> based on musl libc and busybox.
>
> It it popular among Docker guests and embedded applications.
>
> Adding it to test against different libc.
>
> [1]: https://
There are a couple of environment variables that we fetch with
os.environ.get() without supplying a default. Clearly they are required
and expected to be set by the ./check script (as evidenced by
execute_setup_common(), which checks for test_dir and
qemu_default_machine to be set, and aborts if t
Instead of checking iotests.py only, check all Python files in the
qemu-iotests/ directory. Of course, most of them do not pass, so there
is an extensive skip list for now. (The only files that do pass are
209, 254, 283, and iotests.py.)
(Alternatively, we could have the opposite, i.e. an explic
Signed-off-by: Max Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Reviewed-by: Willian Rampazzo
---
tests/qemu-iotests/129 | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129
index 0e13244d85..2fc65ada6a 100755
--- a/te
@busy is false when the job is paused, which happens all the time
because that is how jobs yield (e.g. for mirror at least since commit
565ac01f8d3).
Back when 129 was added (2015), perhaps there was no better way of
checking whether the job was still actually running. Now we have the
@status fie
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Willian Rampazzo
---
tests/qemu-iotests/124| 8 +---
tests/qemu-iotests/iotests.py | 11 +++
2 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/tests/qemu-i
Cover letters:
v1: https://lists.nongnu.org/archive/html/qemu-block/2021-01/msg00254.html
v2: https://lists.nongnu.org/archive/html/qemu-block/2021-01/msg00296.html
v3: https://lists.nongnu.org/archive/html/qemu-block/2021-01/msg00371.html
v4: https://lists.nongnu.org/archive/html/qemu-block/2021-0
Throttling on the BB has not affected block jobs in a while, so it is
possible that one of the jobs in 129 finishes before the VM is stopped.
We can fix that by running the job from a throttle node.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
Revie
Issuing 'stop' on the VM drains all nodes. If the mirror job has many
large requests in flight, this may lead to significant I/O that looks a
bit like 'stop' would make the job try to complete (which is what 129
should verify not to happen).
We can limit the I/O in flight by limiting the buffer s
And consequentially drop it from 297's skip list.
Signed-off-by: Max Reitz
Reviewed-by: Willian Rampazzo
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/129 | 4 ++--
tests/qemu-iotests/297 | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/qemu-iotes
On Mon, 18 Jan 2021 12:12:03 +1100
David Gibson wrote:
> On Fri, Jan 15, 2021 at 06:22:16PM +0100, Greg Kurz wrote:
> > On Thu, 14 Jan 2021 15:06:28 -0300
> > Daniel Henrique Barboza wrote:
> >
> > > The only restriction we have when unplugging CPUs is to forbid unplug of
> > > the boot cpu cor
Before this patch, test_block_commit() performs an active commit, which
under the hood is a mirror job. If we want to test various different
block jobs, we should perhaps run an actual commit job instead.
Doing so requires adding an overlay above the source node before the
commit is done (and the
And consequentially drop it from 297's skip list.
Signed-off-by: Max Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Willian Rampazzo
---
tests/qemu-iotests/297 | 2 +-
tests/qemu-iotests/300 | 18 +++---
2 files changed, 16 insertions(+), 4 deletions(-)
diff --git a
Any update on this?
Tried on fresh env, Illegal instruction (core dumped), and Segmentation fault
(core dumped) errors are still thrown with go commands.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bug
The following changes since commit 825a215c003cd028e26c7d19aa5049d957345f43:
Merge remote-tracking branch
'remotes/kraxel/tags/audio-20210115-pull-request' into staging (2021-01-15
22:21:21 +)
are available in the Git repository at:
https://github.com/stsquad/qemu.git tags/pull-testing
Hello,
On 5/3/19 8:59 AM, Gerd Hoffmann wrote:
> From: Daniel P. Berrangé
>
> hw/usb/hcd-xhci.c: In function ‘usb_xhci_realize’:
> hw/usb/hcd-xhci.c:3339:66: warning: ‘%d’ directive output may be truncated
> writing between 1 and 10 bytes into a region of size 5 [-Wformat-trunca\
> tion=]
> 33
r-6.0-pull-request
for you to fetch changes up to 580e733321511ab4eda7d6ca14ca157d71ea8728:
hw/ide/ahci: Replace fprintf() by qemu_log_mask(GUEST_ERROR) (2021-01-18 11=
:51:26 +0100)
Trivial patches 20210118
Fix memory leaks
Use qem
From: Philippe Mathieu-Daudé
Replace I/O write error reported with error_report() by
qemu_log_mask(GUEST_ERROR) which allow filtering.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Reviewed-by: Stefano Garzarella
Message-Id: <20201210172834.178052-1-phi...@redhat.com>
Signed-
From: Gan Qixin
When running device-introspect-test, a memory leak occurred in the pl031_init
function, this patch use timer_free() in the finalize function to fix it.
ASAN shows memory leak stack:
Direct leak of 48 byte(s) in 1 object(s) allocated from:
#0 0xab97e1f0 in __interceptor_c
From: Philippe Mathieu-Daudé
Replace fprintf() calls by qemu_log_mask(LOG_GUEST_ERROR).
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Message-Id: <20210112112955.1849212-1-phi...@redhat.com>
Signed-off-by: Laurent Vivier
---
hw/ide/ahci.c | 8 +---
1 file changed, 5 inse
From: Gan Qixin
When running device-introspect-test, a memory leak occurred in the mos6522_init
function, this patch use timer_free() in the finalize function to fix it.
ASAN shows memory leak stack:
Direct leak of 96 byte(s) in 2 object(s) allocated from:
#0 0xfffd5fe9e1f0 in __interceptor
On Mon, Jan 18, 2021 at 12:31:07PM +0100, Philippe Mathieu-Daudé wrote:
> Hello,
>
> On 5/3/19 8:59 AM, Gerd Hoffmann wrote:
> > From: Daniel P. Berrangé
> >
> > hw/usb/hcd-xhci.c: In function ‘usb_xhci_realize’:
> > hw/usb/hcd-xhci.c:3339:66: warning: ‘%d’ directive output may be truncated
> >
On 11/19/20 5:16 PM, Daniele Buono wrote:
> Hi Philippe,
>
> On 11/6/2020 9:28 AM, Philippe Mathieu-Daudé wrote:
>> On 11/5/20 11:18 PM, Daniele Buono wrote:
>>> The UASStatus data structure has a variable sized field inside of
>>> type uas_iu,
>>> that however is not placed at the end of the data
On 1/18/21 12:35 PM, Daniel P. Berrangé wrote:
> On Mon, Jan 18, 2021 at 12:31:07PM +0100, Philippe Mathieu-Daudé wrote:
>> Hello,
>>
>> On 5/3/19 8:59 AM, Gerd Hoffmann wrote:
>>> From: Daniel P. Berrangé
>>>
>>> hw/usb/hcd-xhci.c: In function ‘usb_xhci_realize’:
>>> hw/usb/hcd-xhci.c:3339:66: wa
+-- On Mon, 18 Jan 2021, Paolo Bonzini wrote --+
| Thank you! This looks great.
| With the small spacing fix suggested by checkpatch,
| Reviewed-by: Paolo Bonzini
Thank you. Will send patch v3 with space typo fix.
| You may add a small patch on top to clamp s->nb_sectors at (uint64_t)INT_MAX
* Philippe Mathieu-Daudé (f4...@amsat.org) wrote:
> 'vmstate_dummy' is special and only used for user-mode. Rename
> it to something more specific.
> It was introduced restricted to user-mode in commit c71c3e99b8
> ("Add a vmstate_dummy struct for CONFIG_USER_ONLY") but this
> restriction was late
queued, thanks!
On Mon, Jan 18, 2021 at 10:19:55AM +0100, Stefano Garzarella wrote:
> Ping :-)
>
> On Fri, Jan 08, 2021 at 06:12:52PM +0100, Stefano Garzarella wrote:
> > Commit 9d7bd0826f introduced a new 'use-disabled-flag' property
> > set to true by default.
> > To allow the migration, we set
From: Prasad J Pandit
While processing ATAPI cmd_read/cmd_read_cd commands,
Logical Block Address (LBA) maybe invalid OR closer to the last block,
leading to an OOB access issues. Add range check to avoid it.
Fixes: CVE-2020-29443
Reported-by: Wenxiang Qian
Suggested-by: Paolo Bonzini
Reviewed
On 18/01/21 12:44, P J P wrote:
To confirm:
* (uint64_t)INT_MAX << 2 is => 8589934588 ~= 8.5G sectors ?
Media size would be:
8.5G * 512B(sector) => ~4TB
8.5G * 4096B(sector) => ~32TB
* We are limiting IDE media size to ~4TB/~32TB ?
s->nb_sectors is in units of 512B, s
On Sun, 17 Jan 2021 at 21:54, Alistair Francis wrote:
>
> The following changes since commit 825a215c003cd028e26c7d19aa5049d957345f43:
>
> Merge remote-tracking branch
> 'remotes/kraxel/tags/audio-20210115-pull-request' into staging (2021-01-15
> 22:21:21 +)
>
> are available in the Git re
Le 17/01/2021 à 20:24, Philippe Mathieu-Daudé a écrit :
> This device doesn't have fields to migrate. Be explicit
> by using vmstate_qdev_no_state_to_migrate.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/nubus/mac-nubus-bridge.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/h
Peter Maydell writes:
> On Fri, 15 Jan 2021 at 13:08, Alex Bennée wrote:
>>
>> The following changes since commit 7c79721606be11b5bc556449e5bcbc331ef6867d:
>>
>> Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210113'
>> into staging (2021-01-14 09:54:29 +)
>>
>> are av
18.01.2021 13:57, Max Reitz wrote:
Instead of checking iotests.py only, check all Python files in the
qemu-iotests/ directory. Of course, most of them do not pass, so there
is an extensive skip list for now. (The only files that do pass are
209, 254, 283, and iotests.py.)
(Alternatively, we co
Reviewed-by: Minwoo Im
+-- On Mon, 18 Jan 2021, Paolo Bonzini wrote --+
| s->nb_sectors is in units of 512B, so the limit would be 4TB. The purpose
| is to limit the lba and nb_sectors arguments (which are in 2048B units) of
| ide_atapi_cmd_read_{dma,pio} to INT_MAX.
* If it's for IDE_CD type, does the patch below lo
Hi Francisco,
On Mon, Jan 18, 2021 at 6:06 PM Francisco Iglesias
wrote:
>
> Hi Bin,
>
> On [2021 Jan 15] Fri 22:38:18, Bin Meng wrote:
> > Hi Francisco,
> >
> > On Fri, Jan 15, 2021 at 8:26 PM Francisco Iglesias
> > wrote:
> > >
> > > Hi Bin,
> > >
> > > On [2021 Jan 15] Fri 10:07:52, Bin Meng w
This tests that trying to write to a (read-only) scsi-cd device backed
by a read-write image file doesn't crash and results in the correct
error.
This is a regression test for https://bugs.launchpad.net/bugs/1906693.
Signed-off-by: Kevin Wolf
---
tests/qtest/virtio-scsi-test.c | 39
Kevin Wolf (2):
block: Separate blk_is_writable() and blk_supports_write_perm()
virtio-scsi-test: Test writing to scsi-cd device
include/sysemu/block-backend.h | 3 ++-
block/block-backend.c | 19 ++---
hw/block/dataplane/xen-block.c | 2 +-
hw/block/fdc.c
Currently, blk_is_read_only() tells whether a given BlockBackend can
only be used in read-only mode because its root node is read-only. Some
callers actually try to answer a slightly different question: Is the
BlockBackend configured to be writable, by taking write permissions on
the root node?
Th
On Montag, 18. Januar 2021 00:09:24 CET Alexander Bulekov wrote:
> virtio-9p devices are often used to expose a virtual-filesystem to the
> guest. There have been some bugs reported in this device, such as
> CVE-2018-19364, and CVE-2021-20181. We should fuzz this device
>
> This patch adds two vir
On 21-01-18 10:46:55, Klaus Jensen wrote:
> From: Klaus Jensen
>
> 64 bit registers like ASQ and ACQ should be writable by both a hi/lo 32
> bit write combination as well as a plain 64 bit write. The spec does not
> define ordering on the hi/lo split, but the code currently assumes that
> the low
1 - 100 of 319 matches
Mail list logo
