Re: Fwd: VirtioSound device emulation implementation

2021-01-15 Thread Shreyansh Chouhan
On Thu, 14 Jan 2021 at 23:17, Alex Bennée wrote: > > Shreyansh Chouhan writes: > > > Just an update: > > > > I've studied the virtio specification along with the source code and I > now > > understand what the device implementation is > > going to look like. Also I understand the source code a l

Re: [RFC PATCH v0 1/1] target/ppc: Support for H_RPT_INVALIDATE hcall

2021-01-15 Thread Bharata B Rao
On Wed, Jan 13, 2021 at 05:22:56PM +0100, Greg Kurz wrote: > Hi Bharata, > > On Wed, 6 Jan 2021 14:29:10 +0530 > Bharata B Rao wrote: > > > If KVM_CAP_RPT_INVALIDATE KVM capability is enabled, then > > > > - indicate the availability of H_RPT_INVALIDATE hcall to the guest via > > ibm,hyperta

Re: [PATCH 03/23] sdlaudio: add -audiodev sdl, out.buffer-count option

2021-01-15 Thread Markus Armbruster
Volker Rümelin writes: > Currently there is a crackling noise with SDL2 audio playback. > Commit bcf19777df: "audio/sdlaudio: Allow audio playback with > SDL2" already mentioned the crackling noise. > > Add an out.buffer-count option to give users a chance to select > sane settings for glitch fre

Re: [PATCH 0/2] ui/gtk: Update refresh rate on EGL as well

2021-01-15 Thread Gerd Hoffmann
Hi, > These patches were made in response to Volkers patches which dealt with > cleaning up my previous code: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg766686.html > and thus are meant to be merged after Volker's patches. > > Hopefully, this commit message isn't too daunting ;)

[PULL 0/1] 9p security fix 2021-01-15

2021-01-15 Thread Greg Kurz
The following changes since commit 7c79721606be11b5bc556449e5bcbc331ef6867d: Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210113' into staging (2021-01-14 09:54:29 +) are available in the Git repository at: https://gitlab.com/gkurz/qemu.git tags/9p-next-2021-01-15 f

RE: [PATCH 3/3] net/colo-compare: Add handler for passthrough connection

2021-01-15 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Thursday, January 14, 2021 9:45 PM > To: Zhang, Chen > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Eric Blake ; Dr. David Alan > Gilbert ; Markus Armbruster ; > Zhang Chen > Subject: Re: [PATCH 3/3] net/colo-compare: Add handler for

[PULL 1/1] 9pfs: Fully restart unreclaim loop (CVE-2021-20181)

2021-01-15 Thread Greg Kurz
Depending on the client activity, the server can be asked to open a huge number of file descriptors and eventually hit RLIMIT_NOFILE. This is currently mitigated using a reclaim logic : the server closes the file descriptors of idle fids, based on the assumption that it will be able to re-open them

RE: [PATCH 3/3] net/colo-compare: Add handler for passthrough connection

2021-01-15 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Thursday, January 14, 2021 9:51 PM > To: Zhang, Chen > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Eric Blake ; Dr. David Alan > Gilbert ; Markus Armbruster ; > Zhang Chen > Subject: Re: [PATCH 3/3] net/colo-compare: Add handler for

Re: [PATCH] qtest/npcm7xx_pwm-test: Fix memleak in pwm_qom_get

2021-01-15 Thread Philippe Mathieu-Daudé
On 1/15/21 8:56 AM, Gan Qixin wrote: > The pwm_qom_get function didn't free "response", which caused an indirect > memory leak. So use qobject_unref() to fix it. > > ASAN shows memory leak stack: > > Indirect leak of 7416 byte(s) in 18000 object(s) allocated from: > #0 0x7f96e2f79d4e in _

Re: [PATCH v4 3/3] hw/blocl/nvme: trigger async event during injecting smart warning

2021-01-15 Thread Philippe Mathieu-Daudé
On 1/15/21 4:27 AM, zhenwei pi wrote: > During smart critical warning injection by setting property from QMP > command, also try to trigger asynchronous event. > > Suggested by Keith, if a event has already been raised, there is no > need to enqueue the duplicate event any more. > > Signed-off-by

Re: [PATCH v4 1/3] block/nvme: introduce bit 5 for critical warning

2021-01-15 Thread Philippe Mathieu-Daudé
On 1/15/21 4:27 AM, zhenwei pi wrote: > According to NVMe spec 1.4 section "According to NVMe spec 1.4 section 5.14.1.2" > , introduce bit 5 > for "Persistent Memory Region has become read-only or unreliable". > > Signed-off-by: zhenwei pi > --- > include/block/nvme.h | 1 + > 1 file changed,

Re: [PATCH v3 01/10] iotests.py: Assume a couple of variables as given

2021-01-15 Thread Vladimir Sementsov-Ogievskiy
14.01.2021 20:02, Max Reitz wrote: There are a couple of environment variables that we fetch with os.environ.get() without supplying a default. Clearly they are required and expected to be set by the ./check script (as evidenced by execute_setup_common(), which checks for test_dir and qemu_defau

Re: [PATCH v3 18/19] i386: provide simple 'hv-default=on' option

2021-01-15 Thread Vitaly Kuznetsov
Igor Mammedov writes: > On Thu, 7 Jan 2021 16:14:49 +0100 > Vitaly Kuznetsov wrote: > >> Enabling Hyper-V emulation for a Windows VM is a tiring experience as it >> requires listing all currently supported enlightenments ("hv-*" CPU >> features) explicitly. We do have 'hv-passthrough' mode enab

Re: [PATCH v19 08/20] io: add qio_channel_readv_full_all_eof & qio_channel_readv_full_all helpers

2021-01-15 Thread Stefan Hajnoczi
On Thu, Jan 14, 2021 at 01:24:37PM -0500, Jag Raman wrote: > > > > On Jan 14, 2021, at 1:00 PM, Daniel P. Berrangé wrote: > > > > On Thu, Jan 14, 2021 at 12:55:58PM -0500, Jag Raman wrote: > >> > >> > >>> On Jan 14, 2021, at 11:27 AM, Stefan Hajnoczi wrote: > >>> > >>> On Thu, Jan 14, 2021

Re: [PATCH v2 2/7] audio: Add spaces around operator/delete redundant spaces

2021-01-15 Thread Philippe Mathieu-Daudé
On 1/15/21 2:24 AM, Zhang Han wrote: > Fix problems about spaces: > -operator needs spaces around it, add them. > -somespaces are redundant, remove them. > > Signed-off-by: Zhang Han > --- > audio/audio_template.h | 2 +- > audio/coreaudio.c | 2 +- > audio/dsoundaudio.c| 2 +- > audio/

Re: [PATCH v2 5/7] audio: Don't use '%#' in format strings

2021-01-15 Thread Philippe Mathieu-Daudé
On 1/15/21 2:24 AM, Zhang Han wrote: > Use '0x' prefix instead of '%#' > > Signed-off-by: Zhang Han > --- > audio/dsoundaudio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v3 09/10] iotests/129: Clean up pylint and mypy complaints

2021-01-15 Thread Max Reitz
On 14.01.21 21:02, Willian Rampazzo wrote: On Thu, Jan 14, 2021 at 2:41 PM Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/129 | 4 ++-- tests/qemu-iotests/297 | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotes

Re: USB Gen2 passthrough not working

2021-01-15 Thread Gerd Hoffmann
Hi, > usb 2-3: new SuperSpeedPlus Gen 2 USB device number 3 using xhci_hcd > localhost login: [ 72.763264] usb 1-4: new low-speed USB device number 3 > using xhci_hcd ilibusb reports LIBUSB_SPEED_SUPER_PLUS and qemu doesn't handle it ... Lets treat it like superspeed for now, does that he

Re: [PATCH] hw/block/nvme: fix for non-msix machines

2021-01-15 Thread Philippe Mathieu-Daudé
On 1/15/21 8:07 AM, Klaus Jensen wrote: > On Jan 12 14:20, Philippe Mathieu-Daudé wrote: >> On 1/12/21 1:47 PM, Klaus Jensen wrote: >>> From: Klaus Jensen >>> >>> Commit 1c0c2163aa08 ("hw/block/nvme: verify msix_init_exclusive_bar() >>> return value") had the unintended effect of breaking support

Re: [PATCH v2] machine: add missing doc for memory-backend option

2021-01-15 Thread Michal Privoznik
On 1/15/21 12:46 AM, Igor Mammedov wrote: Add documentation for '-machine memory-backend' CLI option and how to use it. And document that x-use-canonical-path-for-ramblock-id, is considered to be stable to make sure it won't go away by accident. Signed-off-by: Igor Mammedov --- v2: - add doc

Re: [PATCH] hw/block/nvme: fix for non-msix machines

2021-01-15 Thread Klaus Jensen
On Jan 15 10:37, Philippe Mathieu-Daudé wrote: > On 1/15/21 8:07 AM, Klaus Jensen wrote: > > On Jan 12 14:20, Philippe Mathieu-Daudé wrote: > >> On 1/12/21 1:47 PM, Klaus Jensen wrote: > >>> From: Klaus Jensen > >>> > >>> Commit 1c0c2163aa08 ("hw/block/nvme: verify msix_init_exclusive_bar() > >>>

Re: [PATCH v2] machine: add missing doc for memory-backend option

2021-01-15 Thread Peter Maydell
On Thu, 14 Jan 2021 at 23:48, Igor Mammedov wrote: > > Add documentation for '-machine memory-backend' CLI option and > how to use it. > > And document that x-use-canonical-path-for-ramblock-id, > is considered to be stable to make sure it won't go away by accident. That's not what the x- prefix

[PATCHv7 2/3] arm-virt: refactor gpios creation

2021-01-15 Thread Maxim Uvarov
No functional change. Just refactor code to better support secure and normal world gpios. Signed-off-by: Maxim Uvarov --- hw/arm/virt.c | 67 --- 1 file changed, 47 insertions(+), 20 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 96

[PATCHv7 0/3] arm-virt: add secure pl061 for reset/power down

2021-01-15 Thread Maxim Uvarov
v7: - same as v6, but resplit patches: patch 2 no function changes and refactor gpio setup for virt platfrom and patch 3 adds secure gpio. v6: - 64k align gpio memory region (Andrew Jones) - adjusted memory region to map this address in the corresponding atf patch v5: - removed vms

[PATCHv7 1/3] hw: gpio: implement gpio-pwr driver for qemu reset/poweroff

2021-01-15 Thread Maxim Uvarov
Implement gpio-pwr driver to allow reboot and poweroff machine. This is simple driver with just 2 gpios lines. Current use case is to reboot and poweroff virt machine in secure mode. Secure pl066 gpio chip is needed for that. Signed-off-by: Maxim Uvarov Reviewed-by: Hao Wu --- hw/gpio/Kconfig

[PATCHv7 3/3] arm-virt: add secure pl061 for reset/power down

2021-01-15 Thread Maxim Uvarov
Add secure pl061 for reset/power down machine from the secure world (Arm Trusted Firmware). Connect it with gpio-pwr driver. Signed-off-by: Maxim Uvarov --- hw/arm/Kconfig| 1 + hw/arm/virt.c | 50 +++ include/hw/arm/virt.h | 2 ++ 3 file

Re: [PATCH] hw/block/nvme: fix for non-msix machines

2021-01-15 Thread Philippe Mathieu-Daudé
On 1/15/21 10:46 AM, Klaus Jensen wrote: > On Jan 15 10:37, Philippe Mathieu-Daudé wrote: >> On 1/15/21 8:07 AM, Klaus Jensen wrote: >>> On Jan 12 14:20, Philippe Mathieu-Daudé wrote: On 1/12/21 1:47 PM, Klaus Jensen wrote: > From: Klaus Jensen > > Commit 1c0c2163aa08 ("hw/block/n

Re: [PATCH 0/2] net/eth: Fix stack-buffer-overflow in _eth_get_rss_ex_dst_addr()

2021-01-15 Thread Miroslav Rezanina
On Thu, Jan 14, 2021 at 03:50:39PM +0100, Philippe Mathieu-Daudé wrote: > I had a look at the patch from Miroslav trying to silence a > compiler warning which in fact is a nasty bug. Here is a fix. > https://www.mail-archive.com/qemu-devel@nongnu.org/msg772735.html > > Philippe Mathieu-Daudé (2)

[PULL 01/11] ui/gtk: don't try to redefine SI prefixes

2021-01-15 Thread Gerd Hoffmann
From: Volker Rümelin Redefining SI prefixes is always wrong. 1s has per definition 1000ms. Remove the misnamed named constant and replace it with a comment explaining the frequency to period conversion in two simple steps. Now you can cancel out the unit mHz in the comment with the implicit unit

[PULL 10/11] vnc: move initialization to framebuffer_update_request

2021-01-15 Thread Gerd Hoffmann
qemu sends various state info like current cursor shape to newly connected clients in response to a set_encoding message. This is not correct according to the rfb spec. Send that information in response to a full (incremental=0) framebuffer update request instead. Also send the resize informatio

[PULL 02/11] ui/gtk: rename variable window to widget

2021-01-15 Thread Gerd Hoffmann
From: Volker Rümelin The type of the variable window is GtkWidget. Rename the variable from window to widget, because windows and widgets are different things. Signed-off-by: Volker Rümelin Message-Id: <20201213165724.13418-2-vr_q...@t-online.de> Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 6

[PULL 07/11] ui: add support for remote power control to VNC server

2021-01-15 Thread Gerd Hoffmann
From: Daniel P. Berrangé The "XVP" (Xen VNC Proxy) extension defines a mechanism for a VNC client to issue power control requests to trigger graceful shutdown, reboot, or hard reset. This option is not enabled by default, since we cannot assume that users with VNC access implicitly have administ

[PULL 00/11] Ui 20210115 patches

2021-01-15 Thread Gerd Hoffmann
The following changes since commit 45240eed4f064576d589ea60ebadf3c11d7ab891: Merge remote-tracking branch 'remotes/armbru/tags/pull-yank-2021-01-13' int= o staging (2021-01-13 14:19:24 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/ui-20210115-pu

[PULL 03/11] ui/gtk: limit virtual console max update interval

2021-01-15 Thread Gerd Hoffmann
From: Volker Rümelin Limit the virtual console maximum update interval to GUI_REFRESH_INTERVAL_DEFAULT. This papers over a integer overflow bug in gtk3 on Windows where the reported monitor refresh frequency can be much smaller than the real refresh frequency. The gtk bug report can be found her

[PULL 11/11] vnc: add support for extended desktop resize

2021-01-15 Thread Gerd Hoffmann
The extended desktop resize encoding adds support for (a) clients sending resize requests to the server, and (b) multihead support. This patch implements (a). All resize requests are rejected by qemu. Qemu can't resize the framebuffer on its own, this is in the hands of the guest, so all qemu can

Re: [PATCH v4 04/11] vfio: Support for RamDiscardMgr in the !vIOMMU case

2021-01-15 Thread David Hildenbrand
On 14.01.21 16:57, David Hildenbrand wrote: > On 14.01.21 16:54, David Hildenbrand wrote: >> On 14.01.21 00:27, Alex Williamson wrote: >>> On Thu, 7 Jan 2021 14:34:16 +0100 >>> David Hildenbrand wrote: >>> Implement support for RamDiscardMgr, to prepare for virtio-mem support. Instead o

[PULL 04/11] ui/gtk: expose gd_monitor_update_interval

2021-01-15 Thread Gerd Hoffmann
From: Nikola Pavlica The gd_egl_refresh function, as the name suggests, is responsible for refreshing displays when using EGL graphics with QEMU's GTK UI. This is a perfect candidate for a function to update the refresh rate in. Since gd_monitor_update_interval is inaccessible from the gd_egl_re

[PULL 06/11] vnc: fix unfinalized tlscreds for VncDisplay

2021-01-15 Thread Gerd Hoffmann
From: Zihao Chang In vnc_display_open(), if tls-creds is enabled, do object_ref(object ref 1->2) for tls-creds. While in vnc_display_close(), object_unparent sets object ref to 1(2->1) and unparent the object for root. Problem: 1. the object can not be found from the objects_root, while the obje

[PULL 08/11] vnc: Fix a memleak in vnc_display_connect()

2021-01-15 Thread Gerd Hoffmann
From: Alex Chen Free the 'sioc' when the qio_channel_socket_connect_sync() fails. Reported-by: Euler Robot Signed-off-by: Alex Chen Reviewed-by: Li Qiang Reviewed-by: Laurent Vivier Message-Id: <20201126065702.35095-1-alex.c...@huawei.com> Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 1 + 1

[PULL 09/11] vnc: move check into vnc_cursor_define

2021-01-15 Thread Gerd Hoffmann
Move the check whenever a cursor exists into the vnc_cursor_define() function so callers don't have to do it. Suggested-by: Marc-André Lureau Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Message-id: 20210112134120.2031837-2-kra...@redhat.com ---

[PULL 05/11] ui/gtk: update monitor interval on egl displays

2021-01-15 Thread Gerd Hoffmann
From: Nikola Pavlica When running QEMU's GTK UI without EGL or OGL, the gd_monitor_update_interval function gets executed and the display refresh rate gets updated accordingly. However, when using EGL or just regular OGL, the function never gets executed. Which is why I decided that the function

Re: [PATCH] fuzz: Add virtio-9p configurations for fuzzing

2021-01-15 Thread Darren Kenny
Hi Alex, On Thursday, 2021-01-14 at 17:17:48 -05, Alexander Bulekov wrote: > Signed-off-by: Alexander Bulekov In general this look good, so: Reviewed-by: Darren Kenny but I do have a question below... > --- > tests/qtest/fuzz/generic_fuzz_configs.h | 12 > 1 file changed, 12 in

Re: [PATCH RFC 0/2] Add debug interface to kick/call on purpose

2021-01-15 Thread Daniel P . Berrangé
On Thu, Jan 14, 2021 at 04:27:28PM -0800, Dongli Zhang wrote: > The virtio device/driver (e.g., vhost-scsi and indeed any device including > e1000e) may hang due to the lost of IRQ or the lost of doorbell register > kick, e.g., > > https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg01711.htm

Re: [PATCH v2] machine: add missing doc for memory-backend option

2021-01-15 Thread Peter Krempa
On Fri, Jan 15, 2021 at 10:02:04 +, Peter Maydell wrote: > On Thu, 14 Jan 2021 at 23:48, Igor Mammedov wrote: > > > > Add documentation for '-machine memory-backend' CLI option and > > how to use it. > > > > And document that x-use-canonical-path-for-ramblock-id, > > is considered to be stable

Re: [PATCH v2] machine: add missing doc for memory-backend option

2021-01-15 Thread Peter Krempa
On Fri, Jan 15, 2021 at 11:43:10 +0100, Peter Krempa wrote: > On Fri, Jan 15, 2021 at 10:02:04 +, Peter Maydell wrote: > > On Thu, 14 Jan 2021 at 23:48, Igor Mammedov wrote: [...] > Removing the 'x-' will fix it only starting with qemu-6.0 and any > downstream which backports the removal of

Re: [PATCH v3 03/10] iotests: Move try_remove to iotests.py

2021-01-15 Thread Vladimir Sementsov-Ogievskiy
14.01.2021 20:02, Max Reitz wrote: Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v3 06/10] iotests/129: Use throttle node

2021-01-15 Thread Vladimir Sementsov-Ogievskiy
14.01.2021 20:03, Max Reitz wrote: Throttling on the BB has not affected block jobs in a while, so it is possible that one of the jobs in 129 finishes before the VM is stopped. We can fix that by running the job from a throttle node. Signed-off-by: Max Reitz Reviewed-by: Eric Blake you forget

Re: [PATCH v6 08/11] iotests: add testenv.py

2021-01-15 Thread Kevin Wolf
Am 09.01.2021 um 13:26 hat Vladimir Sementsov-Ogievskiy geschrieben: > Add TestEnv class, which will handle test environment in a new python > iotests running framework. > > Difference with current ./check interface: > - -v (verbose) option dropped, as it is unused > > - -xdiff option is dropped,

Re: [PATCH v3 09/10] iotests/129: Clean up pylint and mypy complaints

2021-01-15 Thread Vladimir Sementsov-Ogievskiy
14.01.2021 20:03, Max Reitz wrote: Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v3 02/10] iotests/297: Rewrite in Python and extend reach

2021-01-15 Thread Vladimir Sementsov-Ogievskiy
14.01.2021 20:02, Max Reitz wrote: Instead of checking iotests.py only, check all Python files in the qemu-iotests/ directory. Of course, most of them do not pass, so there is an extensive skip list for now. (The only files that do pass are 209, 254, 283, and iotests.py.) (Alternatively, we co

Re: [PATCH v3 10/10] iotests/300: Clean up pylint and mypy complaints

2021-01-15 Thread Vladimir Sementsov-Ogievskiy
14.01.2021 20:03, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/297 | 2 +- tests/qemu-iotests/300 | 18 +++--- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/297 b/tests/qemu-iotests/297 index 1dce1d1b1c..03d8604538 100755

Re: [PATCH for-5.2 00/10] block/export: vhost-user-blk server tests and input validation

2021-01-15 Thread Peter Maydell
On Tue, 17 Nov 2020 at 09:18, Michael S. Tsirkin wrote: > > On Wed, Nov 11, 2020 at 12:43:21PM +, Stefan Hajnoczi wrote: > > The vhost-user-blk server test was already in Michael Tsirkin's recent vhost > > pull request, but was dropped because it exposed vhost-user regressions > > (b7c1bd9d784

Re: [PATCH v11 0/5] UFFD write-tracking migration/snapshots

2021-01-15 Thread Andrey Gruzdev
Ping On 06.01.2021 18:21, Andrey Gruzdev wrote: This patch series is a kind of 'rethinking' of Denis Plotnikov's ideas he's implemented in his series '[PATCH v0 0/4] migration: add background snapshot'. Currently the only way to make (external) live VM snapshot is using existing dirty page log

Re: [PATCH] hw/misc/sifive_u_otp: handling the fails of blk_pread and blk_pwrite

2021-01-15 Thread Peter Maydell
Ping! This patch was trying to fix a Coverity issue (CID 1435959, 1435960, 1435961) -- is anybody planning to review it? (I'm not entirely sure 'guest error' is the right warning category, but I don't know the specifics of this device.) thanks -- PMM On Wed, 4 Nov 2020 at 09:29, Green Wan wrote

[PATCH v3 11/10] iotests: add flake8 linter

2021-01-15 Thread Vladimir Sementsov-Ogievskiy
pylint is good, but doesn't cover the PEP8. Let's add flake8, to be sure that our code sutisfy PEP8. Add new linter and fix some code style in checked files. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi! Here is my small addition to Max's series, hope you like it! Note, that this is not

Re: [PATCH v3 02/10] iotests/297: Rewrite in Python and extend reach

2021-01-15 Thread Max Reitz
On 15.01.21 12:13, Vladimir Sementsov-Ogievskiy wrote: 14.01.2021 20:02, Max Reitz wrote: Instead of checking iotests.py only, check all Python files in the qemu-iotests/ directory.  Of course, most of them do not pass, so there is an extensive skip list for now.  (The only files that do pass ar

Re: [PATCH v3 06/10] iotests/129: Use throttle node

2021-01-15 Thread Max Reitz
On 15.01.21 12:16, Vladimir Sementsov-Ogievskiy wrote: 14.01.2021 20:03, Max Reitz wrote: Throttling on the BB has not affected block jobs in a while, so it is possible that one of the jobs in 129 finishes before the VM is stopped. We can fix that by running the job from a throttle node. Signed

Re: [PATCH v3 10/10] iotests/300: Clean up pylint and mypy complaints

2021-01-15 Thread Max Reitz
On 15.01.21 12:30, Vladimir Sementsov-Ogievskiy wrote: 14.01.2021 20:03, Max Reitz wrote: Signed-off-by: Max Reitz ---   tests/qemu-iotests/297 |  2 +-   tests/qemu-iotests/300 | 18 +++---   2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/297 b/tes

Re: [PATCH v3 11/10] iotests: add flake8 linter

2021-01-15 Thread Max Reitz
On 15.01.21 12:53, Vladimir Sementsov-Ogievskiy wrote: pylint is good, but doesn't cover the PEP8. Let's add flake8, to be sure that our code sutisfy PEP8. Add new linter and fix some code style in checked files. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi! Here is my small addition to

[RFC PATCH 0/5] hw/block/nvme: support multi-path for ctrl/ns

2021-01-15 Thread Minwoo Im
Hello, This series added support for multi-path I/O with multi-controllers and namespace sharing. By supporting these features, we can test Linux kernel mpath(multi-path) code with this NVMe device. Patches from the first to third added multi-controller support in a NVM subsystem by adding a mpa

[RFC PATCH 1/5] hw/block/nvme: add controller id parameter

2021-01-15 Thread Minwoo Im
There is Contrller ID field in Identify Controller data structure and nvme device has never set this field, 0 by default. Added a parameter for controller identifier in a NVM subsystem. This is reflected to Identify Controller data structrue of the controller. This parameter is helpful when a us

[RFC PATCH 4/5] nvme: add NMIC enum value for Identify Namespace

2021-01-15 Thread Minwoo Im
Added Namespace Multi-path I/O and Namespace Sharing Capabilities (NMIC) field to support shared namespace from controller(s). This field is in Identify Namespace data structure in [30]. Signed-off-by: Minwoo Im --- include/block/nvme.h | 4 1 file changed, 4 insertions(+) diff --git a/in

[RFC PATCH 2/5] nvme: add CMIC enum value for Identify Controller

2021-01-15 Thread Minwoo Im
Added Controller Multi-path I/O and Namespace Sharing Capabilities (CMIC) field to support multi-controller in the following patches. This field is in Identify Controller data structure in [76]. Signed-off-by: Minwoo Im --- include/block/nvme.h | 4 1 file changed, 4 insertions(+) diff --

[RFC PATCH 3/5] hw/block/nvme: add multi-controller param for mpath

2021-01-15 Thread Minwoo Im
Added mpath.ctrl parameter to set multi-controller bit[1] in CMIC field in Identify Controller data structure. It will indicate that a NVM subsystem can have two or more controllers in the subsystem. To set up multi-controller in a NVM subsystem, user needs to give same serial parameter to the co

[RFC PATCH 5/5] hw/block/nvme: add namespace sharing param for mpath

2021-01-15 Thread Minwoo Im
Added mpath.ns parameter to set multi-namespace bit[0] in NMIC field in Identify Namespace data structure. It will indicate that the namespace can be shared by two or more controllers. Example: To share the namespace between two controllers in a NVM subsystem, first multi-controllers should be

Re: [PATCH v6 08/11] iotests: add testenv.py

2021-01-15 Thread Vladimir Sementsov-Ogievskiy
15.01.2021 14:18, Kevin Wolf wrote: Am 09.01.2021 um 13:26 hat Vladimir Sementsov-Ogievskiy geschrieben: Add TestEnv class, which will handle test environment in a new python iotests running framework. Difference with current ./check interface: - -v (verbose) option dropped, as it is unused -

[PATCH] hw/block/nvme: error if drive less than a zone size

2021-01-15 Thread Minwoo Im
If a user gives backing device file less than a single zone size, the namespace capacity will be reported to 0 and the kerenl will fail to allocate namespace silently. This patch errors in case that num_zones are 0 which is backing device is less than a single zone size. Signed-off-by: Minwoo Im

Re: [PATCH] fuzz: Add virtio-9p configurations for fuzzing

2021-01-15 Thread Greg Kurz
On Thu, 14 Jan 2021 17:17:48 -0500 Alexander Bulekov wrote: > Signed-off-by: Alexander Bulekov > --- No changelog at all ? > tests/qtest/fuzz/generic_fuzz_configs.h | 12 > 1 file changed, 12 insertions(+) > > diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h > b/tests/qtes

Re: [PATCH 0/9] hw/block: m25p80: Fix the mess of dummy bytes needed for fast read commands

2021-01-15 Thread Francisco Iglesias
Hi Bin, On [2021 Jan 15] Fri 10:07:52, Bin Meng wrote: > Hi Francisco, > > On Fri, Jan 15, 2021 at 2:13 AM Francisco Iglesias > wrote: > > > > Hi Bin, > > > > On [2021 Jan 14] Thu 23:08:53, Bin Meng wrote: > > > From: Bin Meng > > > > > > The m25p80 model uses s->needed_bytes to indicate how ma

Re: [PATCH v3 02/10] iotests/297: Rewrite in Python and extend reach

2021-01-15 Thread Vladimir Sementsov-Ogievskiy
15.01.2021 14:57, Max Reitz wrote: On 15.01.21 12:13, Vladimir Sementsov-Ogievskiy wrote: 14.01.2021 20:02, Max Reitz wrote: Instead of checking iotests.py only, check all Python files in the qemu-iotests/ directory.  Of course, most of them do not pass, so there is an extensive skip list for n

Re: [PATCH v6 08/11] iotests: add testenv.py

2021-01-15 Thread Kevin Wolf
Am 15.01.2021 um 13:19 hat Vladimir Sementsov-Ogievskiy geschrieben: > 15.01.2021 14:18, Kevin Wolf wrote: > > Am 09.01.2021 um 13:26 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > Add TestEnv class, which will handle test environment in a new python > > > iotests running framework. > > > > >

Re: [PATCH] fuzz: Add virtio-9p configurations for fuzzing

2021-01-15 Thread Christian Schoenebeck via
On Freitag, 15. Januar 2021 13:23:08 CET Greg Kurz wrote: > On Thu, 14 Jan 2021 17:17:48 -0500 > > Alexander Bulekov wrote: > > Signed-off-by: Alexander Bulekov > > --- > > No changelog at all ? Yeah, that's indeed quite short. :) > > tests/qtest/fuzz/generic_fuzz_configs.h | 12

Re: [PATCH v7 03/13] sev: Remove false abstraction of flash encryption

2021-01-15 Thread Cornelia Huck
On Thu, 14 Jan 2021 10:58:01 +1100 David Gibson wrote: > When AMD's SEV memory encryption is in use, flash memory banks (which are > initialed by pc_system_flash_map()) need to be encrypted with the guest's > key, so that the guest can read them. > > That's abstracted via the kvm_memcrypt_encryp

Re: [PATCH v7 04/13] confidential guest support: Move side effect out of machine_set_memory_encryption()

2021-01-15 Thread Cornelia Huck
On Thu, 14 Jan 2021 10:58:02 +1100 David Gibson wrote: > When the "memory-encryption" property is set, we also disable KSM > merging for the guest, since it won't accomplish anything. > > We want that, but doing it in the property set function itself is > thereoretically incorrect, in the unlike

[RFC PATCH 1/2] block: Allow changing bs->file on reopen

2021-01-15 Thread Alberto Garcia
When the x-blockdev-reopen was added it allowed reconfiguring the graph by replacing backing files, but changing the 'file' option was forbidden. Because of this restriction some operations are not possible, notably inserting and removing block filters. This patch adds support for replacing the 'f

[RFC PATCH 0/2] Allow changing bs->file on reopen

2021-01-15 Thread Alberto Garcia
Hi, during the past months we talked about making x-blockdev-reopen stable API, and one of the missing things was having support for changing bs->file. See here for the discusssion (I can't find the message from Kashyap that started the thread in the web archives): https://lists.gnu.org/archiv

[RFC PATCH 2/2] iotests: Update 245 to support replacing files with x-blockdev-reopen

2021-01-15 Thread Alberto Garcia
Signed-off-by: Alberto Garcia --- tests/qemu-iotests/245 | 54 +- tests/qemu-iotests/245.out | 4 +-- 2 files changed, 55 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/245 b/tests/qemu-iotests/245 index f9d68b3958..bad6911f0c 100755 --- a/

Re: [PATCH v7 05/13] confidential guest support: Rework the "memory-encryption" property

2021-01-15 Thread Cornelia Huck
On Thu, 14 Jan 2021 10:58:03 +1100 David Gibson wrote: > Currently the "memory-encryption" property is only looked at once we > get to kvm_init(). Although protection of guest memory from the > hypervisor isn't something that could really ever work with TCG, it's > not conceptually tied to the K

[PULL 01/30] tests/docker: Remove Debian 9 remnant lines

2021-01-15 Thread Alex Bennée
From: Philippe Mathieu-Daudé Debian 9 base container has been removed in commits e3755276d1f and c9d78b06c06. Remove the last remnants. Fixes: e3755276d1f ("tests/docker: Remove old Debian 9 containers") Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth

[PULL 02/30] Makefile: add GNU global tags support

2021-01-15 Thread Alex Bennée
GNU Global is another tags engine which is more like cscope in being able to support finding both references and definitions. You will be un-surprised to know it also integrates well with Emacs. The main benefit of integrating it into find-src-path is it takes less time to rebuild the database fro

[PULL 04/30] Add newline when generating Dockerfile

2021-01-15 Thread Alex Bennée
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico Signed-off-by: Alex Bennée Reviewed-by: Willian Rampazzo Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1610080146-14968-36-git-send-email-tsimp...@quicinc.com> Message-Id: <20210114165730.31607-5-alex.ben...@linaro.org> di

[PULL 00/30] testing, gdbstub and semihosting

2021-01-15 Thread Alex Bennée
The following changes since commit 7c79721606be11b5bc556449e5bcbc331ef6867d: Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210113' into staging (2021-01-14 09:54:29 +) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-testing-and-mi

[PULL 03/30] shippable.yml: Remove jobs duplicated on Gitlab-CI

2021-01-15 Thread Alex Bennée
From: Philippe Mathieu-Daudé The following jobs are duplicated on Gitlab-CI since commit 6bcb5fc0f7a ("gitlab-ci: Add cross-compiling build tests"): - IMAGE=debian-armel-cross TARGET_LIST=arm-softmmu -> cross-armel-system TARGET_LIST=arm-linux-user-> cross-armel-us

Re: [PATCH v6 08/11] iotests: add testenv.py

2021-01-15 Thread Vladimir Sementsov-Ogievskiy
15.01.2021 15:45, Kevin Wolf wrote: Am 15.01.2021 um 13:19 hat Vladimir Sementsov-Ogievskiy geschrieben: 15.01.2021 14:18, Kevin Wolf wrote: Am 09.01.2021 um 13:26 hat Vladimir Sementsov-Ogievskiy geschrieben: Add TestEnv class, which will handle test environment in a new python iotests runnin

Re: [PATCH] cirrus: don't run full qtest on macOS

2021-01-15 Thread Markus Armbruster
Mark Cave-Ayland writes: > On 06/01/2021 13:36, Daniel P. Berrangé wrote: > >>> The Cirrus CI macOS build hosts have exhibited a serious performance >>> degradation in recent months. For example the "qom-test" qtest takes >>> over an hour for only the qemu-system-aarch64 binary. This is as much >

[PULL 17/30] gdbstub: add support to Xfer:auxv:read: packet

2021-01-15 Thread Alex Bennée
From: Lirong Yuan This allows gdb to access the target’s auxiliary vector, which can be helpful for telling system libraries important details about the hardware, operating system, and process. Signed-off-by: Lirong Yuan [AJB: minor tweaks to test case, update MAINTAINERS] Signed-off-by: Alex B

[PULL 06/30] Makefile: wrap etags in quiet-command calls

2021-01-15 Thread Alex Bennée
For prettier output. Signed-off-by: Alex Bennée Reviewed-by: Willian Rampazzo Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210114165730.31607-7-alex.ben...@linaro.org> diff --git a/Makefile b/Makefile index bbab640b31..f7e9eb9f08 100644 --- a/Makefile +++ b/Makefile @@ -272,8 +272,13 @@

[PULL 25/30] semihosting: Support SYS_HEAPINFO when env->boot_info is not set

2021-01-15 Thread Alex Bennée
From: Keith Packard env->boot_info is only set in some ARM startup paths, so we cannot rely on it to support the SYS_HEAPINFO semihosting function. When not available, fallback to finding a RAM memory region containing the current stack and use the base of that. Signed-off-by: Keith Packard Sig

[PULL 16/30] gdbstub: implement a softmmu based test

2021-01-15 Thread Alex Bennée
This adds a new tests that allows us to test softmmu only features including watchpoints. To do achieve this we need to: - add _exit: labels to the boot codes - write a memory.py test case - plumb the test case into the build system - tweak the run_test script to: - re-direct output wh

[PULL 05/30] Makefile: wrap ctags in quiet-command calls

2021-01-15 Thread Alex Bennée
For prettier output. Signed-off-by: Alex Bennée Reviewed-by: Willian Rampazzo Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210114165730.31607-6-alex.ben...@linaro.org> diff --git a/Makefile b/Makefile index 0c509a7704..bbab640b31 100644 --- a/Makefile +++ b/Makefile @@ -250,8 +250,13 @@

[PULL 21/30] target/arm: use official org.gnu.gdb.aarch64.sve layout for registers

2021-01-15 Thread Alex Bennée
While GDB can work with any XML description given to it there is special handling for SVE registers on the GDB side which makes the users life a little better. The changes aren't that major and all the registers save the $vg reported the same. All that changes is: - report org.gnu.gdb.aarch64.sv

[PULL 18/30] gdbstub: drop CPUEnv from gdb_exit()

2021-01-15 Thread Alex Bennée
gdb_exit() has never needed anything from env and I doubt we are going to start now. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210108224256.2321-8-alex.ben...@linaro.org> diff --git a/include/exec/g

[PULL 10/30] audio: break generic buffer dependency on mixing-engine

2021-01-15 Thread Gerd Hoffmann
From: Volker Rümelin Break the unnecessary dependency of the generic buffer management code on mixing-engine. This is required for the next patch. Signed-off-by: Volker Rümelin Message-id: 9315afe5-5958-c0b4-ea1e-14769511a...@t-online.de Message-Id: <20210110100239.27588-10-vr_q...@t-online.de>

[PULL 30/30] semihosting: Implement SYS_ISERROR

2021-01-15 Thread Alex Bennée
From: Keith Packard Part of Semihosting for AArch32 and AArch64 Release 2.0 Signed-off-by: Keith Packard Signed-off-by: Alex Bennée Message-Id: <20210107170717.2098982-10-kei...@keithp.com> Message-Id: <20210108224256.2321-21-alex.ben...@linaro.org> diff --git a/hw/semihosting/arm-compat-semi

Re: [PATCH v7 07/13] confidential guest support: Introduce cgs "ready" flag

2021-01-15 Thread Cornelia Huck
On Thu, 14 Jan 2021 10:58:05 +1100 David Gibson wrote: > The platform specific details of mechanisms for implementing > confidential guest support may require setup at various points during > initialization. Thus, it's not really feasible to have a single cgs > initialization hook, but instead e

Re: [PATCH v6 08/11] iotests: add testenv.py

2021-01-15 Thread Kevin Wolf
Am 15.01.2021 um 14:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > 15.01.2021 15:45, Kevin Wolf wrote: > > Am 15.01.2021 um 13:19 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > 15.01.2021 14:18, Kevin Wolf wrote: > > > > Am 09.01.2021 um 13:26 hat Vladimir Sementsov-Ogievskiy geschrieben:

[PULL 21/30] dsoundaudio: rename dsound_open()

2021-01-15 Thread Gerd Hoffmann
From: Volker Rümelin Rename dsound_open() to dsound_set_cooperative_level(). The only task of that function is to set the cooperative level for DirectSound. Signed-off-by: Volker Rümelin Message-id: 9315afe5-5958-c0b4-ea1e-14769511a...@t-online.de Message-Id: <20210110100239.27588-21-vr_q...@t-

[PULL 07/30] Makefile: wrap cscope in quiet-command calls

2021-01-15 Thread Alex Bennée
For prettier output. Signed-off-by: Alex Bennée Reviewed-by: Willian Rampazzo Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210114165730.31607-8-alex.ben...@linaro.org> diff --git a/Makefile b/Makefile index f7e9eb9f08..2a926aaeb0 100644 --- a/Makefile +++ b/Makefile @@ -282,9 +282,17 @@

[PULL 01/30] sdlaudio: remove leftover SDL1.2 code

2021-01-15 Thread Gerd Hoffmann
From: Volker Rümelin Signed-off-by: Volker Rümelin Reviewed-by: Thomas Huth Message-id: 9315afe5-5958-c0b4-ea1e-14769511a...@t-online.de Message-Id: <20210110100239.27588-1-vr_q...@t-online.de> Signed-off-by: Gerd Hoffmann --- audio/sdlaudio.c | 30 +- 1 file chang

[PULL 09/30] sdlaudio: add recording functions

2021-01-15 Thread Gerd Hoffmann
From: Volker Rümelin Add audio recording functions. SDL 2.0.5 or later is required to use the recording functions. Playback continues to work with earlier SDL 2.0 versions. Signed-off-by: Volker Rümelin Message-id: 9315afe5-5958-c0b4-ea1e-14769511a...@t-online.de Message-Id: <20210110100239.275

  1   2   3   4   5   >