Re: [PATCH-for-5.2? v3 3/9] hw/usb: reorder fields in UASStatus

2021-01-14 Thread Marc-André Lureau
Hi On Thu, Nov 19, 2020 at 8:19 PM Daniele Buono wrote: > Hi Philippe, > > On 11/6/2020 9:28 AM, Philippe Mathieu-Daudé wrote: > > On 11/5/20 11:18 PM, Daniele Buono wrote: > >> The UASStatus data structure has a variable sized field inside of type > uas_iu, > >> that however is not placed at th

Re: [PATCH] docs/devel: Explain how acceptance tests can be skipped

2021-01-14 Thread Thomas Huth
On 13/01/2021 20.52, Wainer dos Santos Moschetta wrote: Documented under the "Acceptance tests using the Avocado Framework" section in testing.rst how environment variables are used to skip tests. Signed-off-by: Wainer dos Santos Moschetta --- CI (success): https://gitlab.com/wainersm/qemu/-/pi

Re: [PATCH v3 2/4] hw/block/nvme: fix overwritten bar.cap

2021-01-14 Thread Klaus Jensen
On Jan 14 15:22, zhenwei pi wrote: > After PMR initialization, bar.cap should not be clear in function > nvme_init_ctrl. Otherwise the PMR cap would be always disabled. > > Signed-off-by: zhenwei pi > --- > hw/block/nvme.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/block/nvme.c

Re: [PATCH v3 4/4] hw/blocl/nvme: trigger async event during injecting smart warning

2021-01-14 Thread Klaus Jensen
On Jan 14 15:22, zhenwei pi wrote: > During smart critical warning injection by setting property from QMP > command, also try to trigger asynchronous event. > > Signed-off-by: zhenwei pi > --- > hw/block/nvme.c | 47 --- > 1 file changed, 40 insertions

[PATCH 0/6] Fix some style problems in audio

2021-01-14 Thread Zhang Han
Some style problems in audio directory are found by checkpatch.pl. Fix these style problems. Zhang Han (6): audio: Add braces for statements/fix braces' position audio: Add spaces around operator/delete redundant spaces audio: foo* bar" should be "foo *bar". audio: Fix lines over 90 charac

[PATCH 2/6] audio: Add spaces around operator/delete redundant spaces

2021-01-14 Thread Zhang Han
Fix problems about spaces: -operator needs spaces around it, add them. -somespaces are redundant, remove them. Signed-off-by: Zhang Han --- audio/audio_template.h | 2 +- audio/coreaudio.c | 2 +- audio/dsoundaudio.c| 2 +- audio/jackaudio.c | 2 +- 4 files changed, 4 insertions(+)

[PATCH 1/6] audio: Add braces for statements/fix braces' position

2021-01-14 Thread Zhang Han
Fix problems about braces: -braces are necessary for all arms of if/for/while statements -else should follow close brace '}' Signed-off-by: Zhang Han --- audio/alsaaudio.c | 15 +-- audio/audio.c | 26 -- audio/audio_template.h | 12

[PATCH 5/6] audio: Don't use '#' flag of printf format ('%#') in

2021-01-14 Thread Zhang Han
Use '0x' prefix instead of '%#' Signed-off-by: Zhang Han --- audio/dsoundaudio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audio/dsoundaudio.c b/audio/dsoundaudio.c index 1891a38bee..f7a3351306 100644 --- a/audio/dsoundaudio.c +++ b/audio/dsoundaudio.c @@ -215,7 +215,7

[PATCH 3/6] audio: foo* bar" should be "foo *bar".

2021-01-14 Thread Zhang Han
Transfer "foo* " to "foo *" Signed-off-by: Zhang Han --- audio/coreaudio.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/audio/coreaudio.c b/audio/coreaudio.c index 6ca0d79c1f..b7c02e0e51 100644 --- a/audio/coreaudio.c +++ b/audio/coreaudio.c @@ -421,12 +421,12

Re: [PATCH v3 2/2] s390x: Use strpadcpy for copying vm name

2021-01-14 Thread Thomas Huth
On 14/01/2021 08.07, Miroslav Rezanina wrote: Using strncpy with length equal to the size of target array, GCC 11 reports following warning: warning: '__builtin_strncpy' specified bound 256 equals destination size [-Wstringop-truncation] We can prevent this warning by using strpadcpy that c

[PATCH] utils/fifo8: change fatal errors from abort() to assert()

2021-01-14 Thread Mark Cave-Ayland
Developer errors are better represented with assert() rather than abort(). Signed-off-by: Mark Cave-Ayland --- This was suggested by Peter during a discussion on IRC yesterday. --- util/fifo8.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/util/fifo8.c b/

[PATCH 6/6] audio: Suspect code indent for conditional statements

2021-01-14 Thread Zhang Han
Fix code indent. Signed-off-by: Zhang Han --- audio/paaudio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index b052084698..7ea9f637c2 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -437,7 +437,7 @@ static pa_stream *qpa_simple_new

[PATCH 4/6] audio: Fix lines over 90 characters

2021-01-14 Thread Zhang Han
Fix the line width of code. Signed-off-by: Zhang Han --- audio/dsoundaudio.c | 37 +++-- 1 file changed, 27 insertions(+), 10 deletions(-) diff --git a/audio/dsoundaudio.c b/audio/dsoundaudio.c index 38ae2471f6..1891a38bee 100644 --- a/audio/dsoundaudio.c +++ b/a

Re: [PATCH v3 3/4] hw/block/nvme: add smart_critical_warning property

2021-01-14 Thread Klaus Jensen
On Jan 14 15:22, zhenwei pi wrote: > There is a very low probability that hitting physical NVMe disk > hardware critical warning case, it's hard to write & test a monitor > agent service. > > For debugging purposes, add a new 'smart_critical_warning' property > to emulate this situation. > > The

Re: [PATCH 0/6] Fix some style problems in audio

2021-01-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210114081059.19632-1-zhangha...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210114081059.19632-1-zhangha...@huawei.com Subject: [PATCH 0/6] Fix some style proble

Re: [PATCH v7 07/13] confidential guest support: Introduce cgs "ready" flag

2021-01-14 Thread Greg Kurz
On Thu, 14 Jan 2021 10:58:05 +1100 David Gibson wrote: > The platform specific details of mechanisms for implementing > confidential guest support may require setup at various points during > initialization. Thus, it's not really feasible to have a single cgs > initialization hook, but instead e

Re: [PATCH] utils/fifo8: change fatal errors from abort() to assert()

2021-01-14 Thread Claudio Fontana
On 1/14/21 9:33 AM, Mark Cave-Ayland wrote: > Developer errors are better represented with assert() rather than abort(). ... "also, make the tests more strict" I'd add this since the checks have been changed sometimes in the patch to be more strict. Reviewed-by: Claudio Fontana > > Signed-of

Re: [PATCH v7 13/13] s390: Recognize confidential-guest-support option

2021-01-14 Thread Christian Borntraeger
On 14.01.21 00:58, David Gibson wrote: [...] > +int s390_pv_init(ConfidentialGuestSupport *cgs, Error **errp) > +{ > +if (!object_dynamic_cast(OBJECT(cgs), TYPE_S390_PV_GUEST)) { > +return 0; > +} > + > +if (!s390_has_feat(S390_FEAT_UNPACK)) { > +error_setg(errp, > +

[PATCH] target/i386: Fix decoding of certain BMI instructions

2021-01-14 Thread David Greenaway via
This patch fixes a translation bug for a subset of x86 BMI instructions such as the following: c4 e2 f9 f7 c0shlxq %rax, %rax, %rax Currently, these incorrectly generate an undefined instruction exception when SSE is disabled via CR4, while instructions like "shrxq" work fine

[PATCH] tests/meson.build: use relative path to refer to files

2021-01-14 Thread Changqing Li
Fix error like: Fatal error: can't create tests/ptimer-test.p/..._qemu-5.2.0_hw_core_ptimer.c.o: File name too long when build path is too long, use meson.source_root() will make this filename too long. Fixed by using relative path to refer to files Signed-off-by: Changqing Li --- tests/meson.

Re: [PATCH v7 13/13] s390: Recognize confidential-guest-support option

2021-01-14 Thread Christian Borntraeger
On 14.01.21 10:10, Christian Borntraeger wrote: > > > On 14.01.21 00:58, David Gibson wrote: > [...] >> +int s390_pv_init(ConfidentialGuestSupport *cgs, Error **errp) >> +{ >> +if (!object_dynamic_cast(OBJECT(cgs), TYPE_S390_PV_GUEST)) { >> +return 0; >> +} >> + >> +if (!s3

Re: [PATCH v2 1/8] iotests/297: Allow checking all Python test files

2021-01-14 Thread Max Reitz
On 13.01.21 20:01, Eric Blake wrote: On 1/13/21 11:57 AM, Max Reitz wrote: I.e., all Python files in the qemu-iotests/ directory. Most files of course do not pass, so there is an extensive skip list for now. (The only files that do pass are 209, 254, 283, and iotests.py.) (Alternatively, we c

Re: [PATCH v7 13/13] s390: Recognize confidential-guest-support option

2021-01-14 Thread Christian Borntraeger
On 14.01.21 10:19, Christian Borntraeger wrote: > > > On 14.01.21 10:10, Christian Borntraeger wrote: >> >> >> On 14.01.21 00:58, David Gibson wrote: >> [...] >>> +int s390_pv_init(ConfidentialGuestSupport *cgs, Error **errp) >>> +{ >>> +if (!object_dynamic_cast(OBJECT(cgs), TYPE_S390_PV_G

Re: [PATCH v2 1/8] iotests/297: Allow checking all Python test files

2021-01-14 Thread Max Reitz
On 13.01.21 20:27, Vladimir Sementsov-Ogievskiy wrote: 13.01.2021 20:57, Max Reitz wrote: I.e., all Python files in the qemu-iotests/ directory. Most files of course do not pass, so there is an extensive skip list for now.  (The only files that do pass are 209, 254, 283, and iotests.py.) (Alte

Re: [PATCH] vnc: fix unfinalized tlscreds for VncDisplay

2021-01-14 Thread Gerd Hoffmann
On Mon, Jan 11, 2021 at 09:19:11PM +0800, Zihao Chang wrote: > In vnc_display_open(), if tls-creds is enabled, do object_ref(object > ref 1->2) for tls-creds. While in vnc_display_close(), object_unparent > sets object ref to 1(2->1) and unparent the object for root. > Problem: > 1. the object can

Re: About creating machines on the command line

2021-01-14 Thread Luc Michel
Hi Zoltan, On 1/11/21 9:04 PM, BALATON Zoltan wrote: On Mon, 11 Jan 2021, Luc Michel wrote: Hi, We would like to work on improving QEMU to be able to create custom machines from the command line. The goal here is to get feedback from the community and shape the future developments. The use

Re: [PATCH v2 1/8] iotests/297: Allow checking all Python test files

2021-01-14 Thread Max Reitz
On 13.01.21 21:28, Vladimir Sementsov-Ogievskiy wrote: 13.01.2021 22:27, Vladimir Sementsov-Ogievskiy wrote: 13.01.2021 20:57, Max Reitz wrote: I.e., all Python files in the qemu-iotests/ directory. Most files of course do not pass, so there is an extensive skip list for now.  (The only files

Re: [PATCH v7 02/13] confidential guest support: Introduce new confidential guest support class

2021-01-14 Thread Daniel P . Berrangé
On Thu, Jan 14, 2021 at 10:58:00AM +1100, David Gibson wrote: > Several architectures have mechanisms which are designed to protect guest > memory from interference or eavesdropping by a compromised hypervisor. AMD > SEV does this with in-chip memory encryption and Intel's MKTME can do > similar t

Re: [qemu-web PATCH] Use GitLab repo URLs instead of git.qemu.org URLs

2021-01-14 Thread Stefan Hajnoczi
On Wed, Jan 13, 2021 at 06:43:15PM +, Alex Bennée wrote: > > Stefan Hajnoczi writes: > > > Switch to GitLab repo URLs to reduce qemu.org bandwidth. > > > > Note that there is still one git.qemu.org remaining in > > _posts/2018-06-28-tcg-testing.md. The git object doesn't exist in GitLab > >

Re: [PATCH 0/3] ui/gtk: paper over a gtk bug on Windows

2021-01-14 Thread Gerd Hoffmann
On Sun, Dec 13, 2020 at 05:56:28PM +0100, Volker Rümelin wrote: > Patch dc26435edb "ui/gtk: Update refresh interval after widget > is realized" exposed a bug in gtk on Windows. The monitor refresh > rate reported by gtk may be much smaller than the real refresh > rate leading to an unusable guest

Re: [qemu-web PATCH v2] Use GitLab repo URLs instead of git.qemu.org URLs

2021-01-14 Thread Thomas Huth
On 13/01/2021 19.54, Stefan Hajnoczi wrote: Switch to GitLab repo URLs to reduce qemu.org bandwidth. Signed-off-by: Stefan Hajnoczi --- v2: * Added missing URL in _posts/2018-06-28-tcg-testing.md. Mark Cave-Ayland and Alex Bennée figured out the issue was that the gitweb link re

Re: Emulation for riscv

2021-01-14 Thread Bin Meng
On Thu, Jan 14, 2021 at 8:09 AM Alistair Francis wrote: > > On Fri, Nov 6, 2020 at 2:36 AM Alex Bennée wrote: > > > > > > Palmer Dabbelt writes: > > > > > On Thu, 22 Oct 2020 17:56:38 PDT (-0700), alistai...@gmail.com wrote: > > >> On Thu, Oct 22, 2020 at 4:58 PM Moises Arreola > > >> wrote: >

Re: [PATCHv4 2/2] arm-virt: add secure pl061 for reset/power down

2021-01-14 Thread Peter Maydell
On Thu, 14 Jan 2021 at 00:04, Andrew Jones wrote: > > On Wed, Jan 13, 2021 at 10:30:47AM +0300, Maxim Uvarov wrote: > > - the same size for secure and non secure gpio. Arm doc says that > > secure memory is also split on 4k pages. So one page here has to be > > ok. > > To be clear, does that means

Re: [PATCH 1/8] build-system: clean up TCG/TCI configury

2021-01-14 Thread John Paul Adrian Glaubitz
Hello! On 1/13/21 3:23 PM, Helge Deller wrote: >> This is what that TCG interpreter provides for. eg would anyone >> really want to emulate aarch64 guest when runing on a hppa host ? > > In debian many packages directly and indirectly depend on the qemu > source package, because it provides - besi

Re: [PULL 0/7] qemu-macppc queue 20210113

2021-01-14 Thread Peter Maydell
On Wed, 13 Jan 2021 at 16:11, Mark Cave-Ayland wrote: > > The following changes since commit f8e1d8852e393b3fd524fb005e38590063d99bc0: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20210112-1' into staging (2021-01-12 > 21:23:25 +) > > are available in the Git r

Re: [PATCH] utils/fifo8: change fatal errors from abort() to assert()

2021-01-14 Thread Mark Cave-Ayland
On 14/01/2021 09:07, Claudio Fontana wrote: On 1/14/21 9:33 AM, Mark Cave-Ayland wrote: Developer errors are better represented with assert() rather than abort(). ... "also, make the tests more strict" I'd add this since the checks have been changed sometimes in the patch to be more strict.

Re: [PATCH v2 3/6] tcg/ppc: Hoist common argument loads in tcg_out_op()

2021-01-14 Thread Philippe Mathieu-Daudé
On 1/14/21 1:28 AM, Richard Henderson wrote: > > Let's just drop the hoisting parts and only do the signature parts for now. > I'd rather think of a way to split up this large function than waste time > optimizing it. Agreed :) Thanks!

[PATCH v5 2/8] acpi: Fix unmatched expected DSDT.pxb file

2021-01-14 Thread Jiahui Cen
Commit fe1127da11 ("unit-test: Add the binary file and clear diff.h") does not use the up-to-date expected file for pxb for ARM virt. Fix the expected DSDT.pxb file. Full diff of changed file disassembly: @@ -5,13 +5,13 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of t

Re: [PATCH v7 09/13] confidential guest support: Update documentation

2021-01-14 Thread Greg Kurz
On Thu, 14 Jan 2021 10:58:07 +1100 David Gibson wrote: > Now that we've implemented a generic machine option for configuring various > confidential guest support mechanisms: > 1. Update docs/amd-memory-encryption.txt to reference this rather than > the earlier SEV specific option > 2. Ad

[PATCH v5 0/8] acpi: Some fixes for pxb support for ARM virt machine

2021-01-14 Thread Jiahui Cen
This patch series adds some fixes for ARM virt machine pxb support. 1. Pass addr offset for IO, MMIO and bus number when builing crs, because the addr_trans is needed to describe an addr resource. [1] 2. Inform guest os not to ignore the resource map generated by firmware as the x86 default way. [2

[PATCH v5 4/8] acpi/gpex: Inform os to keep firmware resource map

2021-01-14 Thread Jiahui Cen
There may be some differences in pci resource assignment between guest os and firmware. Eg. A Bridge with Bus [d2] -+-[:d2]---01.0-[d3]01.0 where [d2:01.00] is a pcie-pci-bridge with BAR0 (mem, 64-bit, non-pref) [size=256] [d3:01.00] is a PCI Device with BAR0 (mem, 64-b

[PATCH v5 1/8] acpi: Allow DSDT acpi table changes

2021-01-14 Thread Jiahui Cen
Acked-by: Igor Mammedov Signed-off-by: Jiahui Cen --- tests/qtest/bios-tables-test-allowed-diff.h | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8b..42418e58e7 100644 --- a/tests/qt

[PATCH v5 6/8] Kconfig: Compile PXB for ARM_VIRT

2021-01-14 Thread Jiahui Cen
PXB is now supported on ARM, so let's compile for arm_virt machine. Acked-by: Igor Mammedov Signed-off-by: Jiahui Cen --- hw/pci-bridge/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-bridge/Kconfig b/hw/pci-bridge/Kconfig index a51ec716f5..f8df4315ba 100644 -

[PATCH v5 7/8] acpi: Enable pxb unit-test for ARM virt machine

2021-01-14 Thread Jiahui Cen
No matter whether the pxb is enabled or not, the CONFIG_PXB macro in test would keep undefined. And since pxb is now enabled for ARM Virt machine by default, let's enable pxb unit-test by removing the CONFIG_PXB. Acked-by: Igor Mammedov Signed-off-by: Jiahui Cen --- tests/qtest/bios-tables-test

[PATCH v5 8/8] acpi: Update _DSM method in expected files

2021-01-14 Thread Jiahui Cen
A new _DSM #5 method is added. Update expected DSDT files accordingly, and re-enable their testing. Full diff of changed files disassembly: tests/data/acpi/microvm/DSDT.pcie.dsl: @@ -5,13 +5,13 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of tests/data/acpi/microvm/DSD

[PATCH v5 5/8] acpi/gpex: Exclude pxb's resources from PCI0

2021-01-14 Thread Jiahui Cen
Exclude the resources of extra root bridges from PCI0's _CRS. Otherwise, the resource windows would overlap in guest, and the IO resource window would fail to be registered. Acked-by: Igor Mammedov Signed-off-by: Jiahui Cen --- hw/pci-host/gpex-acpi.c | 64 +--- 1 file changed,

[PATCH v5 3/8] acpi: Add addr offset in build_crs

2021-01-14 Thread Jiahui Cen
AML needs Address Translation offset to describe how a bridge translates addresses accross the bridge when using an address descriptor, and especially on ARM, the translation offset of pio resource is usually non zero. Therefore, it's necessary to pass offset for pio, mmio32, mmio64 and bus number

Re: [PATCH] utils/fifo8: change fatal errors from abort() to assert()

2021-01-14 Thread Claudio Fontana
On 1/14/21 10:58 AM, Mark Cave-Ayland wrote: > On 14/01/2021 09:07, Claudio Fontana wrote: > >> On 1/14/21 9:33 AM, Mark Cave-Ayland wrote: >>> Developer errors are better represented with assert() rather than abort(). >> >> ... "also, make the tests more strict" >> >> I'd add this since the check

Re: [PATCH v3 2/2] s390x: Use strpadcpy for copying vm name

2021-01-14 Thread Cornelia Huck
On Thu, 14 Jan 2021 08:07:36 +0100 Miroslav Rezanina wrote: > Using strncpy with length equal to the size of target array, GCC 11 > reports following warning: > > warning: '__builtin_strncpy' specified bound 256 equals destination size > [-Wstringop-truncation] > > We can prevent this warnin

Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-14 Thread Christian Borntraeger
On 13.01.21 13:42, Dr. David Alan Gilbert wrote: > * Cornelia Huck (coh...@redhat.com) wrote: >> On Tue, 5 Jan 2021 12:41:25 -0800 >> Ram Pai wrote: >> >>> On Tue, Jan 05, 2021 at 11:56:14AM +0100, Halil Pasic wrote: On Mon, 4 Jan 2021 10:40:26 -0800 Ram Pai wrote: >> > The main

Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-14 Thread Dr. David Alan Gilbert
* Christian Borntraeger (borntrae...@de.ibm.com) wrote: > > > On 13.01.21 13:42, Dr. David Alan Gilbert wrote: > > * Cornelia Huck (coh...@redhat.com) wrote: > >> On Tue, 5 Jan 2021 12:41:25 -0800 > >> Ram Pai wrote: > >> > >>> On Tue, Jan 05, 2021 at 11:56:14AM +0100, Halil Pasic wrote: >

Re: [PATCH v7 10/13] spapr: Add PEF based confidential guest support

2021-01-14 Thread Greg Kurz
On Thu, 14 Jan 2021 10:58:08 +1100 David Gibson wrote: > Some upcoming POWER machines have a system called PEF (Protected > Execution Facility) which uses a small ultravisor to allow guests to > run in a way that they can't be eavesdropped by the hypervisor. The > effect is roughly similar to AM

Re: [PATCH] docs/devel: Explain how acceptance tests can be skipped

2021-01-14 Thread Alex Bennée
Thomas Huth writes: > On 13/01/2021 20.52, Wainer dos Santos Moschetta wrote: >> Documented under the "Acceptance tests using the Avocado Framework" >> section in testing.rst how environment variables are used to skip tests. >> >> Signed-off-by: Wainer dos Santos Moschetta >> --- >> CI (succe

Re: [PATCH v6 07/11] iotests: add findtests.py

2021-01-14 Thread Kevin Wolf
Am 14.01.2021 um 08:38 hat Vladimir Sementsov-Ogievskiy geschrieben: > 12.01.2021 19:42, Kevin Wolf wrote: > > > +def find_tests(self, groups: Optional[List[str]] = None, > > > + exclude_groups: Optional[List[str]] = None, > > > + tests: Optional[List[str]] =

Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-14 Thread Christian Borntraeger
On 14.01.21 11:36, Dr. David Alan Gilbert wrote: > * Christian Borntraeger (borntrae...@de.ibm.com) wrote: >> >> >> On 13.01.21 13:42, Dr. David Alan Gilbert wrote: >>> * Cornelia Huck (coh...@redhat.com) wrote: On Tue, 5 Jan 2021 12:41:25 -0800 Ram Pai wrote: > On Tue, Jan 0

Re: [PATCH v2 1/8] iotests/297: Allow checking all Python test files

2021-01-14 Thread Vladimir Sementsov-Ogievskiy
14.01.2021 12:31, Max Reitz wrote: On 13.01.21 21:28, Vladimir Sementsov-Ogievskiy wrote: 13.01.2021 22:27, Vladimir Sementsov-Ogievskiy wrote: 13.01.2021 20:57, Max Reitz wrote: I.e., all Python files in the qemu-iotests/ directory. Most files of course do not pass, so there is an extensive

Re: About creating machines on the command line

2021-01-14 Thread Luc Michel
Hi Liviu, On 1/11/21 9:28 PM, Liviu Ionescu wrote: I know it does not answer your question directly, but you might find useful to take a look at the solution used in the xPack QEMU Arm (formerly GNU ARM Eclipse QEMU). In this fork I dynamically create the peripheral registers when QEMU starts

Re: [PULL 0/7] Yank patches patches for 2021-01-13

2021-01-14 Thread Alex Bennée
Peter Maydell writes: > On Wed, 13 Jan 2021 at 09:31, Markus Armbruster wrote: >> >> This pull request is on behalf of Lukas. Hope that's okay. >> >> The following changes since commit f8e1d8852e393b3fd524fb005e38590063d99bc0: >> >> Merge remote-tracking branch >> 'remotes/pmaydell/tags/pu

Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-14 Thread Cornelia Huck
On Thu, 14 Jan 2021 11:52:11 +0100 Christian Borntraeger wrote: > On 14.01.21 11:36, Dr. David Alan Gilbert wrote: > > * Christian Borntraeger (borntrae...@de.ibm.com) wrote: > >> > >> > >> On 13.01.21 13:42, Dr. David Alan Gilbert wrote: > >>> * Cornelia Huck (coh...@redhat.com) wrote: > >

Re: [PATCH] utils/fifo8: change fatal errors from abort() to assert()

2021-01-14 Thread Philippe Mathieu-Daudé
On 1/14/21 11:15 AM, Claudio Fontana wrote: > On 1/14/21 10:58 AM, Mark Cave-Ayland wrote: >> On 14/01/2021 09:07, Claudio Fontana wrote: >> >>> On 1/14/21 9:33 AM, Mark Cave-Ayland wrote: Developer errors are better represented with assert() rather than abort(). >>> >>> ... "also, make the te

Re: About creating machines on the command line

2021-01-14 Thread Liviu Ionescu
> On 14 Jan 2021, at 12:56, Luc Michel wrote: > > ... But yes the goal here is to rely on QEMU's already existing device models > to dynamically create a machine. I did not check the current QEMU device models, so I might be wrong, but I think that the scope might be slightly different. In

Re: [qemu-web PATCH v2] Use GitLab repo URLs instead of git.qemu.org URLs

2021-01-14 Thread Philippe Mathieu-Daudé
On 1/13/21 7:54 PM, Stefan Hajnoczi wrote: > Switch to GitLab repo URLs to reduce qemu.org bandwidth. > > Signed-off-by: Stefan Hajnoczi > --- > v2: > * Added missing URL in _posts/2018-06-28-tcg-testing.md. Mark >Cave-Ayland and Alex Bennée > figured out the issue was that the gitweb >

Re: [Slirp] [PATCH v6 6/7] slirp: update build flags for iOS resolv fix

2021-01-14 Thread Marc-André Lureau
Hi On Tue, Jan 12, 2021 at 3:52 PM Philippe Mathieu-Daudé wrote: > Hi Joelle, > > On 1/5/21 3:20 AM, Joelle van Dyne wrote: > > A future libslirp update will use libresolv on Darwin systems, so we add > the > > flags in QEMU build now. > > > > Reviewed-by: Stefan Hajnoczi > > Signed-off-by: Joe

[Bug 1911666] Re: ZDI-CAN-10904: QEMU Plan 9 File System TOCTOU Privilege Escalation Vulnerability

2021-01-14 Thread P J P
Requesting a CVE... ** Information type changed from Private Security to Public Security -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1911666 Title: ZDI-CAN-10904: QEMU Plan 9 File System TOCTOU

Re: minimal "zero conf" build dockerfiles for fedora:latest and alpine:latest

2021-01-14 Thread Andrea Bolognani
On Wed, 2021-01-13 at 13:31 -0500, John Snow wrote: > On 1/13/21 5:09 AM, Gerd Hoffmann wrote: > > > I don't like Perl really, but there's a chicken-and-egg problem between > > > detecting Python and using it to print the configure help script. For > > > configure-time tasks, Perl has the advantag

Re: [PATCH 1/3] ui/gtk: don't try to redefine SI prefixes

2021-01-14 Thread Philippe Mathieu-Daudé
On 12/13/20 5:57 PM, Volker Rümelin wrote: > Redefining SI prefixes is always wrong. 1s has per definition > 1000ms. Remove the misnamed named constant and replace it with > a comment explaining the frequency to period conversion in two > simple steps. Now you can cancel out the unit mHz in the com

Re: [PATCH v6 08/11] iotests: add testenv.py

2021-01-14 Thread Kevin Wolf
Am 14.01.2021 um 05:28 hat Vladimir Sementsov-Ogievskiy geschrieben: > 09.01.2021 15:26, Vladimir Sementsov-Ogievskiy wrote: > > Add TestEnv class, which will handle test environment in a new python > > iotests running framework. > > > > Difference with current ./check interface: > > - -v (verbose

Re: [PATCHv4 2/2] arm-virt: add secure pl061 for reset/power down

2021-01-14 Thread Maxim Uvarov
On Thu, 14 Jan 2021 at 12:50, Peter Maydell wrote: > > On Thu, 14 Jan 2021 at 00:04, Andrew Jones wrote: > > > > On Wed, Jan 13, 2021 at 10:30:47AM +0300, Maxim Uvarov wrote: > > > - the same size for secure and non secure gpio. Arm doc says that > > > secure memory is also split on 4k pages. So

Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-14 Thread Daniel P . Berrangé
On Mon, Jan 11, 2021 at 11:58:30AM -0800, Ram Pai wrote: > On Mon, Jan 11, 2021 at 05:59:14PM +0100, Cornelia Huck wrote: > > On Tue, 5 Jan 2021 12:41:25 -0800 > > Ram Pai wrote: > > > > > On Tue, Jan 05, 2021 at 11:56:14AM +0100, Halil Pasic wrote: > > > > On Mon, 4 Jan 2021 10:40:26 -0800 > > >

Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-14 Thread Daniel P . Berrangé
On Wed, Jan 13, 2021 at 12:42:26PM +, Dr. David Alan Gilbert wrote: > * Cornelia Huck (coh...@redhat.com) wrote: > > On Tue, 5 Jan 2021 12:41:25 -0800 > > Ram Pai wrote: > > > > > On Tue, Jan 05, 2021 at 11:56:14AM +0100, Halil Pasic wrote: > > > > On Mon, 4 Jan 2021 10:40:26 -0800 > > > > Ra

Re: [PATCH v6 08/11] iotests: add testenv.py

2021-01-14 Thread Vladimir Sementsov-Ogievskiy
14.01.2021 14:14, Kevin Wolf wrote: Am 14.01.2021 um 05:28 hat Vladimir Sementsov-Ogievskiy geschrieben: 09.01.2021 15:26, Vladimir Sementsov-Ogievskiy wrote: Add TestEnv class, which will handle test environment in a new python iotests running framework. Difference with current ./check interf

Re: [PATCHv4 2/2] arm-virt: add secure pl061 for reset/power down

2021-01-14 Thread Maxim Uvarov
On Thu, 14 Jan 2021 at 14:22, Maxim Uvarov wrote: > > On Thu, 14 Jan 2021 at 12:50, Peter Maydell wrote: > > > > On Thu, 14 Jan 2021 at 00:04, Andrew Jones wrote: > > > > > > On Wed, Jan 13, 2021 at 10:30:47AM +0300, Maxim Uvarov wrote: > > > > - the same size for secure and non secure gpio. Arm

Re: [PATCH 6/9] net: Transfer tabs to spcaes

2021-01-14 Thread Philippe Mathieu-Daudé
On 12/22/20 9:23 AM, Zhang Han wrote: > Code indent use spaces instead of tabs. > > Signed-off-by: Zhang Han > --- > net/tap-linux.h | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) FWIW typo "spaces" in subject (no need to repost).

Re: [PATCH 7/9] net: Remove assignment in if condition

2021-01-14 Thread Philippe Mathieu-Daudé
On 12/22/20 9:23 AM, Zhang Han wrote: > Put the assignment before the if condition > > Signed-off-by: Zhang Han > --- > net/tap-bsd.c | 3 ++- > net/tap-solaris.c | 9 ++--- > 2 files changed, 8 insertions(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: About creating machines on the command line

2021-01-14 Thread Daniel P . Berrangé
On Mon, Jan 11, 2021 at 03:50:58PM +0100, Luc Michel wrote: > Hi, > > We would like to work on improving QEMU to be able to create custom machines > from the command line. The goal here is to get feedback from the community > and shape the future developments. > > The use case mainly comes from p

Re: [PATCH 09/22] hw/sd: ssi-sd: Use macros for the dummy value and tokens in the transfer

2021-01-14 Thread Philippe Mathieu-Daudé
On 12/31/20 12:29 PM, Bin Meng wrote: > From: Bin Meng > > At present the codes use hardcoded numbers (0xff/0xfe) for the dummy > value and block start token. Replace them with macros, and add more > tokens for multiple block write. > > Signed-off-by: Bin Meng > --- > > hw/sd/ssi-sd.c | 30 ++

Re: [PATCH 13/22] hw/sd: Introduce receive_ready() callback

2021-01-14 Thread Philippe Mathieu-Daudé
On 12/31/20 12:30 PM, Bin Meng wrote: > From: Bin Meng > > At present there is a data_ready() callback for the SD data read > path. Let's add a receive_ready() for the SD data write path. > > Signed-off-by: Bin Meng > --- > > include/hw/sd/sd.h | 2 ++ > hw/sd/core.c | 13 +

Re: [qemu-web PATCH v2] Use GitLab repo URLs instead of git.qemu.org URLs

2021-01-14 Thread Alex Bennée
Stefan Hajnoczi writes: > Switch to GitLab repo URLs to reduce qemu.org bandwidth. > > Signed-off-by: Stefan Hajnoczi Reviewed-by: Alex Bennée > --- > v2: > * Added missing URL in _posts/2018-06-28-tcg-testing.md. Mark >Cave-Ayland and Alex Bennée > figured out the issue was that

Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-14 Thread Dr. David Alan Gilbert
* Cornelia Huck (coh...@redhat.com) wrote: > On Thu, 14 Jan 2021 11:52:11 +0100 > Christian Borntraeger wrote: > > > On 14.01.21 11:36, Dr. David Alan Gilbert wrote: > > > * Christian Borntraeger (borntrae...@de.ibm.com) wrote: > > >> > > >> > > >> On 13.01.21 13:42, Dr. David Alan Gilbert wrot

Re: [PATCH v7 02/13] confidential guest support: Introduce new confidential guest support class

2021-01-14 Thread David Gibson
On Thu, Jan 14, 2021 at 09:34:36AM +, Daniel P. Berrangé wrote: > On Thu, Jan 14, 2021 at 10:58:00AM +1100, David Gibson wrote: > > Several architectures have mechanisms which are designed to protect guest > > memory from interference or eavesdropping by a compromised hypervisor. AMD > > SEV d

Re: [PATCH v7 13/13] s390: Recognize confidential-guest-support option

2021-01-14 Thread David Gibson
On Thu, Jan 14, 2021 at 10:10:02AM +0100, Christian Borntraeger wrote: > > > On 14.01.21 00:58, David Gibson wrote: > [...] > > +int s390_pv_init(ConfidentialGuestSupport *cgs, Error **errp) > > +{ > > +if (!object_dynamic_cast(OBJECT(cgs), TYPE_S390_PV_GUEST)) { > > +return 0; > > +

Re: [PATCHv4 2/2] arm-virt: add secure pl061 for reset/power down

2021-01-14 Thread Peter Maydell
On Thu, 14 Jan 2021 at 11:24, Maxim Uvarov wrote: > > On Thu, 14 Jan 2021 at 14:22, Maxim Uvarov wrote: > > Does that mean that in that case you need all regions to be 64k > > aligned? I mean secure and non-secure. > > Has anybody tested 64k pages under qemu? > > [VIRT_GIC_V2M] ={

Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-14 Thread Christian Borntraeger
On 14.01.21 12:45, Dr. David Alan Gilbert wrote: > * Cornelia Huck (coh...@redhat.com) wrote: >> On Thu, 14 Jan 2021 11:52:11 +0100 >> Christian Borntraeger wrote: >> >>> On 14.01.21 11:36, Dr. David Alan Gilbert wrote: * Christian Borntraeger (borntrae...@de.ibm.com) wrote: > >

Re: [PATCH 05/22] hw/sd: sd: Drop sd_crc16()

2021-01-14 Thread Philippe Mathieu-Daudé
On 12/31/20 12:29 PM, Bin Meng wrote: > From: Bin Meng > > commit f6fb1f9b319f ("sdcard: Correct CRC16 offset in sd_function_switch()") > changed the 16-bit CRC to be stored at offset 64. In fact, this CRC > calculation is completely wrong. Yeah: https://www.mail-archive.com/qemu-devel@nongnu.or

Re: [PATCHv4 2/2] arm-virt: add secure pl061 for reset/power down

2021-01-14 Thread Maxim Uvarov
On Thu, 14 Jan 2021 at 14:48, Peter Maydell wrote: > > On Thu, 14 Jan 2021 at 11:24, Maxim Uvarov wrote: > > > > On Thu, 14 Jan 2021 at 14:22, Maxim Uvarov wrote: > > > Does that mean that in that case you need all regions to be 64k > > > aligned? I mean secure and non-secure. > > > Has anybody

Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-14 Thread Daniel P . Berrangé
On Thu, Jan 14, 2021 at 12:50:12PM +0100, Christian Borntraeger wrote: > > > On 14.01.21 12:45, Dr. David Alan Gilbert wrote: > > * Cornelia Huck (coh...@redhat.com) wrote: > >> On Thu, 14 Jan 2021 11:52:11 +0100 > >> Christian Borntraeger wrote: > >> > >>> On 14.01.21 11:36, Dr. David Alan Gilb

Re: Call for Google Summer of Code 2021 project ideas

2021-01-14 Thread Markus Armbruster
John Snow writes: > On 1/13/21 4:19 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 1/11/21 6:47 AM, Stefan Hajnoczi wrote: Dear QEMU, KVM, and rust-vmm community, QEMU will apply for Google Summer of Code (https://summerofcode.withgoogle.com/) again this year. This

Re: [PULL 0/7] Yank patches patches for 2021-01-13

2021-01-14 Thread Markus Armbruster
Alex Bennée writes: > Peter Maydell writes: > >> On Wed, 13 Jan 2021 at 09:31, Markus Armbruster wrote: >>> >>> This pull request is on behalf of Lukas. Hope that's okay. >>> >>> The following changes since commit f8e1d8852e393b3fd524fb005e38590063d99bc0: >>> >>> Merge remote-tracking branch

Re: [PULL 0/7] Yank patches patches for 2021-01-13

2021-01-14 Thread Lukas Straub
On Thu, 14 Jan 2021 13:40:52 +0100 Markus Armbruster wrote: > Alex Bennée writes: > > > Peter Maydell writes: > > > >> On Wed, 13 Jan 2021 at 09:31, Markus Armbruster wrote: > >> > >>> > >>> This pull request is on behalf of Lukas. Hope that's okay. > >>> > >>> The following changes sin

[PATCH 0/5] Update libslirp & make it a subproject

2021-01-14 Thread marcandre . lureau
From: Marc-André Lureau Hi, Here is a few patches to update libslirp to git upstream. Since it now supports meson subproject(), adapt the build system to use it, and related fixes. Marc-André Lureau (5): build-sys: remove unused LIBS build-sys: set global arguments for cflags/ldflags buil

[PATCH 1/5] build-sys: remove unused LIBS

2021-01-14 Thread marcandre . lureau
From: Marc-André Lureau Since meson switch and commit feabc71dfa58 ("configure: do not include dependency flags in QEMU_CFLAGS and LIBS"), LIBS is unused. Signed-off-by: Marc-André Lureau --- configure | 32 1 file changed, 32 deletions(-) diff --git a/configu

[PATCH 4/5] slirp: update to git master

2021-01-14 Thread marcandre . lureau
From: Marc-André Lureau git cherry-diff: Commits on bacb71f1c3ed5f40e393afd8be81bedfba13a401 branch that is not on 8f43a99191afb47ca3f3c6972f6306209f367ece branch + 1021b0dc38d39f1dc95a296fe3e05a24a087cdc6 disable_dns option + 0f94ceec752592e4ac632a24e3c64a97dd09bf4c limit vnameserver_addr to p

[PATCH 5/5] build-sys: make libslirp a meson subproject

2021-01-14 Thread marcandre . lureau
From: Marc-André Lureau Remove the manual build. Signed-off-by: Marc-André Lureau --- configure | 2 +- meson.build | 62 +++ .gitmodules | 6 ++-- slirp => subprojects/libslirp | 0 4 files changed, 8 i

[PATCH 2/5] build-sys: set global arguments for cflags/ldflags

2021-01-14 Thread marcandre . lureau
From: Marc-André Lureau As we want subprojects to share those arguments Signed-off-by: Marc-André Lureau --- meson.build | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/meson.build b/meson.build index 3d889857a0..a4adf06997 100644 --- a/meson.build +++ b/me

[PATCH 3/5] build-sys: add libvhost-user missing dependencies

2021-01-14 Thread marcandre . lureau
From: Marc-André Lureau This help fixing static compilation issues. Signed-off-by: Marc-André Lureau --- subprojects/libvhost-user/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/subprojects/libvhost-user/meson.build b/subprojects/libvhost-user/meson.build index c5d85c11d7.

Re: [PATCH v4 3/5] qapi: Introduce QAPI_LIST_APPEND

2021-01-14 Thread Markus Armbruster
Eric Blake writes: > Similar to the existing QAPI_LIST_PREPEND, but designed for use where > we want to preserve insertion order. Callers will be added in > upcoming patches. Note the difference in signature: PREPEND takes > List*, APPEND takes List**. > > Signed-off-by: Eric Blake > Reviewed-

[PATCH v2 00/25] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles

2021-01-14 Thread Daniel P . Berrangé
Currently the tests/docker/dockerfiles/*Dockerfile recipes are all hand written by contributors. There is a common design pattern, but the set of packages listed for installation leaves alot to be desired - There is no consistency at all across distros - Many potential build deps are not listed

[PATCH v2 09/25] tests/docker: fix mistakes in fedora package list

2021-01-14 Thread Daniel P . Berrangé
llvm is not required by QEMU, just clang. libblockdev-mpath-devel is not used by QEMU, rather it wants device-mapper-multipath-devel. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/fedora.docker | 2 -- 1 file changed, 2 deletions(-) diff --

[PATCH v2 06/25] tests/docker: remove FEATURES env var from templates

2021-01-14 Thread Daniel P . Berrangé
In preparation for switching to auto-generated dockerfiles, remove the FEATURES env variable. The equivalent functionality can be achieved in most cases by just looking for existance of a binary. The cases which don't correspond to binaries are simply dropped because configure/meson will probe for

[PATCH v2 05/25] tests/docker: remove travis container

2021-01-14 Thread Daniel P . Berrangé
The travis container that we have no longer matches what travis currently uses. As all x86 jobs are being moved to GitLab CI too, there is no compelling reason to update the travis container. It is simpler to just remove it. Signed-off-by: Daniel P. Berrangé --- docs/devel/testing.rst

  1   2   3   4   5   >