On 1/13/21 3:15 AM, Jiaxun Yang wrote:
> 在 2021/1/13 上午5:54, Philippe Mathieu-Daudé 写道:
>> Loongson is next step in the "MIPS decodetree conversion" epic.
>> Start with the simplest extension.
>>
>> The diffstat addition comes from the TCG functions expanded.
>> The code is easier to review now.
>>
On Tue, 12 Jan 2021 10:55:11 -0800
Ram Pai wrote:
> On Tue, Jan 12, 2021 at 09:19:43AM +0100, Cornelia Huck wrote:
> > On Mon, 11 Jan 2021 11:58:30 -0800
> > Ram Pai wrote:
> >
> > > On Mon, Jan 11, 2021 at 05:59:14PM +0100, Cornelia Huck wrote:
> > > > On Tue, 5 Jan 2021 12:41:25 -0800
> >
On Wed, Jan 13, 2021 at 9:06 AM Philippe Mathieu-Daudé wrote:
> On 1/13/21 3:15 AM, Jiaxun Yang wrote:
> > Loong-EXT is a super set of Loongson2F's Godson2 and MMI instructions,
> > how could we tell it?
>
> MMI instructions are currently handled by the ASE_LMMI flag,
> a different decoder (which
** Tags added: linux-user
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1791796
Title:
unimplemented thread syscalls in nios2 user-mode emulation
Status in QEMU:
Expired
Bug description:
This
On Wed, Jan 13, 2021, at 4:06 PM, Philippe Mathieu-Daudé wrote:
> On 1/13/21 3:15 AM, Jiaxun Yang wrote:
> > 在 2021/1/13 上午5:54, Philippe Mathieu-Daudé 写道:
> >> Loongson is next step in the "MIPS decodetree conversion" epic.
> >> Start with the simplest extension.
> >>
> >> The diffstat addition
On 12/01/21 23:37, John Snow wrote:
- our configure file suggests bzip2 is an optional dependency (It's set
to 'auto') but meson will error out if it is not present at
configuration time:
../pc-bios/meson.build:5:2: ERROR: Program 'bzip2' not found
Yes, the configure option is for libbz
On 13/01/21 07:48, Thomas Huth wrote:
[254/8314] Generating texture-blit-frag.h with a meson_exe.py custom
command
FAILED: ui/shader/texture-blit-frag.h
/usr/bin/python3 /qemu-5.2.0/meson/meson.py --internal exe --capture
ui/shader/texture-blit-frag.h -- /usr/bin/env perl
/qemu-5.2.0/scripts
On 13/01/21 08:51, Dave wrote:
[,br=bridge][,helper=helper][,sndbuf=nbytes][,vnet_hdr=on|off][,vhost=on|off]
use network helper 'helper'
(default=/nonexistent/libexec/qemu-bridge-helper) to
-netdev bridge,id=str[,br=bridge][,helper=helper]
using the program
QEMU option -cpu max(max_features) means "Enables all features supported by
the accelerator in the current host", this looks true for all the features
except guest max physical address width, so add this patch to enable it.
Signed-off-by: Yang Weijiang
---
target/i386/cpu.c | 2 +-
1 file change
On Tue, Jan 12, 2021 at 9:10 PM John Snow wrote:
> I have one that is probably way too ambitious, but requires a particular
> skillset that might be of good interest to a student that has some
> experience in the area already.
>
> The idea is for a TUI qmp-shell (maybe using urwid?) to create an
>
On Wed, Jan 13, 2021, at 3:19 PM, Thomas Huth wrote:
> On 21/12/2020 01.53, Jiaxun Yang wrote:
> > As per POSIX specification of limits.h [1], OS libc may define
> > PAGE_SIZE in limits.h.
> >
> > To prevent collosion of definition, we discard PAGE_SIZE from
> > defined by libc and take QEMU's
John Snow writes:
> On 1/11/21 6:47 AM, Stefan Hajnoczi wrote:
>> Dear QEMU, KVM, and rust-vmm community,
>> QEMU will apply for Google Summer of Code
>> (https://summerofcode.withgoogle.com/) again this year. This internship
>> program offers paid, 10-week, remote work internships for
>> contri
This patch series fixes error style problems found by checkpatch.pl.
V2->V3:
Make the patch into a series.
V1->V2:
Add cover letter message.
Fix some style error in patch file before.
Liyang Shi (4):
bsd-user: "foo * bar" should be "foo *bar"
bsd-user: suspect code indent for conditional sta
From: Lukas Straub
Migration and yank code assume that qio_channel_shutdown is thread
-safe and can be called from qmp oob handler. Document this after
checking the code.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
Reviewed-by: Daniel P. Berrangé
Message-Id:
<32b8c27e256da043f0f00d
From: Lukas Straub
Register yank functions on sockets to shut them down.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
Acked-by: Dr. David Alan Gilbert
Message-Id:
<484c6a14cc2506bebedd5a237259b91363ff8f88.1609167865.git.lukasstra...@web.de>
Signed-off-by: Markus Armbruster
---
mig
From: Lukas Straub
Make qio_channel_tls_shutdown thread-safe by using atomics when
accessing tioc->shutdown.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
Reviewed-by: Daniel P. Berrangé
Message-Id:
<5bd8733f583f3558b32250fd0eb576b7aa756485.1609167865.git.lukasstra...@web.de>
Signed-
This pull request is on behalf of Lukas. Hope that's okay.
The following changes since commit f8e1d8852e393b3fd524fb005e38590063d99bc0:
Merge remote-tracking branch
'remotes/pmaydell/tags/pull-target-arm-20210112-1' into staging (2021-01-12
21:23:25 +)
are available in the Git repositor
From: Lukas Straub
A connecting chardev object has an additional reference by the connecting
thread, so if the chardev is still connecting by the end of the test,
then the chardev object won't be freed. This in turn means that the yank
instance won't be unregistered and when running the next test
From: Lukas Straub
Register a yank function to shutdown the socket on yank.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
Message-Id:
<1f4eeed1d066c6cbb8d05ffa9585f6e87b34aac6.1609167865.git.lukasstra...@web.de>
Acked-by: Marc-André Lureau
Signed-off-by: Markus Armbruster
---
chard
From: Lukas Straub
Register a yank function which shuts down the socket and sets
s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an
error occured.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
Message-Id:
Signed-off-by: Markus Armbruster
---
bl
This patch fixes error style problems found by checkpatch.pl:
ERROR: space required after that ';'
Signed-off-by: Liyang Shi
---
bsd-user/elfload.c | 2 +-
bsd-user/syscall.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c
index a
This patch fixes error style problems found by checkpatch.pl:
ERROR: "foo ** bar" should be "foo **bar".
ERROR: "foo * bar" should be "foo *bar"
Signed-off-by: Liyang Shi
---
bsd-user/bsdload.c | 6 +++---
bsd-user/elfload.c | 22 +++---
bsd-user/qemu.h| 14 +++---
This patch fixes error messages found by checkpatch.pl:
ERROR: do not use C99 // comments
Signed-off-by: Liyang Shi
---
bsd-user/elfload.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c
index fab9da757c..ff571088f7 100644
--- a/bs
From: Lukas Straub
The yank feature allows to recover from hanging qemu by "yanking"
at various parts. Other qemu systems can register themselves and
multiple yank functions. Then all yank functions for selected
instances can be called by the 'yank' out-of-band qmp command.
Available instances ca
This patch fixes error style problems found by checkpatch.pl:
ERROR: suspect code indent for conditional statements
Signed-off-by: Liyang Shi
---
bsd-user/elfload.c | 10 +-
bsd-user/syscall.c | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/bsd-user/elfload.c b/b
Implement gpio-pwr driver to allow reboot and poweroff machine.
This is simple driver with just 2 gpios lines. Current use case
is to reboot and poweroff virt machine in secure mode. Secure
pl066 gpio chip is needed for that.
Signed-off-by: Maxim Uvarov
Reviewed-by: Hao Wu
---
hw/gpio/Kconfig
v5: - removed vms flag, added fdt (Andrew Jones)
- added patch3 to combine secure and non secure pl061. It has to be
more easy to review if this changes are in the separate patch.
v4: rework patches accodring to Peter Maydells comments:
- split patches on gpio-pwr driver and
Add secure pl061 for reset/power down machine from
the secure world (Arm Trusted Firmware). Connect it
with gpio-pwr driver.
Signed-off-by: Maxim Uvarov
---
hw/arm/Kconfig| 1 +
hw/arm/virt.c | 34 ++
include/hw/arm/virt.h | 2 ++
3 files changed
Combine code for secure and non secure pl061 (gpio) with
refining fdt creation.
Signed-off-by: Maxim Uvarov
---
hw/arm/virt.c | 122 ++
1 file changed, 83 insertions(+), 39 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index d38a7d5d2f..
On Tue, Jan 12, 2021 at 09:44:03PM +0100, BALATON Zoltan wrote:
> On Tue, 12 Jan 2021, Stefan Hajnoczi wrote:
> > It is possible to repeat the --trace option to specify multiple
> > patterns. This may be preferrable to users who do not want to create a
> > file with a list of patterns.
> >
> > Sug
On Mon, Dec 14, 2020 at 01:40:45PM +0300, Roman Kagan wrote:
> On Mon, Nov 23, 2020 at 10:47:32AM +0300, Roman Kagan wrote:
> > On Mon, Nov 02, 2020 at 08:37:50AM +0300, Roman Kagan wrote:
> > > When the slot is in steady powered-off state and the device is being
> > > removed, there's no need to p
12.01.2021 20:27, Alberto Garcia wrote:
On Sat 09 Jan 2021 01:57:58 PM CET, Vladimir Sementsov-Ogievskiy wrote:
-void bdrv_set_backing_hd(BlockDriverState *bs, BlockDriverState *backing_hd,
+int bdrv_set_backing_hd(BlockDriverState *bs, BlockDriverState *backing_hd,
Er
On 12/01/21 22:02, Joshua Watt wrote:
There are two cases that need to be accounted for when compiling QEMU
for MinGW32:
1) A standalone distribution, where QEMU is self contained and
extracted by the user, such as a user would download from the QEMU
website. In this case, all the QEM
On Tue, Jan 12, 2021 at 1:23 AM Cédric Le Goater wrote:
>
> > QEMU 5.2.x, an e300 based machine ppc603 are impacted.
> > Here is my fix, narrowed down to MSR_TGPR and MSR_ILE
> > ```
> > From 42ce41671f1e6c4dd44e6fb481bbda9df09320bd Mon Sep 17 00:00:00 2001
> > From: Yonggang Luo mailto:luoyongg
On 13/01/21 10:04, Yang Weijiang wrote:
QEMU option -cpu max(max_features) means "Enables all features supported by
the accelerator in the current host", this looks true for all the features
except guest max physical address width, so add this patch to enable it.
Signed-off-by: Yang Weijiang
--
12.01.2021 20:44, Max Reitz wrote:
Hi,
tl;dr: I have some troubles debugging what’s wrong with iotest 129. It wants
to check that 'stop' does not drain a block job, but to me it seems like that’s
exactly what’s happening with the mirror job.
For quite some time, I’ve had 129 disabled in my
Hi,
> I don't like Perl really, but there's a chicken-and-egg problem between
> detecting Python and using it to print the configure help script. For
> configure-time tasks, Perl has the advantage that "#! /usr/bin/env perl"
> just works.
Assuming perl is actually installed, the world seems to
On Tue, 12 Jan 2021 17:20:54 +0100
Markus Armbruster wrote:
> Queued. Thanks for persevering!
>
Great, Thanks!
Regards,
Lukas Straub
--
pgp2UZF6HO_i7.pgp
Description: OpenPGP digital signature
This is ok but I'm afraid we may end up doing this kind of thing in a
lot of devices. So maybe we should consider changing the behavior of
device_is_in_reset() so that it returns false in the reset-exit case.
What do you think ? (I've a patch for this, which make this one useless)
But this patch
12.01.2021 18:27, David Edmondson wrote:
When a call to fcntl(2) for the purpose of manipulating file locks
fails with an error other than EAGAIN or EACCES, report the error
returned by fcntl.
EAGAIN or EACCES are elided as they are considered to be common
failures, indicating that a conflicting
On 1/13/21 11:09 AM, Gerd Hoffmann wrote:
> Hi,
>
>> I don't like Perl really, but there's a chicken-and-egg problem between
>> detecting Python and using it to print the configure help script. For
>> configure-time tasks, Perl has the advantage that "#! /usr/bin/env perl"
>> just works.
>
> A
On Thu, Jan 07, 2021 at 03:00:39PM +0100, Paolo Bonzini wrote:
> Right now meson_options.txt lists almost 60 options. Each option
> needs code in configure to parse it and pass the option down to Meson as
> a -D command-line argument; in addition the default must be duplicated
> between configure
On Tue, Jan 12, 2021 at 02:16:03PM +0100, Laszlo Ersek wrote:
> virtio-fs qualifies as a bootable device minimally under OVMF, but
> currently the necessary "bootindex" property is missing. Add the property.
>
> Expose the property only in the PCI device, for now. There is no boot
> support for vi
12.01.2021 19:42, Kevin Wolf wrote:
Am 09.01.2021 um 13:26 hat Vladimir Sementsov-Ogievskiy geschrieben:
Add python script with new logic of searching for tests:
Current ./check behavior:
- tests are named [0-9][0-9][0-9]
- tests must be registered in group file (even if test doesn't belong
On Wednesday, 2021-01-13 at 13:26:48 +03, Vladimir Sementsov-Ogievskiy wrote:
> 12.01.2021 18:27, David Edmondson wrote:
>> When a call to fcntl(2) for the purpose of manipulating file locks
>> fails with an error other than EAGAIN or EACCES, report the error
>> returned by fcntl.
>>
>> EAGAIN or
On 01/13/21 11:36, Stefan Hajnoczi wrote:
> On Tue, Jan 12, 2021 at 02:16:03PM +0100, Laszlo Ersek wrote:
>> virtio-fs qualifies as a bootable device minimally under OVMF, but
>> currently the necessary "bootindex" property is missing. Add the property.
>>
>> Expose the property only in the PCI dev
On 13.01.21 10:53, Vladimir Sementsov-Ogievskiy wrote:
12.01.2021 20:44, Max Reitz wrote:
Hi,
tl;dr: I have some troubles debugging what’s wrong with iotest 129.
It wants to check that 'stop' does not drain a block job, but to me it
seems like that’s exactly what’s happening with the mirror
Am 13.01.2021 um 11:37 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 12.01.2021 19:42, Kevin Wolf wrote:
> > Am 09.01.2021 um 13:26 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > +def __init__(self, test_dir: Optional[str] = None) -> None:
> > > +self.groups = defaultdict(set)
>
On Mon, 11 Jan 2021 14:43:22 +0100
Cornelia Huck wrote:
> On Mon, 11 Jan 2021 08:00:45 -0500
> "Michael S. Tsirkin" wrote:
>
> > On Mon, Jan 11, 2021 at 01:54:04PM +0100, Cornelia Huck wrote:
> > > On Mon, 4 Jan 2021 21:20:56 +0100
> > > Eric Farman wrote:
> > >
> > > > Signed-off-by:
* leirao (lei@intel.com) wrote:
> From: "Rao, Lei"
>
> If we don't disable the feature of auto-converge for live migration
> before entering COLO mode, it will continue to run with COLO running,
> and eventually the system will hang due to the CPU throttle reaching
> DEFAULT_MIGRATE_MAX_CPU_T
On Wed, 13 Jan 2021 at 07:06, Thomas Huth wrote:
>
> On 21/12/2020 01.53, Jiaxun Yang wrote:
> > signal.h is equlevant of sys/signal.h on Linux, musl would complain
> > wrong usage of sys/signal.h.
> >
> > In file included from /builds/FlyGoat/qemu/include/qemu/osdep.h:108,
> > f
On 27/10/2020 01.38, Michael Forney wrote:
Prior to 2a4b472c3c, sys/signal.h was only included on OpenBSD
(apart from two .c files). The POSIX standard location for this
header is just and in fact, OpenBSD's signal.h includes
sys/signal.h itself.
Unconditionally including on musl causes warnin
On Mon, Jan 11, 2021 at 04:01:12PM +0100, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tcg/s390/tcg-target.c.inc | 252 ++
> 1 file changed, 122 insertions(+), 130 deletions(-)
>
> diff --git a/tcg/s390/tcg-target.c.inc b/tcg
* David Gibson (da...@gibson.dropbear.id.au) wrote:
> On Tue, Jan 12, 2021 at 11:59:59AM +0100, Greg Kurz wrote:
> > On Tue, 12 Jan 2021 15:45:00 +1100
> > David Gibson wrote:
> >
> > > Currently the "memory-encryption" property is only looked at once we
> > > get to kvm_init(). Although protect
On Tue, Dec 22, 2020 at 06:39:29PM -0500, Igor Mammedov wrote:
>
> Series implements support for 'onboard' naming scheme for network
> interfaces (1), which is based on PCI firmware spec and lets user
> to explicitly specify index that will be used by guest to name
> network interface, ex:
> -
On Tue, Dec 22, 2020 at 06:39:33PM -0500, Igor Mammedov wrote:
> Implement _DSM according to:
> PCI Firmware Specification 3.1
> 4.6.7. DSM for Naming a PCI or PCI Express Device Under
> Operating Systems
> and wire it up to cold and hot-plugged PCI devices.
> Feature depends o
On 13/01/21 11:31, Daniel P. Berrangé wrote:
- because we need to run the script to generate the full help, we
cannot rely on the user supplying the path to a Python interpreter
with --python. For this reason, the script is written in Perl.
Perl 5 is universally available as "/usr/bin/
* Cornelia Huck (coh...@redhat.com) wrote:
> On Tue, 5 Jan 2021 12:41:25 -0800
> Ram Pai wrote:
>
> > On Tue, Jan 05, 2021 at 11:56:14AM +0100, Halil Pasic wrote:
> > > On Mon, 4 Jan 2021 10:40:26 -0800
> > > Ram Pai wrote:
>
> > > > The main difference between my proposal and the other proposa
On 03/12/20 03:55, Zihao Chang wrote:
Ping? This is a fix patch which has been reviewed, whose tree should it go via?
Thanks
Zihao
On 2020/11/3 22:03, Zihao Chang wrote:
On 2020/11/3 18:52, Fam Zheng wrote:
On Tue, 2020-11-03 at 14:12 +0800, Zihao Chang wrote:
'enospc' is the default for -
Eric Blake writes:
> On first glance, the loop in qmp_query_rx_filter() has early return
> paths that could leak any allocation of filter_list from a previous
> iteration. But on closer inspection, it is obvious that all of the
> early exits are guarded by has_name, and that the bulk of the loop
Eric Blake writes:
> Instead of modifying the value member of a list element passed as a
> parameter, and open-coding the manipulation of that list, it's nicer
> to just return a freshly allocated value to be prepended to a list
> using QAPI_LIST_PREPEND.
>
> Signed-off-by: Eric Blake
> Reviewed
Eric Blake writes:
> Instead of taking a list parameter and returning a new head at a
> distance, just return the new item for the caller to insert into a
> list via QAPI_LIST_PREPEND. Update some variable names to avoid long
> lines, and drop a useless comment.
>
> Signed-off-by: Eric Blake
>
On Mon, 4 Jan 2021 21:20:54 +0100
Eric Farman wrote:
> Conny, et al,
>
> Here is an updated (final?) version of the QEMU series for the vfio-ccw
> request notifier now that the kernel code landed upstream [1]. The actual
> meat (patch 3) is identical to its counterpart in v2 [2].
>
> Earlier v
Eric Blake writes:
> Anywhere we create a list of just one item or by prepending items
> (typically because order doesn't matter), we can use the
> QAPI_LIST_PREPEND macro. But places where we must keep the list in
> order by appending remain open-coded until later patches.
>
> Note that as a si
Eric Blake writes:
> Similar to the existing QAPI_LIST_PREPEND, but designed for use where
> we want to preserve insertion order. Callers will be added in
> upcoming patches. Note the difference in signature: PREPEND takes
> List*, APPEND takes List**.
>
> Signed-off-by: Eric Blake
> ---
> in
Cc'ing TCI, SH4 and PA contacts FWIW.
On 1/7/21 5:06 PM, Daniel P. Berrangé wrote:
> On Thu, Jan 07, 2021 at 04:50:36PM +0100, Paolo Bonzini wrote:
>> On 07/01/21 16:01, Peter Maydell wrote:
>>> On Thu, 7 Jan 2021 at 14:03, Paolo Bonzini wrote:
Make CONFIG_TCG_INTERPRETER a Meson option
Eric Blake writes:
> The easiest spots to use QAPI_LIST_APPEND are where we already have an
> obvious pointer to the tail of a list. While at it, consistently use
> the variable name 'tail' for that purpose.
>
> Signed-off-by: Eric Blake
> ---
[...]
> diff --git a/hw/acpi/cpu.c b/hw/acpi/cpu.c
Hi Philippe,
On Wed, Jan 13, 2021 at 3:53 PM Philippe Mathieu-Daudé wrote:
>
> Hi Ben,
>
> On 1/13/21 4:29 AM, Bin Meng wrote:
> > On Wed, Jan 13, 2021 at 2:35 AM Philippe Mathieu-Daudé
> > wrote:
> >>
> >> Hi,
> >>
> >> As it is sometimes harder for me to express myself in plain
> >> English,
On Tue, Dec 15, 2020 at 12:54:19PM -0500, Paolo Bonzini wrote:
> In using the address_space_translate_internal API, address_space_cache_init
> forgot one piece of advice that can be found in the code for
> address_space_translate_internal:
>
> /* MMIO registers can be expected to perform full-
Eric Blake writes:
> These cases require a bit more thought to review; in each case, the
> code was appending to a list, but not with a FOOList **tail variable.
>
> Signed-off-by: Eric Blake
> ---
[...]
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index a5058a3bd15e..10ee740eee1b
Philippe Mathieu-Daudé wrote:
> 'burst_length' is cleared in imx_spi_reset(), which is called
> after imx_spi_realize(). Remove the initialization to simplify.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Juan Quintela
Philippe Mathieu-Daudé wrote:
> Convert some DPRINTF() to trace events.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Juan Quintela
> diff --git a/hw/ssi/trace-events b/hw/ssi/trace-events
> index 612d3d6087a..20fcaf32df6 100644
> --- a/hw/ssi/trace-events
> +++ b/hw/ssi/trace-events
Philippe Mathieu-Daudé wrote:
> From: Bin Meng
>
> Avoid using a magic number (4) everywhere for the number of chip
> selects supported.
>
> Signed-off-by: Bin Meng
> Reviewed-by: Alistair Francis
> Reviewed-by: Philippe Mathieu-Daudé
> Message-Id: <20210112145526.31095-2-bmeng...@gmail.com>
>
Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
I think this one is wrong.
> ---
> hw/ssi/imx_spi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/ssi/imx_spi.c b/hw/ssi/imx_spi.c
> index 35ab33c0511..bcc535f2893 100644
> --- a/hw/ssi/imx_s
On 1/13/21 2:09 PM, Philippe Mathieu-Daudé wrote:
> Cc'ing TCI, SH4 and PA contacts FWIW.
>
> On 1/7/21 5:06 PM, Daniel P. Berrangé wrote:
>> On Thu, Jan 07, 2021 at 04:50:36PM +0100, Paolo Bonzini wrote:
>>> On 07/01/21 16:01, Peter Maydell wrote:
On Thu, 7 Jan 2021 at 14:03, Paolo Bonzini w
Philippe Mathieu-Daudé wrote:
> When the block is disabled, all registers are reset with the
> exception of the ECSPI_CONREG. It is initialized to zero
> when the instance is created.
>
> Ref: i.MX 6DQ Applications Processor Reference Manual (IMX6DQRM),
> chapter 21.7.3: Control Register (ECS
Juan Quintela wrote:
> Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé
>
> I think this one is wrong.
Wrong is a strong word. I mean that it changes behaviour and the commit
message don't talk about changing behaviour.
Later, Juan.
>
>
>> ---
>> hw/ssi/imx_spi.c | 3 +
Philippe Mathieu-Daudé wrote:
> When the block is disabled, it stay it is 'internal reset logic'
> (internal clocks are gated off). Reading any register returns
> its reset value. Only update this value if the device is enabled.
>
> Ref: i.MX 6DQ Applications Processor Reference Manual (IMX6DQRM),
On Wed, Jan 13, 2021 at 02:42:51PM +0100, Helge Deller wrote:
> On 1/13/21 2:09 PM, Philippe Mathieu-Daudé wrote:
> > Cc'ing TCI, SH4 and PA contacts FWIW.
> >
> > On 1/7/21 5:06 PM, Daniel P. Berrangé wrote:
> >> On Thu, Jan 07, 2021 at 04:50:36PM +0100, Paolo Bonzini wrote:
> >>> On 07/01/21 16:0
13.01.2021 14:05, Max Reitz wrote:
On 13.01.21 10:53, Vladimir Sementsov-Ogievskiy wrote:
12.01.2021 20:44, Max Reitz wrote:
Hi,
tl;dr: I have some troubles debugging what’s wrong with iotest 129. It wants to
check that 'stop' does not drain a block job, but to me it seems like that’s
exactl
On Thu, Jan 07, 2021 at 07:40:37PM +0800, Jiahui Cen wrote:
> Commit fe1127da11 ("unit-test: Add the binary file and clear diff.h") does not
> use the up-to-date expected file for pxb for ARM virt.
>
> Fix the expected DSDT.pxb file.
>
> Full diff of changed file disassembly:
>
> diff -ru /tmp/o
On 13/01/21 11:31, Daniel P. Berrangé wrote:
meson-buildoptions.json | 717
I'm not a fan of seeing this file introduced as it has significant
overlap with meson_options.txt.I feel like the latter has enough
information present to do an acceptable jo
Throttling on the BB has not affected block jobs in a while, so it is
possible that one of the jobs in 129 finishes before the VM is stopped.
We can fix that by running the job from a throttle node.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/129 | 39 +++
On 2021-01-13 8:42 a.m., Helge Deller wrote:
>>> ia64 is a dead host architecture and doesn't exist in any OS distro that
>>> we target anymore, so I don't think we need to consider it.
> I have no opinion about ia64.
>
>>> Likewise parisc/hppa doesn't seem exist in Debian since Squeeze, so I
>>> t
13.01.2021 16:59, Vladimir Sementsov-Ogievskiy wrote:
13.01.2021 14:05, Max Reitz wrote:
On 13.01.21 10:53, Vladimir Sementsov-Ogievskiy wrote:
12.01.2021 20:44, Max Reitz wrote:
Hi,
tl;dr: I have some troubles debugging what’s wrong with iotest 129. It wants to
check that 'stop' does not dr
@busy is false when the job is paused, which happens all the time
because that is how jobs yield (e.g. for mirror at least since commit
565ac01f8d3).
Back when 129 was added (2015), perhaps there was no better way of
checking whether the job was still actually running. Now we have the
@status fie
Before this patch, test_block_commit() performs an active commit, which
under the hood is a mirror job. If we want to test various different
block jobs, we should perhaps run an actual commit job instead.
Doing so requires adding an overlay above the source node before the
commit is done (and the
Signed-off-by: Max Reitz
---
tests/qemu-iotests/124| 8 +---
tests/qemu-iotests/iotests.py | 11 +++
2 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/tests/qemu-iotests/124 b/tests/qemu-iotests/124
index 3705cbb6b3..e40eeb50b9 100755
--- a/tests/qemu-iotests/12
Signed-off-by: Max Reitz
---
tests/qemu-iotests/129 | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129
index 0e13244d85..2fc65ada6a 100755
--- a/tests/qemu-iotests/129
+++ b/tests/qemu-iotests/129
@@ -47,6 +47,8 @@ class TestStopWithBlockJob(iote
Signed-off-by: Max Reitz
---
tests/qemu-iotests/129 | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129
index c3ad584ba2..ec303069e9 100755
--- a/tests/qemu-iotests/129
+++ b/tests/qemu-iotests/129
@@ -20,9 +20,10 @@
import
Hi,
There are some problems with iotests 129 (perhaps more than these, but
these are the ones I know of):
1. It checks @busy to see whether a block job is still running; however,
block jobs tend to unset @busy all the time (when they yield).
[Fixed by patch 3]
2. It uses blockdev throttlin
On 1/13/21 7:04 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> Similar to the existing QAPI_LIST_PREPEND, but designed for use where
>> we want to preserve insertion order. Callers will be added in
>> upcoming patches. Note the difference in signature: PREPEND takes
>> List*, APPEND tak
Issuing 'stop' on the VM drains all nodes. If the mirror job has many
large requests in flight, this may lead to significant I/O that looks a
bit like the job is being drained.
We can limit the I/O in flight by limiting the buffer size, so mirror
will make very little progress during the 'stop' d
On Wed, 13 Jan 2021, 11:19 Damien Hedde, wrote:
>
> This is ok but I'm afraid we may end up doing this kind of thing in a
> lot of devices. So maybe we should consider changing the behavior of
> device_is_in_reset() so that it returns false in the reset-exit case.
> What do you think ? (I've a pa
On 12/24/20 3:56 AM, Vladimir Sementsov-Ogievskiy wrote:
> 24.12.2020 01:11, Eric Blake wrote:
>> The easiest spots to use QAPI_LIST_APPEND are where we already have an
>> obvious pointer to the tail of a list. While at it, consistently use
>> the variable name 'tail' for that purpose.
>>
>> Signe
On Wed, Jan 13, 2021 at 01:51:17PM +0100, BALATON Zoltan wrote:
> On Wed, 13 Jan 2021, Stefan Hajnoczi wrote:
> > On Tue, Jan 12, 2021 at 09:44:03PM +0100, BALATON Zoltan wrote:
> > > On Tue, 12 Jan 2021, Stefan Hajnoczi wrote:
> > > > It is possible to repeat the --trace option to specify multiple
On 13.01.21 15:06, Max Reitz wrote:
Throttling on the BB has not affected block jobs in a while, so it is
possible that one of the jobs in 129 finishes before the VM is stopped.
We can fix that by running the job from a throttle node.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/129 | 39 +
On 1/13/21 7:16 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> The easiest spots to use QAPI_LIST_APPEND are where we already have an
>> obvious pointer to the tail of a list. While at it, consistently use
>> the variable name 'tail' for that purpose.
>>
>> Signed-off-by: Eric Blake
>>
On Mon, Jan 11, 2021 at 04:59:54PM +0200, Marian Posteuca wrote:
> Igor Mammedov writes:
>
> > overall looks good.
> > Please add a test case for it, see
> > tests/qtest/bios-tables-test.c for description how to do it
> > an/or at
> > "[PATCH v3 08/12] tests/acpi: allow updates for expected dat
On Wed, 13 Jan 2021 at 13:57, Daniel P. Berrangé wrote:
> The question still remains whether anyone is actually likely to be
> running/using QEMU on a sh4/hppa *host*, to emulate a different
> guest arch ? This is what that TCG interpreter provides for.
> eg would anyone really want to emulate aar
1 - 100 of 409 matches
Mail list logo
